Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-25 Thread Hyong Youb Kim
[...] > > > I see it can work if an application always wants this config option to > > > have > > > *same* value. So it can set this in eal_init() always. > > > > > > This requires "driver=xxx,key=value" kind of support in devargs. > > > > > > > > > John, Hyong, > > > > > > I guess some lev

[dpdk-dev] [PATCH v7 8/8] net/ice: support vector AVX2 in TX

2019-03-25 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/nics/ice.rst| 18 doc/guides/rel_notes/release_19_05.rst | 4 + drivers/net/ice/ice_rxtx.c | 13 ++- drivers/net/ice/ice_rxtx.h | 2 + drivers/net/ice/ice_rxtx_vec_avx2.c| 158 +

[dpdk-dev] [PATCH v7 5/8] net/ice: support Tx SSE vector

2019-03-25 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/nics/features/ice_vec.ini | 2 + drivers/net/ice/ice_rxtx.c| 17 + drivers/net/ice/ice_rxtx.h| 4 + drivers/net/ice/ice_rxtx_vec_common.h | 133 ++ drivers/net/ice/ice_rxtx_vec_sse.c| 12

[dpdk-dev] [PATCH v7 6/8] net/ice: support Rx AVX2 vector

2019-03-25 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ice/Makefile| 19 ++ drivers/net/ice/ice_rxtx.c | 16 +- drivers/net/ice/ice_rxtx.h | 2 + drivers/net/ice/ice_rxtx_vec_avx2.c | 622 drivers/net/ice/meson.build | 15 + 5 fil

[dpdk-dev] [PATCH v7 7/8] net/ice: support Rx scatter AVX2 vector

2019-03-25 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 10 -- drivers/net/ice/ice_rxtx.h | 3 ++ drivers/net/ice/ice_rxtx_vec_avx2.c | 64 + 3 files changed, 74 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/

[dpdk-dev] [PATCH v7 1/8] net/ice: fix Tx function setting

2019-03-25 Thread Wenzhuo Lu
The TX setting functions is not called. Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Cc: sta...@dpdk.org Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index cdb55

[dpdk-dev] [PATCH v7 3/8] net/ice: support vector SSE in RX

2019-03-25 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/nics/features/ice_vec.ini | 33 +++ drivers/net/ice/Makefile | 3 + drivers/net/ice/ice_ethdev.c | 2 - drivers/net/ice/ice_ethdev.h | 2 + drivers/net/ice/ice_rxtx.c| 27 +- drivers/net/ice/ice_rxtx.h

[dpdk-dev] [PATCH v7 2/8] net/ice: add pointer for queue buffer release

2019-03-25 Thread Wenzhuo Lu
Add function pointers of buffer releasing for RX and TX queues, for vector functions will be added for RX and TX. Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 17 +++-- drivers/net/ice/ice_rxtx.h | 5 + 2 files changed, 20 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v7 4/8] net/ice: support Rx scatter SSE vector

2019-03-25 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 16 +++ drivers/net/ice/ice_rxtx.h | 2 ++ drivers/net/ice/ice_rxtx_vec_sse.c | 41 ++ 3 files changed, 55 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_rx

[dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE

2019-03-25 Thread Wenzhuo Lu
Use SSE and AVX2 instructions in ICE RX and TX path. --- v2: - Updated feature doc. - Fixed checklog and checkpatch issues. v3: - Fixed potential compile issue on non-X86 platform. v4: - Removed compile configure, CONFIG_RTE_LIBRTE_ICE_INC_VECTOR. - Fixed checkpatch warnings. - Added more

[dpdk-dev] [PATCH v5 8/8] build: meson changes to build on windows

2019-03-25 Thread Anand Rawat
Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- app/

[dpdk-dev] [PATCH v5 6/8] eal: add minimum viable code for eal on windows

2019-03-25 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v5 5/8] eal: add headers for compatibility with windows environment

2019-03-25 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/lib

[dpdk-dev] [PATCH v5 7/8] doc: add documention for windows

2019-03-25 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS |

[dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-25 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions(

[dpdk-dev] [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-25 Thread Anand Rawat
adding a DEF file for kvargs to specify the exports for the creation of the shared library. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_kvargs/rte_kvargs_exports.def | 7 +++ 1 file changed, 7 insertions(+)

[dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows

2019-03-25 Thread Anand Rawat
Added header files to support windows on x86 platforms. Updated rte_common.h to include rte_windows.h for windows build. Updated lib/meson.build to create shared libraries on windows. Added def file to list the exports for the eal library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam

[dpdk-dev] [PATCH v5 0/8] HelloWorld example for windows

2019-03-25 Thread Anand Rawat
Includes Windows-specific EAL changes and meson changes to build the code on windows. v5 Changes: 1. Reduced meson workrounds for windows. 2. Updated documention to include details about buildtool options v4 Changes: 1. Exposed more functions for eal DLL in the module definition file 2. Moved dis

[dpdk-dev] [PATCH v5 1/8] eal: eal stub to add windows support

2019-03-25 Thread Anand Rawat
Added initial stub source files for windows support and only the required meson changes for windows. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 23 -- config/x86/meson.b

[dpdk-dev] [PATCH v4] net/iavf: fix Tx interrupt vertor configuration error

2019-03-25 Thread Wei Zhao
There is need to align to kernel iavf code when setting Tx queue interrupt vector in messge VIRTCHNL_OP_CONFIG_IRQ_MAP, if not it maybe cause restart iavf port error in some scenario. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- v2: u

Re: [dpdk-dev] [PATCH 3/3] doc/rcu: add lib_rcu documentation

2019-03-25 Thread Honnappa Nagarahalli
Hi Marko, Thank you for your comments. I will make all the suggested changes in the next version. > > -- > > If it's possible to enlarge the image a bit it would be good to be able to > read > the lower text I need to enlarge it to 175% maybe I'm just blind but if it's > possible it w

Re: [dpdk-dev] [PATCH 1/3] rcu: add RCU library supporting QSBR mechanism

2019-03-25 Thread Honnappa Nagarahalli
> Hi Honnappa, > > > diff --git a/lib/librte_rcu/rte_rcu_qsbr.c > > b/lib/librte_rcu/rte_rcu_qsbr.c new file mode 100644 index > > 0..0fc4515ea > > --- /dev/null > > +++ b/lib/librte_rcu/rte_rcu_qsbr.c > > @@ -0,0 +1,99 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * > > + * Copyr

Re: [dpdk-dev] [PATCH v5 3/5] lib/mempool: allow page size aligned mempool

2019-03-25 Thread Ye Xiaolong
On 03/25, Andrew Rybchenko wrote: >On 3/25/19 9:03 AM, Xiaolong Ye wrote: >> Allow create a mempool with page size aligned base address. >> >> Signed-off-by: Qi Zhang >> Signed-off-by: Xiaolong Ye >> --- >> lib/librte_mempool/rte_mempool.c | 3 +++ >> lib/librte_mempool/rte_mempool.h | 1 + >>

[dpdk-dev] [PATCH v3] net/iavf: fix Tx interrupt vertor configuration error

2019-03-25 Thread Wei Zhao
There is need to align to kernel iavf code when setting Tx queue interrupt vector in messge VIRTCHNL_OP_CONFIG_IRQ_MAP, if not it maybe cause restart iavf port error in some scenario. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- v2: u

Re: [dpdk-dev] Aligned rte_mempool for storage applications

2019-03-25 Thread Varghese, Vipin
Hi Seth, If I may I would like to suggest and ask a query on the mempool alignment details. Please find my suggestion and query inline to the email. Snipped > > In SPDK, we use the rte_mempool struct for many internal structure > collections. The per-thread cache and ease of allocation of m

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-25 Thread Ye Xiaolong
On 03/25, Luca Boccassi wrote: >On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote: >> On 03/24, Luca Boccassi wrote: >> > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: >> > > On 03/02, Ye Xiaolong wrote: >> > > > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += >> > > > > > -lrte_pmd_

Re: [dpdk-dev] [PATCH v5 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-25 Thread Ye Xiaolong
On 03/25, Stephen Hemminger wrote: >On Mon, 25 Mar 2019 14:03:56 +0800 >Xiaolong Ye wrote: > >> + >> +ret = xsk_ring_prod__reserve(fq, reserve_size, &idx); >> +if (unlikely(!ret)) { >> +AF_XDP_LOG(ERR, "Failed to reserve enough fq descs.\n"); > >You defined AF_XDP_LOG to add a

Re: [dpdk-dev] [PATCH v6 2/8] net/ice: add pointer for queue buffer release

2019-03-25 Thread Lu, Wenzhuo
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Monday, March 25, 2019 9:24 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 2/8] net/ice: add pointer for queue buffer > release > > > > On 3/25/19 7:06 AM, Wenzh

Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector

2019-03-25 Thread Lu, Wenzhuo
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Monday, March 25, 2019 4:26 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector > > Hi, > > On 3/25/19 3:22 AM, Lu, Wenzhuo wrote:

[dpdk-dev] DPDK techboard minutes of March 13

2019-03-25 Thread Ananyev, Konstantin
Meeting notes for the DPDK technical board meeting held on 2019-03-13. Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Stephen Hemminger - Th

Re: [dpdk-dev] [PATCH 2/2] test/event_timer: improve unit test compatability

2019-03-25 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Saturday, March 16, 2019 3:28 PM > To: Jerin Jacob Kollanukkaran ; Carrillo, Erik G > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PATCH 2/2] test/event_timer:

Re: [dpdk-dev] [PATCH] bnxt: fix receive VLAN offload flags

2019-03-25 Thread Ajit Khaparde
On Mon, Mar 25, 2019 at 2:28 PM Stephen Hemminger < step...@networkplumber.org> wrote: > From: Stephen Hemminger > > The bnxt driver is not correctly setting the receive VLAN offload > flags. When VLAN is offloaded the driver must set the PKT_RX_VLAN_STRIPPED > flag. > > Actually, several drivers

[dpdk-dev] [PATCH] bnxt: fix receive VLAN offload flags

2019-03-25 Thread Stephen Hemminger
From: Stephen Hemminger The bnxt driver is not correctly setting the receive VLAN offload flags. When VLAN is offloaded the driver must set the PKT_RX_VLAN_STRIPPED flag. Actually, several drivers have the same bug, only most of the Intel drivers look right. Any driver that sets vlan_tci is prob

Re: [dpdk-dev] Aligned rte_mempool for storage applications

2019-03-25 Thread Harris, James R
On 3/25/19, 2:06 PM, "Howell, Seth" wrote: Hello, In SPDK, we use the rte_mempool struct for many internal structure collections. The per-thread cache and ease of allocation of mempools are very useful features. Some of the collections we store in SPDK are pools of I/O buffe

Re: [dpdk-dev] [PATCH v5] net/kni: calc mbuf&mtu according to given mb_pool

2019-03-25 Thread Ferruh Yigit
On 3/25/2019 8:48 PM, lir...@marvell.com wrote: > From: Liron Himi > > - mbuf_size and mtu are now being calculated according > to the given mb-pool. > > - max_mtu is now being set according to the given mtu > > the above two changes provide the ability to work with jumbo frames > > Signed-off

[dpdk-dev] [PATCH v2 2/2] test/hash: lock-free rw concurrency test ext bkt

2019-03-25 Thread Dharmik Thakkar
Add unit test to check for hash lookup and bulk-lookup perf. Test with lock-free enabled and with lock-free disabled. Test include: - hash lookup on keys in ext bkt, hash delete causing key-shifts of keys from ext bkt to secondary bkt Suggested-by: Honnappa Nagarahalli Signed-off-by: Dharmik Th

[dpdk-dev] [PATCH v2 0/2] hash: add lock free support for ext bkt

2019-03-25 Thread Dharmik Thakkar
This patch series: - Enables lock-free read-write concurrency support for extendable bucket feature. - Adds lock-free read-write concurrency tests for ext bkt Dharmik Thakkar (2): hash: add lock free support for extendable bucket test/hash: lock-free rw concurrency test ext bkt app/test/tes

[dpdk-dev] [PATCH v2 1/2] hash: add lock free support for extendable bucket

2019-03-25 Thread Dharmik Thakkar
This patch enables lock-free read-write concurrency support for extendable bucket feature. Suggested-by: Honnappa Nagarahalli Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- v2: - Update doc (Yipeng) - Update lib/librte_ha

[dpdk-dev] Aligned rte_mempool for storage applications

2019-03-25 Thread Howell, Seth
Hello, In SPDK, we use the rte_mempool struct for many internal structure collections. The per-thread cache and ease of allocation of mempools are very useful features. Some of the collections we store in SPDK are pools of I/O buffers. Typically, these pools contain elements of at least 4096 by

Re: [dpdk-dev] [RFC v5] /net: memory interface (memif)

2019-03-25 Thread Ferruh Yigit
On 3/22/2019 11:57 AM, Jakub Grajciar wrote: > Memory interface (memif), provides high performance > packet transfer over shared memory. > > Signed-off-by: Jakub Grajciar <...> > @@ -0,0 +1,200 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > +Copyright(c) 2018-2019 Cisco Systems, Inc. > +

Re: [dpdk-dev] [PATCH 1/2] eventdev: check timer adapter status before start

2019-03-25 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Saturday, March 16, 2019 3:28 PM > To: Jerin Jacob Kollanukkaran ; Carrillo, Erik G > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PATCH 1/2] eventdev: check time

Re: [dpdk-dev] [PATCH 1/2] hash: add lock free support for extendable bucket

2019-03-25 Thread Dharmik Thakkar
+Honnappa Hi Yipeng, Thank you for reviewing! > On Mar 22, 2019, at 6:48 PM, Wang, Yipeng1 wrote: > > Thanks for the patch! > > Comments inlined: > >> -Original Message- >> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >> Sent: Wednesday, March 20, 2019 3:35 PM >> To: Wang,

Re: [dpdk-dev] [RFC 1/2] hash: add lock free support for extendable bucket

2019-03-25 Thread Dharmik Thakkar
Hi Honnappa, Thank you for the review comments! > On Mar 14, 2019, at 7:31 PM, Honnappa Nagarahalli > wrote: > > > @@ -1072,10 +1071,23 @@ __rte_hash_add_key_with_hash(const struct >> rte_hash *h, const void *key, bkt_id = (uint32_t)((uintptr_t)ext_bkt_id) - 1; /* Use th

[dpdk-dev] [PATCH 0/3] net/mlx: remove device register remap

2019-03-25 Thread Yongseok Koh
This patchset lifts the requirement of reserving huge virtual address space and remapping device UAR register on to it in order to use the same address between primary and secondary process. Yongseok Koh (3): net/mlx5: fix recursive inclusion of header file net/mlx5: remove device register rem

[dpdk-dev] [PATCH 3/3] net/mlx4: remove device register remap

2019-03-25 Thread Yongseok Koh
UAR (User Access Region) registers will be stored in a process-local table and a process accesses a register in a table entry with index. Alloc/free of table entry is managed by a global bitmap. When there's a need to store a UAR register such as Tx BlueFlame register for doorbell, an index should

[dpdk-dev] [PATCH 1/3] net/mlx5: fix recursive inclusion of header file

2019-03-25 Thread Yongseok Koh
mlx5.h includes mlx5_rxtx.h and mlx5_rxtx.h includes mlx5.h recursively. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.h| 1 - drivers/net/mlx5/mlx5_flow.c | 5 +++-- drivers/net/mlx5/mlx5_flow_dv.c| 3 ++- drivers/net/mlx5/mlx5_flow_verbs.c | 5 +++-- drivers/net/m

[dpdk-dev] [PATCH 2/3] net/mlx5: remove device register remap

2019-03-25 Thread Yongseok Koh
UAR (User Access Region) registers will be stored in a process-local table and a process accesses a register in a table entry with index. Alloc/free of table entry is managed by a global bitmap. When there's a need to store a UAR register such as Tx BlueFlame register for doorbell, an index should

[dpdk-dev] [PATCH v2 6/6] net/mlx4: enable secondary process to register DMA memory

2019-03-25 Thread Yongseok Koh
The Memory Region (MR) for DMA memory can't be created from secondary process due to lib/driver limitation. Whenever it is needed, secondary process can make a request to primary process through the EAL IPC channel (rte_mp_msg) which is established on initialization. Once a MR is created by primary

[dpdk-dev] [PATCH v2 4/6] net/mlx5: enable secondary process to register DMA memory

2019-03-25 Thread Yongseok Koh
The Memory Region (MR) for DMA memory can't be created from secondary process due to lib/driver limitation. Whenever it is needed, secondary process can make a request to primary process through the EAL IPC channel (rte_mp_msg) which is established on initialization. Once a MR is created by primary

[dpdk-dev] [PATCH v2 5/6] net/mlx4: add control of excessive memory pinning by kernel

2019-03-25 Thread Yongseok Koh
A new PMD parameter (mr_ext_memseg_en) is added to control extension of memseg when creating a MR. It is enabled by default. If enabled, mlx4_mr_create() tries to maximize the range of MR registration so that the LKey lookup tables on datapath become smaller and get the best performance. However,

[dpdk-dev] [PATCH v2 2/6] net/mlx5: fix external memory registration

2019-03-25 Thread Yongseok Koh
Secondary process is not allowed to register MR due to a restriction of library and kernel driver. Fixes: 7e43a32ee060 ("net/mlx5: support externally allocated static memory") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler --- doc/guides/nics/mlx5.rst | 5 + dri

[dpdk-dev] [PATCH v2 3/6] net/mlx5: add control of excessive memory pinning by kernel

2019-03-25 Thread Yongseok Koh
A new PMD parameter (mr_ext_memseg_en) is added to control extension of memseg when creating a MR. It is enabled by default. If enabled, mlx5_mr_create() tries to maximize the range of MR registration so that the LKey lookup tables on datapath become smaller and get the best performance. However,

[dpdk-dev] [PATCH v2 1/6] net/mlx: remove debug messages on datapath

2019-03-25 Thread Yongseok Koh
Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler --- drivers/net/mlx4/mlx4_mr.c | 4 drivers/net/mlx5/mlx5_mr.c | 6 -- 2 files changed, 10 deletions(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c index 01894faecf..0ba55fda04 100644 ---

[dpdk-dev] [PATCH v2 0/6] net/mlx: enable secondary process to register DMA memory

2019-03-25 Thread Yongseok Koh
RFC: https://mails.dpdk.org/archives/dev/2019-March/125517.html v2: * add more sanity check for eth_dev and return value from IPC request. * complement commit messages * add MLX5_MP_REQ_TIMEOUT_SEC * keep acked-by: Shahaf Shuler Yongseok Koh (6): net/mlx: remove debug messages on datapath net

[dpdk-dev] [PATCH v2 3/3] net/mlx4: add secondary process support

2019-03-25 Thread Yongseok Koh
In order to support secondary process, a few features are required. a) rdma-core library should allocate device resources using DPDK's memory allocator. b) UAR should be remapped for secondary processes. Currently, in order not to use different data structure for secondary processes, PMD tr

[dpdk-dev] [PATCH v2 0/3] net/mlx4: add secondary process support

2019-03-25 Thread Yongseok Koh
RFC: https://mails.dpdk.org/archives/dev/2019-March/125516.html v2: * add more sanity check for eth_dev and return value from IPC request. * complement commit messages * add MLX5_MP_REQ_TIMEOUT_SEC Yongseok Koh (3): net/mlx4: change device reference for secondary process net/mlx4: add externa

[dpdk-dev] [PATCH v2 2/3] net/mlx4: add external allocator for Verbs object

2019-03-25 Thread Yongseok Koh
To support secondary process, the memory allocated by library such as completion rings (CQ) and buffer rings (WQ) must be manageable by EAL, in order to share it with secondary processes. With new changes in rdma-core and kernel driver, it is possible to provide an external allocator to the library

[dpdk-dev] [PATCH v2 1/3] net/mlx4: change device reference for secondary process

2019-03-25 Thread Yongseok Koh
rte_eth_devices[] is not shared between primary and secondary process, but a static array to each process. The reverse pointer of device (priv->dev) becomes invalid if mlx4 supports secondary process. Instead, priv has the pointer to shared data of the device, struct rte_eth_dev_data *dev_data;

[dpdk-dev] [PATCH v2 4/4] net/mlx5: sync stop/start of datapath with secondary process

2019-03-25 Thread Yongseok Koh
Rx/Tx burst function pointers are stored in the rte_eth_dev structure, which is local to a process. Even though primary process replaces the function pointers, secondary will not run the new ones. With rte_mp APIs, primary can easily broadcast a request to stop/start the datapath of secondary proce

[dpdk-dev] [PATCH v2 1/4] net/mlx5: fix memory event on secondary process

2019-03-25 Thread Yongseok Koh
As the memory event is propagated to secondary processes, the event is processed redundantly. This should be processed once because the data structure used for MR and the event is global across the processes. Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH v2 3/4] net/mlx5: rework PMD global data init

2019-03-25 Thread Yongseok Koh
There's more need to have PMD global data structure. This should be initialized once per a process regardless of how many PMD instances are probed. mlx5_init_once() is called during probing and make sure all the init functions are called once per a process. Currently, such global data and its initi

[dpdk-dev] [PATCH v2 0/4] net/mlx5: rework IPC socket and PMD global data init

2019-03-25 Thread Yongseok Koh
The existing socket-based IPC channel is replaced with the new rte_mp APIs of EAL and extended to request stop/start of dataplane to secondary processes. Also, initialization of PMD global data including the new IPC channel is reworked to provide more generic framework for future use. v2: * add mo

[dpdk-dev] [PATCH v2 2/4] net/mlx5: replace IPC socket with EAL API

2019-03-25 Thread Yongseok Koh
Socket API is used for IPC in order for secondary process to acquire Verb command file descriptor. The FD is used to remap UAR address. The new multi-process APIs (rte_mp) in EAL are newly introduced. mlx5_socket.c is replaced with mlx5_mp.c, which uses the new APIs. As it is PMD global infrastruc

[dpdk-dev] [PATCH] net/mlx5: revert mbuf address calculation for x86

2019-03-25 Thread Yongseok Koh
When replenishing mbufs on Rx, buffer address (mbuf->buf_addr) should be loaded. non-x86 processors (mostly RISC such as ARM and Power) are more vulnerable to load stall. For x86, reducing the number of instructions seems to matter most. For x86, this is simply a load but for other architectures,

Re: [dpdk-dev] [PATCH v4 0/8] HelloWorld example for windows

2019-03-25 Thread Harini Ramakrishnan
Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Friday, March 22, 2019 3:55 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net

[dpdk-dev] [PATCH v5] net/kni: calc mbuf&mtu according to given mb_pool

2019-03-25 Thread lironh
From: Liron Himi - mbuf_size and mtu are now being calculated according to the given mb-pool. - max_mtu is now being set according to the given mtu the above two changes provide the ability to work with jumbo frames Signed-off-by: Liron Himi --- doc/guides/nics/kni.rst

Re: [dpdk-dev] [PATCH v2 01/13] net/mlx5: add representor recognition on kernels 5.x

2019-03-25 Thread Stephen Hemminger
On Mon, 25 Mar 2019 17:03:22 + Viacheslav Ovsiienko wrote: > + if (switch_id_set) { > + if (info.port_name_new) { > + /* New representors naming schema. */ > + if (port_name_set) { > + info.master = (info.port

Re: [dpdk-dev] [PATCH v2 01/13] net/mlx5: add representor recognition on kernels 5.x

2019-03-25 Thread Stephen Hemminger
On Mon, 25 Mar 2019 17:03:22 + Viacheslav Ovsiienko wrote: > + * Currently we support sinlge E-Switch per PF configurations > + * only and representors_id field contains the vport index for > + * corresponding VF, deduced from representor port name. > + * For exapmple, let

Re: [dpdk-dev] [PATCH v2] hash: fix sprintf with snprintf

2019-03-25 Thread Wang, Yipeng1
Sorry for the late reply, but I noticed the test folder is recently moved under app so you may need a rebase. Please keep my ack after rebase: Acked-by: Yipeng Wang >-Original Message- >From: Poornima, PallantlaX >Sent: Monday, March 25, 2019 7:43 AM >To: dev@dpdk.org >Cc: Pattan, Resh

Re: [dpdk-dev] [PATCH v4 7/8] doc: add documention for windows

2019-03-25 Thread Pallavi Kadam
On 3/25/2019 3:24 AM, Bruce Richardson wrote: On Sat, Mar 23, 2019 at 04:51:27PM +, Jerin Jacob Kollanukkaran wrote: On Fri, 2019-03-22 at 15:55 -0700, Anand Rawat wrote: Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to incl

[dpdk-dev] [PATCH v2 13/13] net/mlx5: add source vport match to the ingress rules

2019-03-25 Thread Viacheslav Ovsiienko
For E-Switch configurations over multiport Infiniband devices we should add source vport match to correctly distribute traffic between representors. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 36 1 file changed, 36 insertions(+)

[dpdk-dev] [PATCH v2 05/13] net/mlx5: add IB shared context alloc/free functions

2019-03-25 Thread Viacheslav Ovsiienko
The Mellanox NICs support SR-IOV and have E-Switch feature. When SR-IOV is set up in switchdev mode and E-Switch is enabled we have so called VF representors in the system. All representors belonging to the same E-Switch are created on the basis of the single PCI function and with current implement

[dpdk-dev] [PATCH v2 12/13] net/mlx5: update event handler for multiport IB devices

2019-03-25 Thread Viacheslav Ovsiienko
This patch modifies asynchronous event handler to support multiport Infiniband devices. Handler queries the event parameters, including event source port index, and invokes the handler for specific devices with appropriate port_id. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_et

[dpdk-dev] [PATCH v2 09/13] net/mlx5: switch to the shared IB device context

2019-03-25 Thread Viacheslav Ovsiienko
The code is updated to use the shared IB device context and device handles. The IB device context is shared between reprentors created over the single multiport IB device. All Verbs and DevX objects will be created whithin this shared context. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf

[dpdk-dev] [PATCH v2 11/13] net/mlx5: update install/uninstall int handler routines

2019-03-25 Thread Viacheslav Ovsiienko
We are implementing the support for multport Infiniband device withj representors attached to these multiple ports. Asynchronous device event notifications (link status change, removal event, etc.) should be shared between ports. We are going to implement shared event handler and this patch introdu

[dpdk-dev] [PATCH v2 07/13] net/mlx5: switch to the shared Protection Domain

2019-03-25 Thread Viacheslav Ovsiienko
The PMD code is updated to use Protected Domain from the the shared IB device context. The Domain is shared between all devices belonging to the same multiport Infiniband device. If IB device has only one port, the PD is not shared, because there is only ethernet device created over IB one. Signed

[dpdk-dev] [PATCH v2 10/13] net/mlx5: provide IB port for the object being created

2019-03-25 Thread Viacheslav Ovsiienko
The code is updated to provide IB port index for the Verbs objects being created - QP and Verbs Flows. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 2 ++ drivers/net/mlx5/mlx5_flow_verbs.c | 1 + drivers/net/mlx5/mlx5_txq.c| 4 ++--

[dpdk-dev] [PATCH v2 08/13] net/mlx5: switch to the shared context IB attributes

2019-03-25 Thread Viacheslav Ovsiienko
The code is updated to use the shared IB device attributes, located in the shared IB context. It saves some memory if there are representors created over the single Infiniband device with multuple ports. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v2 03/13] net/mlx5: add getting IB ports number for multiport IB

2019-03-25 Thread Viacheslav Ovsiienko
There is the routine mlx5_nl_portnum() added to get the number of ports of multiport Infiniband device. It is assumed the Uplink/VF representors are attached on this ports. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_n

[dpdk-dev] [PATCH v2 06/13] net/mlx5: switch to the names in the shared IB context

2019-03-25 Thread Viacheslav Ovsiienko
The IB device names are moved from device private data to the shared context, code involving the names is updated. The IB port index treatment is added where it is relevant. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h| 2 -- drivers/net/mlx5/

[dpdk-dev] [PATCH v2 01/13] net/mlx5: add representor recognition on kernels 5.x

2019-03-25 Thread Viacheslav Ovsiienko
The master device and VF representors were distinguished by presence of port name, master device did not have one. The new Linux kernels starting from 5.0 provide the port name for master device and the implemented representor recognizing method does not work. The new recognizing method is based on

[dpdk-dev] [PATCH v2 04/13] net/mlx5: add multiport IB device support to probing

2019-03-25 Thread Viacheslav Ovsiienko
mlx5_pci_probe() routine is refactored to probe the ports of found Infiniband devices. All active ports (with attached network interface), belonging to the same Infiniband device will use the signle shared Infiniband context of that device. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx

[dpdk-dev] [PATCH v2 02/13] net/mlx5: modify get ifindex routine for multiport IB

2019-03-25 Thread Viacheslav Ovsiienko
There is the routine mlx5_nl_ifindex() returning the network interface index associated with Infiniband device. We are going to support multiport IB devices, now function takes the IB port as argument and returns ifindex associated with tuple Signed-off-by: Viacheslav Ovsiienko --- drivers/net/

[dpdk-dev] [PATCH v2 00/14] net/mlx5: add support for multiport IB devices

2019-03-25 Thread Viacheslav Ovsiienko
The Mellanox NICs support SR-IOV and have E-Switch feature. When SR-IOV is set up in switchdev mode and E-Switch is enabled we have so called VF representors in the system. All representors belonging to the same E-Switch are created on the basis of the single PCI function and with current implemen

Re: [dpdk-dev] [PATCH v8] ci: Introduce travis builds for github repositories

2019-03-25 Thread Thomas Monjalon
25/03/2019 16:32, Michael Santana: > GitHub is a service used by developers to store repositories. GitHub > provides service integrations that allow 3rd party services to access > developer repositories and perform actions. One of these services is > Travis-CI, a simple continuous integration pla

Re: [dpdk-dev] [PATCH v5 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-25 Thread Stephen Hemminger
On Mon, 25 Mar 2019 14:03:56 +0800 Xiaolong Ye wrote: > + > + ret = xsk_ring_prod__reserve(fq, reserve_size, &idx); > + if (unlikely(!ret)) { > + AF_XDP_LOG(ERR, "Failed to reserve enough fq descs.\n"); You defined AF_XDP_LOG to add a newline (similar to other drivers). But a

Re: [dpdk-dev] [PATCH v4] net/kni: calc mbuf&mtu according to given mb_pool

2019-03-25 Thread Ferruh Yigit
On 3/24/2019 12:15 PM, lir...@marvell.com wrote: > From: Liron Himi > > - mbuf_size and mtu are now being calculated according > to the given mb-pool. > > - max_mtu is now being set according to the given mtu > > the above two changes provide the ability to work with jumbo frames > > Signed-of

[dpdk-dev] [PATCH] app/test-pipeline: fix missing dependency for FreeBSD build

2019-03-25 Thread Bruce Richardson
When building on FreeBSD, the compiler emitted an error due to being unable to find rte_pci.h. This was due to missing dependencies for the application. Fixes: 474572d2ae5a ("app/pipeline: move from test directory") Signed-off-by: Bruce Richardson --- app/test-pipeline/meson.build | 2 +- 1 fil

[dpdk-dev] [PATCH v8] ci: Introduce travis builds for github repositories

2019-03-25 Thread Michael Santana
GitHub is a service used by developers to store repositories. GitHub provides service integrations that allow 3rd party services to access developer repositories and perform actions. One of these services is Travis-CI, a simple continuous integration platform. This series introduces the ability

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix a typo

2019-03-25 Thread Thomas Monjalon
25/03/2019 15:16, Ferruh Yigit: > On 3/22/2019 3:17 PM, Rami Rosen wrote: > > This patch fixes a trivial typo in rte_ethdev.h. > > retieve=>retrieve > > > > Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Rami Rosen > > Review

Re: [dpdk-dev] [PATCH v2 7/7] app/testpmd: verify mtu with rte_eth_dev_info_get()

2019-03-25 Thread Ferruh Yigit
On 3/22/2019 1:01 PM, Ian Stokes wrote: > This commit uses the mtu fields populated in rte_eth_dev_info_get() > to validate the mtu value being passed in port_mtu_set(). > > Signed-off-by: Ian Stokes For patch title, I think 'rte_eth_dev_info_get()' is implementation detail here, what we are ver

Re: [dpdk-dev] [PATCH v2] test/distributor: fix sprintf with strlcpy

2019-03-25 Thread Hunt, David
Hi Poornima, On 14/2/2019 9:45 AM, Pallantla Poornima wrote: sprintf function is not secure as it doesn't check the length of string. replaced sprintf with strlcpy. Fixes: f74df2c57e ("test/distributor: test single and burst API") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- v2:

Re: [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU for igb devices

2019-03-25 Thread Ferruh Yigit
On 3/22/2019 1:01 PM, Ian Stokes wrote: > This commit sets the min and max supported MTU values for igb devices > via the eth_igb_info_get() function. Min MTU supported is set to > ETHER_MIN_MTU and max mtu is calculated as the max packet length > supported minus the transport overhead. To aid in t

[dpdk-dev] [PATCH] net: fix Tx VLAN flag for offload emulation

2019-03-25 Thread Chas Williams
From: Bill Hong A PMD might use rte_vlan_insert to implement Tx VLAN offload. Typically the PMD will insert the VLAN header in the transmit path and then attempt to send the packets. If this fails, the packets are returned to the application which may attempt to send these packets again. If the

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix a typo

2019-03-25 Thread Ferruh Yigit
On 3/22/2019 3:17 PM, Rami Rosen wrote: > This patch fixes a trivial typo in rte_ethdev.h. > retieve=>retrieve > > Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information") > Cc: sta...@dpdk.org > > Signed-off-by: Rami Rosen Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master

[dpdk-dev] [PATCH] vhost/crypto: fix coverity issues

2019-03-25 Thread Fan Zhang
Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode") Coverity Issue: 277214 Coverity Issue: 277220 Coverity Issue: 277233 Coverity Issue: 277236 Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

Re: [dpdk-dev] [PATCH v5 0/4] display testpmd forwarding engine stats on the fly

2019-03-25 Thread Ferruh Yigit
On 3/25/2019 8:51 AM, David Marchand wrote: > Here is a little series that makes it possible to display and clear > testpmd fwd engines while they run without having to stop them. > This is mostly handy when running stress tests and you look for packets > drops without having to stop/start testpmd

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: add min/max MTU to device info

2019-03-25 Thread Ferruh Yigit
On 3/22/2019 1:01 PM, Ian Stokes wrote: > From: Stephen Hemminger > > This addresses the usability issue raised by OVS at DPDK Userspace > summit. It adds general min/max mtu into device info. For compatiablity, > and to save space, it fits in a hole in existing structure. > > The initial versio

Re: [dpdk-dev] [PATCH v6 0/3] enable package download in ice driver

2019-03-25 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Monday, March 25, 2019 5:01 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > Subject: [PATCH v6 0/3] enable package download in ice driver > > This patch set enabled package downloading to the device. The package is to be > in t

[dpdk-dev] [PATCH v3 1/2] crypto/aesni_mb: enable out of place processing

2019-03-25 Thread Fan Zhang
Add out-of-place processing, i.e. different source and destination m_bufs, plus related capability update, tests and documentation. Signed-off-by: Fiona Trahe Signed-off-by: Paul Luse Signed-off-by: Fan Zhang Acked-by: Fiona Trahe Acked-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_mb.rs

  1   2   >