Re: [dpdk-dev] [PATCH v4] net/iavf: fix Tx interrupt vertor configuration error

2019-03-26 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Tuesday, March 26, 2019 1:08 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v4] net/iavf: fix Tx interrupt vertor configuration error > > There is need to align to kernel iavf code when setting T

Re: [dpdk-dev] [PATCH v2 01/13] net/mlx5: add representor recognition on kernels 5.x

2019-03-26 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Monday, March 25, 2019 20:08 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Shahaf Shuler > Subject: Re: [dpdk-dev] [PATCH v2 01/13] net/mlx5: add representor > recognition on kernels 5.x > > On Mon, 25 Mar 2019 17:03:22 + > Viachesl

Re: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for txonly mode

2019-03-26 Thread Ferruh Yigit
On 3/20/2019 4:53 AM, Pavan Nikhilesh Bhagavatula wrote: > On Tue, 2019-03-19 at 16:48 +, Ferruh Yigit wrote: >> On 3/1/2019 1:47 PM, Pavan Nikhilesh Bhagavatula wrote: >>> From: Pavan Nikhilesh >>> >>> Use mempool bulk get ops to alloc burst of packets and process >>> them. >>> If bulk get fa

[dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid

2019-03-26 Thread Wei Zhao
A log message is required when provided RSS key is not valid so that driver will use the default RSS key. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao Tested-by: Peng Yuan --- v2: update dev info message v3: update log info --- drivers/n

Re: [dpdk-dev] [PATCH v3] crypto/aesni_mb: support newer version library only

2019-03-26 Thread Akhil Goyal
On 3/25/2019 7:28 PM, Fan Zhang wrote: > As stated in 19.02 deprecation notice, this patch updates the > aesni_mb PMD to remove the support of older Intel-ipsec-mb > library version eariler than 0.52. > > Signed-off-by: Fan Zhang > Acked-by: Pablo de Lara > --- > v3: > - updated documentation.

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-26 Thread Dekel Peled
+Idan Werpoler. From: Pradeep Satyanarayana Sent: Sunday, March 24, 2019 7:38 PM To: Shahaf Shuler Cc: bruce.richard...@intel.com; Chao Zhu ; Dekel Peled ; dev@dpdk.org; David Christensen ; honnappa.nagaraha...@arm.com; konstantin.anan...@intel.com; ola.liljed...@arm.com; Ori Kam ; Thomas Mon

Re: [dpdk-dev] [PATCH 1/3] ethdev: add actions to modify TCP header fields

2019-03-26 Thread Dekel Peled
Hi Adrien, Can you please review? I'll appreciate receiving any comments soon. Thanks, Dekel > -Original Message- > From: Dekel Peled > Sent: Thursday, March 21, 2019 4:19 PM > To: Adrien Mazarguil ; > wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; Yongseok

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-03-26 Thread David Marchand
On Tue, Mar 19, 2019 at 6:18 PM Ferruh Yigit wrote: > On 3/14/2019 3:13 PM, David Marchand wrote: > > Introduce a new api to retrieve per queue statistics from the drivers. > > The api objectives: > > - easily add some common per queue statistics and have it exposed > > through the user xstats

Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector

2019-03-26 Thread Maxime Coquelin
Hi, On 3/26/19 2:00 AM, Lu, Wenzhuo wrote: Hi Maxime, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Monday, March 25, 2019 4:26 PM To: Lu, Wenzhuo ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector Hi, On 3/25/19

[dpdk-dev] [PATCH] compress/isal: fix compression stream initialization

2019-03-26 Thread Tomasz Cel
This patch fixes ISAL internal state fields initialization. Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality") Cc: sta...@dpdk.org Signed-off-by: Tomasz Cel --- drivers/compress/isal/isal_compress_pmd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE

2019-03-26 Thread Ferruh Yigit
On 3/26/2019 6:16 AM, Wenzhuo Lu wrote: > Use SSE and AVX2 instructions in ICE RX and TX path. > > --- > v2: > - Updated feature doc. > - Fixed checklog and checkpatch issues. > > v3: > - Fixed potential compile issue on non-X86 platform. > > v4: > - Removed compile configure, CONFIG_RTE_LIB

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-26 Thread Luca Boccassi
On Tue, 2019-03-26 at 10:18 +0800, Ye Xiaolong wrote: > On 03/25, Luca Boccassi wrote: > > On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote: > > > On 03/24, Luca Boccassi wrote: > > > > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: > > > > > On 03/02, Ye Xiaolong wrote: > > > > > > > >

Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows

2019-03-26 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > Added header files to support windows on x86 platforms. > Updated rte_common.h to include rte_windows.h for windows > build. Updated lib/meson.build to create shared libraries > on windows. Added def file to list the exports for the > eal libr

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto

2019-03-26 Thread Iremonger, Bernard
Hi Akhil, > Subject: Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st pkt > dropped for inline crypto > > Hi Bernard, > > On 3/7/2019 8:27 PM, Bernard Iremonger wrote: > > Inline crypto installs a flow rule in the NIC. This flow rule must be > > installed before the first inbound pac

Re: [dpdk-dev] [PATCH v5 7/8] doc: add documention for windows

2019-03-26 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > Added documentation to build helloworld example > on windows using meson and clang. Updated the > maintainers list to include windows maintainers. > > Signed-off-by: Pallavi Kadam > Signed-off-by: Anand Rawat > Reviewed-by: Jeff Shaw > Rev

[dpdk-dev] [PATCH v3] app/test/hash: fix sprintf with snprintf

2019-03-26 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 473d1bebce ("hash: allow to store data in hash table") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima Acked-by: Yipeng Wang --- v3: Rebased. v2: Addressed review comment

Re: [dpdk-dev] [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > adding a DEF file for kvargs to specify the exports > for the creation of the shared library. > > Signed-off-by: Bruce Richardson > Signed-off-by: Anand Rawat > Reviewed-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > lib/librte_kv

Re: [dpdk-dev] [PATCH v5 7/8] doc: add documention for windows

2019-03-26 Thread David Marchand
On Tue, Mar 26, 2019 at 7:04 AM Anand Rawat wrote: > Added documentation to build helloworld example > on windows using meson and clang. Updated the > maintainers list to include windows maintainers. > Can you fix the patch subject ? -- David Marchand

Re: [dpdk-dev] [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Bruce Richardson
On Tue, Mar 26, 2019 at 10:32:34AM +, Jerin Jacob Kollanukkaran wrote: > On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > > adding a DEF file for kvargs to specify the exports > > for the creation of the shared library. > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: Anand R

Re: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for txonly mode

2019-03-26 Thread Thomas Monjalon
01/03/2019 14:47, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > Use mempool bulk get ops to alloc burst of packets and process them. > If bulk get fails fallback to rte_mbuf_raw_alloc. > > Suggested-by: Andrew Rybchenko > Signed-off-by: Pavan Nikhilesh > --- > > v2 Changes: > - U

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto

2019-03-26 Thread Akhil Goyal
Hi Bernard, On 3/26/2019 3:52 PM, Iremonger, Bernard wrote: > Hi Akhil, > > >> Subject: Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st pkt >> dropped for inline crypto >> >> Hi Bernard, >> >> On 3/7/2019 8:27 PM, Bernard Iremonger wrote: >>> Inline crypto installs a flow rule in the

Re: [dpdk-dev] [PATCH v1 1/4] baseband/fpga_lte_fec: addition of driver for 4G turbo FEC with PAC N300 FPGA card

2019-03-26 Thread Akhil Goyal
Hi Smith, Could you please reply to Thomas' comments. Regards, Akhil On 3/9/2019 6:54 AM, Thomas Monjalon wrote: > Hi, > > 01/03/2019 18:23, Smith, Eleanor: >> Addition of a FPGA driver for acceleration of 4G turbo encoding and >> decoding. >> >> Signed-off-by: Smith, Eleanor > I'm really not

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto

2019-03-26 Thread Iremonger, Bernard
Hi Akhil, > >> Subject: Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st > >> pkt dropped for inline crypto > >> > >> Hi Bernard, > >> > >> On 3/7/2019 8:27 PM, Bernard Iremonger wrote: > >>> Inline crypto installs a flow rule in the NIC. This flow rule must > >>> be installed before

Re: [dpdk-dev] [PATCH v2 02/13] net/mlx5: modify get ifindex routine for multiport IB

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 7:03 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2 02/13] net/mlx5: modify get ifindex routine > for multiport IB > > There is the routine mlx5_nl_ifindex() returning the network interface index > associated with Infiniband device. > We are going to support multi

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto

2019-03-26 Thread Akhil Goyal
Hi Bernard, On 3/26/2019 5:11 PM, Iremonger, Bernard wrote: > Hi Akhil, > > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto Hi Bernard, On 3/7/2019 8:27 PM, Bernard Iremonger wrote: > Inline crypto installs a f

Re: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for txonly mode

2019-03-26 Thread Iremonger, Bernard
Hi Pavan, > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for > txonly mode > > 01/03/2019 14:47, Pavan Nikhilesh Bhagavatula: > > From: Pavan Nikhilesh > > > > Use mempool bulk get ops to alloc burst of packets and process them. > > If bulk get fails fallback to rte_mbu

[dpdk-dev] [PATCH 1/4] bus/dpaa: fq lookup table saved for secondary process

2019-03-26 Thread Hemant Agrawal
From: Akhil Goyal A reference to qman_fq_lookup_table need to be saved in each fq, so that it is retrieved while in running secondary process. Signed-off-by: Akhil Goyal --- drivers/bus/dpaa/base/qbman/qman.c| 8 +++- drivers/bus/dpaa/include/fsl_qman.h | 6 ++ drivers/bu

[dpdk-dev] [PATCH 2/4] mempool/dpaa: bp info dynamic allocation for multiprocess

2019-03-26 Thread Hemant Agrawal
From: Akhil Goyal rte_dpaa_bpid_info shall be allocated with the hugepage memory which can be shared across processes. Signed-off-by: Akhil Goyal --- drivers/bus/dpaa/include/fsl_qman.h | 1 + drivers/mempool/dpaa/dpaa_mempool.c | 10 +- drivers/mempool/dpaa/dpaa_mempool.h | 4 ++--

[dpdk-dev] [PATCH 3/4] bus/dpaa: delay fman device list to bus probe

2019-03-26 Thread Hemant Agrawal
The fman device list need to be accessed across processes. The hw device structures should be allocated with rte_calloc instead of calloc. The rte_calloc is not available at the time of bus scan, so better prepare the device list at probe. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/

[dpdk-dev] [PATCH 4/4] net/dpaa2: add support for flow table flush

2019-03-26 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 + drivers/net/dpaa2/dpaa2_ethdev.h | 2 + drivers/net/dpaa2/dpaa2_flow.c | 118 +-- 3 files changed, 85 insertions(+), 37 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers

Re: [dpdk-dev] [PATCH v2 04/13] net/mlx5: add multiport IB device support to probing

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 7:03 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2 04/13] net/mlx5: add multiport IB device > support to probing > > mlx5_pci_probe() routine is refactored to probe the ports of found > Infiniband devices. All active ports (with attached network interface), > bel

Re: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for txonly mode

2019-03-26 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, March 26, 2019 5:20 PM > To: Thomas Monjalon ; Pavan Nikhilesh > Bhagavatula > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > arybche...@solarflare.com; Yigit, Ferruh > Subject: [EXT] RE: [dpdk-dev] [PATCH v2] app/testp

Re: [dpdk-dev] [PATCH v2 05/13] net/mlx5: add IB shared context alloc/free functions

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 7:03 PM, Viacheslav Ovsiienko: > Subject: [PATCH v2 05/13] net/mlx5: add IB shared context alloc/free > functions > > The Mellanox NICs support SR-IOV and have E-Switch feature. > When SR-IOV is set up in switchdev mode and E-Switch is enabled we have > so called VF represen

Re: [dpdk-dev] [PATCH v2 11/13] net/mlx5: update install/uninstall int handler routines

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 7:04 PM, Viacheslav Ovsiienko: > Subject: [PATCH v2 11/13] net/mlx5: update install/uninstall int handler > routines > > We are implementing the support for multport Infiniband device withj > representors attached to these multiple ports. Asynchronous device event > notifica

Re: [dpdk-dev] [PATCH v2 12/13] net/mlx5: update event handler for multiport IB devices

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 7:04 PM, Viacheslav Ovsiienko: > Subject: [PATCH v2 12/13] net/mlx5: update event handler for multiport IB > devices > > This patch modifies asynchronous event handler to support multiport > Infiniband devices. Handler queries the event parameters, including event > source p

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-26 Thread Ye Xiaolong
On 03/26, Luca Boccassi wrote: >On Tue, 2019-03-26 at 10:18 +0800, Ye Xiaolong wrote: >> On 03/25, Luca Boccassi wrote: >> > On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote: >> > > On 03/24, Luca Boccassi wrote: >> > > > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: >> > > > > On 03/02

[dpdk-dev] [PATCH 1/5] raw/dpaa2_qdma: remove experimental tag from APIs

2019-03-26 Thread Hemant Agrawal
These APIs has been in the DPDK for few release now. This patch removes the experimental tags for the APIs. Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/Makefile | 1 - drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 20 ++--- drivers/raw/dpaa2_qdma/rte_pmd_dpa

[dpdk-dev] [PATCH 5/5] raw/dpaa2x: remove rte logs from data path

2019-03-26 Thread Hemant Agrawal
From: Nipun Gupta The runtime traces shall not be present in datapath Signed-off-by: Nipun Gupta --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 4 drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 8 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 2 +- 3 files changed, 1 insertion(

[dpdk-dev] [PATCH 2/5] raw/dpaa2_qdma: fix to support multiprocess execution

2019-03-26 Thread Hemant Agrawal
From: Shreyansh Jain Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs") Cc: nipun.gu...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH 4/5] raw/dpaa2_qdma: add rbp mode support

2019-03-26 Thread Hemant Agrawal
Add support for route by port mode. The route by port feature in HW helps in translating the PCI addresss of connected device. Signed-off-by: Minghuan Lian Signed-off-by: Sachin Saxena --- drivers/raw/dpaa2_qdma/Makefile | 2 +- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 403 ++

[dpdk-dev] [PATCH 3/5] raw/dpaa2_qdma: add burst mode support

2019-03-26 Thread Hemant Agrawal
This patch adds support the batch processing for the qdma jobs Signed-off-by: Hemant Agrawal Signed-off-by: Yi Liu --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 309 ++-- drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 6 +- 2 files changed, 167 insertions(+), 148 deletions(

Re: [dpdk-dev] [PATCH v2 01/13] net/mlx5: add representor recognition on kernels 5.x

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 7:03 PM, Viacheslav Ovsiienko: > Subject: [PATCH v2 01/13] net/mlx5: add representor recognition on kernels > 5.x > > The master device and VF representors were distinguished by presence of > port name, master device did not have one. The new Linux kernels starting > from 5.

Re: [dpdk-dev] [PATCH v2 13/13] net/mlx5: add source vport match to the ingress rules

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 7:04 PM, Viacheslav Ovsiienko: > Subject: [PATCH v2 13/13] net/mlx5: add source vport match to the ingress > rules > > For E-Switch configurations over multiport Infiniband devices we should add > source vport match to correctly distribute traffic between representors. > >

[dpdk-dev] [PATCH v6 0/5] Introduce AF_XDP PMD

2019-03-26 Thread Xiaolong Ye
Overview This patchset adds a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below links [1] [2] for details of AF_XDP introduction: AF_XDP roadmap == - AF_XDP is included in upstream kernel since 4.18, and AF_XDP support i

[dpdk-dev] [PATCH v6 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-26 Thread Xiaolong Ye
Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.org/2018/schedule/event/af_xdp/ [2] https://

[dpdk-dev] [PATCH v6 2/5] lib/mbuf: introduce helper to create mempool with flags

2019-03-26 Thread Xiaolong Ye
This allows applications to create mbuf mempool with specific flags such as MEMPOOL_F_NO_SPREAD if they want fixed size memory objects. Signed-off-by: Qi Zhang Signed-off-by: Xiaolong Ye --- lib/librte_mbuf/rte_mbuf.c | 29 ++ lib/librte_mbuf/rte_mbuf.h | 45

[dpdk-dev] [PATCH v6 3/5] lib/mempool: allow page size aligned mempool

2019-03-26 Thread Xiaolong Ye
Allow create a mempool with page size aligned base address. Signed-off-by: Qi Zhang Signed-off-by: Xiaolong Ye --- lib/librte_mempool/rte_mempool.c | 3 +++ lib/librte_mempool/rte_mempool.h | 1 + 2 files changed, 4 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempo

[dpdk-dev] [PATCH v6 4/5] net/af_xdp: use mbuf mempool for buffer management

2019-03-26 Thread Xiaolong Ye
Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf allocated from rte_mempool can be converted to xdp_desc's address and vice versa. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 117 +--- 1 file changed, 72 insertions(+), 45 delet

[dpdk-dev] [PATCH v6 5/5] net/af_xdp: enable zero copy

2019-03-26 Thread Xiaolong Ye
Try to check if external mempool (from rx_queue_setup) is fit for af_xdp, if it is, it will be registered to af_xdp socket directly and there will be no packet data copy on Rx and Tx. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 130 1 file ch

[dpdk-dev] [PATCH v3 1/2] app/testpmd: optimize testpmd txonly mode

2019-03-26 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Optimize testpmd txonly mode by 1. Moving per packet ethernet header copy above the loop. 2. Use bulk ops for allocating segments instead of having a inner loop for every segment. Also, move the packet prepare logic into a separate function so that it can be reused later.

[dpdk-dev] [PATCH v3 2/2] app/testpmd: add mempool bulk get for txonly mode

2019-03-26 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Use mempool bulk get ops to alloc burst of packets and process them. If bulk get fails fallback to rte_mbuf_raw_alloc. Tested-by: Yingya Han Suggested-by: Andrew Rybchenko Signed-off-by: Pavan Nikhilesh --- app/test-pmd/txonly.c | 37 ++--

Re: [dpdk-dev] [PATCH v2 1/4] net/mlx5: fix memory event on secondary process

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 9:16 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2 1/4] net/mlx5: fix memory event on > secondary process > > As the memory event is propagated to secondary processes, the event is > processed redundantly. This should be processed once because the data > structure used f

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto

2019-03-26 Thread Ananyev, Konstantin
Hi Akhil, > > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st > pkt dropped for inline crypto > > Hi Bernard, > > On 3/7/2019 8:27 PM, Bernard Iremonger wrote: > > Inline crypto installs a flow rule in the NIC. This flow rule must > > b

Re: [dpdk-dev] [PATCH v2 2/4] net/mlx5: replace IPC socket with EAL API

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 9:16 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2 2/4] net/mlx5: replace IPC socket with EAL > API > > Socket API is used for IPC in order for secondary process to acquire Verb > command file descriptor. The FD is used to remap UAR address. The new > multi-process APIs

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx5: rework PMD global data init

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 9:16 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2 3/4] net/mlx5: rework PMD global data init > > There's more need to have PMD global data structure. This should be > initialized once per a process regardless of how many PMD instances are > probed. mlx5_init_once() is c

Re: [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid

2019-03-26 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Tuesday, March 26, 2019 4:35 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > ; Zhao1, Wei > Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid > > A log message is required when provided RSS ke

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: sync stop/start of datapath with secondary process

2019-03-26 Thread Shahaf Shuler
Monday, March 25, 2019 9:16 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2 4/4] net/mlx5: sync stop/start of datapath > with secondary process > > Rx/Tx burst function pointers are stored in the rte_eth_dev structure, which > is local to a process. Even though primary process replaces the funct

[dpdk-dev] [PATCH] eal: make max interrupt vectors configurable

2019-03-26 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Make max interrupt vectors configurable so that platforms can choose interrupt vector limit. Signed-off-by: Pavan Nikhilesh --- config/common_base | 1 + lib/librte_eal/common/include/rte_eal_interrupts.h | 2 +- 2 files changed, 2 insertio

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto

2019-03-26 Thread Akhil Goyal
Hi Konstantin, On 3/26/2019 5:59 PM, Ananyev, Konstantin wrote: > Hi Akhil, > >> Subject: Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st >> pkt dropped for inline crypto >> >> Hi Bernard, >> >> On 3/7/2019 8:27 PM, Bernard Iremonger wrote: >>> Inline crypto

[dpdk-dev] [PATCH v4 1/2] app/testpmd: optimize testpmd txonly mode

2019-03-26 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Optimize testpmd txonly mode by 1. Moving per packet ethernet header copy above the loop. 2. Use bulk ops for allocating segments instead of having a inner loop for every segment. Also, move the packet prepare logic into a separate function so that it can be reused later.

[dpdk-dev] [PATCH v4 2/2] app/testpmd: add mempool bulk get for txonly mode

2019-03-26 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Use mempool bulk get ops to alloc burst of packets and process them. If bulk get fails fallback to rte_mbuf_raw_alloc. Tested-by: Yingya Han Suggested-by: Andrew Rybchenko Signed-off-by: Pavan Nikhilesh --- app/test-pmd/txonly.c | 37 ++--

Re: [dpdk-dev] [PATCH] eal: make max interrupt vectors configurable

2019-03-26 Thread Jerin Jacob Kollanukkaran
On Tue, 2019-03-26 at 12:54 +, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Make max interrupt vectors configurable so that platforms can > choose interrupt vector limit. > > Signed-off-by: Pavan Nikhilesh > --- > config/common_base Pleas

Re: [dpdk-dev] [PATCH] eal: make max interrupt vectors configurable

2019-03-26 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Tuesday, March 26, 2019 6:38 PM > To: tho...@monjalon.net; Pavan Nikhilesh Bhagavatula > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: make max interrupt vectors > configurable > > On Tue, 2019-03-26 at 12:54 +00

Re: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for txonly mode

2019-03-26 Thread Jerin Jacob Kollanukkaran
On Tue, 2019-03-26 at 12:06 +, Pavan Nikhilesh Bhagavatula wrote: > > -Original Message- > > From: Iremonger, Bernard > > Sent: Tuesday, March 26, 2019 5:20 PM > > To: Thomas Monjalon ; Pavan Nikhilesh > > Bhagavatula > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > > arybche...@so

[dpdk-dev] [PATCH v2] eal: make max interrupt vectors configurable

2019-03-26 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Make max interrupt vectors configurable so that platforms can choose interrupt vector limit. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Add defaults for meson build. (Jerin Jacob) config/common_base | 1 + config/meson.build

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Jerin Jacob Kollanukkaran
On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > --- > --- > On Tue, Mar 26, 2019 at 10:32:34AM +, Jerin Jacob Kollanukkaran > wrote: > > On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > > > adding a DEF file for

[dpdk-dev] [PATCH v5 0/1] add dynamic sgl allocation

2019-03-26 Thread Tomasz Jozwiak
This patch adds dynamic sgl allocation in QAT PMD and depends on 'malloc: add rte_realloc_socket function patch' (https://patches.dpdk.org/patch/50711/) which should be applied first. Changes -v2: added rte_realloc_socket instead of rte_realloc -v3: fixed subject in patches series to see cov

[dpdk-dev] [PATCH v5 1/1] compress/qat: add dynamic sgl allocation

2019-03-26 Thread Tomasz Jozwiak
This patch adds dynamic SGL allocation instead of static one. The number of element in SGL can be adjusted in each operation depend of the request. Signed-off-by: Tomasz Jozwiak --- config/common_base | 1 - doc/guides/compressdevs/qat_comp.rst | 1 - doc/guides/cryptodevs/qa

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Thomas Monjalon
26/03/2019 14:37, Jerin Jacob Kollanukkaran: > On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > > However, my hope is that down the road we can have the def file > > generated > > from the map file (or potentially vice versa). Perhaps the meson > > python > > module could be used to all

Re: [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU for igb devices

2019-03-26 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, March 25, 2019 10:25 PM > To: Stokes, Ian ; dev@dpdk.org > Cc: step...@networkplumber.org; Lu, Wenzhuo ; > Ananyev, Konstantin ; Xing, Beilei > ; Zhang, Qi Z > Subject: Re: [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU

Re: [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU for igb devices

2019-03-26 Thread Ananyev, Konstantin
Hi Qi, > > > > On 3/22/2019 1:01 PM, Ian Stokes wrote: > > > This commit sets the min and max supported MTU values for igb devices > > > via the eth_igb_info_get() function. Min MTU supported is set to > > > ETHER_MIN_MTU and max mtu is calculated as the max packet length > > > supported minus th

Re: [dpdk-dev] [PATCH v2] eal: make max interrupt vectors configurable

2019-03-26 Thread Thomas Monjalon
26/03/2019 14:21, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > Make max interrupt vectors configurable so that platforms can > choose interrupt vector limit. What is the impact of setting a big value? Can we agree on a big enough value without introducing any config?

Re: [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU for igb devices

2019-03-26 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, March 26, 2019 10:02 PM > To: Zhang, Qi Z ; Yigit, Ferruh > ; > Stokes, Ian ; dev@dpdk.org > Cc: step...@networkplumber.org; Lu, Wenzhuo ; Xing, > Beilei > Subject: RE: [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max

Re: [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU for igb devices

2019-03-26 Thread Ananyev, Konstantin
> > > > Hi Qi, > > > > > > > > > > On 3/22/2019 1:01 PM, Ian Stokes wrote: > > > > > This commit sets the min and max supported MTU values for igb > > > > > devices via the eth_igb_info_get() function. Min MTU supported is > > > > > set to ETHER_MIN_MTU and max mtu is calculated as the max packet

[dpdk-dev] [PATCH] drivers/qat: fix qp numa node

2019-03-26 Thread Tomasz Jozwiak
This patch assigns QAT queue pair resources to the correct NUMA nodes. Any DMA'able memory should use NUMA node of QAT device rather than socket_id of the initializing process. Fixes: 98c4a35c736f ("crypto/qat: move common qat files to common dir") Fixes: a795248d740b ("compress/qat: add configure

[dpdk-dev] [PATCH v4 0/1] test: new test structure for asymmetric crypto

2019-03-26 Thread Damian Nowak
This patch adds new test structure for modexp and modinv for asymmetric cryptography This patch depends on following patchsets: [1] - Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices (http://patchwork.dpdk.org/cover/50660/) --- v4: - rebase - remove unused

[dpdk-dev] [PATCH v4 1/1] test: new test structure for asymmetric crypto

2019-03-26 Thread Damian Nowak
This patch adds new test structure for modexp and modinv for asymmetric cryptography Signed-off-by: Damian Nowak --- app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 318 ++ app/test/test_cryptodev_mod_test_vectors.h | 967 +

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Bruce Richardson
On Tue, Mar 26, 2019 at 01:37:33PM +, Jerin Jacob Kollanukkaran wrote: > On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > > --- > > --- > > On Tue, Mar 26, 2019 at 10:32:34AM +, Jerin Jacob Kollanukkaran > > wrote:

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Bruce Richardson
On Tue, Mar 26, 2019 at 02:55:41PM +0100, Thomas Monjalon wrote: > 26/03/2019 14:37, Jerin Jacob Kollanukkaran: > > On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > > > However, my hope is that down the road we can have the def file > > > generated > > > from the map file (or potentiall

Re: [dpdk-dev] [PATCH v2] eal: make max interrupt vectors configurable

2019-03-26 Thread Bruce Richardson
On Tue, Mar 26, 2019 at 03:04:58PM +0100, Thomas Monjalon wrote: > 26/03/2019 14:21, Pavan Nikhilesh Bhagavatula: > > From: Pavan Nikhilesh > > > > Make max interrupt vectors configurable so that platforms can > > choose interrupt vector limit. > > What is the impact of setting a big value? > Ca

Re: [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid

2019-03-26 Thread Ferruh Yigit
On 3/26/2019 12:41 PM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Zhao1, Wei >> Sent: Tuesday, March 26, 2019 4:35 PM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh >> ; Zhao1, Wei >> Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Thomas Monjalon
26/03/2019 15:41, Bruce Richardson: > On Tue, Mar 26, 2019 at 02:55:41PM +0100, Thomas Monjalon wrote: > > 26/03/2019 14:37, Jerin Jacob Kollanukkaran: > > > On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > > > > However, my hope is that down the road we can have the def file > > > > ge

Re: [dpdk-dev] [RFC] ethdev: add administrative information in per-port info

2019-03-26 Thread Ferruh Yigit
On 12/12/2017 11:10 AM, olivier.matz at 6wind.com (Olivier MATZ) wrote: > Hi Andrew, > > On Wed, Nov 15, 2017 at 12:09:24PM +0300, Andrew Rybchenko wrote: >> On 09/08/2017 12:21 PM, Ivan Boule wrote: >>> To help administrative tasks on DPDK ports, add in the data structure >>> rte_eth_dev_info the

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Bruce Richardson
On Tue, Mar 26, 2019 at 04:07:26PM +0100, Thomas Monjalon wrote: > 26/03/2019 15:41, Bruce Richardson: > > On Tue, Mar 26, 2019 at 02:55:41PM +0100, Thomas Monjalon wrote: > > > 26/03/2019 14:37, Jerin Jacob Kollanukkaran: > > > > On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > > > > >

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Thomas Monjalon
26/03/2019 16:17, Bruce Richardson: > On Tue, Mar 26, 2019 at 04:07:26PM +0100, Thomas Monjalon wrote: > > 26/03/2019 15:41, Bruce Richardson: > > > On Tue, Mar 26, 2019 at 02:55:41PM +0100, Thomas Monjalon wrote: > > > > 26/03/2019 14:37, Jerin Jacob Kollanukkaran: > > > > > On Tue, 2019-03-26 at

Re: [dpdk-dev] [PATCH v3] crypto/aesni_mb: support newer version library only

2019-03-26 Thread Zhang, Roy Fan
Hi Akhil, I have discussed with Ferruh in relation to the updating release note for this change. However the change seems not apply to any section under the release note. The change does not introduce new feature, nor breaks ABI/API - it only changes the requirement of the dependent external l

Re: [dpdk-dev] [RFC] ethdev: add administrative information in per-port info

2019-03-26 Thread Ferruh Yigit
On 3/26/2019 3:09 PM, Ferruh Yigit wrote: > On 12/12/2017 11:10 AM, olivier.matz at 6wind.com (Olivier MATZ) wrote: >> Hi Andrew, >> >> On Wed, Nov 15, 2017 at 12:09:24PM +0300, Andrew Rybchenko wrote: >>> On 09/08/2017 12:21 PM, Ivan Boule wrote: To help administrative tasks on DPDK ports, ad

[dpdk-dev] [PATCH v3 01/13] net/mlx5: add representor recognition on kernels 5.x

2019-03-26 Thread Viacheslav Ovsiienko
The master device and VF representors were distinguished by presence of port name, master device did not have one. The new Linux kernels starting from 5.0 provide the port name for master device and the implemented representor recognizing method does not work. The new recognizing method is based on

[dpdk-dev] [PATCH v3 00/14] net/mlx5: add support for multiport IB devices

2019-03-26 Thread Viacheslav Ovsiienko
The Mellanox NICs support SR-IOV and have E-Switch feature. When SR-IOV is set up in switchdev mode and E-Switch is enabled we have so called VF representors in the system. All representors belonging to the same E-Switch are created on the basis of the single PCI function and with current implemen

[dpdk-dev] [PATCH v3 02/13] net/mlx5: modify get ifindex routine for multiport IB

2019-03-26 Thread Viacheslav Ovsiienko
There is the routine mlx5_nl_ifindex() returning the network interface index associated with Infiniband device. We are going to support multiport IB devices, now function takes the IB port as argument and returns ifindex associated with tuple Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf

[dpdk-dev] [PATCH v3 03/13] net/mlx5: add getting IB ports number for multiport IB

2019-03-26 Thread Viacheslav Ovsiienko
There is the routine mlx5_nl_portnum() added to get the number of ports of multiport Infiniband device. It is assumed the Uplink/VF representors are attached on these ports. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH v3 06/13] net/mlx5: switch to the names in the shared IB context

2019-03-26 Thread Viacheslav Ovsiienko
The IB device names are moved from device private data to the shared context, code involving the names is updated. The IB port index treatment is added where it is relevant. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h| 2 -- drivers/net/mlx5/

[dpdk-dev] [PATCH v3 04/13] net/mlx5: add multiport IB device support to probing

2019-03-26 Thread Viacheslav Ovsiienko
mlx5_pci_probe() routine is refactored to probe the ports of found Infiniband devices. All active ports (with attached network interface), belonging to the same Infiniband device will use the signle shared Infiniband context of that device. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shu

[dpdk-dev] [PATCH v3 07/13] net/mlx5: switch to the shared Protection Domain

2019-03-26 Thread Viacheslav Ovsiienko
The PMD code is updated to use Protected Domain from the the shared IB device context. The Domain is shared between all devices belonging to the same multiport Infiniband device. If IB device has only one port, the PD is not shared, because there is only ethernet device created over IB one. Signed

[dpdk-dev] [PATCH v3 09/13] net/mlx5: switch to the shared IB device context

2019-03-26 Thread Viacheslav Ovsiienko
The code is updated to use the shared IB device context and device handles. The IB device context is shared between reprentors created over the single multiport IB device. All Verbs and DevX objects will be created whithin this shared context. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf

[dpdk-dev] [PATCH v3 10/13] net/mlx5: provide IB port for the object being created

2019-03-26 Thread Viacheslav Ovsiienko
The code is updated to provide IB port index for the Verbs objects being created - QPs and Verbs Flows. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 2 ++ drivers/net/mlx5/mlx5_flow_verbs.c | 1 + drivers/net/mlx5/mlx5_txq.c| 4 ++-

[dpdk-dev] [PATCH v3 08/13] net/mlx5: switch to the shared context IB attributes

2019-03-26 Thread Viacheslav Ovsiienko
The code is updated to use the shared IB device attributes, located in the shared IB context. It saves some memory if there are representors created over the single Infiniband device with multuple ports. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v3 11/13] net/mlx5: update install/uninstall int handler routines

2019-03-26 Thread Viacheslav Ovsiienko
We are implementing the support for multport Infiniband device withj representors attached to these multiple ports. Asynchronous device event notifications (link status change, removal event, etc.) should be shared between ports. We are going to implement shared event handler and this patch introdu

[dpdk-dev] [PATCH v3 12/13] net/mlx5: update event handler for multiport IB devices

2019-03-26 Thread Viacheslav Ovsiienko
This patch modifies asynchronous event handler to support multiport Infiniband devices. Handler queries the event parameters, including event source port index, and invokes the handler for specific devices with appropriate port_id. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler ---

[dpdk-dev] [PATCH v3 13/13] net/mlx5: add source vport match to the ingress rules

2019-03-26 Thread Viacheslav Ovsiienko
For E-Switch configurations over multiport Infiniband devices we should add source vport match to correctly distribute traffic between representors. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 36 1 file changed, 36 insertions(+)

  1   2   >