[dpdk-dev] [PATCH v2 2/3] mlx5: Implement support for read_clock

Signed-off-by: Tom Barbette --- drivers/net/mlx5/mlx5.c| 1 + drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_ethdev.c | 29 + drivers/net/mlx5/mlx5_glue.c | 8 drivers/net/mlx5/mlx5_glue.h | 2 ++ 5 files changed, 41 insertions(+)

[dpdk-dev] [PATCH v2 3/3] rxtx_callbacks: Add support for HW timestamp

Use rxtx callback to demonstrate a way to use rte_eth_read_clock to convert the hardware timestamps to an amount of cycles. This allows to get the amount of time the packet spent since its entry in the device. While the regular latency only shows the latency from when it entered the software stack

[dpdk-dev] [PATCH v2 1/3] rte_ethdev: Add API function to read dev clock

Add rte_eth_read_clock to read the raw clock of a devide. The main use is to get the device clock conversion co-efficients to be able to translate the raw clock of the timestamp field of the pkt mbuf to a local synced time value. This function was missing to allow users to convert the RX timestam

[dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API

Some NICs allow to timestamp packets, but do not support the full PTP synchronization process. Hence, the value set in the mbuf timestamp field is only the raw value of an internal clock. To make sense of this value, one at least needs to be able to query the current hardware clock value. As with

Re: [dpdk-dev] [PATCH v3 00/14] net/mlx5: add support for multiport IB devices

Tuesday, March 26, 2019 5:35 PM, Viacheslav Ovsiienko: > Subject: [PATCH v3 00/14] net/mlx5: add support for multiport IB devices > > The Mellanox NICs support SR-IOV and have E-Switch feature. > When SR-IOV is set up in switchdev mode and E-Switch is enabled we have > so called VF representors in

[dpdk-dev] [PATCH v2 3/3] doc/rcu: add lib_rcu documentation

Add lib_rcu QSBR API and programmer guide documentation. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Marko Kovacevic --- doc/api/doxy-api-index.md | 3 +- doc/api/doxy-api.conf.in | 1 + .../prog_guide/img/rcu_general_info.svg | 509 +

[dpdk-dev] [PATCH v2 2/3] test/rcu_qsbr: add API and functional tests

From: Dharmik Thakkar Add API positive/negative test cases, functional tests and performance tests. Signed-off-by: Malvika Gupta Signed-off-by: Dharmik Thakkar Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/Makefile | 2 + app/test/autotest_data.py

[dpdk-dev] [PATCH v2 1/3] rcu: add RCU library supporting QSBR mechanism

Add RCU library supporting quiescent state based memory reclamation method. This library helps identify the quiescent state of the reader threads so that the writers can free the memory associated with the lock less data structures. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Steve Capper R

[dpdk-dev] [PATCH v2 0/3] lib/rcu: add RCU library supporting QSBR mechanism

Lock-less data structures provide scalability and determinism. They enable use cases where locking may not be allowed (for ex: real-time applications). In the following paras, the term 'memory' refers to memory allocated by typical APIs like malloc or anything that is representative of memory, for

Re: [dpdk-dev] [PATCH v6 1/5] net/af_xdp: introduce AF XDP PMD driver

On 03/26, Stephen Hemminger wrote: >On Tue, 26 Mar 2019 20:20:25 +0800 >Xiaolong Ye wrote: > >> +This Linux-specific PMD driver creates the AF_XDP socket and binds it to a >> +specific netdev queue, it allows a DPDK application to send and receive raw >> +packets through the socket which would byp

Re: [dpdk-dev] [PATCH] mem: don't use address hint for mapping unless requested

Anatoly, Alejandro, Any comments on this one? Thursday, March 21, 2019 10:22 PM, Shahaf Shuler: > Subject: [dpdk-dev] [PATCH] mem: don't use address hint for mapping > unless requested > > patch[1] added an address hint as starting address for 64 bit systems in case > an explicit base virtual ad

[dpdk-dev] [PATCH] net/fm10k: fix VLAN strip offload flag

Since the VLAN header is stripped from mbuf data, PKT_RX_VLAN_STRIPPED should be set in offload flag. Fixes: 6b59a3bc82b1 ("fm10k: fix VLAN in Rx mbuf") Fixes: 7092be8437bd ("fm10k: add vector Rx") Cc: sta...@dpdk.org Signed-off-by: Xiao Wang --- drivers/net/fm10k/fm10k_rxtx.c | 4 ++-- dr

Re: [dpdk-dev] Aligned rte_mempool for storage applications

Thanks Jim for the consideration. I humbly suggested the ideas, since we had a similar issue when creating AF_XDP_ZC PMD. Happy to share ideas. Thanks Vipin Varghese > -Original Message- > From: Harris, James R > Sent: Wednesday, March 27, 2019 12:29 AM > To: Howell, Seth ; Varghese, V

[dpdk-dev] [PATCH v2] raw/ifpga: modify log output

print function name in ifpga log and a new line goes after every IFPGA log. Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: rosen...@intel.com Cc: andy@intel.com Cc: sta...@dpdk.org Signed-off-by: Andy Pei --- drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 4 ++-- 1 file

Re: [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU for igb devices

> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, March 26, 2019 10:18 PM > To: Zhang, Qi Z ; Yigit, Ferruh > ; > Stokes, Ian ; dev@dpdk.org > Cc: step...@networkplumber.org; Lu, Wenzhuo ; Xing, > Beilei > Subject: RE: [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max

Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector

Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, March 26, 2019 5:29 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector > > Hi, > > On 3/26/19 2:00 AM, Lu, Wenzhuo wrote:

Re: [dpdk-dev] How to use mlx4 as bond

Hi, 26/03/2019 16:36, chetan bhasin: > Hi, > > I am using DPDK 17.11.4 with a Mellanox ConnectX-3 Pro dual port card, one > of the features of this card is that both ports have the same PCI address. > i.e. there are two ports here but only one PCI reported: > > # lspci | grep -i mell > 0a:00.0 E

Re: [dpdk-dev] [RFC] eal: rename state values in rte_lcore_state

26/03/2019 20:25, Stephen Hemminger: > C language does not really treat enum's as first class symbols. > The values in an enum live in a global namespace. That means if > DPDK defines "RUNNING" it can't be used by another enum in an > application using DPDK. > > To solve this add a prefix "LCORE_

Re: [dpdk-dev] [PATCH v3 0/4] One versionfile to rule them all...

15/03/2019 19:20, Bruce Richardson: > Right now with DPDK we have two sources of version information - the > rte_version.h header file containing macros for C use, and the project > version number in the project definition in meson.build. This is not > optimal, so this patchset aims to provide a si

Re: [dpdk-dev] [PATCH v3 3/4] build: use version number from config file

15/03/2019 19:20, Bruce Richardson: > Since we have the version number in a separate file at the root level, > we should not need to duplicate this in rte_version.h too. Best > approach here is to move the macros for specifying the year/month/etc. > parts from the version header file to the build c

Re: [dpdk-dev] [PATCH] usertools: add octeontx2 SSO and NPA PCIe devices

26/02/2019 13:29, Jerin Jacob Kollanukkaran: > Add the Marvell's octeontx2's SSO and NPA PCIe devices as > eventdev, mempool devices in devbind script. > > Signed-off-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH] test: fix build when pdump config is disabled

20/03/2019 16:17, Rami Rosen: > pdump unit test has dependency on pthread code > in test.c and process.h to run send_pkts(), > this code should be enabled only when > CONFIG_RTE_LIBRTE_PDUMP is enabled. > > Bugzilla ID: 222 > > Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") > C

Re: [dpdk-dev] [PATCH] app/test-pipeline: fix missing dependency for FreeBSD build

25/03/2019 16:38, Bruce Richardson: > When building on FreeBSD, the compiler emitted an error due to being > unable to find rte_pci.h. This was due to missing dependencies for the > application. > > Fixes: 474572d2ae5a ("app/pipeline: move from test directory") > > Signed-off-by: Bruce Richardson

Re: [dpdk-dev] [PATCH] devtools: fix invalid config check when building tags

13/03/2019 16:09, Bruce Richardson: > The check for a valid configuration in build-tags.sh relied on the output > of "make showconfig" rather than checking directly for a config file of > that name. This broke when as part of the rename of the linuxapp/bsdapp > configs to just linux/freebsd, as we

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

27/03/2019 00:43, Jeff Shaw: > On Wed, Mar 27, 2019 at 12:00:49AM +0100, Thomas Monjalon wrote: > > 26/03/2019 23:34, Jeff Shaw: > > > On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > > > > 26/03/2019 22:54, Jeff Shaw: > > > > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Mon

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

On Wed, Mar 27, 2019 at 12:00:49AM +0100, Thomas Monjalon wrote: > 26/03/2019 23:34, Jeff Shaw: > > On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > > > 26/03/2019 22:54, Jeff Shaw: > > > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > > > > 26/03/2019 22:14

Re: [dpdk-dev] [PATCH v1] doc: update cross build tool links

11/03/2019 04:05, Joyce Kong: > Update cross build tool links as newer cross build tools > version are provided on Linaro, and attempts to download > the old one give permission denied. > > Fixes: 01add9da25cd ("doc: add cross compiling guide") > Cc: sta...@dpdk.org > > Signed-off-by: Joyce Kong

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

On 3/26/2019 9:46 AM, Bruce Richardson wrote: On Tue, Mar 26, 2019 at 03:35:36PM +, Jerin Jacob Kollanukkaran wrote: On Tue, 2019-03-26 at 14:40 +, Bruce Richardson wrote: It is painful due to the fact that, If it is windows ONLY file then developer need to test on Windows as well as it

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

26/03/2019 23:34, Jeff Shaw: > On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > > 26/03/2019 22:54, Jeff Shaw: > > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > > > 26/03/2019 22:14, Jeff Shaw: > > > > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Mon

Re: [dpdk-dev] [PATCH v5 1/8] eal: eal stub to add windows support

Acked-by: Omar Cardona -Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net Subje

Re: [dpdk-dev] [PATCH v5 0/8] HelloWorld example for windows

Acked-by: Omar Cardona -Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net Subje

Re: [dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

On 3/26/19 3:15 PM, Stephen Hemminger wrote: If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly modify the original copy. Original code was expecting clone to make a copy (it doesn't). Better to let the caller deal with making a copy or setting up mbuf chain to allow for header to be

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > 26/03/2019 22:54, Jeff Shaw: > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > > 26/03/2019 22:14, Jeff Shaw: > > > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > > > > Even better woul

Re: [dpdk-dev] [PATCH v2] meson: remove build warnings

19/03/2019 18:36, Luca Boccassi: > On Tue, 2019-03-19 at 17:22 +, Jerin Jacob Kollanukkaran wrote: > > From: Jerin Jacob > > > > Remove the following warning by comparing string to string. > > > > config/arm/meson.build:153: WARNING: Trying to compare values of > > different types (list, str

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

26/03/2019 22:54, Jeff Shaw: > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > 26/03/2019 22:14, Jeff Shaw: > > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > > > Even better would be to get it as a dependency outside of DPDK. > > > > Where this code com

Re: [dpdk-dev] [PATCH v5] build: move variable definition to top level

25/03/2019 11:34, Andrius Sirvys: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Defining driver_classes in dpdk/m

Re: [dpdk-dev] [PATCH] build: use integer for new max_ethports option too

01/03/2019 16:46, luca.bocca...@gmail.com: > From: Luca Boccassi > > max_ethports was merged after the other patch was written: > > e04ea7fcf03c ("build: use integers for numerical options") > > So convert this one too like the others have already been. > > Signed-off-by: Luca Boccassi Appli

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > 26/03/2019 22:14, Jeff Shaw: > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > > Even better would be to get it as a dependency outside of DPDK. > > > Where this code come from? > > > How other projects on Win

Re: [dpdk-dev] [PATCH v8] ci: Introduce travis builds for github repositories

25/03/2019 17:10, Thomas Monjalon: > 25/03/2019 16:32, Michael Santana: > > GitHub is a service used by developers to store repositories. GitHub > > provides service integrations that allow 3rd party services to access > > developer repositories and perform actions. One of these services is > > T

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

26/03/2019 22:14, Jeff Shaw: > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > Even better would be to get it as a dependency outside of DPDK. > > Where this code come from? > > How other projects on Windows get it? > > It comes from FreeBSD 12.0, specifically > https://gith

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > 26/03/2019 20:06, Stephen Hemminger: > > On Mon, 25 Mar 2019 23:02:34 -0700 > > Anand Rawat wrote: > > > > > +/*- > > > + * SPDX-License-Identifier: BSD-3-Clause > > > + * > > > + * Copyright (c) 1991, 1993 > > > + * The Reg

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

26/03/2019 20:06, Stephen Hemminger: > On Mon, 25 Mar 2019 23:02:34 -0700 > Anand Rawat wrote: > > > +/*- > > + * SPDX-License-Identifier: BSD-3-Clause > > + * > > + * Copyright (c) 1991, 1993 > > + * The Regents of the University of California. All rights reserved. > > + * > > + * Redistributio

Re: [dpdk-dev] [PATCH v3 13/13] net/mlx5: add source vport match to the ingress rules

Tuesday, March 26, 2019 5:35 PM, Viacheslav Ovsiienko: > Subject: [PATCH v3 13/13] net/mlx5: add source vport match to the ingress > rules > > For E-Switch configurations over multiport Infiniband devices we should add > source vport match to correctly distribute traffic between representors. > >

Re: [dpdk-dev] [PATCH v3 01/13] net/mlx5: add representor recognition on kernels 5.x

Tuesday, March 26, 2019 5:35 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v3 01/13] net/mlx5: add representor recognition > on kernels 5.x > > The master device and VF representors were distinguished by presence of > port name, master device did not have one. The new Linux kernels starti

Re: [dpdk-dev] [PATCH v3 05/13] net/mlx5: add IB shared context alloc/free functions

Tuesday, March 26, 2019 5:35 PM, Viacheslav Ovsiienko: > Subject: [PATCH v3 05/13] net/mlx5: add IB shared context alloc/free > functions > > The Mellanox NICs support SR-IOV and have E-Switch feature. > When SR-IOV is set up in switchdev mode and E-Switch is enabled we have > so called VF represe

Re: [dpdk-dev] [PATCH v2 3/3] net/mlx4: add secondary process support

Monday, March 25, 2019 9:18 PM, Yongseok Koh: > To: Shahaf Shuler > Cc: dev@dpdk.org > Subject: [PATCH v2 3/3] net/mlx4: add secondary process support > > In order to support secondary process, a few features are required. > > a) rdma-core library should allocate device resources using DPDK's me

[dpdk-dev] [RFC] eal: rename state values in rte_lcore_state

C language does not really treat enum's as first class symbols. The values in an enum live in a global namespace. That means if DPDK defines "RUNNING" it can't be used by another enum in an application using DPDK. To solve this add a prefix "LCORE_" to the enum values, and make them grammatically

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx4: add external allocator for Verbs object

Monday, March 25, 2019 9:18 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2 2/3] net/mlx4: add external allocator for > Verbs object > > To support secondary process, the memory allocated by library such as > completion rings (CQ) and buffer rings (WQ) must be manageable by EAL, in > order to sh

Re: [dpdk-dev] [PATCH v2 1/3] net/mlx4: change device reference for secondary process

Monday, March 25, 2019 9:18 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2 1/3] net/mlx4: change device reference for > secondary process > > rte_eth_devices[] is not shared between primary and secondary process, > but a static array to each process. The reverse pointer of device (priv->dev) >

[dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly modify the original copy. Original code was expecting clone to make a copy (it doesn't). Better to let the caller deal with making a copy or setting up mbuf chain to allow for header to be added. Also fix docbook comment about paramet

Re: [dpdk-dev] [PATCH v6 1/5] net/af_xdp: introduce AF XDP PMD driver

On Tue, 26 Mar 2019 20:20:25 +0800 Xiaolong Ye wrote: > +This Linux-specific PMD driver creates the AF_XDP socket and binds it to a > +specific netdev queue, it allows a DPDK application to send and receive raw > +packets through the socket which would bypass the kernel network stack. > +Current

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

On Mon, 25 Mar 2019 23:02:34 -0700 Anand Rawat wrote: > +/*- > + * SPDX-License-Identifier: BSD-3-Clause > + * > + * Copyright (c) 1991, 1993 > + * The Regents of the University of California. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without >

Re: [dpdk-dev] [PATCH v5 3/8] kvargs: adding a module definition file

On Mon, 25 Mar 2019 23:02:33 -0700 Anand Rawat wrote: > diff --git a/lib/librte_kvargs/rte_kvargs_exports.def > b/lib/librte_kvargs/rte_kvargs_exports.def > new file mode 100644 > index 0..265d3cc9a > --- /dev/null > +++ b/lib/librte_kvargs/rte_kvargs_exports.def > @@ -0,0 +1,7 @@ > +EXP

Re: [dpdk-dev] Aligned rte_mempool for storage applications

On 3/26/19, 11:34 AM, "Howell, Seth" wrote: Hi Vipin, Thanks for your quick reply. I will respond to your queries in order. 1. Yes, in at least one case we have buffers of size 4096 bytes. Some of our other buffers are much larger (>64KiB) 2. These buffers are used in the

[dpdk-dev] [PATCH] eal: initialize alarms early

We currently initialize rte_alarms after starting to listen for IPC hotplug requests, which gives us a data race window. Upon receiving such hotplug request we always try to set an alarm and this obviously doesn't work if the alarms weren't initialized yet. To fix it, we initialize alarms before s

Re: [dpdk-dev] Aligned rte_mempool for storage applications

Hi Vipin, Thanks for your quick reply. I will respond to your queries in order. 1. Yes, in at least one case we have buffers of size 4096 bytes. Some of our other buffers are much larger (>64KiB) 2. These buffers are used in the I/O path, so performance is very important. Allocating and freeing

Re: [dpdk-dev] [PATCH v5 7/8] doc: add documention for windows

On 3/26/2019 3:37 AM, David Marchand wrote: On Tue, Mar 26, 2019 at 7:04 AM Anand Rawat > wrote: Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Can you fix

Re: [dpdk-dev] [PATCH] net: fix Tx VLAN flag for offload emulation

On 3/26/19 12:50 PM, Ferruh Yigit wrote: On 3/25/2019 3:05 PM, Chas Williams wrote: From: Bill Hong A PMD might use rte_vlan_insert to implement Tx VLAN offload. Typically the PMD will insert the VLAN header in the transmit path and then attempt to send the packets. If this fails, the pack

Re: [dpdk-dev] [PATCH v6] net/kni: calc mbuf&mtu according to given mb_pool

On 3/26/2019 6:40 PM, lir...@marvell.com wrote: > From: Liron Himi > > - mbuf_size and mtu are now being calculated according > to the given mb-pool. > > - max_mtu is now being set according to the given mtu > > the above two changes provide the ability to work with jumbo frames > > Signed-off

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix tx qinq insert enable

Hi Nithin > Subject: [PATCH v2 2/2] app/testpmd: fix tx qinq insert enable > ./dpdk/devtools/check-git-log.sh -1 Wrong headline lowercase: app/testpmd: fix tx qinq insert enable The commit line does not seem correct as it is actually fixing the tx_qinq_set() function. Otherwise Ack

Re: [dpdk-dev] [PATCH] bnxt: fix receive VLAN offload flags

On 3/25/2019 9:34 PM, Ajit Khaparde wrote: > On Mon, Mar 25, 2019 at 2:28 PM Stephen Hemminger < > step...@networkplumber.org> wrote: > >> From: Stephen Hemminger >> >> The bnxt driver is not correctly setting the receive VLAN offload >> flags. When VLAN is offloaded the driver must set the PKT_R

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq dependency

Hi Nithin > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, March 21, 2019 5:11 PM > To: Nithin Kumar Dabilpuram ; Lu, Wenzhuo > ; Wu, Jingjing ; Iremonger, > Bernard > Cc: dev@dpdk.org; Wang, Xiao W > Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq >

Re: [dpdk-dev] [PATCH v3 01/15] app/testpmd: replace uint with unsigned int

Hi Nataneal, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Natanael Copa > Sent: Wednesday, March 13, 2019 5:07 PM > To: dev@dpdk.org > Cc: Natanael Copa > Subject: [dpdk-dev] [PATCH v3 01/15] app/testpmd: replace uint with > unsigned int This should have th

Re: [dpdk-dev] [PATCH] net: fix Tx VLAN flag for offload emulation

On 3/25/2019 3:05 PM, Chas Williams wrote: > From: Bill Hong > > A PMD might use rte_vlan_insert to implement Tx VLAN offload. Typically > the PMD will insert the VLAN header in the transmit path and then attempt > to send the packets. If this fails, the packets are returned to > the application

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

On Tue, Mar 26, 2019 at 03:35:36PM +, Jerin Jacob Kollanukkaran wrote: > On Tue, 2019-03-26 at 14:40 +, Bruce Richardson wrote: > > > It is painful due to the fact that, If it is windows ONLY file then > > > developer need to test on Windows as well as it may break Windows. > > > If it is a

Re: [dpdk-dev] [PATCH v5 8/8] build: meson changes to build on windows

-Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v5 7/8] doc: add documention for windows

-Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v5 5/8] eal: add headers for compatibility with windows environment

-Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v5 6/8] eal: add minimum viable code for eal on windows

-Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

-Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v5 3/8] kvargs: adding a module definition file

-Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows

-Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v5 1/8] eal: eal stub to add windows support

-Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.net Subject: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v6] net/kni: calc mbuf&mtu according to given mb_pool

From: Liron Himi - mbuf_size and mtu are now being calculated according to the given mb-pool. - max_mtu is now being set according to the given mtu the above two changes provide the ability to work with jumbo frames Signed-off-by: Liron Himi --- doc/guides/nics/kni.rst

Re: [dpdk-dev] [PATCH v5 0/8] HelloWorld example for windows

Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Monday, March 25, 2019 11:03 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.ne

Re: [dpdk-dev] [PATCH v4 1/2] app/testpmd: optimize testpmd txonly mode

Hi Pavan, > -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Tuesday, March 26, 2019 1:03 PM > To: Jerin Jacob Kollanukkaran ; tho...@monjalon.net; > arybche...@solarflare.com; Yigit, Ferruh ; > Iremonger, Bernard > Cc: dev@dpdk.org; Pavan N

Re: [dpdk-dev] [EXT] Re: [PATCH v2] eal: make max interrupt vectors configurable

On Tue, 2019-03-26 at 14:43 +, Bruce Richardson wrote: + Anatoly > > --- > --- > On Tue, Mar 26, 2019 at 03:04:58PM +0100, Thomas Monjalon wrote: > > 26/03/2019 14:21, Pavan Nikhilesh Bhagavatula: > > > From: Pavan Nikhilesh >

[dpdk-dev] [PATCH v3 8/8] ipsec: de-duplicate crypto op prepare code-path

For sym_crypto_op prepare move common code into a separate function(s). Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/esp_inb.c | 72 + lib/librte_ipsec/esp_outb.c | 57 +++-- 2 files changed, 80 insertions(+), 49 deletions(-)

[dpdk-dev] [PATCH v3 7/8] ipsec: reorder packet process for esp inbound

Change the order of operations for esp inbound post-process: - read mbuf metadata and esp tail first for all packets in the burst first to minimize stalls due to load latency. - move code that is common for both transport and tunnel modes into separate functions to reduce code duplication. - ad

[dpdk-dev] [PATCH v3 6/8] ipsec: reorder packet check for esp inbound

Right now check for packet length and padding is done inside cop_prepare(). It makes sense to have all necessary checks in one place at early stage: inside pkt_prepare(). That allows to simplify (and later hopefully) optimize cop_prepare() part. Signed-off-by: Konstantin Ananyev --- lib/librte_i

[dpdk-dev] [PATCH v3 5/8] ipsec: move inbound and outbound code into different files

sa.c becomes too big, so decided to split it into 3 chunks: - sa.c - control path related functions (init/fini, etc.) - esp_inb.c - ESP inbound packet processing - esp_outb.c - ESP outbound packet processing Plus few changes in internal function names to follow the same code convention. No func

[dpdk-dev] [PATCH v3 4/8] ipsec: change the way unprocessed mbufs are accounted

As was pointed in one of previous reviews - we can avoid updating contents of mbuf array for successfully processed packets. Instead store indexes of failed packets, to move them beyond the good ones later. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 166 +++

[dpdk-dev] [PATCH v3 3/8] ipsec: change the order in filling crypto op

Right now we first fill crypto_sym_op part of crypto_op, then in a separate cycle we fill crypto op fields. It makes more sense to fill whole crypto-op in one go instead. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 46 --- 1 file changed,

[dpdk-dev] [PATCH v3 2/8] ipsec: add Tx offload template into SA

Operations to set/update bit-fields often cause compilers to generate suboptimal code. To avoid such negative effect, use tx_offload raw value and mask to update l2_len and l3_len fields within mbufs. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 23 ++- lib/l

[dpdk-dev] [PATCH v3 1/8] mbuf: new function to generate raw Tx offload value

Operations to set/update bit-fields often cause compilers to generate suboptimal code. To help avoid such situation for tx_offload fields: introduce new enum for tx_offload bit-fields lengths and offsets, and new function to generate raw tx_offload value. Signed-off-by: Konstantin Ananyev --- li

Re: [dpdk-dev] [PATCH v3] crypto/aesni_mb: support newer version library only

On 3/26/2019 9:05 PM, Zhang, Roy Fan wrote: > Hi Akhil, > > I have discussed with Ferruh in relation to the updating release note > for this change. > However the change seems not apply to any section under the release note. > > The change does not introduce new feature, nor breaks ABI/API - > it

[dpdk-dev] [PATCH v3 0/8] Few small improvements for ipsec library

v3 -> v2 Address comments: - make rte_mbuf_tx_offload() always inline - rename OL[2,3]_LEN to OUTL[2,3]_LEN for better naming Add 'unused' parameter into rte_mbuf_tx_offload() for consistency Some code de-duplication v1 -> v2 Add patch to improve a bit esp inbound pkt_process code The fir

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

On Tue, 2019-03-26 at 14:40 +, Bruce Richardson wrote: > > It is painful due to the fact that, If it is windows ONLY file then > > developer need to test on Windows as well as it may break Windows. > > If it is a common file, at least, it will be tested on one > > platform. > > So responsibly w

[dpdk-dev] How to use mlx4 as bond

Hi, I am using DPDK 17.11.4 with a Mellanox ConnectX-3 Pro dual port card, one of the features of this card is that both ports have the same PCI address. i.e. there are two ports here but only one PCI reported: # lspci | grep -i mell 0a:00.0 Ethernet controller: Mellanox Technologies MT27520

[dpdk-dev] [PATCH v3 13/13] net/mlx5: add source vport match to the ingress rules

For E-Switch configurations over multiport Infiniband devices we should add source vport match to correctly distribute traffic between representors. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 36 1 file changed, 36 insertions(+)

[dpdk-dev] [PATCH v3 05/13] net/mlx5: add IB shared context alloc/free functions

The Mellanox NICs support SR-IOV and have E-Switch feature. When SR-IOV is set up in switchdev mode and E-Switch is enabled we have so called VF representors in the system. All representors belonging to the same E-Switch are created on the basis of the single PCI function and with current implement

[dpdk-dev] [PATCH v3 12/13] net/mlx5: update event handler for multiport IB devices

This patch modifies asynchronous event handler to support multiport Infiniband devices. Handler queries the event parameters, including event source port index, and invokes the handler for specific devices with appropriate port_id. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler ---

[dpdk-dev] [PATCH v3 11/13] net/mlx5: update install/uninstall int handler routines

We are implementing the support for multport Infiniband device withj representors attached to these multiple ports. Asynchronous device event notifications (link status change, removal event, etc.) should be shared between ports. We are going to implement shared event handler and this patch introdu

[dpdk-dev] [PATCH v3 08/13] net/mlx5: switch to the shared context IB attributes

The code is updated to use the shared IB device attributes, located in the shared IB context. It saves some memory if there are representors created over the single Infiniband device with multuple ports. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v3 10/13] net/mlx5: provide IB port for the object being created

The code is updated to provide IB port index for the Verbs objects being created - QPs and Verbs Flows. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 2 ++ drivers/net/mlx5/mlx5_flow_verbs.c | 1 + drivers/net/mlx5/mlx5_txq.c| 4 ++-

[dpdk-dev] [PATCH v3 09/13] net/mlx5: switch to the shared IB device context

The code is updated to use the shared IB device context and device handles. The IB device context is shared between reprentors created over the single multiport IB device. All Verbs and DevX objects will be created whithin this shared context. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf

[dpdk-dev] [PATCH v3 07/13] net/mlx5: switch to the shared Protection Domain

The PMD code is updated to use Protected Domain from the the shared IB device context. The Domain is shared between all devices belonging to the same multiport Infiniband device. If IB device has only one port, the PD is not shared, because there is only ethernet device created over IB one. Signed

[dpdk-dev] [PATCH v3 04/13] net/mlx5: add multiport IB device support to probing

mlx5_pci_probe() routine is refactored to probe the ports of found Infiniband devices. All active ports (with attached network interface), belonging to the same Infiniband device will use the signle shared Infiniband context of that device. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shu

[dpdk-dev] [PATCH v3 03/13] net/mlx5: add getting IB ports number for multiport IB

There is the routine mlx5_nl_portnum() added to get the number of ports of multiport Infiniband device. It is assumed the Uplink/VF representors are attached on these ports. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH v3 06/13] net/mlx5: switch to the names in the shared IB context

The IB device names are moved from device private data to the shared context, code involving the names is updated. The IB port index treatment is added where it is relevant. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h| 2 -- drivers/net/mlx5/

  1   2   >