[dpdk-dev] [PATCH v3] net/ixgbe: enable 10Mb/s link setup for x553

2019-03-31 Thread Wei Zhao
This patch enable 10Mb/s link for ixgbe x553. This new device has own device id of 0x15E4 and 0x15E5, so ixgbe PMD driver need to special check when setup link for these two types of device. Signed-off-by: Wei Zhao --- v2: delete test code and change permit link speed V3: update git log info -

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-31 Thread David Marchand
On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon wrote: > 19/03/2019 19:04, Ferruh Yigit: > > On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > > >>> +uint16_t __rte_experimental > > >> > > >> Do we need _rte_experimental on function definitions? I guess only in > .h file, > > >> function declaration

Re: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for x553

2019-03-31 Thread Zhao1, Wei
> -Original Message- > From: Stillwell Jr, Paul M > Sent: Saturday, March 30, 2019 2:47 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhang, Qi Z > ; Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for > x553 > > > > -O

Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE

2019-03-31 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, March 31, 2019 11:52 PM > To: Yigit, Ferruh ; Lu, Wenzhuo > ; Zhang, Qi Z > Cc: dev@dpdk.org; O'Hare, Cathal ; Mcnamara, > John > Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector in

Re: [dpdk-dev] [PATCH v4 00/38] ice share code update.

2019-03-31 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, April 1, 2019 1:06 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > ; Stillwell Jr, Paul M ; > Yigit, Ferruh ; O'Hare, Cathal > ; > Mcnamara, John > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v7 0/2] guide to debug and troubleshoot.

2019-03-31 Thread Varghese, Vipin
Hi John and Marko, Waiting for updates for changes if any, as these are not pushed for 19.02. Please do let me know if there are changes required any more? Thanks Vipin Varghese > -Original Message- > From: Varghese, Vipin > Sent: Monday, February 25, 2019 10:42 PM > To: Mcnamara, John

Re: [dpdk-dev] [PATCH v3] app/pdump: enhance to support multi-core capture

2019-03-31 Thread Varghese, Vipin
Hi Reshma & Ferruh, Summarizing the discussion with maintainer and proposed changes below. 1. Agreed to make changes for migrating 'strlcpy' to 'rte_strlcpy'. 2. Agreed to make changes for spelling error. 3. Informed it is user decision to enable multiple core capture for queue-pair. 4. Informed

[dpdk-dev] [PATCH v3 3/4] net/mlx5: use port sibling iterators

2019-03-31 Thread Thomas Monjalon
Iterating over siblings was done with RTE_ETH_FOREACH_DEV() which skips the owned ports. The new iterators RTE_ETH_FOREACH_DEV_SIBLING() and RTE_ETH_FOREACH_DEV_OF() are more appropriate and more correct. Signed-off-by: Thomas Monjalon --- drivers/net/mlx5/mlx5.c| 34 +---

[dpdk-dev] [PATCH v3 4/4] app/testpmd: use port sibling iterator in device cleanup

2019-03-31 Thread Thomas Monjalon
When removing a rte_device on a port-based request, all the sibling ports must be marked as closed. The iterator loop can be simplified by using the dedicated macro. Signed-off-by: Thomas Monjalon --- app/test-pmd/testpmd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/a

[dpdk-dev] [PATCH v3 1/4] ethdev: simplify port state comparisons

2019-03-31 Thread Thomas Monjalon
There are three states for an ethdev port. Checking that the port is unused looks simpler than checking it is neither attached nor removed. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[dpdk-dev] [PATCH v3 2/4] ethdev: add siblings iterators

2019-03-31 Thread Thomas Monjalon
If multiple ports share the same hardware device (rte_device), they are siblings and can be found thanks to the new functions and loop macros. One iterator takes a port id as reference, while the other one directly refers to the parent device. The ownership is not checked because siblings may have

[dpdk-dev] [PATCH v3 0/4] ethdev iterators for multi-ports device

2019-03-31 Thread Thomas Monjalon
Add port iterators in order to allow listing easily the ports of the same device. The iterators can be tested by using mlx5 or testpmd. v3: changes only in the (main) patch 2 Thomas Monjalon (4): ethdev: simplify port state comparisons ethdev: add siblings iterators net/mlx5: use port si

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-31 Thread Thomas Monjalon
19/03/2019 19:04, Ferruh Yigit: > On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > >>> +uint16_t __rte_experimental > >> > >> Do we need _rte_experimental on function definitions? I guess only in .h > >> file, > >> function declaration is enough. > > > > Yes we need them both in .h and .c files. >

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-31 Thread Thomas Monjalon
27/02/2019 11:51, Thomas Monjalon: > 27/02/2019 11:07, Gaƫtan Rivet: > > On Wed, Feb 20, 2019 at 11:10:49PM +0100, Thomas Monjalon wrote: > > > +uint16_t __rte_experimental > > > +rte_eth_find_next_of(uint16_t port_id, const struct rte_device *parent) > > > +{ > > > + while (port_id < RTE_MAX_ETHPO

[dpdk-dev] [PATCH v5 7/8] test/stack: add lock-free stack tests

2019-03-31 Thread Gage Eads
This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz ---

[dpdk-dev] [PATCH v5 8/8] mempool/stack: add lock-free stack mempool handler

2019-03-31 Thread Gage Eads
This commit adds support for lock-free (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the lock-free handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a standard (lock-based)

[dpdk-dev] [PATCH v5 6/8] stack: add C11 atomic implementation

2019-03-31 Thread Gage Eads
This commit adds an implementation of the lock-free stack push, pop, and length functions that use __atomic builtins, for systems that benefit from the finer-grained memory ordering control. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- lib/librte_stack/Makefile | 3 +- lib

[dpdk-dev] [PATCH v5 1/8] stack: introduce rte stack library

2019-03-31 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

[dpdk-dev] [PATCH v5 4/8] test/stack: add stack perf test

2019-03-31 Thread Gage Eads
stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH v5 3/8] test/stack: add stack test

2019-03-31 Thread Gage Eads
stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 1 + app/test/Makefile | 2 + app/test/meson.build | 3 +

[dpdk-dev] [PATCH v5 5/8] stack: add lock-free stack implementation

2019-03-31 Thread Gage Eads
This commit adds support for a lock-free (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, RTE_STACK_F_LF. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counte

[dpdk-dev] [PATCH v5 0/8] Add stack library and new mempool handler

2019-03-31 Thread Gage Eads
This patchset introduces a stack library, supporting both lock-based and lock-free stacks, and a lock-free stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The lock-free stack mempool hand

[dpdk-dev] [PATCH v5 2/8] mempool/stack: convert mempool to use rte stack

2019-03-31 Thread Gage Eads
The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 2 +- drivers/mempool/stack/Makef

Re: [dpdk-dev] [PATCH v3 6/8] stack: add C11 atomic implementation

2019-03-31 Thread Eads, Gage
> -Original Message- > From: Eads, Gage > Sent: Friday, March 29, 2019 2:25 PM > To: Honnappa Nagarahalli ; > dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; Gavin Hu (Arm Technology China) > ; nd ; tho...@monjalon.net;

Re: [dpdk-dev] [pull-request] next-qos 19.05 PRE-RC1

2019-03-31 Thread Thomas Monjalon
29/03/2019 21:02, Cristian Dumitrescu: > http://dpdk.org/git/next/dpdk-next-qos Pulled, thanks

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq dependency

2019-03-31 Thread Nithin Kumar Dabilpuram
Hi Ferruh Yigit, Sorry, missed to see your inline comment about the check in v1. >> @@ tx_vlan_set(portid_t port_id, uint16_t vlan_id) >> if (vlan_id_is_invalid(vlan_id)) >> return; >> >> -vlan_offload = rte_eth_dev_get_vlan_offload(port_id); >> -if (vlan_offload & ETH

Re: [dpdk-dev] [PATCH v4 00/38] ice share code update.

2019-03-31 Thread Thomas Monjalon
25/03/2019 08:07, Zhang, Qi Z: > > Sync to latest kernel driver, main changes: > > 1. add DCB/FDIR support. > > 2. add more APIs in switch module. > > 3. code clean and bug fix. > > > > Qi Zhang (38): > > net/ice/base: add switch resource allocation and free > > net/ice/base: improve comments

[dpdk-dev] [PATCH] ethdev: fix DMA zone reserve not honoring size

2019-03-31 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh The `rte_eth_dma_zone_reserve()` is generally used to create HW rings. In some scenarios when a driver needs to reconfigure the ring size since the named memzone already exists it returns the previous memzone without checking if a different sized ring is requested. Introduc

Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE

2019-03-31 Thread Thomas Monjalon
26/03/2019 10:50, Ferruh Yigit: > > Wenzhuo Lu (8): > > net/ice: fix Tx function setting > > net/ice: add pointer for queue buffer release > > net/ice: support vector SSE in RX > > net/ice: support Rx scatter SSE vector > > net/ice: support Tx SSE vector > > net/ice: support Rx AVX2 vec

[dpdk-dev] [PATCH v3] eal: increase max number of interrupt vectors

2019-03-31 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh MSI-X permits a device to allocate up to 2048 interrupts as per PCIe spec. Increase the max number of vectors to a reasonable value of 512. Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Instead of making it a configurable option set max vectors to a reasonable value

Re: [dpdk-dev] [PATCH v2 00/15] Add patch set for IPN3KE

2019-03-31 Thread Xu, Rosen
Hi Ferruh, My reply is online. > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, March 30, 2019 2:59 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang > Subject: Re: [PATCH v2 00/15] Add

[dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode

2019-03-31 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Optimize testpmd txonly mode by 1. Moving per packet ethernet header copy above the loop. 2. Use bulk ops for allocating segments instead of having a inner loop for every segment. Also, move the packet prepare logic into a separate function so that it can be reused later.

[dpdk-dev] [PATCH v5 2/2] app/testpmd: add mempool bulk get for txonly mode

2019-03-31 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Use mempool bulk get ops to alloc burst of packets and process them. If bulk get fails fallback to rte_mbuf_raw_alloc. Tested-by: Yingya Han Suggested-by: Andrew Rybchenko Signed-off-by: Pavan Nikhilesh --- app/test-pmd/txonly.c | 37 ++--

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: add actions to modify TCP header fields

2019-03-31 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Adrien Mazarguil > Sent: Friday, March 29, 2019 4:59 PM > To: Dekel Peled > Cc: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; Yongseok Koh ; > Shahaf Shuler ; dev@dpdk.org; Ori Kam > > Subject: Re: [PATCH 2/3] app/t

Re: [dpdk-dev] [PATCH 1/3] ethdev: add actions to modify TCP header fields

2019-03-31 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Adrien Mazarguil > Sent: Friday, March 29, 2019 4:59 PM > To: Dekel Peled > Cc: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; Yongseok Koh ; > Shahaf Shuler ; dev@dpdk.org; Ori Kam > > Subject: Re: [PATCH 1/3] ethde

Re: [dpdk-dev] [PATCH v6 4/5] net/af_xdp: use mbuf mempool for buffer management

2019-03-31 Thread Ye Xiaolong
Hi, Olivier Thanks for the comments. On 03/29, Olivier Matz wrote: >Hi Xiaolong, > >On Tue, Mar 26, 2019 at 08:20:28PM +0800, Xiaolong Ye wrote: >> Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf >> allocated from rte_mempool can be converted to xdp_desc's address and >> vice

Re: [dpdk-dev] [PATCH v3] app/eventdev: add option to set global dequeue tmo

2019-03-31 Thread Jerin Jacob Kollanukkaran
On Fri, 2019-03-29 at 07:11 +, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Add option to provide a global dequeue timeout that is used to create > the eventdev. > The dequeue timeout provided will be common across all the worker > ports. If the eventdev hardware supports po

[dpdk-dev] [PATCH] rte_ethdev: fix typos in error log message

2019-03-31 Thread Dekel Peled
Correct minor typing mistake: pre-queue ==> per-queue Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled --- lib/librte_ethdev/rte_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eth

[dpdk-dev] [PATCH] app/testpmd: fix typo in comment

2019-03-31 Thread Dekel Peled
Correct minor typing mistake: then ==> the Fixes: 79bec05b32b7 ("app/testpmd: add ability to split outgoing packets") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/app/test

[dpdk-dev] [PATCH] doc: fix typos in testpmd user guide

2019-03-31 Thread Dekel Peled
Correct typing mistakes in several places. 1) "Those command will" ==> "These commands will" 2) icmp6_nd_opt_sla_eth ==> icmp6_nd_opt_tla_eth (change 's' to 't' for 'target' where applicable) Fixes: 1960be7d32f8 ("app/testpmd: add VXLAN encap/decap") Cc: sta...@dpdk.org Signed-off-by: Dekel Pe

[dpdk-dev] [PATCH] doc: fix typos in mlx5 doc

2019-03-31 Thread Dekel Peled
Correct typing mistakes: appiled ==> applied tarffic ==> traffic Fixes: 0280f2812284 ("doc: add mlx5 E-Switch VXLAN tunnels limitations") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled --- doc/guides/nics/mlx5.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/gui

[dpdk-dev] [PATCH] net/mlx5: fix typos in comments

2019-03-31 Thread Dekel Peled
Correct typing mistake in several locations: ernno ==> errno Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.c | 14 +++--- drivers/net/mlx5/mlx5_flow_dv.c| 6 +++--- d

[dpdk-dev] [PATCH v2] mem: limit use of address hint

2019-03-31 Thread Shahaf Shuler
patch[1] added an address hint as starting address for 64 bit systems in case an explicit base virtual address was not set by the user. The justification for such hint was to help devices that work in VA mode and has a address range limitation to work smoothly with the eal memory subsystem. While