[dpdk-dev] [PATCH v1 1/2] app: update usage field

2019-05-06 Thread Vipin Varghese
Usage option q is reflect how many port-queue pair can run per lcore. In l2fwd, l2fwd-crypto, l2fwd-jobstats, and l2fwd-keepalive both RX and TX are configured to be one. Signed-off-by: Vipin Varghese --- examples/l2fwd-crypto/main.c| 2 +- examples/l2fwd-jobstats/main.c | 2 +- examples/l2

[dpdk-dev] [PATCH v1 2/2] doc: update usage field for port-queue

2019-05-06 Thread Vipin Varghese
Usage option q is reflect how many port-queue pair can run per lcore. Updating usage field to refelct port-queue is done for one RX and TX only. Signed-off-by: Vipin Varghese --- doc/guides/sample_app_ug/l2_forward_crypto.rst | 4 +++- doc/guides/sample_app_ug/l2_forward_job_stats.rst|

[dpdk-dev] [PATCH v1 2/2] doc: update usage field for port-queue

2019-05-06 Thread Vipin Varghese
Usage option q is reflect how many port-queue pair can run per lcore. Updating usage field to refelct port-queue is done for one RX and TX only. Signed-off-by: Vipin Varghese --- doc/guides/sample_app_ug/l2_forward_crypto.rst | 4 +++- doc/guides/sample_app_ug/l2_forward_job_stats.rst|

[dpdk-dev] [PATCH v2] net/ice: set min and max MTU

2019-05-06 Thread Qi Zhang
This commit sets the min and max supported MTU values for ice devices via the ice_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Qi Zhang --- v2: - fix typo drivers/net

Re: [dpdk-dev] [PATCH v9 2/4] test/rcu_qsbr: add API and functional tests

2019-05-06 Thread Honnappa Nagarahalli
Summary of discussions with David. I am not able to reproduce the 'Test Fail' issue. However, log indicates an issue in the test code. David has validated the patch and I will send it out soon. The test case taking long time to complete happens when the code is compiled with '-O0 -g', but the t

[dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name

2019-05-06 Thread Yongseok Koh
Currently, the name of MPRQ mempool is set by snprintf(name, sizeof(name), "%s-mprq", dev->device->name); For port representor, the name is duplicate of its master and failed to create such a mempool having the same name. Port ID is used in the name instead. Fixes: 7d6bf6b866b8 ("net/mlx5:

Re: [dpdk-dev] [PATCH] net/ice: set min and max MTU

2019-05-06 Thread Zhang, Qi Z
> -Original Message- > From: Stillwell Jr, Paul M > Sent: Tuesday, May 7, 2019 1:39 AM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; Yang, Qiming > Cc: Stokes, Ian ; Yigit, Ferruh > ; > dev@dpdk.org; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH] net/ice: set min and max MTU > > > > -Origi

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension

2019-05-06 Thread Yongseok Koh
> On May 3, 2019, at 10:50 AM, Yongseok Koh wrote: > >> I think this change might have an impact on the existing users. Does this >> change need to be documented somewhere (at least in the release notes)? > > Practically, there would be no impact. Even if user's app makes use of crypto > instr

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-06 Thread Yongseok Koh
> On May 3, 2019, at 3:13 PM, Dharmik Thakkar wrote: > > Hi Yongseok, > Thank you for the patch! I have tested it on Bluefield reference platform. It > works fine. Thanks for your testing. > One observation: > Even though I used 'make config T=arm64-bluefield-linuxapp-gcc’, > at the end of t

[dpdk-dev] [PATCH] doc: update release notes for timer library changes

2019-05-06 Thread Erik Gabriel Carrillo
Signed-off-by: Erik Gabriel Carrillo --- doc/guides/rel_notes/release_19_05.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index 5044ac7..f4457ac 100644 --- a/doc/guides/rel_notes/release_19_05.rst +

[dpdk-dev] [PATCH] test: call timer subsystem finalize at exit

2019-05-06 Thread Erik Gabriel Carrillo
The eal_flags_autotest checks that no hugepage map files are left behind after a process exits, which can only be the case if all allocations made from DPDK heaps were freed back to the freelist, resulting in the hugepage map files being unlinked automatically. Add a call to rte_timer_subsystem_fi

[dpdk-dev] about IOVA and namespace in DPDK 19.05

2019-05-06 Thread Robert Nie
Hello, I am take a trial on AF_XDP feature of 19.05-rc2. I encountered two problems. One is about "iova-mode", another is about attaching bpf prog onto interface of specified namespace (probably new feature?) I created a VM using uvt-tool, release=eoan, cpu=8, mem=8G, with host-passthrough ena

[dpdk-dev] [PATCH v2 3/4] test: change memory barrier variables to uint64_t

2019-05-06 Thread David Christensen
Memory barrier failures can be intermittent. Increase the size of the sum/val/iteration variables to allow tests that can run for days so that sporadic errors can be identified. Signed-off-by: David Christensen --- v2: * Removed change to ITER_MAX app/test/test_barrier.c | 23 --

[dpdk-dev] [PATCH v2 1/4] test: fix typo in print statement

2019-05-06 Thread David Christensen
Change "much" to "match" in a printf. Signed-off-by: David Christensen --- v2: * None app/test/test_barrier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c index 82b572c..c219d56 100644 --- a/app/test/test_barrier.c +++ b/a

[dpdk-dev] [PATCH v2 2/4] test: verify calloc succeeded for sum variable

2019-05-06 Thread David Christensen
Code tested calloc failures for pt & lpt variables but not for the sum variable. Add a test for calloc failure of sum. Signed-off-by: David Christensen --- v2: * Removed change to ITER_MAX app/test/test_barrier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_

[dpdk-dev] [PATCH v2 4/4] test: fix memory barrier test failure on power CPUs

2019-05-06 Thread David Christensen
The memory barrier test fails on IBM Power 9 systems. Add additional barriers to accommodate the weakly ordered model used on Power CPUs. Signed-off-by: David Christensen --- v2: * Removed ifdef's for PPC since the rte_smp_*mb() macros are already customized for each CPU architecture app/tes

Re: [dpdk-dev] [PATCH 4/4] test: fix memory barrier test failure on power CPUs

2019-05-06 Thread David Christensen
-#define ITER_MAX 0x1 +#define ITER_MAX 0x100 This is a revert of a change done in patch 3. I'll fix and resubmit. @@ -92,12 +92,19 @@ struct lcore_plock_test { other = self ^ 1; l->flag[self] = 1; +#ifdef RTE_ARCH_PPC_64 + rte_smp_wmb(); +#endi

Re: [dpdk-dev] [PATCH] net/ice: set min and max MTU

2019-05-06 Thread Stillwell Jr, Paul M
> -Original Message- > From: dev On Behalf Of Qi Zhang > Sent: Saturday, May 4, 2019 2:46 AM > To: Lu, Wenzhuo ; Yang, Qiming > > Cc: Stokes, Ian ; Yigit, Ferruh > ; > dev@dpdk.org; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH] net/ice: set min and max MTU > > This commit sets the min an

Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression

2019-05-06 Thread Neil Horman
On Mon, May 06, 2019 at 02:56:51PM +0200, David Marchand wrote: > On Fri, May 3, 2019 at 7:16 PM David Marchand > wrote: > > > On Fri, May 3, 2019 at 5:18 PM Neil Horman wrote: > > > >> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote: > >> > Even if rare, the check script should h

Re: [dpdk-dev] [PATCH v2] ipc: unlock on failure

2019-05-06 Thread David Marchand
On Mon, May 6, 2019 at 3:48 PM Aaron Conole wrote: > Reported by Coverity. > > Coverity issue: 340076 Fixes: a2a06860b8c4 ("ipc: fix memory leak on request failure") > Cc: Herakliusz Lipiec > Cc: sta...@dpdk.org > Cc: Anatoly Burakov > Signed-off-by: Aaron Conole > --- > lib/librte_eal/commo

[dpdk-dev] [PATCH v2] ipc: unlock on failure

2019-05-06 Thread Aaron Conole
Reported by Coverity. Fixes: a2a06860b8c4 ("ipc: fix memory leak on request failure") Cc: Herakliusz Lipiec Cc: sta...@dpdk.org Cc: Anatoly Burakov Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_proc.c | 34 + 1 file changed, 18 insertions(+), 16 delet

Re: [dpdk-dev] [PATCH] ipc: unlock on failure

2019-05-06 Thread Aaron Conole
David Marchand writes: > On Mon, May 6, 2019 at 3:11 PM Aaron Conole wrote: > > Reported by Coverity. > > Fixes: a2a06860b8c4 ("ipc: fix memory leak on request failure") > Cc: Herakliusz Lipiec > Cc: sta...@dpdk.org > Cc: Anatoly Burakov > Signed-off-by: Aaron Conole > --- > lib/libr

Re: [dpdk-dev] [PATCH] ipc: unlock on failure

2019-05-06 Thread David Marchand
On Mon, May 6, 2019 at 3:11 PM Aaron Conole wrote: > Reported by Coverity. > > Fixes: a2a06860b8c4 ("ipc: fix memory leak on request failure") > Cc: Herakliusz Lipiec > Cc: sta...@dpdk.org > Cc: Anatoly Burakov > Signed-off-by: Aaron Conole > --- > lib/librte_eal/common/eal_common_proc.c | 4

[dpdk-dev] [PATCH] ipc: unlock on failure

2019-05-06 Thread Aaron Conole
Reported by Coverity. Fixes: a2a06860b8c4 ("ipc: fix memory leak on request failure") Cc: Herakliusz Lipiec Cc: sta...@dpdk.org Cc: Anatoly Burakov Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_proc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib

[dpdk-dev] [Bug 276] rte_rand() bit 31 and 63 are always zero

2019-05-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=276 Bug ID: 276 Summary: rte_rand() bit 31 and 63 are always zero Product: DPDK Version: 19.05 Hardware: All OS: All Status: CONFIRMED Severity: normal Prior

Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression

2019-05-06 Thread David Marchand
On Fri, May 3, 2019 at 7:16 PM David Marchand wrote: > On Fri, May 3, 2019 at 5:18 PM Neil Horman wrote: > >> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote: >> > Even if rare, the check script should handle removing a section. >> > >> > Fixes: 4bec48184e33 ("devtools: add checks

Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support

2019-05-06 Thread Igor Russkikh
>>> >>> The hw->allow_unsupported_sfp is used too late in >>> https://git.dpdk.org/next/dpdk-next-net-intel/tree/drivers/net/ixgbe/b >>> ase/ixgbe_phy.c#n1530 And if we've already got out earlier in >>> https://git.dpdk.org/next/dpdk-next-net-intel/tree/drivers/net/ixgbe/b >>> ase/ixgbe_phy.c#n150

Re: [dpdk-dev] [RFC v5] /net: memory interface (memif)

2019-05-06 Thread Damjan Marion (damarion)
> On 6 May 2019, at 13:00, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES > at Cisco) wrote: > > > > From: Honnappa Nagarahalli > Sent: Friday, May 3, 2019 6:27 AM > To: Jakub Grajciar; Ferruh Yigit; dev@dpdk.org; Honnappa Nagarahalli > Cc: nd; n

Re: [dpdk-dev] [RFC v5] /net: memory interface (memif)

2019-05-06 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
From: Honnappa Nagarahalli Sent: Friday, May 3, 2019 6:27 AM To: Jakub Grajciar; Ferruh Yigit; dev@dpdk.org; Honnappa Nagarahalli Cc: nd; nd Subject: RE: [dpdk-dev] [RFC v5] /net: memory interface (memif) > On 3/22/2019 11:57 AM, Jakub Grajciar wrote: > >

[dpdk-dev] [PATCH] examples/ip_fragmentation: fix Tx queues init

2019-05-06 Thread Ali Alnubani
The application tries to configure queue ids larger than the maximum allowed by MAX_TX_QUEUE_PER_PORT. This causes the startup error: " ... Initializing port 0 on lcore 0... Address:7C:FE:90:12:23:0D txq=0,0 txq=1,1 txq=2,2 txq=3,3 txq=4,4 txq=5,5 txq=6,6 txq=7,7 txq=8,8 txq=9,9 txq=10,10

[dpdk-dev] [PATCH v2] doc: remove redundant information from the guide

2019-05-06 Thread Vipin Varghese
Remove redundant information from section Performance issue isolation. Re-word for section header for packet capture. Signed-off-by: Vipin Varghese V2: - correct spelling for redundant - Vipin Varghese --- doc/guides/howto/debug_troubleshoot.rst | 8 ++-- 1 file changed, 2 insertions(+), 6

[dpdk-dev] [PATCH] net/fm10k: advertise supported RSS hash function

2019-05-06 Thread Xiao Wang
PMD should advertise supported RSS hash functions via dev_info.flow_type_rss_offloads variable [1], otherwise upper level check would fail on configuring RSS, leading to MQ RSS failure. [1] commit aa1a6d87f15d ("ethdev: force RSS offload rules again") Cc: sta...@dpdk.org Signed-off-by: Xiao Wang

[dpdk-dev] [PATCH] examples/ip_fragmentation: fix Tx queues init

2019-05-06 Thread Ali Alnubani
The application tries to configure queue ids larger than the maximum allowed by MAX_TX_QUEUE_PER_PORT. This causes the startup error: " ... Initializing port 0 on lcore 0... Address:7C:FE:90:12:23:0D txq=0,0 txq=1,1 txq=2,2 txq=3,3 txq=4,4 txq=5,5 txq=6,6 txq=7,7 txq=8,8 txq=9,9 txq=10,10

[dpdk-dev] [PATCH 2/2] doc: update recommended versions for i40e

2019-05-06 Thread Lijuan Tu
add recommended DPDK/kernel driver/firmware version matching list for i40e for 19.02 Signed-off-by: Lijuan Tu --- doc/guides/nics/i40e.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 2e9ec79..a97484c 100644 --- a/doc/guides/nics

[dpdk-dev] [PATCH 1/2] doc: add tested Intel platforms with Intel NICs

2019-05-06 Thread Lijuan Tu
Add tested Intel platforms with Intel NICs to v19.05 release note. Signed-off-by: Lijuan Tu --- doc/guides/rel_notes/release_19_05.rst | 88 ++ 1 file changed, 88 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-05-06 Thread Andrew Rybchenko
On 5/4/19 11:45 PM, Thomas Monjalon wrote: 02/05/2019 22:27, Thomas Monjalon: 02/05/2019 20:31, Ferruh Yigit: On 4/29/2019 10:52 AM, Thomas Monjalon wrote: 25/04/2019 17:27, Ferruh Yigit: On 4/25/2019 2:29 PM, Thomas Monjalon wrote: 25/04/2019 13:47, Ferruh Yigit: On 4/25/2019 9:19 AM, Thom

[dpdk-dev] [Bug 265] i40e flow flush & add new flow will occur segfault

2019-05-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=265 Bug ID: 265 Summary: i40e flow flush & add new flow will occur segfault Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: major

Re: [dpdk-dev] [PATCH v3 0/5] prepare to make lcore_config not visible in ABI

2019-05-06 Thread David Marchand
On Fri, May 3, 2019 at 7:25 PM Stephen Hemminger wrote: > This set of patches makes the lcore_config structure less visible > as part of the ABI. This version does not break the ABI (yet) > follow on patch moves lcore_config into eal_private.h > > Changes for v3 (based on David's feedback): >