[dpdk-dev] [PATCH v3] eal: remove non-thread panic calls from init sequence

This patch changes some void functions to return a value, so that the init sequence may tear down orderly instead of calling panic. The calls for launching core messaging threads were left in tact in all 3 eal implementations. This should be addressed in a different patchset. There are still cases

Re: [dpdk-dev] [PATCH 24/25] net/ena: fix direct access to shared memory config

On 29.05.2019 18:31, Anatoly Burakov wrote: The ENA driver calculates a ring's NUMA node affinity by directly accessing the memzone list. Fix it to do it through the public API's instead. Signed-off-by: Anatoly Burakov --- drivers/net/ena/ena_ethdev.c | 18 +++--- 1 file changed,

Re: [dpdk-dev] [PATCH v3] eal: remove non-thread panic calls from init sequence

Hello, Thanks for looking at this. First round of review, there is still something fishy about mem_cfg_fd in secondary process implementation for Linux to me. Maybe Anatoly can review this patch as well. On Mon, Jun 3, 2019 at 9:21 AM Arnon Warshavsky wrote: > This patch changes some void fun

[dpdk-dev] [PATCH 1/2] net/i40e: fix dropped packets statistics name

i40e and i40evf currently use two different names for the statistic on dropped packets on the rx and tx sides. Let's prefer i40evf so that all statistics are suffixed with _packets. This also avoids a statistic name conflict in OVS. Fixes: f4a91c38b4ad ("i40e: add extended stats") Cc: sta...@dpdk

[dpdk-dev] [PATCH 2/2] net/ice: fix dropped packets statistics name

Copy/paste from i40e, let's align with the fix on i40e. Fixes: a37bde56314d ("net/ice: support statistics") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/d

Re: [dpdk-dev] [PATCH] app/test: add unit test cases for mbuf library APIs

Hi Lavanya, Please find some comments inline. On Mon, Apr 15, 2019 at 01:40:15PM +0100, Lavanya Govindarajan wrote: > added new unit test cases for > rte_validate_tx_offload, > rte_pktmbuf_alloc_bulk, > rte_pktmbuf_read, > rte_pktmbuf_ext_shinfo_init_helper, > rte_pktmbuf_attach_extbuf, > rte_mbu

[dpdk-dev] [PATCH 0/6] rawdev driver for ntb

This patch set adds support for Intel NTB device with Skylake platform. It is a raw device for allowing two hosts to communicate with each other and access the peer memory. This patch set also provides a simple example to transmit a file between two hosts. But since there is no FIFO here, only sup

[dpdk-dev] [PATCH 5/6] usertools/dpdk-devbind.py: add support for ntb

In order to allow binding/unbinding of devices for use by the ntb_rawdev, we need to update the devbind script to add a new class of device, and add device ids for the specific HW instances. And only support skx platform right now. Signed-off-by: Xiaoyun Li --- usertools/dpdk-devbind.py | 9

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix positive error codes from probe/remove

On Thu, May 30, 2019 at 3:26 PM Ilya Maximets wrote: > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' and their > 'hotplug' equivalents must return 0 or negative error code. Bus code > About this first part, existing callers in dpdk are not consistent with the api which might explain

[dpdk-dev] [PATCH 6/6] doc: update docs for ntb pmd

Update related documents for ntb pmd and example. Signed-off-by: Xiaoyun Li --- MAINTAINERS| 8 + doc/guides/rawdevs/index.rst | 1 + doc/guides/rawdevs/ntb_rawdev.rst | 25 ++ doc/guides/rel_notes/release_19_08.rst | 16 + doc

[dpdk-dev] [PATCH 4/6] examples/ntb: enable an example for ntb

Enable an example for rawdev ntb. Support interactive mode to send file on one host and receive file from another host. The command line would be 'send [filepath]' and 'receive [filepath]'. But since the FIFO is not enabled right now, use rte_memcpy as the enqueue and dequeue functions and only su

[dpdk-dev] [PATCH 2/6] raw/ntb: add intel ntb support

Add in the list of registers for the device. And enable ntb device ops for intel skylake platform. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/Makefile | 1 + drivers/raw/ntb_rawdev/meson.build| 3 +- drivers/raw/ntb_rawdev/ntb_hw_intel.c | 373 ++

[dpdk-dev] [PATCH 3/6] raw/ntb: add handshake process

Add handshake process using doorbell so that two hosts can communicate to start and stop. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/ntb_rawdev.c | 276 1 file changed, 276 insertions(+) diff --git a/drivers/raw/ntb_rawdev/ntb_rawdev.c b/drivers/raw/ntb_r

[dpdk-dev] [PATCH 1/6] raw/ntb: introduce ntb rawdev driver

Introduce rawdev driver support for NTB (Non-transparent Bridge) which can help to connect two separate hosts with each other. Signed-off-by: Xiaoyun Li --- config/common_base| 5 + drivers/raw/Makefile | 1 + drivers/raw/meson.build

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/i40e: fix dropped packets statistics name

Looks good to me… Acked-by: Eelco Chaudron On 3 Jun 2019, at 10:31, David Marchand wrote: i40e and i40evf currently use two different names for the statistic on dropped packets on the rx and tx sides. Let's prefer i40evf so that all statistics are suffixed with _packets. This also avoids a s

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] net/ice: fix dropped packets statistics name

Looks good to me… Acked-by: Eelco Chaudron On 3 Jun 2019, at 10:31, David Marchand wrote: > Copy/paste from i40e, let's align with the fix on i40e. > > Fixes: a37bde56314d ("net/ice: support statistics") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/ice/ice_ethde

Re: [dpdk-dev] [PATCH 3/5] replace RTE_IPv4 with uppercase RTE_IPV4

Thomas, Ferruh, Can I get your review on these patches? Then a quick merge would help, so that I send the changes on OVS dpdk-latest branch. Thanks! -- David Marchand On Wed, May 29, 2019 at 6:50 PM Olivier Matz wrote: > On Wed, May 29, 2019 at 01:29:16PM +0200, David Marchand wrote: > > Si

[dpdk-dev] [PATCH 0/2] Enable rte_flow API in ice driver

This patch set enables the backend of rte_flow, and the generic filter related functions in ice driver. Supported flows include ipv4, tcpv4, udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch set depends on shared code update. Qiming Yang (1): net/ice: add generic flow API wei zhao (1): net/i

[dpdk-dev] [PATCH 2/2] net/ice: add generic flow API

This patch adds ice_flow_create, ice_flow_destroy, ice_flow_flush and ice_flow_validate support, these are going to used to handle all the generic filters. Signed-off-by: Qiming Yang --- drivers/net/ice/Makefile | 1 + drivers/net/ice/ice_ethdev.c | 44 +++ drivers/net/ice/ice

[dpdk-dev] [PATCH 1/2] net/ice: enable switch filter

From: wei zhao The patch enables the backend of rte_flow. It transfers rte_flow_xxx to device specific data structure and configures packet process engine's binary classifier (switch) properly. Signed-off-by: Wei Zhao --- drivers/net/ice/Makefile| 1 + drivers/net/ice/ice_ethdev.

[dpdk-dev] [PATCH 1/5] event/octeontx2: resize SSO inflight event buffers

From: Pavan Nikhilesh Resize SSO internal in-flight buffer count based on the Rx queues mempool size connected to event queues. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.h | 2 ++ drivers/event/octeontx2/otx2_evdev_adptr.c | 34 +- 2 files

[dpdk-dev] [PATCH 2/5] event/octeontx2: add event eth Rx adapter fastpath ops

From: Pavan Nikhilesh Add support for event eth Rx adapter fastpath operations. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram --- drivers/event/octeontx2/otx2_evdev.c | 310 - drivers/event/octeontx2/otx2_evdev.h |

[dpdk-dev] [PATCH 4/5] event/octeontx2: add Tx adadpter support

From: Pavan Nikhilesh Add event eth Tx adapter support to octeontx2 SSO. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram --- drivers/event/octeontx2/otx2_evdev.c | 78 ++ drivers/event/octeontx2/otx2_evdev.h | 26

[dpdk-dev] [PATCH 3/5] event/octeontx2: add PTP support for SSO

From: Harman Kalra Add PTP support for SSO based on rx_offloads of the queue connected to it. Signed-off-by: Harman Kalra Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 2 ++ drivers/event/octeontx2/otx2_evdev.h | 6 ++

[dpdk-dev] [PATCH 0/5] event/octeontx2: add Rx/Tx adapter support

From: Pavan Nikhilesh This patchset adds event eth Rx/Tx adapter support. Depends on the following patchsets: http://patches.dpdk.org/project/dpdk/list/?series=4844 http://patches.dpdk.org/project/dpdk/list/?series=4847 http://patches.dpdk.org/project/dpdk/list/?series=4848 Pavan Nikhilesh (5):

[dpdk-dev] [PATCH 5/5] doc: update Marvell OCTEON TX2 documentation

From: Pavan Nikhilesh Update event octentx2 capabilities w.r.t event eth Rx/Tx capabilities. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx2.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/eventdevs/octeontx2.rst b/doc/guides/eventdevs/octeontx2.rst

Re: [dpdk-dev] [PATCH 00/25] Make shared memory config non-public

30/05/2019 12:15, Bruce Richardson: > On Thu, May 30, 2019 at 09:07:44AM +0100, Burakov, Anatoly wrote: > > On 29-May-19 9:11 PM, David Marchand wrote: > > > On the names of the functions, could we have something shorter ? > > > The prefix rte_eal_mcfg_ is not necessary from my pov. > > > > I can

[dpdk-dev] [PATCH 1/2] examples/l3fwd-vf: remove old Rx/Tx configuration defines

The RX and TX Prefetch, Host, and Write-back threshold values are defined but not used anywhere. They are leftovers from a previous patch. Fixes: 81f7ecd9 ("examples: use factorized default Rx/Tx configuration") Cc: sta...@dpdk.org Signed-off-by: Bao-Long Tran --- examples/l3fwd-vf/main.c | 19

[dpdk-dev] [PATCH 0/2] clean up old Rx/Tx configuration leftovers

The Rx/Tx configuration was updated in this commit 81f7ecd9 ("examples: use factorized default Rx/Tx configuration") The patch set remove some leftovers from that commit. Bao-Long Tran (2): examples/l3fwd-vf: remove old Rx/Tx configuration defines doc: remove old Rx/Tx configuration info in l

[dpdk-dev] [PATCH 2/2] doc: remove old Rx/Tx configuration info in l2fwd

Update doc the match with code. Fixes: 81f7ecd9 ("examples: use factorized default Rx/Tx configuration") Cc: sta...@dpdk.org Signed-off-by: Bao-Long Tran --- doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 12 1 file changed, 12 deletions(-) diff --git a/doc/guides/sample_a

[dpdk-dev] [PATCH] app/test-compress-perf: report header improvement

This patch adds extra features to the compress performance test. Some important parameters (memory allocation, number of ops, number of segments) are calculated and printed out on the screen. Signed-off-by: Artur Trybula --- app/test-compress-perf/main.c | 105 +++---

Re: [dpdk-dev] [PATCH v5 0/5] make lcore_config internal

31/05/2019 17:36, David Marchand: > This set of patches makes the lcore_config structure less visible > as part of the ABI. This version does not break the ABI (yet) > follow on patch moves lcore_config into eal_private.h > > Changelog since v4: > The only change is in patch 2: marked new apis as

[dpdk-dev] [PATCH v2 5/6] event/octeontx2: add Tx adadpter support

From: Pavan Nikhilesh Add event eth Tx adapter support to octeontx2 SSO. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram --- drivers/event/octeontx2/otx2_evdev.c | 78 ++ drivers/event/octeontx2/otx2_evdev.h | 26

[dpdk-dev] [PATCH v2 0/6] event/octeontx2: add Rx/Tx adapter support

From: Pavan Nikhilesh This patchset adds event eth Rx/Tx adapter support. Depends on the following patchsets: http://patches.dpdk.org/project/dpdk/list/?series=4844 http://patches.dpdk.org/project/dpdk/list/?series=4847 http://patches.dpdk.org/project/dpdk/list/?series=4848 v2 Changes: - add mis

[dpdk-dev] [PATCH v2 3/6] event/octeontx2: add event eth Rx adapter fastpath ops

From: Pavan Nikhilesh Add support for event eth Rx adapter fastpath operations. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram --- drivers/event/octeontx2/otx2_evdev.c | 310 - drivers/event/octeontx2/otx2_evdev.h |

[dpdk-dev] [PATCH v2 6/6] doc: update Marvell OCTEON TX2 documentation

From: Pavan Nikhilesh Update event octentx2 capabilities w.r.t event eth Rx/Tx capabilities. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx2.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/eventdevs/octeontx2.rst b/doc/guides/eventdevs/octeontx2.rst

[dpdk-dev] [PATCH v2 4/6] event/octeontx2: add PTP support for SSO

From: Harman Kalra Add PTP support for SSO based on rx_offloads of the queue connected to it. Signed-off-by: Harman Kalra Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 2 ++ drivers/event/octeontx2/otx2_evdev.h | 6 ++

[dpdk-dev] [PATCH v2 1/6] event/octeontx2: add event eth Rx adapter support

From: Pavan Nikhilesh Add event eth Rx adapter capabilities, queue add and delete functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Jerin Jacob --- drivers/event/octeontx2/Makefile | 4 +- drivers/event/octeontx2/meson.build| 2 +- drivers/event/octeontx2/otx2_evd

[dpdk-dev] [PATCH v2 2/6] event/octeontx2: resize SSO inflight event buffers

From: Pavan Nikhilesh Resize SSO internal in-flight buffer count based on the Rx queues mempool size connected to event queues. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.h | 2 ++ drivers/event/octeontx2/otx2_evdev_adptr.c | 34 +- 2 files

Re: [dpdk-dev] eal/pci: Improve automatic selection of IOVA mode

Hello, On Thu, May 30, 2019 at 7:48 PM Ben Walker wrote: > In SPDK, not all drivers are registered with DPDK at start up time. > Previously, that meant DPDK always chose to set itself up in IOVA_PA > mode. Instead, when the correct iova choice is unclear based on the > devices and drivers known

Re: [dpdk-dev] [PATCH v1 1/9] raw/octeontx2_dma: add build infra and device probe

On Sat, 2019-06-01 at 23:50 +0530, jer...@marvell.com wrote: > diff --git a/drivers/raw/octeontx2_dma/meson.build > b/drivers/raw/octeontx2_dma/meson.build > new file mode 100644 > index 0..1281268aa > --- /dev/null > +++ b/drivers/raw/octeontx2_dma/meson.build > @@ -0,0 +1,18 @@ > +# SPDX-

[dpdk-dev] [PATCH v3 00/11] A new net PMD - hinic

This patch set adds support of a new net PMD for Huawei Intelligent nic. This patch provides supoort for basic RX/TX and the contorl path needed for it. Later on new features will be added like VLAN, VFs, etc. Basic features: 1. Basic device operations: probe, initialization, start/stop, config

[dpdk-dev] [PATCH v3 01/11] net/hinic/base: add registers for Huawei Hi1822 NIC

Add the registers that comprise the Huawei Hi1822 NIC. There is no functionality in this patch. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_csr.h | 164 + 1 file changed, 164 insertions(+) create mode 100644 drivers/net/hinic/base/hinic_csr.h diff --

[dpdk-dev] [PATCH v3 02/11] net/hinic/base: add command channels code

Admin channels include api channel and command queue, Api channel is for mgmt module. And command queue is for ucode module. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_api_cmd.c | 1037 drivers/net/hinic/base/hinic_pmd_api_cmd.h | 271 + drivers/net

[dpdk-dev] [PATCH v3 03/11] net/hinic/base: add mgmt module interactive code

Add the structures, functionalities for interaction with mgmt module. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_hw_mgmt.h| 85 +++ drivers/net/hinic/base/hinic_pmd_mgmt.c | 617 ++ drivers/net/hinic/base/hinic_pmd_mgmt.h | 125 .../net/

[dpdk-dev] [PATCH v3 05/11] net/hinic/base: add eqs and context code

Add code for eq. Aeq is a kind queue for mgmt asynchronous message and mgmt command response message. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_ctx_def.h | 184 ++ drivers/net/hinic/base/hinic_pmd_dpdev.h | 146 + drivers/net/hinic/base/hinic_pmd_eqs.c | 725 +++

[dpdk-dev] [PATCH v3 04/11] net/hinic/base: add code about hardware operation

Add code for hardware operation, including configuration, query and so on. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_cfg.c | 269 drivers/net/hinic/base/hinic_pmd_cfg.h | 264 drivers/net/hinic/base/hinic_pmd_hw.h| 49 + drivers/net/hinic/base/hinic_pm

[dpdk-dev] [PATCH v3 06/11] net/hinic/base: add code for nic business

Add code for nic business, including qps structures, qps configuration, wqs configuration for qps, nic business configuration functionalities. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_nic.h| 85 ++ drivers/net/hinic/base/hinic_pmd_niccfg.c | 1376

[dpdk-dev] [PATCH v3 07/11] net/hinic/base: add various headers

Add various headers that define mgmt commands, cmdq commands, rx data structures, tx data structures and basic defines for use in the code. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_compat.h | 239 drivers/net/hinic/base/hinic_port_cmd.h | 483 +++

[dpdk-dev] [PATCH v3 09/11] net/hinic: add RX module

Add code for RX module. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/Makefile | 2 +- drivers/net/hinic/hinic_pmd_rx.c | 902 +++ drivers/net/hinic/meson.build| 2 +- 3 files changed, 904 insertions(+), 2 deletions(-) create mode 100644 drivers/net/

[dpdk-dev] [PATCH v3 08/11] net/hinic: add hinic PMD build and doc files

Add build and doc files, and common code files. Signed-off-by: Ziyang Xuan --- MAINTAINERS | 9 + config/common_base | 5 + doc/guides/nics/features/hinic.ini | 32 ++ doc/guides/nics/hinic.rst| 49 ++ drivers/net/Makefile

Re: [dpdk-dev] [PATCH v10] net/memif: introduce memory interface (memif) PMD

> -Original Message- > From: Ye Xiaolong > Sent: Friday, May 31, 2019 9:43 AM > To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v10] net/memif: introduce memory interface > (memif) PMD > > Minor nit, this should b

[dpdk-dev] [PATCH v3 10/11] net/hinic: add TX module

Add code for TX module Signed-off-by: Ziyang Xuan --- drivers/net/hinic/Makefile |2 +- drivers/net/hinic/hinic_pmd_tx.c | 1070 ++ drivers/net/hinic/meson.build|2 +- 3 files changed, 1072 insertions(+), 2 deletions(-) create mode 100644 drivers/ne

[dpdk-dev] [PATCH v3 11/11] net/hinic: add support for basic device operations

Add hinic PMD initialization and ethernet operatioins code. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/hinic_pmd_ethdev.c| 2125 +++ drivers/net/hinic/rte_pmd_hinic_version.map |4 + 2 files changed, 2129 insertions(+) create mode 100644 drivers/net/hinic/rte_p

Re: [dpdk-dev] Compilation failure with DPDK 18.11.1 (LTS)

Thank you, David. Let me look at this once more and get back to you. Regards, raghu From: David Marchand Sent: Wednesday, May 29, 2019 4:45 AM To: adabala, raghuram Cc: us...@dpdk.org; dev@dpdk.org; Kevin Traynor Subject: Re: [dpdk-dev] Compilation failure with DPDK 18.11.1 (LTS) [EXTERNAL EMAI

[dpdk-dev] [PATCH] usertools: add device index for dpdk-devbind script

Add a device index in front of the PCI ID for easy counting Network devices using DPDK-compatible driver 0: :07:00.0 ... 1: :07:00.1 ... Signed-off-by: Loc Nguyen --- usertools/dpdk-devbind.py | 4 +++- 1 file changed, 3 insertions(+), 1 de

Re: [dpdk-dev] [PATCH 3/5] replace RTE_IPv4 with uppercase RTE_IPV4

29/05/2019 16:26, Olivier Matz: > On Wed, May 29, 2019 at 01:29:16PM +0200, David Marchand wrote: > > Since we change this macro, we might as well avoid triggering complaints > > from checkpatch because of mixed case. > > > > old=RTE_IPv4 > > new=RTE_IPV4 > > git grep -lw $old | xargs sed -i -e "s

Re: [dpdk-dev] [EXT] [PATCH v1 2/7] app/test-compress-perf: add ptest command line option

> -Original Message- > From: Tomasz Jozwiak > Sent: Thursday, May 30, 2019 1:36 PM > To: dev@dpdk.org; fiona.tr...@intel.com; tjozwiakgm.gmail.com@mx0a- > 0016f401.pphosted.com; Shally Verma > Subject: [EXT] [PATCH v1 2/7] app/test-compress-perf: add ptest command line > option > > Ex

Re: [dpdk-dev] [PATCH 24/25] net/ena: fix direct access to shared memory config

On 03.06.2019 09:33, Michał Krawczyk wrote: On 29.05.2019 18:31, Anatoly Burakov wrote: The ENA driver calculates a ring's NUMA node affinity by directly accessing the memzone list. Fix it to do it through the public API's instead. Signed-off-by: Anatoly Burakov ---   drivers/net/ena/ena_ethde

Re: [dpdk-dev] [PATCH v10] net/memif: introduce memory interface (memif) PMD

Jakub Grajciar writes: > Memory interface (memif), provides high performance > packet transfer over shared memory. > > Signed-off-by: Jakub Grajciar > --- > MAINTAINERS |6 + > config/common_base |5 + > config/common_linux

Re: [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness

> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, May 29, 2019 7:17 PM > To: Jozwiak, TomaszX ; Shally Verma > ; dev@dpdk.org; sta...@dpdk.org > Cc: Trybula, ArturX ; Trahe, Fiona > > Subject: [EXT] RE: [PATCH] app/test-compress-perf: fix reliance on integer > endianness >

[dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness (CI:328524)

This patch fixes Coverity Issue 328524: Reliance on integer endianness (INCOMPATIBLE_CAST) in function *parse_window_sz*. Signed-off-by: Artur Trybula --- app/test-compress-perf/comp_perf_options_parse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-compress-pe

Re: [dpdk-dev] [PATCH v3] eal: remove non-thread panic calls from init sequence

Hi > > The part below can go after a --- marker, this is more a comment for the > work in progress rather than something to put in this patch commitlog. > Ack > > The calls for launching core messaging threads were left in tact >> in all 3 eal implementations. >> > > For these I will submit a p

Re: [dpdk-dev] [PATCH v10] net/memif: introduce memory interface (memif) PMD

On 06/03, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > >> -Original Message- >> From: Ye Xiaolong >> Sent: Friday, May 31, 2019 9:43 AM >> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) >> >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH 8/8] raw/ioat: add local API to perform copies

30/05/2019 23:25, Bruce Richardson: > Add local APIs to trigger data copies, and retrieve handle values once > those copies are completed. Included are unit tests to validate the data > is copies correctly. Would be nice to have a small design overview in the guide. We may need also to answer the

[dpdk-dev] [PATCH 0/9] add QAT support for digest encrypted

From: Damian Nowak This patchset adds digest appended and encrypted auth-cipher operations support for QAT, with dedicated feature flag and a set of tests for KASUMI and SNOW3G in-place, out-of-place and SGL using operations. Damian Nowak (9): crypto/qat: check buffer size for oop auth-cipher

[dpdk-dev] [PATCH 1/9] crypto/qat: check buffer size for oop auth-cipher

From: Damian Nowak This patch adds condition to be met when using wireless algorithms (SNOW3G, KASUMI, ZUC) in out-of-place auth-cipher operations. It verifies if there is enough room for the digest in the output buffer. Conditions rewritten for better readibility and possible SGL support. Sign

[dpdk-dev] [PATCH 2/9] test/crypto: add snow3g test cases for oop operation

From: Damian Nowak This patch adds test cases for snow3g out of place auth-cipher operations. Test cases include digest generation with buffer encryption and buffer decryption with digest verification. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 228

[dpdk-dev] [PATCH 3/9] test/crypto: add kasumi test cases for oop operation

From: Damian Nowak This patch adds test cases for kasumi out of place auth-cipher operations. Test cases include digest generation with buffer encryption and buffer decryption with digest verification. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 190

[dpdk-dev] [PATCH 4/9] test/crypto: add sgl test cases for ip and oop

From: Damian Nowak This patch adds test cases for snow3g in-place and out-of-place auth-cipher operations with scatter-gather lists as input and output mbufs. Test cases include digest generation with buffer encryption and buffer decryption with digest verification. Signed-off-by: Damian Nowak

[dpdk-dev] [PATCH 5/9] cryptodev: document usage of digest-appended operations

From: Damian Nowak This patch explains what are the conditions and how to use digest appended for auth-cipher operations. Signed-off-by: Damian Nowak --- lib/librte_cryptodev/rte_crypto_sym.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/lib/librte_cr

[dpdk-dev] [PATCH 6/9] cryptodev: add digest encrypted feature flag

From: Damian Nowak Some PMDs can only support digest being encrypted separately in auth-cipher operations. Thus it is required to add feature flag in PMD to reflect if it does support digest-appended both: digest generation with encryption and decryption with digest verification. Signed-off-by:

[dpdk-dev] [PATCH 7/9] crypto/qat: add digest encrypted feature flag

From: Damian Nowak This patch adds feature flag for QuickAssist Technology to emphasize it's support for digest appended auth-cipher operations. Signed-off-by: Damian Nowak --- drivers/crypto/qat/qat_sym_pmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto

[dpdk-dev] [PATCH 8/9] test/crypto: add digest encrypted feature flag check

From: Damian Nowak This patch adds checking of digest encrypted feature flag for auth-cipher out-of-place operations test cases to determine if the operations are supported. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 40 ++-- 1 file changed,

[dpdk-dev] [PATCH 9/9] test/crypto: return correct value if feature not supported

From: Damian Nowak This patch makes unsupported tests visible in the testsuite summary. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 937849e..5d7

[dpdk-dev] [PATCH] cryptodev: add ff_disable field in cryptodev config

Adding a new field, ff_disable, to allow applications to control the features enabled on the crypto device. This would allow for efficient usage of HW/SW offloads by disabling the features not required by the application. Signed-off-by: Anoob Joseph --- doc/guides/rel_notes/deprecation.rst | 1

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix positive error codes from probe/remove

On 03.06.2019 11:50, David Marchand wrote: > > > On Thu, May 30, 2019 at 3:26 PM Ilya Maximets > wrote: > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' and their > 'hotplug' equivalents must return 0 or negative error code. Bus code > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix positive error codes from probe/remove

On Mon, Jun 3, 2019 at 5:37 PM Ilya Maximets wrote: > On 03.06.2019 11:50, David Marchand wrote: > > > > > > On Thu, May 30, 2019 at 3:26 PM Ilya Maximets > wrote: > > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' and their > > 'hotplug' eq

Re: [dpdk-dev] eal/pci: Improve automatic selection of IOVA mode

On Mon, 2019-06-03 at 12:48 +0200, David Marchand wrote: > Hello, > > On Thu, May 30, 2019 at 7:48 PM Ben Walker wrote: > > In SPDK, not all drivers are registered with DPDK at start up time. > > Previously, that meant DPDK always chose to set itself up in IOVA_PA > > mode. Instead, when the cor

[dpdk-dev] [PATCH 05/39] examples/l2fwd-event: move dataplane code to new file

Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/Makefile | 1 + examples/l2fwd-event/l2fwd_worker.c | 231 examples/l2fwd-event/l2fwd_worker.h | 10 ++ examples/l2fwd-event/main.c | 189 +---

[dpdk-dev] [PATCH 03/39] examples/l2fwd-event: move structures to common header

Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_common.h | 12 examples/l2fwd-event/main.c | 10 -- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/examples/l2fwd-event/l2fwd_common.h b/examples/l2fwd-event/

[dpdk-dev] [PATCH 04/39] examples/l2fwd-event: move global vars to common header

Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_common.h | 26 +++ examples/l2fwd-event/main.c | 41 +++-- 2 files changed, 43 insertions(+), 24 deletions(-) diff --git a/examples/l2fwd-event/l

[dpdk-dev] [PATCH 07/39] examples/l2fwd-event: move drain buffers to new function

Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_worker.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd-event/l2fwd_worker.c b/examples/l2fwd-event/l2fwd_worker.c index 942b191..eb

[dpdk-dev] [PATCH 06/39] examples/l2fwd-event: remove unused header includes

Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_worker.c | 12 1 file changed, 12 deletions(-) diff --git a/examples/l2fwd-event/l2fwd_worker.c b/examples/l2fwd-event/l2fwd_worker.c index 167fe39..942b191 100644 --- a/examples/l2fwd-event/

[dpdk-dev] [PATCH 08/39] examples/l2fwd-event: optimize check for master core

Replacing the check for lcore_id & mastercore_id with the check for a flag. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_worker.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/examples/l2fwd-event/l2fwd_worker.c b/exampl

[dpdk-dev] [PATCH 10/39] examples/l2fwd-event: do timer updates only on master

The timer updates and checks are required only for stats printing by the master core. This can be entirely skipped for other cores. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_worker.c | 21 + 1 file changed, 13 insertions(+), 8

[dpdk-dev] [PATCH 09/39] examples/l2fwd-event: move periodic tasks to new func

Move the periodic operations (stats flush and drain buffers) to a new function. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_worker.c | 83 - examples/l2fwd-event/l2fwd_worker.h | 6 +++ 2 files changed, 52 insert

[dpdk-dev] [PATCH 12/39] examples/l2fwd-event: use fprintf in usage print

Following the convention of l3fwd, using fprintf instead of printf for printing usage. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-e

[dpdk-dev] [PATCH 14/39] eventdev: add files for eventmode helper

Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/Makefile| 5 +++-- lib/librte_eventdev/meson.build | 2 ++ lib/librte_eventdev/rte_eventmode_helper.c | 7 +++ lib/librte_eventdev/rte_eventmode_helper.h

[dpdk-dev] [PATCH 11/39] examples/l2fwd-event: move pkt send code to a new func

Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_worker.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd-event/l2fwd_worker.c b/examples/l2fwd-event/l2fwd_worker.c index 58fd5b8..1a7ee2b 100644 --

[dpdk-dev] [PATCH 16/39] eventdev: add eventmode CL options framework

Adding usage prints and CL parsing routines for eventmode. Option to select packet transfer mode is also added. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/rte_eventdev_version.map | 2 + lib/librte_eventdev/rte_eventmode_helper.c | 128 +++

[dpdk-dev] [PATCH 13/39] examples/l2fwd-event: improvements to the usage print

Fixed alignment and split the usage print to aid easy addition of eventmode usage prints. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/examples/l2fwd-event/

[dpdk-dev] [PATCH 15/39] eventdev: add routines for logging eventmode helper

Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- config/common_base | 1 + lib/librte_eal/common/eal_common_log.c | 1 + lib/librte_eal/common/include/rte_log.h| 1 + .../rte_eventmode_helper_internal.h| 29

[dpdk-dev] [PATCH 17/39] eventdev: allow application to set ethernet portmask

Application would be required to restrict helper functions to use only certain ports. The field eth_portmask field in the conf could be used for this. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/rte_eventmode_helper.c | 3 +++ lib/librte_eventdev/rte_event

[dpdk-dev] [PATCH 19/39] eventdev: add common initialize routine for eventmode devs

Adding framework for common initialization routine for event mode. Event mode would involve initialization of multiple devices, like eventdev, ethdev etc and this routine would be the placeholder for all initialization to come in. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- l

[dpdk-dev] [PATCH 20/39] eventdev: add eventdevice init for eventmode

Adding routines to initialize event devs. The internal conf structure would be used to track device configuration. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/rte_eventmode_helper.c | 131 + .../rte_eventmode_helper_internal.h

[dpdk-dev] [PATCH 18/39] eventdev: add framework for eventmode conf

Adding eventmode conf which would have all required configuration for the event mode. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/rte_eventmode_helper.c | 16 lib/librte_eventdev/rte_eventmode_helper_internal.h | 5 + 2 files

[dpdk-dev] [PATCH 21/39] eventdev: add eventdev port-lcore link

Adding eventdev port-lcore link. In addition, this will also specify which event queue need to be connected to the event port. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/rte_eventmode_helper.c | 22 ++ lib/librte_eventdev/rte_e

[dpdk-dev] [PATCH 25/39] eventdev: add routine to validate conf

Adding routine to validate event mode conf. This function will verify the conf requested by the user and would populate other fields with default values. Presently, the function acts as placeholder for the above mentioned actions. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- l

[dpdk-dev] [PATCH 22/39] eventdev: add option to specify schedule mode for app stage

Scheduling mode for each event queue is dependent on the same of app stage. Configure event queue taking this also into account. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/rte_eventmode_helper.c | 24 -- .../rte_eventmode_helpe

  1   2   3   >