Re: [dpdk-dev] [PATCH 4/6] examples/ntb: enable an example for ntb

2019-06-03 Thread Ye Xiaolong
On 06/03, Xiaoyun Li wrote: >Enable an example for rawdev ntb. Support interactive mode to send >file on one host and receive file from another host. The command line >would be 'send [filepath]' and 'receive [filepath]'. > >But since the FIFO is not enabled right now, use rte_memcpy as the enqueue

[dpdk-dev] [PATCH v1 1/2] raw/ifpga: fix use of untrusted scalar value

2019-06-03 Thread Zhang, Tianfei
Add checking the buffer size and use const char * for buffer declaration. Coverity issue: 279449 Cc: sta...@dpdk.org Signed-off-by: Zhang, Tianfei --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 4 +-- drivers/raw/ifpga_rawdev/base/ifpga_api.h | 2 +- .../raw/ifpga_rawdev/base/ifpga_f

[dpdk-dev] [PATCH v1 2/2] raw/ifpga: fix logically dead code

2019-06-03 Thread Zhang, Tianfei
add temporary variable in max10_reg_write(). Coverity issue: 337927 Cc: sta...@dpdk.org Signed-off-by: Zhang, Tianfei --- drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c

[dpdk-dev] [PATCH 49/49] net/ice/base: changes for reducing ice add adv rule time

2019-06-03 Thread Leyi Rong
While calling ice_find_recp we were calling ice_get_recp_to_prof_map everytime we called ice_find_recp. ice_get_recp_to_prof_map is a very expensive operation and we should try to reduce the number of times we call this function. So moved it into ice_get_recp_frm_fw since we only need to have fresh

[dpdk-dev] [PATCH 48/49] net/ice/base: allow forward to Q groups in switch rule

2019-06-03 Thread Leyi Rong
Enable forward to Q group action in ice_add_adv_rule. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_switch.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ic

[dpdk-dev] [PATCH 47/49] net/ice/base: enable additional switch rules

2019-06-03 Thread Leyi Rong
Add capability to create inner IP and inner TCP switch recipes and rules. Change UDP tunnel dummy packet to accommodate the training of these new rules. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_protocol_type.h | 8 +-

[dpdk-dev] [PATCH 46/49] net/ice/base: add vxlan/generic tunnel management

2019-06-03 Thread Leyi Rong
Added routines for handling tunnel management: - ice_tunnel_port_in_use() - ice_tunnel_get_type() - ice_find_free_tunnel_entry() - ice_create_tunnel() - ice_destroy_tunnel() Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi R

[dpdk-dev] [PATCH 43/49] net/ice/base: refactor VSI node sched code

2019-06-03 Thread Leyi Rong
Refactored VSI node sched code to use port_info ptr as call arg. The declaration of VSI node getter function has been modified to use pointer to ice_port_info structure instead of pointer to hw structure. This way suitable port_info structure is used to find VSI node. Signed-off-by: Grzegorz Nitk

[dpdk-dev] [PATCH 45/49] net/ice/base: add 16-byte Flex Rx Descriptor

2019-06-03 Thread Leyi Rong
Add 16-byte Flex Rx descriptor structure definition. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_lan_tx_rx.h | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/

[dpdk-dev] [PATCH 44/49] net/ice/base: add some minor new defines

2019-06-03 Thread Leyi Rong
1. Add defines for Link Topology Netlist Section. 2. Add missing Read MAC command response bits. 3. Adds AQ error 29. Signed-off-by: Jacek Naczyk Signed-off-by: Faerman Lev Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_adminq_cmd.h | 5 - drivers

[dpdk-dev] [PATCH 40/49] net/ice/base: code clean up

2019-06-03 Thread Leyi Rong
Cleanup the useless code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_controlq.c | 62 +--- drivers/net/ice/base/ice_fdir.h | 1 - drivers/net/ice/base/ice_flex_pipe.c | 5 ++- drivers/net/ice/base/ice_sched.c | 4

[dpdk-dev] [PATCH 42/49] net/ice/base: change how VMDq capability is wrapped

2019-06-03 Thread Leyi Rong
This patch exposes the VMDq capability when at least one among VMDQ_SUPPORT, OFFLOAD_MACVLAN_SUPPORT or ADQ_SUPPORT (ADQ uses VMDQ as well) is defined. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_adminq_cmd.h |

[dpdk-dev] [PATCH 41/49] net/ice/base: cleanup ice flex pipe files

2019-06-03 Thread Leyi Rong
Make functions that can be, static. Remove some code that is not currently called. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 579 --- drivers/net/ice/base/ice_flex_pipe.h | 59 ---

[dpdk-dev] [PATCH 39/49] net/ice/base: slightly code update

2019-06-03 Thread Leyi Rong
Mainly update below functions: ice_flow_proc_seg_hdrs ice_flow_find_prof_conds ice_dealloc_flow_entry ice_add_rule_internal Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 13 +++ drivers/net/ice/base/ice_flow.c | 47 +

[dpdk-dev] [PATCH 37/49] net/ice/base: fix Flow Director VSI count

2019-06-03 Thread Leyi Rong
Flow director keeps a list of VSIs for each flow type (TCP4, UDP6, etc.) This list varies in length depending on the number of traffic classes (ADQ). This patch uses the define of max TCs to calculate the size of the VSI array. Fixes: bd984f155f49 ("net/ice/base: support FDIR") Signed-off-by: Hen

[dpdk-dev] [PATCH 36/49] net/ice/base: add lock around profile map list

2019-06-03 Thread Leyi Rong
Add locking mechanism around profile map list. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 31 +--- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/net/ice/base/

[dpdk-dev] [PATCH 38/49] net/ice/base: use more efficient structures

2019-06-03 Thread Leyi Rong
Move a bunch of members around to make more efficient use of memory, eliminating holes where possible. None of these members are hot path so cache line alignment is not very important here. Signed-off-by: Jesse Brandeburg Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/

[dpdk-dev] [PATCH 35/49] net/ice/base: calculate rate limit burst size correctly

2019-06-03 Thread Leyi Rong
When the MSB is not set, the lower 11 bits do not represent bytes, but chunks of 64 bytes. Adjust the rate limit burst size calculation accordingly, and update the comments to indicate the way the hardware actually works. Signed-off-by: Ben Shelton Signed-off-by: Paul M Stillwell Jr Signed-off-b

[dpdk-dev] [PATCH 32/49] net/ice/base: implement LLDP persistent settings

2019-06-03 Thread Leyi Rong
This patch implements persistent, across reboots, start and stop of LLDP agent. Added additional function parameter to ice_aq_start_lldp and ice_aq_stop_lldp. Signed-off-by: Jaroslaw Ilgiewicz Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_dcb.c | 33 +

[dpdk-dev] [PATCH 33/49] net/ice/base: check new FD filter duplicate location

2019-06-03 Thread Leyi Rong
Function ice_fdir_is_dup_fltr tests if new Flow Director rule is not a duplicate. Signed-off-by: Karol Kolacinski Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_fdir.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 31/49] net/ice/base: track HW stat registers past rollover

2019-06-03 Thread Leyi Rong
Modify ice_stat_update40 to use rd64 instead of two calls to rd32. Additionally, drop the now unnecessary hireg function parameter. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 57 +++

[dpdk-dev] [PATCH 34/49] net/ice/base: correct UDP/TCP PTYPE assignments

2019-06-03 Thread Leyi Rong
1. Using the UDP-IL PTYPEs when processing packet segments as it contains all PTYPEs with UDP and allow packets to be forwarded to associated VSIs as switch rules are based on outer IPs. 2. Add PTYPE 0x088 to TCP PTYPE bitmap list. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr

[dpdk-dev] [PATCH 28/49] net/ice/base: add some minor features

2019-06-03 Thread Leyi Rong
1. Disable TX pacing option. 2. Use a different ICE_DBG bit for firmware log messages. 3. Always set prefena when configuring a RX queue. 4. make FDID available for FlexDescriptor. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c| 44

[dpdk-dev] [PATCH 29/49] net/ice/base: cleanup update link info

2019-06-03 Thread Leyi Rong
1. Do not unnecessarily initialize local variable. 2. Cleanup ice_update_link_info. 3. Dont clear auto_fec bit in ice_cfg_phy_fec. Signed-off-by: Bruce Allan Signed-off-by: Chinh T Cao Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 52 +

[dpdk-dev] [PATCH 27/49] net/ice/base: call out dev/func caps when printing

2019-06-03 Thread Leyi Rong
This patch makes a change to add a "func cap" prefix when printing function capabilities, and a "dev cap" prefix when printing device capabilities. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 75 +

[dpdk-dev] [PATCH 30/49] net/ice/base: add rd64 support

2019-06-03 Thread Leyi Rong
Add API support for rd64. Signed-off-by: Qi Zhang Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_osdep.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/base/ice_osdep.h b/drivers/net/ice/base/ice_osdep.h index ede893fc9..35a17b941 100644 --- a/drivers/net/ic

[dpdk-dev] [PATCH 24/49] net/ice/base: move VSI to VSI group

2019-06-03 Thread Leyi Rong
Add function to add a VSI to a given VSIG and update package with this entry. The usual flow in XLT management would iterate through all characteristics of the input VSI and create a new VSIG and TCAMs till a matching characteristic is found. When a match is found the VSI is moved into a matching V

[dpdk-dev] [PATCH 26/49] net/ice/base: add some minor features

2019-06-03 Thread Leyi Rong
1. Add loopback reporting to get link response. 2. Add infrastructure for NVM Write/Write Activate calls. 3. Add opcode for NVM save factory settings/NVM Update EMPR command. 4. Add lan overflow event to ice_aq_desc. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ic

[dpdk-dev] [PATCH 25/49] net/ice/base: forbid VSI to remove unassociated ucast filter

2019-06-03 Thread Leyi Rong
If a VSI is not using a unicast filter or did not configure that particular unicast filter, driver should not allow it to be removed by the rogue VSI. Signed-off-by: Akeem G Abodunrin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_switch.c | 57 +++

[dpdk-dev] [PATCH 23/49] net/ice/base: add support for reading REPC statistics

2019-06-03 Thread Leyi Rong
Add a new ice_stat_update_repc function which will read the register and increment the appropriate statistics in the ice_eth_stats structure. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 51 +

[dpdk-dev] [PATCH 22/49] net/ice/base: add and fix debuglogs

2019-06-03 Thread Leyi Rong
Adding missing debuglogs and fixing existing debuglogs. Signed-off-by: Marta Plantykow Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c| 16 +++ drivers/net/ice/base/ice_controlq.c | 19 drivers/net/ice/base/ice_flex_pipe.c | 7

[dpdk-dev] [PATCH 21/49] net/ice/base: added sibling head to parse nodes

2019-06-03 Thread Leyi Rong
There was a bug in the previous code which never traverses all the children to get the first node of the requested layer. Added a sibling head pointer to point the first node of each layer per TC. This helps the traverse easy and quicker and also removed the recursive, complexity of the code. Sig

[dpdk-dev] [PATCH 20/49] net/ice/base: add helper functions for PHY caching

2019-06-03 Thread Leyi Rong
Add additional functions to aide in caching PHY configuration. In order to cache the initial modes, we need to determine the operating mode based on capabilities. Add helper functions for flow control and FEC to take a set of capabilities and return the operating mode matching those capabilities. A

[dpdk-dev] [PATCH 18/49] net/ice/base: move and redefine ice debug cq API

2019-06-03 Thread Leyi Rong
The ice_debug_cq function is only called from ice_controlq.c, and has no other callers outside of that file. Move it and mark it static to avoid namespace pollution. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c

[dpdk-dev] [PATCH 19/49] net/ice/base: separate out control queue lock creation

2019-06-03 Thread Leyi Rong
The ice_init_all_ctrlq and ice_shutdown_all_ctrlq functions create and destroy the locks used to protect the send and receive process of each control queue. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 6 +-

[dpdk-dev] [PATCH 16/49] net/ice/base: add API to init FW logging

2019-06-03 Thread Leyi Rong
In order to initialize the current status of the FW logging, the api ice_get_fw_log_cfg is added. The function retrieves the current setting of the FW logging from HW and updates the ice_hw structure accordingly. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Ro

[dpdk-dev] [PATCH 17/49] net/ice/base: use macro instead of magic 8

2019-06-03 Thread Leyi Rong
Replace the use of the magic number 8 by BITS_PER_BYTE when calculating the number of bits from the number of bytes. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 4 +- drivers/net/ice/base/ice_flow.c | 7

[dpdk-dev] [PATCH 14/49] net/ice/base: refactor HW table init function

2019-06-03 Thread Leyi Rong
1. Separated the calls to initialize and allocate the HW XLT tables from call to fill table. This is to allow the ice_init_hw_tbls call to be made prior to package download so that all HW structures are correctly initialized. This will avoid any invalid memory references if package download fails o

[dpdk-dev] [PATCH 13/49] net/ice/base: cache the data of set PHY cfg AQ in SW

2019-06-03 Thread Leyi Rong
After the transition from cable-unplug to cable-plug events, FW will clear the set-phy-cfg data, sent by user. Thus, we will need to cache these info. 1. The submitted data when set-phy-cfg is called. This info will be used later to check if FW clears out the PHY info, requested by user. 2. The FC,

[dpdk-dev] [PATCH 15/49] net/ice/base: add compatibility check for package version

2019-06-03 Thread Leyi Rong
1. Perform a check against the package version to make sure that it will be compatible with the shared code implementation. There will be points in time when the shared code and package will need to be changed in lock step; the mechanism added here is meant to deal with those situations. 2. Support

[dpdk-dev] [PATCH 11/49] net/ice/base: rollback AVF RSS configurations

2019-06-03 Thread Leyi Rong
Adding support to remove RSS configurations added prior to failing case in AVF. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flow.c | 128 1 file changed, 128 insertions(+) diff --git a

[dpdk-dev] [PATCH 12/49] net/ice/base: move RSS replay list

2019-06-03 Thread Leyi Rong
1. Move the RSS list pointer and lock from the VSI context to the ice_hw structure. This is to ensure that the RSS configurations added to the list prior to reset and maintained until the PF is unloaded. This will ensure that the configuration list is unaffected by VFRs that would destroy the VSI c

[dpdk-dev] [PATCH 09/49] net/ice/base: add lock around profile map list

2019-06-03 Thread Leyi Rong
Add locking mechanism around profile map list. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 29 drivers/net/ice/base/ice_flex_type.h | 5 +++-- 2 files changed, 28 insertions(+), 6

[dpdk-dev] [PATCH 10/49] net/ice/base: save and post reset replay q bandwidth

2019-06-03 Thread Leyi Rong
Added code to save the queue bandwidth information when it is applied and it is replayed when queue is re-enabled again. Earlier saved value is used for replay purpose. Added vsi_handle, tc, and q_handle argument to the ice_cfg_q_bw_lmt, ice_cfg_q_bw_dflt_lmt. Signed-off-by: Tarun Singh Signed-of

[dpdk-dev] [PATCH 08/49] net/ice/base: code for removing advanced rule

2019-06-03 Thread Leyi Rong
This patch also contains ice_remove_adv_rule function to remove existing advanced rules. it also handles the case when we have multiple VSI using the same rule using the following helper functions: ice_adv_rem_update_vsi_list - function to remove VS from VSI list for advanced rules. Signed-off-by

[dpdk-dev] [PATCH 06/49] net/ice/base: programming a new switch recipe

2019-06-03 Thread Leyi Rong
1. Added an interface to support adding advanced switch rules. 2. Advanced rules are provided in a form of protocol headers and values to match in addition to actions (limited actions are current supported). 3. Retrieve field vectors for ICE configuration package to determine extracted fields and e

[dpdk-dev] [PATCH 07/49] net/ice/base: replay advanced rule after reset

2019-06-03 Thread Leyi Rong
Code added to replay the advanced rule per VSI basis and remove the advanced rule information from shared code recipe list. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_switch.c | 81 ++- 1 file c

[dpdk-dev] [PATCH 02/49] net/ice/base: update standard extr seq to include DIR flag

2019-06-03 Thread Leyi Rong
Once upon a time, the ice_flow_create_xtrct_seq() function in ice_flow.c extracted only protocol fields explicitly specified by the caller of the ice_flow_add_prof() function via its struct ice_flow_seg_info instances. However, to support different ingress and egress flow profiles with the same mat

[dpdk-dev] [PATCH 05/49] net/ice/base: add funcs to create new switch recipe

2019-06-03 Thread Leyi Rong
Add functions to support following admin queue commands: 1. 0x0208: allocate resource to hold a switch recipe. This is needed when a new switch recipe needs to be created. 2. 0x0290: create a recipe with protocol header information and other details that determine how this recipe filter work. 3. 0x

[dpdk-dev] [PATCH 03/49] net/ice/base: add API to configure MIB

2019-06-03 Thread Leyi Rong
Add ice_cfg_lldp_mib_change and treat DCBx state NOT_STARTED as valid. Signed-off-by: Chinh T Cao Signed-off-by: Dave Ertman Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_dcb.c | 41 +- drivers/net/ice/base/ice_dcb.h |

[dpdk-dev] [PATCH 04/49] net/ice/base: add more recipe commands

2019-06-03 Thread Leyi Rong
Add the Add Recipe (0x0290), Recipe to Profile (0x0291), Get Recipe (0x0292) and Get Recipe to Profile (0x0293) Commands. Signed-off-by: Lev Faerman Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_adminq_cmd.h | 73 +++ 1 file ch

[dpdk-dev] [PATCH 01/49] net/ice/base: add macro for rounding up

2019-06-03 Thread Leyi Rong
Add macro ROUND_UP for rounding up to an arbitrary multiple. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_type.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/ice/base/ice_type.h b/drivers/ne

[dpdk-dev] [PATCH 00/49] shared code update

2019-06-03 Thread Leyi Rong
Main changes: 1. Advanced switch rule support. 2. Add more APIs for tunnel management. 3. Add some minor features. 4. Code clean and bug fix. Leyi Rong (49): net/ice/base: add macro for rounding up net/ice/base: update standard extr seq to include DIR flag net/ice/base: add API to configure

Re: [dpdk-dev] [EXT] Re: [PATCH v2 0/2] Introduces armada target

2019-06-03 Thread Liron Himi
Hi Thomas, I followed the history where two separate patches were uploaded, if you insist I will submit one patch. As for the MUSDK, please look at the attached mail where Ruifeng was able to build DPDK with MUSDK. If more help is needed, let me know Regards, Liron -Original Message-

Re: [dpdk-dev] [PATCH v5 0/3] add actions to modify header fields

2019-06-03 Thread Dekel Peled
Hi Adrien, I understand that you might have some reservations about patch http://patches.dpdk.org/patch/52975/. I'm preparing v6, with update documentation according to comments from Thomas. In v5 I modified the struct rte_flow_integer_action, according to your comments in previous versions. Ple

Re: [dpdk-dev] [DPDK v2] net/ipn3ke: modifications on AFU configurations

2019-06-03 Thread Wei, Dan
Hi Rosen, thank you for your comments. > > > -Original Message- > > From: Wei, Dan > > Sent: Thursday, May 30, 2019 22:59 > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; Wei, Dan > > ; Xu, Rosen ; sta...@dpdk.org > > Subject: [DPDK v2] net/ipn3ke: modifications on AFU configurations > > > >

Re: [dpdk-dev] [PATCH 2/6] raw/ntb: add intel ntb support

2019-06-03 Thread Ye Xiaolong
On 06/03, Xiaoyun Li wrote: >Add in the list of registers for the device. And enable ntb device >ops for intel skylake platform. > >Signed-off-by: Xiaoyun Li >--- > drivers/raw/ntb_rawdev/Makefile | 1 + > drivers/raw/ntb_rawdev/meson.build| 3 +- > drivers/raw/ntb_rawdev/ntb_hw_intel.

Re: [dpdk-dev] [PATCH 1/6] raw/ntb: introduce ntb rawdev driver

2019-06-03 Thread Ye Xiaolong
On 06/03, Xiaoyun Li wrote: >Introduce rawdev driver support for NTB (Non-transparent Bridge) which >can help to connect two separate hosts with each other. > >Signed-off-by: Xiaoyun Li >--- > config/common_base| 5 + > drivers/raw/Makefile |

Re: [dpdk-dev] [PATCH 1/2] net/ice: enable switch filter

2019-06-03 Thread Zhao1, Wei
Hi,qiming > -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Tuesday, June 4, 2019 1:08 AM > To: Yang, Qiming > Cc: Zhang, Qi Z ; dev@dpdk.org; Zhao1, Wei > > Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: enable switch filter > > Qiming Yang writes: > > > Fro

[dpdk-dev] Meson build failing in ../drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c

2019-06-03 Thread Stephen Hemminger
The Intel build is failing because of recent AES changes? *Meson Failed Build #1: OS: CENTOS76-64 Target:build-gcc-static FAILED: drivers/a715181@@tmp_rte_pmd_aesni_mb at sta/crypto_aesni_mb_rte_aesni_mb_pmd.c.o gcc -Idrivers/a715181@@tmp_rte_pmd_aesni_mb at sta -Idrivers -I../drivers -Idriver

[dpdk-dev] [PATCH] examples/multi_process - fix crash in mp_client with sparse ports

2019-06-03 Thread Stephen Hemminger
From: Stephen Hemminger The mp_client crashes if run on Azure or any system where ethdev ports are owned. In that case, the tx_buffer and tx_stats for the real port were initialized correctly, but the wrong port was used. For example if the server has Ports 3 and 5. Then calling rte_eth_tx_buffe

Re: [dpdk-dev] [PATCH v2 0/2] Introduces armada target

2019-06-03 Thread Thomas Monjalon
22/05/2019 04:24, Gavin Hu (Arm Technology China): > From: lir...@marvell.com > > Introduces armada target to address difference > > in number of cores, no numa support > > > > Liron Himi (2): > > mk: add Marvell ARMADA architecture based on armv8-a > > meson: add Marvell ARMADA architecture ba

Re: [dpdk-dev] [PATCH v3] build: disable armv8 crypto extension

2019-06-03 Thread Thomas Monjalon
13/05/2019 21:26, Honnappa Nagarahalli: > > > > Per armv8 crypto extension support, make build always enable it by default > > as > > long as compiler supports the feature while meson build only enables it for > > 'default' machine of generic armv8 architecture. > > > > It is known that not all

Re: [dpdk-dev] [PATCH v3 1/2] bus/pci: add Mellanox kernel driver type

2019-06-03 Thread Thomas Monjalon
02/05/2019 11:07, Yongseok Koh: > When checking RTE_PCI_DRV_IOVA_AS_VA flag to determine IOVA mode, > pci_one_device_has_iova_va() returns true only if kernel driver of the > device is vfio. However, Mellanox mlx4/5 PMD doesn't need to be detached > from kernel driver and attached to VFIO/UIO. Cont

Re: [dpdk-dev] [PATCH] meson: Update flags and values for ppc_64

2019-06-03 Thread Thomas Monjalon
27/05/2019 11:41, Bruce Richardson: > On Fri, May 24, 2019 at 09:04:04AM -0700, David Wilder wrote: > > Setting RTE_MAX_LCORE to reflect the largest available configuration. > > Adding defines for missing RTE_MACHINE_CPUFLAGs. > > > > Signed-off-by: David Wilder > > --- > > --- a/config/ppc_64/me

[dpdk-dev] [PATCH v2] examples/client_server_mp: check port ownership

2019-06-03 Thread Stephen Hemminger
From: Stephen Hemminger The mp_server would accept a port mask that included hidden (owned) ports and which later caused either lost packets or failed initialization. This fixes explicitly checks for ownership when parsing the port mask. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Signed

Re: [dpdk-dev] [PATCH 2/2] build: add rdrand and rdseed checks to build

2019-06-03 Thread Thomas Monjalon
15/05/2019 18:53, Mattias Rönnblom: > On 2019-05-14 15:37, Bruce Richardson wrote: > > The meson build never checked for the presence of rdrand and rdseed > > instructions, while make build never checked for rdseed. Ensure builds > > always have the appropriate checks - and therefore defines - for

Re: [dpdk-dev] [PATCH] build: add unused parameter warnings to meson build

2019-06-03 Thread Thomas Monjalon
15/05/2019 16:39, Luca Boccassi: > On Wed, 2019-05-15 at 12:38 +0100, Bruce Richardson wrote: > > To improve code quality we want to turn on as many warnings as we can > > in > > the DPDK code, so turn on the "unused-parameter" warning in meson > > builds to > > match that of the make builds. To en

Re: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds

2019-06-03 Thread Thomas Monjalon
28/05/2019 13:07, Bruce Richardson: > This set fixes some issues seen on the automated CI system with building > on 32-bit Linux distro's using meson and ninja. The fixes are to disable > unsupported parts of the build, and switch the 32-bit builds to always > having large file support, so that mak

[dpdk-dev] [PATCH] doc: announce removal of old port count function

2019-06-03 Thread Thomas Monjalon
The function rte_eth_dev_count() was marked as deprecated in DPDK 18.05 in commit d9a42a69febf ("ethdev: deprecate port count function"). It is planned to be removed after the next LTS release. Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 i

Re: [dpdk-dev] [RFC] ethdev: enhance metadata as flow rule criteria

2019-06-03 Thread Yongseok Koh
This has been overridden by another RFC. http://patches.dpdk.org/project/dpdk/list/?series=4875 Thanks, Yongseok > On May 16, 2019, at 8:31 AM, Moti Haimovsky wrote: > > Current implementation of rte_flow metadata match sets metadata only > for egress traffic leaving the need for such feature

[dpdk-dev] [RFC 3/3] ethdev: add flow tag

2019-06-03 Thread Yongseok Koh
A tag is a transient data which can be used during flow match. This can be used to store match result from a previous table so that the same pattern need not be matched again on the next table. Even if outer header is decapsulated on the previous match, the match result can be kept. Some device ex

[dpdk-dev] [RFC 1/3] ethdev: extend flow metadata

2019-06-03 Thread Yongseok Koh
Currently, metadata can be set on egress path via mbuf tx_meatadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_RX_META matches metadata. This patch extends the usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting multiple tables, Tx metadata can also be set by a rule and match

[dpdk-dev] [RFC 2/3] ethdev: add flow modify mark action

2019-06-03 Thread Yongseok Koh
Mark ID can be modified when supporting multiple tables. Partial bit alteration is supported to preserve some bit-fields set by previous match. Signed-off-by: Yongseok Koh --- doc/guides/prog_guide/rte_flow.rst | 21 + lib/librte_ethdev/rte_flow.h | 24 +

[dpdk-dev] [PATCH] rcu: change format specifier in fprintf

2019-06-03 Thread Honnappa Nagarahalli
Use %u to fix argument type mismatch in fprintf. Coverity issue: 340074 Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism") Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- This patch is dependent on: http://patchwork.dpdk.org/patch/53455 lib/librte_rcu/rt

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/hash: rectify slaveid to point to valid cores

2019-06-03 Thread Dharmik Thakkar
> On Jun 3, 2019, at 2:31 PM, David Marchand wrote: > > > On Mon, Jun 3, 2019 at 6:57 PM Dharmik Thakkar > wrote: > > On Jun 1, 2019, at 10:59 AM, David Marchand > > wrote: > > I would change the Fixes: tag, fix the checkpatch warning, and send it next > > week. > I am not sure about thi

Re: [dpdk-dev] [PATCH v5 0/5] make lcore_config internal

2019-06-03 Thread Stephen Hemminger
On Mon, 03 Jun 2019 12:32:02 +0200 Thomas Monjalon wrote: > 31/05/2019 17:36, David Marchand: > > This set of patches makes the lcore_config structure less visible > > as part of the ABI. This version does not break the ABI (yet) > > follow on patch moves lcore_config into eal_private.h > > > >

[dpdk-dev] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless

2019-06-03 Thread Arek Kusztal
Asymmetric cryptography algorithms may more likely use sessionless API so there is need to extend API. Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_asym.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_c

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/hash: rectify slaveid to point to valid cores

2019-06-03 Thread David Marchand
On Mon, Jun 3, 2019 at 6:57 PM Dharmik Thakkar wrote: > > On Jun 1, 2019, at 10:59 AM, David Marchand > wrote: > > I would change the Fixes: tag, fix the checkpatch warning, and send it > next week. > I am not sure about this. Do we simply go by 'git blame' or insert the > commit that truly intr

[dpdk-dev] [PATCH] test: skip test when cores do not meet requirement

2019-06-03 Thread Michael Santana
If the running platform does not meet the required 4 cores or more to run tests rcu_qsbr_autotest and hash_readwrite_autotest meson reports them as failed tests when they really should be skipped tests. The working change can be shown here: FAIL: https://travis-ci.com/Maickii/dpdk-2/jobs/205045946

[dpdk-dev] [PATCH v2] net/virtio: add Tx preparation

2019-06-03 Thread Andrew Rybchenko
From: Dilshod Urazov Virtio requires pseudo-header checksum in TCP/UDP checksum to do offload, but it was lost when Tx prepare is introduced. Also rte_validate_tx_offload() should be used to validate Tx offloads. Also it is incorrect to do virtio_tso_fix_cksum() after prepend to mbuf without tak

[dpdk-dev] [PATCH] net/virtio: add Tx preparation

2019-06-03 Thread Andrew Rybchenko
From: Dilshod Urazov Virtio requires pseudo-header checksum in TCP/UDP checksum to do offload, but it was lost when Tx prepare is introduced. Also rte_validate_tx_offload() should be used to validate Tx offloads. Also it is incorrect to do virtio_tso_fix_cksum() after prepend to mbuf without tak

Re: [dpdk-dev] [PATCH v2] net/i40e: Fail rte_flow MARK requests if RX func was vectorized

2019-06-03 Thread Ergin, Mesut A
> -Original Message- > From: Zhang, Qi Z > Sent: Saturday, May 25, 2019 4:56 AM > To: Ergin, Mesut A ; Xing, Beilei > > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] net/i40e: Fail rte_flow MARK requests if RX func was > vectorized > > > > > -Original Message- > > From: Ergin, Me

[dpdk-dev] [PATCH v3] net/i40e: Fail rte_flow MARK requests if RX func was vectorized

2019-06-03 Thread Mesut Ali Ergin
Runtime requests to install an rte_flow with MARK action should fail if the device was started and a vector RX function was already chosen for during configuration time. Currently, i40e rte_flow driver would successfully install the flow with MARK action, even when vector RX functions are in use.

[dpdk-dev] [PATCH 38/39] examples/l2fwd-event: add eventmode worker

2019-06-03 Thread Anoob Joseph
Adding burst no Tx internal-port eventmode worker Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_worker.c | 219 +++- 1 file changed, 218 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-event/l2fwd_worker.c b/

[dpdk-dev] [PATCH 39/39] examples/l2fwd-event: add eventmode worker

2019-06-03 Thread Anoob Joseph
Adding burst Tx internal port eventmode worker. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_worker.c | 200 +++- 1 file changed, 199 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-event/l2fwd_worker.c b/ex

[dpdk-dev] [PATCH 35/39] eventdev: display Tx adapter conf

2019-06-03 Thread Anoob Joseph
Adding routines to display Tx adapter configuration. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/rte_eventmode_helper_prints.c | 46 ++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/lib/librte_eventdev/rte_eventmode_hel

[dpdk-dev] [PATCH 36/39] examples/l2fwd-event: add eventmode for l2fwd

2019-06-03 Thread Anoob Joseph
Adding eventmode support in l2fwd. This uses rte_eventmode_helper APIs to setup and use the eventmode capabilties. Adding non-burst no Tx internal-port eventmode worker. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/Makefile | 1 + examples/l2fwd-e

[dpdk-dev] [PATCH 37/39] examples/l2fwd-event: add eventmode worker

2019-06-03 Thread Anoob Joseph
Adding non-burst Tx internal-port eventmode worker. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/l2fwd-event/l2fwd_worker.c | 164 +++- 1 file changed, 163 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-event/l2fwd_worker.c

[dpdk-dev] [PATCH 33/39] eventdev: add Tx adapter support

2019-06-03 Thread Anoob Joseph
Adding support for Tx adapter. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/rte_eventmode_helper.c | 349 - lib/librte_eventdev/rte_eventmode_helper.h | 24 ++ .../rte_eventmode_helper_internal.h| 30 ++

[dpdk-dev] [PATCH 34/39] eventdev: add support for internal ports

2019-06-03 Thread Anoob Joseph
For eventdev-ethdev combinations having Tx internal port & Rx internal port, usage of ethcore is not needed. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/rte_eventmode_helper.c | 213 + lib/librte_eventdev/rte_eventmode_helper.h

[dpdk-dev] [PATCH 32/39] eventdev: add routine to launch eventmode workers

2019-06-03 Thread Anoob Joseph
With eventmode, workers could be drafted differently according to the capabilities of the underlying event device. The added function would receive an array of such workers and probes the eventmode properties to choose the worker. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- l

[dpdk-dev] [PATCH 30/39] eventdev: add routine to access eventmode link info

2019-06-03 Thread Anoob Joseph
When the application is drafted for single stage eventmode, it will be efficient to have the loop in the application space, rather than passing it on to the helper. But application would need to have info on the links to be able to do that efficiently. This function exposes the links to that applic

[dpdk-dev] [PATCH 31/39] eventdev: add routine to access event queue for eth Tx

2019-06-03 Thread Anoob Joseph
When the application is drafted for single stage eventmode, it will be efficient to have the loop in the application space, rather than passing it on to the helper. When the application's stage is in ORDERED sched mode, the application will have to change the sched type of the event to ATOMIC befo

[dpdk-dev] [PATCH 29/39] eventdev: add routines to display the eventmode conf

2019-06-03 Thread Anoob Joseph
Adding routines to display the eventmode configuration. This gives an overview of the devices used with the configuration. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/Makefile | 1 + lib/librte_eventdev/meson.build

[dpdk-dev] [PATCH 28/39] eventdev: add default conf for event port-lcore link

2019-06-03 Thread Anoob Joseph
Generate a default conf for event port-lcore link, if not specified in the conf. This routine will check the number of available ports and then create links according to the number of cores available. This patch also adds a new entry in the eventmode conf to denote that all queues is to be linked

[dpdk-dev] [PATCH 27/39] eventdev: add default conf for Rx adapter conf

2019-06-03 Thread Anoob Joseph
Generate a default conf for Rx adapter, if not specified in the conf. This routine will check the available eth ports and event queues, and maps them 1:1. So one eth port will be connected to one event queue. This way, event queue ID could be used to figure out the port on which the packet came in.

[dpdk-dev] [PATCH 25/39] eventdev: add routine to validate conf

2019-06-03 Thread Anoob Joseph
Adding routine to validate event mode conf. This function will verify the conf requested by the user and would populate other fields with default values. Presently, the function acts as placeholder for the above mentioned actions. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- l

[dpdk-dev] [PATCH 20/39] eventdev: add eventdevice init for eventmode

2019-06-03 Thread Anoob Joseph
Adding routines to initialize event devs. The internal conf structure would be used to track device configuration. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- lib/librte_eventdev/rte_eventmode_helper.c | 131 + .../rte_eventmode_helper_internal.h

[dpdk-dev] [PATCH 19/39] eventdev: add common initialize routine for eventmode devs

2019-06-03 Thread Anoob Joseph
Adding framework for common initialization routine for event mode. Event mode would involve initialization of multiple devices, like eventdev, ethdev etc and this routine would be the placeholder for all initialization to come in. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- l

  1   2   3   >