[dpdk-dev] [PATCH] vfio: fix expanding DMA area in ppc64le

2019-06-11 Thread Takeshi Yoshimura
In ppc64le, expanding DMA areas always fail because we cannot remove a DMA window. As a result, we cannot allocate more than one memseg in ppc64le. This is because vfio_spapr_dma_mem_map() doesn't unmap all the mapped DMA before removing the window. This patch fixes this incorrect behavior. I adde

[dpdk-dev] [PATCH] net/af_xdp: update release notes

2019-06-11 Thread Xiaolong Ye
Update release notes for new added features include zero copy and multi-queue. Signed-off-by: Xiaolong Ye --- doc/guides/rel_notes/release_19_08.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst index 5

Re: [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure

2019-06-11 Thread Shreyansh Jain
> -Original Message- > From: dev On Behalf Of Thinh Tran > Sent: Wednesday, June 12, 2019 3:14 AM > To: dev@dpdk.org > Cc: Thinh Tran > Subject: [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure > > Using memory on the stack instead of on the heap by calling malloc > als

[dpdk-dev] [PATCH] net/mlx5: fix 32b compilation

2019-06-11 Thread Shahaf Shuler
32b Compilation output the below error: drivers/net/mlx5/mlx5_txq.c: In function 'mlx5_txq_ibv_new': error: format '%lx' expects argument of type 'long unsigned int', but argument 8 has type 'off_t' [-Werror=format=] DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%lx", ^ Fixes: 6bf10ab69be0 ("net

Re: [dpdk-dev] RFC - vdev_netvsc automatic blacklisting

2019-06-11 Thread Matan Azrad
From: Stephen Hemminger > > Hi Stephen > > > > From: Stephen Hemminger > > > When using DPDK on Azure it is common to have one non-DPDK > interface. > > > If that non-DPDK interface is present vdev_netvsc correctly skip it. > > > But if the non-DPDK has accelerated networking the Mellanox driv

Re: [dpdk-dev] [PATCH v2 1/3] net/af_xdp: enable zero copy by extbuf

2019-06-11 Thread Ye Xiaolong
Hi, On 06/11, William Tu wrote: [snip] >> @@ -294,16 +326,26 @@ eth_af_xdp_tx(void *queue, struct rte_mbuf **bufs, >> uint16_t nb_pkts) >> >> desc = xsk_ring_prod__tx_desc(&txq->tx, idx_tx + i); >> mbuf = bufs[i]; >> - >> - desc->addr = (uint64_t)add

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-11 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 12, 2019 1:18 AM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org > Cc: tho...@monjalon.net; Gavin Hu (Arm Technology China) > ; nd ; nd > Subject: [EXT] RE: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 > c

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix dropped packets statistics name

2019-06-11 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > Sent: Monday, June 3, 2019 4:31 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > Subject: [dpdk-dev] [PATCH 1/2] net/i40e: fix dropped packets statistics > name > > i

Re: [dpdk-dev] [PATCH v2 1/4] net/ipn3ke: add new register address

2019-06-11 Thread Xu, Rosen
> -Original Message- > From: Pei, Andy > Sent: Tuesday, June 11, 2019 17:49 > To: dev@dpdk.org > Cc: Pei, Andy ; Xu, Rosen > Subject: [PATCH v2 1/4] net/ipn3ke: add new register address > > ipn3ke can work on 10G mode and 25G mode. > 10G mode and 25G mode has different MAC register add

Re: [dpdk-dev] [PATCH v2 2/4] net/ipn3ke: delete MAC register address mask

2019-06-11 Thread Xu, Rosen
> -Original Message- > From: Pei, Andy > Sent: Tuesday, June 11, 2019 17:49 > To: dev@dpdk.org > Cc: Pei, Andy ; Xu, Rosen > Subject: [PATCH v2 2/4] net/ipn3ke: delete MAC register address mask > > original code is compatible with older device, whose mac register address is > no more t

Re: [dpdk-dev] [PATCH v2 3/4] net/ipn3ke: clear statistics when init and start dev

2019-06-11 Thread Xu, Rosen
> -Original Message- > From: Pei, Andy > Sent: Tuesday, June 11, 2019 17:49 > To: dev@dpdk.org > Cc: Pei, Andy ; Xu, Rosen > Subject: [PATCH v2 3/4] net/ipn3ke: clear statistics when init and start dev > > clear line side and NIC side statistics registers when HW init and uinit, and >

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by default configuration

2019-06-11 Thread Zhao1, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, June 11, 2019 10:37 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Peng, Yuan ; Lu, Wenzhuo > ; Kevin Traynor > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by > default configuration > > On

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-11 Thread Zhao1, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, June 11, 2019 10:42 PM > To: Zhao1, Wei ; Kevin Traynor > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error > > On 6/11/2019 2:28 AM, Zhao1, Wei wrote: > > Hi, Ke

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by default configuration

2019-06-11 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, June 11, 2019 10:37 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Peng, Yuan ; Lu, Wenzhuo > ; Kevin Traynor > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by > default configurat

Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements

2019-06-11 Thread Lance Richardson
On Tue, Jun 11, 2019 at 5:30 PM Stephen Hemminger wrote: > > On Tue, 11 Jun 2019 17:18:42 -0400 > Lance Richardson wrote: > > > On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger > > wrote: > > > > > > On Mon, 10 Jun 2019 10:51:48 -0700 > > > Stephen Hemminger wrote: > > > > > > > While testing

[dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure

2019-06-11 Thread Thinh Tran
Using memory on the stack instead of on the heap by calling malloc also avoid memory leak in case of test case failures Fixes: 88d0e47880ec ("raw/skeleton: fix memory leak on test failure") Signed-off-by: Thinh Tran --- drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c | 11 +++ 1 file

Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements

2019-06-11 Thread Stephen Hemminger
On Tue, 11 Jun 2019 17:18:42 -0400 Lance Richardson wrote: > On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger > wrote: > > > > On Mon, 10 Jun 2019 10:51:48 -0700 > > Stephen Hemminger wrote: > > > > > While testing KNI with netvsc, saw lots of places more code > > > could be safely removed f

Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements

2019-06-11 Thread Lance Richardson
On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger wrote: > > On Mon, 10 Jun 2019 10:51:48 -0700 > Stephen Hemminger wrote: > > > While testing KNI with netvsc, saw lots of places more code > > could be safely removed from KNI kernel driver. > > > > This is still mostly "putting lipstick on a pig"

Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements

2019-06-11 Thread Stephen Hemminger
On Mon, 10 Jun 2019 10:51:48 -0700 Stephen Hemminger wrote: > While testing KNI with netvsc, saw lots of places more code > could be safely removed from KNI kernel driver. > > This is still mostly "putting lipstick on a pig" all users > would be better off using virtio_user rather than KNI. > >

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-11 Thread Honnappa Nagarahalli
Reduced the CC list (changing the topic slightly) > > > > My understanding is that the generated code for both your patch and my > > changes above is the same. Above suggested changes will conform to > > ACLE recommendation. > > Though instructions are different. Effective cycles are same even th

[dpdk-dev] warning on remapping memory

2019-06-11 Thread Yongseok Koh
Hi Anatoly, There's a report that remap fails on a specific x86 host. We can silence this warning by specifying '--base-virtaddr', but wondering if you know in which case it could happen. Log attached. Thanks, Yongseok EAL: Detected lcore 0 as core 0 on socket 0 EAL: Detected lcore 1 as core

Re: [dpdk-dev] [PATCH v1 0/9] mlx5: Handle data-path completions with error

2019-06-11 Thread Shahaf Shuler
Thursday, May 30, 2019 10:16 AM, Matan Azrad: > Cc: dev@dpdk.org; Matan Azrad > Subject: [PATCH v1 0/9] mlx5: Handle data-path completions with error > > Add support for data-path Rx and Tx completions with error handling: > > 1. Detect the error. > 2. Do not crash. > 3. Report it in statistics

Re: [dpdk-dev] [PATCH] net/mlx5: fix master device Netlink socket sharing

2019-06-11 Thread Shahaf Shuler
Thursday, June 6, 2019 3:23 PM, Viacheslav Ovsiienko: > Subject: [PATCH] net/mlx5: fix master device Netlink socket sharing > > There is the patch [1] that uses master device Netlink socket to retrieve > master device link settings. This is not thread safe because this resource may > be in use by

Re: [dpdk-dev] [PATCH v2 30/66] net/ice/base: add some minor features

2019-06-11 Thread Stillwell Jr, Paul M
> -Original Message- > From: Rong, Leyi > Sent: Tuesday, June 11, 2019 8:52 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Rong, Leyi ; Stillwell Jr, Paul M > > Subject: [PATCH v2 30/66] net/ice/base: add some minor features > > 1. Disable TX pacing option. > 2. Use a different ICE_DBG bit for

Re: [dpdk-dev] [PATCH v2 27/66] net/ice/base: add some minor features

2019-06-11 Thread Stillwell Jr, Paul M
> -Original Message- > From: Rong, Leyi > Sent: Tuesday, June 11, 2019 8:52 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Rong, Leyi ; Stillwell Jr, Paul M > > Subject: [PATCH v2 27/66] net/ice/base: add some minor features > > 1. Add loopback reporting to get link response. > 2. Add infrastr

Re: [dpdk-dev] [PATCH v2 24/66] net/ice/base: add support for reading REPC statistics

2019-06-11 Thread Stillwell Jr, Paul M
> -Original Message- > From: Rong, Leyi > Sent: Tuesday, June 11, 2019 8:52 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Rong, Leyi ; Keller, Jacob E > ; Stillwell Jr, Paul M > > Subject: [PATCH v2 24/66] net/ice/base: add support for reading REPC > statistics > > Add a new ice_stat_update_r

Re: [dpdk-dev] [PATCH v2 21/66] net/ice/base: add helper functions for PHY caching

2019-06-11 Thread Stillwell Jr, Paul M
> -Original Message- > From: Rong, Leyi > Sent: Tuesday, June 11, 2019 8:52 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Rong, Leyi ; Nguyen, Anthony L > ; Stillwell Jr, Paul M > > Subject: [PATCH v2 21/66] net/ice/base: add helper functions for PHY caching > > Add additional functions to ai

Re: [dpdk-dev] [PATCH v2 17/66] net/ice/base: add API to init FW logging

2019-06-11 Thread Stillwell Jr, Paul M
> -Original Message- > From: Rong, Leyi > Sent: Tuesday, June 11, 2019 8:52 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Rong, Leyi ; Nowlin, Dan > ; Stillwell Jr, Paul M > Subject: [PATCH v2 17/66] net/ice/base: add API to init FW logging > > In order to initialize the current status of the

Re: [dpdk-dev] [PATCH v2 0/3] test/ipsec: fixes and improvements

2019-06-11 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Friday, June 7, 2019 11:33 AM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com > Cc: Iremonger, Bernard > Subject: [PATCH v2 0/3] test/ipsec: fixes and improvements > > The following patches contain one fix and > i

Re: [dpdk-dev] [PATCH v2 1/3] net/af_xdp: enable zero copy by extbuf

2019-06-11 Thread William Tu
On Thu, May 30, 2019 at 2:16 AM Xiaolong Ye wrote: > > Implement zero copy of af_xdp pmd through mbuf's external memory > mechanism to achieve high performance. > > This patch also provides a new parameter "pmd_zero_copy" for user, so they > can choose to enable zero copy of af_xdp pmd or not. > >

Re: [dpdk-dev] [PATCH v4 11/11] net/hinic: add support for basic device operations

2019-06-11 Thread Ferruh Yigit
On 6/6/2019 12:07 PM, Ziyang Xuan wrote: > Add hinic PMD initialization and ethernet operatioins code. Hi Xuan, Previous patches puts the code without enabling them, this last patch registers the PMD with lots of new code, it is hard to review this PMD. I think "OCTEON TX2" which also submitted

Re: [dpdk-dev] [PATCH v4 07/11] net/hinic/base: add various headers

2019-06-11 Thread Ferruh Yigit
On 6/6/2019 12:06 PM, Ziyang Xuan wrote: > Add various headers that define mgmt commands, cmdq commands, > rx data structures, tx data structures and basic defines for > use in the code. > > Signed-off-by: Ziyang Xuan <...> > +#define PMD_DRV_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_

Re: [dpdk-dev] [PATCH v4 09/11] net/hinic: add RX module

2019-06-11 Thread Ferruh Yigit
On 6/6/2019 12:06 PM, Ziyang Xuan wrote: > Add code for RX module. > > Signed-off-by: Ziyang Xuan <...> > @@ -0,0 +1,902 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2017 Huawei Technologies Co., Ltd > + */ > + > +#include > +#include > +#include > +#ifdef __ARM64_NEON__

Re: [dpdk-dev] [PATCH v4 08/11] net/hinic: add hinic PMD build and doc files

2019-06-11 Thread Ferruh Yigit
On 6/6/2019 12:06 PM, Ziyang Xuan wrote: > Add build and doc files, and common code files. > > Signed-off-by: Ziyang Xuan > --- > MAINTAINERS | 9 + > config/common_base | 5 + > config/common_linux | 5 + >

[dpdk-dev] [PATCH v2 63/66] net/ice/base: fix potential memory leak in destroy tunnel

2019-06-11 Thread Leyi Rong
Fix for an issue where an error would cause a memory leak in the ice_destroy_tunnel function. Fixes: 8c518712ef9f ("net/ice/base: add vxlan/generic tunnel management") Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.

[dpdk-dev] [PATCH v2 65/66] net/ice/base: add link event defines

2019-06-11 Thread Leyi Rong
Add support to mask the topology and media conflict events. Signed-off-by: Doug Dziggel Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_adminq_cmd.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/n

[dpdk-dev] [PATCH v2 64/66] net/ice/base: correct NVGRE header structure

2019-06-11 Thread Leyi Rong
Correct NVGRE header structure and its field offsets. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_protocol_type.h | 5 +++-- drivers/net/ice/base/ice_switch.c| 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)

[dpdk-dev] [PATCH v2 66/66] net/ice/base: reduce calls to get profile associations

2019-06-11 Thread Leyi Rong
Added refresh_required flag to determine if we need to update the recipe to profile mapping cache. This will reduce the number of calls made to refresh the profile map. Signed-off-by: Shivanshu Shukla Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_swit

[dpdk-dev] [PATCH v2 62/66] net/ice/base: use the specified size for ice zero bitmap

2019-06-11 Thread Leyi Rong
A couple of places in the code use a 'sizeof(bitmap) * BITS_PER_BYTE' construction to calculate the size of the bitmap when calling ice_zero_bitmap. Instead of doing this, just use the same value as in the ice_declare_bitmap declaration. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell

[dpdk-dev] [PATCH v2 61/66] net/ice/base: use ice zero bitmap instead of ice memset

2019-06-11 Thread Leyi Rong
A few places in the code used ice_memset instead of ice_zero_bitmap to initialize a bitmap to zeros. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v2 60/66] net/ice/base: rework API for ice cp bitmap

2019-06-11 Thread Leyi Rong
Fix ice_cp_bitmap to copy the entire storage. Fixes: c9e37832c95f ("net/ice/base: rework on bit ops") Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_bitops.h | 17 + 1 file changed, 5 insertions(+), 12 delet

[dpdk-dev] [PATCH v2 59/66] net/ice/base: rework API for ice zero bitmap

2019-06-11 Thread Leyi Rong
Fix ice_zero_bitmap to zero the entire storage. Fixes: c9e37832c95f ("net/ice/base: rework on bit ops") Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_bitops.h | 19 ++- 1 file changed, 6 insertions(+), 13 d

[dpdk-dev] [PATCH v2 58/66] net/ice/base: deduce TSA value in the CEE mode

2019-06-11 Thread Leyi Rong
In CEE mode, the TSA information can be derived from the reported priority value. Signed-off-by: Chinh T Cao Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_dcb.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice

[dpdk-dev] [PATCH v2 57/66] net/ice/base: changes for reducing ice add adv rule time

2019-06-11 Thread Leyi Rong
While calling ice_find_recp we were calling ice_get_recp_to_prof_map everytime we called ice_find_recp. ice_get_recp_to_prof_map is a very expensive operation and we should try to reduce the number of times we call this function. So moved it into ice_get_recp_frm_fw since we only need to have fresh

[dpdk-dev] [PATCH v2 55/66] net/ice/base: enable additional switch rules

2019-06-11 Thread Leyi Rong
Add capability to create inner IP and inner TCP switch recipes and rules. Change UDP tunnel dummy packet to accommodate the training of these new rules. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_protocol_type.h | 8 +-

[dpdk-dev] [PATCH v2 56/66] net/ice/base: allow forward to Q groups in switch rule

2019-06-11 Thread Leyi Rong
Enable forward to Q group action in ice_add_adv_rule. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_switch.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ic

[dpdk-dev] [PATCH v2 54/66] net/ice/base: add vxlan/generic tunnel management

2019-06-11 Thread Leyi Rong
Added routines for handling tunnel management: - ice_tunnel_port_in_use() - ice_tunnel_get_type() - ice_find_free_tunnel_entry() - ice_create_tunnel() - ice_destroy_tunnel() Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi R

[dpdk-dev] [PATCH v2 52/66] net/ice/base: add some minor new defines

2019-06-11 Thread Leyi Rong
1. Add defines for Link Topology Netlist Section. 2. Add missing Read MAC command response bits. 3. Adds AQ error 29. Signed-off-by: Jacek Naczyk Signed-off-by: Faerman Lev Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_adminq_cmd.h | 5 - drivers

[dpdk-dev] [PATCH v2 53/66] net/ice/base: add 16-byte Flex Rx Descriptor

2019-06-11 Thread Leyi Rong
Add 16-byte Flex Rx descriptor structure definition. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_lan_tx_rx.h | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/

[dpdk-dev] [PATCH v2 47/66] net/ice/base: introduce some new macros

2019-06-11 Thread Leyi Rong
Introduce some more new macros, like ICE_VSI_LB and the like. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flow.c | 4 +++- drivers/net/ice/base/ice_switch.h | 14 +- drivers/net/ice/base/ice_type.h | 6 +- 3 files changed, 13 in

[dpdk-dev] [PATCH v2 50/66] net/ice/base: cleanup ice flex pipe files

2019-06-11 Thread Leyi Rong
Make functions that can be, static. Remove some code that is not currently called. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 579 --- drivers/net/ice/base/ice_flex_pipe.h | 59 ---

[dpdk-dev] [PATCH v2 49/66] net/ice/base: code clean up

2019-06-11 Thread Leyi Rong
Cleanup the useless code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_controlq.c | 62 +--- drivers/net/ice/base/ice_fdir.h | 4 -- drivers/net/ice/base/ice_flex_pipe.c | 7 ++-- drivers/net/ice/base/ice_sched.c |

[dpdk-dev] [PATCH v2 51/66] net/ice/base: refactor VSI node sched code

2019-06-11 Thread Leyi Rong
Refactored VSI node sched code to use port_info ptr as call arg. The declaration of VSI node getter function has been modified to use pointer to ice_port_info structure instead of pointer to hw structure. This way suitable port_info structure is used to find VSI node. Signed-off-by: Grzegorz Nitk

[dpdk-dev] [PATCH v2 45/66] net/ice/base: protect list add with lock

2019-06-11 Thread Leyi Rong
Function ice_add_rule_internal needs to call ice_create_pkt_fwd_rule with lock held because it uses the LIST_ADD to modify the filter rule list. It needs to be protected when modified. Signed-off-by: Tarun Singh Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/ba

[dpdk-dev] [PATCH v2 46/66] net/ice/base: fix Rx functionality for ethertype filters

2019-06-11 Thread Leyi Rong
In the function ice_add_eth_mac(), there is a line that hard-codes the filter info flag to TX. This is redundant and inaccurate. That flag will be set by the calling function that built the list of filters to add, and hard-coding it eliminates the Rx functionality of this code. The paired function

[dpdk-dev] [PATCH v2 48/66] net/ice/base: add init for SW recipe member rg list

2019-06-11 Thread Leyi Rong
Initialize ice_sw_recipe member rg_list in ice_init_def_sw_recp. Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_switch.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c index 2c376321b..373acb7a6 100644 --- a/drive

[dpdk-dev] [PATCH v2 44/66] net/ice/base: check RSS flow profile list

2019-06-11 Thread Leyi Rong
Minor change to check if there are any RSS flow profiles to remove. This will avoid flow profile lock acquisition and release if the list is empty. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flow.c | 3 +++ 1 file cha

[dpdk-dev] [PATCH v2 43/66] net/ice/base: add new API to dealloc flow entry

2019-06-11 Thread Leyi Rong
Decouple ice_dealloc_flow_entry from ice_flow_rem_entry_sync. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flow.c | 35 - 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b/

[dpdk-dev] [PATCH v2 42/66] net/ice/base: fix for signed package download

2019-06-11 Thread Leyi Rong
In order to properly support signed packages, we always have to send the complete buffer to firmware, regardless of any unused space at the end. This is because the SHA hash value is computed over the entire buffer. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Signed-off-by:

[dpdk-dev] [PATCH v2 41/66] net/ice/base: silent semantic parser warnings

2019-06-11 Thread Leyi Rong
Eliminate some semantic warnings, static analysis warnings. Signed-off-by: Bruce Allan Signed-off-by: Kevin Scott Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 8 drivers/net/ice/base/ice_flow.c | 5 + drivers/

[dpdk-dev] [PATCH v2 38/66] net/ice/base: add lock around profile map list

2019-06-11 Thread Leyi Rong
Add locking mechanism around profile map list. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 31 +--- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/net/ice/base/

[dpdk-dev] [PATCH v2 39/66] net/ice/base: fix Flow Director VSI count

2019-06-11 Thread Leyi Rong
Flow director keeps a list of VSIs for each flow type (TCP4, UDP6, etc.) This list varies in length depending on the number of traffic classes (ADQ). This patch uses the define of max TCs to calculate the size of the VSI array. Fixes: bd984f155f49 ("net/ice/base: support FDIR") Signed-off-by: Hen

[dpdk-dev] [PATCH v2 40/66] net/ice/base: use more efficient structures

2019-06-11 Thread Leyi Rong
Move a bunch of members around to make more efficient use of memory, eliminating holes where possible. None of these members are hot path so cache line alignment is not very important here. Signed-off-by: Jesse Brandeburg Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/

[dpdk-dev] [PATCH v2 37/66] net/ice/base: calculate rate limit burst size correctly

2019-06-11 Thread Leyi Rong
When the MSB is not set, the lower 11 bits do not represent bytes, but chunks of 64 bytes. Adjust the rate limit burst size calculation accordingly, and update the comments to indicate the way the hardware actually works. Signed-off-by: Ben Shelton Signed-off-by: Paul M Stillwell Jr Signed-off-b

[dpdk-dev] [PATCH v2 35/66] net/ice/base: check new FD filter duplicate location

2019-06-11 Thread Leyi Rong
Function ice_fdir_is_dup_fltr tests if new Flow Director rule is not a duplicate. Signed-off-by: Karol Kolacinski Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_fdir.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v2 34/66] net/ice/base: implement LLDP persistent settings

2019-06-11 Thread Leyi Rong
This patch implements persistent, across reboots, start and stop of LLDP agent. Added additional function parameter to ice_aq_start_lldp and ice_aq_stop_lldp. Signed-off-by: Jaroslaw Ilgiewicz Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_dcb.c | 33 +

[dpdk-dev] [PATCH v2 36/66] net/ice/base: correct UDP/TCP PTYPE assignments

2019-06-11 Thread Leyi Rong
1. Using the UDP-IL PTYPEs when processing packet segments as it contains all PTYPEs with UDP and allow packets to be forwarded to associated VSIs as switch rules are based on outer IPs. 2. Add PTYPE 0x088 to TCP PTYPE bitmap list. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr

[dpdk-dev] [PATCH v2 33/66] net/ice/base: track HW stat registers past rollover

2019-06-11 Thread Leyi Rong
Modify ice_stat_update40 to use rd64 instead of two calls to rd32. Additionally, drop the now unnecessary hireg function parameter. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 57 +++

[dpdk-dev] [PATCH v2 31/66] net/ice/base: cleanup update link info

2019-06-11 Thread Leyi Rong
1. Do not unnecessarily initialize local variable. 2. Cleanup ice_update_link_info. 3. Dont clear auto_fec bit in ice_cfg_phy_fec. Signed-off-by: Bruce Allan Signed-off-by: Chinh T Cao Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 52 +

[dpdk-dev] [PATCH v2 32/66] net/ice/base: add rd64 support

2019-06-11 Thread Leyi Rong
Add API support for rd64. Signed-off-by: Qi Zhang Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_osdep.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/base/ice_osdep.h b/drivers/net/ice/base/ice_osdep.h index ede893fc9..35a17b941 100644 --- a/drivers/net/ic

[dpdk-dev] [PATCH v2 26/66] net/ice/base: forbid VSI to remove unassociated ucast filter

2019-06-11 Thread Leyi Rong
If a VSI is not using a unicast filter or did not configure that particular unicast filter, driver should not allow it to be removed by the rogue VSI. Signed-off-by: Akeem G Abodunrin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_switch.c | 57 +++

[dpdk-dev] [PATCH v2 30/66] net/ice/base: add some minor features

2019-06-11 Thread Leyi Rong
1. Disable TX pacing option. 2. Use a different ICE_DBG bit for firmware log messages. 3. Always set prefena when configuring a RX queue. 4. make FDID available for FlexDescriptor. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c| 44

[dpdk-dev] [PATCH v2 29/66] net/ice/base: call out dev/func caps when printing

2019-06-11 Thread Leyi Rong
This patch makes a change to add a "func cap" prefix when printing function capabilities, and a "dev cap" prefix when printing device capabilities. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 75 +

[dpdk-dev] [PATCH v2 28/66] net/ice/base: add hweight32 support

2019-06-11 Thread Leyi Rong
Add API support for hweight32. Signed-off-by: Qi Zhang Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_osdep.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/ice/base/ice_osdep.h b/drivers/net/ice/base/ice_osdep.h index d2d9238c7..ede893fc9 100644 --- a/dr

[dpdk-dev] [PATCH v2 27/66] net/ice/base: add some minor features

2019-06-11 Thread Leyi Rong
1. Add loopback reporting to get link response. 2. Add infrastructure for NVM Write/Write Activate calls. 3. Add opcode for NVM save factory settings/NVM Update EMPR command. 4. Add lan overflow event to ice_aq_desc. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ic

[dpdk-dev] [PATCH v2 25/66] net/ice/base: move VSI to VSI group

2019-06-11 Thread Leyi Rong
Add function to add a VSI to a given VSIG and update package with this entry. The usual flow in XLT management would iterate through all characteristics of the input VSI and create a new VSIG and TCAMs till a matching characteristic is found. When a match is found the VSI is moved into a matching V

[dpdk-dev] [PATCH v2 23/66] net/ice/base: add and fix debuglogs

2019-06-11 Thread Leyi Rong
Adding missing debuglogs and fixing existing debuglogs. Signed-off-by: Marta Plantykow Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c| 16 +++ drivers/net/ice/base/ice_controlq.c | 19 drivers/net/ice/base/ice_flex_pipe.c | 7

[dpdk-dev] [PATCH v2 21/66] net/ice/base: add helper functions for PHY caching

2019-06-11 Thread Leyi Rong
Add additional functions to aide in caching PHY configuration. In order to cache the initial modes, we need to determine the operating mode based on capabilities. Add helper functions for flow control and FEC to take a set of capabilities and return the operating mode matching those capabilities. A

[dpdk-dev] [PATCH v2 24/66] net/ice/base: add support for reading REPC statistics

2019-06-11 Thread Leyi Rong
Add a new ice_stat_update_repc function which will read the register and increment the appropriate statistics in the ice_eth_stats structure. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 51 +

[dpdk-dev] [PATCH v2 22/66] net/ice/base: added sibling head to parse nodes

2019-06-11 Thread Leyi Rong
There was a bug in the previous code which never traverses all the children to get the first node of the requested layer. Added a sibling head pointer to point the first node of each layer per TC. This helps the traverse easy and quicker and also removed the recursive, complexity of the code. Sig

[dpdk-dev] [PATCH v2 20/66] net/ice/base: separate out control queue lock creation

2019-06-11 Thread Leyi Rong
The ice_init_all_ctrlq and ice_shutdown_all_ctrlq functions create and destroy the locks used to protect the send and receive process of each control queue. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 6 +-

[dpdk-dev] [PATCH v2 19/66] net/ice/base: move and redefine ice debug cq API

2019-06-11 Thread Leyi Rong
The ice_debug_cq function is only called from ice_controlq.c, and has no other callers outside of that file. Move it and mark it static to avoid namespace pollution. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c

[dpdk-dev] [PATCH v2 18/66] net/ice/base: use macro instead of magic 8

2019-06-11 Thread Leyi Rong
Replace the use of the magic number 8 by BITS_PER_BYTE when calculating the number of bits from the number of bytes. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 4 +- drivers/net/ice/base/ice_flow.c | 7

[dpdk-dev] [PATCH v2 16/66] net/ice/base: add compatibility check for package version

2019-06-11 Thread Leyi Rong
1. Perform a check against the package version to make sure that it will be compatible with the shared code implementation. There will be points in time when the shared code and package will need to be changed in lock step; the mechanism added here is meant to deal with those situations. 2. Support

[dpdk-dev] [PATCH v2 14/66] net/ice/base: cache the data of set PHY cfg AQ in SW

2019-06-11 Thread Leyi Rong
After the transition from cable-unplug to cable-plug events, FW will clear the set-phy-cfg data, sent by user. Thus, we will need to cache these info. 1. The submitted data when set-phy-cfg is called. This info will be used later to check if FW clears out the PHY info, requested by user. 2. The FC,

[dpdk-dev] [PATCH v2 15/66] net/ice/base: refactor HW table init function

2019-06-11 Thread Leyi Rong
1. Separated the calls to initialize and allocate the HW XLT tables from call to fill table. This is to allow the ice_init_hw_tbls call to be made prior to package download so that all HW structures are correctly initialized. This will avoid any invalid memory references if package download fails o

[dpdk-dev] [PATCH v2 17/66] net/ice/base: add API to init FW logging

2019-06-11 Thread Leyi Rong
In order to initialize the current status of the FW logging, the api ice_get_fw_log_cfg is added. The function retrieves the current setting of the FW logging from HW and updates the ice_hw structure accordingly. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Ro

[dpdk-dev] [PATCH v2 11/66] net/ice/base: save and post reset replay q bandwidth

2019-06-11 Thread Leyi Rong
Added code to save the queue bandwidth information when it is applied and it is replayed when queue is re-enabled again. Earlier saved value is used for replay purpose. Added vsi_handle, tc, and q_handle argument to the ice_cfg_q_bw_lmt, ice_cfg_q_bw_dflt_lmt. Signed-off-by: Tarun Singh Signed-of

[dpdk-dev] [PATCH v2 12/66] net/ice/base: rollback AVF RSS configurations

2019-06-11 Thread Leyi Rong
Adding support to remove RSS configurations added prior to failing case in AVF. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flow.c | 128 1 file changed, 128 insertions(+) diff --git a

[dpdk-dev] [PATCH v2 13/66] net/ice/base: move RSS replay list

2019-06-11 Thread Leyi Rong
1. Move the RSS list pointer and lock from the VSI context to the ice_hw structure. This is to ensure that the RSS configurations added to the list prior to reset and maintained until the PF is unloaded. This will ensure that the configuration list is unaffected by VFRs that would destroy the VSI c

[dpdk-dev] [PATCH v2 10/66] net/ice/base: add lock around profile map list

2019-06-11 Thread Leyi Rong
Add locking mechanism around profile map list. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 29 drivers/net/ice/base/ice_flex_type.h | 5 +++-- 2 files changed, 28 insertions(+), 6

[dpdk-dev] [PATCH v2 09/66] net/ice/base: code for removing advanced rule

2019-06-11 Thread Leyi Rong
This patch also contains ice_remove_adv_rule function to remove existing advanced rules. it also handles the case when we have multiple VSI using the same rule using the following helper functions: ice_adv_rem_update_vsi_list - function to remove VS from VSI list for advanced rules. Signed-off-by

[dpdk-dev] [PATCH v2 08/66] net/ice/base: replay advanced rule after reset

2019-06-11 Thread Leyi Rong
Code added to replay the advanced rule per VSI basis and remove the advanced rule information from shared code recipe list. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_switch.c | 81 ++- 1 file c

[dpdk-dev] [PATCH v2 07/66] net/ice/base: programming a new switch recipe

2019-06-11 Thread Leyi Rong
1. Added an interface to support adding advanced switch rules. 2. Advanced rules are provided in a form of protocol headers and values to match in addition to actions (limited actions are current supported). 3. Retrieve field vectors for ICE configuration package to determine extracted fields and e

[dpdk-dev] [PATCH v2 06/66] net/ice/base: add funcs to create new switch recipe

2019-06-11 Thread Leyi Rong
Add functions to support following admin queue commands: 1. 0x0208: allocate resource to hold a switch recipe. This is needed when a new switch recipe needs to be created. 2. 0x0290: create a recipe with protocol header information and other details that determine how this recipe filter work. 3. 0x

[dpdk-dev] [PATCH v2 05/66] net/ice/base: add more recipe commands

2019-06-11 Thread Leyi Rong
Add the Add Recipe (0x0290), Recipe to Profile (0x0291), Get Recipe (0x0292) and Get Recipe to Profile (0x0293) Commands. Signed-off-by: Lev Faerman Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_adminq_cmd.h | 73 +++ 1 file ch

[dpdk-dev] [PATCH v2 04/66] net/ice/base: add another valid DCBx state

2019-06-11 Thread Leyi Rong
When a port is not cabled, but DCBx is enabled in the firmware, the status of DCBx will be NOT_STARTED. This is a valid state for FW enabled and should not be treated as a is_fw_lldp true automatically. Add the code to treat NOT_STARTED as another valid state. Signed-off-by: Dave Ertman Signed-o

[dpdk-dev] [PATCH v2 03/66] net/ice/base: add API to configure MIB

2019-06-11 Thread Leyi Rong
Decouple ice_cfg_lldp_mib_change from the ice_init_dcb function call. Signed-off-by: Chinh T Cao Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_dcb.c | 38 ++ drivers/net/ice/base/ice_dcb.h | 3 ++- 2 files changed, 36

[dpdk-dev] [PATCH v2 02/66] net/ice/base: update standard extr seq to include DIR flag

2019-06-11 Thread Leyi Rong
Once upon a time, the ice_flow_create_xtrct_seq() function in ice_flow.c extracted only protocol fields explicitly specified by the caller of the ice_flow_add_prof() function via its struct ice_flow_seg_info instances. However, to support different ingress and egress flow profiles with the same mat

[dpdk-dev] [PATCH v2 01/66] net/ice/base: add macro for rounding up

2019-06-11 Thread Leyi Rong
Add macro ROUND_UP for rounding up to an arbitrary multiple. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_type.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/ice/base/ice_type.h b/drivers/ne

  1   2   >