Re: [dpdk-dev] [PATCH v3 4/4] net/ipn3ke: implementation of statistics

Hi David, Reply inline. From: David Marchand [mailto:david.march...@redhat.com] Sent: Tuesday, June 25, 2019 4:58 PM To: Pei, Andy Cc: dev ; Xu, Rosen Subject: Re: [dpdk-dev] [PATCH v3 4/4] net/ipn3ke: implementation of statistics On Tue, Jun 25, 2019 at 10:53 AM Pei, Andy mailto:andy@in

[dpdk-dev] [Bug 297] max_rx_pkt_len issues with i40e dpdk SRIOV driver net_i40e_vf.

https://bugs.dpdk.org/show_bug.cgi?id=297 Bug ID: 297 Summary: max_rx_pkt_len issues with i40e dpdk SRIOV driver net_i40e_vf. Product: DPDK Version: 18.02 Hardware: x86 OS: All Status: CONFIRMED

Re: [dpdk-dev] [PATCH 32/39] eventdev: add routine to launch eventmode workers

Hi Erik, Please see inline. Thanks, Anoob > -Original Message- > From: Carrillo, Erik G > Sent: Monday, June 10, 2019 8:16 PM > To: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Rao, Nikhil ; Gujjar, > Abhinandan S ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: Narayana Prasad Ra

Re: [dpdk-dev] [PATCH v4 4/4] net/ipn3ke: implementation of statistics

Hi, > -Original Message- > From: Pei, Andy > Sent: Tuesday, June 25, 2019 16:00 > To: dev@dpdk.org > Cc: Pei, Andy ; Xu, Rosen ; > david.march...@redhat.com > Subject: [PATCH v4 4/4] net/ipn3ke: implementation of statistics > > This patch implemente statistics read and reset function for

Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper library

Hi Jerin, Mattias, Please see inline. Thanks, Anoob > -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Tuesday, June 25, 2019 4:03 PM > To: Anoob Joseph ; Mattias Rönnblom > ; Nikhil Rao ; Erik > Gabriel Carrillo ; Abhinandan Gujjar > ; Bruce Richardson > ; Pablo de Lara > >

[dpdk-dev] [PATCH] crypto/octeontx: remove unsupported capabilities

Removing capabilities not supported with latest firmware. Signed-off-by: Anoob Joseph --- .../crypto/octeontx/otx_cryptodev_capabilities.c | 48 +++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev_capabilities.c b/driver

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

From: Maxime Coquelin > For functional reasons, I agree. So I that's why I agree with your > tso patch as the application has to support it, but that's not the > case of the mergeable buffers features. > >>> > >>> Performance reasons are not good enough? > >> > >> No, that's not w

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

OK, what do you think about this: #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES if (record_cycle & RECORD_TX_CORE_CYCLES) { .. do measurement stuff .. } #endif + add some new command to config in runtime: "set record_cycle 3" We keep existing RTE_TEST_PMD_RECORD_CORE_CYCLES, do not introduce new b

Re: [dpdk-dev] [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest command line option

> -Original Message- > From: Tomasz Jozwiak > Sent: Wednesday, June 26, 2019 11:05 PM > To: Shally Verma ; dev@dpdk.org; > fiona.tr...@intel.com; arturx.tryb...@intel.com > Subject: Re: [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest > command line option > > Hi Shally, > > > >

[dpdk-dev] [PATCH 3/3] test/hash: init hash parameters in the correct function

Each test case initializes its hash parameters in the test case function. To be consistent, generate keys function should initialize hash parameters similarly. Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dh

[dpdk-dev] [PATCH 2/3] test/hash: free allocated memory

Free allocated memory. Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/test_hash_readwrite_lf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/test_hash_readwr

[dpdk-dev] [PATCH 1/3] test/hash: reset global variable to discard old data

Reset tbl_rwc_test_param to discard data from previous run of the test. Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/test_hash_readwrite_lf.c | 3 +++ 1 file changed, 3 inserti

Re: [dpdk-dev] [PATCH 0/3] some update on CVL shared code

Please saw the compile error in community. Not x86_64 gcc. > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, June 26, 2019 5:36 PM > To: Yang, Qiming ; Rong, Leyi > ; Ye, Xiaolong > Cc: dev@dpdk.org > Subject: RE: [PATCH 0/3] some update on CVL shared code > > Hi, Qiming > >

Re: [dpdk-dev] [PATCH v8 4/4] doc: add release note for generic flow

Hi, Thomas OK I'll move the release adding to patches. -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Thursday, June 27, 2019 5:28 AM To: Yang, Qiming Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v8 4/4] doc: add release note for generic flow 26/06/2019 1

Re: [dpdk-dev] [PATCH] net/i40e: i40e rework for ipn3ke

Hi, Xiaolong OK, I will do this in V2. Thanks. -Original Message- From: Ye, Xiaolong Sent: Wednesday, June 26, 2019 11:33 PM To: Pei, Andy Cc: dev@dpdk.org; Zhang, Roy Fan ; Zhang, Qi Z ; Wu, Jingjing ; Xing, Beilei ; Yigit, Ferruh ; Xu, Rosen Subject: Re: [dpdk-dev] [PATCH] net/i4

Re: [dpdk-dev] [PATCH v2 00/28] sched: feature enhancements

On Tue, 25 Jun 2019 16:31:49 +0100 Jasvinder Singh wrote: > This patchset refactors the dpdk qos sched library to add > following features to enhance the scheduler functionality. > > 1. flexibile configuration of the pipe traffic classes and queues; > >Currently, each pipe has 16 queues har

[dpdk-dev] [PATCH v2 0/2] failsafe: add xstats

A useful feature of netvsc PMD is the ability to see how many packets were processed through the VF device. This patch set adds a similar (but more limited) capability to failsafe driver. Since failsafe doesn't have top level xstats, this set uses the generic xstats that exist already as a base th

[dpdk-dev] [PATCH v2 2/2] failsafe: implement xstats

Add support for extended statistics in failsafe driver. Reports basic statistics for the failsafe driver, and detailed statistics for each sub device. Signed-off-by: Stephen Hemminger --- drivers/net/failsafe/failsafe_ops.c | 130 1 file changed, 130 insertions(+) d

[dpdk-dev] [PATCH v2 1/2] ethdev: expose basic xstats for driver use

Avoid duplication by having generic basic xstats available for use by drivers. A later patch uses this for failsafe driver. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 17 - lib/librte_ethdev/rte_ethdev_core.h | 14 ++ lib/libr

Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and mempool driver

On Tue, 25 Jun 2019 23:39:36 +0200 Thomas Monjalon wrote: > 22/06/2019 15:23, jer...@marvell.com: > > From: Jerin Jacob > > > > This patch set adds initial driver support for OCTEON TX2 SoC. > > > > OCTEON TX2 is an armv8.2 SoC with integrated HW based mempool, ethdev, > > cryptodev, compressd

Re: [dpdk-dev] [PATCH v2] eal/linux: fix return after alarm registration failure

On Wed, 26 Jun 2019 16:02:34 +0200 Thomas Monjalon wrote: > When adding an alarm, if an error happen when registering > the common alarm callback, it is not considered as a major failure. > The alarm is then inserted in the list. > However it was returning an error code after inserting the alarm.

[dpdk-dev] [PATCH] mempool/octeontx2: fix build with ICC

The Intel compiler is pickier about casts and generates: otx2_mempool_ops.c(344): error #191: type qualifier is meaningless on cast type int64_t * const addr = (int64_t * const) ^ This is because of the nature of const. In this example, the expression is bein

[dpdk-dev] [PATCH] malloc: deprecate unused set limit

The function rte_malloc_set_limit was defined but never implemented. Mark it as deprecated for now, and remove in next release. There is no point in keeping dead code. "You Aren't Going to Need It" Signed-off-by: Stephen Hemminger --- app/test/test_malloc.c | 21

[dpdk-dev] [PATCH 2/2] failsafe: implement xstats

From: Stephen Hemminger Add support for extended statistics in failsafe driver. Reports basic statistics for the failsafe driver, and detailed statistics for each sub device. Signed-off-by: Stephen Hemminger --- drivers/net/failsafe/failsafe_ops.c | 144 1 file cha

[dpdk-dev] [PATCH 0/2] failsafe: add xstats

A useful feature of netvsc PMD is the ability to see how many packets were processed through the VF device. This patch set adds a similar (but more limited) capability to failsafe driver. Since failsafe doesn't have top level xstats, this set uses the generic xstats that exist already as a base th

[dpdk-dev] [PATCH 1/2] ethdev: expose basic xstats for driver use

From: Stephen Hemminger Avoid duplication by having generic basic xstats available for use by drivers. A later patch uses this for failsafe driver. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 17 - lib/librte_ethdev/rte_ethdev_core.h | 1

Re: [dpdk-dev] [PATCH v3 1/2] lib/ipsec: add support for header construction

Hi Fan, > -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, June 26, 2019 4:05 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ananyev, Konstantin ; > Zhang, Roy Fan ; Kovacevic, > Marko > Subject: [PATCH v3 1/2] lib/ipsec: add support for header construction > > Add support

Re: [dpdk-dev] [PATCH 1/5] bus/fslmc: support device iteration

Hi Hemant, Your series may deserve a cover letter to explain the general idea. I'm embarassed also because these patches are sent late in 19.08 cycle.

Re: [dpdk-dev] [PATCH v2 00/28] sched: feature enhancements

25/06/2019 17:31, Jasvinder Singh: > Jasvinder Singh (27): > sched: update macros for flexible config > sched: update subport and pipe data structures > sched: update internal data structures > sched: update port config API > sched: update port free API > sched: update subport config AP

Re: [dpdk-dev] [PATCH v2 28/28] sched: add release note

25/06/2019 17:32, Jasvinder Singh: > --- a/doc/guides/rel_notes/release_19_08.rst > +++ b/doc/guides/rel_notes/release_19_08.rst > @@ -135,6 +135,11 @@ API Changes > +* sched: To allow more traffic classes, flexible mapping of pipe queues to > + traffic classes, and subport level configuration of

Re: [dpdk-dev] [PATCH v8 4/4] doc: add release note for generic flow

26/06/2019 10:58, Qiming Yang: > --- a/doc/guides/rel_notes/release_19_08.rst > +++ b/doc/guides/rel_notes/release_19_08.rst > @@ -93,6 +93,7 @@ New Features >Updated ice driver with new features and improvements, including: > >* Enabled Tx outer/inner L3/L4 checksum offload. > + * Enabl

Re: [dpdk-dev] [PATCH v3 7/7] doc: update release notes for 19.08

26/06/2019 18:30, Tomasz Jozwiak: > --- a/doc/guides/rel_notes/release_19_08.rst > +++ b/doc/guides/rel_notes/release_19_08.rst > +* **Updated test-compress-perf tool application.** > + > + Added multiple cores feature to compression perf tool application. This should be in the patch adding this

Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags

18/05/2019 17:18, Ananyev, Konstantin: > > Hi, > > > Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags > > during fragmentation and reassemble operation implicitly. > > Because of this, application is forced to use checksum offload > > whether it is supported by platform or not. > > >

Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

07/06/2019 10:32, David Marchand: > Thomas, > > - Calling unplug on a device that is not attached is a bit weird to me, all > the more so that we have rte_dev_probed(). > But there might be users calling directly the bus unplug api and not the > official api... > Does this enter the ABI stability

Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

07/06/2019 10:32, David Marchand: > On Thu, Jun 6, 2019 at 12:03 PM Ilya Maximets > wrote: > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > > return 0 or negative error code. Bus code returns positive values > > if device wasn't recognized by any driver, so the result of >

[dpdk-dev] kill rte_malloc_set_limit

The function rte_malloc_set_limit was never implemented fully, and is unused anywhere in current DPDK. It should be deprecated (based on YAGNI).

Re: [dpdk-dev] [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest command line option

Hi Shally, -Original Message- From: Tomasz Jozwiak Sent: Wednesday, June 26, 2019 10:00 PM To: dev@dpdk.org; fiona.tr...@intel.com; tjozwia...@gmail.com; Shally Verma ; arturx.tryb...@intel.com Subject: [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest command line option Externa

Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] drivers/net: fix double free on init failure cleanup

On 6/17/2019 4:05 PM, David Marchand wrote: > If we don't clear mac_addrs, ethdev will double free it on cleanup. > > Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit Applied to dpdk-next

Re: [dpdk-dev] [PATCH 2/3] net/bnx2x: fix invalid free on unplug

On 6/17/2019 4:05 PM, David Marchand wrote: > mac_addrs points to a field in dev_private. > We can't let ethdev free it. > > Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit Applied to dp

Re: [dpdk-dev] [PATCH 1/3] net/nfb: avoid memory leak on unplug

On 6/17/2019 4:05 PM, David Marchand wrote: > Clearing mac_addrs on remove will prevent ethdev from freeing it. > > Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest command line option

> -Original Message- > From: Tomasz Jozwiak > Sent: Wednesday, June 26, 2019 10:00 PM > To: dev@dpdk.org; fiona.tr...@intel.com; tjozwia...@gmail.com; Shally > Verma ; arturx.tryb...@intel.com > Subject: [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest command > line option > > E

Re: [dpdk-dev] [PATCH v2 1/1] app/test-compress-perf: fix reliance on integer endianness

> -Original Message- > From: dev On Behalf Of Artur Trybula > Sent: Tuesday, June 4, 2019 6:11 PM > To: dev@dpdk.org; fiona.tr...@intel.com; adamx.dybkow...@intel.com; > arturx.tryb...@intel.com > Subject: [dpdk-dev] [PATCH v2 1/1] app/test-compress-perf: fix reliance on > integer endia

Re: [dpdk-dev] [PATCH] app/test-compress-perf: report header improvement

> -Original Message- > From: dev On Behalf Of Artur Trybula > Sent: Monday, June 3, 2019 3:54 PM > To: dev@dpdk.org; fiona.tr...@intel.com; arturx.tryb...@intel.com; > adamx.dybkow...@intel.com > Subject: [dpdk-dev] [PATCH] app/test-compress-perf: report header > improvement > > This pa

Re: [dpdk-dev] [PATCH v5 00/15] A new net PMD - hinic

On 6/26/2019 3:42 PM, Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions) wrote: >> On 6/19/2019 4:45 PM, Ziyang Xuan wrote: >>> This patch set adds support of a new net PMD for Huawei Intelligent >>> nic. This patch provides supoort for basic R

Re: [dpdk-dev] [PATCH] doc/api: add missing header file to API documentation

On 6/26/2019 4:20 PM, A.McLoughlin wrote: > The APIs in the rte_bus_vdev.h file were not part of the API > documentation. I added this header file to the doxygen config file with > the name vdev. > > Signed-off-by: A.McLoughlin Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v3 7/7] doc: update release notes for 19.08

From: Tomasz Jozwiak Added release note entry for test-compress-perf application Signed-off-by: Tomasz Jozwiak --- doc/guides/rel_notes/release_19_08.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst inde

[dpdk-dev] [PATCH v3 4/7] app/test-compress-perf: add benchmark test case

From: Tomasz Jozwiak This patch adds a benchmark part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/Makefile | 1 + app/test-compress-perf/comp_

[dpdk-dev] [PATCH v3 6/7] app/test-compress-perf: add force process termination

From: Tomasz Jozwiak This patch adds a possibility to force controlled process termination as a result of two signals: SIGTERM and SIGINT Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/comp_perf_options.h| 1 + app/test-compress-perf/comp_perf_test_benchmark.c | 13 +

[dpdk-dev] [PATCH v3 5/7] doc: update dpdk-test-compress-perf description

From: Tomasz Jozwiak This patch updates a dpdk-test-compress-perf documentation. Signed-off-by: Tomasz Jozwiak --- doc/guides/tools/comp_perf.rst | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/doc/guides/tools/comp_perf.rst b/doc/guides/

[dpdk-dev] [PATCH v3 3/7] app/test-compress-perf: add verification test case

From: Tomasz Jozwiak This patch adds a verification part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/Makefile| 1 + app/test-compress-perf/comp_perf_test_verify.c | 122 ++

[dpdk-dev] [PATCH v3 1/7] app/test-compress-perf: add weak functions for multi-cores test

From: Tomasz Jozwiak This patch adds a template functions for multi-cores performance version of compress-perf-tool. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/Makefile | 3 +- app/test-compress-perf/comp_perf.h | 6

[dpdk-dev] [PATCH v3 2/7] app/test-compress-perf: add ptest command line option

From: Tomasz Jozwiak This patch adds --ptest option to make possible a choose of test case from command line. Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/comp_perf_options_parse.c | 36 1 file changed, 36 insertions(+) diff --git a/app/test-compress-perf/

[dpdk-dev] [PATCH v3 0/7] add multiple cores feature to test-compress-perf

This patchset adds multiple cores feature to compression perf tool. All structures have been aligned and are consistent with crypto perf tool. All test cases have constructor, runner and destructor and can use more cores and compression devices at the same time. v2 changes: - fixed checkpatch w

Re: [dpdk-dev] 答复: [PATCH v5 14/15] net/hinic: add tx/rx package burst

On 6/26/2019 4:58 PM, Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions) wrote: >> On 6/19/2019 5:20 PM, Ziyang Xuan wrote: >>> This patch add package sending and receiving function codes. >>> >>> Signed-off-by: Ziyang Xuan >> >> <...> >> >>>

[dpdk-dev] 答复: [PATCH v5 14/15] net/hinic: add tx/rx package burst

> On 6/19/2019 5:20 PM, Ziyang Xuan wrote: > > This patch add package sending and receiving function codes. > > > > Signed-off-by: Ziyang Xuan > > <...> > > > @@ -543,6 +728,113 @@ void hinic_free_all_rx_skbs(struct hinic_rxq *rxq) > > } > > } > > > > +static inline void hinic_rq_cqe_be_to_

[dpdk-dev] [PATCH] doc: fix link to pdf document

The old link redirected to https://www.dpdk.org/events/. Signed-off-by: Ali Alnubani --- doc/guides/linux_gsg/linux_drivers.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/linux_gsg/linux_drivers.rst b/doc/guides/linux_gsg/linux_drivers.rst index 695edbb13..23

[dpdk-dev] [PATCH] doc/api: add missing header file to API documentation

The APIs in the rte_bus_vdev.h file were not part of the API documentation. I added this header file to the doxygen config file with the name vdev. Signed-off-by: A.McLoughlin --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in| 1 + drivers/bus/vdev/rte_bus_vdev.h | 6 ++

Re: [dpdk-dev] [PATCH v5 10/15] net/hinic: add various headers

> On 6/19/2019 5:08 PM, Ziyang Xuan wrote: > > Add various headers that define mgmt commands, cmdq commands, rx > data > > structures, tx data structures, private adapter data structures and > > basic defines for use in the code. > > > > Signed-off-by: Ziyang Xuan > > --- > > drivers/net/hinic/ba

[dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: support header reconstruction

This patch updates the ipsec-secgw application to support header reconstruction. In addition a series of tests have been added to prove the implementation's correctness. Signed-off-by: Fan Zhang --- doc/guides/rel_notes/release_19_08.rst | 6 + examples/ipsec-secgw/sa.c

[dpdk-dev] [PATCH v3 1/2] lib/ipsec: add support for header construction

Add support for RFC 4301(5.1.2) to update of Type of service field and Traffic class field bits inside ipv4/ipv6 packets for outbound cases and inbound cases which deals with the update of the DSCP/ENC bits inside each of the fields. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- l

[dpdk-dev] [PATCH v3 0/2] ipsec: ECN and DSCP header reconstruction

This patchset adds the ECN and DSCP tunnel mode header reconstruction support for rte_ipsec library. The ipsec-secgw sample application is updated with the feature's enabling and a python3 script for testing the correctness of the implementation. v3: - Rebased on top of latest dpdk-next-crypto. -

Re: [dpdk-dev] [PATCH v5] eal: do not panic on shared memory init

11/06/2019 10:07, David Marchand: > On Mon, Jun 10, 2019 at 9:09 AM Arnon Warshavsky wrote: > > > This patch changes some void functions to return a value, > > so that the init sequence may tear down orderly > > instead of calling panic. > > > > Signed-off-by: Arnon Warshavsky > > --- > > > > Th

Re: [dpdk-dev] [EXT] Re: [PATCH v6 2/4] lib/kni: add PCI related information

On Wed, 26 Jun 2019 03:48:12 + Vamsi Krishna Attunuru wrote: > > From: Stephen Hemminger > Sent: Tuesday, June 25, 2019 11:11 PM > To: Vamsi Krishna Attunuru > Cc: dev@dpdk.org; ferruh.yi...@intel.com; olivier.m...@6wind.com; > arybche...@solarflare.com > Su

Re: [dpdk-dev] [PATCH v5 11/15] net/hinic: add hinic PMD build and doc files

> On 6/19/2019 5:09 PM, Ziyang Xuan wrote: > > Add build and doc files along with hinic_pmd_ethdev.c which just > > includes PMD register and log initialization for compilation. > > > > Signed-off-by: Ziyang Xuan > <...> > > > @@ -17,3 +17,8 @@ CONFIG_RTE_TOOLCHAIN_ICC=y # Solarflare PMD > build

Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD

> > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > > explicitly in its build recipe, it restricts visibility of a non POSIX > > features subset, such as IANA protocol numbers (IPPROTO_* macros). > > Non standard features are enabled by default for DPDK both for Linux > > thanks

Re: [dpdk-dev] [PATCH v5 00/15] A new net PMD - hinic

> On 6/19/2019 4:45 PM, Ziyang Xuan wrote: > > This patch set adds support of a new net PMD for Huawei Intelligent > > nic. This patch provides supoort for basic RX/TX and the contorl path > > needed for it. > > Later on new features will be added like VLAN, VFs, etc. > > > > Basic features: > > 1.

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

On 6/26/19 3:24 PM, Matan Azrad wrote: -Original Message- From: Maxime Coquelin Sent: Wednesday, June 26, 2019 3:06 PM To: Matan Azrad ; Noa Ezra Cc: dev@dpdk.org; Tiwei Bie Subject: Re: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling On 6/26/19 1:18 PM, Matan Azrad wrote:

[dpdk-dev] [PATCH v2] eal/linux: fix return after alarm registration failure

When adding an alarm, if an error happen when registering the common alarm callback, it is not considered as a major failure. The alarm is then inserted in the list. However it was returning an error code after inserting the alarm. The error code is not set anymore to be consistent with the behavi

Re: [dpdk-dev] [PATCH v2] test/eal: add ut cases for in-memory and single-file-segment

On Wed, Jun 26, 2019 at 3:47 PM Pallantla Poornima < pallantlax.poorn...@intel.com> wrote: > Added unit test case for eal command line 'in-memory' option > which will cover below functions. > get_seg_memfd() > test_memfd_create() > pagesz_flags() > > Added unit test case for eal command line 'sing

[dpdk-dev] [PATCH v2] test/eal: add ut cases for in-memory and single-file-segment

Added unit test case for eal command line 'in-memory' option which will cover below functions. get_seg_memfd() test_memfd_create() pagesz_flags() Added unit test case for eal command line 'single-file-segments' option which will cover resize_hugefile(). Signed-off-by: Pallantla Poornima Reviewed

[dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix lack of ip type for crypto session

When ixgbe_crypto_add_sa() is called, it checks whether the ip type is IPv6 or IPv4 to write correct addresses to the registers. Type itself is never specified, and act as IPv4, which is the default value. It causes lack of support for IPv6. To fix that, ip type needs to be stored in device privat

[dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

Application ipsec-secgw is not working for IPv4 transport mode and for IPv6 both transport and tunnel mode. IPv6 tunnel mode is not working due to wrongly assigned fields of security association patterns, as it was IPv4, during creation of inline crypto session. IPv6 and IPv4 transport mode is it

[dpdk-dev] [PATCH v2 0/2] fixes for inline-crypto ipsec

Fixes for ipsec-secgw application to work with inline crypto IPv4 transport mode and IPv6 tunnel/transport modes. v2: * Added comment to WITHOUT_TRANSPORT_VERSION macro * Added macros around all ipsec_sa flags checks Mariusz Drost (2): net/ixgbe: fix lack of ip type for crypto session example

Re: [dpdk-dev] [PATCH v8 0/4] Enable rte_flow API in ice driver

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Wednesday, June 26, 2019 4:58 PM > To: dev@dpdk.org > Cc: Yang, Qiming > Subject: [dpdk-dev] [PATCH v8 0/4] Enable rte_flow API in ice driver > > This patch set enables the backend of rte_flow,

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 26, 2019 3:06 PM > To: Matan Azrad ; Noa Ezra > Cc: dev@dpdk.org; Tiwei Bie > Subject: Re: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling > > > > On 6/26/19 1:18 PM, Matan Azrad wrote: > > > > > > From: Maxime

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

On Wed, Jun 26, 2019 at 01:19:24PM +, Slava Ovsiienko wrote: > Hi, Bruce > > Do you mean using "if (core_rx_cycle_enabled) {...}" instead of #ifdef ? > > No, I did not try runtime control settings. > Instead I compared performance with all RECORD_CORE_XX_CYCLES options > enabled/disabled bui

Re: [dpdk-dev] [PATCH] eal/linux: fix return after alarm registration failure

26/06/2019 14:52, Burakov, Anatoly: > On 26-Jun-19 1:36 PM, Bruce Richardson wrote: > > On Wed, Jun 26, 2019 at 01:55:53PM +0200, Thomas Monjalon wrote: > >> 26/06/2019 13:43, Burakov, Anatoly: > >>> On 26-Jun-19 12:39 PM, David Marchand wrote: > On Wed, Jun 26, 2019 at 1:36 PM Thomas Monjalon

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

Hi, Bruce Do you mean using "if (core_rx_cycle_enabled) {...}" instead of #ifdef ? No, I did not try runtime control settings. Instead I compared performance with all RECORD_CORE_XX_CYCLES options enabled/disabled builds and have seen the ~1-2% performance difference on my setups (mainly fwd txo

Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and mempool driver

On 6/22/2019 2:23 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > This patch set adds initial driver support for OCTEON TX2 SoC. > > OCTEON TX2 is an armv8.2 SoC with integrated HW based mempool, ethdev, > cryptodev, compressdev, and eventdev devices. > > This patch set adds common driver

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

On Wed, Jun 26, 2019 at 12:48:37PM +, Viacheslav Ovsiienko wrote: > There is the testpmd configuration option called > RTE_TEST_PMD_RECORD_CORE_CYCLES, if this one is turned on > the testpmd application measures the CPU clocks spent > within forwarding loop. This time is the sum of execution >

Re: [dpdk-dev] [PATCH] eal/linux: fix return after alarm registration failure

On 26-Jun-19 1:36 PM, Bruce Richardson wrote: On Wed, Jun 26, 2019 at 01:55:53PM +0200, Thomas Monjalon wrote: 26/06/2019 13:43, Burakov, Anatoly: On 26-Jun-19 12:39 PM, David Marchand wrote: On Wed, Jun 26, 2019 at 1:36 PM Thomas Monjalon wrote: 26/06/2019 13:20, David Marchand: On Wed, J

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] eal/freebsd: add config reattach

On 26-Jun-19 1:21 PM, David Marchand wrote: On Wed, Jun 26, 2019 at 2:03 PM David Marchand wrote: On Tue, Jun 25, 2019 at 5:51 PM Anatoly Burakov wrote: Linux EAL will attach the shared config at an arbitrary address, find out where the shared config is mapped in the primary, and then wil

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] eal/freebsd: add config reattach

On 26-Jun-19 1:03 PM, David Marchand wrote: On Tue, Jun 25, 2019 at 5:51 PM Anatoly Burakov wrote: Linux EAL will attach the shared config at an arbitrary address, find out where the shared config is mapped in the primary, and then will reattach it at that exact address. FreeBSD version doesn

[dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

There is the testpmd configuration option called RTE_TEST_PMD_RECORD_CORE_CYCLES, if this one is turned on the testpmd application measures the CPU clocks spent within forwarding loop. This time is the sum of execution times of rte_eth_rx_burst(), rte_eth_tx_burst(), rte_delay_us(), rte_pktmbuf_fr

Re: [dpdk-dev] [PATCH] eal/linux: fix return after alarm registration failure

On Wed, Jun 26, 2019 at 01:55:53PM +0200, Thomas Monjalon wrote: > 26/06/2019 13:43, Burakov, Anatoly: > > On 26-Jun-19 12:39 PM, David Marchand wrote: > > > On Wed, Jun 26, 2019 at 1:36 PM Thomas Monjalon > > > wrote: > > > > > >> 26/06/2019 13:20, David Marchand: > > >>> On Wed, Jun 26, 2019 a

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] eal/freebsd: add config reattach

On Wed, Jun 26, 2019 at 2:03 PM David Marchand wrote: > > > On Tue, Jun 25, 2019 at 5:51 PM Anatoly Burakov > wrote: > >> Linux EAL will attach the shared config at an arbitrary address, >> find out where the shared config is mapped in the primary, and >> then will reattach it at that exact addr

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

On 6/26/19 1:18 PM, Matan Azrad wrote: From: Maxime Coquelin On 6/26/19 9:50 AM, Matan Azrad wrote: Hi Maxim Any response here? Besides that, Regarding the TSO and this patch: I think we shouldn't be so strict to not take them for this version: 1. The later time was a technical issue wi

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal/freebsd: fix missing write to internal config

On Tue, Jun 25, 2019 at 5:51 PM Anatoly Burakov wrote: > When init is complete, EAL is supposed to update internal config > to indicate that initialization is complete. Add missing write. > > Fixes: a99c96e96ad3 ("eal: add internal flag of init completed") > Cc: sta...@dpdk.org > > Signed-off-by:

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] eal/freebsd: add config reattach

On Tue, Jun 25, 2019 at 5:51 PM Anatoly Burakov wrote: > Linux EAL will attach the shared config at an arbitrary address, > find out where the shared config is mapped in the primary, and > then will reattach it at that exact address. > > FreeBSD version doesn't seem to go for that extra reattach

Re: [dpdk-dev] [PATCH v5 00/15] A new net PMD - hinic

On 6/19/2019 4:45 PM, Ziyang Xuan wrote: > This patch set adds support of a new net PMD > for Huawei Intelligent nic. This patch provides supoort > for basic RX/TX and the contorl path needed for it. > Later on new features will be added like VLAN, VFs, etc. > > Basic features: > 1. Basic device o

Re: [dpdk-dev] [PATCH v5 11/15] net/hinic: add hinic PMD build and doc files

On 6/19/2019 5:09 PM, Ziyang Xuan wrote: > Add build and doc files along with hinic_pmd_ethdev.c > which just includes PMD register and log initialization > for compilation. > > Signed-off-by: Ziyang Xuan <...> > @@ -17,3 +17,8 @@ CONFIG_RTE_TOOLCHAIN_ICC=y > # Solarflare PMD build is not suppo

Re: [dpdk-dev] [PATCH] eal/linux: fix return after alarm registration failure

26/06/2019 13:43, Burakov, Anatoly: > On 26-Jun-19 12:39 PM, David Marchand wrote: > > On Wed, Jun 26, 2019 at 1:36 PM Thomas Monjalon wrote: > > > >> 26/06/2019 13:20, David Marchand: > >>> On Wed, Jun 26, 2019 at 12:41 PM Thomas Monjalon > >>> wrote: > >>> > When adding an alarm, if an er

Re: [dpdk-dev] [PATCH v5 10/15] net/hinic: add various headers

On 6/19/2019 5:08 PM, Ziyang Xuan wrote: > Add various headers that define mgmt commands, cmdq commands, > rx data structures, tx data structures, private adapter data > structures and basic defines for use in the code. > > Signed-off-by: Ziyang Xuan > --- > drivers/net/hinic/base/hinic_compat.h

Re: [dpdk-dev] [PATCH v5 14/15] net/hinic: add tx/rx package burst

On 6/19/2019 5:20 PM, Ziyang Xuan wrote: > This patch add package sending and receiving function codes. > > Signed-off-by: Ziyang Xuan <...> > @@ -543,6 +728,113 @@ void hinic_free_all_rx_skbs(struct hinic_rxq *rxq) > } > } > > +static inline void hinic_rq_cqe_be_to_cpu32(void *dst_le3

Re: [dpdk-dev] [PATCH] eal/linux: fix return after alarm registration failure

On 26-Jun-19 12:39 PM, David Marchand wrote: On Wed, Jun 26, 2019 at 1:36 PM Thomas Monjalon wrote: 26/06/2019 13:20, David Marchand: On Wed, Jun 26, 2019 at 12:41 PM Thomas Monjalon wrote: When adding an alarm, if an error happen when registering the common alarm callback, it is not consi

Re: [dpdk-dev] [PATCH] eal/linux: fix return after alarm registration failure

On Wed, Jun 26, 2019 at 1:36 PM Thomas Monjalon wrote: > 26/06/2019 13:20, David Marchand: > > On Wed, Jun 26, 2019 at 12:41 PM Thomas Monjalon > > wrote: > > > > > When adding an alarm, if an error happen when registering > > > the common alarm callback, it is not considered as a major failure.

Re: [dpdk-dev] [PATCH] eal/linux: fix return after alarm registration failure

26/06/2019 13:20, David Marchand: > On Wed, Jun 26, 2019 at 12:41 PM Thomas Monjalon > wrote: > > > When adding an alarm, if an error happen when registering > > the common alarm callback, it is not considered as a major failure. > > The alarm is then inserted in the list. > > However it was retu

Re: [dpdk-dev] [PATCH] eal/linux: fix return after alarm registration failure

On Wed, Jun 26, 2019 at 12:41 PM Thomas Monjalon wrote: > When adding an alarm, if an error happen when registering > the common alarm callback, it is not considered as a major failure. > The alarm is then inserted in the list. > However it was returning an error code after inserting the alarm. >

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

From: Maxime Coquelin > On 6/26/19 9:50 AM, Matan Azrad wrote: > > Hi Maxim > > > > Any response here? > > > > Besides that, > > > > Regarding the TSO and this patch: > > I think we shouldn't be so strict to not take them for this version: > > 1. The later time was a technical issue with the mail

[dpdk-dev] [PATCH] eal/linux: fix return after alarm registration failure

When adding an alarm, if an error happen when registering the common alarm callback, it is not considered as a major failure. The alarm is then inserted in the list. However it was returning an error code after inserting the alarm. The error code is reset to 0 so the behaviour and the return code

  1   2   >