Mellanox NICs support the wide set of Tx offloads. The supported
offloads are reported by the mlx5 PMD in rte_eth_dev_info tx_offload_capa
field. An application may choose any combination of supported offloads
and configure the device appropriately. Some of Tx offloads may be
not requested by appli
This patch updates the Tx datapath control and configuration
structures and code for mananging Tx datapath settings.
Signed-off-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_rxtx.c | 4 +-
drivers/net/mlx5/mlx5_rxtx.h | 55 +
drivers/net/mlx5/mlx5_txq.c | 182 +++
This patch introduces new mlx5 PMD devarg options:
- txq_inline_min - specifies minimal amount of data to be inlined into
WQE during Tx operations. NICs may require this minimal data amount
to operate correctly. The exact value may depend on NIC operation mode,
requested offloads, etc.
- tx
This patch updates Tx datapath definitions, mostly hardware related.
The Tx descriptor structures are redefined with required fields,
size definitions are renamed to reflect the meanings in more
appropriate way. This is a preparation step before introducing
the new Tx datapath implementation.
Sign
This patch adds the implementation of tx_burst routine template.
The template supports all Tx offloads and multiple optimized
tx_burst routines can be generated by compiler from this one.
Signed-off-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_rxtx.c | 2897
Tx data packet data may be inlined into transmit descriptor.
At some circumstances ConnectX NICs may require data to be
inlined for correct operation. The exact data amount may
depend on NIC operation mode, requested Tx offloads,
E-Switch configuration, etc.
The number of data bytes to inline may
This patch fills the tx_desc_lim.nb_seg_max and
tx_desc_lim.nb_mtu_seg_max fields of rte_eth_dev_info
structure to report thee maximal number of packet
segments, requested inline data configuration is
taken into account in conservative way.
Signed-off-by: Viacheslav Ovsiienko
---
drivers/net/mlx
This patch removes the existing Tx datapath code
as preparation step before introducing the new
implementation. The following entities are being
removed:
- obsolete devargs
- tx_burst() routines
- related PRM definitions
- SQ configuration code
- Tx routine selection code
- incompatible Tx complet
This patchset introduces the new implementation of tx_burst
routine of mlx5 PMD. The existing implementation is based on the
several branches of tx_burst routines optimizied for most
common sets of Tx hardware offload, supported by Mellanox NICs.
It was not very easy to update, support and develop
Hi,
> -Original Message-
> From: dev On Behalf Of Matan Azrad
> Sent: Tuesday, July 16, 2019 5:35 PM
> To: Shahaf Shuler ; Yongseok Koh
> ; Slava Ovsiienko
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: accelerate DV flow counters
> mangement
>
> New features in devx to
https://bugs.dpdk.org/show_bug.cgi?id=324
Bug ID: 324
Summary: eal/cmdline_autotest failed
Product: DPDK
Version: 19.08
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: Norm
> -Original Message-
> From: Hyong Youb Kim (hyonkim)
> Sent: Wednesday, July 17, 2019 11:26 AM
> To: Nithin Kumar Dabilpuram ; David Marchand
> ; Thomas Monjalon
> ; Ferruh Yigit ; Bruce
> Richardson
> Cc: Jerin Jacob Kollanukkaran ; John Daley (johndale)
> ; Shahed Shaikh ;
> dev@dpdk.o
> -Original Message-
> From: Nithin Dabilpuram
> Sent: Wednesday, July 17, 2019 1:44 AM
[...]
> Subject: [RFC PATCH v3 3/3] drivers/net: use unmask API in interrupt
> handlers
>
> Replace rte_intr_enable() with rte_intr_unmask() API
> for unmasking in interrupt handlers and rx_queue_intr_
> -Original Message-
> From: Nithin Dabilpuram
> Sent: Wednesday, July 17, 2019 1:44 AM
> To: Hyong Youb Kim (hyonkim) ; David Marchand
> ; Thomas Monjalon
> ; Ferruh Yigit ; Bruce
> Richardson
> Cc: jer...@marvell.com; John Daley (johndale) ;
> Shahed Shaikh ; dev@dpdk.org; Nithin Dabilp
Add hmac(sha1), cbc(aes) authenc tests in the test mechanism.
Signed-off-by: Nagadheeraj Rottela
---
app/test/test_cryptodev.c | 52 ++
app/test/test_cryptodev.h | 1 +
app/test/test_cryptodev_aes_test_vectors.h | 30 +++-
Add all the session management operations.
Signed-off-by: Nagadheeraj Rottela
---
drivers/crypto/nitrox/nitrox_sym.c | 323 -
drivers/crypto/nitrox/nitrox_sym_ctx.h | 85 +
2 files changed, 405 insertions(+), 3 deletions(-)
create mode 100644 drivers
Add burst enqueue and dequeue operations along with interface for
symmetric request manager.
Signed-off-by: Nagadheeraj Rottela
---
drivers/crypto/nitrox/nitrox_qp.h | 55 ++
drivers/crypto/nitrox/nitrox_sym.c| 123 -
drivers/crypto/nitrox/nitrox_sym_
Add cipher auth crypto chain processing functionality in symmetric
request manager.
Signed-off-by: Nagadheeraj Rottela
---
drivers/crypto/nitrox/nitrox_sym_reqmgr.c | 427 +-
1 file changed, 425 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/nitrox/nitrox_
Add software queue management code corresponding to queue pair setup
and release functions.
Signed-off-by: Nagadheeraj Rottela
---
drivers/crypto/nitrox/Makefile| 2 +
drivers/crypto/nitrox/meson.build | 2 +
drivers/crypto/nitrox/nitrox_qp.c | 74 +++
Add the following cryptodev operations,
- dev_configure
- dev_start
- dev_stop
- dev_close
- dev_infos_get
Signed-off-by: Nagadheeraj Rottela
---
doc/guides/cryptodevs/features/nitrox.ini | 38
doc/guides/cryptodevs/nitrox.rst| 37 +++
drivers/crypto/ni
Add hardware queue management code corresponding to queue pair setup
and release functions.
Signed-off-by: Nagadheeraj Rottela
---
drivers/crypto/nitrox/nitrox_csr.h | 13
drivers/crypto/nitrox/nitrox_hal.c | 151 +
drivers/crypto/nitrox/nitrox_hal.h | 1
Add Nitrox symmetric cryptodev with no operations. Cryptodev
operations will be added in the next set of patches. Also, registered
nitrox log type.
Signed-off-by: Nagadheeraj Rottela
---
drivers/crypto/nitrox/Makefile| 2 +
drivers/crypto/nitrox/meson.build | 2 +
drivers/crypto/ni
Add pci probe, remove and hardware init routines.
Signed-off-by: Nagadheeraj Rottela
---
drivers/crypto/nitrox/Makefile| 1 +
drivers/crypto/nitrox/meson.build | 1 +
drivers/crypto/nitrox/nitrox_csr.h| 28 +
drivers/crypto/nitrox/nitrox_device.c | 105 ++
Add bare minimum Nitrox PMD library and doc build infrastructure and
claim responsibility by updating the maintainers file.
Signed-off-by: Nagadheeraj Rottela
---
MAINTAINERS | 7 ++
config/common_base | 5 +
doc/guides
Add the Nitrox PMD to support Nitrox crypto device.
Nagadheeraj Rottela (10):
crypto/nitrox: add Nitrox build and doc skeleton
crypto/nitrox: add PCI probe and remove routines
crypto/nitrox: create Nitrox symmetric cryptodev
crypto/nitrox: add basic symmetric cryptodev operations
crypto/
2019年7月16日 下午10:19,He Peng 写道:
Hi,
2019年7月16日 下午9:51,Stephen Hemminger 写道:
On Wed, 17 Jul 2019 02:26:57 GMT
He Peng wrote:
Hi,
In file dpdk/lib/librte_eal/common/rte_malloc.c:
/*
* Allocate memory on default heap.
*/
void *
rte_malloc(const char *type, size_t size, unsigned alig
Hi,
2019年7月16日 下午9:51,Stephen Hemminger 写道:
On Wed, 17 Jul 2019 02:26:57 GMT
He Peng wrote:
Hi,
In file dpdk/lib/librte_eal/common/rte_malloc.c:
/*
* Allocate memory on default heap.
*/
void *
rte_malloc(const char *type, size_t size, unsigned align)
{
return rte_malloc_socket(type,
On Wed, 17 Jul 2019 12:31:00 +0800
Qi Zhang wrote:
> Exclude 4 bytes CRC for rx bytes stats.
> This also aligned Rx stats calculation with PF.
>
> Fixes: f4a41a6953af ("net/avf: support stats")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Qi Zhang
> ---
> drivers/net/iavf/iavf_ethdev.c | 1 +
> 1
On Wed, 17 Jul 2019 02:26:57 GMT
He Peng wrote:
> Hi,
>
> In file dpdk/lib/librte_eal/common/rte_malloc.c:
>
> /*
> * Allocate memory on default heap.
> */
> void *
> rte_malloc(const char *type, size_t size, unsigned align)
> {
> return rte_malloc_socket(type, size, align, SOCKET_ID_ANY);
>
Exclude 4 bytes CRC for rx bytes stats.
This also aligned Rx stats calculation with PF.
Fixes: f4a41a6953af ("net/avf: support stats")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
---
drivers/net/iavf/iavf_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/iavf/iavf_ethdev.
> -Original Message-
> From: Wang, Xiao W
> Sent: Tuesday, July 16, 2019 7:31 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Wang, Xiao W
> Subject: [PATCH] net/ifc: add devargs pointer check
>
> We need to check devargs pointer before dereference it, if no devargs
> specified
> then this
Hi,
In file dpdk/lib/librte_eal/common/rte_malloc.c:
/*
* Allocate memory on default heap.
*/
void *
rte_malloc(const char *type, size_t size, unsigned align)
{
return rte_malloc_socket(type, size, align, SOCKET_ID_ANY);
}
/*
* Allocate zero'd memory on specified heap.
*/
void *
rte_zmalloc_s
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, July 16, 2019 10:45 PM
> To: Zhang, Xiao ; dev@dpdk.org
> Cc: Zhang, Qi Z ; Wang, Xiao W
> ; Xing, Beilei ; Lu, Wenzhuo
> ; Yang, Qiming ;
> sta...@dpdk.org
> Subject: Re: [dpdk-stable] [v2] drivers/net: fix dereference after null
On Tue, 19-07-16, 18:41, Ferruh Yigit wrote:
> On 7/10/2019 11:43 AM, Xiaoyu Min wrote:
> > This patch intend to support
> > action_raw_encap/decap [1] in a generic and convenient way.
> >
> > Two new commands - set raw_encap, set raw_decap are introduced just
> > like the other commands for encap
Fixes: c33d45af3633 ("net/ark: add Tx initial version")
Cc: sta...@dpdk.org
Signed-off-by: Ed Czeck
---
drivers/net/ark/ark_ethdev_rx.c | 4 +---
drivers/net/ark/ark_ethdev_tx.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the resources
for the port can be freed by rte_eth_dev_close()
Signed-off-by: Ed Czeck
---
drivers/net/ark/ark_ethdev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 86e500
The generic RTE_LOGTYPE_PMD is a historical relic and should
not be used. Every driver must use dynamic logtypes.
Compile tested only!
Signed-off-by: Stephen Hemminger
---
drivers/net/ena/base/ena_plat_dpdk.h | 20 ++--
drivers/net/ena/ena_ethdev.c | 167 ---
dr
The generic RTE_LOGTYPE_PMD is a historical relic and should
not be used. Bonding driver was still using it in one place.
Signed-off-by: Stephen Hemminger
---
drivers/net/bonding/rte_eth_bond_args.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_b
On 7/16/2019 12:13 PM, Michal Krawczyk wrote:
> In 2.0.1 ENA, there were patches for:
> * assigning NUMA node to the IO queue
> commit 4217cb0b7d2c ("net/ena: fix assigning NUMA node to IO queue")
> * statistics counters (Rx checksum errors and per-queue number of the
> Tx packets)
>
On Tue, 16 Jul 2019 22:14:22 +0530
Nithin Dabilpuram wrote:
> This reverts commit 89aac60e0be9ed95a87b16e3595f102f9faaffb4.
> "vfio: fix interrupts race condition"
>
> The above mentioned commit moves the interrupt's eventfd setup
> to probe time but only enables one interrupt for all types of
>
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, July 16, 2019 10:07 AM
> To: Gavin Hu (Arm Technology China)
> Cc: Olivier Matz ; dev@dpdk.org; nd
> ; jer...@marvell.com; hemant.agra...@nxp.com;
> nipun.gu...@nxp.com; Honnappa Nagarahalli
> ; i.maxim...@samsung.co
Currently, the flush is done by dequeuing the ring in a while loop. It is
much simpler to flush the queue by resetting the head and tail indices.
Signed-off-by: Gavin Hu
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
Acked-by: Olivier Matz
---
lib/librte_ring/rte_ring.c
Within rte_hash_reset, calling a while loop to dequeue one by
one from the ring, while not using them at all, is wasting cycles,
The patch just flush the ring by resetting the indices can save cpu
cycles.
Signed-off-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
Acked-by: Yipeng Wang
---
lib/l
V2:
- fix the coding style issue(commit message line too long)
V3:
- allow experimental API for meson build
V4:
- include the ring perf test case enhancement patch in the series.
- replace ARRAY_SIZE with RTE_DIM.
- call memset to avoid clang compling complains.
V5:
- commit message tweaking for r
The generic RTE_LOGTYPE_PMD is a historical relic and should
will be deprecated in near future. Every driver must register its own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/ark/ark_ethdev.c | 9 +
drivers/net/ark/ark_logs.h | 25 ++---
2 files chang
The generic RTE_LOGTYPE_PMD is a historical relic and should
be deprecated. Every driver must register its own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/cxgbe/cxgbe_compat.h | 7 +--
drivers/net/cxgbe/cxgbe_ethdev.c | 9 +
2 files changed, 14 insertions(+), 2 deletion
This patch removes RSA PKCS1_5 BT0 padding from test cases
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 8391545..0e1277b 100644
---
This patch adds information about format of the message should have
before sending it to the signing operation when using RSA algorithm.
Signed-off-by: Arek Kusztal
---
lib/librte_cryptodev/rte_crypto_asym.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/librte_cryptodev/rte_cr
This patch adds an example how to use padding none option with RSA.
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 46 +-
1 file changed, 37 insertions(+), 9 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_crypto
This patch adds function to simulate pkcs1_5 padding, it serves nothing
else than example. It provides no security and should not be used in
security context.
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym_util.h | 54 +
1 file changed, 54 insert
This patch adds RSA padding none description.
Signed-off-by: Arek Kusztal
---
lib/librte_cryptodev/rte_crypto_asym.h | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
b/lib/librte_cryptodev/rte_crypto_asym.h
index 5026042..7f630
BT0 block type padding after rfc2313 has been discontinued.
Signed-off-by: Arek Kusztal
---
lib/librte_cryptodev/rte_crypto_asym.h | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
b/lib/librte_cryptodev/rte_crypto_asym.h
This patch removes RSA PKCS1_5 BT0 padding from openssl PMD.
Signed-off-by: Arek Kusztal
---
drivers/crypto/openssl/rte_openssl_pmd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
b/drivers/crypto/openssl/rte_openssl_pmd.c
index
This patch adds cipher field to RSA test cases
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 4dee164..8391545 100644
--- a/app/test/test_cryptodev_asym.c
Asymmetric nature of RSA algorithm suggest to use
additional field for output. In place operations
still can be done by setting cipher and message pointers
with the same memory address.
Signed-off-by: Arek Kusztal
---
lib/librte_cryptodev/rte_crypto_asym.h | 26 +-
1 file
RSA modulus cannot be prime as its security basing on integer
factorization.
Signed-off-by: Arek Kusztal
---
lib/librte_cryptodev/rte_crypto_asym.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
b/lib/librte_cryptodev/rte_crypto_
This commit adds cipher field to openssl pmd to comfort to
API change.
Signed-off-by: Arek Kusztal
---
drivers/crypto/openssl/rte_openssl_pmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
b/drivers/crypto/openssl/rte_opens
Split into smaller commits, in order from least disputable ones.
Open things beside this:
1. Creating padding struct
2. Padding parameters (seedlen, optional label etc)
3. Leading zeroes questions.
4. Random number requirements.
5. Capabilities.
6. Verify signature field when none padding.
v3:
-
All log messages should use driver logtype. RTE_LOGTYPE_PMD is
planned to be deprecated in the future.
Signed-off-by: Stephen Hemminger
---
drivers/net/octeontx/octeontx_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev.c
b/drivers
On 7/16/2019 10:28 AM, Ajit Khaparde wrote:
> Patchset fixing various bugs in bnxt PMD based on recent patch submission.
> https://patchwork.dpdk.org/patch/56311/
> Please apply.
>
> Note this patchset supersedes the previous patch series:
> https://patchwork.dpdk.org/project/dpdk/list/?series=546
Some configuration options can not be tested properly with testpmd
because it automatically starts all ports. This makes it harder
to test driver handling of configuration options:
(for example rx_deferred_start).
Add new command line flag --disable-device-start which skips
the device start. The p
On 7/16/2019 7:29 PM, Stephen Hemminger wrote:
> Some configuration options can not be tested properly with current
> testpmd because it automatically starts all ports.
> This makes it harder to test driver handling of configuration options:
> (for example rx_deferred_start) which maybe buggy in so
On 7/10/2019 2:07 PM, Nithin Dabilpuram wrote:
> With the latest published interface of
> rte_eal_hotplug_[add,remove](), and rte_eth_dev_close(),
> rte_eth_dev_close() would cleanup all the data structures of
> port's eth dev leaving the device common resource intact
> if RTE_ETH_DEV_CLOSE_REMOVE
Some configuration options can not be tested properly with current
testpmd because it automatically starts all ports.
This makes it harder to test driver handling of configuration options:
(for example rx_deferred_start) which maybe buggy in some
drivers.
Add new command line flag --disable-device
On 7/16/2019 3:31 PM, Ferruh Yigit wrote:
> On 7/16/2019 3:26 PM, A.McLoughlin wrote:
>> Because of the commit mentioned below the default case was changed and
>> this broke single_iface support. This patch adds a check to fix
>> single_iface support.
>>
>> Fixes: a3f5252e5cbd ("net/pcap: enable in
On 7/10/2019 11:43 AM, Xiaoyu Min wrote:
> This patch intend to support
> action_raw_encap/decap [1] in a generic and convenient way.
>
> Two new commands - set raw_encap, set raw_decap are introduced just
> like the other commands for encap/decap, i.e. set vxlan.
>
> These two commands have corr
In general, DPDK libraries to not print error messages to
stdout because that is often redirected to /dev/null for daemons.
This patch changes cfgfile library to use RTE_LOG with its
own type.
Signed-off-by: Stephen Hemminger
---
lib/librte_cfgfile/rte_cfgfile.c| 25 +++--
Better to use calloc when allocating arrays.
Signed-off-by: Stephen Hemminger
---
lib/librte_cfgfile/rte_cfgfile.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
index c4b768b6833f..39fec4b82bce 100
No need to initialize variable if it is immediately overwritten.
It is better style not do unnecessary initialization with modern
tools since it lets compiler and other static checkers detect
uninitialized data.
Signed-off-by: Stephen Hemminger
---
lib/librte_cfgfile/rte_cfgfile.c | 8
Some small patches for the cfgfile library
Stephen Hemminger (3):
cfgfile: remove unnecessary initialization
cfgfile: use RTE_LOG for errors
cfgfile: use calloc
lib/librte_cfgfile/rte_cfgfile.c| 42 ++---
lib/librte_eal/common/include/rte_log.h | 1 +
2 files c
The key size for memif is 256 but the unix domain socket structure has
space for 100 bytes. Change it to use a larger buffer and not hard
code the keysize everywhere.
Not sure what purpose of socket is anyway since there is no code
which connects to it in the current tree anyway?
Still an RFC, ha
The key size for memif is 256 but the unix domain socket structure has
space for 100 bytes. Change it to use a larger buffer and not hard
code the keysize everywhere.
Not sure what purpose of socket is anyway since there is no code
which connects to it in the current tree anyway?
Still and RFC si
On 7/11/2019 3:15 PM, Ferruh Yigit wrote:
> On 7/11/2019 2:59 PM, A.McLoughlin wrote:
>> In the eth_pcap_tx() and eth_pcap_tx_dumper() functions mbufs were freed
>> without incrementing num_tx. To fix the issue, the mbuf freeing was
>> removed as it was not of any benefit.
>>
>> Fixes: 6db141c91e1f
The state of virtio device has been defined in both header file and
source file, keep the definition in header file for public use.
Fixes: a50245ede72a ("examples/tep_term: initialize VXLAN sample")
Cc: sta...@dpdk.org
Signed-off-by: Haiyue Wang
---
examples/tep_termination/main.c | 5 -
1
This reverts commit 89aac60e0be9ed95a87b16e3595f102f9faaffb4.
"vfio: fix interrupts race condition"
The above mentioned commit moves the interrupt's eventfd setup
to probe time but only enables one interrupt for all types of
interrupt handles i.e VFIO_MSI, VFIO_LEGACY, VFIO_MSIX, UIO.
It works fin
Replace rte_intr_enable() with rte_intr_unmask() API
for unmasking in interrupt handlers and rx_queue_intr_enable()
in callbacks of PMD's whose original intent was to unmask interrupts
after handling is completed if device is backed by UIO, IGB_UIO or
VFIO(with INTx).
Signed-off-by: Nithin Dabilpu
Add new mask and unmask interrupt APIs to avoid using
VFIO_IRQ_SET_ACTION_TRIGGER for masking/unmasking purpose for VFIO
based handlers. This implementation is specific to Linux.
Using action trigger for masking and unmasking has below issues
* Time consuming to do for every interrupt received a
On 7/10/2019 6:11 PM, Lance Richardson wrote:
> Fix an overrun of the ring group array with BCM5750X-based
> adapters by ensuring that the ring group array is not allocated
> or accessed for adapters that do not support ring groups.
>
> Fixes: f8168ca0e690 ("net/bnxt: support thor controller")
> S
On Tue, 16 Jul 2019 01:17:56 +
"Li, WenjieX A" wrote:
> Hi Stephen,
>
>
>
> This DPDK patch makes cmdline_autotest failed. List the details as below.
>
> Could you please help to resolve it?
>
> Thank you!
> Test Setup
> Steps to reproduce
> List the steps to reproduce the issue.
> ./x86
On 7/10/2019 3:24 PM, Lance Richardson wrote:
> The conditional used to determine whether freeing RSS
> contexts for thor vs. non-thor controller was reversed.
> Fix this, also reset number of active RSS contexts to
> zero after release in the thor case.
>
> Fixes: 38412304b50a ("net/bnxt: enable
Previously in the PCAP PMD it was only possibe to specify an rxq which
uses an iface or a pcap file. This patch creates a 'dummy Rx' function
which is used when no rx_pcap or rx_iface is passed but a tx queue is
passed. This function can be polled and receives no packets.
Signed-off-by: A.McLoughl
The generic RTE_LOGTYPE_PMD is a historical relic and should
not be used. Every driver must dynamic log types.
Signed-off-by: Stephen Hemminger
---
drivers/net/iavf/iavf_ethdev.c | 28
drivers/net/iavf/iavf_log.h| 19 +--
2 files changed, 41 inser
The generic RTE_LOGTYPE_PMD is a historical relic and should
not be used. Every driver must dynamic log types.
Signed-off-by: Stephen Hemminger
---
drivers/net/i40e/i40e_ethdev.c | 27 +++
drivers/net/i40e/i40e_logs.h | 24 +++-
2 files changed, 42 i
The generic RTE_LOGTYPE_PMD is a historical relic and should
not be used. Every driver must dynamic log types.
Signed-off-by: Stephen Hemminger
---
drivers/net/ice/ice_ethdev.c | 27 +++
drivers/net/ice/ice_logs.h | 18 --
2 files changed, 39 insertions(
The generic RTE_LOGTYPE_PMD is a historical relic and should
not be used. Every driver should register the logtypes
for itself.
Signed-off-by: Stephen Hemminger
---
drivers/net/e1000/e1000_logs.c | 48 +++---
drivers/net/e1000/e1000_logs.h | 25 +++---
2 f
The generic RTE_LOGTYPE_PMD is a historical relic and should
not be used. Every driver must dynamic log types.
Signed-off-by: Stephen Hemminger
---
drivers/net/ixgbe/ixgbe_ethdev.c | 27 +++
drivers/net/ixgbe/ixgbe_logs.h | 24 +++-
drivers/net/ixgbe
The generic RTE_LOGTYPE_PMD is a historical relic and should
not be used. Every driver must dynamic log types.
Signed-off-by: Stephen Hemminger
---
drivers/net/fm10k/fm10k_ethdev.c | 28
drivers/net/fm10k/fm10k_logs.h | 18 --
2 files changed, 40 in
The RTE_LOGTYPE_PMD has been superseded by individual driver
logtypes. There still is still some vestigtial usage in the
Intel driver code. This patch set converts all of these to
use logtype_tx and logtype_rx.
Stephen Hemminger (6):
net/e1000: use dynamic log type for tx/rx debug
net/fm10k: u
On 7/5/2019 3:51 PM, Olivier Matz wrote:
> On Mon, Jun 24, 2019 at 02:46:02PM +0100, Andrew Rybchenko wrote:
>> From: Dilshod Urazov
>>
>> Layer 2 length must be updated after the prepend to mbuf to keep
>> the length right to be used by other Tx offloads.
>>
>> If the packet has tunnel encapsulat
On 7/16/2019 4:00 PM, Andrew Rybchenko wrote:
> On 7/16/19 5:28 PM, Bruce Richardson wrote:
>> On Tue, Jul 16, 2019 at 03:23:03PM +0100, Ferruh Yigit wrote:
>>> On 7/16/2019 1:23 PM, Andrew Rybchenko wrote:
On 7/15/19 5:53 PM, Ferruh Yigit wrote:
> On 7/12/2019 9:32 AM, A.McLoughlin wrote:
I am yet to look at changes here but I am sure I still have some opens to be
agreed upon here.
Arek,
If you are submitting it in smaller patches , I will spend time on them then.
Thanks
Shally
Sent from Workspace ONE Boxer
On 16-Jul-2019 7:57 PM, "Trahe, Fiona" wrote:
>
> External Email
>
>
>
> On 16-Jul-19 2:46 PM, jer...@marvell.com wrote:
> > From: David Marchand
> >
> > The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA
> which
> > was intended to mean "driver only supports VA" but had been understood
> > as "driver supports both PA and VA" by most net drivers and u
16/07/2019 16:03, Gavin Hu (Arm Technology China):
> From: Olivier Matz
> > On Tue, Jul 16, 2019 at 11:01:21AM +0200, Olivier Matz wrote:
> > > On Fri, Jul 12, 2019 at 11:54:36PM +0800, Gavin Hu wrote:
> > > > Currently, the flush is done by dequeuing the ring in a while loop. It
> > > > is
> > >
On 7/16/19 5:28 PM, Bruce Richardson wrote:
On Tue, Jul 16, 2019 at 03:23:03PM +0100, Ferruh Yigit wrote:
On 7/16/2019 1:23 PM, Andrew Rybchenko wrote:
On 7/15/19 5:53 PM, Ferruh Yigit wrote:
On 7/12/2019 9:32 AM, A.McLoughlin wrote:
The 'Accumulated forward statistics for all ports' incorrec
> -Original Message-
> From: Bruce Richardson
> Sent: Tuesday, July 16, 2019 3:31 AM
> To: Carrillo, Erik G
> Cc: 'Stephen Hemminger' ;
> 'tho...@monjalon.net' ; 'dev@dpdk.org'
>
> Subject: Re: [dpdk-dev] [PATCH 1/2] timer: fix null pointer dereference
>
> On Mon, Jul 15, 2019 at 07:
On 7/16/2019 3:52 PM, Stephen Hemminger wrote:
> On Mon, 15 Jul 2019 22:37:20 -0700
> John Daley wrote:
>
>> Don't use RTE_LOGTYPE_PMD as it is too general.
>>
>> Also, just use 1 log type for all of enic PMD (pmd.net.enic)
>>
>> Signed-off-by: John Daley
>> Reviewed-by: Hyong Youb Kim
>
> Loo
On Mon, 15 Jul 2019 22:37:20 -0700
John Daley wrote:
> Don't use RTE_LOGTYPE_PMD as it is too general.
>
> Also, just use 1 log type for all of enic PMD (pmd.net.enic)
>
> Signed-off-by: John Daley
> Reviewed-by: Hyong Youb Kim
Looks good. I have a set of patches to kill all LOGTYPE_PMD
but
On Tue, 16 Jul 2019 09:46:04 +0100
Bruce Richardson wrote:
> On Mon, Jul 15, 2019 at 05:19:12PM -0700, Stephen Hemminger wrote:
> > On Mon, 15 Jul 2019 16:41:36 -0700
> > Stephen Hemminger wrote:
> >
> > > If DPDK is built as a shared library, then any application linked
> > > with rte.app.mk
On 7/16/2019 3:35 PM, Zhang, Xiao wrote:
>
>> -Original Message-
>> From: Yigit, Ferruh
>> Sent: Tuesday, July 16, 2019 10:26 PM
>> To: Zhang, Xiao ; dev@dpdk.org
>> Cc: Zhang, Qi Z ; Wang, Xiao W
>> ; Xing, Beilei ; Lu,
>> Wenzhuo ; Yang, Qiming ;
>> sta...@dpdk.org
>> Subject: Re: [dpdk-
On Tue, 16 Jul 2019 11:39:50 +0200
Olivier Matz wrote:
> On Fri, Jul 12, 2019 at 12:23:19PM +, Jerin Jacob Kollanukkaran wrote:
> > > -Original Message-
> > > From: dev On Behalf Of Olivier Matz
> > > Sent: Thursday, July 11, 2019 1:07 PM
> > > To: Stephen Hemminger
> > > Cc: dev@dp
1 - 100 of 205 matches
Mail list logo