[dpdk-dev] [PATCH] buildtools: fix pmdinfogen compilation

2019-07-30 Thread pbhagavatula
From: Pavan Nikhilesh Pmdinfogen is always compiled with host gcc. If host gcc version is lessthan 7 and target gcc is greaterthan 7 pmdinfogen fails to compile due to unsupported cflags. This patch removes unsupported host cflags when the above condition is met. Fixes: 98b0fdb0ffc6 ("pmdinfogen

Re: [dpdk-dev] [PATCH v3] net/mlx5: add workaround for VLAN in virtual machine

2019-07-30 Thread Shahaf Shuler
Tuesday, July 30, 2019 12:20 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v3] net/mlx5: add workaround for VLAN in > virtual machine > > On some virtual setups (particularly on ESXi) when we have SR-IOV and E- > Switch enabled there is the problem to receive VLAN traffic on VF interfaces

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] app/testpmd: fix scatter offload configuration

2019-07-30 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit > On 7/30/2019 7:34 PM, Matan Azrad wrote: > > > > > > From: Ferruh Yigit > >> On 7/30/2019 4:56 PM, Matan Azrad wrote: > >>> Hi Ferruh > >>> > >>> From: Ferruh Yigit > Sent: Tuesday, July 30, 2019 6:22 PM > To: Matan Azrad ; Wenzhuo Lu > ; Jingjing Wu

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 1/1] fbarray: get fbarrays from containerized secondary

2019-07-30 Thread Yasufumi Ogawa
On 2019/07/30 18:18, Burakov, Anatoly wrote: On 30-Jul-19 9:16 AM, Thomas Monjalon wrote: 24/07/2019 11:59, Burakov, Anatoly: On 24-Jul-19 9:20 AM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique

[dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-30 Thread Takeshi Yoshimura
Commit b76fafb174d2 ("eal: fix IOVA mode selection as VA for PCI drivers") breaks ppc apps with no IOVA configs (or RTE_IOVA_DC) because of the inconsistency of user's request and the result of device capability for IOVA mode. I updated the code to force IOVA as PA in ppc as before because current

Re: [dpdk-dev] [PATCH] examples/bpf: fix compilation issue

2019-07-30 Thread Varghese, Vipin
snipped > Example BPF programs t1.c, t2.c, t3.c in folder examples/bpf are failing to > compile with latest dpdk.org master. As a note, the file t3.c is one which fails to get compiled. > The reason is changes in some core DPDK header files, that causes now > inclusion > of x86 specific headers

Re: [dpdk-dev] [RFC,v2] ethdev: extend RSS offload types

2019-07-30 Thread Su, Simei
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, July 30, 2019 11:50 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > adrien.mazarg...@6wind.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC,v2] ethdev: extend RSS offload types >

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix unaligned memory access

2019-07-30 Thread Ruifeng Wang (Arm Technology China)
> -Original Message- > From: David Christensen > Sent: Wednesday, July 31, 2019 01:45 > To: jer...@marvell.com; Bruce Richardson ; > tho...@monjalon.net > Cc: dev@dpdk.org; sta...@dpdk.org; hgovindh > ; Marko Kovacevic > ; Ori Kam ; Pablo de > Lara ; Radu Nicolau > ; akhil.go...@nxp.com;

[dpdk-dev] [dpdk-announce] release candidate 19.08-rc3

2019-07-30 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.08-rc3 124 patches were integrated. The release notes are almost complete: http://doc.dpdk.org/guides/rel_notes/release_19_08.html There are some open bugs to check in bugzilla: https

Re: [dpdk-dev] [PATCH] doc: update features supported by mlx

2019-07-30 Thread Thomas Monjalon
30/07/2019 18:32, Matan Azrad: > From: Thomas Monjalon > > Flow control was not documented as a supported feature since the first fill > > of > > features matrix for mlx drivers. > > > > Flow API and CRC offload flag support in mlx4 were missing in the feature > > matrix when they were implemente

Re: [dpdk-dev] [PATCH] test: fix undefined behavior in flow classify test

2019-07-30 Thread Thomas Monjalon
30/07/2019 23:31, Aaron Conole: > The unit test for the flow classify introduced undefined behavior by using > a corrupted list. Remove these tests as the invalid data is impossible to > detect with the current API. > > Fixes: 9c9befea4f57 ("test: add flow classify unit tests") > Cc: Bernard Irem

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] usertools: replace unsafe input function

2019-07-30 Thread Thomas Monjalon
08/04/2019 15:54, Andrius Sirvys: > LGTM static code analysis tool reports that the function 'input' is > unsafe. Changed to use raw_input which then converts it using > ast.literal_eval() which is safe. > > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > Cc: ciara.po...@intel

Re: [dpdk-dev] [PATCH v3] devtools: better freebsd support

2019-07-30 Thread Thomas Monjalon
29/07/2019 10:31, David Marchand: > On Thu, Jul 11, 2019 at 4:25 PM Olivier Matz wrote: > > > > - As "readlink -e" and "readlink -m" do not exist on freebsd, > > use "readlink -f", it should not have any impact in these cases. > > - "sed -ri" is invalid on freebsd and should be replaced by > >

Re: [dpdk-dev] [PATCH] devtools: fix building kernel component tags

2019-07-30 Thread Thomas Monjalon
17/07/2019 17:54, jer...@marvell.com: > From: Jerin Jacob > > Update devtools/build-tags.sh to account the kernel > components under in kernel directory. > > Fixes: acaa9ee991b5 ("move kernel modules directories") > Cc: sta...@dpdk.org > > Signed-off-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [PATCH v4 0/3] Small usability improvements for devbind

2019-07-30 Thread Thomas Monjalon
> Anatoly Burakov (3): > usertools/devbind: add error on forgetting to specify driver > usertools/devbind: check if module is loaded before binding > usertools/devbind: print all errors to stderr Applied, thanks

[dpdk-dev] [PATCH] librte_acl: fix undefined behavior

2019-07-30 Thread Aaron Conole
Left-shift of an integer constant is represented as 'int' type, but a left shift of 1 by 31 bits in 'int' is undefined. Use the U suffix to force a representation as unsigned. Caught while running with ubsan under gcc. Fixes: dc276b5780c2 ("acl: new library") Cc: Konstantin Ananyev Signed-off-b

Re: [dpdk-dev] [PATCH] mk: fix printing target name when build completes

2019-07-30 Thread Thomas Monjalon
04/06/2019 11:21, kka...@marvell.com: > --- a/config/defconfig_x86_64-native-linuxapp-gcc > +++ b/config/defconfig_x86_64-native-linuxapp-gcc > +CONFIG_RTE_EXEC_ENV="linux" Why do you do this change in this file? I think changing this variable can break backward compatibility.

[dpdk-dev] [PATCH] test: fix undefined behavior in flow classify test

2019-07-30 Thread Aaron Conole
The unit test for the flow classify introduced undefined behavior by using a corrupted list. Remove these tests as the invalid data is impossible to detect with the current API. Fixes: 9c9befea4f57 ("test: add flow classify unit tests") Cc: Bernard Iremonger Cc: Jasvinder Singh Signed-off-by: A

Re: [dpdk-dev] [PATCH] doc: remove unused maintainer role from guide

2019-07-30 Thread Thomas Monjalon
> > The backup maintainer role is not explicitly used in the file MAINTAINERS. > > Listing names in a priority order is preferred and more flexible than > > explicit named roles. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: John McNamara Applied

Re: [dpdk-dev] [PATCH v1] doc: update release notes for 19.08

2019-07-30 Thread Thomas Monjalon
30/07/2019 15:24, John McNamara: > Fix grammar, spelling and formatting of DPDK 19.08 release notes. > > Signed-off-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH V2] doc: add tested Intel platforms with Intel NICs

2019-07-30 Thread Thomas Monjalon
> > From: Wenjie Li > > > > Add tested Intel platforms with Intel NICs to v19.08 release note. > > > > Signed-off-by: Wenjie Li > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] maintainers: add co-maintainer to sched library

2019-07-30 Thread Thomas Monjalon
> > Add myself as a co-maintainer to dpdk sched library. > > > > Signed-off-by: Jasvinder Singh > > --- > > Hierarchical scheduler > > M: Cristian Dumitrescu > > +M: Jasvinder Singh > > F: lib/librte_sched/ > > F: doc/guides/prog_guide/qos_framework.rst > > F: app/test/test_red.c > > Acke

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal: fix ctrl thread affinity with --lcores

2019-07-30 Thread Thomas Monjalon
30/07/2019 17:05, David Marchand: > The ctrl thread cpu affinity setting has been broken when using --lcores. > > Using -l/-c options makes each lcore associated to a physical cpu in a 1:1 > fashion. > On the contrary, when using --lcores, each lcore cpu affinity can be set > to a list of any onli

Re: [dpdk-dev] [PATCH] eal: fix ctrl thread affinity with --lcores

2019-07-30 Thread Johan Källström
Hi, for the online check I referred to the check of "default_set" via the initial thread affinity. I see that pthread_getaffinity_np returns an already and:ed mask, was under the impression that pthread_getaffinity_np would return the same mask as was set using pthread_setaffinity_np. Looking

[dpdk-dev] [PATCH 6/6] mk: replace license text with SPDX tag

2019-07-30 Thread David Christensen
Replace license text with SPDX tag on PPC files. Signed-off-by: David Christensen --- mk/arch/ppc_64/rte.vars.mk| 32 ++-- mk/machine/power8/rte.vars.mk | 31 ++- 2 files changed, 4 insertions(+), 59 deletions(-) diff --git a/mk/arch/p

[dpdk-dev] [PATCH 5/6] librte_lpm: replace license text with SPDX tag

2019-07-30 Thread David Christensen
Replace license text with SPDX tag on PPC files. Signed-off-by: David Christensen --- lib/librte_lpm/rte_lpm_altivec.h | 33 +++-- 1 file changed, 3 insertions(+), 30 deletions(-) diff --git a/lib/librte_lpm/rte_lpm_altivec.h b/lib/librte_lpm/rte_lpm_altivec.h index

[dpdk-dev] [PATCH 4/6] librte_eal: replace license text with SPDX tag

2019-07-30 Thread David Christensen
Replace license text with SPDX tag on PPC files. Signed-off-by: David Christensen --- lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 33 +++- 1 file changed, 3 insertions(+), 30 deletions(-) diff --git a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c b/lib/librte_eal/

[dpdk-dev] [PATCH 0/6] add SPDX tag to files for Power architecture

2019-07-30 Thread David Christensen
This patchset replaces the full BSD 3 clause license headers with the SPDX tag for remaining files used for Power architecture. David Christensen (6): config: replace license text with SPDX tag librte_eal: replace license text with SPDX tag librte_acl: replace license text with SPDX tag li

[dpdk-dev] [PATCH 3/6] librte_acl: replace license text with SPDX tag

2019-07-30 Thread David Christensen
Replace license text with SPDX tag on PPC files. Signed-off-by: David Christensen --- lib/librte_acl/acl_run_altivec.c | 34 +++--- lib/librte_acl/acl_run_altivec.h | 33 +++-- 2 files changed, 6 insertions(+), 61 deletions(-) diff --git a

[dpdk-dev] [PATCH 2/6] librte_eal: replace license text with SPDX tag

2019-07-30 Thread David Christensen
Replace license text with SPDX tag on PPC files. Signed-off-by: David Christensen --- .../common/include/arch/ppc_64/rte_atomic.h| 35 ++-- .../common/include/arch/ppc_64/rte_byteorder.h | 38 +++--- .../common/include/arch/ppc_64/rte_cpuflags.h |

[dpdk-dev] [PATCH 1/6] config: replace license text with SPDX tag

2019-07-30 Thread David Christensen
Replace license text with SPDX tag on PPC files. Signed-off-by: David Christensen --- config/defconfig_ppc_64-power8-linuxapp-gcc | 31 ++--- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/config/defconfig_ppc

Re: [dpdk-dev] [PATCH v5] Examples/l3fwd: fix unaligned memory access

2019-07-30 Thread Thomas Monjalon
30/07/2019 17:48, Lipiec, Herakliusz: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hariprasad > > Govindharajan > > > > Fix unaligned memory access when reading IPv6 header which leads to > > segmentation fault by changing aligned memory read to unaligned memory > > read. > > > > Bugz

Re: [dpdk-dev] [PATCH] eal: fix ctrl thread affinity with --lcores

2019-07-30 Thread David Marchand
On Tue, Jul 30, 2019 at 6:32 PM Johan Källström wrote: > > Hi, for the online check I referred to the check of "default_set" via the > initial thread affinity. > > I see that pthread_getaffinity_np returns an already and:ed mask, was under > the impression that pthread_getaffinity_np would retur

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] app/testpmd: fix scatter offload configuration

2019-07-30 Thread Ferruh Yigit
On 7/30/2019 7:34 PM, Matan Azrad wrote: > > > From: Ferruh Yigit >> On 7/30/2019 4:56 PM, Matan Azrad wrote: >>> Hi Ferruh >>> >>> From: Ferruh Yigit Sent: Tuesday, July 30, 2019 6:22 PM To: Matan Azrad ; Wenzhuo Lu ; Jingjing Wu Cc: dev@dpdk.org; sta...@dpdk.org Subj

Re: [dpdk-dev] [dpdk-stable] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-30 Thread Adrien Mazarguil
On Tue, Jul 30, 2019 at 01:27:41PM -0400, Aaron Conole wrote: > Ferruh Yigit writes: > > > On 7/30/2019 5:18 PM, Adrien Mazarguil wrote: > >> On Tue, Jul 30, 2019 at 03:48:31PM +0100, Ferruh Yigit wrote: > >>> On 7/30/2019 3:42 PM, Aaron Conole wrote: > David Marchand writes: > > >

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration

2019-07-30 Thread Matan Azrad
From: Ferruh Yigit > On 7/30/2019 4:56 PM, Matan Azrad wrote: > > Hi Ferruh > > > > From: Ferruh Yigit > >> Sent: Tuesday, July 30, 2019 6:22 PM > >> To: Matan Azrad ; Wenzhuo Lu > >> ; Jingjing Wu > >> Cc: dev@dpdk.org; sta...@dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/bpf: fix compilation issue

2019-07-30 Thread Thomas Monjalon
30/07/2019 12:19, Konstantin Ananyev: > Example BPF programs t1.c, t2.c, t3.c in folder examples/bpf are > failing to compile with latest dpdk.org master. > The reason is changes in some core DPDK header files, that causes > now inclusion of x86 specific headers. > To overcome the issue, minimize i

Re: [dpdk-dev] [PATCH] net/virtio: fix build errors

2019-07-30 Thread Thomas Monjalon
30/07/2019 18:12, Maxime Coquelin: > On 7/30/19 1:04 PM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Add extern to variable declaration to avoid some compiler treating it > > as variable definition. > > > > build error log: > > > > lib/librte_pmd_virtio.a(vhost_kernel.o):(.rodata+0x

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix unaligned memory access

2019-07-30 Thread David Christensen
On Tue, Jul 30, 2019 at 10:50:14AM +0200, Thomas Monjalon wrote: Review please? 26/07/2019 15:58, hgovindh: Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("ex

Re: [dpdk-dev] [PATCH v2 0/2] standardize rawdev names

2019-07-30 Thread Thomas Monjalon
30/07/2019 15:39, Thomas Monjalon: > The names of the rawdev drivers and the resultant libraries they built > were pretty inconsistent. In terms of directory names, some had "rawdev" > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > Also, for the built .so/.a libraries, the

[dpdk-dev] [PATCH v3 2/2] devtools: allow misc options in null test

2019-07-30 Thread Thomas Monjalon
In order to ease basic testing with customized options, EAL and testpmd options can be added as third and fourth arguments of the "null PMD" script. Also, the first argument becomes more flexible by accepting the testpmd path as an alternative to the build directory. Signed-off-by: Thomas Monjalo

[dpdk-dev] [PATCH v3 1/2] devtools: restore null test

2019-07-30 Thread Thomas Monjalon
This small testpmd test was not working for a long time because of several changes in EAL and mempool. The 3 main issues solved are: - Make --no-huge working by specifying an amount of memory to allocate in legacy mode, and disabling mlockall. - Load a mempool handle

Re: [dpdk-dev] [dpdk-stable] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-30 Thread Aaron Conole
Ferruh Yigit writes: > On 7/30/2019 4:43 PM, Aaron Conole wrote: >> Ferruh Yigit writes: >> >>> On 7/30/2019 3:42 PM, Aaron Conole wrote: David Marchand writes: > On Wed, Jul 10, 2019 at 11:49 PM Thomas Monjalon > wrote: >> >> 09/07/2019 13:09, Bernard Iremonger: >>

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration

2019-07-30 Thread Ferruh Yigit
On 7/30/2019 4:56 PM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit >> Sent: Tuesday, July 30, 2019 6:22 PM >> To: Matan Azrad ; Wenzhuo Lu >> ; Jingjing Wu >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload >> configuration >> >>

Re: [dpdk-dev] [dpdk-stable] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-30 Thread Aaron Conole
Ferruh Yigit writes: > On 7/30/2019 5:18 PM, Adrien Mazarguil wrote: >> On Tue, Jul 30, 2019 at 03:48:31PM +0100, Ferruh Yigit wrote: >>> On 7/30/2019 3:42 PM, Aaron Conole wrote: David Marchand writes: > On Wed, Jul 10, 2019 at 11:49 PM Thomas Monjalon > wrote: >> >>

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: set Rx checksum flags in vector mode receive

2019-07-30 Thread Ferruh Yigit
On 7/30/2019 4:45 PM, Somnath Kotur wrote: > On Tue, Jul 30, 2019 at 2:58 AM Lance Richardson > wrote: >> >> From: Kalesh AP >> >> Fixed to return the checksum status of rx packets by setting >> "ol_flags" correctly in vector mode receive. >> >> These changes have been there for non vector mode r

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix context memory allocation

2019-07-30 Thread Ferruh Yigit
On 7/29/2019 10:28 PM, Lance Richardson wrote: > From: Kalesh AP > > There is a bug in context memory allocation because of which > it results in reusing the context memory allocated for the first > port while allocating memory for next ports. > > Fix it by passing the port id in the name field

[dpdk-dev] [PATCH v3] eal: warn on legacy memory allocation requirement

2019-07-30 Thread Thomas Monjalon
When using --no-huge mode, dynamic allocation is not supported. Because of this limitation, the option --legacy-mem is implied and -m may be needed to specify the amount of memory to allocate. Otherwise the default amount MEMSIZE_IF_NO_HUGE_PAGE will be allocated. The option --socket-mem can also

Re: [dpdk-dev] [dpdk-stable] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-30 Thread Ferruh Yigit
On 7/30/2019 4:43 PM, Aaron Conole wrote: > Ferruh Yigit writes: > >> On 7/30/2019 3:42 PM, Aaron Conole wrote: >>> David Marchand writes: >>> On Wed, Jul 10, 2019 at 11:49 PM Thomas Monjalon wrote: > > 09/07/2019 13:09, Bernard Iremonger: >> This patch fixes the out-of-b

Re: [dpdk-dev] [PATCH v4 1/4] examples/multi_process/client_server_mp: check port validity

2019-07-30 Thread Stephen Hemminger
On Tue, 30 Jul 2019 16:39:52 + Matan Azrad wrote: > Hi > > From: Stephen Hemminger > > On Tue, 30 Jul 2019 09:21:02 + > > Matan Azrad wrote: > > > > > Hi Stephen > > > > > > From: Stephen Hemminger > > > > From: Stephen Hemminger > > > > > > > > The mp_server incorrectly allows a

Re: [dpdk-dev] [PATCH v4 1/4] examples/multi_process/client_server_mp: check port validity

2019-07-30 Thread Matan Azrad
Hi From: Stephen Hemminger > On Tue, 30 Jul 2019 09:21:02 + > Matan Azrad wrote: > > > Hi Stephen > > > > From: Stephen Hemminger > > > From: Stephen Hemminger > > > > > > The mp_server incorrectly allows a port mask that included hidden > > > ports and which later caused either lost packe

Re: [dpdk-dev] [dpdk-stable] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-30 Thread Ferruh Yigit
On 7/30/2019 5:18 PM, Adrien Mazarguil wrote: > On Tue, Jul 30, 2019 at 03:48:31PM +0100, Ferruh Yigit wrote: >> On 7/30/2019 3:42 PM, Aaron Conole wrote: >>> David Marchand writes: >>> On Wed, Jul 10, 2019 at 11:49 PM Thomas Monjalon wrote: > > 09/07/2019 13:09, Bernard Iremon

Re: [dpdk-dev] [PATCH] doc: update features supported by mlx

2019-07-30 Thread Matan Azrad
From: Thomas Monjalon > Flow control was not documented as a supported feature since the first fill of > features matrix for mlx drivers. > > Flow API and CRC offload flag support in mlx4 were missing in the feature > matrix when they were implemented (see below commits). > > Fixes: 46d5736a70

Re: [dpdk-dev] [EXT] Re: [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, July 30, 2019 9:36 PM > To: Jerin Jacob Kollanukkaran > Cc: Marcin Zapolski ; dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions > non-inline > > On Tue, Jul 30, 2019 at 03:45:38PM +

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Stephen Hemminger
On Tue, 30 Jul 2019 17:11:31 +0100 Bruce Richardson wrote: > On Tue, Jul 30, 2019 at 08:54:13AM -0700, Stephen Hemminger wrote: > > On Tue, 30 Jul 2019 16:33:55 +0100 > > Bruce Richardson wrote: > > > > > On Tue, Jul 30, 2019 at 08:25:34AM -0700, Stephen Hemminger wrote: > > > > On Tue, 30

Re: [dpdk-dev] [dpdk-stable] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-30 Thread Adrien Mazarguil
On Tue, Jul 30, 2019 at 03:48:31PM +0100, Ferruh Yigit wrote: > On 7/30/2019 3:42 PM, Aaron Conole wrote: > > David Marchand writes: > > > >> On Wed, Jul 10, 2019 at 11:49 PM Thomas Monjalon > >> wrote: > >>> > >>> 09/07/2019 13:09, Bernard Iremonger: > This patch fixes the out-of-bounds c

Re: [dpdk-dev] [PATCH] net/virtio: fix build errors

2019-07-30 Thread Maxime Coquelin
On 7/30/19 1:04 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > Add extern to variable declaration to avoid some compiler treating it > as variable definition. > > build error log: > > lib/librte_pmd_virtio.a(vhost_kernel.o):(.rodata+0x110): > multiple definition of `vhost_msg_strings'

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Bruce Richardson
On Tue, Jul 30, 2019 at 08:54:13AM -0700, Stephen Hemminger wrote: > On Tue, 30 Jul 2019 16:33:55 +0100 > Bruce Richardson wrote: > > > On Tue, Jul 30, 2019 at 08:25:34AM -0700, Stephen Hemminger wrote: > > > On Tue, 30 Jul 2019 14:49:49 +0200 > > > Marcin Zapolski wrote: > > > > > > > Make r

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Bruce Richardson
On Tue, Jul 30, 2019 at 03:45:38PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, July 30, 2019 9:02 PM > > To: Jerin Jacob Kollanukkaran > > Cc: Marcin Zapolski ; dev@dpdk.org > > Subject: [EXT] Re: [dpdk-dev] [RFC 19.11 1/2]

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Wiles, Keith
> On Jul 30, 2019, at 10:54 AM, Stephen Hemminger > wrote: > > On Tue, 30 Jul 2019 16:33:55 +0100 > Bruce Richardson wrote: > >> On Tue, Jul 30, 2019 at 08:25:34AM -0700, Stephen Hemminger wrote: >>> On Tue, 30 Jul 2019 14:49:49 +0200 >>> Marcin Zapolski wrote: >>> Make rte_eth_rx_bu

[dpdk-dev] [RFC PATCH] drivers/net: deprecate private API for VF ports

2019-07-30 Thread Thomas Monjalon
Since the concept of representors was introduced, we do not need any specific API for VF ports. Any VF port should be able to be configured through its representor port in a more generic fashion. Signed-off-by: Thomas Monjalon --- drivers/net/bnxt/rte_pmd_bnxt.h | 15 ++- drivers/n

[dpdk-dev] [PATCH] doc: remove deprecated ethdev features

2019-07-30 Thread Thomas Monjalon
As legacy filter API "filter_ctrl" is superseded since 2017 by the rte_flow API, and got the deprecated attribute in DPDK 19.05, it is time to remove the associated features from the matrix. Not documenting deprecated features as supported will avoid confusion. Signed-off-by: Thomas Monjalon ---

[dpdk-dev] [PATCH] doc: update features supported by mlx

2019-07-30 Thread Thomas Monjalon
Flow control was not documented as a supported feature since the first fill of features matrix for mlx drivers. Flow API and CRC offload flag support in mlx4 were missing in the feature matrix when they were implemented (see below commits). Fixes: 46d5736a7049 ("net/mlx4: support basic flow items

Re: [dpdk-dev] [PATCH v4 1/4] examples/multi_process/client_server_mp: check port validity

2019-07-30 Thread Stephen Hemminger
On Tue, 30 Jul 2019 09:21:02 + Matan Azrad wrote: > Hi Stephen > > From: Stephen Hemminger > > From: Stephen Hemminger > > > > The mp_server incorrectly allows a port mask that included hidden ports and > > which later caused either lost packets or failed initialization. > > > > This fix

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration

2019-07-30 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit > Sent: Tuesday, July 30, 2019 6:22 PM > To: Matan Azrad ; Wenzhuo Lu > ; Jingjing Wu > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload > configuration > > On 7/30/2019 2:17 PM, Matan Azrad wrote: > > Hi Ferru

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Stephen Hemminger
On Tue, 30 Jul 2019 16:33:55 +0100 Bruce Richardson wrote: > On Tue, Jul 30, 2019 at 08:25:34AM -0700, Stephen Hemminger wrote: > > On Tue, 30 Jul 2019 14:49:49 +0200 > > Marcin Zapolski wrote: > > > > > Make rte_eth_rx_burst, rte_eth_tx_burst and other static inline ethdev > > > functions no

[dpdk-dev] [PATCH v3 1/2] eal: make base address hint OS-specific

2019-07-30 Thread Anatoly Burakov
Not all OS's follow Linux's memory layout, which may lead to problems following the suggested common address hint absent of a base-virtaddr flag. Make this address hint OS-specific. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 19 +--

[dpdk-dev] [PATCH v3 2/2] eal: use base address hint to reserve space for mem config

2019-07-30 Thread Anatoly Burakov
Currently, mem config will be mapped without using the virtual area reservation infrastructure, which means it will be mapped at an arbitrary location. This may cause failures to map the shared config in secondary process due to things like PCI whitelist arguments allocating memory in a space where

Re: [dpdk-dev] [RFC,v2] ethdev: extend RSS offload types

2019-07-30 Thread Stephen Hemminger
On Fri, 26 Jul 2019 08:35:50 +0800 simei wrote: > From: Simei Su > > This RFC reserves several bits as input set selection from bottom > of the 64 bits. The flow type is combined with input set to > represent rss types. > > Correct the input set mask to align with the definition in rte_ethdev.

Re: [dpdk-dev] [PATCH v5] Examples/l3fwd: fix unaligned memory access

2019-07-30 Thread Lipiec, Herakliusz
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hariprasad > Govindharajan > > Fix unaligned memory access when reading IPv6 header which leads to > segmentation fault by changing aligned memory read to unaligned memory > read. > > Bugzilla ID: 279 > Fixes: 64d3955de1de ("examples/l3fwd:

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, July 30, 2019 9:02 PM > To: Jerin Jacob Kollanukkaran > Cc: Marcin Zapolski ; dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions > non-inline > >

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: set Rx checksum flags in vector mode receive

2019-07-30 Thread Somnath Kotur
On Tue, Jul 30, 2019 at 9:02 PM Ferruh Yigit wrote: > > On 7/29/2019 10:28 PM, Lance Richardson wrote: > > From: Kalesh AP > > > > Fixed to return the checksum status of rx packets by setting > > "ol_flags" correctly in vector mode receive. > > > > These changes have been there for non vector mod

Re: [dpdk-dev] [dpdk-stable] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-30 Thread Aaron Conole
Ferruh Yigit writes: > On 7/30/2019 3:42 PM, Aaron Conole wrote: >> David Marchand writes: >> >>> On Wed, Jul 10, 2019 at 11:49 PM Thomas Monjalon >>> wrote: 09/07/2019 13:09, Bernard Iremonger: > This patch fixes the out-of-bounds coverity issue by removing the > offending

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: set Rx checksum flags in vector mode receive

2019-07-30 Thread Somnath Kotur
On Tue, Jul 30, 2019 at 2:58 AM Lance Richardson wrote: > > From: Kalesh AP > > Fixed to return the checksum status of rx packets by setting > "ol_flags" correctly in vector mode receive. > > These changes have been there for non vector mode receive. > In vector mode receive also indicate inner a

[dpdk-dev] [PATCH v2 1/2] eal: make base address hint OS-specific

2019-07-30 Thread Anatoly Burakov
Not all OS's follow Linux's memory layout, which may lead to problems following the suggested common address hint absent of a base-virtaddr flag. Make this address hint OS-specific. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 19 +--

[dpdk-dev] [PATCH v2 2/2] eal: use base address hint to reserve space for mem config

2019-07-30 Thread Anatoly Burakov
Currently, mem config will be mapped without using the virtual area reservation infrastructure, which means it will be mapped at an arbitrary location. This may cause failures to map the shared config in secondary process due to things like PCI whitelist arguments allocating memory in a space where

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Bruce Richardson
On Tue, Jul 30, 2019 at 08:25:34AM -0700, Stephen Hemminger wrote: > On Tue, 30 Jul 2019 14:49:49 +0200 > Marcin Zapolski wrote: > > > Make rte_eth_rx_burst, rte_eth_tx_burst and other static inline ethdev > > functions not inline. They are referencing DPDK internal structures and > > inlining fo

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: set Rx checksum flags in vector mode receive

2019-07-30 Thread Ferruh Yigit
On 7/29/2019 10:28 PM, Lance Richardson wrote: > From: Kalesh AP > > Fixed to return the checksum status of rx packets by setting > "ol_flags" correctly in vector mode receive. > > These changes have been there for non vector mode receive. > In vector mode receive also indicate inner and outer c

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Bruce Richardson
On Tue, Jul 30, 2019 at 03:01:00PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- From: dev On Behalf > > Of Marcin Zapolski Sent: Tuesday, July 30, 2019 6:20 PM To: > > dev@dpdk.org Cc: Marcin Zapolski > > Subject: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functio

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Stephen Hemminger
On Tue, 30 Jul 2019 14:49:49 +0200 Marcin Zapolski wrote: > Make rte_eth_rx_burst, rte_eth_tx_burst and other static inline ethdev > functions not inline. They are referencing DPDK internal structures and > inlining forces those structures to be exposed to user applications. > > In internal test

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration

2019-07-30 Thread Ferruh Yigit
On 7/30/2019 2:17 PM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit >> Sent: Tuesday, July 30, 2019 4:09 PM >> To: Matan Azrad ; Wenzhuo Lu >> ; Jingjing Wu >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload >> configuration >> >>

[dpdk-dev] [PATCH v2] eal: fix ctrl thread affinity with --lcores

2019-07-30 Thread David Marchand
The ctrl thread cpu affinity setting has been broken when using --lcores. Using -l/-c options makes each lcore associated to a physical cpu in a 1:1 fashion. On the contrary, when using --lcores, each lcore cpu affinity can be set to a list of any online cpu on the system. To handle both cases, e

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Marcin Zapolski > Sent: Tuesday, July 30, 2019 6:20 PM > To: dev@dpdk.org > Cc: Marcin Zapolski > Subject: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non- > inline > > Make rte_eth_rx_burst, rte_eth_tx_burst and other static

Re: [dpdk-dev] [RFC 19.11 2/2] ethdev: hide DPDK internal struct from public API

2019-07-30 Thread Ferruh Yigit
On 7/30/2019 1:49 PM, Marcin Zapolski wrote: > Remove rte_eth_dev, rte_eth_dev_data and rte_eth_dev_ops from > public API (make rte_ethdev_core APIs private). They are DPDK internal > structures and as such should not be accessed by user applications > directly. > > Signed-off-by: Marcin Zapolski

Re: [dpdk-dev] [dpdk-stable] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-30 Thread Ferruh Yigit
On 7/30/2019 3:42 PM, Aaron Conole wrote: > David Marchand writes: > >> On Wed, Jul 10, 2019 at 11:49 PM Thomas Monjalon wrote: >>> >>> 09/07/2019 13:09, Bernard Iremonger: This patch fixes the out-of-bounds coverity issue by removing the offending line of code at line 107 in rte_flow_

Re: [dpdk-dev] [dpdk-stable] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-30 Thread Ferruh Yigit
On 7/29/2019 2:09 PM, David Marchand wrote: > On Wed, Jul 10, 2019 at 11:49 PM Thomas Monjalon wrote: >> >> 09/07/2019 13:09, Bernard Iremonger: >>> This patch fixes the out-of-bounds coverity issue by removing the >>> offending line of code at line 107 in rte_flow_classify_parse.c >>> which is ne

Re: [dpdk-dev] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-30 Thread Aaron Conole
David Marchand writes: > On Wed, Jul 10, 2019 at 11:49 PM Thomas Monjalon wrote: >> >> 09/07/2019 13:09, Bernard Iremonger: >> > This patch fixes the out-of-bounds coverity issue by removing the >> > offending line of code at line 107 in rte_flow_classify_parse.c >> > which is never executed. >>

[dpdk-dev] [PATCH] net/octeontx2: drop Rx and L2 error packets

2019-07-30 Thread jerinj
From: Jerin Jacob >From B0 HW revision onwards, HW can drop the Rx and L2 error packets. Enable this by default if the feature is available. Since this bit field is used as reserved in old HW revisions, No need to have additional HW version check. Signed-off-by: Jerin Jacob --- drivers/net/oct

Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix crash in dev_info_get in secondary process

2019-07-30 Thread Matan Azrad
Hi Stephen From: Stephen Hemminger > mlx4_dev_info_get calls mlx4_get_ifname, but mlx4_get_ifname uses priv- > >ctx which is not a valid pointer in a secondary process. The fix is to cache > >the > value in primary. > > In the primary process, get and store the interface index of the device so

Re: [dpdk-dev] [PATCH] eal: fix ctrl thread affinity with --lcores

2019-07-30 Thread David Marchand
On Tue, Jul 30, 2019 at 1:38 PM Johan Källström wrote: > The CPU failsafe is nice to have as you could set the thread affinity to > offline cpus. Created a "dpdk" cpuset and put cpus 4-7 into it (my system is mono numa with 8 cpus) # cd /sys/fs/cgroup/cpuset/ # mkdir dpdk # cd dpdk # echo 4-7 >

[dpdk-dev] [PATCH v2 2/2] drivers/raw: standardize naming

2019-07-30 Thread Thomas Monjalon
From: Bruce Richardson The driver names for rawdevs were both different in make and meson builds and were non-standard in the make version in that some included "rawdev" in the name while others didn't. Therefore, for global consistency of naming, we can use "rte_rawdev" rather than "rte_pmd" fo

[dpdk-dev] [PATCH v2 1/2] drivers/raw: remove rawdev from directory names

2019-07-30 Thread Thomas Monjalon
From: Bruce Richardson The ifpga and skeleton rawdev drivers included "rawdev" in their directory names, which was superfluous given that they were in the drivers/raw directory. Shorten the names via this patch. For meson builds, this will rename the final library .so/.a files produced, but thos

[dpdk-dev] [PATCH v2 0/2] standardize rawdev names

2019-07-30 Thread Thomas Monjalon
The names of the rawdev drivers and the resultant libraries they built were pretty inconsistent. In terms of directory names, some had "rawdev" in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. Also, for the built .so/.a libraries, the names were not always consistent between ma

Re: [dpdk-dev] [PATCH BUG 335 3/3] net/virtio: fix compilation error with 0 headroom

2019-07-30 Thread Maxime Coquelin
On 7/26/19 2:25 PM, Olivier Matz wrote: Hi, On Thu, Jul 25, 2019 at 04:36:45PM +0530, Hemant Agrawal wrote: When using RTE_PKTMBUF_HEADROOM as 0, virito ethdev driver throws compilation error virtio_ethdev.c:1851:2: note: in expansion of macro ‘RTE_BUILD_BUG_ON’ RTE_BUILD_BUG_ON(RTE_PKTMBUF_

Re: [dpdk-dev] [RFC PATCH 0/2] standardize rawdev names

2019-07-30 Thread Thomas Monjalon
30/07/2019 14:20, Neil Horman: > On Tue, Jul 30, 2019 at 10:17:46AM +0200, Thomas Monjalon wrote: > > 05/07/2019 11:39, Thomas Monjalon: > > > 05/07/2019 11:38, Thomas Monjalon: > > > > 05/07/2019 11:35, Bruce Richardson: > > > > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: >

[dpdk-dev] [PATCH v5] Examples/l3fwd: fix unaligned memory access

2019-07-30 Thread Hariprasad Govindharajan
Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: Hariprasad

[dpdk-dev] [PATCH v1] doc: update release notes for 19.08

2019-07-30 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 19.08 release notes. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_19_08.rst | 126 - 1 file changed, 63 insertions(+), 63 deletions(-) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration

2019-07-30 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit > Sent: Tuesday, July 30, 2019 4:09 PM > To: Matan Azrad ; Wenzhuo Lu > ; Jingjing Wu > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload > configuration > > On 7/29/2019 1:36 PM, Matan Azrad wrote: > > When the

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration

2019-07-30 Thread Ferruh Yigit
On 7/29/2019 1:36 PM, Matan Azrad wrote: > When the mbuf data size cannot contain the maximum Rx packet length with > the mbuf headroom, a packet should be scattered in more than one mbuf. > > The application did not configure scatter offload in the above case. > > Enable the Rx scatter offload i

[dpdk-dev] [RFC 19.11 2/2] ethdev: hide DPDK internal struct from public API

2019-07-30 Thread Marcin Zapolski
Remove rte_eth_dev, rte_eth_dev_data and rte_eth_dev_ops from public API (make rte_ethdev_core APIs private). They are DPDK internal structures and as such should not be accessed by user applications directly. Signed-off-by: Marcin Zapolski --- drivers/net/cxgbe/base/adapter.h | 1

  1   2   >