Re: [dpdk-dev] [PATCH v4 1/2] vhost: support inflight share memory protocol feature

2019-07-31 Thread Tiwei Bie
On Thu, Aug 01, 2019 at 04:40:49AM +0800, JinYu wrote: > This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD > and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared > buffer between qemu and backend. > > Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the > shared buff

[dpdk-dev] [RFC,v4] ethdev: extend RSS offload types

2019-07-31 Thread simei
From: Simei Su This RFC cover two aspects: (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve different purposes. (2)reserve several bits as input set selection from bottom of the 64 bits.It is combined with exisiting ETH_RSS_* to represent rss types. for ex

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread Takeshi T Yoshimura
-David Marchand wrote: - >To: Takeshi T Yoshimura >From: David Marchand >Date: 08/01/2019 02:01PM >Cc: dev , David Christensen >Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in >ppc > >Hello, > >On Thu, Aug 1, 2019 at 6:10 AM Takeshi T Yoshimura >wrote: >> Here's

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread David Marchand
On Wed, Jul 31, 2019 at 11:20 PM David Christensen wrote: > > >> Here's the output from my Power 9 system running 19.08-RC2 (I'm not > >> using VFIO since I have an MLX5 adapter). > >> > >> sudo -E LD_LIBRARY_PATH=/home/davec/src/dpdk/build/lib > >> /home/davec/src/dpdk/build/app/testpmd --log-lev

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread David Marchand
Hello, On Thu, Aug 1, 2019 at 6:10 AM Takeshi T Yoshimura wrote: > Here's the full debug log I got. I ran upstream SPDK on NVMe on IBM Power9 > AC922. > The operating system is Ubuntu 18.04 and Linux 4.17. > > Starting SPDK v19.07-pre / DPDK 19.08.0-rc3 initialization... > [ DPDK EAL parameters:

Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-07-31 Thread Slava Ovsiienko
Hi, David Yes, thank you for the patch, acked. The "txq_inline_min" value was not set for ConnectX-5 to 0 as default. At the TX queue setup time the "txq_inline_min" is checked against MLX5_ARG_UNSET and default value 0 is set: txq_set_params() ... inlen_mode = (config->txq_inline_min == MLX5_

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread Takeshi T Yoshimura
-David Marchand wrote: - >To: Takeshi T Yoshimura >From: David Marchand >Date: 08/01/2019 04:45AM >Cc: dev , David Christensen >Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in >ppc > >On Wed, Jul 31, 2019 at 12:44 PM Takeshi T Yoshimura > wrote: >> >> -David M

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread Takeshi T Yoshimura
-David Marchand wrote: - >To: Takeshi T Yoshimura >From: David Marchand >Date: 08/01/2019 04:45AM >Cc: dev , David Christensen >Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in >ppc > >On Wed, Jul 31, 2019 at 12:44 PM Takeshi T Yoshimura > wrote: >> >> -David M

[dpdk-dev] [PATCH v2 3/3] config: add cortex-a76 configuration

2019-07-31 Thread Gavin Hu
To make the list complete and consistent, add cortex-a76 configuration. Signed-off-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 995d321..1ac798e 100644 --- a/co

[dpdk-dev] [PATCH v2 0/3] add arm neoverse N1 SDP configuration

2019-07-31 Thread Gavin Hu
Nerverse N1 is a new SoC based on armv8.2-a and with other advanced features. N1 SDP is the infrastructure segment development platform with N1 SoC inside. Here is more information about it: https://community.arm.com/developer/tools-software/oss-platforms/w/docs/440/neoverse-n1-sdp V2: Add the cov

[dpdk-dev] [PATCH v2 2/3] config: add arm neoverse N1 SDP configuration

2019-07-31 Thread Gavin Hu
Arm N1 SDP is an infrastructure segment development platform based on armv8.2-a Neoverse N1 CPU. For more information, refer to: https://community.arm.com/developer/tools-software/oss-platforms/w/ docs/440/neoverse-n1-sdp Signed-off-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ste

[dpdk-dev] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2

2019-07-31 Thread Gavin Hu
With "-march=armv8.2-a" specified, a compiling error generated: app/test/test_rcu_qsbr.c:234:10: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-compare] Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH 2/2] config: add N1SDP configuration

2019-07-31 Thread Gavin Hu
For more information of this platform, refer to: https://community.arm.com/developer/tools-software/oss-platforms/w/ docs/440/neoverse-n1-sdp Signed-off-by: Gavin Hu --- config/arm/meson.build | 4 +++- config/defconfig_arm64-neoversen1-linux-gcc | 16 2 fi

[dpdk-dev] [PATCH 1/2] test/rcu: fix the compiling error for armv8.2

2019-07-31 Thread Gavin Hu
With "-march=armv8.2-a" specified, a compiling error generated: app/test/test_rcu_qsbr.c:234:10: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-compare] Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") Cc: sta...@dpdk.org Sig

Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-07-31 Thread Stephen Hemminger
On Wed, 31 Jul 2019 17:41:11 -0500 David Christensen wrote: > The function mlx5_set_min_inline() includes a switch() that checks > various PCI device IDs in order to set the txq_inline_min value. No > value is set when the PCI device ID matches the ConnectX-5 adapters, > resulting in an assert()

[dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-07-31 Thread David Christensen
The function mlx5_set_min_inline() includes a switch() that checks various PCI device IDs in order to set the txq_inline_min value. No value is set when the PCI device ID matches the ConnectX-5 adapters, resulting in an assert() failure later in the function mlx5_set_txlimit_params(). This error

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread David Christensen
Here's the output from my Power 9 system running 19.08-RC2 (I'm not using VFIO since I have an MLX5 adapter). sudo -E LD_LIBRARY_PATH=/home/davec/src/dpdk/build/lib /home/davec/src/dpdk/build/app/testpmd --log-level lib.\*:debug -w :01:00.0 -w :01:00.1 -l 4,8-79 -n 4 -- --rxq=32 --rxd=10

Re: [dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci

2019-07-31 Thread Michael Santana Francisco
On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote: > > When building under Travis (or another linux CI service), enable running the > fast-tests for selected builds. Only the shared builds are enabled at this > point, since they are the ones passing. Builds that are statically linked > still s

Re: [dpdk-dev] [PATCH] test/eal: fix incorrect array sizes

2019-07-31 Thread Michael Santana Francisco
On Wed, Jul 31, 2019 at 2:56 PM David Marchand wrote: > > Following removal of -c and -n options, the array should have been > shrunk to avoid launch_proc to access unitialised strings. > > Fixes: b4dbacdb1ad7 ("test/eal: set core mask/list config only in dedicated > test") > Fixes: 501fa9a40298

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread David Marchand
On Wed, Jul 31, 2019 at 12:44 PM Takeshi T Yoshimura wrote: > > -David Marchand wrote: - > > >To: Takeshi Yoshimura > >From: David Marchand > >Date: 07/31/2019 06:29PM > >Cc: dev > >Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in > >ppc > > > >On Wed, Jul 31, 2019

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread David Marchand
On Wed, Jul 31, 2019 at 9:23 PM David Christensen wrote: > > On 7/31/19 3:58 AM, David Marchand wrote: > > --log-level lib.*:debug > > Here's the output from my Power 9 system running 19.08-RC2 (I'm not > using VFIO since I have an MLX5 adapter). > > sudo -E LD_LIBRARY_PATH=/home/davec/src/dpdk/bu

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread David Christensen
On 7/31/19 3:58 AM, David Marchand wrote: --log-level lib.*:debug Here's the output from my Power 9 system running 19.08-RC2 (I'm not using VFIO since I have an MLX5 adapter). sudo -E LD_LIBRARY_PATH=/home/davec/src/dpdk/build/lib /home/davec/src/dpdk/build/app/testpmd --log-level lib.\*:de

[dpdk-dev] [PATCH] test/eal: fix incorrect array sizes

2019-07-31 Thread David Marchand
Following removal of -c and -n options, the array should have been shrunk to avoid launch_proc to access unitialised strings. Fixes: b4dbacdb1ad7 ("test/eal: set core mask/list config only in dedicated test") Fixes: 501fa9a40298 ("test/eal: set memory channel config only in dedicated test") Sig

Re: [dpdk-dev] [PATCH 1/2] tests: Fix unit tests for shared builds

2019-07-31 Thread Aaron Conole
Aaron Conole writes: > Bruce Richardson writes: > >> On Wed, Jul 31, 2019 at 10:50:29AM -0400, Aaron Conole wrote: >>> From: Michael Santana >>> >>> Currently many unit tests fail when running tests under shared builds. >>> This happens because of missing driver dependencies. This is fixed by

Re: [dpdk-dev] [PATCH 1/2] tests: Fix unit tests for shared builds

2019-07-31 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Jul 31, 2019 at 10:50:29AM -0400, Aaron Conole wrote: >> From: Michael Santana >> >> Currently many unit tests fail when running tests under shared builds. >> This happens because of missing driver dependencies. This is fixed by >> explicitly linking in missin

[dpdk-dev] [PATCH v2] doc: add tested Marvell integrated NIC platforms

2019-07-31 Thread jerinj
From: Jerin Jacob Add tested Marvell integrated NIC platforms to v19.08 release note. Signed-off-by: Jerin Jacob --- v2: Updated based on Thomas's following comments http://mails.dpdk.org/archives/dev/2019-July/140203.html doc/guides/rel_notes/release_19_08.rst | 15 +++ 1 file ch

[dpdk-dev] [PATCH v2] librte_acl: fix undefined behavior

2019-07-31 Thread Aaron Conole
Left-shift of an integer constant is represented as 'int' type, but a left shift of 1 by 31 bits in 'int' is undefined. Use the U suffix to force a representation as unsigned. Caught while running with ubsan under gcc. Fixes: dc276b5780c2 ("acl: new library") Cc: Konstantin Ananyev Signed-off-b

Re: [dpdk-dev] [PATCH 0/5] blank lines at EOF fixes

2019-07-31 Thread Bruce Richardson
On Wed, Jul 31, 2019 at 07:57:37AM -0700, Stephen Hemminger wrote: > Using a simple shell script which cleans up trailing whitespace > found several places with extra lines at end of file. > > More in base drivers but they are known to be problematic. > > Stephen Hemminger (5): > examples: remo

Re: [dpdk-dev] [PATCH 1/2] tests: Fix unit tests for shared builds

2019-07-31 Thread Bruce Richardson
On Wed, Jul 31, 2019 at 10:50:29AM -0400, Aaron Conole wrote: > From: Michael Santana > > Currently many unit tests fail when running tests under shared builds. > This happens because of missing driver dependencies. This is fixed by > explicitly linking in missing drivers for the test application

[dpdk-dev] [PATCH] pcap: propagate timestamp from pcap_pkthdr to mbuf

2019-07-31 Thread Sylvain Rodon
From: Sylvain Rodon Timestamp is always set in PCAP header, whether it reads a file or listen on an interface. This information can be important for some applications and it cannot be obtained otherwise (especially when reading a PCAP file). Timestamp here is the number of microseconds since epoc

[dpdk-dev] [PATCH 2/5] test: remove blank lines at eof

2019-07-31 Thread Stephen Hemminger
Several tests have extraneous blank lines at end of file. Signed-off-by: Stephen Hemminger --- app/test/test_cryptodev_asym_util.h | 4 app/test/test_table_combined.c | 1 - app/test/test_table_tables.c| 3 +-- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/app/t

[dpdk-dev] [PATCH 5/5] net/mlx5: remove blank lines at eof

2019-07-31 Thread Stephen Hemminger
Whitespace fix. Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/mlx5_rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index a4fc388d2293..8acd8cd2a4a9 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx

[dpdk-dev] [PATCH 4/5] net/ipn3ke: cleanup blank line at eof

2019-07-31 Thread Stephen Hemminger
Leftover from editor? Remove blank lines at end of file. Signed-off-by: Stephen Hemminger --- drivers/net/ipn3ke/ipn3ke_flow.c | 1 - drivers/net/ipn3ke/ipn3ke_tm.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/ipn3ke/ipn3ke_flow.c b/drivers/net/ipn3ke/ipn3ke_flow.c index f3

[dpdk-dev] [PATCH 1/5] examples: remove extra blank lines at eof

2019-07-31 Thread Stephen Hemminger
There should not be blank lines at end of files. Signed-off-by: Stephen Hemminger --- examples/flow_filtering/flow_blocks.c | 1 - examples/l3fwd-power/perf_core.c | 1 - examples/vhost_scsi/vhost_scsi.c | 1 - 3 files changed, 3 deletions(-) diff --git a/examples/flow_filtering/flow_

[dpdk-dev] [PATCH 0/5] blank lines at EOF fixes

2019-07-31 Thread Stephen Hemminger
Using a simple shell script which cleans up trailing whitespace found several places with extra lines at end of file. More in base drivers but they are known to be problematic. Stephen Hemminger (5): examples: remove extra blank lines at eof test: remove blank lines at eof pmdinfogen: remov

[dpdk-dev] [PATCH 3/5] pmdinfogen: remove blank line at eof

2019-07-31 Thread Stephen Hemminger
No need for blank line at end of file. Signed-off-by: Stephen Hemminger --- buildtools/pmdinfogen/pmdinfogen.h | 1 - 1 file changed, 1 deletion(-) diff --git a/buildtools/pmdinfogen/pmdinfogen.h b/buildtools/pmdinfogen/pmdinfogen.h index 27bab30e5eb0..c8a9e2136add 100644 --- a/buildtools/pmdi

[dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci

2019-07-31 Thread Aaron Conole
When building under Travis (or another linux CI service), enable running the fast-tests for selected builds. Only the shared builds are enabled at this point, since they are the ones passing. Builds that are statically linked still show some issues in some of the eal_flags tests. Additionally, t

[dpdk-dev] [PATCH 1/2] tests: Fix unit tests for shared builds

2019-07-31 Thread Aaron Conole
From: Michael Santana Currently many unit tests fail when running tests under shared builds. This happens because of missing driver dependencies. This is fixed by explicitly linking in missing drivers for the test application. before and after (clang): https://travis-ci.com/Maickii/dpdk-2/jobs/2

[dpdk-dev] [PATCH 0/2] Enable fast-unit tests under travis

2019-07-31 Thread Aaron Conole
This series turns the fast unit tests on for a limited set of builds under the travis build system. An example run is available at: https://travis-ci.org/orgcandman/dpdk/builds/565991679 The builds which execute the unit tests may be distinguished by the "RUN_TESTS" parameter. Aaron Conole (1):

[dpdk-dev] [PATCH] net/mlx5: fix limit on direct rules tables number

2019-07-31 Thread Dekel Peled
MLX5 PMD limits the number of SW steering tables to 32. This patch updates the limit to 65535, to allow wide range of values. Fixes: e2b4925ef7c1 ("net/mlx5: support Direct Rules E-Switch") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5.h | 4 ++-- drivers/net/

Re: [dpdk-dev] [PATCH] buildtools: fix pmdinfogen compilation

2019-07-31 Thread Bruce Richardson
On Wed, Jul 31, 2019 at 11:57:05AM +0530, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Pmdinfogen is always compiled with host gcc. > If host gcc version is lessthan 7 and target gcc is greaterthan 7 > pmdinfogen fails to compile due to unsupported cflags. > This patch removes unsu

Re: [dpdk-dev] [PATCH] buildtools: fix pmdinfogen compilation

2019-07-31 Thread Bruce Richardson
On Wed, Jul 31, 2019 at 03:21:46PM +0100, Bruce Richardson wrote: > On Wed, Jul 31, 2019 at 07:35:03AM -0400, Neil Horman wrote: > > On Wed, Jul 31, 2019 at 11:57:05AM +0530, pbhagavat...@marvell.com wrote: > > > From: Pavan Nikhilesh > > > > > > Pmdinfogen is always compiled with host gcc. > > >

Re: [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal

2019-07-31 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Wednesday, July 31, 2019 7:53 PM > To: David Marchand > Cc: dev@dpdk.org; tho...@monjalon.net; step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal > > On Wed, Jul 31,

Re: [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal

2019-07-31 Thread Bruce Richardson
On Wed, Jul 31, 2019 at 01:06:17PM +0200, David Marchand wrote: > New accessors have been introduced to provide the hidden information. > This symbol can now be kept internal. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH] doc: add tested Marvell integrated NIC platforms

2019-07-31 Thread Thomas Monjalon
31/07/2019 16:14, jer...@marvell.com: > From: Jerin Jacob > > Add tested Marvell integrated NIC platforms to v19.08 release note. > > Signed-off-by: Jerin Jacob > --- > +* ARMv8 SoC combinations from Marvell (with integrated NICs) > + > + * SoC: > + > + * CN83xx, CN96xx, CNF95xx, CN93xx >

Re: [dpdk-dev] [PATCH] buildtools: fix pmdinfogen compilation

2019-07-31 Thread Bruce Richardson
On Wed, Jul 31, 2019 at 07:35:03AM -0400, Neil Horman wrote: > On Wed, Jul 31, 2019 at 11:57:05AM +0530, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Pmdinfogen is always compiled with host gcc. > > If host gcc version is lessthan 7 and target gcc is greaterthan 7 > > pmdinfo

[dpdk-dev] [PATCH] doc: add tested Marvell integrated NIC platforms

2019-07-31 Thread jerinj
From: Jerin Jacob Add tested Marvell integrated NIC platforms to v19.08 release note. Signed-off-by: Jerin Jacob --- doc/guides/rel_notes/release_19_08.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/releas

Re: [dpdk-dev] [PATCH 00/30] fix spelling errors in comments and messages

2019-07-31 Thread Thomas Monjalon
16/07/2019 13:07, Thomas Monjalon: > 01/07/2019 20:25, Stephen Hemminger: > > Ran the codespell tool against the lib and examples. > > Lots of little repeated errors fixed. > > Please could you send a v2 addresing comments? > I think it can be only all squashed in one patch. Stephen, is it the ri

Re: [dpdk-dev] [PATCH] ethdev: sort experimental symbols per release

2019-07-31 Thread Stephen Hemminger
On Wed, 31 Jul 2019 14:27:16 +0200 David Marchand wrote: > Sort the experimental symbols per release to make it easier/quicker to > check for how long we have them. > > Signed-off-by: David Marchand Acked-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal

2019-07-31 Thread Stephen Hemminger
On Wed, 31 Jul 2019 13:06:17 +0200 David Marchand wrote: > New accessors have been introduced to provide the hidden information. > This symbol can now be kept internal. > > Signed-off-by: David Marchand > --- > doc/guides/rel_notes/deprecation.rst | 4 > 1 file changed, 4 insertions(+) >

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix crash in dev_info_get in secondary process

2019-07-31 Thread Stephen Hemminger
On Wed, 31 Jul 2019 07:36:26 + Raslan Darawsheh wrote: > Hi Stephen, > > Can you please confirm that Slava's patch fixed your issue and this patch is > not needed anymore for MLX5? > So that I can take mlx4 patch only from this series? > > Kindest regards, > Raslan Darawsheh OK, but my ot

Re: [dpdk-dev] [PATCH] ethdev: sort experimental symbols per release

2019-07-31 Thread Ferruh Yigit
On 7/31/2019 1:27 PM, David Marchand wrote: > Sort the experimental symbols per release to make it easier/quicker to > check for how long we have them. > > Signed-off-by: David Marchand Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash support

2019-07-31 Thread Shahaf Shuler
Wednesday, July 31, 2019 3:31 PM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash > support > > On Wed, Jul 31, 2019 at 03:08:19PM +0300, Andrew Rybchenko wrote: > > On 7/25/19 7:57 AM, simei wrote: > > > From: Simei Su > > > > > > Currently, there are

Re: [dpdk-dev] [PATCH] librte_acl: fix undefined behavior

2019-07-31 Thread Aaron Conole
"Ananyev, Konstantin" writes: > Hi Aaron, > >> >> Left-shift of an integer constant is represented as 'int' type, but a left >> shift of 1 by 31 bits in 'int' is undefined. Use the U suffix to force >> a representation as unsigned. >> >> Caught while running with ubsan under gcc. >> >> Fixes:

Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash support

2019-07-31 Thread Andrew Rybchenko
On 7/31/19 3:30 PM, Adrien Mazarguil wrote: On Wed, Jul 31, 2019 at 03:08:19PM +0300, Andrew Rybchenko wrote: On 7/25/19 7:57 AM, simei wrote: From: Simei Su Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash funtion. To support symmetric hash by rte_flow RSS action, this patch adds ne

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

2019-07-31 Thread Thomas Monjalon
31/07/2019 11:45, David Marchand: > On Tue, Jul 30, 2019 at 5:58 PM Thomas Monjalon wrote: > > > > As legacy filter API "filter_ctrl" is superseded since 2017 > > by the rte_flow API, and got the deprecated attribute in DPDK 19.05, > > it is time to remove the associated features from the matrix.

[dpdk-dev] [PATCH v4 2/2] vhost: Add vhost-user-blk example which support inflight

2019-07-31 Thread JinYu
A vhost-user-blk example that support inflight feature. It uses the new APIs that introduced in the first patch, so It can show how there APIs work to support inflight feature. Signed-off-by: Jin Yu --- V1 - add the case. V2 - add the rte_vhost prefix. V3 - add packed ring support --- examples/v

[dpdk-dev] [PATCH v4 1/2] vhost: support inflight share memory protocol feature

2019-07-31 Thread JinYu
This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the shared buffer from backend. Then qemu should send it back through VHOST_USER_S

[dpdk-dev] [PATCH v4 0/2] vhost: support inflight share memory protocol feature

2019-07-31 Thread JinYu
This patches introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. This shared buffer is used to process inflight I/O when backend reconnect Now It can both support split and packed ring. The example c

[dpdk-dev] [PATCH v4 2/2] eal: use base address hint to reserve space for mem config

2019-07-31 Thread Anatoly Burakov
Currently, mem config will be mapped without using the virtual area reservation infrastructure, which means it will be mapped at an arbitrary location. This may cause failures to map the shared config in secondary process due to things like PCI whitelist arguments allocating memory in a space where

[dpdk-dev] [PATCH v4 1/2] eal: make base address hint OS-specific

2019-07-31 Thread Anatoly Burakov
Not all OS's follow Linux's memory layout, which may lead to problems following the suggested common address hint absent of a base-virtaddr flag. Make this address hint OS-specific. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 19 +--

Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash support

2019-07-31 Thread Adrien Mazarguil
On Wed, Jul 31, 2019 at 03:08:19PM +0300, Andrew Rybchenko wrote: > On 7/25/19 7:57 AM, simei wrote: > > From: Simei Su > > > > Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash funtion. > > To support symmetric hash by rte_flow RSS action, this patch adds > > new hash function "Symmetric

[dpdk-dev] [PATCH] ethdev: sort experimental symbols per release

2019-07-31 Thread David Marchand
Sort the experimental symbols per release to make it easier/quicker to check for how long we have them. Signed-off-by: David Marchand --- lib/librte_ethdev/rte_ethdev_version.map | 51 1 file changed, 32 insertions(+), 19 deletions(-) diff --git a/lib/librte_eth

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli

2019-07-31 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, July 31, 2019 12:33 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile > cli > > Since sched library always check the non-zero value of subport tc

Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash support

2019-07-31 Thread Andrew Rybchenko
On 7/25/19 7:57 AM, simei wrote: From: Simei Su Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash funtion. To support symmetric hash by rte_flow RSS action, this patch adds new hash function "Symmetric Toeplitz" which is supported by some hardware. Isn't it a question of key to achiev

[dpdk-dev] [PATCH] eal: hide internal function

2019-07-31 Thread David Marchand
This function has never been used outside of this code unit. Mark it static and remove it from the eal internal header. Fixes: 9e29251b2afa ("eal: thread affinity API") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_thread.c | 3 ++- lib/librte_eal/commo

[dpdk-dev] Recall: [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

2019-07-31 Thread Shahed Shaikh
Shahed Shaikh would like to recall the message, "[PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD".

Re: [dpdk-dev] [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

2019-07-31 Thread Shahed Shaikh
+ is not enabled. Before binging DPDK driver to one or more devices on Binging=>binding Thanks, Shahed > -Original Message- > From: Rasesh Mody > Sent: Wednesday, July 31, 2019 1:32 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; John McNamara > ; Thomas Monjalon ; > Jerin Jacob K

Re: [dpdk-dev] [PATCH] buildtools: fix pmdinfogen compilation

2019-07-31 Thread Neil Horman
On Wed, Jul 31, 2019 at 11:57:05AM +0530, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Pmdinfogen is always compiled with host gcc. > If host gcc version is lessthan 7 and target gcc is greaterthan 7 > pmdinfogen fails to compile due to unsupported cflags. > This patch removes unsu

[dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli

2019-07-31 Thread Jasvinder Singh
Since sched library always check the non-zero value of subport tc ov weight. Therefore, it is necessary to set right value of tc ov weight even if RTE_SCHED_SUBPORT_TC_OV is disabled. Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [dpdk-dev] [RFC PATCH] drivers/net: deprecate private API for VF ports

2019-07-31 Thread Ajit Khaparde
On Wed, Jul 31, 2019 at 2:36 AM Andrew Rybchenko wrote: > On 7/30/19 6:59 PM, Thomas Monjalon wrote: > > Since the concept of representors was introduced, > > we do not need any specific API for VF ports. > > Any VF port should be able to be configured through > > its representor port in a more g

Re: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in ipsec-secgw

2019-07-31 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > > > > > > > > 30/07/2019 10:48, Akhil Goyal: > > > > > > > 30/07/2019 09:20, Akhil Goyal: > > > > > > > > > 30/07/2019 07:55, Akhil Goyal: > > > > > > > > > > > > > > All the functionality of the legacy code path in now > available > > > > > > > > > > > > > >

[dpdk-dev] [PATCH] doc: announce lcore_config symbol removal

2019-07-31 Thread David Marchand
New accessors have been introduced to provide the hidden information. This symbol can now be kept internal. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread David Marchand
On Wed, Jul 31, 2019 at 12:44 PM Takeshi T Yoshimura wrote: > Ah, I overlooked your first question. The "ppc driver" is in > drivers/bus/pci/linux/pci.c. In pci.c, pci_one_device_iommu_support_va() > always returns false in ppc. so, the driver does not allow VA mode in ppc. > > This return value i

Re: [dpdk-dev] [PATCH v5 0/9] Make shared memory config non-public

2019-07-31 Thread David Marchand
On Wed, Jul 31, 2019 at 12:32 PM Burakov, Anatoly wrote: > > On 31-Jul-19 11:07 AM, David Marchand wrote: > > Hello Anatoly, > > > > On Fri, Jul 5, 2019 at 11:09 PM Thomas Monjalon wrote: > >> > >> 05/07/2019 19:26, Anatoly Burakov: > >>> This patchset removes the shared memory config from public

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

2019-07-31 Thread Ajit Khaparde
On Wed, Jul 31, 2019 at 3:35 AM Jerin Jacob Kollanukkaran < jer...@marvell.com> wrote: > > -Original Message- > > From: dev On Behalf Of Andrew Rybchenko > > Sent: Wednesday, July 31, 2019 3:04 PM > > To: Thomas Monjalon ; John McNamara > > ; Marko Kovacevic > > ; Ajit Khaparde > > ; Somn

Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice about changes to ethernet structures

2019-07-31 Thread Ferruh Yigit
On 7/23/2019 12:28 PM, Andrew Rybchenko wrote: > On 7/19/19 7:56 PM, Stephen Hemminger wrote: >> Tell users about upcoming changes to rte_ether_addr and >> rte_ether_header. >> >> Signed-off-by: Stephen Hemminger >> Acked-by: Bruce Richardson > > Acked-by: Andrew Rybchenko > Acked-by: Ferruh

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread Takeshi T Yoshimura
-David Marchand wrote: - >To: Takeshi Yoshimura >From: David Marchand >Date: 07/31/2019 06:29PM >Cc: dev >Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in >ppc > >On Wed, Jul 31, 2019 at 5:36 AM Takeshi Yoshimura >wrote: >> >> Commit b76fafb174d2 ("eal: fix IOVA m

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

2019-07-31 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Andrew Rybchenko > Sent: Wednesday, July 31, 2019 3:04 PM > To: Thomas Monjalon ; John McNamara > ; Marko Kovacevic > ; Ajit Khaparde > ; Somnath Kotur > ; Ferruh Yigit ; > John Daley ; Hyong Youb Kim ; > Beilei Xing ; Qi Zhang ; > Wenzhuo Lu ;

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread Takeshi T Yoshimura
-David Marchand wrote: - >To: Takeshi Yoshimura >From: David Marchand >Date: 07/31/2019 06:29PM >Cc: dev >Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in >ppc > >On Wed, Jul 31, 2019 at 5:36 AM Takeshi Yoshimura >wrote: >> >> Commit b76fafb174d2 ("eal: fix IOVA m

Re: [dpdk-dev] [PATCH v5 0/9] Make shared memory config non-public

2019-07-31 Thread Burakov, Anatoly
On 31-Jul-19 11:07 AM, David Marchand wrote: Hello Anatoly, On Fri, Jul 5, 2019 at 11:09 PM Thomas Monjalon wrote: 05/07/2019 19:26, Anatoly Burakov: This patchset removes the shared memory config from public API, and replaces all usages of said config with new API calls. A lot of the patch

Re: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in ipsec-secgw

2019-07-31 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > > > 30/07/2019 10:48, Akhil Goyal: > > > > > > 30/07/2019 09:20, Akhil Goyal: > > > > > > > > 30/07/2019 07:55, Akhil Goyal: > > > > > > > > > > > > > All the functionality of the legacy code path in now > > > > > > > > > > > > > available > > > > > > > > > > > > > in the li

Re: [dpdk-dev] [PATCH v5 0/9] Make shared memory config non-public

2019-07-31 Thread David Marchand
Hello Anatoly, On Fri, Jul 5, 2019 at 11:09 PM Thomas Monjalon wrote: > > 05/07/2019 19:26, Anatoly Burakov: > > This patchset removes the shared memory config from public > > API, and replaces all usages of said config with new API > > calls. > > > > A lot of the patchset is a search-and-replace

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

2019-07-31 Thread David Marchand
On Tue, Jul 30, 2019 at 5:58 PM Thomas Monjalon wrote: > > As legacy filter API "filter_ctrl" is superseded since 2017 > by the rte_flow API, and got the deprecated attribute in DPDK 19.05, > it is time to remove the associated features from the matrix. > Not documenting deprecated features as sup

Re: [dpdk-dev] [RFC PATCH] drivers/net: deprecate private API for VF ports

2019-07-31 Thread Andrew Rybchenko
On 7/30/19 6:59 PM, Thomas Monjalon wrote: Since the concept of representors was introduced, we do not need any specific API for VF ports. Any VF port should be able to be configured through its representor port in a more generic fashion. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybche

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

2019-07-31 Thread Andrew Rybchenko
On 7/30/19 6:57 PM, Thomas Monjalon wrote: As legacy filter API "filter_ctrl" is superseded since 2017 by the rte_flow API, and got the deprecated attribute in DPDK 19.05, it is time to remove the associated features from the matrix. Not documenting deprecated features as supported will avoid con

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread David Marchand
On Wed, Jul 31, 2019 at 5:36 AM Takeshi Yoshimura wrote: > > Commit b76fafb174d2 ("eal: fix IOVA mode selection as VA for PCI > drivers") breaks ppc apps with no IOVA configs (or RTE_IOVA_DC) > because of the inconsistency of user's request and the result of > device capability for IOVA mode. I up

Re: [dpdk-dev] [PATCH v3] eal: warn on legacy memory allocation requirement

2019-07-31 Thread Burakov, Anatoly
On 30-Jul-19 6:21 PM, Thomas Monjalon wrote: When using --no-huge mode, dynamic allocation is not supported. Because of this limitation, the option --legacy-mem is implied and -m may be needed to specify the amount of memory to allocate. Otherwise the default amount MEMSIZE_IF_NO_HUGE_PAGE will b

Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc

2019-07-31 Thread Burakov, Anatoly
On 31-Jul-19 4:35 AM, Takeshi Yoshimura wrote: Commit b76fafb174d2 ("eal: fix IOVA mode selection as VA for PCI drivers") breaks ppc apps with no IOVA configs (or RTE_IOVA_DC) because of the inconsistency of user's request and the result of device capability for IOVA mode. I updated the code to f

Re: [dpdk-dev] [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

2019-07-31 Thread Thomas Monjalon
31/07/2019 10:02, Rasesh Mody: > Add and update co-existence considerations for bnx2x PMD > > Signed-off-by: Rasesh Mody > --- > doc/guides/nics/bnx2x.rst | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.

Re: [dpdk-dev] [PATCH] doc: add a co-existence consideration for qede PMD

2019-07-31 Thread Thomas Monjalon
31/07/2019 10:02, Rasesh Mody: > Add and update co-existence considerations for qede PMD > > Signed-off-by: Rasesh Mody > --- > doc/guides/nics/qede.rst | 21 +++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > +- Linux kernel drivers and qede PMD can’t be mixed on a gi

Re: [dpdk-dev] [PATCH] mk: fix printing target name when build completes

2019-07-31 Thread Bruce Richardson
On Tue, Jul 30, 2019 at 11:35:52PM +0200, Thomas Monjalon wrote: > 04/06/2019 11:21, kka...@marvell.com: > > --- a/config/defconfig_x86_64-native-linuxapp-gcc > > +++ b/config/defconfig_x86_64-native-linuxapp-gcc > > +CONFIG_RTE_EXEC_ENV="linux" > > Why do you do this change in this file? > > I t

Re: [dpdk-dev] [PATCH v2 2/2] drivers/raw: standardize naming

2019-07-31 Thread Thomas Monjalon
31/07/2019 09:29, Xu, Rosen: > Hi, > > I'm okay if it's applied in 19.11. It is already applied in 19.08-rc3.

Re: [dpdk-dev] [PATCH] examples/bpf: fix compilation issue

2019-07-31 Thread Ananyev, Konstantin
> -Original Message- > From: Varghese, Vipin > Sent: Wednesday, July 31, 2019 9:20 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] examples/bpf: fix compilation issue > > Snipped > > > > > Example BPF programs t1.c, t2.c, t3.c in fold

Re: [dpdk-dev] [PATCH] examples/bpf: fix compilation issue

2019-07-31 Thread Varghese, Vipin
Snipped > > > Example BPF programs t1.c, t2.c, t3.c in folder examples/bpf are > > > failing to compile with latest dpdk.org master. > > > > As a note, the file t3.c is one which fails to get compiled. > > t2.c also uses rte_mbuf, so same story for both. Thank you. So, the rewrite will be ' Exa

Re: [dpdk-dev] [PATCH] librte_acl: fix undefined behavior

2019-07-31 Thread Ananyev, Konstantin
Hi Aaron, > > Left-shift of an integer constant is represented as 'int' type, but a left > shift of 1 by 31 bits in 'int' is undefined. Use the U suffix to force > a representation as unsigned. > > Caught while running with ubsan under gcc. > > Fixes: dc276b5780c2 ("acl: new library") > Cc: Ko

Re: [dpdk-dev] [PATCH 1/2] doc: use SPDX tag for bnx2x PMD guide

2019-07-31 Thread Rasesh Mody
+cc Jerin and John with proper email. On 7/31/19, 1:02 AM, "Rasesh Mody" wrote: Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst inde

[dpdk-dev] [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

2019-07-31 Thread Rasesh Mody
Add and update co-existence considerations for bnx2x PMD Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst index a7dee0c10..358ed7927 100644 --- a/doc

[dpdk-dev] [PATCH 1/2] doc: use SPDX tag for bnx2x PMD guide

2019-07-31 Thread Rasesh Mody
Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst index cecbfc2e7..a7dee0c10 100644 --- a/doc/guides/nics/bnx2x.rst +++ b/doc/guides/nics/bnx2x.rst @@ -1,6 +1,5 @@ -.

[dpdk-dev] [PATCH] doc: add a co-existence consideration for qede PMD

2019-07-31 Thread Rasesh Mody
Add and update co-existence considerations for qede PMD Signed-off-by: Rasesh Mody --- doc/guides/nics/qede.rst | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst index c0a383381..87cf989c1 100644 --- a/d

  1   2   >