On 08/14, Xiaoyun Li wrote:
>Resource file was not freed or pointed-to in fseek/ftell. This patch
>fixed this issue which is found by coverity scan.
>
>Coverity issue: 347277
>Fixes: 440af660ff83 ("examples/ntb: fix error handling")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Xiaoyun Li
>---
> examples
Resource file was not freed or pointed-to in fseek/ftell. This patch
fixed this issue which is found by coverity scan.
Coverity issue: 347277
Fixes: 440af660ff83 ("examples/ntb: fix error handling")
Cc: sta...@dpdk.org
Signed-off-by: Xiaoyun Li
---
examples/ntb/ntb_fwd.c | 2 ++
1 file changed,
> -Original Message-
> From: Ori Kam
> Sent: Wednesday, August 14, 2019 8:36 AM
> To: Stephen Hemminger
> Cc: Thomas Monjalon ; ferruh.yi...@intel.com;
> arybche...@solarflare.com; Shahaf Shuler ; Slava
> Ovsiienko ; Alex Rosenbaum
> ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [RFC] ethdev
Hi Stephen,
> -Original Message-
> From: Stephen Hemminger
> Sent: Tuesday, August 13, 2019 6:46 PM
> To: Ori Kam
> Cc: Thomas Monjalon ; ferruh.yi...@intel.com;
> arybche...@solarflare.com; Shahaf Shuler ; Slava
> Ovsiienko ; Alex Rosenbaum
> ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [RF
Add new protocol header match support as below
RTE_FLOW_ITEM_TYPE_GTP_PSC
- matches a GTP PDU extension header (type is 0x85:
PDU Session Container)
RTE_FLOW_ITEM_TYPE_PPPOES
- matches a PPPoE Session header.
RTE_FLOW_ITEM_TYPE_PPPOED
- matches a PPPoE Discovery sta
Hi，
We found that *rte_vhost_rx_queue_count* is not protected by vq->access_lock,
and the access to vq->avail->idx is not thread-safe, since at the same time, the
vq->avail might be
set by *vring_invalidate* when some vhost-user messages arrived, such as
VRING_SET_ADDRESS,
VRING_SET_MEM_TAB
Add new protocol header match support as below
RTE_FLOW_ITEM_TYPE_GTP_PSC
- matches a GTP PDU extension header (type is 0x85:
PDU Session Container)
RTE_FLOW_ITEM_TYPE_PPPOES
- matches a PPPoE Session header.
RTE_FLOW_ITEM_TYPE_PPPOED
- matches a PPPoE Discovery sta
On 7/2/19 11:01 AM, Ferruh Yigit wrote:
On 5/16/2019 10:12 AM, David Marchand wrote:
Hello Chas,
On Fri, Apr 19, 2019 at 12:50 AM Chas Williams <3ch...@gmail.com> wrote:
On 4/18/19 3:11 AM, David Marchand wrote:
Hello Chas,
On Fri, Apr 12, 2019 at 4:02 PM Chas Williams <3ch...@gmail.com
On Tue, Aug 13, 2019 at 08:32:44AM +0200, David Marchand wrote:
> On Mon, Aug 12, 2019 at 10:14 PM Neil Horman wrote:
> >
> > On Mon, Aug 12, 2019 at 09:02:28AM +0200, David Marchand wrote:
> > > Dumping every object file for every symbol is too heavy.
> > > Use a temporary storage.
> > >
> > > Be
On 8/13/19 4:28 AM, Christian Ehrhardt wrote:
The AltiVec header file breaks boolean type:
error: incompatible types when initializing type
'__vector _bool int' {aka '_vector(4) __bool int'} using type 'int'
If __APPLE_ALTIVEC__ is defined, then bool type is redefined
and conflicts with stdbool
On Tue, 13 Aug 2019 13:37:48 +
Ori Kam wrote:
> This RFC replaces RFC[1].
>
> The hairpin feature (different name can be forward) acts as "bump on the
> wire",
> meaning that a packet that is received from the wire can be modified using
> offloaded action and then sent back to the wire with
Just open the sysfs file and handle failure, rather than
using access(). This eliminates Coverity warnings about
"time of check versus time of use"; although for this sysfs
file that is not really an issue anyway.
Coverity ID: 347276
Signed-off-by: Stephen Hemminger
---
drivers/bus/pci/linux/pci
Replace rte_ipsec_sad_add(), rte_ipsec_sad_del() and
rte_ipsec_sad_lookup() stubs with actual implementation.
It uses three librte_hash tables each of which contains
an entries for a specific SA type (either it is addressed by SPI only
or SPI+DIP or SPI+DIP+SIP)
Signed-off-by: Vladimir Medvedkin
Signed-off-by: Vladimir Medvedkin
---
app/test/Makefile | 1 +
app/test/autotest_data.py | 6 +
app/test/meson.build | 1 +
app/test/test_ipsec_sad.c | 874 ++
4 files changed, 882 insertions(+)
create mode 100644 app/test/test_ipsec
Replace rte_ipsec_sad_create(), rte_ipsec_sad_free() and
rte_ipsec_sad_find_existing() API stubs with actual
implementation.
Signed-off-by: Vladimir Medvedkin
---
lib/librte_ipsec/Makefile| 2 +-
lib/librte_ipsec/ipsec_sad.c | 221 +--
lib/librte_ips
Usage example and performance evaluation for the ipsec SAD library
Signed-off-by: Vladimir Medvedkin
---
app/Makefile | 1 +
app/meson.build | 3 +-
app/test-sad/Makefile| 18 ++
app/test-sad/main.c | 420 +++
app/tes
Add inbound security association database (SAD) API
and stub implementation.
Signed-off-by: Vladimir Medvedkin
---
lib/librte_ipsec/Makefile | 2 +
lib/librte_ipsec/ipsec_sad.c | 50 ++
lib/librte_ipsec/meson.build | 4 +-
lib/librte_ipsec/rte_ipsec_
According to RFC 4301 IPSec implementation needs an inbound SA database (SAD).
For each incoming inbound IPSec-protected packet (ESP or AH) it has to
perform a lookup within it’s SAD.
Lookup should be performed by:
Security Parameters Index (SPI) + destination IP (DIP) + source IP (SIP)
or SPI +
On 08/14, Xiao Zhang wrote:
>I40evf queue can not work properly with kernel pf driver for X722 vf.
>Eg. when configure 8 queues pair, only 4 queues can receive packets,
>and half packets will be lost if using 2 queues pair.
>This issue is caused by misconfiguration of look up table, the original
On Tue, Aug 13, 2019 at 4:41 PM Aaron Conole wrote:
>
> David Marchand writes:
>
> > Install missing dependencies so that doc can be generated.
> > While at it, explicitly configure that we want the doc to be generated.
> > Missing dependencies are then reported as an error rather than silently
>
David Marchand writes:
> Install missing dependencies so that doc can be generated.
> While at it, explicitly configure that we want the doc to be generated.
> Missing dependencies are then reported as an error rather than silently
> ignored.
>
> Because of these extra dependencies, only build th
In struct mlx5_ibv_shared, member esw_drop_action was added between
existing member tx_tbl and the comment line describing it.
This patch moves the comment line to its original location, and fixes
a typo in the comment.
Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch")
Cc:
This RFC replaces RFC[1].
The hairpin feature (different name can be forward) acts as "bump on the wire",
meaning that a packet that is received from the wire can be modified using
offloaded action and then sent back to the wire without application intervention
which save CPU cycles.
The hairpin
The vmxnet3_prep_pkts function set rte_errno to ENOTSUP for any packets
having PKT_TX_IP_CHECKSUM set in ol_flags. But the vmxnet3 has
DEV_TX_OFFLOAD_IPV4_CKSUM set in this tx offload capa.
This issue has been introduced with the new Rx offload
API. DEV_TX_OFFLOAD_IPV4_CKSUM and DEV_RX_OFFLOAD_IPV
On 13-Aug-19 12:25 PM, Dekel Peled wrote:
Documentation includes separate pages of EAL command-line options for
Linux and for FreeBSD.
Links to these pages use the same text 'EAL parameters', so it is not
clear which link to use for which environment.
This patch adds the text '(Linux)' and '(Fre
I40evf queue can not work properly with kernel pf driver for X722 vf.
Eg. when configure 8 queues pair, only 4 queues can receive packets,
and half packets will be lost if using 2 queues pair.
This issue is caused by misconfiguration of look up table, the original
code of LUT configuration did no
Install missing dependencies so that doc can be generated.
While at it, explicitly configure that we want the doc to be generated.
Missing dependencies are then reported as an error rather than silently
ignored.
Because of these extra dependencies, only build them in dedicated travis
jobs.
Fixes:
13/08/2019 14:18, David Marchand:
> Start a new release cycle with empty release notes.
>
> Signed-off-by: David Marchand
> ---
> Changelog since v1:
> - added missing reference in index,
> - bumped the libraries version to 19.08,
> - included isonum,
Acked-by: Thomas Monjalon
Applied, thanks.
On 13/08/2019 04:24, Stephen Hemminger wrote:
> On Tue, 13 Aug 2019 11:06:10 +0800
> Haiyue Wang wrote:
>
>> Enhance the PMD to support retrieving trace information like
>> Rx/Tx burst selection etc.
>>
>> Signed-off-by: Haiyue Wang
>> ---
>> lib/librte_ethdev/rte_ethdev.c | 18
Replacing full license text with SPDX tag.
Signed-off-by: Allain Legacy
---
app/test/test_cfgfile.c | 32 ++--
1 file changed, 2 insertions(+), 30 deletions(-)
diff --git a/app/test/test_cfgfile.c b/app/test/test_cfgfile.c
index 37435b395..01905920e 100644
--- a/app/
Replace full license text with SPDX tag.
Signed-off-by: Allain Legacy
---
doc/guides/nics/avp.rst | 29 +
1 file changed, 1 insertion(+), 28 deletions(-)
diff --git a/doc/guides/nics/avp.rst b/doc/guides/nics/avp.rst
index 1fcba66ce..b3dbc2816 100644
--- a/doc/guides
Start a new release cycle with empty release notes.
Signed-off-by: David Marchand
---
Changelog since v1:
- added missing reference in index,
- bumped the libraries version to 19.08,
- included isonum,
---
VERSION| 2 +-
doc/guides/rel_notes/index.rst |
The AltiVec header file breaks boolean type:
error: incompatible types when initializing type
'__vector _bool int' {aka '_vector(4) __bool int'} using type 'int'
If __APPLE_ALTIVEC__ is defined, then bool type is redefined
and conflicts with stdbool.h.
There is no good solution to fix it for the
A build of recent DPDK 19.08 on all Ubuntu architectures returned this on ppc64:
../drivers/net/mlx4/mlx4_rxtx.c: In function ‘mlx4_tx_burst’:
../drivers/net/mlx4/mlx4_rxtx.c:919:14: error: incompatible types when
initializing type ‘__vector __bool int’ {aka ‘__vector(4) __bool int’}
us
Documentation includes separate pages of EAL command-line options for
Linux and for FreeBSD.
Links to these pages use the same text 'EAL parameters', so it is not
clear which link to use for which environment.
This patch adds the text '(Linux)' and '(FreeBSD)' where relevant, to
clearly identify t
> -Original Message-
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Tuesday, August 13, 2019 17:58
> To: Stephen Hemminger ; Wang, Haiyue
>
> Cc: dev ; Neil Horman
> Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace
> information
>
> On Tue,
As packet length extraction code was simplified,the ordering
was not necessary any more.[1]
2% performance gain was measured on Marvell ThunderX2.
4.3% performance gain was measure on Ampere eMAG80
[1] http://mails.dpdk.org/archives/dev/2016-April/037529.html
Fixes: ae0eb310f253 ("net/i40e: impl
Aarch64 neon vPMD survives across discontinuous DD bits, which makes
the ordering for descriptors loading unnecessary.
Similarly, the compiler barrier to order the extraction of packet
length is not needed any more when the extraction was simplified
by anothe patch.
Gavin Hu (2):
net/i40e: desc
For x86, the descriptors needs to be loaded in order, so in between two
descriptors loading, there is a compiler barrier in place.[1]
For aarch64, a patch [2] is in place to survive with discontinuous DD bits,
the barriers can be removed to take full advantage of out-of-order
execution.
50% perfor
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Govindarajan,
> LavanyaX
> Sent: Monday, July 22, 2019 7:02 PM
> To: Olivier Matz
> Cc: dev@dpdk.org; Pattan, Reshma ; Richardson,
> Bruce
> Subject: Re: [dpdk-dev] [PATCH] app/test: add unit test cases for m
The memory barrier was intended for descriptor data integrity (see
comments in [1]). However, since NEON loads are atomic, there is
no need for the memory barrier. Remove it accordingly.
Corrected couple of code comments.
In terms of performance, observed slightly higher average throughput
in tes
vPMD for aarch64 calculates the number of received packets using a loop.
Change to use NEON intrinsics for calculation. This saves CPU cycles
and has slightly better performance.
Signed-off-by: Ruifeng Wang
Reviewed-by: Gavin Hu
---
drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 27 +
Couple of changes to IXGBE vector PMD on aarch64 platform.
An unnecessary memory barrier was identified and removed.
Also part of processing was replaced with NEON intrinsics.
Both of the changes will help to improve performance.
Ruifeng Wang (2):
net/ixgbe: remove barrier in vPMD for aarch64
On Tue, Aug 13, 2019 at 5:24 AM Stephen Hemminger
wrote:
>
> On Tue, 13 Aug 2019 11:06:10 +0800
> Haiyue Wang wrote:
> > int rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id,
> > struct rte_eth_txq_info *qinfo);
> >
> > +int
> > +rte_eth_trace_info_get(uint16_t port_id, uint1
On Tue, 2019-08-13 at 01:03 +0200, Thomas Monjalon wrote:
> In order to re-use the same test environment as with
> test-build.sh, the configuration file is loaded at each build,
> after adjusting the variable DPDK_TARGET.
>
> This is especially useful to set the variable PKG_CONFIG_PATH,
> or defi
On Tue, 2019-08-13 at 01:03 +0200, Thomas Monjalon wrote:
> The compilation test is skipped if the compiler is not available.
> In the case of gcc/arm, it was tested both in the generic function
> "build" and in the cross-compilation section.
>
> By passing the compiler as argument of the generic
On Tue, 2019-08-13 at 01:03 +0200, Thomas Monjalon wrote:
> With VERBOSE=1, this error was seen in debug mode with gcc 9.1:
>
> In file included from /tmp/dpdk.auto-config-h.sh.c.w0VWMi:1:
> In file included from rdma-core/build/include/infiniband/mlx5dv.h:47:
> In file included from rdma-core/bui
On Tue, 2019-08-13 at 01:03 +0200, Thomas Monjalon wrote:
> If rdma-core is not installed in a standard directory of the system,
> it is possible to specify the location of the pkgconfig file via
> an environment variable:
> PKG_CONFIG_PATH=$PKG_CONFIG_PATH:~/rdma-core/build/lib/pkgconfig
>
> In t
On Tue, 2019-08-13 at 01:03 +0200, Thomas Monjalon wrote:
> Some drivers were missing reasons text for their disabling in meson.
>
> Signed-off-by: Thomas Monjalon <
> tho...@monjalon.net
> >
> ---
> drivers/baseband/turbo_sw/meson.build | 1 +
> drivers/net/memif/meson.build | 5 +++--
>
On Tue, 2019-08-13 at 01:03 +0200, Thomas Monjalon wrote:
> As explained in drivers/meson.build,
> "
> For the find_library() case (but not with dependency()) we also
> need to specify the "-l" flags in pkgconfig_extra_libs variable
> too, so that it can be reflected in the pkgconfig output f
Hi Jason,
Unrolled option effect is highly dependent on compilers. Just tried some
compilers around my side.
Vhost en-queue/de-queue path is separated into small parts which can assure
compilers can do unroll optimization.
Since only GCC8 support unroll program, only GCC8 added "#pragma GCC unrol
13/08/2019 09:46, David Marchand:
> On Tue, Aug 13, 2019 at 1:17 AM Thomas Monjalon wrote:
> >
> > 12/08/2019 13:43, David Marchand:
> > > Start a new release cycle with empty release notes.
> > >
> > > Signed-off-by: David Marchand
> > > ---
> > > VERSION| 2 +-
> -Original Message-
> From: Ye, Xiaolong
> Sent: Tuesday, August 13, 2019 3:37 PM
> To: Zhang, Xiao
> Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [v5] net/i40e: fix vf runtime queues rss config
>
> On 08/13, Zhang, Xiao wrote:
> >
> >
> >> -Original
On Tue, Aug 13, 2019 at 1:17 AM Thomas Monjalon wrote:
>
> 12/08/2019 13:43, David Marchand:
> > Start a new release cycle with empty release notes.
> >
> > Signed-off-by: David Marchand
> > ---
> > VERSION| 2 +-
> > doc/guides/rel_notes/release_19_11.rst | 214
On 08/13, Zhang, Xiao wrote:
>
>
>> -Original Message-
>> From: Ye, Xiaolong
>> Sent: Tuesday, August 13, 2019 2:28 PM
>> To: Zhang, Xiao
>> Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org
>> Subject: Re: [dpdk-dev] [v5] net/i40e: fix vf runtime queues rss config
>>
>> Hi, Xiao
>>
>> On
Additionally the dpdk-devbind.py shows as follows:
[root@vprobe mnt]#
/var/cache/ocsm/dpdk/dpdk-18.11/usertools/dpdk-devbind.py -s
Network devices using DPDK-compatible driver
:03:00.0 'VMXNET3 Ethernet Controller 07b0' drv=igb_uio unused=vmxnet3
N
> -Original Message-
> From: Ye, Xiaolong
> Sent: Tuesday, August 13, 2019 2:28 PM
> To: Zhang, Xiao
> Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [v5] net/i40e: fix vf runtime queues rss config
>
> Hi, Xiao
>
> On 08/13, Xiao Zhang wrote:
> >I40evf queu
The SEC HW code is being shared by multiple NXP based
drivers. It is better to place it at a common place.
the current users are:
1. DPAA2_SEC
2. DPAA_SEC
3. CAAM_JR
Signed-off-by: Hemant Agrawal
---
.../dpaa2_sec/hw => common/dpaax/caamflib}/compat.h | 0
.../{crypto/dpaa2_sec/hw => comm
58 matches
Mail list logo
