Re: [dpdk-dev] [PATCH v4] net/iavf: enable AVX2 for iavf

2019-09-22 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Monday, September 23, 2019 2:03 PM > To: Lu, Wenzhuo ; Zhang, Qi Z > ; Ye, Xiaolong > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH v4] net/iavf: enable AVX2 for iavf > > This patch enables AVX data path for iavf PMD. > > Signed-off-by

[dpdk-dev] [PATCH v4 30/30] net/ice/base: remove unused code

2019-09-22 Thread Qi Zhang
Remove unused code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 4 drivers/net/ice/base/ice_common.h| 2 -- drivers/net/ice/base/ice_flex_pipe.c | 1 - drivers/net/ice/base/ice_flow.h | 3 --- 4 files changed, 10 deletions(

[dpdk-dev] [PATCH v4 29/30] net/ice/base: add switch support for IPv6 tc field

2019-09-22 Thread Qi Zhang
Add support for IPv6 traffic class (tc) field for switch rule. Correct ice_ipv6_hdr based on the IPv6 Protocol using bitfields. Add big/little endian convert for tc field before it is inserted, since tc is only one byte and also does not have a byte-aligned offset. Signed-off-by: Junfeng Guo Sign

[dpdk-dev] [PATCH v4 23/30] net/ice/base: search field vector indices for result slots

2019-09-22 Thread Qi Zhang
Previously, switch code would use only pre-reserved index sl ots at the end of each field vector for recipe result index locations. This patch adds code that detects other internal empty index slots that could potentially be used. For each recipe that is added, a determ ination is made as to whethe

[dpdk-dev] [PATCH v4 26/30] net/ice/base: use bitmap copy where appropriate

2019-09-22 Thread Qi Zhang
ice_cp_bitmap() already exists and should be used instead of using ice_memcpy(). Note, there are a couple comments that sugges t using a bitmap-specific copy function, but those are not correct since the source block of memory is not a bitmap. Signed-off-by: Bruce Allan Signed-off-by: Paul M Sti

[dpdk-dev] [PATCH v4 25/30] net/ice/base: remove unnecessary error log

2019-09-22 Thread Qi Zhang
Remove the error log message when attempting to download a p ackage that has an unsupported version. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 16 1 file changed, 4 insertions(+), 12 deletion

[dpdk-dev] [PATCH v4 27/30] net/ice/base: fix alignment isue

2019-09-22 Thread Qi Zhang
As title says, fix an alignment issue. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Cc: sta...@dpdk.org Signed-off-by: Tony Nguyen Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 5 +++-- 1 file changed, 3 insertions(

[dpdk-dev] [PATCH v4 27/30] net/ice/base: fix alignment isue

2019-09-22 Thread Qi Zhang
As title says, fix an alignment issue. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Cc: sta...@dpdk.org Signed-off-by: Tony Nguyen Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 5 +++-- 1 file changed, 3 insertions(

[dpdk-dev] [PATCH v4 28/30] net/ice/base: fix PTYPE bitmap

2019-09-22 Thread Qi Zhang
Before this patch, IPv4 and UDP inner hash rule will be over written by later rules after RSS initialization phase. This is because the PTYPE bitmap table cover some PTYPEs belong to another PTGs. And some PTYPEs are reserved. Remove these PTYPEs in TCP, UDP, SCTP and ipv4 bitmap table. Fixes: aa1

[dpdk-dev] [PATCH v4 24/30] net/ice/base: fix 4 byte alignment for pppoe dummy packet

2019-09-22 Thread Qi Zhang
Add two bytes to meet the requirement of 4 byte alignment for dummy packet for creating switch rule for PPPoE. Fixes: 032b6c617a96 ("net/ice/base: add support for GTP and PPPoE protocols") Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ic

[dpdk-dev] [PATCH v4 22/30] net/ice/base: remove unused DDP package macros

2019-09-22 Thread Qi Zhang
Macros no longer be used and can be removed Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_type.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h index

[dpdk-dev] [PATCH v4 21/30] net/ice/base: fix segment in remove existing RSS rule

2019-09-22 Thread Qi Zhang
Before this patch, RSS tunneled rules can not be destroyed at runtime. This is because it can not find the existing matching profile for tunnels. segs[0] should always be zero and all matched, segs[1] for inner part. It only construct one segment. This patch modifies construct segment in ice_rem_r

[dpdk-dev] [PATCH v4 19/30] net/ice/base: add FDIR support for GTPU qfi field

2019-09-22 Thread Qi Zhang
Add GTPU qfi field support for flow director. Note that for GTPU pkt, only qfi field (6 bits) can be set for FD. The supported GTPU pkts are defined as: ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_UDP, ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP, ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP, ICE_FLTR_PTYPE_NONF_IPV4_

[dpdk-dev] [PATCH v4 17/30] net/ice/base: enable symmetric hash for RSS

2019-09-22 Thread Qi Zhang
Add parameter "symm" to rss configuration APIs. When symm is 1, Symmetric Teoplitz Hash can be enabled by configuring GLQF_HSYMM properly. NOTE: Symmetric Teoplitz hash will work only if hash schema of VSIQF_HASH_CTL be configured to 01b and it is assumed be enabled in PMD. Signed-off-by: Qi Zhan

[dpdk-dev] [PATCH v4 20/30] net/ice/base: fix the bitmap for TCP in RSS

2019-09-22 Thread Qi Zhang
Before this patch, if set rule for IPv4 first and then set rule for TCP with IPv4. The first rule for inner IP will be overwritten by TCP rule. This is because MAC_IPV6_TUN_MAC_IPV4_PAY using the same ptgs PTG_TUN_INNER_IPV4_OTHER with MAC_IPV4_TUN_MAC_IPV4_PAY, this ptype should not in TCP bitmap.

[dpdk-dev] [PATCH v4 18/30] net/ice/base: replace alloc-followed-by-copy with memdup

2019-09-22 Thread Qi Zhang
ice_memdup() is preferred over an alloc immediately followed by a copy. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 5 ++--- drivers/net/ice/base/ice_switch.c| 7 ++- 2 files changed, 4 insertions(+),

[dpdk-dev] [PATCH v4 16/30] net/ice/base: update FW API minor version

2019-09-22 Thread Qi Zhang
Update FW API minor version to align to current value advertised by FW in NVM images. Signed-off-by: Kevin Scott Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_controlq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ic

[dpdk-dev] [PATCH v4 15/30] net/ice/base: add dest MAC field support for FDIR

2019-09-22 Thread Qi Zhang
Add dest MAC address support so that this field can be matched when we set Flow Director filter with dst addr for MAC. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 19 +++ 1 file changed, 19 insertio

[dpdk-dev] [PATCH v4 07/30] net/ice/base: remove pointless NULL check of port info

2019-09-22 Thread Qi Zhang
The code in ice_sched_cleanup_all checks whether the port info is NULL prior to calling ice_sched_clear_port. More importantly, it also checks whether the port structure has been initialized by checking its port_state field as well. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr

[dpdk-dev] [PATCH v4 13/30] net/ice/base: enable fdir queue region

2019-09-22 Thread Qi Zhang
Add fdir queue region support. Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_fdir.c | 3 +++ drivers/net/ice/base/ice_fdir.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c index e

[dpdk-dev] [PATCH v4 11/30] net/ice/base: associate switch recipe to profiles

2019-09-22 Thread Qi Zhang
Properly associate switch recipes to profiles. Previous code was using the wrong bitfield for updating the associations, which was causing other PFs to not properly identify and use existing recipes. This sometimes resulted in rules not being added when it should have been possible. Signed-off-by:

[dpdk-dev] [PATCH v4 12/30] net/ice/base: enable RSS for PPPoE with SCTP

2019-09-22 Thread Qi Zhang
Add two ptypes(MAC_PPPOE_IPV4_SCTP and MAC_PPPOE_IPV6_SCTP) in sctp ptype bitmap to enable rss. Signed-off-by: Zhirun Yan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/n

[dpdk-dev] [PATCH v4 10/30] net/ice/base: minor structure refactor

2019-09-22 Thread Qi Zhang
When declaring the ice_prot_ext, and ice_prot_id_tbl structure, we can use a fixed length array instead of a variable length one which helps us catch future code changes that might desynchronize the enum ice_protocol_type and the structs. This change also necessitates removing the last member of t

[dpdk-dev] [PATCH v4 14/30] net/ice/base: enable setting up FDIR counters

2019-09-22 Thread Qi Zhang
Enable getting value from input to set up flow director counters, so that the FDIR counters can count none, packets only, bytes only or both packets and bytes as demanded. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c

[dpdk-dev] [PATCH v4 09/30] net/ice/base: add support for switch rule about VLAN PPPoE

2019-09-22 Thread Qi Zhang
Add support for switch rule about single-VLAN-PPPoE. Note that double VLAN is not supported by the hardware at this point, therefore only single-VLAN support for PPPoE is added. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_p

[dpdk-dev] [PATCH v4 08/30] net/ice/base: remove RSS code as iavf host

2019-09-22 Thread Qi Zhang
The DPDK PF doesn't support SRIOV so remove the related iavf host code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 128 1 file changed, 128 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b

[dpdk-dev] [PATCH v4 06/30] net/ice/base: propagate errors from functions

2019-09-22 Thread Qi Zhang
There could be an error returned from ice_fill_adv_dummy_packet() so we need to propagate that to the caller. Additionally, the call to ice_flow_xtract_pkt_flags() could also return an error so we need to propagate it as well. Also add in the correct offsets for GENEVE and VXLAN_GPE to the dummy p

[dpdk-dev] [PATCH v4 03/30] net/ice/base: add non-word aligned ip field support

2019-09-22 Thread Qi Zhang
Add non-word aligned field support for ipv4 with ttl, tos and proto. All these fields are one byte within one word. In order to match bytes within the IPv4 header for flow director we need to use a mask. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang ---

[dpdk-dev] [PATCH v4 01/30] net/ice/base: remove redundant empty lines

2019-09-22 Thread Qi Zhang
Remove redundant empty lines Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h| 111 --- drivers/net/ice/base/ice_bitops.h| 2 - drivers/net/ice/base/ice_common.c| 25 --- drivers/net/ice/b

[dpdk-dev] [PATCH v4 04/30] net/ice/base: add non-word aligned ipv6 field support

2019-09-22 Thread Qi Zhang
Add non-word aligned field support for IPv6 with hlim, tc and proto. All these fields are one byte within one word. In order to match bytes within the IPv6 header for flow director we need to use a mask. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang ---

[dpdk-dev] [PATCH v4 05/30] net/ice/base: correct the mask for checking protocol header

2019-09-22 Thread Qi Zhang
Before this patch, the logic of protocol header checking only support non-tunneled packet. This patch remove the inner protocol in L3/L4 RSS seg hdr mask and change the protocol header validation to reflect this. So, for ice_add_rss_cfg(), the last parameter addl_hdrs could specify the protocol hea

[dpdk-dev] [PATCH v4 02/30] net/ice/base: add support for tunnel packets

2019-09-22 Thread Qi Zhang
Add VXLAN tunnel training packets to flow director and change the interface to support tunnel packets. Signed-off-by: Henry Tieman Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 266 drivers/net/ice/base

[dpdk-dev] [PATCH v4 00/30] net/ice/base: share code update secend batch.

2019-09-22 Thread Qi Zhang
The patchset depends on the first batch http://patchwork.dpdk.org/project/dpdk/list/?series=6158&state=* Key Features: 1) Add tunnel support for fdir 2) Add non-word aligned field support for fdir 3) Add dest mac field support for fdir 4) Add flow count support for fdir 5) Add queue region suppor

[dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-09-22 Thread Marvin Liu
If reserve virtio header room by function rte_pktmbuf_prepend, both segment data length and packet length of mbuf will be increased. Data length will be equal to descriptor length, while packet length should be decreased as virtio-net header won't be taken into packet. Thus will cause mismatch in m

Re: [dpdk-dev] [PATCH v2 06/16] vhost: rename flush shadow used ring functions

2019-09-22 Thread Tiwei Bie
On Fri, Sep 20, 2019 at 12:36:33AM +0800, Marvin Liu wrote: > Simplify flush shadow used ring function names as all shadow rings are > reflect to used rings. No need to emphasize ring type. I think the old name "flush_shadow_used_ring" is more readable than the new name "flush_shadow". In the new

[dpdk-dev] [PATCH v4] net/iavf: enable AVX2 for iavf

2019-09-22 Thread Leyi Rong
This patch enables AVX data path for iavf PMD. Signed-off-by: Leyi Rong --- v4: - Romoves redundant IAVF_NO_VECTOR_FLAGS define. v3: - Adds release note. v2: - Fixes build error on aarch64. --- doc/guides/rel_notes/release_19_11.rst | 3 + drivers/net/iavf/Makefile | 21 + d

Re: [dpdk-dev] [PATCH v2 03/16] vhost: add burst enqueue function for packed ring

2019-09-22 Thread Tiwei Bie
On Fri, Sep 20, 2019 at 12:36:30AM +0800, Marvin Liu wrote: > Burst enqueue function will first check whether descriptors are cache > aligned. It will also check prerequisites in the beginning. Burst > enqueue function not support chained mbufs, single packet enqueue > function will handle it. > >

Re: [dpdk-dev] [PATCH v4 3/4] raw/ntb: add enqueue and dequeue functions

2019-09-22 Thread Wu, Jingjing
> -Original Message- > From: Li, Xiaoyun > Sent: Monday, September 9, 2019 11:27 AM > To: Wu, Jingjing ; Wiles, Keith > ; Maslekar, > Omkar ; Liang, Cunming > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v4 3/4] raw/ntb: add enqueue and dequeue functions > > Introduce enqueue and

Re: [dpdk-dev] [PATCH v2 02/16] vhost: unify unroll pragma parameter

2019-09-22 Thread Tiwei Bie
On Fri, Sep 20, 2019 at 12:36:29AM +0800, Marvin Liu wrote: > Add macro for unifying Clang/ICC/GCC unroll pragma format. Burst > functions were contained of several small loops which optimized by > compiler’s loop unrolling pragma. > > Signed-off-by: Marvin Liu > > diff --git a/lib/librte_vhost/

Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction support for per Rx queue

2019-09-22 Thread Wang, Haiyue
> -Original Message- > From: Yang, Qiming > Sent: Monday, September 23, 2019 11:26 > To: Rong, Leyi ; Wang, Haiyue ; > Lu, Wenzhuo > ; Zhang, Qi Z ; Ye, Xiaolong > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction > support for per Rx queue >

Re: [dpdk-dev] [PATCH v4 2/4] raw/ntb: add xstats support

2019-09-22 Thread Wu, Jingjing
> static int > -ntb_xstats_reset(struct rte_rawdev *dev __rte_unused, > - const uint32_t ids[] __rte_unused, > - uint32_t nb_ids __rte_unused) > +ntb_xstats_reset(struct rte_rawdev *dev, > + const uint32_t ids[], > + uint32_t nb_ids) > { > -

Re: [dpdk-dev] [PATCH v4 1/4] raw/ntb: setup ntb queue

2019-09-22 Thread Li, Xiaoyun
Hi > -Original Message- > From: Wu, Jingjing > Sent: Monday, September 23, 2019 10:50 > To: Li, Xiaoyun ; Wiles, Keith ; > Maslekar, Omkar ; Liang, Cunming > > Cc: dev@dpdk.org > Subject: RE: [PATCH v4 1/4] raw/ntb: setup ntb queue > > <...> > > +static void > > +ntb_rxq_release(struct n

Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction support for per Rx queue

2019-09-22 Thread Yang, Qiming
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Leyi Rong > Sent: Thursday, September 19, 2019 2:26 PM > To: Wang, Haiyue ; Lu, Wenzhuo > ; Zhang, Qi Z ; Ye, Xiaolong > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction s

Re: [dpdk-dev] [PATCH v4 1/4] raw/ntb: setup ntb queue

2019-09-22 Thread Wu, Jingjing
<...> > +static void > +ntb_rxq_release(struct ntb_rx_queue *rxq) > +{ > + if (!rxq) { > + NTB_LOG(ERR, "Pointer to rxq is NULL"); > + return; > + } > + > + ntb_rxq_release_mbufs(rxq); > + > + rte_free(rxq->sw_ring); > + rte_free(rxq); It' better to free

Re: [dpdk-dev] [PATCH v4 0/5] drivers/net: release port upon close

2019-09-22 Thread Yang, Qiming
> -Original Message- > From: Di, ChenxuX > Sent: Thursday, September 19, 2019 10:48 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Di, ChenxuX > > Subject: [PATCH v4 0/5] drivers/net: release port upon close > > Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources > for the

[dpdk-dev] dpdk : windows build issue

2019-09-22 Thread Revanur Srinivasa Kumar (RBEI/ETA)
Hi, We are evaluating dpdk on windows10 64 bit desktop version ( linux runs fine ). Build system is setup on PC, but I see that dpdk is supported on windows server 2016/2019 only. Can we run dpdk on windows 10 ? Best regards, srinivas

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-09-22 Thread Abhishek Marathe
Hi All, While testing 18.11.3-rc1 on Azure we faced following problems: 1. VERIFY-DPDK-OVS - This test case builds OVS (OpenVSwitch) with DPDK support on Ubuntu distro (16.04 and 18.04) and tests if the OVS DPDK ports can be created. This testcase aborted, after diagnosis we found out that ins

Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit doorbell register write barrier

2019-09-22 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Sunday, September 22, 2019 9:59 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Raslan Darawsheh > Subject: RE: [PATCH] net/mlx5: fix transmit doorbell register write barrier > > Hi Slava > > Questions inline. > [.. skipped ...] > > + /*

Re: [dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst error handling

2019-09-22 Thread Matan Azrad
From: Dekel Peled > In the process of recovery from error CQE, when using vectorized Rx burst, > the initialization of data length in mbufs was not done. > As a result the wrong length was left written in mbuf, causing memory > overwrite or wrong error report. > > This patch fixes the initializ

[dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst error handling

2019-09-22 Thread Dekel Peled
In the process of recovery from error CQE, when using vectorized Rx burst, the initialization of data length in mbufs was not done. As a result the wrong length was left written in mbuf, causing memory overwrite or wrong error report. This patch fixes the initialization of mbuf data length during

Re: [dpdk-dev] [PATCH v1 0/9] mlx5: Handle data-path completions with error

2019-09-22 Thread Matan Azrad
From: Kevin Traynor > On 30/05/2019 11:20, Matan Azrad wrote: > > Add support for data-path Rx and Tx completions with error handling: > > > > 1. Detect the error. > > 2. Do not crash. > > 3. Report it in statistics counters. > > 4. Dump debug information to system log file. > > 5. Recover the er

Re: [dpdk-dev] [PATCH] net/mlx5: fix UAR remap initialization for 32-bit systems

2019-09-22 Thread Matan Azrad
From: Viacheslav Ovsiienko > The txq_uar_init() routine uses the uninitialized uar_mmap_offset field in > 32-bit configurations due to this field is initialized after txq_uar_init() > call. > > Fixes: 120dc4a7dcd3 ("net/mlx5: remove device register remap") > > Signed-off-by: Viacheslav Ovsiie