Re: [dpdk-dev] [PATCH 1/7] uuid: remove BSD boilerplate

2019-09-25 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH 13/13] doc: add hairpin feature

2019-09-25 Thread Ori Kam
This commit adds the hairpin feature to the release notes. Signed-off-by: Ori Kam --- doc/guides/rel_notes/release_19_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst index c8d97f1..a880655 100644 ---

[dpdk-dev] [PATCH 09/13] net/mlx5: add internal tag item and action

2019-09-25 Thread Ori Kam
This commit introduce the setting and matching on regiters. This item and and action will be used with number of different features like hairpin, metering, metadata. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c| 52 + drivers/net/mlx5/mlx5_flow.h| 54

[dpdk-dev] [PATCH 12/13] net/mlx5: split hairpin flows

2019-09-25 Thread Ori Kam
Since the encap action is not supported in RX, we need to split the hairpin flow into RX and TX. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.c| 10 ++ drivers/net/mlx5/mlx5.h| 10 ++ drivers/net/mlx5/mlx5_flow.c | 281 +++-- dr

[dpdk-dev] [PATCH 08/13] net/mlx5: add support for hairpin hrxq

2019-09-25 Thread Ori Kam
The hairpin hrxq is based on the DevX hrxq but uses different pd. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_rxq.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index a673da9..bf39112 100644 --- a/d

[dpdk-dev] [PATCH 11/13] net/mlx5: add default flows for hairpin

2019-09-25 Thread Ori Kam
When using hairpin all traffic from TX hairpin queues should jump to dedecated table where matching can be done using regesters. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/mlx5_flow.c| 60 +++ drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH 10/13] net/mlx5: add id generation function

2019-09-25 Thread Ori Kam
When splitting flows for example in hairpin / metering, there is a need to combine the flows. This is done using ID. This commit introduce a simple way to generate such IDs. The reason why bitmap was not used is due to fact that the release and allocation are O(n) while in the chosen approch the a

[dpdk-dev] [PATCH 06/13] app/testpmd: add hairpin support

2019-09-25 Thread Ori Kam
This commit introduce the hairpin queues to the testpmd. the hairpin queue is configured using --hairpinq= the hairpin queue adds n queue objects for both the total number of TX queues and RX queues. The connection between the queues are 1 to 1, first Rx hairpin queue will be connected to the first

[dpdk-dev] [PATCH 03/13] net/mlx5: support Rx hairpin queues

2019-09-25 Thread Ori Kam
This commit adds the support for creating Rx hairpin queues. Hairpin queue is a queue that is created using DevX and only used by the HW. This results in that all the data part of the RQ is not being used. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.c | 2 + drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH 07/13] net/mlx5: add hairpin binding function

2019-09-25 Thread Ori Kam
When starting the port, in addition to creating the queues we need to bind the hairpin queues. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_devx_cmds.c | 1 + drivers/net/mlx5/mlx5_prm.h | 6 +++ drivers/net/mlx5/mlx5_trigger.c | 97 +++

[dpdk-dev] [PATCH 02/13] net/mlx5: query hca hairpin capabilities

2019-09-25 Thread Ori Kam
This commit query and store the hairpin capabilities from the device. Those capabilities will be used when creating the hairpin queue. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 4 drivers/net/mlx5/mlx5_devx_cmds.c | 7 +++ 2 files changed, 11 insertions(+) diff --

[dpdk-dev] [PATCH 04/13] net/mlx5: prepare txq to work with different types

2019-09-25 Thread Ori Kam
Currenlty all Tx queues are created using Verbs. This commit modify the naming so it will not include verbs, since in next commit a new type will be introduce (hairpin) Signed-off-by: Ori Kam Conflicts: drivers/net/mlx5/mlx5_txq.c --- drivers/net/mlx5/mlx5.c | 2 +- drivers/net

[dpdk-dev] [PATCH 05/13] net/mlx5: support Tx hairpin queues

2019-09-25 Thread Ori Kam
This commit adds the support for creating Tx hairpin queues. Hairpin queue is a queue that is created using DevX and only used by the HW. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.c | 26 drivers/net/mlx5/mlx5.h | 46 +++ drivers/net/mlx5/mlx5_devx_cmds.c |

[dpdk-dev] [PATCH 01/13] ethdev: support setup function for hairpin queue

2019-09-25 Thread Ori Kam
This commit introduce the RX/TX hairpin setup function. Hairpin is RX/TX queue that is used by the nic in order to offload wire to wire traffic. Each hairpin queue is binded to one or more queues from other type. For example TX hairpin queue should be binded to at least 1 RX hairpin queue and vic

[dpdk-dev] [PATCH 00/13] add hairpin feature

2019-09-25 Thread Ori Kam
This patch set implements the hairpin feature. The hairpin feature was introduced in RFC[1] The hairpin feature (different name can be forward) acts as "bump on the wire", meaning that a packet that is received from the wire can be modified using offloaded action and then sent back to the wire wit

[dpdk-dev] SR-IOV with vfio-pci

2019-09-25 Thread Deepak Gowda
Hi, I'm trying to run test-pmd application with virtual functions bound to vfio-pci. I'm able to bind and unbind the virtual functions from ixgbevf to vfio-pci and vice-versa And i'm seeing the below VF Initialization failure error, i can't seem to figure out what's going wrong here, EAL: using

Re: [dpdk-dev] [PATCH v3 10/15] vhost: optimize enqueue function of packed ring

2019-09-25 Thread Tiwei Bie
On Thu, Sep 26, 2019 at 01:13:24AM +0800, Marvin Liu wrote: > static __rte_noinline uint32_t > virtio_dev_rx_packed(struct virtio_net *dev, struct vhost_virtqueue *vq, > struct rte_mbuf **pkts, uint32_t count) > { > uint32_t pkt_idx = 0; > - uint16_t num_buffers; > - struct b

Re: [dpdk-dev] [PATCH v3 02/15] vhost: unify unroll pragma parameter

2019-09-25 Thread Tiwei Bie
On Thu, Sep 26, 2019 at 01:13:16AM +0800, Marvin Liu wrote: > Add macro for unifying Clang/ICC/GCC unroll pragma format. Batch > functions were contained of several small loops which optimized by > compiler’s loop unrolling pragma. > > Signed-off-by: Marvin Liu > > diff --git a/lib/librte_vhost/

Re: [dpdk-dev] [PATCH v3 13/15] vhost: cache address translation result

2019-09-25 Thread Tiwei Bie
On Thu, Sep 26, 2019 at 01:13:27AM +0800, Marvin Liu wrote: > Cache address translation result and use it in next translation. Due > to limited regions are supported, buffers are most likely in same > region when doing data transmission. > > Signed-off-by: Marvin Liu > > diff --git a/lib/librte_

Re: [dpdk-dev] [PATCH v1 1/1] bus/pci: probe PCI devices in whitelisted order

2019-09-25 Thread Vamsi Krishna Attunuru
-Original Message- From: dev On Behalf Of Gaëtan Rivet Sent: Wednesday, September 25, 2019 2:37 PM To: Slava Ovsiienko Cc: Vamsi Krishna Attunuru ; dev@dpdk.org; ferruh.yi...@intel.com; anatoly.bura...@intel.com; Thomas Monjalon ; Jerin Jacob Kollanukkaran Subject: Re: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH v6 0/4] enable FIFO for NTB

2019-09-25 Thread Wu, Jingjing
> -Original Message- > From: Li, Xiaoyun > Sent: Thursday, September 26, 2019 11:20 AM > To: Wu, Jingjing ; Wiles, Keith > ; Maslekar, > Omkar ; Liang, Cunming > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v6 0/4] enable FIFO for NTB > > Enable FIFO for NTB rawdev driver to suppo

[dpdk-dev] [PATCH v6 2/4] raw/ntb: add xstats support

2019-09-25 Thread Xiaoyun Li
Add xstats support for ntb rawdev. Support tx-packets, tx-bytes, tx-errors and rx-packets, rx-bytes, rx-missed. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb/ntb.c | 170 +- drivers/raw/ntb/ntb.h | 12 +++ 2 files changed, 164 insertions(+), 18 deletions(

[dpdk-dev] [PATCH v6 1/4] raw/ntb: setup ntb queue

2019-09-25 Thread Xiaoyun Li
Setup and init ntb txq and rxq. And negotiate queue information with the peer. If queue size and number of queues are not consistent on both sides, return error. Signed-off-by: Xiaoyun Li --- doc/guides/rawdevs/ntb.rst | 39 +- doc/guides/rel_notes/release_19_11.rst | 4 + drivers

Re: [dpdk-dev] [PATCH v4 1/5] net/e1000: release port upon close

2019-09-25 Thread Di, ChenxuX
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 11:41 PM > To: Di, ChenxuX > Cc: dev@dpdk.org; Yang, Qiming > Subject: Re: [dpdk-dev] [PATCH v4 1/5] net/e1000: release port upon close > > On 09/19, Di ChenxuX wrote: > >Set RTE_ETH_DEV_CLOSE_REMOVE upon

[dpdk-dev] [PATCH v6 0/4] enable FIFO for NTB

2019-09-25 Thread Xiaoyun Li
Enable FIFO for NTB rawdev driver to support packet based processing. And an example is provided to support txonly, rxonly, iofwd between NTB device and ethdev, and file transmission. Acked-by: Omkar Maslekar --- v6: * Fixed xstats reset typo. * Fixed free functions when error happens. * Adde

[dpdk-dev] [PATCH v6 3/4] raw/ntb: add enqueue and dequeue functions

2019-09-25 Thread Xiaoyun Li
Introduce enqueue and dequeue functions to support packet based processing. And enable write-combining for ntb driver since it can improve the performance a lot. Signed-off-by: Xiaoyun Li --- doc/guides/rawdevs/ntb.rst | 54 drivers/raw/ntb/ntb.c | 242

[dpdk-dev] [PATCH v6 4/4] examples/ntb: support more functions for NTB

2019-09-25 Thread Xiaoyun Li
Support to transmit files between two systems. Support iofwd between one ethdev and NTB device. Support rxonly and txonly for NTB device. Support to set forwarding mode as file-trans, txonly, rxonly or iofwd. Support to show/clear port stats and throughput. Signed-off-by: Xiaoyun Li --- doc/guid

[dpdk-dev] [PATCH v2] net/i40e: fix exception with multi-driver

2019-09-25 Thread alvinx . zhang
From: Alvin Zhang If support-multi-driver is enabled, the global registers should not be configured. But with the correct code base, if creating a flow with rte_flow API, the global register GLQF_FD_MSK may be changed. Fixes: cfdfca493cae ("net/i40e: fix multiple driver support") Cc: sta...@dpdk

Re: [dpdk-dev] [PATCH v2 4/7] ethdev: change allmulticast callbacks to return status

2019-09-25 Thread Yang, Qiming
[snip] ... Hi, Andrew I think it's no need to define a 'ret'. Return -EAGAIN and return 0 is enough. Qiming static int diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 46ed70816..c699f3ef0 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error

2019-09-25 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of taox@intel.com > Sent: Thursday, September 26, 2019 2:03 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; ivan.ilche...@oktetlabs.com; Zhu, TaoX > > Subject: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH 2/9] eal: syslog implementation for windows

2019-09-25 Thread Pallavi Kadam
On 9/10/2019 2:17 AM, Stephen Hemminger wrote: On Mon, 9 Sep 2019 12:53:57 -0700 Pallavi Kadam wrote: +/* Copyright (c) 1982, 1986, 1988, 1993 + * The Regents of the University of California. All rights reserved. + * + * Redistribution and use in source and binary forms, with or withou

Re: [dpdk-dev] |WARNING| pw59738 [PATCH v2 2/2] mbuf: add bulk free function

2019-09-25 Thread Stephen Hemminger
On Wed, 25 Sep 2019 14:17:42 +0200 Morten Brørup wrote: > Dear Thomas - listed as checkpatch maintainer, > > I think this warning is bogus, and is a bug checkpatch. > > The line in question was deliberately indented using tabs to the current > indentation level, and using spaces for the readab

[dpdk-dev] [PATCH] eal:ppc: fix incorrect ifdef for ppc_64

2019-09-25 Thread David Christensen
An ifdef present in eal_memory.c references "RTE_ARCH_PPC64" when it should actually use "RTE_ARCH_PPC_64". Simple testing revealed that both the PPC_64 and non-PPC_64 versions of the code involved work, but the PPC_64 version of the code is retained to be consistent with other instances in the sa

Re: [dpdk-dev] [PATCH v3 03/15] vhost: add batch enqueue function for packed ring

2019-09-25 Thread Mattias Rönnblom
On 2019-09-25 19:13, Marvin Liu wrote: Batch enqueue function will first check whether descriptors are cache aligned. It will also check prerequisites in the beginning. Batch enqueue function not support chained mbufs, single packet enqueue function will handle it. Signed-off-by: Marvin Liu di

Re: [dpdk-dev] [PATCH v2 2/2] mbuf: add bulk free function

2019-09-25 Thread Mattias Rönnblom
On 2019-09-25 14:03, Morten Brørup wrote: Add function for freeing a bulk of mbufs. Signed-off-by: Morten Brørup --- lib/librte_mbuf/rte_mbuf.c | 35 +++ lib/librte_mbuf/rte_mbuf.h | 16 +--- 2 files changed, 40 insertions(+), 11 deletions(-) dif

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-25 Thread Ananyev, Konstantin
> > > > > > > > > This action type allows the burst of symmetric crypto > > > > > > > > > workload using > > > the > > > > > > > same > > > > > > > > > algorithm, key, and direction being processed by CPU cycles > > > > > synchronously. > > > > > > > > > This flexible action type does not requir

Re: [dpdk-dev] [PATCH 0/3] RFC: Support disabling DPDK drivers in meson builds

2019-09-25 Thread Luca Boccassi
On Wed, 2019-09-25 at 15:55 +0100, Bruce Richardson wrote: > Following on from the discussion about meson at userspace 2019, here > is > a patchset which allows a user to disable drivers in a DPDK build. > This > set also includes the changes necessary to recursively disable any > drivers that depe

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix Segment fault when start fwd

2019-09-25 Thread Ferruh Yigit
On 9/24/2019 10:09 AM, Iremonger, Bernard wrote: >> -Original Message- >> From: Wang, ShougangX >> Sent: Tuesday, September 24, 2019 5:49 AM >> To: dev@dpdk.org >> Cc: Yang, Qiming ; Iremonger, Bernard >> ; Yigit, Ferruh ; >> Wang, ShougangX ; sta...@dpdk.org >> Subject: [PATCH v3] app/test

Re: [dpdk-dev] [RFC v3 4/4] app/testpmd: show the Rx/Tx burst mode description

2019-09-25 Thread Wang, Haiyue
Thanks, Bernard. Hi Ferruh, Can this series patches be for 20.02 upstream ? BR, Haiyue > -Original Message- > From: Iremonger, Bernard > Sent: Friday, September 13, 2019 00:08 > To: Wang, Haiyue ; dev@dpdk.org; Yigit, Ferruh > ; > m...@ashroe.eu; Sun, Chenmin > Cc: Wang, Haiyue > Sub

[dpdk-dev] [PATCH v7] eal: make lcore_config private

2019-09-25 Thread Stephen Hemminger
The internal structure of lcore_config is no longer be part of visible API/ABI. Make it private to EAL. Rearrange and resize the fields in the structure so it takes less memory (and cache footprint). Signed-off-by: Stephen Hemminger --- v7 - add eal_private.h to windows lib/librte_eal/common/e

[dpdk-dev] 18.11.3 (LTS) patches review and test

2019-09-25 Thread Kevin Traynor
On 19/09/2019 11:22, Yu, PingX wrote: > Hi all, > Update Intel test result here. > Hi Yu Ping, Thanks for testing. Some comments/questions on the failures, > # Basic Intel(R) NIC testing > * PF(i40e): Pass > * PF(ixgbe): Pass > * VF: Pass > * Build or compile: 3 bugs are found. > 1. [dpdk-st

[dpdk-dev] [PATCH 7/7] test: add SPDX headers

2019-09-25 Thread Stephen Hemminger
These are minor test files that never got converted. Signed-off-by: Stephen Hemminger --- app/test/test_cfgfile.c | 32 ++- app/test/test_compressdev_test_buffer.h | 2 ++ app/test/test_thash.c | 34 +++-- app/test/test_t

[dpdk-dev] [PATCH 6/7] testpmd: add SPDX license tags

2019-09-25 Thread Stephen Hemminger
These files are old tests where the original owner is not active. Change from BSD boilerplate to SPDX. Signed-off-by: Stephen Hemminger --- app/test-pmd/flowgen.c | 35 +++ app/test-pmd/macswap.c | 33 ++--- 2 files changed, 5 insertion

[dpdk-dev] [PATCH 5/7] ethdev: add SPDX tags to pci and vdev headers

2019-09-25 Thread Stephen Hemminger
Missing SPDX tags on these. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev_pci.h | 34 +++-- lib/librte_ethdev/rte_ethdev_vdev.h | 34 +++-- 2 files changed, 6 insertions(+), 62 deletions(-) diff --git a/lib/librte_ethdev/rte_e

[dpdk-dev] [PATCH 0/7] SPDX license tag changes

2019-09-25 Thread Stephen Hemminger
These patches are all comment (not code) related to SPDX license tags. Stephen Hemminger (7): uuid: remove BSD boilerplate reciprocal: remove redundant boilerplate windows: remove boilerplate from BSD header kni: add SPDX license tag ethdev: add SPDX tags to pci and vdev headers testpm

[dpdk-dev] [PATCH 1/7] uuid: remove BSD boilerplate

2019-09-25 Thread Stephen Hemminger
License type is already clear from SPDX tag. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_uuid.c | 26 lib/librte_eal/common/include/rte_uuid.h | 26 2 files changed, 52 deletions(-) diff --git a/lib/librte_eal/common/e

[dpdk-dev] [PATCH 2/7] reciprocal: remove redundant boilerplate

2019-09-25 Thread Stephen Hemminger
No need for extra language, coverd by SPDX tag. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/rte_reciprocal.c | 34 ++ 1 file changed, 2 insertions(+), 32 deletions(-) diff --git a/lib/librte_eal/common/rte_reciprocal.c b/lib/librte_eal/common/rte_reciproc

[dpdk-dev] [PATCH 4/7] kni: add SPDX license tag

2019-09-25 Thread Stephen Hemminger
Per policy, DPDK uses SPDX license tags instead of BSD boilerplate. Signed-off-by: Stephen Hemminger --- lib/librte_port/rte_port_kni.c | 36 -- lib/librte_port/rte_port_kni.h | 36 -- 2 files changed, 8 insertions(+), 64 deletions(

[dpdk-dev] [PATCH 3/7] windows: remove boilerplate from BSD header

2019-09-25 Thread Stephen Hemminger
The BSD license is already handled by SPDX tag. Signed-off-by: Stephen Hemminger --- .../windows/eal/include/sys/queue.h | 25 --- 1 file changed, 25 deletions(-) diff --git a/lib/librte_eal/windows/eal/include/sys/queue.h b/lib/librte_eal/windows/eal/include/sys/queu

Re: [dpdk-dev] [PATCH v4 1/5] net/e1000: release port upon close

2019-09-25 Thread Ye Xiaolong
On 09/19, Di ChenxuX wrote: >Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources > for the port can be freed by rte_eth_dev_close(). > >Signed-off-by: Di ChenxuX >--- > doc/guides/rel_notes/release_19_11.rst | 5 + > drivers/net/e1000/igb_ethdev.c | 144 --

Re: [dpdk-dev] [dpdk-techboard] [RFC] Proposals and notes from ABI stability panel @ DPDK Userspace

2019-09-25 Thread Ray Kinsella
On 25/09/2019 15:40, Bruce Richardson wrote: > On Wed, Sep 25, 2019 at 03:29:16PM +0100, Ray Kinsella wrote: >> >>> In the short term, based on the feedback at the conference and to give >>> something concrete to be considered, here is a suggestion, >>> >>> ABI freeze starts at 20.02 for 9 month

[dpdk-dev] [PATCH 3/3] build: support disabling drivers with meson

2019-09-25 Thread Bruce Richardson
Add support for a new build option to turn off certain drivers. Any other drivers which depend on the one being disabled will also be disabled with a suitable debug message. Signed-off-by: Bruce Richardson --- drivers/meson.build | 16 meson_options.txt | 2 ++ 2 files change

[dpdk-dev] [PATCH 2/3] build: process dependencies before main build check

2019-09-25 Thread Bruce Richardson
If we want to add support for turning off components because of missing dependencies, then we need to check for those dependencies before we make a determination as to whether a component should be built or not, assuming that the component says it should be built. Signed-off-by: Bruce Richardson

[dpdk-dev] [PATCH 1/3] build: align variable names between drivers and libs

2019-09-25 Thread Bruce Richardson
The variable names in the library and drivers meson.build files are slighty different with "static_deps" in one and "static_objs" in the other. Rename to use "static_deps" in both for consistency. Signed-off-by: Bruce Richardson --- drivers/meson.build | 22 +++--- 1 file changed

[dpdk-dev] [PATCH 0/3] RFC: Support disabling DPDK drivers in meson builds

2019-09-25 Thread Bruce Richardson
Following on from the discussion about meson at userspace 2019, here is a patchset which allows a user to disable drivers in a DPDK build. This set also includes the changes necessary to recursively disable any drivers that depend upon the disabled one, e.g. disabling mempool/dpaa also disables net

Re: [dpdk-dev] [PATCH v7 10/10] vhost: add vhost-user-blk example which support inflight

2019-09-25 Thread Tiwei Bie
On Fri, Sep 20, 2019 at 08:01:02PM +0800, Jin Yu wrote: > A vhost-user-blk example that support inflight feature. It uses the > new APIs that introduced in the first patch, so It can show how there s/It/it/ s/there/these/ > APIs work to support inflight feature. > > Signed-off-by: Jin Yu > ---

Re: [dpdk-dev] [dpdk-techboard] [RFC] Proposals and notes from ABI stability panel @ DPDK Userspace

2019-09-25 Thread Kevin Traynor
On 25/09/2019 15:40, Bruce Richardson wrote: > On Wed, Sep 25, 2019 at 03:29:16PM +0100, Ray Kinsella wrote: >> >>> In the short term, based on the feedback at the conference and to give >>> something concrete to be considered, here is a suggestion, >>> >>> ABI freeze starts at 20.02 for 9 months,

Re: [dpdk-dev] [dpdk-techboard] [RFC] Proposals and notes from ABI stability panel @ DPDK Userspace

2019-09-25 Thread Bruce Richardson
On Wed, Sep 25, 2019 at 03:29:16PM +0100, Ray Kinsella wrote: > > > In the short term, based on the feedback at the conference and to give > > something concrete to be considered, here is a suggestion, > > > > ABI freeze starts at 20.02 for 9 months, with a review as planned to see > > if 20.11 s

Re: [dpdk-dev] [PATCH v4 1/4] doc: separate versioning.rst into version and policy

2019-09-25 Thread Neil Horman
On Wed, Sep 25, 2019 at 02:01:01PM +0100, Ray Kinsella wrote: > Hi Neil, > > Thanks for the feedback, other comment below. > > On 25/09/2019 13:24, Neil Horman wrote: > > On Wed, Sep 25, 2019 at 11:23:53AM +0100, Ray Kinsella wrote: > >> Separate versioning.rst into abi versioning and abi policy

Re: [dpdk-dev] [RFC] Proposals and notes from ABI stability panel @ DPDK Userspace

2019-09-25 Thread Ray Kinsella
> In the short term, based on the feedback at the conference and to give > something concrete to be considered, here is a suggestion, > > ABI freeze starts at 20.02 for 9 months, with a review as planned to see > if 20.11 should be frozen 2 years. > > pros: > + Eliminates any need for delaying

Re: [dpdk-dev] [PATCH v7 00/10] vhost: support inflight share memory protocol feature

2019-09-25 Thread Tiwei Bie
> [PATCH v7 00/10] vhost: support inflight share memory protocol feature This should be v8. Please increase the version number when sending a new series. Thanks, Tiwei On Fri, Sep 20, 2019 at 08:00:52PM +0800, Jin Yu wrote: > This patches introduces two new messages VHOST_USER_GET_INFLIGHT_FD

[dpdk-dev] [PATCH v2 17/17] net/hinic: optimize tx&rx performance

2019-09-25 Thread Xiaoyun wang
This patch optimizes receive packets performance in arm platform. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_rx.c | 17 + drivers/net/hinic/hinic_pmd_rx.h | 11 +++ 2 files changed, 28 insertions(+) diff --git a/drivers/net/hinic/hinic_pmd_rx.c b/drivers

[dpdk-dev] [PATCH v2 16/17] net/hinic/base: optimize aeq interfaces

2019-09-25 Thread Xiaoyun wang
This patch deletes ceq interfaces that not needed, fix aeq buges in some scenarios. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_csr.h | 29 +--- drivers/net/hinic/base/hinic_pmd_cmd.h | 5 +- drivers/net/hinic/base/hinic_pmd_eqs.c | 245 +

[dpdk-dev] [PATCH v2 14/17] net/hinic: support LRO offload

2019-09-25 Thread Xiaoyun wang
This patch supports LRO offload. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c index 8ea5998..6f3eb18

[dpdk-dev] [PATCH v2 15/17] net/hinic: add hinic PMD doc files

2019-09-25 Thread Xiaoyun wang
Add doc files about new features and modification. Signed-off-by: Xiaoyun wang --- doc/guides/nics/features/hinic.ini | 12 - doc/guides/nics/hinic.rst | 6 + doc/guides/rel_notes/release_19_11.rst | 45 ++ 3 files changed, 25 inserti

[dpdk-dev] [PATCH v2 12/17] net/hinic: set link down and up

2019-09-25 Thread Xiaoyun wang
This patch supports setting link down and up, Also adds support for geting firmware version. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cmd.h| 4 ++ drivers/net/hinic/base/hinic_pmd_niccfg.c | 78 drivers/net/hinic/base/hinic_pmd_niccfg.h |

[dpdk-dev] [PATCH v2 11/17] net/hinic: flush fdir filter

2019-09-25 Thread Xiaoyun wang
Supports to flush fdir filter. Destroy all flow rules associated with a port on hinic. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c | 16 drivers/net/hinic/hinic_pmd_ethdev.h | 3 +- drivers/net/hinic/hinic_pmd_flow.c | 140 +++ 3

[dpdk-dev] [PATCH v2 13/17] net/hinic: support inner L3 checksum offload

2019-09-25 Thread Xiaoyun wang
This patch supports inner L3 checksum offload, modifies rx checksum offload. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.h | 1 + drivers/net/hinic/hinic_pmd_rx.c | 10 +- drivers/net/hinic/hinic_pmd_tx.c | 190 ++- 3 files change

[dpdk-dev] [PATCH v2 10/17] net/hinic: create and destroy fdir filter

2019-09-25 Thread Xiaoyun wang
Add support for creating/destroying fdir filter. The filter rule includes LACP,ARP and ICMP packet type. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.h | 16 ++ drivers/net/hinic/hinic_pmd_flow.c | 423 +-- 2 files changed, 422 insertions(

[dpdk-dev] [PATCH v2 08/17] net/hinic: add fdir validate flow operations

2019-09-25 Thread Xiaoyun wang
This patch is to validate the filter rules, which includes ntuple filter, ethertype filter and fdir filter. The packets type that supported are BGP,VRRP,LACP,ARP and ICMP. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/Makefile |1 + drivers/net/hinic/hinic_pmd_ethdev.c | 42 +

[dpdk-dev] [PATCH v2 09/17] net/hinic: create and destroy ntuple filter

2019-09-25 Thread Xiaoyun wang
Add support for creating/destroying ntuple filter. The filter rule includes BGP and VRRP packet type. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.h | 75 drivers/net/hinic/hinic_pmd_flow.c | 684 +++ 2 files changed, 759 insertions(+

[dpdk-dev] [PATCH v2 07/17] net/hinic: add fdir config interface

2019-09-25 Thread Xiaoyun wang
This patch adds fdir config operation, including set fdir filter, normal filter, set and clear fdir tcam. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cmd.h| 2 + drivers/net/hinic/base/hinic_pmd_niccfg.c | 205 ++ drivers/net/hinic/base/hini

[dpdk-dev] [PATCH v2 06/17] net/hinic: add unicast and multicast MAC set

2019-09-25 Thread Xiaoyun wang
This patch adds unicast and multicast set interfaces. Application can add or remove unicast MAC address, also can set multicast MAC address, tha maximum multicast list size is 2048. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_niccfg.c | 55 +++ drivers/net/hinic/hinic_p

[dpdk-dev] [PATCH v2 04/17] net/hinic: add VLAN filter and offload

2019-09-25 Thread Xiaoyun wang
This patch adds support for VLAN filter and VLAN offload. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cmd.h| 1 + drivers/net/hinic/base/hinic_pmd_niccfg.c | 136 + drivers/net/hinic/base/hinic_pmd_niccfg.h | 29 + drivers/net/hinic/hinic_pmd_e

[dpdk-dev] [PATCH v2 05/17] net/hinic: add allmulticast mode and MTU set

2019-09-25 Thread Xiaoyun wang
When enable allmulticast mode, all multicast packets can be received. This patch also adds support for mtu set, the range of MTU is from 256 to 9600. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c | 108 ++- drivers/net/hinic/hinic_pmd_ethdev

[dpdk-dev] [PATCH v2 03/17] net/hinic: add VF PMD operation interfaces

2019-09-25 Thread Xiaoyun wang
This patch adds VF PMD operation interfaces to support SRIOV. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_niccfg.c | 35 drivers/net/hinic/base/hinic_pmd_niccfg.h | 14 ++ drivers/net/hinic/hinic_pmd_ethdev.c | 255 -- 3 files changed,

[dpdk-dev] [PATCH v2 01/17] net/hinic/base: add mbox command channel for SRIOV

2019-09-25 Thread Xiaoyun wang
Add mbox command channel for SRIOV, which is used to communicate between VF and VF, VF and PF. This patch introduces data structures, initialization, interfaces and commands of mbox channel. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/Makefile | 1 + drivers/net/hinic/base/

[dpdk-dev] [PATCH v2 02/17] net/hinic/base: add HW interfaces for SRIOV

2019-09-25 Thread Xiaoyun wang
This patch introduces some HW interfaces required for SRIOV function, including: init hwdev, set port state, get default cos, vf dma attribute table, vf txrx flush and so on. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_compat.h | 32 drivers/net/hinic/base/hinic_pmd_a

[dpdk-dev] [PATCH v2 00/17] Add advanced features for Huawei hinic pmd

2019-09-25 Thread Xiaoyun wang
This patch set adds advanced features for Huawei hinic pmd, such as VLAN filter and VLAN offload, SR-IOV, FW version get, set link down and up, Flow director for LACP, VRRP, BGP and so on. Xiaoyun wang (17): net/hinic/base: add mbox command channel for SRIOV net/hinic/base: add HW interfaces f

[dpdk-dev] [PATCH v3 0/2] extend RSS offload types

2019-09-25 Thread Simei Su
[PATCH v3 1/2] ethdev: add several bits for extending rss offload types. [PATCH v3 2/2] app/testpmd: add cmdline support for extending rss types. v3: * update code comments and code style. v2: * Revise annotation. Simei Su (2): ethdev: extend RSS offload types app/testpmd: add RSS offload ty

[dpdk-dev] [PATCH v3 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Simei Su
This patch cover two aspects: (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve different purposes. (2)reserve several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent rss types. for example: ETH

[dpdk-dev] [PATCH v3 2/2] app/testpmd: add RSS offload types extending support

2019-09-25 Thread Simei Su
This patch adds cmdline support for extended rss types configuration. Signed-off-by: Simei Su --- app/test-pmd/config.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 1a5a5c1..b95bd43 100644 --- a/app/test-pmd/config.c +++ b/app/test

Re: [dpdk-dev] [RFC] Proposals and notes from ABI stability panel @ DPDK Userspace

2019-09-25 Thread Kevin Traynor
On 23/09/2019 18:51, Ray Kinsella wrote: > Folks, > > As you may be aware, there was a panel on ABI Stability @ DPDK > Userspace. There where a number of proposed amendments to the ABI > stability proposal made, as well as a number of points and comments, you > will find all these below. The prop

Re: [dpdk-dev] [PATCH v4 1/4] doc: separate versioning.rst into version and policy

2019-09-25 Thread Ray Kinsella
Hi Neil, Thanks for the feedback, other comment below. On 25/09/2019 13:24, Neil Horman wrote: > On Wed, Sep 25, 2019 at 11:23:53AM +0100, Ray Kinsella wrote: >> Separate versioning.rst into abi versioning and abi policy guidance, in >> preparation for adding more detail to the abi policy. >> >>

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 8:24 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/25, Su, Simei wrote: > >> >+/* > >> >+ * We use the followi

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 8:23 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/25, Su, Simei wrote: > >Hi, xiaolong > > > >> -Original

Re: [dpdk-dev] [PATCH v3 2/4] doc: changes to abi policy introducing major abi versions

2019-09-25 Thread Kevin Traynor
On 24/09/2019 12:32, Ray Kinsella wrote: > > Thanks Kevin for working through all this. > Other comments are inline. > > On 30/08/2019 17:20, Kevin Traynor wrote: >> Hi Ray, >> >> On 15/08/2019 11:23, Ray Kinsella wrote: >>> This policy change introduces major ABI versions, these are >>> declared

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/25, Su, Simei wrote: >> >+/* >> >+ * We use the following macros to combine with above ETH_RSS_* for >> >+ * more specific input set selection. These bits are defined starting >> >+ * from the bottom of the 64 bits. >> >> s/bottom/high end/ > > Sorry, what does it mean, I didn't understand i

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/25, Su, Simei wrote: >Hi, xiaolong > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Wednesday, September 25, 2019 6:50 PM >> To: Su, Simei >> Cc: Zhang, Qi Z ; Wu, Jingjing ; >> dev@dpdk.org >> Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types >> >> On 09/23, Simei

Re: [dpdk-dev] [PATCH v4 1/4] doc: separate versioning.rst into version and policy

2019-09-25 Thread Neil Horman
On Wed, Sep 25, 2019 at 11:23:53AM +0100, Ray Kinsella wrote: > Separate versioning.rst into abi versioning and abi policy guidance, in > preparation for adding more detail to the abi policy. > > Signed-off-by: Ray Kinsella > --- > doc/guides/contributing/abi_policy.rst | 169 + > do

Re: [dpdk-dev] |WARNING| pw59738 [PATCH v2 2/2] mbuf: add bulk free function

2019-09-25 Thread Morten Brørup
Dear Thomas - listed as checkpatch maintainer, I think this warning is bogus, and is a bug checkpatch. The line in question was deliberately indented using tabs to the current indentation level, and using spaces for the readability alignment. This makes the code readable in editors with another

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
Hi, xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 6:28 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/23, Simei Su wrote: > >This patch cover two aspe

[dpdk-dev] [PATCH v2 0/2] mbuf: add bulk free function

2019-09-25 Thread Morten Brørup
Add function for freeing a bulk of mbufs. v2: * Function is not inline. * Optimized to free multible mbufs belonging to the same mempool in bulk. Inspired by ixgbe_tx_free_bufs(), but allowing NULL pointers in the array, just like rte_pktmbuf_free() can take a NULL pointer. * Use unsigned int inst

[dpdk-dev] [PATCH v2 2/2] mbuf: add bulk free function

2019-09-25 Thread Morten Brørup
Add function for freeing a bulk of mbufs. Signed-off-by: Morten Brørup --- lib/librte_mbuf/rte_mbuf.c | 35 +++ lib/librte_mbuf/rte_mbuf.h | 16 +--- 2 files changed, 40 insertions(+), 11 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/libr

[dpdk-dev] [PATCH v2 1/2] mbuf: add bulk free function

2019-09-25 Thread Morten Brørup
Add function for freeing a bulk of mbufs. Signed-off-by: Morten Brørup --- lib/librte_mbuf/rte_mbuf.h | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 98225ec80..f2e174da1 100644 --- a/lib/librte_mbuf/rte_mbuf.h

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
Hi, xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 6:50 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/23, Simei Su wrote: > >This patch cover two aspe

[dpdk-dev] [PATCH] net/mlx5: adjust inline setting for large Tx queue sizes

2019-09-25 Thread Viacheslav Ovsiienko
The hardware may have limitations on maximal amount of supported Tx descriptors building blocks (WQEBB). Application requires the Tx queue must accept the specified amount of packets. If inline data feature is engaged the packet may require more WQEBBs and overall amount of blocks may exceed the ha

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/23, Simei Su wrote: >This patch cover two aspects: > (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve > different purposes. > > (2)reserve several bits as input set selection from bottom > of the 64 bits. It is combined with exisiting ETH_RSS_* to > represent rss typ

[dpdk-dev] [PATCH v2] test/bpf: add new test cases

2019-09-25 Thread Harman Kalra
This patch implements following new test cases: - test_call4: test case to verify if stack corruption occurs across with multiple function calls. - test_jump2: test case with a default packet in memory, parse the packet and check if dest ip is part of a subnet. - test_call5: test case with string d

Re: [dpdk-dev] [DPDK] app/testpmd: fix unused variable compile error

2019-09-25 Thread Andrew Rybchenko
On 9/25/19 8:54 PM, taox@intel.com wrote: From: Zhu Tao This minor patch fixes unused variable ‘ret’ compile error When CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected. Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info") Signed-off-by: Zhu Tao Reviewed-by: Andre

  1   2   >