[dpdk-dev] [PATCH] net/ice: cleanup RSS/FDIR profile when device init

2019-09-27 Thread Ying Wang
The patch cleanup RSS/FDIR profile resources when device init to fix profile ID increase issue. Fixes: d7d150b93070 ("net/ice: enable RSS when device init") Cc: sta...@dpdk.org Signed-off-by: Ying Wang --- --- This patch depends on the following patches in patchwork: (1) http://patchwork.dpdk.or

[dpdk-dev] [PATCH v5 1/3] ethdev: decouple flow types and RSS offload types

2019-09-27 Thread Simei Su
This patch decouples RTE_ETH_FLOW_* and ETH_RSS_*. Both serves different purposes. The former defines flow types. The later defines RSS offload types. Signed-off-by: Simei Su --- lib/librte_ethdev/rte_ethdev.h | 49 -- 1 file changed, 23 insertions(+), 26

[dpdk-dev] [PATCH v5 2/3] ethdev: extend RSS offload types

2019-09-27 Thread Simei Su
This patch reserves several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent rss types. for example: ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY: hash on src ip address only ETH_RSS_IPV4_UDP | ETH_RSS_L4_DST_ONLY: hash on src/dst IP and

[dpdk-dev] [PATCH v5 3/3] app/testpmd: add RSS offload types extending support

2019-09-27 Thread Simei Su
This patch adds cmdline support for extended rss types configuration. Signed-off-by: Simei Su --- app/test-pmd/config.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 1a5a5c1..a59a69e 100644 --- a/app/test-pmd/config.c +++ b/app/test-p

[dpdk-dev] [PATCH v5 0/3] extend RSS offload types

2019-09-27 Thread Simei Su
[PATCH v5 1/3] ethdev: decouple flow types and RSS offload types. [PATCH v5 2/3] ethdev: add several bits for extending rss offload types. [PATCH v5 3/3] app/testpmd: add cmdline support for extending rss types. v5: * Update code comments. v4: * Divide one patch into two patches. * Delete ETH_RSS

Re: [dpdk-dev] [PATCH v4 2/3] ethdev: extend RSS offload types

2019-09-27 Thread Su, Simei
Hi, Zhangqi > -Original Message- > From: Zhang, Qi Z > Sent: Saturday, September 28, 2019 9:04 AM > To: Su, Simei ; Wu, Jingjing ; Ye, > Xiaolong > Cc: dev@dpdk.org > Subject: RE: [PATCH v4 2/3] ethdev: extend RSS offload types > > > > > -Original Message- > > From: Su, Simei >

Re: [dpdk-dev] [PATCH v4 2/3] ethdev: extend RSS offload types

2019-09-27 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Friday, September 27, 2019 4:54 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Ye, Xiaolong > Cc: dev@dpdk.org; Su, Simei > Subject: [PATCH v4 2/3] ethdev: extend RSS offload types > > This patch reserves several bits as input set selection from

[dpdk-dev] [PATCH 3/5] mbuf: deinline rte_pktmbuf_clone

2019-09-27 Thread Stephen Hemminger
Cloning mbufs requires allocations and iteration and therefore should not be an inline. Signed-off-by: Stephen Hemminger --- lib/librte_mbuf/rte_mbuf.c | 39 lib/librte_mbuf/rte_mbuf.h | 38 ++- lib/librte_mbuf/rte_mbuf_ver

[dpdk-dev] [PATCH 5/5] mbuf: add pktmbuf copy test

2019-09-27 Thread Stephen Hemminger
New test for rte_pktmbuf_copy based of the clone tests. Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 126 +++ 1 file changed, 126 insertions(+) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index aafad0cf6206..49c3a5f7893c 100644

[dpdk-dev] [PATCH 4/5] mbuf: add a pktmbuf copy routine

2019-09-27 Thread Stephen Hemminger
This is a commonly used operation that surprisingly the DPDK has not supported. The new rte_pktmbuf_copy does a deep copy of packet. This is a complete copy including meta-data. It handles the case where the source mbuf comes from a pool with larger data area than the destination pool. The routine

[dpdk-dev] [PATCH 2/5] mbuf: delinline rte_pktmbuf_linearize

2019-09-27 Thread Stephen Hemminger
This function is too big to be put inline. The places it is used are only in special exception paths where a highly fragmented mbuf arrives at a device that can't handle it. Signed-off-by: Stephen Hemminger --- lib/librte_mbuf/rte_mbuf.c | 40 lib/librte_mb

[dpdk-dev] [PATCH 1/5] mbuf: don't generate invalid mbuf in clone test

2019-09-27 Thread Stephen Hemminger
The test for cloning changed mbuf would generate an mbuf whose length and segments were invalid. This would cause a crash if test was run with mbuf debugging enabled. Fixes: f1022aba76a5 ("app/test: rename mbuf variable") Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 3 +++ 1 file

[dpdk-dev] [PATCH 0/5] mbuf related patches

2019-09-27 Thread Stephen Hemminger
This patch set is all about improving the mbuf related cloning and copying. They are motivated by seeing issues with mbuf copying in rte_pdump and realized this a wider and more general problem. The pdump copy could not handle different size pools and did not handle meta data, etc. They cause no f

Re: [dpdk-dev] [PATCH] eal/ppc_64: add SPDX license tag

2019-09-27 Thread David Christensen
Cc: Gowrishankar Muthukrishnan Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/arch/ppc_64/rte_cycles.c | 4 1 file changed, 4 insertions(+) Reviewed-by: David Christensen

[dpdk-dev] [PATCH v2 1/2] eal: split compat header file

2019-09-27 Thread Bruce Richardson
The compat.h header file provided macros for two purposes: 1. it provided the macros for marking functions as rte_experimental 2. it provided the macros for doing function versioning Although these were in the same file, #1 is something that is for use by public header files, which #2 is for inter

[dpdk-dev] [PATCH v2 2/2] build: support building ABI versioned files twice

2019-09-27 Thread Bruce Richardson
Any file with ABI versioned functions needs different macros for shared and static builds, so we need to accomodate that. Rather than building everything twice, we just flag to the build system which libraries need that handling, by setting use_function_versioning in the meson.build files. To ensu

[dpdk-dev] [PATCH v2 0/2] Improve function versioning meson support

2019-09-27 Thread Bruce Richardson
Adding support for LTO has exposed some issues with how the functions versioning was supported by meson, which was always set to build both shared and static libraries. For plain C code, so long as the -fPIC compiler flag was passed, the output is identical whether or not the code is to be include

Re: [dpdk-dev] [PATCH 1/2] eal: split compat header file

2019-09-27 Thread Bruce Richardson
On Fri, Sep 27, 2019 at 08:49:31PM +0100, Bruce Richardson wrote: > The compat.h header file provided macros for two purposes: > 1. it provided the macros for marking functions as rte_experimental > 2. it provided the macros for doing function versioning > > Although these were in the same file, #

[dpdk-dev] [PATCH v2 12/12] net/cxgbe: add rte_flow support for setting VLAN PCP

2019-09-27 Thread Rahul Lakkireddy
Add support for setting VLAN PCP field via rte_flow API. Hardware overwrites the entire 16-bit VLAN TCI field. So, both VLAN VID and PCP actions must be specified. Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/cxgbe_flow.c | 27 +++ 1 file chang

[dpdk-dev] [PATCH v2 10/12] net/cxgbe: fetch max Tx coalesce limit from firmware

2019-09-27 Thread Rahul Lakkireddy
Query firmware for max number of packets that can be coalesced by Tx. Signed-off-by: Rahul Lakkireddy --- v2: - No changes. doc/guides/nics/cxgbe.rst | 18 ++-- drivers/net/cxgbe/base/common.h | 1 + drivers/net/cxgbe/base/t4fw_interface.h | 3 +- drivers/net/cxg

[dpdk-dev] [PATCH v2 09/12] net/cxgbe: add devarg to control Tx coalescing

2019-09-27 Thread Rahul Lakkireddy
Remove compile time option to control Tx coalescing Latency vs Throughput behavior. Add tx_mode_latency devarg instead, to dynamically control Tx coalescing behavior. Signed-off-by: Rahul Lakkireddy --- v2: - No changes. config/common_base | 1 - doc/guides/nics/cxgbe.rst

[dpdk-dev] [PATCH v2 11/12] net/cxgbe: add rte_flow support for matching VLAN

2019-09-27 Thread Rahul Lakkireddy
Add support for matching VLAN fields via rte_flow API. When matching VLAN pattern, the ethertype field in hardware filter specification must contain VLAN header's ethertype, and not Ethernet header's ethertype. The hardware automatically searches for ethertype 0x8100 in Ethernet header, when parsi

[dpdk-dev] [PATCH v2 08/12] net/cxgbe: separate VF only devargs

2019-09-27 Thread Rahul Lakkireddy
Rework devargs parsing logic to separate VF only args. Signed-off-by: Rahul Lakkireddy --- v2: - In cxgbe.rst doc, use ^ (instead of -) to represent common and vf-only devargs as subsection of Runtime Options. doc/guides/nics/cxgbe.rst | 6 +++ drivers/net/cxgbe/base/adapter.h |

[dpdk-dev] [PATCH v2 07/12] net/cxgbe: use dynamic logging for debug prints

2019-09-27 Thread Rahul Lakkireddy
Remove compile time flags and use dynamic logging for debug prints. Also remove rarely used debug logs in register access and datapath. Signed-off-by: Rahul Lakkireddy --- v2: - Remove rarely used CXGBE_DEBUG_REG, CXGBE_DEBUG_TX, and CXGBE_DEBUG_RX debug logs. config/common_base

[dpdk-dev] [PATCH v2 03/12] net/cxgbe: fix slot allocation for IPv6 flows

2019-09-27 Thread Rahul Lakkireddy
IPv6 flows occupy only 2 slots on Chelsio T6 NICs. Fix the slot calculation logic to return correct number of slots. Cc: sta...@dpdk.org Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows") Fixes: 9eb2c9a48072 ("net/cxgbe: implement flow create operation") Fixes: 3f2c1e209cfc ("net/cxgbe: a

[dpdk-dev] [PATCH v2 02/12] net/cxgbe: fix NULL access when allocating CLIP entry

2019-09-27 Thread Rahul Lakkireddy
Pass correct arguments to CLIP allocation code to avoid NULL pointer dereference. Cc: sta...@dpdk.org Fixes: 3f2c1e209cfc ("net/cxgbe: add Compressed Local IP region") Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/cxgbe_filter.c | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH v2 06/12] net/cxgbe: avoid polling link status before device start

2019-09-27 Thread Rahul Lakkireddy
Link updates come in firmware event queue, which is only created when device starts. So, don't poll for link status if firmware event queue is not yet created. This fixes NULL dereference when accessing non existent firmware event queue. Cc: sta...@dpdk.org Fixes: 265af08e75ba ("net/cxgbe: add li

[dpdk-dev] [PATCH v2 05/12] net/cxgbe: fix prefetch for non-coalesced Tx packets

2019-09-27 Thread Rahul Lakkireddy
Move prefetch code out of Tx coalesce path to allow prefetching for non-coalesced Tx packets, as well. Cc: sta...@dpdk.org Fixes: bf89cbedd2d9 ("cxgbe: optimize forwarding performance for 40G") Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/cxgbe_ethdev.c | 9 +++--

[dpdk-dev] [PATCH v2 04/12] net/cxgbe: fix parsing VLAN ID rewrite action

2019-09-27 Thread Rahul Lakkireddy
Set VLAN action mode to VLAN_REWRITE only if VLAN_INSERT has not been set yet. Otherwise, the resulting VLAN packets will have their VLAN header rewritten, instead of pushing a new outer VLAN header. Also fix the VLAN ID extraction logic and endianness issues. Cc: sta...@dpdk.org Fixes: 1decc62b1

[dpdk-dev] [PATCH v2 01/12] net/cxgbe: add cxgbe_ prefix to global functions

2019-09-27 Thread Rahul Lakkireddy
To avoid name collisions, add cxgbe_ prefix to some global functions. Also, make some local functions static in cxgbe_filter.c. Cc: sta...@dpdk.org Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows") Fixes: 9eb2c9a48072 ("net/cxgbe: implement flow create operation") Fixes: 3a381a4116ed ("n

[dpdk-dev] [PATCH v2 00/12] net/cxgbe: bug fixes and updates for CXGBE/CXGBEVF PMD

2019-09-27 Thread Rahul Lakkireddy
This series of patches contain bug fixes and feature updates for CXGBE and CXGBEVF PMD. Patches 1 to 6 contain bug fixes. Patches 7 to 12 contain updates and new features for CXGBE/CXGBEVF PMD. Patch 1 adds cxgbe_ prefix to some global functions to avoid name collision. Patch 2 fixes NULL derefer

Re: [dpdk-dev] [PATCH 07/12] net/cxgbe: use dynamic logging for debug prints

2019-09-27 Thread Rahul Lakkireddy
On Friday, September 09/27/19, 2019 at 20:07:20 +0530, Ferruh Yigit wrote: > On 9/6/2019 10:52 PM, Rahul Lakkireddy wrote: > > Remove compile time flags and use dynamic logging for debug prints. > > > > Signed-off-by: Rahul Lakkireddy > > --- > > config/common_base | 5 --- > > do

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-27 Thread Bruce Richardson
On Thu, Sep 26, 2019 at 05:32:12PM +0200, Andrzej Ostruszka wrote: > On 9/24/19 2:59 PM, Neil Horman wrote: > > On Tue, Sep 24, 2019 at 12:25:35PM +0200, Bruce Richardson wrote: > >> On Tue, Sep 24, 2019 at 08:46:25AM +0200, Andrzej Ostruszka wrote: > >>> On 9/23/19 6:13 PM, Bruce Richardson wrote:

[dpdk-dev] [PATCH 0/2] Improve function versioning meson support

2019-09-27 Thread Bruce Richardson
Adding support for LTO has exposed some issues with how the functions versioning was supported by meson, which was always set to build both shared and static libraries. For plain C code, so long as the -fPIC compiler flag was passed, the output is identical whether or not the code is to be include

[dpdk-dev] [PATCH 2/2] build: support building ABI versioned files twice

2019-09-27 Thread Bruce Richardson
Any file with ABI versioned functions needs different macros for shared and static builds, so we need to accomodate that. Rather than building everything twice, we just flag to the build system which libraries need that handling, by setting use_function_versioning in the meson.build files. To ensu

[dpdk-dev] [PATCH 1/2] eal: split compat header file

2019-09-27 Thread Bruce Richardson
The compat.h header file provided macros for two purposes: 1. it provided the macros for marking functions as rte_experimental 2. it provided the macros for doing function versioning Although these were in the same file, #1 is something that is for use by public header files, which #2 is for inter

Re: [dpdk-dev] [PATCH] maintainers: update for ena

2019-09-27 Thread Ferruh Yigit
On 9/26/2019 11:45 AM, Michal Krawczyk wrote: > Add Igor Chauskin from the Amazon as another maintainer of the driver. > Igor is another person from the Amazon team that is responsible for the > ENA DPDK driver. > > Signed-off-by: Michal Krawczyk Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2] vhost: add experimental flag

2019-09-27 Thread Ferruh Yigit
On 9/24/2019 10:23 AM, Jim Harris wrote: > This function is listed under EXPERIMENTAL in the > rte_vhost_version.map, so it needs to be marked > with __rte_experimental in the header file as well. > > Found by check-experimental-syms.sh when trying to compile > DPDK with -finstrument-functions. T

[dpdk-dev] [PATCH v3 1/3] vhost: translate incoming log address to gpa

2019-09-27 Thread Adrian Moreno
When IOMMU is enabled the incoming log address is in IOVA space. In that case, look in IOTLB table and translate the resulting HVA to GPA. If IOMMU is not enabled, the incoming log address is already a GPA so no transformation is needed. Fixes: 69c90e98f483 ("vhost: enable IOMMU support") Cc: max

[dpdk-dev] [PATCH v3 0/3] vhost: add support for IOVA_VA mode

2019-09-27 Thread Adrian Moreno
Currently, IOVAs are assumed to be GPA when the dirty page logging is performed. Add support for guest IOVA_VA mode by translating addresses to GPA before doing the dirty page logging. Also, the guest_pages tracking mechanism used for zero_copy will not work either if IOVA_VA is enabled. In fact,

[dpdk-dev] [PATCH v3 3/3] vhost: prevent zero copy mode if iommu is on

2019-09-27 Thread Adrian Moreno
The simltaneous use of dequeue_zero_copy and IOMMU is problematic. Not only because IOVA_VA mode is not supported but also because the potential invalidation of guest pages while the buffers are in use, is not handled. Prevent these two features to be enabled simultaneosly. Fixes: 69c90e98f483 ("

[dpdk-dev] [PATCH v3 2/3] vhost: convert buffer addresses to GPA for logging

2019-09-27 Thread Adrian Moreno
Note that the API facing rte_vhost_log_write is not modified. So, make explicit that it expects the address in GPA space. Fixes: 69c90e98f483 ("vhost: enable IOMMU support") Cc: maxime.coque...@redhat.com Cc: sta...@dpdk.org Signed-off-by: Adrian Moreno --- lib/librte_vhost/rte_vhost.h | 2 +-

Re: [dpdk-dev] [PATCH v3 18/22] net/hns3: add dump register ops for hns3 PMD driver

2019-09-27 Thread Ferruh Yigit
On 9/26/2019 3:02 PM, Wei Hu (Xavier) wrote: > This patch adds get_reg related function codes for hns3 PMD driver. > > Signed-off-by: Wei Hu (Xavier) > Signed-off-by: Chunsong Feng > Signed-off-by: Min Hu (Connor) > Signed-off-by: Hao Chen > Signed-off-by: Huisong Li <...> > +static int > +

Re: [dpdk-dev] [PATCH v3 00/22] add hns3 ethernet PMD driver

2019-09-27 Thread Ferruh Yigit
On 9/26/2019 3:01 PM, Wei Hu (Xavier) wrote: > The Hisilicon Network Subsystem is a long term evolution IP which is > supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920. > > This series add DPDK rte_ethdev poll mode driver for Hisilicon > Network Subsystem 3(hns3) network engine. > > v

[dpdk-dev] [PATCH v2 3/3] vhost: prevent zero copy mode if iommu is on

2019-09-27 Thread Adrian Moreno
The simltaneous use of dequeue_zero_copy and IOMMU is problematic. Not only because IOVA_VA mode is not supported but also because the potential invalidation of guest pages while the buffers are in use is not handled. Prevent these two features to be enabled simultaneosly. Fixes: 69c90e98f483 ("v

[dpdk-dev] [PATCH v2 1/3] vhost: translate incoming log address to gpa

2019-09-27 Thread Adrian Moreno
When IOMMU is enabled the incoming log address is in IOVA space. In that case, look in IOTLB table and translate the resulting HVA to GPA. If IOMMU is not enabled, the incoming log address is already a GPA so no transformation is needed. Fixes: 69c90e98f483 ("vhost: enable IOMMU support") Cc: max

[dpdk-dev] [PATCH v2 2/3] vhost: convert buffer addresses to GPA for logging

2019-09-27 Thread Adrian Moreno
Note that the API facing rte_vhost_log_write is not modified. So, make explicit that it expects the address in GPA space. Fixes: 69c90e98f483 ("vhost: enable IOMMU support") Cc: maxime.coque...@redhat.com Cc: sta...@dpdk.org Signed-off-by: Adrian Moreno --- lib/librte_vhost/rte_vhost.h | 2 +-

[dpdk-dev] [PATCH v2 0/3] vhost: add support for IOVA_VA mode

2019-09-27 Thread Adrian Moreno
Currently, IOVAs are assumed to be GPA when the dirty page logging is performed. Add support for guest IOVA_VA mode by translatingi adresses to GPA before doing the dirty page logging. Also, the page tables used for zero_copy mode also assume will not work either if IOVA VA is enabled. In fact, e

Re: [dpdk-dev] [PATCH 09/11] examples/l3fwd: add event em main loop

2019-09-27 Thread Stephen Hemminger
On Thu, 26 Sep 2019 15:35:56 +0530 wrote: > +static __rte_always_inline void > +em_event_loop_single(struct l3fwd_eventdev_resources *evdev_rsrc, > + const uint8_t flags) Do not use always_inline except for cases where compiler will get it wrong. This function should not have inline

Re: [dpdk-dev] [PATCH 09/11] examples/l3fwd: add event em main loop

2019-09-27 Thread Stephen Hemminger
On Thu, 26 Sep 2019 15:35:56 +0530 wrote: > +#define L3FWD_EM_EVENT_MODE\ > +EM_FP(tx_d, 0, 0, L3FWD_EVENT_TX_DIRECT | L3FWD_EVENT_SINGLE) \ > +EM_FP(tx_d_burst,0, 1, L3FWD_EVENT_TX_DIRECT | L3FWD_EVENT_BURST) \ > +EM_FP(tx_q, 1,

[dpdk-dev] [PATCH v6 4/4] doc: add maintainer for abi policy

2019-09-27 Thread Ray Kinsella
Add an entry to the maintainer file for the abi policy. Signed-off-by: Ray Kinsella --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3d9aad..d231f03 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -80,6 +80,10 @@ M: Marko Kovacevic F: READM

[dpdk-dev] [PATCH v6 0/4] doc: changes to abi policy introducing major abi versions

2019-09-27 Thread Ray Kinsella
TL;DR abbreviation: A major ABI version that all DPDK releases during a one year period support. ABI versioning is managed at a project-level, in place of library-level management. ABI changes to add new features are permitted, as long as ABI compatibility with the major ABI version is maintained.

[dpdk-dev] [PATCH v6 3/4] doc: updates to versioning guide for abi versions

2019-09-27 Thread Ray Kinsella
Updates to the ABI versioning guide, to account for the changes to the DPDK ABI/API policy. Fixes for references to abi versioning and policy guides. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_versioning.rst | 248 +++-- doc/guides/contributing/patches.rs

[dpdk-dev] [PATCH v6 1/4] doc: separate versioning.rst into version and policy

2019-09-27 Thread Ray Kinsella
Separate versioning.rst into abi versioning and abi policy guidance, in preparation for adding more detail to the abi policy. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_policy.rst | 169 + doc/guides/contributing/abi_versioning.rst | 427 + doc/gu

Re: [dpdk-dev] [PATCH v4 1/4] doc: separate versioning.rst into version and policy

2019-09-27 Thread Ray Kinsella
On 27/09/2019 16:43, Aaron Conole wrote: > Ray Kinsella writes: > >> Separate versioning.rst into abi versioning and abi policy guidance, in >> preparation for adding more detail to the abi policy. >> >> Signed-off-by: Ray Kinsella >> --- >> doc/guides/contributing/abi_policy.rst | 169 +

[dpdk-dev] [PATCH v5 2/4] doc: changes to abi policy introducing major abi versions

2019-09-27 Thread Ray Kinsella
This policy change introduces major ABI versions, these are declared every year, typically aligned with the LTS release and are supported by subsequent releases in the following year. This change is intended to improve ABI stabilty for those projects consuming DPDK. Signed-off-by: Ray Kinsella --

[dpdk-dev] [PATCH v5 4/4] doc: add maintainer for abi policy

2019-09-27 Thread Ray Kinsella
Add an entry to the maintainer file for the abi policy. Signed-off-by: Ray Kinsella --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3d9aad..d231f03 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -80,6 +80,10 @@ M: Marko Kovacevic F: READM

[dpdk-dev] [PATCH v5 3/4] doc: updates to versioning guide for abi versions

2019-09-27 Thread Ray Kinsella
Updates to the ABI versioning guide, to account for the changes to the DPDK ABI/API policy. Fixes for references to abi versioning and policy guides. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_versioning.rst | 248 +++-- doc/guides/contributing/patches.rs

[dpdk-dev] [PATCH v5 1/4] doc: separate versioning.rst into version and policy

2019-09-27 Thread Ray Kinsella
Separate versioning.rst into abi versioning and abi policy guidance, in preparation for adding more detail to the abi policy. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_policy.rst | 169 + doc/guides/contributing/abi_versioning.rst | 427 + doc/gu

[dpdk-dev] [PATCH v5 0/4] doc: changes to abi policy introducing major abi versions

2019-09-27 Thread Ray Kinsella
TL;DR abbreviation: A major ABI version that all DPDK releases during a one year period support. ABI versioning is managed at a project-level, in place of library-level management. ABI changes to add new features are permitted, as long as ABI compatibility with the major ABI version is maintained.

[dpdk-dev] [PATCH v5 4/4] examples/ipsec-secgw: add offload fallback tests

2019-09-27 Thread Marcin Smoczynski
Add tests for offload fallback feature; add inbound config modificator SGW_CFG_XPRM_IN (offload fallback setting can be set only for inbound SAs). Tests are using cryptodev for outbound SA. To test fragmentation with QAT set: MULTI_SEG_TEST="--reassemble=4096 --cryptodev_mask=0x" Acked-by: Ko

[dpdk-dev] [PATCH v5 2/4] examples/ipsec-secgw: add fallback session feature

2019-09-27 Thread Marcin Smoczynski
Inline processing is limited to a specified subset of traffic. It is often unable to handle more complicated situations, such as fragmented traffic. When using inline processing such traffic is dropped. Introduce fallback session for inline processing allowing processing packets that normally woul

[dpdk-dev] [PATCH v5 3/4] examples/ipsec-secgw: add frag TTL cmdline option

2019-09-27 Thread Marcin Smoczynski
Due to fragment loss on highly saturated links and long fragment lifetime, ipsec-secgw application quickly runs out of free reassembly buckets. As a result new fragments are being dropped. Introduce --frag-ttl option which allow user to lower default fragment lifitime which solves problem of satur

[dpdk-dev] [PATCH v5 1/4] examples/ipsec-secgw: ipsec_sa structure cleanup

2019-09-27 Thread Marcin Smoczynski
Cleanup ipsec_sa structure by removing every field that is already in the rte_ipsec_session structure: * cryptodev/security session union * action type * offload flags * security context References to abovementioned fields are changed to direct references to matching fields of rte_ipsec_session

[dpdk-dev] [PATCH v5 0/4] add fallback session

2019-09-27 Thread Marcin Smoczynski
Add fallback session feature allowing to process packets that inline processor is unable to handle (e.g. fragmented traffic). Processing takes place in a secondary session defined for SA in a configuration file. This feature is limited to ingress IPsec traffic only. IPsec anti-replay window and ES

[dpdk-dev] [PATCH v2 3/3] crypto/qat: handle Single Pass Crypto Requests on GEN3 QAT

2019-09-27 Thread Adam Dybkowski
This patch improves the performance of AES GCM by using the Single Pass Crypto Request functionality when running on GEN3 QAT. Falls back to classic chained mode on older hardware. Signed-off-by: Adam Dybkowski --- doc/guides/rel_notes/release_19_11.rst | 7 +++ drivers/crypto/qat/qat_sym.c

[dpdk-dev] [PATCH v2 2/3] common/qat: add new QAT GEN3 definitions

2019-09-27 Thread Adam Dybkowski
This patch adds few definitions specific to GEN3 QAT. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw_la.h | 19 +++ drivers/common/qat/qat_adf/icp_qat_hw.h| 19 +++ 2 files changed, 34 insertions(+), 4 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v2 1/3] test/crypto: add more AES GCM tests for QAT PMD

2019-09-27 Thread Adam Dybkowski
This patch adds 256-bit AES GCM tests for QAT PMD (which already existed for AESNI and OpenSSL) and also adds a number of negative unit tests for AES GCM for QAT PMD, in order to verify authenticated encryption and decryption with modified data. Signed-off-by: Adam Dybkowski --- app/test/test_cr

[dpdk-dev] [PATCH v2 0/3] QAT: handle Single Pass GCM

2019-09-27 Thread Adam Dybkowski
This patch improves the performance of AES GCM by using the Single Pass Crypto Request when running on GEN3 QAT. --- v2: * Fix the session preparation function and request building code. * Update release notes. Adam Dybkowski (3): test/crypto: add more AES GCM tests for QAT PMD common/qat: add

Re: [dpdk-dev] [PATCH v4 1/4] doc: separate versioning.rst into version and policy

2019-09-27 Thread Aaron Conole
Ray Kinsella writes: > Separate versioning.rst into abi versioning and abi policy guidance, in > preparation for adding more detail to the abi policy. > > Signed-off-by: Ray Kinsella > --- > doc/guides/contributing/abi_policy.rst | 169 + > doc/guides/contributing/abi_versioning.rst

Re: [dpdk-dev] [PATCH v4 1/4] doc: separate versioning.rst into version and policy

2019-09-27 Thread Ray Kinsella
On 25/09/2019 13:24, Neil Horman wrote: > On Wed, Sep 25, 2019 at 11:23:53AM +0100, Ray Kinsella wrote: > This seems..confusing. In patch 0: > = > * DPDK v20 is declared as the supported ABI version for one year, aligned with >t

Re: [dpdk-dev] [PATCH v5 6/6] doc/guides/: provide IOAT sample app guide

2019-09-27 Thread Baran, MarcinX
-Original Message- From: Bruce Richardson Sent: Friday, September 27, 2019 5:01 PM To: Baran, MarcinX Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 6/6] doc/guides/: provide IOAT sample app guide On Fri, Sep 27, 2019 at 03:51:48PM +0100, Baran, MarcinX wrote: > -Original Me

Re: [dpdk-dev] [PATCH v5 6/6] doc/guides/: provide IOAT sample app guide

2019-09-27 Thread Baran, MarcinX
-Original Message- From: Bruce Richardson Sent: Friday, September 27, 2019 3:23 PM To: Baran, MarcinX Cc: dev@dpdk.org; Mcnamara, John ; Kovacevic, Marko Subject: Re: [dpdk-dev] [PATCH v5 6/6] doc/guides/: provide IOAT sample app guide On Fri, Sep 20, 2019 at 09:37:14AM +0200, Marcin

Re: [dpdk-dev] [PATCH 03/20] security: add hfn override option in PDCP

2019-09-27 Thread Akhil Goyal
Hi Anoob, Thanks for review. > > > @@ -270,6 +270,8 @@ struct rte_security_pdcp_xform { > > > uint32_t hfn; > > > /** HFN Threshold for key renegotiation */ > > > uint32_t hfn_threshold; > > > + /** Enable per packet HFN override */ > > > + uint32_t hfn_ovrd; > > [Anoob] I think you should

Re: [dpdk-dev] [PATCH v5 6/6] doc/guides/: provide IOAT sample app guide

2019-09-27 Thread Bruce Richardson
On Fri, Sep 27, 2019 at 03:51:48PM +0100, Baran, MarcinX wrote: > -Original Message- > From: Bruce Richardson > Sent: Friday, September 27, 2019 1:02 PM > To: Baran, MarcinX > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 6/6] doc/guides/: provide IOAT sample app > guide > > On

Re: [dpdk-dev] [PATCH v2 00/13] introduces ppfe network PMD

2019-09-27 Thread Gagandeep Singh
Hi Ferruh, > > Gagandeep Singh (12): > > net/ppfe: introduce ppfe net poll mode driver > > doc: add guide for ppfe net PMD > > net/ppfe: support dynamic logging > > net/ppfe: add HW specific macros and operations > > net/ppfe: add MAC and host interface initialisation > > net/ppfe: add

Re: [dpdk-dev] [PATCH v5 6/6] doc/guides/: provide IOAT sample app guide

2019-09-27 Thread Baran, MarcinX
-Original Message- From: Bruce Richardson Sent: Friday, September 27, 2019 1:02 PM To: Baran, MarcinX Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 6/6] doc/guides/: provide IOAT sample app guide On Fri, Sep 20, 2019 at 09:37:14AM +0200, Marcin Baran wrote: > Added guide for IOAT

Re: [dpdk-dev] [PATCH v2 0/2] Add external mbufs option

2019-09-27 Thread Akhil Goyal
> > Adam Dybkowski (2): > > test/compress: add external buffer in mbuf API test > > app/compress-perf: add external mbufs option > > > > app/test-compress-perf/comp_perf_options.h| 2 + > > .../comp_perf_options_parse.c | 15 + > > .../comp_perf_test_benchmark.c

Re: [dpdk-dev] [PATCH v2] net/ena: change license clause to SPDX tags

2019-09-27 Thread Ferruh Yigit
On 9/27/2019 12:41 PM, Maciej Bielski wrote: > Signed-off-by: Maciej Bielski > Acked-by: Michal Krawczyk Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-09-27 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Tuesday, September 10, 2019 4:33 PM > To: Shahaf Shuler ; Thomas Monjalon > ; dev@dpdk.org > Cc: Pavan Nikhilesh Bhagavatula ; Hemant > Agrawal ; Opher Reviv ; > Alex Rosenbaum ; Dovrat Zifroni > ; Prasun Kapoor ; Nipun Gupta >

Re: [dpdk-dev] [PATCH v4 04/10] examples/l2fwd-event: add eth port setup for eventdev

2019-09-27 Thread Pavan Nikhilesh Bhagavatula
>> Subject: [dpdk-dev] [PATCH v4 04/10] examples/l2fwd-event: add eth >port >> setup for eventdev >> >> From: Sunil Kumar Kori >> >> Add ethernet port Rx/Tx queue setup for event device which are later >> used for setting up event eth Rx/Tx adapters. >> >> Signed-off-by: Sunil Kumar Kori >> --- >

Re: [dpdk-dev] [PATCH v4 05/10] examples/l2fwd-event: add eventdev queue and port setup

2019-09-27 Thread Pavan Nikhilesh Bhagavatula
>> Subject: [dpdk-dev] [PATCH v4 05/10] examples/l2fwd-event: add >eventdev >> queue and port setup >> >> From: Pavan Nikhilesh >> >> Add event device queue and port setup based on event eth Tx >adapter >> capabilities. >> >> Signed-off-by: Sunil Kumar Kori >> Signed-off-by: Pavan Nikhilesh >> -

Re: [dpdk-dev] [PATCH v2 2/3] mbuf: move mbuf definition into a separate file

2019-09-27 Thread Andrew Rybchenko
On 9/27/19 4:50 PM, Konstantin Ananyev wrote: Right now inclusion of rte_mbuf.h header can cause inclusion of some arch/os specific headers. That prevents it to be included directly by some non-DPDK (but related) entities: KNI, BPF programs, etc. To overcome that problem usually a separate defini

Re: [dpdk-dev] [PATCH v3 0/3] compress/qat: add stateful decompression

2019-09-27 Thread Akhil Goyal
> > This patchset adds the stateful decompression feature > > to the QAT PMD, together with the documentation updates > > and two new unit tests. > > --- > > v3: > > * Minor corrections in features list in the documentation. > > > > v2: > > * Typo correction in the error message. > > > > Adam Dybko

Re: [dpdk-dev] [PATCH 00/12] net/cxgbe: bug fixes and updates for CXGBE/CXGBEVF PMD

2019-09-27 Thread Ferruh Yigit
On 9/6/2019 10:52 PM, Rahul Lakkireddy wrote: > This series of patches contain bug fixes and feature updates for > CXGBE and CXGBEVF PMD. Patches 1 to 6 contain bug fixes. Patches > 7 to 12 contain updates and new features for CXGBE/CXGBEVF PMD. > > Patch 1 adds cxgbe_ prefix to some global functi

Re: [dpdk-dev] [PATCH 07/12] net/cxgbe: use dynamic logging for debug prints

2019-09-27 Thread Ferruh Yigit
On 9/6/2019 10:52 PM, Rahul Lakkireddy wrote: > Remove compile time flags and use dynamic logging for debug prints. > > Signed-off-by: Rahul Lakkireddy > --- > config/common_base | 5 --- > doc/guides/nics/cxgbe.rst| 20 --- > drivers/net/cxgbe/cxgbe_compat.h | 58

Re: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add eventdev main loop

2019-09-27 Thread Pavan Nikhilesh Bhagavatula
>> >> From: Pavan Nikhilesh >> >> Add event dev main loop based on enabled l2fwd options and >eventdev >> capabilities. >> >> Signed-off-by: Pavan Nikhilesh >> --- > > > >> +if (flags & L2FWD_EVENT_TX_DIRECT) { >> +rte_event_eth_tx_adapter_txq_set(mbuf, 0); >> +

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-09-27 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Wang Xiang > > Hi Jerin, > > Thanks for your response. More comments below and inline. > > 1) I think the size of some varaibles (e.g. nb_matches, scan_size, matching > offset, etc) should be increased based on what Hyperscan supports. > > a) struct rte

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix over MTU packet crash

2019-09-27 Thread Akhil Goyal
> > > > When sending an encrypted packet which size after encapsulation exceeds > > MTU, ipsec-secgw application tries to fragment it. If --reassemble > > option has not been set it results with a segmantation fault, because > > fragmentation buckets have not been initialized. > > > > Fix crashing

Re: [dpdk-dev] [PATCH] doc: fix aesni-gcm limitations

2019-09-27 Thread Akhil Goyal
Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v4 3/8] net/ice: add FDIR create and destroy

2019-09-27 Thread Ferruh Yigit
On 9/27/2019 6:04 PM, Yahui Cao wrote: > Add ice_create_fdir_filter to create a rule. If a flow is matched by > flow director filter, filter rule will be set to HW. For now common > pattern and queue/passthru/drop/mark actions are supported. > > Signed-off-by: Yahui Cao Off the topic. This is t

[dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec lib

2019-09-27 Thread Konstantin Ananyev
List of unsupported features doesn't reflect latest changes. Fixes: cd5b860c1851 ("ipsec: support header construction") Fixes: 2c1887fad075 ("ipsec: fix transport mode for IPv6 with extensions") Signed-off-by: Konstantin Ananyev --- doc/guides/prog_guide/ipsec_lib.rst | 3 --- 1 file changed, 3

Re: [dpdk-dev] [PATCH v3 0/3] support IPv6 tunnel for lookaside crypto

2019-09-27 Thread Akhil Goyal
> > changes in v3: > fix ipheader initialization scope > > changes in v2: > used RTE_IPV6_HDR_* macros instead of localized driver specific macros. > > Akhil Goyal (3): > crypto/dpaa_sec: support IPv6 tunnel for protocol offload > crypto/dpaa2_sec: support IPv6 tunnel for protocol offload

Re: [dpdk-dev] [PATCH v5 6/6] doc/guides/: provide IOAT sample app guide

2019-09-27 Thread Baran, MarcinX
-Original Message- From: Bruce Richardson Sent: Friday, September 27, 2019 12:36 PM To: Baran, MarcinX Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 6/6] doc/guides/: provide IOAT sample app guide On Fri, Sep 20, 2019 at 09:37:14AM +0200, Marcin Baran wrote: > Added guide for I

Re: [dpdk-dev] [PATCH] app/test-compress-perf: fix out-of-bounds read

2019-09-27 Thread Akhil Goyal
> One issue caught by Coverity 344984 > *overrun-local: Overrunning array cperf_test_type_strs of 2 8-byte elements > > The array cperf_test_type_strs defined in app/test-compress-perf conflicts > with the same name being defined in app/test-crypto-perf. Due to which > coverity reports error. >

Re: [dpdk-dev] [PATCH 2/3] net/af_xdp: support pinning of IRQs

2019-09-27 Thread Ye Xiaolong
On 09/27, Loftus, Ciara wrote: >[snip] > >> >+ >> >+static void >> >+configure_irqs(struct pmd_internals *internals, uint16_t rx_queue_id) >> >+{ >> >+ int coreid = internals->queue_irqs[rx_queue_id]; >> >+ char driver[NAME_MAX]; >> >+ uint16_t netdev_qid = rx_queue_id + internals->start_queu

Re: [dpdk-dev] [PATCH v5 5/6] examples/ioat: add stats printing for each port

2019-09-27 Thread Baran, MarcinX
-Original Message- From: Bruce Richardson Sent: Friday, September 27, 2019 12:13 PM To: Baran, MarcinX Cc: dev@dpdk.org; Modrak, PawelX Subject: Re: [dpdk-dev] [PATCH v5 5/6] examples/ioat: add stats printing for each port On Fri, Sep 20, 2019 at 09:37:13AM +0200, Marcin Baran wrot

Re: [dpdk-dev] [PATCH v5 4/6] examples/ioat: add two threads configuration

2019-09-27 Thread Baran, MarcinX
-Original Message- From: Bruce Richardson Sent: Friday, September 27, 2019 12:09 PM To: Baran, MarcinX Cc: dev@dpdk.org; Modrak, PawelX Subject: Re: [dpdk-dev] [PATCH v5 4/6] examples/ioat: add two threads configuration On Fri, Sep 20, 2019 at 09:37:12AM +0200, Marcin Baran wrote: > F

Re: [dpdk-dev] [PATCH v5 3/6] examples/ioat: add rawdev copy mode support

2019-09-27 Thread Baran, MarcinX
-Original Message- From: Bruce Richardson Sent: Friday, September 27, 2019 12:06 PM To: Baran, MarcinX Cc: dev@dpdk.org; Modrak, PawelX Subject: Re: [dpdk-dev] [PATCH v5 3/6] examples/ioat: add rawdev copy mode support On Fri, Sep 20, 2019 at 09:37:11AM +0200, Marcin Baran wrote: > Ad

[dpdk-dev] Minutes of Technical Board Meeting, 2019-09-25

2019-09-27 Thread Bruce Richardson
Members Attending - Bruce (chair) Ferruh Hemant Jerin Konstantin Maxime Stephen Thomas NOTE: The technical board meetings every second Wednesday on IRC channel #dpdk-board, at 3pm UTC. Meetings are public and DPDK community members are welcome to attend. NOTE: Next meeting wil

  1   2   3   >