Re: [dpdk-dev] [PATCH v3 0/3] net/bnx2x: update to latest FW

2019-10-02 Thread Rasesh Mody
>From: Jerin Jacob >Sent: Wednesday, October 02, 2019 10:57 PM > >On Thu, Oct 3, 2019 at 12:45 AM Rasesh Mody wrote: >> >> Hi, >> >> Currently, BNX2X PMD uses a very old firmware 7.2.51. >> This patch series updated the base driver to use to latest firmware >> 7.13.11. The latest firmware compris

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-02 Thread Hemant Agrawal
Hi Nikhil, > -Original Message- > From: Rao, Nikhil > Sent: Thursday, October 3, 2019 11:43 AM > > > > On Wed, Oct 2, 2019 at 8:38 AM Hemant Agrawal > > > wrote: > > > > > > Hi Jerin, > > > > Hi Hemant, > > > > > > > > > I understand your concern that this shall not be valid on a general

Re: [dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

2019-10-02 Thread Honnappa Nagarahalli
> > > + > > +/* Reclaim resources from the defer queue. */ int > > +rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq *dq) { > > + uint32_t max_cnt; > > + uint32_t cnt; > > + void *token; > > + uint64_t *tmp; > > + uint32_t i; > > + > > + if (dq == NULL) { > > + rte_log(RTE_LOG_

[dpdk-dev] [PATCH] drivers/octeontx2: fix parser error to ol_flags translation

2019-10-02 Thread Sunil Kumar Kori
NPC errors were incorrectly translated to ol_flag as error code enum was not in sync with NPC profile. Fixes: 371d3212cbed ("common/octeontx2: add build infrastructure and HW definition") Signed-off-by: Sunil Kumar Kori --- drivers/common/octeontx2/hw/otx2_npc.h | 7 --- drivers/net/octeon

Re: [dpdk-dev] meson support of armv8 crypto PMD

2019-10-02 Thread Jerin Jacob
On Wed, Oct 2, 2019 at 4:09 PM David Marchand wrote: > > On Wed, Oct 2, 2019 at 11:19 AM David Marchand > wrote: > > > > On Wed, Oct 2, 2019 at 10:56 AM Thomas Monjalon wrote: > > > There is no meson support for drivers/crypto/armv8/ > > > > > > Please, who can add it? > > > > From my side, I wo

Re: [dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

2019-10-02 Thread Honnappa Nagarahalli
> > Hi Honnappa, Thanks Konstantin for the feedback. > > > > Add resource reclamation APIs to make it simple for applications and > > libraries to integrate rte_rcu library. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Ola Liljedhal > > Reviewed-by: Ruifeng Wang > > --- > >

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-02 Thread Rao, Nikhil
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, October 2, 2019 1:24 PM > To: Hemant Agrawal > Cc: Nipun Gupta ; Jerin Jacob ; > dpdk-dev ; Pavan Nikhilesh ; > Sunil Kumar Kori ; Richardson, Bruce > ; Kovacevic, Marko > ; Ori Kam ; Nicolau, Radu

Re: [dpdk-dev] [PATCH 0/9] net/qede/base: update FW to 8.40.25.0

2019-10-02 Thread Rasesh Mody
Hi Jerin, >From: Jerin Jacob >Sent: Wednesday, October 02, 2019 10:06 PM > >On Mon, Sep 30, 2019 at 8:19 AM Rasesh Mody wrote: >> >> Hi, >> >> This patch series updates the FW to 8.40.25.0 and includes >> corresponding base driver changes. It also includes some enhancements >and fixes. >> The PM

Re: [dpdk-dev] [PATCH v3 0/3] net/bnx2x: update to latest FW

2019-10-02 Thread Jerin Jacob
On Thu, Oct 3, 2019 at 12:45 AM Rasesh Mody wrote: > > Hi, > > Currently, BNX2X PMD uses a very old firmware 7.2.51. > This patch series updated the base driver to use to latest > firmware 7.13.11. The latest firmware comprises of enhancements > and fixes. > > v3: > - Addressed gcc 9.2 build issue

Re: [dpdk-dev] [PATCH 0/9] net/qede/base: update FW to 8.40.25.0

2019-10-02 Thread Jerin Jacob
On Mon, Sep 30, 2019 at 8:19 AM Rasesh Mody wrote: > > Hi, > > This patch series updates the FW to 8.40.25.0 and includes corresponding > base driver changes. It also includes some enhancements and fixes. > The PMD version is bumped to 2.11.0.1. > > Please apply. > > Thanks! > -Rasesh > > Rasesh M

Re: [dpdk-dev] [PATCH 1/6] test/event_crypto: fix missing IV value for AES algo

2019-10-02 Thread Gujjar, Abhinandan S
Sure Jerin. Regards Abhinandan > -Original Message- > From: Jerin Jacob > Sent: Thursday, October 3, 2019 8:54 AM > To: Hemant Agrawal > Cc: dpdk-dev ; Jerin Jacob ; Gujjar, > Abhinandan S > Subject: Re: [dpdk-dev] [PATCH 1/6] test/event_crypto: fix missing IV value > for > AES algo >

Re: [dpdk-dev] meson support of armv8 crypto PMD

2019-10-02 Thread Honnappa Nagarahalli
> Subject: Re: meson support of armv8 crypto PMD > > On Wed, Oct 2, 2019 at 11:19 AM David Marchand > wrote: > > > > On Wed, Oct 2, 2019 at 10:56 AM Thomas Monjalon > wrote: > > > There is no meson support for drivers/crypto/armv8/ > > > > > > Please, who can add it? I will add for the DPDK part

[dpdk-dev] [Bug 352] Bifurcated Driver X710 for ipv6 flow rule addition not working

2019-10-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=352 Bug ID: 352 Summary: Bifurcated Driver X710 for ipv6 flow rule addition not working Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCO

Re: [dpdk-dev] [PATCH 2/5] lib/ring: add template to support different element sizes

2019-10-02 Thread Honnappa Nagarahalli
> > > > > > Add templates to support creating ring APIs with different ring > > > > element sizes. > > > > > > > > Signed-off-by: Honnappa Nagarahalli > > > > Reviewed-by: Dharmik Thakkar > > > > Reviewed-by: Gavin Hu > > > > Reviewed-by: Ruifeng Wang > > > > --- > > > > lib/librte_ring/Make

Re: [dpdk-dev] [PATCH v2] app/test-eventdev: add options to set mbuf and pkt size

2019-10-02 Thread Jerin Jacob
On Wed, Oct 2, 2019 at 8:49 PM Jerin Jacob wrote: > > On Mon, Sep 30, 2019 at 10:18 PM wrote: > > > > From: Pavan Nikhilesh > > > > Add options to set mbuf size and max packet size which allow the user to > > enable jumbo frames and Rx/Tx scatter gather. > > Arrange `struct evt_options` based on

Re: [dpdk-dev] [PATCH 1/6] test/event_crypto: fix missing IV value for AES algo

2019-10-02 Thread Jerin Jacob
On Tue, Oct 1, 2019 at 5:06 PM Hemant Agrawal wrote: > > The IV was not set, which was causing HW based SEC on DPAA1 > to fail. > > Fixes: ce02103ad072 ("test/event_crypto: change the SEC cipher algo") > > Signed-off-by: Hemant Agrawal Abhinandan, Could you please review the crypto adapter fixe

Re: [dpdk-dev] [PATCH v2 3/9] eal: add windows compatible header files

2019-10-02 Thread Pallavi Kadam
On 9/30/2019 10:56 PM, Jerin Jacob wrote: On Mon, Sep 30, 2019 at 11:19 PM Pallavi Kadam wrote: Hi Jerin, On 9/27/2019 12:58 AM, Jerin Jacob wrote: On Fri, Sep 27, 2019 at 2:24 AM Pallavi Kadam wrote: Adding dlfcn.h on Windows to support common code. Adding eal_filesystem.h to support fu

[dpdk-dev] [PATCH v2 20/20] net/bnxt: handle flow flush handling

2019-10-02 Thread Ajit Khaparde
We are not freeing all the flows when a flow_flush is called. Iterate through all the flows belonging to all the VNICs in use and free the filters. Reviewed-by: Rahul Gupta Reviewed-by: Venkat Duvvuru Reviewed-by: Kalesh Anakkur Purayil Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_f

[dpdk-dev] [PATCH v2 17/20] net/bnxt: drop untagged frames when specified

2019-10-02 Thread Ajit Khaparde
When a drop action for L2 filters is specified, support it. Signed-off-by: Ajit Khaparde Reviewed-by: Rahul Gupta Reviewed-by: Somnath Kotur Reviewed-by: Kalesh Anakkur Purayil --- drivers/net/bnxt/bnxt_filter.h | 6 drivers/net/bnxt/bnxt_flow.c | 61 ++

[dpdk-dev] [PATCH v2 19/20] net/bnxt: fix multicast filter programming

2019-10-02 Thread Ajit Khaparde
From: Kalesh AP Fixed multicast filter programming and allmulti programming. Fixed to skip programming multicast macs if the user requests allmulti mode. Also removed a comment in bnxt_hwrm_cfa_l2_set_rx_mask() which is no longer valid now. Fixes: d69851df12b2 ("net/bnxt: support multicast filt

[dpdk-dev] [PATCH v2 18/20] net/bnxt: fix VLAN filtering code path

2019-10-02 Thread Ajit Khaparde
From: Venkat Duvvuru Currently, when hw-vlan-filter is enabled on testpmd, driver is receiving all vlan packets. Instead, it should only receive untagged packets and vlan packets for which the VLAN filter is programmed. This is because, the default rule to match on MAC is not getting deleted, whe

[dpdk-dev] [PATCH v2 16/20] net/bnxt: synchronize between flow related functions

2019-10-02 Thread Ajit Khaparde
From: Venkat Duvvuru Currently, there are four flow related functions, namely bnxt_flow_create, bnxt_flow_destroy, bnxt_flow_validate, bnxt_flow_flush. All these functions are not multi-thread safe. This patch fixes it by synchronizing these functions with a lock. Reviewed-by: Kalesh Anakkur Pu

[dpdk-dev] [PATCH v2 05/20] net/bnxt: add support for RSS action

2019-10-02 Thread Ajit Khaparde
Add support for RSS action during flow creation. group id should not be 0 when RSS action is specified. Driver will return an error for such a flow. If a group id is used to create a filter with “n” RSS queues, it cannot be used to create a filter with a different number of RSS queues till all th

[dpdk-dev] [PATCH v2 15/20] net/bnxt: handle cleanup if flow creation fails

2019-10-02 Thread Ajit Khaparde
If flow creation fails because of an HWRM command failure or or some other reason, reset the vnic and rxq info set earlier. Reviewed-by: Rahul Gupta Reviewed-by: Venkat Duvvuru Reviewed-by: Kalesh Anakkur Purayil Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_flow.c | 66 +

[dpdk-dev] [PATCH v2 13/20] net/bnxt: check for invalid VNIC ID in vnic tpa cfg

2019-10-02 Thread Ajit Khaparde
From: Somnath Kotur If driver init/probe fails as part of cleanup/rollback, we may end up invoking this HWRM cmd even on an invalid vNIC which will unecessarily log an error message as the cmd will fail. Check for invalid ID before issuing the HWRM cmd Signed-off-by: Somnath Kotur Reviewed-by:

[dpdk-dev] [PATCH v2 14/20] net/bnxt: validate RSS hash key length

2019-10-02 Thread Ajit Khaparde
From: Venkat Duvvuru In bnxt_rss_hash_update_op, driver is proceeding with bnxt_hwrm_vnic_rss_cfg even though RSS hashkey length is invalid. This patch fixes the problem by returning -EINVAL when RSS hashkey length is invalid. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-

[dpdk-dev] [PATCH v2 12/20] net/bnxt: check device is started before flow creation

2019-10-02 Thread Ajit Khaparde
Check device is started before flow creation. Since the vnic data structures aren't created until device start, the driver dereferences NULL vnic if flow creation is attempted before device is started, Reviewed-by: Somnath Kotur Reviewed-by: Venkat Duvvuru Signed-off-by: Ajit Khaparde --- driv

[dpdk-dev] [PATCH v2 10/20] net/bnxt: allow only unicast MAC address filter creation

2019-10-02 Thread Ajit Khaparde
Check if the application is trying to create filters using broadcast and multicast MAC address and reject it. Signed-off-by: Ajit Khaparde Reviewed-by: Rahul Gupta Reviewed-by: Santoshkumar Karanappa Rastapur --- drivers/net/bnxt/bnxt_flow.c | 16 1 file changed, 16 insertions

[dpdk-dev] [PATCH v2 07/20] net/bnxt: delete and flush L2 filters cleanly

2019-10-02 Thread Ajit Khaparde
Once the last filter associated with a VNIC is deleted when using RSS action or the Queue action free the VNIC. Also free the RSS context if the VNIC is using it. Reviewed-by: Rahul Gupta Reviewed-by: Venkat Duvvuru Signed-off-by: Kalesh AP Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v2 11/20] net/bnxt: properly handle ring cleanup in case of error

2019-10-02 Thread Ajit Khaparde
From: Rahul Gupta Initialize all rings to INVALID_HW_RING_ID. This can be used to determine the rings to free if allocation fails. Signed-off-by: Rahul Gupta Reviewed-by: Venkat Duvvuru Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Ajit Khaparde Signed-off-by: Ajit Khaparde --- drivers/

[dpdk-dev] [PATCH v2 09/20] net/bnxt: fix an issue in setting default MAC address

2019-10-02 Thread Ajit Khaparde
From: Kalesh AP Driver was incorrectly programming the MAC with the already configured one instead of the newly requested MAC by user. Also, fix to restore the old mac address back to the default vnic filter if the mac update operation fails. Fixes: 68f589f2c728e ("net/bnxt: fix setting primary

[dpdk-dev] [PATCH v2 06/20] net/bnxt: parse priority attribute for flow creation

2019-10-02 Thread Ajit Khaparde
Parse priority attribute during flow creation. This information will be used to give a hint to the FW to place the flow rule accordingly in the CFA tables. Reviewed-by: Rahul Gupta Reviewed-by: Lance Richardson Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.h | 1 + drivers/net

[dpdk-dev] [PATCH v2 08/20] net/bnxt: cleanup vnic after flow validate

2019-10-02 Thread Ajit Khaparde
When an application issues flow validate, we free the temporary filter that is created. But the vnic is not freed up. This can potentially interfere with subsequent flow creation. So free the vnic. Reviewed-by: Rahul Gupta Reviewed-by: Venkat Duvvuru Signed-off-by: Ajit Khaparde --- drivers/ne

[dpdk-dev] [PATCH v2 04/20] net/bnxt: add support to create SMAC and inner DMAC filters

2019-10-02 Thread Ajit Khaparde
We are currently creating only outer DMAC filters. Create SMAC and inner DMAC filters using HWRM_CFA_L2_FILTER_ALLOC. For this the HWRM_CFA_L2_FILTER_ALLOC has already been updated. Reviewed-by: Somnath Kotur Reviewed-by: Rahul Gupta Signed-off-by: Kalesh AP Signed-off-by: Ajit Khaparde --- d

[dpdk-dev] [PATCH v2 03/20] net/bnxt: allow flow creation when RSS is enabled

2019-10-02 Thread Ajit Khaparde
Currently flow creation is allowed with queue action only when RSS is disabled. Remove this restriction. Flows can be created when RSS is enabled. Signed-off-by: Ajit Khaparde Reviewed-by: Rahul Gupta Reviewed-by: Venkat Duvvuru --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt

[dpdk-dev] [PATCH v2 00/20] bnxt patchset to improve rte flow support

2019-10-02 Thread Ajit Khaparde
Among other changes, this patchset adds support to: - create filters with RSS action. - create source MAC filters. - use user provided priority to place rule appropriately in HW. This patch has been rebased to dpdk-next-net commit 8587a8b9eddefa39e4ceac7e9385efcc5e73307c Please apply. Ajit Khap

[dpdk-dev] [PATCH v2 01/20] net/bnxt: return standard error codes for HWRM command

2019-10-02 Thread Ajit Khaparde
If the FW returns an error for an HWRM request, it does not necessarily return standard error codes. Convert these HWRM errors to standard errno. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH v2 02/20] net/bnxt: refactor code to allow dynamic creation of VNIC

2019-10-02 Thread Ajit Khaparde
Refactor code to allow dynamic creation of VNIC for RSS or Queue Action during flow create. Signed-off-by: Kalesh AP Signed-off-by: Santoshkumar Karanappa Rastapur Signed-off-by: Ajit Khaparde Reviewed-by: Rahul Gupta Reviewed-by: Venkat Duvvuru --- drivers/net/bnxt/bnxt.h| 1 + dri

[dpdk-dev] [PATCH v8 5/7] drivers/net: update Rx flow flag and mark capabilities

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action flag and mark. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko Acked-by: Jerin Jacob --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/enic/enic_res.c | 3 ++-

[dpdk-dev] [PATCH v8 7/7] examples: disable Rx packet type parsing

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Disable packet type parsing in examples that don't use `rte_mbuf::packet_type` by setting ptype_mask as 0 in `rte_eth_dev_set_supported_ptypes` Signed-off-by: Pavan Nikhilesh --- examples/bbdev_app/main.c | 1 + examples/bond/main.c

[dpdk-dev] [PATCH v8 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash delivery. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko Reviewed-by: Hemant Agrawal Acked-by: Jerin Jacob Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- driv

[dpdk-dev] [PATCH v8 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result into the mbuf. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/main.c | 113 - .../p

[dpdk-dev] [PATCH v8 1/7] ethdev: add set ptype function

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Add `rte_eth_dev_set_supported_ptypes` function that will allow the application to inform the PMD the packet types it is interested in. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t want any ptype information it can call `rte_eth_dev_set_s

[dpdk-dev] [PATCH v8 2/7] ethdev: add mbuf RSS update as an offload

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to enable/disable PMDs write to `rte_mbuf::hash::rss`. PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. Signed-off-by: Pavan Ni

[dpdk-dev] [PATCH v8 0/7] ethdev: add new Rx offload flags

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` and `DEV_RX_OFFLOAD_FLOW_MARK`. These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and `hash.fdir.hi` and also `ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`. Add new packet type set functi

[dpdk-dev] [PATCH v8 3/7] ethdev: add flow action type update as an offload

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and `rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and `RTE_FLOW_ACTION_FLAG` are enabled. PMDs notify the validity of `rte_mbuf::ha

[dpdk-dev] [PATCH v5 10/10] doc: add application usage guide for l2fwd-event

2019-10-02 Thread pbhagavatula
From: Sunil Kumar Kori Add documentation for l2fwd-event example. Update release notes. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 1 + doc/guides/rel_notes/release_19_11.rst| 6 + doc/guides/sample_app_ug/index.rst| 1 + doc/g

[dpdk-dev] [PATCH v5 08/10] examples/l2fwd-event: add eventdev main loop

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Add event dev main loop based on enabled l2fwd options and eventdev capabilities. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_common.c | 6 + examples/l2fwd-event/l2fwd_common.h | 2 + examples/l2fwd-event/l2fwd_event.c | 294 +++

[dpdk-dev] [PATCH v5 09/10] examples/l2fwd-event: add graceful teardown

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Add graceful teardown that addresses both event mode and poll mode. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/main.c | 50 + 1 file changed, 40 insertions(+), 10 deletions(-) diff --git a/examples/l2fwd-event/main.c b/exa

[dpdk-dev] [PATCH v5 07/10] examples/l2fwd-event: add service core setup

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Setup service cores for eventdev and Rx/Tx adapter when they don't have internal port capability. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_event.c | 87 ++ examples/l2fwd-event/l2fwd_event.h | 1 + examples/l2fwd-event/mai

[dpdk-dev] [PATCH v5 06/10] examples/l2fwd-event: add event Rx/Tx adapter setup

2019-10-02 Thread pbhagavatula
From: Sunil Kumar Kori Add event eth Rx/Tx adapter setup for both generic and internal port event device pipelines. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_event.c| 3 + examples/l2fwd-event/l2fwd_event.h| 16 +++

[dpdk-dev] [PATCH v5 05/10] examples/l2fwd-event: add eventdev queue and port setup

2019-10-02 Thread pbhagavatula
From: Sunil Kumar Kori Add event device queue and port setup based on event eth Tx adapter capabilities. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_event.c| 9 +- examples/l2fwd-event/l2fwd_event.h| 10 ++ examples/

[dpdk-dev] [PATCH v5 04/10] examples/l2fwd-event: add event device setup

2019-10-02 Thread pbhagavatula
From: Sunil Kumar Kori Add event device device setup based on event eth Tx adapter capabilities. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_event.c| 3 + examples/l2fwd-event/l2fwd_event.h| 16 examples/l2fwd-eve

[dpdk-dev] [PATCH v5 03/10] examples/l2fwd-event: add infra to split eventdev framework

2019-10-02 Thread pbhagavatula
From: Sunil Kumar Kori Add infra to split eventdev framework based on event Tx adapter capability. If event Tx adapter has internal port capability then we use `rte_event_eth_tx_adapter_enqueue` to transmitting packets else we use a SINGLE_LINK event queue to enqueue packets to a service core whi

[dpdk-dev] [PATCH v5 02/10] examples/l2fwd-event: add infra for eventdev

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Add infra to select event device as a mode to process packets through command line arguments. Also, allow the user to select the schedule type to be either RTE_SCHED_TYPE_ORDERED or RTE_SCHED_TYPE_ATOMIC. Usage: `--mode="eventdev"` or `--mode="poll"` `--eventq-sched="order

[dpdk-dev] [PATCH v5 01/10] examples/l2fwd-event: add default poll mode routines

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh Add the default l2fwd poll mode routines similar to examples/l2fwd. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- MAINTAINERS | 5 + examples/Makefile | 1 + examples/l2fwd-event/Makefile | 59

[dpdk-dev] [PATCH v5 00/10] example/l2fwd-event: introduce l2fwd-event example

2019-10-02 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds a new application to demonstrate the usage of event mode. The poll mode is also available to help with the transition. The following new command line parameters are added: --mode: Dictates the mode of operation either poll or event. --eventq_sync: Dicta

[dpdk-dev] [PATCH v8] eal: make lcore_config private

2019-10-02 Thread Stephen Hemminger
The internal structure of lcore_config is no longer be part of visible API/ABI. Make it private to EAL. Rearrange and resize the fields in the structure so it takes less memory (and cache footprint). Signed-off-by: Stephen Hemminger --- v8 - update release notes rearrange to move cpuset to

[dpdk-dev] [PATCH v3 3/3] net/bnx2x: update to latest FW 7.13.11

2019-10-02 Thread Rasesh Mody
Use latest firmware 7.13.11. Some of the fixes included with this FW are as following: - Packets from a VF with pvid configured which were sent with a different vlan were transmitted instead of being discarded. - In some multi-function configurations, inter-PF and inter-VF Tx s

[dpdk-dev] [PATCH v3 0/3] net/bnx2x: update to latest FW

2019-10-02 Thread Rasesh Mody
Hi, Currently, BNX2X PMD uses a very old firmware 7.2.51. This patch series updated the base driver to use to latest firmware 7.13.11. The latest firmware comprises of enhancements and fixes. v3: - Addressed gcc 9.2 build issues v2: - Squashed pmd version patch into "net/bnx2x: update to latest F

Re: [dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

2019-10-02 Thread Ananyev, Konstantin
> + > +/* Reclaim resources from the defer queue. */ > +int > +rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq *dq) > +{ > + uint32_t max_cnt; > + uint32_t cnt; > + void *token; > + uint64_t *tmp; > + uint32_t i; > + > + if (dq == NULL) { > + rte_log(RTE_LOG_ERR

Re: [dpdk-dev] [PATCH v3 1/3] lib/ring: add peek API

2019-10-02 Thread Ananyev, Konstantin
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Tuesday, October 1, 2019 7:29 AM > To: honnappa.nagaraha...@arm.com; Ananyev, Konstantin > ; step...@networkplumber.org; > paul...@linux.ibm.com > Cc: Wang, Yipeng1 ; Medvedkin, Vladimir > ;

Re: [dpdk-dev] [PATCH v3 00/16] bnxt patchset

2019-10-02 Thread Ferruh Yigit
On 10/2/2019 6:17 PM, Ajit Khaparde wrote: > bnxt patchset against dpdk-next-net. > This patchset has been rebased and is dependent on > "bnxt patchset to support device error recovery" > commit-id 5f30ec0329bf81d8a4a3404faaf450dbceb9463e > > Please apply. > > v1->v2: 5f30ec0329bf81d8a4a3404faaf4

Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs

2019-10-02 Thread Flavio Leitner
On Wed, 2 Oct 2019 17:50:41 + Shahaf Shuler wrote: > Wednesday, October 2, 2019 3:59 PM, Flavio Leitner: > > Obrembski MichalX ; Stokes Ian > > > > Subject: Re: [dpdk-dev] [PATCH] vhost: add support to large linear > > mbufs > > > > > > Hi Shahaf, > > > > Thanks for looking into this, see

[dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

2019-10-02 Thread Rahul Shah
Adding a new port type called eventdev to the rte_port library. Signed-off-by: Rahul Shah --- lib/librte_port/Makefile | 4 +- lib/librte_port/meson.build | 8 +- lib/librte_port/rte_port_eventdev.c | 585 +++ lib/librte_port/rte_port_eventdev.h

Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs

2019-10-02 Thread Shahaf Shuler
Wednesday, October 2, 2019 3:59 PM, Flavio Leitner: > Obrembski MichalX ; Stokes Ian > > Subject: Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs > > > Hi Shahaf, > > Thanks for looking into this, see my inline comments. > > On Wed, 2 Oct 2019 09:00:11 + > Shahaf Shuler wr

Re: [dpdk-dev] [PATCH v2 0/5] fix and optimize barriers usage with some PMDs

2019-10-02 Thread Ferruh Yigit
On 9/16/2019 12:27 PM, Gavin Hu wrote: > DPDK has well-defined barriers, such as CIO barriers and IO barriers. > > X86, as a strong ordering model, implements the barriers as compiler > barriers, but on aarch64, as a weak memory ordering model, has fine > grained barriers. Using correct while as r

Re: [dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

2019-10-02 Thread Ananyev, Konstantin
Hi Honnappa, > Add resource reclamation APIs to make it simple for applications > and libraries to integrate rte_rcu library. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Ola Liljedhal > Reviewed-by: Ruifeng Wang > --- > app/test/test_rcu_qsbr.c | 291 +++

[dpdk-dev] [PATCH v3 14/16] net/bnxt: fix a segfault in secondary process

2019-10-02 Thread Ajit Khaparde
From: Stephen Hemminger The secondary process should not modify device state when init is called. The pci device information pointed to by dev_private pointer is not correct in secondary process. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: sta...@dpdk

[dpdk-dev] [PATCH v3 08/16] net/bnxt: fix use of deferred start of transmit queues

2019-10-02 Thread Ajit Khaparde
From: Kalesh AP Driver should not change "deferred_start" state of the tx queues. It should get the state in queue_setup_op() and use that value. Since the deferred start state was being used in the packet transmit functions to determine whether the queue has been stopped already, introduced a p

[dpdk-dev] [PATCH v3 12/16] net/bnxt: fix accessing variable before null check

2019-10-02 Thread Ajit Khaparde
From: Kalesh AP Check input argument "rxq" in bnxt_rx_queue_release_mbufs(), to be sure variable is not NULL before accessing it. Fixes: 9b63c6fd70e3 ("net/bnxt: support Rx/Tx queue start/stop") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-

[dpdk-dev] [PATCH v3 15/16] net/bnxt: support for QinQ insertion and stripping

2019-10-02 Thread Ajit Khaparde
From: Somnath Kotur Driver will accelerate only outer/S-VLAN insertion by turning on the appropriate bits in the Tx Buffer Descriptor when the packet arrives for transmission. The TPID to be used for this S-VLAN is conveyed by the vlan_tpid_set dev_op which will terminate in the driver. In the Rx

[dpdk-dev] [PATCH v3 13/16] net/bnxt: fix Rx queue count devop

2019-10-02 Thread Ajit Khaparde
From: Rahul Gupta Fix Computing of number of used descriptors in an Rx queue. Fixes: 1b7ceba3e375 ("net/bnxt: support Rx queue count") Cc: sta...@dpdk.org Signed-off-by: Rahul Gupta Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_

[dpdk-dev] [PATCH v3 10/16] net/bnxt: remove unused macro

2019-10-02 Thread Ajit Khaparde
From: Kalesh AP remove MAX_NUM_MAC_ADDR macro Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index

[dpdk-dev] [PATCH v3 09/16] net/bnxt: remove unnecessary return check

2019-10-02 Thread Ajit Khaparde
From: Kalesh AP HWRM_CHECK_RESULT_SILENT() returns if the HWRM command fails. There is no need to check the return value after this call. Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 119 +--

[dpdk-dev] [PATCH v3 16/16] net/bnxt: use macro for getting default vnic

2019-10-02 Thread Ajit Khaparde
From: Kalesh AP Minor code cleanup. BNXT_GET_DEFAULT_VNIC macro returns the default VNIC of the function and fixed code to use the macro. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 10 +- 1 file changed, 5 inser

[dpdk-dev] [PATCH v3 04/16] net/bnxt: subscribe to link speed change notification

2019-10-02 Thread Ajit Khaparde
We are not subscribing to link speed change notification. This patch addresses that. Signed-off-by: Ajit Khaparde Reviewed-by: Rahul Gupta Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Kalesh Anakkur Purayil --- drivers/net/bnxt/bnxt_hwrm.c | 1 + drivers/net/bnxt/bnxt_hwrm.h | 2

[dpdk-dev] [PATCH v3 07/16] net/bnxt: fix L2 context calculation for Thor

2019-10-02 Thread Ajit Khaparde
From: Kalesh AP On Wh+, number of L2 context supported by FW is the sum of number of EM flow count and number of L2 context count returned in HWRM_FUNC_QCFG. This is not true for Thor. Restrict this only for Whitney for now. Fixes: ff9c0ca47e81176 ("net/bnxt: save the number of EM flow count")

[dpdk-dev] [PATCH v3 11/16] net/bnxt: remove unnecessary interrupt disable

2019-10-02 Thread Ajit Khaparde
From: Kalesh AP Since bnxt_enable_int() is called at start time, invoke bnxt_disable_int() during stop only. Remove it from device uninit function. Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev

[dpdk-dev] [PATCH v3 05/16] net/bnxt: fix async link handling and update

2019-10-02 Thread Ajit Khaparde
When updating the link because of an async link notification there is no need to set wait_for_completion. At this point the link related information should be available without need to poll. Use rte_eth_linkstatus_set instead of memcpy to ensure atomicity while updating the link status. We force th

[dpdk-dev] [PATCH v3 03/16] net/bnxt: fix rxq stop/start handling

2019-10-02 Thread Ajit Khaparde
From: Kalesh AP Driver should not change "deferred_start" state of the rx queues. It should get the state in queue_setup_op() and use that value. Since the deferred start state was being used in the packet receive functions to determine whether a stopped rx ring should be polled, introduced a pe

[dpdk-dev] [PATCH v3 00/16] bnxt patchset

2019-10-02 Thread Ajit Khaparde
bnxt patchset against dpdk-next-net. This patchset has been rebased and is dependent on "bnxt patchset to support device error recovery" commit-id 5f30ec0329bf81d8a4a3404faaf450dbceb9463e Please apply. v1->v2: 5f30ec0329bf81d8a4a3404faaf450dbceb9463e v2->v3: Removed an unnecessary patch from v2.

[dpdk-dev] [PATCH v3 01/16] net/bnxt: fix incorrect flow steering

2019-10-02 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur When user creates a flow similar to an existing flow with just the destination queue change, we delete the old filter and allocate a new one with this destination queue change. We were also allocating a new L2 filter matching the same destination mac resultin

[dpdk-dev] [PATCH v3 06/16] net/bnxt: fix 40G link failure for Thor

2019-10-02 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur Link autonegotiation for 40G is not supported by Thor. Hence speed needs to be forced and autoneg disabled to configure 40G speed. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Reviewed-by: Ajit Khaparde Signed-off-by: Santoshkumar Karanappa Ras

[dpdk-dev] [PATCH v3 02/16] net/bnxt: fix traffic failure with higher mbuf size

2019-10-02 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur Maximum frame length supported by hw is 9600 bytes. When user launches testpmd with --mbuf-size=9729, we are posting buffer descriptors of size 9601 to the ring. This was causing packets getting discarded. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Cc

[dpdk-dev] [PATCH v2] port: Eventdev port support added in the rte_port library

2019-10-02 Thread Rahul Shah
Adding a new port type called eventdev to the rte_port library. Signed-off-by: Rahul Shah --- lib/librte_port/Makefile | 4 +- lib/librte_port/meson.build | 8 +- lib/librte_port/rte_port_eventdev.c | 585 +++ lib/librte_port/rte_port_eventdev.h

Re: [dpdk-dev] [PATCH v3 00/15] bnxt patchset to support device error recovery

2019-10-02 Thread Ferruh Yigit
On 10/2/2019 2:23 AM, Ajit Khaparde wrote: > This patchset adds support to monitor the health of the firmware and the > underlying device and recover to an operational state in case of error. > We can also detect if a FW upgrade is in progress and quiesce all > access to the device and recover once

[dpdk-dev] [PATCH] devtools: reset compilation flags for each target

2019-10-02 Thread David Marchand
Same idea than overriding PATH and PKG_CONFIG_PATH, it can be quite useful to override compilation flags like CFLAGS, CPPFLAGS and LDFLAGS for cross compilation or libraries that won't provide a pkg-config file. Fixes: 272236741258 ("devtools: load target-specific compilation environment") Signed

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix compilation issue with gcc pragma

2019-10-02 Thread Ferruh Yigit
On 10/2/2019 1:36 PM, Viacheslav Ovsiienko wrote: > The GCC compiler might generate warning or error if > format parameter of fscanf is not literal. This was > suppressed with GCC specific pragms. Some compilers > (i.e Intel icc) do not recognize GCC diagnostic > pragma, so the code was refactored

Re: [dpdk-dev] [PATCH v5 1/4] examples/ipsec-secgw: ipsec_sa structure cleanup

2019-10-02 Thread Nicolau, Radu
On 9/27/2019 4:54 PM, Marcin Smoczynski wrote: Cleanup ipsec_sa structure by removing every field that is already in the rte_ipsec_session structure: * cryptodev/security session union * action type * offload flags * security context References to abovementioned fields are changed to di

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix SAD selection logic

2019-10-02 Thread Nicolau, Radu
On 9/24/2019 11:35 AM, Drost, MariuszX wrote: Ipsec-secgw example application fails to initialize when using default configuration file (ep0.cfg) in library mode (librte_ipsec enabled). The reason is that two of SP rules in ep0.cfg, one for IPv4 and one for IPv6, are using the same SPI number.

Re: [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in meson

2019-10-02 Thread David Marchand
On Wed, Oct 2, 2019 at 5:18 PM Thomas Monjalon wrote: > > 02/10/2019 16:24, David Marchand: > > There is no dependency on this library for mlx4. > > > > Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build") > > Cc: sta...@dpdk.org > > It seems this dependency was added by mistake. > It was used in

Re: [dpdk-dev] [PATCH v2] app/test-eventdev: add options to set mbuf and pkt size

2019-10-02 Thread Jerin Jacob
On Mon, Sep 30, 2019 at 10:18 PM wrote: > > From: Pavan Nikhilesh > > Add options to set mbuf size and max packet size which allow the user to > enable jumbo frames and Rx/Tx scatter gather. > Arrange `struct evt_options` based on ascending order of data type to > make it more readable. > > Packe

Re: [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in meson

2019-10-02 Thread Thomas Monjalon
02/10/2019 16:24, David Marchand: > There is no dependency on this library for mlx4. > > Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build") > Cc: sta...@dpdk.org It seems this dependency was added by mistake. It was used in mlx5 for TC Flower, and has been dropped recently.

Re: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds

2019-10-02 Thread Kevin Traynor
On 28/05/2019 12:07, Bruce Richardson wrote: > This set fixes some issues seen on the automated CI system with building > on 32-bit Linux distro's using meson and ninja. The fixes are to disable > unsupported parts of the build, and switch the 32-bit builds to always > having large file support, so

Re: [dpdk-dev] [PATCH v4 1/2] eal: make base address hint OS-specific

2019-10-02 Thread Stephen Hemminger
On Wed, 2 Oct 2019 13:41:30 +0200 David Marchand wrote: > > +uint64_t eal_get_baseaddr(void) > > +{ > > + /* > > +* Linux kernel uses a really high address as starting address for > > +* serving mmaps calls. If there exists addressing limitations and > > IOVA > > +*

[dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in meson

2019-10-02 Thread David Marchand
There is no dependency on this library for mlx4. Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/mlx4/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/meson.build b/drivers/ne

Re: [dpdk-dev] [PATCH v7 1/7] ethdev: add set ptype function

2019-10-02 Thread Pavan Nikhilesh Bhagavatula
>On 10/2/19 4:37 PM, Andrew Rybchenko wrote: >> Hi, >> >> looks good, just few comments below. >> >> Many thanks for working on it, >> Andrew. >> Thank you for your patience. Pavan. >> On 10/2/19 6:47 AM, pbhagavat...@marvell.com wrote: >>> From: Pavan Nikhilesh >>> >>> Add `rte_eth_dev_set_su

Re: [dpdk-dev] [RFC] ethdev: add new fields for max LRO session size

2019-10-02 Thread Thomas Monjalon
24/09/2019 14:03, Matan Azrad: > From: Ferruh Yigit > > On 9/15/2019 8:48 AM, Matan Azrad wrote: > > > Hi Ferruh > > > > > > From: Ferruh Yigit > > >> On 8/29/2019 8:47 AM, Matan Azrad wrote: > > >>> It may be needed by the user to limit the LRO session packet size. > > >>> In order to allow the a

Re: [dpdk-dev] [PATCH v2 3/3] examples/bpf: remove duplicate mbuf definition

2019-10-02 Thread Michel Machado
Acked-by: Michel Machado [ ]'s Michel Machado On 9/27/19 9:50 AM, Konstantin Ananyev wrote: Get rid of duplicate definitions for rte_mbuf and related macros. Include rte_mbuf_core.h instead. Signed-off-by: Konstantin Ananyev --- examples/bpf/mbuf.h | 605 ---

  1   2   >