Re: [dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

2019-10-03 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > > > > Add resource reclamation APIs to make it simple for applications > > > > and libraries to integrate rte_rcu library. > > > > > > > > Signed-off-by: Honnappa Nagarahalli > > > > Reviewed-by: Ola Liljedhal > > > > Reviewed-by: Ruifeng Wang > > > > --- > > > > app/test

[dpdk-dev] [PATCH 07/10] net/bnxt: reduce cleanup time during reset recovery

2019-10-03 Thread Ajit Khaparde
From: Rahul Gupta In stop_op(), don't wait for link down event's ASYNC response from FW. Signed-off-by: Rahul Gupta Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH 10/10] net/bnxt: remove a useless check in validate flow routine

2019-10-03 Thread Ajit Khaparde
From: Kalesh AP Since vnic->rx_queue_cnt is already checked against non-zero, removed the useless check from the inside condition check. Fixes: 4be31562a4ba ("net/bnxt: allow flow creation when RSS is enabled") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_flo

[dpdk-dev] [PATCH 08/10] net/bnxt: change msix vector to queue mapping

2019-10-03 Thread Ajit Khaparde
From: Rahul Gupta DPDK PCIe-VFIO framework configures base MSIX vector for interrupts which is supported by other h/w. In case of bnxt, base MSIX vector starts with the RX completion queue 0. To comply with the DPDK framework We need to increase the map index by 1 so that RXTX completion queues e

[dpdk-dev] [PATCH 09/10] net/bnxt: fix to handle if change status in port start only

2019-10-03 Thread Ajit Khaparde
From: Kalesh AP Driver should handle if change status during port start only. Also fixed to enable interrupts after issuing hwrm_if_change. Fixes: 92d6617b6e33 ("net/bnxt: inform firmware about IF state changes") Signed-off-by: Kalesh AP --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net

[dpdk-dev] [PATCH 04/10] net/bnxt: remove redundant header file inclusion

2019-10-03 Thread Ajit Khaparde
From: Kalesh AP bnxt.h header includes bnxt_cpr.h and bnxt_util.h. There is no need to include these headers file explicitly. This commit does not cause any functional change. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c| 1 - drivers/net/bnxt/bnxt_

[dpdk-dev] [PATCH 02/10] net/bnxt: free default completion ring before VF configuration

2019-10-03 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur If the VF resources need to be reconfigured using the bnxt_hwrm_func_reserve_vf_resc, make sure that the default completion ring is freed first before the resources are reserved. Reallocate the ring once the VF resources are configured. Signed-off-by: Santo

[dpdk-dev] [PATCH 06/10] net/bnxt: get the default HWRM command timeout from firmware

2019-10-03 Thread Ajit Khaparde
The HWRM command timeout is set to a very high value. VER_GET command response returns the default request timeout value. Use this value for waiting for HWRM commands to complete. Poll for the valid bit every 1us instead of 600us. Signed-off-by: Santoshkumar Karanappa Rastapur Signed-off-by: Ajit

[dpdk-dev] [PATCH 03/10] net/bnxt: return error if setting link up fail

2019-10-03 Thread Ajit Khaparde
From: Kalesh AP Currently bnxt driver does not return error in case setting link up fails. Fixes: 5c206086feaa ("net/bnxt: add link state operations") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion

[dpdk-dev] [PATCH 00/10] bnxt patchset with bug fixes

2019-10-03 Thread Ajit Khaparde
This patch against dpdk-next-net contains bug fixes for issues found during testing. This patch is dependent on bnxt patchset https://patchwork.dpdk.org/project/dpdk/list/?series=6686 Please apply. Thanks Ajit Khaparde (2): net/bnxt: update trusted VF status only when it changes net/bnxt: ge

[dpdk-dev] [PATCH 01/10] net/bnxt: change return value of few routines

2019-10-03 Thread Ajit Khaparde
From: Kalesh AP Change bnxt_init_nic() and bnxt_init_ring_grps() to void functions as these can never fail. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Santoshkumar Karanappa Rastapur --- drivers/net/bnxt/bnxt_ethdev.c | 13 +++-- drivers/net/bnxt/bnxt_ring.c |

[dpdk-dev] [PATCH 05/10] net/bnxt: update trusted VF status only when it changes

2019-10-03 Thread Ajit Khaparde
We are currently logging trusted VF information everytime a VF config change is indicated by the async message. Update it only when new setting is different from the current setting. Fixes: b42c15c83e88 ("net/bnxt: support trusted VF") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-10-03 Thread Honnappa Nagarahalli
Adding Arm JIT and Kernel experts > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 3, 2019 10:06 AM > To: Jerin Jacob ; tho...@monjalon.net > Cc: jer...@marvell.com; dpdk-dev ; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > > Subject: RE: [dpdk-dev]

[dpdk-dev] [PATCH v10 3/3] app/testpmd: add RSS offload types extending support

2019-10-03 Thread Simei Su
This patch adds cmdline support for extended rss types configuration. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- app/test-pmd/cmdline.c | 14 -- app/test-pmd/config.c | 4 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test

[dpdk-dev] [PATCH v10 1/3] ethdev: decouple flow types and RSS offload types

2019-10-03 Thread Simei Su
This patch decouples RTE_ETH_FLOW_* and ETH_RSS_*. The former defines flow types and the latter defines RSS offload types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 49 ---

[dpdk-dev] [PATCH v10 0/3] extend RSS offload types

2019-10-03 Thread Simei Su
[PATCH v10 1/3] ethdev: decouple flow types and RSS offload types. [PATCH v10 2/3] ethdev: add several bits for extending rss offload types. [PATCH v10 3/3] app/testpmd: add cmdline support for extending rss types. v10: * Modify duplicate logic in rte_eth_dev_configure() and rte_eth_dev_rss_hash

[dpdk-dev] [PATCH v10 2/3] ethdev: extend RSS offload types

2019-10-03 Thread Simei Su
This patch reserves several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent RSS types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam --- lib/librte_ethdev/rte_ethdev.c | 42

[dpdk-dev] [PATCH v2 5/9] net/bnxt: use common receive transmit nq ring

2019-10-03 Thread Ajit Khaparde
From: Lance Richardson Thor queue scaling is currently limited by the number of NQs that can be allocated. Fix by using a common NQ for all receive/transmit rings instead of allocating a separate NQ for each ring. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH v2 9/9] net/bnxt: improve CPR handling in vector PMD

2019-10-03 Thread Ajit Khaparde
From: Lance Richardson Reduce overhead of CPR descriptor validity checking in vector receive and transmit functions. Preserve raw cpr consumer index in vector transmit completion function. Remove an unneeded prefetch (per benchmarking) from vector transmit completion function. Fixes: bc4a000f2

[dpdk-dev] [PATCH v2 6/9] net/bnxt: fix stats context calculation

2019-10-03 Thread Ajit Khaparde
From: Lance Richardson The required number of statistics contexts is computed as the sum of the number of receive and transmit rings plus one for the async completion ring. A statistics context is not actually required for the async completion ring, so remove it from the calculation. Fixes: bd0a

[dpdk-dev] [PATCH v2 8/9] net/bnxt: advertise scatter receive offload capability

2019-10-03 Thread Ajit Khaparde
From: Lance Richardson Scattered receive is supported but not included in receive offload capabilities. Fix by adding it and including in scattered receive calculation. Fixes: 9c1507d96ab8 ("net/bnxt: switch to the new offload API") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-b

[dpdk-dev] [PATCH v2 7/9] net/bnxt: use correct default Rx queue for thor

2019-10-03 Thread Ajit Khaparde
From: Lance Richardson Use first receive queue assigned to VNIC as the default receive queue when configuring Thor VNICs. This is necessary e.g. in order for flow redirection to a specific receive queue to work correctly. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Signed-off-by: L

[dpdk-dev] [PATCH v2 3/9] net/bnxt: add support for LRO on thor adapters

2019-10-03 Thread Ajit Khaparde
From: Lance Richardson Add support for LRO for adapters based on Thor (BCM57508). Reviewed-by: Kalesh Anakkur Purayil Signed-off-by: Lance Richardson Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 16 drivers/net/bnxt/bnxt_ethdev.c | 4 ++ drivers/net/bnxt/bnxt_h

[dpdk-dev] [PATCH v2 4/9] net/bnxt: add support for CoS classification

2019-10-03 Thread Ajit Khaparde
From: Venkat Duvvuru Class of Service (CoS) is a way to manage multiple types of traffic over a network to offer different types of services to applications. CoS classification (priority to cosqueue) is determined by the user and configured through the PF driver. DPDK driver queries this configur

[dpdk-dev] [PATCH v2 0/9] bnxt patchset

2019-10-03 Thread Ajit Khaparde
Apart form fixes support for Thor and vector PMD, this patchset adds support for LRO on Thor based adapters and CoS classification. Patchset against dpdk-next-net, has been compiled & tested on an x86_64 system. Please apply. Lance Richardson (8): net/bnxt: increase tqm entry allocation net/

[dpdk-dev] [PATCH v2 2/9] net/bnxt: fix ring alignment for thor-based adapters

2019-10-03 Thread Ajit Khaparde
From: Lance Richardson When using transmit/receive queue sizes smaller than 256, alignment requirements are not being met for Thor-based adapters. Fix by forcing memory addresses used for transmit/receive/aggregation ring allocations to be on 4K boundaries. Fixes: f8168ca0e690 ("net/bnxt: suppor

[dpdk-dev] [PATCH v2 1/9] net/bnxt: increase tqm entry allocation

2019-10-03 Thread Ajit Khaparde
From: Lance Richardson The current TQM backing store size isn't sufficient to allow 512 transmit rings. Fix by correcting TQM SP queue size calculation. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Revi

Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless

2019-10-03 Thread Anoob Joseph
> -Original Message- > From: Arek Kusztal > Sent: Friday, September 6, 2019 5:28 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Anoob Joseph ; Arek > Kusztal > Subject: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by > sessionless >

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-10-03 Thread Pei Zhang
Hi Kevin, The testings from Red Hat get PASS result. Below 13 testing scenarios look good with v18.11.3-rc1. Testing scenarios: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size): PASS (3)Guest

[dpdk-dev] [PATCH] crypto/armv8: enable meson build

2019-10-03 Thread Dharmik Thakkar
Add new meson.build file for crypto/armv8 Signed-off-by: Dharmik Thakkar --- drivers/crypto/armv8/meson.build | 25 + drivers/crypto/meson.build | 6 +++--- meson_options.txt| 2 ++ 3 files changed, 30 insertions(+), 3 deletions(-) create mode 100

Re: [dpdk-dev] [PATCH 2/5] lib/ring: add template to support different element sizes

2019-10-03 Thread Honnappa Nagarahalli
> > > > > > > +++ b/lib/librte_ring/rte_ring_template.h > > > > > > > @@ -0,0 +1,330 @@ > > > > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > > > > + * Copyright (c) 2019 Arm Limited */ > > > > > > > + > > > > > > > +#ifndef _RTE_RING_TEMPLATE_H_ #define > _RTE_RING_TEMPLATE_H_ > > > >

[dpdk-dev] [PATCH] net/ixgbe: avoid multpile definitions of 'bool'

2019-10-03 Thread Dharmik Thakkar
Compilation issue arises due to multiple definitions of 'bool' in 'ixgbe_ethdev.h'. Error: '/dpdk/drivers/net/ixgbe/ixgbe_ethdev.c: In function ‘ixgbe_dev_setup_link_alarm_handler’: /dpdk/drivers/net/ixgbe/ixgbe_ethdev.c:4075:43: error: passing argument 3 of ‘ixgbe_get_link_capabilities’ from inco

Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs

2019-10-03 Thread Flavio Leitner
On Thu, 3 Oct 2019 18:57:32 +0200 Ilya Maximets wrote: > On 02.10.2019 20:15, Flavio Leitner wrote: > > On Wed, 2 Oct 2019 17:50:41 + > > Shahaf Shuler wrote: > > > >> Wednesday, October 2, 2019 3:59 PM, Flavio Leitner: > >>> Obrembski MichalX ; Stokes Ian > >>> > >>> Subject: Re: [dpd

Re: [dpdk-dev] [PATCH v3 1/3] lib/ring: add peek API

2019-10-03 Thread Honnappa Nagarahalli
> > Subject: [PATCH v3 1/3] lib/ring: add peek API > > > > From: Ruifeng Wang > > > > The peek API allows fetching the next available object in the ring > > without dequeuing it. This helps in scenarios where dequeuing of > > objects depend on their value. > > > > Signed-off-by: Dharmik Thakkar >

Re: [dpdk-dev] [PATCH 01/13] ethdev: support setup function for hairpin queue

2019-10-03 Thread Ray Kinsella
Hi On 26/09/2019 13:18, Andrew Rybchenko wrote: > On 9/26/19 9:28 AM, Ori Kam wrote: >> This commit introduce the RX/TX hairpin setup function. > > RX/TX should be Rx/Tx here and everywhere below. > >> Hairpin is RX/TX queue that is used by the nic in order to offload >> wire to wire traffic. >>

Re: [dpdk-dev] [PATCH] net/qede: only access sw rx ring index for debug

2019-10-03 Thread Rasesh Mody
>From: dev On Behalf Of Jerin Jacob >Sent: Thursday, October 03, 2019 7:40 AM > >On Fri, Sep 27, 2019 at 4:59 PM David Marchand > wrote: >> >> Caught by clang, this idx value is only used for a debug message when >> the mbufs allocation fails. >> No need to use idx as a temporary storage. >> >> Fi

Re: [dpdk-dev] [PATCH] net/qede: only access sw rx ring index for debug

2019-10-03 Thread Rasesh Mody
>From: David Marchand >Sent: Friday, September 27, 2019 4:29 AM > >-- >Caught by clang, this idx value is only used for a debug message when the >mbufs allocation fails. >No need to use idx as a temporary storage. > >Fixes: 8f2312

Re: [dpdk-dev] [PATCH 01/13] ethdev: support setup function for hairpin queue

2019-10-03 Thread Ori Kam
Hi Andrew, @Thomas Monjalon, @Ferruh Yigit Please comment if you have any issues with my answer. Thanks, Ori > -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 3, 2019 4:26 PM > To: Ori Kam ; Thomas Monjalon > ; Ferruh Yigit > Cc: dev@dpdk.org; jingjing...@intel.c

Re: [dpdk-dev] [PATCH v8 1/7] ethdev: add set ptype function

2019-10-03 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Andrew Rybchenko >Sent: Thursday, October 3, 2019 1:11 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; John McNamara >; Marko Kovacevic >; Thomas Monjalon >; Ferruh Yigit >Cc: dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH v8

Re: [dpdk-dev] [PATCH v5 4/4] examples/ipsec-secgw: add offload fallback tests

2019-10-03 Thread Iremonger, Bernard
Hi Marcin, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marcin Smoczynski > Sent: Friday, September 27, 2019 4:55 PM > To: ano...@marvell.com; akhil.go...@nxp.com; Ananyev, Konstantin > > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [dpdk-dev] [PATCH v5

Re: [dpdk-dev] [PATCH v5 2/4] examples/ipsec-secgw: add fallback session feature

2019-10-03 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marcin Smoczynski > Sent: Friday, September 27, 2019 4:55 PM > To: ano...@marvell.com; akhil.go...@nxp.com; Ananyev, Konstantin > > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [dpdk-dev] [PATCH v5 2/4] exam

Re: [dpdk-dev] [PATCH v5 1/4] examples/ipsec-secgw: ipsec_sa structure cleanup

2019-10-03 Thread Iremonger, Bernard
Hi Marcin, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marcin Smoczynski > Sent: Friday, September 27, 2019 4:55 PM > To: ano...@marvell.com; akhil.go...@nxp.com; Ananyev, Konstantin > > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [dpdk-dev] [PATCH v5

Re: [dpdk-dev] [PATCH] net/octeontx2: extract nvgre as ltype

2019-10-03 Thread Jerin Jacob
On Wed, Sep 11, 2019 at 2:49 PM wrote: > > From: Kiran Kumar K > > Adding change to sync RTE Flow with KPU profile to extract > NVGRE as ltype. > > Signed-off-by: Kiran Kumar K Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > drivers/net/octeontx2/otx2_flow_parse.

Re: [dpdk-dev] [PATCH v3] net/octeontx2: add tx desc status dev ops

2019-10-03 Thread Jerin Jacob
On Fri, Sep 6, 2019 at 6:13 PM wrote: > > From: Kiran Kumar K > > Adding support for tx descriptor status dev ops for octeontx2. > > Signed-off-by: Kiran Kumar K # Fixed check-git-log.sh issue(Subject changed to net/octeontx2: add Tx descriptor status op) # Tx descriptor status = Y update was m

Re: [dpdk-dev] DPDK Release Status Meeting 3/10/2019

2019-10-03 Thread Stephen Hemminger
On Thu, 3 Oct 2019 12:14:46 +0100 Ferruh Yigit wrote: > Open > > > * The time of the meeting is not good for the US timezone, we talked about > changing the time of the meeting but not had enough time to discuss it. > If you have any preferences, please comment. In the past (at OSDL) w

Re: [dpdk-dev] [PATCH] net/octeontx2: use updated LB ltypes

2019-10-03 Thread Jerin Jacob
On Sun, Sep 29, 2019 at 9:59 AM Vivek Kumar Sharma wrote: > > Ping! > > > Thanks, > Vivek > > > From: viveksha...@marvell.com > Sent: 06 September 2019 05:43 > To: dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran; Vivek Kumar Sharma > Subject: [PATCH] net/octe

Re: [dpdk-dev] [PATCH 0/2] use pkg-config to find Netcope dependencies

2019-10-03 Thread Ferruh Yigit
On 9/14/2019 10:36 AM, Thomas Monjalon wrote: > The libraries required for Netcope PMDs can be found in > https://www.netcope.com/en/company/community-support/dpdk-libsze2 > > These libraries are compatible with pkg-config, which is a better solution > than directly looking for libraries and inclu

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-10-03 Thread Ananyev, Konstantin
Hi everyone, > > On Thu, Oct 3, 2019 at 6:21 PM Thomas Monjalon wrote: > > > > 03/09/2019 12:59, jer...@marvell.com: > > > Added eBPF arm64 JIT support to improve the eBPF program performance > > > on arm64. > > > > > > lib/librte_bpf/bpf_jit_arm64.c | 1451 > >

Re: [dpdk-dev] [PATCH] net/octeontx2: allow vfs to enable back pressure

2019-10-03 Thread Jerin Jacob
On Fri, Aug 30, 2019 at 9:35 AM Nithin Dabilpuram wrote: > > Allow VFs to enable backpressure for performance reasons. > The backpressure control is with kernel AF driver that will enable > backpressure even if one PF/VF requests it and disable it only > after all the PFs/VFs request for disable.

Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless

2019-10-03 Thread Shally Verma
Sent from Workspace ONE Boxer On 03-Oct-2019 7:58 PM, Akhil Goyal wrote: > > Hi Shally, > > Any more comments on this patch. > If not please Ack. > > Regards, > Akhil > > > -Original Message- > > From: Shally Verma > > Sent: Sunday, September 8, 2019 11:49 AM > > To: Arek Kusztal ; dev@

Re: [dpdk-dev] [PATCH v3 0/3] add fallback session

2019-10-03 Thread Ananyev, Konstantin
Hi Anoob, > > > > > I've few more observations regarding the proposed feature. > > > > > > > > > > 1. From what I understood, if an ESP packet ends up on an > > > > > unprotected interface and doesn't have 'PKT_RX_SEC_OFFLOAD' bit > > > > > set, then the packet > > > > would be looked up to see th

Re: [dpdk-dev] [PATCH] net/qede: only access sw rx ring index for debug

2019-10-03 Thread Jerin Jacob
On Fri, Sep 27, 2019 at 4:59 PM David Marchand wrote: > > Caught by clang, this idx value is only used for a debug message when > the mbufs allocation fails. > No need to use idx as a temporary storage. > > Fixes: 8f2312474529 ("net/qede: fix performance bottleneck in Rx path") > Cc: sta...@dpdk.o

Re: [dpdk-dev] [PATCH] drivers/octeontx2: fix parser error to ol_flags translation

2019-10-03 Thread Jerin Jacob
On Thu, Oct 3, 2019 at 12:03 PM Sunil Kumar Kori wrote: > > NPC errors were incorrectly translated to ol_flag as > error code enum was not in sync with NPC profile. > > Fixes: 371d3212cbed ("common/octeontx2: add build infrastructure and HW > definition") > > Signed-off-by: Sunil Kumar Kori Cha

Re: [dpdk-dev] [PATCH] common/cpt: add support for new firmware

2019-10-03 Thread Akhil Goyal
> > Hi Akhil, Pablo, > > From my end, this patch is good to go. > > Thanks, > Anoob > > > -Original Message- > > From: Anoob Joseph > > Sent: Wednesday, August 14, 2019 3:11 PM > > To: Akhil Goyal ; Pablo de Lara > > > > Cc: Ankur Dwivedi ; Jerin Jacob Kollanukkaran > > ; Narayana Pra

Re: [dpdk-dev] [PATCH v2 00/20] bnxt patchset to improve rte flow support

2019-10-03 Thread Ferruh Yigit
On 10/3/2019 12:25 AM, Ajit Khaparde wrote: > Among other changes, this patchset adds support to: > - create filters with RSS action. > - create source MAC filters. > - use user provided priority to place rule appropriately in HW. > > This patch has been rebased to dpdk-next-net commit > 8587a8b9e

Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless

2019-10-03 Thread Akhil Goyal
Hi Shally, Any more comments on this patch. If not please Ack. Regards, Akhil > -Original Message- > From: Shally Verma > Sent: Sunday, September 8, 2019 11:49 AM > To: Arek Kusztal ; dev@dpdk.org > Cc: Akhil Goyal ; fiona.tr...@intel.com; Anoob Joseph > > Subject: RE: [EXT] [PATCH v2]

Re: [dpdk-dev] [PATCH] cryptodev: fix pmd allocation on multi-process

2019-10-03 Thread Akhil Goyal
> > > > Primary process is responsible to initialize the data struct of each > > crypto devices. > > > > Secondary process should not override this data during the > > initialization. > > > > Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto > > devices") > > Cc: sta...@d

Re: [dpdk-dev] [PATCH 2/2] test/crypto: add negative test support for dpaaX

2019-10-03 Thread Akhil Goyal
> > Signed-off-by: Hemant Agrawal > --- > app/test/test_cryptodev.c | 20 > 1 file changed, 20 insertions(+) > Added description of the patch and altered patch title. Patchset Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-10-03 Thread Kevin Traynor
On 26/09/2019 08:41, Yu, PingX wrote: > Kevin, > FYi. >> 2. [dpdk-stable 18.11.3] meson build error on ub1604-i86 > Q1: What are the error logs? > Please see below Error info. > > Q2: Is it a regression for you? i.e. did this test pass with 18.11.2? > No, it isn't a regression. We don't test it

Re: [dpdk-dev] [PATCH 01/13] ethdev: support setup function for hairpin queue

2019-10-03 Thread Andrew Rybchenko
Hi Ori, @Thomas, @Ferruh, please, see question below. On 10/2/19 3:19 PM, Ori Kam wrote: Hi Andrew, Sorry it took me some time to responded, (I'm on vacation 😊) I think we are in most cases in agreement. The only open issue is the checks so please see my comments below. As soon as we get to un

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-03 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > > > > > > > > > > > > This action type allows the burst of symmetric > > > > > > > > > > > > > > crypto > > > workload > > > > > using > > > > > > > > the > > > > > > > > > > > > same > > > > > > > > > > > > > > algorithm, key, and direction being processed

Re: [dpdk-dev] [PATCH v2 2/3] net/af_xdp: support pinning of IRQs

2019-10-03 Thread Loftus, Ciara
> -Original Message- > From: Stephen Hemminger > Sent: Monday 30 September 2019 18:12 > To: Loftus, Ciara > Cc: dev@dpdk.org; Ye, Xiaolong ; Laatz, Kevin > ; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v2 2/3] net/af_xdp: support pinning of IRQs > > On Mon, 30 Sep 2019 16:42:0

[dpdk-dev] 18.11.3 (LTS) patches review and test

2019-10-03 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for LTS release 18.11.3. The planned date for the final release is 14th October. Please note the commits since RC1 below. They are primarily to address some build issues for 32-bit with meson and FreeBSD. As such, I would expect that most RC1 testing i

[dpdk-dev] [PATCH 5/6] examples/load_balancer: remove example from DPDK

2019-10-03 Thread Bruce Richardson
From: Ciara Power This example can be removed because DPDK now has a range of libraries, especially rte_eventdev, that did not exist previously for load balancing, making this less relevant. Also, modern NIC cards have greater ability to do load balancing, e.g. using RSS, over a wider range of f

[dpdk-dev] [PATCH 6/6] doc: close up gaps in sample app guide table

2019-10-03 Thread Bruce Richardson
Following the removal of some sample applications, close up the gaps introduced in the table so that it is formatted nicely for the next release. Signed-off-by: Bruce Richardson --- doc/guides/sample_app_ug/intro.rst | 30 +- 1 file changed, 13 insertions(+), 17 delet

[dpdk-dev] [PATCH 4/6] examples/netmap-compat: remove example from DPDK

2019-10-03 Thread Bruce Richardson
From: Ciara Power Rather than providing a shim layer on top of netmap, we should instead encourage users to create apps using the DPDK APIs directly. Signed-off-by: Ciara Power --- MAINTAINERS | 3 - doc/guides/sample_app_ug/index.rst| 1 - doc

[dpdk-dev] [PATCH 3/6] examples/quota-watermark: remove example from DPDK

2019-10-03 Thread Bruce Richardson
From: Ciara Power Original DPDK rings code had explicit support for a single watermark per-ring, but more recent releases of DPDK had a more general mechanism where each enqueue or dequeue call could return the remaining elements/free-slots in the ring. Therefore, this example is not as relevant

[dpdk-dev] [PATCH 1/6] examples/exception_path: remove example from DPDK

2019-10-03 Thread Bruce Richardson
The example app shows the use of TUN/TAP with DPDK, but DPDK has a built-in TAP PMD, so this example is obsolete and so can be removed. Signed-off-by: Bruce Richardson --- MAINTAINERS | 3 - doc/guides/sample_app_ug/exception_path.rst | 281 -- doc/guide

[dpdk-dev] [PATCH 0/6] remove a few example applications

2019-10-03 Thread Bruce Richardson
As discussed by the DPDK technical board e.g. [1][2] and on the DPDK mailing list [3], we have a lot of example applications shipped with DPDK - a number which increases with each DPDK release, and not all of which are probably needed any more. Therefore, this set removes 5 example applications fro

[dpdk-dev] [PATCH 2/6] examples/l3fwd-vf: remove example from DPDK

2019-10-03 Thread Bruce Richardson
The main l3fwd app should work with both PF and VF devices, so remove the VF-only l3fwd example. Signed-off-by: Bruce Richardson --- MAINTAINERS |3 - doc/guides/sample_app_ug/index.rst|1 - .../sample_app_ug/l3_forward_virtual.rst | 9

Re: [dpdk-dev] [PATCH v2 00/20] bnxt patchset to improve rte flow support

2019-10-03 Thread Ferruh Yigit
On 10/3/2019 12:25 AM, Ajit Khaparde wrote: > Among other changes, this patchset adds support to: > - create filters with RSS action. > - create source MAC filters. > - use user provided priority to place rule appropriately in HW. > > This patch has been rebased to dpdk-next-net commit > 8587a8b9e

Re: [dpdk-dev] [PATCH v2 17/20] net/bnxt: drop untagged frames when specified

2019-10-03 Thread Ferruh Yigit
On 10/3/2019 12:25 AM, Ajit Khaparde wrote: > When a drop action for L2 filters is specified, support it. > > Signed-off-by: Ajit Khaparde > Reviewed-by: Rahul Gupta > Reviewed-by: Somnath Kotur > Reviewed-by: Kalesh Anakkur Purayil <...> > @@ -1121,19 +1152,27 @@ bnxt_validate_and_parse_flo

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-10-03 Thread Jerin Jacob
On Thu, Oct 3, 2019 at 6:21 PM Thomas Monjalon wrote: > > 03/09/2019 12:59, jer...@marvell.com: > > Added eBPF arm64 JIT support to improve the eBPF program performance > > on arm64. > > > > lib/librte_bpf/bpf_jit_arm64.c | 1451 > > I am concerned about duplicatin

Re: [dpdk-dev] [PATCH v2 3/3] crypto/qat: handle Single Pass Crypto Requests on GEN3 QAT

2019-10-03 Thread Trahe, Fiona
Hi Adam, > -Original Message- > From: Dybkowski, AdamX > Sent: Friday, September 27, 2019 4:48 PM > To: dev@dpdk.org; Trahe, Fiona ; Kusztal, ArkadiuszX > ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 3/3] crypto/qat: handle Single Pass Crypto Requests on > GEN3 QAT >

Re: [dpdk-dev] [PATCH v1 1/3] lib/ethdev: add ethdev op to get hash index

2019-10-03 Thread Andrew Rybchenko
Hi, On 9/14/19 8:52 AM, vattun...@marvell.com wrote: From: Vamsi Attunuru Some networking devices may use custom algos for computing hash indices and spread the packets accordingly. Patch adds a eth_dev op to get the hash index correspond to the given hash value received on the given port. S

Re: [dpdk-dev] [PATCH v2 2/3] common/qat: add new QAT GEN3 definitions

2019-10-03 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Friday, September 27, 2019 4:48 PM > To: dev@dpdk.org; Trahe, Fiona ; Kusztal, ArkadiuszX > ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 2/3] common/qat: add new QAT GEN3 definitions > > This patch adds few defi

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-10-03 Thread Thomas Monjalon
03/09/2019 12:59, jer...@marvell.com: > Added eBPF arm64 JIT support to improve the eBPF program performance > on arm64. > > lib/librte_bpf/bpf_jit_arm64.c | 1451 I am concerned about duplicating the BPF JIT effort in DPDK and Linux. Could we try to pull the Linu

Re: [dpdk-dev] [PATCH] cryptodev: fix invalid dev_id after a pmd close

2019-10-03 Thread Akhil Goyal
Hi Julien > > Each cryptodev are indexed with its dev_id in the global > rte_crypto_devices variable. nb_devs is incremented / decremented each > time a cryptodev is created / deleted. The goal of nb_devs is to prevent > the user to get an invalid dev_id. > > Let's imagine DPDK has configured N

Re: [dpdk-dev] [PATCH v5 00/10] example/l2fwd-event: introduce l2fwd-event example

2019-10-03 Thread Jerin Jacob
On Thu, Oct 3, 2019 at 6:10 PM Hemant Agrawal wrote: > > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, October 3, 2019 4:04 PM > > To: Pavan Nikhilesh > > Cc: Jerin Jacob ; Richardson, Bruce > > ; Akhil Goyal ; dpdk- > > dev ; Van Haaren, Harry ; > > mattia

Re: [dpdk-dev] [PATCH v2 1/3] test/crypto: add more AES GCM tests for QAT PMD

2019-10-03 Thread Trahe, Fiona
Hi Adam, > -Original Message- > From: Dybkowski, AdamX > Sent: Friday, September 27, 2019 4:48 PM > To: dev@dpdk.org; Trahe, Fiona ; Kusztal, ArkadiuszX > ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 1/3] test/crypto: add more AES GCM tests for QAT PMD > > This patch

Re: [dpdk-dev] [PATCH v5 00/10] example/l2fwd-event: introduce l2fwd-event example

2019-10-03 Thread Hemant Agrawal
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Thursday, October 3, 2019 4:04 PM > To: Pavan Nikhilesh > Cc: Jerin Jacob ; Richardson, Bruce > ; Akhil Goyal ; dpdk- > dev ; Van Haaren, Harry ; > mattias.ronnb...@ericsson.com; liang.j...@intel.com; Gujjar, Abhinandan > S ; Rao

Re: [dpdk-dev] [PATCH v2 20/20] net/bnxt: handle flow flush handling

2019-10-03 Thread Ferruh Yigit
On 10/3/2019 12:26 AM, Ajit Khaparde wrote: > We are not freeing all the flows when a flow_flush is called. > Iterate through all the flows belonging to all the VNICs in use and > free the filters. For the patch title "handle flow flush handling", I think here 'handle' means fixing the "flow flush

Re: [dpdk-dev] [PATCH 2/5] lib/ring: add template to support different element sizes

2019-10-03 Thread Ananyev, Konstantin
> > > > > > > +++ b/lib/librte_ring/rte_ring_template.h > > > > > > @@ -0,0 +1,330 @@ > > > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > > > + * Copyright (c) 2019 Arm Limited */ > > > > > > + > > > > > > +#ifndef _RTE_RING_TEMPLATE_H_ > > > > > > +#define _RTE_RING_TEMPLATE_H_ > > >

Re: [dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

2019-10-03 Thread Ananyev, Konstantin
Hi Honnappa, > > > Add resource reclamation APIs to make it simple for applications and > > > libraries to integrate rte_rcu library. > > > > > > Signed-off-by: Honnappa Nagarahalli > > > Reviewed-by: Ola Liljedhal > > > Reviewed-by: Ruifeng Wang > > > --- > > > app/test/test_rcu_qsbr.c

Re: [dpdk-dev] [PATCH] net: re-add qede to meson

2019-10-03 Thread Ferruh Yigit
On 10/3/2019 9:38 AM, Jerin Jacob wrote: > On Thu, Oct 3, 2019 at 1:48 PM David Marchand > wrote: >> >> qede has been dropped from the drivers/net meson. >> Add it again. >> >> Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure") >> >> Signed-off-by: David Marchand > > Review

Re: [dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

2019-10-03 Thread Ananyev, Konstantin
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Thursday, October 3, 2019 7:42 AM > To: Ananyev, Konstantin ; > step...@networkplumber.org; paul...@linux.ibm.com > Cc: Wang, Yipeng1 ; Medvedkin, Vladimir > ; Ruifeng Wang (Arm Technology >

Re: [dpdk-dev] [PATCH 2/5] lib/ring: add template to support different element sizes

2019-10-03 Thread Ananyev, Konstantin
> > > > > +++ b/lib/librte_ring/rte_ring_template.h > > > > > @@ -0,0 +1,330 @@ > > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > > + * Copyright (c) 2019 Arm Limited */ > > > > > + > > > > > +#ifndef _RTE_RING_TEMPLATE_H_ > > > > > +#define _RTE_RING_TEMPLATE_H_ > > > > > + > > > > >

[dpdk-dev] [PATCH v9 0/3] extend RSS offload types

2019-10-03 Thread Simei Su
[PATCH v9 1/3] ethdev: decouple flow types and RSS offload types. [PATCH v9 2/3] ethdev: add several bits for extending rss offload types. [PATCH v9 3/3] app/testpmd: add cmdline support for extending rss types. v9: * Fix code style. * Delete duplicate logic in rte_eth_dev_configure(). v8: * Add

[dpdk-dev] [PATCH v9 1/3] ethdev: decouple flow types and RSS offload types

2019-10-03 Thread Simei Su
This patch decouples RTE_ETH_FLOW_* and ETH_RSS_*. The former defines flow types and the latter defines RSS offload types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 49 ---

[dpdk-dev] [PATCH v9 3/3] app/testpmd: add RSS offload types extending support

2019-10-03 Thread Simei Su
This patch adds cmdline support for extended rss types configuration. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- app/test-pmd/cmdline.c | 18 +++--- app/test-pmd/config.c | 4 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/

[dpdk-dev] [PATCH v9 2/3] ethdev: extend RSS offload types

2019-10-03 Thread Simei Su
This patch reserves several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent RSS types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam --- lib/librte_ethdev/rte_ethdev.c | 11 +++ lib/librte_ethdev/rte_e

Re: [dpdk-dev] [PATCH v2 00/30] Enhancements and fixes in NXP dpaax drivers and fsl-mc bus

2019-10-03 Thread Ferruh Yigit
On 8/29/2019 11:27 AM, Sachin Saxena wrote: > This patch set adds following enhancements: > 1. IEEE1588 support in net/dpaa2 > 2. Interrupt support in net/dpaa > 3. Support multi vfio group in fsl-mc bus > 4. Taildrop support on frame count basis > 5. Soft parser drive

[dpdk-dev] DPDK Release Status Meeting 3/10/2019

2019-10-03 Thread Ferruh Yigit
Minutes 3 October 2019 -- Agenda: * Release Dates * Subtrees * OvS * Opens Participants: * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v19.11 dates: * Integration/Merge/RC1 date pushed to *Wednesday 23 October* * Sub-tre

Re: [dpdk-dev] [PATCH 8/9] event/opdl: remove commented out code

2019-10-03 Thread Liang, Ma
On 01 Oct 14:04, Kevin Traynor wrote: > Some variables are commented out. Remove them. > > Fixes: d548ef513cd7 ("event/opdl: add unit tests") > Cc: liang.j...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Kevin Traynor > --- > drivers/event/opdl/opdl_test.c | 3 --- > 1 file changed, 3 del

Re: [dpdk-dev] [PATCH] devtools: reset compilation flags for each target

2019-10-03 Thread Bruce Richardson
On Thu, Oct 03, 2019 at 12:08:30PM +0200, David Marchand wrote: > On Thu, Oct 3, 2019 at 11:21 AM Bruce Richardson > wrote: > > > > On Wed, Oct 02, 2019 at 06:55:47PM +0200, David Marchand wrote: > > > Same idea than overriding PATH and PKG_CONFIG_PATH, it can be quite > > > useful to override com

Re: [dpdk-dev] [PATCH v5 00/10] example/l2fwd-event: introduce l2fwd-event example

2019-10-03 Thread Jerin Jacob
On Thu, Oct 3, 2019 at 2:28 AM wrote: > > From: Pavan Nikhilesh > > This patchset adds a new application to demonstrate the usage of event > mode. The poll mode is also available to help with the transition. > > The following new command line parameters are added: > --mode: Dictates the mode of

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-03 Thread Jerin Jacob
On Thu, Oct 3, 2019 at 12:15 PM Hemant Agrawal wrote: > > Hi Nikhil, > > > -Original Message- > > From: Rao, Nikhil > > Sent: Thursday, October 3, 2019 11:43 AM > > > > > > On Wed, Oct 2, 2019 at 8:38 AM Hemant Agrawal > > > > > wrote: > > > > > > > > Hi Jerin, > > > > > > Hi Hemant, > >

Re: [dpdk-dev] [PATCH] devtools: reset compilation flags for each target

2019-10-03 Thread David Marchand
On Thu, Oct 3, 2019 at 11:21 AM Bruce Richardson wrote: > > On Wed, Oct 02, 2019 at 06:55:47PM +0200, David Marchand wrote: > > Same idea than overriding PATH and PKG_CONFIG_PATH, it can be quite > > useful to override compilation flags like CFLAGS, CPPFLAGS and LDFLAGS > > for cross compilation o

Re: [dpdk-dev] [PATCH v6 0/6] examples/ioat: sample app on ioat driver usage

2019-10-03 Thread Bruce Richardson
On Mon, Sep 30, 2019 at 09:50:28AM +0200, Marcin Baran wrote: > A new sample app demonstrating use of driver for CBDMA. > The app receives packets, performs software or hardware > copy, changes packets' MAC addresses (if enabled) and > forwards them. The patch includes sample application as > well

Re: [dpdk-dev] [PATCH v2 04/30] bus/dpaa: decouple fq portal alloc and init

2019-10-03 Thread Nipun Gupta
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 3, 2019 1:23 PM > To: Sachin Saxena ; dev@dpdk.org > Cc: tho...@monjalon.net; Nipun Gupta > Subject: Re: [dpdk-dev] [PATCH v2 04/30] bus/dpaa: decouple fq portal alloc > and > init > > On 8/29/2019 11:27 AM, Sachin Sa

  1   2   >