[dpdk-dev] [PATCH v1] app/testpmd: fix CRC strip config error

2019-10-11 Thread Ting Xu
This patch fixed the bug that an error appears when config rx_offload crc_strip using command "port config all crc-strip on|off". The reason is that this command was removed previously. However, the current command does not enable "crc_strip" option properly, so that testpmd returns error when conf

[dpdk-dev] [PATCH v2 2/2] test/distributor: fix false unit test failure

2019-10-11 Thread Ruifeng Wang
Sanity test could spuriously fail with reporting flush count error. It was caused by worker stat coherent issue between distributor and worker thread. Fix this issue by using atomic operations to update worker stat. Fixes: c3eabff124e6 ("distributor: add unit tests") Cc: sta...@dpdk.org Signed-of

[dpdk-dev] [PATCH v2 1/2] lib/distributor: fix deadlock issue for aarch64

2019-10-11 Thread Ruifeng Wang
Distributor and worker threads rely on data structs in cache line for synchronization. The shared data structs were not protected. This caused deadlock issue on weaker memory ordering platforms as aarch64. Fix this issue by adding memory barriers to ensure synchronization among cores. Bugzilla ID:

[dpdk-dev] [PATCH v2 0/2] fix distributor unit test

2019-10-11 Thread Ruifeng Wang
Bug 342 reported distributor_autotest execution suspension on aarch64 platform. Issue was due to lack of synchronization among threads. Distributor thread and worker thread may get deadlocked. Fixed synchronization issue by adding barriers. Another issue identified was in test case. Non-atomic ope

[dpdk-dev] [PATCH v1] doc: update cross build tool links and fix compiling issue

2019-10-11 Thread Joyce Kong
Update cross build tool links as newer cross build tools version are provided on Linaro. And remove the command 'git checkout' which results in compiling error when cross building. Fixes: 01add9da25cd ("doc: add cross compiling guide") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong --- doc/guide

[dpdk-dev] [PATCH 16/17] net/ionic: add TX checksum support

2019-10-11 Thread Alfredo Cardigliano
Add support for TX checksumming. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_ethdev.c |5 ++ drivers/net/ionic/ionic_lif.c|1 drivers/net/ionic/ionic_lif.h|1 drivers/net/ionic/ionic_rxtx.c | 86 +++

[dpdk-dev] [PATCH 17/17] net/ionic: read fw version

2019-10-11 Thread Alfredo Cardigliano
Add support for reading the firmware version. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |1 + drivers/net/ionic/ionic.h |1 + drivers/net/ionic/ionic_dev.c |8 drivers/net/ionic/ionic_ethdev.c | 2

[dpdk-dev] [PATCH 15/17] net/ionic: add stats

2019-10-11 Thread Alfredo Cardigliano
Add basic, per queue and extended statistics for RX and TX, both from the adapter and the driver. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |3 drivers/net/ionic/ionic_ethdev.c | 253 driver

[dpdk-dev] [PATCH 10/17] net/ionic: add basic port operations

2019-10-11 Thread Alfredo Cardigliano
Add support for port start/stop and handle basic features including mtu and link up/down. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |4 drivers/net/ionic/ionic.h |1 drivers/net/ionic/ionic_dev.h |3 driver

[dpdk-dev] [PATCH 09/17] net/ionic: add notifyq support

2019-10-11 Thread Alfredo Cardigliano
Add support for the notify queue, which is used for events published by the NIC. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h|2 drivers/net/ionic/ionic_ethdev.c | 97 +++ drivers/net/ionic/ionic_lif.c| 192

[dpdk-dev] [PATCH 14/17] net/ionic: add RX and TX handling

2019-10-11 Thread Alfredo Cardigliano
Add RX and TX queues setup and handling. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 10 drivers/net/ionic/Makefile |1 drivers/net/ionic/ionic_dev.h |1 drivers/net/ionic/ionic_ethdev.c | 114 drivers

[dpdk-dev] [PATCH 13/17] net/ionic: add RSS support

2019-10-11 Thread Alfredo Cardigliano
Add code to manipulate the RSS configuration used by the adapter. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |3 + drivers/net/ionic/ionic_ethdev.c | 175 drivers/net/ionic/ionic_ethdev.h |

[dpdk-dev] [PATCH 11/17] net/ionic: add RX filters support

2019-10-11 Thread Alfredo Cardigliano
Add support for managing RX filters based on MAC and VLAN. Hardware cannot provide the list of filters, thus we keep a local list. Add support for promisc and allmulticast modes. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |4 + dri

[dpdk-dev] [PATCH 12/17] net/ionic: net-ionic-add-flow-control-support

2019-10-11 Thread Alfredo Cardigliano
Add support for managing Flow Control. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |1 + drivers/net/ionic/ionic_ethdev.c | 56 2 files changed, 57 insertions(+) diff --git a/doc/guides/nics/

[dpdk-dev] [PATCH 07/17] net/ionic: add doorbells

2019-10-11 Thread Alfredo Cardigliano
Doorbell registers are used by the driver to signal to the NIC that requests are waiting on the message queues. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_dev.c | 15 +++ drivers/net/ionic/ionic_dev.h | 19 +++ driv

[dpdk-dev] [PATCH 06/17] net/ionic: add basic lif support

2019-10-11 Thread Alfredo Cardigliano
Initialize LIFs (Logical Interfaces) which represents external connections. The NIC can multiplex many LIFs to a single port, but in most setups, LIF0 is the primary control for the port. Create a device for each LIF. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/ne

[dpdk-dev] [PATCH 08/17] net/ionic: add adminq support

2019-10-11 Thread Alfredo Cardigliano
Add support for the admin queue, which is used for most of the NIC configurations. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h |4 drivers/net/ionic/ionic_dev.c | 256 + drivers/net/ionic/ionic_dev.h | 9

[dpdk-dev] [PATCH 04/17] net/ionic: register and initialize the adapter

2019-10-11 Thread Alfredo Cardigliano
Register the Pensando ionic PMD (net_ionic) and define initial probe and remove callbacks with adapter initialization. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |2 + drivers/net/ionic/Makefile |3 + drivers/net/ionic/i

[dpdk-dev] [PATCH 05/17] net/ionic: add port management commands

2019-10-11 Thread Alfredo Cardigliano
Add port management commands that apply to the physical ports associated with the PCI device, which might be shared among several logical interfaces. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h|6 ++ drivers/net/ionic/ionic_dev.c|

[dpdk-dev] [PATCH 03/17] net/ionic: add log

2019-10-11 Thread Alfredo Cardigliano
Add debug options to the config file. Define macros used for logs and make use of config file options to enable them. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- config/common_base |2 ++ drivers/net/ionic/Makefile |2 +- drivers/net/ionic/ioni

[dpdk-dev] [PATCH 01/17] net/ionic: add skeleton

2019-10-11 Thread Alfredo Cardigliano
Add makefile and config file options to compile the Pensando ionic PMD. Add feature and version map file. Update maintainers file. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- MAINTAINERS |6 +++ config/common_base

[dpdk-dev] [PATCH 00/17] Series short description

2019-10-11 Thread Alfredo Cardigliano
The patch series provides an initial version of a poll mode driver for Pensando network adapters. The driver name is ionic. --- Alfredo Cardigliano (17): net/ionic: add skeleton net/ionic: add hardware structures definitions net/ionic: add log net/ionic: register and initi

[dpdk-dev] [PATCH 02/17] net/ionic: add hardware structures definitions

2019-10-11 Thread Alfredo Cardigliano
Add hardware structures and message commands definitions for Pensando network adapters. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_if.h | 2491 ++ 1 file changed, 2491 insertions(+) create mode 100644 drive

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-10-11 Thread Kevin Traynor
On 11/10/2019 17:33, Ju-Hyoung Lee wrote: > Is there any other partners have done DPDK performance test with different OS > distro? There was a few other perf testings reported elsewhere in reply to this thread and there wasn't other perf drop reported. I only know the distro of the Red Hat testi

[dpdk-dev] [PATCH] rte_bus_pci: remove unneeded library dependency.

2019-10-11 Thread Seth Howell
The makefile in drivers/bus/pci specified rte_ethdev as a dependency for the library. However there are no actual symbols from librte_ethdev used in librte_bus_pci. Including librte_ethdev as a dependency only becomes a problem in some niche cases like when attempting to build the rte_bus_pci libr

Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build

2019-10-11 Thread Jerin Jacob
On Sat, 12 Oct, 2019, 1:44 AM Honnappa Nagarahalli, < honnappa.nagaraha...@arm.com> wrote: > On Sat, 12 Oct, 2019, 12:44 AM Honnappa Nagarahalli, < > honnappa.nagaraha...@arm.com> wrote: > > > > > > On Thu, 10 Oct, 2019, 10:17 AM Honnappa Nagarahalli, < > honnappa.nagaraha...@arm.com> wrote: > >

Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build

2019-10-11 Thread Honnappa Nagarahalli
On Sat, 12 Oct, 2019, 12:44 AM Honnappa Nagarahalli, mailto:honnappa.nagaraha...@arm.com>> wrote: On Thu, 10 Oct, 2019, 10:17 AM Honnappa Nagarahalli, mailto:honnappa.nagaraha...@arm.com>> wrote: On Mon, 7 Oct, 2019, 3:49 PM Jerin Jacob, mailto:jerinjac...@gmail.com>> wrote: On Sun, 6 Oct,

Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build

2019-10-11 Thread Jerin Jacob
On Sat, 12 Oct, 2019, 12:44 AM Honnappa Nagarahalli, < honnappa.nagaraha...@arm.com> wrote: > > > > > On Thu, 10 Oct, 2019, 10:17 AM Honnappa Nagarahalli, < > honnappa.nagaraha...@arm.com> wrote: > > > > > > On Mon, 7 Oct, 2019, 3:49 PM Jerin Jacob, wrote: > > > > On Sun, 6 Oct, 2019, 11:36 PM

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-11 Thread Honnappa Nagarahalli
Hi Bruce, Konstantin, Stephen, Appreciate if you could provide feedback on this. Thanks, Honnappa > -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, October 8, 2019 9:47 PM > To: olivier.m...@6wind.com; sthem...@microsoft.com; jer...@marvell.com; > bruce.richard..

Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build

2019-10-11 Thread Honnappa Nagarahalli
On Thu, 10 Oct, 2019, 10:17 AM Honnappa Nagarahalli, mailto:honnappa.nagaraha...@arm.com>> wrote: On Mon, 7 Oct, 2019, 3:49 PM Jerin Jacob, mailto:jerinjac...@gmail.com>> wrote: On Sun, 6 Oct, 2019, 11:36 PM Thomas Monjalon, mailto:tho...@monjalon.net>> wrote: 05/10/2019 17:28, Jerin Jacob:

Re: [dpdk-dev] [PATCH 10/10] crypto/dpaa_sec: code reorg for better session mgmt

2019-10-11 Thread Aaron Conole
Hemant Agrawal writes: > The session related parameters shall be populated during > the session create only. > At the runtime on first packet, the CDB should just reference > the session data instead of re-interpreting data again. > > Signed-off-by: Hemant Agrawal > --- As a part of this patch,

Re: [dpdk-dev] [PATCH v3 1/3] lib/ring: add peek API

2019-10-11 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > > > > > > > > Subject: [PATCH v3 1/3] lib/ring: add peek API > > > > > > > > > > > > > > > > From: Ruifeng Wang > > > > > > > > > > > > > > > > The peek API allows fetching the next available object in > > > > > > > > the ring without dequeuing it. This helps in s

[dpdk-dev] [PATCH v3 2/2] test/compress: unit test for stateless overflow recovery

2019-10-11 Thread Artur Trybula
Added unit test to check out-of-space recoverable feature. Signed-off-by: Artur Trybula --- app/test/test_compressdev.c | 261 +--- 1 file changed, 214 insertions(+), 47 deletions(-) diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c index d47

[dpdk-dev] [PATCH v3 0/2] Add overflow recovery for stateless compression

2019-10-11 Thread Artur Trybula
This patch adds out-of-space recoverable feature for stateless compression scenario to QuickAssist compressdev driver. Unit test was also created to verify the new feature. v3: - rebasing onto the recent master v2: - rebasing over the external mbufs Artur Trybula (2): compress/

[dpdk-dev] [PATCH v3 1/2] compress/qat: overflow catch for stateless compression

2019-10-11 Thread Artur Trybula
This patch adds out-of-space recoverable feature for stateless compression scenario to QuickAssist compressdev driver Signed-off-by: Artur Trybula --- drivers/compress/qat/qat_comp.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/compres

Re: [dpdk-dev] [PATCH v2] net/af_packet: improve Tx statistics accuracy

2019-10-11 Thread Musatescu, Flavia
On 10/10/2019 19:35, Stephen Hemminger wrote: On Thu, 10 Oct 2019 18:34:30 +0100 Flavia Musatescu wrote: When sendto call fails and ENOBUFS error is being set some of the packets are actually successfully transmitted. There is no available count of those packets, so in order to make the statis

[dpdk-dev] [PATCH v3] vhost: add support for large buffers

2019-10-11 Thread Flavio Leitner
The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the data fits into a buffer, then all data is copied and a single linear buffer is returned. Otherwise it allocates additional mbufs and chains them together to return a multiple segments mbuf. While that covers most use cases, it

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-10-11 Thread Luca Boccassi
+Christian from Canonical for the Ubuntu on Azure performance issue On Fri, 2019-10-11 at 16:33 +, Ju-Hyoung Lee wrote: > Is there any other partners have done DPDK performance test with > different OS distro? > I wonder if this is distro-specific or Azure-specific. > > Ju > > -Original

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix SAD selection logic

2019-10-11 Thread Ananyev, Konstantin
> > > > Ipsec-secgw example application fails to initialize when using default > > > > configuration file (ep0.cfg) in library mode (librte_ipsec enabled). > > > > > > > > The reason is that two of SP rules in ep0.cfg, one for IPv4 and one > > > > for IPv6, are using the same SPI number. When SA

[dpdk-dev] [PATCH 07/10] test/crypto: add test to test ESN like case

2019-10-11 Thread Hemant Agrawal
This patch add support for case when there is auth only header and auth only tailroom area. This simulates the cases of IPSEC ESN cases. This patch also enable the new test case for openssl, dpaaX platforms. Signed-off-by: Hemant Agrawal Signed-off-by: Vakul Garg --- app/test/test_cryptodev.c

[dpdk-dev] [PATCH 09/10] test/crypto: enable snow3G and zuc cases for dpaa

2019-10-11 Thread Hemant Agrawal
This patch add the snow and zuc cipher only and auth only cases support. Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index ec0473016.

[dpdk-dev] [PATCH 10/10] crypto/dpaa_sec: code reorg for better session mgmt

2019-10-11 Thread Hemant Agrawal
The session related parameters shall be populated during the session create only. At the runtime on first packet, the CDB should just reference the session data instead of re-interpreting data again. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 612 -

[dpdk-dev] [PATCH 08/10] crypto/dpaa_sec: add support for snow3G and ZUC

2019-10-11 Thread Hemant Agrawal
This patch add support for ZUC and SNOW 3G in non-PDCP offload mode. Signed-off-by: Hemant Agrawal --- doc/guides/cryptodevs/dpaa_sec.rst | 4 + doc/guides/cryptodevs/features/dpaa_sec.ini | 4 + drivers/crypto/dpaa_sec/dpaa_sec.c | 378 drivers/crypto/

[dpdk-dev] [PATCH 06/10] test/crypto: increase test cases support for dpaax

2019-10-11 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 132 -- 1 file changed, 113 insertions(+), 19 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 879b31ceb..c4c730495 100644 --- a/app/test/test_cryptodev.c +++ b/

[dpdk-dev] [PATCH 05/10] crypto/dpaa2_sec: add support of auth trailer in cipher-auth

2019-10-11 Thread Hemant Agrawal
From: Vakul Garg This patch adds support of auth-only data trailing after cipher data. Signed-off-by: Vakul Garg --- drivers/crypto/caam_jr/caam_jr.c| 24 +-- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 17 +- drivers/crypto/dpaa2_sec/hw/desc/ipsec.h| 167 --

[dpdk-dev] [PATCH 04/10] crypto/dpaa2_sec: enhance gcm descs to not skip aadt

2019-10-11 Thread Hemant Agrawal
From: Vakul Garg The GCM descriptors needlessly skip auth_only_len bytes from output buffer. Due to this, workarounds have to be made in dpseci driver code. Also this leads to failing of one cryptodev test case for gcm. In this patch, we change the descriptor construction and adjust dpseci driver

[dpdk-dev] [PATCH 02/10] crypto/dpaa2_sec: fix ipv6 support

2019-10-11 Thread Hemant Agrawal
HW PDB Option was being overwritten. Fixes: 53982ba2805d ("crypto/dpaa2_sec: support IPv6 tunnel for protocol offload") Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/dpaa2_se

[dpdk-dev] [PATCH 03/10] crypto/dpaa_sec: fix to check for aead as well

2019-10-11 Thread Hemant Agrawal
From: Vakul Garg The code shall also check aead as non auth-cipher case Fixes: 1f14d500bce1 ("crypto/dpaa_sec: support IPsec protocol offload") Cc: sta...@dpdk.org Signed-off-by: Vakul Garg --- drivers/crypto/dpaa_sec/dpaa_sec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[dpdk-dev] [PATCH 01/10] test/crypto: fix PDCP test support

2019-10-11 Thread Hemant Agrawal
use session_priv_mpool instead of session pool Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases") Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev

[dpdk-dev] [PATCH 00/10] NXP DPAAx crypto fixes

2019-10-11 Thread Hemant Agrawal
This patch series largely content 1. fixes in crypto drivers 2. supprot ESN like cases 3. enabling snow/ZUC for dpaa_sec Hemant Agrawal (7): test/crypto: fix PDCP test support crypto/dpaa2_sec: fix ipv6 support test/crypto: increase test cases support for dpaax test/crypto: add test to tes

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-10-11 Thread Ju-Hyoung Lee
Is there any other partners have done DPDK performance test with different OS distro? I wonder if this is distro-specific or Azure-specific. Ju -Original Message- From: Abhishek Marathe Sent: Friday, October 11, 2019 9:30 AM To: Kevin Traynor ; sta...@dpdk.org Cc: dev@dpdk.org; Akhil G

Re: [dpdk-dev] [PATCH v2 8/9] net/qede/base: update the FW to 8.40.25.0

2019-10-11 Thread Rasesh Mody
>From: Ferruh Yigit >Sent: Friday, October 11, 2019 9:14 AM > >On 10/6/2019 9:14 PM, Rasesh Mody wrote: >> This patch updates the FW to 8.40.25.0 and corresponding base driver >> changes. It also updates the PMD version to 2.11.0.1. The FW updates >> consists of enhancements and fixes as described

Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU

2019-10-11 Thread Ferruh Yigit
On 9/19/2019 12:22 PM, Igor Ryzhov wrote: > Starting with kernel version 4.10, there are new min/max MTU values in > net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by > default. We should be able to change these values to allow MTU more than > 1500 to be set on KNI. > > Signed

Re: [dpdk-dev] [PATCH v2 8/9] net/qede/base: update the FW to 8.40.25.0

2019-10-11 Thread Ferruh Yigit
On 10/6/2019 9:14 PM, Rasesh Mody wrote: > This patch updates the FW to 8.40.25.0 and corresponding base driver > changes. It also updates the PMD version to 2.11.0.1. The FW updates > consists of enhancements and fixes as described below. > > - VF RX queue start ramrod can get stuck due to compl

Re: [dpdk-dev] [PATCH v3] net/bonding: fix selection logic

2019-10-11 Thread Chas Williams
This looks better. While reviewing this I noticed that a few lines: case AGG_STABLE: if (default_slave == slaves_count) new_agg_id = slave_id; < else new_agg_id = slaves[default_slave];

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

2019-10-11 Thread Thomas Monjalon
11/10/2019 14:40, Akhil Goyal: > Hi All, > > This patchset would need ack from more vendors as it will impact user > experience > on a key example application which is normally demonstrated to customers. > > IPSec library is still evolving and there are new functionality added every > release.

Re: [dpdk-dev] [PATCH v6 3/3] vhost: prevent zero copy mode if iommu is on

2019-10-11 Thread Maxime Coquelin
On 10/9/19 1:54 PM, Adrian Moreno wrote: > The simultaneous use of dequeue_zero_copy and IOMMU is problematic. > Not only because IOVA_VA mode is not supported but also because the > potential invalidation of guest pages while the buffers are in use, > is not handled. > > Prevent these two feat

Re: [dpdk-dev] [PATCH v6 2/3] vhost: convert buffer addresses to GPA for logging

2019-10-11 Thread Maxime Coquelin
On 10/9/19 1:54 PM, Adrian Moreno wrote: > Add IOVA versions of dirty page logging functions. > > Note that the API facing rte_vhost_log_write is not modified. > So, make explicit that it expects the address in GPA space. > > Fixes: 69c90e98f483 ("vhost: enable IOMMU support") > Cc: maxime.coq

Re: [dpdk-dev] [PATCH v6 1/3] vhost: translate incoming log address to gpa

2019-10-11 Thread Maxime Coquelin
On 10/9/19 1:54 PM, Adrian Moreno wrote: > When IOMMU is enabled the incoming log address is in IOVA space. In that > case, look in IOTLB table and translate the resulting HVA to GPA. > > If IOMMU is not enabled, the incoming log address is already a GPA so no > transformation is needed. > > F

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

2019-10-11 Thread Iremonger, Bernard
Hi Akhil, With this patch applied the legacy code path in the ipsec-secgw application is still available. The default code path is now to use librte_ipsec. The "-l 0" option at startup allows the legacy code path to be used. Both code paths are still available. Regards, Bernard > -Origina

Re: [dpdk-dev] [PATCH v6 2/4] examples/ipsec-secgw: add fallback session feature

2019-10-11 Thread Ananyev, Konstantin
Hi Akhil, > > > > Inline processing is limited to a specified subset of traffic. It is > > often unable to handle more complicated situations, such as fragmented > > traffic. When using inline processing such traffic is dropped. > > > > Introduce fallback session for inline processing allowing pro

Re: [dpdk-dev] [PATCH v5 08/10] examples/l2fwd-event: add eventdev main loop

2019-10-11 Thread Jerin Jacob
On Thu, Oct 3, 2019 at 2:29 AM wrote: > > From: Pavan Nikhilesh > > Add event dev main loop based on enabled l2fwd options and eventdev > capabilities. > > Signed-off-by: Pavan Nikhilesh > --- > examples/l2fwd-event/l2fwd_common.c | 6 + > examples/l2fwd-event/l2fwd_common.h | 2 + > exampl

Re: [dpdk-dev] [PATCH v1 6/6] crypto/ccp: updating ccp document

2019-10-11 Thread Akhil Goyal
Hi, > > From: Amaranath Somalapuram > > Signed-off-by: Amaranath Somalapuram > --- Title should be "crypto/ccp: fix documentation" Please add an appropriate description to the patch. This patch is a fix and should also have fixes tag and also cc to sta...@dpdk.org > doc/guides/cryptodevs/c

Re: [dpdk-dev] [PATCH v5 01/10] examples/l2fwd-event: add default poll mode routines

2019-10-11 Thread Jerin Jacob
On Thu, Oct 3, 2019 at 2:28 AM wrote: > > From: Pavan Nikhilesh > > Add the default l2fwd poll mode routines similar to examples/l2fwd. > > Signed-off-by: Sunil Kumar Kori > Signed-off-by: Pavan Nikhilesh > --- > MAINTAINERS | 5 + > examples/Makefile

Re: [dpdk-dev] [PATCH v6 2/4] examples/ipsec-secgw: add fallback session feature

2019-10-11 Thread Akhil Goyal
Hi All, > > Inline processing is limited to a specified subset of traffic. It is > often unable to handle more complicated situations, such as fragmented > traffic. When using inline processing such traffic is dropped. > > Introduce fallback session for inline processing allowing processing > pac

Re: [dpdk-dev] [PATCH v3 1/3] lib/ring: add peek API

2019-10-11 Thread Ananyev, Konstantin
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Friday, October 11, 2019 6:04 AM > To: Ananyev, Konstantin ; > step...@networkplumber.org; paul...@linux.ibm.com > Cc: Wang, Yipeng1 ; Medvedkin, Vladimir > ; Ruifeng Wang (Arm Technology >

Re: [dpdk-dev] [PATCH v4 03/14] vhost: add batch enqueue function for packed ring

2019-10-11 Thread Maxime Coquelin
On 10/9/19 3:38 PM, Marvin Liu wrote: > Batch enqueue function will first check whether descriptors are cache > aligned. It will also check prerequisites in the beginning. Batch > enqueue function not support chained mbufs, single packet enqueue > function will handle it. > > Signed-off-by: Mar

Re: [dpdk-dev] [PATCH 1/3] app/test: use RTE_DIM instead of ARRAY_SIZE

2019-10-11 Thread Eads, Gage
> -Original Message- > From: pbhagavat...@marvell.com [mailto:pbhagavat...@marvell.com] > Sent: Thursday, October 10, 2019 11:07 PM > To: Doherty, Declan ; Eads, Gage > ; Olivier Matz > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 1/3] app/test: use RTE_DIM instead of

Re: [dpdk-dev] [PATCH v4 13/14] vhost: check whether disable software pre-fetch

2019-10-11 Thread Maxime Coquelin
On 10/9/19 3:38 PM, Marvin Liu wrote: > Disable software pre-fetch actions on Skylake and later platforms. > Hardware can fetch needed data for vhost, additional software pre-fetch > will impact performance. > > Signed-off-by: Marvin Liu > > diff --git a/lib/librte_vhost/Makefile b/lib/librte

Re: [dpdk-dev] [PATCH v5 10/10] doc: add application usage guide for l2fwd-event

2019-10-11 Thread Jerin Jacob
On Thu, Oct 3, 2019 at 2:29 AM wrote: > > From: Sunil Kumar Kori > > Add documentation for l2fwd-event example. > Update release notes. > > Signed-off-by: Sunil Kumar Kori # Please fix the typos through with the following command aspell --lang=en_US --check doc/guides/sample_app_ug/l2_forward_

[dpdk-dev] [PATCH 2/2] event/dpaa: support Tx adapter

2019-10-11 Thread Nipun Gupta
This patch adds the support of Tx adapter for DPAA1 platform Signed-off-by: Nipun Gupta --- drivers/event/dpaa/dpaa_eventdev.c | 75 -- 1 file changed, 70 insertions(+), 5 deletions(-) diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventde

[dpdk-dev] [PATCH 1/2] event/dpaa: fix number of supported atomic flows

2019-10-11 Thread Nipun Gupta
The number of atomic flows supported was not returned correctly for DPAA driver. This patch fixes the same. Fixes: b08dc6430abd ("event/dpaa: add queue config get/set") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/event/dpaa/dpaa_eventdev.c | 1 + drivers/event/dpaa/dpaa_eventdev.

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix SAD selection logic

2019-10-11 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > Ipsec-secgw example application fails to initialize when using default > > > configuration file (ep0.cfg) in library mode (librte_ipsec enabled). > > > > > > The reason is that two of SP rules in ep0.cfg, one for IPv4 and one > > > for IPv6, are using the same

Re: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE

2019-10-11 Thread Ferruh Yigit
On 10/11/2019 10:32 AM, Ananyev, Konstantin wrote: > > >> Hi Pavan, >> >>> >>> From: Pavan Nikhilesh >>> >>> Use RTE_DIM instead of re-defining ARRAY_SIZE. >>> >>> Signed-off-by: Pavan Nikhilesh >>> --- >>> drivers/bus/dpaa/base/qbman/qman.c| 6 ++-- >>> drivers/bus/dpaa/include/c

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix SAD selection logic

2019-10-11 Thread Ananyev, Konstantin
Hi Akhil, > > Ipsec-secgw example application fails to initialize when using default > > configuration file (ep0.cfg) in library mode (librte_ipsec enabled). > > > > The reason is that two of SP rules in ep0.cfg, one for IPv4 and one > > for IPv6, are using the same SPI number. When SA rules are

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-11 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > ..[snip] > > > > > > OK let us assume that you have a separate structure. But I have a > > > > > > few > > > queries: > > > > > > 1. how can multiple drivers use a same session > > > > > > > > > > As a short answer: they can't. > > > > > It is pretty much the sam

[dpdk-dev] [PATCH v5] eventdev: flag to identify same destined packets enqueue

2019-10-11 Thread Nipun Gupta
This patch introduces a `flag` in the Eth TX adapter enqueue API. Some drivers may support burst functionality only with the packets having same destination device and queue. The flag `RTE_EVENT_ETH_TX_ADAPTER_ENQUEUE_SAME_DEST` can be used to indicate this so the underlying driver, for drivers to

Re: [dpdk-dev] [PATCH] doc: replace license text with SPDX tag in ARK nic

2019-10-11 Thread Ed Czeck
Thanks.Do not hesitate to message me directly about needed ACKs. Acked-by: Ed Czeck On Fri, Sep 27, 2019 at 5:06 AM Hemant Agrawal wrote: > Cc: Ed Czeck > Cc: John Miller > > Signed-off-by: Hemant Agrawal > --- > doc/guides/nics/ark.rst | 29 + > 1 file chan

Re: [dpdk-dev] [PATCH v4 04/14] vhost: add single packet dequeue function

2019-10-11 Thread Maxime Coquelin
On 10/9/19 3:38 PM, Marvin Liu wrote: > Add vhost single packet dequeue function for packed ring and meanwhile > left space for shadow used ring update function. > > Signed-off-by: Marvin Liu > Reviewed-by: Maxime Coquelin

[dpdk-dev] [PATCH v2 2/5] crypto/octeontx: add asymmetric session operations

2019-10-11 Thread Anoob Joseph
From: Kanaka Durga Kotamarthy Add asymmetric session setup and free functions. RSA and modexp operations are supported. Signed-off-by: Anoob Joseph Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/octeontx.ini| 6 +- doc/guides/cr

[dpdk-dev] [PATCH v2 5/5] app/test: register octeontx PMD to asym testsuite

2019-10-11 Thread Anoob Joseph
From: Sunila Sahu Updated asymmetric crypto unit-test application to test asymmetric crypto operations in octeontx PMD Signed-off-by: Anoob Joseph Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Sunila Sahu --- app/test/test_cryptodev_asym.c | 31 +++ do

[dpdk-dev] [PATCH v2 4/5] crypto/octeontx: add asymmetric enqueue/dequeue ops

2019-10-11 Thread Anoob Joseph
From: Sunila Sahu Add asymmetric crypto op enqueue & dequeue routines Signed-off-by: Anoob Joseph Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Sunila Sahu --- drivers/common/cpt/cpt_common.h | 1 + drivers/common/cpt/cpt_mcode_defines.h | 20 ++ drivers/common/cp

[dpdk-dev] [PATCH v2 3/5] common/cpt: add helper functions for asymmetric crypto

2019-10-11 Thread Anoob Joseph
From: Kanaka Durga Kotamarthy Add helper functions to get meta len for asymmetric operations Signed-off-by: Anoob Joseph Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Sunila Sahu --- drivers/common/cpt/cpt_pmd_ops_helper.c | 15 + drivers/common/cpt/cpt_pmd_ops_help

[dpdk-dev] [PATCH v2 1/5] crypto/octeontx: add device type mailbox routine

2019-10-11 Thread Anoob Joseph
From: Kanaka Durga Kotamarthy Add mailbox communication to query symmetric or asymmetric device type Signed-off-by: Anoob Joseph Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Sunila Sahu --- drivers/common/cpt/cpt_common.h | 3 --- drivers/crypto/octeontx/otx_crypt

[dpdk-dev] [PATCH v2 0/5] add asym support in crypto_octeontx PMD

2019-10-11 Thread Anoob Joseph
This series adds asymmetric crypto support in 'crypto_octoentx' PMD. Changes in v2: * Squashed patches as directed by Akhil * Split the doc patch and added documentation along with feature * Added check for ASYM SESSIONLESS (not supported currently) * Made separate enqueue & dequeue routines for s

Re: [dpdk-dev] [PATCH v4 03/14] vhost: add batch enqueue function for packed ring

2019-10-11 Thread Maxime Coquelin
On 10/9/19 3:38 PM, Marvin Liu wrote: > Batch enqueue function will first check whether descriptors are cache > aligned. It will also check prerequisites in the beginning. Batch > enqueue function not support chained mbufs, single packet enqueue > function will handle it. > > Signed-off-by: Mar

Re: [dpdk-dev] [PATCH v4 02/14] vhost: unify unroll pragma parameter

2019-10-11 Thread Maxime Coquelin
On 10/9/19 3:38 PM, Marvin Liu wrote: > Add macro for unifying Clang/ICC/GCC unroll pragma format. Batch > functions were contained of several small loops which optimized by > compiler’s loop unrolling pragma. > > Signed-off-by: Marvin Liu > > diff --git a/lib/librte_vhost/Makefile b/lib/libr

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

2019-10-11 Thread Akhil Goyal
Hi All, This patchset would need ack from more vendors as it will impact user experience on a key example application which is normally demonstrated to customers. IPSec library is still evolving and there are new functionality added every release. Atleast from NXP side we are not OK with this ch

Re: [dpdk-dev] [PATCH v4 01/14] vhost: add single packet enqueue function

2019-10-11 Thread Maxime Coquelin
On 10/9/19 3:38 PM, Marvin Liu wrote: > Add vhost enqueue function for single packet and meanwhile left space > for flush used ring function. > > Signed-off-by: Marvin Liu > Reviewed-by: Maxime Coquelin

[dpdk-dev] [PATCH v8 0/2] mbuf: add bulk free function

2019-10-11 Thread Morten Brørup
Add function for freeing a bulk of mbufs. Add unit test for functions for allocating and freeing a bulk of mbufs. --- v8: * Add unit test, covering both bulk alloc and bulk free. v7: * Squash multiple modifications into one. v6: * Remove __rte_always_inline from static function. The compiler w

[dpdk-dev] [PATCH v8 1/2] mbuf: add bulk free function

2019-10-11 Thread Morten Brørup
Add function for freeing a bulk of mbufs. Signed-off-by: Morten Brørup Acked-by: Konstantin Ananyev Reviewed-by: Andrew Rybchenko Acked-by: Stephen Hemminger --- v8: * Add unit test, covering both bulk alloc and bulk free. v7: * Squash multiple modifications into one. v6: * Remove __rte_alwa

[dpdk-dev] [PATCH v8 2/2] mbuf: add unit test for bulk alloc/free functions

2019-10-11 Thread Morten Brørup
Add unit test for functions for allocating and freeing a bulk of mbufs. Signed-off-by: Morten Brørup --- app/test/test_mbuf.c | 171 +++ 1 file changed, 171 insertions(+) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index 2a97afe20..fbce0ca7c

Re: [dpdk-dev] [PATCH v3] build: add emag(arm64) platform and default config

2019-10-11 Thread Jerin Jacob
On Wed, Oct 9, 2019 at 8:15 AM Gavin Hu wrote: > > From: Jerry Hao OS > I think the subject can be changed to "build: add emag target " > config: add emag configuration > mk/machine: add emag machine configurations The above lines are not a sentence. Please make it as a sentence in the git c

Re: [dpdk-dev] [PATCH v5 0/5] ipsec: add inbound SAD

2019-10-11 Thread Akhil Goyal
> -Original Message- > From: Vladimir Medvedkin > Sent: Thursday, October 10, 2019 10:19 PM > To: dev@dpdk.org > Cc: konstantin.anan...@intel.com; bernard.iremon...@intel.com; Akhil Goyal > > Subject: [PATCH v5 0/5] ipsec: add inbound SAD > > According to RFC 4301 IPSec implementation

[dpdk-dev] rte_mempool_get_bulk uses either cache or common pool

2019-10-11 Thread Morten Brørup
The rte_mempool_get_bulk() documentation says: "If cache is enabled, objects will be retrieved first from cache, subsequently from the common pool." But __mempool_generic_get() only uses the cache if the request is smaller than the cache size. If not, objects will be retrieved from the common p

Re: [dpdk-dev] [PATCH v5 3/5] ipsec: add SAD add/delete/lookup implementation

2019-10-11 Thread Akhil Goyal
> int > -rte_ipsec_sad_lookup(__rte_unused const struct rte_ipsec_sad *sad, > - __rte_unused const union rte_ipsec_sad_key *keys[], > - __rte_unused void *sa[], __rte_unused uint32_t n) > +rte_ipsec_sad_lookup(const struct rte_ipsec_sad *sad, > + const union

Re: [dpdk-dev] [PATCH v11 9/9] vhost: add vhost-user-blk example which support inflight

2019-10-11 Thread Maxime Coquelin
On 10/9/19 10:48 PM, Jin Yu wrote: > A vhost-user-blk example that support inflight feature. It uses the > new APIs that introduced in the first patch, so it can show how these > APIs work to support inflight feature. > > Signed-off-by: Jin Yu > --- > V1 - add the case. > V2 - add the rte_vhos

Re: [dpdk-dev] [PATCH v11 8/9] vhost: add vring functions packed ring support

2019-10-11 Thread Maxime Coquelin
On 10/9/19 10:48 PM, Jin Yu wrote: > This patch add packed ring support in two APIs > so user can get the packed ring`. > > Signed-off-by: Lin Li > Signed-off-by: Xun Ni > Signed-off-by: Yu Zhang > Signed-off-by: Jin Yu > --- > lib/librte_vhost/vhost.c | 68 +---

Re: [dpdk-dev] [PATCH v11 7/9] vhost: add APIs for user getting inflight ring

2019-10-11 Thread Maxime Coquelin
On 10/9/19 10:48 PM, Jin Yu wrote: > This patch introduces two APIs. one is for getting inflgiht s/inflgiht/inflight/ > ring and the other is for getting base. > > Signed-off-by: Lin Li > Signed-off-by: Xun Ni > Signed-off-by: Yu Zhang > Signed-off-by: Jin Yu > --- > lib/librte_vhost/rte

Re: [dpdk-dev] [PATCH v11 6/9] vhost: add the APIs to operate inflight ring

2019-10-11 Thread Maxime Coquelin
On 10/9/19 10:48 PM, Jin Yu wrote: > This patch introduces three APIs to operate the inflight > ring. Three APIs are set, set last and clear. It includes > split and packed ring. > > Signed-off-by: Lin Li > Signed-off-by: Xun Ni > Signed-off-by: Yu Zhang > Signed-off-by: Jin Yu > --- > lib

  1   2   >