Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-01 Thread Liu, Yu Y
Add Damjan from FD.io for awareness... Hi Thomas, Long time no see. Sorry I use outlook which is not friendly to community email. >Anyway I will propose to replace this API in the next release. Will your plan be affected by API/ABI stable plan? BTW, if you propose new change in next release, it

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-01 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Saturday, November 2, 2019 06:46 > To: Wang, Haiyue > Cc: dev@dpdk.org; arybche...@solarflare.com; Yigit, Ferruh > ; > jerinjac...@gmail.com; Ye, Xiaolong ; Kinsella, Ray > ; > Sun, Chenmin ; Slava Ovsiienko > > Subject: Re: [PATCH

[dpdk-dev] [PATCH] net/enic: re-enable link status change interrupt

2019-11-01 Thread Hyong Youb Kim
When INTx is used, the interrupt handler needs to explicitly re-enable interrupt in order to receive another one in future. The LSC interrupt handler currently does not, and the link state never gets updated when INTx is used (e.g. uio_pci_generic). Call rte_intr_ack() at the end of the handler, to

Re: [dpdk-dev] [PATCH v1] examples/power: fix oob frequency oscillations

2019-11-01 Thread Thomas Monjalon
29/10/2019 15:05, Hunt, David: > On 27/10/2019 18:35, Thomas Monjalon wrote: > > 06/08/2019 13:18, Thomas Monjalon: > >> 26/07/2019 12:15, Burakov, Anatoly: > >>> So it's biased towards scaling up quickly, but it's doing that over a > >>> period. Please correct me if i'm wrong as i'm not really fam

Re: [dpdk-dev] [EXT] Re: [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-01 Thread Thomas Monjalon
31/10/2019 17:44, Pavan Nikhilesh Bhagavatula: > >29/10/2019 16:37, pbhagavat...@marvell.com: > >> From: Pavan Nikhilesh > >> +{ > >> + uint64_t offloads_diff = req_offloads ^ set_offloads; > >> + uint64_t offloads_req_diff, offloads_set_diff; > >> + uint64_t offload; > >> + uint8_t err = 0; >

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-01 Thread Thomas Monjalon
Thank you for trying to address comments done late. 31/10/2019 18:11, Haiyue Wang: > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > -enum rte_eth_burst_mode_option { > - RTE_ETH_BURST_SCALAR = (1 << 0), > - RTE_ETH_BURST_VECTOR = (1 << 1), > - > - /**< bi

Re: [dpdk-dev] [PATCH v15 1/7] ethdev: add set ptype function

2019-11-01 Thread Thomas Monjalon
01/11/2019 11:55, Andrew Rybchenko: > On 10/31/19 7:38 PM, Pavan Nikhilesh Bhagavatula wrote: > >> 29/10/2019 16:37, pbhagavat...@marvell.com: > >>> From: Pavan Nikhilesh > >>> Removed Items > >>> - > >>> --- a/lib/librte_ethdev/rte_ethdev.h > >>> +++ b/lib/librte_ethdev/rte_ethdev.h

Re: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-11-01 Thread Thomas Monjalon
01/11/2019 12:11, Andrew Rybchenko: > On 10/31/19 7:51 PM, Pavan Nikhilesh Bhagavatula wrote: > > > >> 29/10/2019 16:37, pbhagavat...@marvell.com: > >>> From: Pavan Nikhilesh > >>> > >>> Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash > >>> delivery. > >>> > >>> Signed-off-by

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with clang 3.4.2

2019-11-01 Thread Thomas Monjalon
31/10/2019 15:05, Ciara Power: > Building with clang 3.4.2 caused the following error: > > CC dpaa2_sec_dpseci.o > In file included from /dpdk/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:40: > In file included from /dpdk/drivers/common/dpaax/caamflib/desc/ipsec.h:11: > In file included from /dpd

Re: [dpdk-dev] [PATCH v2 00/10] Add an option to use LTO for DPDK build

2019-11-01 Thread Stephen Hemminger
On a relate topic. Last time, tried build a DPDK application using -fwhole-program gcc gave lots of warnings because it decided not to inline rte_memcpy. Perhaps this might impact LTO as well. Really rte_memcpy_func should not be inline. We already optimize for the constant size case where inline

[dpdk-dev] [PATCH 2/2] failsafe: implement xstats

2019-11-01 Thread Stephen Hemminger
Add support for extended statistics in failsafe driver. Reports detailed statistics for each sub device. Example: testpmd> show port xstats 1 rx_good_packets: 0 tx_good_packets: 0 rx_good_bytes: 0 tx_good_bytes: 0 rx_missed_errors: 0 rx_errors: 0 tx_errors: 0 rx_mbuf_allocation_errors: 0 rx_q0pac

[dpdk-dev] [PATCH 0/2] xstats related patches

2019-11-01 Thread Stephen Hemminger
This is an updated simplified version of previous failsafe xstats patch and a bug fix for testpmd. The failsafe xstats patch is almostly a complete redo. Stephen Hemminger (2): app/testpmd: block xstats for hidden ports failsafe: implement xstats app/test-pmd/config.c | 8 ++

[dpdk-dev] [PATCH 1/2] app/testpmd: block xstats for hidden ports

2019-11-01 Thread Stephen Hemminger
All the other testpmd commands block access to devices that are owned. Looks like xstat got overlooked. Fixes: bfd5051b43b5 ("app/testpmd: new command to get extended statistics") Signed-off-by: Stephen Hemminger --- app/test-pmd/config.c | 8 1 file changed, 8 insertions(+) diff --git

Re: [dpdk-dev] DPDK QoS scheduler changes, are we there yet?

2019-11-01 Thread Gladchun, Glenn
Jasvinder, Thanks! Got confused by outdated documentation that still references old design... Glenn Sent from iPad From: Singh, Jasvinder Sent: Thursday, October 31, 2019 1:45 PM To: Gladchun, Glenn; dev@dpdk.org Cc: Dumitrescu, Cristian; Yigit, Ferruh Subject:

[dpdk-dev] [PATCH v2 12/13] crypto/dpaa2_sec: use aes-ctr initial counter as 1

2019-11-01 Thread Hemant Agrawal
From: Vakul Garg As per RFC3686, the initial aes-ctr counter value should be '1' for use in ipsec. The patches changes SEC descriptor for using correct counter value. In addition, it drops a redundant parameter for passing IV while creating the descriptor. Signed-off-by: Vakul Garg --- drivers

[dpdk-dev] [PATCH v2 11/13] crypto/dpaa_sec: use macros in queue attach and detach

2019-11-01 Thread Hemant Agrawal
From: Gagandeep Singh Align the cleanup and allocation for the queues. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c ind

[dpdk-dev] [PATCH v2 13/13] crypto/dpaa_sec: enable ipsec aes-ctr to use nonce

2019-11-01 Thread Hemant Agrawal
From: Vakul Garg The protocol aware ipsec descriptor has been modified to use ctr_initial value of 1 and salt configured for ipsec SA. Signed-off-by: Hemant Agrawal Signed-off-by: Vakul Garg --- drivers/common/dpaax/caamflib/desc/ipsec.h | 18 -- drivers/crypto/dpaa2_sec/dpaa

[dpdk-dev] [PATCH v2 08/13] test/cryptodev: enable additional cases for dpaax

2019-11-01 Thread Hemant Agrawal
This patch enables short buffer and 12 bit IV AES-CTR cases for dpaax_sec pmds. Signed-off-by: Vakul Garg Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev_aes_test_vectors.h | 24 +++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/app/test/test_crypto

[dpdk-dev] [PATCH v2 09/13] crypto/dpaa2_sec: enable warning with truncated sha256

2019-11-01 Thread Hemant Agrawal
This patch throw the warning when using truncted digest len for SHA256 case. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 drivers/crypto/dpaa_sec/dpaa_sec.c | 4 2 files changed, 8 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/dpaa2

[dpdk-dev] [PATCH v2 07/13] crypto/dpaa_sec: add AES-GCM support for lookaside case

2019-11-01 Thread Hemant Agrawal
This patch add support for AES-128-GCM, when used in proto lookaside mode. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 331 - 1 file changed, 233 insertions(+), 98 deletions(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/cryp

[dpdk-dev] [PATCH v2 06/13] crypto/dpaa2_sec: add AES-GCM support for lookaside case

2019-11-01 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 96 - 1 file changed, 92 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 6c2faa69a..c6b6444aa 100644 ---

[dpdk-dev] [PATCH v2 05/13] crypto/dpaa_sec: adding NULL cipher or NULL auth

2019-11-01 Thread Hemant Agrawal
These are supported when using protocol offload mode or when in chain mode. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 33 ++-- drivers/crypto/dpaa_sec/dpaa_sec.h | 41 ++ 2 files changed, 66 insertions(+), 8 deletions(-

[dpdk-dev] [PATCH v2 10/13] crypto/dpaa2_sec: remove unwanted context type check

2019-11-01 Thread Hemant Agrawal
From: Gagandeep Singh This patch remove redundant checks. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_se

[dpdk-dev] [PATCH v2 03/13] crypto/dpaa_sec: add check for the session validity

2019-11-01 Thread Hemant Agrawal
Check if the session is not null during processing. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 31fe092ce..8704fe33d 100644 --- a/dr

[dpdk-dev] [PATCH v2 02/13] crypto/dpaa2_sec: add check for the session validity

2019-11-01 Thread Hemant Agrawal
Check if the session is not null during processing. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 6d59e73e9..702

[dpdk-dev] [PATCH v2 01/13] crypto/dpaa_sec: fix to set PDCP capability flags

2019-11-01 Thread Hemant Agrawal
set the pdcp capa_flags to 0 by default. Fixes: a1173d55598c ("crypto/dpaa_sec: support PDCP offload") Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_se

[dpdk-dev] [PATCH v2 04/13] crypto/dpaa2_sec: adding NULL cipher or NULL auth

2019-11-01 Thread Hemant Agrawal
These are supported when using protocol offload mode or in chain mode. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 22 +++ drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 41 + 2 files changed, 56 insertions(+), 7 deletions(-) diff -

Re: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-11-01 Thread Liron Himi
Hi, mvpp2 and mvneta PMDs are also support RSS hash. Please add them to the patch. Regards, Liron -Original Message- From: dev On Behalf Of pbhagavat...@marvell.com Sent: Tuesday, 29 October 2019 17:37 To: ferruh.yi...@intel.com; arybche...@solarflare.com; Jerin Jacob Kollanukkaran ; A

Re: [dpdk-dev] [PATCH v6 07/12] app/test: clean LTO build warnings (maybe-uninitialized)

2019-11-01 Thread Wang, Yipeng1
>-Original Message- >From: Andrzej Ostruszka [mailto:aostrus...@marvell.com] >Sent: Tuesday, October 29, 2019 7:12 AM >To: dev@dpdk.org; Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; Chas Williams ; Burakov, Anatoly > >Cc: mattias.ronnb...@ericsson.com; step...@networkplumber.org

Re: [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests

2019-11-01 Thread Wang, Yipeng1
Hi, Amit, I think I acked this patch. But from patchwork seems you superseded this patch set accidentally. So Thomas might have missed it. To make his life easier, you may submit a newer version with my acked. I believe Thomas will see it. Thanks Yipeng >-Original Message- >From: Ami

[dpdk-dev] RTE_METER no longer configurable

2019-11-01 Thread Stephen Hemminger
Did anyone notice that RTE_METER library is now required in DPDK. Since the introduction of the traffic manager library into ethdev RTE_METER can not be disabled: ethdev depends on rte_mtr.h and rte_mtr.h depends on rte_meter.

[dpdk-dev] [PATCH v5] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-01 Thread Haiyue Wang
The original design is to use rte_mbuf::udata64 to save the metadata of protocol extraction which has network protocol data fields and type, a private API is used to decode this metadata. It is not so generic. Use the new dynamic mbuf field and flags to handle protocol extraction. Then the metadat

[dpdk-dev] [PATCH v6 11/12] test/fib: add FIB library performance autotests

2019-11-01 Thread Vladimir Medvedkin
Performance tests for the new FIB library. Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 2 + app/test/test_fib_perf.c | 411 ++ 4 files changed, 420 insertion

[dpdk-dev] [PATCH v6 12/12] test/fib: add FIB library ipv6 performance autotests

2019-11-01 Thread Vladimir Medvedkin
Performance ipv6 tests for the FIB library. Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 ++ app/test/meson.build | 2 + app/test/test_fib6_perf.c | 157 ++ 4 files changed, 166 inserti

[dpdk-dev] [PATCH v6 10/12] test/fib: add ipv6 support for FIB autotests

2019-11-01 Thread Vladimir Medvedkin
Functional ipv6 tests for the FIB library. Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 12 ++ app/test/meson.build | 3 + app/test/test_fib6.c | 423 ++ 4 files changed, 439 insertio

[dpdk-dev] [PATCH v6 08/12] fib: add dataplane algorithm for ipv6

2019-11-01 Thread Vladimir Medvedkin
Add fib implementation for ipv6 using modified DIR24_8 algorithm. Implementation is similar to current LPM6 implementation but has few enhancements: faster control plabe operations more bits for userdata in table entries configurable userdata size Signed-off-by: Vladimir Medvedkin --- lib/librte

[dpdk-dev] [PATCH v6 09/12] test/fib: add FIB library autotests

2019-11-01 Thread Vladimir Medvedkin
Functional tests for the new FIB library. Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 12 ++ app/test/meson.build | 4 + app/test/test_fib.c | 414 ++ 4 files changed, 431 insertion

[dpdk-dev] [PATCH v6 05/12] fib: add FIB library

2019-11-01 Thread Vladimir Medvedkin
Add FIB (Forwarding Information Base) library. This library implements a dataplane structures and algorithms designed for fast longest prefix match. Internally it consists of two parts - RIB (control plane ops) and implementation for the dataplane tasks. Initial version provides two implementations

[dpdk-dev] [PATCH v6 06/12] fib: add FIB ipv6 support

2019-11-01 Thread Vladimir Medvedkin
Add FIB library support for IPv6. It implements a dataplane structures and algorithms designed for fast IPv6 longest prefix match. Signed-off-by: Vladimir Medvedkin --- lib/librte_fib/Makefile| 4 +- lib/librte_fib/meson.build | 4 +- lib/librte_fib/rte_fib6.c |

[dpdk-dev] [PATCH v6 07/12] fib: add DIR24-8 dataplane algorithm

2019-11-01 Thread Vladimir Medvedkin
Add fib implementation for DIR24_8 algorithm for ipv4. Implementation is similar to current LPM implementation but has few enhancements: faster control plabe operations more bits for userdata in table entries configurable userdata size Signed-off-by: Vladimir Medvedkin --- lib/librte_fib/Makefil

[dpdk-dev] [PATCH v6 02/12] test/rib: add RIB library autotests

2019-11-01 Thread Vladimir Medvedkin
Functional tests for the new RIB library. Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 2 + app/test/autotest_data.py | 6 + app/test/meson.build | 3 + app/test/test_rib.c | 351 ++ 4 files changed, 362 insertions

[dpdk-dev] [PATCH v6 04/12] test/rib: add ipv6 support for RIB autotests

2019-11-01 Thread Vladimir Medvedkin
Functional tests for RIB6. Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 2 + app/test/test_rib6.c | 357 ++ 4 files changed, 366 insertions(+) create mod

[dpdk-dev] [PATCH v6 03/12] rib: add ipv6 support for RIB

2019-11-01 Thread Vladimir Medvedkin
Extend RIB library with ipv6 support. Signed-off-by: Vladimir Medvedkin --- lib/librte_rib/Makefile| 4 +- lib/librte_rib/meson.build | 4 +- lib/librte_rib/rte_rib6.c | 598 + lib/librte_rib/rte_rib6.h | 334 +

[dpdk-dev] [PATCH v6 00/12] lib: add RIB and FIB liraries

2019-11-01 Thread Vladimir Medvedkin
This is heavily reworked version of previous RIB library series: https://mails.dpdk.org/archives/dev/2018-April/099492.html Current lpm implementation while provides really good lookup performance has number of problems. One of them is very low speed for control plane operations such as add or del

[dpdk-dev] [PATCH v6 01/12] rib: add RIB library

2019-11-01 Thread Vladimir Medvedkin
Add RIB (Routing Information Base) library. This library implements an IPv4 routing table optimized for control plane operations. It implements a control plane struct containing routes in a tree and provides fast add/del operations for routes. Also it allows to perform fast subtree traversals (i.e.

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-11-01 Thread Akhil Goyal
Hi Konstantin, > > > Hi Akhil, > > > > > > > Added my comments inline with your draft. > > > > > > [snip].. > > > > > > > > > > > > > > > > > > > > Ok, then my suggestion: > > > > > > > Let's at least write down all points about crypto-dev approach > > > > > > > where > we > > > > > > > disagr

Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bitoperation APIs

2019-11-01 Thread Honnappa Nagarahalli
> > > > > > > > > -Original Message- > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Joyce Kong > > (Arm > > > > Technology China) > > > > Sent: Wednesday, October 23, 2019 5:08 AM > > > > > > > > > > > -Original Message- > > > > > > > From: dev [mailto:dev-boun...@dpdk

[dpdk-dev] [PATCH v2] crypto/aesni_gcm: support in-place chained mbufs

2019-11-01 Thread Pablo de Lara
IPSec Multi buffer library supports encryption on multiple segments. When dealing with chained buffers (multiple segments), as long as the operation is in-place, the destination buffer does not have to be contiguous (unlike in the case of out-of-place operation). Therefore, the limitation of not su

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-01 Thread Jerin Jacob
On Fri, Nov 1, 2019 at 6:03 AM Thomas Monjalon wrote: > > 30/10/2019 10:15, Jerin Jacob: > > On Wed, Oct 30, 2019 at 2:26 PM Thomas Monjalon wrote: > > > > > > 30/10/2019 05:08, Jerin Jacob: > > > > On Wed, Oct 30, 2019 at 12:21 AM Thomas Monjalon > > > > wrote: > > > > > > > > > > In a virtual

[dpdk-dev] [PATCH v5 5/5] net/hinic: remove Free Tx mbuf on demand from hinic.ini

2019-11-01 Thread Xiaoyun wang
This patch removes feature Free Tx mbuf on demand from hinic.ini because pmd driver does not support this feature. Fixes: 1d09792a270a ("net/hinic: add build and doc files") Signed-off-by: Xiaoyun wang --- doc/guides/nics/features/hinic.ini | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/

[dpdk-dev] [PATCH v5 3/5] net/hinic: optimize mbuf alloc function with initialized

2019-11-01 Thread Xiaoyun wang
When port start, driver needs to alloc mbuf resource to fill rx queue bd section, replace rte_mbuf_raw_alloc function to rte_pktmbuf_alloc_bulk with initialized mbuf structure to aviod some structures being used without initialization. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_

[dpdk-dev] [PATCH v5 4/5] net/hinic: remove Flow Director feature from doc files

2019-11-01 Thread Xiaoyun wang
This patch removes deprecated feature Flow Director from hinic.ini, hinic.rst and release_19_11.rst, because the feature has been removed from the feature list in the following commit: Commit 030febb6642c ("doc: remove deprecated ethdev features"), and adds Flow API feature which is for generic fil

[dpdk-dev] [PATCH v5 2/5] net/hinic: fix offload info calculating problem for TSO

2019-11-01 Thread Xiaoyun wang
For VXLAN TSO offload, pmd driver calcutes offload info err due to the wrong branch, which can cause hardware failed. Fixes: c3ba1f0f20cd ("net/hinic: support inner L3 checksum offload") Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_tx.c | 3 ++- 1 file changed, 2 insertions(+), 1

[dpdk-dev] [PATCH v5 1/5] net/hinic/base: fix code style check issue

2019-11-01 Thread Xiaoyun wang
This patch fixs the code style check issue for MACRO_ARG_REUSE. Fixes: b8582d051af1 ("net/hinic/base: add HW interfaces for SR-IOV") Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_mbox.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/hini

[dpdk-dev] [PATCH v5 0/5] Some fixes for hinic PMD driver

2019-11-01 Thread Xiaoyun wang
This patch fixes code style check issue, offload info calculating problem for TSO offload. Replace mbuf alloc function with initialized, remove Flow Director feature from doc files and add Flow API feature to hinic.ini, Remove Free Tx mbuf on demand from hinic.ini. -- v4->v5: - Fix code style c

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

2019-11-01 Thread Akhil Goyal
Hi Bernard, > > Hi Akhil, > > > > > > > > > > > > > > > 11/10/2019 14:40, Akhil Goyal: > > > > > > Hi All, > > > > > > > > > > > > This patchset would need ack from more vendors as it will impact > > > > > > user > > > > > experience > > > > > > on a key example application which is normally demo

[dpdk-dev] [PATCH v4] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-01 Thread Haiyue Wang
The original design is to use rte_mbuf::udata64 to save the metadata of protocol extraction which has network protocol data fields and type, a private API is used to decode this metadata. It is not so generic. Use the new dynamic mbuf field and flags to handle protocol extraction. Then the metadat

Re: [dpdk-dev] [PATCH v8 2/2] ethdev: move egress metadata to dynamic field

2019-11-01 Thread Andrew Rybchenko
On 10/31/19 7:48 PM, Viacheslav Ovsiienko wrote: > The dynamic mbuf fields were introduced by [1]. The egress metadata is > good candidate to be moved from statically allocated field tx_metadata to > dynamic one. Because mbufs are used in half-duplex fashion only, it is > safe to share this dynamic

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-11-01 Thread Jerin Jacob
On Fri, Nov 1, 2019 at 5:24 PM Luca Boccassi wrote: > > For distros, out-of-tree kernel modules are painful. From my POV, it I agree. > would be preferable to try and find a solution upstream, even if it is > going to be difficult and require a lot of negotiation and work. I understand from RH,

Re: [dpdk-dev] [PATCH v6 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-01 Thread Ananyev, Konstantin
> > From: Yasufumi Ogawa > > In secondary_msl_create_walk(), it creates a file for fbarrays with its > PID for reserving unique name among secondary processes. However, it > does not work if several secondaries run as app containers because each > of containerized secondary has PID 1, and fai

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-11-01 Thread Luca Boccassi
For distros, out-of-tree kernel modules are painful. From my POV, it would be preferable to try and find a solution upstream, even if it is going to be difficult and require a lot of negotiation and work. On Thu, 2019-10-31 at 18:03 +0100, Thomas Monjalon wrote: > We don't get enough attention on

[dpdk-dev] [PATCH] app: add few sanity checks in test-sad app

2019-11-01 Thread Vladimir Medvedkin
Coverity reported about two division by zero: *** CID 350344: Incorrect expression (DIVIDE_BY_ZERO) Although in fact these dividers will never be equal to 0, adding explicit checks in lookup() to make coverity happy will not affect the execution speed. Signed-off-by: Vladimir Medvedkin Acked-by

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-01 Thread Andrew Rybchenko
On 10/31/19 5:49 PM, Thomas Monjalon wrote: > 31/10/2019 10:49, Andrew Rybchenko: >> On 10/28/19 5:00 PM, Ori Kam wrote: -Original Message- >>> From: Andrew Rybchenko On 10/28/19 1:50 PM, Ori Kam wrote: > Hi Pavan, > > Sorry for jumping in late. > > I don't un

Re: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-11-01 Thread Andrew Rybchenko
On 10/31/19 7:51 PM, Pavan Nikhilesh Bhagavatula wrote: > >> 29/10/2019 16:37, pbhagavat...@marvell.com: >>> From: Pavan Nikhilesh >>> >>> Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash >>> delivery. >>> >>> Signed-off-by: Pavan Nikhilesh >>> Reviewed-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-01 Thread Andrew Rybchenko
On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: >> From: Pavan Nikhilesh Bhagavatula >>> Hi Matan, >>> Hi Pavan From: Pavan Nikhilesh > Some PMDs cannot work when certain offloads are enable/disabled, as a > workaround PMDs auto enable/disable offloads internally and

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-01 Thread Jerin Jacob
On Fri, Nov 1, 2019 at 6:03 AM Thomas Monjalon wrote: > > 30/10/2019 10:15, Jerin Jacob: > > On Wed, Oct 30, 2019 at 2:26 PM Thomas Monjalon wrote: > > > > > > 30/10/2019 05:08, Jerin Jacob: > > > > On Wed, Oct 30, 2019 at 12:21 AM Thomas Monjalon > > > > wrote: > > > > > > > > > > In a virtual

Re: [dpdk-dev] [PATCH v15 1/7] ethdev: add set ptype function

2019-11-01 Thread Andrew Rybchenko
On 10/31/19 7:38 PM, Pavan Nikhilesh Bhagavatula wrote: >> 29/10/2019 16:37, pbhagavat...@marvell.com: >>> From: Pavan Nikhilesh >>> Removed Items >>> - >>> --- a/lib/librte_ethdev/rte_ethdev.h >>> +++ b/lib/librte_ethdev/rte_ethdev.h >>> +/** >>> + * @warning >>> + * @b EXPERIMENTAL

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-01 Thread Ilya Maximets
On 01.11.2019 10:06, Ilya Maximets wrote: On 01.11.2019 1:24, Thomas Monjalon wrote: 30/10/2019 10:24, Jerin Jacob: On Wed, Oct 30, 2019 at 12:52 PM Shahaf Shuler wrote: Wednesday, October 30, 2019 6:09 AM, Jerin Jacob: Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from

Re: [dpdk-dev] [EXT] [PATCH v5 1/3] security: add anti replay window size

2019-11-01 Thread Hemant Agrawal
Hi Anoop, Thanks for the comment. > > +* indicates that Anti Replay Window is not > supported. > > [Anoob] Minor comment. Should it be "Anti Replay is not supported."? Akhil, will you please take care of it while applying? Regards, Hemant

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-01 Thread Ilya Maximets
On 30.10.2019 22:42, Thomas Monjalon wrote: 30/10/2019 17:09, Ilya Maximets: On 30.10.2019 16:49, Thomas Monjalon wrote: 30/10/2019 16:07, Ilya Maximets: On 29.10.2019 19:50, Thomas Monjalon wrote: In a virtual environment, the network controller may have to configure some SR-IOV VF parameter

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-01 Thread Ilya Maximets
On 01.11.2019 1:24, Thomas Monjalon wrote: 30/10/2019 10:24, Jerin Jacob: On Wed, Oct 30, 2019 at 12:52 PM Shahaf Shuler wrote: Wednesday, October 30, 2019 6:09 AM, Jerin Jacob: Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host On Wed, Oct 30, 2019 at 12:21 AM Thom

[dpdk-dev] [PATCH v6 0/1] fbarray: fix duplicated fbarray file in secondary

2019-11-01 Thread yasufum . o
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if several secondaries run as app containers because each of containerized secondary has PID 1, and failed to reserve uni

[dpdk-dev] [PATCH v6 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-01 Thread yasufum . o
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if several secondaries run as app containers because each of containerized secondary has PID 1, and failed to reserve uni

Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF reset

2019-11-01 Thread Eelco Chaudron
On 1 Nov 2019, at 3:38, Xing, Beilei wrote: -Original Message- From: Eelco Chaudron [mailto:echau...@redhat.com] Sent: Tuesday, October 29, 2019 3:47 PM To: Zhang, Xiao ; Xing, Beilei Cc: Zhang, Qi Z ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state

Re: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header

2019-11-01 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Friday, November 1, 2019 3:33 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header > > Currently if user want to set VLAN id/pcp on an

Re: [dpdk-dev] [PATCH v3] vhost: fix vhost user virtqueue not accessible

2019-11-01 Thread Liu, Yong
> -Original Message- > From: Adrian Moreno [mailto:amore...@redhat.com] > Sent: Friday, November 01, 2019 1:48 AM > To: Liu, Yong ; Bie, Tiwei > Cc: maxime.coque...@redhat.com; Wang, Zhihong ; > dev@dpdk.org > Subject: Re: [PATCH v3] vhost: fix vhost user virtqueue not accessible > > Hi