Re: [dpdk-dev] [PATCH 2/2] pdump: use dynamic logtype

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 5:39 AM Stephen Hemminger wrote: > > The logtype USER1 should not be overloaded for library function. > Instead use a dynamic log type. > > Signed-off-by: Stephen Hemminger This patch is incomplete. $ git grep -w RTE_LOG lib/librte_pdump/ lib/librte_pdump/rte_pdump.c:/* Ma

Re: [dpdk-dev] [PATCH 1/3] net/mlx5: reorganize flow tables with hash list

2019-11-08 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Friday, November 8, 2019 6:45 > To: Slava Ovsiienko > Cc: Ori Kam ; Raslan Darawsheh > ; dev@dpdk.org > Subject: [PATCH 1/3] net/mlx5: reorganize flow tables with hash list > > In the current flow tables organization, arrays are used. This i

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: reorganize flow matcher resources

2019-11-08 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Friday, November 8, 2019 6:45 > To: Slava Ovsiienko > Cc: Ori Kam ; Raslan Darawsheh > ; dev@dpdk.org > Subject: [PATCH 3/3] net/mlx5: reorganize flow matcher resources > > Matchers are created on the specific table. If a single linked list

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Andrew Rybchenko
On 11/6/19 10:42 AM, Ori Kam wrote: > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Wednesday, November 6, 2019 8:41 AM >> To: Ori Kam ; Thomas Monjalon >> >> Cc: dev@dpdk.org; pbhagavat...@marvell.com; ferruh.yi...@intel.com; >> jer...@marvell.com; John McNamara ; Marko >> Ko

Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-08 Thread Olivier Matz
On Wed, Nov 06, 2019 at 01:09:43PM +0100, Thomas Monjalon wrote: > The constants like AF_INET are in sys/socket.h in FreeBSD. > The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD > in order to be consistent across DPDK files, and allow to grep > for EXEC_ENV among other benefits. >

Re: [dpdk-dev] [PATCH v16 4/8] drivers/net: update Rx RSS hash offload capabilities

2019-11-08 Thread Andrew Rybchenko
On 11/7/19 8:22 PM, Ferruh Yigit wrote: > On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: >> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c >> index ed8cbd849..37df1c40a 100644 >> --- a/drivers/net/i40e/i40e_ethdev.c >> +++ b/drivers/net/i40e/i40e_ethdev.c >> @@

Re: [dpdk-dev] [PATCH 1/2] examples/l3fwd: increase number of routes

2019-11-08 Thread David Marchand
On Wed, Oct 30, 2019 at 6:23 AM wrote: > > From: Pavan Nikhilesh > > Increase the number of routes from 8 to 16 that are statically added for > lpm and em mode as most of the SoCs support more than 8 interfaces. > > Signed-off-by: Pavan Nikhilesh > --- > examples/l3fwd/l3fwd_em.c | 72

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Tom Barbette
My two cents as a regular user of the flow and mark feature: (A) seems much better and natural. In packet processing platform such as FastClick, I don't have a real understanding of the rules of the user, and rules can be added by the user while the application is running via a socket or web in

Re: [dpdk-dev] [PATCH v16 1/8] ethdev: add set ptype function

2019-11-08 Thread Andrew Rybchenko
On 11/7/19 9:28 PM, Ferruh Yigit wrote: > On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Add `rte_eth_dev_set_ptypes` function that will allow the application >> to inform the PMD about reduced range of packet types to handle. >> Based on the ptypes set PMDs c

Re: [dpdk-dev] [PATCH v4 2/3] net/mlx5: use API to set max LRO packet size

2019-11-08 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Thursday, November 7, 2019 14:35 > To: john.mcnam...@intel.com; marko.kovace...@intel.com; > nhor...@tuxdriver.com; ajit.khapa...@broadcom.com; > somnath.ko...@broadcom.com; anatoly.bura...@intel.com; > xuanziya...@huawei.com; cloud.wangxiao

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Ferruh Yigit
On 11/8/2019 6:54 AM, Matan Azrad wrote: > Hi > > From: Ferruh Yigit >> On 11/7/2019 12:35 PM, Dekel Peled wrote: >>> @@ -1266,6 +1286,18 @@ struct rte_eth_dev * >>> >> RTE_ETHER_MAX_LEN; >>> } >>> >>> + /* >>> +* If LRO is enabled, check that the maximum aggregated packet >>> +

Re: [dpdk-dev] [PATCH v4 2/3] net/mlx5: use API to set max LRO packet size

2019-11-08 Thread Ferruh Yigit
On 11/8/2019 9:12 AM, Slava Ovsiienko wrote: >> -Original Message- >> From: Dekel Peled >> Sent: Thursday, November 7, 2019 14:35 >> To: john.mcnam...@intel.com; marko.kovace...@intel.com; >> nhor...@tuxdriver.com; ajit.khapa...@broadcom.com; >> somnath.ko...@broadcom.com; anatoly.bura...@

Re: [dpdk-dev] [PATCH] net/ice: clear the HW tables when close device

2019-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, November 8, 2019 2:51 PM > To: Ye, Xiaolong > Cc: Yang, Qiming ; dev@dpdk.org > Subject: RE: [PATCH] net/ice: clear the HW tables when close device > > > > > -Original Message- > > From: Ye, Xiaolong > > Sent: Friday,

[dpdk-dev] [PATCH] net/ice: net/ice: free the HW tables when close device

2019-11-08 Thread Qi Zhang
Free the HW tables during dev_close. Otherwise there will be two issues: 1. Memory not be freed if the device is detached. 2. Driver can't be initialized correctly after device reset. Fixes: a4c8c48fe3f4 ("net/ice: load OS default package") Signed-off-by: Qi Zhang --- drivers/net/ice/ice_ethdev

Re: [dpdk-dev] [PATCH] ethdev: reserve space in main structs for extension

2019-11-08 Thread Thomas Monjalon
08/11/2019 04:41, Stephen Hemminger: > On Thu, 7 Nov 2019 23:15:24 +0100 > Thomas Monjalon wrote: > > > The struct rte_eth_dev and rte_eth_dev_data are supposed > > to be used internally only, but there is a chance that > > increasing their size would break ABI for some applications. > > In orde

Re: [dpdk-dev] [PATCH v16 1/8] ethdev: add set ptype function

2019-11-08 Thread Ferruh Yigit
On 11/8/2019 9:05 AM, Andrew Rybchenko wrote: > On 11/7/19 9:28 PM, Ferruh Yigit wrote: >> On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: >>> From: Pavan Nikhilesh >>> >>> Add `rte_eth_dev_set_ptypes` function that will allow the application >>> to inform the PMD about reduced range of pack

Re: [dpdk-dev] [PATCH] ethdev: reserve space in main structs for extension

2019-11-08 Thread Ferruh Yigit
On 11/7/2019 10:15 PM, Thomas Monjalon wrote: > The struct rte_eth_dev and rte_eth_dev_data are supposed > to be used internally only, but there is a chance that > increasing their size would break ABI for some applications. > In order to allow smooth addition of features without breaking > ABI com

[dpdk-dev] [PATCH] net: replace IP VHL DEF macro with RTE IPV4 VHL DEF

2019-11-08 Thread Reshma Pattan
Use new macro RTE_IPV4_VHL_DEF instead of IP_VHL_DEF wherever applicable. CC: xiaoyun...@intel.com CC: ferruh.yi...@intel.com CC: Bernard Iremonger CC: John Daley CC: Hyong Youb Kim Signed-off-by: Reshma Pattan --- app/test-pmd/csumonly.c| 3 --- app/test-pmd/flowgen.c

[dpdk-dev] [PATCH] examples/l2fwd-event: fix build on RHEL 7.6

2019-11-08 Thread David Marchand
CC l2fwd_event_generic.o .../l2fwd_event_generic.c: In function ‘l2fwd_rx_tx_adapter_setup_generic’: .../l2fwd_event_generic.c:203:3: error: missing initializer for field ‘impl_opaque’ of ‘struct ’ [-Werror=missing-field-initializers] } ^ In file included from .../l2fwd_event_generic.

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Matan Azrad
From: Ferruh Yigit > On 11/8/2019 6:54 AM, Matan Azrad wrote: > > Hi > > > > From: Ferruh Yigit > >> On 11/7/2019 12:35 PM, Dekel Peled wrote: > >>> @@ -1266,6 +1286,18 @@ struct rte_eth_dev * > >>> > >>RTE_ETHER_MAX_LEN; > >>> } > >>> > >>> + /* > >>> + * If LRO is enabled, check that the

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Andrew Rybchenko
On 11/7/19 9:56 AM, Matan Azrad wrote: > Hi > > From: Andrew Rybchenko >> On 11/6/19 9:58 AM, Matan Azrad wrote: >>> >>> >>> From: Andrew Rybchenko On 11/5/19 5:05 PM, Matan Azrad wrote: > From: Andrew Rybchenko >> On 11/3/19 6:16 PM, Matan Azrad wrote >>> From: Andrew Rybchenko >

Re: [dpdk-dev] [EXT] [PATCH v4 1/1] test/compress: unit tests refactoring

2019-11-08 Thread Akhil Goyal
> > -- > > Core engine refactoring (test_deflate_comp_decomp function). > > Smaller specialized functions created. > > > > Signed-off-by: Artur Trybula > > Acked-by: Adam Dybkowski > > --- > Acked-by : Shally Verma > .. Applied

Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 9:44 AM Olivier Matz wrote: > > On Wed, Nov 06, 2019 at 01:09:43PM +0100, Thomas Monjalon wrote: > > The constants like AF_INET are in sys/socket.h in FreeBSD. > > The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD > > in order to be consistent across DPDK fi

[dpdk-dev] [PATCH v15 05/19] raw/ifpga/base: add device tree support

2019-11-08 Thread Rosen Xu
From: Tianfei zhang In PAC N3000 card, this is a BMC chip which using MAX10 FPGA to manage the board configuration, like sensors, flash controller, QSFP, powers. And this is a SPI bus connected between A10 FPGA and MAX10, we can access the MAX10 registers over this SPI bus. In BMC, there are abo

[dpdk-dev] [PATCH v15 01/19] net/i40e: i40e support ipn3ke FPGA port bonding

2019-11-08 Thread Rosen Xu
From: Andy Pei In ipn3ke, each FPGA network side port bonding to an i40e pf, each i40e pf link status should get data from FPGA network, side port. This patch provide bonding relationship. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/i40e/base/i40e_type.h | 3 +++

[dpdk-dev] [PATCH v15 00/19] add PCIe AER disable and IRQ support for ipn3ke

2019-11-08 Thread Rosen Xu
This patch set adds PCIe AER disable and FPGA interrupt support for ipn3ke. It also provides a small rework for port bonding between FPGA line side port and I40e PF port. What is the PCI Express AER(Advanced Error Reporting)? Advanced Error Reporting capability is implemented with a PCI Express ad

[dpdk-dev] [PATCH v15 02/19] raw/ifpga/base: add irq support

2019-11-08 Thread Rosen Xu
From: Tianfei zhang Add irq support for ifpga FME global error, port error and uint unit. We implmented this feature by vfio interrupt mechanism. To build this feature, CONFIG_RTE_EAL_VFIO should be enabled. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- config/common_base

[dpdk-dev] [PATCH v15 07/19] raw/ifpga/base: add sensor support

2019-11-08 Thread Rosen Xu
From: Tianfei zhang The sensor devices are connected in MAX10 FPGA. we used the device tree to describe those sensor devices. Parse the device tree to get the sensor devices and add them into a list. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_intel_ma

[dpdk-dev] [PATCH v15 04/19] raw/ifpga/base: add SEU error support

2019-11-08 Thread Rosen Xu
From: Tianfei zhang This patch exposes SEU error information to application then application could compare this information (128bit) with its own SMH file to know if this SEU is a fatal error or not. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines

[dpdk-dev] [PATCH v15 06/19] raw/ifpga/base: align the send buffer for SPI

2019-11-08 Thread Rosen Xu
From: Tianfei zhang The length of send buffer of SPI bus should be 4bytes align. Signed-off-by: Tianfei Zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_spi_transaction.c | 40 --- 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/drivers/raw/

[dpdk-dev] [PATCH v15 08/19] raw/ifpga/base: introducing sensor APIs

2019-11-08 Thread Rosen Xu
From: Tianfei zhang Introducing sensor APIs to PMD driver for PAC N3000 card. Those sensor APIs: 1. opae_mgr_for_each_sensor() 2. opae_mgr_get_sensor_by_name() 3. opae_mgr_get_sensor_by_id() 4. opae_mgr_get_sensor_value_by_name() 5. opae_mgr_get_sensor_value_by_id() 6. opae_mgr_get_sensor_value(

[dpdk-dev] [PATCH v15 03/19] raw/ifpga/base: clear pending bit

2019-11-08 Thread Rosen Xu
From: Tianfei zhang Every defined bit in FME_ERROR0 is RW1C. Other reserved bits are always 0 when readout and it will plan to be RW1C if needed in future. So it is safe just write the read back value to clear all the errors. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/ra

[dpdk-dev] [PATCH v15 10/19] raw/ifpga: add SEU error handler

2019-11-08 Thread Rosen Xu
Add SEU interrupt support for FPGA. Signed-off-by: Tianfei zhang Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 245 +++ 1 file changed, 245 insertions(+) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/if

Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest

2019-11-08 Thread kkanas
Hi David, Thanks for review, hopefully this patch will addresses most of the sutff. Rest I will address here. > > > + const char *procdir = "/proc/self/fd/"; > > self is a Linux thing. > This won't work on FreeBSD. IMHO original code didn't worked on FreeBSD as well. I have created funct

[dpdk-dev] [PATCH v15 09/19] raw/ifpga/base: update SEU register definition

2019-11-08 Thread Rosen Xu
From: Tianfei zhang Update the SEU registser definition. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/base/ifpga_defines.h b/drivers/raw/ifpga/base/ifpg

[dpdk-dev] [PATCH v15 11/19] raw/ifpga: add PCIe BDF devices tree scan

2019-11-08 Thread Rosen Xu
Add PCIe BDF devices tree scan for ipn3ke. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 551 ++- drivers/raw/ifpga/ifpga_rawdev.h | 16 ++ 2 files changed, 562 insertions(+), 5 deletions(-) diff --git a/drivers/raw/

[dpdk-dev] [PATCH v15 14/19] raw/ifpga/base: configure FEC mode

2019-11-08 Thread Rosen Xu
From: Tianfei zhang We can change the PKVL FEC mode when the A10 NIOS FW initialization. The end-user can use this feature the change the FEC mode, the default mode is RS FEC mode. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_fme.c | 42 +++

[dpdk-dev] [PATCH v15 13/19] raw/ifpga/base: add secure support

2019-11-08 Thread Rosen Xu
From: Tianfei zhang Add secure max10 device support. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h| 2 + drivers/raw/ifpga/base/ifpga_fme.c| 26 -- drivers/raw/ifpga/base/opae_intel_max10.c | 137 +---

[dpdk-dev] [PATCH v3 1/3] test: fix timeout in flags autotest

2019-11-08 Thread kkanas
From: Krzysztof Kanas Test eal_flags_autotest times out on 64 ARM due to excessive calls to 'access' system call. While at it fix process_dup logic so it tests correct file path for opened fd's. Fixes: af75078fece3 ("first public release") Cc: intel.com Signed-off-by: Krzysztof Kanas --- app/

[dpdk-dev] [PATCH v3 2/3] test: move close files to separate function

2019-11-08 Thread kkanas
From: Krzysztof Kanas As iterating over opened files is different on Linux and FreeBSD move to separate function. Signed-off-by: Krzysztof Kanas --- app/test/process.h | 89 ++ 1 file changed, 50 insertions(+), 39 deletions(-) diff --git a/app/test/

[dpdk-dev] [PATCH v15 12/19] net/ipn3ke: remove configuration for i40e port bonding

2019-11-08 Thread Rosen Xu
The ipn3ke board FPGA and i40e BDF scan has added in ifpga_rawdev, so it doesn't need to provide configuration for i40e port bonding. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/ipn3ke/Makefile | 1 + drivers/net/ipn3ke/ipn3ke_ethdev.c| 293 ++

[dpdk-dev] [PATCH v15 15/19] raw/ifpga/base: clean fme errors

2019-11-08 Thread Rosen Xu
From: Tianfei zhang Clean fme errors register when some fme errors occurred. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_fme_error.c | 24 ++-- drivers/raw/ifpga/ifpga_rawdev.c | 22 ++ 2 files changed,

[dpdk-dev] [PATCH v15 17/19] raw/ifpga: add lightweight fpga image support

2019-11-08 Thread Rosen Xu
From: Andy Pei if fpga image support lightweight feature, set afu uuid to all 0, ipn3ke representor will not be probed. Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 44 +--- 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH v15 16/19] raw/ifpga/base: add new API get board info

2019-11-08 Thread Rosen Xu
From: Tianfei zhang Add new API to get the board info. opae_mgr_get_board_info() Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_api.c | 11 +++ drivers/raw/ifpga/base/ifpga_defines.h | 55 ++ drivers/raw/ifpga/base

[dpdk-dev] [PATCH v3 3/3] test: fix FreeBSD file closing function

2019-11-08 Thread kkanas
From: Krzysztof Kanas The FreeBSD was iterating over non existing procfs entries, where sysctl could give same information. Signed-off-by: Krzysztof Kanas --- app/test/process.h | 51 +- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/a

[dpdk-dev] [PATCH v15 18/19] raw/ifpga/base: add multiple cards support

2019-11-08 Thread Rosen Xu
From: Tianfei zhang In PAC N3000 card, there is one MAX10 chip in each card, and all of the sensors are connected to MAX10 chip. To support multiple cards in one server, we introducing a sensor device list under intel_max10_device instead of a global list. On the other hand, we using separate int

Re: [dpdk-dev] [PATCH v16 1/8] ethdev: add set ptype function

2019-11-08 Thread Andrew Rybchenko
On 11/8/19 12:52 PM, Ferruh Yigit wrote: > On 11/8/2019 9:05 AM, Andrew Rybchenko wrote: >> On 11/7/19 9:28 PM, Ferruh Yigit wrote: >>> On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Add `rte_eth_dev_set_ptypes` function that will allow the application >

[dpdk-dev] [PATCH v15 19/19] raw/ifpga: introducing new irq API

2019-11-08 Thread Rosen Xu
From: Tianfei zhang Introducing new register and unregister API for ifpga interrupt. 1. register FME and AFU interrupt ifpga_register_msix_irq() 2. unregister FME and AFU interrupt ifpga_unregister_msix_irq() On PAC N3000 card, there is one PCIe MSIX interrupt for FME managerment, like th

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Thomas Monjalon
08/11/2019 09:35, Andrew Rybchenko: > The problem: > > PMD wants to know before port start if application wants to > to use flow MARK/FLAG in the future. It is required because: > > 1. HW may be configured in a different way to reserve resources >for MARK/FLAG delivery > > 2. Dat

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Matan Azrad
From: Andrew Rybchenko > Sent: Friday, November 8, 2019 12:12 PM > To: Matan Azrad ; Pavan Nikhilesh Bhagavatula > ; ferruh.yi...@intel.com; Jerin Jacob > Kollanukkaran ; Thomas Monjalon > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads > set by PM

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Andrew Rybchenko
On 11/8/19 1:28 PM, Thomas Monjalon wrote: > 08/11/2019 09:35, Andrew Rybchenko: >> The problem: >> >> PMD wants to know before port start if application wants to >> to use flow MARK/FLAG in the future. It is required because: >> >> 1. HW may be configured in a different way to reserve

Re: [dpdk-dev] [PATCH] ethdev: reserve space in main structs for extension

2019-11-08 Thread Andrew Rybchenko
On 11/8/19 12:57 PM, Ferruh Yigit wrote: > On 11/7/2019 10:15 PM, Thomas Monjalon wrote: >> The struct rte_eth_dev and rte_eth_dev_data are supposed >> to be used internally only, but there is a chance that >> increasing their size would break ABI for some applications. >> In order to allow smooth

[dpdk-dev] [PATCH v3] app/test-crypto-perf: support PDCP

2019-11-08 Thread Akhil Goyal
test-crypto-perf app is updated to calculate PDCP throughput numbers. 2 new params are added for PDCP --pdcp-sn-sz <5/7/12/15/18> --pdcp-domain ./dpdk-test-crypto-perf --master-lcore 0 -l 0,1 --log-level=8 -- --devtype crypto_dpaa2_sec --optype pdcp --cipher-algo aes-ctr --cipher-op encrypt --au

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Thomas Monjalon
08/11/2019 11:42, Andrew Rybchenko: > On 11/8/19 1:28 PM, Thomas Monjalon wrote: > > 08/11/2019 09:35, Andrew Rybchenko: > >> The problem: > >> > >> PMD wants to know before port start if application wants to > >> to use flow MARK/FLAG in the future. It is required because: > >> > >> 1

Re: [dpdk-dev] [PATCH v16 1/8] ethdev: add set ptype function

2019-11-08 Thread Ferruh Yigit
On 11/8/2019 10:24 AM, Andrew Rybchenko wrote: > On 11/8/19 12:52 PM, Ferruh Yigit wrote: >> On 11/8/2019 9:05 AM, Andrew Rybchenko wrote: >>> On 11/7/19 9:28 PM, Ferruh Yigit wrote: On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add `rte_eth_dev

Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 11:21 AM wrote: > > Hi David, > > Thanks for review, hopefully this patch will addresses most of the sutff. > Rest I will address here. > > > > > > + const char *procdir = "/proc/self/fd/"; > > > > self is a Linux thing. > > This won't work on FreeBSD. > > IMHO origina

Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 12:05 PM David Marchand wrote: > > On Fri, Nov 8, 2019 at 11:21 AM wrote: > > > > Hi David, > > > > Thanks for review, hopefully this patch will addresses most of the sutff. > > Rest I will address here. > > > > > > > > > + const char *procdir = "/proc/self/fd/"; > >

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Andrew Rybchenko
On 11/8/19 1:29 PM, Matan Azrad wrote: > > > From: Andrew Rybchenko >> Sent: Friday, November 8, 2019 12:12 PM >> To: Matan Azrad ; Pavan Nikhilesh Bhagavatula >> ; ferruh.yi...@intel.com; Jerin Jacob >> Kollanukkaran ; Thomas Monjalon >> >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v15

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Ferruh Yigit
On 11/8/2019 10:10 AM, Matan Azrad wrote: > > > From: Ferruh Yigit >> On 11/8/2019 6:54 AM, Matan Azrad wrote: >>> Hi >>> >>> From: Ferruh Yigit On 11/7/2019 12:35 PM, Dekel Peled wrote: > @@ -1266,6 +1286,18 @@ struct rte_eth_dev * > RTE_ETHER_MAX_LEN; > } > >

Re: [dpdk-dev] [PATCH v16 1/8] ethdev: add set ptype function

2019-11-08 Thread Andrew Rybchenko
On 11/8/19 2:05 PM, Ferruh Yigit wrote: > On 11/8/2019 10:24 AM, Andrew Rybchenko wrote: >> On 11/8/19 12:52 PM, Ferruh Yigit wrote: >>> On 11/8/2019 9:05 AM, Andrew Rybchenko wrote: On 11/7/19 9:28 PM, Ferruh Yigit wrote: > On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: >> From

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Friday, November 8, 2019 7:04 PM > To: Andrew Rybchenko > Cc: Ori Kam ; dev@dpdk.org; > pbhagavat...@marvell.com; Yigit, Ferruh ; > jer...@marvell.com; Mcnamara, John ; > Kovacevic, Marko ; Adrien Mazarguil > ; david

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Matan Azrad
From: Andrew Rybchenko > On 11/8/19 1:29 PM, Matan Azrad wrote: > > > > > > From: Andrew Rybchenko > >> Sent: Friday, November 8, 2019 12:12 PM > >> To: Matan Azrad ; Pavan Nikhilesh Bhagavatula > >> ; ferruh.yi...@intel.com; Jerin Jacob > >> Kollanukkaran ; Thomas Monjalon > >> > >> Cc: dev@dpd

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Matan Azrad
From: Ferruh Yigit > On 11/8/2019 10:10 AM, Matan Azrad wrote: > > > > > > From: Ferruh Yigit > >> On 11/8/2019 6:54 AM, Matan Azrad wrote: > >>> Hi > >>> > >>> From: Ferruh Yigit > On 11/7/2019 12:35 PM, Dekel Peled wrote: > > @@ -1266,6 +1286,18 @@ struct rte_eth_dev * > > >

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Andrew Rybchenko
On 11/8/19 2:03 PM, Thomas Monjalon wrote: > 08/11/2019 11:42, Andrew Rybchenko: >> On 11/8/19 1:28 PM, Thomas Monjalon wrote: >>> 08/11/2019 09:35, Andrew Rybchenko: The problem: PMD wants to know before port start if application wants to to use flow MARK/FLAG in t

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Andrew Rybchenko
On 11/8/19 2:48 PM, Matan Azrad wrote: > > > From: Andrew Rybchenko >> On 11/8/19 1:29 PM, Matan Azrad wrote: >>> >>> >>> From: Andrew Rybchenko Sent: Friday, November 8, 2019 12:12 PM To: Matan Azrad ; Pavan Nikhilesh Bhagavatula ; ferruh.yi...@intel.com; Jerin Jacob Kollanuk

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Ori Kam
Hi Andrew, Thanks very much for the summery, I think this makes the discussion much better. (we even got some new folks 😊) I vote for B and C, Please read my comments below. Ori > -Original Message- > From: dev On Behalf Of Zhang, Qi Z > Sent: Friday, November 8, 2019 1:41 PM > To: T

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Andrew Rybchenko
On 11/8/19 3:12 PM, Ori Kam wrote: > > Hi Andrew, > > Thanks very much for the summery, I think this makes the discussion much > better. > (we even got some new folks 😊) > > I vote for B and C, > > Please read my comments below. > > Ori > >> -Original Message- >> From: dev On Behalf

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Thomas Monjalon
Hi, I see this patch is already merged in next-net-intel, but please I would prefer to have below improvements first. 07/11/2019 11:44, Haiyue Wang: > The original design is to use rte_mbuf::udata64 to save the metadata of > protocol extraction which has network protocol data fields and type, a >

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Ori Kam
Yes missed somehow 6. One more general comment, what happened until now? The Mark is already implemented and working more then 2 years. > -Original Message- > From: Andrew Rybchenko > Sent: Friday, November 8, 2019 2:20 PM > To: Ori Kam ; Zhang, Qi Z ; > Thomas Monjalon > Cc: dev@dpdk.o

[dpdk-dev] [PATCH v9 0/4] doc: changes to abi policy introducing major abi versions

2019-11-08 Thread Ray Kinsella
TL;DR abbreviation: A major ABI version that all DPDK releases during an agreed period support. ABI versioning is managed at a project-level, in place of library-level management. ABI changes to add new features are permitted, as long as ABI compatibility with the major ABI version is maintained.

[dpdk-dev] [PATCH v9 2/4] doc: changes to abi policy introducing major abi versions

2019-11-08 Thread Ray Kinsella
This policy change introduces major ABI versions, these are declared every year, typically aligned with the LTS release and are supported by subsequent releases in the following year. This change is intended to improve ABI stabilty for those projects consuming DPDK. Signed-off-by: Ray Kinsella Ac

[dpdk-dev] [PATCH v9 1/4] doc: separate versioning.rst into version and policy

2019-11-08 Thread Ray Kinsella
Separate versioning.rst into abi versioning and abi policy guidance, in preparation for adding more detail to the abi policy. Signed-off-by: Ray Kinsella Acked-by: John Mcnamara Acked-by: Stephen Hemminger --- doc/guides/contributing/abi_policy.rst | 167 doc/guides/contributing/a

[dpdk-dev] [PATCH v9 4/4] doc: add maintainer for abi policy

2019-11-08 Thread Ray Kinsella
Add an entry to the maintainer file for the abi policy. Signed-off-by: Ray Kinsella Acked-by: John Mcnamara --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 717c318..d5bb806 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -84,6 +84,10 @@ M: M

[dpdk-dev] [PATCH v9 3/4] doc: updates to versioning guide for abi versions

2019-11-08 Thread Ray Kinsella
Updates to the ABI versioning guide, to account for the changes to the DPDK ABI/API policy. Fixes for references to abi versioning and policy guides. Signed-off-by: Ray Kinsella Acked-by: John Mcnamara Acked-by: Stephen Hemminger --- doc/guides/contributing/abi_policy.rst | 15 +- doc/gui

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Ferruh Yigit
On 11/8/2019 11:56 AM, Matan Azrad wrote: > > > From: Ferruh Yigit >> On 11/8/2019 10:10 AM, Matan Azrad wrote: >>> >>> >>> From: Ferruh Yigit On 11/8/2019 6:54 AM, Matan Azrad wrote: > Hi > > From: Ferruh Yigit >> On 11/7/2019 12:35 PM, Dekel Peled wrote: >>> @@ -1266,6

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Thomas Monjalon
07/11/2019 11:44, Haiyue Wang: > --- a/drivers/net/ice/rte_pmd_ice_version.map > +++ b/drivers/net/ice/rte_pmd_ice_version.map > +EXPERIMENTAL { > + global: > + > + # added in 19.11 > + rte_net_ice_dynfield_proto_xtr_metadata_offs; > + rte_net_ice_dynflag_proto_xtr_vlan_mask; > +

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Thomas Monjalon
08/11/2019 13:09, Andrew Rybchenko: > On 11/8/19 2:48 PM, Matan Azrad wrote: > > From: Andrew Rybchenko > >> It does 3 things for all port at the end of rte_eth_dev_configure() based > >> on > >> dev->data->dev_conf (if PMD updates it in the case of violations). > >> > >> 1. If requested offload i

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Thomas Monjalon
08/11/2019 12:40, Zhang, Qi Z: > > > -Original Message- > > From: dev On Behalf Of Thomas Monjalon > > Sent: Friday, November 8, 2019 7:04 PM > > To: Andrew Rybchenko > > Cc: Ori Kam ; dev@dpdk.org; > > pbhagavat...@marvell.com; Yigit, Ferruh ; > > jer...@marvell.com; Mcnamara, John ; >

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Ananyev, Konstantin
> -Original Message- > From: Matan Azrad > Sent: Friday, November 8, 2019 11:56 AM > To: Yigit, Ferruh ; Dekel Peled > ; Mcnamara, John ; > Kovacevic, Marko ; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; > somnath.ko...@broadcom.com; Burakov, Anatoly ; > xuanziya...@huawei.com

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Ori Kam > Sent: Friday, November 8, 2019 8:43 PM > To: Andrew Rybchenko ; Zhang, Qi Z > ; Thomas Monjalon > Cc: dev@dpdk.org; pbhagavat...@marvell.com; Yigit, Ferruh > ; jer...@marvell.com; Mcnamara, John > ; Kovacevic, Marko > ; Adrien Mazarguil > ; david.m

Re: [dpdk-dev] [PATCH v1 1/6] doc: documentation update

2019-11-08 Thread Akhil Goyal
> > Hi Akhil, > If I use fix as a tag. I get the below message. > Is this messages is ok or do we need to have bug numbers for this? > > ./devtools/check-git-log.sh > Missing 'Fixes' tag: > doc: fix app usage in CCP guide > > Regards, > S.Amarnath > Yes, it should have a fixes tag Fo

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Thomas Monjalon
08/11/2019 13:00, Andrew Rybchenko: > On 11/8/19 2:03 PM, Thomas Monjalon wrote: > > 08/11/2019 11:42, Andrew Rybchenko: > >> On 11/8/19 1:28 PM, Thomas Monjalon wrote: > >>> 08/11/2019 09:35, Andrew Rybchenko: > The problem: > > PMD wants to know before port start if ap

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Thomas Monjalon
08/11/2019 14:16, Zhang, Qi Z: > From: Ori Kam > > > > Yes missed somehow 6. > > One more general comment, what happened until now? The Mark is already > > implemented and working more then 2 years. > > Actually we get many complain on i40e driver does not support MARK due to > vector path is s

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Andrew Rybchenko
On 11/8/19 4:17 PM, Thomas Monjalon wrote: > 08/11/2019 13:00, Andrew Rybchenko: >> On 11/8/19 2:03 PM, Thomas Monjalon wrote: >>> 08/11/2019 11:42, Andrew Rybchenko: On 11/8/19 1:28 PM, Thomas Monjalon wrote: > 08/11/2019 09:35, Andrew Rybchenko: >> The problem: >> >>

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-08 Thread Thomas Monjalon
08/11/2019 14:27, Andrew Rybchenko: > On 11/8/19 4:17 PM, Thomas Monjalon wrote: > > 08/11/2019 13:00, Andrew Rybchenko: > >> On 11/8/19 2:03 PM, Thomas Monjalon wrote: > >>> 08/11/2019 11:42, Andrew Rybchenko: > On 11/8/19 1:28 PM, Thomas Monjalon wrote: > > 08/11/2019 09:35, Andrew Rybch

Re: [dpdk-dev] [PATCH v3] app/testpmd: add hairpin support

2019-11-08 Thread Ferruh Yigit
On 11/5/2019 7:05 PM, Ori Kam wrote: > This commit introduce the hairpin queues to the testpmd. > the hairpin queue is configured using --hairpinq= > the hairpin queue adds n queue objects for both the total number > of TX queues and RX queues. > The connection between the queues are 1 to 1, first

Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 12:05 PM David Marchand wrote: > > On Fri, Nov 8, 2019 at 11:21 AM wrote: > > > > Hi David, > > > > Thanks for review, hopefully this patch will addresses most of the sutff. > > Rest I will address here. > > > > > > > > > + const char *procdir = "/proc/self/fd/"; > >

Re: [dpdk-dev] [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask

2019-11-08 Thread Ananyev, Konstantin
> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Thursday, November 7, 2019 7:41 PM > To: Jerin Jacob > Cc: Pavan Nikhilesh ; Andrew Rybchenko > ; jer...@marvell.com; > tho...@monjalon.net; Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Mcnamara, John ; > Kov

Re: [dpdk-dev] [PATCH v4 3/3] app/testpmd: use API to set max LRO packet size

2019-11-08 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 7, 2019 10:26 PM > To: Dekel Peled ; john.mcnam...@intel.com; > marko.kovace...@intel.com; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; > anatoly.bura...@intel.com; xuanzi

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Wang, Haiyue
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, November 8, 2019 20:55 > To: Wang, Haiyue > Cc: dev@dpdk.org; olivier.m...@6wind.com; Ye, Xiaolong > ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by > dynamic mbuf A

Re: [dpdk-dev] [v2 PATCH 0/8] Coverity fixes and other cleanups

2019-11-08 Thread David Marchand
On Wed, Nov 6, 2019 at 8:02 PM Kevin Traynor wrote: > > Patches 1-4 are Coverity fixes. > Patches 5-8 are removing commented out code. > > v2: > - 1/8: removed added NULL check for devargs_all > - 2/8: fixed headline to common/cpt > - v1 3/9 'net/bnxt: remove logically dead code' > removed as du

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Wang, Haiyue
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, November 8, 2019 20:34 > To: Wang, Haiyue > Cc: dev@dpdk.org; olivier.m...@6wind.com; Ye, Xiaolong > ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by > dynamic mbuf A

Re: [dpdk-dev] [PATCH v8 2/4] doc: changes to abi policy introducing major abi versions

2019-11-08 Thread Ray Kinsella
On 06/11/2019 21:07, Thomas Monjalon wrote: > Hi, > Please find the techboard comments below. > > 06/11/2019 10:22, Ray Kinsella: >> On 06/11/2019 09:06, Thomas Monjalon wrote: >>> 06/11/2019 09:49, Ray Kinsella: On 06/11/2019 00:11, Thomas Monjalon wrote: > 05/11/2019 16:24, Ray Kinse

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, November 8, 2019 3:11 PM > To: Matan Azrad ; Yigit, Ferruh > ; Dekel Peled ; Mcnamara, > John ; Kovacevic, Marko > ; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Burakov, > An

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: fix build on RHEL 7.6

2019-11-08 Thread Kevin Traynor
On 08/11/2019 10:04, David Marchand wrote: > CC l2fwd_event_generic.o > .../l2fwd_event_generic.c: In function > ‘l2fwd_rx_tx_adapter_setup_generic’: > .../l2fwd_event_generic.c:203:3: error: missing initializer for field > ‘impl_opaque’ of ‘struct ’ > [-Werror=missing-field-initializers] >

Re: [dpdk-dev] [PATCH v2 00/19] net/mlx5: support meter

2019-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Friday, November 8, 2019 5:49 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Ori Kam ; Raslan Darawsheh > ; dev@dpdk.org > Subject: [PATCH v2 00/19] net/mlx5: support meter > > The patches introduce the meter action support for mlx5.

Re: [dpdk-dev] SPDX check: files with missing or redundant license info

2019-11-08 Thread Bruce Richardson
On Thu, Nov 07, 2019 at 08:28:49PM -0800, Stephen Hemminger wrote: > Patches are outstanding for some of these. > The big area with missing SPDX tags is all the ipsec-secgw shell scripts. > > No local changes to save > > Files without SPDX License > -- > > usertools/dpdk

Re: [dpdk-dev] [PATCH v7 00/12] Add an option to use LTO for DPDK build

2019-11-08 Thread Thomas Monjalon
07/11/2019 16:03, Andrzej Ostruszka: > This patch series adds an option to make use of link time optimization > (if compiler has support for it). It is split as follows: > - 1st patch is just a minor doc fix for versioning macros > - 2nd patch fixes missing __vsym annotations (needed for LTO) > -

Re: [dpdk-dev] [EXT] Re: [PATCH v12 0/2] add IOVA=VA mode support

2019-11-08 Thread Ferruh Yigit
>> Hi Vasim, Jerin, >> >> Overall looks good and I not getting any functional error but I am observing >> a >> huge performance drop with this update, 3.8Mpps to 0.7Mpps [1]. > > Hi Ferruh, > When it comes to actual kernel netdev test cases like iperf or any other use > cases, there wou

[dpdk-dev] [PATCH] usertools/dpdk-telemetry-client: fix typo in SPDX tag

2019-11-08 Thread Bruce Richardson
There is a typo in the SPDX tag, which is down as an "SPDK" tag. One-character change should be all that is needed. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: sta...@dpdk.org Reported-by: Stephen Hemminger Signed-off-by: Bruce Richardson --- usertools/dpdk-telemetry

  1   2   >