Coverity issue: 350592
Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
Cc: sta...@dpdk.org
Signed-off-by: Jin Yu
---
examples/vhost_blk/vhost_blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/v
Fix the time of check time of use warning in example code
Coverity issue: 350589 158663
Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
Cc: sta...@dpdk.org
Signed-off-by: Jin Yu
---
examples/vhost_blk/vhost_blk.c | 9 ++---
1 file changed, 2 insertions(+), 7 delet
When using mkstemp(), remember to safely set the umask
before to restrict the resulting temporary file
permissions to only the owner.
Coverity issue: 350367
Fixes: d87f1a1cb7b6 ("vhost: support inflight info sharing")
Cc: sta...@dpdk.org
Signed-off-by: Jin Yu
---
lib/librte_vhost/vhost_user.c |
On Tue, Nov 26, 2019 at 4:04 PM Sunil Kumar Kori wrote:
>
> loopback mode is not supported for VFs so returning error if
> VF is being configured with loopback mode.
>
> Fixes: 920717e4d8ba ("net/octeontx2: add device start operation")
Cc: sta...@dpdk.org
>
> Signed-off-by: Sunil Kumar Kori
> -
From: Wang Yinan
add virtio paths selection and usage introduction for better
virtio usability.
Signed-off-by: Wang Yinan
---
doc/guides/howto/index.rst| 1 +
.../virtio_paths_selection_and_usage.rst | 142 ++
2 files changed, 143 insertions(+)
creat
Hello Matan and Slava,
Thanks for your quick response.
How about the following?
BR,
Hideyuki Yamashita
NTT TechnoCross
> Hello Matan and Slava,
>
> Thanks for your quick response.
>
> 1. What you were saying is correct.
> When I create flow with dst mac 10:22:33:44:55:66 instead of
> 11:22:3
loopback mode is not supported for VFs so returning error if
VF is being configured with loopback mode.
Fixes: 920717e4d8ba ("net/octeontx2: add device start operation")
Signed-off-by: Sunil Kumar Kori
---
drivers/net/octeontx2/otx2_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The following changes since commit bdc993fa3dc38d6ae2d4d1480604556bc20a5522:
mem: clarify documentation of virt2iova behaviour (2019-11-26 00:30:51 +0100)
are available in the Git repository at:
http://dpdk.org/git/next/dpdk-next-eventdev
for you to fetch changes up to 292af427c47293a923679
nic bind to mlx5_core, enable sriov, nic has one pf and 8 vfs,
bind pf to vfio-pci failed, can not regress to mlx5_core
Signed-off-by: Wei Hui
---
usertools/dpdk-devbind.py | 165 ++
1 file changed, 94 insertions(+), 71 deletions(-)
diff --git a/usertools/dpd
Multiple experimental symbols are used. They must be allowed
to avoid compilation error.
Signed-off-by: Sunil Kumar Kori
---
drivers/common/octeontx2/Makefile | 2 ++
drivers/common/octeontx2/meson.build | 2 ++
drivers/net/octeontx2/Makefile| 2 ++
drivers/net/octeontx2/meson.build
On 11/26, Xiao Wang wrote:
>It's possible that we fail to get the IOMMU group of ifcvf device, this
>patch adds a check on the return value.
>
>Coverity issue: 349894
>Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Xiao Wang
>---
> drivers/net/ifc/i
On Wed, Nov 20, 2019 at 10:39 PM Jerin Jacob wrote:
>
> On Thu, Nov 7, 2019 at 2:34 PM Hemant Agrawal wrote:
> >
> > The IV was not set, which was causing HW based SEC on DPAA1
> > to fail.
> >
> > Fixes: ce02103ad072 ("test/event_crypto: change the SEC cipher algo")
> >
> > Signed-off-by: Hemant
On Fri, Nov 22, 2019 at 4:23 AM wrote:
>
> From: Pavan Nikhilesh
>
> Fix unchecked return values reported by coverity.
>
> Coverity Issue: 336861
> Coverity Issue: 349906
> Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh
Changed
On Fri, Nov 22, 2019 at 4:22 AM wrote:
>
> From: Pavan Nikhilesh
>
> Fix possible divide by zero condition when calculating percentages.
>
> Coverity Issue: 277205
> Coverity Issue: 277234
> Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a producer")
> Cc: sta...@dpdk.org
>
> Sign
On Fri, Nov 22, 2019 at 3:27 AM wrote:
>
> From: Pavan Nikhilesh
>
> Fix incorrect command line argument documented for l2fwd-event.
>
> Bugzilla ID: 367
> Bugzilla ID: 368
> Fixes: 14d7ea259aeb ("doc: add application usage guide for l2fwd-event")
>
> Reported-by: Vipin Varghese
> Signed-off-by:
On Fri, Nov 22, 2019 at 3:27 AM wrote:
>
> From: Pavan Nikhilesh
>
> Validate `rte_eth_link_get_nowait`, `rte_service_map_lcore_set` and
> `rte_eth_dev_info_get` return values.
>
> Coverity issue: 350600
> Coverity issue: 350601
> Coverity issue: 350602
>
> Signed-off-by: Pavan Nikhilesh
Applie
Hi Yinan,
Thanks for the work! Will take a closer look ASAP.
Please see some quick comments inline.
On Tue, Nov 26, 2019 at 05:42:38AM -0500, Yinan wrote:
> From: Wang Yinan
>
> add virtio paths selection and usage introduction for better
> virtio usability.
>
> Signed-off-by: Wang Yinan
>
It's possible that we fail to get the IOMMU group of ifcvf device, this
patch adds a check on the return value.
Coverity issue: 349894
Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Wang
---
drivers/net/ifc/ifcvf_vdpa.c | 8 ++--
1 file chan
On 11/26, Lu, Wenzhuo wrote:
>Hi,
>
>> -Original Message-
>> From: Cui, LunyuanX
>> Sent: Wednesday, November 13, 2019 8:47 PM
>> To: dev@dpdk.org
>> Cc: Lu, Wenzhuo ; Yang, Qiming
>> ; Cui, LunyuanX ;
>> sta...@dpdk.org
>> Subject: [PATCH] net/e1000: fix link status
>>
>> The link status
Adding new API function to query the maximum key ID
that could possibly be returned by rte_hash_add_key and
rte_hash_add_key_with_hash. When RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD
is set, the maximum key id is larger than the entry count specified
by the user.
Signed-off-by: Kumar Amber
---
lib/l
Hi,
> -Original Message-
> From: Cui, LunyuanX
> Sent: Wednesday, November 13, 2019 8:47 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Cui, LunyuanX ;
> sta...@dpdk.org
> Subject: [PATCH] net/e1000: fix link status
>
> The link status got from link status register was not cor
Hi, yinan
Minor nit, please use '--in-reply-to' when using git-send-email, it helps
tracking
all history about this patch together.
Thanks,
Xiaolong
On 11/26, Yinan wrote:
>From: Wang Yinan
>
>add virtio paths selection and usage introduction for better
>virtio usability.
>
>Signed-off-by: Wan
On 11/26, Lu, Wenzhuo wrote:
>Hi,
>
>
>> -Original Message-
>> From: Cui, LunyuanX
>> Sent: Monday, November 18, 2019 11:38 PM
>> To: dev@dpdk.org
>> Cc: Lu, Wenzhuo ; Cui, LunyuanX
>> ; sta...@dpdk.org
>> Subject: [PATCH v4] net/ixgbe: fix link status
>>
>> The link status for 82599eb got
On 11/20, Lunyuan Cui wrote:
>There is no need to judge the original link state,
>only update the data according to the current link state.
>It can maintain better robustness.
>
>In addition, this patch change the variable
>from link_check to link_up.
>
>Fixes: 80ba61115e77 ("net/e1000: use link st
Hi,
> -Original Message-
> From: Cui, LunyuanX
> Sent: Monday, November 18, 2019 11:38 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; Cui, LunyuanX
> ; sta...@dpdk.org
> Subject: [PATCH v4] net/ixgbe: fix link status
>
> The link status for 82599eb got from link status register was not correc
Hi,
> -Original Message-
> From: Cui, LunyuanX
> Sent: Thursday, November 14, 2019 1:33 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Cui, LunyuanX ;
> sta...@dpdk.org
> Subject: [PATCH] net/e1000: fix link status update
>
> Unassigned variable should not be used as judgment,
From: Wang Yinan
add virtio paths selection and usage introduction for better
virtio usability.
Signed-off-by: Wang Yinan
---
doc/guides/howto/index.rst| 1 +
.../virtio_paths_selection_and_usage.rst | 142 ++
2 files changed, 143 insertions(+)
creat
On Mon, 25 Nov 2019 23:56:00 +0100
Thomas Monjalon wrote:
> 05/11/2019 02:56, Stephen Hemminger:
> > When doing a cross compiling it is common to use EXTRA_CFLAGS with
> > --sysroot option to point to alternate root filesystem. This already
> > works as expected for objects and executables, it ju
18/11/2019 14:14, Olivier Matz:
> On Thu, Nov 14, 2019 at 02:13:06PM +, Anatoly Burakov wrote:
> > It may not be immediately clear that rte_mem_virt2iova does not actually
> > check the internal memseg table, and will instead either return VA (in
> > IOVA as VA mode), or will fall back to kerne
25/11/2019 16:00, David Hunt:
> Should be passing errno rather than ret, which could be negative.
>
> Coverity issue: 350362
> Fixes: 9dc843eb273b ("power: extend guest channel API for reading")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Hunt
Applied, thanks
21/11/2019 16:14, Burakov, Anatoly:
> On 21-Nov-19 2:25 PM, Xueming Li wrote:
> > This patch fixes wrong inner memory element size when joining two
> > elements.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Xueming Li
> > ---
> > --- a/lib/l
25/11/2019 23:55, Dharmik Thakkar:
>
> > On Nov 25, 2019, at 4:44 PM, Thomas Monjalon wrote:
> >
> > 25/11/2019 23:02, Wang, Yipeng1:
> >> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> >>> 25/11/2019 19:49, Wang, Yipeng1:
> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>
11/11/2019 20:50, Stephen Hemminger:
> Remove trailing blank lines. They serve no purpose and are just
> editor leftovers.
> These can cause git to complain about whitespace errors during merges.
>
> Signed-off-by: Stephen Hemminger
I rebased and added few new occurences, plus some doc ones.
Ap
05/11/2019 02:56, Stephen Hemminger:
> When doing a cross compiling it is common to use EXTRA_CFLAGS with
> --sysroot option to point to alternate root filesystem. This already
> works as expected for objects and executables, it just doesn't work
> correctly for shared libraries.
>
> When a shared
> On Nov 25, 2019, at 4:44 PM, Thomas Monjalon wrote:
>
> 25/11/2019 23:02, Wang, Yipeng1:
>> From: Thomas Monjalon [mailto:tho...@monjalon.net]
>>> 25/11/2019 19:49, Wang, Yipeng1:
From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>
> Remove __hash_rw_reader_unlock() calls fro
Aaron Conole writes:
> Thomas Monjalon writes:
>
>>> From: Aaron Conole
>>> > - if (!service_valid(id))
>>> > + if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
>>
>> Why not adding this check in service_valid()?
>
> I think the best fix is to use SERVICE_VALID_GET_OR_ERR_RET() in these
> p
07/08/2019 07:40, Matan Azrad:
>
> Acked-by: Matan Azrad
>
> From: Stephen Hemminger
> > Sent: Monday, August 5, 2019 7:38 PM
> >
> > v7 - widen port mask to allow 64 ports
> >
> > v6 - just include fixes; cleanups can wait until 19.11
> >
> > v5 - change logic in server_mp for evaluating po
25/11/2019 23:02, Wang, Yipeng1:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> >25/11/2019 19:49, Wang, Yipeng1:
> >> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
> >> >
> >> >Remove __hash_rw_reader_unlock() calls from lock free hash lookup
> >> >
> >> >Signed-off-by: Dharmik Th
25/11/2019 04:36, Gavin Hu:
> If the RTE_MAX_LCORE is less than 10, a compilation error is generated:
> app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
> expressions of different signedness: ‘unsigned int’ and ‘int’
> [-Werror=sign-compare]
>
> The cause is (RTE_MAX_LCORE - 10) resul
On Mon, 25 Nov 2019 16:13:26 +0300
Vadim wrote:
> + MODE4_DEBUG("prefered partner system
> %02x:%02x:%02x:%02x:%02x:%02x "
> + "not equal self system:
> %02x:%02x:%02x:%02x:%02x:%02x\n",
> + partner->port_params.system.addr_byt
22/11/2019 12:30, Ferruh Yigit:
> This patch functionally reverts the patch in fixes line to not have any
> hardcoded library path in the final binary for the security reasons, in
> case this binary distributed to production environment.
>
> RPATH only added in RTE_DEVEL_BUILD case and this binary
>-Original Message-
>From: Thomas Monjalon [mailto:tho...@monjalon.net]
>Sent: Monday, November 25, 2019 1:55 PM
>To: Wang, Yipeng1 ; Dharmik Thakkar
>
>Cc: dev@dpdk.org; Gobriel, Sameh ; Richardson, Bruce
>;
>honnappa.nagaraha...@arm.com
>Subject: Re: [dpdk-dev] [PATCH] lib/hash: remove
> On Nov 25, 2019, at 3:46 PM, Frank Li wrote:
>
> Current IPv6 functionality in pktgen is broken. This fix makes it so that
> IPv6 addresses are properly set when using the set, sequence, and save
> commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses
> are properly set.
>
25/11/2019 19:49, Wang, Yipeng1:
> >-Original Message-
> >From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
> >Sent: Thursday, November 21, 2019 10:18 AM
> >To: Wang, Yipeng1 ; Gobriel, Sameh
> >; Richardson, Bruce
> >
> >Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; Dharmik Thakkar
Current IPv6 functionality in pktgen is broken. This fix makes it so that
IPv6 addresses are properly set when using the set, sequence, and save
commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses
are properly set.
To preserve the runtime commands, the `_atoip` function no lon
25/11/2019 11:27, Olivier Matz:
> On Mon, Nov 25, 2019 at 10:21:32AM +, Shahaf Shuler wrote:
> > With the API and ABI freeze ahead, it will be good to reserve
> > some bits on the private structure for future use.
> >
> > Otherwise we will potentially need to maintain two different
> > private
> -Original Message-
> From: dev On Behalf Of Chen, Zhaoyan
> Sent: Friday, November 22, 2019 2:13 AM
> To: dev@dpdk.org
> Cc: Li, WenjieX A
> Subject: [dpdk-dev] [PATCH V1] doc: add tested Intel platforms with Intel
> NICs
>
> From: Wenjie Li
>
> Add tested Intel platforms with Int
Hi, Amber, Thanks for the patch! A bit comment inlined:
>-Original Message-
>From: Amber, Kumar
>Sent: Monday, November 25, 2019 3:08 AM
>To: dev@dpdk.org
>Cc: Wang, Yipeng1
>Subject: [PATCH v3] hash: added a new API to hash to query key id
>
>Adding new API function to query the maximum
13/11/2019 14:05, Alejandro Lucero:
> On Wed, Nov 13, 2019 at 12:55 PM Ferruh Yigit
> wrote:
> > On 11/13/2019 12:47 PM, Alejandro Lucero wrote:
> > > I'm leaving Netronome and will not work with the NFP anymore.
[...]
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > Netronome nfp
> > > -M:
>-Original Message-
>From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>Sent: Thursday, November 21, 2019 10:18 AM
>To: Wang, Yipeng1 ; Gobriel, Sameh
>; Richardson, Bruce
>
>Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; Dharmik Thakkar
>
>Subject: [PATCH] lib/hash: remove unnecess
Thomas Monjalon writes:
>> From: Aaron Conole
>> > - if (!service_valid(id))
>> > + if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
>
> Why not adding this check in service_valid()?
I think the best fix is to use SERVICE_VALID_GET_OR_ERR_RET() in these
places. For this, I at least want
---
drivers/net/af_packet/rte_eth_af_packet.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
b/drivers/net/af_packet/rte_eth_af_packet.c
index f5806bf42..eb1902170 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++
From: podovinnikov
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c
b/drivers/net/bonding/rte_eth_bond_8023ad.c
index b77a37ddb..132ff74a1 100644
--- a/drivers/net/b
> From: Aaron Conole
> > - if (!service_valid(id))
> > + if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
Why not adding this check in service_valid()?
Hey Folks,
> -Original Message-
> From: Aaron Conole
> Sent: Monday, November 25, 2019 4:59 PM
> To: Amber, Kumar
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Yigit, Ferruh
> ; tho...@monjalon.net; Van Haaren, Harry
> ; Thakur, Sham Singh
> ; David Marchand
> Subject: Re: [dpdk-dev] [PATCH v3] h
In order to change RSS parameters, the host requires that RSS
is disable first.
Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: sta...@dpdk.org
Signed-off-by: Dexuan Cui
Signed-off-by: Stephen Hemminger
---
drivers/net/netvsc/hn_ethdev.c | 14 ++
1 file ch
On 11/7/2019 9:13 AM, Hemant Agrawal wrote:
> Alejandro,
> Please ack this patch also.
Unfortunately we don't have a nfp PMD maintainer as of now.
If this PMD keeps holding the updates, unfortunately we need to consider
removing the PMD from DPDK.
>
> Regards,
> Hemant
>
>> -Original
"Amber, Kumar" writes:
> Hi all ,
>
> I want to report random untouched unit test cases failed by Jenkins
> . pls can you guys check why it is unstable ?
> Every upload shows random test failed .
>
> http://mails.dpdk.org/archives/test-report/2019-November/109120.html
I think the service core c
When searching for raw devices with the correct type, we check the driver
name using strcmp, without first checking that the call to info get
succeeded and assigned a value to that pointer.
If the call to get the device info fails, we can treat it as if the device
didn't match, and continue the lo
On 11/19/2019 3:04 PM, Ferruh Yigit wrote:
> On 11/19/2019 12:12 PM, Andrew Rybchenko wrote:
>> The functionality is added, but the deprecation notice is not
>> removed.
>>
>> Fixes: 5d4813acda2c ("ethdev: add packet type range function")
>>
>> Signed-off-by: Andrew Rybchenko
>
> Acked-by: Ferruh
On 11/19/2019 3:04 PM, Ferruh Yigit wrote:
> On 11/19/2019 12:12 PM, Andrew Rybchenko wrote:
>> The offload was added, but the deprecation notice was not removed.
>>
>> Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
>>
>> Signed-off-by: Andrew Rybchenko
>
> Acked-by: Ferruh Yig
On Mon, Nov 25, 2019 at 03:23:03PM +, Bruce Richardson wrote:
> On a failure with the ioat dequeue, -1 is returned, which was not properly
> handled. This could lead to out-of-bounds reads on a later loop which
> assumed a positive return value. Fix this by treating an error as though a
> deque
On Sun, Nov 24, 2019 at 9:18 PM David Marchand
wrote:
> - I don't think variables were considered in the rte_experimental
> framework: seeing the __rte_experimental macro, I doubt it would work
> for variables to be put in .text.
> Do we need a different marker for those? or did I miss something e
So far, we did not pay attention to direct access to variables but they
are part of the API/ABI too and should be clearly identified.
Introduce a __rte_experimental_var tag and mark existing variables.
Fixes: a4bcd61de82d ("buildtools: add script to check experimental API exports")
Cc: sta...@dpd
On 11/25/2019 9:00 AM, Wei Hu (Xavier) wrote:
> From: "Wei Hu (Xavier)"
>
> In .tx_pkt_burst ops implementation function of hns3 PMD driver,
> there is one check whether there are enough BDs in the TX queue.
> If not, driver will stop sending the packets.
>
> Currently in the 'for' process loop,
On 11/25/2019 3:55 PM, Pavan Nikhilesh Bhagavatula wrote:
> Hi Ferruh,
>
>> -Original Message-
>> From: dev On Behalf Of Ferruh Yigit
>> Sent: Monday, November 25, 2019 7:32 PM
>> To: Jerin Jacob ; Pavan Nikhilesh Bhagavatula
>>
>> Cc: Jerin Jacob Kollanukkaran ; Nithin Kumar
>> Dabilpur
"Amber, Kumar" writes:
> Hi all ,
>
> I want to report random untouched unit test cases failed by Jenkins
> . pls can you guys check why it is unstable ?
> Every upload shows random test failed .
I'll work on the service_autotest patch.
> http://mails.dpdk.org/archives/test-report/2019-November
On 11/25/2019 9:00 AM, Wei Hu (Xavier) wrote:
> From: "Wei Hu (Xavier)"
>
> In .tx_pkt_burst ops implementation function of hns3 PMD driver,
> there is one check whether there are enough BDs in the TX queue.
Out of curiosity, is BD refers to "buffer descriptor"? What is the difference
between Tx
Hi Ferruh,
>-Original Message-
>From: dev On Behalf Of Ferruh Yigit
>Sent: Monday, November 25, 2019 7:32 PM
>To: Jerin Jacob ; Pavan Nikhilesh Bhagavatula
>
>Cc: Jerin Jacob Kollanukkaran ; Nithin Kumar
>Dabilpuram ; Kiran Kumar Kokkilagadda
>; dpdk-dev
>Subject: Re: [dpdk-dev] [PATCH]
From: Wang Yinan
add virtio paths selection and usage introduction for better
virtio usability.
Signed-off-by: Wang Yinan
---
.../virtio_paths_selection_and_usage.rst | 142 ++
1 file changed, 142 insertions(+)
create mode 100644 doc/guides/howto/virtio_paths_selection_an
Hi all ,
I want to report random untouched unit test cases failed by Jenkins . pls can
you guys check why it is unstable ?
Every upload shows random test failed .
http://mails.dpdk.org/archives/test-report/2019-November/109120.html
Regards
Amber
-Original Message-
From: dev On Beha
Thanks your suggestion, I will add the link in v2 version.
> -Original Message-
> From: Stephen Hemminger
> Sent: 2019年11月18日 10:24
> To: Wang, Yinan
> Cc: dev@dpdk.org; maxime.coque...@redhat.com; Bie, Tiwei
> ; Wang, Zhihong ;
> Mcnamara, John ; Kovacevic, Marko
>
> Subject: Re: [dpdk
To get the amount of memory needed for stats, we call the xstats_get_names
function with a NULL parameter, which can return -1 on error. This negative
value was not previously handled correctly, so we adjust things to quit the
stats printing routine if this basic call fails.
Coverity issue: 350346
On 11/22/2019 11:31 PM, Rasesh Mody wrote:
> - Add note for sharing an adapter between DPDK and Linux drivers.
> - Update the firmware version in example.
> - Add Config note for potential error due to lack of memzone desciptor
>count.
>
> Signed-off-by: Rasesh Mody
Applied to dpdk-next-n
On a failure with the ioat dequeue, -1 is returned, which was not properly
handled. This could lead to out-of-bounds reads on a later loop which
assumed a positive return value. Fix this by treating an error as though a
dequeue of 0 had been encountered.
Coverity issue: 350342
Fixes: 2328542ed84e
On 25-Nov-19 2:55 PM, Bruce Richardson wrote:
Add instructions on building DPDK and using the pkg-config file to the
linux GSG.
Signed-off-by: Bruce Richardson
---
Acked-by: Anatoly Burakov
--
Thanks,
Anatoly
Should be passing errno rather than ret, which could be negative.
Coverity issue: 350362
Fixes: 9dc843eb273b ("power: extend guest channel API for reading")
Cc: sta...@dpdk.org
Signed-off-by: David Hunt
---
lib/librte_power/guest_channel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The output of running the helloworld example on FreeBSD was a little
out-of-date and can be shortened by using the latest version of DPDK.
Update appropriately.
Signed-off-by: Bruce Richardson
---
doc/guides/freebsd_gsg/install_from_ports.rst | 56 ---
1 file changed, 22 insertio
The EAL command-line reference section duplicated material covered in a
previous chapter, was out of date, and generally is unnecessary as options
are best queried directly by passing "--help" to a DPDK binary. Therefore
we can drop this section to avoid having to try and keep it up-to-date in
the
Since the meson instructions are the simpler of the two sets, and also the
ones most future-proof, put those first in the user documentation with make
instructions following them.
Signed-off-by: Bruce Richardson
Acked-by: Gavin Hu
---
.../linux_gsg/cross_build_dpdk_for_arm64.rst | 32 +
Update the FreeBSD GSG doc with instructions for installing using meson and
ninja rather than make.
Signed-off-by: Bruce Richardson
---
doc/guides/freebsd_gsg/build_dpdk.rst | 164 +++---
1 file changed, 40 insertions(+), 124 deletions(-)
diff --git a/doc/guides/freebsd_gsg/
Update the documentation on building and running apps on FreeBSD, taking
account of having used meson for building. We can also update the section
on the command-line parameters, rather than claiming to be a complete list
of parameters, it should describe how to get the complete list and only
cover
FreeBSD 10 is now EOL and all testing with DPDK takes place on BSD versions
11 and 12, so we can just remove the note. The BSD ports are supported on
all non-EOL versions of BSD.
Signed-off-by: Bruce Richardson
---
doc/guides/freebsd_gsg/install_from_ports.rst | 6 --
1 file changed, 6 delet
Update the system requirements section of the doc to cover builds with
meson and ninja. This involves updating the package dependencies to include
meson, ninja and python 3.5, and also updating the optional dependencies
section to explain that the components are enabled/disabled automatically
by me
This patchset includes documentation updates for both the Linux and
FreeBSD Getting Started Guide Docs. The majority of changes are to add
information on building using meson and ninja, with some additional
cleanups being performed at the same time.
V2: Updated patch 2 following feedback from Anat
Add instructions on building DPDK and using the pkg-config file to the
linux GSG.
Signed-off-by: Bruce Richardson
---
V2: Changes following Anatoly's review:
* minor grammar fix
* added ldconfig call to instructions and note about needing to add
/usr/local/lib* to loader paths on RHEL/Fedora
*
> >>> +.. code-block:: makefile
> >>> +
> >>> +PKGCONF = pkg-config
> >>> +
> >>> +CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)
> >>> +LDFLAGS += $(shell $(PKGCONF) --libs libdpdk)
> >>> +
> >>> +$(APP): $(SRCS-y) Makefile
> >>> +$(CC) $(CFLAGS)
> -Original Message-
> From: Burakov, Anatoly
> Sent: Monday, November 25, 2019 1:23 PM
> To: Richardson, Bruce ; Mcnamara, John
>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/8] doc: add building with meson to linux
> GSG
>
> On 22-Nov-19 4:03 PM, Bruce Richardson wrote:
> >
25/11/2019 13:58, Burakov, Anatoly:
> On 25-Nov-19 12:36 PM, David Marchand wrote:
> > On Mon, Nov 25, 2019 at 1:03 PM Ferruh Yigit wrote:
> I would like to get your comment on the issue.
>
> For the OvS mode, hopefully binding the device to 'vfio-pci'
> can be a solution, but
On Thu, Nov 7, 2019 at 6:13 PM Viacheslav Ovsiienko
wrote:
> @@ -1011,7 +1010,29 @@
> pkts[pos + 3]->timestamp =
> rte_be_to_cpu_64(cq[pos + p3].timestamp);
> }
> -
> + if (rte_flow_dynf_metadata_avail()) {
> +
Confirmed author with Bruce offlist.
Applied with commitlog proposed by Bruce:
While most windows apps can handle both "\" and "/" as path separators,
"more" is treating the "/" as the start of a command-line flag in this
case, causing errors.
Fixes: cba806e07d6f ("build: change ABI versioning t
On 11/25/2019 1:00 PM, Jerin Jacob wrote:
On Sat, Nov 23, 2019 at 5:58 PM wrote:
From: Pavan Nikhilesh
Enable Ptype parsing by default, only disable when `rte_eth_dev_set_ptypes`
is called with ptype_mask as 0.
This would enable applications that are dependent on packet type parsing
like l3f
On Mon, Nov 25, 2019 at 2:06 PM Burakov, Anatoly
wrote:
>
> On 23-Nov-19 2:59 AM, Pallavi Kadam wrote:
> > This patch fixes Windows build failure caused due to
> > 'config: change ABI versioning to global' patch.
> > This patch can be merged in 19.11 release.
> >
> > Signed-off-by: Bruce Richardso
On 25-Nov-19 1:27 PM, Bruce Richardson wrote:
On Mon, Nov 25, 2019 at 01:19:13PM +, Burakov, Anatoly wrote:
On 22-Nov-19 4:03 PM, Bruce Richardson wrote:
Add instructions on building DPDK and using the pkg-config file to the
linux GSG.
Signed-off-by: Bruce Richardson
---
doc/guides/lin
On Mon, Nov 25, 2019 at 01:19:13PM +, Burakov, Anatoly wrote:
> On 22-Nov-19 4:03 PM, Bruce Richardson wrote:
> > Add instructions on building DPDK and using the pkg-config file to the
> > linux GSG.
> >
> > Signed-off-by: Bruce Richardson
> > ---
> > doc/guides/linux_gsg/build_dpdk.rst | 9
On Mon, Nov 25, 2019 at 09:10:06AM +0100, David Marchand wrote:
> The map-list-symbol.sh script displays the filename, section and symbol
> names of map files.
>
> Example:
> $ buildtools/map-list-symbol.sh -S EXPERIMENTAL \
> lib/librte_ethdev/rte_ethdev_version.map |grep rte_mtr_create
> lib
On 22-Nov-19 4:03 PM, Bruce Richardson wrote:
Add instructions on building DPDK and using the pkg-config file to the
linux GSG.
Signed-off-by: Bruce Richardson
---
+
+Building Applications Using Installed DPDK
+~~
+
+When installed system-wide, DPDK
On 22-Nov-19 4:03 PM, Bruce Richardson wrote:
Add instructions on building DPDK and using the pkg-config file to the
linux GSG.
Signed-off-by: Bruce Richardson
---
doc/guides/linux_gsg/build_dpdk.rst | 94 +++--
1 file changed, 90 insertions(+), 4 deletions(-)
diff -
On 23-Nov-19 2:59 AM, Pallavi Kadam wrote:
This patch fixes Windows build failure caused due to
'config: change ABI versioning to global' patch.
This patch can be merged in 19.11 release.
Signed-off-by: Bruce Richardson
Reviewed-by: Ranjit Menon
Tested-by: Pallavi Kadam
---
Missing Fixes: t
On Sat, Nov 23, 2019 at 5:58 PM wrote:
>
> From: Pavan Nikhilesh
>
> Enable Ptype parsing by default, only disable when `rte_eth_dev_set_ptypes`
> is called with ptype_mask as 0.
> This would enable applications that are dependent on packet type parsing
> like l3fwd.
>
> Fixes: d2706e15e6fb ("net
1 - 100 of 137 matches
Mail list logo
