Re: [dpdk-dev] [PATCH] net/ipn3ke, raw/ifpga: fix meson build

2019-12-12 Thread Ye Xiaolong
On 12/12, Bruce Richardson wrote: >The ipn3ke driver and the ifpga driver had circular dependencies on each >other, meaning that neither could be built with meson. Fix this by: > >* setting the build order of net and raw to match that in makefiles >* removing the dependency from the net driver on t

Re: [dpdk-dev] [EXT] Re: [PATCH 00/15] add OCTEONTX2 inline IPsec support

2019-12-12 Thread Anoob Joseph
Hi Thomas, Jerin, Please see inline. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, December 11, 2019 4:25 AM > To: Jerin Jacob ; Anoob Joseph > > Cc: Akhil Goyal ; Declan Doherty > ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Kiran Ku

Re: [dpdk-dev] [PATCH v2] net/iavf: fix Rx total stats

2019-12-12 Thread Wu, Jingjing
> -Original Message- > From: Min, JiaqiX > Sent: Friday, December 13, 2019 9:23 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Yang, Qiming > ; Min, JiaqiX > ; sta...@dpdk.org > Subject: [PATCH v2] net/iavf: fix Rx total stats > > Rx total stats is the total number of successfully receive

Re: [dpdk-dev] [EXT] Re: [PATCH 10/15] crypto/octeontx2: add lookup mem changes to hold sa indices

2019-12-12 Thread Anoob Joseph
Hi Jerin, Please see inline. Thanks, Anoob > -Original Message- > From: Jerin Jacob > Sent: Monday, December 9, 2019 1:32 PM > To: Anoob Joseph > Cc: Akhil Goyal ; Declan Doherty > ; Thomas Monjalon ; > Archana Muniganti ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ;

Re: [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition

2019-12-12 Thread Xiaojun Liu
1. FM10K is the i2c master, the PCA9545/PCA9505/PCA9538 are the slave. 2. All the i2c slave connect on board to FM10K SoC. 3. To control the PHY and LED -Original Message- From: Jerin Jacob [mailto:jerinjac...@gmail.com] Sent: Friday, December 13, 2019 1:12 AM To: Xiaojun Liu Cc: xiao.w.

[dpdk-dev] [PATCH v2] net/ixgbe: fixed port can not link up in FreeBSD

2019-12-12 Thread Lunyuan Cui
In FreeBSD environment, nic_uio drivers do not support interrupts, rte_intr_callback_register() will fail to register interrupts. We can not make link status to change from down to up by interrupt callback. So we need to wait for the controller to acquire link when ports start. Through multiple tes

[dpdk-dev] [PATCH v2] net/iavf: fix Rx total stats

2019-12-12 Thread Jiaqi Min
Rx total stats is the total number of successfully received packets, so exclude the number of rx_discards for Rx total stats. Fixes: f4a41a6953af ("net/avf: support stats") Cc: sta...@dpdk.org Signed-off-by: Jiaqi Min --- v2: * Changed commit message. --- drivers/net/iavf/iavf_ethdev.c | 2 +-

Re: [dpdk-dev] [PATCH] net/ipn3ke, raw/ifpga: fix meson build

2019-12-12 Thread Xu, Rosen
> -Original Message- > From: Richardson, Bruce > Sent: Friday, December 13, 2019 1:29 > To: dev@dpdk.org > Cc: Richardson, Bruce ; Xu, Rosen > ; Zhang, Tianfei ; > sta...@dpdk.org > Subject: [PATCH] net/ipn3ke, raw/ifpga: fix meson build > > The ipn3ke driver and the ifpga driver had c

Re: [dpdk-dev] [PATCH] net/mlx5: fix eagain on admin down

2019-12-12 Thread Thomas Monjalon
+Cc maintainers 09/12/2019 19:23, Mike Manning: > The check in mlx5_link_update_unlocked_gs() returns -EAGAIN if link > status does not correspond to link speed. If status is DOWN, the speed > is expected to be ETH_SPEED_NUM_NONE (0). But as the link speed is -1 > on admin down, modify the check t

Re: [dpdk-dev] [PATCH v2] doc: fix build with python 3.8

2019-12-12 Thread Thomas Monjalon
11/12/2019 12:15, Bruce Richardson: > On Wed, Dec 11, 2019 at 12:01:40PM +0100, Thomas Monjalon wrote: > > After upgrading to python-3.8.0, a syntax mismatch is revealed: > > > > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal. > > Did you mean "!="? > > if value is not '':

Re: [dpdk-dev] [PATCH] net/mlx: fix variadic macro

2019-12-12 Thread Thomas Monjalon
11/12/2019 07:49, Ali Alnubani: > This rewrites the MKSTR macro appending an empty string to its arguments > to resolve build failures similar to: > > drivers/net/mlx4/mlx4.c:461:14: fatal error: format string is not a > string literal [-Wformat-nonliteral] > MKSTR(path, "%s/device/u

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net: fix mlx* glue libraries ABI version

2019-12-12 Thread Thomas Monjalon
04/12/2019 11:05, David Marchand: > Those libraries have been missed when switching to global ABI version. The versioning of the glue libraries are for compatibility checks between the PMD and its dependency (rdma-core) packaged as a plugin, called glue library. This versioning is updated when th

Re: [dpdk-dev] BCM57414 VF Mode: max_rx_em_flows value is inconsistent

2019-12-12 Thread Kevin Traynor
Hi Christophe, On 11/12/2019 17:45, Ajit Khaparde wrote: > On Wed, Dec 11, 2019 at 7:57 AM Christophe Grosse < > christophe.gro...@6wind.com> wrote: > >> Hello, >> >> I am using DPDK 18.11.5 from dpdk-stable repository with a Broadcom >> network adapter in VF mode : >> Broadcom Limited BCM57414 N

[dpdk-dev] [PATCH] event/dsw: add by-name xstats retrieval

2019-12-12 Thread Mattias Rönnblom
Implement rte_event_dev_stats_by_name(). Suggested-by: Niclas Storm Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_xstats.c | 144 + drivers/event/sw/sw_evdev_xstats.c | 2 - 2 files changed, 108 insertions(+), 38 deletions(-) diff --git a/drivers/e

[dpdk-dev] [PATCH] net/octeontx2: fix get supported ptype callback

2019-12-12 Thread Harman Kalra
Setting up supported ptypes using testpmd command is failing because supported_ptypes_get callback will never return ptypes supported, as NIX_RX_OFFLOAD_PTYPE_F bit in rx_offload_flags is zero by default in testpmd. Fixes: d2706e15e6fb ("net/octeontx2: support reduced set of packet types") Cc: sta

[dpdk-dev] [PATCH] net/ipn3ke, raw/ifpga: fix meson build

2019-12-12 Thread Bruce Richardson
The ipn3ke driver and the ifpga driver had circular dependencies on each other, meaning that neither could be built with meson. Fix this by: * setting the build order of net and raw to match that in makefiles * removing the dependency from the net driver on the rawdev one * fixing the dependency n

Re: [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition

2019-12-12 Thread Jerin Jacob
On Thu, Dec 12, 2019 at 3:05 PM Xiaojun Liu wrote: > > This is not a generic i2c bus, but rather an indirect access to i2c devices > through FM10k registers. It's only purpose is to support the fm10k chip. Also > there's currently no i2c bus support framework in DPDK. To understand it better:

Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Ray Kinsella
On 12/12/2019 11:58, Bruce Richardson wrote: > The soname for each stable ABI version should be just the ABI version major > number without the minor number. Unfortunately both major and minor were > used causing version 20.1 to be incompatible with 20.0. > > This patch fixes the issue by switc

[dpdk-dev] What's possible reasons that may cause rx_total_missed_packets increase in ixgbe driver?

2019-12-12 Thread Haosong Huang
Hi, DPDK masters, I am debugging a `imissed` issue when we are using DPDK. We notice that imissed increase even when the traffic is slow. We are using x520 nic and ixgbe driver. Via check the code, imissed comes from rx_total_missed_packets in ixgbe. But what's the possible reason that make rx_to

Re: [dpdk-dev] [PATCH] Don't combine '-r' and '--export-dynamic' linker options

2019-12-12 Thread Thomas Monjalon
25/10/2019 03:20, Rafael Ávila de Espíndola: > Running ld with '-r' switches the linker to a very special mode where > some other linker options don't make sense. > > In particular, '--export-dynamic' normally requires that all global > symbols be included in the dynamic symbol table, but a .o fil

Re: [dpdk-dev] [PATCH] net/ena: initialize PCI info in eth_ena_dev_init

2019-12-12 Thread David Harton (dharton)
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, December 12, 2019 9:54 AM > To: David Harton (dharton) ; dev@dpdk.org; > m...@semihalf.com; m...@semihalf.com; gtza...@amazon.com; evge...@amazon.com; > igo...@amazon.com > Subject: Re: [dpdk-dev] [PATCH] net/ena: initialize PCI i

[dpdk-dev] [PATCH v2 33/36] net/i40e/base: introduce firmware EMP reset register offsets

2019-12-12 Thread Xiaolong Ye
Introduce offsets of firmware registers holding a number of EMP resets. Implement offsets as a preprocessor's constants. Required by drivers to read a number of EMP resets reported by FW. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_register.h | 2 ++ 1 file changed, 2 insertions(+)

[dpdk-dev] [PATCH v2 35/36] net/i40e/base: enable LED blinking flow

2019-12-12 Thread Xiaolong Ye
Add X710T*L device specific operations (in port LED detection and handling of GLGEN_GPIO_CTL.PIN_FUNC field) to enable LED blinking. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 28 +--- drivers/net/i40e/base/i40e_devids.h | 2 ++ 2 files changed,

Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Bruce Richardson
On Thu, Dec 12, 2019 at 03:25:12PM +, Ray Kinsella wrote: > > > On 12/12/2019 13:02, Bruce Richardson wrote: > > On Thu, Dec 12, 2019 at 12:30:19PM +, Ray Kinsella wrote: > >> > >> > >> On 12/12/2019 11:58, Bruce Richardson wrote: > >>> The soname for each stable ABI version should be jus

[dpdk-dev] [PATCH v2 36/36] net/i40e/base: add new link speed constants

2019-12-12 Thread Xiaolong Ye
This patch fixes 'NIC Link is Up, Unknown bps' message in dmesg for 2.5Gb/5Gb speeds. This problem is fixed by adding constants for VIRTCHNL_LINK_SPEED_2_5GB and VIRTCHNL_LINK_SPEED_5GB. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_prototype.h | 4 drivers/net/i40e/base/virtchn

[dpdk-dev] [PATCH v2 34/36] net/i40e/base: add CRC stripping capability

2019-12-12 Thread Xiaolong Ye
Some VFs may want to disable CRC stripping on incoming packets so create an offload for that. The VF already sends information about configuring it's RX queues so use that structure to indicate that the CRC stripping should be enabled or not. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/

[dpdk-dev] [PATCH v2 32/36] net/i40e/base: exposing missing LED functionality

2019-12-12 Thread Xiaolong Ye
The previous code had the LED code wrapped such that, it was static to the file and not usable outside of it. It is now available. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c| 8 drivers/net/i40e/base/i40e_prototype.h | 5 - 2 files changed, 8 insertions(+

[dpdk-dev] [PATCH v2 30/36] net/i40e/base: set PHY Access flag on X722

2019-12-12 Thread Xiaolong Ye
The X722 FW API version 1.9 adds support for accessing PHY registers with Admin Queue Command. This enables reading EEPROM data from (Q)SFP+ transceivers, what was previously possible only on X710 devices. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq.c | 5 + drivers/

[dpdk-dev] [PATCH v2 31/36] net/i40e/base: implement reading lpi statistics

2019-12-12 Thread Xiaolong Ye
There was no time duration statistics for LPI (Low Power Idle) in EEE (Energy-Efficient Ethernet). Added new procedure to get duration values from FW. Otherwise there is no available procedure to get tx_lpi_duration and rx_lpi_duration values. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base

[dpdk-dev] [PATCH v2 29/36] net/i40e/base: removed unreachable code

2019-12-12 Thread Xiaolong Ye
The result of the check is always FALSE and the code within "if" is never executed. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 9ad0dd654..

[dpdk-dev] [PATCH v2 28/36] net/i40e/base: add Flow Director defines

2019-12-12 Thread Xiaolong Ye
Add defines for creating Flow Director flows as defined in datasheet section 7.1.5.4 for field vectors. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_register.h | 81 +++ 1 file changed, 81 insertions(+) diff --git a/drivers/net/i40e/base/i40e_register.h b/d

[dpdk-dev] [PATCH v2 23/36] net/i40e/base: add persistent lldp support

2019-12-12 Thread Xiaolong Ye
This patch adds a function to read nvm module data and uses it to read current lldp agent configuration from nvm api version 1.8. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_dcb.c | 20 +++- drivers/net/i40e/base/i40e_dcb.h | 5 ++ drivers/net/i40e/base/i40e_nvm.c

[dpdk-dev] [PATCH v2 27/36] net/i40e/base: change wrong 'Advertised FEC modes'

2019-12-12 Thread Xiaolong Ye
Fix display of FEC settings for ethtool. This patch change variable 'phy.link_info.req_fec_info' sent to ethtool. Without this patch wrong FEC settings can be shown. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletio

[dpdk-dev] [PATCH v2 26/36] net/i40e/base: mark additional missing bits as reserved

2019-12-12 Thread Xiaolong Ye
Mark bits 0xD through 0xF for the command flags of a cloud filter as reserved. These bits are not yet defined and are considered as reserved in the data sheet. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq_cmd.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/ne

[dpdk-dev] [PATCH v2 22/36] net/i40e/base: update FW API version

2019-12-12 Thread Xiaolong Ye
Update FW API version to 1.9. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h index f6c9d3e1a..0443c6361 100644 --- a/

[dpdk-dev] [PATCH v2 21/36] net/i40e/base: add FWS1B register masks

2019-12-12 Thread Xiaolong Ye
Function check_recovery_mode had wrong if statement. Now we check proper FWS1B register values, which are responsible for the recovery mode. Recovery mode has 6 values in total. That's why we need 6 different flags. Now in if statement we recognize type of mac and register value. Without those chan

[dpdk-dev] [PATCH v2 24/36] net/i40e/base: make i40e_set_mac_type() public

2019-12-12 Thread Xiaolong Ye
Make i40e_set_mac_type() public. i40e driver requires i40e_set_mac_type() to be public. It is required for recovery mode handling. Without this patch recovery mode could not be detected at probe() function. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c| 4 drivers/n

[dpdk-dev] [PATCH v2 25/36] net/i40e/base: change retrying logic

2019-12-12 Thread Xiaolong Ye
Fixed a bug where driver was breaking out of the loop and reporting an error without retrying first. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/dr

[dpdk-dev] [PATCH v2 13/36] net/i40e/base: read LPI status from external PHY

2019-12-12 Thread Xiaolong Ye
When external PHY is used, MAC register may not reflect actual state of LPI. Add function reading it directly from PHY or MAC, depending on what is supported by the device. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c| 45 ++ drivers/net/i40e/bas

[dpdk-dev] [PATCH v2 18/36] net/i40e/base: change of the incorrect Tx descriptors number

2019-12-12 Thread Xiaolong Ye
The existing driver allows setting the number of TX descriptors to the value that is indivisible by 32. This is not properly supported by x710 hardware. The patch limits the number of TX descriptors to the whole value of 32. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_type.h | 4 ++

[dpdk-dev] [PATCH v2 17/36] net/i40e/base: update status codes

2019-12-12 Thread Xiaolong Ye
Add a few new status codes and rename a few to make them more consistent. Error code are mapped to similar values as in i40e_status.h, so as to be compatible with older VF drivers not using this status enum. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/virtchnl.h | 12 +--- 1 fil

[dpdk-dev] [PATCH v2 20/36] net/i40e/base: add drop mode parameter to set MAC config

2019-12-12 Thread Xiaolong Ye
This patch adds "drop mode" parameter to set mac config AQ command. This bit controls the behavior when a no-drop packet is blocking a TC queue. 0 – The PF driver is notified. 1 – The blocking packet is dropped and then the PF driver is notified. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/b

[dpdk-dev] [PATCH v2 15/36] net/i40e/base: add reading LPI counters

2019-12-12 Thread Xiaolong Ye
This change introduces new function i40e_get_lpi_counters() reading Low Power Idle (LPI) mode counters from Energy Efficient Ethernet (EEE) statistics. Since reading EEE statistics requires running DNL script, function i40e_aq_run_phy_activity() able to run it, was implemented. i40e_lpi_stat_updat

[dpdk-dev] [PATCH v2 19/36] net/i40e/base: extend PHY access AQ command

2019-12-12 Thread Xiaolong Ye
Currently FW use MDIO I/F number corresponded with current PF for PHY access. This code allow to specify used MDIO I/F number. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq.c | 57 +++ drivers/net/i40e/base/i40e_adminq_cmd.h | 6 ++- drivers/net/i40e/b

[dpdk-dev] [PATCH v2 16/36] net/i40e/base: backport style changes from upstream Linux

2019-12-12 Thread Xiaolong Ye
The upstream virtchnl.h has a few minor style differences to what is out-of-tree, and there is no real reason we should prefer the current style over whats upstream. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/virtchnl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[dpdk-dev] [PATCH v2 14/36] net/i40e/base: change for missing "link modes"

2019-12-12 Thread Xiaolong Ye
Fix for missing "Supported link modes" and "Advertised link modes" info in ethtool after changed speed on X722 devices with BASE-T PHY with FW API version >= 1.7. The same FW API version on X710 and X722 does not mean the same feature set so the change was needed as mac type of the device should al

[dpdk-dev] [PATCH v2 11/36] net/i40e/base: add getter for FW LLDP agent status

2019-12-12 Thread Xiaolong Ye
This change introduces i40e_get_fw_lldp_status() function capable of reporting status of FW Link Layer Discovery Protocol (LLDP) agent. Since reading LLDP configuration from NVM only gives information what is the default state of FW LLDP agent after POR, this change introduces more reliable method

[dpdk-dev] [PATCH v2 09/36] net/i40e/base: adding flags for PHY types

2019-12-12 Thread Xiaolong Ye
Adding bit flags to enable/disable EEE capability for 2.5GBase-T and 5GBase-T PHY types as well as 'Set autonomous EEE for relevant enabled PHY types' flag. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq_cmd.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i

[dpdk-dev] [PATCH v2 12/36] net/i40e/base: add support for Energy Efficient Ethernet

2019-12-12 Thread Xiaolong Ye
This change adds i40e_enable_eee() function controlling advertisement of Energy Efficient Ethernet mode (EEE). Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c| 64 ++ drivers/net/i40e/base/i40e_prototype.h | 1 + 2 files changed, 65 insertions(+)

[dpdk-dev] [PATCH v2 10/36] net/i40e/base: improve AQ log granularity

2019-12-12 Thread Xiaolong Ye
This patch makes it possible to log only AQ descriptors, without the entire AQ message buffers being dumped too. It should greatly reduce kernel log size in cases where a full AQ dump is not needed. Selection is made by setting flags in hw->debug_mask. Additionally, some debug messages that preced

[dpdk-dev] [PATCH v2 08/36] net/i40e/base: add check for MAC type

2019-12-12 Thread Xiaolong Ye
Some features were introduced in different FW API version on XL710 and X722 MACs. Others are available only on specific MAC type. Make sure that they are properly assigned. Also fix the style issues reported by current check-patch. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq

[dpdk-dev] [PATCH v2 06/36] net/i40e/base: further implementation of LLDP

2019-12-12 Thread Xiaolong Ye
This code implements shared code changes necessary for LLDP Agent support. 1. Modified i40e_aq_start_lldp and i40e_aq_stop_lldp. Now Stop and Start can also be persistent across power cycles. 2. Added new function i40e_aq_restore_lldp which restores factory setting for LLDP Agent or gets its statu

[dpdk-dev] [PATCH v2 04/36] net/i40e/base: decouple cfg_lldp_mib_change from init_dcb

2019-12-12 Thread Xiaolong Ye
There is a need to enable MIB change event, not at the same time as init_dcb. This patch will serve this requirement. Modify the i40e_init_dcb to return the correct error when LLDP or DCBX is not in operational state. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_dcb.c | 28

[dpdk-dev] [PATCH v2 05/36] net/i40e/base: change misleading error message

2019-12-12 Thread Xiaolong Ye
This patch changes an error code for an admin queue head overrun to use I40E_ERR_ADMIN_QUEUE_FULL instead of I40E_ERR_QUEUE_EMPTY. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/i40e_adm

[dpdk-dev] [PATCH v2 07/36] net/i40e/base: add new device ids

2019-12-12 Thread Xiaolong Ye
New device ids are created to support SFP+ and backplane connections. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 2 ++ drivers/net/i40e/base/i40e_devids.h | 2 ++ drivers/net/i40e/i40e_ethdev.c | 2 ++ 3 files changed, 6 insertions(+) diff --git a/drivers/net/i40e

[dpdk-dev] [PATCH v2 01/36] net/i40e/base: add support for feature flags

2019-12-12 Thread Xiaolong Ye
Extend NVM Update API to support reporting of features available for the tools. This change is needed by NVM Update to determine if driver supports changing NVM layout from structured to flat. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 11 drivers/net/i40e/bas

[dpdk-dev] [PATCH v2 03/36] net/i40e/base: change buffer address

2019-12-12 Thread Xiaolong Ye
The high 32-bits were being set incorrectly in the 'Set Local LLDP MIB' AQ command (0x0A08). Change it to use the right macro to get the correct bits. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v2 00/36] update for i40e base code

2019-12-12 Thread Xiaolong Ye
This series is to support FVL 7.2 release. The main changes include: * virtchnl updates * add lldp support * Flow director updates * extend PHY access AQ cmd * add reading LPI counters * add support for Energy Efficient Ethernet * A few fixes. V2: * strip some unnecessary code * squash some fix

[dpdk-dev] [PATCH v2 02/36] net/i40e/base: increase max VSI count for VFs

2019-12-12 Thread Xiaolong Ye
For historical reasons, we allowed 3 VSIs per VF, but never used more than one. Now with ADq, we can use up to 4 VSIs per VF, so change this value to match. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Ray Kinsella
On 12/12/2019 13:02, Bruce Richardson wrote: > On Thu, Dec 12, 2019 at 12:30:19PM +, Ray Kinsella wrote: >> >> >> On 12/12/2019 11:58, Bruce Richardson wrote: >>> The soname for each stable ABI version should be just the ABI version major >>> number without the minor number. Unfortunately bo

Re: [dpdk-dev] [PATCH] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Bruce Richardson
On Thu, Dec 12, 2019 at 02:05:44PM +, Ray Kinsella wrote: > > > On 12/12/2019 13:58, Luca Boccassi wrote: > > On Thu, 2019-12-12 at 11:14 +, Ray Kinsella wrote: > >> > >> On 11/12/2019 11:11, Bruce Richardson wrote: > >>> On Wed, Dec 11, 2019 at 11:04:01AM +, Luca Boccassi wrote: > >>

Re: [dpdk-dev] [PATCH] net/ena: initialize PCI info in eth_ena_dev_init

2019-12-12 Thread Ferruh Yigit
On 12/10/2019 10:37 PM, David Harton wrote: > Network drivers were originally modified to initialize PCI info with > commit eeefe73f0af1 ("drivers: copy PCI device info to ethdev data"). > Modifying net/ena to conform. > > Signed-off-by: David Harton > --- > drivers/net/ena/ena_ethdev.c | 1 + >

Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Ferruh Yigit
On 12/12/2019 11:58 AM, Bruce Richardson wrote: > The soname for each stable ABI version should be just the ABI version major > number without the minor number. Unfortunately both major and minor were > used causing version 20.1 to be incompatible with 20.0. > > This patch fixes the issue by switc

Re: [dpdk-dev] [PATCH v3 01/17] net/ionic: add skeleton

2019-12-12 Thread Alfredo Cardigliano
> On 12 Dec 2019, at 13:39, Ferruh Yigit wrote: > > On 12/12/2019 12:01 PM, Alfredo Cardigliano wrote: >> >> >>> On 10 Dec 2019, at 19:48, Ferruh Yigit wrote: >>> >>> On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: Add makefile and config file options to compile the Pensando ionic PM

[dpdk-dev] [PATCH v2 0/1] Refactor crypto unit tests.

2019-12-12 Thread Adam Dybkowski
This patch is a first step to refactor the overly complex symmetric crypto unit tests. It merges many separate arrays of the tests for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc into one big array that's then used when running unit tests on these PMDs. Indivi

Re: [dpdk-dev] [PATCH] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Ray Kinsella
On 12/12/2019 13:58, Luca Boccassi wrote: > On Thu, 2019-12-12 at 11:14 +, Ray Kinsella wrote: >> >> On 11/12/2019 11:11, Bruce Richardson wrote: >>> On Wed, Dec 11, 2019 at 11:04:01AM +, Luca Boccassi wrote: On Wed, 2019-12-11 at 10:26 +, Bruce Richardson wrote: > The sonam

Re: [dpdk-dev] [PATCH] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Luca Boccassi
On Thu, 2019-12-12 at 11:14 +, Ray Kinsella wrote: > > On 11/12/2019 11:11, Bruce Richardson wrote: > > On Wed, Dec 11, 2019 at 11:04:01AM +, Luca Boccassi wrote: > > > On Wed, 2019-12-11 at 10:26 +, Bruce Richardson wrote: > > > > The soname for each stable ABI version should be just

Re: [dpdk-dev] [PATCH v2] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Thomas Monjalon
12/12/2019 12:59, Bruce Richardson: > On Thu, Dec 12, 2019 at 11:44:51AM +, Bruce Richardson wrote: > > On Thu, Dec 12, 2019 at 08:57:50AM +, Ferruh Yigit wrote: > > > On 12/12/2019 8:27 AM, David Marchand wrote: > > > > Hello Bruce, > > > > > > > > On Wed, Dec 11, 2019 at 4:16 PM Bruce Ri

Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-12 Thread Sexton, Rory
Hi Ori, Let me rework the patch to make it clearer that this is supporting new flow type for l2tpv3 over IP, rather than l2tpv2/v3 over UDP which is how you interpreted it. Will take into account all your feedback. Please review v2 once I submit. Regards, Rory -Original Message- From:

[dpdk-dev] [PATCH] config: disable all kmods by default from v20.02

2019-12-12 Thread jerinj
From: Jerin Jacob Based on the techboard meeting held on 2019-11-06, It's been decided to disable all kmods by default from v20.02. http://mails.dpdk.org/archives/dev/2019-November/151763.html Signed-off-by: Jerin Jacob --- config/common_linux | 2 -- 1 file changed, 2 deletions(-) diff --gi

Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Bruce Richardson
On Thu, Dec 12, 2019 at 12:30:19PM +, Ray Kinsella wrote: > > > On 12/12/2019 11:58, Bruce Richardson wrote: > > The soname for each stable ABI version should be just the ABI version major > > number without the minor number. Unfortunately both major and minor were > > used causing version 20

Re: [dpdk-dev] [PATCH v3 04/17] net/ionic: register and initialize the adapter

2019-12-12 Thread Ferruh Yigit
On 12/12/2019 12:04 PM, Alfredo Cardigliano wrote: > > >> On 10 Dec 2019, at 19:50, Ferruh Yigit wrote: >> >> On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: >>> Register the Pensando ionic PMD (net_ionic) and define initial probe >>> and remove callbacks with adapter initialization. >>> >>> Si

Re: [dpdk-dev] [PATCH v3 01/17] net/ionic: add skeleton

2019-12-12 Thread Ferruh Yigit
On 12/12/2019 12:01 PM, Alfredo Cardigliano wrote: > > >> On 10 Dec 2019, at 19:48, Ferruh Yigit wrote: >> >> On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: >>> Add makefile and config file options to compile the Pensando ionic PMD. >>> Add feature and version map file. >>> Update maintainers

Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Ray Kinsella
On 12/12/2019 11:58, Bruce Richardson wrote: > The soname for each stable ABI version should be just the ABI version major > number without the minor number. Unfortunately both major and minor were > used causing version 20.1 to be incompatible with 20.0. > > This patch fixes the issue by switc

[dpdk-dev] DPDK Release Status Meeting 12/12/2019

2019-12-12 Thread Ferruh Yigit
Minutes 12 December 2019 Agenda: * Release Dates * Subtrees * OvS Participants: * Arm * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.02 dates: * Proposal/V1 deadline passed, it was on Wednesday 11 December 2019 * I

Re: [dpdk-dev] [PATCH v3 04/17] net/ionic: register and initialize the adapter

2019-12-12 Thread Alfredo Cardigliano
> On 10 Dec 2019, at 19:50, Ferruh Yigit wrote: > > On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: >> Register the Pensando ionic PMD (net_ionic) and define initial probe >> and remove callbacks with adapter initialization. >> >> Signed-off-by: Alfredo Cardigliano >> Reviewed-by: Shannon N

Re: [dpdk-dev] [PATCH v3 01/17] net/ionic: add skeleton

2019-12-12 Thread Alfredo Cardigliano
> On 10 Dec 2019, at 19:48, Ferruh Yigit wrote: > > On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: >> Add makefile and config file options to compile the Pensando ionic PMD. >> Add feature and version map file. >> Update maintainers file. >> >> Signed-off-by: Alfredo Cardigliano >> Reviewe

Re: [dpdk-dev] [PATCH v2] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Bruce Richardson
On Thu, Dec 12, 2019 at 11:44:51AM +, Bruce Richardson wrote: > On Thu, Dec 12, 2019 at 08:57:50AM +, Ferruh Yigit wrote: > > On 12/12/2019 8:27 AM, David Marchand wrote: > > > Hello Bruce, > > > > > > On Wed, Dec 11, 2019 at 4:16 PM Bruce Richardson > > > wrote: > > >> > > >> The soname

[dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Bruce Richardson
The soname for each stable ABI version should be just the ABI version major number without the minor number. Unfortunately both major and minor were used causing version 20.1 to be incompatible with 20.0. This patch fixes the issue by switching from 2-part to 3-part ABI version numbers so that we

Re: [dpdk-dev] [PATCH 0/1] Refactor crypto unit tests.

2019-12-12 Thread Akhil Goyal
Hi Adam, This patch doesn't apply on TOT. Could you please rebase or let us know if some dependent patch is there? Also, it would be nice if this patch can be broken into smaller patches, as it is blocked by patchworks due to its length and it would be easier to review it. Also, please add al

Re: [dpdk-dev] [PATCH v2] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Bruce Richardson
On Thu, Dec 12, 2019 at 08:57:50AM +, Ferruh Yigit wrote: > On 12/12/2019 8:27 AM, David Marchand wrote: > > Hello Bruce, > > > > On Wed, Dec 11, 2019 at 4:16 PM Bruce Richardson > > wrote: > >> > >> The soname for each stable ABI version should be just the ABI version major > >> number witho

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: return on encountering algo as NULL

2019-12-12 Thread Ananyev, Konstantin
Hi, > if algo is NULL set the status to error and return. As this is a bug fix please add 'fix' to the commit header: examples/ipsec-secgw: fix ... Also probably worth to add 1-2 line explanation why this is needed into the commit message. Apart from that: Acked-by: Konstantin Ananyev >

Re: [dpdk-dev] [PATCH] app/testpmd: support unequal number of RXQ and TXQ

2019-12-12 Thread Hemant Agrawal
> -Original Message- > From: Jerin Jacob > On Wed, Dec 11, 2019 at 3:29 PM Ananyev, Konstantin > wrote: > > > > > > > > > -Original Message- > > > From: dev On Behalf Of Hemant Agrawal > > > Sent: Wednesday, December 11, 2019 5:30 AM > > > To: dev@dpdk.org > > > Cc: Jun Yang

Re: [dpdk-dev] [PATCH] net/ixgbe: fixed port can not link up in FreeBSD

2019-12-12 Thread Ananyev, Konstantin
Hi, > > In FreeBSD environment, nic_uio drivers do not support interrupts, > rte_intr_callback_register() will fail to register interrupts. > We can not make link status to change from down to up by interrupt > callback. So we need to wait for the controller to acquire link > when ports start. Th

Re: [dpdk-dev] [PATCH] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Ray Kinsella
On 11/12/2019 11:11, Bruce Richardson wrote: > On Wed, Dec 11, 2019 at 11:04:01AM +, Luca Boccassi wrote: >> On Wed, 2019-12-11 at 10:26 +, Bruce Richardson wrote: >>> The soname for each stable ABI version should be just the ABI version >>> major >>> number without the minor number. Unf

Re: [dpdk-dev] [PATCH v1] net/virtio-user: fix packed ring server mode

2019-12-12 Thread Ding, Xuan
> -Original Message- > From: Liu, Yong > Sent: Monday, December 9, 2019 4:52 PM > To: Ding, Xuan ; maintai...@dpdk.org > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Bie, Tiwei > ; Wang, Zhihong ; Ding, Xuan > ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v1] net/virtio-user: fix

Re: [dpdk-dev] [PATCH] build: fix soname info for 19.11 compatiblity

2019-12-12 Thread Ray Kinsella
On 11/12/2019 11:19, Ferruh Yigit wrote: > On 12/11/2019 11:14 AM, Bruce Richardson wrote: >> On Wed, Dec 11, 2019 at 12:08:25PM +0100, Thomas Monjalon wrote: >>> 11/12/2019 12:04, Luca Boccassi: On Wed, 2019-12-11 at 10:26 +, Bruce Richardson wrote: > The soname for each stable ABI

Re: [dpdk-dev] [PATCH] maintainers: update for OCTEONTX

2019-12-12 Thread Ferruh Yigit
On 12/11/2019 3:27 PM, Harman Kalra wrote: > On Wed, Dec 11, 2019 at 07:53:42PM +0530, jer...@marvell.com wrote: >> From: Jerin Jacob >> >> Harman thankfully accepted to replace myself as maintainer for OCTEONTX >> ethdev PMD. >> > > Acked-by: Harman Kalra > >> Signed-off-by: Jerin Jacob Than

Re: [dpdk-dev] [PATCH] maintainers: adjust maintainership of intel tree

2019-12-12 Thread Ferruh Yigit
On 12/12/2019 1:05 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: dev On Behalf Of Xiaolong Ye >> Sent: Wednesday, December 11, 2019 5:13 PM >> To: Thomas Monjalon >> Cc: dev@dpdk.org; Ye, Xiaolong >> Subject: [dpdk-dev] [PATCH] maintainers: adjust maintainership of intel tr

[dpdk-dev] rte_event_dev_xstats_by_name_get issues

2019-12-12 Thread Mattias Rönnblom
Hi. I'm looking at implementing rte_event_dev_xstats_by_name() for DSW, and I have some API-related questions. Shouldn't rte_event_dev_xstats_by_name_get() return mode and queue/port id? Otherwise the caller needs to know if the name refers to a device- or port-level stat, and in case of the

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-12 Thread Kinsella, Ray
First, good find, much kudos. To fix, I tend to agree with Bruce. The SONAME should be comprised of the library name and the major version number, period. As described in the DPDK documentation. I too would be concerned about our forgetting to make the change in 20.11. Also, what would happen w

[dpdk-dev] Jumbo frame not supported in virtio PMD

2019-12-12 Thread Nirmal Sarkar
Hello, I'm trying to send/receive Jumbo frames [ max: 9600] using pktgen-dpdk. The flags sent to the virtio driver are not supported. = Ethdev port_id=0 requested Rx offloads 0x800 doesn't match Rx offloads

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-12 Thread Kinsella, Ray
> -Original Message- > From: Bruce Richardson > Sent: Tuesday 10 December 2019 14:37 > To: Yigit, Ferruh > Cc: Kinsella, Ray ; Thomas Monjalon > ; David Marchand ; Luca > Boccassi ; Christian Ehrhardt > ; Timothy Redaelli > ; Kevin Traynor ; dpdk-dev > ; Laatz, Kevin ; Andrew Rybchenko

Re: [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters

2019-12-12 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Monday, November 25, 2019 7:29 PM > To: Stephen Hemminger ; dev@dpdk.org; > donald_...@trendmicro.com > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters > > > From: Stephen Hemminger > > Sent: Monday, November 25, 2019 9:13 A

Re: [dpdk-dev] [PATCH v4 1/3] build: add dump files for v20.0 ABI

2019-12-12 Thread Laatz, Kevin
On 12/12/2019 09:36, David Marchand wrote: On Thu, Dec 12, 2019 at 9:43 AM David Marchand wrote: You missed some drivers, which makes my tests fail right away: $ for file in $(find lib/ drivers/ -name "*.map") do pattern=$(basename ${file/_version.map}) [ $(find lib/ drivers/ -name "*$pa

Re: [dpdk-dev] [PATCH v4 1/3] build: add dump files for v20.0 ABI

2019-12-12 Thread Laatz, Kevin
On 12/12/2019 08:43, David Marchand wrote: On 11/12/2019 19:21, Kevin Laatz wrote: This patch adds the .dump files generated for the v20.0 ABI. These files will be used to compare the ABI during the meson build when the compat_checks meson is enabled. If there is a mismatch between the .dump

Re: [dpdk-dev] [PATCH v4 1/3] build: add dump files for v20.0 ABI

2019-12-12 Thread David Marchand
On Thu, Dec 12, 2019 at 9:43 AM David Marchand wrote: > You missed some drivers, which makes my tests fail right away: > > $ for file in $(find lib/ drivers/ -name "*.map") > do > pattern=$(basename ${file/_version.map}) > [ $(find lib/ drivers/ -name "*$pattern*.dump" |wc -l) = 0 ] || > c

Re: [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition

2019-12-12 Thread Xiaojun Liu
This is not a generic i2c bus, but rather an indirect access to i2c devices through FM10k registers. It's only purpose is to support the fm10k chip. Also there's currently no i2c bus support framework in DPDK. -Original Message- From: Jerin Jacob [mailto:jerinjac...@gmail.com] Sent: Wed

[dpdk-dev] [PATCH v1] examples/ipsec-secgw: return on encountering algo as NULL

2019-12-12 Thread Savinay Dharmappa
if algo is NULL set the status to error and return. Signed-off-by: Savinay Dharmappa --- examples/ipsec-secgw/sa.c | 9 + 1 file changed, 9 insertions(+) diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index 7f046e3ed..c75a5a15f 100644 --- a/examples/ipsec-secgw/sa.c

Re: [dpdk-dev] [DPDK] net/virtio: packed ring notification data feature support

2019-12-12 Thread Jiang, Cheng1
> -Original Message- > From: Liu, Yong > Sent: Monday, December 9, 2019 10:00 AM > To: Jiang, Cheng1 ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Bie, Tiwei ; Wang, > Zhihong ; Jiang, Cheng1 > > Subject: RE: [dpdk-dev] [DPDK] net/virtio: packed ring notification data > feature suppo

  1   2   >