[dpdk-dev] [PATCH] net/dpaa: fix Rx offload flags on jumbo MTU set

2020-01-15 Thread Apeksha Gupta
The JUMBO frame handling in dpaa_dev_mtu_set api was not correct. When frame_size is greater than RTE_ETHER_MAX_LEN, the intention is to add JUMBO flag in rx offload while it was resetting all other flags other than JUMBO as AND operator was used instead of OR. Fixes: 0ebce6129bc6 ("net/dpaa: su

[dpdk-dev] [PATCH] examples/l2fwd-crypto:skip dev configure for masked devices

2020-01-15 Thread Apeksha Gupta
The devices which are masked by cryptodev mask should not be initialized and skipped while traversing the device list. Fixes: 61a7018ba0 ("examples/l2fwd-crypto:skip dev configure for masked devices") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta --- examples/l2fwd-crypto/main.c | 6 ++

Re: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-15 Thread Andrew Rybchenko
On 1/15/20 11:43 PM, Thomas Monjalon wrote: > 15/01/2020 19:35, Ferruh Yigit: >> On 1/15/2020 6:49 AM, 方统浩50450 wrote: >>> Hi Ferruh, thanks for your message. >>> >>> >>> We developed a ethtool-dpdk which is secondary process based dpdk 17.08 >>> version. Our device >>> support hotplug detach, but

[dpdk-dev] [PATCH 2/3] build: allow to hide dependencies from pkg-config

2020-01-15 Thread Thomas Monjalon
If a dependency is required for a driver build, but should not be exposed to the application (via pkg-config), it can be declared in the array hidden_deps. The hidden_deps are used as internal dependencies, when building the shared library and the first stage of static library. The final static li

[dpdk-dev] [PATCH 3/3] net/mlx: support static ibverbs linkage with meson

2020-01-15 Thread Thomas Monjalon
The libibverbs (and libmlx4/5) can be statically embedded in the shared PMD library, or in the application with the static PMD. It was supported with make build system in commit 2c0dd7b69fb0 ("config: add static linkage of mlx dependency"). The same feature is enabled with meson. The main differe

[dpdk-dev] [PATCH 0/3] add static ibverbs in meson

2020-01-15 Thread Thomas Monjalon
This is the follow-up of the feature I added one year ago: static linkage of libibverbs in mlx PMDs. The first implementation was focused on "make". This second implementation works with "make" and "meson". Thomas Monjalon (3): buildtools: rework static pkg-config script build: allow to hide

[dpdk-dev] [PATCH 1/3] buildtools: rework static pkg-config script

2020-01-15 Thread Thomas Monjalon
The shell script options-ibverbs-static.sh was used with make in forcing static linkage of ibverbs dependency. It is now renamed pkg-config-static.sh and it is made generic, i.e. it can work with any .pc library file. The idea is to distinguish its own libraries and the dependencies by looking at

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-15 Thread Jerin Jacob
On Wed, Jan 15, 2020 at 11:45 PM Morten Brørup wrote: > > > > IMO, in order to have effective use of data plane, the control > > > > plane has to be integrated together in an OS-independent way. > > > > > > > > > > Also remember that not all DPDK applications need an IP stack resembling > > what

Re: [dpdk-dev] [dpdk-stable] [PATCH v5] net/virtio-user: fix packed ring server mode

2020-01-15 Thread Ding, Xuan
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 15, 2020 11:41 PM > To: Maxime Coquelin ; Ding, Xuan > ; Bie, Tiwei ; Wang, Zhihong > ; Liu, Yong ; Ye, Xiaolong > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v5] net/virtio-user:

[dpdk-dev] [PATCH] net/ice: cleanup for vec path check

2020-01-15 Thread Xiaolong Ye
Move the conditional compilation block to the inner check helper, so we can reduce the number of multiple ifdef check pairs used. Signed-off-by: Xiaolong Ye --- drivers/net/ice/ice_rxtx.c| 9 - drivers/net/ice/ice_rxtx_vec_common.h | 8 2 files changed, 8 insertions(

Re: [dpdk-dev] FW: || pw64572 lib/eventdev: use custom element size ring for event rings

2020-01-15 Thread Honnappa Nagarahalli
> > >> > >> > > >> > >> Aaron Conole writes: > > >> > >> > > >> > >> > Honnappa Nagarahalli writes: > > >> > >> > > > >> > >> >> Hi Aaron, > > >> > >> >> I am not able to understand the error, looks like there is > > >> > >> >> no particular error. Can you please take a look? > > >> > >> > > > >

[dpdk-dev] [PATCH v9 5/6] lib/hash: use ring with 32b element size to save memory

2020-01-15 Thread Honnappa Nagarahalli
The freelist and external bucket indices are 32b. Using rings that use 32b element sizes will save memory. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- lib/librte_hash/rte_cuckoo_hash.c | 94 --- lib/librte_hash/rte_cuckoo

[dpdk-dev] [PATCH v9 6/6] lib/eventdev: use custom element size ring for event rings

2020-01-15 Thread Honnappa Nagarahalli
Use custom element size ring APIs to replace event ring implementation. This avoids code duplication. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- lib/librte_eventdev/rte_event_ring.c | 147 ++- lib/librte_eventdev/rte_event_r

[dpdk-dev] [PATCH v9 2/6] lib/ring: apis to support configurable element size

2020-01-15 Thread Honnappa Nagarahalli
Current APIs assume ring elements to be pointers. However, in many use cases, the size can be different. Add new APIs to support configurable ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_rin

[dpdk-dev] [PATCH v9 1/6] test/ring: use division for cycle count calculation

2020-01-15 Thread Honnappa Nagarahalli
Use division instead of modulo operation to calculate more accurate cycle count. Signed-off-by: Honnappa Nagarahalli Acked-by: Olivier Matz --- app/test/test_ring_perf.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/app/test/test_ring_perf.c b/app/

[dpdk-dev] [PATCH v9 4/6] test/ring: modify perf test cases to use rte_ring_xxx_elem APIs

2020-01-15 Thread Honnappa Nagarahalli
Adjust the performance test cases to test rte_ring_xxx_elem APIs. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring_perf.c | 454 +++--- 1 file changed, 273 insertions(+), 181 deletions(-) diff --git a/app/test/test_ring_perf.c b/a

[dpdk-dev] [PATCH v9 3/6] test/ring: add functional tests for rte_ring_xxx_elem APIs

2020-01-15 Thread Honnappa Nagarahalli
Add basic infrastructure to test rte_ring_xxx_elem APIs. Adjust the existing test cases to test for various ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring.c | 1342 +- app/test/test_ring.h | 187 +

[dpdk-dev] [PATCH v9 0/6] lib/ring: APIs to support custom element size

2020-01-15 Thread Honnappa Nagarahalli
The current rte_ring hard-codes the type of the ring element to 'void *', hence the size of the element is hard-coded to 32b/64b. Since the ring element type is not an input to rte_ring APIs, it results in couple of issues: 1) If an application requires to store an element which is not 64b, it

[dpdk-dev] [PATCH v5] net/i40e: add PF MDD event handler

2020-01-15 Thread taox . zhu
From: Zhu Tao add warning and counter to handle the maliciouse driver detection event. When the hardware determines that a VF has maliciouse driver, this VF will become unworkable, the PF records and gives a warning message. Signed-off-by: Zhu Tao Acked-by: Qiming Yang --- doc/guides/nics/i40

Re: [dpdk-dev] [PATCH 0/5] net/ixgbe: improvements to ixgbe driver

2020-01-15 Thread Ye Xiaolong
On 01/14, Reshma Pattan wrote: >This patch set does below ixgbe driver code improvements. > >1)Removed usage of CONFIG_RTE_IXGBE_INC_VECTOR and used >architectures specific flags instead. > >2)Removed weak symbols from the stub functions for ppc >architecture. > >3)Removed duplicate function declar

Re: [dpdk-dev] [PATCH v2 0/4] Intel iavf and ice PMDs clean up

2020-01-15 Thread Ye Xiaolong
On 01/14, Haiyue Wang wrote: >a. Remove the unused definitions in osdep.h. > >b. Put the common definitions used by Intel net PMDs under the macro >__INTEL_NET_BASE_OSDEP__, which works as an include file, so that it >is easily maintained. > >--- >v2: add the osdep.h clean up, which depends on v1 t

Re: [dpdk-dev] [PATCH v2] net/ice: fix TSO pkt exceeds allowed buf size issue

2020-01-15 Thread Ye Xiaolong
On 12/26, Xiaoyun Li wrote: >Hardware limits that max buffer size per tx descriptor should be >(16K-1)B. So when TSO enabled, the mbuf data size may exceed the >limit and cause malicious behavior to the NIC. This patch fixes >this issue by using more tx descs for this kind of large buffer. > >Fixes

Re: [dpdk-dev] [PATCH v4] net/i40e: add PF MDD event handler

2020-01-15 Thread Ye Xiaolong
On 01/15, taox@intel.com wrote: >From: Zhu Tao > >add warning and counter to handle the maliciouse >driver detection event. Better to have more descriptions about the motivation about this patch. >update doc/guides/nics/i40e.rst >update doc/guides/rel_notes/release_20_02.rst Above 2 lines a

[dpdk-dev] [PATCH] vhost:fix crash on port deletion and VM shutdown at same time

2020-01-15 Thread Zhike Wang
The vhost_user_read_cb() and rte_vhost_driver_unregister() can be called at the same time by 2 threads. Eg thread1 calls vhost_user_read_cb() and removes the vsocket from conn_list, then thread2 calls rte_vhost_driver_unregister() and frees the vsocket since it is NOT in the conn_list. So thread1 w

Re: [dpdk-dev] [PATCH v9 2/4] net/ice: cleanup Tx buffers

2020-01-15 Thread Di, ChenxuX
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 15, 2020 10:34 PM > To: Di, ChenxuX ; Ye, Xiaolong > Cc: dev@dpdk.org; Yang, Qiming > Subject: Re: [dpdk-dev] [PATCH v9 2/4] net/ice: cleanup Tx buffers > > On 1/14/2020 12:40 PM, Ferruh Yigit wrote: > > On 1/13/2020

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

2020-01-15 Thread Zhang, AlvinX
Tested-by: Zhang Alvin

[dpdk-dev] [PATCH] net/i40e: fix X722 judgement when disable adminq operation

2020-01-15 Thread Zhike Wang
X722 SFPs have different flavors, eg I40E_DEV_ID_SFP_X722 /I40E_DEV_ID_SFP_I_X722. So instead we use mac.type to judge whether it is X722 or not. Fixes: 9efa8d28b ("net/i40e: fix SFP X722 with FW4.16") Signed-off-by: Zhike Wang --- drivers/net/i40e/i40e_ethdev.c | 2 +- 1 file changed, 1 inserti

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events

2020-01-15 Thread Ananyev, Konstantin
> IXGBE link status task use rte alarm thread in old implementation. > Sometime ixgbe link status task takes up to 9 seconds. This will > severely affect the rte-alarm-thread-dependent a task in the > system, like interrupt or hotplug event. So replace with a > independent thread which has the s

Re: [dpdk-dev] [PATCH v3 1/6] cryptodev: introduce cpu crypto support API

2020-01-15 Thread Ananyev, Konstantin
Hi Marcin, > Add new API allowing to process crypto operations in a synchronous > manner. Operations are performed on a set of SG arrays. > > Sync mode is selected by setting appropriate flag in an xform > type number. Cryptodevs which allows CPU crypto operation mode have to > use RTE_CRYPTO

Re: [dpdk-dev] [PATCH v3 2/6] crypto/aesni_gcm: cpu crypto support

2020-01-15 Thread Ananyev, Konstantin
> > Add support for CPU crypto mode by introducing required handler. > Crypto mode (sync/async) is chosen during sym session create if an > appropriate flag is set in an xform type number. > > Authenticated encryption and decryption are supported with tag > generation/verification. > > Signed

Re: [dpdk-dev] [PATCH v3 3/6] security: add cpu crypto action type

2020-01-15 Thread Ananyev, Konstantin
> > Introduce CPU crypto action type allowing to differentiate between > regular async 'none security' and synchronous, CPU crypto accelerated > sessions. > > Signed-off-by: Marcin Smoczynski > --- > lib/librte_security/rte_security.h | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(

[dpdk-dev] [PATCH v3] net/mlx5: optimize Rx hash fields conversion

2020-01-15 Thread Dekel Peled
Previous fix added translation of Rx hash fields to PRM format. This patch optimizes the fix, to perform value translation only if value is not zero. In case value is zero, there is no need to translate it. Fixes: 51035775c3c7 ("net/mlx5: fix setting of Rx hash fields") Cc: sta...@dpdk.org Signe

Re: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-15 Thread Thomas Monjalon
15/01/2020 19:35, Ferruh Yigit: > On 1/15/2020 6:49 AM, 方统浩50450 wrote: > > Hi Ferruh, thanks for your message. > > > > > > We developed a ethtool-dpdk which is secondary process based dpdk 17.08 > > version. Our device > > support hotplug detach, but hotplug deatch is failed when we use > > et

Re: [dpdk-dev] [PATCH v4 00/36] update for i40e base code

2020-01-15 Thread Kevin Traynor
On 13/01/2020 05:59, Ye, Xiaolong wrote: > > >> -Original Message- >> From: Xing, Beilei >> Sent: Monday, January 13, 2020 11:26 AM >> To: Ye, Xiaolong >> Cc: dev@dpdk.org; Ye, Xiaolong >> Subject: RE: [dpdk-dev] [PATCH v4 00/36] update for i40e base code >> >> >> >>> -Original Mess

Re: [dpdk-dev] FW: || pw64572 lib/eventdev: use custom element size ring for event rings

2020-01-15 Thread Honnappa Nagarahalli
> >> > >> > >> > >> Aaron Conole writes: > >> > >> > >> > >> > Honnappa Nagarahalli writes: > >> > >> > > >> > >> >> Hi Aaron, > >> > >> >> I am not able to understand the error, looks like there is no > >> > >> >> particular error. Can you please take a look? > >> > >> > > >> > >> > Gladly. A

Re: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 6:49 AM, 方统浩50450 wrote: > Hi Ferruh, thanks for your message. > > > We developed a ethtool-dpdk which is secondary process based dpdk 17.08 > version. Our device > support hotplug detach, but hotplug deatch is failed when we use > ethtool-dpdk.We found the > secondary process will

[dpdk-dev] [PATCH v3 6/6] examples/ipsec-secgw: cpu crypto testing

2020-01-15 Thread Marcin Smoczynski
Enable cpu-crypto mode testing by adding dedicated environmental variable CRYPTO_PRIM_TYPE. Setting it to 'type cpu-crypto' allows to run test scenario with cpu crypto acceleration. Signed-off-by: Konstantin Ananyev Signed-off-by: Marcin Smoczynski --- examples/ipsec-secgw/test/common_defs.sh

[dpdk-dev] [PATCH v3 5/6] examples/ipsec-secgw: cpu crypto support

2020-01-15 Thread Marcin Smoczynski
Add support for CPU accelerated crypto. 'cpu-crypto' SA type has been introduced in configuration allowing to use abovementioned acceleration. Legacy mode is not currently supported. Signed-off-by: Konstantin Ananyev Signed-off-by: Marcin Smoczynski --- examples/ipsec-secgw/ipsec.c |

[dpdk-dev] [PATCH v3 4/6] ipsec: introduce support for cpu crypto mode

2020-01-15 Thread Marcin Smoczynski
Update library to handle CPU cypto security mode which utilizes cryptodev's synchronous, CPU accelerated crypto operations. Signed-off-by: Konstantin Ananyev Signed-off-by: Marcin Smoczynski --- lib/librte_ipsec/esp_inb.c | 154 ++- lib/librte_ipsec/esp_outb.c

[dpdk-dev] [PATCH v3 2/6] crypto/aesni_gcm: cpu crypto support

2020-01-15 Thread Marcin Smoczynski
Add support for CPU crypto mode by introducing required handler. Crypto mode (sync/async) is chosen during sym session create if an appropriate flag is set in an xform type number. Authenticated encryption and decryption are supported with tag generation/verification. Signed-off-by: Marcin Smoczy

[dpdk-dev] [PATCH v3 0/6] Introduce CPU crypto mode

2020-01-15 Thread Marcin Smoczynski
Originally both SW and HW crypto PMDs use rte_crypot_op based API to process the crypto workload asynchronously. This way provides uniformity to both PMD types, but also introduce unnecessary performance penalty to SW PMDs that have to "simulate" HW async behavior (crypto-ops enqueue/dequeue, HW ad

[dpdk-dev] [PATCH v3 3/6] security: add cpu crypto action type

2020-01-15 Thread Marcin Smoczynski
Introduce CPU crypto action type allowing to differentiate between regular async 'none security' and synchronous, CPU crypto accelerated sessions. Signed-off-by: Marcin Smoczynski --- lib/librte_security/rte_security.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/

[dpdk-dev] [PATCH v3 1/6] cryptodev: introduce cpu crypto support API

2020-01-15 Thread Marcin Smoczynski
Add new API allowing to process crypto operations in a synchronous manner. Operations are performed on a set of SG arrays. Sync mode is selected by setting appropriate flag in an xform type number. Cryptodevs which allows CPU crypto operation mode have to use RTE_CRYPTODEV_FF_SYM_CPU_CRYPTO capabi

Re: [dpdk-dev] FW: || pw64572 lib/eventdev: use custom element size ring for event rings

2020-01-15 Thread Aaron Conole
Honnappa Nagarahalli writes: > >> > >> >> > >> Aaron Conole writes: >> > >> >> > >> > Honnappa Nagarahalli writes: >> > >> > >> > >> >> Hi Aaron, >> > >> >> I am not able to understand the error, looks like there is no >> > >> >> particular error. Can you please take a look? >> > >> > >> > >>

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-15 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Wednesday, January 15, 2020 5:04 PM > > On Wed, Jan 15, 2020 at 9:00 PM Morten Brørup > wrote: > > > > > -Original Message- > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > >

Re: [dpdk-dev] [PATCH v3 2/4] mbuf: create packet pool with external memory buffers

2020-01-15 Thread Slava Ovsiienko
> -Original Message- > From: Olivier Matz > Sent: Tuesday, January 14, 2020 18:05 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > ; step...@networkplumber.org > Subject: Re: [PATCH v3 2/4] mbuf: create packet pool with external memory

Re: [dpdk-dev] [PATCH v3 2/4] test/crypto: refactor unit tests - continuation

2020-01-15 Thread Trahe, Fiona
Hi Adam, > -Original Message- > From: Dybkowski, AdamX > Sent: Friday, December 13, 2019 3:23 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: ravi1.ku...@amd.com; ruifeng.w...@arm.com; ano...@marvell.com; Zhang, Roy > Fan > ; Doherty, Declan ; De > Lara Guarch, Pablo > ;

Re: [dpdk-dev] [PATCH v2 0/2] Add Chacha20-Poly1305 algorithm to QAT

2020-01-15 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, January 15, 2020 5:55 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX > > Subject: [PATCH v2 0/2] Add Chacha20-Poly1305 algorithm to QAT > > This patchest adds Chacha20-Poly1305

[dpdk-dev] [PATCH v2 2/2] test/cryptodev: add chacha poly test cases to cryptodev

2020-01-15 Thread Arek Kusztal
This patch adds Chacha20-Poly1305 implementation to cryptodev tests. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev.c | 35 + app/test/test_cryptodev_aead_test_vectors.h | 77 + 2 files changed, 112 insertions(+) diff --git a/ap

[dpdk-dev] [PATCH v2 1/2] crypto/qat: add chacha poly implementation

2020-01-15 Thread Arek Kusztal
This patchset adds Chacha20-Poly1305 implementation to Intel QuickAssist Technology pmd. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/features/qat.ini| 13 +-- doc/guides/cryptodevs/qat.rst | 1 + doc/guides/rel_notes/release_20_02.rst| 5 ++ drivers/common/qat/

[dpdk-dev] [PATCH v2 0/2] Add Chacha20-Poly1305 algorithm to QAT

2020-01-15 Thread Arek Kusztal
This patchest adds Chacha20-Poly1305 algorithm to Intel QuickAssist Technology driver. v2: - rebased against current master Arek Kusztal (2): crypto/qat: add chacha poly implementation test/cryptodev: add chacha poly test cases to cryptodev app/test/test_cryptodev.c | 35

Re: [dpdk-dev] [PATCH v6 10/13] config: add debug to I40E Flow Director

2020-01-15 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 15, 2020 4:18 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Zhang, Qi Z ; > Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v6 10

[dpdk-dev] Virtio MultiQueue

2020-01-15 Thread kumaraparameshwaran rathinavel
Hi All, I am using virtio DPDK PMD with multiqueue feature and I am facing the issue where the packets of a flow aren't coming to the same RX queue, looks like it is being received randomly. On the host side I am using OpenVswitch. Please let me know if there is something to be done from the DPDK

Re: [dpdk-dev] [PATCH v6 12/13] doc: release note for ESP

2020-01-15 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 15, 2020 4:21 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Zhang, Qi Z ; > Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v6 12

Re: [dpdk-dev] [PATCH v6 03/13] app/testpmd: dump Rx and Tx mbuf

2020-01-15 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 15, 2020 4:29 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Zhang, Qi Z ; > Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v6 03

Re: [dpdk-dev] [PATCH] net/ixgbe: fix build for gcc 4.8.5

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 10:17 AM, Ye Xiaolong wrote: > On 01/14, Ferruh Yigit wrote: >> Build error: >> In function ‘ixgbe_recv_pkts_lro_bulk_alloc’: >> ../drivers/net/ixgbe/ixgbe_rxtx.c:2209:24: >> error: ‘next_sc_entry’ may be used uninitialized in this function >> [-Werror=maybe-uninitialized] >>nex

Re: [dpdk-dev] [PATCH v6 03/13] app/testpmd: dump Rx and Tx mbuf

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 3:53 PM, Bernard Iremonger wrote: > add call to rte_pktmbuf_dump() in dump_pkt_burst in util.c > > Signed-off-by: Bernard Iremonger > --- > app/test-pmd/util.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c > index b514be5..bf0387

Re: [dpdk-dev] [PATCH v6 12/13] doc: release note for ESP

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 3:53 PM, Bernard Iremonger wrote: > Release note for ESP support on the i40e PMD. > Release note for ESP support on testpmd. > > Signed-off-by: Bernard Iremonger > --- > doc/guides/rel_notes/release_20_02.rst | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/doc/gui

Re: [dpdk-dev] [PATCH v6 10/13] config: add debug to I40E Flow Director

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 3:53 PM, Bernard Iremonger wrote: > add CONFIG_RTE_LIBRTE_I40E_DEBUG_FD to config/common_base file > > Signed-off-by: Bernard Iremonger > --- > config/common_base | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/config/common_base b/config/common_base > index 7dec7ed..7a76c

[dpdk-dev] [pull-request] next-crypto 20.02 rc1

2020-01-15 Thread Akhil Goyal
The following changes since commit bbfc94efcafab236339cd1ec73bb523275d52c60: doc: reduce indentation in meson build file (2020-01-15 08:50:28 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 3115d69b6d13164523b75fbf84e1

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-15 Thread Jerin Jacob
On Wed, Jan 15, 2020 at 9:00 PM Morten Brørup wrote: > > > -Original Message- > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Wednesday, January 15, 2020 1:57 PM > > > > On Wed, Jan 15, 2020 at 5:58 PM Morten Brørup > > wrote: > > > > > > > -Original Message- > > >

Re: [dpdk-dev] [PATCH] test/compress: replace test vector

2020-01-15 Thread Akhil Goyal
> > > > This patch replaces existing test vector with a new > > one containing C code to fix license issue. > > > > Signed-off-by: Artur Trybula > Acked-by: Fiona Trahe Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: return on encountering algo as NULL

2020-01-15 Thread Akhil Goyal
> Hi, > > > > if algo is NULL set the status to error and return. This change > > prevent crashing of ipsec-secgw application when a specific > > cipher/auth/aead algo are not supported by application. > > It seems you forgot 'fix' in the header 😊 > examples/ipsec-secgw: fix ... Fixed title. >

[dpdk-dev] [PATCH v6 13/13] doc: update i40e user guide

2020-01-15 Thread Bernard Iremonger
Update the i40e user guide with ESP information. Signed-off-by: Bernard Iremonger --- doc/guides/nics/i40e.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 38acf59..5cf34d9 100644 --- a/doc/guides/nics/i40e.rst +

[dpdk-dev] [PATCH v6 11/13] net/i40e: display Flow Director packet

2020-01-15 Thread Bernard Iremonger
include rte_config.h in i40e_fdir.c In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() and in i40e_fdir_construct_pkt() Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_fdir.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --

[dpdk-dev] [PATCH v6 12/13] doc: release note for ESP

2020-01-15 Thread Bernard Iremonger
Release note for ESP support on the i40e PMD. Release note for ESP support on testpmd. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_20_02.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_2

Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: fix missing operation status check

2020-01-15 Thread Akhil Goyal
> > > > Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented") > > Fixes: 77a217a19bb7 ("test/crypto: add AES-CCM tests") > > > > Signed-off-by: Adam Dybkowski > > --- > > app/test/test_cryptodev.c | 96 +-- > > 1 file changed, 52 insertio

[dpdk-dev] [PATCH v6 10/13] config: add debug to I40E Flow Director

2020-01-15 Thread Bernard Iremonger
add CONFIG_RTE_LIBRTE_I40E_DEBUG_FD to config/common_base file Signed-off-by: Bernard Iremonger --- config/common_base | 1 + 1 file changed, 1 insertion(+) diff --git a/config/common_base b/config/common_base index 7dec7ed..7a76c26 100644 --- a/config/common_base +++ b/config/common_base @@ -3

[dpdk-dev] [PATCH v6 08/13] net/i40e: support ESP flows

2020-01-15 Thread Bernard Iremonger
add eth/ipv4/esp and eth/ipv6/esp patterns add eth/ipv4/udp/esp and eth/ipv6/esp/udp patterns update i40e_flow_parse_fdir_filter() add i40e_flow_set_filter_spi() Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_flow.c | 135 ++- 1 file changed, 1

[dpdk-dev] [PATCH v6 07/13] net/i40e: support ESP in customized code

2020-01-15 Thread Bernard Iremonger
update customized code for ESP Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5f1cf8a..a462eba

[dpdk-dev] [PATCH v6 09/13] net/i40e: support ESP in Flow Director

2020-01-15 Thread Bernard Iremonger
add fill_ip6_head() hardcode udp destination port to 4500 handle ESP and AH pctypes in ESP-AH profile Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_fdir.c | 126 --- 1 file changed, 118 insertions(+), 8 deletions(-) diff --git a/drivers/net/i

[dpdk-dev] [PATCH v6 06/13] net/i40e: support ipsec-ah profile

2020-01-15 Thread Bernard Iremonger
Add flow structures for the following patterns in i40e_ethdev files: eth/ipv4/esp eth/ipv6/esp eth/ipv4/udp/esp eth/ipv6/esp/udp add oip_type in filter add is_udp in filter use tenant_id in filter for spi Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.h | 38 +

[dpdk-dev] [PATCH v6 02/13] app/testpmd: improve debug

2020-01-15 Thread Bernard Iremonger
print function name in port_flow_complain() Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index d599682..2753ec5 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/co

[dpdk-dev] [PATCH v6 01/13] app/testpmd: parse flow command line for ESP

2020-01-15 Thread Bernard Iremonger
add ITEM_ESP add ITEM_ESP_SPI Signed-off-by: Bernard Iremonger Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 99dade7..9c6ed

[dpdk-dev] [PATCH v6 04/13] net/i40e: improve RSS debug

2020-01-15 Thread Bernard Iremonger
improve RSS debug in i40e_ethdev.c Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5999c96..5f1cf8a 100644 ---

[dpdk-dev] [PATCH v6 05/13] net/i40e: handle ESP tunnel

2020-01-15 Thread Bernard Iremonger
handle ESP tunnel in rte_pmd_i40e.c Signed-off-by: Bernard Iremonger --- drivers/net/i40e/rte_pmd_i40e.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index fdcb1a4..b987346 100644 --- a/drivers/net/i40e/rt

[dpdk-dev] [PATCH v6 03/13] app/testpmd: dump Rx and Tx mbuf

2020-01-15 Thread Bernard Iremonger
add call to rte_pktmbuf_dump() in dump_pkt_burst in util.c Signed-off-by: Bernard Iremonger --- app/test-pmd/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index b514be5..bf03873 100644 --- a/app/test-pmd/util.c +++ b/app/test-pmd/util.c @@ -

Re: [dpdk-dev] [PATCH v3] cryptodev: add chacha20-poly1305 aead algorithm

2020-01-15 Thread Akhil Goyal
> > > > This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev. > > > > Signed-off-by: Arek Kusztal > > Acked-by: Fiona Trahe > > Acked-by: Anoob Joseph > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

[dpdk-dev] [PATCH v6 00/13] net/i40e: ESP support

2020-01-15 Thread Bernard Iremonger
Changes in V6: - Rebase to latest master branch Fixed patch 0001-app-testpmd-parse-flow-command-line-for-ESP.patch Dropped the following v5 patch due to ABI breakage: 0012-librte_ethdev-add-ESP-and-AH-flow-types-to-RSS.patch Changes in V5: - Rebase to latest master branch U

Re: [dpdk-dev] [PATCH v2 1/4] cryptodev: support ECDSA

2020-01-15 Thread Akhil Goyal
> From: Ayuj Verma > > Asymmetric crypto library is extended to add ECDSA. Elliptic curve > xform and ECDSA op params are introduced. > > Signed-off-by: Anoob Joseph > Signed-off-by: Ayuj Verma > Signed-off-by: Sunila Sahu > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v2 0/4] add ECDSA support

2020-01-15 Thread Akhil Goyal
> This series adds support for ECDSA asymmetric operations. Library changes > and PMD changes for crypto_octeontx & crypto_octoentx2 is added. The final > patch adds the required test vectors and verification routines. > > v2: > * Changed all NIST references to use SECP. > * Minor updates to do

Re: [dpdk-dev] [PATCH v2 1/4] cryptodev: support ECPM

2020-01-15 Thread Akhil Goyal
> From: Balakrishna Bhamidipati > > Asymmetric crypto library is extended to add ECPM (Elliptic Curve Point > Multiplication). The required xform type and op parameters are > introduced. > > Signed-off-by: Anoob Joseph > Signed-off-by: Balakrishna Bhamidipati > Signed-off-by: Sunila Sahu >

Re: [dpdk-dev] [PATCH v2 0/4] add ECPM support

2020-01-15 Thread Akhil Goyal
> This series adds support for ECPM (Elliptic Curve Point Multiplication) > asymmetric operations. Library changes and PMD changes for > crypto_octeontx & crypto_octeontx2 is added. The final patch adds > the required test vectors and verification routines. > > v2: > * Made all references to poi

Re: [dpdk-dev] [PATCH v5 0/4] Add dual threading in QAT PMD

2020-01-15 Thread Akhil Goyal
> > Remove the limitation whereby enqueue and dequeue must be > done in same thread. > The inflight calculation is reworked to be thread-safe for 2 > threads - note this is not general multi-thread support, i.e > all enqueues to a qp must still be done in one thread and > all dequeues must be done

Re: [dpdk-dev] [PATCH v3 0/2] Handle mixed algorithms on GEN3 QAT

2020-01-15 Thread Akhil Goyal
> v2: > * Added release notes update. > > v3: > * Rebase, update release notes. > > Adam Dybkowski (2): > crypto/qat: handle mixed hash-cipher requests on GEN3 QAT > test/crypto: add more tests for mixed encypted-digest > > app/test/test_cryptodev.c| 400 +- > app

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-15 Thread Akhil Goyal
Hi Vladimir, There is more than 10% drop with this patchset on NXP hardware with both legacy mode and the ipsec lib mode. This would need some debugging. Didn't you see any drop on intel? Regards, Akhil > -Original Message- > From: Vladimir Medvedkin > Sent: Tuesday, January 14, 2020 7

Re: [dpdk-dev] [dpdk-stable] [PATCH v5] net/virtio-user: fix packed ring server mode

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 11:16 AM, Maxime Coquelin wrote: > > > On 1/15/20 7:13 AM, Xuan Ding wrote: >> This patch fixes the situation where data path does not work properly when >> vhost reconnects to virtio in server mode with packed ring. >> >> Currently, virtio and vhost share memory of vring. For split

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-15 Thread Morten Brørup
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, January 15, 2020 1:57 PM > > On Wed, Jan 15, 2020 at 5:58 PM Morten Brørup > wrote: > > > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce > Richardson

Re: [dpdk-dev] [PATCH v3 2/2] test/crypto: add more tests for mixed encypted-digest

2020-01-15 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, January 15, 2020 2:59 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v3 2/2] test/crypto: add more tests for mixed encypted-digest > > This patch adds unit tests for QAT

Re: [dpdk-dev] [PATCH v3 1/2] crypto/qat: handle mixed hash-cipher requests on GEN3 QAT

2020-01-15 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, January 15, 2020 2:59 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v3 1/2] crypto/qat: handle mixed hash-cipher requests on GEN3 > QAT > > This patch implements handl

Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet

2020-01-15 Thread Iremonger, Bernard
Hi Ferruh > >> Subject: Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow > >> Director packet > >> > >> On 1/14/2020 1:55 PM, Bernard Iremonger wrote: > >>> include rte_config.h in i40e_fdir.c > >>> In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() and > >>> in i40e_fdir_con

[dpdk-dev] [PATCH v3 1/2] crypto/qat: handle mixed hash-cipher requests on GEN3 QAT

2020-01-15 Thread Adam Dybkowski
This patch implements handling mixed encrypted digest hash-cipher requests (e.g. SNOW3G + ZUC or ZUC + AES CTR) possible when running on GEN3 QAT. Such algorithm combinations are not supported on GEN1/GEN2 hardware. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 2

[dpdk-dev] [PATCH v3 2/2] test/crypto: add more tests for mixed encypted-digest

2020-01-15 Thread Adam Dybkowski
This patch adds unit tests for QAT PMD for mixed encrypted-digest cases, involving SNOW3G UIA2, ZUC EIA3, AES CMAC and NULL auth algorithms together with SNOW3G UEA2, ZUC EEA3, AES CTR and NULL cipher algorithms in various combinations. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c

[dpdk-dev] [PATCH v3 0/2] Handle mixed algorithms on GEN3 QAT

2020-01-15 Thread Adam Dybkowski
v2: * Added release notes update. v3: * Rebase, update release notes. Adam Dybkowski (2): crypto/qat: handle mixed hash-cipher requests on GEN3 QAT test/crypto: add more tests for mixed encypted-digest app/test/test_cryptodev.c| 400 +- app/test/test_cryptodev_mixed

Re: [dpdk-dev] [PATCH] examples/fips_validation: add AES XTS support

2020-01-15 Thread Akhil Goyal
Hi Marko, > > From: Sucharitha Sarananaga > > AES XTS support is added to fips application. Parse test-vectors > from input files, populate AES XTS tests and prepare AES XTS > operations for fips validation. > > Signed-off-by: Abed Kamaluddin > Signed-off-by: Archana Muniganti > Signed-off-b

Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 2:11 PM, Iremonger, Bernard wrote: > Hi Ferruh, > > > >> Subject: Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH >> flow types to RSS >> >> On 1/15/2020 10:55 AM, Andrew Rybchenko wrote: >>> On 1/15/20 1:44 PM, Ferruh Yigit wrote: On 1/15/2020 9:13 AM, Andrew Ryb

Re: [dpdk-dev] [PATCH v9 2/4] net/ice: cleanup Tx buffers

2020-01-15 Thread Ferruh Yigit
On 1/14/2020 12:40 PM, Ferruh Yigit wrote: > On 1/13/2020 9:57 AM, Chenxu Di wrote: >> Add support to the ice driver for the API rte_eth_tx_done_cleanup >> to force free consumed buffers on Tx ring. >> >> Signed-off-by: Chenxu Di > > <...> > >> +static int >> +ice_tx_done_cleanup_vec(struct ice_

[dpdk-dev] [PATCH v5 4/4] crypto/qat: add minimum enq threshold to qat pmd

2020-01-15 Thread Arek Kusztal
This patch adds minimum enqueue threshold to Intel QuickAssist Technology PMD. It is an optimisation, configured by a command line option, which can be used to reduce MMIO write occurrences. Signed-off-by: Fiona Trahe Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 18

[dpdk-dev] [PATCH v5 3/4] common/qat: add dual thread support

2020-01-15 Thread Arek Kusztal
From: Fiona Trahe Remove the limitation whereby enqueue and dequeue must be done in same thread. The inflight calculation is reworked to be thread-safe for 2 threads - note this is not general multi-thread support, i.e all enqueues to a qp must still be done in one thread and all dequeues must be

[dpdk-dev] [PATCH v5 0/4] Add dual threading in QAT PMD

2020-01-15 Thread Arek Kusztal
Remove the limitation whereby enqueue and dequeue must be done in same thread. The inflight calculation is reworked to be thread-safe for 2 threads - note this is not general multi-thread support, i.e all enqueues to a qp must still be done in one thread and all dequeues must be done in one thread,

  1   2   >