Re: [dpdk-dev] [PATCH v2] ethdev: fix updating device data when ops pointer is NULL

2020-01-16 Thread Andrew Rybchenko
On 1/17/20 9:23 AM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" I think summary is misleading. It is too generic and does not mention VLAN offloads. Consider something like: ethdev: fix VLAN offloads set if no driver callback > Currently, there is a potential problem that changing the conte

Re: [dpdk-dev] [PATCH] vhost: check vhost message header size read

2020-01-16 Thread Tiwei Bie
On Thu, Jan 16, 2020 at 11:44:44AM +0100, Maxime Coquelin wrote: > This patch adds a check to ensure the read size of > the Vhost-user message header is not smaller than > the expected size. > > Fixes: 8f972312b8f4 ("vhost: support vhost-user") > Cc: sta...@dpdk.org > > Reported-by: Ilja Van Spru

Re: [dpdk-dev] [PATCH] vhost: catch overflow causing mmap of size 0

2020-01-16 Thread Tiwei Bie
On Thu, Jan 16, 2020 at 11:44:27AM +0100, Maxime Coquelin wrote: > This patch catches an overflow that could happen if an > invalid region size or page alignement is provided by the s/alignement/alignment/ > guest via the VHOST_USER_SET_MEM_TABLE request. > > If the sum of the size to mmap and t

Re: [dpdk-dev] [PATCH] net/ice: fix wrong GTP-U fdir profile

2020-01-16 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, January 17, 2020 2:21 PM > To: Cao, Yahui ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix wrong GTP-U fdir profile > > A GTP-U fdir profile should be regarded as a tunnel type, or

[dpdk-dev] [PATCH] doc: add release notes for Intel PMDs

2020-01-16 Thread Xiaolong Ye
Add release notes for Intel ice/iavf/i40e PMDs. Signed-off-by: Xiaolong Ye --- doc/guides/rel_notes/release_20_02.rst | 28 ++ 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_20_02.rst i

Re: [dpdk-dev] [PATCH v8] net/i40e: add PF MDD event handler

2020-01-16 Thread Ye Xiaolong
On 01/17, taox@intel.com wrote: >From: Zhu Tao > >Add warning and counter to handle the malicious driver detection event. >When the hardware determines that a malicious driver on VF, >this VF will become unworkable, the PF records and gives a warning message. > >Signed-off-by: Zhu Tao >Acked-

[dpdk-dev] [PATCH v2] ethdev: fix updating device data when ops pointer is NULL

2020-01-16 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, there is a potential problem that changing the content of dev->data->dev_conf.rxmode.offloads even when the pointer named dev->dev_ops->vlan_offload_set is NULL in the API function named rte_eth_dev_set_vlan_offload. It is a good idea that prevent the side effe

[dpdk-dev] [PATCH] net/ice: fix wrong GTP-U fdir profile

2020-01-16 Thread Qi Zhang
A GTP-U fdir profile should be regarded as a tunnel type, or the profile target to inner IPv4 will also cover inner IPv6 packet type due to some side effect. Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/ice/ice_fd

[dpdk-dev] [PATCH v8] net/i40e: add PF MDD event handler

2020-01-16 Thread taox . zhu
From: Zhu Tao Add warning and counter to handle the malicious driver detection event. When the hardware determines that a malicious driver on VF, this VF will become unworkable, the PF records and gives a warning message. Signed-off-by: Zhu Tao Acked-by: Qiming Yang --- doc/guides/nics/i40e.r

Re: [dpdk-dev] [RFC] DPDK Trace support

2020-01-16 Thread Jerin Jacob
> > > > > > > > Yes this is when trace is enabled. If the trace is disabled then it > > > > will be the only a handful of cycles. > > > > > > > Two follow-on questions: > > > 1. Is the trace enable/disable dynamic at runtime? > > > > Yes. See the requirement section. > > > > > 2. Have you investiga

[dpdk-dev] [PATCH] vfio: fix VFIO mapping failures in ppc64le

2020-01-16 Thread Takeshi Yoshimura
ppc64le failed when using large physical memory. I found problems in my two commits in the past. In commit e072d16f8920 ("vfio: fix expanding DMA area in ppc64le"), I added a sanity check using a mapped address to resolve an issue around expanding IOMMU window, but this was not enough, since memor

Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02

2020-01-16 Thread Jerin Jacob
On Fri, Jan 17, 2020 at 4:08 AM Honnappa Nagarahalli wrote: > > > > > > > > > On 1/16/20 2:11 PM, Jerin Jacob wrote: > > > > Ping. > > > > > > > > On Thu, Dec 12, 2019 at 6:42 PM wrote: > > > >> > > > >> From: Jerin Jacob > > > >> > > > >> Based on the techboard meeting held on 2019-11-06, It's

[dpdk-dev] [PATCH v7] net/i40e: add PF MDD event handler

2020-01-16 Thread taox . zhu
From: Zhu Tao Add warning and counter to handle the malicious driver detection event. When the hardware determines that a malicious driver on VF, this VF will become unworkable, the PF records and gives a warning message. Signed-off-by: Zhu Tao Acked-by: Qiming Yang --- doc/guides/nics/i40e.r

Re: [dpdk-dev] [PATCH v5] net/i40e: add PF MDD event handler

2020-01-16 Thread Zhu, TaoX
Hi ALL, The name of patch subject has forgotten to be modified. Please ignore this patch and I will resend it. BR, Zhu, Tao > -Original Message- > From: Zhu, TaoX > Sent: Friday, January 17, 2020 7:24 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Qiming ; Ye, Xiaolong

Re: [dpdk-dev] [PATCH] ethdev: move non null judgment of ops function pointer ahead

2020-01-16 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/1/17 5:08, Ferruh Yigit wrote: On 1/16/2020 12:27 PM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" This patch moves the following judgement statement to the first half of the function named rte_eth_dev_set_vlan_offload, so we can avoid changing the content of dev->d

[dpdk-dev] [PATCH v5] net/i40e: add PF MDD event handler

2020-01-16 Thread taox . zhu
From: Zhu Tao Add warning and counter to handle the malicious driver detection event. When the hardware determines that a malicious driver on VF, this VF will become unworkable, the PF records and gives a warning message. Signed-off-by: Zhu Tao Acked-by: Qiming Yang --- doc/guides/nics/i40e.r

Re: [dpdk-dev] 17.11.10 (LTS) patches review and test

2020-01-16 Thread Pei Zhang
Hi Luca, Testing with dpdk 17.11.10-rc1 from Red Hat looks good. We cover below 13 scenarios and and all get PASS: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Guest with device

Re: [dpdk-dev] [PATCH v13 2/5] eal: add the APIs to wait until equal

2020-01-16 Thread Gavin Hu
> -Original Message- > From: David Marchand > Sent: Friday, January 17, 2020 5:38 AM > To: Honnappa Nagarahalli > Cc: Gavin Hu ; Jerin Jacob ; > Ananyev, Konstantin ; > tho...@monjalon.net; dev@dpdk.org; Mcnamara, John > ; Kovacevic, Marko > ; jer...@marvell.com; Jan Viktorin > ; nd > Su

Re: [dpdk-dev] [PATCH] net/ice: cleanup for vec path check

2020-01-16 Thread Yang, Qiming
> -Original Message- > From: Ye, Xiaolong > Sent: Thursday, January 16, 2020 3:10 PM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Yigit, Ferruh ; Di, ChenxuX > ; Ye, Xiaolong > Subject: [PATCH] net/ice: cleanup for vec path check > > Move the conditional compilation block t

Re: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-16 Thread 方统浩50450
ok, I send a new version of my patch and rewrite commit log again. you can check my patch in https://patches.dpdk.org/patch/64819/ 发件人:Ferruh Yigit 发送日期:2020-01-16 20:18:18 收件人:"方统浩50450" 抄送人:Andrew Rybchenko ,Thomas Monjalon ,dev@dpdk.org,sta...@dpdk.org,jia@intel.com,cunming.li...@i

[dpdk-dev] [PATCH v3] Fixes: ethdev: secondary process change shared memory

2020-01-16 Thread Fang TongHao
Fixes the secondary process changed shared memory in "rte_eth_copy_pci_info" function.In that function only primary can update the value of "eth_dev->data" which shared by primary and secondary. Signed-off-by: Fang TongHao --- lib/librte_ethdev/rte_ethdev_pci.h | 18 ++ 1 file ch

Re: [dpdk-dev] [PATCH 1/5] ethdev: add API to dump device internal flow info

2020-01-16 Thread Stephen Hemminger
On Thu, 16 Jan 2020 20:37:36 + Ferruh Yigit wrote: > On 1/16/2020 10:14 AM, Xiaoyu Min wrote: > > Introduce an API which dump the device's internal representation > > information of rte flows in hardware. > > > > Signed-off-by: Xiaoyu Min > > <...> > > > @@ -1212,3 +1212,19 @@ rte_flow_

Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02

2020-01-16 Thread Honnappa Nagarahalli
> > > > On 1/16/20 2:11 PM, Jerin Jacob wrote: > > > Ping. > > > > > > On Thu, Dec 12, 2019 at 6:42 PM wrote: > > >> > > >> From: Jerin Jacob > > >> > > >> Based on the techboard meeting held on 2019-11-06, It's been > > >> decided to disable all kmods by default from v20.02. > > >> > > >> http

Re: [dpdk-dev] [PATCH v13 2/5] eal: add the APIs to wait until equal

2020-01-16 Thread David Marchand
On Tue, Dec 10, 2019 at 8:52 AM Honnappa Nagarahalli wrote: > > > > > > Again I suppose they might be re-used in future some other ARM > > > specific low-level primitvies. > > > > > > > > > > Do this low-level routines _LOAD_EXC_ need to be exposed in EAL > > > > > for re- > > > use? > > > > > > >

Re: [dpdk-dev] [PATCH] ethdev: move non null judgment of ops function pointer ahead

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 12:27 PM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > This patch moves the following judgement statement to the first half of > the function named rte_eth_dev_set_vlan_offload, so we can avoid changing > the content of dev->data->dev_conf.rxmode.offloads even when the pointe

Re: [dpdk-dev] [PATCH 1/5] ethdev: add API to dump device internal flow info

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 10:14 AM, Xiaoyu Min wrote: > Introduce an API which dump the device's internal representation > information of rte flows in hardware. > > Signed-off-by: Xiaoyu Min <...> > @@ -1212,3 +1212,19 @@ rte_flow_expand_rss(struct rte_flow_expand_rss *buf, > size_t size, > } >

Re: [dpdk-dev] [PATCH] net/dpaa: fix Rx offload flags on jumbo MTU set

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 7:56 AM, Apeksha Gupta wrote: > The JUMBO frame handling in dpaa_dev_mtu_set api was not correct. > When frame_size is greater than RTE_ETHER_MAX_LEN, the > intention is to add JUMBO flag in rx offload while it was resetting > all other flags other than JUMBO as AND operator was used

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-16 Thread Thomas Monjalon
16/01/2020 19:49, Neil Horman: > On Thu, Jan 16, 2020 at 03:20:48PM +0100, Thomas Monjalon wrote: > > 16/01/2020 12:52, Neil Horman: > > > On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote: > > > > 15/01/2020 12:33, Neil Horman: > > > > > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thom

Re: [dpdk-dev] [PATCH v2] app/testpmd: add dynamic flag support

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 12:53 PM, Ori Kam wrote: > DPDK now supports registration of dynamic flags (dynf) to the mbuf. > dynf can be given any name, and can be used with a supporting PMD or > supporting application. > > Due to the generic concept of the dynf, it is impossible and meaningless, > to define reg

[dpdk-dev] [RFC] service: stop lcore threads before 'finalize'

2020-01-16 Thread Aaron Conole
I've noticed an occasional segfault from the build system in the service_autotest and after talking with David (CC'd), it seems like it's due to the rte_service_finalize deleting the lcore_states object while active lcores are running. The below patch is an attempt to solve it by first reassigning

Re: [dpdk-dev] [PATCH v2] ethdev: fix switching domain allocation

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 4:19 PM, Viacheslav Ovsiienko wrote: > The maximum amount of unique swutching domain is supposed > to be equal RTE_MAX_ETHPORTS. Current implementation allows > to allocate only RTE_MAX_ETHPORTS-1 domains. > > The definition of RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID is > changed from 0

[dpdk-dev] [PATCH] app/testpmd: add support of GTP message type

2020-01-16 Thread Dekel Peled
This patch adds CLI option to enter the msg_type value for GTP flow pattern item. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 99dade7..df

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-16 Thread Neil Horman
On Thu, Jan 16, 2020 at 03:20:48PM +0100, Thomas Monjalon wrote: > 16/01/2020 12:52, Neil Horman: > > On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote: > > > 15/01/2020 12:33, Neil Horman: > > > > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote: > > > > > 20/12/2019 1

Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02

2020-01-16 Thread Jerin Jacob
On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin wrote: > > > > On 1/16/20 2:11 PM, Jerin Jacob wrote: > > Ping. > > > > On Thu, Dec 12, 2019 at 6:42 PM wrote: > >> > >> From: Jerin Jacob > >> > >> Based on the techboard meeting held on 2019-11-06, > >> It's been decided to disable all kmods by

Re: [dpdk-dev] [PATCH] net/nfp: use macro PCI_PRI_FMT for PCI log format

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 8:12 AM, Heinrich Kuhn wrote: > >> Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format. >> >> Signed-off-by: Yunjian Wang >> --- >> drivers/net/nfp/nfp_net.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/nfp/nfp_net.c b/drivers

Re: [dpdk-dev] [pull-request] next-eventdev 20.02 RC1

2020-01-16 Thread Thomas Monjalon
15/01/2020 12:57, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

[dpdk-dev] [PATCH] net/mlx5: add GTP item support

2020-01-16 Thread Dekel Peled
This patch adds to MLX5 PMD support of matching on GTP item, fields msg_type and teid, according to RFC [1]. GTP item validation and translation functions are added and called. GTP tunnel type is added to supported tunnels. [1] http://mails.dpdk.org/archives/dev/2019-December/152799.html Signed-o

Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02

2020-01-16 Thread Maxime Coquelin
On 1/16/20 2:11 PM, Jerin Jacob wrote: > Ping. > > On Thu, Dec 12, 2019 at 6:42 PM wrote: >> >> From: Jerin Jacob >> >> Based on the techboard meeting held on 2019-11-06, >> It's been decided to disable all kmods by default from v20.02. >> >> http://mails.dpdk.org/archives/dev/2019-November/1

Re: [dpdk-dev] [PATCH v3 0/4] Intel iavf and ice PMDs clean up

2020-01-16 Thread Ferruh Yigit
On 1/15/2020 10:55 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Wang, Haiyue >> Sent: Wednesday, January 15, 2020 8:50 AM >> To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z >> ; Yang, Qiming >> Cc: Wang, Haiyue >> Subject: [PATCH v3 0/4] Intel iavf and ice PMDs clean up >> >>

Re: [dpdk-dev] DPDK Release Status Meeting 16/01/2020

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 4:42 PM, Akhil Goyal wrote: > Hi Konstantin, > >> Hi Akhil, >> > > * next-net-crypto > * Pull request sent > * There is a performance concern on some ipsec-gw patches, > they can go in -rc2 if the issue is solved > * CPU crypto from last release may b

Re: [dpdk-dev] DPDK Release Status Meeting 16/01/2020

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 1:19 PM, Akhil Goyal wrote: > Hi Ferruh, > >> >> * v20.02 dates: >> * Integration deadline passed, it was on Wednesday 15 January 2020 >> * RC1 is expected before the weekend, possibly on Friday 17 January >> * PRC holidays on 24-20 Jan (inclusive) >> * Release:

Re: [dpdk-dev] [PATCH v7 00/10] net/i40e: ESP support

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 12:44 PM, Bernard Iremonger wrote: > Add support for ESP flows to testpmd. > Improve debug information in testpmd and the i40e PMD. > Process ESP flows on the i40e Flow Director. > > Changes in V7: > - > Dropped the following debug patch from v6 patchset > 0003-app-testpm

[dpdk-dev] [PATCH] usertools: add telemetry python3 compatibility

2020-01-16 Thread Ciara Power
The client script for use with the telemetry library did not support python3, as the data being sent over the socket was in string format. Python3 requires the data be explicitly converted to bytes before being sent. Similarily, the received bytes need to be decoded into string format. Cc: sta...

Re: [dpdk-dev] DPDK Release Status Meeting 16/01/2020

2020-01-16 Thread Akhil Goyal
Hi Konstantin, > Hi Akhil, > > > > > > > > > * next-net-crypto > > > > * Pull request sent > > > > * There is a performance concern on some ipsec-gw patches, > > > > they can go in -rc2 if the issue is solved > > > > * CPU crypto from last release may be breaking ABI, need to confirm >

Re: [dpdk-dev] [PATCH v9 0/6] lib/ring: APIs to support custom element size

2020-01-16 Thread Honnappa Nagarahalli
I see that the none of the CIs (except Travis) have run on this patch. Intel CI has reported a compilation error and I fixed it in this version. Does anyone know if/when the CI will run on the patches? Thanks, Honnappa > -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday

Re: [dpdk-dev] [PATCH v2 0/2] Add Chacha20-Poly1305 algorithm to QAT

2020-01-16 Thread Akhil Goyal
> > > > This patchest adds Chacha20-Poly1305 algorithm to Intel > > QuickAssist Technology driver. > > > > v2: > > - rebased against current master > > > > Arek Kusztal (2): > > crypto/qat: add chacha poly implementation > > test/cryptodev: add chacha poly test cases to cryptodev > > > > Serie

[dpdk-dev] [PATCH v2] ethdev: fix switching domain allocation

2020-01-16 Thread Viacheslav Ovsiienko
The maximum amount of unique swutching domain is supposed to be equal RTE_MAX_ETHPORTS. Current implementation allows to allocate only RTE_MAX_ETHPORTS-1 domains. The definition of RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID is changed from 0 to UINT16_MAX, the rte_eth_dev_info_get is updated to initiali

Re: [dpdk-dev] Travis not picking documentation warnings/errors

2020-01-16 Thread Richardson, Bruce
> -Original Message- > From: dev On Behalf Of David Marchand > Sent: Thursday, January 16, 2020 3:31 PM > To: Aaron Conole ; Michael Santana > > Cc: Thomas Monjalon ; c...@dpdk.org; dev > Subject: [dpdk-dev] Travis not picking documentation warnings/errors > > Hello, > > We noticed t

Re: [dpdk-dev] [PATCH v6 10/13] config: add debug to I40E Flow Director

2020-01-16 Thread Ferruh Yigit
On 1/15/2020 5:26 PM, Iremonger, Bernard wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, January 15, 2020 4:18 PM >> To: Iremonger, Bernard ; dev@dpdk.org; >> Xing, Beilei ; Zhang, Qi Z ; >> Doherty, Declan >> Cc: Ananyev, Konstantin ; Byrne, Stephe

[dpdk-dev] Travis not picking documentation warnings/errors

2020-01-16 Thread David Marchand
Hello, We noticed that documentation generation warnings/errors are not being reported in Travis. I did not look into the details, but it would sure help to catch this earlier than when merging in master. Example: https://travis-ci.com/ovsrobot/dpdk/jobs/275846558 Look for WARNING: -- David Ma

Re: [dpdk-dev] [PATCH 4/5] net/ixgbe: add missing stubs for ppc

2020-01-16 Thread Ferruh Yigit
On 1/14/2020 11:29 AM, Reshma Pattan wrote: > add stubs for ixgbe_xmit_fixed_burst_vec, > ixgbe_rx_queue_release_mbufs_vec and > ixgbe_txq_vec_setup > > CC: Vlad Zolotarov > > Signed-off-by: Reshma Pattan <...> > @@ -5834,4 +5828,23 @@ ixgbe_rxq_vec_setup(struct ixgbe_rx_queue __rte_unused >

Re: [dpdk-dev] [PATCH v9 3/4] net/ixgbe: cleanup Tx buffers

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 2:47 PM, Ferruh Yigit wrote: > On 1/13/2020 9:57 AM, Chenxu Di wrote: >> Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup >> to force free consumed buffers on Tx ring. >> >> Signed-off-by: Chenxu Di >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 2 + >> drivers/net

Re: [dpdk-dev] [PATCH v9 3/4] net/ixgbe: cleanup Tx buffers

2020-01-16 Thread Ferruh Yigit
On 1/13/2020 9:57 AM, Chenxu Di wrote: > Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup > to force free consumed buffers on Tx ring. > > Signed-off-by: Chenxu Di > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 + > drivers/net/ixgbe/ixgbe_rxtx.c | 109 ++

Re: [dpdk-dev] [dpdk-stable] [PATCH] meter: move RFC4115 trTCM APIs as none experimental

2020-01-16 Thread Thomas Monjalon
16/01/2020 13:42, Ferruh Yigit: > On 1/16/2020 11:54 AM, Neil Horman wrote: > > On Thu, Jan 16, 2020 at 12:25:06PM +0100, David Marchand wrote: > >> On Tue, Dec 17, 2019 at 2:08 PM Eelco Chaudron wrote: > >>> > >>> Moved RFC4115 APIs to none experimental as they have been there > >>> since 19.02.

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix modify actions support limitation

2020-01-16 Thread Ori Kam
> -Original Message- > From: Bing Zhao > Sent: Sunday, January 12, 2020 5:57 PM > To: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh ; > Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix modify actions support limitation > > In the root table, there i

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-16 Thread Thomas Monjalon
16/01/2020 12:52, Neil Horman: > On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote: > > 15/01/2020 12:33, Neil Horman: > > > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote: > > > > 20/12/2019 17:20, Kinsella, Ray: > > > > > From: Richardson, Bruce > > > > > > From: D

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: new flow dump CLI

2020-01-16 Thread Ori Kam
> -Original Message- > Subject: [PATCH 3/5] app/testpmd: new flow dump CLI > > From: Xueming Li > > New flow dump CLI to dump device internal representation information > of flows into screen. > > Signed-off-by: Xueming Li > Signed-off-by: Xiaoyu Min > --- Acked-by: Ori Kam Thank

Re: [dpdk-dev] [PATCH v7 02/10] app/testpmd: improve debug

2020-01-16 Thread Ananyev, Konstantin
> print function name in port_flow_complain() > > Signed-off-by: Bernard Iremonger > --- > app/test-pmd/config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index d599682..2753ec5 100644 > --- a/app/test-pmd/config.

Re: [dpdk-dev] DPDK Release Status Meeting 16/01/2020

2020-01-16 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > * next-net-crypto > > > * Pull request sent > > > * There is a performance concern on some ipsec-gw patches, > > > they can go in -rc2 if the issue is solved > > > * CPU crypto from last release may be breaking ABI, need to confirm > > > > AFAIK, there is no ABI bre

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2020-01-16 Thread Ori Kam
Just one more question inline. > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Thursday, January 16, 2020 2:03 PM > To: Ori Kam ; Medvedkin, Vladimir > ; Ananyev, Konstantin > ; Akhil Goyal ; > Adrien Mazarguil ; Doherty, Declan > ; Yigit, Ferruh ; Jerin > Jacob Kollanu

Re: [dpdk-dev] [PATCH 1/5] ethdev: add API to dump device internal flow info

2020-01-16 Thread Ori Kam
> -Original Message- > ; dpdk-dev > Subject: Re: [PATCH 1/5] ethdev: add API to dump device internal flow info > > On Thu, Jan 16, 2020 at 3:45 PM Xiaoyu Min wrote: > > > > Introduce an API which dump the device's internal representation > > information of rte flows in hardware. > > >

Re: [dpdk-dev] DPDK Release Status Meeting 16/01/2020

2020-01-16 Thread Akhil Goyal
Hi Ferruh, > > * v20.02 dates: > * Integration deadline passed, it was on Wednesday 15 January 2020 > * RC1 is expected before the weekend, possibly on Friday 17 January > * PRC holidays on 24-20 Jan (inclusive) > * Release: Friday 14 February 2020 > What is the prop

Re: [dpdk-dev] DPDK Release Status Meeting 16/01/2020

2020-01-16 Thread Akhil Goyal
Hi Konstantin, > Hi everyone, > > > > > * next-net-crypto > > * Pull request sent > > * There is a performance concern on some ipsec-gw patches, > > they can go in -rc2 if the issue is solved > > * CPU crypto from last release may be breaking ABI, need to confirm > > AFAIK, there is no

Re: [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02

2020-01-16 Thread Jerin Jacob
Ping. On Thu, Dec 12, 2019 at 6:42 PM wrote: > > From: Jerin Jacob > > Based on the techboard meeting held on 2019-11-06, > It's been decided to disable all kmods by default from v20.02. > > http://mails.dpdk.org/archives/dev/2019-November/151763.html > > Signed-off-by: Jerin Jacob > --- > con

Re: [dpdk-dev] [PATCH v4] mempool: remove memory wastage on non x86

2020-01-16 Thread Jerin Jacob
On Wed, Jan 15, 2020 at 2:35 AM wrote: > > From: Jerin Jacob > > The existing optimize_object_size() function address the memory object > alignment constraint on x86 for better performance. > > Different (micro) architecture may have different memory alignment > constraint for better performance

Re: [dpdk-dev] [PATCH v2 1/3] eal: introduce structure marker typedefs

2020-01-16 Thread Jerin Jacob
On Thu, Jan 2, 2020 at 3:18 PM Matan Azrad wrote: > > > > From: Jerin Jacob > > On Thu, Dec 26, 2019 at 1:45 PM Matan Azrad > > wrote: > > > > > > Hi > > Sorry, missed it. > Series-acked-by: Matan Azrad Ping for merge. > > > > > > > > > /** > > > > * Combines 32b inputs most significant s

[dpdk-dev] [PATCH v4 3/5] mbuf: create packet pool with external memory buffers

2020-01-16 Thread Viacheslav Ovsiienko
The dedicated routine rte_pktmbuf_pool_create_extbuf() is provided to create mbuf pool with data buffers located in the pinned external memory. The application provides the external memory description and routine initializes each mbuf with appropriate virtual and physical buffer address. It is enti

[dpdk-dev] [PATCH v4 5/5] net/mlx5: allow use allocated mbuf with external buffer

2020-01-16 Thread Viacheslav Ovsiienko
In the Rx datapath the flags in the newly allocated mbufs are all explicitly cleared but the EXT_ATTACHED_MBUF must be preserved. It would allow to use mbuf pools with pre-attached external data buffers. The vectorized rx_burst routines are updated in order to inherit the EXT_ATTACHED_MBUF from mb

[dpdk-dev] [PATCH v4 2/5] mbuf: detach mbuf with pinned external buffer

2020-01-16 Thread Viacheslav Ovsiienko
Update detach routine to check the mbuf pool type. Introduce the special internal version of detach routine to handle the special case of pinned external bufferon mbuf freeing. Signed-off-by: Shahaf Shuler Signed-off-by: Viacheslav Ovsiienko --- lib/librte_mbuf/rte_mbuf.h | 95 +

[dpdk-dev] [PATCH v4 4/5] app/testpmd: add mempool with external data buffers

2020-01-16 Thread Viacheslav Ovsiienko
The new mbuf pool type is added to testpmd. To engage the mbuf pool with externally attached data buffers the parameter "--mp-alloc=xbuf" should be specified in testpmd command line. The objective of this patch is just to test whether mbuf pool with externally attached data buffers works OK. The m

[dpdk-dev] [PATCH v4 1/5] mbuf: introduce routine to get private mbuf pool flags

2020-01-16 Thread Viacheslav Ovsiienko
The routine rte_pktmbuf_priv_flags is introduced to fetch the flags from the mbuf memory pool private structure in unified fashion. Signed-off-by: Viacheslav Ovsiienko --- lib/librte_mbuf/rte_mbuf.h | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.h

[dpdk-dev] [PATCH v4 0/5] mbuf: detach mbuf with pinned external buffer

2020-01-16 Thread Viacheslav Ovsiienko
Today's pktmbuf pool contains only mbufs with no external buffers. This means data buffer for the mbuf should be placed right after the mbuf structure (+ the private data when enabled). On some cases, the application would want to have the buffers allocated from a different device in the platform.

[dpdk-dev] [PATCH v2] app/testpmd: add dynamic flag support

2020-01-16 Thread Ori Kam
DPDK now supports registration of dynamic flags (dynf) to the mbuf. dynf can be given any name, and can be used with a supporting PMD or supporting application. Due to the generic concept of the dynf, it is impossible and meaningless, to define register set/get function for each flag. This commit

Re: [dpdk-dev] DPDK Release Status Meeting 16/01/2020

2020-01-16 Thread Ananyev, Konstantin
Hi everyone, > > * next-net-crypto > * Pull request sent > * There is a performance concern on some ipsec-gw patches, > they can go in -rc2 if the issue is solved > * CPU crypto from last release may be breaking ABI, need to confirm AFAIK, there is no ABI breakage. > and discussed

[dpdk-dev] [PATCH V4 08/10] net/bnxt: use macro for PCI log format

2020-01-16 Thread Kalesh A P
From: Kalesh AP Fixes: 19e6af01bb36 ("net/bnxt: support get/set EEPROM") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/bnxt/bnx

[dpdk-dev] [PATCH V4 09/10] net/bnxt: release port upon close

2020-01-16 Thread Kalesh A P
From: Somnath Kotur Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). Signed-off-by: Somnath Kotur Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 53 +++

[dpdk-dev] [PATCH V4 10/10] net/bnxt: fix to cap max rings to minimum of compl rings and stat contexts

2020-01-16 Thread Kalesh A P
From: Somnath Kotur Max Tx rings count could be lesser than max Rx rings in some cases, so take this into account as well. Account for stat contexts available(one for each ring) along with no: of completion rings(one for each ring) to cap the max no: of Tx /Rx rings that can be possibly created.

[dpdk-dev] [PATCH V4 05/10] net/bnxt: fix VLAN strip support

2020-01-16 Thread Kalesh A P
From: Kalesh AP HWRM_VNIC_CFG command to configure vnic dynamically with traffic running is not working. Driver has to free and recreate the vnic and then reconfigure the vnic filters. Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP

[dpdk-dev] [PATCH V4 07/10] net/bnxt: fix a memory leak in port stop

2020-01-16 Thread Kalesh A P
From: Kalesh AP The memory for mark table is allocated during port start. But the allocated memory is freed only during port close or driver unload which in turn causes a memory leakage on each port start/stop. Fixed it by moving the memory free to port stop. Fixes: a968a9f5456d ("net/bnxt: add

[dpdk-dev] [PATCH V4 01/10] net/bnxt: fix flow create failure

2020-01-16 Thread Kalesh A P
From: Kalesh AP If flow create fails due to not enough filter resources, driver does not populate the rte_flow_error using rte_flow_error_set(). Since "rte_errno" could have garbage value and is not relaiable, it could cause a segfault in the stack in port_flow_complain(). Fix it to set rte_flo

[dpdk-dev] [PATCH V4 06/10] net/bnxt: handle hw filter setting when port is stopped

2020-01-16 Thread Kalesh A P
From: Kalesh AP Driver destroy the vnic when the port is brought down. Port hw filter setting such as promiscuos, allmulti and vlan filtering will be applied when port is started. Fixed to return success silently for these callbacks when port is stopped. Also fixed to clear "bp->dev_stopped" bef

[dpdk-dev] [PATCH V4 04/10] net/bnxt: fix enable/disable VLAN filtering

2020-01-16 Thread Kalesh A P
From: Kalesh AP There is no condition check for the user requested operation for VLAN filtering. As a result, VLAN filtering is getting disabled when the user enables/disables VLAN stripping on same port. The function bnxt_hwrm_clear_l2_filter() didn't actually free L2 filter in HW if the refere

[dpdk-dev] [PATCH V4 02/10] net/bnxt: fix probe failure in FreeBSD

2020-01-16 Thread Kalesh A P
From: Kalesh AP In FreeBSD environment, nic_uio driver does not support interrupts and rte_intr_callback_register() will fail to register interrupts which in turn causes bnxt driver probe failure. Fixed driver to ignore interrupt callback failures in FreeBSD. Also fixed to not use a dedicated co

[dpdk-dev] [PATCH V4 03/10] net/bnxt: fix to use correct IOVA mapping

2020-01-16 Thread Kalesh A P
From: Kalesh AP Use rte_malloc_virt2iova() to obtain the IO address of a virtual address obtained through rte_malloc(). Fixed to use the iova address returned by rte_memzone_reserve_aligned() as the call always returns with populating "mz->iova" with rte_malloc_virt2iova(mz->addr). Removed redu

[dpdk-dev] [PATCH V4 00/10] bnxt patchset with bug fixes

2020-01-16 Thread Kalesh A P
From: Kalesh AP v1->v2: fixed the correct the commit ids in Fixes tag. v2->v3: shorten commit log and update commit ids for Fixes tag. v3->v4: addressed Ferruh's comment on Patch#1 and Pacth#9 and marked required patches for stable inclusion. Kalesh AP (8): net/bnxt: fix flow create failure

[dpdk-dev] [PATCH v7 08/10] net/i40e: support ESP in Flow Director

2020-01-16 Thread Bernard Iremonger
add fill_ip6_head() hardcode udp destination port to 4500 handle ESP and AH pctypes in ESP-AH profile update the i40e user guide with ESP information. update release notes for i40e changes Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- doc/guides/nics/i40e.rst | 4 +- d

[dpdk-dev] [PATCH v7 10/10] net/i40e: display Flow Director packet

2020-01-16 Thread Bernard Iremonger
include rte_config.h in i40e_fdir.c In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() and in i40e_fdir_construct_pkt() Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_fdir.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --

[dpdk-dev] [PATCH v7 07/10] net/i40e: support ESP flows

2020-01-16 Thread Bernard Iremonger
add eth/ipv4/esp and eth/ipv6/esp patterns add eth/ipv4/udp/esp and eth/ipv6/esp/udp patterns update i40e_flow_parse_fdir_filter() add i40e_flow_set_filter_spi() Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_flow.c | 135 ++

[dpdk-dev] [PATCH v7 06/10] net/i40e: support ESP in customized code

2020-01-16 Thread Bernard Iremonger
update customized code for ESP Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c in

[dpdk-dev] [PATCH v7 09/10] config: add debug to I40E Flow Director

2020-01-16 Thread Bernard Iremonger
add CONFIG_RTE_LIBRTE_I40E_DEBUG_FD to config/common_base file Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- config/common_base | 1 + 1 file changed, 1 insertion(+) diff --git a/config/common_base b/config/common_base index 7dec7ed..7a76c26 100644 --- a/config/common_base +++ b/conf

[dpdk-dev] [PATCH v7 00/10] net/i40e: ESP support

2020-01-16 Thread Bernard Iremonger
Add support for ESP flows to testpmd. Improve debug information in testpmd and the i40e PMD. Process ESP flows on the i40e Flow Director. Changes in V7: - Dropped the following debug patch from v6 patchset 0003-app-testpmd-dump-Rx-and-Tx-mbuf.patch Included release notes and doc patch

[dpdk-dev] [PATCH v7 05/10] net/i40e: support ipsec-ah profile

2020-01-16 Thread Bernard Iremonger
Add flow structures for the following patterns in i40e_ethdev files: eth/ipv4/esp eth/ipv6/esp eth/ipv4/udp/esp eth/ipv6/esp/udp add oip_type in filter add is_udp in filter use tenant_id in filter for spi Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.h |

[dpdk-dev] [PATCH v7 04/10] net/i40e: handle ESP tunnel

2020-01-16 Thread Bernard Iremonger
handle ESP tunnel in rte_pmd_i40e.c Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/rte_pmd_i40e.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index fdcb1a4..b987346 100644 --- a

[dpdk-dev] [PATCH v7 02/10] app/testpmd: improve debug

2020-01-16 Thread Bernard Iremonger
print function name in port_flow_complain() Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index d599682..2753ec5 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/co

[dpdk-dev] [PATCH v7 03/10] net/i40e: improve RSS debug

2020-01-16 Thread Bernard Iremonger
improve RSS debug in i40e_ethdev.c Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5999c96..5f1cf8a 100644 ---

[dpdk-dev] [PATCH v7 01/10] app/testpmd: parse flow command line for ESP

2020-01-16 Thread Bernard Iremonger
add ITEM_ESP add ITEM_ESP_SPI update release notes for testpmd changes add sample ESP rules in testpmd guide Signed-off-by: Bernard Iremonger Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 34 ++--- doc/guides/rel_notes/release_20_02.rst | 4 ++

[dpdk-dev] [PATCH v5 4/4] test/crypto: refactor unit tests into one combined array

2020-01-16 Thread Adam Dybkowski
This patch refactors most of unit tests to be contained in one combined array, and run depending on the PMD capabilities instead of providing multiple array with tests for individual PMDs. Only a subset of unit tests was merged into one array - it combines all tests originally meant to be run on th

[dpdk-dev] [PATCH v5 2/4] test/crypto: refactor unit tests - continuation

2020-01-16 Thread Adam Dybkowski
Remove the functions that are not used any more but were left after the previous commit. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 323 -- 1 file changed, 323 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c

[dpdk-dev] [PATCH v5 3/4] test/crypto: add capability checks

2020-01-16 Thread Adam Dybkowski
This patch adds capability checks to many tests meant to be run in the future on various PMDs. This way the code is prepared for more thorough refactoring in order to create one big central unit tests array. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 616 ++

Re: [dpdk-dev] [dpdk-stable] [PATCH] meter: move RFC4115 trTCM APIs as none experimental

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 11:54 AM, Neil Horman wrote: > On Thu, Jan 16, 2020 at 12:25:06PM +0100, David Marchand wrote: >> On Tue, Dec 17, 2019 at 2:08 PM Eelco Chaudron wrote: >>> >>> Moved RFC4115 APIs to none experimental as they have been there >>> since 19.02. Also, these APIs are the same as the none RF

  1   2   >