Re: [dpdk-dev] [PATCH v5 11/17] net/ionic: add Rx filters support

2020-01-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Monday, January 20, 2020 6:58 PM > To: Alfredo Cardigliano ; John McNamara > ; Marko Kovacevic > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: Re: [dpdk-dev] [PATCH v5 11/17] net/ionic: add Rx filters support > > On 1/19/2020 3:53

Re: [dpdk-dev] [PATCH v2 0/3] armv8 crypto PMD update

2020-01-20 Thread Akhil Goyal
Hi, Please also enable meson build for armv8 PMD. There was a patch in last release which was not applied. That need a rebase and can be included in this series if more changes need to be done for the changes in this patchset. http://patches.dpdk.org/patch/60499/ Please also update the release

Re: [dpdk-dev] [PATCH v6 3/5] mbuf: create packet pool with external memory buffers

2020-01-20 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Monday, January 20, 2020 22:48 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > ; olivier.m...@6wind.com; tho...@mellanox.net > Subject: Re: [PATCH v6 3/5] mbuf: create packet pool

Re: [dpdk-dev] [PATCH v5 1/5] mbuf: introduce routine to get private mbuf pool flags

2020-01-20 Thread Slava Ovsiienko
Hi, Stephen I'm appreciated for the for reviewing. > -Original Message- > From: Stephen Hemminger > Sent: Monday, January 20, 2020 22:44 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > ; olivier.m...@6wind.com; tho...@mellanox.net >

Re: [dpdk-dev] [PATCH v2 0/7] support switch management

2020-01-20 Thread Xiaojun Liu
Hi Xiao, Thank you! I will update the commit log and prepare a document to describe the design and implementation. Best regards, Xiaojun -Original Message- From: Wang, Xiao W [mailto:xiao.w.w...@intel.com] Sent: Tuesday, January 21, 2020 10:53 AM To: Xiaojun Liu Cc: dev@dpdk.org; Zhang

Re: [dpdk-dev] [PATCH v1] crypto/ccp: add support for new CCP device ID

2020-01-20 Thread Kumar, Ravi1
[AMD Public Use] Looks good to me. Acked-by: Ravi Kumar Regards, Ravi >-Original Message- >From: dev On Behalf Of Selwin Sebastian >Sent: Monday, December 30, 2019 10:05 PM >To: dev@dpdk.org >Cc: Sebastian, Selwin >Subject: [dpdk-dev] [PATCH v1] crypto/ccp: add support for new CCP

Re: [dpdk-dev] [PATCH v1] crypto/ccp: aes-gcm driver bug fix

2020-01-20 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Looks good to me. Acked-by: Ravi Kumar Regards, Ravi > > >-Original Message- >From: dev On Behalf Of Selwin Sebastian >Sent: Tuesday, December 31, 2019 12:38 AM >To: dev@dpdk.org >Cc: Sebastian, Selwin >Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH] doc: add inline protocol in feature list

2020-01-20 Thread Anoob Joseph
Hi Ferruh, Can you review this patch? Thanks, Anoob > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Tuesday, December 10, 2019 12:23 PM > To: John McNamara ; Marko Kovacevic > ; Ferruh Yigit > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athr

[dpdk-dev] [DPDK] net/ice: add outer IPv4 matching for GTPU flow

2020-01-20 Thread chenmin . sun
From: Chenmin Sun This patch adds the capability of matching the outer IPv4 headers for GTPU flows Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") Signed-off-by: Chenmin Sun --- drivers/net/ice/base/ice_fdir.c | 4 drivers/net/ice/ice_fdir_filter.c | 3 ++- 2 files c

Re: [dpdk-dev] [PATCH v2 0/7] support switch management

2020-01-20 Thread Wang, Xiao W
Hi Xiaojun, Could you please help to improve the commit logs of all the 7 patches? They look very similar, and info like below is not very helpful for reviewer, since we already know which file you are adding. "To support switch management, add the following files: Add fm10k/switch/fm10k_debug.h

[dpdk-dev] [PATCH v2] net/ice: fix FDIR flag issue

2020-01-20 Thread Beilei Xing
If there's no mark action when creating a FDIR rule, there shouldn't be FDIR flags in mbuf. Fixes: f5cafa961fae ("net/ice: add flow director create and destroy") Fixes: bd984f155f49 ("net/ice/base: support FDIR") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing Acked-by: Qi Zhang --- V2 change:

[dpdk-dev] [PATCH] net/ice: fix FDIR PASSTHRU issue

2020-01-20 Thread Yahui Cao
The original PASSTHRU implementation is forwarding to queue 0. The corrected implementation is forwarding to the next stage filter. Fixes: f5cafa961fae ("net/ice: add flow director create and destroy") Cc: sta...@dpdk.org Signed-off-by: Yahui Cao --- drivers/net/ice/base/ice_fdir.c | 9 ++

[dpdk-dev] [dpdk-stable] [PATCH v2] net/tap: fix memory leak when unregister intr handler

2020-01-20 Thread Yunjian Wang
The return check of function tap_lsc_intr_handle_set() is wrong, it should be 0 or a positive number if success. So the intr_handle->intr_vec was not been freed when tap_lsc_intr_handle_set() returned a positive number. Fixes: 4870a8cdd968 ("net/tap: support Rx interrupt") Cc: sta...@dpdk.org Sig

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: fix memory leak when unregister intr handler

2020-01-20 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, January 20, 2020 8:43 PM > To: wangyunjian ; dev@dpdk.org; > keith.wi...@intel.com > Cc: xudingke ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/tap: fix memory leak when > unreg

[dpdk-dev] [PATCH v2] net/ice: fix fdir GTP-U pattern

2020-01-20 Thread Qi Zhang
Base on current fdir implementation for GTP-U, inner specification is not supported, issue a rule for eth/ipv4/gtpu/ipv4 will also match eth/ipv4/gtpu/ipv6, the patch add new pattern list to align with exist implementation. Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") Cc: sta

[dpdk-dev] [dpdk-announce] release candidate 20.02-rc1

2020-01-20 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v20.02-rc1 There are 374 new patches in this snapshot. DPDK 20.02 will be tiny, as expected. The release notes so far: http://doc.dpdk.org/guides/rel_notes/release_20_02.html Please think about up

Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE

2020-01-20 Thread Thomas Monjalon
02/12/2019 16:35, David Marchand: > We are currently stuck with no option but recompile a DPDK if the system > has more cores than RTE_MAX_LCORE. > A bit of a pity when you get a system with more than 200+ cores and your > testpmd has been built and packaged with RTE_MAX_LCORE == 128. > > The --lc

Re: [dpdk-dev] [PATCH v6 0/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Thomas Monjalon
20/01/2020 20:16, Viacheslav Ovsiienko: > Today's pktmbuf pool contains only mbufs with no external buffers. > This means data buffer for the mbuf should be placed right after the > mbuf structure (+ the private data when enabled). > > On some cases, the application would want to have the buffers

Re: [dpdk-dev] [PATCH v5 1/5] mbuf: introduce routine to get private mbuf pool flags

2020-01-20 Thread Thomas Monjalon
20/01/2020 21:43, Stephen Hemminger: > On Mon, 20 Jan 2020 17:23:19 + > Viacheslav Ovsiienko wrote: > > > The routine rte_pktmbuf_priv_flags is introduced to fetch > > the flags from the mbuf memory pool private structure > > in unified fashion. > > > > Signed-off-by: Viacheslav Ovsiienko >

Re: [dpdk-dev] [PATCH] mk: disable OCTEON TX2 EP on old compilers

2020-01-20 Thread Thomas Monjalon
20/01/2020 20:51, Ali Alnubani: > OCTEON TX2 isn't built for gcc 4.8.5 as the compiler emits > "internal compiler error" on aarch64. This causes the following > build error when OCTEON TX2 EP is enabled: > > /usr/bin/ld: cannot find -lrte_common_octeontx2 > collect2: error: ld returned 1 exit

Re: [dpdk-dev] [PATCH v2 3/3] mbuf: use structure marker typedef in eal

2020-01-20 Thread Thomas Monjalon
26/12/2019 17:24, Olivier Matz: > On Thu, Dec 19, 2019 at 04:55:07PM +0530, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Use new marker typedef available in EAL and remove private marker > > typedef. > > > > Signed-off-by: Jerin Jacob > > Acked-by: Olivier Matz Series applied, tha

Re: [dpdk-dev] [PATCH V4 00/10] bnxt patchset with bug fixes

2020-01-20 Thread Ajit Khaparde
On Thu, Jan 16, 2020 at 4:47 AM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > v1->v2: fixed the correct the commit ids in Fixes tag. > v2->v3: shorten commit log and update commit ids for Fixes tag. > v3->v4: addressed Ferruh's comment on Patch#1 and Pacth#9 and m

Re: [dpdk-dev] [PATCH v6 3/5] mbuf: create packet pool with external memory buffers

2020-01-20 Thread Stephen Hemminger
On Mon, 20 Jan 2020 19:16:24 + Viacheslav Ovsiienko wrote: > + ((user_mbp_priv->flags & RTE_PKTMBUF_POOL_F_PINNED_EXT_BUF) ? > + sizeof(struct rte_mbuf_ext_shared_info) : > + user_mbp_priv->mbuf_data_room_size Should rte_pktmbuf_data_room_s

Re: [dpdk-dev] [PATCH v5 1/5] mbuf: introduce routine to get private mbuf pool flags

2020-01-20 Thread Stephen Hemminger
On Mon, 20 Jan 2020 17:23:19 + Viacheslav Ovsiienko wrote: > The routine rte_pktmbuf_priv_flags is introduced to fetch > the flags from the mbuf memory pool private structure > in unified fashion. > > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Olivier Matz > --- > lib/librte_mbuf/rte

[dpdk-dev] [PATCH] maintainers: set git tree for EAL and core libraries

2020-01-20 Thread David Marchand
Without a git tree, the "guess" script from dpdk-ci will ignore all files that are referenced in those sections and let a patchset land in any subtree. Changes in the EAL, mbuf, mempool... go through the main repository. Signed-off-by: David Marchand --- MAINTAINERS | 2 ++ 1 file changed, 2 ins

Re: [dpdk-dev] [PATCH v2 1/3] eal: introduce structure marker typedefs

2020-01-20 Thread Thomas Monjalon
19/12/2019 12:25, jer...@marvell.com: > From: Jerin Jacob > > Introduce EAL typedef for structure 1B, 2B, 4B, 8B alignment marking and > a generic marker for a point in a structure. > > Signed-off-by: Jerin Jacob > --- > > v2: > - Changed __extension__ to RTE_STD_C11 (Thomas) Actually I was

[dpdk-dev] [PATCH] mk: disable OCTEON TX2 EP on old compilers

2020-01-20 Thread Ali Alnubani
OCTEON TX2 isn't built for gcc 4.8.5 as the compiler emits "internal compiler error" on aarch64. This causes the following build error when OCTEON TX2 EP is enabled: /usr/bin/ld: cannot find -lrte_common_octeontx2 collect2: error: ld returned 1 exit status Fixes: 56d46d13f736 ("raw/octeontx2_

Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE

2020-01-20 Thread David Marchand
On Mon, Jan 20, 2020 at 7:37 PM Yigit, Ferruh wrote: > > On 12/2/2019 3:35 PM, David Marchand wrote: > > We are currently stuck with no option but recompile a DPDK if the system > > has more cores than RTE_MAX_LCORE. > > A bit of a pity when you get a system with more than 200+ cores and your > >

[dpdk-dev] [PATCH v6 1/5] mbuf: introduce routine to get private mbuf pool flags

2020-01-20 Thread Viacheslav Ovsiienko
The routine rte_pktmbuf_priv_flags is introduced to fetch the flags from the mbuf memory pool private structure in unified fashion. Signed-off-by: Viacheslav Ovsiienko Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 17 + 1 file changed, 17 insertions(+) diff --git a/li

[dpdk-dev] [PATCH v6 5/5] net/mlx5: allow use allocated mbuf with external buffer

2020-01-20 Thread Viacheslav Ovsiienko
In the Rx datapath the flags in the newly allocated mbufs are all explicitly cleared but the EXT_ATTACHED_MBUF must be preserved. It would allow to use mbuf pools with pre-attached external data buffers. The vectorized rx_burst routines are updated in order to inherit the EXT_ATTACHED_MBUF from mb

[dpdk-dev] [PATCH v6 3/5] mbuf: create packet pool with external memory buffers

2020-01-20 Thread Viacheslav Ovsiienko
The dedicated routine rte_pktmbuf_pool_create_extbuf() is provided to create mbuf pool with data buffers located in the pinned external memory. The application provides the external memory description and routine initializes each mbuf with appropriate virtual and physical buffer address. It is enti

[dpdk-dev] [PATCH v6 4/5] app/testpmd: add mempool with external data buffers

2020-01-20 Thread Viacheslav Ovsiienko
The new mbuf pool type is added to testpmd. To engage the mbuf pool with externally attached data buffers the parameter "--mp-alloc=xbuf" should be specified in testpmd command line. The objective of this patch is just to test whether mbuf pool with externally attached data buffers works OK. The m

[dpdk-dev] [PATCH v6 2/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Viacheslav Ovsiienko
Update detach routine to check the mbuf pool type. Introduce the special internal version of detach routine to handle the special case of pinned external bufferon mbuf freeing. Signed-off-by: Shahaf Shuler Signed-off-by: Viacheslav Ovsiienko Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.

[dpdk-dev] [PATCH v6 0/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Viacheslav Ovsiienko
Today's pktmbuf pool contains only mbufs with no external buffers. This means data buffer for the mbuf should be placed right after the mbuf structure (+ the private data when enabled). On some cases, the application would want to have the buffers allocated from a different device in the platform.

Re: [dpdk-dev] [PATCH] build: allow using wildcards to disable drivers

2020-01-20 Thread Thomas Monjalon
20/01/2020 18:37, Bruce Richardson: > Rather than having to explicitly list each and every driver to disable in a > build, we can use a small python script and the python glob library to > expand out the wildcards. This means that we can configure meson using e.g. > > meson -Ddisable_drivers=c

Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE

2020-01-20 Thread Yigit, Ferruh
On 12/2/2019 3:35 PM, David Marchand wrote: > We are currently stuck with no option but recompile a DPDK if the system > has more cores than RTE_MAX_LCORE. > A bit of a pity when you get a system with more than 200+ cores and your > testpmd has been built and packaged with RTE_MAX_LCORE == 128. Ju

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/compress: replace test vector

2020-01-20 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon > Sent: Monday, January 20, 2020 2:33 PM > To: Trahe, Fiona ; Trybula, ArturX > ; Mcnamara, John > Cc: dev@dpdk.org; sta...@dpdk.org; shal...@marvell.com; Dybkowski, AdamX > ; Danilewicz, MarcinX > ; Akhil Goyal > Subject: Re: [dpdk-stable]

Re: [dpdk-dev] [PATCH v2 1/1] eal: improve user notification for too low memzone segments

2020-01-20 Thread Thomas Monjalon
14/01/2020 11:40, Burakov, Anatoly: > On 20-Dec-19 3:08 PM, Artur Trybula wrote: > > In case of too low number of memzone segements user notification > > was misleading. This patch improves the description by providing > > better explanation about the cause. > > > > Signed-off-by: Artur Trybula >

Re: [dpdk-dev] [PATCH v5 3/5] mbuf: create packet pool with external memory buffers

2020-01-20 Thread Olivier Matz
On Mon, Jan 20, 2020 at 05:23:21PM +, Viacheslav Ovsiienko wrote: > The dedicated routine rte_pktmbuf_pool_create_extbuf() is > provided to create mbuf pool with data buffers located in > the pinned external memory. The application provides the > external memory description and routine initiali

Re: [dpdk-dev] [PATCH v2] config: disable all kmods by default from v20.02

2020-01-20 Thread Thomas Monjalon
17/01/2020 20:14, jer...@marvell.com: > From: Jerin Jacob > > Based on the techboard meeting held on 2019-11-06, > It's been decided to disable all kmods by default from v20.02. > > http://mails.dpdk.org/archives/dev/2019-November/151763.html > > Signed-off-by: Jerin Jacob > --- > v2: > - Upda

Re: [dpdk-dev] [PATCH v5 0/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Olivier Matz
On Mon, Jan 20, 2020 at 05:30:45PM +, Slava Ovsiienko wrote: > The unit test (as part of test_mbuf application) will be provided as > separated patch. OK, thanks

Re: [dpdk-dev] [PATCH v5 2/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Olivier Matz
On Mon, Jan 20, 2020 at 05:23:20PM +, Viacheslav Ovsiienko wrote: > Update detach routine to check the mbuf pool type. > Introduce the special internal version of detach routine to handle > the special case of pinned external bufferon mbuf freeing. > > Signed-off-by: Shahaf Shuler > Signed-of

[dpdk-dev] [PATCH] build: allow using wildcards to disable drivers

2020-01-20 Thread Bruce Richardson
Rather than having to explicitly list each and every driver to disable in a build, we can use a small python script and the python glob library to expand out the wildcards. This means that we can configure meson using e.g. meson -Ddisable_drivers=crypto/*,event/* build to do a build omitting

Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled

2020-01-20 Thread Bruce Richardson
On Mon, Dec 23, 2019 at 06:53:05AM +, Reshma Pattan wrote: > Some unit tests has dependency on RING PMD, > so this patch is trying to fix those and other > closely related issues. > > 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter > unit tests are dependent on ring PMD, so c

Re: [dpdk-dev] [PATCH v4 3/5] mbuf: create packet pool with external memory buffers

2020-01-20 Thread Slava Ovsiienko
Hi, Olivier Great! Thanks a lot for the unit test template, this is very nice starting point, I will think what would be good to add for more thorough testing. With best regards, Slava > One more thing: it would be nice to have a functional test for this new > feature. I did a very minimal one

Re: [dpdk-dev] [PATCH v5 0/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Slava Ovsiienko
The unit test (as part of test_mbuf application) will be provided as separated patch. With best regards, Slava > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Monday, January 20, 2020 19:23 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ;

[dpdk-dev] [PATCH v5 4/5] app/testpmd: add mempool with external data buffers

2020-01-20 Thread Viacheslav Ovsiienko
The new mbuf pool type is added to testpmd. To engage the mbuf pool with externally attached data buffers the parameter "--mp-alloc=xbuf" should be specified in testpmd command line. The objective of this patch is just to test whether mbuf pool with externally attached data buffers works OK. The m

[dpdk-dev] [PATCH v5 3/5] mbuf: create packet pool with external memory buffers

2020-01-20 Thread Viacheslav Ovsiienko
The dedicated routine rte_pktmbuf_pool_create_extbuf() is provided to create mbuf pool with data buffers located in the pinned external memory. The application provides the external memory description and routine initializes each mbuf with appropriate virtual and physical buffer address. It is enti

[dpdk-dev] [PATCH v5 5/5] net/mlx5: allow use allocated mbuf with external buffer

2020-01-20 Thread Viacheslav Ovsiienko
In the Rx datapath the flags in the newly allocated mbufs are all explicitly cleared but the EXT_ATTACHED_MBUF must be preserved. It would allow to use mbuf pools with pre-attached external data buffers. The vectorized rx_burst routines are updated in order to inherit the EXT_ATTACHED_MBUF from mb

[dpdk-dev] [PATCH v5 0/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Viacheslav Ovsiienko
Today's pktmbuf pool contains only mbufs with no external buffers. This means data buffer for the mbuf should be placed right after the mbuf structure (+ the private data when enabled). On some cases, the application would want to have the buffers allocated from a different device in the platform.

[dpdk-dev] [PATCH v5 1/5] mbuf: introduce routine to get private mbuf pool flags

2020-01-20 Thread Viacheslav Ovsiienko
The routine rte_pktmbuf_priv_flags is introduced to fetch the flags from the mbuf memory pool private structure in unified fashion. Signed-off-by: Viacheslav Ovsiienko Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 17 + 1 file changed, 17 insertions(+) diff --git a/li

[dpdk-dev] [PATCH v5 2/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Viacheslav Ovsiienko
Update detach routine to check the mbuf pool type. Introduce the special internal version of detach routine to handle the special case of pinned external bufferon mbuf freeing. Signed-off-by: Shahaf Shuler Signed-off-by: Viacheslav Ovsiienko --- lib/librte_mbuf/rte_mbuf.h | 102

[dpdk-dev] [PATCH v2] pktgen: fix sequence help message

2020-01-20 Thread Ivan Dyukov
pktgen cli does not show sequence help if it's wrong or incomplete Signed-off-by: Ivan Dyukov --- app/cli-functions.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/cli-functions.c b/app/cli-functions.c index f104781..f43d23e 100644 --- a/app/cli-functions.c +++ b

[dpdk-dev] [PATCH v2 1/2] net/virtio: refactor devargs parsing

2020-01-20 Thread Ivan Dyukov
refactor vdpa specific devargs parsing to more generic way Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 35 +- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev

[dpdk-dev] [PATCH v2 2/2] net/virtio: add link speed devarg

2020-01-20 Thread Ivan Dyukov
Some applications like pktgen use link_speed to calculate transmit rate. It limits outcome traffic to hardcoded 10G. This patch adds link_speed devarg which allows to configure link_speed of virtio device. Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 101 +

[dpdk-dev] [PATCH v1 35/38] net/mlx5: reduce Netlink commands dependencies

2020-01-20 Thread Matan Azrad
As an arrangment for Netlink command moving to the common library, reduce the net/mlx5 dependecies. Replace ethdev class command parameters. Improve Netlink sequence number mechanism to be controlled by the mlx5 Netlink mechanism. Move mlx5_nl_check_switch_info to mlx5_nl.c since it is the only

[dpdk-dev] [PATCH v1 34/38] net/mlx5: separate Netlink commands interface

2020-01-20 Thread Matan Azrad
The Netlink commands interfaces is included in the mlx5.h file with a lot of other PMD interfaces. As an arrangement to make the Netlink commands shared with different PMDs, this patch moves the Netlink interface to a new file called mlx5_nl.h. Move non Netlink pure vlan commands from mlx5_nl.c t

[dpdk-dev] [PATCH v1 38/38] vdpa/mlx5: disable ROCE

2020-01-20 Thread Matan Azrad
In order to support virtio queue creation by the FW, ROCE mode should be disabled in the device. Do it by netlink which is like the devlink tool commands: 1. devlink dev param set pci/[pci] name enable_roce value false cmode driverinit 2. devlink dev reload pci/[pci] Or

[dpdk-dev] [PATCH v1 37/38] common/mlx5: support ROCE disable through Netlink

2020-01-20 Thread Matan Azrad
Add new 4 Netlink commands to support enable/disable ROCE: 1. mlx5_nl_devlink_family_id_get to get the Devlink family ID of Netlink general command. 2. mlx5_nl_enable_roce_get to get the ROCE current status. 3. mlx5_nl_driver_reload - to reload the device kernel d

[dpdk-dev] [PATCH v1 36/38] mlx5: share Netlink commands

2020-01-20 Thread Matan Azrad
Move Netlink mechanism and its dependecies from net/mlx5 to common/mlx5 in order to be ready to use by other mlx5 drivers. The dependencies are BITFIELD defines, the ppc64 compilation workaround for bool type and the function mlx5_translate_port_name. Update build mechanism accordingly. Signed-o

[dpdk-dev] [PATCH v1 33/38] mlx5: skip probing according to the vDPA mode

2020-01-20 Thread Matan Azrad
Both, net/mlx5 PMD and vdpa/mlx5 drivers can probe the same Mellanox devices. Skip net/mlx5 PMD probing while the device is in vDPA mode selected by the device devargs provided by the user: vdpa=1. Skip vdpa/mlx5 PMD probing while the device is not in vDPA mode selected by the device devargs prov

[dpdk-dev] [PATCH v1 31/38] vdpa/mlx5: support live migration

2020-01-20 Thread Matan Azrad
Add support for live migration feature by the HW: Create a single Mkey that maps the memory address space of the VHOST live migration log file. Modify VIRTIO_NET_Q object and provide vhost_log_page, dirty_bitmap_mkey, dirty_bitmap_size, dirty_bitmap_a

[dpdk-dev] [PATCH v1 25/38] common/mlx5: add TIR fields constants

2020-01-20 Thread Matan Azrad
The DevX TIR object configuration should get L3 and L4 protocols expected to be forwarded by the TIR. Add the PRM constant values needed to configure the L3 and L4 protocols. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 10 ++ 1 file changed, 10 insertions(+) diff --

[dpdk-dev] [PATCH v1 32/38] vdpa/mlx5: support close and config operations

2020-01-20 Thread Matan Azrad
Support dev_conf and dev_conf operations. These operations allow vdpa traffic. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.c | 51 +-- drivers/vdpa/mlx5/mlx5_vdpa.h | 1 + 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH v1 26/38] common/mlx5: add DevX command to modify RQT

2020-01-20 Thread Matan Azrad
RQ table can be changed to support different list of queues. Add DevX command to modify DevX RQT object to point on new RQ list. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c| 47 + drivers/common/mlx5/mlx5_devx_cmds.h| 2 ++

[dpdk-dev] [PATCH v1 29/38] vdpa/mlx5: support queue state operation

2020-01-20 Thread Matan Azrad
Add support for set_vring_state operation. Using DevX API the virtq state can be changed as described in PRM: enable - move to ready state. disable - move to suspend state. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.c | 23 ++- drivers/v

[dpdk-dev] [PATCH v1 27/38] common/mlx5: get DevX capability for max RQT size

2020-01-20 Thread Matan Azrad
In order to allow RQT size configuration which is limited to the correct maximum value, add log_max_rqt_size for DevX capability structure. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 3 insertions(+) di

[dpdk-dev] [PATCH v1 30/38] vdpa/mlx5: map doorbell

2020-01-20 Thread Matan Azrad
The HW support only 4 bytes doorbell writing detection. The virtio device set only 2 bytes when it rings the doorbell. Map the virtio doorbell detected by the virtio queue kickfd to the HW VAR space when it expects to get the virtio emulation doorbell. Use the EAL interrupt mechanism to get notif

[dpdk-dev] [PATCH v1 28/38] vdpa/mlx5: add basic steering configurations

2020-01-20 Thread Matan Azrad
Add a steering object to be managed by a new file mlx5_vdpa_steer.c. Allow promiscuous flow to scatter the device Rx packets to the virtio queues using RSS action. In order to allow correct RSS in L3 and L4, split the flow to 7 flows as required by the device. Signed-off-by: Matan Azrad --- dr

[dpdk-dev] [PATCH v1 24/38] common/mlx5: allow type configuration for DevX RQT

2020-01-20 Thread Matan Azrad
Allow virtio queue type configuration in the RQ table. The needed fields and configuration was added. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/common/mlx5/mlx5_prm.h | 5 +++-- 3 files changed, 5 insertio

[dpdk-dev] [PATCH v1 22/38] vdpa/mlx5: prepare virtio queues

2020-01-20 Thread Matan Azrad
The HW virtq object represents an emulated context for a VIRTIO_NET virtqueue which was created and managed by a VIRTIO_NET driver as defined in VIRTIO Specification. Add support to prepare and release all the basic HW resources needed the user virtqs emulation according to the rte_vhost configura

[dpdk-dev] [PATCH v1 18/38] vdpa/mlx5: prepare memory regions

2020-01-20 Thread Matan Azrad
In order to map the guest physical addresses used by the virtio device guest side to the host physical addresses used by the HW as the host side, memory regions are created. By this way, for example, the HW can translate the addresses of the packets posted by the guest and to take the packets from

[dpdk-dev] [PATCH v1 23/38] vdpa/mlx5: support stateless offloads

2020-01-20 Thread Matan Azrad
Add support for the next features in virtq configuration: VIRTIO_F_RING_PACKED, VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_TSO6, VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, VIRTIO_F_VERSION_1, These features support depends in the DevX capabilities re

[dpdk-dev] [PATCH v1 20/38] vdpa/mlx5: prepare completion queues

2020-01-20 Thread Matan Azrad
As an arrangement to the vitrio queues creation, a CQ should be created for the virtio queue. The design is to trigger an event for the guest and for the vdpa driver when a new CQE is posted by the HW after the packet transition. This patch add the basic operations to create and destroy CQs and t

[dpdk-dev] [PATCH v1 15/38] common/mlx5: add DevX command to create CQ

2020-01-20 Thread Matan Azrad
HW implements completion queues(CQ) used to post completion reports upon completion of work request. Used for Rx and Tx datapath. Add DevX command to create a CQ. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c| 57 drivers/common/mlx5/mlx5_

[dpdk-dev] [PATCH v1 21/38] vdpa/mlx5: handle completions

2020-01-20 Thread Matan Azrad
In order to free resources in the CQ and to allow to the HW to send packets from the guest, the CQ should be polled. In order to poll the CQ we need to trigger an interrupt for each new CQE posted by the HW. Register interrupt handler to poll and arm a CQ when completion event was raised by the H

[dpdk-dev] [PATCH v1 16/38] common/mlx5: glue VAR allocation

2020-01-20 Thread Matan Azrad
Virtio access region(VAR) is the UAR that allocated for virtio emulation access. Add rdma-core operations to allocate and free VAR. Signed-off-by: Matan Azrad --- drivers/common/mlx5/Makefile| 5 + drivers/common/mlx5/meson.build | 1 + drivers/common/mlx5/mlx5_glue.c | 26 +++

[dpdk-dev] [PATCH v1 17/38] common/mlx5: add DevX virtio emulation commands

2020-01-20 Thread Matan Azrad
Virtio emulation offload allows SW to offload the I/O operations of a virtio virtqueue, using the device, allowing an improved performance for its users. While supplying all the relevant Virtqueue information (type, size, memory location, doorbell information, etc.). The device can then offload the

[dpdk-dev] [PATCH v1 14/38] common/mlx5: glue UAR allocation

2020-01-20 Thread Matan Azrad
The isolated, protected and independent direct access to the HW by multiple processes is implemented via User Access Region (UAR) mechanism. The UAR is part of PCI address space that is mapped for direct access to the HW from the CPU. UAR is comprised of multiple pages, each page containing registe

[dpdk-dev] [PATCH v1 12/38] common/mlx5: glue event queue query

2020-01-20 Thread Matan Azrad
The event queue is managed only by the kernel. Add the rdma-core command in glue to query the kernel event queue details. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_glue.c | 15 +++ drivers/common/mlx5/mlx5_glue.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a

[dpdk-dev] [PATCH v1 19/38] mlx5: share CQ entry check

2020-01-20 Thread Matan Azrad
The CQE has owner bit to indicate if it is in SW control or HW. Share a CQE check for all the mlx5 drivers. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h | 41 +++ drivers/net/mlx5/mlx5_rxtx.h | 39 +

[dpdk-dev] [PATCH v1 13/38] common/mlx5: glue event interrupt commands

2020-01-20 Thread Matan Azrad
Add the next commands to glue in order to support interrupt event channel operations associated to events in the EQ: devx_create_event_channel, devx_destroy_event_channel, devx_subscribe_devx_event, devx_subscribe_devx_event_fd, devx_get_event. Signed-off-by

[dpdk-dev] [PATCH v1 11/38] common/mlx5: support DevX indirect mkey creation

2020-01-20 Thread Matan Azrad
Add option to create an indirect mkey by the current mlx5_devx_cmd_mkey_create command. Align the net/mlx5 driver usage in the above command. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 43 ++-- drivers/common/mlx5/mlx5_devx_cmds.h | 12

[dpdk-dev] [PATCH v1 10/38] common/mlx5: glue null memory region allocation

2020-01-20 Thread Matan Azrad
Add support for rdma-core API to allocate NULL MR. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_glue.c | 13 + drivers/common/mlx5/mlx5_glue.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/common/mlx5/mlx5_glue.c b/drivers/common/mlx5/mlx5_glue.c index d5

[dpdk-dev] [PATCH v1 00/38] Introduce mlx5 vDPA driver

2020-01-20 Thread Matan Azrad
Steps: - Prepare net/mlx5 for code sharing. - Introduce new common lib for mlx5 devices. - Share code from net/mlx5 to common/mlx5. - Introduce vDPA driver for Mellanox devices. Matan Azrad (38): net/mlx5: separate DevX commands interface mlx5: prepare common library mlx5: share the mlx5 gl

[dpdk-dev] [PATCH v1 09/38] vdpa/mlx5: support features get operations

2020-01-20 Thread Matan Azrad
Add support for get_features and get_protocol_features operations. Part of the features are reported by the DevX capabilities. Signed-off-by: Matan Azrad --- doc/guides/vdpadevs/features/mlx5.ini | 7 drivers/vdpa/mlx5/mlx5_vdpa.c | 66 +-- 2 files

[dpdk-dev] [PATCH v1 07/38] common/mlx5: expose vDPA DevX capabilities

2020-01-20 Thread Matan Azrad
Add the DevX capabilities for vDPA configuration and information of Mellanox devices. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 90 drivers/common/mlx5/mlx5_devx_cmds.h | 24 ++ drivers/common/mlx5/mlx5_prm.h | 45 +++

[dpdk-dev] [PATCH v1 04/38] mlx5: share mlx5 PCI device detection

2020-01-20 Thread Matan Azrad
Move PCI detection by IB device from mlx5 PMD to the common code. Signed-off-by: Matan Azrad --- drivers/common/mlx5/Makefile| 2 +- drivers/common/mlx5/mlx5_common.c | 55 + drivers/common/mlx5/mlx5_common.h | 4 ++ drive

[dpdk-dev] [PATCH v1 06/38] drivers: introduce mlx5 vDPA driver

2020-01-20 Thread Matan Azrad
Add a new driver to support vDPA operations by Mellanox devices. The first Mellanox devices which support vDPA operations are ConnectX6DX and Bluefield1 HCA for their PF ports and VF ports. This driver is depending on rdma-core like the mlx5 PMD, also it is going to use mlx5 DevX to create HW obj

[dpdk-dev] [PATCH v1 01/38] net/mlx5: separate DevX commands interface

2020-01-20 Thread Matan Azrad
The DevX commands interfaces is included in the mlx5.h file with a lot of other PMD interfaces. As an arrangement to make the DevX commands shared with different PMDs, this patch moves the DevX interface to a new file called mlx5_devx_cmds.h. Also remove shared device structure dependency from De

[dpdk-dev] [PATCH v1 08/38] vdpa/mlx5: support queues number operation

2020-01-20 Thread Matan Azrad
Support get_queue_num operation to get the maximum number of queues supported by the device. This number comes from the DevX capabilities. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.c | 54 ++- 1 file changed, 53 insertions(+), 1 deletion(

[dpdk-dev] [PATCH v1 05/38] mlx5: share mlx5 devices information

2020-01-20 Thread Matan Azrad
Move the vendor information, vendor ID and device IDs from mlx5 PMD to the common mlx5 file. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h | 21 + drivers/net/mlx5/mlx5.h | 21 - drivers/net/mlx5/mlx5_txq.c | 1 + 3 file

[dpdk-dev] [PATCH v1 03/38] mlx5: share the mlx5 glue reference

2020-01-20 Thread Matan Azrad
A new Mellanox vdpa PMD will be added to support vdpa operations by Mellanox adapters. Both, the mlx5 PMD and the vdpa mlx5 PMD should initialize the glue. The glue initialization should be only one per process, so all the mlx5 PMDs using the glue should share the same glue object. Move the glue

Re: [dpdk-dev] [PATCH v5 11/17] net/ionic: add Rx filters support

2020-01-20 Thread Ferruh Yigit
On 1/19/2020 3:53 PM, Alfredo Cardigliano wrote: > Add support for managing RX filters based on MAC and VLAN. > Hardware cannot provide the list of filters, thus we keep > a local list. > Add support for promisc and allmulticast modes. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon

Re: [dpdk-dev] [RFC] DPDK Trace support

2020-01-20 Thread Stephen Hemminger
On Sat, 18 Jan 2020 10:14:31 -0500 wrote: > It would be well worth considering one of the vpp techniques to minimize > trace impact: > > static inline ring_handler_inline (..., int is_traced) > { > for (i = 0; i < vector_size; i++) > { > if (is_traced) > { > do_trace_w

Re: [dpdk-dev] [PATCH 0/2] Fix build with FreeBSD 13-CURRENT

2020-01-20 Thread Thomas Monjalon
03/01/2020 12:52, Bruce Richardson: > The FreeBSD CI system is reporting errors with DPDK on the current head > of the FreeBSD development branch for FreeBSD 13. Ahead of BSD 13's > release, we need to apply fixes to ensure DPDK continues to compile > on the various versions. > > Bruce Richardson

Re: [dpdk-dev] [PATCH v4 2/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Olivier Matz
Hi, On Mon, Jan 20, 2020 at 03:41:10PM +, Slava Ovsiienko wrote: > Hi, Olivier > > Thanks a lot for the thorough review. > There are some answers to comments, please, see below. > > > > > > > /** > > > + * @internal version of rte_pktmbuf_detach() to be used on mbuf freeing. > > > > -versi

Re: [dpdk-dev] [PATCH] doc: update testpmd guide for flow dump command

2020-01-20 Thread Ferruh Yigit
On 1/20/2020 4:01 AM, Xiaoyu Min wrote: > Explanation of flow dump command is added into testpmd functions. > > Signed-off-by: Xiaoyu Min Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v4 2/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Slava Ovsiienko
Hi, Olivier Thanks a lot for the thorough review. There are some answers to comments, please, see below. > > > > /** > > + * @internal version of rte_pktmbuf_detach() to be used on mbuf freeing. > > -version > +Version > > > + * For indirect and regular (not pinned) external mbufs the standard

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix dependency on file in /sys

2020-01-20 Thread Thomas Monjalon
20/01/2020 13:22, Bruce Richardson: > Meson versions 0.52 and 0.53 are being overly smart and detecting the path > "/sys/devices/system/cpu/present" in the call to cat in > app/test/meson.build and then adding it as a dependency to the build > configuration. This causes issues on systems where the

  1   2   >