Re: [dpdk-dev] [PATCH 10/11] net/mlx5: update description of validation funcs

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org > Subject: [PATCH 10/11] net/mlx5: update description of validation funcs > > Description of several functions is not

Re: [dpdk-dev] [PATCH 11/11] doc: update MLX5 supported hardware offloads table

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org > Subject: [PATCH 11/11] doc: update MLX5 supported hardware offloads table > > Function of_set_vlan_vid is wrongly l

Re: [dpdk-dev] [PATCH 07/11] net/mlx5: fix block pop VLAN action on Tx

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 07/11] net/mlx5: fix block pop VLAN action on Tx > > Add missing check in validati

Re: [dpdk-dev] [PATCH 08/11] net/mlx5: fix pop VLAN action validation function

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 08/11] net/mlx5: fix pop VLAN action validation function > > Validation function o

Re: [dpdk-dev] [PATCH 06/11] net/mlx5: fix block push VLAN action on Rx

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 06/11] net/mlx5: fix block push VLAN action on Rx > > Add missing check in validat

Re: [dpdk-dev] [PATCH 09/11] net/mlx5: fix the set VLAN VID action validation

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 09/11] net/mlx5: fix the set VLAN VID action validation > > Validation function of

Re: [dpdk-dev] [PATCH 05/11] net/mlx5: unify validation of drop action

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org > Subject: [PATCH 05/11] net/mlx5: unify validation of drop action > > According to PRM: "Drop action is mutually-exc

Re: [dpdk-dev] [PATCH 03/11] net/mlx5: fix bit mask used for push VLAN validate

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 03/11] net/mlx5: fix bit mask used for push VLAN validate > > Validation function

Re: [dpdk-dev] [PATCH 02/11] net/mlx5: fix invalid check for VLAN actions

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 02/11] net/mlx5: fix invalid check for VLAN actions > > Flow validation function i

Re: [dpdk-dev] [PATCH 01/11] net/mlx5: fix masks of encap and decap actions

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 01/11] net/mlx5: fix masks of encap and decap actions > > PUSH_VLAN and POP_VLAN a

Re: [dpdk-dev] [PATCH 04/11] net/mlx5: fix allow push VLAN without VID value

2020-01-22 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 04/11] net/mlx5: fix allow push VLAN without VID value > > Currently the push VLAN

[dpdk-dev] [PATCH 1/2] net/mlx5: support maximum id in id allocate

2020-01-22 Thread Suanming Mou
The id allocated is for the register unique id match. Some registers may not use the full 32 bits. Add the maximum id to avoid allocate id over the register restriction. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 12 drivers/net/ml

[dpdk-dev] [PATCH 2/2] net/mlx5: fix incorrect register usage in meter

2020-01-22 Thread Suanming Mou
Flow with meter will split to three subflows, the prefix subflow with meter action do the color, the meter subflow filter the packets, the suffix subflow do all the left actions for packets pass the filter. Both the color and the subflow match between prefix and suffix use the register to store th

[dpdk-dev] [PATCH 0/2] fix incorrect register usage in meter

2020-01-22 Thread Suanming Mou
Flow with meter will split to three subflows, the prefix subflow with meter action do the color, the meter subflow filter the packets, the suffix subflow do all the left actions for packets pass the filter. Both the color and the subflow match between prefix and suffix use the register to store th

Re: [dpdk-dev] [EXT] Re: [PATCH] net/octeontx2: extend RSS supported offload types

2020-01-22 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, January 22, 2020 1:35 PM > To: Kiran Kumar Kokkilagadda > Cc: Jerin Jacob Kollanukkaran ; Nithin Kumar Dabilpuram > ; Vamsi Krishna Attunuru > ; dpdk-dev > Subject: [EXT] Re: [dpdk-dev] [PATCH] net/octeontx2: extend RSS suppor

Re: [dpdk-dev] [PATCH v4 11/11] doc: update l3fwd user guide to support eventdev

2020-01-22 Thread Jerin Jacob
On Thu, Jan 23, 2020 at 12:00 AM wrote: > > From: Pavan Nikhilesh > > Update l3fwd user guide to include event device related information. > > Signed-off-by: Pavan Nikhilesh > --- > doc/guides/sample_app_ug/l3_forward.rst | 79 +++-- > 1 file changed, 73 insertions(+), 6 del

[dpdk-dev] [PATCH v3 0/5] armv8 crypto PMD update

2020-01-22 Thread Ruifeng Wang
Maintainance of armv8_crypto library created by Marvell/Cavium will be discontinued. Going forward, Armv8 crypto PMD will link to AArch64 crypto library hosted by Arm. Patch 1/5, 3/5 update source code and document respectively to reflect the change. Patch 2/5 adds meson build support for this PMD

[dpdk-dev] [PATCH v3 5/5] crypto/armv8: fix clang build

2020-01-22 Thread Ruifeng Wang
1. Clang requires braces around initialization of subobject. 2. Clang complains implicit conversion of enumeration type. Trapped issue with Clang version 8.0 and CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO was set. Error messages: rte_armv8_pmd.c:144:2: error: suggest braces around initialization of subob

[dpdk-dev] [PATCH v3 3/5] doc: update link to the crypto library for armv8 PMD

2020-01-22 Thread Ruifeng Wang
Armv8 crypto PMD now uses crypto library hosted by Arm. Update doc with the crypto library link to reflect the change. Signed-off-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Jerin Jacob --- doc/guides/cryptodevs/armv8.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletio

[dpdk-dev] [PATCH v3 1/5] crypto/armv8: link PMD to crypto library hosted by Arm

2020-01-22 Thread Ruifeng Wang
Armv8 crypto PMD linked to armv8_crypto library created by Marvell. Maintenance of armv8_crypto library will be discontinued. Change Armv8 PMD to link to AArch64 crypto library hosted by Arm. Signed-off-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Li

[dpdk-dev] [PATCH v3 2/5] crypto/armv8: enable meson build

2020-01-22 Thread Ruifeng Wang
From: Dharmik Thakkar Add new meson.build file for crypto/armv8 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Tested-by: Ruifeng Wang --- drivers/crypto/armv8/meson.build | 25 + drivers/crypto/meson.build | 1 +

[dpdk-dev] [PATCH v3 4/5] doc: update release notes for armv8 crypto PMD

2020-01-22 Thread Ruifeng Wang
Armv8 crypto PMD is changed to depend on external crypto library hosted by Arm. Library name also has change. Signed-off-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- doc/guides/rel_notes/release_20_02.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/re

Re: [dpdk-dev] [DPDK] net/ice: add outer IPv4 matching for GTPU flow

2020-01-22 Thread Zhang, Qi Z
> -Original Message- > From: Sun, Chenmin > Sent: Tuesday, January 21, 2020 7:57 PM > To: Cao, Yahui ; Zhang, Qi Z ; > Xing, Beilei > Cc: dev@dpdk.org; Sun, Chenmin > Subject: [DPDK] net/ice: add outer IPv4 matching for GTPU flow > > From: Chenmin Sun > > This patch adds the capabi

Re: [dpdk-dev] [PATCH 0/2] net/bnxt: statistic related fixes

2020-01-22 Thread Ajit Khaparde
On Wed, Jan 22, 2020 at 9:56 AM Stephen Hemminger < step...@networkplumber.org> wrote: > A couple of minor things in bnxt statistics > > Stephen Hemminger (2): > net/bnxt: do not print error if stats queried before start > net/bnxt: remove unnecessary memset > > drivers/net/bnxt/bnxt_stats.c

Re: [dpdk-dev] [PATCH v2] net/bnxt: fix VLAN strip flags in sse mode

2020-01-22 Thread Ajit Khaparde
On Wed, Jan 22, 2020 at 3:18 PM Ajit Khaparde wrote: > From: Stephen Hemminger > > When the VLAN is stripped from the packet on receive the > driver must set the PKT_RX_VLAN_STRIPPED flag in the mbuf. > This is done correctly for normal receive in the bnxt driver > but was not being handled corr

[dpdk-dev] [PATCH v2] net/bnxt: fix VLAN strip flags in sse mode

2020-01-22 Thread Ajit Khaparde
From: Stephen Hemminger When the VLAN is stripped from the packet on receive the driver must set the PKT_RX_VLAN_STRIPPED flag in the mbuf. This is done correctly for normal receive in the bnxt driver but was not being handled correctly in the new SSE code. Fixes: bc4a000f2f53 ("net/bnxt: implem

Re: [dpdk-dev] [PATCH] maintainers: set git tree for EAL and core libraries

2020-01-22 Thread Thomas Monjalon
20/01/2020 21:35, David Marchand: > Without a git tree, the "guess" script from dpdk-ci will ignore all files > that are referenced in those sections and let a patchset land in any > subtree. > Changes in the EAL, mbuf, mempool... go through the main repository. > > Signed-off-by: David Marchand

[dpdk-dev] [PATCH] maintainers: set QoS git tree for some ethdev files

2020-01-22 Thread Thomas Monjalon
The tree dpdk-next-tm does not exist anymore. Traffic management and metering APIs, which are part of ethdev, can be merged in the existing tree dpdk-next-qos. Signed-off-by: Thomas Monjalon --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINT

Re: [dpdk-dev] [PATCH v2] maintainers: set git tree for packet framework and QoS

2020-01-22 Thread Thomas Monjalon
14/01/2020 14:09, David Marchand: > Mark librte_meter and librte_sched as being handled in the dpdk-next-qos > subtree. > The packet framework bits go through dpdk-next-pipeline. > > Signed-off-by: David Marchand Applied, thanks

Re: [dpdk-dev] [PATCH] maintainers: set git tree for test applications

2020-01-22 Thread Thomas Monjalon
14/01/2020 14:57, Andrew Rybchenko: > On 1/14/20 1:25 PM, Ferruh Yigit wrote: > > On 1/14/2020 10:12 AM, Thomas Monjalon wrote: > >> 14/01/2020 10:20, Jerin Jacob: > >>> On Tue, Jan 14, 2020 at 2:48 PM David Marchand > >>> wrote: > > Changes on the main test applications should be consid

Re: [dpdk-dev] [PATCH] vfio: fix VFIO mapping failures in ppc64le

2020-01-22 Thread David Christensen
ppc64le failed when using large physical memory. I found problems in my two commits in the past. In commit e072d16f8920 ("vfio: fix expanding DMA area in ppc64le"), I added a sanity check using a mapped address to resolve an issue around expanding IOMMU window, but this was not enough, since memo

[dpdk-dev] [PATCH v4 11/11] doc: update l3fwd user guide to support eventdev

2020-01-22 Thread pbhagavatula
From: Pavan Nikhilesh Update l3fwd user guide to include event device related information. Signed-off-by: Pavan Nikhilesh --- doc/guides/sample_app_ug/l3_forward.rst | 79 +++-- 1 file changed, 73 insertions(+), 6 deletions(-) diff --git a/doc/guides/sample_app_ug/l3_forwa

[dpdk-dev] [PATCH v4 08/11] examples/l3fwd: add event lpm main loop

2020-01-22 Thread pbhagavatula
From: Pavan Nikhilesh Add lpm main loop for handling events based on capabilities of the event device. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd.h | 9 ++ examples/l3fwd/l3fwd_event.c | 9 ++ examples/l3fwd/l3fwd_event.h | 5 + examples/l3fwd/l3fwd_lpm.c | 203 +

[dpdk-dev] [PATCH v4 10/11] examples/l3fwd: add graceful teardown for eventdevice

2020-01-22 Thread pbhagavatula
From: Pavan Nikhilesh Add graceful teardown that addresses both event mode and poll mode. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/main.c | 50 +-- 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/examples/l3fwd/main.c b/examples/

[dpdk-dev] [PATCH v4 09/11] examples/l3fwd: add event em main loop

2020-01-22 Thread pbhagavatula
From: Pavan Nikhilesh Add em main loop for handling events based on capabilities of the event device. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd.h | 10 ++ examples/l3fwd/l3fwd_em.c| 177 +++ examples/l3fwd/l3fwd_em.h|

[dpdk-dev] [PATCH v4 05/11] examples/l3fwd: add event port and queue setup

2020-01-22 Thread pbhagavatula
From: Sunil Kumar Kori Add event device queue and port setup based on event eth Tx adapter capabilities. Signed-off-by: Sunil Kumar Kori --- examples/l3fwd/l3fwd_event.c | 28 +- examples/l3fwd/l3fwd_event.h | 1 + examples/l3fwd/l3fwd_event_generic.c |

[dpdk-dev] [PATCH v4 07/11] examples/l3fwd: add service core setup based on caps

2020-01-22 Thread pbhagavatula
From: Pavan Nikhilesh Add service core setup when eventdev and Rx/Tx adapter don't have internal port capability. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd_event.c | 6 ++ examples/l3fwd/main.c| 188 +++ 2 files changed, 150 insertions(+)

[dpdk-dev] [PATCH v4 06/11] examples/l3fwd: add event eth Rx/Tx adapter setup

2020-01-22 Thread pbhagavatula
From: Pavan Nikhilesh Add event eth Rx/Tx adapter setup for both generic and internal port event device pipelines. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd_event.c | 3 + examples/l3fwd/l3fwd_event.h | 1 + example

[dpdk-dev] [PATCH v4 01/11] examples/l3fwd: add framework for event device

2020-01-22 Thread pbhagavatula
From: Sunil Kumar Kori Add framework to enable event device as a producer of packets. To switch between event mode and poll mode the following options have been added: `--mode="eventdev"` or `--mode="poll"` Allow the user to select the schedule type to be either RTE_SCHED_TYPE_ORDERED, RT

[dpdk-dev] [PATCH v4 04/11] examples/l3fwd: add ethdev setup based on eventdev

2020-01-22 Thread pbhagavatula
From: Sunil Kumar Kori Add ethernet port Rx/Tx queue setup for event device which are later used for setting up event eth Rx/Tx adapters. Signed-off-by: Sunil Kumar Kori Signed-off-by: Nipun Gupta --- examples/l3fwd/l3fwd.h | 10 +++ examples/l3fwd/l3fwd_event.c | 138 +

[dpdk-dev] [PATCH v4 02/11] examples/l3fwd: split pipelines based on capability

2020-01-22 Thread pbhagavatula
From: Sunil Kumar Kori Add infra to split eventdev framework based on event Tx adapter capability. If event Tx adapter has internal port capability then we use `rte_event_eth_tx_adapter_enqueue` to transmitting packets else we use a SINGLE_LINK event queue to enqueue packets to a service core whi

[dpdk-dev] [PATCH v4 03/11] examples/l3fwd: add event device configuration

2020-01-22 Thread pbhagavatula
From: Pavan Nikhilesh Add event device configuration based on the capabilities of the probed event device. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd_event.c | 3 + examples/l3fwd/l3fwd_event.h | 36 ++ examples/l3fwd/l3fwd_event_generic.c

[dpdk-dev] [PATCH v4 00/11] example/l3fwd: introduce event device support

2020-01-22 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds support for event mode in l3fwd. The poll mode is still the default mode of operation. The following new command line parameters are added: --mode: Dictates the mode of operation either poll or event. If unset then by default poll mode is used.

[dpdk-dev] [PATCH 0/2] net/bnxt: statistic related fixes

2020-01-22 Thread Stephen Hemminger
A couple of minor things in bnxt statistics Stephen Hemminger (2): net/bnxt: do not print error if stats queried before start net/bnxt: remove unnecessary memset drivers/net/bnxt/bnxt_stats.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.20.1

[dpdk-dev] [PATCH 1/2] net/bnxt: do not print error if stats queried before start

2020-01-22 Thread Stephen Hemminger
When using pktgen lots of unnecessary errors are printed because pktgen queries statistics before device is started. Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type") Cc: ajit.khapa...@broadcom.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_stats.c | 4 +-

[dpdk-dev] [PATCH 2/2] net/bnxt: remove unnecessary memset

2020-01-22 Thread Stephen Hemminger
The rte_ethdev layer already zeros statistics before calling the device. Fixes: 57d5e5bc86e4 ("net/bnxt: add statistics") Cc: ajit.khapa...@broadcom.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_stats.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[dpdk-dev] [PATCH v3] mbuf: display more fields in dump

2020-01-22 Thread Stephen Hemminger
The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko --- v3 - only display vlan tci if offload flags say it is there display packet type v2 - remove casts, change in_por

Re: [dpdk-dev] pci device access from dpdk secondary process with igb_uio

2020-01-22 Thread Trahe, Fiona
Hi Vijay, Sorry for the delay, we missed this as It arrived while on Christmas holidays. We'll investigate, though it may take some time as this looks like a pci lib issue and up to recently we have only been using QAT in primary processes so don't have expertise yet in this area. If you could

[dpdk-dev] [PATCH v2] mem: fix incorrect munmap in error unwind

2020-01-22 Thread Stephen Hemminger
The loop to unwind existing mmaps was only unmapping the first segment and the error paths after mmap() were not doing munmap of the current segment. Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Ac

Re: [dpdk-dev] [PATCH v5] eal: add manual probing option

2020-01-22 Thread Pavan Nikhilesh Bhagavatula
Ping @gr...@u256.net Since, you weren't reachable on regular email I rebased the patch on ToT and sent a v6 http://patches.dpdk.org/patch/64235/ >-Original Message- >From: dev On Behalf Of Gaetan Rivet >Sent: Friday, October 25, 2019 9:17 PM >To: dev@dpdk.org >Cc: Gaetan Rivet ; Vamsi K

Re: [dpdk-dev] 17.11.10 (LTS) patches review and test

2020-01-22 Thread Luca Boccassi
On Wed, 2020-01-22 at 16:06 +, Ali Alnubani wrote: > Hi, > > > -Original Message- > > From: Luca Boccassi < > > bl...@debian.org > > > > > Sent: Monday, January 13, 2020 2:47 PM > > To: dpdk stable < > > sta...@dpdk.org > > > > > Cc: > > dev@dpdk.org > > ; Akhil Goyal < > > akhil.go..

[dpdk-dev] SPDX license nag

2020-01-22 Thread Stephen Hemminger
Files without SPDX License -- app/test-pmd/flowgen.c app/test-pmd/macswap.c app/test/test_compressdev_test_buffer.h app/test/test_timer_racecond.c devtools/cocci.sh devtools/load-devel-config examples/ipsec-secgw/test/trs_aesgcm_inline_crypto_fallback_defs.sh examples/ipsec-

Re: [dpdk-dev] [dpdk-users] Issue :- segmentation fault in rte_eal_wait_lcore.

2020-01-22 Thread Stephen Hemminger
On Wed, 22 Jan 2020 10:52:28 + "Burakov, Anatoly" wrote: > On 20-Jan-20 7:34 AM, Lalithaditya Naidu Gajula wrote: > > Hi All, > > I got a segmentation fault issue regarding ret_eal_wait_lcore and > > rte_eal_mp_wait_lcore(), > > when i am running the code in a few logical cores usin

Re: [dpdk-dev] [dpdk-stable] 17.11.10 (LTS) patches review and test

2020-01-22 Thread Luca Boccassi
On Wed, 2020-01-22 at 15:17 +0100, Kevin Traynor wrote: > On 22/01/2020 12:37, Luca Boccassi wrote: > > On Wed, 2020-01-22 at 05:27 +, Yu, PingX wrote: > > > Luca, > > > Update the regression test result of Intel part. See the details > > > as > > > below. > > > > > > * Intel(R) Testing > > >

Re: [dpdk-dev] 17.11.10 (LTS) patches review and test

2020-01-22 Thread Ali Alnubani
Hi, > -Original Message- > From: Luca Boccassi > Sent: Monday, January 13, 2020 2:47 PM > To: dpdk stable > Cc: dev@dpdk.org; Akhil Goyal ; Ali Alnubani > ; benjamin.wal...@intel.com; David Christensen > ; Hemant Agrawal ; > Ian Stokes ; Jerin Jacob ; John > McNamara ; Kevin Traynor > ;

Re: [dpdk-dev] [PATCH v2] net/i40e: fix i40e flow director merge

2020-01-22 Thread Sexton, Rory
Acked-by: Rory Sexton

[dpdk-dev] [PATCH v2] net/i40e: fix i40e flow director merge

2020-01-22 Thread Bernard Iremonger
Merge of ESP and L2TP code in i40e_fdir.c added checks on cus_pctype->index which caused flow creation for ESP to fail. Added fill_ipv4_function() Refactored code to have one path for customized and non customized pctype's. Fixes: c5f8365bc85d ("net/i40e: support flow director for L2TPv3 over IP"

[dpdk-dev] [PATCH] net/mlx5: fix zero out UDP checksum in encap data

2020-01-22 Thread Matan Azrad
From: Eli Britstein The cited commit zeroed the UDP checksum for raw-encap case. Add the same handling for vxlan-encap case. Fixes: bf1d7d9a033a ("net/mlx5: zero out UDP checksum in encapsulation") Cc: sta...@dpdk.org Signed-off-by: Eli Britstein Acked-by: Matan Azrad --- drivers/net/mlx5/ml

Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT

2020-01-22 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, January 22, 2020 2:42 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT > > Remove one AES GCM scatter-gather u

[dpdk-dev] [PATCH v2 0/1] test/crypto: remove repeated test and enable on QAT

2020-01-22 Thread Adam Dybkowski
Remove one AES GCM scatter-gather unit test repetition and enable this test on QAT (after a fix included in the commit b26ef1a11f21). --- v2: * Repair referenced commit id. Adam Dybkowski (1): test/crypto: remove repeated test and enable on QAT app/test/test_cryptodev.c | 7 --- 1 file ch

[dpdk-dev] [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT

2020-01-22 Thread Adam Dybkowski
Remove one AES GCM scatter-gather unit test repetition and enable this test on QAT (after a fix included in the commit b26ef1a11f21). Fixes: 157d0b11d204 ("test/crypto: add capability checks") Fixes: b26ef1a11f21 ("test/crypto: fix missing operation status check") Signed-off-by: Adam Dybkowski -

[dpdk-dev] [PATCH] net/mlx5: fix icmpv6 header rewrite actions

2020-01-22 Thread Shiri Kuzin
the ConnectX-5 HW cannot calculate the checksum for ICMPv6, therefore flows with pattern 'ipv6 proto is 58' with actions that change the header should be rejected. the actions that change the header in this type of flow are 'set_ipv6_src' and 'set_ipv6_dst'. Fixes: 4bb14c83df95 ("net/mlx5: support

[dpdk-dev] [PATCH] net/mlx5: fix clang 3.4.2 compilation

2020-01-22 Thread Matan Azrad
Compilation massage example: "dpdk/drivers/net/mlx5/mlx5_flow_dv.c:1087:10: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare] if (reg < 0) ~~~ ^ ~ " enum modify_reg holds only non-negative integers and in some places in the code

[dpdk-dev] [PATCH 10/11] net/mlx5: update description of validation funcs

2020-01-22 Thread Dekel Peled
Description of several functions is not accurate. This patch updates the description, parameter names etc. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH 11/11] doc: update MLX5 supported hardware offloads table

2020-01-22 Thread Dekel Peled
Function of_set_vlan_vid is wrongly listed twice in table "Supported hardware offloads". This patch removes the listing of of_set_vlan_vid under "Header rewrite", and leaves the listing of of_set_vlan_vid under "VLAN". Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst |

Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable

2020-01-22 Thread Wang, Xiao W
Hi Kalra, This patch is more about bug fix on user interrupt, no powering saving tuning. The target scenario is, a worker core is dealing with 2 Rx queues, and it go sleep due to no traffic for some time, and then the first queue has new traffic arrived, and wakes up this core, so this worker co

[dpdk-dev] [PATCH 07/11] net/mlx5: fix block pop VLAN action on Tx

2020-01-22 Thread Dekel Peled
Add missing check in validation function of 'pop VLAN' action. Action is not allowed for egress flow rules. Fixes: b41e47da2592 ("net/mlx5: support pop flow action on VLAN header") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 6 ++

[dpdk-dev] [PATCH 06/11] net/mlx5: fix block push VLAN action on Rx

2020-01-22 Thread Dekel Peled
Add missing check in validation function of 'push VLAN' action. Action is not allowed for ingress flow rules. Fixes: 9aee7a8418d4 ("net/mlx5: support push flow action on VLAN header") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 6 +

[dpdk-dev] [PATCH 08/11] net/mlx5: fix pop VLAN action validation function

2020-01-22 Thread Dekel Peled
Validation function of 'POP VLAN' action includes check for other 'POP VLAN' actions present in flow. It doesn't check for 'PUSH VLAN' actions present in flow. This patch adds check for 'PUSH VLAN' actions present in flow. Fixes: b41e47da2592 ("net/mlx5: support pop flow action on VLAN header") C

[dpdk-dev] [PATCH 04/11] net/mlx5: fix allow push VLAN without VID value

2020-01-22 Thread Dekel Peled
Currently the push VLAN action requires a VID value, either from existing VLAN item, or from following 'set VLAN vid' action. This patch removes this limitation, allowing a push VLAN action with vid value 0. Fixes: b8c0372bc5ac ("net/mlx5: fix set VLAN ID/PCP in new header") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH 09/11] net/mlx5: fix the set VLAN VID action validation

2020-01-22 Thread Dekel Peled
Validation function of 'set VLAN VID' action checks twice for existing same action in flow rule. This patch updates the validation function logic, to check the same restrictions more efficiently. Fixes: 5f163d520cff ("net/mlx5: support modify VLAN ID on existing VLAN header") Fixes: b8c0372bc5ac

[dpdk-dev] [PATCH 02/11] net/mlx5: fix invalid check for VLAN actions

2020-01-22 Thread Dekel Peled
Flow validation function includes, after all items and actions are validated discretely, a check for VLAN and VXLAN actions. This check is incorrect and redundant. This patch removes the invalid check from validation function. Check is incorrect, action_flags bit map is checked against items mask

[dpdk-dev] [PATCH 00/11] net/mlx5: vlan actions validation fixes

2020-01-22 Thread Dekel Peled
This series includes several patches, fixing different faults in validation functions of VLAN actions. Series-acked-by: Ori Kam Dekel Peled (11): net/mlx5: fix masks of encap and decap actions net/mlx5: fix invalid check for VLAN actions net/mlx5: fix bit mask used for push VLAN validate

[dpdk-dev] [PATCH 05/11] net/mlx5: unify validation of drop action

2020-01-22 Thread Dekel Peled
According to PRM: "Drop action is mutually-exclusive with any other action, except for Count action". In current code this limitaion is checked separately in validation function of each action. This patch removes the discrete checks, and adds a single check common for all actions. Signed-off-by:

[dpdk-dev] [PATCH 03/11] net/mlx5: fix bit mask used for push VLAN validate

2020-01-22 Thread Dekel Peled
Validation function of 'push VLAN' action uses (POP_VLAN or PUSH_VLAN) actions flags, instead of using a mask of both flags. This patch replaces it to use existing VLAN_ACTIONS mask. Fixes: 9aee7a8418d4 ("net/mlx5: support push flow action on VLAN header") Cc: sta...@dpdk.org Signed-off-by: Deke

[dpdk-dev] [PATCH 01/11] net/mlx5: fix masks of encap and decap actions

2020-01-22 Thread Dekel Peled
PUSH_VLAN and POP_VLAN actions flags were added to ENCAP_ACTIONS and DECAP_ACTIONS bit masks, respectively. This is incorrect, because VLAN actions are considered as 'modify header' actions, not as 'packet reformat' actions. This patch removes the PUSH_VLAN and POP_VLAN actions flags from ENCAP_AC

Re: [dpdk-dev] [dpdk-stable] 17.11.10 (LTS) patches review and test

2020-01-22 Thread Kevin Traynor
On 22/01/2020 12:37, Luca Boccassi wrote: > On Wed, 2020-01-22 at 05:27 +, Yu, PingX wrote: >> Luca, >> Update the regression test result of Intel part. See the details as >> below. >> >> * Intel(R) Testing >> # Basic Intel(R) NIC testing >> * PF(i40e): one compile issue is found and we fix it

Re: [dpdk-dev] [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-22 Thread Jerin Jacob
On Wed, Jan 22, 2020 at 6:26 PM Akhil Goyal wrote: > > > > > > > > > Hi Jerin, > > > > > > > > Will do the suggested change (RX/rx-> Rx & TX/tx->Tx). Do you want me > > > > to trim the headline as well? > > > > > > > > > > Hi Anoob, > > > > > > > @Akhil, did you get a chance to review the series?

Re: [dpdk-dev] [dpdk-stable] [PATCH] meter: move RFC4115 trTCM APIs as none experimental

2020-01-22 Thread Ray Kinsella
On 16/01/2020 12:42, Ferruh Yigit wrote: > On 1/16/2020 11:54 AM, Neil Horman wrote: >> On Thu, Jan 16, 2020 at 12:25:06PM +0100, David Marchand wrote: >>> On Tue, Dec 17, 2019 at 2:08 PM Eelco Chaudron wrote: Moved RFC4115 APIs to none experimental as they have been there since

Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable

2020-01-22 Thread Harman Kalra
On Mon, Jan 20, 2020 at 10:06:57PM -0500, Xiao Wang wrote: > Since all related queues' interrupts are turned on before epoll, we need > to turn off all the interrupts after wakeup. This patch fixes the issue > of only turning off the interrupted queues. > > Fixes: b736d64787fc ("examples/l3fwd-pow

Re: [dpdk-dev] [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-22 Thread Akhil Goyal
> > > > > > Hi Jerin, > > > > > > Will do the suggested change (RX/rx-> Rx & TX/tx->Tx). Do you want me > > > to trim the headline as well? > > > > > > > Hi Anoob, > > > > > @Akhil, did you get a chance to review the series? Do you have any > > > comments on the patches? > > > > > > > You are addi

Re: [dpdk-dev] [PATCH v3 2/6] crypto/aesni_gcm: cpu crypto support

2020-01-22 Thread Ananyev, Konstantin
> > > > > > Add support for CPU crypto mode by introducing required handler. > > > > > > Crypto mode (sync/async) is chosen during sym session create if > > > > > > an appropriate flag is set in an xform type number. > > > > > > > > > > > > Authenticated encryption and decryption are supported wi

[dpdk-dev] [PATCH] net/mlx5: fix setting of port ID for egress rules

2020-01-22 Thread Dekel Peled
Previous patch fixed the setting of port-id for eswitch rules, which are ingress only. This patch expands the fix, to support nic rules as well, which can be ingress or egress. Fixes: ce777b147bf8 ("net/mlx5: fix E-Switch flow without port item") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Ac

Re: [dpdk-dev] [PATCH v5] doc: introduce openwrt how-to guide

2020-01-22 Thread Mcnamara, John
> -Original Message- > From: Ye, Xiaolong > Sent: Saturday, January 18, 2020 5:49 AM > To: Mcnamara, John ; Kovacevic, Marko > > Cc: dev@dpdk.org; Richardson, Bruce ; Stephen > Hemminger ; Ye, Xiaolong > > Subject: [PATCH v5] doc: introduce openwrt how-to guide > > This doc describes ho

Re: [dpdk-dev] 17.11.10 (LTS) patches review and test

2020-01-22 Thread Luca Boccassi
On Wed, 2020-01-22 at 05:27 +, Yu, PingX wrote: > Luca, > Update the regression test result of Intel part. See the details as > below. > > * Intel(R) Testing > # Basic Intel(R) NIC testing > * PF(i40e): one compile issue is found and we fix it with attached > patch to go ahead the test. All pa

Re: [dpdk-dev] [PATCH v2 1/2] crypto/ccp: sha3 support enabling in ccp

2020-01-22 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] For series, Acked-by: Ravi Kumar Regards, Ravi >-Original Message- >From: Sardar, Shamsher singh >Sent: Wednesday, January 22, 2020 4:22 PM >To: dev@dpdk.org >Cc: Kumar, Ravi1 >Subject: [PATCH v2 1/2] crypto/ccp: sha3 support enabl

Re: [dpdk-dev] [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-22 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Wednesday, January 22, 2020 3:46 PM > To: Anoob Joseph ; Jerin Jacob > > Cc: Declan Doherty ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Narayana Prasad Raju Athreya ; Kiran Kumar > Kokki

[dpdk-dev] [PATCH v2 2/2] examples/crypto: crypto test application

2020-01-22 Thread ssardar
From: Sardar Shamsher Singh test application to test Cipher/Authentication/AEAD in AMD CCP a crypto controller. This test application can be used as reference to develop/test crypto algo. Signed-off-by: Sardar Shamsher Singh --- doc/guides/sample_app_ug/ccp_crypto.rst | 114 +++ examples/crypt

[dpdk-dev] [PATCH v2 1/2] crypto/ccp: sha3 support enabling in ccp

2020-01-22 Thread ssardar
From: Sardar Shamsher Singh sha3 support enabled in AMD-CCP crypto controller Signed-off-by: Sardar Shamsher Singh --- lib/librte_cryptodev/rte_cryptodev.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptod

Re: [dpdk-dev] Issue :- segmentation fault in rte_eal_wait_lcore.

2020-01-22 Thread Burakov, Anatoly
On 20-Jan-20 7:34 AM, Lalithaditya Naidu Gajula wrote: Hi All, I got a segmentation fault issue regarding ret_eal_wait_lcore and rte_eal_mp_wait_lcore(), when i am running the code in a few logical cores using rte_eal_remote _launch() function which has a while (1) (infinite loop) in a

Re: [dpdk-dev] [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-22 Thread Akhil Goyal
> > Hi Jerin, > > Will do the suggested change (RX/rx-> Rx & TX/tx->Tx). Do you want me to trim > the headline as well? > Hi Anoob, > @Akhil, did you get a chance to review the series? Do you have any comments > on the patches? > You are adding inline ipsec support to ethernet device and n

[dpdk-dev] [RFC PATCH 0/3] librte_ethdev: error recovery support

2020-01-22 Thread Kalesh A P
From: Kalesh AP This patch adds support for recovery event in rte_eth_event framework. FW error and FW reset conditions would be managed by PMD. Driver uses RTE_ETH_EVENT_INTR_RESET event to notify the applications about the FW reset or error. In such cases, PMD would need recovery events to noti

[dpdk-dev] [RFC PATCH 1/3] librte_ethdev: support device recovery event

2020-01-22 Thread Kalesh A P
From: Kalesh AP Adding support for recovery event in rte_eth_event framework. FW error and FW reset conditions would be managed by PMD. In such cases, PMD would need recovery events to notify application about PMD has recovered from FW reset or FW error. Signed-off-by: Kalesh AP Signed-off-by:

[dpdk-dev] [RFC PATCH 2/3] net/bnxt: notify applications about device reset

2020-01-22 Thread Kalesh A P
From: Kalesh AP When the driver receives RESET_NOTIFY async event from FW or detected an error condition, it should update the application that FW is going to reset. Once the driver recoveres from the reset, update the reset recovery status to application as well. The recovery process is transpa

[dpdk-dev] [RFC PATCH 3/3] app/testpmd: handle device recovery event

2020-01-22 Thread Kalesh A P
From: Kalesh AP Added code to handle device recovery event in testpmd. This is an indication from PMD that it has recovered from a FW reset or FW error condition. Signed-off-by: Kalesh AP Reviewed-by: Ajit Kumar Khaparde --- app/test-pmd/testpmd.c | 7 ++- 1 file changed, 6 insertions(+),

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list

2020-01-22 Thread Anoob Joseph
Hi Ferruh, Please see inline. Thanks, Anoob > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 21, 2020 9:42 PM > To: Anoob Joseph ; John McNamara > ; Marko Kovacevic > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; dev@dpdk.org > Subject: [EXT] Re:

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events

2020-01-22 Thread Ye Xiaolong
On 01/15, taox@intel.com wrote: >From: Zhu Tao > >IXGBE link status task use rte alarm thread in old implementation. >Sometime ixgbe link status task takes up to 9 seconds. This will >severely affect the rte-alarm-thread-dependent a task in the What does "rte-alarm-thread-dependent a task" me

Re: [dpdk-dev] [PATCH] net/ice: fix flow fdir/switch memory leak.

2020-01-22 Thread Ye Xiaolong
On 01/16, taox@intel.com wrote: >From: Tao Zhu > >1. Fix ice fdir and hash flow memory leak. >2. Fix the ice definition of LIST_FOR_EACH_ENTRY_SAFE not > save tmp which cause list deletion incompletely. > >Fixes: 5f0978e9622 ("net/ice/base: add OS specific implementation") >Fixes: f5cafa961

Re: [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02

2020-01-22 Thread Thomas Monjalon
22/01/2020 07:34, Stephen Hemminger: > On a related topic. All the documented examples should be changed to use vfio. > Everyone just cut and paste from the documentation and expects igb_uio. Yes, good catch Stephen. Who is volunteer?

[dpdk-dev] [PATCH] mbuf: fix pinned memory free routine style issue

2020-01-22 Thread Viacheslav Ovsiienko
Minor style issue is fixed. Fixes: 6c8e50c2e549 ("mbuf: create pool with external memory buffers") Signed-off-by: Viacheslav Ovsiienko --- lib/librte_mbuf/rte_mbuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c ind

  1   2   >