Earlier after a successful mac_addr_add operation, index was returned
by underlying layer which was unused but same as provided by DPDK API.
So API is enhanced to use application provided index location to add
MAC address entry.
Fixes: e4373bf1b3f5 ("net/octeontx: add unicast MAC filter")
Signed
From: Pavan Nikhilesh
use RTE_DIM macro to calculate array size.
Suggested-by: David Marchand
Signed-off-by: Pavan Nikhilesh
---
examples/ip_pipeline/parser.c | 2 +-
examples/ipv4_multicast/main.c | 6 +-
examples/l3fwd-power/main.c| 18 --
examples/l3fwd/l3fwd_em.
From: Pavan Nikhilesh
Use RTE_DIM macro to calculate array size
Suggested-by: David Marchand
Signed-off-by: Pavan Nikhilesh
---
v3 Changes:
--
- remove variables that are used only once.(David)
- rebase on ToT.
- flush out rest of instances not using RTE_DIM.
v2 Changes:
--
From: Pavan Nikhilesh
use RTE_DIM to calculate array size.
Suggested-by: David Marchand
Signed-off-by: Pavan Nikhilesh
Acked-by: Cristian Dumitrescu
---
lib/librte_ethdev/rte_ethdev.c | 8 +++-
lib/librte_ip_frag/ip_frag_internal.c| 5 ++---
lib/librte_port/
From: Pavan Nikhilesh
Add em main loop for handling events based on capabilities of the
event device.
Signed-off-by: Pavan Nikhilesh
---
examples/l3fwd/l3fwd.h | 10 ++
examples/l3fwd/l3fwd_em.c| 177 +++
examples/l3fwd/l3fwd_em.h|
From: Pavan Nikhilesh
Update l3fwd user guide to include event device related information.
Update release notes and MAINTAINERS file.
Signed-off-by: Pavan Nikhilesh
---
MAINTAINERS | 1 +
doc/guides/rel_notes/release_20_02.rst | 5 ++
doc/guides/sample_app_ug/l3_
From: Pavan Nikhilesh
Add graceful teardown that addresses both event mode and poll mode.
Signed-off-by: Pavan Nikhilesh
---
examples/l3fwd/main.c | 50 +--
1 file changed, 34 insertions(+), 16 deletions(-)
diff --git a/examples/l3fwd/main.c b/examples/
From: Pavan Nikhilesh
Add service core setup when eventdev and Rx/Tx adapter don't have
internal port capability.
Signed-off-by: Pavan Nikhilesh
---
examples/l3fwd/l3fwd_event.c | 6 ++
examples/l3fwd/main.c| 188 +++
2 files changed, 150 insertions(+)
From: Pavan Nikhilesh
Add lpm main loop for handling events based on capabilities of the
event device.
Signed-off-by: Pavan Nikhilesh
---
examples/l3fwd/l3fwd.h | 9 ++
examples/l3fwd/l3fwd_event.c | 9 ++
examples/l3fwd/l3fwd_event.h | 5 +
examples/l3fwd/l3fwd_lpm.c | 203 +
From: Sunil Kumar Kori
Add ethernet port Rx/Tx queue setup for event device which are later
used for setting up event eth Rx/Tx adapters.
Signed-off-by: Sunil Kumar Kori
Signed-off-by: Nipun Gupta
---
examples/l3fwd/l3fwd.h | 10 +++
examples/l3fwd/l3fwd_event.c | 138 +
From: Pavan Nikhilesh
Add event eth Rx/Tx adapter setup for both generic and internal port
event device pipelines.
Signed-off-by: Sunil Kumar Kori
Signed-off-by: Pavan Nikhilesh
---
examples/l3fwd/l3fwd_event.c | 3 +
examples/l3fwd/l3fwd_event.h | 1 +
example
From: Sunil Kumar Kori
Add event device queue and port setup based on event eth Tx adapter
capabilities.
Signed-off-by: Sunil Kumar Kori
---
examples/l3fwd/l3fwd_event.c | 28 +-
examples/l3fwd/l3fwd_event.h | 1 +
examples/l3fwd/l3fwd_event_generic.c |
From: Sunil Kumar Kori
Add framework to enable event device as a producer of packets.
To switch between event mode and poll mode the following options
have been added:
`--mode="eventdev"` or `--mode="poll"`
Allow the user to select the schedule type to be either
RTE_SCHED_TYPE_ORDERED, RT
From: Pavan Nikhilesh
Add event device configuration based on the capabilities of the
probed event device.
Signed-off-by: Pavan Nikhilesh
---
examples/l3fwd/l3fwd_event.c | 3 +
examples/l3fwd/l3fwd_event.h | 36 ++
examples/l3fwd/l3fwd_event_generic.c
From: Sunil Kumar Kori
Add infra to split eventdev framework based on event Tx adapter
capability.
If event Tx adapter has internal port capability then we use
`rte_event_eth_tx_adapter_enqueue` to transmitting packets else
we use a SINGLE_LINK event queue to enqueue packets to a service
core whi
From: Pavan Nikhilesh
This patchset adds support for event mode in l3fwd.
The poll mode is still the default mode of operation.
The following new command line parameters are added:
--mode: Dictates the mode of operation either poll or event. If unset then
by default poll mode is used.
From: Kiran Kumar K
Extend RSS offload types for octeontx2. Add support to select
L3 SRC, L3 DST, L4 SRC and L4 DST for RSS calculation.
Add support to select L3 SRC or DST only, L4 SRC or DST only for RSS
calculation.
With this requirement there will be following combinations,
IPV[4,6]_SRC_ONL
Hi
From: Ferruh Yigit
> On 1/23/2020 3:29 PM, Matan Azrad wrote:
> >
> > Hi
> >
> > From: Ferruh Yigit
> >> On 1/23/2020 2:05 PM, Matan Azrad wrote:
> >>> Hi
> >>>
> >>> From: Yigit, Ferruh
> On 11/12/2019 8:47 AM, Matan Azrad wrote:
> > The port was not validated before detaching.
>
On 1/23/2020 5:46 PM, Iremonger, Bernard wrote:
> Hi Ferruh,
>
>>
>>
> Subject: [PATCH] app/testpmd: fix hotplug
>
This is reverting the original patch, which breaks hotplug.
I think the commit message should make this clear.
This patch is not fixing hotplug, the original p
On 1/23/2020 3:29 PM, Matan Azrad wrote:
>
> Hi
>
> From: Ferruh Yigit
>> On 1/23/2020 2:05 PM, Matan Azrad wrote:
>>> Hi
>>>
>>> From: Yigit, Ferruh
On 11/12/2019 8:47 AM, Matan Azrad wrote:
> The port was not validated before detaching.
>
> Ignore port detach operation when the
I see the current implementation doesn't cater for this escape sequence. U
have to implement a little logic to traverse through the empty buffs w.r.t.
current packets in buffer via some count.
On Thu, Jan 23, 2020, 10:54 PM Suraj R Gupta wrote:
> Folks,
> Any Ideas on this.
>
> On Mon, Jan 13, 2
Use the MLX5_ASSERT macros instead of the standard assert clause.
Depends on the MLX5_DEBUG configuration option to define it.
If MLX5_DEBUG is enabled MLX5_ASSERT is equal to RTE_VERIFY
to bypass the global CONFIG_RTE_ENABLE_ASSERT option.
If MLX5_DEBUG is disabled, the global CONFIG_RTE_ENABLE_AS
Use the MLX4_ASSERT macros instead of the standard assert clause.
Depends on the MLX4_DEBUG configuration option to define it.
If MLX4_DEBUG is enabled MLX4_ASSERT is equal to RTE_VERIFY
to bypass the global CONFIG_RTE_ENABLE_ASSERT option.
If MLX4_DEBUG is disabled, the global CONFIG_RTE_ENABLE_AS
Define a new MLX5_DEBUG compilation flag to get rid of dependency
on the NDEBUG definition. This is a preparation step to switch
from standard assert clauses to DPDK RTE_ASSERT ones in MLX5 driver.
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/Makefile
Define a new MLX4_DEBUG compilation flag to get rid of dependency
on the NDEBUG definition. This is a preparation step to switch
from standard assert clauses to DPDK RTE_ASSERT ones in MLX4 driver.
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx4/Makefile
The Mellanox PMD uses the NDEBUG definition to control built-in debug
features including the asserting one. The DPDK uses a bit different
approach and provides RTE_ASSERT macro and appropriate global
configuration option: CONFIG_RTE_ENABLE_ASSERT.
The patch set introduces the MLX_ASSERT macros that
Remove -Werror-all flag in ICC configuration file to stop treating ICC
warnings as errors in DPDK due to many false positives. We are using
GCC and Clang as a benchmark for warnings anyway for simplification.
Suggested-by: Thomas Monjalon
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovs
Folks,
Any Ideas on this.
On Mon, Jan 13, 2020 at 1:04 PM Suraj R Gupta
wrote:
> Hi all,
> This is regarding an issue in the draining packet using rte_reorder_drain.
> Suppose we have a window size of 16 and we get packets with sequence no
> like 0,1,2,4,5,6. On performing drain operation, I ret
Hi Ferruh,
>
>
> > >> Subject: [PATCH] app/testpmd: fix hotplug
> > >>
> > > This is reverting the original patch, which breaks hotplug.
> > > I think the commit message should make this clear.
> > > This patch is not fixing hotplug, the original patch seems to have
> > > revealed a
> > problem
On Wed, Jan 22, 2020 at 02:32:26PM +, Wang, Xiao W wrote:
> External Email
>
> --
> Hi Kalra,
>
> This patch is more about bug fix on user interrupt, no powering saving tuning.
> The target scenario is, a worker core is deali
Hi Ferruh,
> >> Subject: [PATCH] app/testpmd: fix hotplug
> >>
> > This is reverting the original patch, which breaks hotplug.
> > I think the commit message should make this clear.
> > This patch is not fixing hotplug, the original patch seems to have revealed
> > a
> problem with hotplug.
> >
On 1/23/2020 5:01 PM, Iremonger, Bernard wrote:
> Hi Ferruh,
>
>> -Original Message-
>> From: Yigit, Ferruh
>> Sent: Thursday, January 23, 2020 3:15 PM
>> To: Lu, Wenzhuo ; Wu, Jingjing
>> ; Iremonger, Bernard
>> ; Matan Azrad
>> Cc: dev@dpdk.org; sta...@dpdk.org
>> Subject: [PATCH] app/
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Thursday, January 23, 2020 3:15 PM
> To: Lu, Wenzhuo ; Wu, Jingjing
> ; Iremonger, Bernard
> ; Matan Azrad
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH] app/testpmd: fix hotplug
>
This is reverting the original patch
On Thu, Jan 23, 2020 at 11:15 AM Stephen Hemminger
wrote:
>
> On Thu, 23 Jan 2020 11:05:58 -0500
> Lance Richardson wrote:
>
> > The DPDK Coding Style document doesn't mention the use of c99 comments
> > using '//' as a comment delimiter, but it does say that traditional
> > '/* */' comment
> >
On Thu, 23 Jan 2020 11:05:58 -0500
Lance Richardson wrote:
> The DPDK Coding Style document doesn't mention the use of c99 comments
> using '//' as a comment delimiter, but it does say that traditional
> '/* */' comment
> delimiters should be used and therefore seems to imply that c99-style comm
Minutes 23 January 2020
---
Agenda:
* Release Dates
* -rc1 status
* Subtrees
* OvS
* Opens
Participants:
* Debian/Microsoft
* Intel
* Marvell
* Mellanox
* NXP
Release Dates
-
* v20.02 dates:
* -rc1 is released on 21 January
* https://mails.dpdk.org/archive
The DPDK Coding Style document doesn't mention the use of c99 comments
using '//' as a comment delimiter, but it does say that traditional
'/* */' comment
delimiters should be used and therefore seems to imply that c99-style comments
are not allowed.
Is this correct?
Lance
Hi
From: Ferruh Yigit
> The 'port_id_is_invalid()' check in the 'detach_port_device()' is breaking the
> hotplug support, since at that stage port will be closed and validity check
> always fail [1] and removing the device is not really completed.
>
> But this cause the vfio request interrupt k
>
> When adding custom element size feature, some internal inline functions were
> added in a public header without rte_ prefix.
> It is fixed by adding __rte_ring_.
>
> Fixes: cc4b218790f6 ("ring: support configurable element size")
>
> Reported-by: David Marchand
> Signed-off-by: Thomas Mon
23/01/2020 15:25, Alexander Kozyrev:
> Use the MLX4_ASSERT macros instead of the standard assert clause.
> Depends on the MLX4_DEBUG configuration option to define it as the
> RTE_ASSERT or an empty clause for a release configuration.
>
> Signed-off-by: Alexander Kozyrev
> Acked-by: Viacheslav Ov
> > > > > > > The SA lookup logic and management is purely requirement based
> > > > > > > for the
> > > > > > application.
> > > > > > >The application may only cater to <128 SAs which can
> > > > > > > be handled based on the current logic.
> > > > > >
> > > > > > Not always, current implementa
On further investigation, it' seen that the dvSwitch does not have any
multicast MAC registered when using DPDK vmxnet3 poll mode driver
along with the KNI sample app post configuring IPv6 address on the
vEth0 KNI interface. The same interface when used with the kernel
driver works fine. Any help o
23/01/2020 15:25, Alexander Kozyrev:
> Remove -Werror-all flag in ICC configuration file to stop treating ICC
> warnings as errors in DPDK due to many false positives. We are using
> GCC as a benchmark for wanings anyway and would like to simplify this.
GCC and clang
typo: wanings
> Suggested-by
Hi
From: Ferruh Yigit
> On 1/23/2020 2:05 PM, Matan Azrad wrote:
> > Hi
> >
> > From: Yigit, Ferruh
> >> On 11/12/2019 8:47 AM, Matan Azrad wrote:
> >>> The port was not validated before detaching.
> >>>
> >>> Ignore port detach operation when the port is not valid.
> >>>
> >>> Fixes: f8e5baa2662
The 'port_id_is_invalid()' check in the 'detach_port_device()' is
breaking the hotplug support, since at that stage port will be closed
and validity check always fail [1] and removing the device is not really
completed.
But this cause the vfio request interrupt keep triggered continuously
and make
On 1/23/2020 2:05 PM, Matan Azrad wrote:
> Hi
>
> From: Yigit, Ferruh
>> On 11/12/2019 8:47 AM, Matan Azrad wrote:
>>> The port was not validated before detaching.
>>>
>>> Ignore port detach operation when the port is not valid.
>>>
>>> Fixes: f8e5baa2662d ("app/testpmd: check not detaching device
Use the MLX4_ASSERT macros instead of the standard assert clause.
Depends on the MLX4_DEBUG configuration option to define it as the
RTE_ASSERT or an empty clause for a release configuration.
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx4/mlx4.c| 25
Define a new MLX5_DEBUG compilation flag to get rid of dependency
on the NDEBUG definition. This is a preparation step to switch
from standard assert clauses to DPDK RTE_ASSERT ones in MLX5 driver.
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/Makefile
Use the MLX5_ASSERT macros instead of the standard assert clause.
Depends on the MLX5_DEBUG configuration option to define it as the
RTE_ASSERT or an empty clause for a release configuration.
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5.c
Define a new MLX4_DEBUG compilation flag to get rid of dependency
on the NDEBUG definition. This is a preparation step to switch
from standard assert clauses to DPDK RTE_ASSERT ones in MLX4 driver.
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx4/Makefile
Remove -Werror-all flag in ICC configuration file to stop treating ICC
warnings as errors in DPDK due to many false positives. We are using
GCC as a benchmark for wanings anyway and would like to simplify this.
Suggested-by: Thomas Monjalon
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav O
The Mellanox PMD uses the NDEBUG definition to control built-in debug
features including the asserting one. The DPDK uses a bit different
approach and provides RTE_ASSERT macro and appropriate global
configuration option: CONFIG_RTE_ENABLE_ASSERT.
The patch set introduces the MLX_ASSERT macros that
Hi
From: Yigit, Ferruh
> On 11/12/2019 8:47 AM, Matan Azrad wrote:
> > The port was not validated before detaching.
> >
> > Ignore port detach operation when the port is not valid.
> >
> > Fixes: f8e5baa2662d ("app/testpmd: check not detaching device twice")
> > Cc: tho...@monjalon.net
> > Cc: sta
>
> Maintainance of armv8_crypto library created by Marvell/Cavium will
> be discontinued. Going forward, Armv8 crypto PMD will link to AArch64
> crypto library hosted by Arm.
>
> Patch 1/5, 3/5 update source code and document respectively to reflect
> the change.
> Patch 2/5 adds meson build
23/01/2020 13:56, Akhil Goyal:
> Hi Konstantin,
> >
> > Hi Akhil,
> >
> > > > > > Hi Vladimir,
> > > > > > The SA lookup logic and management is purely requirement based for
> > > > > > the
> > > > > application.
> > > > > >The application may only cater to <128 SAs which can
> > > > > > be hand
On 11/12/2019 8:47 AM, Matan Azrad wrote:
> The port was not validated before detaching.
>
> Ignore port detach operation when the port is not valid.
>
> Fixes: f8e5baa2662d ("app/testpmd: check not detaching device twice")
> Cc: tho...@monjalon.net
> Cc: sta...@dpdk.org
>
> Signed-off-by: Matan
On 13-Dec-19 2:13 PM, Maxime Coquelin wrote:
This new API allows to pass a file descriptor while
registering external and contiguous memory in the IOVA space.
This is required for using Virtio-user PMD with application
using external memory for the mbuf's buffers, like Seastar
or VPP.
FD is onl
Hi Konstantin,
>
> Hi Akhil,
>
> > > > > Hi Vladimir,
> > > > > The SA lookup logic and management is purely requirement based for the
> > > > application.
> > > > >The application may only cater to <128 SAs which can
> > > > > be handled based on the current logic.
> > > >
> > > > Not always, cu
Hi Akhil,
> > > > Hi Vladimir,
> > > > The SA lookup logic and management is purely requirement based for the
> > > application.
> > > >The application may only cater to <128 SAs which can
> > > > be handled based on the current logic.
> > >
> > > Not always, current implementation can handle < 12
Hi All,
>
> Hi Konstantin,
> >
> > Hi Akhil,
> >
> > > Hi Vladimir,
> > > The SA lookup logic and management is purely requirement based for the
> > application.
> > >The application may only cater to <128 SAs which can
> > > be handled based on the current logic.
> >
> > Not always, current imple
On Wed, 2020-01-22 at 16:34 +, Luca Boccassi wrote:
> On Wed, 2020-01-22 at 16:06 +, Ali Alnubani wrote:
> > Hi,
> >
> > > -Original Message-
> > > From: Luca Boccassi <
> > > bl...@debian.org
> > >
> > >
> > > Sent: Monday, January 13, 2020 2:47 PM
> > > To: dpdk stable <
> > >
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, January 22, 2020 10:03 PM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh ; Dumitrescu, Cristian
>
> Subject: [PATCH] maintainers: set QoS git tree for some ethdev files
>
> The tree dpdk-next-tm does not exist anymore.
> Traffic
On Mon, Dec 2, 2019 at 1:03 PM Jerin Jacob wrote:
>
> On Mon, Dec 2, 2019 at 4:01 PM Liron Himi wrote:
> >
> > Hi Jerin,
> >
> > I have created a patch to MUSDK that fix this conflicts as you suggested.
> > This will be externally available in the next MUSDK release.
> > Once it will be out, we c
Add a new EAL option enabling manual probing in the EAL.
This command line option will configure the EAL so that buses
will not trigger their probe step on their own.
Applications are then expected to hotplug devices as they see fit.
Devices declared on the command line by the user (using -w and
On 22/01/2020 17:51, Pavan Nikhilesh Bhagavatula wrote:
Ping
@gr...@u256.net
Since, you weren't reachable on regular email I rebased the patch on ToT and
sent a v6
http://patches.dpdk.org/patch/64235/
Hello Pavan, indeed sorry about this.
I have not heard remarks about the patchset anyway in
On 1/22/2020 11:37 PM, Ajit Khaparde wrote:
> On Wed, Jan 22, 2020 at 9:56 AM Stephen Hemminger <
> step...@networkplumber.org> wrote:
>
>> A couple of minor things in bnxt statistics
>>
>> Stephen Hemminger (2):
>> net/bnxt: do not print error if stats queried before start
>> net/bnxt: remove
On 1/22/2020 7:49 AM, Ye Xiaolong wrote:
> On 01/22, Xing, Beilei wrote:
>>
>>
>>> -Original Message-
>>> From: Ye, Xiaolong
>>> Sent: Wednesday, January 22, 2020 11:58 AM
>>> To: Xing, Beilei ; Zhang, Qi Z
>>> Cc: dev@dpdk.org; Ye, Xiaolong
>>> Subject: [PATCH] net/i40e/base: skip furthe
When adding custom element size feature, some internal inline functions
were added in a public header without rte_ prefix.
It is fixed by adding __rte_ring_.
Fixes: cc4b218790f6 ("ring: support configurable element size")
Reported-by: David Marchand
Signed-off-by: Thomas Monjalon
---
lib/librt
68 matches
Mail list logo
