Re: [dpdk-dev] [PATCH v2] net/e1000: update UPDATE_VF_STAT to handle rollover

2020-01-28 Thread Ye Xiaolong
On 01/26, David Harton wrote: >Modified UPDATE_VF_STAT to properly handle rollover conditions. > >Fixes: d82170d27918 ("igb: add VF support") >Cc: intel.com > >Signed-off-by: David Harton >--- > drivers/net/e1000/igb_ethdev.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) >

Re: [dpdk-dev] [PATCH v2] net/ixgbevf: update VF_STAT macros to handle rollover

2020-01-28 Thread Ye Xiaolong
On 01/26, David Harton wrote: >Added rollover logic to UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT macros. > >Fixes: af75078fece3 ("first public release") >Cc: intel.com Cc: sta...@dpdk.org > >Signed-off-by: David Harton >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++-- > 1 file changed, 10

Re: [dpdk-dev] [PATCH] net/mlx5: make FDB default rule optional

2020-01-28 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Tuesday, January 28, 2020 19:07 > To: Slava Ovsiienko > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: make FDB default rule optional > > There are RDMA-CORE versions which are not supported multi-table for some > Mellanox

[dpdk-dev] [PATCH v2 1/1] net/octeontx: fix user supplied index in MAC address add

2020-01-28 Thread Sunil Kumar Kori
Earlier after a successful mac_addr_add operation, index was returned by underlying layer which was unused but same as provided by DPDK API. So API is enhanced to use application provided index location to add MAC address entry. Fixes: e4373bf1b3f5 ("net/octeontx: add unicast MAC filter") Signed

Re: [dpdk-dev] [EXT] Re: [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-28 Thread Anoob Joseph
Hi Ferruh, Akhil, Thomas, I would like to make the following modifications to MAINTAINERS file to better isolate security additions. diff --git a/MAINTAINERS b/MAINTAINERS index 94bccae..76171ce 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -724,6 +724,12 @@ F: drivers/net/octeontx2/ F: doc/gui

[dpdk-dev] [PATCH] net/bnx2x: fix to set stripped flag for VLAN packet

2020-01-28 Thread Rasesh Mody
For VLAN packet the tci is saved in rx_mb->vlan_tci, however the STRIPPED offload flag is not set along with PKT_RX_VLAN flag. Set the PKT_RX_VLAN_STRIPPED flag as well. Fixes: 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags") Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN") Cc:

Re: [dpdk-dev] [PATCH v5 8/9] build: add additional common files support

2020-01-28 Thread Pallavi Kadam
On 1/27/2020 2:55 PM, Thomas Monjalon wrote: 13/01/2020 22:55, Pallavi Kadam: Added support for additional common files in meson build to expand Windows EAL and to support the lcore parsing feature on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranj

Re: [dpdk-dev] [PATCH v5 7/9] eal: remove syslog support for windows

2020-01-28 Thread Pallavi Kadam
On 1/27/2020 2:52 PM, Thomas Monjalon wrote: 13/01/2020 22:55, Pallavi Kadam: Added #ifndef WIN64 to exclude syslog definitions and parameters from Windows builds. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_ea

Re: [dpdk-dev] [PATCH v5 3/9] eal: add windows compatible header files

2020-01-28 Thread Pallavi Kadam
On 1/27/2020 2:41 PM, Thomas Monjalon wrote: 13/01/2020 22:55, Pallavi Kadam: Modified \common\include\arch\x86\rte_vect.h to include SSE4 header for Windows. Adding dlfcn.h on Windows to support common code. Adding eal_filesystem.h to support functions and path defines for files and directo

Re: [dpdk-dev] DPDK Windows Build

2020-01-28 Thread Dmitry Kozliuk
Hello Jeremy, > clang: error: no such file or directory: '/OPT:REF' There is a bug in Meson: '/OPT:REF' must be prefixed with '-Wl,' when using Clang with link.exe, because Clang does not recognize '/OPT:REF' as an argument to pass to linker, but treats it as a filename instead. A patch is not un

Re: [dpdk-dev] [PATCH v3 0/9] bnxt patch set

2020-01-28 Thread Ajit Khaparde
On Tue, Jan 28, 2020 at 1:02 PM Ajit Khaparde wrote: > Please apply. > > v1->v2: Added one more patch to the set ("net/bnxt: fix coverity warnings") > v2->v3: Updated Fixes tag and added sta...@dpdk.org where necessary. > Patchset applied to dpdk-next-net-brcm. Thanks > > Kalesh AP (5): > net

[dpdk-dev] [PATCH v3 9/9] net/bnxt: fix coverity warnings

2020-01-28 Thread Ajit Khaparde
From: Kalesh AP return value stored in "ret" but it has been overwritten before use. CID 353621: Code maintainability issues (UNUSED_VALUE) Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW") Cc: sta...@dpdk.

[dpdk-dev] [PATCH v3 8/9] net/bnxt: fix to support zero mark id along with RSS action

2020-01-28 Thread Ajit Khaparde
From: Somnath Kotur Certain applications(Ex: OVS-DPDK) can issue rte_flow_create with mark id set to 0. The mark table entry creation in the driver was assuming non-zero mark ids. Fix it to have a valid flag for each entry. Also, it is possible that both RSS flags and cfa_code/ mark id are set as

[dpdk-dev] [PATCH] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-01-28 Thread Thinh Tran
__ppc_get_timebase() is GNU extention and is more efficient Signed-off-by: Thinh Tran --- .../common/include/arch/ppc_64/rte_cycles.h | 28 ++- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h b/lib/librte_

[dpdk-dev] [PATCH v3 1/9] net/bnxt: fix alloc filter to use a common routine

2020-01-28 Thread Ajit Khaparde
From: Somnath Kotur Invoke bnxt_get_unused_filter() inside bnxt_alloc_filter() so that all filters are allocated from one common routine. Fixes: f92735db1e4c ("net/bnxt: add L2 filter alloc/init/free") Cc: sta...@dpdk.org Reviewed-by: Kalesh Anakkur Purayil Signed-off-by: Somnath Kotur Signed

[dpdk-dev] [PATCH v3 6/9] net/bnxt: remove unnecessary structure variable

2020-01-28 Thread Ajit Khaparde
From: Kalesh AP This change could help in reducing the size of bnxt PMD private data structure by converting a uint8_t variable to use bit map flag. Fixes: 5cd0e2889c432 ("net/bnxt: support NIC Partitioning") Cc: sta...@dpdk.org Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Ajit Kh

[dpdk-dev] [PATCH v3 4/9] net/bnxt: remove redundant if statement

2020-01-28 Thread Ajit Khaparde
From: Kalesh AP Since "eth_dev->data->dev_started" has been assigned to 0 at the beginning of bnxt_dev_stop_op() routine, the code inside the if() condition is redundant. Remove it. Anyways "eth_dev->data->dev_link.link_status" will be set to 0 in bnxt_dev_set_link_down_op() later in the routine

[dpdk-dev] [PATCH v3 5/9] net/bnxt: remove redundant macro

2020-01-28 Thread Ajit Khaparde
From: Kalesh AP Use "dev->data->dev_started" state, instead of local BNXT_FLAG_INIT_DONE to check whether device has been initialised or not. Fixes: ed2ced6fe927 ("net/bnxt: check initialization before accessing stats") Cc: sta...@dpdk.org Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-

[dpdk-dev] [PATCH v3 3/9] net/bnxt: fix to allow group ID 0 for RSS action

2020-01-28 Thread Ajit Khaparde
From: Somnath Kotur Allow RSS action with group ID 0. The RSS match check will ensure if requested RSS action configuration parameters should be allowed as per the VNIC's RSS configuration or not and if it does match as it is by design in OVS-DPDK use case, the default vnic can be used to create

[dpdk-dev] [PATCH v3 2/9] net/bnxt: fix bumping of L2 filter reference count

2020-01-28 Thread Ajit Khaparde
From: Somnath Kotur Now that the L2 filter reference count is bumped up in all cases including bnxt_alloc_filter() which is issued in init, just move this ref count bump inside the routine issuing the HWRM cmd so that it is bumped up only if the cmd is successful. Fixes: 5c1171c97216 ("net/bnxt:

[dpdk-dev] [PATCH v3 7/9] net/bnxt: remove a redundant variable

2020-01-28 Thread Ajit Khaparde
From: Kalesh AP Use "dev->data->dev_started" state, instead of local "dev_stopped" to check whether port has been started or not. Fixes: 316e412299fd ("net/bnxt: fix crash when closing") Cc: sta...@dpdk.org Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Ajit Khaparde Signed-off-by:

[dpdk-dev] [PATCH v3 0/9] bnxt patch set

2020-01-28 Thread Ajit Khaparde
Please apply. v1->v2: Added one more patch to the set ("net/bnxt: fix coverity warnings") v2->v3: Updated Fixes tag and added sta...@dpdk.org where necessary. Kalesh AP (5): net/bnxt: remove redundant if statement net/bnxt: remove redundant macro net/bnxt: remove unnecessary structure varia

Re: [dpdk-dev] [PATCH] ci: increase unit test timeout

2020-01-28 Thread Aaron Conole
Ferruh Yigit writes: > Timeout multiplier was 3, which gives 30 seconds for unit test but still > some unit test was timing out time to time and travis reporting false > positive failures. > > Increasing the multiplier to 10, which makes timeout duration > 100seconds. > > Signed-off-by: Ferruh Yi

Re: [dpdk-dev] [PATCH] Documentation errata:RCU_lib.rst and Ring fig 6.10 corrected

2020-01-28 Thread Honnappa Nagarahalli
Hi Prateek, Thanks for the patch, few comments inline. Can you please look at [1] and format the patch accordingly? [1] https://doc.dpdk.org/guides/contributing/patches.html#make-your-changes (sections 6.5 to 6.12) > -Original Message- > From: dev On Behalf Of pratee...@cse.iit

Re: [dpdk-dev] [PATCH] ci: increase unit test timeout

2020-01-28 Thread Michael Santana
I have been out of the loop for a while, so I do not know how many false positives there are. Looking at https://travis-ci.com/ovsrobot/dpdk/builds up to two weeks back it seems that hash_readwrite_lf_autotest is the only culprit. It looks like it lives in the neighborhood of 20-30s seconds so

Re: [dpdk-dev] [PATCH 2/2] eal: add eal_parse_optionlist to parse user input

2020-01-28 Thread Ferruh Yigit
On 1/27/2020 10:30 AM, Hariprasad Govindharajan wrote: > In current version, there is a function which parses > the corelist based on user value. A new generic > function eal_parse_optionlist is added which will > parse corelist as well as similar user input so > that we can use it as a public API

Re: [dpdk-dev] [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-28 Thread Ferruh Yigit
On 1/28/2020 8:29 AM, Jerin Jacob wrote: > On Mon, Jan 27, 2020 at 8:24 PM Anoob Joseph wrote: >> >> Hi Jerin, Akhil, >> >> Let me summarize the design changes from the discussions below. >> >> Currently, drivers/crypto/octeontx2/otx2_security.c defines all security ctx >> ops for the ethdev (ide

Re: [dpdk-dev] [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-28 Thread Ferruh Yigit
On 1/27/2020 2:54 PM, Anoob Joseph wrote: > Hi Jerin, Akhil, > > Let me summarize the design changes from the discussions below. > > Currently, drivers/crypto/octeontx2/otx2_security.c defines all security ctx > ops for the ethdev (idea was to add all crypto security ctx for lookaside > also th

[dpdk-dev] [PATCH] net/mlx5: make FDB default rule optional

2020-01-28 Thread Matan Azrad
There are RDMA-CORE versions which are not supported multi-table for some Mellanox mlx5 devices. Hence, the optimization added in commit [1] which forwards all the FDB traffic to table 1 cannot be configured. Make the above optimization optional: Do not fail when either table 1 cannot be created

Re: [dpdk-dev] [PATCH 1/2] net/octeontx2: check compiler flag before use

2020-01-28 Thread Jerin Jacob
On Fri, Jan 24, 2020 at 9:10 PM Bruce Richardson wrote: > > Rather than assuming all compilers support the -flax-vector-extensions > flag, we should test this before using it, thereby potentially avoiding > warnings. > > Cc: jer...@marvell.com > > Signed-off-by: Bruce Richardson Acked-by: Jerin

[dpdk-dev] DPDK Windows Build

2020-01-28 Thread Jeremy Plsek
Hello, I'm trying to build DPDK on Windows for the DPDK Community Lab CI. I have a mostly fresh install of Windows Server 2019 and I mostly followed https://doc.dpdk.org/guides/windows_gsg/build_dpdk.html But I'm having trouble compiling it. I've attached logs for both clang 7 and clang 9. Any

[dpdk-dev] [RFC PATCH v2] kni: properly translate pa2va for cloned mbuf

2020-01-28 Thread Junxiao Shi
Previously, KNI kernel module uses the difference between m->buf_addr and m->buf_iova to calculate userspace virtual address from physical address. This works for direct mbufs, but does not work for indirect (cloned) mbufs that come from another mempool. Transmitting a cloned mbuf may cause segment

Re: [dpdk-dev] [PATCH v5 2/8] crypto/aesni_gcm: cpu crypto support

2020-01-28 Thread Ananyev, Konstantin
> -Original Message- > From: Smoczynski, MarcinX > Sent: Tuesday, January 28, 2020 2:22 PM > To: akhil.go...@nxp.com; Ananyev, Konstantin ; > Zhang, Roy Fan ; Doherty, > Declan ; Nicolau, Radu ; De > Lara Guarch, Pablo > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v5 2/8

Re: [dpdk-dev] [PATCH v5 5/8] ipsec: introduce support for cpu crypto mode

2020-01-28 Thread Ananyev, Konstantin
> > Update library to handle CPU cypto security mode which utilizes > cryptodev's synchronous, CPU accelerated crypto operations. > > Signed-off-by: Konstantin Ananyev > Signed-off-by: Marcin Smoczynski > Acked-by: Fan Zhang > --- > lib/librte_ipsec/esp_inb.c | 156 ++

[dpdk-dev] [PATCH] ci: increase unit test timeout

2020-01-28 Thread Ferruh Yigit
Timeout multiplier was 3, which gives 30 seconds for unit test but still some unit test was timing out time to time and travis reporting false positive failures. Increasing the multiplier to 10, which makes timeout duration 100seconds. Signed-off-by: Ferruh Yigit --- .ci/linux-build.sh | 2 +-

[dpdk-dev] [PATCH v3 23/25] net/mlx5: reduce Netlink commands dependencies

2020-01-28 Thread Matan Azrad
As an arrangment for Netlink command moving to the common library, reduce the net/mlx5 dependencies. Replace ethdev class command parameters. Improve Netlink sequence number mechanism to be controlled by the mlx5 Netlink mechanism. Move mlx5_nl_check_switch_info to mlx5_nl.c since it is the only

[dpdk-dev] [PATCH v3 25/25] common/mlx5: support ROCE disable through Netlink

2020-01-28 Thread Matan Azrad
Add new 4 Netlink commands to support enable/disable ROCE: 1. mlx5_nl_devlink_family_id_get to get the Devlink family ID of Netlink general command. 2. mlx5_nl_enable_roce_get to get the ROCE current status. 3. mlx5_nl_driver_reload - to reload the device kernel d

[dpdk-dev] [PATCH v3 22/25] net/mlx5: separate Netlink command interface

2020-01-28 Thread Matan Azrad
The Netlink commands interfaces is included in the mlx5.h file with a lot of other PMD interfaces. As an arrangement to make the Netlink commands shared with different PMDs, this patch moves the Netlink interface to a new file called mlx5_nl.h. Move non Netlink pure vlan commands from mlx5_nl.c t

[dpdk-dev] [PATCH v3 24/25] common/mlx5: share Netlink commands

2020-01-28 Thread Matan Azrad
Move Netlink mechanism and its dependencies from net/mlx5 to common/mlx5 in order to be ready to use by other mlx5 drivers. The dependencies are BITFIELD defines, the ppc64 compilation workaround for bool type and the function mlx5_translate_port_name. Update build mechanism accordingly. Signed-

[dpdk-dev] [PATCH v3 21/25] net/mlx5: select driver by vDPA device argument

2020-01-28 Thread Matan Azrad
There might be a case that one Mellanox device can be probed by multiple mlx5 drivers. One case is that any mlx5 vDPA device can be probed by bothe net/mlx5 and vdpa/mlx5. Add a new mlx5 common API to get the requested driver by devargs: vdpa=1. Skip net/mlx5 PMD probing while the device is sele

[dpdk-dev] [PATCH v3 19/25] common/mlx5: add DevX command to modify RQT

2020-01-28 Thread Matan Azrad
RQ table can be changed to support different list of queues. Add DevX command to modify DevX RQT object to point on new RQ list. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c| 47 + drivers/common/mlx5/mlx

[dpdk-dev] [PATCH v3 16/25] common/mlx5: add support for DevX QP operations

2020-01-28 Thread Matan Azrad
QP creation is needed for vDPA virtq support. Add 2 DevX commands to create QP and to modify QP state. The support is for RC QP only in force loopback address mode. By this way, the packets can be sent to other inernal destinations in the nic. For example: other QPs or virtqs. Signed-off-by: Ma

[dpdk-dev] [PATCH v3 17/25] common/mlx5: allow type configuration for DevX RQT

2020-01-28 Thread Matan Azrad
Allow virtio queue type configuration in the RQ table. The needed fields and configuration was added. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/common/mlx5/mlx5_prm.h | 5 ++

[dpdk-dev] [PATCH v3 18/25] common/mlx5: add TIR field constants

2020-01-28 Thread Matan Azrad
The DevX TIR object configuration should get L3 and L4 protocols expected to be forwarded by the TIR. Add the PRM constant values needed to configure the L3 and L4 protocols. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_prm.h | 10 ++ 1 file ch

[dpdk-dev] [PATCH v3 20/25] common/mlx5: get DevX capability for max RQT size

2020-01-28 Thread Matan Azrad
In order to allow RQT size configuration which is limited to the correct maximum value, add log_max_rqt_size for DevX capability structure. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 fi

[dpdk-dev] [PATCH v3 12/25] common/mlx5: glue UAR allocation

2020-01-28 Thread Matan Azrad
The isolated, protected and independent direct access to the HW by multiple processes is implemented via User Access Region (UAR) mechanism. The UAR is part of PCI address space that is mapped for direct access to the HW from the CPU. UAR is comprised of multiple pages, each page containing registe

[dpdk-dev] [PATCH v3 15/25] common/mlx5: add DevX virtq commands

2020-01-28 Thread Matan Azrad
Virtio emulation offload allows SW to offload the I/O operations of a virtio virtqueue, using the device, allowing an improved performance for its users. While supplying all the relevant Virtqueue information (type, size, memory location, doorbell information, etc.). The device can then offload the

[dpdk-dev] [PATCH v3 14/25] common/mlx5: glue VAR allocation

2020-01-28 Thread Matan Azrad
Virtio access region(VAR) is the UAR that allocated for virtio emulation access. Add rdma-core operations to allocate and free VAR. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/Makefile| 5 + drivers/common/mlx5/meson.build | 1 + drivers/common/m

[dpdk-dev] [PATCH v3 08/25] common/mlx5: glue null memory region allocation

2020-01-28 Thread Matan Azrad
Add support for rdma-core API to allocate NULL MR. When the device HW get a NULL MR address, it will do nothing with the address, no read and no write. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_glue.c | 13 + drivers/common/mlx5/mlx5_glu

[dpdk-dev] [PATCH v3 10/25] common/mlx5: glue event queue query

2020-01-28 Thread Matan Azrad
The event queue is managed only by the kernel. Add the rdma-core command in glue to query the kernel event queue details. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_glue.c | 15 +++ drivers/common/mlx5/mlx5_glue.h | 2 ++ 2 files changed

[dpdk-dev] [PATCH v3 09/25] common/mlx5: support DevX indirect mkey creation

2020-01-28 Thread Matan Azrad
Add option to create an indirect mkey by the current mlx5_devx_cmd_mkey_create command. Indirect mkey points to set of direct mkeys. By this way, the HW\SW can reference fragmented memory by one object. Align the net/mlx5 driver usage in the above command. Signed-off-by: Matan Azrad Acked-by: V

[dpdk-dev] [PATCH v3 11/25] common/mlx5: glue event interrupt commands

2020-01-28 Thread Matan Azrad
Add the next commands to glue in order to support interrupt event channel operations associated to events in the EQ: devx_create_event_channel, devx_destroy_event_channel, devx_subscribe_devx_event, devx_subscribe_devx_event_fd, devx_get_event. Signed-off-by

[dpdk-dev] [PATCH v3 06/25] common/mlx5: share CQ entry check

2020-01-28 Thread Matan Azrad
The CQE has owner bit to indicate if it is in SW control or HW. Share a CQE check for all the mlx5 drivers. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_common.h | 41 +++ drivers/net/mlx5/mlx5_rxtx.h | 39 +

[dpdk-dev] [PATCH v3 13/25] common/mlx5: add DevX command to create CQ

2020-01-28 Thread Matan Azrad
HW implements completion queues(CQ) used to post completion reports upon completion of work request. Used for Rx and Tx datapath. Add DevX command to create a CQ. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c| 57 +++

[dpdk-dev] [PATCH v3 07/25] common/mlx5: add query vDPA DevX capabilities

2020-01-28 Thread Matan Azrad
Add the DevX capabilities for vDPA configuration and information of Mellanox devices. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 90 drivers/common/mlx5/mlx5_devx_cmds.h | 24 ++ drivers/commo

[dpdk-dev] [PATCH v3 03/25] common/mlx5: share the mlx5 glue reference

2020-01-28 Thread Matan Azrad
A new Mellanox vdpa PMD will be added to support vdpa operations by Mellanox adapters. Both, the mlx5 PMD and the vdpa mlx5 PMD should initialize the glue. The glue initialization should be only one per process, so all the mlx5 PMDs using the glue should share the same glue object. Move the glue

[dpdk-dev] [PATCH v3 04/25] common/mlx5: share mlx5 PCI device detection

2020-01-28 Thread Matan Azrad
Move PCI detection by IB device from mlx5 PMD to the common code. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/Makefile| 2 +- drivers/common/mlx5/mlx5_common.c | 55 + drivers/common/mlx5/mlx5_commo

[dpdk-dev] [PATCH v3 01/25] net/mlx5: separate DevX commands interface

2020-01-28 Thread Matan Azrad
The DevX commands interface is included in the mlx5.h file with a lot of other PMD interfaces. As an arrangement to make the DevX commands shared with different PMDs, this patch moves the DevX interface to a new file called mlx5_devx_cmds.h. Also remove shared device structure dependency on DevX

[dpdk-dev] [PATCH v3 05/25] common/mlx5: share mlx5 devices information

2020-01-28 Thread Matan Azrad
Move the vendor information, vendor ID and device IDs from net/mlx5 PMD to the common mlx5 file. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_common.h | 21 + drivers/net/mlx5/mlx5.h | 21 - drivers/net/

[dpdk-dev] [PATCH v3 00/25] Introduce mlx5 common library

2020-01-28 Thread Matan Azrad
Steps: - Prepare net/mlx5 for code sharing. - Introduce new common lib for mlx5 devices. - Share code from net/mlx5 to common/mlx5. v2: - Reorder patches for 2 serieses - this is the first one for common directory and vDPA preparation, the second will be sent later for vDPA new driver part. - F

Re: [dpdk-dev] [PATCH 1/2] devtools: standardize script arguments

2020-01-28 Thread Ferruh Yigit
On 1/28/2020 3:02 PM, Ciara Power wrote: > This patch modifies the arguments expected by the check-git-log script, > to match the format of arguments for the checkpatches script. Both > scripts now take certain argument options in the same format, making > them easier to use. > e.g. Both now take a

Re: [dpdk-dev] [PATCH 2/2] devtools: added stats print

2020-01-28 Thread Ferruh Yigit
On 1/28/2020 3:02 PM, Ciara Power wrote: > When all checks are completed on the specified commit logs, the script > indicates if all are valid, or if there were some failures. > > Signed-off-by: Ciara Power Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH 2/2] devtools: added stats print

2020-01-28 Thread Ciara Power
When all checks are completed on the specified commit logs, the script indicates if all are valid, or if there were some failures. Signed-off-by: Ciara Power --- devtools/check-git-log.sh | 45 ++- 1 file changed, 30 insertions(+), 15 deletions(-) diff --git

[dpdk-dev] [PATCH 1/2] devtools: standardize script arguments

2020-01-28 Thread Ciara Power
This patch modifies the arguments expected by the check-git-log script, to match the format of arguments for the checkpatches script. Both scripts now take certain argument options in the same format, making them easier to use. e.g. Both now take a commit ID range by "-r " The checkpatches help pr

[dpdk-dev] [PATCH 0/2] standardize devtools check scripts

2020-01-28 Thread Ciara Power
This patchset standardizes the checkpatches and check-git-log scripts to accept the same syntax commandline arguments, to make them easier to use. The output is also standardized, check-git-log previously showed no output to the user when no errors were found, but now prints a similar output to th

[dpdk-dev] [PATCH v5 6/8] examples/ipsec-secgw: cpu crypto support

2020-01-28 Thread Marcin Smoczynski
Add support for CPU accelerated crypto. 'cpu-crypto' SA type has been introduced in configuration allowing to use abovementioned acceleration. Legacy mode is not currently supported. Signed-off-by: Konstantin Ananyev Signed-off-by: Marcin Smoczynski Acked-by: Fan Zhang --- examples/ipsec-secg

[dpdk-dev] [PATCH v5 7/8] examples/ipsec-secgw: cpu crypto testing

2020-01-28 Thread Marcin Smoczynski
Enable cpu-crypto mode testing by adding dedicated environmental variable CRYPTO_PRIM_TYPE. Setting it to 'type cpu-crypto' allows to run test scenario with cpu crypto acceleration. Signed-off-by: Konstantin Ananyev Signed-off-by: Marcin Smoczynski Acked-by: Fan Zhang --- examples/ipsec-secgw/

[dpdk-dev] [PATCH v5 8/8] doc: add cpu crypto related documentation

2020-01-28 Thread Marcin Smoczynski
Update documentation with a description of cpu crypto in cryptodev, ipsec and security libraries. Add release notes for 20.02. Signed-off-by: Marcin Smoczynski --- doc/guides/cryptodevs/aesni_gcm.rst | 7 +- doc/guides/prog_guide/cryptodev_lib.rst | 33 - doc/gu

[dpdk-dev] [PATCH v5 5/8] ipsec: introduce support for cpu crypto mode

2020-01-28 Thread Marcin Smoczynski
Update library to handle CPU cypto security mode which utilizes cryptodev's synchronous, CPU accelerated crypto operations. Signed-off-by: Konstantin Ananyev Signed-off-by: Marcin Smoczynski Acked-by: Fan Zhang --- lib/librte_ipsec/esp_inb.c | 156 ++- lib/lib

[dpdk-dev] [PATCH v5 2/8] crypto/aesni_gcm: cpu crypto support

2020-01-28 Thread Marcin Smoczynski
Add support for CPU crypto mode by introducing required handler. Crypto mode (sync/async) is chosen during sym session create if an appropriate flag is set in an xform type number. Authenticated encryption and decryption are supported with tag generation/verification. Signed-off-by: Marcin Smoczy

[dpdk-dev] [PATCH v5 3/8] test/crypto: add CPU crypto tests

2020-01-28 Thread Marcin Smoczynski
Add unit and performance tests for CPU crypto mode currently implemented by AESNI-GCM cryptodev. Unit tests cover AES-GCM and GMAC test vectors. Signed-off-by: Marcin Smoczynski Acked-by: Pablo de Lara --- app/test/Makefile | 3 +- app/test/cpu_crypto_all_gcm_perf_

[dpdk-dev] [PATCH v5 4/8] security: add cpu crypto action type

2020-01-28 Thread Marcin Smoczynski
Introduce CPU crypto action type allowing to differentiate between regular async 'none security' and synchronous, CPU crypto accelerated sessions. Signed-off-by: Marcin Smoczynski Acked-by: Konstantin Ananyev Acked-by: Fan Zhang --- lib/librte_security/rte_security.h | 8 ++-- 1 file chang

[dpdk-dev] [PATCH v5 1/8] cryptodev: introduce cpu crypto support API

2020-01-28 Thread Marcin Smoczynski
Add new API allowing to process crypto operations in a synchronous manner. Operations are performed on a set of SG arrays. Sync mode is selected by setting appropriate flag in an xform type number. Cryptodevs which allows CPU crypto operation mode have to use RTE_CRYPTODEV_FF_SYM_CPU_CRYPTO capabi

[dpdk-dev] [PATCH v5 0/8] Introduce CPU crypto mode

2020-01-28 Thread Marcin Smoczynski
Originally both SW and HW crypto PMDs use rte_crypot_op based API to process the crypto workload asynchronously. This way provides uniformity to both PMD types, but also introduce unnecessary performance penalty to SW PMDs that have to "simulate" HW async behavior (crypto-ops enqueue/dequeue, HW ad

Re: [dpdk-dev] [PATCH] Documentation errata:RCU_lib.rst and Ring fig 6.10 corrected

2020-01-28 Thread Ferruh Yigit
On 1/28/2020 2:38 AM, pratee...@cse.iitb.ac.in wrote: > From: PRATEEK AGARWAL > > --- > .../prog_guide/img/ring-mp-enqueue3.png | Bin 0 -> 52346 bytes > .../prog_guide/img/ring-mp-enqueue3.svg | 785 -- > doc/guides/prog_guide/rcu_lib.rst | 2 +- > 3 fi

Re: [dpdk-dev] [PATCH] bpf: properly install headers in meson build

2020-01-28 Thread Bruce Richardson
On Mon, Jan 27, 2020 at 02:38:00PM -0700, Junxiao Shi wrote: > Previously, when librte_bpf is built with meson+ninja, its > headers such as bpf_def is not installed to the system. > This commit fixes this problem. > > Fixes: 94972f3 ("bpf: add BPF loading and execution framework") > > Signed-off-

[dpdk-dev] [PATCH v3] net/i40e: fix i40e flow director merge

2020-01-28 Thread Bernard Iremonger
Merge of ESP and L2TP code in i40e_fdir.c added checks on cus_pctype->index which caused flow creation for ESP to fail. Added fill_ipv4_function() Refactored code to have one path for customized and non customized pctype's. Fixes: c5f8365bc85d ("net/i40e: support flow director for L2TPv3 over IP"

[dpdk-dev] [PATCH] doc: thunderx: explain which PCI is secondary VF

2020-01-28 Thread kkanas
From: Krzysztof Kanas Thunderx-nic uses secondary VF's to provide more queues to DPDK. Current instructions explain the concept but don't show easy way to find which PCI id is primary and which is secondary VF's. Signed-off-by: Krzysztof Kanas --- doc/guides/nics/thunderx.rst | 48

Re: [dpdk-dev] [PATCH v2 00/12] add eventmode to ipsec-secgw

2020-01-28 Thread Ananyev, Konstantin
> > Hi Akhil, Konstantin, > > Do you have any further comments? Will try to have a proper look today/tomorrow. Sorry for delay. Konstantin > > Thanks, > Anoob > > > -Original Message- > > From: dev On Behalf Of Anoob Joseph > > Sent: Monday, January 20, 2020 7:15 PM > > To: Akhil G

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: update Rx offload after setting MTU sccessfully

2020-01-28 Thread Ferruh Yigit
On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > Currently, Rx offload capabilities and max_rx_pkt_len in the struct > variable named rte_port are not updated after setting mtu successfully > in port_mtu_set function by 'port config mtu ' command. > This may lead to re

Re: [dpdk-dev] [PATCH] net/octeontx2: disable HIGIG on port stop

2020-01-28 Thread Jerin Jacob
On Fri, Jan 24, 2020 at 7:25 PM wrote: > > From: Kiran Kumar K > > If HIGIG mode is enabled on configure, This needs to be disabled > on port stop. Adding support to send mbox message on port stop > to configure the port to default. > > Signed-off-by: Kiran Kumar K Acked-by: Jerin Jacob Applie

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: fix the initial value when setting PFC

2020-01-28 Thread Ferruh Yigit
On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > Currently, the initial values of the local structure variable named > rx_tx_onoff_2_lfc_mode and rx_tx_onoff_2_pfc_mode are different in the > similar part of these two following functions: > cmd_link_flow_ctrl_set_

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: fix uninitialized members when setting PFC

2020-01-28 Thread Ferruh Yigit
On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > Only a part of members in the local structure variable named pfc_conf are > initialized in the function named cmd_priority_flow_ctrl_set_parsed when > typing "set pfc_ctrl..." command, and others are random values. Howeve

Re: [dpdk-dev] [PATCH v2] net/octeontx2: extend RSS supported offload types

2020-01-28 Thread Jerin Jacob
On Fri, Jan 24, 2020 at 9:16 AM wrote: > > From: Kiran Kumar K > > Extend RSS offload types for octeontx2. Add support to select > L3 SRC, L3 DST, L4 SRC and L4 DST for RSS calculation. > > Add support to select L3 SRC or DST only, L4 SRC or DST only for RSS > calculation. > > With this requireme

[dpdk-dev] [PATCH] Documentation errata:RCU_lib.rst and Ring fig 6.10 corrected

2020-01-28 Thread prateekag
From: PRATEEK AGARWAL --- .../prog_guide/img/ring-mp-enqueue3.png | Bin 0 -> 52346 bytes .../prog_guide/img/ring-mp-enqueue3.svg | 785 -- doc/guides/prog_guide/rcu_lib.rst | 2 +- 3 files changed, 1 insertion(+), 786 deletions(-) create mode 100644 do

Re: [dpdk-dev] [PATCH v4 4/8] security: add cpu crypto action type

2020-01-28 Thread Ananyev, Konstantin
> Introduce CPU crypto action type allowing to differentiate between > regular async 'none security' and synchronous, CPU crypto accelerated > sessions. > > Signed-off-by: Marcin Smoczynski > --- > lib/librte_security/rte_security.h | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) >

Re: [dpdk-dev] [PATCH v4 3/8] test/crypto: add CPU crypto tests

2020-01-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev On Behalf Of De Lara Guarch, Pablo > Sent: Tuesday, January 28, 2020 9:31 AM > To: Smoczynski, MarcinX ; > akhil.go...@nxp.com; Ananyev, Konstantin ; > Zhang, Roy Fan ; Doherty, Declan > ; Nicolau, Radu > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH v4 2/8] crypto/aesni_gcm: cpu crypto support

2020-01-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: Smoczynski, MarcinX > Sent: Tuesday, January 28, 2020 3:17 AM > To: akhil.go...@nxp.com; Ananyev, Konstantin > ; Zhang, Roy Fan ; > Doherty, Declan ; Nicolau, Radu > ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v4 2/8

[dpdk-dev] [PATCH v2 25/25] common/mlx5: support ROCE disable through Netlink

2020-01-28 Thread Matan Azrad
Add new 4 Netlink commands to support enable/disable ROCE: 1. mlx5_nl_devlink_family_id_get to get the Devlink family ID of Netlink general command. 2. mlx5_nl_enable_roce_get to get the ROCE current status. 3. mlx5_nl_driver_reload - to reload the device kernel d

[dpdk-dev] [PATCH v2 23/25] net/mlx5: reduce Netlink commands dependencies

2020-01-28 Thread Matan Azrad
As an arrangment for Netlink command moving to the common library, reduce the net/mlx5 dependencies. Replace ethdev class command parameters. Improve Netlink sequence number mechanism to be controlled by the mlx5 Netlink mechanism. Move mlx5_nl_check_switch_info to mlx5_nl.c since it is the only

[dpdk-dev] [PATCH v2 24/25] common/mlx5: share Netlink commands

2020-01-28 Thread Matan Azrad
Move Netlink mechanism and its dependencies from net/mlx5 to common/mlx5 in order to be ready to use by other mlx5 drivers. The dependencies are BITFIELD defines, the ppc64 compilation workaround for bool type and the function mlx5_translate_port_name. Update build mechanism accordingly. Signed-

[dpdk-dev] [PATCH v2 22/25] net/mlx5: separate Netlink command interface

2020-01-28 Thread Matan Azrad
The Netlink commands interfaces is included in the mlx5.h file with a lot of other PMD interfaces. As an arrangement to make the Netlink commands shared with different PMDs, this patch moves the Netlink interface to a new file called mlx5_nl.h. Move non Netlink pure vlan commands from mlx5_nl.c t

[dpdk-dev] [PATCH v2 20/25] common/mlx5: get DevX capability for max RQT size

2020-01-28 Thread Matan Azrad
In order to allow RQT size configuration which is limited to the correct maximum value, add log_max_rqt_size for DevX capability structure. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 fi

[dpdk-dev] [PATCH v2 17/25] common/mlx5: allow type configuration for DevX RQT

2020-01-28 Thread Matan Azrad
Allow virtio queue type configuration in the RQ table. The needed fields and configuration was added. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/common/mlx5/mlx5_prm.h | 5 ++

[dpdk-dev] [PATCH v2 19/25] common/mlx5: add DevX command to modify RQT

2020-01-28 Thread Matan Azrad
RQ table can be changed to support different list of queues. Add DevX command to modify DevX RQT object to point on new RQ list. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c| 47 + drivers/common/mlx5/mlx

[dpdk-dev] [PATCH v2 21/25] net/mlx5: select driver by vDPA device argument

2020-01-28 Thread Matan Azrad
There might be a case that one Mellanox device can be probed by multiple mlx5 drivers. One case is that any mlx5 vDPA device can be probed by bothe net/mlx5 and vdpa/mlx5. Add a new mlx5 common API to get the requested driver by devargs: vdpa=1. Skip net/mlx5 PMD probing while the device is sele

[dpdk-dev] [PATCH v2 16/25] common/mlx5: add support for DevX QP operations

2020-01-28 Thread Matan Azrad
QP creation is needed for vDPA virtq support. Add 2 DevX commands to create QP and to modify QP state. The support is for RC QP only in force loopback address mode. By this way, the packets can be sent to other inernal destinations in the nic. For example: other QPs or virtqs. Signed-off-by: Ma

[dpdk-dev] [PATCH v2 14/25] common/mlx5: glue VAR allocation

2020-01-28 Thread Matan Azrad
Virtio access region(VAR) is the UAR that allocated for virtio emulation access. Add rdma-core operations to allocate and free VAR. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/Makefile| 5 + drivers/common/mlx5/meson.build | 1 + drivers/common/m

[dpdk-dev] [PATCH v2 18/25] common/mlx5: add TIR field constants

2020-01-28 Thread Matan Azrad
The DevX TIR object configuration should get L3 and L4 protocols expected to be forwarded by the TIR. Add the PRM constant values needed to configure the L3 and L4 protocols. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_prm.h | 10 ++ 1 file ch

[dpdk-dev] [PATCH v2 15/25] common/mlx5: add DevX virtq commands

2020-01-28 Thread Matan Azrad
Virtio emulation offload allows SW to offload the I/O operations of a virtio virtqueue, using the device, allowing an improved performance for its users. While supplying all the relevant Virtqueue information (type, size, memory location, doorbell information, etc.). The device can then offload the

  1   2   >