Re: [dpdk-dev] [PATCH] app/eventdev: fix test pipeline meson build

2020-02-14 Thread Jerin Jacob
On Mon, Feb 3, 2020 at 10:23 AM wrote: > > From: Pavan Nikhilesh > > Add missing pipeline test to meson build. > > Fixes: 2ff67267b049 ("app/eventdev: build with meson") Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob Applied to dpdk-next-eventdev/master. Thanks.

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: extend inline session to non AES-GCM

2020-02-14 Thread Anoob Joseph
> This patch extends creation of inline session to all the algorithms. > Previously the inline session was enabled only for AES-GCM cipher. > > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline > crypto") > > Signed-off-by: Ankur Dwivedi > --- > examples/ipsec-secgw/sa.c

Re: [dpdk-dev] [PATCH] doc: fix service core mask used in l3fwd example

2020-02-14 Thread Jerin Jacob
On Fri, Feb 7, 2020 at 11:04 AM wrote: > > From: Pavan Nikhilesh > > Service core mask should be a hexadecimal value rather than a range of > lcores. > > Bugzilla ID: 392 > Fixes: 55499896d91a ("doc: add event mode to l3fwd guide") > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-eventde

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: fix return value handling from API

2020-02-14 Thread Jerin Jacob
On Mon, Feb 3, 2020 at 10:44 AM Pavan Nikhilesh Bhagavatula wrote: > > >Subject: [PATCH] examples/l2fwd-event: fix return value handling from > >API > > > >Patch fixes coverity issues which handles return values from API > >calling. > > > >Coverity issue: 350588 > >Coverity issue: 350594 > >Coveri

Re: [dpdk-dev] [PATCH] event/dpaa2: set number of order sequeuences

2020-02-14 Thread Jerin Jacob
On Thu, Feb 13, 2020 at 3:44 PM Nipun Gupta wrote: > > Hi Jerin, > > This patch (bug fix) is required for RC3. > Do you have any comments/concerns on this? No. Applied to dpdk-next-eventdev/master. Thanks. > Thanks, > Nipun > > > -Original Message- > > From: Hemant Agrawal > > Sent:

Re: [dpdk-dev] [PATCH] event/octeontx2: remove WFE from dualslot dequeue

2020-02-14 Thread Gavin Hu
Hi Pavan, > -Original Message- > From: pbhagavat...@marvell.com > Sent: Friday, February 14, 2020 2:45 PM > To: jer...@marvell.com; Pavan Nikhilesh > Cc: Gavin Hu ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] event/octeontx2: remove WFE from dualslot > dequeue > > From: Pavan Nikhilesh

Re: [dpdk-dev] [PATCH 3/7] vfio/pci: Introduce VF token

2020-02-14 Thread Alex Williamson
On Thu, 13 Feb 2020 19:35:16 +0100 Cornelia Huck wrote: > On Thu, 13 Feb 2020 10:23:21 -0700 > Alex Williamson wrote: > > > On Thu, 13 Feb 2020 12:46:54 +0100 > > Cornelia Huck wrote: > > > > > On Tue, 11 Feb 2020 16:05:42 -0700 > > > Alex Williamson wrote: > > > > > > > If we enable

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-14 Thread Bruce Richardson
On Fri, Feb 14, 2020 at 03:48:48PM -0500, Neil Horman wrote: > On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote: > > On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: > > > On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote: > > > > > > > > > > > > On 05/02/20

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-14 Thread Neil Horman
On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote: > On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: > > On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote: > > > > > > > > > On 05/02/2020 11:32, Neil Horman wrote: > > > > On Wed, Feb 05, 2020 at 11:04:29AM +

[dpdk-dev] L3fwd-power queue utilization issue

2020-02-14 Thread Soumen Chandra Laha
Hi, I'm trying to run l3fwd-power application for 2 Port with queue. Always only queue 1 of port 0 and port 1 are utilized. CPU C-state, hpet are enabled, ports are binded to igb_uio. Tried with NIC's x772 (10 GbE) and XXV710(25 GbE), Observed same behavior. I am observing the below output: */ro

Re: [dpdk-dev] [EXT] RE: [PATCH 2/2] examples/ip_pipeline: fix to use sock id instead of cpuid

2020-02-14 Thread Jun Yang
Hi Cristian, Per my debug log, the CPU ID is actually DPDK current core ID on NXP ARM64 platform whose socket ID is always 0. -Original Message- From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] Sent: Friday, February 14, 2020 7:27 PM To: Hemant Agrawal ; dev@dpdk.org Cc:

Re: [dpdk-dev] [PATCH v2] lib: fix unnecessary double negation

2020-02-14 Thread David Marchand
On Fri, Feb 14, 2020 at 5:28 PM Ciara Power wrote: > > An equality expression already returns either 0 or 1. > There is no need to use double negation for these cases. > > Fixes: ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure") > Fixes: a0fd91cefcc0 ("mempool: rename functions with confusin

Re: [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services

2020-02-14 Thread Kevin Traynor
On 07/02/2020 14:27, Aaron Conole wrote: > Kevin Traynor writes: > >> On 20/12/2019 14:43, David Marchand wrote: >>> On Wed, Dec 4, 2019 at 9:34 AM David Marchand >>> wrote: On Wed, Dec 4, 2019 at 9:33 AM David Marchand wrote: > > On Tue, Dec 3, 2019 at 10:15 PM Aaron C

[dpdk-dev] [PATCH v2] lib: fix unnecessary double negation

2020-02-14 Thread Ciara Power
An equality expression already returns either 0 or 1. There is no need to use double negation for these cases. Fixes: ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure") Fixes: a0fd91cefcc0 ("mempool: rename functions with confusing names") Cc: olivier.m...@6wind.com Cc: bruce.richard...@intel

Re: [dpdk-dev] [PATCH] lpm6: add const to IPv6 addresses

2020-02-14 Thread Andrzej Ostruszka
On 2/14/20 4:47 PM, Stephen Hemminger wrote: > On Fri, 14 Feb 2020 15:37:59 +0100 > Andrzej Ostruszka wrote: > >> LPM6 does not modify input IPv6 addresses so mark them as 'const'. >> >> The real need is to add those annotations to the API but in addition >> they were added also to internal funct

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] crypto/ccp: enable IOMMU for CCP

2020-02-14 Thread Thomas Monjalon
12/02/2020 14:50, Akhil Goyal: > > Acked-by: Ravi Kumar > > > Applied to dpdk-next-crypto > Removed stable tag as it is a feature not a fix. Sorry I must drop this patch because it does not compile on i686. Note: it is too late in the cycle to add such a feature.

Re: [dpdk-dev] [PATCH] lpm6: add const to IPv6 addresses

2020-02-14 Thread Stephen Hemminger
On Fri, 14 Feb 2020 15:37:59 +0100 Andrzej Ostruszka wrote: > LPM6 does not modify input IPv6 addresses so mark them as 'const'. > > The real need is to add those annotations to the API but in addition > they were added also to internal functions and slight formatting changes > were performed (a

Re: [dpdk-dev] [PATCH v8 1/1] fbarray: fix duplicated fbarray file in secondary

2020-02-14 Thread Thomas Monjalon
14/02/2020 16:08, David Marchand: > On Fri, Feb 14, 2020 at 8:46 AM Yasufumi Ogawa wrote: > > > > Hi, > > > > Could I confirm that this patch is going to be merged in 20.02? > > Sorry, but I can't take this patch in 20.02. > It breaks compilation on FreeBSD. > http://mails.dpdk.org/archives/test-

Re: [dpdk-dev] [PATCH 0/7] vfio/pci: SR-IOV support

2020-02-14 Thread Alex Williamson
On Fri, 14 Feb 2020 15:57:04 +1100 Alexey Kardashevskiy wrote: > On 12/02/2020 10:05, Alex Williamson wrote: > > Given the mostly positive feedback from the RFC[1], here's a new > > non-RFC revision. Changes since RFC: > > > > - vfio_device_ops.match semantics refined > > - Use helpers for st

Re: [dpdk-dev] [PATCH v8 1/1] fbarray: fix duplicated fbarray file in secondary

2020-02-14 Thread David Marchand
On Fri, Feb 14, 2020 at 8:46 AM Yasufumi Ogawa wrote: > > Hi, > > Could I confirm that this patch is going to be merged in 20.02? Sorry, but I can't take this patch in 20.02. It breaks compilation on FreeBSD. http://mails.dpdk.org/archives/test-report/2019-November/109435.html I am still unconv

[dpdk-dev] [PATCH] lpm6: add const to IPv6 addresses

2020-02-14 Thread Andrzej Ostruszka
LPM6 does not modify input IPv6 addresses so mark them as 'const'. The real need is to add those annotations to the API but in addition they were added also to internal functions and slight formatting changes were performed (aligning of input args). Signed-off-by: Andrzej Ostruszka --- lib/libr

Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le

2020-02-14 Thread David Marchand
On Fri, Feb 14, 2020 at 12:22 AM dwilder wrote: > > On 2020-02-13 14:17, Thomas Monjalon wrote: > > 13/02/2020 21:58, dwilder: > >> On 2020-02-13 12:32, Thomas Monjalon wrote: > >> > 13/02/2020 21:24, David Wilder: > >> >> - The --no-huge option requires iova-mode=VA. > >> >> On ppc64le iova-mod

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix typo

2020-02-14 Thread David Marchand
On Fri, Feb 14, 2020 at 12:41 PM Fan Zhang wrote: > > This patch fixes the cipher len keyword typo. > > Fixes: 07f5e4553293 ("examples/fips_validation: fix cipher length for > AES-GCM") > Suggested-by: Akhil Goyal > Signed-off-by: Fan Zhang Acked-by: David Marchand Applied, thanks. -- D

Re: [dpdk-dev] [PATCH 0/2] l3fwd-power fixes

2020-02-14 Thread David Marchand
On Mon, Jan 20, 2020 at 4:12 PM Xiao Wang wrote: > > The second patch will apply failed without the first patch applied, so make > them a series. The first patch is just a typo fix. The second patch fixes > the issue that the interrupts are turned off only on the Rx queues that > has traffic arriv

Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg

2020-02-14 Thread Maxime Coquelin
Hi Ivan, On 2/14/20 8:59 AM, Ivan Dyukov wrote: > Hi Maxime, > > 13.02.2020 16:54, Maxime Coquelin пишет: >> Hi Ivan, >> >> On 2/12/20 11:40 AM, Maxime Coquelin wrote: >>> On 2/12/20 11:35 AM, Tiwei Bie wrote: On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote: > Some applicatio

[dpdk-dev] [PATCH] examples/fips_validation: fix typo

2020-02-14 Thread Fan Zhang
This patch fixes the cipher len keyword typo. Fixes: 07f5e4553293 ("examples/fips_validation: fix cipher length for AES-GCM") Cc: ssaranan...@marvell.com Signed-off-by: Fan Zhang --- examples/fips_validation/fips_validation_gcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-14 Thread Bruce Richardson
On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: > On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote: > > > > > > On 05/02/2020 11:32, Neil Horman wrote: > > > On Wed, Feb 05, 2020 at 11:04:29AM +0100, Luca Boccassi wrote: > > >> On Tue, 2020-02-04 at 07:02 -0500, Neil Horm

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] kni: fix not contiguous FIFO

2020-02-14 Thread David Marchand
On Fri, Feb 14, 2020 at 11:01 AM Ferruh Yigit wrote: > > From: Scott Wasson > > KNI requires FIFO to be physically contiguous, with existing > 'rte_memzone_reserve()' API this is not guaranteed by default and as a > result KNI rings and packet delivery may be broken if reserved memory > is not ph

Re: [dpdk-dev] [PATCH 2/2] examples/ip_pipeline: fix to use sock id instead of cpuid

2020-02-14 Thread Dumitrescu, Cristian
> -Original Message- > From: dev On Behalf Of Hemant Agrawal > Sent: Wednesday, December 11, 2019 5:26 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; sta...@dpdk.org; > Jun Yang > Subject: [dpdk-dev] [PATCH 2/2] examples/ip_pipeline: fix to use sock id > instead of cpuid > > From:

Re: [dpdk-dev] [PATCH 1/2] examples/ip_pipeline: fix crypto queue config

2020-02-14 Thread Dumitrescu, Cristian
> -Original Message- > From: dev On Behalf Of Hemant Agrawal > Sent: Wednesday, December 11, 2019 5:26 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; sta...@dpdk.org; > Jun Yang ; Hemant Agrawal > > Subject: [dpdk-dev] [PATCH 1/2] examples/ip_pipeline: fix crypto queue > config > >

Re: [dpdk-dev] [PATCH 1/2] examples/ip_pipeline: fix crypto queue config

2020-02-14 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Hemant Agrawal > Sent: Wednesday, December 11, 2019 5:26 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; sta...@dpdk.org; > Jun Yang ; Hemant Agrawal > > Subject: [dpdk-dev] [PATCH 1/2] examples/ip_pipeline: fix crypto queue > config > > q

Re: [dpdk-dev] [PATCH 1/2] l3fwd-power: fix a typo

2020-02-14 Thread Hunt, David
On 21/1/2020 3:06 AM, Xiao Wang wrote: Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling switch") Cc: sta...@dpdk.org Signed-off-by: Xiao Wang --- examples/l3fwd-power/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3

Re: [dpdk-dev] [PATCH 1/2] l3fwd-power: fix a typo

2020-02-14 Thread Hunt, David
On 21/1/2020 3:06 AM, Xiao Wang wrote: Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling switch") Cc: sta...@dpdk.org Signed-off-by: Xiao Wang --- examples/l3fwd-power/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3

Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable

2020-02-14 Thread Hunt, David
On 30/1/2020 5:40 PM, Liang, Ma wrote: On 20 Jan 22:06, Xiao Wang wrote: Since all related queues' interrupts are turned on before epoll, we need to turn off all the interrupts after wakeup. This patch fixes the issue of only turning off the interrupted queues. Fixes: b736d64787fc ("examples/

[dpdk-dev] [PATCH v2] kni: fix not contiguous FIFO

2020-02-14 Thread Ferruh Yigit
From: Scott Wasson KNI requires FIFO to be physically contiguous, with existing 'rte_memzone_reserve()' API this is not guaranteed by default and as a result KNI rings and packet delivery may be broken if reserved memory is not physically contiguous. Fixing it by providing 'RTE_MEMZONE_IOVA_CONT

Re: [dpdk-dev] [PATCH] doc: add new features and improvements to i40e

2020-02-14 Thread Ye Xiaolong
On 02/14, Jiaqi Min wrote: >Added support for API rte_eth_tx_done_cleanup. >Added support for VF multiple queues interrupt. >Added support for setting the link to specific speed. > >Signed-off-by: Jiaqi Min >--- > doc/guides/rel_notes/release_20_02.rst | 5 - > 1 file changed, 4 insertions(+),

Re: [dpdk-dev] [PATCH] doc: add new features and improvements to ixgbe

2020-02-14 Thread Ye Xiaolong
On 02/14, Jiaqi Min wrote: >Added support for API rte_eth_tx_done_cleanup. >Added support setting VF MAC address by PF driver. >Added support for setting the link to specific speed. > >Signed-off-by: Jiaqi Min >--- > doc/guides/rel_notes/release_20_02.rst | 6 ++ > 1 file changed, 6 insertions(

Re: [dpdk-dev] [PATCH] doc: add new features and improvements to ice

2020-02-14 Thread Ye Xiaolong
On 02/14, Jiaqi Min wrote: >Added support for API rte_eth_tx_done_cleanup. > >Signed-off-by: Jiaqi Min >--- > doc/guides/rel_notes/release_20_02.rst | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/doc/guides/rel_notes/release_20_02.rst >b/doc/guides/rel_notes/release_20_02.rst >index 786f9

Re: [dpdk-dev] [PATCH v1] net/ice: resolve unchecked return value

2020-02-14 Thread Ye Xiaolong
On 02/12, Sunil Pai G wrote: >This checks the return value of the function ice_xmit_cleanup > >Coverity issue: 353623 >Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") >Cc: wenzhuo...@intel.com Cc: sta...@dpdk.org > >Signed-off-by: Sunil Pai G >--- > drivers/net/ice/ice_rxtx.c | 2 +- > 1 fil

Re: [dpdk-dev] [PATCH v2] net/i40e: fix unchecked return value

2020-02-14 Thread Ye Xiaolong
On 02/12, Beilei Xing wrote: >This patch fixes unchecked return value >of the i40e_xmit_cleanup function. > >Coverity issue: 353617 >Fixes: 4861cde46116 ("i40e: new poll mode driver") > >Signed-off-by: Beilei Xing >--- >V2 change: > - Use cast. > > drivers/net/i40e/i40e_rxtx.c | 2 +- > 1 file chan

Re: [dpdk-dev] [PATCH v2] eal: fix to set the rte_device ptr's device args before hotplug

2020-02-14 Thread Gaetan Rivet
On 14/02/2020 07:43, Somnath Kotur wrote: As per the comments in this code section, since there is a matching device, it is now its responsibility to manage the devargs we've just inserted. But the matching device ptr's devargs is still uninitialized or not pointing to the newest dev_args that we

Re: [dpdk-dev] [PATCH v4] net/i40e: relaxed barrier in the tx fastpath

2020-02-14 Thread Gavin Hu
Hi Jerin, Could you help review this patch? We discussed a lot on this topic and I think we agreed already to relax the barrier only on the fast path. Best Regards, Gavin > -Original Message- > From: Gavin Hu > Sent: Friday, February 14, 2020 3:58 PM > To: Gavin Hu > Subject: Re: [d