[dpdk-dev] [PATCH] net/octeontx: meson build fix if octeontx drivers are disabled

2020-02-16 Thread agupta3
From: Amit Gupta Add a condition to check if octeontx drivers are disabled. octeontx drivers are built only if dependent drivers i.e. ethdev, mempool and common/octeontx are enabled. BugZilla ID # BUG 387 Signed-off-by: Amit Gupta --- drivers/net/octeontx/base/meson.build | 32 +++

[dpdk-dev] [PATCH] net/octeontx: meson build fix if octeontx drivers are disabled

2020-02-16 Thread agupta3
From: Amit Gupta Add a condition to check if octeontx drivers are disabled. octeontx drivers are built only if dependent drivers i.e. ethdev, mempool and common/octeontx are enabled. BugZilla ID # BUG 387 Change-Id: Idf9578fc04345e690ac48b4836faff2e25170331 Signed-off-by: Amit Gupta --- drive

Re: [dpdk-dev] [RFC PATCH 0/5] graph: introduce graph subsystem

2020-02-16 Thread Jerin Jacob
I got initial comments from Ray and Stephen on this RFC[1]. Thanks for the comments. Is anyone else planning to have an architecture level or API usage level review or any review of other top-level aspects? I believe low-level aspects of the code can be taken care of from the v1 series onwards. I

Re: [dpdk-dev] [PATCH 6/6] doc: guide for Windows build using MinGW-w64

2020-02-16 Thread Dmitry Kozlyuk
> Remembered another issue: thread-local storage (TLS) with shared libraries. > Windows PE doesn't support TLS via special sections, so compilers use TLS > emulation layer. With static libraries, there are no issues described below. > > The first aspect is a build-time issue of MinGW. When linking

Re: [dpdk-dev] [PATCH v5] doc: introduce openwrt how-to guide

2020-02-16 Thread Ye Xiaolong
On 02/17, Dmitry Kozlyuk wrote: >> On 02/16, Thomas Monjalon wrote: >> >16/02/2020 18:29, Ye Xiaolong: >> >> On 02/16, Thomas Monjalon wrote: >> >> >18/01/2020 06:48, Xiaolong Ye: >> >> >[...] >> >> >> +[binaries] >> >> >> +c = 'x86_64-openwrt-linux-gcc' >> >> >> +cpp = 'x86_64-op

[dpdk-dev] [PATCH] net/i40e: fix multiple interrupt for VF

2020-02-16 Thread Shougang Wang
Interrupt mapping should be 1:n queue(s).This patch fixes the logic of interrupt bind by code reconstruction. Fixes: 6a6cf5f88b4a ("net/i40e: enable multi-queue Rx interrupt for VF") Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_ethdev_vf.c | 63 --- 1 file

Re: [dpdk-dev] [PATCH v5] doc: introduce openwrt how-to guide

2020-02-16 Thread Dmitry Kozlyuk
> On 02/16, Thomas Monjalon wrote: > >16/02/2020 18:29, Ye Xiaolong: > >> On 02/16, Thomas Monjalon wrote: > >> >18/01/2020 06:48, Xiaolong Ye: > >> >[...] > >> >> +[binaries] > >> >> +c = 'x86_64-openwrt-linux-gcc' > >> >> +cpp = 'x86_64-openwrt-linux-cpp' > >> >> +ar = 'x86_

[dpdk-dev] [PATCH v6] doc: introduce openwrt how-to guide

2020-02-16 Thread Xiaolong Ye
This doc describes how to enable DPDK on Openwrt in both virtual and physical x86 environment. Signed-off-by: Xiaolong Ye Acked-by: John McNamara --- V6 changes: 1. addressed review comments raised by Thomas V5 changes: 1. improve the doc's grammar and wording according to John's suggestions

[dpdk-dev] [PATCH] eal/windows: fix out-of-memory check

2020-02-16 Thread Dmitry Kozlyuk
Check vsnprintf() result to prevent calling malloc() with negative size. Check actual malloc() result and terminate asprintf() with documented error code to prevent the use of NULL pointer. Fixes: e8428a9d8 ("eal/windows: add some basic functions and macros") Signed-off-by: Dmitry Kozlyuk --- l

Re: [dpdk-dev] [PATCH v2] examples/tep_term: fix return value check

2020-02-16 Thread Li, Xiaoyun
Hi > -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, February 13, 2020 22:57 > To: Li, Xiaoyun > Cc: Ye, Xiaolong ; Kovacevic, Marko > ; dev ; dpdk stable > > Subject: Re: [dpdk-dev] [PATCH v2] examples/tep_term: fix return value check > >

[dpdk-dev] [PATCH v3] examples/tep_term: remove redundant info get

2020-02-16 Thread Xiaoyun Li
Removed redundant function call of 'rte_eth_dev_info_get()' since it has already been called earlier. Coverity issue: 349922 Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- examples/tep_termination/vxlan_setup.c | 2 --

Re: [dpdk-dev] [PATCH v5] doc: introduce openwrt how-to guide

2020-02-16 Thread Ye Xiaolong
On 02/16, Thomas Monjalon wrote: >16/02/2020 18:29, Ye Xiaolong: >> On 02/16, Thomas Monjalon wrote: >> >18/01/2020 06:48, Xiaolong Ye: >> >[...] >> >> +[binaries] >> >> +c = 'x86_64-openwrt-linux-gcc' >> >> +cpp = 'x86_64-openwrt-linux-cpp' >> >> +ar = 'x86_64-openwrt-linux-ar' >>

Re: [dpdk-dev] Windows Draft Build

2020-02-16 Thread Dmitry Kozlyuk
Hi, > "Dpdk.sln" builds OK, will try launching sample apps > a bit later. Netuio driver consistently fails to install on Windows 10 in QEMU with virtio-net (modern interface). Described below is my attempt to install the driver from clean "windpdk-v18.08-clang" branch of "dpdk-draft-windows" repo

[dpdk-dev] Bug Report

2020-02-16 Thread 980680431
static int test_timer_perf(void) {        .        .        .        rte_timer_stop(&tms[0]);    rte_free(tms); return 0; } REGISTER_TEST_COMMAND(timer_perf_autotest, test_timer_perf);

[dpdk-dev] [dpdk-announce] release candidate 20.02-rc3

2020-02-16 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v20.02-rc3 121 patches were integrated. The release notes so far: http://doc.dpdk.org/guides/rel_notes/release_20_02.html Some deprecation notices might be added if reviewed on time. The -rc4 will

Re: [dpdk-dev] [PATCH v2] usertools: fix telemetry python3 compatibility

2020-02-16 Thread Thomas Monjalon
24/01/2020 11:11, Laatz, Kevin: > > The client script for use with the telemetry library did not support > > Python3, as the data being sent over the socket was in string format. > > Python3 requires the data be explicitly converted to bytes before being > > sent. Similarily, the received bytes nee

Re: [dpdk-dev] [dpdk-stable] [PATCH] usertools: fix syntax warning in python 3.8

2020-02-16 Thread Thomas Monjalon
12/02/2020 13:31, Thomas Faivre: > Silent the following warning when running script with python 3.8: > > > /usr/bin/dpdk-pmdinfo:542: SyntaxWarning: "is" with a literal. > > Did you mean "=="? > > if (autoload_path is None or autoload_path is ""): > > As autoload_path can only be None or a stri

Re: [dpdk-dev] [PATCH v2] mempool/octeontx2: optimize for L1D cache architecture

2020-02-16 Thread Thomas Monjalon
01/02/2020 12:51, Jerin Jacob: > On Fri, Jan 31, 2020 at 10:53 PM wrote: > > > > From: Pavan Nikhilesh > > > > OCTEON TX2 has 8 sets, 41 ways L1D cache, VA<9:7> bits dictate > > the set selection. > > Add additional padding to ensure that the element size always > > occupies odd number of cacheli

Re: [dpdk-dev] [PATCH] Documentation errata:RCU_lib.rst and Ring fig 6.10 corrected

2020-02-16 Thread Thomas Monjalon
03/02/2020 05:56, pratee...@cse.iitb.ac.in: > From: prateekagarwal88 > > Signed-off-by: prateekagarwal88 Sorry if the process is a bit hard. There are 3 requirements for this patch: - please use your real name (Prateek Agarwal) - please add a description of the change -

Re: [dpdk-dev] [PATCH 0/5] l3fwd and lpm cleanups

2020-02-16 Thread Thomas Monjalon
26/01/2020 02:09, Stephen Hemminger: > While working on l3fwd, saw some minor things that should be cleaned up. > > Stephen Hemminger (5): > lpm: make ipv6 address immutable > examples/l3fwd: use RTE_DIM > examples/l3fwd: make lookup struct static > examples/l3fwd: make route array constan

Re: [dpdk-dev] [PATCH] app/test-fib: add test-fib application

2020-02-16 Thread Thomas Monjalon
11/12/2019 19:45, Vladimir Medvedkin: > Introduce new application to provide user to evaluate and perform > custom functional and performance tests for FIB library. > > Signed-off-by: Vladimir Medvedkin > --- > app/test-fib/Makefile| 21 + > app/test-fib/main.c | 1262 > +

Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled

2020-02-16 Thread Thomas Monjalon
20/01/2020 18:36, Bruce Richardson: > On Mon, Dec 23, 2019 at 06:53:05AM +, Reshma Pattan wrote: > > Some unit tests has dependency on RING PMD, > > so this patch is trying to fix those and other > > closely related issues. > > > > 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adap

Re: [dpdk-dev] [PATCH v5] doc: introduce openwrt how-to guide

2020-02-16 Thread Thomas Monjalon
16/02/2020 18:29, Ye Xiaolong: > On 02/16, Thomas Monjalon wrote: > >18/01/2020 06:48, Xiaolong Ye: > >[...] > >> +[binaries] > >> +c = 'x86_64-openwrt-linux-gcc' > >> +cpp = 'x86_64-openwrt-linux-cpp' > >> +ar = 'x86_64-openwrt-linux-ar' > >> +strip = 'x86_64-openwrt-linux-stri

Re: [dpdk-dev] [PATCH v4] net/i40e: relaxed barrier in the tx fastpath

2020-02-16 Thread Thomas Monjalon
16/02/2020 17:38, Ye Xiaolong: > Hi, Thomas > > On 02/16, Thomas Monjalon wrote: > >15/02/2020 16:16, Ye Xiaolong: > >> s/relaxed/relax > >> > >> On 02/12, Gavin Hu wrote: > >> >To keep ordering of mixed accesses, rte_cio is sufficient. > >> >The rte_io barrier inside the I40E_PCI_REG_WRITE is ov

Re: [dpdk-dev] [PATCH v5] doc: introduce openwrt how-to guide

2020-02-16 Thread Ye Xiaolong
Hi, Thomas Thanks a lot for your detailed review. On 02/16, Thomas Monjalon wrote: >18/01/2020 06:48, Xiaolong Ye: >> This doc describes how to enable DPDK on Openwrt in both virtual and >> physical x86 environment. >> >> Signed-off-by: Xiaolong Ye >> --- >> --- /dev/null >> +++ b/doc/guides/ho

Re: [dpdk-dev] [PATCH v4] net/i40e: relaxed barrier in the tx fastpath

2020-02-16 Thread Ye Xiaolong
Hi, Thomas On 02/16, Thomas Monjalon wrote: >15/02/2020 16:16, Ye Xiaolong: >> s/relaxed/relax >> >> On 02/12, Gavin Hu wrote: >> >To keep ordering of mixed accesses, rte_cio is sufficient. >> >The rte_io barrier inside the I40E_PCI_REG_WRITE is overkill.[1] >[...] >> >> Applied to dpdk-next-net

Re: [dpdk-dev] [PATCH] net/mlx5: add BlueField-2 device ID

2020-02-16 Thread Gavin Hu
Reviewed-by: Gavin Hu

Re: [dpdk-dev] [PATCH] build: skip processing docs folder if docs disabled

2020-02-16 Thread David Marchand
On Sun, Feb 16, 2020 at 11:07 AM Thomas Monjalon wrote: > > 03/01/2020 15:46, Bruce Richardson: > > While each target is set to be ignored if the docs are disabled in the > > meson build, there is little reason to process the docs folder at all. > > > > Signed-off-by: Bruce Richardson > > --- > >

Re: [dpdk-dev] [PATCH] maintainers: set QoS git tree for some ethdev files

2020-02-16 Thread Thomas Monjalon
23/01/2020 11:04, Dumitrescu, Cristian: > From: Thomas Monjalon > > > > The tree dpdk-next-tm does not exist anymore. > > Traffic management and metering APIs, which are part of ethdev, > > can be merged in the existing tree dpdk-next-qos. > > > > Signed-off-by: Thomas Monjalon > > --- > > ---

Re: [dpdk-dev] [PATCH v1] doc: rework vm power manager user guide

2020-02-16 Thread Thomas Monjalon
07/01/2020 10:13, David Hunt: > Review and re-work of vm_power_manager documentation. Hopefully this > is clearer, easier to follow. > > Signed-off-by: David Hunt checkpatch is reporting a typo done several times: s/virutal/virtual/ > --- > .../img/vm_power_mgr_highlevel.svg

Re: [dpdk-dev] [PATCH v5] doc: introduce openwrt how-to guide

2020-02-16 Thread Thomas Monjalon
18/01/2020 06:48, Xiaolong Ye: > This doc describes how to enable DPDK on Openwrt in both virtual and > physical x86 environment. > > Signed-off-by: Xiaolong Ye > --- > --- /dev/null > +++ b/doc/guides/howto/openwrt.rst > +Enable DPDK on openwrt > +== > + > +This document desc

Re: [dpdk-dev] [PATCH v8] doc: add meson ut info in prog guide

2020-02-16 Thread Thomas Monjalon
12/08/2019 14:40, Jananee Parthasarathy: > From: Hari Kumar Vemula > > Add a programmer's guide section for meson ut > > Signed-off-by: Hari Kumar Vemula > Acked-by: Bruce Richardson > Acked-by: Michael Santana The last part about enabling some skipped test case is not correct. Because this

Re: [dpdk-dev] [PATCH] build: skip processing docs folder if docs disabled

2020-02-16 Thread Thomas Monjalon
03/01/2020 15:46, Bruce Richardson: > While each target is set to be ignored if the docs are disabled in the > meson build, there is little reason to process the docs folder at all. > > Signed-off-by: Bruce Richardson > --- > +if not get_option('enable_docs') > + subdir_done() > +endif Why t

Re: [dpdk-dev] [PATCH 0/5] Update docs for installing on FreeBSD

2020-02-16 Thread Thomas Monjalon
03/01/2020 16:32, Bruce Richardson: > Update the FreeBSD GSG guide to cover: > > * installing from package as well as via ports collection > * building and installing manually via meson and ninja > * building examples using the pkg-config file, since both the port/pkg > and building from source

Re: [dpdk-dev] [PATCH v4] net/i40e: relaxed barrier in the tx fastpath

2020-02-16 Thread Thomas Monjalon
15/02/2020 16:16, Ye Xiaolong: > s/relaxed/relax > > On 02/12, Gavin Hu wrote: > >To keep ordering of mixed accesses, rte_cio is sufficient. > >The rte_io barrier inside the I40E_PCI_REG_WRITE is overkill.[1] [...] > > Applied to dpdk-next-net-intel with Jerin's Reviewed-by tag, Thanks. I assume

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix hot-unplug detaching

2020-02-16 Thread Thomas Monjalon
16/02/2020 09:09, Matan Azrad: > Hi Thomas > > Thanks for the patches, I Saw it just now. > please see small comment below: > > From: Thomas Monjalon > > There is a possible race condition in the hotplug path in > > rmv_port_callback(). > > If a port is created between > > close_port(port_id)

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix hot-unplug detaching

2020-02-16 Thread Matan Azrad
Hi Thomas Thanks for the patches, I Saw it just now. please see small comment below: From: Thomas Monjalon > There is a possible race condition in the hotplug path in rmv_port_callback(). > If a port is created between > close_port(port_id) and detach_port_device(port_id), then the port_id will