Re: [dpdk-dev] [PATCH v4 2/4] net/virtio: add link speed devarg

2020-02-25 Thread Ye Xiaolong
On 02/25, Ivan Dyukov wrote: >Some applications like pktgen use link_speed to calculate >transmit rate. It limits outcome traffic to hardcoded 10G. s/transmit/transmission > >This patch adds link_speed devarg which allows to configure s/link_speed, given the fact that you've renamed link_speed d

Re: [dpdk-dev] [PATCH v4 1/4] net/virtio: refactor devargs parsing

2020-02-25 Thread Ye Xiaolong
On 02/25, Ivan Dyukov wrote: >refactor vdpa specific devargs parsing to more generic way > >Signed-off-by: Ivan Dyukov >--- > drivers/net/virtio/virtio_ethdev.c | 35 +- > 1 file changed, 25 insertions(+), 10 deletions(-) > >diff --git a/drivers/net/virtio/virtio_ethdev.

Re: [dpdk-dev] Windows Draft Build

2020-02-25 Thread Dmitry Kozlyuk
Hi Ranjit, > This is a very interesting find. Will this change to a custom class allow the > driver to load in the native (bare-metal) case, too? I don't have a DPDK-compatible hardware NIC right now, so I can't perform a complete test. However, I was able to successfully install netUIO with mul

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning

2020-02-25 Thread Akhil Goyal
> > gcc 10.0.1 reports: > > ../examples/ipsec-secgw/ipsec_process.c: In function ‘ipsec_process’: > ../examples/ipsec-secgw/ipsec_process.c:132:34: > error: ‘grp.m’ may be used uninitialized in this function [-Werror=maybe- > uninitialized] > 132 |grp[n].cnt = pkts + i - grp[n].m; >

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-25 Thread Akhil Goyal
Hi Lukasz, > > > > Is it not possible to use the existing functions for finding routes, > > checking > packet types and checking security policies. > > It will be very difficult to manage two separate functions for same work. I > > can > see that the pkt->data_offs > > Are not required to be upd

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-25 Thread Akhil Goyal
Hi Anoob, > > > > >> +/* Get core ID */ > > > > >> +lcore_id = rte_lcore_id(); > > > > >> + > > > > >> +/* Get socket ID */ > > > > >> +socket_id = rte_lcore_to_socket_id(lcore_id); > > > > >> + > > > > >> +/* Save routing table */ > > > > >> +lconf.rt.rt4_ctx = socket_ctx[

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx

2020-02-25 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ravi Kumar > > >-Original Message- >From: Sebastian, Selwin >Sent: Tuesday, February 25, 2020 6:10 PM >To: dev@dpdk.org >Cc: Kumar, Ravi1 >Subject: [PATCH v1] net/axgbe: add support for Scattered Rx > >From: Selwin Sebasti

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-25 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, February 25, 2020 9:34 PM > To: Anoob Joseph ; Akhil Goyal > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Ankur Dwivedi > ; Archana Muniganti ; > Teja

[dpdk-dev] 答复: [RFC]app/testpmd: time-consuming question of mlockall function execution

2020-02-25 Thread humin (Q)
Hello, David Marchand, Thanks for your quick response. We have another question about your patch. It seems that mlockall() also takes about two seconds after using this patch(about 0.2 seconds before using this patch), if we use "always" option for transparent hugepage configration. Is this r

Re: [dpdk-dev] [PATCH v1] ci: add test suite run without hugepage

2020-02-25 Thread Ruifeng Wang
> -Original Message- > From: Aaron Conole > Sent: Tuesday, February 25, 2020 23:57 > To: Ruifeng Wang > Cc: David Marchand ; Michael Santana > ; Bruce Richardson > ; dev ; Gavin Hu > ; Honnappa Nagarahalli > ; nd > Subject: Re: [PATCH v1] ci: add test suite run without hugepage > > Ru

Re: [dpdk-dev] Question about vhost user interrupt mode

2020-02-25 Thread Tiwei Bie
On Tue, Feb 25, 2020 at 12:44:48PM -0800, Yifeng Sun wrote: > > > > +int rte_vhost_get_kickfd(int vid, uint16_t queue_id) Introducing rte_vhost_get_kickfd() may not help much, we already have rte_vhost_get_vhost_vring() to do that. https://github.com/DPDK/dpdk/blob/d7142fbae16f/drivers/net/vhost/

Re: [dpdk-dev] [PATCH v3] regexdev: introduce regexdev subsystem

2020-02-25 Thread Wang Xiang
Hi Ori and Jerin, One comment regarding my concern with len and end_offset problem. >From open source SW regex library(libpcre, re2 and Hyperscan) and Intel's perspective, the matching results returned are always start offset and end offset. More importantly, Hyperscan only reports end offset mos

Re: [dpdk-dev] [PATCH] maintainers: resign from virtio and vhost

2020-02-25 Thread Tiwei Bie
On Tue, Feb 25, 2020 at 06:51:52PM +0100, Maxime Coquelin wrote: > On 2/21/20 2:28 PM, Tiwei Bie wrote: > > I'm leaving Intel, and I'm not sure when I could dedicate enough > > time to DPDK in the future. So I'm removing my name from the > > MAINTAINERS file. > > > > Signed-off-by: Tiwei Bie > >

[dpdk-dev] [PATCH] devtools: add new SPDX license compliance checker

2020-02-25 Thread Stephen Hemminger
Simple script to look for drivers and scripts that are missing requires SPDX header. Signed-off-by: Stephen Hemminger --- v5 - fix issue in counting warnings update Copyright date MAINTAINERS | 1 + devtools/check-spdx-tag.sh | 73 +++

[dpdk-dev] SPDX status with 20.2

2020-02-25 Thread Stephen Hemminger
Only a few places still need addressing $ ./devtools/check-spdx-tag.sh -v Files without SPDX License -- Files with redundant license text - app/test/test_timer_racecond.c lib/librte_ethdev/rte_ethdev_pci.h lib/librte_ethdev/rte_ethdev_vdev.

Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation

2020-02-25 Thread Stephen Hemminger
On Fri, 7 Feb 2020 15:29:59 +0100 Olivier Matz wrote: > The meaning of each flag should be as simple as possible, I think we can > summarize them like this: > > - PKT_RX_VLAN: the vlan is saved in vlan tci. > - PKT_RX_VLAN_STRIPPED: the vlan hdr is removed from packet data. > - PKT_RX_QINQ: the

Re: [dpdk-dev] Questions about rte_timer APIs

2020-02-25 Thread Honnappa Nagarahalli
Hi Erik, I see that the rte_timer_alt_xxx APIs are still marked as experimental. So, we should be able to change them without any ABI constraints. Please let me know what you think. Thank you, Honnappa > -Original Message- > From: dev On Behalf Of Honnappa Nagarahalli > Sent: T

[dpdk-dev] [Bug 410] KNI deadlocks when used with Mellanox device

2020-02-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=410 Bug ID: 410 Summary: KNI deadlocks when used with Mellanox device Product: DPDK Version: 18.02 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [dpdk-announce] DPDK 20.02 released

2020-02-25 Thread Thomas Monjalon
A new release is available: https://fast.dpdk.org/rel/dpdk-20.02.tar.xz The statistics looks like a post-LTS ABI-compatible release: 820 commits from 156 authors 876 files changed, 59941 insertions(+), 22565 deletions(-) It is not planned (yet) to start a maintenance branc

Re: [dpdk-dev] [PATCH 1/2] lib/timer: protect timer subsystem initialized with lock

2020-02-25 Thread Carrillo, Erik G
> -Original Message- > From: Phil Yang > Sent: Monday, February 24, 2020 12:42 AM > To: rsanf...@akamai.com; Carrillo, Erik G ; > dev@dpdk.org > Cc: david.march...@redhat.com; Burakov, Anatoly > ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nxp.com; honnappa.nagaraha...@arm.c

Re: [dpdk-dev] Question about vhost user interrupt mode

2020-02-25 Thread Yifeng Sun
+ Tiwei and Maxime Thanks, Yifeng On Fri, Feb 21, 2020 at 2:32 PM Yifeng Sun wrote: > > Hi all, > > Right now on OVS, dpdkvhostuser can only run in polling mode (please > correct me if I am wrong). We are trying to enable interrupt mode of > dpdkvhostuser type port on OVS. We found that, with ch

Re: [dpdk-dev] [PATCH v3] devtools: export title syntax data for check-git-log

2020-02-25 Thread Thomas Monjalon
24/02/2020 16:30, Ferruh Yigit: > From: Sean Morrissey > > Moved title syntax to a separate file so that it improves code > readability and allows easy addition. > > Also logic changed from checking for bad pattern to checking good > pattern which documents the expected syntax more clearly, and

[dpdk-dev] [Bug 409] testpmd sometimes does not correctly show RX-missed on Mellanox NICs

2020-02-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=409 Bug ID: 409 Summary: testpmd sometimes does not correctly show RX-missed on Mellanox NICs Product: DPDK Version: 19.11 Hardware: All OS: All Status: UNCO

Re: [dpdk-dev] pci device access from dpdk secondary process with igb_uio

2020-02-25 Thread vijay mohan
Hi Fiona, Thanks for verifying the fix. I will send this patch out for review. Thanks, Vijay On Tue, 25 Feb 2020 at 07:09, Trahe, Fiona wrote: > > Hi Vijay, > > Thanks for debugging. We've recreated your issue and validated that this > fixes it. > Do you want to go ahead and send up a patch or

Re: [dpdk-dev] [PATCH v2] doc: plan splitting the ethdev ops struct

2020-02-25 Thread Ferruh Yigit
On 2/25/2020 6:13 PM, David Marchand wrote: > On Tue, Feb 25, 2020 at 1:44 PM Ferruh Yigit wrote: >> >> For the ABI compatibility it is better to hide internal data structures >> from the application as much as possible. But because of some inline >> functions 'struct eth_dev_ops' can't be hidden

Re: [dpdk-dev] [PATCH v2] doc: plan splitting the ethdev ops struct

2020-02-25 Thread David Marchand
On Tue, Feb 25, 2020 at 1:44 PM Ferruh Yigit wrote: > > For the ABI compatibility it is better to hide internal data structures > from the application as much as possible. But because of some inline > functions 'struct eth_dev_ops' can't be hidden completely. > > Plan is to split the 'struct eth_d

Re: [dpdk-dev] [PATCH] doc: fix VM power manager guide as PDF

2020-02-25 Thread Thomas Monjalon
25/02/2020 19:00, David Marchand: > On Tue, Feb 25, 2020 at 6:58 PM Thomas Monjalon wrote: > > > > When generating PDF with on an old system, > > there are failures because of long tables: > > > > vm_power_management.rst:420: ERROR: Malformed table. > > Column span alignment problem in table line

Re: [dpdk-dev] [PATCH] maintainers: update for virtio and vhost

2020-02-25 Thread Maxime Coquelin
Hi Xiaolong, On 2/21/20 2:35 PM, Xiaolong Ye wrote: > I volunteer to be co-maintainer for Vhost-user/Vhost PMD/Virtio PMD. > Thanks for offering your help, I really appreciate it! Acked-by: Maxime Coquelin Maxime > Signed-off-by: Xiaolong Ye > --- > MAINTAINERS | 3 +++ > 1 file changed, 3

Re: [dpdk-dev] [PATCH] doc: fix VM power manager guide as PDF

2020-02-25 Thread David Marchand
On Tue, Feb 25, 2020 at 6:58 PM Thomas Monjalon wrote: > > When generating PDF with on an old system, > there are failures because of long tables: > > vm_power_management.rst:420: ERROR: Malformed table. > Column span alignment problem in table line 5. > vm_power_management.rst:545: ERROR: Malform

[dpdk-dev] [PATCH] doc: fix VM power manager guide as PDF

2020-02-25 Thread Thomas Monjalon
When generating PDF with on an old system, there are failures because of long tables: vm_power_management.rst:420: ERROR: Malformed table. Column span alignment problem in table line 5. vm_power_management.rst:545: ERROR: Malformed table. Column span alignment problem in table line 5. vm_power_man

Re: [dpdk-dev] [PATCH] doc: alias to experimental tag for stable apis

2020-02-25 Thread David Marchand
On Tue, Feb 25, 2020 at 4:36 PM Neil Horman wrote: > > On Wed, Feb 05, 2020 at 03:17:52PM +, Ray Kinsella wrote: > > When a maintainer is promoting an API to become part of the next major ABI > > version by removing the experimental tag, possibly a few releases in > > advance of > > the decla

Re: [dpdk-dev] [PATCH] maintainers: resign from virtio and vhost

2020-02-25 Thread Maxime Coquelin
On 2/21/20 2:28 PM, Tiwei Bie wrote: > I'm leaving Intel, and I'm not sure when I could dedicate enough > time to DPDK in the future. So I'm removing my name from the > MAINTAINERS file. > > Signed-off-by: Tiwei Bie > --- > Xiaolong has been an active and experienced -next tree maintainer > fo

Re: [dpdk-dev] [PATCH v2] doc: rework vm power manager user guide

2020-02-25 Thread Thomas Monjalon
25/02/2020 17:59, Thomas Monjalon: > 25/02/2020 17:46, Ferruh Yigit: > > On 2/17/2020 10:48 AM, David Hunt wrote: > > > Review and re-work of vm_power_manager documentation. Hopefully this > > > is clearer, easier to follow. > > > > > > Signed-off-by: David Hunt > > <...> > > > > Bernard reporte

Re: [dpdk-dev] [PATCH] doc: add tested Marvell integrated NIC platforms

2020-02-25 Thread David Marchand
On Tue, Feb 25, 2020 at 6:08 PM wrote: > > From: Jerin Jacob > > Add tested Marvell integrated NIC platforms to v20.02 release note. > > Signed-off-by: Jerin Jacob Applied, thanks. -- David Marchand

[dpdk-dev] [PATCH] doc: add tested Marvell integrated NIC platforms

2020-02-25 Thread jerinj
From: Jerin Jacob Add tested Marvell integrated NIC platforms to v20.02 release note. Signed-off-by: Jerin Jacob --- - No critical issue found in QA testing with Marvell integrated NIC platform testing. doc/guides/rel_notes/release_20_02.rst | 16 1 file changed, 16 insert

Re: [dpdk-dev] [PATCH v2] doc: rework vm power manager user guide

2020-02-25 Thread Thomas Monjalon
25/02/2020 17:46, Ferruh Yigit: > On 2/17/2020 10:48 AM, David Hunt wrote: > > Review and re-work of vm_power_manager documentation. Hopefully this > > is clearer, easier to follow. > > > > Signed-off-by: David Hunt > <...> > > Bernard reported following errors [1] in DPDK 20.02-rc4 caused by th

Re: [dpdk-dev] [PATCH v2] doc: rework vm power manager user guide

2020-02-25 Thread Ferruh Yigit
On 2/17/2020 10:48 AM, David Hunt wrote: > Review and re-work of vm_power_manager documentation. Hopefully this > is clearer, easier to follow. > > Signed-off-by: David Hunt > > --- > changes in v2 > * Fixed typos. Typos not found even with checkpatch from kernel 5.5.4, but > when the codespel

Re: [dpdk-dev] [PATCH v2] doc: plan splitting the ethdev ops struct

2020-02-25 Thread Andrew Rybchenko
On 2/25/20 7:13 PM, Ferruh Yigit wrote: > On 2/25/2020 3:51 PM, Andrew Rybchenko wrote: >> On 2/25/20 3:44 PM, Ferruh Yigit wrote: >>> For the ABI compatibility it is better to hide internal data structures >>> from the application as much as possible. But because of some inline >>> functions 'stru

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] devtools: add fixes column to git-log-fixes

2020-02-25 Thread Thomas Monjalon
03/02/2020 16:59, Kevin Traynor: > During backporting, if the fixes or stable tag are missing, > it usually requires some investigation by stable maintainer > as to why. > > The presence of a fixes tag may be known from whether the > originating release of the issue is printed at the end of the >

Re: [dpdk-dev] [PATCH v2] doc: plan splitting the ethdev ops struct

2020-02-25 Thread Ferruh Yigit
On 2/25/2020 3:51 PM, Andrew Rybchenko wrote: > On 2/25/20 3:44 PM, Ferruh Yigit wrote: >> For the ABI compatibility it is better to hide internal data structures >> from the application as much as possible. But because of some inline >> functions 'struct eth_dev_ops' can't be hidden completely. >>

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-25 Thread Ananyev, Konstantin
> > >> Add application inbound/outbound worker thread and IPsec application > > >> processing code for event mode. > > >> > > >> Example ipsec-secgw command in app mode: > > >> ipsec-secgw -w 0002:02:00.0,ipsec_in_max_spi=128 -w > > >> 0002:03:00.0,ipsec_in_max_spi=128 -w 0002:0e:00.0 -w 0002:10:00

Re: [dpdk-dev] [PATCH v1] ci: add test suite run without hugepage

2020-02-25 Thread Aaron Conole
Ruifeng Wang writes: >> -Original Message- >> From: Aaron Conole >> Sent: Tuesday, February 25, 2020 22:36 >> To: David Marchand >> Cc: Ruifeng Wang ; Michael Santana >> ; Bruce Richardson >> ; dev ; Gavin Hu >> ; Honnappa Nagarahalli >> ; nd >> Subject: Re: [PATCH v1] ci: add test sui

Re: [dpdk-dev] [PATCH v2] doc: plan splitting the ethdev ops struct

2020-02-25 Thread Andrew Rybchenko
On 2/25/20 3:44 PM, Ferruh Yigit wrote: > For the ABI compatibility it is better to hide internal data structures > from the application as much as possible. But because of some inline > functions 'struct eth_dev_ops' can't be hidden completely. > > Plan is to split the 'struct eth_dev_ops' into tw

Re: [dpdk-dev] [PATCH] doc: add feature support matrix link for i40e

2020-02-25 Thread Thomas Monjalon
25/02/2020 16:37, Ferruh Yigit: > On 2/25/2020 11:14 AM, Xiaolong Ye wrote: > > There is an increase in number of issues related to supported cables and > > modules, this link and note can help users identify or narrow down the > > issues. > > > > Signed-off-by: Xiaolong Ye > > Acked-by: Ferruh

Re: [dpdk-dev] [PATCH v1] ci: add test suite run without hugepage

2020-02-25 Thread Ruifeng Wang
> -Original Message- > From: Aaron Conole > Sent: Tuesday, February 25, 2020 22:36 > To: David Marchand > Cc: Ruifeng Wang ; Michael Santana > ; Bruce Richardson > ; dev ; Gavin Hu > ; Honnappa Nagarahalli > ; nd > Subject: Re: [PATCH v1] ci: add test suite run without hugepage > > Da

Re: [dpdk-dev] [PATCH] doc: add feature support matrix link for i40e

2020-02-25 Thread Ferruh Yigit
On 2/25/2020 11:14 AM, Xiaolong Ye wrote: > There is an increase in number of issues related to supported cables and > modules, this link and note can help users identify or narrow down the > issues. > > Signed-off-by: Xiaolong Ye Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] doc: remove not supported features from hinic matrix

2020-02-25 Thread Thomas Monjalon
25/02/2020 16:28, Ferruh Yigit: > On 2/24/2020 7:51 PM, Thomas Monjalon wrote: > > Only the supported features are supposed to be listed > > in the networking features matrix. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Ferruh Yigit Applied

Re: [dpdk-dev] [PATCH] doc: alias to experimental tag for stable apis

2020-02-25 Thread Neil Horman
On Wed, Feb 05, 2020 at 03:17:52PM +, Ray Kinsella wrote: > When a maintainer is promoting an API to become part of the next major ABI > version by removing the experimental tag, possibly a few releases in advance > of > the declaration of the next ABI version. The maintainer may choose to off

Re: [dpdk-dev] [PATCH] doc: remove not supported features from hinic matrix

2020-02-25 Thread Ferruh Yigit
On 2/24/2020 7:51 PM, Thomas Monjalon wrote: > Only the supported features are supposed to be listed > in the networking features matrix. > > Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] doc: fix typos in rel_notes-19.11

2020-02-25 Thread Thomas Monjalon
31/12/2019 08:36, Yong Wang: > Remove the redundant "when used". And modify "ans" to "and". > > Fixes: b21302a10721 ("eventdev: add Tx flag for packets with same > destination") > Fixes: 92c083915ade ("doc: update release notes for 19.11") > > Signed-off-by: Yong Wang Applied, thanks Note: on

Re: [dpdk-dev] [dpdk-announce] release candidate 20.02-rc4

2020-02-25 Thread Raslan Darawsheh
Hi, It's Ok from our side and we can release. Kindest regards Raslan Darawsheh Kindest regards Raslan Darawsheh From: Thomas Monjalon Sent: Tuesday, February 25, 2020 4:44:26 PM To: Ali Alnubani ; Xu, Qian Q ; Raslan Darawsheh Cc: dev@dpdk.org ; Asaf Penso ;

Re: [dpdk-dev] [PATCH v1] ci: add test suite run without hugepage

2020-02-25 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Tuesday, February 25, 2020 17:15 > To: Ruifeng Wang > Cc: Aaron Conole ; Michael Santana > ; Bruce Richardson > ; dev ; Gavin Hu > ; Honnappa Nagarahalli > ; nd > Subject: Re: [PATCH v1] ci: add test suite run without hugepage > > On

Re: [dpdk-dev] [PATCH] doc: add tested platforms with Mellanox NICs

2020-02-25 Thread Thomas Monjalon
25/02/2020 10:24, Raslan Darawsheh: > Signed-off-by: Raslan Darawsheh > --- > doc/guides/rel_notes/release_20_02.rst | 121 > + > 1 file changed, 121 insertions(+) Applied, thanks

Re: [dpdk-dev] Facing issue with mellanox after increasing number of buffers

2020-02-25 Thread Asaf Penso
Thank you Chetan for this mail. We will look internally at the below issue and will come back after our analysis. Regards, Asaf Penso > -Original Message- > From: dev On Behalf Of chetan bhasin > Sent: Friday, February 21, 2020 6:30 AM > To: dev@dpdk.org > Subject: [dpdk-dev] Facing iss

Re: [dpdk-dev] [RFC 0/6] New sync modes for ring

2020-02-25 Thread Ananyev, Konstantin
> > > > Upfront note - that RFC is not a complete patch. > > > > It introduces an ABI breakage, plus it doesn't update ring_elem code > > > > properly, etc. > > > > I plan to deal with all these things in later versions. > > > > Right now I seek an initial feedback about proposed ideas. > > > > Wou

Re: [dpdk-dev] pci device access from dpdk secondary process with igb_uio

2020-02-25 Thread Trahe, Fiona
Hi Vijay, Thanks for debugging. We've recreated your issue and validated that this fixes it. Do you want to go ahead and send up a patch or will I do that? Fiona > -Original Message- > From: Trahe, Fiona > Sent: Wednesday, January 22, 2020 5:19 PM > To: vijay mohan ; dev@dpdk.org; Yigi

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

2020-02-25 Thread David Marchand
On Mon, Feb 17, 2020 at 10:27 AM Robin Jarry wrote: > > Now that Python 2 is officially not maintained anymore, prepare the > removal of support in DPDK. > > Add a deprecation notice indicating the removal schedule. > > Cc: Bruce Richardson > Cc: Kevin Traynor > Cc: Timothy Redaelli > > Signed-

Re: [dpdk-dev] [PATCH] doc: fix naming of Mellanox devices

2020-02-25 Thread Thomas Monjalon
24/02/2020 20:52, Thomas Monjalon: > The devices of the family ConnectX may have two letters as suffix. > Such suffix is preceded with a space and the second x is lowercase: > - ConnectX-4 Lx > - ConnectX-5 Ex > - ConnectX-6 Dx > > Uppercase of the device family name BlueField is also

Re: [dpdk-dev] [PATCH] doc: deprecation notice to move igb_uio to a new repo

2020-02-25 Thread David Marchand
On Thu, Jan 30, 2020 at 5:59 PM wrote: > > From: Jerin Jacob > > Based on the tech board meeting held on 2019-11-06, > It's been decided to move igb_uio kernel module to a new repository > hosted by dpdk.org in v20.11 release. > > http://mails.dpdk.org/archives/dev/2019-November/151763.html > > A

Re: [dpdk-dev] [PATCH] doc: deprecate using MAX values as array size

2020-02-25 Thread David Marchand
On Thu, Jan 30, 2020 at 3:20 PM Ferruh Yigit wrote: > Adding the deprecation notice as reminder for next ABI breakage release > (20.11). > This one time breakage is required to be able to extend enum/define > without breaking ABI. > > Signed-off-by: Ferruh Yigit Acked-by: Akhil Goyal Acked-by:

Re: [dpdk-dev] [dpdk-announce] release candidate 20.02-rc4

2020-02-25 Thread Thomas Monjalon
Can we assume we are OK to release today? 25/02/2020 15:37, Xu, Qian Q: > Some quick update from Intel on RC4 testing > > Summary > > 1. Totally execution percentage is around 90%, pass rate is around 98% > 2. Created 2 new medium/low issue in RC4. > > Details: > 1. Intel NIC PMD PF & VF reg

Re: [dpdk-dev] [PATCH] doc: remove redundant line in mlx5 guide

2020-02-25 Thread Thomas Monjalon
24/02/2020 20:50, Thomas Monjalon: > When adding GTP to the list of supported tunnels, > the old line was not removed. > > Fixes: f31d7a0171da ("net/mlx5: support GTP") > > Signed-off-by: Thomas Monjalon Applied

Re: [dpdk-dev] [dpdk-announce] release candidate 20.02-rc4

2020-02-25 Thread Xu, Qian Q
Some quick update from Intel on RC4 testing Summary 1. Totally execution percentage is around 90%, pass rate is around 98% 2. Created 2 new medium/low issue in RC4. Details: 1. Intel NIC PMD PF & VF regression: 95% executed, 0 critical issue and high issue found. Function cases include rx/tx

Re: [dpdk-dev] [PATCH v1] ci: add test suite run without hugepage

2020-02-25 Thread Aaron Conole
David Marchand writes: > On Tue, Feb 25, 2020 at 8:33 AM Ruifeng Wang wrote: >> >> This test suite is derived from fast-tests suite. Cases in this >> suite are run with '--no-huge' flag. >> >> The suite aims to cover as many as possible test cases out of the >> fast-tests suites in the environme

Re: [dpdk-dev] [PATCH v4] doc: alias to experimental tag for stable apis

2020-02-25 Thread Kevin Traynor
On 18/02/2020 10:46, Ray Kinsella wrote: > When a maintainer is promoting an API to become part of the next major ABI > version by removing the experimental tag, possibly a few releases in > advance of the declaration of the next ABI version. The maintainer may > choose to offer an alias to the exp

Re: [dpdk-dev] [PATCH] vfio: map contiguous areas in one go

2020-02-25 Thread Burakov, Anatoly
On 25-Feb-20 1:49 PM, Ray Kinsella wrote: Hi Anatoly, On 25/02/2020 13:24, Anatoly Burakov wrote: Currently, when we are creating DMA mappings for memory that's either external or is backed by hugepages in IOVA as PA mode, we assume that each page is necessarily discontiguous. This may not actu

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

2020-02-25 Thread David Marchand
On Mon, Feb 17, 2020 at 10:27 AM Robin Jarry wrote: > > Now that Python 2 is officially not maintained anymore, prepare the > removal of support in DPDK. > > Add a deprecation notice indicating the removal schedule. > > Cc: Bruce Richardson > Cc: Kevin Traynor > Cc: Timothy Redaelli > > Signed-

Re: [dpdk-dev] [PATCH] doc: deprecate using MAX values as array size

2020-02-25 Thread David Marchand
On Thu, Jan 30, 2020 at 3:20 PM Ferruh Yigit wrote: > Adding the deprecation notice as reminder for next ABI breakage release > (20.11). > This one time breakage is required to be able to extend enum/define > without breaking ABI. > > Signed-off-by: Ferruh Yigit > --- > doc/guides/rel_notes/depr

Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: deprecation notice to move igb_uio to a new repo

2020-02-25 Thread David Marchand
On Tue, Feb 25, 2020 at 1:48 PM Thomas Monjalon wrote: > > 25/02/2020 12:50, Jerin Jacob: > > On Tue, Feb 25, 2020 at 4:30 PM Thomas Monjalon wrote: > > > > > > > > From: Jerin Jacob > > > > > > > > > > Based on the tech board meeting held on 2019-11-06, > > > > > It's been decided to move igb_u

Re: [dpdk-dev] [PATCH] vfio: map contiguous areas in one go

2020-02-25 Thread Ray Kinsella
Hi Anatoly, On 25/02/2020 13:24, Anatoly Burakov wrote: > Currently, when we are creating DMA mappings for memory that's > either external or is backed by hugepages in IOVA as PA mode, we > assume that each page is necessarily discontiguous. This may not > actually be the case, especially for exte

Re: [dpdk-dev] [RFC 0/6] New sync modes for ring

2020-02-25 Thread Ananyev, Konstantin
> > > > Upfront note - that RFC is not a complete patch. > > > > It introduces an ABI breakage, plus it doesn't update ring_elem > > > > code properly, etc. > > > > I plan to deal with all these things in later versions. > > > > Right now I seek an initial feedback about proposed ideas. > > > > Wou

[dpdk-dev] [PATCH] vfio: map contiguous areas in one go

2020-02-25 Thread Anatoly Burakov
Currently, when we are creating DMA mappings for memory that's either external or is backed by hugepages in IOVA as PA mode, we assume that each page is necessarily discontiguous. This may not actually be the case, especially for external memory, where the user is able to create their own IOVA tabl

Re: [dpdk-dev] [PATCH] doc: describe the pktmbuf pool with pinned extarnal memory

2020-02-25 Thread Thomas Monjalon
24/02/2020 18:58, Viacheslav Ovsiienko: > Document the new mbuf pools with external pinned buffers. > > Signed-off-by: Viacheslav Ovsiienko > --- > doc/guides/prog_guide/mbuf_lib.rst | 34 > ++ Please submit this documentation separately for review by Olivier

Re: [dpdk-dev] [PATCH] doc/mlx5: update mlx5 guide

2020-02-25 Thread Thomas Monjalon
24/02/2020 18:57, Viacheslav Ovsiienko: > - metadata limitation is described > - no inline hint flag is described > > Signed-off-by: Viacheslav Ovsiienko > --- Split in 2 patches and applied, thanks

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

2020-02-25 Thread Kevin Traynor
On 17/02/2020 09:26, Robin Jarry wrote: > Now that Python 2 is officially not maintained anymore, prepare the > removal of support in DPDK. > > Add a deprecation notice indicating the removal schedule. > > Cc: Bruce Richardson > Cc: Kevin Traynor > Cc: Timothy Redaelli > > Signed-off-by: Robi

[dpdk-dev] [PATCH] net/ice: remove unnecessary variable

2020-02-25 Thread Qi Zhang
Remove unnecessary variable "meta" in ice_flow_create and ice_flow_validate, it should be defined when really be needed: its ice_parse_engine_create and ice_parse_engine_validate. The patch also move the meta's memory free from each filter engine->create to upper layer, the memory leakage when cre

Re: [dpdk-dev] [PATCH v2 5/5] net/fm10k: add switch management support

2020-02-25 Thread Xiaojun Liu
Hi Xiao, Thank you! I will follow your comments. Best regards, Xiaojun From: Wang, Xiao W Sent: Tuesday, February 25, 2020 7:28 PM To: Xiaojun Liu ; Zhang, Qi Z ; Kwan, Ngai-mint ; Keller, Jacob E Cc: dev@dpdk.org ; Ye, Xiaolong Subject: RE: [PATCH v2 5/5] ne

Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: deprecation notice to move igb_uio to a new repo

2020-02-25 Thread Thomas Monjalon
25/02/2020 12:50, Jerin Jacob: > On Tue, Feb 25, 2020 at 4:30 PM Thomas Monjalon wrote: > > > > > > From: Jerin Jacob > > > > > > > > Based on the tech board meeting held on 2019-11-06, > > > > It's been decided to move igb_uio kernel module to a new repository > > > > hosted by dpdk.org in v20.1

[dpdk-dev] [PATCH v2] doc: plan splitting the ethdev ops struct

2020-02-25 Thread Ferruh Yigit
For the ABI compatibility it is better to hide internal data structures from the application as much as possible. But because of some inline functions 'struct eth_dev_ops' can't be hidden completely. Plan is to split the 'struct eth_dev_ops' into two as ones used by inline functions and ones not u

Re: [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct

2020-02-25 Thread Ferruh Yigit
On 2/18/2020 5:07 AM, Jerin Jacob wrote: > On Mon, Feb 17, 2020 at 9:08 PM Ferruh Yigit wrote: >> >> For the ABI compatibility it is better to hide internal data structures >> from the application as much as possible. But because of some inline >> functions 'struct eth_dev_ops' can't be hidden com

[dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx

2020-02-25 Thread ssebasti
From: Selwin Sebastian Enable scattered rx support and add jumbo packet transmit capability Signed-off-by: Selwin Sebastian --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_common.h | 2 + drivers/net/axgbe/axgbe_ethdev.c | 18 +++- drivers/net/axgbe/axgbe_rxtx.c

Re: [dpdk-dev] [PATCH] doc: update mlx5 encap/decap limitations

2020-02-25 Thread Thomas Monjalon
23/02/2020 10:30, Raslan Darawsheh: > Document validation limitations for encap/decap. > > Signed-off-by: Raslan Darawsheh > Acked-by: Ori kam Applied, thanks

Re: [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct

2020-02-25 Thread Ferruh Yigit
On 2/25/2020 10:35 AM, Andrew Rybchenko wrote: > On 2/21/20 1:40 PM, Ferruh Yigit wrote: >> On 2/18/2020 6:01 AM, Stephen Hemminger wrote: >>> On Mon, 17 Feb 2020 15:38:05 + >>> Ferruh Yigit wrote: >>> For the ABI compatibility it is better to hide internal data structures from the a

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-25 Thread Anoob Joseph
Hi Akhil, Konstantin, One question below. Thanks, Anoob > -Original Message- > From: Lukas Bartosik > Sent: Tuesday, February 25, 2020 5:21 PM > To: Akhil Goyal ; Anoob Joseph > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Ankur Dwivedi ; > Archana Muniganti ; Tejas

Re: [dpdk-dev] [EXT] RE: [PATCH v4 00/15] add eventmode to ipsec-secgw

2020-02-25 Thread Lukas Bartosik
Hi Akhil, Please see my answer below. Thanks, Lukasz On 24.02.2020 14:40, Akhil Goyal wrote: > External Email > > -- > Hi Anoob/Lukasz, > >> >> This series introduces event-mode additions to ipsec-secgw. >> >> With this series

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-25 Thread Lukas Bartosik
Hi Akhil, Please see my answers below. Thanks, Lukasz On 24.02.2020 15:13, Akhil Goyal wrote: > External Email > > -- > Hi Lukasz/Anoob, > >> >> Add application inbound/outbound worker thread and >> IPsec application processin

Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: deprecation notice to move igb_uio to a new repo

2020-02-25 Thread Jerin Jacob
On Tue, Feb 25, 2020 at 4:30 PM Thomas Monjalon wrote: > > > > From: Jerin Jacob > > > > > > Based on the tech board meeting held on 2019-11-06, > > > It's been decided to move igb_uio kernel module to a new repository > > > hosted by dpdk.org in v20.11 release. > > > > > > http://mails.dpdk.org/

Re: [dpdk-dev] [RFC 0/6] New sync modes for ring

2020-02-25 Thread Ananyev, Konstantin
> > -Original Message- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Monday, February 24, 2020 1:35 PM > > To: Jerin Jacob > > Cc: Konstantin Ananyev ; dpdk-dev > > ; Olivier Matz > > Subject: Re: [dpdk-dev] [RFC 0/6] New sync modes for ring > > > > On Mon, 24 Feb 2020 23:29:5

Re: [dpdk-dev] [PATCH v2 5/5] net/fm10k: add switch management support

2020-02-25 Thread Wang, Xiao W
Hi Xiaojun, Gather some comments about the code changes to original file: Based on the latest dpdk, "git am" will fail with the Makefile. Add CONFIG_RTE_FM10K_MANAGEMENT=n as a default option into ./config is better. If user wants to turn on this switch feature, it's easier to just change "n" t

Re: [dpdk-dev] [PATCH v3] doc: add IP DSCP rewrite to mlx5 and release notes

2020-02-25 Thread Thomas Monjalon
24/02/2020 20:50, Thomas Monjalon: > The new rte_flow feature for DSCP field rewrite offload was > missing in the release notes. > > The mlx5 requirements for DSCP field rewrite offload were missing. > > Fixes: 8482ffe4b68b ("ethdev: add IPv4/IPv6 DSCP rewrite action") > Fixes: 6f26e604a9c3 ("net

Re: [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct

2020-02-25 Thread Andrew Rybchenko
Hi Konstantin, On 2/25/20 2:07 PM, Ananyev, Konstantin wrote: > Hi Andew, > >> On 2/21/20 1:40 PM, Ferruh Yigit wrote: >>> On 2/18/2020 6:01 AM, Stephen Hemminger wrote: On Mon, 17 Feb 2020 15:38:05 + Ferruh Yigit wrote: > For the ABI compatibility it is better to hide int

[dpdk-dev] [PATCH] doc: add feature support matrix link for i40e

2020-02-25 Thread Xiaolong Ye
There is an increase in number of issues related to supported cables and modules, this link and note can help users identify or narrow down the issues. Signed-off-by: Xiaolong Ye --- doc/guides/nics/i40e.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/nics/i40

Re: [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct

2020-02-25 Thread Ananyev, Konstantin
Hi Andew, > On 2/21/20 1:40 PM, Ferruh Yigit wrote: > > On 2/18/2020 6:01 AM, Stephen Hemminger wrote: > >> On Mon, 17 Feb 2020 15:38:05 + > >> Ferruh Yigit wrote: > >> > >>> For the ABI compatibility it is better to hide internal data structures > >>> from the application as much as possib

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

2020-02-25 Thread Thomas Monjalon
17/02/2020 11:42, Bruce Richardson: > On Mon, Feb 17, 2020 at 10:26:59AM +0100, Robin Jarry wrote: > > Now that Python 2 is officially not maintained anymore, prepare the > > removal of support in DPDK. > > > > Add a deprecation notice indicating the removal schedule. > > > > Cc: Bruce Richardson

Re: [dpdk-dev] [PATCH] doc: deprecate using MAX values as array size

2020-02-25 Thread Thomas Monjalon
> > > Adding the deprecation notice as reminder for next ABI breakage release > > > (20.11). > > > This one time breakage is required to be able to extend enum/define > > > without breaking ABI. > > > > > > Signed-off-by: Ferruh Yigit > > > --- > > > +* lib: will fix extending some enum/define bre

Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: deprecation notice to move igb_uio to a new repo

2020-02-25 Thread Thomas Monjalon
> > From: Jerin Jacob > > > > Based on the tech board meeting held on 2019-11-06, > > It's been decided to move igb_uio kernel module to a new repository > > hosted by dpdk.org in v20.11 release. > > > > http://mails.dpdk.org/archives/dev/2019-November/151763.html > > > > Adding the deprecation

Re: [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct

2020-02-25 Thread Andrew Rybchenko
On 2/21/20 1:40 PM, Ferruh Yigit wrote: > On 2/18/2020 6:01 AM, Stephen Hemminger wrote: >> On Mon, 17 Feb 2020 15:38:05 + >> Ferruh Yigit wrote: >> >>> For the ABI compatibility it is better to hide internal data structures >>> from the application as much as possible. But because of some inl

Re: [dpdk-dev] [PATCH 1/2] crypto/qat: support DOCSIS AES-256

2020-02-25 Thread Trahe, Fiona
Hi Mairtin, > -Original Message- > From: O'loingsigh, Mairtin > Sent: Tuesday, February 25, 2020 9:48 AM > To: Trahe, Fiona ; akhil.go...@nxp.com > Cc: dev@dpdk.org; O'loingsigh, Mairtin > Subject: [PATCH 1/2] crypto/qat: support DOCSIS AES-256 > > This patch adds support for DOCSIS AES

Re: [dpdk-dev] [dpdk-announce] release candidate 20.02-rc4

2020-02-25 Thread Ali Alnubani
Hi, > -Original Message- > From: announce On Behalf Of Thomas > Monjalon > Sent: Saturday, February 22, 2020 11:08 PM > To: annou...@dpdk.org > Subject: [dpdk-announce] release candidate 20.02-rc4 > > A new DPDK release candidate is ready for testing: > > This is the last release cand

Re: [dpdk-dev] [PATCH 1/2] vdpa/mlx5: fix guest notification timing

2020-02-25 Thread Thomas Monjalon
24/02/2020 17:55, Matan Azrad: > When the HW finishes to consume the guest Rx descriptors, it creates a > CQE in the CQ. > > The mlx5 driver arms the CQ to get notifications when a specific CQE > index is created - the index to be armed is the next CQE index which > should be polled by the driver.

  1   2   >