From: Amaranath Somalapuram
Adding api for flow_ctrl_get and flow_ctrl_set.
By default axgbe driver flow control is disabled.
Adding dpdk flow control to set water high and low.
Signed-off-by: Amaranath Somalapuram
---
drivers/net/axgbe/axgbe_ethdev.c | 84
dri
From: Amaranath Somalapuram
Adding API for priority_flow_ctrl_set.
Priority flow control to set water high and low,
pause_time and priority.
Signed-off-by: Amaranath Somalapuram
---
drivers/net/axgbe/axgbe_common.h | 16 ++
drivers/net/axgbe/axgbe_ethdev.c | 94 +++
Hi, Qi
On 03/03, Qi Zhang wrote:
>Remove unnecessary variable "meta" in ice_flow_create and
>ice_flow_validate, it should be defined when really be needed:
>its ice_parse_engine_create and ice_parse_engine_validate.
>
>In a validate opertion, a meta is not necessary be created during
>parser, so N
> -Original Message-
> From: Ye, Xiaolong
> Sent: Tuesday, March 3, 2020 4:27 PM
> To: Zhang, Qi Z
> Cc: Cao, Yahui ; Su, Simei ; Zhao,
> Wei ; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH v2] net/ice: remove unnecessary variable
>
> Hi, Qi
>
> On 03/03, Qi Zhang wrote:
> >Rem
On Thu, Feb 27, 2020 at 3:20 PM Ivan Dyukov wrote:
>
> refactor vdpa specific devargs parsing to more generic way
>
> Signed-off-by: Ivan Dyukov
> ---
> drivers/net/virtio/virtio_ethdev.c | 34 +-
> 1 file changed, 24 insertions(+), 10 deletions(-)
>
> diff --git a/dr
Hi Xiao,
Sorry for delayed response.
Thanks,
Ori
> -Original Message-
> From: dev On Behalf Of Xiao Zhang
> Sent: Thursday, February 20, 2020 6:02 AM
> To: dev@dpdk.org
> Cc: arybche...@solarflare.com; ferruh.yi...@intel.com; Xiao Zhang
>
> Subject: [dpdk-dev] ethdev: add PFCP header t
In order that all queues of pools can receive packets,
add enable-rss argument to change rss configuration.
Fixes: 6bb97df521aa ("examples/vmdq: new app")
Cc: sta...@dpdk.org
Signed-off-by: Junyu Jiang
---
examples/vmdq/main.c | 39 ++-
1 file changed, 34 ins
On Thu, Feb 27, 2020 at 12:03 PM Sunil Kumar Kori wrote:
> We have two build machine with two different version of GCC.
> So the issue is reported on one setup only not on the other one.
> It looks like because of different version of GCC, this warning is caught.
f30 gcc 9 with -Wformat-overflow
Hello,
My name is Anver, I work for Reduxio, and I am new in this mailing list.
I need help with i40e driver.
I am experiencing issues with Intel NIC X710 , driver i40e.
The linux kernel driver host the PF and I am trying to configure the VF
with dpdk.
The configuration failed in the function i40
On Tue, Mar 03, 2020 at 03:10:56AM +, Amit Gupta wrote:
>
> > -Original Message-
> > From: Bruce Richardson
> > Sent: Monday, March 2, 2020 4:23 PM
> > To: Amit Gupta
> > Cc: Harman Kalra ; dev@dpdk.org; sta...@dpdk.org
> > Subject: [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: f
> -Original Message-
> From: Hemant Agrawal
> Sent: Monday, March 2, 2020 8:02 PM
> To: ferruh.yi...@intel.com
> Cc: dev@dpdk.org; Gagandeep Singh
> Subject: [PATCH 00/10] net/enetc: optimization and cleanup
>
> This patch series includes patches to optimize and clean
> the network dr
The nic_mask struct in function mlx5_flow_validate_item_ipv6()
includes hop_limits field.
This is redundant since matching on this item is not supported using
Verbs flow engine (dv_flow_en=0).
(Separate patch will be sent to handle this issue for DV flow engine.)
Setting a rule including match on
This patch adds to MLX5 PMD the support of matching on IPv4 TTL and
IPv6 hoplimit.
Support is valid when using DV flow engine (Verbs flow engine doesn't
support matching on this field).
Signed-off-by: Eli Britstein
Signed-off-by: Dekel Peled
Acked-by: Matan Azrad
---
doc/guides/rel_notes/relea
Thank you for the clarification. I was trying to get the queue and traffic
class information from where the packet is going to be dequeued. Its
resolved now.
Regards
Avinash
On Fri, Feb 28, 2020 at 7:09 PM Singh, Jasvinder
wrote:
>
>
> > -Original Message-
> > From: dev On Behalf Of Av
None of the public functions modify IPv6 address passed so their
parameters are made const.
Previously only lookup and add were updated to have addresses passed as
const so I'm adding this fixline.
Fixes: d82927d2f81d ("lpm6: make IPv6 address immutable")
Cc: step...@networkplumber.org
Signed-of
This is a helper function in case components would like to do more work
than just logging a message based on log level, like for example
collecting some stats if the log type is DEBUG etc..
A few existing relevant usage converted to this new API.
Signed-off-by: Ferruh Yigit
---
drivers/bus/fslm
Changing format specifier for the 'size_t' as '%z' and for 'off_t' as
'%jd'.
Also this fix enables compiling PMD for 32bit architecture.
Fixes: 29a62d1476b6 ("net/nfp: add CPP bridge as service")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
drivers/net/nfp/nfp_net.c | 20 ++-
On 3/3/2020 12:31 PM, Gagandeep Singh wrote:
>
>
>> -Original Message-
>> From: Hemant Agrawal
>> Sent: Monday, March 2, 2020 8:02 PM
>> To: ferruh.yi...@intel.com
>> Cc: dev@dpdk.org; Gagandeep Singh
>> Subject: [PATCH 00/10] net/enetc: optimization and cleanup
>>
>> This patch series
Hi Savinay,
> +static int
> +testsuite_setup(void)
> +{
> + struct rte_mbuf *mbuf[NUM_MBUF];
> + int ret, i;
> +
> + mbuf_pool = rte_pktmbuf_pool_create("IPSEC_PERF_MBUFPOOL",
> + NUM_MBUFS, MBUF_CACHE_SIZE, 0, MBUF_SIZE,
> + rte_socket_id());
On Tue, 3 Mar 2020 13:25:12 +
Ferruh Yigit wrote:
>
> +int
> +rte_log_can_log(uint32_t logtype, uint32_t level)
> +{
> + int log_level;
> +
> + if (level > rte_log_get_global_level())
> + return 0;
> +
> + log_level = rte_log_get_level(logtype);
> + if (log_leve
On 3/3/2020 4:02 PM, Stephen Hemminger wrote:
> On Tue, 3 Mar 2020 13:25:12 +
> Ferruh Yigit wrote:
>
>>
>> +int
>> +rte_log_can_log(uint32_t logtype, uint32_t level)
>> +{
>> +int log_level;
>> +
>> +if (level > rte_log_get_global_level())
>> +return 0;
>> +
>> +lo
gcc 10.0.1 reports: error: array subscript 0 is outside the bounds of an
interior zero-length array 'RTE_MARKER64' {aka 'long unsigned int[0]'}
[-Werror=zero-length-bounds] 310 | *(uint64_t *)(&mbuf->rearm_data) =
val;
Declaring zero-length arrays in other contexts, including as interior
members
Acked-by: Marko Kovacevic
On 3/2/2020 2:58 PM, Hemant Agrawal wrote:
> From: Gagandeep Singh
>
> Enable congestion handling/tail drop for TX queues.
>
> Signed-off-by: Gagandeep Singh
I don't know why it revealed itself with this patch, but I am getting an error
with this patch [1], this looks like build dependency err
On 3/2/2020 2:58 PM, Hemant Agrawal wrote:
> From: Gagandeep Singh
>
> Enable congestion handling/tail drop for TX queues.
>
> Signed-off-by: Gagandeep Singh
<...>
> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map
> b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> index e6ca4361e..86f581
On 3/2/2020 2:58 PM, Hemant Agrawal wrote:
> From: Nipun Gupta
>
> The patch adds support for portal migration by disabling stashing
> for the portals which is used in the non-affined threads, or on
> threads affined to multiple cores
>
> Signed-off-by: Nipun Gupta
<...>
> @@ -754,7 +856,7 @@
Clang and recent versions of GCC has builtin functions to do most math
operations and check for wraparound. On most architectures this is a
just a math operation followed by a branch on carry set.
But DPDK needs to be able to handle older GCC versions, and other
compilers so a wrapper macro is nee
The response from the firmware is accessed multiple times.
This is a potential TOCTOU error.
Reported-by: Christopher Ertl
Signed-off-by: Stephen Hemminger
---
drivers/net/bnxt/bnxt_hwrm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/d
This set of patches came from security review of bnxt driver.
It introduces a set of overflow macros that could be more widely
used in other places in DPDK to check for math overflows.
Stephen Hemminger (6):
eal: add portable way to check for math overflow
net/bnxt: fix potential data race
n
If hardware returned a bogus number of vnic's from the
query it could cause an out of bounds read into vnic table.
Reported-by: Christopher Ertl
Signed-off-by: Stephen Hemminger
---
drivers/net/bnxt/bnxt_hwrm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/bnxt/bnxt_hwr
If the hardware returns invalid values, the buffer size calculation
could overflow. Check for this by using the GCC/Clang builtin
that checks.
Reported-by: Christopher Ertl
Signed-off-by: Stephen Hemminger
---
drivers/net/bnxt/bnxt_hwrm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(
If a request to read a small value is passed to nvram reader
it would underflow.
Reported-by: Christopher Ertl
Signed-off-by: Stephen Hemminger
---
drivers/net/bnxt/bnxt_hwrm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
ind
>
> This series introduces event-mode additions to ipsec-secgw.
>
> With this series, ipsec-secgw would be able to run in eventmode. The
> worker thread (executing loop) would be receiving events and would be
> submitting it back to the eventdev after the processing. This way,
> multicore scali
If max_l2_ctx is very large, then adding the additional value
could cause wraparound.
Reported-by: Christopher Ertl
Signed-off-by: Stephen Hemminger
---
drivers/net/bnxt/bnxt_hwrm.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/dr
Hi Akhil, Thomas,
Checking whether there is anything on your end or can we have these patches
merged?
I did not include the release note update in that serie but will push a trivial
patchset for this later on if that's okay.
Thanks,
Nic
-Original Message-
From: Chautru, Nicolas
On Tue, 3 Mar 2020 18:13:22 +
Christopher Ertl wrote:
> Can we add the `volatile` qualifier to the `hwrm_cmd_resp_addr` member (in
> drivers/net/bnxt/bnxt.h) to get a stronger guarantee that the compiler won't
> insert TOCTOU races in the output?
>
> Christopher Ertl | MSRC Vulnerabilities
This is a helper function in case components would like to do more work
than just logging a message based on log level, like for example
collecting some stats if the log type is DEBUG etc..
A few existing relevant usage converted to this new API.
Signed-off-by: Ferruh Yigit
---
Cc: David Marchan
v5 changes:
* fixed code style
* fixed commit message and logging text
v4 changes:
* link_speed renamed to speed devarg
* speed devarg is added to virtio-user driver
v3 changes:
* link_speed devarg is added to virtio documentation
refactor vdpa specific devargs parsing to more generic way
Signed-off-by: Ivan Dyukov
---
drivers/net/virtio/virtio_ethdev.c | 34 +-
1 file changed, 24 insertions(+), 10 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev
Some applications like pktgen use link speed to calculate
transmission rate. It limits outcome traffic to hardcoded 10G.
This patch adds speed devarg which allows to configure
link speed of virtio device.
Signed-off-by: Ivan Dyukov
---
doc/guides/nics/virtio.rst | 7 +++
drivers/net/vi
virtio driver already parses speed devarg. virtio-user should add
it to list of valid devargs and call eth_virtio_dev_init function
which init speed value.
eth_virtio_dev_init already is called from virtio_user_pmd_probe
function. The only change is required to enable speed devargs:
adding speed t
strtoull returns 0 if it fails to parse input string. It's ignored
in get_integer_arg.
This patch handles error cases for strtoull function.
Signed-off-by: Ivan Dyukov
---
drivers/net/virtio/virtio_user_ethdev.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/d
https://bugs.dpdk.org/show_bug.cgi?id=416
Bug ID: 416
Summary: nfb build failed - missing rpms?
Product: DPDK
Version: 20.02
Hardware: All
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority:
When calling to setup RSS on v4 API, ESX will expect
IPv4/6 TCP RSS to be set/requested mandatorily.
This patch will:
- Set IPv4/6 TCP RSS when these have not been set. A warning
message is thrown to make sure we warn the application we are
setting IPv4/6 TCP RSS when not set.
- An additional chec
> +#if defined(__has_builtin)
> +#if __has_builtin(__builtin_add_overflow)
> +#define RTE_HAVE_BUILTIN_OVERFLOW
> +#endif
> +#elif defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 5000)
> +#define RTE__HAVE_BUILTIN_OVERFLOW
Excessive underline after RTE results in RTE_HAVE_BUILTIN
>From: dev On Behalf Of Dey, Souvik
>Sent: Monday, March 02, 2020 5:29 PM
>
>In case of bnx2xvf pmd, tx packets can support vland id in 2 ways :
>1. setting the mbuf ol_flags=PKT_TX_VLAN_PKT and passing the vlanid in
>mbuf->vlan_tci.
>2. the tx packet itself has the vlan id included in the packet.
Hi Souvik,
Could you resend this patch in text format?
When we are doing open source work, the contents of the footer are not
compatible with what we are doing. Please remove the footer in patches and
mailing list interactions for future.
Thanks!
-Rasesh
From: Dey, Souvik
Sent: Friday
Remove unnecessary variable "meta" in ice_flow_create and
ice_flow_validate, it should be defined when really be needed:
its ice_parse_engine_create and ice_parse_engine_validate.
A meta data be created by parser->parse_pattern_action should be
freed inside parser->engine->create.
During a valida
When calling to setup RSS on v4 API, ESX will expect
IPv4/6 TCP RSS to be set/requested mandatorily.
This patch will:
- Set IPv4/6 TCP RSS when these have not been set. A warning
message is thrown to make sure we warn the application we are
setting IPv4/6 TCP RSS when not set.
- An additional chec
On 03/04, Qi Zhang wrote:
>Remove unnecessary variable "meta" in ice_flow_create and
>ice_flow_validate, it should be defined when really be needed:
>its ice_parse_engine_create and ice_parse_engine_validate.
>
>A meta data be created by parser->parse_pattern_action should be
>freed inside parser->
Minor nit, better to reply the new series to the first mail (cover letter or
first patch) of V1.
On 03/03, Ivan Dyukov wrote:
>v5 changes:
>* fixed code style
>* fixed commit message and logging text
>
>v4 changes:
>* link_speed renamed to speed devarg
>* speed devarg is added to virtio-user drive
From: Amit Gupta
Add a condition to check if octeontx drivers are disabled.
octeontx drivers are built only if dependent drivers i.e.
ethdev, mempool and common/octeontx are enabled.
Bugzilla ID: 387
Fixes: 7f615033d64f ("drivers/net: build Cavium NIC PMDs with meson")
Signed-off-by: Amit Gupt
ACK
> -Original Message-
> From: Bruce Richardson
> Sent: Tuesday, March 3, 2020 4:47 PM
> To: Amit Gupta
> Cc: Harman Kalra ; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson
> build for disabled octeontx drivers
>
> On Tue, Mar 0
Hi,
I have observed that the dpdk-devbind.py is an interactive tool and
not quite useful for automated testing in CI/CD. We are planning to
create “dpdk-usertools-server” for making it streamlined.
The idea is to create a separate application, which provides REST interface to:
- Query the curre
Hi,
When I study the code of i40e_xmit_pkts_vec in dpdk, I have some questions for
the code.
The i40e_xmit_pkts_vec function calls the i40e_xmit_fixed_burst_vec.
I see it just transmits the tx_pkts one by one, but it doesn’t consider the
case the tx_pkts have multiple segments.
In the receive r
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, March 4, 2020 3:18 AM
> To: Hemant Agrawal ; Sachin Saxena
> ; Fiona Trahe ; John
> Griffin ; Deepak Kumar Jain
> ; John Daley (johndale) ;
> Hyong Youb Kim (hyonkim) ; Alfredo Cardigliano
> ; Matan Azrad ; Shahaf
> Shuler ; Viac
56 matches
Mail list logo
