Re: [dpdk-dev] [PATCH v2 00/28] graph: introduce graph subsystem

2020-03-26 Thread Jerin Jacob
On Thu, Mar 26, 2020 at 10:26 PM wrote: > > From: Jerin Jacob > > Using graph traversal for packet processing is a proven architecture > that has been implemented in various open source libraries. > > Graph architecture for packet processing enables abstracting the data > processing functions as

Re: [dpdk-dev] [PATCH] crypto/nitrox: add 3DES-CBC support

2020-03-26 Thread Nagadheeraj Rottela
> -Original Message- > From: Akhil Goyal > Sent: Thursday, March 26, 2020 12:18 AM > To: Nagadheeraj Rottela > Cc: dev@dpdk.org; Srikanth Jampala > Subject: [EXT] RE: [PATCH] crypto/nitrox: add 3DES-CBC support > > External Email > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] eal/mem: preallocate VA space in no-huge mode

2020-03-26 Thread David Marchand
On Thu, Mar 26, 2020 at 6:07 PM Burakov, Anatoly wrote: > > On 25-Mar-20 2:39 PM, David Marchand wrote: > > On Fri, Feb 7, 2020 at 12:11 PM Anatoly Burakov > > wrote: > >> > >> When --no-huge mode is used, the memory is currently allocated with > >> mmap(NULL, ...). This is fine in most cases, bu

[dpdk-dev] [PATCH v6 3/7] net/ice: acquire and disable the DCF capability

2020-03-26 Thread Haiyue Wang
Since the DCF (Device Config Function) controls the flow setting of other VFs by the mailbox with PF, for security, it needs to acquire the DCF capability from PF when starts, and disable it when exits. Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/net/ice/ice_dcf.c | 27 +++

[dpdk-dev] [PATCH v6 7/7] net/ice: get the VF hardware index in DCF

2020-03-26 Thread Haiyue Wang
The DCF (Device Config Function) needs the hardware index of the VFs to control the flow setting. And also if the VF resets, the index may be changed, so it should handle this in VF reset event. Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/net/ice/Makefile | 1 + drivers/n

[dpdk-dev] [PATCH v6 4/7] net/ice: handle the AdminQ command by DCF

2020-03-26 Thread Haiyue Wang
The DCF (Device Config Function) splits the AdminQ command into two parts: one is the descriptor of AdminQ command, the other is the buffer of AdminQ command (the descriptor has BUF flag set). When both of them are received by the PF, the PF will handle them as one command. And also, the filled de

[dpdk-dev] [PATCH v6 5/7] net/ice: export the DDP definition symbols

2020-03-26 Thread Haiyue Wang
A new DCF PMD will be introduced, which runs on Intel VF hardware, and it is a pure software design to control the advance functionality (such as switch, ACL) for rest of the VFs. The DCF (Device Config Function) feature shares the core functions of the ICE PMD, like it needs to export the DDP def

[dpdk-dev] [PATCH v6 2/7] net/ice: add the DCF hardware initialization

2020-03-26 Thread Haiyue Wang
Introduce the DCF (Device Config Function) feature in the ice PMD, it works as a standalone PMD which doesn't handle the packet Rx/Tx related things. Its hardware entity is the VF. Add the basic DCF hardware initialization, this is specified by devarg 'cap=dcf'. Signed-off-by: Haiyue Wang Acked-

[dpdk-dev] [PATCH v6 6/7] net/ice: handle the PF initialization by DCF

2020-03-26 Thread Haiyue Wang
The DCF (Device Config Function) works at the user PF level, it can't access the real PF hardware directly. So it will pass through the PF's AdminQ command by the DCF's mailbox. And the DCF is mainly used to control the flow setting of other VFs, so it only needs to initialize some core functions

[dpdk-dev] [PATCH v6 0/7] add Intel DCF PMD support

2020-03-26 Thread Haiyue Wang
A DCF (Device Config Function) based approach is proposed where a device bound to the device's VF0 can act as a sole controlling entity to exercise advance functionality (such as switch, ACL) for rest of the VFs. The DCF works as a standalone PMD to support this function, which shares the ice PMD

[dpdk-dev] [PATCH v6 1/7] net/iavf: stop the PCI probe in DCF mode

2020-03-26 Thread Haiyue Wang
A new DCF PMD will be introduced, which runs on Intel VF hardware, and it is a pure software design to control the advance functionality (such as switch, ACL) for rest of the VFs. So if the DCF (Device Config Function) mode is specified by the devarg 'cap=dcf', then it will stop the PCI probe in t

Re: [dpdk-dev] [PATCH v2 4/8] eal: move arch-specific header files

2020-03-26 Thread Gavin Hu
Reviewed-by: Gavin Hu

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] eal/mem: preallocate VA space in no-huge mode

2020-03-26 Thread Zhou, JunX W
Tested-by: Zhou, JunX W -Original Message- From: Jiang, YuX Sent: Thursday, March 26, 2020 8:24 PM To: David Marchand ; Burakov, Anatoly Cc: dev ; dpdk stable ; Zhou, JunX W Subject: RE: [dpdk-dev] [dpdk-stable] [PATCH v3] eal/mem: preallocate VA space in no-huge mode + Zhou, JunX

[dpdk-dev] [PATCH v2 6/8] eal: move common header files

2020-03-26 Thread Thomas Monjalon
The EAL API (with doxygen documentation) is moved from common/include/ to include/, which makes more clear that it is the global API for all environments and architectures. Note that the arch-specific and OS-specific include files are not in this global include directory, but include/generic/ shou

[dpdk-dev] [PATCH v2 8/8] eal: clean make and meson files

2020-03-26 Thread Thomas Monjalon
Clean up indent and line ordering in Makefile and meson.build for consistency in linux/ and freebsd/ directories. Signed-off-by: Thomas Monjalon --- lib/librte_eal/freebsd/Makefile| 2 +- lib/librte_eal/freebsd/meson.build | 25 lib/librte_eal/linux/Makefile |

[dpdk-dev] [PATCH v2 7/8] eal: move OS-specific sub-directories

2020-03-26 Thread Thomas Monjalon
Since the kernel modules are moved to kernel/ directory, there is no need anymore for the sub-directory eal/ in linux/, freebsd/ and windows/. Signed-off-by: Thomas Monjalon --- MAINTAINERS | 12 +--- kernel/linux/kni/meson.build

[dpdk-dev] [PATCH v2 5/8] eal: simplify meson build of common directory

2020-03-26 Thread Thomas Monjalon
The variable common_sources allows to change the list of common files from an arch-specific or OS-specific meson file. For consistency and least surprise principle, this variable is removed. Now the list of common sources is defined only in common/meson.build. As a consequence, the temporary list o

[dpdk-dev] [PATCH v2 3/8] eal: move arch-specific C files

2020-03-26 Thread Thomas Monjalon
The arch-specific directories arm, ppc and x86 in common/arch/ are moved at the same level as the OS-specific directories. It makes more clear that EAL is covering a matrix combining OS and arch. Signed-off-by: Thomas Monjalon --- MAINTAINERS | 6 +++-

[dpdk-dev] [PATCH v2 1/8] eal: remove useless makefiles

2020-03-26 Thread Thomas Monjalon
When moving files to the directory kernel/, the file BSDmakefile.meson was left in eal/. Also the intermediate makefiles in linux/ and freebsd/ became useless. Fixes: acaa9ee991b5 ("move kernel modules directories") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- MAINTAINERS

[dpdk-dev] [PATCH v2 4/8] eal: move arch-specific header files

2020-03-26 Thread Thomas Monjalon
The arch-specific directories arm, ppc and x86 in common/include/arch/ are moved as include/ sub-directories of respective arch directories: - arm/include/ - ppc/include/ - x86/include/ Signed-off-by: Thomas Monjalon --- MAINTAINERS

[dpdk-dev] [PATCH v2 0/8] eal: reorganize directories layout

2020-03-26 Thread Thomas Monjalon
Some clean-up is done in EAL sub-directories. The goal is to make organization easier to understand, and to prepare moving some files from common to Unix-only place. Since the kernel modules are moved to kernel/ directory, there is no need anymore for the sub-directory eal/ in linux/, freebsd/ and

[dpdk-dev] [PATCH v2 2/8] build: rename ppc sub-directories

2020-03-26 Thread Thomas Monjalon
The directories ppc_64 are renamed as ppc in - config/ - lib/librte_eal/common/arch/ - lib/librte_eal/common/include/arch/ The EAL directories are not really renamed, but symbolically linked, because they will be moved with their new name in the next commits. If ppc_32 nee

Re: [dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD

2020-03-26 Thread Stephen Hemminger
On Tue, 24 Mar 2020 23:31:11 -0400 zhihongx.p...@intel.com wrote: > +/*BSD has no interrupt mechanism, so force NIC status synchronization.*/ > +#ifdef RTE_EXEC_ENV_FREEBSD > + wait = 1; > +#endif > + Please format comments correctly. Is there a better way to detect interrupt mechanism with a

Re: [dpdk-dev] [dpdk-users] Issue while running DPDK19.11 test-pmd with Intel X722 Nic

2020-03-26 Thread Puneet Singh
Hi Everyone, I am using X722 NIC with DPDK 19.11 after a single line patch for port detection as was advised earlier. The port gets detected properly. The NIC stats via rte_eth_stats_get report that the packets are arriving at NIC. There are no packets that are dropped due to no-mbuf's But the

Re: [dpdk-dev] [PATCH 3/3] net/i40e/base: add constants for PTP pins

2020-03-26 Thread Kwapulinski, Piotr
ACK -Original Message- From: Min, JiaqiX Sent: Wednesday, March 25, 2020 4:24 AM To: dev@dpdk.org Cc: Min, JiaqiX ; Kwapulinski, Piotr Subject: [PATCH 3/3] net/i40e/base: add constants for PTP pins Introduce constants for handling PTP pins used for external clock source. Signed-off-b

[dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD

2020-03-26 Thread zhihongx . peng
From: Peng Zhihong DPDK does not implement interrupt mechanism on BSD, so force NIC status synchronization. Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF) Cc: liang-min.w...@intel.com Signed-off-by: Peng Zhihong --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 + 1 file changed,

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-03-26 Thread Andrzej Ostruszka
On 3/25/20 12:11 PM, Morten Brørup wrote: [...] >>> - Notification scheme has been changed - instead of having just >>> callbacks now event queueing is also available (or a mix of those >>> two). > > Thank you for adding event queueing! That was actually a good input from you - thank you. >

Re: [dpdk-dev] [PATCH 0/3] add new Double Word Key hash table

2020-03-26 Thread Medvedkin, Vladimir
Hi Yipeng, Stephen, all, On 17/03/2020 19:52, Wang, Yipeng1 wrote: -Original Message- From: Stephen Hemminger Sent: Monday, March 16, 2020 12:33 PM To: Medvedkin, Vladimir Cc: Morten Brørup ; dev@dpdk.org; Ananyev, Konstantin ; Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce ; Suanm

Re: [dpdk-dev] [PATCH v4 1/2] common/qat: get version of QAT firmware

2020-03-26 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Thursday, March 26, 2020 4:22 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v4 1/2] common/qat: get version of QAT firmware > > This patch adds the function for retrieving QAT fi

Re: [dpdk-dev] [PATCH v4 2/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-26 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Thursday, March 26, 2020 4:22 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v4 2/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 > QAT > > This patch adds handling of mix

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] eal/mem: preallocate VA space in no-huge mode

2020-03-26 Thread Burakov, Anatoly
On 25-Mar-20 2:39 PM, David Marchand wrote: On Fri, Feb 7, 2020 at 12:11 PM Anatoly Burakov wrote: When --no-huge mode is used, the memory is currently allocated with mmap(NULL, ...). This is fine in most cases, but can fail in cases where DPDK is run on a machine with an IOMMU that is of more

[dpdk-dev] [PATCH v2 26/28] l3fwd-graph: add graph config and main loop

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Add graph creation, configuration logic and graph main loop. This graph main loop is run on every slave lcore and calls rte_graph_walk() to walk over lcore specific rte_graph. Master core accumulates and prints graph walk stats of all the lcore's graph's. Signed-off-by: N

[dpdk-dev] [PATCH v2 28/28] doc: add l3fwd graph application user guide

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Adding the user guide for l3fwd graph application. Signed-off-by: Nithin Dabilpuram --- MAINTAINERS | 1 + doc/guides/rel_notes/release_20_05.rst| 8 + doc/guides/sample_app_ug/index.rst| 1 + doc/guides/sample

[dpdk-dev] [PATCH v2 22/28] node: add ipv4 rewrite and lookup ctrl API

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Add ip4_rewrite and ip4_lookup ctrl API. ip4_lookup ctrl API is used to add route entries for LPM lookup with result data containing next hop id and next proto. ip4_rewrite ctrl API is used to add rewrite data for every next hop. Signed-off-by: Nithin Dabilpuram Signed-o

[dpdk-dev] [PATCH v2 24/28] l3fwd-graph: add graph based l3fwd skeleton

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Add graph based l3fwd application skeleton with cmdline parsing support inline with normal l3fwd. Signed-off-by: Nithin Dabilpuram --- MAINTAINERS | 3 + examples/Makefile| 3 + examples/l3fwd-graph/Makefile| 58 exampl

[dpdk-dev] [PATCH v2 25/28] l3fwd-graph: add ethdev configuration changes

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Add changes to ethdev port and queue configuration based on command line parameters for l3fwd graph application. Signed-off-by: Nithin Dabilpuram --- examples/l3fwd-graph/main.c | 350 +++- 1 file changed, 349 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v2 23/28] node: add pkt drop node

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Add pkt drop node process function for pkt_drop rte_node. This node simply free's every object received as an rte_mbuf to its rte_pktmbuf pool. Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh Signed-off-by: Kiran Kumar K --- lib/librte_node/Makefile

[dpdk-dev] [PATCH v2 18/28] node: add ethdev Rx and Tx node ctrl API

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Add ctrl api to setup ethdev_rx and ethdev_tx node. This ctrl api clones 'N' number of ethdev_rx and ethdev_tx nodes with specific (port, queue) pairs updated in their context. All the ethdev ports and queues are setup before this api is called. Signed-off-by: Nithin Dabi

[dpdk-dev] [PATCH v2 21/28] node: add ipv4 rewrite node

2020-03-26 Thread jerinj
From: Kiran Kumar K Add ip4 rewrite process function for ip4_rewrite rte_node. On every packet received by this node, header is overwritten with new data before forwarding it to next node. Header data to overwrite with is identified by next hop id passed in mbuf priv data by previous node. Signe

[dpdk-dev] [PATCH v2 20/28] node: ipv4 lookup for x86

2020-03-26 Thread jerinj
From: Pavan Nikhilesh Add IPv4 lookup process function for ip4_lookup rte_node. This node performs LPM lookup using x86_64 vector supported RTE_LPM API on every packet received and forwards it to a next node that is identified by lookup result. Signed-off-by: Pavan Nikhilesh Signed-off-by: Nith

[dpdk-dev] [PATCH v2 19/28] node: ipv4 lookup for arm64

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Add arm64 specific IPv4 lookup process function for ip4_lookup node. This node performs LPM lookup on every packet received and forwards it to a next node that is identified by lookup result. Signed-off-by: Nithin Dabilpuram Signed-off-by: Kiran Kumar K Signed-off-by: P

[dpdk-dev] [PATCH v2 17/28] node: add ethdev Tx node

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Add rte_node ethdev_tx process function and register it to graph infra. This node has a specific (port, tx-queue) as context and it enqueue's all the packets received to that specific queue pair. When rte_eth_tx_burst() i.e enqueue to queue pair fails, packets are forwarde

[dpdk-dev] [PATCH v2 16/28] node: add ethdev Rx node

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Add source rte_node ethdev_rx process function and register it. This node is a source node that will be called periodically and when called, performs rte_eth_rx_burst() on a specific (port, queue) pair and enqueue them as stream of objects to next node. Signed-off-by: Nit

[dpdk-dev] [PATCH v2 13/28] graph: add unit test case

2020-03-26 Thread jerinj
From: Kiran Kumar K Adding the unit test to test the functionality of node and graph APIs. Testing includes registering a node, cloning a node, creating a graph, perform graph walk, collecting stats and all node and graph debug APIs. example command to test: echo "graph_autotest" | sudo ./build/

[dpdk-dev] [PATCH v2 15/28] node: add log infra and null node

2020-03-26 Thread jerinj
From: Nithin Dabilpuram Add log infra for node specific logging. Also, add null rte_node that just ignores all the objects directed to it. Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh Signed-off-by: Kiran Kumar K --- MAINTAINERS | 5 + config/

[dpdk-dev] [PATCH v2 14/28] graph: add performance testcase

2020-03-26 Thread jerinj
From: Pavan Nikhilesh Add unit test framework to create and test performance of various graph models. example command to test: echo "graph_perf_autotest" | sudo ./build/app/test/dpdk-test -c 0x30 Signed-off-by: Pavan Nikhilesh --- app/test/Makefile |1 + app/test/meson.build

[dpdk-dev] [PATCH v2 12/28] graph: implement fastpath API routines

2020-03-26 Thread jerinj
From: Jerin Jacob Adding implementation for rte_graph_walk() API. This will perform a walk on the circular buffer and call the process function of each node and collect the stats if stats collection is enabled. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhil

[dpdk-dev] [PATCH v2 10/28] graph: implement debug routines

2020-03-26 Thread jerinj
From: Jerin Jacob Adding implementation for graph specific API to dump the Graph information to a file. This API will dump detailed internal info about node objects and graph objects. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh --- lib/librte_graph/

[dpdk-dev] [PATCH v2 11/28] graph: implement stats support

2020-03-26 Thread jerinj
From: Jerin Jacob Adding implementation for graph stats collection API. This API will create a cluster for a specified node pattern and aggregate the node runtime stats. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram --

[dpdk-dev] [PATCH v2 09/28] graph: implement Graphviz export

2020-03-26 Thread jerinj
From: Jerin Jacob Adding API implementation support exporting the graph object to file. This will export the graph to a file in Graphviz format. It can be viewed in many viewers such as https://dreampuf.github.io/GraphvizOnline/ Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-of

[dpdk-dev] [PATCH v2 06/28] graph: populate fastpath memory for graph reel

2020-03-26 Thread jerinj
From: Jerin Jacob Adding support to create and populate the memory for graph reel. This includes reserving the memory in the memzone, populating the nodes, Allocating memory for node-specific streams to hold objects. Once it is populated the reel memory contains the following sections. +---

[dpdk-dev] [PATCH v2 04/28] graph: implement node debug routines

2020-03-26 Thread jerinj
From: Jerin Jacob Adding node debug API implementation support to dump single or all the node objects to the given file. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh --- lib/librte_graph/Makefile | 1 + lib/librte_graph/graph_debug.c

[dpdk-dev] [PATCH v2 08/28] graph: implement graph operation APIs

2020-03-26 Thread jerinj
From: Jerin Jacob Adding support for graph specific API implementation like Graph lookup to get graph object, retrieving graph ID >From name and graph name from ID. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh --- lib/librte_graph/graph.c

[dpdk-dev] [PATCH v2 05/28] graph: implement internal graph operation helpers

2020-03-26 Thread jerinj
From: Jerin Jacob Adding internal graph API helpers support to check whether a graph has isolated nodes and any node have a loop to itself and BFS algorithm implementation etc. Signed-off-by: Jerin Jacob --- lib/librte_graph/Makefile| 1 + lib/librte_graph/graph.c | 2 +- l

[dpdk-dev] [PATCH v2 07/28] graph: implement create and destroy APIs

2020-03-26 Thread jerinj
From: Jerin Jacob Adding graph specific API implementations like graph create and graph destroy. This detect loops in the graph, check for isolated nodes and operation to verify the validity of graph. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh ---

[dpdk-dev] [PATCH v2 01/28] graph: define the public API for graph support

2020-03-26 Thread jerinj
From: Jerin Jacob Graph architecture abstracts the data processing functions as "node" and "link" them together to create a complex "graph" to enable reusable/modular data processing functions. These APIs enables graph framework operations such as create, lookup, dump and destroy on graph and no

[dpdk-dev] [PATCH v2 00/28] graph: introduce graph subsystem

2020-03-26 Thread jerinj
From: Jerin Jacob Using graph traversal for packet processing is a proven architecture that has been implemented in various open source libraries. Graph architecture for packet processing enables abstracting the data processing functions as “nodes” and “links” them together to create a complex “

[dpdk-dev] [PATCH v2 02/28] graph: implement node registration

2020-03-26 Thread jerinj
From: Jerin Jacob Adding rte_node_register() API implementation includes allocating memory for node object, check for duplicate node name and add the allocated node to STAILQ node_list for future use. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh ---

[dpdk-dev] [PATCH v2 03/28] graph: implement node operations

2020-03-26 Thread jerinj
From: Jerin Jacob Adding node-specific API implementation like cloning node, updating edges for the node, shrinking edges of a node, retrieving edges of a node. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh --- lib/librte_graph/graph_private.h |

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-26 Thread Ray Kinsella
On 26/03/2020 09:56, Pavan Nikhilesh Bhagavatula wrote: > >> -Original Message- >> From: Ray Kinsella >> Sent: Tuesday, March 24, 2020 8:08 PM >> To: Pavan Nikhilesh Bhagavatula ; Jerin >> Jacob Kollanukkaran ; Nithin Kumar Dabilpuram >> >> Cc: dev@dpdk.org; tho...@monjalon.net; >> da

[dpdk-dev] [PATCH v2 1/2] hash: add hash bulk lookup with hash signatures array

2020-03-26 Thread Vladimir Medvedkin
Implement rte_hash_lookup_with_hash_bulk_data() - lookup function with precomputed hash signatures. Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/rte_cuckoo_hash.c| 296 +++ lib/librte_hash/rte_hash.h | 27 lib/librte_hash/rte_hash_vers

[dpdk-dev] [PATCH v2 2/2] test: update hash performance tests

2020-03-26 Thread Vladimir Medvedkin
Add preformance test for rte_hash_lookup_with_hash_bulk_data() Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c

[dpdk-dev] [PATCH v2 1/2] ipsec: use hash lookup with hash sigs in sad lookup

2020-03-26 Thread Vladimir Medvedkin
Change hash function from jhash to crc. Precalculate hash signatures for a bulk of keys and then use rte_hash_lookup_with_hash_bulk_data() to speed up sad lookup Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/ipsec_sad.c | 38 +- 1 file changed, 29 ins

[dpdk-dev] [PATCH v2 2/2] ipsec: use hash add and delete with precalculated signatures

2020-03-26 Thread Vladimir Medvedkin
Use rte_hash_add_key_with_hash and _del_key_with_hash with precalculated hash signature for a key in rte_ipsec_sad_add and rte_ipsec_sad_del. Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/ipsec_sad.c | 80 1 file changed, 51 insertions(+), 29

Re: [dpdk-dev] [PATCH] vhost: prefix vDPA enum value for PCI address type

2020-03-26 Thread Maxime Coquelin
On 3/26/20 5:33 PM, Matan Azrad wrote: > Hi > > From: Maxime Coquelin >> In order to avoid potential conflicts, rename the PCI_ADDR enum value to >> VDPA_ADDR_PCI in vdpa_addr_type_enum. >> >> All symbols referencing this enum are experimental, so it does not break API >> policy. >> >> Signed-o

Re: [dpdk-dev] [PATCH] vhost: prefix vDPA enum value for PCI address type

2020-03-26 Thread Matan Azrad
Hi From: Maxime Coquelin > In order to avoid potential conflicts, rename the PCI_ADDR enum value to > VDPA_ADDR_PCI in vdpa_addr_type_enum. > > All symbols referencing this enum are experimental, so it does not break API > policy. > > Signed-off-by: Maxime Coquelin Acked-by: Matan Azrad I thi

[dpdk-dev] [PATCH v4 0/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-26 Thread Adam Dybkowski
This patch set adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. v2: * minor fixes and improvements v3: * include missing header file v4: * update d

[dpdk-dev] [PATCH v4 1/2] common/qat: get version of QAT firmware

2020-03-26 Thread Adam Dybkowski
This patch adds the function for retrieving QAT firmware version, required to check the internal capabilities that depend on the FW version. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw.h | 2 + drivers/common/qat/qat_qp.c | 93 + d

[dpdk-dev] [PATCH v4 2/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-26 Thread Adam Dybkowski
This patch adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 13 -

Re: [dpdk-dev] [dpdk-dev v3] [PATCH] net/octeontx2: add devargs to lock Rx/Tx ctx

2020-03-26 Thread Andrzej Ostruszka [C]
On 3/26/20 7:33 AM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add device arguments to lock Rx/Tx contexts. > Application can either choose to lock Rx or Tx contexts by using > 'lock_rx_ctx' or 'lock_tx_ctx' respectively per each port. > > Example: > -w 0002:02:00.0,lock_r

Re: [dpdk-dev] [PATCH 1/2] hash: add hash bulk lookup with hash signatures array

2020-03-26 Thread Medvedkin, Vladimir
Hi Yipeng, On 17/03/2020 17:27, Wang, Yipeng1 wrote: -Original Message- From: Medvedkin, Vladimir Sent: Monday, March 9, 2020 5:44 AM To: dev@dpdk.org Cc: Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce Subject: [PATCH 1/2] hash: add hash bulk lookup with hash signatures array Impl

[dpdk-dev] [PATCH] vhost: prefix vDPA enum value for PCI address type

2020-03-26 Thread Maxime Coquelin
In order to avoid potential conflicts, rename the PCI_ADDR enum value to VDPA_ADDR_PCI in vdpa_addr_type_enum. All symbols referencing this enum are experimental, so it does not break API policy. Signed-off-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +- drivers/vdpa/mlx5/mlx5_vdp

Re: [dpdk-dev] [PATCH v3] log: add API to check if a logtype can log in a given level

2020-03-26 Thread Andrzej Ostruszka
On 3/13/20 3:51 PM, Ferruh Yigit wrote: > This is a helper function in case components would like to do more work > than just logging a message based on log level, like for example > collecting some stats if the log type is DEBUG etc.. > > A few existing relevant usage converted to this new API. >

Re: [dpdk-dev] [PATCH] ipsec: use hash lookup with hash sigs in sad lookup

2020-03-26 Thread Medvedkin, Vladimir
Hi Konstantin, On 24/03/2020 19:57, Ananyev, Konstantin wrote: Hi Vladimir, Change hash function from jhash to crc. Precalculate hash signatures for a bulk of keys and then use rte_hash_lookup_with_hash_bulk_data() to speed up sad lookup Looks good in general. Few thoughts below, nothing majo

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-03-26 Thread Andrzej Ostruszka
Thank you David for taking time to look at this. On 3/25/20 9:08 AM, David Marchand wrote: > Hello Andrzej, > > On Tue, Mar 10, 2020 at 12:11 PM Andrzej Ostruszka [...] > I can see we end up exposing structures for registering callbacks. Right. I was thinking more in terms of user convenience s

Re: [dpdk-dev] [RFC 5/6] ring: introduce HTS ring mode

2020-03-26 Thread Ananyev, Konstantin
> > Introduce head/tail sync mode for MT ring synchronization. > > In that mode enqueue/dequeue operation is fully serialized: > > only one thread at a time is allowed to perform given op. > > Suppose to reduce stall times in case when ring is used on overcommitted > > cpus (multiple active threads

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: support 192/256 AES key sizes

2020-03-26 Thread Anoob Joseph
Adding support for the following, 1. AES-192-GCM 2. AES-256-GCM 3. AES-192-CBC Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- v2: * Updated doc and release notes doc/guides/rel_notes/release_20_05.rst | 7 +++ doc/guides/sample_app_ug/ipsec_secgw.rst | 3 +++ examples/i

Re: [dpdk-dev] [PATCH] build: don't parse build configs of explicitly disabled drivers

2020-03-26 Thread Bruce Richardson
On Thu, Mar 26, 2020 at 10:22:59AM +0100, Darek Stojaczyk wrote: > Even when a PMD was disabled with meson's disable_drivers option > its config file was still being parsed. Some of the PMD configs > attempt to find a library they depend on and parse its header files > with certain assumptions. If

Re: [dpdk-dev] [dpdk.org] [PATCH] fib: add "C" extern linkage for C++ programs

2020-03-26 Thread Medvedkin, Vladimir
On 16/03/2020 18:42, Muhammad Asim Jamshed wrote: This patch allows C++ programs to use librte_fib library routines. Previously C++ programs were not able to link this library and programs would fail to get linked. With this patch compilation and linking will be successful. Signed-off-by: Muhamm

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix zero value validation for metadata

2020-03-26 Thread Slava Ovsiienko
> -Original Message- > From: Wisam Monther > Sent: Thursday, March 26, 2020 12:22 > To: Ori Kam ; Matan Azrad ; > dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix zero value validation for metadata > > MARK and META items are in

[dpdk-dev] [PATCH v2] net/mlx5: fix zero value validation for metadata

2020-03-26 Thread Wisam Jaddo
MARK and META items are interrelated with datapath - they might move from/to the applications in mbuf. zero value for these items has the special meaning - it means "no metadata are provided", not zero values are treated by applications and PMD as valid ones. Moreover in the flow engine domain th

[dpdk-dev] 答复: [PATCH] kvargs: fix a heap-buffer-overflow when detect list

2020-03-26 Thread wangyunjian
> -邮件原件- > 发件人: Olivier Matz [mailto:olivier.m...@6wind.com] > 发送时间: 2020年3月26日 0:32 > 收件人: wangyunjian > 抄送: dev@dpdk.org; Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > 主题: Re: [dpdk-dev] [PATCH] kvargs: fix a heap-buffer-overflow when detect > list > > Hi, > > On Thu, Mar 19, 2020

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-26 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Ray Kinsella >Sent: Tuesday, March 24, 2020 8:08 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; Nithin Kumar Dabilpuram > >Cc: dev@dpdk.org; tho...@monjalon.net; >david.march...@redhat.com; mattias.ronnb...@ericsson.com; Kiran >Kumar Kokkilag

[dpdk-dev] [PATCH] build: don't parse build configs of explicitly disabled drivers

2020-03-26 Thread Darek Stojaczyk
Even when a PMD was disabled with meson's disable_drivers option its config file was still being parsed. Some of the PMD configs attempt to find a library they depend on and parse its header files with certain assumptions. If the library is found, but it's simply too old to contain the necessary he

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: support 192/256 AES key sizes

2020-03-26 Thread Akhil Goyal
> > > > > > Adding support for the following, > > > 1. AES-192-GCM > > > 2. AES-256-GCM > > > 3. AES-192-CBC > > > > > > Signed-off-by: Anoob Joseph > > > Signed-off-by: Tejasree Kondoj > > > --- > > > examples/ipsec-secgw/ipsec.h | 2 +- > > > examples/ipsec-secgw/sa.c| 25

Re: [dpdk-dev] [PATCH v2] net/ice: fix RSS advanced rule invalid issue

2020-03-26 Thread Yang, Qiming
Hi, Junyu NACKed. I still keep my point of view, I think no need to enable a restore function. Beside, 'ptr' = rss rule? I don't get your point, please don't define a various with a no meaning name. Hi, Qi What do you think about move the 'ice_rss_init' into 'ice_dev_init' ? Qiming > -Origi

Re: [dpdk-dev] [PATCH 0/4] Support DMA-accelerated Tx operations for vhost-user PMD

2020-03-26 Thread Maxime Coquelin
On 3/26/20 9:25 AM, Hu, Jiayu wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Thursday, March 26, 2020 3:53 PM >> To: Hu, Jiayu ; dev@dpdk.org >> Cc: Ye, Xiaolong ; Wang, Zhihong >> >> Subject: Re: [PATCH 0/4] Support DMA-accelerated Tx operations for vho

Re: [dpdk-dev] [PATCH] net/mlx5: fix call to modify action without init item

2020-03-26 Thread Matan Azrad
From: Asaf Penso > The item is being set according to the attribute value, whether it is udp/tcp > or > ipv4/6. > Also, there are two condition calls. > > If the attribute is neither udp/tcp or ipv4/6 the item is not initialized at > all, but > the call to the flow_dv_convert_modify_action is

Re: [dpdk-dev] [PATCH 0/4] Support DMA-accelerated Tx operations for vhost-user PMD

2020-03-26 Thread Hu, Jiayu
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, March 26, 2020 3:53 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ye, Xiaolong ; Wang, Zhihong > > Subject: Re: [PATCH 0/4] Support DMA-accelerated Tx operations for vhost- > user PMD > > Hi Jiayu, > > On 3/19/20 12:47

Re: [dpdk-dev] [RFC] ring: make ring implementation non-inlined

2020-03-26 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Wednesday, March 25, 2020 10:09 PM > > On Fri, Mar 20, 2020 at 10:11 PM Konstantin Ananyev > wrote: > > > > As was discussed here: > > http://mails.dpdk.org/archives/dev/2020-February/158586.html > > this RFC aimed to hide

[dpdk-dev] [PATCH v1] vhost: dequeue zero copy with linear buffers

2020-03-26 Thread Sivaprasad Tummala
Removed the linear buffer and zero_copy compatibility restriction. Applications that requires packets contained in a single buffer will enable linear buffer in vhost library. This restriction is not allowing zero_copy mode for such cases. Signed-off-by: Sivaprasad Tummala --- lib/librte_vhost/s

Re: [dpdk-dev] [PATCH 0/4] Support DMA-accelerated Tx operations for vhost-user PMD

2020-03-26 Thread Maxime Coquelin
Hi Jiayu, On 3/19/20 12:47 PM, Hu, Jiayu wrote: >> >> Ok, so what about: >> >> Introducing a pair of callbacks in struct virtio_net for DMA enqueue and >> dequeue. >> >> lib/librte_vhost/ioat.c which would implement dma_enqueue and >> dma_dequeue callback for IOAT. As it will live in the vhost li

[dpdk-dev] [dpdk-dev v2 4/4] app/testpmd: add new types to RSS hash commands

2020-03-26 Thread Jeff Guo
Add some new types, such as eth-src-only/eth-dst-only/svlan/cvlan/ l2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used to configure these rss input set by cmdline. Signed-off-by: Jeff Guo --- v1: 1.refine some rte eth rss offload types. --- app/test-pmd/cmdline.c | 24 +

[dpdk-dev] [dpdk-dev v2 2/4] net/iavf: add RSS configuration for VFs

2020-03-26 Thread Jeff Guo
Add RSS configuration for VFs. The VF must be capable of configuring RSS. Signed-off-by: Jeff Guo --- v1: 1.add NAT T ESP and refine gtpu down/up 2.reference some fixing patch from pf side. --- drivers/net/iavf/Makefile |1 + drivers/net/iavf/iavf.h | 10 + drivers/net/iavf/iavf_

[dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type

2020-03-26 Thread Jeff Guo
Add gtp pdu type configure in the cmdline. Signed-off-by: Jeff Guo --- v1: no change --- app/test-pmd/cmdline_flow.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index a78154502..c1bd02919 100644 --- a/a

[dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload types

2020-03-26 Thread Jeff Guo
Defines some new RSS offload types for ETH/SVLAN/CVLAN/GTPU/L2TPV3/ ESP/AH/PFCP. Signed-off-by: Jeff Guo --- v1: 1.refine some rte eth rss offload types. --- lib/librte_ethdev/rte_ethdev.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethde

[dpdk-dev] [dpdk-dev v2 0/4] add RSS configuration for iavf

2020-03-26 Thread Jeff Guo
Because the VF must be capable of configuring RSS, so add RSS configuration for iavf. The supported protocol rss input set as below. eth-src-only/ eth-dst-only/ svlan/ cvlan/ ipv4/ ipv6/ l3_src_only/ l3_dst_only/ l2tpv3/ esp/ ah/ pfcp/ gtpu down/ gtpu up/ udp/ tcp/ sctp/ This patchset depends on

[dpdk-dev] [PATCH v5 7/7] net/ice: get the VF hardware index in DCF

2020-03-26 Thread Haiyue Wang
The DCF (Device Config Function) needs the hardware index of the VFs to control the flow setting. And also if the VF resets, the index may be changed, so it should handle this in VF reset event. Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/net/ice/Makefile | 1 + drivers/n

[dpdk-dev] [PATCH v5 5/7] net/ice: export the DDP definition symbols

2020-03-26 Thread Haiyue Wang
A new DCF PMD will be introduced, which runs on Intel VF hardware, and it is a pure software design to control the advance functionality (such as switch, ACL) for rest of the VFs. The DCF (Device Config Function) feature shares the core functions of the ICE PMD, like it needs to export the DDP def

[dpdk-dev] [PATCH v5 6/7] net/ice: handle the PF initialization by DCF

2020-03-26 Thread Haiyue Wang
The DCF (Device Config Function) works at the user PF level, it can't access the real PF hardware directly. So it will pass through the PF's AdminQ command by the DCF's mailbox. And the DCF is mainly used to control the flow setting of other VFs, so it only needs to initialize some core functions

  1   2   >