This patch moved the ice_init_rss into ice_dev_configure to fix RSS
advanced rule invalid after running port stop and port start.
Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
Cc: sta...@dpdk.org
Signed-off-by: Junyu Jiang
---
drivers/net/ice/ice_ethdev.c | 13 +++--
1 file chang
On Tue, Mar 31, 2020 at 7:05 PM Ananyev, Konstantin
wrote:
>
> Hi everyone,
>
> Have a question regarding validate-abi.sh.
> It complains on the following changes with that patch:
>
> @@ -111,11 +129,21 @@ struct rte_ring {
> char pad0 __rte_cache_aligned; /**< empty cache line */
>
>
From: Martin Spinler
The driver wrongly assumed the presence of at least one rxmac in every
firmware and accessed to non-existing unit
Signed-off-by: Martin Spinler
Acked-by: Jakub Neruda
diff --git a/drivers/net/nfb/nfb_rxmode.c b/drivers/net/nfb/nfb_rxmode.c
index 3327c8272..2d0b613d2 10064
On 09/03/2020 12:43, Vladimir Medvedkin wrote:
> Add new lookup implementation for DIR24_8 algorithm using
> AVX512 instruction set
>
> Signed-off-by: Vladimir Medvedkin
> ---
> lib/librte_fib/dir24_8.c| 71
> lib/librte_fib/dir24_8_avx512.h | 116
>
Replace the PNG binary format with SVG text format.
Signed-off-by: Haiyue Wang
---
v3: Recreate it as .svg from scratch
v2: Fix the commit tile log format error
---
doc/guides/nics/img/ice_dcf.png | Bin 39168 -> 0 bytes
doc/guides/nics/img/ice_dcf.svg | 516
2 f
Hi Vladimir,
On 09/03/2020 12:43, Vladimir Medvedkin wrote:
> Add type argument to dir24_8_get_lookup_fn()
> Now it supports 3 different lookup implementations:
> RTE_FIB_DIR24_8_SCALAR_MACRO
> RTE_FIB_DIR24_8_SCALAR_INLINE
> RTE_FIB_DIR24_8_SCALAR_UNI
>
> Add new rte_fib_set_lookup_fn() - use
snipped
> diff --git a/lib/librte_if_proxy/Makefile b/lib/librte_if_proxy/Makefile
> new file mode 100644
> index 0..43cb702a2
> --- /dev/null
> +++ b/lib/librte_if_proxy/Makefile
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(C) 2020 Marvell International Ltd.
On 03/24, Guinan Sun wrote:
>Due to the restriction of the flag I40E_FLAG_VF_MAC_BY_PF,
>VF cannot program the MAC address.
>In order to solve this inflexibility, the use of I40E_FLAG_VF_MAC_BY_PF
>has been deleted in the code implementation to ensure that
>VF can flexibly program the MAC address.
Hi, Lunyuan
On 03/25, Lunyuan Cui wrote:
>This patch is intended to add iavf_dev_reset ops, enable iavf to support
>"port reset all".
>
>Signed-off-by: Lunyuan Cui
>---
> drivers/net/iavf/iavf_ethdev.c | 19 +++
> 1 file changed, 19 insertions(+)
>
>diff --git a/drivers/net/iavf/ia
On 03/31, Haiyue Wang wrote:
>The ice_memdup doesn't check the new allocated memory pointer, it calls
>the rte_memcpy directly. It should check it.
>
>Fixes: 5f0978e96220 ("net/ice/base: add OS specific implementation")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Haiyue Wang
>---
> drivers/net/ice/base
On 03/23, Qi Zhang wrote:
>To clean up the feature matrix, we decide merge vector path and
>non-vector path into one colume, the patch remove all *_vec."
>of Intel NICs, if a feature only support by non vector path,
>it will be represented as "P".
>
>Qi Zhang (4):
> doc: update i40e feature list
>
Snipped
> diff --git a/lib/librte_eal/linux/eal/eal_vfio.c
> b/lib/librte_eal/linux/eal/eal_vfio.c
> index 01b5ef3..e2fdd35 100644
> --- a/lib/librte_eal/linux/eal/eal_vfio.c
> +++ b/lib/librte_eal/linux/eal/eal_vfio.c
DPDK supports freebsd where `/dev/pci` can be probed like Linux `/sys/bus/pci`.
> -Original Message-
> From: Yang, Qiming
> Sent: Monday, March 30, 2020 4:31 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z ; Yang, Qiming
>
> Subject: [PATCH v2 1/2] net/iavf: support generic flow
>
> This patch added iavf_flow_create, iavf_flow_destroy, iavf_flow_flush and
> iavf_flow_val
> -Original Message-
> From: Sun, GuinanX
> Sent: Tuesday, March 24, 2020 12:37 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z ; Sun, GuinanX
>
> Subject: [PATCH] net/i40e: enable VF to program MAC address
>
> Due to the restriction of the flag I40E_FLAG_VF_MAC_BY_PF, VF cannot
> program the
Hi,
DPDK 20.05-rc1 is planned to be released in less than three weeks.
This is challenging because some patches are missing reviews.
We all want to have our code reviewed and accepted.
It will happen if everybody take time to read ideas,
comment the designs and review the implementations.
Before
26/03/2020 09:04, Morten Brørup:
> From: Jerin Jacob
> > On Fri, Mar 20, 2020 Konstantin Ananyev wrote:
> > >
> > > As was discussed here:
> > > http://mails.dpdk.org/archives/dev/2020-February/158586.html
> > > this RFC aimed to hide ring internals into .c and make all
> > > ring functions non-inl
Hi,
09/03/2020 10:54, Joyce Kong:
> Bitwise operation APIs are defined and used in a lot of PMDs,
> which caused a huge code duplication.
Statistics of the series: 653 insertions(+), 326 deletions(-)
I would not say it is a huge duplication.
> To reduce duplication,
> this patch consolidates the
The multi-stride operations now allow to reduce a stride size
while supporting Jumbo frames. That means that it is possible
to have mbufs configured with a size smaller than the whole
packet received. It is not an issue during normal MPRQ operations
since we attach external buffers instead of copyi
In order to support the 9K MTU the MPRQ feature should be updated
to allow a packet to take more than one stride (single linear buffer).
Receiving a packet into multiple adjacent strides should be implemented.
The reason preventing the packet to be received into multiple strides is
that the data bu
MPRQ feature should be updated to allow a packet to be received
into multiple strides in order to support the MTU exceeding 8KB.
Special care is needed to prevent the headroom corruption in the
multi-stride mode since the headroom space is borrowed by the PMD
from the tail of the preceding stride.
Provide a descriptin of a newly added mprq_log_stride_size devarg
parameter for specifying a stride size in case of MPRQ Rx is on.
Signed-off-by: Alexander Kozyrev
---
doc/guides/nics/mlx5.rst | 9 +
doc/guides/rel_notes/release_20_05.rst | 1 +
2 files changed, 10 insertio
Define a device parameter to configure log 2 of a stride size for MPRQ
- mprq_log_stride_size. User is able to specify a stride size in a range
allowed by an underlying hardware. The default stride size is defined as
2048 bytes to encompass most commonly used packet sizes in the Internet
(MTU 1518
>
> 26/03/2020 18:28, Medvedkin, Vladimir:
> > Hi Yipeng, Stephen, all,
> >
> > On 17/03/2020 19:52, Wang, Yipeng1 wrote:
> > > From: Stephen Hemminger
> > >> On Mon, 16 Mar 2020 18:27:40 +
> > >> "Medvedkin, Vladimir" wrote:
> > >>
> > >>> Hi Morten,
> > >>>
> > >>>
> > >>> On 16/03/2020
0-day Robot writes:
> From: ro...@bytheb.org
>
> Test-Label: travis-robot
> Test-Status: WARNING
> http://dpdk.org/patch/67494
>
> _Travis build: failed_
> Build URL: https://travis-ci.com/ovsrobot/dpdk/builds/157275800
D'oh! Thanks 0-day Robot. :-/ v2 coming soon.
Greetings DPDK Project Community:
We hope you are managing okay and remaining safe and healthy as the
coronavirus crisis has thrown the world into a frenzy. While many of
us are used to working remotely and using online collaborative tools,
we are having to adapt to new circumstances at home. It
31/03/2020 21:56, Neil Horman:
> On Tue, Mar 31, 2020 at 02:29:08PM +0200, Thomas Monjalon wrote:
> > 31/03/2020 14:17, Neil Horman:
> > > On Tue, Mar 31, 2020 at 01:25:25PM +0200, Thomas Monjalon wrote:
> > > > Hi,
> > > >
> > > > Raising this topic again.
> > > >
> > > > As said in the past, it
31/03/2020 21:51, Neil Horman:
> On Tue, Mar 31, 2020 at 07:58:45AM -0700, Stephen Hemminger wrote:
> > On Tue, 31 Mar 2020 12:39:17 +
> > Michael Lilja wrote:
> >
> > > Hi,
> > >
> > > I appreciate the discussion. It would of course be nice if vendors could
> > > be allowed to use external
On Tue, Mar 31, 2020 at 02:29:08PM +0200, Thomas Monjalon wrote:
> 31/03/2020 14:17, Neil Horman:
> > On Tue, Mar 31, 2020 at 01:25:25PM +0200, Thomas Monjalon wrote:
> > > Hi,
> > >
> > > Raising this topic again.
> > >
> > > As said in the past, it is better to have this PMD inside DPDK.
> > >
26/03/2020 18:28, Medvedkin, Vladimir:
> Hi Yipeng, Stephen, all,
>
> On 17/03/2020 19:52, Wang, Yipeng1 wrote:
> > From: Stephen Hemminger
> >> On Mon, 16 Mar 2020 18:27:40 +
> >> "Medvedkin, Vladimir" wrote:
> >>
> >>> Hi Morten,
> >>>
> >>>
> >>> On 16/03/2020 14:39, Morten Brørup wrote:
On Tue, Mar 31, 2020 at 07:58:45AM -0700, Stephen Hemminger wrote:
> On Tue, 31 Mar 2020 12:39:17 +
> Michael Lilja wrote:
>
> > Hi,
> >
> > I appreciate the discussion. It would of course be nice if vendors could be
> > allowed to use external libraries/drivers and have a DPDK shim but I a
10/03/2020 15:47, Medvedkin, Vladimir:
> On 10/03/2020 09:13, Andrzej Ostruszka wrote:
> > None of the public functions modify IPv6 address passed. So their
> > parameters are made const - with the exception of bulk functions.
> > This exception is due to compatibility problems - some compilers re
From: Nithin Dabilpuram
Add changes to ethdev port and queue configuration based
on command line parameters for l3fwd graph application.
Signed-off-by: Nithin Dabilpuram
---
examples/l3fwd-graph/main.c | 350 +++-
1 file changed, 349 insertions(+), 1 deletion(-)
From: Nithin Dabilpuram
Add ip4_rewrite and ip4_lookup ctrl API. ip4_lookup ctrl
API is used to add route entries for LPM lookup with
result data containing next hop id and next proto.
ip4_rewrite ctrl API is used to add rewrite data for
every next hop.
Signed-off-by: Nithin Dabilpuram
Signed-o
From: Nithin Dabilpuram
Add graph based l3fwd application skeleton with cmdline
parsing support inline with normal l3fwd.
Signed-off-by: Nithin Dabilpuram
---
MAINTAINERS | 3 +
examples/Makefile| 3 +
examples/l3fwd-graph/Makefile| 58
exampl
From: Nithin Dabilpuram
Add packet drop node process function for pkt_drop
rte_node. This node simply free's every object received as
an rte_mbuf to its rte_pktmbuf pool.
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Kiran Kumar K
---
lib/librte_node/Makefile
From: Nithin Dabilpuram
Adding the user guide for l3fwd graph application.
Signed-off-by: Nithin Dabilpuram
---
MAINTAINERS | 1 +
doc/guides/rel_notes/release_20_05.rst| 8 +
doc/guides/sample_app_ug/index.rst| 1 +
doc/guides/sample
From: Nithin Dabilpuram
Add graph creation, configuration logic and graph main loop.
This graph main loop is run on every slave lcore and calls
rte_graph_walk() to walk over lcore specific rte_graph.
Master core accumulates and prints graph walk stats of all the
lcore's graph's.
Signed-off-by: N
From: Kiran Kumar K
Add ip4 rewrite process function for ip4_rewrite
rte_node. On every packet received by this node,
header is overwritten with new data before forwarding
it to next node. Header data to overwrite with is
identified by next hop id passed in mbuf priv data
by previous node.
Signe
From: Nithin Dabilpuram
Add arm64 specific IPv4 lookup process function
for ip4_lookup node. This node performs LPM lookup
on every packet received and forwards it to a next
node that is identified by lookup result.
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Kiran Kumar K
Signed-off-by: P
From: Nithin Dabilpuram
Add ctrl api to setup ethdev_rx and ethdev_tx node.
This ctrl api clones 'N' number of ethdev_rx and ethdev_tx
nodes with specific (port, queue) pairs updated in their context.
All the ethdev ports and queues are setup before this api
is called.
Signed-off-by: Nithin Dabi
From: Pavan Nikhilesh
Add IPv4 lookup process function for ip4_lookup node.
This node performs LPM lookup using simple RTE_LPM API on every packet
received and forwards it to a next node that is identified by lookup
result.
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
d
From: Pavan Nikhilesh
Add IPv4 lookup process function for ip4_lookup
rte_node. This node performs LPM lookup using x86_64
vector supported RTE_LPM API on every packet received
and forwards it to a next node that is identified by
lookup result.
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nith
From: Nithin Dabilpuram
Add rte_node ethdev_tx process function and register it to
graph infra. This node has a specific (port, tx-queue) as context
and it enqueue's all the packets received to that specific queue pair.
When rte_eth_tx_burst() i.e enqueue to queue pair fails, packets
are forwarde
From: Nithin Dabilpuram
Add source rte_node ethdev_rx process function and register
it. This node is a source node that will be called periodically
and when called, performs rte_eth_rx_burst() on a specific
(port, queue) pair and enqueue them as stream of objects to
next node.
Signed-off-by: Nit
From: Jerin Jacob
Adding implementation for rte_graph_walk() API. This will perform a walk
on the circular buffer and call the process function of each node
and collect the stats if stats collection is enabled.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhil
From: Pavan Nikhilesh
Add unit test framework to create and test performance of various graph
models.
example command to test:
echo "graph_perf_autotest" | sudo ./build/app/test/dpdk-test -c 0x30
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
app/test/Makefile
From: Nithin Dabilpuram
Add log infra for node specific logging.
Also, add null rte_node that just ignores all the objects
directed to it.
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Kiran Kumar K
---
MAINTAINERS | 5 +
app/tes
From: Jerin Jacob
Adding implementation for graph stats collection API. This API will
create a cluster for a specified node pattern and aggregate the node
runtime stats.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
--
From: Kiran Kumar K
Adding the unit test to test the functionality of node and graph APIs.
Testing includes registering a node, cloning a node, creating a graph,
perform graph walk, collecting stats and all node and graph debug APIs.
example command to test:
echo "graph_autotest" | sudo ./build/
From: Jerin Jacob
Adding implementation for graph specific API to dump the
Graph information to a file. This API will dump detailed internal
info about node objects and graph objects.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin
From: Jerin Jacob
Adding graph specific API implementations like graph create
and graph destroy. This detect loops in the graph,
check for isolated nodes and operation to verify the validity of
graph.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signe
From: Jerin Jacob
Adding API implementation support exporting the graph object to file.
This will export the graph to a file in Graphviz format.
It can be viewed in many viewers such as
https://dreampuf.github.io/GraphvizOnline/
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-of
From: Jerin Jacob
Adding support for graph specific API implementation like
Graph lookup to get graph object, retrieving graph ID
>From name and graph name from ID.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
li
From: Jerin Jacob
Adding support to create and populate the memory for graph reel.
This includes reserving the memory in the memzone, populating the nodes,
Allocating memory for node-specific streams to hold objects.
Once it is populated the reel memory contains the following sections.
+---
From: Jerin Jacob
Adding node-specific API implementation like cloning node, updating
edges for the node, shrinking edges of a node, retrieving edges of a
node.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
lib/li
From: Jerin Jacob
Adding internal graph API helpers support to check whether a graph has
isolated nodes and any node have a loop to itself and BFS
algorithm implementation etc.
Signed-off-by: Jerin Jacob
Signed-off-by: Nithin Dabilpuram
---
lib/librte_graph/Makefile| 1 +
lib/librte
From: Jerin Jacob
Adding node debug API implementation support to dump
single or all the node objects to the given file.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
lib/librte_graph/Makefile | 1 +
From: Jerin Jacob
Using graph traversal for packet processing is a proven architecture
that has been implemented in various open source libraries.
Graph architecture for packet processing enables abstracting the data
processing functions as “nodes” and “links” them together to create a
complex “
From: Jerin Jacob
Adding rte_node_register() API implementation includes allocating
memory for node object, check for duplicate node name and
add the allocated node to STAILQ node_list for future use.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signe
From: Jerin Jacob
Graph architecture abstracts the data processing functions as
"node" and "link" them together to create a complex "graph" to enable
reusable/modular data processing functions.
These APIs enables graph framework operations such as create, lookup,
dump and destroy on graph and no
31/03/2020 21:22, Thomas Monjalon:
> 31/03/2020 19:05, Ananyev, Konstantin:
> > Hi everyone,
> >
> > Have a question regarding validate-abi.sh.
>
> devtools/validate-abi.sh should be removed.
> Please use the new devtools/check-abi.sh
The file doc/guides/contributing/abi_versioning.rst
should be
31/03/2020 19:05, Ananyev, Konstantin:
> Hi everyone,
>
> Have a question regarding validate-abi.sh.
devtools/validate-abi.sh should be removed.
Please use the new devtools/check-abi.sh
On Tue, Mar 31, 2020 at 5:23 AM Ferruh Yigit wrote:
> On 3/3/2020 5:59 PM, Stephen Hemminger wrote:
> > This set of patches came from security review of bnxt driver.
> > It introduces a set of overflow macros that could be more widely
> > used in other places in DPDK to check for math overflows.
On Tue, 31 Mar 2020 10:52:47 -0700
Ajit Khaparde wrote:
> On Tue, Mar 31, 2020 at 5:23 AM Ferruh Yigit wrote:
>
> > On 3/3/2020 5:59 PM, Stephen Hemminger wrote:
> > > This set of patches came from security review of bnxt driver.
> > > It introduces a set of overflow macros that could be more
On 3/31/2020 4:19 PM, Wang, Haiyue wrote:
>> -Original Message-
>> From: Yigit, Ferruh
>> Sent: Tuesday, March 31, 2020 21:25
>> To: Wang, Haiyue ; dev@dpdk.org; Ye, Xiaolong
>>
>> Subject: Re: [PATCH v2] doc: use svg file type for ice
>>
>> On 3/31/2020 1:06 PM, Haiyue Wang wrote:
>>> R
On 3/31/2020 6:43 PM, Ferruh Yigit wrote:
> On 3/31/2020 6:31 PM, Stephen Hemminger wrote:
>> While working on netvsc driver, noticed that there are still some places
>> in some drivers using the old PMD static logtype. Would like to
>> eradicate all of these and even mark it as deprecated in a fu
-Original Message-
From: Eduard Serra Miralles
Date: Wednesday, March 25, 2020 at 12:19 PM
To: "dev@dpdk.org"
Cc: Yong Wang
Subject: [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU.
(Picked up from @Charles Myers patch
https://patchwork.dpdk.org/patch/5777
On 3/31/2020 6:31 PM, Stephen Hemminger wrote:
> While working on netvsc driver, noticed that there are still some places
> in some drivers using the old PMD static logtype. Would like to
> eradicate all of these and even mark it as deprecated in a future
> release.
>
> v2 - fix checkpatch whites
On 3/31/2020 5:41 AM, Stephen Hemminger wrote:
> While working on netvsc driver, noticed that there are still some places
> in some drivers using the old PMD static logtype. Would like to
> eradicate all of these and even mark it as deprecated in a future
> release.
>
> Stephen Hemminger (7):
>
The PMD static logtype is original DPDK legacy and should not be used.
Fixes: 43362c6a7647 ("net/thunderx: support RSS and RETA query and update")
Cc: jerin.ja...@caviumnetworks.com
Signed-off-by: Stephen Hemminger
---
drivers/net/thunderx/nicvf_ethdev.c | 17 +
1 file changed, 9
Accidental use of PMD logtype rather than per-driver logtype.
Fixes: 14255b351537 ("net/bnxt: fix queue start/stop operations")
Cc: ajit.khapa...@broadcom.com
Signed-off-by: Stephen Hemminger
---
drivers/net/bnxt/bnxt_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
The static PMD logtype should not be used by drivers.
Instead, use existing log macros in this driver.
Also use standard rte_ether routine to format ether address.
Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup")
Cc: shreyansh.j...@nxp.com
Signed-off-by: Stephen Hemminger
---
dri
Virtio driver has its own logtype adn should not use legacy
PMD logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/virtio/virtio_rxtx.c| 6 +++---
drivers/net/virtio/virtio_user_ethdev.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/virtio/virt
The PMD logtype is legacy and drivers should use their own logtype.
Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)")
Cc: ophi...@mellanox.com
Signed-off-by: Stephen Hemminger
---
drivers/net/tap/rte_eth_tap.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --g
The PMD logtype is a legacy from original DPDK logging.
All drivers must use their own dynamic log type.
Fixes: b1bc1afa4a0e ("net/pfe: support dynamic logging")
Cc: g.si...@nxp.com
Signed-off-by: Stephen Hemminger
---
drivers/net/pfe/pfe_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
The PMD logtype is legacy and should not be used.
Fixes: 3378383dceab ("net/mvneta: support statistics reset")
Cc: nsams...@marvell.com
Signed-off-by: Stephen Hemminger
---
drivers/net/mvneta/mvneta_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mvneta/m
While working on netvsc driver, noticed that there are still some places
in some drivers using the old PMD static logtype. Would like to
eradicate all of these and even mark it as deprecated in a future
release.
v2 - fix checkpatch whitespace complaints
Stephen Hemminger (7):
net/mvneta: do no
From: Pavan Nikhilesh
Fix improper byte order conversion used to extract fragmentation offset in
ipv6 reassembly.
Fixes: 4f1a8f633862 ("ip_frag: add IPv6 reassembly")
Cc: sta...@dpdk.org
Signed-off-by: Pavan Nikhilesh
---
lib/librte_ip_frag/rte_ipv6_reassembly.c | 2 +-
1 file changed, 1 inse
>
> >
> > > >
> > > > > Subject: [dpdk-dev] [RFC 0/6] New sync modes for ring
> > > > >
> > > > > Upfront note - that RFC is not a complete patch.
> > > > > It introduces an ABI breakage, plus it doesn't update ring_elem
> > > > > code properly,
> > > > As per the current rules, these changes (in
Since the ring buffer with host is shared for both transmit
completions and receive packets, it is possible that transmitter
could get starved if receive ring gets full.
Better to process all outstanding events which frees up transmit
buffer slots, even if means dropping some packets.
Fixes: 7e6c
Remove unlocked check for data in receive ring.
This check is not safe because of missing barriers etc.
Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/net/netvsc/hn_rxtx.c | 4
1 file changed, 4 deletions(-)
d
The VMBus has reserved transmit area (per device) and transmit descriptors
(per queue). The previous code was always having a 1:1 mapping between
send buffers and descriptors. This can lead to one queue starving another
and also buffer bloat.
Change to working more like FreeBSD where there is a po
The transmit need signal function can avoid an unnecessary
dereference by passing the right pointer. This also makes
code better match FreeBSD driver.
Signed-off-by: Stephen Hemminger
---
drivers/bus/vmbus/vmbus_bufring.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
The netvsc PMD was putting the mac address in private data but the
core rte_ethdev doesn't allow that it. It has to be in rte_malloc'd
memory or the a message will be printed on shutdown/close.
EAL: Invalid memory
Fixes: f8279f47dd89 ("net/netvsc: fix crash in secondary process")
Cc: sta...@dpdk.
If tx_free_thresh is quite low, it is possible that we need to
cleanup based on burst size.
Fixes: fc30efe3a22e ("net/netvsc: change Rx descriptor setup and sizing")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/net/netvsc/hn_rxtx.c | 5 +++--
1 file changed, 3 insertions(+),
It is possible for a packet to arrive during the configuration
process when setting up multiple queue mode. This would cause
configure to fail; fix by just ignoring receive packets while
waiting for control commands.
Use the receive ring lock to avoid possible races between
oddly behaved applicati
31/03/2020 17:58, Stephen Hemminger:
> On Tue, 31 Mar 2020 17:43:55 +0200
> Thomas Monjalon wrote:
> > 31/03/2020 16:31, Ajit Khaparde:
> > > On Tue, Mar 31, 2020 at 4:36 AM Ferruh Yigit
> > > wrote:
> > > > I saw Ajit merged this patch to brcm tree, but I am not sure about it.
> > > > We
> > >
If application cares about descriptor limits, the netvsc device
values should reflect those of the VF as well.
Fixes: dc7680e8597c ("net/netvsc: support integrated VF")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/net/netvsc/hn_vf.c | 13 +
1 file changed, 13 inse
These are bug fixes for netvsc PMD mostly related to issues
in the transmit ring discovered by users of multi-queue.
v4 - add more bug fixes
v3 - fix checkpatch complaints
v2 - simplify the locking on multi-channel setup
Stephen Hemminger (8):
net/netvsc: propagate descriptor limits from VF to
On 3/31/20 2:53 PM, pbhagavat...@marvell.com wrote:
> From: Pavan Nikhilesh
>
> Current l2fwd-event application statically configures adjacent ports as
> destination ports for forwarding the traffic.
>
> Add a config option to pass the forwarding port pair mapping which allows
> the user to conf
This fix treats a 0 return value from vfio_open_group_fd
in vfio_get_group_fd as the intended error condition instead
of putting an incorrect 0 file descriptor in the vfio_group table.
Sometimes, the creation of device files in sysfs is not
instantaneously causing vfio_open_groupfd to return 0.
Th
Hi everyone,
Have a question regarding validate-abi.sh.
It complains on the following changes with that patch:
@@ -111,11 +129,21 @@ struct rte_ring {
char pad0 __rte_cache_aligned; /**< empty cache line */
/** Ring producer status. */
- struct rte_ring_headtail prod __rte_
This fix treats a 0 return value from vfio_open_group_fd
in vfio_get_group_fd as the intended error condition instead
of putting an incorrect 0 file descriptor in the vfio_group table.
Sometimes, the creation of device files in sysfs is not
instantaneously causing vfio_open_groupfd to return 0.
Th
Introduce new test case to test HTS ring mode under contention.
Signed-off-by: Konstantin Ananyev
---
app/test/Makefile | 1 +
app/test/meson.build| 1 +
app/test/test_ring_hts_stress.c | 32
app/test/test_ring_stress.c | 3 +++
a
For rings with producer/consumer in RTE_RING_SYNC_ST, RTE_RING_SYNC_MT_HTS
mode, provide an ability to split enqueue/dequeue operation
into two phases:
- enqueue/dequeue start
- enqueue/dequeue finish
That allows user to inspect objects in the ring without removing
them from it (aka MT
Introduce new test case to test RTS ring mode under contention.
Signed-off-by: Konstantin Ananyev
---
app/test/Makefile | 1 +
app/test/meson.build| 1 +
app/test/test_ring_rts_stress.c | 32
app/test/test_ring_stress.c | 3 +++
a
Introduce new test case to test MT peek API.
Signed-off-by: Konstantin Ananyev
---
app/test/Makefile| 1 +
app/test/meson.build | 1 +
app/test/test_ring_peek_stress.c | 43
app/test/test_ring_stress.c | 3 +++
app/test/test_ri
Introduce head/tail sync mode for MT ring synchronization.
In that mode enqueue/dequeue operation is fully serialized:
only one thread at a time is allowed to perform given op.
Suppose to reduce stall times in case when ring is used on
overcommitted cpus (multiple active threads on the same cpu).
RFC - V1 changes:
1. remove ABI brekage (at least I hope I did)
2. Add support for ring_elem
3. Rework peek related API a bit
4. Rework test to make it less verbose and unite all test-cases
in one command
5. Add new test-case for MT peek API
TODO list:
1. Add C11 atomics support
2. Update docs
Introduce relaxed tail sync (RTS) mode for MT ring synchronization.
Aim to reduce stall times in case when ring is used on
overcommited cpus (multiple active threads on the same cpu).
The main difference from original MP/MC algorithm is that
tail value is increased not by every thread that finished
1 - 100 of 200 matches
Mail list logo
