Re: [dpdk-dev] [PATCH v4 16/29] node: add ethdev Rx node

2020-04-10 Thread Nithin Dabilpuram
On Fri, Apr 10, 2020 at 01:05:08AM +0200, Andrzej Ostruszka wrote: > On 4/5/20 10:56 AM, jer...@marvell.com wrote: > > From: Nithin Dabilpuram > > > > Add source rte_node ethdev_rx process function and register > > it. This node is a source node that will be called periodically > > and when calle

Re: [dpdk-dev] [RFC v1 1/1] vfio: set vf token and gain vf device access

2020-04-10 Thread Vamsi Krishna Attunuru
Hi Vipin, Please see inline. > -Original Message- > From: dev On Behalf Of Varghese, Vipin > Sent: Wednesday, April 1, 2020 8:45 AM > To: Vamsi Krishna Attunuru ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; > alex.william...@redhat.com; tho...@monjalon.net; > david.march...@redhat.com

Re: [dpdk-dev] [PATCH v4 23/29] node: add ipv4 rewrite and lookup ctrl API

2020-04-10 Thread Nithin Dabilpuram
On Fri, Apr 10, 2020 at 01:04:37AM +0200, Andrzej Ostruszka wrote: > On 4/5/20 10:56 AM, jer...@marvell.com wrote: > > From: Nithin Dabilpuram > > > > Add ip4_rewrite and ip4_lookup ctrl API. ip4_lookup ctrl > > API is used to add route entries for LPM lookup with > > result data containing next

Re: [dpdk-dev] [RFC v1 1/1] vfio: set vf token and gain vf device access

2020-04-10 Thread Vamsi Krishna Attunuru
Hi Wang, > -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Thursday, April 2, 2020 6:13 PM > To: Vamsi Krishna Attunuru ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; > alex.william...@redhat.com; tho...@monjalon.net; > david.march...@redhat.com > Subject: Re: [dpdk-dev

Re: [dpdk-dev] [PATCH v2 1/5] net/iavf: add support for FDIR basic rule

2020-04-10 Thread Cao, Yahui
> -Original Message- > From: Su, Simei > Sent: Thursday, April 2, 2020 9:33 PM > To: Zhang, Qi Z ; Ye, Xiaolong ; > Wu, Jingjing > Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei > > Subject: [PATCH v2 1/5] net/iavf: add support for FDIR basic rule > > This patch adds FDIR create/destroy/va

[dpdk-dev] [RFC v2] eal: add VFIO-PCI SR-IOV support

2020-04-10 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. An example VF token option would take this form: 1. ./usertools/dpdk-devbind

Re: [dpdk-dev] [RFC v1 1/1] vfio: set vf token and gain vf device access

2020-04-10 Thread Wang, Haiyue
Hi Vamsi, Fixed one dev_args issue, and send the whole patch to express the whole design: https://patchwork.dpdk.org/patch/68114/ BR, Haiyue > -Original Message- > From: Vamsi Krishna Attunuru > Sent: Friday, April 10, 2020 15:28 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Jerin Jacob Kolla

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-10 Thread Ferruh Yigit
On 4/10/2020 2:41 AM, wangyunjian wrote: >> -Original Message- >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Thursday, April 9, 2020 10:51 PM >> To: wangyunjian >> Cc: Ferruh Yigit ; dev@dpdk.org; >> keith.wi...@intel.com; Lilijun (Jerry) ; xudingke >> ; sta...@dp

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-10 Thread Thomas Monjalon
10/04/2020 08:26, Ray Kinsella: > On 09/04/2020 17:51, Thomas Monjalon wrote: > > 09/04/2020 18:29, Ray Kinsella: > >> On 09/04/2020 16:18, Thomas Monjalon wrote: > >>> 09/04/2020 16:52, Ray Kinsella: > On 09/04/2020 11:59, Thomas Monjalon wrote: > > 09/04/2020 12:45, Ray Kinsella: > >

Re: [dpdk-dev] [PATCH v2 1/5] net/iavf: add support for FDIR basic rule

2020-04-10 Thread Su, Simei
Hi, Yahui > -Original Message- > From: Cao, Yahui > Sent: Friday, April 10, 2020 3:40 PM > To: Su, Simei ; Zhang, Qi Z ; Ye, > Xiaolong ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 1/5] net/iavf: add support for FDIR basic rule > > > > > -Original Message- > > Fr

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-10 Thread David Marchand
On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš wrote: > libjansson4 is not enough to build telemetry. Replace it with > libjansson-dev. Fixes: 99889bd85228 ("ci: introduce Travis builds for GitHub repositories") Cc: sta...@dpdk.org > Signed-off-by: Juraj Linkeš Acked-by: Aaron Conole Reviewed-by

Re: [dpdk-dev] [PATCH v4 18/29] node: add ethdev Rx and Tx node ctrl API

2020-04-10 Thread Nithin Dabilpuram
On Fri, Apr 10, 2020 at 10:39:44AM +0530, Nithin Dabilpuram wrote: > On Fri, Apr 10, 2020 at 01:07:17AM +0200, Andrzej Ostruszka wrote: > > On 4/5/20 10:56 AM, jer...@marvell.com wrote: > > > From: Nithin Dabilpuram > > > > > > Add ctrl api to setup ethdev_rx and ethdev_tx node. > > > This ctrl a

Re: [dpdk-dev] [PATCH v4 25/29] l3fwd-graph: add graph based l3fwd skeleton

2020-04-10 Thread Nithin Dabilpuram
On Fri, Apr 10, 2020 at 01:04:20AM +0200, Andrzej Ostruszka wrote: > On 4/5/20 10:56 AM, jer...@marvell.com wrote: > > From: Nithin Dabilpuram > > > > Add graph based l3fwd application skeleton with cmdline > > parsing support inline with normal l3fwd. > > > > Signed-off-by: Nithin Dabilpuram >

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/6] net/null: fix secondary burst function selection

2020-04-10 Thread Ferruh Yigit
On 4/7/2020 9:38 AM, Ferruh Yigit wrote: > On 3/2/2020 5:36 PM, Ferruh Yigit wrote: >> Secondary process uses the primary process device and while setting the >> Rx/Tx functions it uses the device arguments from the secondary process >> instead of the primary ones. >> >> This may cause primary and

Re: [dpdk-dev] [PATCH v3 1/2] net/hinic/base: fix FW hotactive problem

2020-04-10 Thread Wangxiaoyun (Cloud)
Hi Ferruch, I will upstream a new patch to clarify the comments. Best regards xiaoyun wang 在 2020/4/4 1:24, Ferruh Yigit 写道: On 4/1/2020 10:30 AM, Xiaoyun wang wrote: When PF detects FW is hotactive, up returns HINIC_DEV_BUSY_ACTIVE_FW for Hi Xiaoyun, What is 'hotactive'? "hot active"? D

Re: [dpdk-dev] [PATCH v2 11/16] examples/l3fwd-power: enable use of new telemetry

2020-04-10 Thread Pattan, Reshma
> -Original Message- > From: Power, Ciara > --- > - > +#define NUM_TELSTATS RTE_DIM(telstats_strings) > > + > +static void > +update_telemetry(__attribute__((unused)) struct rte_timer *tim, > + __attribute__((unused)) void *arg) > + uint64_t values[3] = {0}; Use NUM_TE

Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list

2020-04-10 Thread Ferruh Yigit
On 10/25/2019 2:39 PM, Jerin Jacob wrote: > On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon wrote: >> >> 25/10/2019 14:51, Ferruh Yigit: >>> "Flow API" is a method/API to implement various filtering features, on >>> its own it doesn't give much context on what features are provided. And >>> it is

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-10 Thread Bruce Richardson
On Thu, Apr 09, 2020 at 06:10:11PM +0200, Lukasz Wojciechowski wrote: > > W dniu 09.04.2020 o 17:22, Thomas Monjalon pisze: > > 09/04/2020 16:21, Lukasz Wojciechowski: > >> W dniu 09.04.2020 o 16:07, Lukasz Wojciechowski pisze: > >>> W dniu 09.04.2020 o 13:13, Bruce Richardson pisze: > On Thu

Re: [dpdk-dev] [PATCH 1/2] doc: add PMD filtering features back

2020-04-10 Thread Ferruh Yigit
On 10/25/2019 2:23 PM, Thomas Monjalon wrote: > 25/10/2019 14:51, Ferruh Yigit: >> Also filter definitions should be clarified more in the features >> documentation so that all PMDs can easily figure out to announce or >> not these filtering features, also users can understand better what to >> exp

Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list

2020-04-10 Thread Thomas Monjalon
10/04/2020 10:44, Ferruh Yigit: > On 10/25/2019 2:39 PM, Jerin Jacob wrote: > > On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon wrote: > >> > >> 25/10/2019 14:51, Ferruh Yigit: > >>> "Flow API" is a method/API to implement various filtering features, on > >>> its own it doesn't give much context o

[dpdk-dev] [PATCH v4 2/3] net/hinic/base: optimize log style

2020-04-10 Thread Xiaoyun wang
The patch adds space between descriptors and variables in log files. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_hwdev.c | 4 ++-- drivers/net/hinic/base/hinic_pmd_hwif.c | 4 ++-- drivers/net/hinic/base/hinic_pmd_mgmt.c | 2 +- drivers/net/hinic/base/hinic_pmd_niccfg.c

[dpdk-dev] [PATCH v4 0/3] Fix and add txq xstats

2020-04-10 Thread Xiaoyun wang
This patch fixes PF firmware hotactive problem, optimizes log style and adds txq xstats members. -- v3->v4: - fix PF firmware hotactive problem - optimize log style - adds txq xstats members v2->v3: - fix FW hotactive problem - optimize log style v1->v2: - Fix LRO problems - Fi

[dpdk-dev] [PATCH v4 1/3] net/hinic/base: fix PF firmware hotactive problem

2020-04-10 Thread Xiaoyun wang
When FW is hotactive which means updating the FW but not needs to reboot OS, FW returns HINIC_DEV_BUSY_ACTIVE_FW for pf driver because firmware is being reinitialized, at which point the cmdq initialization that relies on the fw channel will fail, so driver should reinit the cmdq when port start.

[dpdk-dev] [PATCH v4 3/3] net/hinic: adds txq xstats member

2020-04-10 Thread Xiaoyun wang
Because some APPs may pass illegal parameters, driver increases checks on illegal parameters and DFX statistics, which includes sge_len0 and mbuf_null txq xstats member. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c | 2 ++ drivers/net/hinic/hinic_pmd_tx.c | 31 ++

[dpdk-dev] [PATCH v4] build: enable allow experimental API flag

2020-04-10 Thread pbhagavatula
From: Pavan Nikhilesh Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and meson.build instead enable ALLOW_EXPERIMENTAL_API flag across app, lib and drivers. This changes reduces the clutter across the project while still maintaining the functionality of ALLOW_EXPERIMENTAL_AP

Re: [dpdk-dev] [dpdk.org] [PATCH] fib: add "C" extern linkage for C++ programs

2020-04-10 Thread David Marchand
On Wed, Mar 25, 2020 at 2:21 PM David Marchand wrote: > On Mon, Mar 16, 2020 at 8:22 PM Muhammad Asim Jamshed > wrote: > > > > This patch allows C++ programs to use librte_fib library routines. > > Previously C++ programs were not able to link this library and programs > > would fail to get linke

Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 2:26 PM Thomas Monjalon wrote: > > 10/04/2020 10:44, Ferruh Yigit: > > On 10/25/2019 2:39 PM, Jerin Jacob wrote: > > > On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon > > > wrote: > > >> > > >> 25/10/2019 14:51, Ferruh Yigit: > > >>> "Flow API" is a method/API to implemen

Re: [dpdk-dev] [PATCH v4 00/29] graph: introduce graph subsystem

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 4:43 AM Andrzej Ostruszka wrote: > > On 4/5/20 10:55 AM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Using graph traversal for packet processing is a proven architecture > > that has been implemented in various open source libraries. > > > > Graph architecture

Re: [dpdk-dev] [PATCH v4 12/29] graph: implement fastpath API routines

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 4:37 AM Andrzej Ostruszka wrote: > > On 4/5/20 10:55 AM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Adding implementation for rte_graph_walk() API. This will perform a walk > > on the circular buffer and call the process function of each node > > and collect t

Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list

2020-04-10 Thread Thomas Monjalon
10/04/2020 11:04, Jerin Jacob: > On Fri, Apr 10, 2020 at 2:26 PM Thomas Monjalon wrote: > > 10/04/2020 10:44, Ferruh Yigit: > > > On 10/25/2019 2:39 PM, Jerin Jacob wrote: > > > > On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon > > > > wrote: > > > >> > > > >> 25/10/2019 14:51, Ferruh Yigit: > >

Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list

2020-04-10 Thread Ferruh Yigit
On 4/10/2020 10:20 AM, Thomas Monjalon wrote: > 10/04/2020 11:04, Jerin Jacob: >> On Fri, Apr 10, 2020 at 2:26 PM Thomas Monjalon wrote: >>> 10/04/2020 10:44, Ferruh Yigit: On 10/25/2019 2:39 PM, Jerin Jacob wrote: > On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon > wrote: >> >>

[dpdk-dev] [PATCH v2] doc: remove flow API from the feature list

2020-04-10 Thread Ferruh Yigit
"Flow API" is a method/API to implement various filtering features, on its own it doesn't give much context on what features are provided. And it is not really a feature, so doesn't fit into feature table. Also since other filtering related APIs, 'filter_ctrl', has been deprecated, flow API is the

Re: [dpdk-dev] [PATCH v4 27/29] l3fwd-graph: add graph config and main loop

2020-04-10 Thread Nithin Dabilpuram
On Fri, Apr 10, 2020 at 01:04:00AM +0200, Andrzej Ostruszka wrote: > On 4/5/20 10:56 AM, jer...@marvell.com wrote: > > From: Nithin Dabilpuram > > > > Add graph creation, configuration logic and graph main loop. > > This graph main loop is run on every slave lcore and calls > > rte_graph_walk() t

[dpdk-dev] [PATCH v2 2/2] doc: remove flow API from the feature list

2020-04-10 Thread Ferruh Yigit
"Flow API" is a method/API to implement various filtering features, on its own it doesn't give much context on what features are provided. And it is not really a feature, so doesn't fit into feature table. Also since other filtering related APIs, 'filter_ctrl', has been deprecated, flow API is the

[dpdk-dev] [PATCH v2 1/2] doc: add PMD filtering features back

2020-04-10 Thread Ferruh Yigit
What has been deprecated is enabling filtering support using the 'filter_ctrl' APIs [1], now same filtering features can be implemented using rte_flow APIs and this is the preferred way for DPDK. Since those filtering features can be enabled via rte_flow too, better to keep them in the feature lis

[dpdk-dev] [PATCH] doc: update flow non-cached mode notes

2020-04-10 Thread Bing Zhao
This patch updates the MLX5 PMD and release notes documentations. Adding the notes of the behavior change that rte flows organization is switched into non-cached mode for applications. Signed-off-by: Bing Zhao --- doc/guides/nics/mlx5.rst | 10 ++ doc/guides/rel_notes/relea

Re: [dpdk-dev] [PATCH v2 09/16] usertools: add new telemetry python script

2020-04-10 Thread Pattan, Reshma
> -Original Message- > From: Power, Ciara Some pylint checks found, good to address valid ones. #pylint-3.6 ./usertools/dpdk-telemetry.py or # pylint ./usertools/dpdk-telemetry.py * Module dpdk-telemetry W: 18, 0: Bad indentation. Found 12 spaces, expected 8 (bad-inden

Re: [dpdk-dev] [PATCH 0/4] app/testfib: testfib app various fixes

2020-04-10 Thread David Marchand
On Mon, Mar 9, 2020 at 1:42 PM Vladimir Medvedkin wrote: > > This patch series fixes compillation problems for some platforms. > Also it enables testfib app build with other applications. > > Vladimir Medvedkin (4): > app/testfib: fix possible uninitialized warning > app/testfib: fix format st

Re: [dpdk-dev] [PATCH] build: add arm 32bit cross compilation to Meson

2020-04-10 Thread Bruce Richardson
On Thu, Apr 09, 2020 at 04:14:48PM +0200, Juraj Linkeš wrote: > * Add arm-linux-gnueabihf cross-file > * Add generic and default arm 32 bit flags to arm meson.build > * Add support for disabling drivers using flags defined in Meson > * Change checks from dpdk_conf.has() to dpdk.conf.get() > * W

[dpdk-dev] [PATCH] ethdev: support flow aging

2020-04-10 Thread BillZhou
One of the reasons to destroy a flow is the fact that no packet matches the flow for "timeout" time. For example, when TCP\UDP sessions are suddenly closed. Currently, there is no any DPDK mechanism for flow aging and the applications use their own ways to detect and destroy aged-out flows. The f

Re: [dpdk-dev] [PATCH] net/i40e: enable PPC altivec support for meson builds

2020-04-10 Thread Bruce Richardson
On Thu, Apr 09, 2020 at 11:20:55AM -0700, David Christensen wrote: > The meson build file does not enable i40e vectorization support for > PPC/altivec systems, even though the existing Makefile does enable the > support. Add the required architecture check and sources line. > > Signed-off-by: Davi

Re: [dpdk-dev] [PATCH v2 09/16] usertools: add new telemetry python script

2020-04-10 Thread Bruce Richardson
On Fri, Apr 10, 2020 at 10:43:18AM +0100, Pattan, Reshma wrote: > > > > -Original Message- > > From: Power, Ciara > > Some pylint checks found, good to address valid ones. > > #pylint-3.6 ./usertools/dpdk-telemetry.py or # pylint > ./usertools/dpdk-telemetry.py > * Modu

Re: [dpdk-dev] [PATCH v2 08/16] ethdev: add callback support fortelemetry

2020-04-10 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, April 9, 2020 10:21 AM > > On Wed, Apr 08, 2020 at 07:16:10PM +0100, Wiles, Keith wrote: > > > > > > > On Apr 8, 2020, at 11:49 AM, Power, Ciara > wrote: > > > > > > From: Bruce Richardson > > > > > > The e

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-10 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, April 4, 2020 9:58 PM > > 04/04/2020 20:30, Andrzej Ostruszka [C]: > > Thomas, > > > > I have replied to the other mail, here I just want to confirm, that > I'm > > fine with the proposed "general messaging" which other librari

[dpdk-dev] DPDK techboard minutes of April 8

2020-04-10 Thread Ferruh Yigit
Meeting notes for the DPDK technical board meeting held on 2020-04-08 Attendees: - Bruce Richardson - Ferruh Yigit (Chair) - Hemant Agrawal - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin

Re: [dpdk-dev] [PATCH] doc: update flow non-cached mode notes

2020-04-10 Thread Thomas Monjalon
10/04/2020 11:36, Bing Zhao: > This patch updates the MLX5 PMD and release notes documentations. > Adding the notes of the behavior change that rte flows organization > is switched into non-cached mode for applications. Please, can it be squashed in the patch doing this change? > + * Flows orga

Re: [dpdk-dev] [PATCH] ethdev: support flow aging

2020-04-10 Thread Thomas Monjalon
10/04/2020 11:46, BillZhou: > One of the reasons to destroy a flow is the fact that no packet matches the > flow for "timeout" time. > For example, when TCP\UDP sessions are suddenly closed. > > Currently, there is no any DPDK mechanism for flow aging and the > applications use their own ways to d

Re: [dpdk-dev] [PATCH v2] fix lacp check system address

2020-04-10 Thread Ferruh Yigit
On 11/26/2019 3:09 PM, podovinnikov wrote: > Hi Ferruh > >> This is bonding patch, please cc bonding maintainers (Chas, instead of John >> W. >> Linville). > Sorry about that. I have 2 patches ( one for af packet, one for bonding). > > I am a little confused. > > >> Can you please give more de

Re: [dpdk-dev] [PATCH] doc: update flow non-cached mode notes

2020-04-10 Thread Bing Zhao
> -Original Message- > From: Thomas Monjalon > Sent: Friday, April 10, 2020 6:10 PM > To: john.mcnam...@intel.com; marko.kovace...@intel.com; Slava > Ovsiienko ; Matan Azrad > ; Bing Zhao > Cc: Shahaf Shuler ; Raslan Darawsheh > ; Ori Kam ; > dev@dpdk.org > Subject: Re: [PATCH] doc: updat

Re: [dpdk-dev] [PATCH v4 19/29] node: add generic ipv4 lookup node

2020-04-10 Thread Nithin Dabilpuram
On Fri, Apr 10, 2020 at 01:07:34AM +0200, Andrzej Ostruszka wrote: > On 4/5/20 10:56 AM, jer...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add IPv4 lookup process function for ip4_lookup node. > > This node performs LPM lookup using simple RTE_LPM API on every packet > > received and fo

[dpdk-dev] [PATCH v3 0/5] net/iavf: support FDIR capabiltiy

2020-04-10 Thread Simei Su
[PATCH 1/5] support FDIR common patterns and actions. [PATCH 2/5] support FDIR GTPU pattern. [PATCH 3/5] support FDIR L2TPv3, ESP, AH and NAT-T pattern. [PATCH 4/5] support FDIR PFCP node and session pattern. [PATCH 5/5] support FDIR mark action. This patchset depend on the following patches on pa

[dpdk-dev] [PATCH v3 2/5] net/iavf: add support for FDIR GTPU

2020-04-10 Thread Simei Su
This patch enables GTPU with TEID and QFI for flow director filter. Signed-off-by: Simei Su --- drivers/net/iavf/iavf_fdir.c | 63 1 file changed, 63 insertions(+) diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index f2b10d7

[dpdk-dev] [PATCH v3 1/5] net/iavf: add support for FDIR basic rule

2020-04-10 Thread Simei Su
This patch adds FDIR create/destroy/validate function in AVF. Common pattern and queue/qgroup/passthru/drop actions are supported. Signed-off-by: Simei Su --- doc/guides/rel_notes/release_20_05.rst | 1 + drivers/net/iavf/Makefile | 1 + drivers/net/iavf/iavf.h|

[dpdk-dev] [PATCH v3 4/5] net/iavf: add support for FDIR PFCP

2020-04-10 Thread Simei Su
This patch enables PFCP node and sesssion packets with S_FIELD for flow director filter. Signed-off-by: Simei Su --- drivers/net/iavf/iavf_fdir.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index 58d

[dpdk-dev] [PATCH v3 3/5] net/iavf: add support for FDIR L2TPv3 and IPSec

2020-04-10 Thread Simei Su
This patch enables L2TPv3 with SESSION_ID, ESP/AH with SPI, NAT-T with SPI and IP src/dst for flow director filter. Signed-off-by: Simei Su --- drivers/net/iavf/iavf_fdir.c | 91 1 file changed, 91 insertions(+) diff --git a/drivers/net/iavf/iavf_fdi

Re: [dpdk-dev] [PATCH v2] fix lacp check system address

2020-04-10 Thread Ferruh Yigit
On 4/10/2020 11:15 AM, Ferruh Yigit wrote: > On 11/26/2019 3:09 PM, podovinnikov wrote: >> Hi Ferruh >> >>> This is bonding patch, please cc bonding maintainers (Chas, instead of John >>> W. >>> Linville). >> Sorry about that. I have 2 patches ( one for af packet, one for bonding). >> >> I am a li

[dpdk-dev] [PATCH v3 5/5] net/iavf: add support for FDIR mark action

2020-04-10 Thread Simei Su
This patch enables mark action support and takes mark only case into consideration. Signed-off-by: Simei Su --- drivers/net/iavf/iavf.h | 1 + drivers/net/iavf/iavf_fdir.c | 45 +++- 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/driv

Re: [dpdk-dev] [PATCH v2] fix lacp check system address

2020-04-10 Thread Ferruh Yigit
On 4/10/2020 11:21 AM, Ferruh Yigit wrote: > On 4/10/2020 11:15 AM, Ferruh Yigit wrote: >> On 11/26/2019 3:09 PM, podovinnikov wrote: >>> Hi Ferruh >>> This is bonding patch, please cc bonding maintainers (Chas, instead of John W. Linville). >>> Sorry about that. I have 2 patches (

[dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file

2020-04-10 Thread Thomas Monjalon
Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat in app/test/meson.build and then adding it as a build dependency. This causes build loop if the timestamp of this file keeps changing. It is fixed by hiding hugepage check in a shell script. Fixes: 77784ef0fba8 ("test: allow

Re: [dpdk-dev] [PATCH v2 1/2] bitmap: add create bitmap with all bits set

2020-04-10 Thread Suanming Mou
> -Original Message- > From: Dumitrescu, Cristian > Sent: Thursday, April 9, 2020 10:16 PM > To: Suanming Mou > Cc: dev@dpdk.org; a...@semihalf.com > Subject: RE: [PATCH v2 1/2] bitmap: add create bitmap with all bits set > > Hi Sunaming, > > > -Original Message- > > From: Su

Re: [dpdk-dev] [PATCH 17.11] lib/librte_ether/rte_ethdev.c: Check device count

2020-04-10 Thread Ferruh Yigit
On 4/7/2020 5:25 PM, Talal Irfan wrote: > Bugzilla ID: 6 > Cc: dev@dpdk.org > Cc: Thomas Monjalon > Cc: Adrien Mazarguil > Cc: sta...@dpdk.org > Reported-by: Wang Zhike > Suggested-by: Vipin Varghese > Signed-off-by: Talal Irfan > --- > lib/librte_ether/rte_ethdev.c | 6 ++ > 1 file chang

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-10 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Saturday, April 4, 2020 12:19 PM > [...] > Since it is the control plane, slow path traffic without any > performance requirement, This is incorrect. Production equipment certainly has control plane performance requirem

Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file

2020-04-10 Thread Bruce Richardson
On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: > Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat > in app/test/meson.build and then adding it as a build dependency. > This causes build loop if the timestamp of this file keeps changing. > > It is fixed by

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-10 Thread Morten Brørup
> From: Ciara Power [mailto:ciara.po...@intel.com] > Sent: Wednesday, April 8, 2020 6:50 PM > > This patchset extensively reworks the telemetry library adding new > functionality and simplifying much of the existing code, while > maintaining backward compatibility. > > This work is based on the p

Re: [dpdk-dev] [PATCH] build: gcc 10 disable stringop-overflow warnings

2020-04-10 Thread Kevin Traynor
On 07/04/2020 17:27, Kevin Traynor wrote: > stringop-overflow warns when it sees a possible overflow > in a string operation. > > In the rte_memcpy functions different implementations are > used depending on the size. stringop-overflow is raised for > the paths in the function where it sees the st

Re: [dpdk-dev] [PATCH 2/2] ethdev: allow unknown link speed

2020-04-10 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, April 8, 2020 12:27 AM > > When querying the link informations, the link status is > a mandatory major information. > Other boolean values are supposed to be accurate: > - duplex mode (half/full) > - negotiation (a

Re: [dpdk-dev] [dpdk-stable] [PATCH 17.11] lib/librte_ether/rte_ethdev.c: Check device count

2020-04-10 Thread Kevin Traynor
On 10/04/2020 11:37, Ferruh Yigit wrote: > On 4/7/2020 5:25 PM, Talal Irfan wrote: >> Bugzilla ID: 6 >> Cc: dev@dpdk.org >> Cc: Thomas Monjalon >> Cc: Adrien Mazarguil >> Cc: sta...@dpdk.org >> Reported-by: Wang Zhike >> Suggested-by: Vipin Varghese >> Signed-off-by: Talal Irfan >> --- >> lib

[dpdk-dev] [PATCH 2/9] net/hns3: replace zero with macro defined in DPDK framework

2020-04-10 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch replaces the specific macro named RTE_INTR_VEC_ZERO_OFFSET provided by DPDK framework instead of the magic number 0. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c| 8 drivers/net/hns3/hns3_ethdev_vf.c

[dpdk-dev] [PATCH 1/9] net/hns3: simplify process of some return values

2020-04-10 Thread Wei Hu (Xavier)
From: Lijun Ou Currently, the return value processing of some functions can be combined and the result is that some codes can be optimized. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_dcb.c | 28 +--- drivers/net/hns3/hns3_eth

[dpdk-dev] [PATCH 0/9] misc updates for hns3 PMD driver

2020-04-10 Thread Wei Hu (Xavier)
This series are cleanup and bugfix for hns3 PMD driver. Chengchang Tang (3): net/hns3: fix failure when adding a MC MAC address net/hns3: fix default VLAN filter configuration for PF net/hns3: fix VLAN filter when setting promisucous mode Chengwen Feng (2): net/hns3: fix Rx interrupt afte

[dpdk-dev] [PATCH 3/9] net/hns3: fix failure when adding a MC MAC address

2020-04-10 Thread Wei Hu (Xavier)
From: Chengchang Tang Currently, when upper application calls the rte_eth_dev_mac_addr_add API function to add a MC mac address based on hns3 PF/VF device, it will fail. In hns3 network engine adding UC and MC mac address with different commands with firmware. We need to determine whether the in

[dpdk-dev] [PATCH 4/9] net/hns3: fix Rx interrupt after reset

2020-04-10 Thread Wei Hu (Xavier)
From: Chengwen Feng Currently, Rx interrupt cannot work normally after reset (such as FLR, global reset and IMP reset), when running l3fwd-power application based on hns3 network engine. The root cause is that the hardware configuration about Rx interrupt does not recover after reset. This patc

[dpdk-dev] [PATCH 7/9] net/hns3: fix missing length of hash key when getting RSS

2020-04-10 Thread Wei Hu (Xavier)
From: Lijun Ou When upper application calls the rte_eth_dev_rss_hash_conf_get API function to get the RSS key parameters, the function should return the RSS key length supported by the device. Otherwise, an error will occur when the upper application needs to use the RSS key length supported by t

[dpdk-dev] [PATCH 5/9] net/hns3: fix residual flow directory rules when app restart

2020-04-10 Thread Wei Hu (Xavier)
From: Chengwen Feng This patch fixes that the flow directory rules are not cleared during initialization, which lead to remaining flow directory rules after upper application(such as testpmd) restarted. Fixes: fcba820d9b9e ("net/hns3: support flow director") Cc: sta...@dpdk.org Signed-off-by: C

[dpdk-dev] [PATCH 8/9] net/hns3: fix default VLAN filter configuration for PF

2020-04-10 Thread Wei Hu (Xavier)
From: Chengchang Tang Currently, By default VLAN filter is enabled during initialization and couldn't be turned off based on hns3 PF device. If upper applications don't call rte_eth_dev_vlan_filter API function to set vlan based on hns3 PF device, hns3 PF PMD driver will can't receive the packets

[dpdk-dev] [PATCH 6/9] net/hns3: fix missing RSS in Rx offload capability

2020-04-10 Thread Wei Hu (Xavier)
From: Lijun Ou Currently, when upper application calls rte_eth_dev_info_get API function to query the Rx offload capability based on hns3 network engine, RSS hash offload capacity is missing. This patch fixes it by adding the related capacity in the '.dev_infos_get' ops implementation function n

[dpdk-dev] [PATCH 9/9] net/hns3: fix VLAN filter when setting promisucous mode

2020-04-10 Thread Wei Hu (Xavier)
From: Chengchang Tang Currently, when upper level application call the API function named rte_eth_dev_set_vlan_offload to configure the hardware vlan filter offload and call the rte_eth_promiscuous_enable API to enable promiscuous mode based on hns3 PF device, driver can't receive the packets wit

Re: [dpdk-dev] [PATCH v2 1/2] test/malloc: run realloc tests on external heap

2020-04-10 Thread David Marchand
Hello Anatoly, On Thu, Apr 2, 2020 at 11:07 AM Anatoly Burakov wrote: > > Due to the fact that the rte_realloc() test depends on the layout of > underlying memory, it can sometimes fail due to fragmentation of the > memory. To address this, make it so that the realloc autotests are run > using a

Re: [dpdk-dev] [PATCH v2 1/2] bitmap: add create bitmap with all bits set

2020-04-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Suanming Mou > Sent: Friday, April 10, 2020 11:34 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; a...@semihalf.com > Subject: RE: [PATCH v2 1/2] bitmap: add create bitmap with all bits set > > > > > -Original Message- > > From: Dumitrescu, Cri

Re: [dpdk-dev] [EXT] RE: [PATCH 1/2] ethdev: add tm cap for private shaper packet mode

2020-04-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Nithin Dabilpuram > Sent: Tuesday, April 7, 2020 6:21 PM > To: Dumitrescu, Cristian > Cc: Thomas Monjalon ; Yigit, Ferruh > ; Andrew Rybchenko > ; dev@dpdk.org; jer...@marvell.com; > kka...@marvell.com > Subject: Re: [EXT] RE: [PATCH 1/2] ethdev: add tm cap

Re: [dpdk-dev] [EXT] RE: [PATCH 1/2] ethdev: add tm cap for private shaper packet mode

2020-04-10 Thread Nithin Dabilpuram
Thanks Cristian. Agree with your comments, Will send a v2 addressing them. On Fri, Apr 10, 2020 at 11:45:06AM +, Dumitrescu, Cristian wrote: > > > > -Original Message- > > From: Nithin Dabilpuram > > Sent: Tuesday, April 7, 2020 6:21 PM > > To: Dumitrescu, Cristian > > Cc: Thomas Mo

Re: [dpdk-dev] [PATCH] ethdev: support flow aging

2020-04-10 Thread Andrew Rybchenko
On 4/10/20 12:46 PM, BillZhou wrote: One of the reasons to destroy a flow is the fact that no packet matches the flow for "timeout" time. For example, when TCP\UDP sessions are suddenly closed. Currently, there is no any DPDK mechanism for flow aging and the applications use their own ways to de

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix resource leak after thread exits normally

2020-04-10 Thread Ananyev, Konstantin
Hi Tao, > From: Zhu Tao > > When the thread exits normally, pthread_join() is not called, which can > result in a resource leak. Therefore, the thread is set to separation > mode using function pthread_detach(), so that no program call > pthread_join() is required to recycle, and when the thread

Re: [dpdk-dev] [PATCH v2 2/2] doc: remove flow API from the feature list

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 3:00 PM Ferruh Yigit wrote: > > "Flow API" is a method/API to implement various filtering features, on > its own it doesn't give much context on what features are provided. And > it is not really a feature, so doesn't fit into feature table. > > Also since other filtering r

Re: [dpdk-dev] [PATCH v4] build: enable allow experimental API flag

2020-04-10 Thread David Marchand
On Fri, Apr 10, 2020 at 11:04 AM wrote: > > From: Pavan Nikhilesh > > Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and > meson.build instead enable ALLOW_EXPERIMENTAL_API flag across app, lib and > drivers. > This changes reduces the clutter across the project while still

Re: [dpdk-dev] Memory requirement calculation to create mempools with external memory

2020-04-10 Thread Burakov, Anatoly
On 04-Apr-20 5:27 AM, Bao-Long Tran wrote: Hi, My goal is to create mbuf pools using external memory with rte_malloc_heap_*(). The initial implementation goes like this: - Create an empty heap rte_malloc_heap_create() - Calculate memory required - Provision and add the calculated single memory c

Re: [dpdk-dev] [PATCH v2 1/2] doc: add PMD filtering features back

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 3:00 PM Ferruh Yigit wrote: > > What has been deprecated is enabling filtering support using the > 'filter_ctrl' APIs [1], now same filtering features can be implemented > using rte_flow APIs and this is the preferred way for DPDK. > > Since those filtering features can be

Re: [dpdk-dev] [PATCH v3 2/4] ci: generate fast-tests suite base on hugepage availability

2020-04-10 Thread David Marchand
On Mon, Mar 30, 2020 at 6:03 PM Ruifeng Wang wrote: > > > > -Original Message- > > From: David Marchand > > Sent: Sunday, March 29, 2020 00:18 > > To: Ruifeng Wang > > Cc: Aaron Conole ; Michael Santana > > ; Bruce Richardson > > ; Ananyev, Konstantin > > ; dev ; Burakov, Anatoly > > ; G

Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file

2020-04-10 Thread Thomas Monjalon
10/04/2020 12:42, Bruce Richardson: > On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > has_hugepage = true > > if is_linux > > Since you check for linux in the script, you can drop these two lines, The issue is fo

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 3:33 PM Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Saturday, April 4, 2020 9:58 PM > > > > 04/04/2020 20:30, Andrzej Ostruszka [C]: > > > Thomas, > > > > > > I have replied to the other mail, here I just want to confirm, that >

Re: [dpdk-dev] [PATCH v2 1/2] bitmap: add create bitmap with all bits set

2020-04-10 Thread Suanming Mou
Hi Cristian Thanks for the suggestion. Will update the v3 patch. BR SuanmingMou > -Original Message- > From: Dumitrescu, Cristian > Sent: Friday, April 10, 2020 7:21 PM > To: Suanming Mou > Cc: dev@dpdk.org; a...@semihalf.com > Subject: RE: [PATCH v2 1/2] bitmap: add create bitmap with

Re: [dpdk-dev] [PATCH v2 2/2] doc: remove flow API from the feature list

2020-04-10 Thread Thomas Monjalon
10/04/2020 14:10, Jerin Jacob: > On Fri, Apr 10, 2020 at 3:00 PM Ferruh Yigit wrote: > > > > "Flow API" is a method/API to implement various filtering features, on > > its own it doesn't give much context on what features are provided. And > > it is not really a feature, so doesn't fit into featur

Re: [dpdk-dev] [PATCH v2 2/2] doc: remove flow API from the feature list

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 6:04 PM Thomas Monjalon wrote: > > 10/04/2020 14:10, Jerin Jacob: > > On Fri, Apr 10, 2020 at 3:00 PM Ferruh Yigit wrote: > > > > > > "Flow API" is a method/API to implement various filtering features, on > > > its own it doesn't give much context on what features are prov

Re: [dpdk-dev] [PATCH] ethdev: support flow aging

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 5:38 PM Andrew Rybchenko wrote: > > On 4/10/20 12:46 PM, BillZhou wrote: > > One of the reasons to destroy a flow is the fact that no packet matches the > > flow for "timeout" time. > > For example, when TCP\UDP sessions are suddenly closed. > > > > Currently, there is no a

Re: [dpdk-dev] [PATCH v2 3/4] net/i40e/base: add constants for PTP pins

2020-04-10 Thread Kwapulinski, Piotr
ACK -Original Message- From: Min, JiaqiX Sent: Wednesday, April 8, 2020 12:05 PM To: dev@dpdk.org Cc: Min, JiaqiX ; Kwapulinski, Piotr Subject: [PATCH v2 3/4] net/i40e/base: add constants for PTP pins Introduce constants for handling PTP pins used for external clock source. Signed-of

[dpdk-dev] [PATCH v3 0/2] bitmap: add create bitmap with all bits set

2020-04-10 Thread Suanming Mou
Currently, in the case to use bitmap as resource allocator, after bitmap creation, all the bitmap bits should be set to indicate the bit available. Every time when allocate one bit, search for the set bits and clear it to make it in use. Add a new rte_bitmap_init_with_all_set() function to have a

[dpdk-dev] [PATCH v3 1/2] bitmap: add create bitmap with all bits set

2020-04-10 Thread Suanming Mou
Currently, in the case to use bitmap as resource allocator, after bitmap creation, all the bitmap bits should be set to indicate the bit available. Every time when allocate one bit, search for the set bits and clear it to make it in use. Add a new rte_bitmap_init_with_all_set() function to have a

[dpdk-dev] [PATCH v3 2/2] test/bitmap: add bitmap create with all bits set case

2020-04-10 Thread Suanming Mou
Add the case to verify bitmap create with all bits set works correctly. Signed-off-by: Suanming Mou --- app/test/test_bitmap.c | 57 +- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c in

Re: [dpdk-dev] [PATCH v4 18/29] node: add ethdev Rx and Tx node ctrl API

2020-04-10 Thread Andrzej Ostruszka
On 4/10/20 7:09 AM, Nithin Dabilpuram wrote: > On Fri, Apr 10, 2020 at 01:07:17AM +0200, Andrzej Ostruszka wrote: [...] >>> +struct rte_node_mbuf_priv2 { >>> + union { >>> + /* Sym crypto */ >>> + struct { >>> + struct rte_crypto_op op; >>> + }; >>>

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-10 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 7:32 PM Mattias Rönnblom wrote: > > On 2020-04-09 15:32, Jerin Jacob wrote: > > On Thu, Apr 9, 2020 at 5:51 PM Mattias Rönnblom > > wrote: > >> On 2020-04-08 21:36, Jerin Jacob wrote: > >>> On Wed, Apr 8, 2020 at 11:27 PM Mattias Rönnblom > >>> wrote: > Extend Eventde

  1   2   3   >