Re: [dpdk-dev] [dpdk-dev v5 1/3] ethdev: add new RSS offload types

2020-04-15 Thread Ori Kam
Hi Jeff, > -Original Message- > From: Jeff Guo > Sent: Wednesday, April 15, 2020 8:11 PM > To: bernard.iremon...@intel.com; Ori Kam ; > xiaolong...@intel.com; qi.z.zh...@intel.com > Cc: dev@dpdk.org; jingjing...@intel.com; yahui@intel.com; > simei...@intel.com; jia@intel.com > S

Re: [dpdk-dev] [PATCH v2 1/2] virtio: one way barrier for split vring used idx

2020-04-15 Thread Joyce Kong
> > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] virtio: one way barrier for > > > split vring used idx > > > > > > On Thu, 2 Apr 2020 10:57:52 +0800 > > > Joyce Kong wrote: > > > > > > > -(vq)->vq_used_cons_idx)) > > > > +static inline uint16_t > > > > +virtqueue_nused(struct virtqueue *vq) > > >

Re: [dpdk-dev] [PATCH v2] event/dsw: fix gcc 4.8 false positive warning

2020-04-15 Thread Mattias Rönnblom
On 2020-04-15 21:45, David Marchand wrote: > On Wed, Apr 15, 2020 at 8:15 PM Mattias Rönnblom > wrote: >> Add redundant stack variable initialization to work around >> false-positive warnings in older versions of GCC. >> >> Fixes: bba7a1aeef46 ("event/dsw: improve migration mechanism") > The commi

Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options from make to meson

2020-04-15 Thread Juraj Linkeš
Hi Luca, > -Original Message- > From: Luca Boccassi > Sent: Wednesday, April 15, 2020 1:45 PM > To: Juraj Linkeš ; bruce.richard...@intel.com; > acon...@redhat.com; maicolgabr...@hotmail.com; ruifeng.w...@arm.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm3

Re: [dpdk-dev] [PATCH] eal: choose initial PRNG seed source at runtime

2020-04-15 Thread Jerin Jacob
On Thu, Apr 16, 2020 at 4:42 AM Dan Gora wrote: > > Instead of choosing to use getentropy() or the rdseed instruction for > the random number generator entropy source using compilation flags, > determine the best source at run time. > > This is accomplished by defining a weak symbol for getentropy

[dpdk-dev] [PATCH v11 6/6] net/virtio: Support of VIRTIO_NET_F_SPEED_DUPLEX

2020-04-15 Thread Ivan Dyukov
This patch adds a support of VIRTIO_NET_F_SPEED_DUPLEX feature for virtio driver. There are two ways to specify speed of the link: * 'speed' devarg * negotiate speed from qemu via VIRTIO_NET_F_SPEED_DUPLEX The highest priority is devarg. If devarg is not specified, driver tries to negotiate it

[dpdk-dev] [PATCH v11 4/6] net/virtio-user: fix devargs parsing

2020-04-15 Thread Ivan Dyukov
strtoull returns 0 if it fails to parse input string. It's ignored in get_integer_arg. This patch handles error cases for strtoull function. Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device") Cc: sta...@dpdk.org Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_user_ethdev.c | 1

[dpdk-dev] [PATCH v11 5/6] net/virtio-user: adding link speed devarg

2020-04-15 Thread Ivan Dyukov
virtio driver already parses speed devarg. virtio-user should add it to list of valid devargs and call eth_virtio_dev_init function which init speed value. eth_virtio_dev_init already is called from virtio_user_pmd_probe function. The only change is required to enable speed devargs: adding speed t

[dpdk-dev] [PATCH v11 2/6] net/virtio: refactor devargs parsing

2020-04-15 Thread Ivan Dyukov
refactor vdpa specific devargs parsing to more generic way Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 34 +- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev

[dpdk-dev] [PATCH v11 0/6] net/virtio: add link speed devarg

2020-04-15 Thread Ivan Dyukov
doc/guides/nics/virtio.rst | 15 +++ drivers/net/virtio/virtio_ethdev.c | 143 ++ drivers/net/virtio/virtio_ethdev.h |

[dpdk-dev] [PATCH v11 3/6] net/virtio: add link speed devarg

2020-04-15 Thread Ivan Dyukov
Default value of link speed is 0x (Unknown) This patch adds speed devarg which allows to configure link speed of virtio device. Signed-off-by: Ivan Dyukov --- doc/guides/nics/virtio.rst | 7 ++ drivers/net/virtio/virtio_ethdev.c | 107 - drivers/net

[dpdk-dev] [PATCH v11 1/6] net/virtio: replace default virtio speed

2020-04-15 Thread Ivan Dyukov
This patch set speed to unknown Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 4 ++-- lib/librte_ethdev/rte_ethdev.h | 27 ++- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/vir

[dpdk-dev] [PATCH v8 6/6] net/hinic: use common rte bit operation APIs instead

2020-04-15 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/hinic/Makefile| 1 + drivers/net/hinic/base/hinic_compat.h | 33 +-- drivers/net/hinic/hin

[dpdk-dev] [PATCH v8 5/6] net/qede: use common rte bit operation APIs instead

2020-04-15 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/qede/base/bcm_osal.c | 22 + drivers/net/qede/base/bcm_osal.h | 14 - drivers/net/qede/ba

[dpdk-dev] [PATCH v8 3/6] net/axgbe: use common rte bit operation APIs instead

2020-04-15 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/axgbe/axgbe_common.h | 29 + drivers/net/axgbe/axgbe_ethdev.c | 14 +++--- drivers/net/axgb

[dpdk-dev] [PATCH v8 4/6] net/bnx2x: use common rte bit operation APIs instead

2020-04-15 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/bnx2x/bnx2x.c| 271 +-- drivers/net/bnx2x/bnx2x.h| 10 +- drivers/net/bnx2x/ecore_sp.c

[dpdk-dev] [PATCH v8 2/6] test/bitops: add bit operation test case

2020-04-15 Thread Joyce Kong
Add test cases for setting bit, clearing bit, testing and setting bit, testing and clearing bit operation. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu Reviewed-by: Phil Yang --- MAINTAINERS | 1 + app/test/Makefile | 1 + app/test/autotest_data.py | 6 ++ app/te

[dpdk-dev] [PATCH v8 0/6] implement common bit operation APIs

2020-04-15 Thread Joyce Kong
Bitwise operation APIs are defined and used in a lot of PMDs, which caused a huge code duplication. To reduce duplication, this patch consolidates them into a common API family and use it for all the PMDs(we started with a few selectively). v8: 1. Change 'rte_pmd_bitops.h' to 'rte_bitops.h' allo

[dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of common bit operation APIs

2020-04-15 Thread Joyce Kong
Bitwise operation APIs are defined and used in a lot of PMDs, which caused a huge code duplication. To reduce duplication, this patch consolidates them into a common API family. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu Reviewed-by: Phil Yang Acked-by: Morten Brørup --- MAINTAINERS

Re: [dpdk-dev] [PATCH v5 0/5] fixes for tap

2020-04-15 Thread Stephen Hemminger
On Thu, 16 Apr 2020 11:03:57 +0800 wangyunjian wrote: > From: Yunjian Wang > > This series include five fixes patches for tap PMD driver. > > -- > v5: > * fix check fd error > v4: > * Update some code suggested by Ferruh Yigit and Stephen Hemminger > * Update commit log > * Add fix leak of fds

Re: [dpdk-dev] [PATCH v2 1/2] virtio: one way barrier for split vring used idx

2020-04-15 Thread Honnappa Nagarahalli
> > Subject: Re: [dpdk-dev] [PATCH v2 1/2] virtio: one way barrier for > > split vring used idx > > > > On Thu, 2 Apr 2020 10:57:52 +0800 > > Joyce Kong wrote: > > > > > -(vq)->vq_used_cons_idx)) > > > +static inline uint16_t > > > +virtqueue_nused(struct virtqueue *vq) > > vq is unmodified and

Re: [dpdk-dev] [dpdk-dev v5 1/3] ethdev: add new RSS offload types

2020-04-15 Thread Jeff Guo
hi, ferruh and bernard On 4/16/2020 6:13 AM, Ferruh Yigit wrote: On 4/15/2020 4:38 PM, Iremonger, Bernard wrote: Hi Jeff, -Original Message- From: Guo, Jia Sent: Wednesday, April 15, 2020 6:11 PM To: Iremonger, Bernard ; or...@mellanox.com; Ye, Xiaolong ; Zhang, Qi Z Cc: dev@dpdk

[dpdk-dev] [PATCH v1] net/ice: check the DSN package file firstly

2020-04-15 Thread Haiyue Wang
Align the package file search sequence with PF only for DCF mode. Get the DSN through the virtual channel firstly to check the package file accessible. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf_parent.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletio

[dpdk-dev] [PATCH v5 5/5] net/tap: fix leak of fds on failure

2020-04-15 Thread wangyunjian
From: Yunjian Wang When eth_dev_tap_create() is failed, nlsk_fd and ka_fd won't be closed thus leading fds leak. Zero is a valid fd. Ultimately leads to a valid fd was closed by mistake. Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing") Fixes: cb7e68da630a ("net/tap: fix cleanup o

[dpdk-dev] [PATCH v5 4/5] net/tap: fix close a valid fd

2020-04-15 Thread wangyunjian
From: Yunjian Wang The internal structure is freed and set to NULL in the rte_eth_dev_release_port() and zero is a valid fd. Ultimately leads to a valid fd was closed by mistake. Fixes: 3101191c63ab ("net/tap: fix device removal when no queue exist") CC: sta...@dpdk.org Reviewed-by: Ferruh Yigi

[dpdk-dev] [PATCH v5 2/5] net/tap: fix mbuf and mem leak during queue release

2020-04-15 Thread wangyunjian
From: Yunjian Wang For the tap PMD, we should release mbufs and iovecs from the Rx queue when closing device. In order to remove duplicated code, rte_pmd_tap_remove() calls tap_dev_close(). Fixes: 0781f5762cfe ("net/tap: support segmented mbufs") CC: sta...@dpdk.org Reviewed-by: Ferruh Yigit S

[dpdk-dev] [PATCH v5 3/5] net/tap: fix check for mbuf's nb_segs failure

2020-04-15 Thread wangyunjian
From: Yunjian Wang Now the rxq->pool is mbuf concatenation, but its nb_segs is 1. When conducting some sanity checks on the mbuf with debug enabled, it fails. Fixes: 0781f5762cfe ("net/tap: support segmented mbufs") CC: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/tap/rte_eth_t

[dpdk-dev] [PATCH v5 1/5] net/tap: fix mbuf double free when writev fails

2020-04-15 Thread wangyunjian
From: Yunjian Wang When the tap_write_mbufs() function return with break, mbuf was freed without increasing num_packets, which could cause applications to free the mbuf again. And the pmd_tx_burst() function should returns the number of original packets it actually sent excluding tso mbufs. Fixe

[dpdk-dev] [PATCH v5 0/5] fixes for tap

2020-04-15 Thread wangyunjian
From: Yunjian Wang This series include five fixes patches for tap PMD driver. -- v5: * fix check fd error v4: * Update some code suggested by Ferruh Yigit and Stephen Hemminger * Update commit log * Add fix leak of fds on failure v3: * Add fix close a vaild fd and netlink socket file descriptor

[dpdk-dev] [PATCH v2 07/10] net/mlx5: convert port id action to indexed

2020-04-15 Thread Suanming Mou
This commit converts port id action to indexed. Using the uint32_t index instead of pointer saves 4 bytes memory for the flow handle. For millions flows, it will save several MBytes of memory. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 11 +

[dpdk-dev] [PATCH v2 08/10] net/mlx5: convert jump resource to indexed

2020-04-15 Thread Suanming Mou
This commit convert jump resource to indexed. The table data struct is allocated from indexed memory. As it is add in the hash list, the pointer is still used for hash list search. The index is added to the table struct, and the pointer in flow handle is decrease to uint32_t type. For flow without

[dpdk-dev] [PATCH v2 09/10] net/mlx5: convert hrxq to indexed

2020-04-15 Thread Suanming Mou
This commit converts hrxq to indexed. Using the uint32_t index instead of pointer saves 4 bytes memory for the flow handle. For millions flows, it will save several MBytes of memory. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c| 31

[dpdk-dev] [PATCH v2 04/10] net/mlx5: convert encap/decap resource to indexed

2020-04-15 Thread Suanming Mou
This commit converts the flow encap/decap resource to indexed. Using the uint32_t index instead of pointer saves 4 bytes memory for the flow handle. For millions flows, it will save several MBytes of memory. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v2 10/10] net/mlx5: convert flow dev handle to indexed

2020-04-15 Thread Suanming Mou
This commit converts flow dev handle to indexed. Change the mlx5 flow handle from pointer to uint32_t saves memory for flow. With million flow, it saves several MBytes memory. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c| 30 +++

[dpdk-dev] [PATCH v2 06/10] net/mlx5: convert tag resource to indexed

2020-04-15 Thread Suanming Mou
This commit convert tag resource to indexed. As tag resources are add in the hash list, to avoid introduce performance issue and keep the hash list, only the tag resource memory is allocated from indexed memory. The resources is still added to the hash list. Add four bytes index in the tag resourc

[dpdk-dev] [PATCH v2 03/10] net/mlx5: add trunk release for indexed pool

2020-04-15 Thread Suanming Mou
While entries are fully freed in trunk, it means the trunk is free now. User may prefer the free trunk memory can be reclaimed. Add the trunk release memory option for indexed pool in this case. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_utils.c | 37 +

[dpdk-dev] [PATCH v2 00/10] net/mlx5: optimize flow resource allocation

2020-04-15 Thread Suanming Mou
Currently, flow may allocate several action resources during creation. Both allocate the individual resources and save the object handles have big memory overhead for the flow. Indexed memory pool is introduced to optimize the memory overhead. The resources can be allocated from the resource's own

[dpdk-dev] [PATCH v2 01/10] net/mlx5: add indexed memory pool

2020-04-15 Thread Suanming Mou
Currently, the memory allocated by rte_malloc() also introduced more than 64 bytes overhead. It means when allocate 64 bytes memory, the real cost in memory maybe double. And the libc malloc() overhead is 16 bytes, If users try allocating millions of small memory blocks, the overhead costing maybe

[dpdk-dev] [PATCH v2 02/10] net/mlx5: add trunk dynamic grow for indexed pool

2020-04-15 Thread Suanming Mou
This commit add trunk dynamic grow for the indexed pool. In case for pools which are not sure the entry number needed, pools can be configured in increase progressively mode. It means the trunk size will be increased dynamically one after one, then reach a stable value. It saves memory to avoid al

[dpdk-dev] [PATCH v2 05/10] net/mlx5: convert push VLAN resource to indexed

2020-04-15 Thread Suanming Mou
This commit converts the push VLAN resource to indexed. Using the uint32_t index instead of pointer saves 4 bytes memory for the flow handle. For millions flows, it will save several MBytes of memory. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c

Re: [dpdk-dev] [PATCH v4 3/5] net/tap: fix check for mbuf's nb_segs failure

2020-04-15 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, April 15, 2020 11:13 PM > To: wangyunjian ; dev@dpdk.org > Cc: keith.wi...@intel.com; Lilijun (Jerry) ; > xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 3/5] net/tap: fix check fo

Re: [dpdk-dev] [PATCH v4 5/5] net/tap: fix leak of fds on failure

2020-04-15 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, April 15, 2020 11:15 PM > To: wangyunjian ; dev@dpdk.org > Cc: keith.wi...@intel.com; Lilijun (Jerry) ; > xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 5/5] net/tap: fix leak of

Re: [dpdk-dev] [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH

2020-04-15 Thread Xing, Beilei
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, April 15, 2020 7:14 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Iremonger, > Bernard > Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH >

Re: [dpdk-dev] [PATCH v4 3/3] net/i40e: add ESP patterns

2020-04-15 Thread Xing, Beilei
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, April 15, 2020 7:14 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Iremonger, > Bernard > Subject: [PATCH v4 3/3] net/i40e: add ESP patterns > > add ESP patterns to i

Re: [dpdk-dev] [PATCH v2 06/13] baseband/fpga_5gnr_fec: add queue configuration

2020-04-15 Thread Xu, Rosen
Hi, > -Original Message- > From: Chautru, Nicolas > Sent: Wednesday, April 15, 2020 23:51 > To: Xu, Rosen ; dev@dpdk.org > Cc: Richardson, Bruce ; O'Hare, Cathal > ; akhil.go...@nxp.com > Subject: RE: [dpdk-dev] [PATCH v2 06/13] baseband/fpga_5gnr_fec: add > queue configuration > > Hi >

Re: [dpdk-dev] [PATCH] vhost: remove deferred shadow update

2020-04-15 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, April 15, 2020 11:04 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong ; epere...@redhat.com > Cc: dev@dpdk.org > Subject: Re: [PATCH] vhost: remove deferred shadow update > > Hi Marvin, > > On 4/15/20 4:55 PM, Liu, Yon

[dpdk-dev] [PATCH v2] eal: choose initial PRNG seed source at runtime

2020-04-15 Thread Dan Gora
Instead of choosing to use getentropy() or the rdseed instruction for the random number generator entropy source using compilation flags, determine the best source at run time. This is accomplished by defining a weak symbol for getentropy(), checking that the compiler can generate the rdseed instr

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix dropping of initial IPsec pkts

2020-04-15 Thread Ananyev, Konstantin
Hi Lukasz, > Hi Konstantin, > > In this patch I moved the sa_init() before rte_eth_dev_start() in order to > avoid dropping > of IPsec pkts when a traffic flows and the ipsec-secgw application is started. > > However I remember that during review of event mode patches you mentioned that > mo

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-15 Thread Dmitry Kozlyuk
Answering the questions. All snipped comments will be fixed in v4. > [...] > > +/** > > + * Memory reservation flags. > > + */ > > +enum eal_mem_reserve_flags { > > + /**< Reserve hugepages (support may be limited or missing). */ > > + EAL_RESERVE_HUGEPAGES = 1 << 0, > > + /**< Fail if reque

[dpdk-dev] [PATCH] net/bnxt: add PCI function stats to extended stats

2020-04-15 Thread Ajit Khaparde
HWRM API allows drivers to query stats per PCI function. These stats can provide some useful information in certain circumstances. Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c| 10 +++- drivers/net/bnxt/bnxt_hwrm.h| 4 +++- drivers/net/bn

[dpdk-dev] [PATCH] eal: choose initial PRNG seed source at runtime

2020-04-15 Thread Dan Gora
Instead of choosing to use getentropy() or the rdseed instruction for the random number generator entropy source using compilation flags, determine the best source at run time. This is accomplished by defining a weak symbol for getentropy(), checking that the compiler can generate the rdseed instr

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-15 Thread Thomas Monjalon
16/04/2020 00:19, Doherty, Declan: > On 14/04/2020 3:44 PM, Thomas Monjalon wrote: > > 14/04/2020 16:02, Trahe, Fiona: > >> From: Thomas Monjalon > >>> 14/04/2020 15:04, Trahe, Fiona: > > 14/04/2020 12:21, Ferruh Yigit: > > > >>> http://inbox.dpdk.org/dev/mn2pr11mb35507d4b96677a41e66440c5e

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-15 Thread Doherty, Declan
On 14/04/2020 3:44 PM, Thomas Monjalon wrote: 14/04/2020 16:02, Trahe, Fiona: Hi Thomas, From: Thomas Monjalon 14/04/2020 15:04, Trahe, Fiona: 14/04/2020 12:21, Ferruh Yigit: http://inbox.dpdk.org/dev/mn2pr11mb35507d4b96677a41e66440c5e3...@mn2pr11mb3550.na mprd11.prod.outlook.com/ I am n

Re: [dpdk-dev] [PATCH v3 07/10] eal: extract common code for memseg list initialization

2020-04-15 Thread Thomas Monjalon
14/04/2020 21:44, Dmitry Kozlyuk: > All supported OS create memory segment lists (MSL) and reserve VA space > for them in a nearly identical way. Move common code into EAL private > functions to reduce duplication. > > Signed-off-by: Dmitry Kozlyuk > --- > lib/librte_eal/common/eal_common_memory

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-15 Thread Thomas Monjalon
14/04/2020 21:44, Dmitry Kozlyuk: > System meory management is implemented differently for POSIX and meory -> memory > Windows. Introduce wrapper functions for operations used across DPDK: > > * rte_mem_map() > Create memory mapping for a regular file or a page file (swap). > This supports m

Re: [dpdk-dev] [dpdk-dev v5 1/3] ethdev: add new RSS offload types

2020-04-15 Thread Ferruh Yigit
On 4/15/2020 4:38 PM, Iremonger, Bernard wrote: > Hi Jeff, > > >> -Original Message- >> From: Guo, Jia >> Sent: Wednesday, April 15, 2020 6:11 PM >> To: Iremonger, Bernard ; >> or...@mellanox.com; Ye, Xiaolong ; Zhang, Qi Z >> >> Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui >> ; Su, Sim

Re: [dpdk-dev] [PATCH v3 05/10] eal: introduce internal wrappers for file operations

2020-04-15 Thread Thomas Monjalon
Thanks for starting the new directory for Unix common implementation. 14/04/2020 21:44, Dmitry Kozlyuk: > --- /dev/null > +++ b/lib/librte_eal/unix/eal.c Please take care of not creating a new file without adding SPDX tag and copyright owner. > @@ -0,0 +1,47 @@ > +#include > +#include > +#incl

[dpdk-dev] Fwd: [Minutes 04/15/2020] Bi-Weekly DPDK Windows Community Call

2020-04-15 Thread Thomas Monjalon
From: Harini Ramakrishnan Attendees: Thomas Monjalon, Ranjit Menon, Tal Shnaiderman, Pallavi Kadam, Ranjit Menon, Narcisa Ana Maria Vasile, Harini Ramakrishnan, Dmitry Kozliuk, William Tu, Tasnim Bashar 1/ UIO Driver * New Intel-Microsoft DA needed to unblock licensing issues. * Naty

Re: [dpdk-dev] [PATCH v3 9/9] ring: add C11 memory model for new sync modes

2020-04-15 Thread Ananyev, Konstantin
Hi Honnappa, > > + > > +/** > > + * @internal This function updates the producer head for enqueue > > + * > > + * @param r > > + * A pointer to the ring structure > > + * @param is_sp > > + * Indicates whether multi-producer path is needed or not > > + * @param n > > + * The number of elemen

[dpdk-dev] [PATCH v10 3/6] net/virtio: add link speed devarg

2020-04-15 Thread Ivan Dyukov
Default value of link speed is 0x (Unknown) This patch adds speed devarg which allows to configure link speed of virtio device. Signed-off-by: Ivan Dyukov --- doc/guides/nics/virtio.rst | 7 ++ drivers/net/virtio/virtio_ethdev.c | 107 - drivers/net

[dpdk-dev] [PATCH v10 6/6] net/virtio: Support of VIRTIO_NET_F_SPEED_DUPLEX

2020-04-15 Thread Ivan Dyukov
This patch adds a support of VIRTIO_NET_F_SPEED_DUPLEX feature for virtio driver. There are two ways to specify speed of the link: * 'speed' devarg * negotiate speed from qemu via VIRTIO_NET_F_SPEED_DUPLEX The highest priority is devarg. If devarg is not specified, driver tries to negotiate it

[dpdk-dev] [PATCH v10 5/6] net/virtio-user: adding link speed devarg

2020-04-15 Thread Ivan Dyukov
virtio driver already parses speed devarg. virtio-user should add it to list of valid devargs and call eth_virtio_dev_init function which init speed value. eth_virtio_dev_init already is called from virtio_user_pmd_probe function. The only change is required to enable speed devargs: adding speed t

[dpdk-dev] [PATCH v10 2/6] net/virtio: refactor devargs parsing

2020-04-15 Thread Ivan Dyukov
refactor vdpa specific devargs parsing to more generic way Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 34 +- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev

[dpdk-dev] [PATCH v10 4/6] net/virtio-user: fix devargs parsing

2020-04-15 Thread Ivan Dyukov
strtoull returns 0 if it fails to parse input string. It's ignored in get_integer_arg. This patch handles error cases for strtoull function. Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device") Cc: sta...@dpdk.org Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_user_ethdev.c | 1

[dpdk-dev] [PATCH v10 1/6] net/virtio: replace default virtio speed

2020-04-15 Thread Ivan Dyukov
This patch set speed to unknown Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 4 ++-- lib/librte_ethdev/rte_ethdev.h | 27 ++- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/vir

[dpdk-dev] [PATCH v10 0/6] net/virtio: add link speed devarg

2020-04-15 Thread Ivan Dyukov
doc/guides/nics/virtio.rst | 15 +++ drivers/net/virtio/virtio_ethdev.c | 143 ++ drivers/net/virtio/virtio_ethdev.h |

Re: [dpdk-dev] [PATCH v2] event/dsw: fix gcc 4.8 false positive warning

2020-04-15 Thread David Marchand
On Wed, Apr 15, 2020 at 8:15 PM Mattias Rönnblom wrote: > > Add redundant stack variable initialization to work around > false-positive warnings in older versions of GCC. > > Fixes: bba7a1aeef46 ("event/dsw: improve migration mechanism") The commitid in master is 1f2b99e8d. > Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH] crypto/qat: support plain SHA1..SHA512 hashes

2020-04-15 Thread Akhil Goyal
> > This patch adds support for plain SHA-1, SHA-224, SHA-256, > SHA-384 and SHA-512 hashes to QAT PMD. > > Signed-off-by: Adam Dybkowski > --- App/test changes may not be required. Rebase this patch over Pablo's crypto test refactoring.

Re: [dpdk-dev] [PATCH] crypto/openssl: fix out-of-place encryption

2020-04-15 Thread Akhil Goyal
Hi Pablo, > When authenticating after encrypting, if the operation > is out-of-place, the destination buffer is the one > that will get authenticated. > If the cipher offset is higher than the authentication > offset, it means that part of the text to authenticate > will be plaintext, so this need

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: remove limitation for crypto sessions

2020-04-15 Thread Akhil Goyal
Hi Vladimir, > > Get rid of hardcoded limit of cryptodev sessions. > > Fixes: e1143d7dbbf4 ("examples/ipsec-secgw: get rid of maximum SA limitation") > Cc: vladimir.medved...@intel.com > > Signed-off-by: Vladimir Medvedkin > --- This will create an issue in case of rte_security sessions. Rte_s

Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-04-15 Thread Mattias Rönnblom
On 2020-04-15 20:17, Vladimir Medvedkin wrote: > K32V64 hash is a hash table that supports 32 bit keys and 64 bit values. > This table is hash function agnostic so user must provide > precalculated hash signature for add/delete/lookup operations. > > Signed-off-by: Vladimir Medvedkin > --- > lib

Re: [dpdk-dev] [PATCH v5] examples/ipsec-secgw: support flow director feature

2020-04-15 Thread Akhil Goyal
Hi Praveen, > > Support load distribution in security gateway application using > NIC load distribution feature(Flow Director). > Flow Director is used to redirect the specified inbound ipsec flow > to a specified queue.This is achieved by extending the SA rule syntax > to support specification b

Re: [dpdk-dev] [PATCH v4 3/3] ipfrag: add unit test case

2020-04-15 Thread Pavan Nikhilesh Bhagavatula
>Initial IP fragmentation unit test. > >Signed-off-by: Aaron Conole >--- > MAINTAINERS| 1 + > app/test/meson.build | 2 + > app/test/test_ipfrag.c | 276 >+ > 3 files changed, 279 insertions(+) > create mode 100644 app/test/test_ipfrag.c >

[dpdk-dev] [dpdk-announce] DPDK 18.11.7 (LTS) released

2020-04-15 Thread Kevin Traynor
Hi all, Here is a new LTS release: https://fast.dpdk.org/rel/dpdk-18.11.7.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=18.11 It has about 120 bugfixes since the previous release. Thanks to the authors who helped with backports and to the following who helped

Re: [dpdk-dev] [PATCH v3 0/4] add new k32v64 hash table

2020-04-15 Thread Mattias Rönnblom
On 2020-04-15 20:17, Vladimir Medvedkin wrote: > Currently DPDK has a special implementation of a hash table for > 4 byte keys which is called FBK hash. Unfortunately its main drawback > is that it only supports 2 byte values. > The new implementation called K32V64 hash > supports 4 byte keys and 8

Re: [dpdk-dev] [PATCH v2 2/2] test/compress: im buffer too small - add unit tests

2020-04-15 Thread Akhil Goyal
Hi Fiona/Adam, > This patch adds a new test suite for verification of the "internal > QAT IM buffer too small" case handling. These unit tests are > specific to the QAT PMD only - that's why they are contained in > a separate test suite. > > Signed-off-by: Adam Dybkowski > --- Why do we need to

[dpdk-dev] [PATCH v2] event/dsw: fix gcc 4.8 false positive warning

2020-04-15 Thread Mattias Rönnblom
Add redundant stack variable initialization to work around false-positive warnings in older versions of GCC. Fixes: bba7a1aeef46 ("event/dsw: improve migration mechanism") Cc: sta...@dpdk.org Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_event.c | 6 +++--- 1 file changed, 3 inserti

Re: [dpdk-dev] [PATCH] event/dsw: fix gcc 4.8 false positive warning

2020-04-15 Thread Mattias Rönnblom
On 2020-04-15 20:07, Mattias Rönnblom wrote: > Add redundant stack variable initialization to work around > false-positive warnings in older versions of GCC. > > Fixes: bba7a1aeef46 ("event/dsw: improve migration mechanism") > Cc: sta...@dpdk.org > > Signed-off-by: Mattias Rönnblom > --- > drive

Re: [dpdk-dev] [PATCH v2 2/2] test/crypto: add CPU crypto mode for AESNI MB

2020-04-15 Thread Akhil Goyal
> > > > This patch adds ability to run unit tests in cpu crypto mode for AESNI MB > > cryptodev. > > > > Signed-off-by: Konstantin Ananyev > > --- > > app/test/test_cryptodev.c | 146 ++ > > Acked-by: Pablo de Lara Acked-by: Akhil Goyal

Re: [dpdk-dev] [dpdk-ci] [EXT] [PATCH 0/8] DSW performance and statistics improvements

2020-04-15 Thread Mattias Rönnblom
On 2020-04-15 19:45, Thomas Monjalon wrote: > 15/04/2020 19:39, Mattias Rönnblom: >> On 2020-04-15 18:37, David Marchand wrote: >>> On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran >>> wrote: From: Mattias Rönnblom > Performance and statistics improvements for the distributed sof

[dpdk-dev] [PATCH] event/dsw: fix gcc 4.8 false positive warning

2020-04-15 Thread Mattias Rönnblom
Add redundant stack variable initialization to work around false-positive warnings in older versions of GCC. Fixes: bba7a1aeef46 ("event/dsw: improve migration mechanism") Cc: sta...@dpdk.org Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_event.c | 4 ++-- 1 file changed, 2 insertion

[dpdk-dev] [PATCH v3 4/4] test: add k32v64 perf tests

2020-04-15 Thread Vladimir Medvedkin
Add performance tests for rte_k32v64_hash Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 130 ++ 1 file changed, 130 insertions(+) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index a438eae..f45a8d9 100644 ---

[dpdk-dev] [PATCH v3 2/4] hash: add documentation for k32v64 hash library

2020-04-15 Thread Vladimir Medvedkin
Add programmers guide and doxygen API for k32v64 hash library Signed-off-by: Vladimir Medvedkin --- doc/api/doxy-api-index.md | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/k32v64_hash_lib.rst | 66 +++ 3 files changed,

[dpdk-dev] [PATCH v3 3/4] test: add k32v64 hash autotests

2020-04-15 Thread Vladimir Medvedkin
Add autotests for rte_k32v64_hash library Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 12 +++ app/test/meson.build| 3 + app/test/test_k32v64_hash.c | 229 4 files changed, 245 in

[dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-04-15 Thread Vladimir Medvedkin
K32V64 hash is a hash table that supports 32 bit keys and 64 bit values. This table is hash function agnostic so user must provide precalculated hash signature for add/delete/lookup operations. Signed-off-by: Vladimir Medvedkin --- lib/Makefile | 2 +- lib/librte_hash

[dpdk-dev] [PATCH v3 0/4] add new k32v64 hash table

2020-04-15 Thread Vladimir Medvedkin
Currently DPDK has a special implementation of a hash table for 4 byte keys which is called FBK hash. Unfortunately its main drawback is that it only supports 2 byte values. The new implementation called K32V64 hash supports 4 byte keys and 8 byte associated values, which is enough to store a point

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove unnecessary NULL check

2020-04-15 Thread Akhil Goyal
> > From: Yunjian Wang > > This NULL check is unnecessary, container_of is never NULL. > > Signed-off-by: Yunjian Wang > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: support 192/256 AES key sizes

2020-04-15 Thread Akhil Goyal
> > Adding support for the following, > 1. AES-192-GCM > 2. AES-256-GCM > 3. AES-192-CBC > > Signed-off-by: Anoob Joseph > Signed-off-by: Tejasree Kondoj > --- > Acked-by: Akhil Goyal

Re: [dpdk-dev] [dpdk-ci] [EXT] [PATCH 0/8] DSW performance and statistics improvements

2020-04-15 Thread Thomas Monjalon
15/04/2020 19:39, Mattias Rönnblom: > On 2020-04-15 18:37, David Marchand wrote: > > On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran > > wrote: > >> From: Mattias Rönnblom > >>> Performance and statistics improvements for the distributed software > >>> (DSW) event device. > >>> > >>> Mat

Re: [dpdk-dev] [EXT] [PATCH 0/8] DSW performance and statistics improvements

2020-04-15 Thread Mattias Rönnblom
On 2020-04-15 18:37, David Marchand wrote: > On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran > wrote: >>> -Original Message- >>> From: Mattias Rönnblom >>> Sent: Monday, March 9, 2020 12:21 PM >>> To: Jerin Jacob Kollanukkaran >>> Cc: dev@dpdk.org; stefan.sundkv...@ericsson.com;

Re: [dpdk-dev] [PATCH] maintainers: update for Marvell OCTEON TX2

2020-04-15 Thread Thomas Monjalon
15/04/2020 16:52, jer...@marvell.com: > From: Jerin Jacob > > Vamsi is no longer associated with Marvell. > Updating Marvell OCTEON TX2 PMDs MAINTAINERS file. > > Signed-off-by: Jerin Jacob Applied

[dpdk-dev] [PATCH v4 1/3] ip_frag: ensure minimum v4 fragmentation length

2020-04-15 Thread Aaron Conole
Do a formal parameter check of mtu length, as well as checking the the various inputs for validity. If any aren't acceptable, we bail. Signed-off-by: Aaron Conole --- lib/librte_ip_frag/rte_ipv4_fragmentation.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_ip_frag/rte_

[dpdk-dev] [PATCH v4 3/3] ipfrag: add unit test case

2020-04-15 Thread Aaron Conole
Initial IP fragmentation unit test. Signed-off-by: Aaron Conole --- MAINTAINERS| 1 + app/test/meson.build | 2 + app/test/test_ipfrag.c | 276 + 3 files changed, 279 insertions(+) create mode 100644 app/test/test_ipfrag.c diff --git a/

[dpdk-dev] [PATCH v4 2/3] ip_frag: ensure minimum v6 fragmentation length

2020-04-15 Thread Aaron Conole
In addition, do a formal parameter check. Signed-off-by: Aaron Conole --- lib/librte_ip_frag/rte_ipv6_fragmentation.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_ip_frag/rte_ipv6_fragmentation.c b/lib/librte_ip_frag/rte_ipv6_fragmentation.c index 43449970e5..ee984aed

[dpdk-dev] [PATCH v4 0/3] ip_frag: add a unit test for fragmentation

2020-04-15 Thread Aaron Conole
This adds a simple unit test for the ip fragmentation library and covers fragmenting ipv4 and ipv6. Additionally, some fixes are introduced, which are really just sanity rather than real issues in the field. v3->v4: - Drop the frag header detection from ipv6 code - Full parameter sanity checking

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-15 Thread Trahe, Fiona
Hi Ray/Bruce/Thomas, We've been trying to make sense of the versioning scheme - but as the docs describe and give examples of a 2-number scheme and the code has a 3-number scheme it's pretty confusing. If you can help me fill out the following table this may help: VERSION | ABI_VERSION | LIBA

Re: [dpdk-dev] [PATCH 1/5] net/enic: fix action reordering

2020-04-15 Thread Ferruh Yigit
On 4/15/2020 2:06 AM, John Daley wrote: > From: Hyong Youb Kim > > The current implementation produces wrong ordering for several cases > like these: > > 1. mark, decap, steer > Current: steer, mark, decap > Correct: mark, steer, decap > > 2. decap, steer, steer > Current: steer, steer, decap >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 18.11 17.11] doc: in doc-clean removed the folder not containing rst files

2020-04-15 Thread Kevin Traynor
On 24/03/2020 12:57, Kevin Traynor wrote: > On 24/03/2020 07:04, Muhammad Bilal wrote: >> On Fri, Mar 20, 2020 at 3:02 PM Kevin Traynor wrote: >>> >>> On 20/03/2020 09:53, Muhammad Bilal wrote: On Fri, Mar 20, 2020 at 2:39 PM Luca Boccassi wrote: > > On Fri, 2020-03-20 at 13:02 +0500

Re: [dpdk-dev] [EXT] [PATCH 0/8] DSW performance and statistics improvements

2020-04-15 Thread David Marchand
On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran wrote: > > > -Original Message- > > From: Mattias Rönnblom > > Sent: Monday, March 9, 2020 12:21 PM > > To: Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; stefan.sundkv...@ericsson.com; ola.liljed...@arm.com; > > Mattias Rönnblom

Re: [dpdk-dev] [dpdk-dev v4 3/3] app/testpmd: add new types to RSS hash commands

2020-04-15 Thread Stephen Hemminger
On Tue, 14 Apr 2020 09:48:31 + Ori Kam wrote: > > @@ -2299,6 +2299,22 @@ cmd_config_rss_parsed(void *parsed_result, > > rss_conf.rss_hf = ETH_RSS_L4_SRC_ONLY; > > else if (!strcmp(res->value, "l4-dst-only")) > > rss_conf.rss_hf = ETH_RSS_L4_DST_ONLY; > > + else i

  1   2   3   >