Re: [dpdk-dev] [PATCH v3 09/12] service: avoid race condition for MT unsafe service

2020-04-17 Thread Honnappa Nagarahalli
> > > > > > > > > > Subject: [PATCH v3 09/12] service: avoid race condition for MT > > > > > > unsafe service > > > > > > > > > > > > From: Honnappa Nagarahalli > > > > > > > > > > > > There has possible that a MT unsafe service might get > > > > > > configured to run on another core while the s

Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging

2020-04-17 Thread Bill Zhou
> -Original Message- > From: Ferruh Yigit > Sent: Saturday, April 18, 2020 6:01 AM > To: Bill Zhou ; Ori Kam ; > Matan Azrad ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com; > john.mcnam...@intel.com; marko.kovace...@intel.com; Thomas Monjalon > ; arybche...@

[dpdk-dev] [PATCH v2] app/testpmd: configure rxd and txd number correctly

2020-04-17 Thread Lijun Ou
When users configure rxds and txds by used port config cmd based on testpmd application, it will not be able to configure rxd and txd according to the max capability range supported by the actual NIC hardware. Due testpmd defects, it can only configure a fixed range to 0 to 2048. The final result i

[dpdk-dev] [PATCH v4 11/11] doc: add feature matrix table for bbdev devices

2020-04-17 Thread Nicolas Chautru
Adding missing overview page in documentation with comparison of feature set by each available PMD implementation. Signed-off-by: Nicolas Chautru --- .gitignore | 1 + doc/guides/bbdevs/features/default.ini | 16 doc/guides/bbdevs/feature

[dpdk-dev] [PATCH v4 10/11] baseband/fpga_5gnr_fec: add interrupt support

2020-04-17 Thread Nicolas Chautru
Adding support for interrupt capability in the PMD and the related operations. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 139 + 1 file changed, 139 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/

[dpdk-dev] [PATCH v4 09/11] baseband/fpga_5gnr_fec: add harq loopback capability

2020-04-17 Thread Nicolas Chautru
Adding optional capability to support loopback preloading and check of the extern HARQ memory. This function is required to run the HARQ bit exact test successfully. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 4 +- drivers/baseband/fpga_5gnr_fec/rte

[dpdk-dev] [PATCH v4 07/11] baseband/fpga_5gnr_fec: add debug functionality

2020-04-17 Thread Nicolas Chautru
Adding functionality for debug mode to be more verbose and catch error from unsupported configuration. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 30 ++ drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 356 + 2 files changed,

[dpdk-dev] [PATCH v4 08/11] baseband/fpga_5gnr_fec: add configure function

2020-04-17 Thread Nicolas Chautru
Add configure function to configure the PF from within the bbdev-test itself without external application configuration the device. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 57 ++ doc/guides/bbdevs/fpga_5gnr_fec.rst| 123 +++

[dpdk-dev] [PATCH v4 05/11] baseband/fpga_5gnr_fec: add LDPC processing functions

2020-04-17 Thread Nicolas Chautru
Adding LDPC processing operations and related documentation. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/fpga_5gnr_fec.rst| 28 + drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 9 + drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 659 +

[dpdk-dev] [PATCH v4 06/11] baseband/fpga_5gnr_fec: add HW error capture

2020-04-17 Thread Nicolas Chautru
Adding HW specific parsing of error report for negative scenarios. Not hit through unit test. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 60 +- 1 file changed, 58 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/fpga_5g

[dpdk-dev] [PATCH v4 01/11] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-04-17 Thread Nicolas Chautru
Add stubs for the FPGA 5GNR FEC PMD Signed-off-by: Nicolas Chautru --- config/common_base | 5 + doc/guides/bbdevs/fpga_5gnr_fec.rst| 146 doc/guides/bbdevs/index.rst| 1 + doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v4 04/11] baseband/fpga_5gnr_fec: add queue configuration

2020-04-17 Thread Nicolas Chautru
Adding function to create and configure queues for the device. Still no capability. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 110 +++ drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 365 - 2 files changed, 474 insertions

[dpdk-dev] [PATCH v4 02/11] baseband/fpga_5gnr_fec: add register definition file

2020-04-17 Thread Nicolas Chautru
Add in the list of registers for the device and related HW specs definitions. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 189 + 1 file changed, 189 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h b/drive

[dpdk-dev] [PATCH v4 00/11] drivers/baseband: PMD for FPGA 5GNR FEC

2020-04-17 Thread Nicolas Chautru
v4: Fix incremental patch build and expose PMD header file to meson. v3: Incremental changes from reviews : file name change, moving few inline function to .h, adding missing inline, doxygen markup fix. Adding new baseband PMD for FPGA 5GNR FEC implementation. Nicolas Chautru (11): drivers

[dpdk-dev] [PATCH v4 03/11] baseband/fpga_5gnr_fec: add info_get function

2020-04-17 Thread Nicolas Chautru
Add in the "info_get" function to the driver, to allow us to query the device. No capability are available yet. Linking bbdev-test to support the PMD with null capability. Signed-off-by: Nicolas Chautru --- app/test-bbdev/Makefile| 3 ++ app/test-bbdev/meson.build

Re: [dpdk-dev] [PATCH] app/testpmd: configure rxd and txd number correctly

2020-04-17 Thread oulijun
在 2020/4/18 8:42, Ferruh Yigit 写道: On 4/17/2020 11:59 AM, Lijun Ou wrote: When users configure rxds and txds by used port config cmd based on testpmd application, it will not be able to configure rxd and txd according to the max capability range supported by the actual NIC hardware. Due testp

Re: [dpdk-dev] [PATCH v2 00/10] net/mlx5: optimize flow resource allocation

2020-04-17 Thread Suanming Mou
Hi Ferruh, Sorry that we missed the 32-bit build verification. I have created the fix path. https://patches.dpdk.org/patch/68831/ Thanks SuanmingMou > -Original Message- > From: Ferruh Yigit > Sent: Friday, April 17, 2020 10:59 PM > To: Suanming Mou ; Raslan Darawsheh > > Cc: Slava Ovs

[dpdk-dev] [PATCH] net/mlx5: fix indexed pool 32-bits build error

2020-04-17 Thread Suanming Mou
Currently, 32-bits compiler treats int64_t as long long int different with 64-bits. The indexed pool dump function build will be failed in 32-bits mode. As the maximum supported entries of the indexed pool is UINT32_MAX, use the 64 bits to record the pool statistics is waste of memory. Align the s

Re: [dpdk-dev] [PATCH] app/testpmd: configure rxd and txd number correctly

2020-04-17 Thread Ferruh Yigit
On 4/17/2020 11:59 AM, Lijun Ou wrote: > When users configure rxds and txds by used port config cmd based > on testpmd application, it will not be able to configure rxd and > txd according to the max capability range supported by the actual > NIC hardware. Due testpmd defects, it can only configure

Re: [dpdk-dev] [PATCH] net/tap: fix rxq and txq fd check before close

2020-04-17 Thread Ferruh Yigit
On 4/17/2020 1:03 PM, wangyunjian wrote: > From: Yunjian Wang > > The fd is possibly a negative value while it is passed as an > argument to function "close". Fix the check to the fd. > > Fixes: ed8132e7c912 ("net/tap: move fds of queues to be in process private") > CC: sta...@dpdk.org > > Sign

Re: [dpdk-dev] [PATCH] doc: update release notes

2020-04-17 Thread Ajit Khaparde
On Fri, Apr 17, 2020 at 3:29 PM Ferruh Yigit wrote: > On 4/17/2020 5:35 PM, Ajit Khaparde wrote: > > Update release notes for 20.05 release with Broadcom PMD improvements: > > > > * Added support for host based flow table management > > * Added flow counters to extended stats > > * Added PC

Re: [dpdk-dev] [PATCH v3 08/11] baseband/fpga_5gnr_fec: add configure function

2020-04-17 Thread Chautru, Nicolas
> > Add configure function to configure the PF from within the bbdev-test > > itself without external application configuration the device. > > > > Signed-off-by: Nicolas Chautru > > --- > > app/test-bbdev/test_bbdev_perf.c | 57 ++ > > doc/guides/bbdevs/fpga_5gnr_fec.rst

Re: [dpdk-dev] [PATCH] doc: update release notes

2020-04-17 Thread Ferruh Yigit
On 4/17/2020 5:35 PM, Ajit Khaparde wrote: > Update release notes for 20.05 release with Broadcom PMD improvements: > > * Added support for host based flow table management > * Added flow counters to extended stats > * Added PCI function stats to extended stats > > Signed-off-by: Ajit Khapa

Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging

2020-04-17 Thread Stephen Hemminger
On Fri, 17 Apr 2020 23:00:57 +0100 Ferruh Yigit wrote: > On 4/14/2020 9:32 AM, Dong Zhou wrote: > > One of the reasons to destroy a flow is the fact that no packet matches the > > flow for "timeout" time. > > For example, when TCP\UDP sessions are suddenly closed. > > > > Currently, there is not

Re: [dpdk-dev] [PATCH v2] net/bnxt: add flow stats in extended stats

2020-04-17 Thread Ferruh Yigit
On 4/17/2020 3:49 PM, Ajit Khaparde wrote: > On Thu, Apr 16, 2020 at 10:49 PM Ajit Khaparde > wrote: > >> From: Somnath Kotur >> >> This patch allows to display flow stats in extended stats. >> To do this, DMA-able memory is registered with the FW during device >> initialization. Then the driver

Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging

2020-04-17 Thread Ferruh Yigit
On 4/14/2020 9:32 AM, Dong Zhou wrote: > One of the reasons to destroy a flow is the fact that no packet matches the > flow for "timeout" time. > For example, when TCP\UDP sessions are suddenly closed. > > Currently, there is not any DPDK mechanism for flow aging and the > applications use their o

[dpdk-dev] [PATCH] doc: support IPsec Multi-buffer lib v0.54

2020-04-17 Thread Pablo de Lara
Updated AESNI MB and AESNI GCM PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_gcm.rst| 6 +++--- doc/guides/cryptodevs/aesni_mb.rst | 6 +++--- doc/guides/rel_notes/releas

[dpdk-dev] [PATCH v1 14/17] timer: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_TIMER_DEBUG. The old define is completely removed from source code and config. The tests were adjusted to use new flag. Signed-off-by: Lukasz Wojciechowski --- app/test/test_timer_secondary.c | 2 +- config/common_base | 1 - l

[dpdk-dev] [PATCH v1 17/17] sched: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_SCHED_DEBUG. The old define is completely removed from source code and config. Signed-off-by: Lukasz Wojciechowski --- config/common_base | 1 - lib/librte_sched/rte_sched.c | 10 +- 2 files changed, 5 insertions(+), 6 deletions(-

[dpdk-dev] [PATCH v1 13/17] rcu: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_RCU_DEBUG. The old define is completely removed from source code and config. Documentation was also updated. Signed-off-by: Lukasz Wojciechowski --- config/common_base| 1 - doc/guides/prog_guide/rcu_lib.rst | 8 li

[dpdk-dev] [PATCH v1 15/17] vhost: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_VHOST_DEBUG. The old define is completely removed from source code and config. Signed-off-by: Lukasz Wojciechowski --- config/common_base | 1 - lib/librte_vhost/vhost.h| 2 +- lib/librte_vhost/vhost_crypto.c | 2 +- lib/

[dpdk-dev] [PATCH v1 16/17] eal: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_MALLOC_DEBUG. The old define is completely removed from source code and config. Tests and documentation were also updated. Signed-off-by: Lukasz Wojciechowski --- app/test/test_malloc.c | 4 ++-- config/common_base

[dpdk-dev] [PATCH v1 11/17] mempool: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_MEMPOOL_DEBUG. The old define is completely removed from source code and config. Documentation was also updated. Signed-off-by: Lukasz Wojciechowski --- config/common_base| 1 - doc/guides/prog_guide/mempool_lib.rst | 7

[dpdk-dev] [PATCH v1 12/17] power: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_POWER_DEBUG. The old define is completely removed from source code and config. Signed-off-by: Lukasz Wojciechowski --- config/common_base | 1 - lib/librte_power/power_acpi_cpufreq.c | 2 +- lib/librte_power/power_pstat

[dpdk-dev] [PATCH v1 10/17] mbuf: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_MBUF_DEBUG. The old define is completely removed from source code and config. Tests and documentation were also updated. Signed-off-by: Lukasz Wojciechowski --- app/test/test_mbuf.c | 2 +- config/common_base | 1

[dpdk-dev] [PATCH v1 09/17] lpm: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_LPM_DEBUG. The old define is completely removed from source code and config. Application of the flag in tests was also adjusted. Signed-off-by: Lukasz Wojciechowski --- app/test/test_lpm.c | 2 +- config/common_base | 1 - lib/libr

[dpdk-dev] [PATCH v1 08/17] ip_frag: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_IP_FRAG_DEBUG. The old define is completely removed from source code and config. The documentation was updated also. Signed-off-by: Lukasz Wojciechowski --- config/common_base | 1 - doc/guides/prog_guide/ip_

[dpdk-dev] [PATCH v1 06/17] cmdline: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_CMDLINE_DEBUG. The old define is completely removed from source code and config. Signed-off-by: Lukasz Wojciechowski --- config/common_base | 1 - lib/librte_cmdline/cmdline_cirbuf.h| 2 +- lib/librte_cmdline/cmdline_p

[dpdk-dev] [PATCH v1 02/17] config: remove unused config flags

2020-04-17 Thread Lukasz Wojciechowski
Following flags were still present in the common_base config, but they were not used anywhere in the code: * CONFIG_RTE_LIBRTE_ACL_DEBUG * CONFIG_RTE_LIBRTE_NFP_DEBUG_TX * CONFIG_RTE_LIBRTE_NFP_DEBUG_RX * CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG Signed-off-by: Lukasz Wojciechowski --- config/com

[dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_ETHDEV_DEBUG. The old define is completely removed from source code and config. The changes were applied also to all drivers using this flag. Signed-off-by: Lukasz Wojciechowski --- config/common_base | 1 - drivers

[dpdk-dev] [PATCH v1 04/17] eventdev: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_EVENTDEV_DEBUG. The old define is completely removed from source code and config. Signed-off-by: Lukasz Wojciechowski --- config/common_base | 1 - lib/librte_eventdev/rte_event_eth_tx_adapter.h | 2 +- lib/librte_

Re: [dpdk-dev] [RFC PATCH] ci: reduce examples built for static builds

2020-04-17 Thread Thomas Monjalon
16/03/2020 18:09, Bruce Richardson: > Static builds can take a lot of space, so reduce the number of examples > built when doing those static builds. > > Signed-off-by: Bruce Richardson No objection after one month, it is a RFC but I see nothing to change. Applied, thanks

[dpdk-dev] [PATCH v1 07/17] hash: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_HASH_DEBUG. The old define is completely removed from source code and config. Signed-off-by: Lukasz Wojciechowski --- config/common_base| 1 - lib/librte_hash/rte_cuckoo_hash.h | 4 ++-- 2 files changed, 2 insertions(+), 3 del

[dpdk-dev] [PATCH v1 05/17] fib: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_FIB_DEBUG. The old define is completely removed from source code and config. Signed-off-by: Lukasz Wojciechowski --- config/common_base| 1 - lib/librte_fib/rte_fib.c | 2 +- lib/librte_fib/rte_fib6.c | 2 +- 3 files changed, 2 inser

[dpdk-dev] [PATCH v1 00/17] introduce global debug flag

2020-04-17 Thread Lukasz Wojciechowski
This set of patches introduces a global debug flag for dpdk. This will allow easy switch to debug build configuration using a single flag. In the debug mode a RTE_DEBUG macro is defined to 1 and can be used to place a debug code inside #ifdef #endif clauses. It should be used for enabling debug co

[dpdk-dev] [PATCH v1 01/17] config: introduce global debug flag

2020-04-17 Thread Lukasz Wojciechowski
There already is a meson core option "debug". To enable this option add -Ddebug=true to the meson command during setup or configuration of the build environment. By enabling this flag the globaly defined macro RTE_DEBUG becomes defined. It should be used for enabling debug code in all dpdk project

Re: [dpdk-dev] [PATCH v3 2/2] test/compress: im buffer too small - add unit tests

2020-04-17 Thread Akhil Goyal
> > This patch adds new tests for verification of the "internal > > QAT IM buffer too small" case handling. These unit tests aren't > > specific to the QAT PMD only - they pass or skip on other PMDs like > > ISAL and ZLIB (depending on particular PMD capabilities). > > > > Signed-off-by: Adam Dybko

Re: [dpdk-dev] [PATCH] sched: fix port time rounding error

2020-04-17 Thread Dumitrescu, Cristian
> -Original Message- > From: alangordonde...@gmail.com > Sent: Thursday, April 16, 2020 9:48 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Alan Dewar > Subject: [PATCH] sched: fix port time rounding error > > From: Alan Dewar > > The QoS scheduler works off port time that is co

Re: [dpdk-dev] [PATCH 1/2] examples/ipsec-secgw: remove duplicated if check

2020-04-17 Thread Akhil Goyal
> > > The two if check does the same task, so removing one. > > > > Coverity Issue: 355669 > > Fixes: 9ad50c29d01d ("examples/ipsec-secgw: add app mode worker") > > > > Signed-off-by: Ankur Dwivedi > > --- > > examples/ipsec-secgw/ipsec_worker.c | 7 +-- > > 1 file changed, 1 insertion(+), 6

Re: [dpdk-dev] [PATCH v2 00/12] enhancements to host based flow table management

2020-04-17 Thread Ajit Khaparde
On Fri, Apr 17, 2020 at 9:19 AM Ajit Khaparde wrote: > This patchset introduces enhancements to the flow table management > related to resource sharing and deletion, flow matching performance, > and flow flushing. > Additionally, a new port database was introduced to store frequently > required p

Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix build

2020-04-17 Thread Thomas Monjalon
17/04/2020 20:55, Ferruh Yigit: > Build fails because '__rte_unused' macro not defined in file, error > produced by 'i686-native-linux-gcc config' but it seems generic issue. > > Build error: > .../examples/vm_power_manager/oob_monitor_nop.c:11:13: >error: expected ‘;’ before ‘static’ >11

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove unnecessary NULL check

2020-04-17 Thread Akhil Goyal
> > > > From: Yunjian Wang > > > > This NULL check is unnecessary, container_of is never NULL. > > > > Signed-off-by: Yunjian Wang > > --- > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks

Re: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: support 192/256 AES key sizes

2020-04-17 Thread Akhil Goyal
> > > > > > Adding support for the following, > > 1. AES-192-GCM > > 2. AES-256-GCM > > 3. AES-192-CBC > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Tejasree Kondoj > > --- > > > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] drivers: fix gcc 10 errors due to logtype var in header

2020-04-17 Thread Akhil Goyal
> > > > Acked-by: Lukasz Wojciechowski > > > > -- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] cryptodev: add missing feature name

2020-04-17 Thread Akhil Goyal
> > >> -Original Message- > > >> From: dev On Behalf Of Pablo de Lara > > >> Sent: Tuesday, April 14, 2020 6:30 PM > > >> To: Doherty, Declan > > >> Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > > >> ; sta...@dpdk.org > > >> Subject: [dpdk-dev] [PATCH] cryptodev: add mis

Re: [dpdk-dev] [PATCH] drivers/crypto: move logtype variables to source files

2020-04-17 Thread Akhil Goyal
> > The four crypto drivers: kasumi, mvsam, snow3g and zuc define logtype > > variables in their header file. As the header files are included in more > > than one > > compilation unit, it might cause appearance of multiple instances of the > variable > > and a linker error. > > Such situation can

Re: [dpdk-dev] [PATCH v6] crypto/aesni_mb: support DOCSIS AES-256

2020-04-17 Thread Akhil Goyal
> > This patch adds support for DOCSIS AES-256 when using AESNI-MB > > Signed-off-by: Mairtin o Loingsigh > Acked-by: Pablo de Lara > --- > This patch depends on these two patches: > Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v6] examples/ipsec-secgw: support flow director feature

2020-04-17 Thread Akhil Goyal
> > Support load distribution in security gateway application using > NIC load distribution feature(Flow Director). > Flow Director is used to redirect the specified inbound ipsec flow > to a specified queue.This is achieved by extending the SA rule syntax > to support specification by adding new

Re: [dpdk-dev] [PATCH] test/crypto: fix flag check

2020-04-17 Thread Akhil Goyal
> > > > An incorrect flag check was done, using "&&" instead of "&". > > > > Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Pablo de Lara > Acked-by: Fiona Trahe Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v3 0/2] support CPU crypto for AESNI MB PMD

2020-04-17 Thread Akhil Goyal
> > v3 - v2 > Address Pablo comments: > - Fix doc typo > - Update release notes > > v2 - v1 > Fix gcc 4.8 compilation issue > > Add support for CPU crypto API into aesni_mb PMD > and extend cryptodev UT to cover this new functionality. > Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] crypto/openssl: fix out-of-place encryption

2020-04-17 Thread Akhil Goyal
> > > > Hi Pablo, > > > > > When authenticating after encrypting, if the operation is > > > out-of-place, the destination buffer is the one that will get > > > authenticated. > > > If the cipher offset is higher than the authentication offset, it > > > means that part of the text to authenticate

Re: [dpdk-dev] [PATCH v1] ethdev: add rte_device to port_id function

2020-04-17 Thread Stephen Hemminger
On Fri, 17 Apr 2020 18:48:37 +0200 Gaetan Rivet wrote: > +/** > + * Find the owned ethdev port id of an `rte_device`. > + * > + * @param dev > + * An `rte_device`. > + * @param owner > + * An owner id. Use `RTE_ETH_DEV_NO_OWNER` for ownerless ports. > + * > + * @return > + * The port id of

Re: [dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security

2020-04-17 Thread Lukasz Wojciechowski
W dniu 17.04.2020 o 22:21, Akhil Goyal pisze: >> W dniu 17.04.2020 o 21:46, Akhil Goyal pisze: >>> Hi Lukasz, Set of patches fix minor issues like proper verification of input parameters and aligning documentation with code in the matter of return values. Another fixed issue is inv

Re: [dpdk-dev] [PATCH v3 08/11] baseband/fpga_5gnr_fec: add configure function

2020-04-17 Thread Akhil Goyal
> > Add configure function to configure the PF from within > the bbdev-test itself without external application > configuration the device. > > Signed-off-by: Nicolas Chautru > --- > app/test-bbdev/test_bbdev_perf.c | 57 ++ > doc/guides/bbdevs/fpga_5gnr_fec.rst

Re: [dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security

2020-04-17 Thread Akhil Goyal
> W dniu 17.04.2020 o 21:46, Akhil Goyal pisze: > > Hi Lukasz, > >> Set of patches fix minor issues like proper verification of input > >> parameters and aligning documentation with code in the matter of return > >> values. Another fixed issue is invalid decrementation of the session > >> counter w

Re: [dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security

2020-04-17 Thread Lukasz Wojciechowski
W dniu 17.04.2020 o 21:46, Akhil Goyal pisze: > Hi Lukasz, >> Set of patches fix minor issues like proper verification of input >> parameters and aligning documentation with code in the matter of return >> values. Another fixed issue is invalid decrementation of the session >> counter which might

Re: [dpdk-dev] [PATCH v3 00/11] drivers/baseband: PMD for FPGA 5GNR FEC

2020-04-17 Thread Akhil Goyal
> > -- > Please also update the MAINTAINERS for the newly added files. Please ignore this. There is a blanket update in MAINTAINERS for all The bbdev drivers.

Re: [dpdk-dev] [PATCH v3 00/11] drivers/baseband: PMD for FPGA 5GNR FEC

2020-04-17 Thread Akhil Goyal
> > v3: Incremental changes from reviews : file name change, > moving few inline function to .h, adding missing inline, > doxygen markup fix. > > Adding new baseband PMD for FPGA 5GNR FEC implementation. > > Nicolas Chautru (11): > drivers/baseband: add PMD for FPGA 5GNR FEC > baseband/fpg

Re: [dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security

2020-04-17 Thread Akhil Goyal
Hi Lukasz, > > Set of patches fix minor issues like proper verification of input > parameters and aligning documentation with code in the matter of return > values. Another fixed issue is invalid decrementation of the session > counter which might cause inconsistency between counter values and a t

[dpdk-dev] [Bug 452] cuckoo hash gcc10 warning

2020-04-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=452 Bug ID: 452 Summary: cuckoo hash gcc10 warning Product: DPDK Version: 20.05 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal

[dpdk-dev] [PATCH] examples/vm_power_manager: fix build

2020-04-17 Thread Ferruh Yigit
Build fails because '__rte_unused' macro not defined in file, error produced by 'i686-native-linux-gcc config' but it seems generic issue. Build error: .../examples/vm_power_manager/oob_monitor_nop.c:11:13: error: expected ‘;’ before ‘static’ 11 | __rte_unused static float |

Re: [dpdk-dev] [PATCH v3 05/11] baseband/fpga_5gnr_fec: add LDPC processing functions

2020-04-17 Thread Akhil Goyal
> > Adding LDPC processing operations and related documentation. > > Signed-off-by: Nicolas Chautru > --- There are compilation issues while compiling the patches individually Please fix them. Please also check meson compilation also for all individual patches. /home/akhil/up/dpdk-next-cry

Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix

2020-04-17 Thread Ajit Khaparde
On Fri, Apr 17, 2020 at 9:32 AM Thomas Monjalon wrote: > Call for action below (especially for octeontx2 and virtio): > > 24/03/2020 09:36, Andrew Rybchenko: > > On 3/20/20 2:15 PM, Zhang, Qi Z wrote: > > > From: Thomas Monjalon > > >> 20/03/2020 06:35, Zhang, Qi Z: > > >>> From: Thomas Monjalon

[dpdk-dev] [dpdk-announce] DPDK Userspace CFP is NOW OPEN (Sept. 24-25)

2020-04-17 Thread Jill Lovato
DPDK Community, We are pleased to announce the DPDK Userspace Summit will take place September 24-25. Currently, the plan is to host a physical event in Bordeaux, France. However, we’ll continue monitoring the current COVID-19 situation; should the need to change dates, venue, or adjust to a vir

[dpdk-dev] dpdk-devbind --status and PCI-PT

2020-04-17 Thread Bly, Mike
Hello, I am looking to know if folks were aware that running "dpdk-debind -status" on a host displays both NICs in host space as well as those "owned" by a VM via PCI-PT where that VM is internally running a DPDK enabled application. Per below there is no discernable difference indicated as to

[dpdk-dev] [PATCH v3 2/2] test/cryptodev: add chacha poly test cases to cryptodev

2020-04-17 Thread Arek Kusztal
This patch adds Chacha20-Poly1305 implementation to cryptodev tests. Signed-off-by: Arek Kusztal --- v3: - rebased against 20.05 app/test/test_cryptodev.c | 18 ++- app/test/test_cryptodev_aead_test_vectors.h | 75 + 2 files changed, 92 insertion

[dpdk-dev] [PATCH v3 1/2] crypto/qat: add chacha poly implementation

2020-04-17 Thread Arek Kusztal
This patchset adds Chacha20-Poly1305 implementation to Intel QuickAssist Technology pmd. Signed-off-by: Arek Kusztal --- v3: - rebased against 20.05 doc/guides/cryptodevs/features/qat.ini| 13 +-- doc/guides/cryptodevs/qat.rst | 1 + doc/guides/rel_notes/release_20_05.rst|

[dpdk-dev] [PATCH v3] lpm: skip table entries update if rules found

2020-04-17 Thread Yangchao Zhou
Table entries do not need to be updated if the same rules can be found. Signed-off-by: Yangchao Zhou --- lib/librte_lpm/rte_lpm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c index 268756419..9085f935e 100644 --- a/lib/librte_lp

Re: [dpdk-dev] [PATCH v12 1/7] ethdev: added UNKNOWN speed value

2020-04-17 Thread Thomas Monjalon
17/04/2020 17:54, Maxime Coquelin: > Hi Ferruh, > > On 4/17/20 5:44 PM, Ferruh Yigit wrote: > > On 4/17/2020 4:14 PM, Maxime Coquelin wrote: > >> Hi Ferruh & Andrew, > >> > >> On 4/17/20 8:40 AM, Ivan Dyukov wrote: > >>> Hello Everyone, > >>> > >>> Ook. I can take care about examples updates. link

[dpdk-dev] [PATCH] net/mlx5: improve logging of MPRQ selection

2020-04-17 Thread Alexander Kozyrev
MPRQ is silently turned off in case there is not enough Rx queues configured. Improve the logging to show a warning in this case to notify a user about the Rx burst function selected. Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support") Cc: sta...@dpdk.org Signed-off-by: Alexander Kozyre

Re: [dpdk-dev] [PATCH 0/4] vdpa/mlx5: support direct notification

2020-04-17 Thread Maxime Coquelin
On 3/24/20 3:24 PM, Asaf Penso wrote: > In order to save CPU usage in host and even make it 0 when guest work with > poll mode, > add support for direct doorbell ringing. > > Now, when the feature is supported in QEMU, the guest doorbell address is > mapped directly to the HW doorbell space a

[dpdk-dev] [PATCH] net/mlx5: set dynamic flow metadata in Rx queues

2020-04-17 Thread Alexander Kozyrev
Using a global mbuf dynamic field for metadata incurs some performance penalty on a datapath. Store this information in the Rx queue descriptor for a better cache locality. Fixes: a18ac6113331 ("net/mlx5: add metadata support to Rx datapath") Cc: sta...@dpdk.org Signed-off-by: Alexander Kozyrev

Re: [dpdk-dev] [PATCH] vdpa/mlx5: set default queue indices

2020-04-17 Thread Maxime Coquelin
On 3/23/20 6:50 PM, Asaf Penso wrote: > The rte_vhost_get_vring_base function is being called to get the values > of last_avail_idx and last_used_idx. > These fields will not have the correct values in case the function > returns an error. > > Adding a check for the function return value, and i

Re: [dpdk-dev] [PATCH v2] doc: add note for vhost builtin example

2020-04-17 Thread Maxime Coquelin
On 3/25/20 5:21 AM, Xuan Ding wrote: > Add memory pre-allocation note for vhost example when enabling > "builtin-net-driver". > > Signed-off-by: Xuan Ding > --- > > v2: > * Modified expression in doc to make it more accurate. > --- > doc/guides/sample_app_ug/vhost.rst | 7 +++ > 1 file c

Re: [dpdk-dev] [PATCH v8 0/5] net/virtio: add link speed devarg

2020-04-17 Thread Maxime Coquelin
Hi Ivan, On 3/30/20 9:57 AM, Ivan Dyukov wrote: > > v8 changes: > * fix code style > > v7 chagnes: > * rebased to latest master > * added support of VIRTIO_NET_F_SPEED_DUPLEX > > v6 changes: > * fix code style > > v5 changes: > * fixed code style > * fixed commit message and logging text > >

Re: [dpdk-dev] [PATCH v2] vhost: fix shadow update

2020-04-17 Thread Maxime Coquelin
On 4/17/20 4:39 AM, Marvin Liu wrote: > Defer shadow ring update introduces functional issue which has been > described in Eugenio's fix patch. > > The current implementation of vhost_net in packed vring tries to fill > the shadow vector before send any actual changes to the guest. While > this

Re: [dpdk-dev] [PATCH] vhost: fix shadowed descs not flushed

2020-04-17 Thread Maxime Coquelin
On 4/17/20 3:16 AM, Marvin Liu wrote: > When ring size or enqueue packets not aligned with batch number, it is > possible that descs update still kept in shadowed used structure when > batched enqueue. Fix this issue by flushing remained shadowed used descs > before batch flush. > > Fixes: f415

Re: [dpdk-dev] [PATCH v3 00/11] drivers/baseband: PMD for FPGA 5GNR FEC

2020-04-17 Thread Akhil Goyal
> Hi Akhil, > > You already have applied these 2 from thr other serie. So when I rebased on > latest these are no longer required. > If you remember we split the initial serie into 2 separate series, but then I > kept > the same first 2 patches on both serie are they are required as a dependenc

[dpdk-dev] [PATCH] doc: update release notes

2020-04-17 Thread Ajit Khaparde
Update release notes for 20.05 release with Broadcom PMD improvements: * Added support for host based flow table management * Added flow counters to extended stats * Added PCI function stats to extended stats Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_20_05.rst | 8

Re: [dpdk-dev] [PATCH v3 00/11] drivers/baseband: PMD for FPGA 5GNR FEC

2020-04-17 Thread Chautru, Nicolas
Hi Akhil, You already have applied these 2 from thr other serie. So when I rebased on latest these are no longer required. If you remember we split the initial serie into 2 separate series, but then I kept the same first 2 patches on both serie are they are required as a dependency (to make su

[dpdk-dev] [PATCH v1] ethdev: add rte_device to port_id function

2020-04-17 Thread Gaetan Rivet
Some EAL facilities are using rte_devices. Once the rte_device of a port is found, some need to transform it into a port id to be able to use the ethdev API. Add a function to transform an rte_device pointer into an ethdev port id, as well as an ownership aware variant. Use this new API in a few

[dpdk-dev] [PATCH v3] net/bnxt: remove redefinition of page size

2020-04-17 Thread Ajit Khaparde
PAGE_SIZE is a common macro and cause redefinition errors. Replace such occurrences. Signed-off-by: Ajit Khaparde --- v2->v3: Fixed a typo in commit message. --- drivers/net/bnxt/tf_core/tf_tbl.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/b

[dpdk-dev] [PATCH v1 2/2] bonding: fix PCI address comparison on non-pci ports

2020-04-17 Thread Gaetan Rivet
The bonding PMD will iterate over all available ETH ports and for each, compare a chunk of bytes at an offset that would correspond to the PCI address in an rte_pci_device. This is incorrect and unsafe. Also, the rte_device using this PCI address is already found, no need to compare again the PCI

[dpdk-dev] [PATCH v1 1/2] bonding: fix port id validity check on parsing

2020-04-17 Thread Gaetan Rivet
If the port_id is equal to RTE_MAX_ETHPORTS, it should be considered invalid. Additionally, UNUSED ports are also not valid port ids to be used afterward. To simplify following the ethdev API rules, use the exposed function checking whether a port id is valid. Fixes: 2efb58cbab6e ("bond: new link

[dpdk-dev] [PATCH v1 0/2] bonding: fix port id check and PCI addr cmp

2020-04-17 Thread Gaetan Rivet
Found these two bugs while reading the bonding code. The first bug is mostly usability: if a user gives an incorrect port id as a slave, it will error-out later. The error will simply be less clear. I'm partially responsible for the second one. I don't see why we did not wrote it properly at the

[dpdk-dev] [PATCH v2 12/12] net/bnxt: remove redefinition of page size

2020-04-17 Thread Ajit Khaparde
PAGE_SIZE is a common macro and cause redefinition errors. Replace such occurances. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_tbl.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/bnxt/tf_core/tf_tbl.h b/drivers/net/bnxt/tf_c

[dpdk-dev] [PATCH v2 11/12] net/bnxt: add port database

2020-04-17 Thread Ajit Khaparde
From: Kishore Padmanabha The port database is a repository of the port details it is used by the ulp code to query any port related details. Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/Makefile

[dpdk-dev] [PATCH v2 09/12] net/bnxt: add default identifiers to ulp mapper

2020-04-17 Thread Ajit Khaparde
From: Mike Baucom - Added ulp_mapper_init/deinit to allocate/deallocate mapper data for storing the default identifiers - Modified the template_db to include the new opcode for accessing the default ids. - Modified the result and key field builders to use the new opcode for writing the defa

[dpdk-dev] [PATCH v2 10/12] net/bnxt: add cache table type for TCAM lookup

2020-04-17 Thread Ajit Khaparde
From: Mike Baucom In order to re-use allocated resources and reduce search complexity for simple keys, a generic software cache table was added for the TCAM. The implementation is specifically only for keys that can be compressed to less than 16 bits. The keys are generated using the same mechan

[dpdk-dev] [PATCH v2 08/12] net/bnxt: add session and function flow flush

2020-04-17 Thread Ajit Khaparde
From: Kishore Padmanabha The ulp flow flush has been extended to support session flow flush and function flow flush. The session flow flush is called when there the device is sole owner of the session and it deletes all the flows associated with that session. The function flow flush is called if

  1   2   3   >