Re: [dpdk-dev] [EXT] [PATCH] trace: fix build with gcc 10

From: Sunil Kumar Kori Sent: Tuesday, April 28, 2020 11:49 AM To: Phil Yang ; jer...@marvell.com; dev@dpdk.org Cc: David Marchand ; Ruifeng Wang ; Lijian Zhang ; nd Subject: [EXT] [PATCH] trace: fix build with gcc 10 Sent from Workspace ONE Boxer On 27-Apr-2020 10:18 PM, Phil Yang

Re: [dpdk-dev] [PATCH] trace: fix build with gcc 10

> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, April 28, 2020 12:59 AM > To: Phil Yang > Cc: jer...@marvell.com; sk...@marvell.com; dev@dpdk.org; > david.march...@redhat.com; Lijian Zhang ; > Ruifeng Wang ; nd > Subject: Re: [dpdk-dev] [PATCH] trace: fix build with gcc 1

Re: [dpdk-dev] [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter

Didn't address my comment in v1 patch. > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, April 28, 2020 1:48 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Xing, Beilei ; > maxime.le...@6wind.com; Zhao1, Wei > Subject: [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter

Re: [dpdk-dev] [PATCH] net/ice/base: workaround for unexpected rule deletion

On 04/24, Zhao1, Wei wrote: >It will be delete after fix in kernel to re-enable vf list feature. > >Reviewed-by: Wei Zhao > >> -Original Message- >> From: dev On Behalf Of Qi Zhang >> Sent: Thursday, April 23, 2020 12:22 PM >> To: Yang, Qiming >> Cc: Ye, Xiaolong ; Xing, Beilei >> ; >>

Re: [dpdk-dev] [dpdk-announce] release candidate 20.05-rc1

27/04/2020 01:40, Thomas Monjalon: > We have four small weeks to complete this release cycle. > DPDK 20.05-rc2 is expected on April 8th. I received some feedbacks that some of you don't have any time machine. That's unfortunate. We have to postpone -rc2 target date to May 8th to accomodate everyon

Re: [dpdk-dev] [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets

> -Original Message- > From: Zhao1, Wei > Sent: Tuesday, April 28, 2020 1:48 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Xing, Beilei ; > maxime.le...@6wind.com; Zhao1, Wei > Subject: [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets > > This patch can enable FDIR awith etherty

Re: [dpdk-dev] [PATCH] net/tap: fix crash from unitialized memory in rte_flow_destroy

On Mon, Apr 27, 2020 at 11:39 PM Stephen Hemminger wrote: > > The TAP driver does not initialize all the elements of the rte_flow > structure. This can lead to crash in rte_flow_destroy. > > (gdb) where > flow=0x100e99280, error=0x0) > at drivers/net/tap/tap_flow.c:1514 > > (gdb) p remote_

Re: [dpdk-dev] [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter

> -Original Message- > From: Xing, Beilei > Sent: Tuesday, April 28, 2020 3:16 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; maxime.le...@6wind.com > Subject: RE: [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter > > Didn't address my comment in v1 patch. Hi,

Re: [dpdk-dev] [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets

> -Original Message- > From: Xing, Beilei > Sent: Tuesday, April 28, 2020 3:38 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; maxime.le...@6wind.com > Subject: RE: [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets > > > > > -Original Message- > > From: Zhao1,

Re: [dpdk-dev] [PATCH] net/iavf: fix link speed

> -Original Message- > From: Zhang, AlvinX > Sent: Tuesday, April 28, 2020 2:49 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Zhang, AlvinX ; Wu, Jingjing > > Subject: [PATCH] net/iavf: fix link speed > > From: Alvin Zhang > > If the PF driver does not support the new s

Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

On Tue, Apr 28, 2020 at 3:29 AM Thinh Tran wrote: > > The AltiVec header file breaks boolean type: > > In file included from ../lib/librte_mempool/rte_mempool_trace_fp.h:18:0, > from ../lib/librte_mempool/rte_mempool.h:54, > from ../lib/librte_mbuf/rte_mbuf.h:38,

[dpdk-dev] [PATCH] eal/ppc: fix redefine bool type

The AltiVec header file breaks boolean type. [1] [2] Currently the workaround was located only in mlx5 device. Adding the trace module caused this issue to appear again, due to order of includes, it keeps overriding the local fix. This patch solves this issue by resetting the bool type, immediate

[dpdk-dev] [PATCH v3 2/3] doc: input set requirement of each pctype for FDIR

Add input set requirement info to i40e doc. Bugzilla ID: 403 Signed-off-by: Wei Zhao --- doc/guides/nics/i40e.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 416b3904e..ad5f51c38 100644 --- a/doc/guides/nics/i40e.rst +++ b/

[dpdk-dev] [PATCH v3 0/3] fix i40e bug for flow filter

fix i40e bug for flow filter and add comment in doc. v2: add more comment in git log. v3: update git log. Wei Zhao (3): net/i40e: fix FDIR issue for ARP packets doc: input set requirement of each pctype for FDIR net/i40e: remove teardown when flush FDIR filter doc/guides/nics/i40e.rst

[dpdk-dev] [PATCH v3 3/3] net/i40e: remove teardown when flush FDIR filter

When we flush FDIR filter, we can not call i40e_fdir_teardown() function as it will free vsi used for FDIR, then the vsi->base_queue will be freed from pf->qp_pool, but vsi->base_queue can only get once when do dev init in i40e_pf_setup(). If we free it, it will never be alloc again. Bugzilla ID:

[dpdk-dev] [PATCH v3 1/3] net/i40e: fix FDIR issue for ARP packets

Currently, flow "pattern eth type is 0x0806 / end actions mark id 0x86 / rss / end" can't be created successfully. FDIR parser shouldn't deny RTE_ETHER_TYPE_ARP since ARP packets will be parsed as PCTYPE_L2_PAYLOAD. This patch fixes the issue. Bugzilla ID: 402 Fixes: 42044b69c67d ("net/i40e: suppo

Re: [dpdk-dev] [PATCH] net/mlx5: save meter index instead of meter id

> -Original Message- > From: Suanming Mou > Sent: Sunday, April 26, 2020 5:51 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: save meter index instead of meter id > > Currently, while creating the flow with meter, m

Re: [dpdk-dev] [PATCH 7/7] bus/pci: support Windows with bifurcated drivers

> Subject: Re: [dpdk-dev] [PATCH 7/7] bus/pci: support Windows with > bifurcated drivers > > On Wed, Apr 22, 2020 at 10:27:47AM +0300, tal...@mellanox.com wrote: > > From: Tal Shnaiderman > > > > Uses SetupAPI.h functions to scan PCI tree. > > Uses DEVPKEY_Device_Numa_Node to get the PCI Numa nod

Re: [dpdk-dev] [PATCH 1/5] app/test-flow-perf: add flow performance skeleton

Thanks Jack, Jerin, Can you please review it according to our discussion in the RFC? >-Original Message- >From: Jack Min >Sent: Friday, April 17, 2020 5:06 AM >To: Wisam Monther >Cc: dev@dpdk.org; jerinjac...@gmail.com; Thomas Monjalon > >Subject: Re: [dpdk-dev] [PATCH 1/5] app/test-flo

Re: [dpdk-dev] [PATCH 3/5] app/test-flow-perf: add deletion rate calculation

Thanks Jack, Jerin, Can you please review it according to our discussion in the RFC? >-Original Message- >From: Jack Min >Sent: Friday, April 17, 2020 5:08 AM >To: Wisam Monther >Cc: dev@dpdk.org; jerinjac...@gmail.com; Thomas Monjalon > >Subject: Re: [PATCH 3/5] app/test-flow-perf: add

Re: [dpdk-dev] [PATCH 2/5] app/test-flow-perf: add insertion rate calculation

Thanks Jack, Jerin, Can you please review it according to our discussion in the RFC? >-Original Message- >From: Jack Min >Sent: Friday, April 17, 2020 5:07 AM >To: Wisam Monther >Cc: dev@dpdk.org; jerinjac...@gmail.com; Thomas Monjalon > >Subject: Re: [PATCH 2/5] app/test-flow-perf: add

Re: [dpdk-dev] [PATCH 4/5] app/test-flow-perf: add memory dump to app

Thanks Jack, Jerin, Can you please review it according to our discussion in the RFC? >-Original Message- >From: Jack Min >Sent: Friday, April 17, 2020 5:09 AM >To: Wisam Monther >Cc: dev@dpdk.org; jerinjac...@gmail.com; Thomas Monjalon >; Suanming Mou >Subject: Re: [PATCH 4/5] app/test

Re: [dpdk-dev] [PATCH 5/5] app/test-flow-perf: add packet forwarding support

Thanks Jack, Jerin, Can you please review it according to our discussion in the RFC? >-Original Message- >From: Jack Min >Sent: Friday, April 17, 2020 5:09 AM >To: Wisam Monther >Cc: dev@dpdk.org; jerinjac...@gmail.com; Thomas Monjalon > >Subject: Re: [PATCH 5/5] app/test-flow-perf: add

[dpdk-dev] [PATCH v11 0/9] add packed ring vectorized path

This patch set introduced vectorized path for packed ring. The size of packed ring descriptor is 16Bytes. Four batched descriptors are just placed into one cacheline. AVX512 instructions can well handle this kind of data. Packed ring TX path can fully transformed into vectorized path. Packed ring

[dpdk-dev] [PATCH v11 1/9] net/virtio: add Rx free threshold setting

Introduce free threshold setting in Rx queue, its default value is 32. Limit the threshold size to multiple of four as only vectorized packed Rx function will utilize it. Virtio driver will rearm Rx queue when more than rx_free_thresh descs were dequeued. Signed-off-by: Marvin Liu Reviewed-by: Ma

[dpdk-dev] [PATCH v11 2/9] net/virtio: inorder should depend on feature bit

Ring initialization is different when inorder feature negotiated. This action should dependent on negotiated feature bits. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 94ba7a3ec..e450477e8 100644 --

[dpdk-dev] [PATCH v11 4/9] net/virtio-user: add vectorized devarg

Add new devarg for virtio user device vectorized path selection. By default vectorized path is disabled. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index a67774e91..fdd0790e0 100644 --- a/doc/guides/nics/virtio.rst

[dpdk-dev] [PATCH v11 3/9] net/virtio: add vectorized devarg

Previously, virtio split ring vectorized path was enabled by default. This is not suitable for everyone because that path dose not follow virtio spec. Add new devarg for virtio vectorized path selection. By default vectorized path is disabled. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coqueli

[dpdk-dev] [PATCH v11 6/9] net/virtio: add vectorized packed ring Rx path

Optimize packed ring Rx path with SIMD instructions. Solution of optimization is pretty like vhost, is that split path into batch and single functions. Batch function is further optimized by AVX512 instructions. Also pad desc extra structure to 16 bytes aligned, thus four elements will be saved in

[dpdk-dev] [PATCH v11 8/9] net/virtio: add election for vectorized path

Rewrite vectorized path selection logic. Default setting comes from vectorized devarg, then checks each criteria. Packed ring vectorized path need: AVX512F and required extensions are supported by compiler and host VERSION_1 and IN_ORDER features are negotiated mergeable feature is not

[dpdk-dev] [PATCH v11 5/9] net/virtio: reuse packed ring functions

Move offload, xmit cleanup and packed xmit enqueue function to header file. These functions will be reused by packed ring vectorized path. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 84f4cf946..a54

[dpdk-dev] [PATCH v11 7/9] net/virtio: add vectorized packed ring Tx path

Optimize packed ring Tx path like Rx path. Split Tx path into batch and single Tx functions. Batch function is further optimized by AVX512 instructions. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h i

[dpdk-dev] [PATCH v11 9/9] doc: add packed vectorized path

Document packed virtqueue vectorized path selection logic in virtio net PMD. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index fdd0790e0..226f4308d 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virti

Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx/Tx stats after clear stats command

Hi, Ferrh Yigit On 2020/4/27 22:00, Ferruh Yigit wrote: On 4/26/2020 10:22 AM, Wei Hu (Xavier) wrote: Hi, Ferruh Yigit On 2020/4/25 0:12, Ferruh Yigit wrote: On 4/24/2020 12:07 PM, Wei Hu (Xavier) wrote: From: Chengwen Feng Currently, when running start/clear stats&xstats/stop command many

Re: [dpdk-dev] [PATCH] net/iavf: fix link speed

Thanks Beilei. > -Original Message- > From: Xing, Beilei > Sent: Tuesday, April 28, 2020 3:50 PM > To: Zhang, AlvinX ; dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing > Subject: RE: [PATCH] net/iavf: fix link speed > > > > > -Original Message- > > From: Zhang, AlvinX > > Sent: T

Re: [dpdk-dev] [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path

On 4/28/20 3:14 AM, Liu, Yong wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, April 27, 2020 7:21 PM >> To: Liu, Yong ; Ye, Xiaolong ; >> Wang, Zhihong >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path >> >>

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

On Sun, Apr 26, 2020 at 10:06 PM Thomas Monjalon wrote: > > 26/04/2020 20:41, Jerin Jacob: > > On Sun, Apr 26, 2020 at 11:38 PM Thomas Monjalon > > wrote: > > > > > > 26/04/2020 19:38, jer...@marvell.com: > > > > From: Jerin Jacob > > > > > > > > If the PCI device is not attached to any driver

Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

On Tue, Apr 28, 2020 at 9:58 AM Jerin Jacob wrote: > > On Tue, Apr 28, 2020 at 3:29 AM Thinh Tran wrote: > > > > The AltiVec header file breaks boolean type: > > > > In file included from ../lib/librte_mempool/rte_mempool_trace_fp.h:18:0, > > from ../lib/librte_mempool/rte_mempoo

[dpdk-dev] [PATCH v2] net/iavf: fix link speed

From: Alvin Zhang If the PF driver does not support the new speed reporting capabilities then use link_event else use link_event_adv to get the speed. Fixes: 48de41ca11f0 (net/iavf: enable link status update) Cc: jingjing...@intel.com Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers

[dpdk-dev] [PATCH v2] net/iavf: fix link speed

From: Alvin Zhang If the PF driver does not support the new speed reporting capabilities then use link_event else use link_event_adv to get the speed. Fixes: 48de41ca11f0 (net/iavf: enable link status update) Cc: jingjing...@intel.com Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang V2: Modify

[dpdk-dev] [PATCH] net/mlx5: fix indexed pool bitmap initialization

Currently, the indexed memory pool bitmap start address is not aligned to cacheline size explicitly. The bitmap initialization requires the address should be cacheline aligned. In that case, the initialization maybe failed if the address is not cacheline aligned. Add RTE_CACHE_LINE_ROUNDUP() to th

[dpdk-dev] [PATCH v3 1/2] vhost: utilize dpdk dynamic memory allocator

Replace dynamic memory allocator with dpdk memory allocator. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index bd1be0104..79fcb9d19 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -191,7 +191,7 @@ vhost_ba

[dpdk-dev] [PATCH v2 1/7] eal: move OS common functions to single file

From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_config.c. Those simple functions are getter functions for IOVA, configuration, Multi-process. Move rte_config and runtime_dir to be defined in a common file. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/c

[dpdk-dev] [PATCH v3 2/2] vhost: binary search address mapping table

If Tx zero copy enabled, gpa to hpa mapping table is updated one by one. This will harm performance when guest memory backend using 2M hugepages. Now utilize binary search to find the entry in mapping table, meanwhile set threshold to 256 entries for linear search. Signed-off-by: Marvin Liu diff

[dpdk-dev] [PATCH v2 5/7] drivers: fix incorrect meson import folder for Windows

From: Tal Shnaiderman import library (/IMPLIB) in meson.build should use the 'drivers' and not 'libs' folder. The error is: fatal error LNK1149: output filename matches input filename. The fix uses the correct folder. Fixes: 5ed3766981 ("drivers: process shared link dependencies as for libs")

[dpdk-dev] [PATCH v2 3/7] eal: add function finding integer in a string

From: Tal Shnaiderman Addition of a function to skip leading chars which are not part of the numeric base and return the number in the needed base. This is needed to call strtoul correctly and will be used by bus/PCI to get the BDF from a PCI output. Signed-off-by: Tal Shnaiderman --- lib/lib

[dpdk-dev] [PATCH v2 6/7] bus/pci: introduce Windows support with stubs

From: Tal Shnaiderman Addition of stub eal and bus/pci functions to compile bus/pci for Windows. Signed-off-by: Tal Shnaiderman --- drivers/baseband/meson.build | 4 + drivers/bus/ifpga/meson.build | 6 ++ drivers/bus/pci/meson.build| 14 ++- drivers/bus/pci/pci_common.

[dpdk-dev] [PATCH v2 0/7] Windows bus/pci support

From: Tal Shnaiderman This patchset implements the EAL and PCI functions needed for probing PMDs using RTE_KDRV_NONE on Windows. Depends-on: series-9374 ("Windows basic memory management") v2: * fix style issues. * fix error handing flow in pci.c * change eal_config.c t

[dpdk-dev] [PATCH v2 2/7] pci: build on Windows

From: Tal Shnaiderman Changing all of PCIs Unix memory mapping to the new memory allocation API wrapper. Added off_t in Windows header file as a supported type since it is needed by PCI. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/windows/include/rte_os.h | 1 + lib/librte_pci/rte_pci.

[dpdk-dev] [PATCH v2 4/7] drivers: ignore pmdinfogen generation for Windows

From: Tal Shnaiderman pmdinfogen generation is currently unsupported for Windows. The relevant part in meson.build is skipped. Signed-off-by: Tal Shnaiderman --- drivers/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/meson.build b/drivers/meson.build

[dpdk-dev] [PATCH v2 7/7] bus/pci: support Windows with bifurcated drivers

From: Tal Shnaiderman Uses SetupAPI.h functions to scan PCI tree. Uses DEVPKEY_Device_Numa_Node to get the PCI Numa node. scanning currently supports types RTE_KDRV_NONE. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/windows/pci.c| 342 ++- lib/libr

[dpdk-dev] [Bug 465] app/test compile failed with gcc and clang

https://bugs.dpdk.org/show_bug.cgi?id=465 Bug ID: 465 Summary: app/test compile failed with gcc and clang Product: DPDK Version: 20.05 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH 09/14] eal: close mem config on cleanup

On 27-Apr-20 6:00 PM, Stephen Hemminger wrote: On Mon, 27 Apr 2020 13:12:32 +0100 "Burakov, Anatoly" wrote: On 04-Jan-20 1:33 AM, Stephen Hemminger wrote: Resolves file descriptor left open after rte_eal_cleanup. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal/eal.c | 6 +++

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value

27/04/2020 16:00, David Marchand: > On Mon, Apr 27, 2020 at 3:47 PM Ananyev, Konstantin wrote: > > From: dev On Behalf Of David Marchand > > > On Mon, Apr 27, 2020 at 3:34 PM Bruce Richardson > > > wrote: > > > > On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote: > > > > > Building O

Re: [dpdk-dev] [PATCH] common/mlx5: reduce size of netlink buffer

> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Thursday, April 23, 2020 1:30 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Nélio Laranjeiro > > Subject: [dpdk-dev] [PATCH] common/mlx5: reduce size of netlink buffer > > Since the driver is just using netlink to rec

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

On Tue, Apr 28, 2020 at 2:21 PM David Marchand wrote: > > On Sun, Apr 26, 2020 at 10:06 PM Thomas Monjalon wrote: > > > > 26/04/2020 20:41, Jerin Jacob: > > > On Sun, Apr 26, 2020 at 11:38 PM Thomas Monjalon > > > wrote: > > > > > > > > 26/04/2020 19:38, jer...@marvell.com: > > > > > From: Jeri

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix uninitialized variable warning

> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Thursday, April 23, 2020 1:32 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Matan Azrad > > Subject: [dpdk-dev] [PATCH v2] common/mlx5: fix uninitialized variable > warning > > Gcc 8.3.0 (Debian 10) complains about un

[dpdk-dev] [PATCH v1] vhost: fix mbuf allocation failures

vhost buffer allocation is successful for packets that fit into a linear buffer. If it fails, vhost library is expected to drop the current buffer descriptor and skip to the next. The patch fixes the error scenario by skipping to next descriptor. Note: Drop counters are not currently supported. S

Re: [dpdk-dev] [PATCH 0/3] 20.05-rc1 fixes for OVS

On Mon, Apr 27, 2020 at 3:24 PM David Marchand wrote: > > Couple of fixes caught while checking OVS integration. > > David Marchand (3): > ring: fix build with -Wswitch-enum > eal: fix typo in endian conversion macros > ethdev: fix build warning on 64-bit value > > lib/librte_eal/include/ge

Re: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD

Tested-by: Huang, ZhiminX Regards, HuangZhiMin -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of zhihongx.p...@intel.com Sent: Friday, April 17, 2020 11:52 AM To: Ye, Xiaolong ; Lu, Wenzhuo ; Ananyev, Konstantin Cc: dev@dpdk.org; Peng, ZhihongX ; Wang, Liang-min

Re: [dpdk-dev] [PATCH v3 4/4] cfgfile: check flags value

On Mon, Apr 27, 2020 at 04:16:25PM -0700, Stephen Hemminger wrote: > All API's should check that they support the flag values > passed. If an application passes an invalid flag it could > cause problems in later ABI. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v3 0/4] Enforce checking on flag values in API's

On Mon, Apr 27, 2020 at 04:16:21PM -0700, Stephen Hemminger wrote: > The DPDK API's are lax about checking for undefined flag values. > This makes it impossible to add new bits to existing API's > without causing ABI breakage. This means we end up doing unnecessary > symbol versioning just to work

Re: [dpdk-dev] [EXT] [PATCH] trace: fix build with gcc 10

>-Original Message- >From: Phil Yang >Sent: Tuesday, April 28, 2020 12:30 PM >To: Sunil Kumar Kori ; Jerin Jacob Kollanukkaran >; dev@dpdk.org >Cc: David Marchand ; Ruifeng Wang >; Lijian Zhang ; nd >; nd >Subject: RE: [EXT] [PATCH] trace: fix build with gcc 10 > >From: Sunil Kumar Kori

Re: [dpdk-dev] [PATCH v3 0/4] Enforce checking on flag values in API's

> The DPDK API's are lax about checking for undefined flag values. > This makes it impossible to add new bits to existing API's > without causing ABI breakage. This means we end up doing unnecessary > symbol versioning just to work around applications that might > pass in naughty bits. > > This is

Re: [dpdk-dev] [PATCH v2 2/2] l3fwd-power: implement proper shutdown handling

Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov Sent: Tuesday, April 21, 2020 1:57 AM To: dev@dpdk.org Cc: Hunt, David ; Pattan, Reshma Subject: [dpdk-dev] [PATCH v2 2/2] l3fwd-power: imp

Re: [dpdk-dev] [PATCH v2 1/2] l3fwd-power: exit if initializing power library failed

Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov Sent: Tuesday, April 21, 2020 1:57 AM To: dev@dpdk.org Cc: Hunt, David ; Pattan, Reshma Subject: [dpdk-dev] [PATCH v2 1/2] l3fwd-power: exi

[dpdk-dev] [PATCH V2] app/testpmd: fix forward stats after clear stats command

From: "Wei Hu (Xavier)" Currently, when running start/clear stats&xstats/stop command many times based on testpmd application, there are incorrect forward Rx/Tx-packets stats as below: -- Forward statistics for port 0 -- RX-packets: 18446744073709544808 RX-dropped

[dpdk-dev] [PATCH V3] app/testpmd: fix forward stats after clear stats command

From: "Wei Hu (Xavier)" Currently, when running start/clear stats&xstats/stop command many times based on testpmd application, there are incorrect forward Rx/Tx-packets stats as below: -- Forward statistics for port 0 -- RX-packets: 18446744073709544808 RX-dropped

Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

On Mon, Apr 27, 2020 at 10:29:48PM +0530, Jerin Jacob wrote: > External Email > > -- > On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit wrote: > > > > On 4/27/2020 5:29 PM, Jerin Jacob wrote: > > > On Mon, Apr 27, 2020 at 9:42 PM Fe

Re: [dpdk-dev] [PATCH v2 1/2] spinlock: use wfe to reduce contention on aarch64

On Sun, Apr 26, 2020 at 2:09 PM Gavin Hu wrote: > > In acquiring a spinlock, cores repeatedly poll the lock variable. > This is replaced by rte_wait_until_equal API. > > Running the micro benchmarking and the testpmd and l3fwd traffic tests > on ThunderX2, Ampere eMAG80 and Arm N1SDP, everything w

[dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

This patch adds CPU flags which will enable the detection of ISA features available on more recent x86 based CPUs. The CPUID leaf information can be found in Table 1-2. "Information Returned by CPUID Instruction" of this document: https://software.intel.com/sites/default/files/managed/c5/15/archit

[dpdk-dev] [PATCH v2 1/4] event/octeontx: add multi segment support to eventdev

Adding support for multi segment to the eventdev PMD. Signed-off-by: Harman Kalra --- drivers/event/octeontx/ssovf_evdev.c | 33 +++--- drivers/event/octeontx/ssovf_evdev.h | 13 drivers/event/octeontx/ssovf_worker.c | 90 --- drivers/event/octeontx/ssovf_worke

[dpdk-dev] [PATCH v2 0/4] event/octeontx: support new features

Since event-octeontx PMD and net-octeontx PMD works very tightly, so this patchset implements the event-octeontx side changes to support new features added to net-octeontx PMD. v2: * replace __hot with __rte_hot Harman Kalra (3): event/octeontx: add multi segment support to eventdev event/oct

[dpdk-dev] [PATCH v2 3/4] event/octeontx: add VLAN filter offload support

From: Vamsi Attunuru Adding rx burst function pointer hooks for vlan filter offload in event PMD. Signed-off-by: Vamsi Attunuru --- drivers/event/octeontx/ssovf_worker.c | 38 +++ drivers/event/octeontx/ssovf_worker.h | 9 +++ drivers/net/octeontx/octeontx_rxtx.h

[dpdk-dev] [PATCH v2 2/4] event/octeontx: add framework for Rx/Tx offloads

Adding macro based framework to hook dequeue/enqueue function pointers to the appropriate function based on rx/tx offloads. Signed-off-by: Harman Kalra --- drivers/event/octeontx/ssovf_evdev.c | 36 drivers/event/octeontx/ssovf_evdev.h | 24 +-- drivers/event/octeontx/ssovf_worker.c | 2

[dpdk-dev] [PATCH v2 4/4] event/octeontx: support Rx Tx checksum offload

Adding support for rx checksum offload. In case of wrong checksum received (inner/outer l3/l4) it reports the corresponding layer which has bad checksum. It also adds rx burst function pointer hook for rx checksum offload to event PMD. Signed-off-by: Harman Kalra --- drivers/event/octeontx/ssovf

Re: [dpdk-dev] [PATCH v3 1/2] vhost: utilize dpdk dynamic memory allocator

On 4/28/20 11:13 AM, Marvin Liu wrote: > Replace dynamic memory allocator with dpdk memory allocator. > > Signed-off-by: Marvin Liu > Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [dpdk-dev] [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path

> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, April 28, 2020 4:44 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path > > > > On 4/28/20 3:14 AM, Liu, Yong wrote: > > > >

Re: [dpdk-dev] [PATCH dpdk-dev v3 2/2] mempool: use shared memzone for rte_mempool_ops

On Mon, Apr 27, 2020 at 8:51 PM Tonghao Zhang wrote: > > On Mon, Apr 27, 2020 at 7:40 PM Thomas Monjalon wrote: > > > > 27/04/2020 10:03, Tonghao Zhang: > > > On Fri, Apr 17, 2020 at 6:27 AM Thomas Monjalon > > > wrote: > > > > > > > > 13/04/2020 16:21, xiangxia.m@gmail.com: > > > > > The o

[dpdk-dev] [PATCH] examples: add flush after stats printing

From: Georgiy Levashov When printf()'s stdout is line-buffered for terminal, it is fully buffered for pipes. So, stdout listener can only get the output when it is flushed (on program termination, when buffer is filled or manual flush). stdout buffer might fill slowly since every stats report co

Re: [dpdk-dev] [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

Thomas Monjalon writes: > 27/04/2020 14:58, Aaron Conole: >> Ferruh Yigit writes: >> > [1] Two issues reported >> > a) ninja: build stopped: Error writing to build log: Disk quota >> > exceeded. >> >> This occurs on some of the ARM64 builds. Travis is aware of the issue, >> but don't seem urge

[dpdk-dev] [PATCH 2/3] net/sfc/base: use simpler EF10 family run-time checks

Fixes: 4625c4f5277d ("net/sfc/base: factor out upstream port vAdaptor allocation") Fixes: 4f12e20c85dc ("net/sfc/base: introduce EVB module for SR-IOV") Fixes: 18c8e84d7726 ("net/sfc/base: support proxy auth operations for SR-IOV") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers

[dpdk-dev] [PATCH 3/3] net/sfc/base: fix build when EVB is enabled

Make local MCDI helper functions static. Fixes: f0bda0cd680d ("net/sfc/base: add MCDI wrappers for vPort and vSwitch in EVB") Fixes: ea94d14dbea0 ("net/sfc/base: provide APIs to configure and reset vPort") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_evb.c

[dpdk-dev] [PATCH 1/3] net/sfc/base: use simpler EF10 family conditional code check

Fixes: 4f12e20c85dc ("net/sfc/base: introduce EVB module for SR-IOV") Fixes: 18c8e84d7726 ("net/sfc/base: support proxy auth operations for SR-IOV") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_evb.c | 4 ++-- drivers/net/sfc/base/efx_evb.c | 4 ++-- drive

Re: [dpdk-dev] [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path

On 4/28/20 3:01 PM, Liu, Yong wrote: >>> Maxime, >>> Thanks for point it out, it will add extra cache miss in datapath. >>> And its impact on performance is around 1% in loopback case. >> Ok, thanks for doing the test. I'll try to run some PVP benchmarks >> on my side because when doing IO loopb

Re: [dpdk-dev] [EXT] [PATCH] trace: fix build with gcc 10

> -Original Message- > From: Sunil Kumar Kori > Sent: Tuesday, April 28, 2020 6:52 PM > To: Phil Yang ; jer...@marvell.com; dev@dpdk.org > Cc: David Marchand ; Ruifeng Wang > ; Lijian Zhang ; nd > ; nd > Subject: RE: [EXT] [PATCH] trace: fix build with gcc 10 > > >> > >Hello, there is

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/1] bus/pci: optimise scanning with whitelist/blacklist

>-Original Message- >From: Gaëtan Rivet >Sent: Tuesday, April 28, 2020 12:14 AM >To: Sunil Kumar Kori >Cc: step...@networkplumber.org; david.march...@redhat.com; Jerin Jacob >Kollanukkaran ; dev@dpdk.org >Subject: [EXT] Re: [dpdk-dev] [PATCH v3 1/1] bus/pci: optimise scanning with >whitel

[dpdk-dev] [RFC] ring: count and empty optimizations

Olivier (maintainer of the Ring), I would like to suggest a couple of minor optimizations to the ring library. 1. Testing if the ring is empty is as simple as comparing the producer and consumer pointers: static inline int rte_ring_empty(const struct rte_ring *r) { - return rte_ring_coun

Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

On 4/28/2020 12:51 PM, Nithin Dabilpuram wrote: > On Mon, Apr 27, 2020 at 10:29:48PM +0530, Jerin Jacob wrote: >> External Email >> >> -- >> On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit wrote: >>> >>> On 4/27/2020 5:29 PM, Jerin

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

On 4/27/2020 5:59 PM, Jerin Jacob wrote: > On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit wrote: >> >> On 4/27/2020 5:29 PM, Jerin Jacob wrote: >>> On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit wrote: On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: > > >> -Original Mess

Re: [dpdk-dev] [PATCH 5/5] app/test-flow-perf: add packet forwarding support

On Thu, Apr 9, 2020 at 6:44 PM Wisam Jaddo wrote: > > Introduce packet forwarding support to the app to do > some performance measurements. > > The measurements are reported in term of packet per > second unit. The forwarding will start after the end > of insertion/deletion operations. > > The sup

[dpdk-dev] [PATCH v2] trace: fix build with gcc 10

Prevent from writing beyond the allocated memory. GCC 10 compiling output: eal_common_trace_utils.c: In function 'eal_trace_dir_args_save': eal_common_trace_utils.c:290:24: error: '__builtin___sprintf_chk' \ may write a terminating nul past the end of the destination \ [-Werror=f

Re: [dpdk-dev] [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path

> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, April 28, 2020 9:46 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; jer...@marvell.com > Subject: Re: [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path > > > >

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

On Tue, Apr 28, 2020 at 03:06:20PM +0100, Ferruh Yigit wrote: > On 4/27/2020 5:59 PM, Jerin Jacob wrote: > > On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit > > wrote: > >> > >> On 4/27/2020 5:29 PM, Jerin Jacob wrote: > >>> On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit > >>> wrote: > >

Re: [dpdk-dev] [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path

On 4/28/20 4:43 PM, Liu, Yong wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, April 28, 2020 9:46 PM >> To: Liu, Yong ; Ye, Xiaolong ; >> Wang, Zhihong >> Cc: dev@dpdk.org; Honnappa Nagarahalli >> ; jer...@marvell.com >> Subject: Re: [PATCH v10 6/9] net/vi

Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

Agreed, this is not rte_trace issue. Moving to rte_common.h does not work neither, because altivec.h is included after and redefine bool This conflict happens on PPC64, I'll create a different patch. Thanks, Thinh Tran On 4/28/2020 2:57 AM, Jerin Jacob wrote: On Tue, Apr 28, 2020 at 3:29 AM Th

Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

On Tue, Apr 28, 2020 at 5:02 PM Thinh Tran wrote: > > Agreed, this is not rte_trace issue. Moving to rte_common.h does not > work neither, because altivec.h is included after and redefine bool > This conflict happens on PPC64, I'll create a different patch. Please look at Ori patch. Thanks. http

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

On Tue, 2020-04-28 at 15:45 +0100, Bruce Richardson wrote: > On Tue, Apr 28, 2020 at 03:06:20PM +0100, Ferruh Yigit wrote: > > On 4/27/2020 5:59 PM, Jerin Jacob wrote: > > > On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit > > > wrote: > > > > On 4/27/2020 5:29 PM, Jerin Jacob wrote: > > > > > On Mo

Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

I looked at it, but I have a simpler patch below that can resolve the conflict, including after removing previous patches in mlx4/mlx5 Thanks, Thinh Tran diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h b/lib/librte_eal/ppc/include/rte_memcpy.h index 25311ba1d..abeede231 100644 --- a/lib

Re: [dpdk-dev] [PATCH v3 2/2] vhost: binary search address mapping table

On 4/28/20 11:13 AM, Marvin Liu wrote: > If Tx zero copy enabled, gpa to hpa mapping table is updated one by > one. This will harm performance when guest memory backend using 2M > hugepages. Now utilize binary search to find the entry in mapping > table, meanwhile set threshold to 256 entries fo

  1   2   >