Re: [dpdk-dev] [PATCH 2/2] eal: add fnmatch implementation on Windows

2020-04-29 Thread Thomas Monjalon
30/04/2020 01:24, Pallavi Kadam: > Added fnmatch implementation on Windows to support > log level arguments. > The source file is with BSD-3-Clause license. > https://github.com/lattera/freebsd/blob/master/usr.bin/csup/fnmatch.c Sorry for the naive question, I don't know Windows programming. Do w

Re: [dpdk-dev] [PATCH] net/ice: fix core dumped issue in switch filter

2020-04-29 Thread Yang, Qiming
Hi, I don't understand your fix log, which pointer is NULL? Qiming > -Original Message- > From: Jiang, JunyuX > Sent: Wednesday, April 29, 2020 15:25 > To: dev@dpdk.org > Cc: Yang, Qiming ; Jiang, JunyuX > ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix core dumped issue in switch fil

Re: [dpdk-dev] [PATCH 0/2] Windows logging

2020-04-29 Thread Thomas Monjalon
30/04/2020 01:24, Pallavi Kadam: > This patchset adds EAL logging support on Windows. > Logs will be sent to console output. > > Pallavi Kadam (2): > eal: initialize eal logging on Windows > eal: add fnmatch implementation on Windows fnmatch is required to change the log level of logs specifi

[dpdk-dev] [PATCH] net/igc: remove some useless log

2020-04-29 Thread alvinx . zhang
From: Alvin Zhang As title. Fixes: 746664d546fb (net/igc: implement flow API) Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_txrx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c index 5b26

Re: [dpdk-dev] [PATCH] net/iavf: fix VF reset issue for FDIR rule

2020-04-29 Thread Peng, Yuan
Test-by Peng, Yuan -Original Message- From: dev On Behalf Of Simei Su Sent: Tuesday, April 28, 2020 1:49 PM To: Zhang, Qi Z ; Ye, Xiaolong ; Wu, Jingjing Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei Subject: [dpdk-dev] [PATCH] net/iavf: fix VF reset issue for FDIR rule After VF reset, F

Re: [dpdk-dev] [PATCH v3] net/iavf: fix link speed

2020-04-29 Thread Xing, Beilei
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, April 30, 2020 11:21 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Zhang, AlvinX ; Wu, Jingjing > ; sta...@dpdk.org > Subject: [PATCH v3] net/iavf: fix link speed > > From: Alvin Zhang > > If the PF driver does

[dpdk-dev] [PATCH v1 1/2] devtools: add internal ABI version check

2020-04-29 Thread Haiyue Wang
INTERNAL is new introduced version, update the shell script that checks whether built libraries are versioned with expected ABI (current ABI, current ABI + 1, EXPERIMENTAL, or INTERNAL). Signed-off-by: Haiyue Wang --- devtools/check-abi-version.sh | 8 1 file changed, 4 insertions(+), 4

[dpdk-dev] [PATCH v1 2/2] devtools: updating internal symbols ABI version

2020-04-29 Thread Haiyue Wang
INTERNAL is new introduced version, update the script that automatically leaving internal section exactly as it is. Signed-off-by: Haiyue Wang --- devtools/update_version_map_abi.py | 37 +++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/devtools/updat

Re: [dpdk-dev] eal: can not run secondary process on openstack environment

2020-04-29 Thread 陈亚辉-云杉研发部
Deleting xdg_runtime_dir and fallback, runtime_dir will always be "/var/run" defined by code: static const char *default_runtime_dir = "/var/run" Here is my patch: # diff -ruN ~/dpdk-18.11.6/lib/librte_eal/linuxapp/eal/eal_orig.c eal.c --- ~/dpdk-18.11.6/lib/librte_eal/linuxapp/eal/eal_orig.c

[dpdk-dev] [PATCH v3] net/iavf: fix link speed

2020-04-29 Thread alvinx . zhang
From: Alvin Zhang If the PF driver does not support the new speed reporting capabilities then use link_event instead of link_event_adv to get the speed. Fixes: 48de41ca11f0 (net/iavf: enable link status update) Cc: jingjing...@intel.com Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang V2: Modif

Re: [dpdk-dev] [PATCH] eal: fix lcore state bug

2020-04-29 Thread Phil Yang
> -Original Message- > From: Lukasz Wojciechowski > Sent: Thursday, April 30, 2020 5:32 AM > To: Phil Yang ; Harry van Haaren > ; Jerin Jacob > > Cc: dev@dpdk.org; sta...@dpdk.org; nd > Subject: Re: [dpdk-dev] [PATCH] eal: fix lcore state bug > > Hi Phil, > > W dniu 29.04.2020 o 17:07,

Re: [dpdk-dev] [PATCH] net/ice/base: fix bm mask set and find switch recipe method

2020-04-29 Thread Zhang, Qi Z
> -Original Message- > From: Fu, Qi > Sent: Wednesday, April 29, 2020 6:16 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhang, Qi Z > Subject: RE: [PATCH] net/ice/base: fix bm mask set and find switch recipe > method > > Tested-by: Fu, Qi > > > -Original Message- > > From: Zhao1

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-04-29 Thread Honnappa Nagarahalli
Hi Konstantin, I like the way the tests are organized and it looks good. I am just wondering about the way it is being tested here. The intent to write the test cases the way they are currently is to mimic how the APIs would be used mostly. IMO, the APIs would be used with a constant val

[dpdk-dev] [PATCH] test/ring: fix long compilation time

2020-04-29 Thread Honnappa Nagarahalli
test_ring.c takes lot of time to compile with clang. It is reproducable with compiler version 8.0 on Ubuntu 18.04. Amount of testing is reduced, but attempt is made to keep the same coverage. Reported-by: Aaron Conole Reported-by: Thomas Monjalon Signed-off-by: Honnappa Nagarahalli Reviewed-by:

Re: [dpdk-dev] [PATCH] examples/vhost_blk: refactor vhost-blk example

2020-04-29 Thread Yu, Jin
Got it. I will check and fix it. Thanks. > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, April 30, 2020 1:54 AM > To: Yu, Jin ; Maxime Coquelin > ; Tiwei Bie ; Wang, > Zhihong ; Mcnamara, John > ; Kovacevic, Marko > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] exampl

Re: [dpdk-dev] [RFC] ring: count and empty optimizations

2020-04-29 Thread Honnappa Nagarahalli
> > Hi Morten, > > On Tue, Apr 28, 2020 at 03:53:15PM +0200, Morten Brørup wrote: > > Olivier (maintainer of the Ring), > > I'm not anymore, CC'ing Konstantin and Honnappa. > > > I would like to suggest a couple of minor optimizations to the ring library. > > > > > > 1. Testing if the ring is

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 2/3] doc: input set requirement of each pctype for FDIR

2020-04-29 Thread Zhao1, Wei
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, April 29, 2020 6:35 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Xing, Beilei ; > maxime.le...@6wind.com > Subject: Re: [dpdk-stable] [PATCH v4 2/3] doc: input set requirement of each > pctype for FDIR > > O

[dpdk-dev] [PATCH 2/2] vfio: modify spapr iommu support to use static window sizing

2020-04-29 Thread David Christensen
Current SPAPR IOMMU support code dynamically modifies the DMA window size in response to every new memory allocation. This is potentially dangerous because all existing mappings need to be unmapped/remapped in order to resize the DMA window, leaving hardware holding IOVA addresses that are not prop

[dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-04-29 Thread David Christensen
Enclose ppc64 specific SPAPR VFIO support with ifdef's. Signed-off-by: David Christensen --- lib/librte_eal/linux/eal_vfio.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linux/eal_vfio.c b/lib/librte_eal/linux/eal_vfio.c index d26e1649a..953397984 10

[dpdk-dev] [PATCH 0/2] vfio: change spapr DMA window sizing operation

2020-04-29 Thread David Christensen
The SPAPR v2 IOMMU used on bare-metal PowerNV systems requires that a DMA window be defined before mapping/unmapping memory. The current VFIO code dynamically resizes this DMA window every time a new memory request is made, which requires that all existing memory be unmapped/remapped. While this

[dpdk-dev] [PATCH 2/2] eal: add fnmatch implementation on Windows

2020-04-29 Thread Pallavi Kadam
Added fnmatch implementation on Windows to support log level arguments. The source file is with BSD-3-Clause license. https://github.com/lattera/freebsd/blob/master/usr.bin/csup/fnmatch.c Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Tasnim Bashar Tested-by: Dmitry Kozlyuk

[dpdk-dev] [PATCH 0/2] Windows logging

2020-04-29 Thread Pallavi Kadam
This patchset adds EAL logging support on Windows. Logs will be sent to console output. Pallavi Kadam (2): eal: initialize eal logging on Windows eal: add fnmatch implementation on Windows lib/librte_eal/windows/eal.c | 3 + lib/librte_eal/windows/eal_log.c | 16 +++ l

[dpdk-dev] [PATCH 1/2] eal: initialize eal logging on Windows

2020-04-29 Thread Pallavi Kadam
Add logging function on Windows to send log output to the console. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Tasnim Bashar Tested-by: Dmitry Kozlyuk --- lib/librte_eal/windows/eal.c | 3 +++ lib/librte_eal/windows/eal_log.c | 16 lib/librte_

Re: [dpdk-dev] [PATCH v2 1/6] service: fix race condition for MT unsafe service

2020-04-29 Thread Honnappa Nagarahalli
Hi Harry, Thanks for getting back on this. > > Subject: [PATCH v2 1/6] service: fix race condition for MT unsafe > > service > > > > From: Honnappa Nagarahalli > > > > The MT unsafe service might get configured to run on another core > > while the service is running currently. This migh

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-04-29 Thread Aaron Conole
Konstantin Ananyev writes: > Rework test code to reduce code complexity for the compiler > and bring down compilation time and memory consumption. > > Signed-off-by: Konstantin Ananyev > --- I'll wait for Honnappa's review, but this looks good to me. Consider that I will ACK by the end of the

Re: [dpdk-dev] ISSUE: compiling with asan+ubsan

2020-04-29 Thread Aaron Conole
"Ananyev, Konstantin" writes: >> >> >> While compiling with asan and ubsan I run into the following error: >> >> >> >> >> >> FAILED: app/test/app@test@@dpdk-test@exe/test_ring.c.o >> >> >> >> >> >> gcc -Iapp/test/app@test@@dpdk-test@exe -Iapp/test -I../app/test >> >> >> -Ilib/librte_acl -I../lib/

Re: [dpdk-dev] [PATCH] maintainers: update for Intel ixgbe/igb/igc

2020-04-29 Thread Thomas Monjalon
27/04/2020 13:47, Ferruh Yigit: > On 4/27/2020 2:28 AM, Wei Zhao wrote: > > Replace Wenzhuo Lu, Alvin Zhang and Konstantin Ananyev > > with Wei Zhao and Jeff Guo. > > > > Signed-off-by: Wei Zhao > > Acked-by: Ferruh Yigit Acked-by: Konstantin Ananyev Acked-by: Wenzhuo Lu Acked-by: Jeff Guo A

Re: [dpdk-dev] [PATCH 0/3] update MAINTAINER

2020-04-29 Thread Thomas Monjalon
26/04/2020 10:21, Beilei Xing: > Update maintainer for Intel i40e, Intel iavf and driver testind tool. > > Beilei Xing (3): > maintainers: update for Intel i40e > maintainers: update for Intel iavf > maintainers: update for driver testing tool Applied, thanks

Re: [dpdk-dev] [PATCH] eal: fix lcore state bug

2020-04-29 Thread Lukasz Wojciechowski
Hi Phil, W dniu 29.04.2020 o 17:07, Phil Yang pisze: > Hi Lukasz, > >> -Original Message- >> From: dev On Behalf Of Lukasz Wojciechowski >> Sent: Tuesday, April 28, 2020 9:22 AM >> To: Harry van Haaren ; Jerin Jacob >> >> Cc: dev@dpdk.org; l.wojciec...@partner.samsung.com; sta...@dpdk.or

Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-04-29 Thread Honnappa Nagarahalli
Hi Vladimir, I am not sure which way the decision is made, but few comments inline. Please use C11 built-ins for synchronization. > -Original Message- > From: dev On Behalf Of Vladimir Medvedkin > Sent: Wednesday, April 15, 2020 1:17 PM > To: dev@dpdk.org > Cc: konstantin.anan...

Re: [dpdk-dev] ISSUE: compiling with asan+ubsan

2020-04-29 Thread Aaron Conole
"Ananyev, Konstantin" writes: >> >> >> While compiling with asan and ubsan I run into the following error: >> >> >> >> >> >> FAILED: app/test/app@test@@dpdk-test@exe/test_ring.c.o >> >> >> >> >> >> gcc -Iapp/test/app@test@@dpdk-test@exe -Iapp/test -I../app/test >> >> >> -Ilib/librte_acl -I../lib/

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-04-29 Thread Honnappa Nagarahalli
Hi Konstantin, Thanks for the patch. I think we need to co-ordinate better on the rte_ring related work to avoid duplicating the efforts. I also have been working on a patch myself and it is undergoing internal review. I will review this patch soon. Thanks, Honnappa > -Original Mes

[dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM

2020-04-29 Thread pbhagavatula
From: Pavan Nikhilesh Merge crc32 hash calculation public API headers for x86 and ARM, split implementations of x86 and ARM into their respective private headers. This reduces the ifdef code clutter while keeping current ABI intact. Although we install `rte_crc_arm64.h` it is not used in any of

Re: [dpdk-dev] ISSUE: compiling with asan+ubsan

2020-04-29 Thread Ananyev, Konstantin
> >> >> While compiling with asan and ubsan I run into the following error: > >> >> > >> >> FAILED: app/test/app@test@@dpdk-test@exe/test_ring.c.o > >> >> > >> >> gcc -Iapp/test/app@test@@dpdk-test@exe -Iapp/test -I../app/test > >> >> -Ilib/librte_acl -I../lib/librte_acl -I. -I../ -Iconfig -I../con

[dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-04-29 Thread Konstantin Ananyev
Rework test code to reduce code complexity for the compiler and bring down compilation time and memory consumption. Signed-off-by: Konstantin Ananyev --- app/test/test_ring.c | 373 +-- 1 file changed, 249 insertions(+), 124 deletions(-) diff --git a/app/

Re: [dpdk-dev] [PATCH] examples/vhost_blk: refactor vhost-blk example

2020-04-29 Thread Ferruh Yigit
On 2/28/2020 3:32 PM, Jin Yu wrote: > Decrease the code and make it easier to read. It's > useful for understanding the inflight APIs and how > packed ring works. Update the RST because the packed > ring patch has been merged to QEMU master and ring_packed > parameter changes to packed. > > Fixes:

Re: [dpdk-dev] [PATCH v4 2/2] vhost: utilize dpdk dynamic memory allocator

2020-04-29 Thread Maxime Coquelin
On 4/29/20 3:06 AM, Liu, Yong wrote: > This is sent by mistake, please ignore. > >> -Original Message- >> From: Liu, Yong >> Sent: Wednesday, April 29, 2020 9:01 AM >> To: maxime.coque...@redhat.com; Ye, Xiaolong ; >> Wang, Zhihong >> Cc: dev@dpdk.org; Liu, Yong >> Subject: [PATCH v4

Re: [dpdk-dev] [PATCH v4 0/2] one way barrier for split vring idx

2020-04-29 Thread Ferruh Yigit
On 4/24/2020 4:39 AM, Joyce Kong wrote: > This patchset replaces the two-way barriers with C11 one-way barriers > for split vring idx, when the frontend and backend are implemented > in software. > > By doing PVP benchmarking, the test result of 2c1q showed the throughput > increased 20% with the

Re: [dpdk-dev] [PATCH v1] vhost: fix mbuf allocation failures

2020-04-29 Thread Flavio Leitner
On Wed, Apr 29, 2020 at 10:43:01AM +0200, Maxime Coquelin wrote: > Hi Sivaprasad, > > On 4/28/20 11:52 AM, Sivaprasad Tummala wrote: > > vhost buffer allocation is successful for packets that fit > > into a linear buffer. If it fails, vhost library is expected > > to drop the current buffer descri

Re: [dpdk-dev] [PATCH v4 3/8] eal: introduce memory management wrappers

2020-04-29 Thread Burakov, Anatoly
On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: Introduce OS-independent wrappers for memory management operations used across DPDK and specifically in common code of EAL: * rte_mem_map() * rte_mem_unmap() * rte_get_page_size() * rte_mem_lock() Windows uses different APIs for memory mapping and re

Re: [dpdk-dev] [PATCH v2 1/6] service: fix race condition for MT unsafe service

2020-04-29 Thread Van Haaren, Harry
> -Original Message- > From: Phil Yang > Sent: Thursday, April 23, 2020 5:31 PM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; Ananyev, Konstantin > ; jer...@marvell.com; > hemant.agra...@nxp.com; honnappa.nagaraha...@arm.com; > gavin...@arm.co

Re: [dpdk-dev] [PATCH v4 2/8] eal: introduce internal wrappers for file operations

2020-04-29 Thread Burakov, Anatoly
On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: EAL common code uses file locking and truncation. Introduce OS-independent wrappers in order to support both Linux/FreeBSD and Windows: * eal_file_lock: lock or unlock an open file. * eal_file_truncate: enforce a given size for an open file. Wrappers

Re: [dpdk-dev] [PATCH v2] crypto/qat: fix computation of cd ptr in zuc and snow

2020-04-29 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, April 29, 2020 3:52 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX > ; > sta...@dpdk.org > Subject: [PATCH v2] crypto/qat: fix computation of cd ptr in zuc and snow > > Offset of cd pointer is too big

Re: [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector

2020-04-29 Thread Wang, Haiyue
> -Original Message- > From: Kevin Traynor > Sent: Wednesday, April 29, 2020 16:41 > To: Wang, Haiyue ; dev@dpdk.org; Richardson, Bruce > ; > Ananyev, Konstantin ; Stokes, Ian > > Subject: Re: [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 > vector > > On 29/04/2020 07:4

Re: [dpdk-dev] [PATCH] eal: fix lcore state bug

2020-04-29 Thread Phil Yang
Hi Lukasz, > -Original Message- > From: dev On Behalf Of Lukasz Wojciechowski > Sent: Tuesday, April 28, 2020 9:22 AM > To: Harry van Haaren ; Jerin Jacob > > Cc: dev@dpdk.org; l.wojciec...@partner.samsung.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] eal: fix lcore state bug > > T

[dpdk-dev] [PATCH v2] crypto/qat: fix computation of cd ptr in zuc and snow

2020-04-29 Thread Arek Kusztal
Offset of cd pointer is too big by state1size + state2size, so few extra unnecessary bytes will be copied into cd. Snow offset was improved as well. Fixes: d9b7d5bbc845 ("crypto/qat: add ZUC EEA3/EIA3 capability") Cc: sta...@dpdk.org Signed-off-by: Arek Kusztal --- v2: - added improvement to Sno

Re: [dpdk-dev] [PATCH v4] ethdev: support flow aging

2020-04-29 Thread Tom Barbette
Great news! - I can understand why there is no timeout unit. But that's calling for user nightmare. Eg I could only get from the code (and not from documentation yet? ) of the following mlx5 driver patch that the value should be in tenth of seconds. If I build an application that is supposed

Re: [dpdk-dev] [PATCH 1/7] build: always link-whole DPDK static libraries

2020-04-29 Thread Andrzej Ostruszka [C]
On 29/04/2020 12:08, Bruce Richardson wrote: > To ensure all constructors are included in static build, we need to pass > the --whole-archive flag when linking, which is used with the > "link_whole" meson option. Since we use link_whole for all libs, we no > longer need to track the lib as part of

Re: [dpdk-dev] [PATCH 6/6] doc: guide for Windows build using MinGW-w64

2020-04-29 Thread Thomas Monjalon
Hi, We didn't get a confirmation from Microsoft about the TLS problem. Please could we have a status? Should we mark shared library linkage as not supported in Windows DPDK? Is there a difference between clang and MinGW? 17/02/2020 07:27, Dmitry Kozlyuk: > > Remembered another issue: thread-loc

Re: [dpdk-dev] [RFC] ring: count and empty optimizations

2020-04-29 Thread Olivier Matz
Hi Morten, On Tue, Apr 28, 2020 at 03:53:15PM +0200, Morten Brørup wrote: > Olivier (maintainer of the Ring), I'm not anymore, CC'ing Konstantin and Honnappa. > I would like to suggest a couple of minor optimizations to the ring library. > > > 1. Testing if the ring is empty is as simple as co

[dpdk-dev] [PATCH] kvargs: fix crash when parsing an invalid token on FreeBSD

2020-04-29 Thread Olivier Matz
The behavior of strtok_r() is not the same between GNU libc and FreeBSD libc: in the first case, the context is set to "" when the last token is returned, while in the second case it is set to NULL. On FreeBSD, the current code crashes because we are dereferencing a NULL pointer (ctx1). Fix it by

[dpdk-dev] [PATCH] net/mlx5: fix wrong assert in modify converting

2020-04-29 Thread Bing Zhao
The assertion was added incorrectly in converting the modify actions into the format of low layer driver. There is no mask specified in the rte_flow actions, and PMD dirver will give a mask of all 1s to the field to be modified. For each field, the mask could not be zero. But for the whole header w

[dpdk-dev] [PATCH] app/testpmd: add cmdline option to set Rx mq mode

2020-04-29 Thread Xiaoyu Min
One new cmdline option `--rx-mq-mode` is added in order to have the possibility to check whether PMD handle the mq mode correctly or not. The reason is some NICs need to do different settings based on different RX mq mode, i.e RSS or not. With this support in testpmd, the above scenario can be te

[dpdk-dev] [PATCH] net/mlx5: fix default rule do RSS regardless rxmode

2020-04-29 Thread Xiaoyu Min
PMD create some default control rules with RSS action if it's not isolated mode. However whether default control rules need to do RSS or not should be controlled by device configuration, the mq_mode of rxmode configuration in specific. In another word, only when mq_mode is configured with ETH_MQ_

Re: [dpdk-dev] [PATCH] doc: remove intel PMD examples in flow bifurcation guide

2020-04-29 Thread Thomas Monjalon
29/04/2020 04:29, Xiaolong Ye: > Now this feature is no longer supported by kernel side, so remove the > intel PMD examples to avoid confusion. Please could you add a link to the commit removing this support in the kernel code? PS: please use capital letter for "Intel".

[dpdk-dev] [PATCH] net/mlx5: fix actions validation on root table

2020-04-29 Thread Bing Zhao
The maximal supported header modifications number of a single modify context on the root table cannot be queried from firmware directly. It is a fixed value of 16 in the latest releases. In the validation stage, PMD driver should ensure that no more than 16 header modify actions exist in a single c

Re: [dpdk-dev] [EXT] RE: [PATCH] examples/ipsec-secgw: fix dropping of initial IPsec pkts

2020-04-29 Thread Lukas Bartosik [C]
Hi Konstantin, Please see my answer below. Thanks, Lukasz On 24.04.2020 14:35, Ananyev, Konstantin wrote: >>> >>> Hi Lukas, >>> >>> Apologies for delay with response. >>> Do you have any thoughts how both cases could be covered: 1. Inline not applied to inbound IPsec pkts for short dur

[dpdk-dev] [PATCH] net/mlx5: fix actions validation on root table

2020-04-29 Thread Bing Zhao
The maximal supported header modifications number of a single modify context on the root table cannot be queried from firmware directly. It is a fixed value of 16 in the latest releases. In the validation stage, PMD driver should ensure that no more than 16 header modify actions exist in a single c

Re: [dpdk-dev] [PATCH] net/mlx5: save meter index instead of meter id

2020-04-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Sunday, April 26, 2020 5:51 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: save meter index instead of meter id > > Currently, while creating the flow with

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix display of sample test vector

2020-04-29 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, April 29, 2020 11:57 AM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX ; sta...@dpdk.org > Subject: [PATCH] app/crypto-perf: fix display of sample test vector > > This patch disables display

Re: [dpdk-dev] [PATCH] ethdev: check for Rx RSS distribution and RSS hash

2020-04-29 Thread Ferruh Yigit
On 4/29/2020 7:41 AM, oulijun wrote: > > > 在 2020/4/27 21:27, Ferruh Yigit 写道: >> On 4/27/2020 1:49 PM, Andrew Rybchenko wrote: >>> On 4/27/20 3:34 PM, Lijun Ou wrote: When rte api checks the Rx RSS distribution is enable but the RSS hash is disabled, it will return an error.

[dpdk-dev] [PATCH v2] raw/ioat: add ICX support

2020-04-29 Thread Radu Nicolau
Add support for Ice Lake IOAT DMA engine PCI Device ID. Signed-off-by: Radu Nicolau --- v2: squash commits, add description. drivers/raw/ioat/ioat_rawdev.c | 2 ++ usertools/dpdk-devbind.py | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ioat/ioat_rawdev

Re: [dpdk-dev] [PATCH] l3fwd-power: add Rx interrupt timeout

2020-04-29 Thread Hunt, David
On 29/4/2020 1:21 PM, Anatoly Burakov wrote: Currently, thread waiting on an interrupt does not have a timeout, so it will not ever wake up until traffic arrives. This means that, when time comes to exit the application, it will not quit unless there happens to be traffic coming in and waking u

[dpdk-dev] [PATCH] l3fwd-power: add Rx interrupt timeout

2020-04-29 Thread Anatoly Burakov
Currently, thread waiting on an interrupt does not have a timeout, so it will not ever wake up until traffic arrives. This means that, when time comes to exit the application, it will not quit unless there happens to be traffic coming in and waking up the thread from sleep. Fix it so that the inte

Re: [dpdk-dev] [PATCH 1/3] maintainers: update for Intel i40e

2020-04-29 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Sunday, April 26, 2020 4:22 PM > To: dev@dpdk.org; Wu, Jingjing ; Lu, Wenzhuo > ; Zhang, Qi Z > Subject: [PATCH 1/3] maintainers: update for Intel i40e > > Replace Qi Zhang with Jeff Guo. > > Signed-off-by: Beilei Xing > --- > MAINT

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix uninitialized variable warning

2020-04-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Thursday, April 23, 2020 1:32 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Matan Azrad > > Subject: [dpdk-dev] [PATCH v2] common/mlx5: fix uninitialized variable > warning > > Gcc 8.3.0 (Debian 10) complains

Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21

2020-04-29 Thread Dodji Seketeli
Hello, Ray Kinsella writes: > ah ok, the particular system I made the change on was Ubuntu 18.04.2. > which is libabigail 1.2.0. Whoah, 1.2 is super old. In my opinion, one of the hallmarks of static analysis tools (and libabigail is just a static analysis framework) is to be able to recognize

[dpdk-dev] [PATCH] mk: fix linking with static ibverbs libraries

2020-04-29 Thread Bing Zhao
When building a target application with static linking mode via makefiles and enable linking to ibverbs libs by setting "CONFIG_RTE_IBVERBS_LINK_STATIC=y". The libibverbs.pc will be chosen and all the libs listed in the file will be linked by default. Some static lib archives may contain the same f

Re: [dpdk-dev] [PATCH v4 2/2] vhost: binary search address mapping table

2020-04-29 Thread Maxime Coquelin
On 4/29/20 3:04 AM, Marvin Liu wrote: > If Tx zero copy enabled, gpa to hpa mapping table is updated one by > one. This will harm performance when guest memory backend using 2M > hugepages. Now utilize binary search to find the entry in mapping > table, meanwhile set the threshold to 256 entries

Re: [dpdk-dev] [PATCH] vhost: zero_copy incompatible with client mode

2020-04-29 Thread Maxime Coquelin
On 4/29/20 4:59 AM, Xuan Ding wrote: > In server mode, virtio-user inits under the assumption that vhost-user > supports a list of features. However, this could be problematic when > in_order feature is negotiated but not supported by vhost-user when > enables dequeue_zero_copy later. > > Add h

Re: [dpdk-dev] [PATCH v2 0/2] fixes for bonding

2020-04-29 Thread Wei Hu (Xavier)
Hi, Chas Williams Could you please give some suggestion on them? Thanks. Best Regards Xavier On 2020/4/17 16:19, Wei Hu (Xavier) wrote: This series include two fixes patches for bonding PMD driver. Wei Hu (Xavier) (2): net/bonding: fix MAC address when switching active port net

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-04-29 Thread David Marchand
On Tue, Apr 28, 2020 at 6:39 PM Ray Kinsella wrote: > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > > index a59df8f13..045f436fb 100644 > > --- a/devtools/libabigail.abignore > > +++ b/devtools/libabigail.abignore > > Kevin - you still have the surpession. > I am tes

Re: [dpdk-dev] [PATCH] ipv4_fragmentation: fix fragmentation of ipv4 packet with optional header

2020-04-29 Thread Ananyev, Konstantin
Hi, First of all - if it is a fix, then we need to have: Fixes: ... And probably Cc: sta...@dpdk.org As described here: https://doc.dpdk.org/guides/contributing/patches.html Second it would be good to add some text here - problem statement and solution description. > > Signed-off-by: Pu Xu <

Re: [dpdk-dev] [PATCH v4] eal/cpuflags: add x86 based cpu flags

2020-04-29 Thread Neil Horman
On Mon, Apr 27, 2020 at 02:58:07PM +0100, Ray Kinsella wrote: > > > On 27/04/2020 13:31, Thomas Monjalon wrote: > > 27/04/2020 11:27, Ray Kinsella: > >> On 25/04/2020 17:04, Thomas Monjalon wrote: > >>> PS: Who is REALLY maintaining the ABI? > >>> We really miss someone who carefully check all th

[dpdk-dev] [PATCH 5/6] net/hns3: fix MSI-x interrupt number during initialization

2020-04-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currnetly, based on hns3 VF device error may occur during initialization. The root cause as below: When the following fomula is excuted during initialization, the private variable named hw->tqps_num has not been obtained from PF driver through mailbox, further causes fail

[dpdk-dev] [PATCH 4/6] net/hns3: fix VLAN pvid when configuring device

2020-04-29 Thread Wei Hu (Xavier)
From: "Min Hu (Connor)" In current version, when upper level application calls the rte_eth_dev_configure API function, if pvid config is not set of the input parameter which struct type is rte_eth_conf, hns3 pmd driver also sets the VLAN pvid related configuration to hardware, and this is not rea

[dpdk-dev] [PATCH 6/6] net/hns3: fix return value when clearing statistics fails

2020-04-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Since the return value of the '.stats_reset' and '.xstats_reset' callback function is int, when failing to issue command to firmware to execute clear statistics, the relevant callback function should return non-zero value. Fixes: 8839c5e202f3 ("net/hns3: support device st

[dpdk-dev] [PATCH 1/6] net/hns3: get Tx abnormal errors in extend device statistics

2020-04-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" When upper level application calls the rte_eth_tx_burst API function to send multiple packets at a time with burst mode based on hns3 network engine, there are some abnormal conditions that cause the driver to fail to operate the hardware to send packets correctly. This p

[dpdk-dev] [PATCH 2/6] net/hns3: print the detail ret value

2020-04-29 Thread Wei Hu (Xavier)
From: Lijun Ou Here adds some prints for return value when the relative function fails and enter the exception branch. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_dcb.c| 7 +-- drivers/net/hns3/hns3_ethdev.c | 4 ++-- drivers/net/hns3/hns3_fdir.c

[dpdk-dev] [PATCH 0/6] misc updates and bugfixes for hns3 PMD driver

2020-04-29 Thread Wei Hu (Xavier)
This series are misc updates and bugfixes for hns3 PMD driver. Lijun Ou (1): net/hns3: print the detail ret value Min Hu (Connor) (1): net/hns3: fix VLAN pvid when configuring device Wei Hu (Xavier) (4): net/hns3: get Tx abnormal errors in extend device statistics net/hns3: get PCI revis

[dpdk-dev] [PATCH 3/6] net/hns3: get PCI revision id

2020-04-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" The hns3 network engine is built-in multiple SoCs, such as kunpeng 920, kunpeng 930, etc. The PCI revision id is 0x21 in kunpeng 920, and the PCI revision id is 0x30 in kunpeng 930. This patch gets PCI revison to identify different version of hardware network engine. Sig

Re: [dpdk-dev] [PATCH 5/7] build/pkg-config: output driver libs first for static build

2020-04-29 Thread Luca Boccassi
On Wed, 2020-04-29 at 12:03 +0100, Bruce Richardson wrote: > On Wed, Apr 29, 2020 at 11:40:33AM +0100, Luca Boccassi wrote: > > On Wed, 2020-04-29 at 11:08 +0100, Bruce Richardson wrote: > > > When calling pkg-config --static --libs, pkg-config will always output the > > > regular libs first, and t

Re: [dpdk-dev] [PATCH 6/7] build/pkg-config: improve static linking flags

2020-04-29 Thread Luca Boccassi
On Wed, 2020-04-29 at 11:58 +0100, Bruce Richardson wrote: > On Wed, Apr 29, 2020 at 11:37:02AM +0100, Luca Boccassi wrote: > > On Wed, 2020-04-29 at 11:08 +0100, Bruce Richardson wrote: > > > Rather than setting -Bstatic in the linker flags when doing a static link, > > > and then having to explic

Re: [dpdk-dev] [PATCH 5/7] build/pkg-config: output driver libs first for static build

2020-04-29 Thread Bruce Richardson
On Wed, Apr 29, 2020 at 11:40:33AM +0100, Luca Boccassi wrote: > On Wed, 2020-04-29 at 11:08 +0100, Bruce Richardson wrote: > > When calling pkg-config --static --libs, pkg-config will always output the > > regular libs first, and then the extra libs from libraries.private field, > > since the assu

Re: [dpdk-dev] [PATCH 7/7] build/pkg-config: prevent overlinking

2020-04-29 Thread Bruce Richardson
On Wed, Apr 29, 2020 at 12:34:56PM +0200, Thomas Monjalon wrote: > 29/04/2020 12:08, Bruce Richardson: > > Add the --as-needed linker flag to the DPDK library list in the pkg-config > > file so as to prevent overlinking. Without this flag, when linking > > statically using flags from $(pkg-config -

[dpdk-dev] [PATCH] app/crypto-perf: fix display of sample test vector

2020-04-29 Thread Adam Dybkowski
This patch disables displaying sample test vector contents when executing throughput and latency tests as the sample data is not used in those tests (not copied to input mbuf in order to achieve better performance). Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc

Re: [dpdk-dev] [PATCH 6/7] build/pkg-config: improve static linking flags

2020-04-29 Thread Bruce Richardson
On Wed, Apr 29, 2020 at 11:37:02AM +0100, Luca Boccassi wrote: > On Wed, 2020-04-29 at 11:08 +0100, Bruce Richardson wrote: > > Rather than setting -Bstatic in the linker flags when doing a static link, > > and then having to explicitly set -Bdynamic again afterwards, we can update > > the pkg-conf

Re: [dpdk-dev] [PATCH 6/7] build/pkg-config: improve static linking flags

2020-04-29 Thread Thomas Monjalon
29/04/2020 12:56, Bruce Richardson: > On Wed, Apr 29, 2020 at 12:32:51PM +0200, Thomas Monjalon wrote: > > 29/04/2020 12:08, Bruce Richardson: > > > Rather than setting -Bstatic in the linker flags when doing a static link, > > > and then having to explicitly set -Bdynamic again afterwards, we can

Re: [dpdk-dev] [PATCH 6/7] build/pkg-config: improve static linking flags

2020-04-29 Thread Bruce Richardson
On Wed, Apr 29, 2020 at 12:32:51PM +0200, Thomas Monjalon wrote: > 29/04/2020 12:08, Bruce Richardson: > > Rather than setting -Bstatic in the linker flags when doing a static link, > > and then having to explicitly set -Bdynamic again afterwards, we can update > > the pkg-config file to use -l:lib

Re: [dpdk-dev] [PATCH v1 2/2] raw/ioat: add ICX support

2020-04-29 Thread Thomas Monjalon
29/04/2020 11:37, Radu Nicolau: > Signed-off-by: Radu Nicolau The commit log of patch 2 is not better than in patch 1. I suggest to squash both commits together.

Re: [dpdk-dev] [PATCH v1 1/2] usertools: add support for ICX IOAT

2020-04-29 Thread Thomas Monjalon
29/04/2020 11:37, Radu Nicolau: > Signed-off-by: Radu Nicolau The commit log is... short :-) Please could you add few words about the HW you want to support? Maybe a link to a description in the web?

Re: [dpdk-dev] [PATCH 5/7] build/pkg-config: output driver libs first for static build

2020-04-29 Thread Bruce Richardson
On Wed, Apr 29, 2020 at 12:30:10PM +0200, Thomas Monjalon wrote: > 29/04/2020 12:08, Bruce Richardson: > > When calling pkg-config --static --libs, pkg-config will always output > > the regular libs first, and then the extra libs from libraries.private > > field, since the assumption is that those

Re: [dpdk-dev] [PATCH 1/7] build: always link-whole DPDK static libraries

2020-04-29 Thread Thomas Monjalon
29/04/2020 12:42, Bruce Richardson: > On Wed, Apr 29, 2020 at 12:18:19PM +0200, Thomas Monjalon wrote: > > 29/04/2020 12:08, Bruce Richardson: > > > To ensure all constructors are included in static build, we need to pass > > > the --whole-archive flag when linking, which is used with the > > > "li

Re: [dpdk-dev] [PATCH 1/7] build: always link-whole DPDK static libraries

2020-04-29 Thread Bruce Richardson
On Wed, Apr 29, 2020 at 12:18:19PM +0200, Thomas Monjalon wrote: > 29/04/2020 12:08, Bruce Richardson: > > To ensure all constructors are included in static build, we need to pass > > the --whole-archive flag when linking, which is used with the > > "link_whole" meson option. Since we use link_whol

Re: [dpdk-dev] [PATCH 5/7] build/pkg-config: output driver libs first for static build

2020-04-29 Thread Luca Boccassi
On Wed, 2020-04-29 at 11:08 +0100, Bruce Richardson wrote: > When calling pkg-config --static --libs, pkg-config will always output the > regular libs first, and then the extra libs from libraries.private field, > since the assumption is that those are additional dependencies for building > statica

Re: [dpdk-dev] [PATCH 6/7] build/pkg-config: improve static linking flags

2020-04-29 Thread Luca Boccassi
On Wed, 2020-04-29 at 11:08 +0100, Bruce Richardson wrote: > Rather than setting -Bstatic in the linker flags when doing a static link, > and then having to explicitly set -Bdynamic again afterwards, we can update > the pkg-config file to use -l:libfoo.a syntax to explicitly refer to the > static l

Re: [dpdk-dev] [PATCH] net/mlx5: fix location of assert function

2020-04-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Asaf Penso > Sent: Thursday, April 16, 2020 8:15 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Dekel Peled > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix location of assert function > > The asserts makes sure that 'i' does

Re: [dpdk-dev] [PATCH 7/7] build/pkg-config: prevent overlinking

2020-04-29 Thread Thomas Monjalon
29/04/2020 12:08, Bruce Richardson: > Add the --as-needed linker flag to the DPDK library list in the pkg-config > file so as to prevent overlinking. Without this flag, when linking > statically using flags from $(pkg-config --static --libs libdpdk), all DPDK > drivers and libs were statically link

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 2/3] doc: input set requirement of each pctype for FDIR

2020-04-29 Thread Ferruh Yigit
On 4/29/2020 3:03 AM, Wei Zhao wrote: > Add input set requirement info to i40e doc. > > Bugzilla ID: 403 Should this document update backported to the LTS? If so which LTS versions are in the scope, it is better if you can add a fixes tag to help us to figure out that. > Signed-off-by: Wei Zhao

Re: [dpdk-dev] [PATCH 6/7] build/pkg-config: improve static linking flags

2020-04-29 Thread Thomas Monjalon
29/04/2020 12:08, Bruce Richardson: > Rather than setting -Bstatic in the linker flags when doing a static link, > and then having to explicitly set -Bdynamic again afterwards, we can update > the pkg-config file to use -l:libfoo.a syntax to explicitly refer to the > static library in question. Sin

  1   2   >