Re: [dpdk-dev] [PATCH 1/7] common/dpaax: move internal symbols into INTERNAL section

On 07/05/2020 07:20, Hemant Agrawal wrote: > Hi David > >> On Tue, May 5, 2020 at 4:10 PM Hemant Agrawal >> wrote: >>> >>> This patch moves the internal symbols to INTERNAL sections so that any >>> change in them is not reported as ABI breakage. >> >> Talking about the series (not just this pa

Re: [dpdk-dev] [PATCH] net/igc: remove some useless log

On 04/30, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >As title. > >Fixes: 746664d546fb (net/igc: implement flow API) >Cc: sta...@dpdk.org > >Signed-off-by: Alvin Zhang >--- > drivers/net/igc/igc_txrx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/drivers/net/i

Re: [dpdk-dev] [PATCH] net/i40e: fix out of bounds read issue

On 05/07, Di, ChenxuX wrote: >Hi, xiaolong > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Thursday, May 7, 2020 1:15 PM >> To: Di, ChenxuX >> Cc: dev@dpdk.org; Xing, Beilei >> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix out of bounds read issue >> >> On 05/07, Chenxu Di wrote:

[dpdk-dev] [PATCH 2/2] net/e1000: fix defects of macro in VF

The defects in the macros UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. If latest is less than last, we will get wrong result. The patch fixes the defect. Fixes: d15fcf76c8b7 ("e1000: move to drivers/net/") Cc: sta...@dpdk.org Signed-off-by: Guinan Sun --- drivers/net/e1000/igb_ethdev.c | 14 +

[dpdk-dev] [PATCH 1/2] net/ixgbe: fix defects of macro in VF

The defects in the macros UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. If latest is less than last, we will get wrong result. The patch fixes the defect. Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") Cc: sta...@dpdk.org Signed-off-by: Guinan Sun --- drivers/net/ixgbe/ixgbe_ethdev.c | 20

[dpdk-dev] [PATCH 0/2] fix defects of macro in VF

The defects of UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. If latest is less than last, we will get wrong result. The issues exist only in ixgbe and e1000 NICs. Guinan Sun (2): net/ixgbe: fix defects of macro in VF net/e1000: fix defects of macro in VF drivers/net/e1000/igb_ethdev.c | 1

Re: [dpdk-dev] [PATCH] net/igc: fix memory illegal accesses

hi, alvin On 5/7/2020 10:01 AM, alvinx.zh...@intel.com wrote: From: Alvin Zhang Add memory access out-of-bounds check. Could you explain why add ...?  If not add, what issue? Fixes: bd3fcf0d0fa1 (net/igc: support RSS) Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/i

Re: [dpdk-dev] [PATCH v2] test/service: add perf test for service on app lcore

> -Original Message- > From: Harry van Haaren > Sent: Thursday, May 7, 2020 1:17 AM > To: dev@dpdk.org > Cc: david.march...@redhat.com; Phil Yang ; > Honnappa Nagarahalli ; Harry van Haaren > > Subject: [PATCH v2] test/service: add perf test for service on app lcore > > This commit adds

Re: [dpdk-dev] [PATCH 1/7] common/dpaax: move internal symbols into INTERNAL section

Hi David > On Tue, May 5, 2020 at 4:10 PM Hemant Agrawal > wrote: > > > > This patch moves the internal symbols to INTERNAL sections so that any > > change in them is not reported as ABI breakage. > > Talking about the series (not just this patch as I did not look at the > details), > travis re

Re: [dpdk-dev] [PATCH] net/i40e: fix out of bounds read issue

Hi, xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Thursday, May 7, 2020 1:15 PM > To: Di, ChenxuX > Cc: dev@dpdk.org; Xing, Beilei > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix out of bounds read issue > > On 05/07, Chenxu Di wrote: > >This patch fixes (out-of-bounds read

Re: [dpdk-dev] [PATCH v3 8/8] net/dpaa2: use cong group id for multiple tcs

Hi Ferruh, > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Thursday, May 7, 2020 3:09 AM > To: Hemant Agrawal ; dev@dpdk.org > Cc: Jun Yang > Subject: Re: [dpdk-dev] [PATCH v3 8/8] net/dpaa2: use cong group id for > multiple tcs > > On 5/4/2020 1:41 PM, Hemant Agrawal

Re: [dpdk-dev] [PATCH v3 4/8] net/dpaa2: add default Rx params in devinfo

Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, May 7, 2020 3:00 AM > To: Hemant Agrawal ; dev@dpdk.org > Subject: Re: [PATCH v3 4/8] net/dpaa2: add default Rx params in devinfo > > On 5/4/2020 1:41 PM, Hemant Agrawal wrote: > > This patch adds default/preferred rx

Re: [dpdk-dev] [PATCH 3/5] doc: add cycles per packet in testpmd user guide

On Thu, May 7, 2020 at 3:30 AM Dharmik Thakkar wrote: > > Update documentation for 'show fwd' testpmd runtime function to show > CPU cycles/packet example. > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Phil Yang > --- > doc/guides/testpmd_app_ug/testpmd_

Re: [dpdk-dev] [PATCH] net/i40e: fix out of bounds read issue

On 05/07, Chenxu Di wrote: >This patch fixes (out-of-bounds read) coverity issue. > >Coverity issue: 357699 >Coverity issue: 357694 >Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") > >Signed-off-by: Chenxu Di >--- > drivers/net/i40e/i40e_ethdev.c | 4 ++-- > 1 file changed,

Re: [dpdk-dev] [PATCH 5/5] doc: add aarch64 generic counter section

On Thu, May 7, 2020 at 3:29 AM Dharmik Thakkar wrote: > > Add a separate section for low-resolution generic counter > for ARM64 profiling methods. > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Phil Yang Acked-by: Jerin Jacob > --- > doc/guides/prog_

Re: [dpdk-dev] [PATCH] app/test: set null cipher iv length to zero

> > For null cipher the iv length should be set to zero. > > Signed-off-by: Ankur Dwivedi Acked-by: Anoob Joseph

Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: fix negative argument passing

> Function create_ipsec_esp_flow returns a negative number in case of any > failure > and we are passing this to strerror to display the error message. > But strerror()'s argument cannot be negative. > In case of failure, displaying exact error message to console is handled in > create_ipsec_esp

[dpdk-dev] [PATCH] net/i40e: fix out of bounds read issue

This patch fixes (out-of-bounds read) coverity issue. Coverity issue: 357699 Coverity issue: 357694 Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix overrun of the ulp device params array

On Wed, May 6, 2020 at 2:17 AM Ferruh Yigit wrote: > On 5/5/2020 8:17 PM, Ajit Khaparde wrote: > > From: Kishore Padmanabha > > > > Fix a buffer overrun issue spotted by coverity while accessing > > the array ulp_device_params. > > If it is spotted by coverity, is there a coverity issue id? > Ye

[dpdk-dev] [PATCH] net/igc: fix memory illegal accesses

From: Alvin Zhang Add memory access out-of-bounds check. Fixes: bd3fcf0d0fa1 (net/igc: support RSS) Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_ethdev.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/igc/igc_ethdev.c b/

Re: [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error

Tested-by: Lu, Nannan -Original Message- From: Zhao1, Wei Sent: Thursday, May 7, 2020 9:16 AM To: dev@dpdk.org Cc: Zhang, Qi Z ; Lu, Nannan ; Zhao1, Wei Subject: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error The dummy packet for pppoe-ipv6 has an error, we should use 0x3b fo

[dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error

The dummy packet for pppoe-ipv6 has an error, we should use 0x3b for next header in ipv6 header in the dummy packet, or some case can not be download, such as: "eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end" Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy

[dpdk-dev] [PATCH v3] app/testpmd: add cmdline option to set Rx mq mode

One new cmdline option `--rx-mq-mode` is added in order to have the possibility to check whether PMD handle the mq mode correctly or not. The reason is some NICs need to do different settings based on different RX mq mode, i.e RSS or not. With this support in testpmd, the above scenario can be te

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix overrun of the ulp device params array

On 5/6/2020 11:14 PM, Ajit Khaparde wrote: > > > On Wed, May 6, 2020 at 2:17 AM Ferruh Yigit > wrote: > > On 5/5/2020 8:17 PM, Ajit Khaparde wrote: > > From: Kishore Padmanabha > > > > > Fix a buffer ove

Re: [dpdk-dev] [PATCH] net/af_packet: changes to accomodate jumbo frames

On 4/21/2020 8:50 AM, Kiran KN wrote: > > Change the maximum packet length to accommodate jumbo frames > > signed-off-by: Kiran KN > > --- > drivers/net/af_packet/rte_eth_af_packet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/af_packet/rte_eth_af_pack

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: print clock with CPU cycles per pkt

W dniu 06.05.2020 o 23:58, Dharmik Thakkar pisze: > On aarch64 platforms, the cycles are counted using either a > low-resolution generic counter or a high-resolution PMU cycle counter. > Print the clock frequency along with CPU cycles/packet to identify which > cycle counter is being used. > > Si

Re: [dpdk-dev] Using pktgen-dpdk with Lua

> On May 6, 2020, at 10:14 AM, Tiffany Kalin wrote: > > Hello, > > I'm wanting to use Lua scripts with pktgen-dpdk, but when I run pktgen-dpdk > it can't find the Pktgen.lua or Pktgen.so even with the test scripts. How > do I setup my system so that I can use the Pktgen Lua module? Is there a

Re: [dpdk-dev] [EXT] Re: input port in mbuf

> For performance optimizations, we need to know the input DPDK port as after > the buffer was transmitted via our ethdev driver instead of > release it back to the memory-pool we can release it to the originated HW > pool of the input port. Then I suppose, you can have your own mempool driver,

Re: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM

> -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, April 29, 2020 11:05 AM > To: jer...@marvell.com; tho...@monjalon.net; Wang, Yipeng1 > ; Gobriel, Sameh ; > Richardson, Bruce ; Ruifeng Wang > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [RFC] hash: un

Re: [dpdk-dev] [PATCH] mk: fix linking with static ibverbs libraries

29/04/2020 14:11, Bing Zhao: > When building a target application with static linking mode via > makefiles and enable linking to ibverbs libs by setting > "CONFIG_RTE_IBVERBS_LINK_STATIC=y". The libibverbs.pc will be > chosen and all the libs listed in the file will be linked > by default. Some sta

[dpdk-dev] [PATCH 2/5] app/testpmd: print fractional part in CPU cycles

Change printing of CPU cycles/packet to include fractional part for accurateness. Example: Without patch: CPU cycles/packet=14 (total cycles=4899533541 / total RX packets=343031966) With patch: CPU cycles/packet=14.28 (total cycles=4899533541 / total RX packets=343031966) Signed-off-by: Dharmik

[dpdk-dev] [PATCH 3/5] doc: add cycles per packet in testpmd user guide

Update documentation for 'show fwd' testpmd runtime function to show CPU cycles/packet example. Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Phil Yang --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 51 + 1 file changed, 31 insertions(+),

[dpdk-dev] [PATCH 4/5] doc: include config options in testpmd user guide

Update testpmd documentation to include RECORD configuration options, CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS. Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Phil Yang --- doc/guides/testpmd_app_ug/build_app.rst | 12

[dpdk-dev] [PATCH 5/5] doc: add aarch64 generic counter section

Add a separate section for low-resolution generic counter for ARM64 profiling methods. Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Phil Yang --- doc/guides/prog_guide/profile_app.rst | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[dpdk-dev] [PATCH 1/5] app/testpmd: print clock with CPU cycles per pkt

On aarch64 platforms, the cycles are counted using either a low-resolution generic counter or a high-resolution PMU cycle counter. Print the clock frequency along with CPU cycles/packet to identify which cycle counter is being used. Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

On 2020-05-06 10:46 GMT+0100 Burakov, Anatoly wrote: > On 06-May-20 12:20 AM, Dmitry Kozlyuk wrote: > > On 2020-05-05 17:24 GMT+0100 Burakov, Anatoly wrote: > >> On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: > >> Lots of duplication... I wonder if it would be possible to share at > >> least some o

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/octeontx: fix GCC 9.1 ABI break

05/05/2020 12:33, Ferruh Yigit: > On 5/4/2020 10:17 AM, Harman Kalra wrote: > > On Sat, May 02, 2020 at 09:40:31PM +0530, pbhagavat...@marvell.com wrote: > >> From: Pavan Nikhilesh > >> > >> GCC 9.1 fixes a bug with passing bitfields as pass by value in function > >> parameters and generates a war

Re: [dpdk-dev] [dpdk-stable] [PATCH] mem: fix the alloc size roundup overflow

21/04/2020 05:18, Bing Zhao: > From: Burakov, Anatoly > > Can we add a unit test for this in malloc_autotest? > > > > Otherwise, > > > > Acked-by: Anatoly Burakov > > Thanks, Burakov. I can try to add one case in the unit for this. Any update about writing an unit test?

Re: [dpdk-dev] [PATCH v3 8/8] net/dpaa2: use cong group id for multiple tcs

On 5/4/2020 1:41 PM, Hemant Agrawal wrote: > From: Jun Yang > > Flow id may not work when used with multipel tcs. > The CGID will be provided in the INDEX field. Hi Jun, Can you please provide more information in commit log, why this change is done, is it to fix something, if so what is broken

[dpdk-dev] [PATCH] common/qat: fix coverity issue

This patch fixes Coverity issue #357770 by removing the non-essential check for NULL pointer. Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation") Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [dpdk-dev] [PATCH v3 4/8] net/dpaa2: add default Rx params in devinfo

On 5/4/2020 1:41 PM, Hemant Agrawal wrote: > This patch adds default/preferred rx/tx params in dev info, > specially the advertised burst size. > > Signed-off-by: Hemant Agrawal > --- > drivers/net/dpaa/dpaa_ethdev.c | 4 > drivers/net/dpaa/dpaa_ethdev.h | 1 + > drivers/net/dpaa2/dpa

Re: [dpdk-dev] [PATCH v3 1/8] bus/fslmc: fix dereferencing null pointer

On 5/4/2020 1:41 PM, Hemant Agrawal wrote: > From: Apeksha Gupta > > This patch fixees the nxp internal coverity reported > null pointer dereferncing issue. > > Fixes: 6fef517e17cf ("bus/fslmc: add qman HW fq query count API") > Cc: sta...@dpdk.org > > Signed-off-by: Apeksha Gupta > --- > dri

Re: [dpdk-dev] [PATCH v3 1/8] bus/fslmc: fix dereferencing null pointer

On 5/6/2020 10:08 PM, Ferruh Yigit wrote: > On 5/4/2020 1:41 PM, Hemant Agrawal wrote: >> From: Apeksha Gupta >> >> This patch fixees the nxp internal coverity reported >> null pointer dereferncing issue. > > What is the coverity issue number? Can you please put it into commit log as > "Coverity

Re: [dpdk-dev] [PATCH v3 1/8] bus/fslmc: fix dereferencing null pointer

On 5/4/2020 1:41 PM, Hemant Agrawal wrote: > From: Apeksha Gupta > > This patch fixees the nxp internal coverity reported > null pointer dereferncing issue. What is the coverity issue number? Can you please put it into commit log as "Coverity issue: ###" format. > > Fixes: 6fef517e17cf ("bus/f

[dpdk-dev] Using pktgen-dpdk with Lua

Hello, I'm wanting to use Lua scripts with pktgen-dpdk, but when I run pktgen-dpdk it can't find the Pktgen.lua or Pktgen.so even with the test scripts. How do I setup my system so that I can use the Pktgen Lua module? Is there an installation step I'm missing to generate the Pktgen Lua module? T

Re: [dpdk-dev] [pull-request] next-eventdev 20.05 RC2

04/05/2020 13:57, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [PATCH 2/2] bus/pci: cleanup private symbols

On Wed, 6 May 2020 19:21:23 +0200 Gaëtan Rivet wrote: > On 06/05/20 14:43 +0200, David Marchand wrote: > > Internal symbols do not need the rte_ prefix. > > Some symbols do not need to be exposed in the private header and have > > been made static. > > > > Fixes: c752998b5e2e ("pci: introduce li

Re: [dpdk-dev] [PATCH v3] net/mlx5: add 200G link speed

On 5/6/2020 1:22 PM, Asaf Penso wrote: > There is no way to report back a link speed of 200Gbps. > > Adding 200G link speed. > > Signed-off-by: Asaf Penso The doc warning fixed [1] and patch split into two as discussed [2] while merging. For ethdev part, Reviewed-by: Ferruh Yigit Applied to

Re: [dpdk-dev] [EXT] Re: input port in mbuf

On Wed, 6 May 2020 20:17:20 + Liron Himi wrote: > For performance optimizations, we need to know the input DPDK port as after > the buffer was transmitted via our ethdev driver instead of release it back > to the memory-pool we can release it to the originated HW pool of the input > port.

Re: [dpdk-dev] [PATCH 2/2] net/tap: use netlink extended ack support

On Wed, 6 May 2020 19:41:28 +0100 Ferruh Yigit wrote: > On 4/27/2020 12:32 PM, Andrzej Ostruszka [C] wrote: > > On 25/04/2020 01:36, Stephen Hemminger wrote: > >> In recent Linux kernels, there is support for extended acknowledgement > >> to netlink messages. This is quite useful for diagnosing

Re: [dpdk-dev] [EXT] Re: input port in mbuf

For performance optimizations, we need to know the input DPDK port as after the buffer was transmitted via our ethdev driver instead of release it back to the memory-pool we can release it to the originated HW pool of the input port. Regards, Liron -Original Message- From: Stephen Hem

Re: [dpdk-dev] [PATCH] doc: update bnxt guide

On Wed, May 6, 2020 at 1:57 AM Ferruh Yigit wrote: > On 5/1/2020 11:03 PM, Ajit Khaparde wrote: > > - Update list of supported adapters. > > - Update list of supported features. > > - Add some details to describe the features. > > - Remove obsolete limitations. > > - Fix and u

Re: [dpdk-dev] [EXT] Re: input port in mbuf

On Wed, 6 May 2020 19:48:26 + Liron Himi wrote: > Fine. Is there another location or option to save this information? > > Regards, > Liron > > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, 6 May 2020 22:43 > To: Liron Himi > Cc: dpdk-dev > Subject: [EXT] Re: [d

[dpdk-dev] [PATCH v2 2/7] app/proc-info: eliminate useless borders

Printing extra borders does not improve readability, and is just unnecessary. Putting TSC hz in header also makes no sense here. Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 35 +++ 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/app/

[dpdk-dev] [PATCH v2 5/7] app/proc-info: hide crypto-context display

If crypto context is not present, no point in displaying it. Also fix spelling error. Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index c4f1f99e7d5d..804c0fd63b3e 10

[dpdk-dev] [PATCH v2 4/7] app/proc-info: add more info to show_ports

Revise the display of port information to include more data and be more human friendly. * Display units for port speed, and decode link fields. * Show driver and device information * Show MAC address * Show flow control information * Combine lines if possible Signed-off-by: Stephen Hemm

[dpdk-dev] [PATCH v2 3/7] app/proc-info: hide EAL info messages

The DPDK EAL info messages at the start of a diagnostic application are not helpful to end user. Suppress them by setting log-level by default. Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/proc-info/m

[dpdk-dev] [PATCH v2 1/7] app/proc-info: remove unused logtype #define

This logtype is defined but never used. Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab438..69e3000616c0 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -39,

[dpdk-dev] [PATCH v2 7/7] app/proc-info: provide way to request info on owned ports

There are cases where a port maybe owned by another (failsafe, netvsc, bond); but currently proc-info has no way to look at stats of those ports. This patch provides way for the user to explicitly ask for these ports. If no portmask is given the output is unchanged; it only shows the top level por

[dpdk-dev] [PATCH v2 6/7] app/proc-info: dump rx and tx descriptor info

Many drivers will report per queue info for both rx and tx as well as how many descriptors are in use. Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 79 1 file changed, 66 insertions(+), 13 deletions(-) diff --git a/app/proc-info/main.c

[dpdk-dev] [PATCH v2 0/7] app/proc-info enhancements

The current proc-info command is useful for diagnosing issues with external DPDK applications, but the display is limited and somewhat ugly. This patchset adds some enhancements which show more info and suppress unnecessary stuff. v2 - fix checkpatch complaints Stephen Hemminger (7): app/proc-i

[dpdk-dev] [PATCH v2 0/4] net/netvsc: diagnostic enhancements

This patch set is based on top of my previous netvsc PMD bug fixes. It provides additional standard diagnostic hooks for queue info and improves the debug output. v2 - add missing Signed-off-by Stephen Hemminger (4): net/netvsc: support per-queue info requests net/netvsc: implement rx/tx desc

[dpdk-dev] [PATCH v2 2/4] net/netvsc: implement rx/tx descriptor status functions

These functions are useful for applications and debugging. The netvsc PMD also transparently handles the rx/tx descriptor functions for underlying VF device. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 3 +++ drivers/net/netvsc/hn_rxtx.c | 39

[dpdk-dev] [PATCH v2 4/4] bus/vmbus: improve debug output

Make debug output more compact. Don't print pending size or interrupt mask for the transmit side (not applicable). Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/vmbus_channel.c | 42 +++ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH v2 3/4] net/netvsc: change tx/rx error handling

The PMD_TX_LOG and PMD_RX_LOG can hide errors since the debug log is typically disabled. Change the code to use PMD_DRV_LOG for errors. Under load, the ring buffer to the host can fill. Add some statistics to estimate the impact and see other errors. Signed-off-by: Stephen Hemminger --- drivers

[dpdk-dev] [PATCH v2 1/4] net/netvsc: support per-queue info requests

There is not a lot of info here from this driver. But worth supporting these additional info queries. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 ++ drivers/net/netvsc/hn_rxtx.c | 20 drivers/net/netvsc/hn_var.h| 2 ++ 3 files changed, 24

Re: [dpdk-dev] [PATCH v4 1/2] timer: move from common to Unix directory

On 2020-05-06 15:01 GMT+0300 Fady Bader wrote: [snip] > diff --git a/lib/librte_eal/unix/meson.build b/lib/librte_eal/unix/meson.build > index 5734f26ad..d13e3 100644 > --- a/lib/librte_eal/unix/meson.build > +++ b/lib/librte_eal/unix/meson.build > @@ -4,4 +4,5 @@ > sources += files( > '

Re: [dpdk-dev] [EXT] Re: input port in mbuf

Fine. Is there another location or option to save this information? Regards, Liron -Original Message- From: Stephen Hemminger Sent: Wednesday, 6 May 2020 22:43 To: Liron Himi Cc: dpdk-dev Subject: [EXT] Re: [dpdk-dev] input port in mbuf External Email ---

Re: [dpdk-dev] [PATCH v4 2/2] timer: support EAL functions on Windows

Getting extremely volatile results from get_tsc_hz(). Here's what I get from 10 successive calls: freq=266000 freq=322000 freq=374000 freq=387000 freq=383000 freq=406000 freq=337000 freq=382000 freq=737000 freq=497000 Please see the last comment for the rea

Re: [dpdk-dev] input port in mbuf

On Wed, 6 May 2020 19:21:30 + Liron Himi wrote: > Hi, > > We need to save the input port in the mbuf in order to return the buffer to > the right hw pool. > For now we use the 'port' in the mbuf as it is supposed to be for this exact > purpose. > But we noticed that some applications are o

[dpdk-dev] [PATCH 7/7] app/proc-info: provide way to request info on owned ports

There are cases where a port maybe owned by another (failsafe, netvsc, bond); but currently proc-info has no way to look at stats of those ports. This patch provides way for the user to explictly ask for these ports. If no portmask is given the output is unchanged; it only shows the top level port

[dpdk-dev] [PATCH 5/7] app/proc-info: hide crypto-context display

If crypto context is not present, no point in displaying it. Also fix spelling error. Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 2f74cbf462d5..bb0e0cbe9e6e 10

[dpdk-dev] [PATCH 6/7] app/proc-info: dump rx and tx descriptor info

Many drivers will report per queue info for both rx and tx as well as how many descriptors are in use. Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 79 1 file changed, 66 insertions(+), 13 deletions(-) diff --git a/app/proc-info/main.c

[dpdk-dev] [PATCH 3/7] app/proc-info: hide EAL info messages

The DPDK EAL info messages at the start of a diagnostic application are not helpful to end user. Suppress them by setting log-level by default. Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/proc-info/m

[dpdk-dev] [PATCH 4/7] app/proc-info: add more info to show_ports

Revise the display of port information to include more data and be more human friendly. * Display units for port speed, and decode link fields. * Show driver and device information * Show MAC address * Show flow control information * Combine lines if possible Signed-off-by: Stephen Hemm

[dpdk-dev] rte_ring work

Hi Konstantin, Just to make sure we are coordinating the work on rte_ring, I plan to get the following things done for 20.08. Please let me know if you have any comments. 1) Remove experimental tag on rte_ring_xxx_elem APIs - they have been around for 2 releases now. 2) Make the legacy

[dpdk-dev] [PATCH 0/7] proc-info enhancements

The current proc-info command is useful for diagnosing issues with external DPDK applications, but the display is limited and somewhat ugly. This patchset adds some enhancements which show more info and suppress unnecessary stuff. Before: EAL: Detected 4 lcore(s) EAL: Detected 1 NUMA nodes EAL: M

[dpdk-dev] [PATCH 2/7] app/proc-info: eliminate useless borders

Printing extra borders does not improve readability, and is just unnecessary. Putting TSC hz in header also makes no sense here. Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 35 +++ 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/app/

[dpdk-dev] [PATCH 1/7] app/proc-info: remove unused logtype #define

This logtype is defined but never used. Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab438..69e3000616c0 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -39,

[dpdk-dev] [PATCH 4/4] bus/vmbus: improve debug output

Make debug output more compact. Don't print pending size or interrupt mask for the transmit side (not applicable). Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/vmbus_channel.c | 42 +++ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH 2/4] net/netvsc: implement rx/tx descriptor status functions

These functions are useful for applications and debugging. The netvsc PMD also transparently handles the rx/tx descriptor functions for underlying VF device. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 3 +++ drivers/net/netvsc/hn_rxtx.c | 39

[dpdk-dev] [PATCH 0/4] net/netvsc: diagnostic enhancements

This patch set is based on top of my previous netvsc PMD bug fixes. It provides additional standard diagnostic hooks for queue info and improves the debug output. Stephen Hemminger (4): net/netvsc: support per-queue info requests net/netvsc: implement rx/tx descriptor status functions net/ne

[dpdk-dev] [PATCH 3/4] net/netvsc: change tx/rx error handling

The PMD_TX_LOG and PMD_RX_LOG can hide errors since the debug log is typically disabled. Change the code to use PMD_DRV_LOG for errors. Under load, the ring buffer to the host can fill. Add some statistics to estimate the impact and see other errors. --- drivers/net/netvsc/hn_ethdev.c | 1 + dri

[dpdk-dev] [PATCH 1/4] net/netvsc: support per-queue info requests

There is not a lot of info here from this driver but worth supporting the standard values for number of descriptors and offloads flags. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 ++ drivers/net/netvsc/hn_rxtx.c | 20 drivers/net/netvsc/hn_var

[dpdk-dev] input port in mbuf

Hi, We need to save the input port in the mbuf in order to return the buffer to the right hw pool. For now we use the 'port' in the mbuf as it is supposed to be for this exact purpose. But we noticed that some applications are override it with the destination port. What should be the right beha

Re: [dpdk-dev] [PATCH 2/2] net/tap: use netlink extended ack support

On 4/27/2020 12:32 PM, Andrzej Ostruszka [C] wrote: > On 25/04/2020 01:36, Stephen Hemminger wrote: >> In recent Linux kernels, there is support for extended acknowledgement >> to netlink messages. This is quite useful for diagnosing errors >> in configuration in the kernel with TAP. >> >> Signed-o

Re: [dpdk-dev] [PATCH 0/2] net/tap: simplfication and servicabilty improvements

On 4/25/2020 2:14 PM, Wiles, Keith wrote: > > >> On Apr 24, 2020, at 6:36 PM, Stephen Hemminger >> wrote: >> >> These are a couple of small fixes to the TAP driver. The first makes it >> more robust to random signals, and the second one adds better error >> reporting. >> >> Stephen Hemminger (2

[dpdk-dev] [PATCH] net/mlx5: fix TxQ release debug log timing

Program received signal SIGSEGV, Segmentation fault. 0x008ef7c4 in mlx5_tx_queue_release (dpdk_txq=0x17ce01680) at drivers/net/mlx5/mlx5_txq.c:302 301 mlx5_txq_release(ETH_DEV(priv), i); 302 DRV_LOG(DEBUG, "port %u removing Tx queue %u from list", 303 PORT_ID(priv), txq->idx); The p

[dpdk-dev] [PATCH v2] net/ring: fix eth_dev device pointer on allocation

When a net_ring device is allocated, its device pointer is not set before calling rte_eth_dev_probing_finish, which is incorrect. The following: commit: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") commit: a6992e961050 ("net/ring: set ethernet device field") already fixed the s

[dpdk-dev] [PATCH v2] event/dsw: fix enqueue burst return value

From: Yuri Chipchev The returned number from rte_event_enqueue_*() wouldn't include events marked with RTE_EVENT_OP_RELEASE. Fixes: 1c8e3caa3 ("event/dsw: add event scheduling and device start/stop") Cc: sta...@dpdk.org Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- v2: - update com

Re: [dpdk-dev] [PATCH] net/tap: fix crash from unitialized memory in rte_flow_destroy

On 5/5/2020 9:09 AM, Ferruh Yigit wrote: > On 5/1/2020 5:19 PM, Stephen Hemminger wrote: >> On Fri, 1 May 2020 17:01:40 +0100 >> Ferruh Yigit wrote: >> >>> On 4/27/2020 10:39 PM, Stephen Hemminger wrote: The TAP driver does not initialize all the elements of the rte_flow structure. This

Re: [dpdk-dev] [PATCH v1 0/6] ethdev: allow unknown link speed

On 4/27/2020 10:57 AM, Ivan Dyukov wrote: > This is initial patchset which introduces UNKNOWN speed to dpdk > applications. Also it contains changes related to printf formating. > Patchset contains changes for app/ and doc/ folders. > examples/ folder will be provided later. > > Also I can see t

Re: [dpdk-dev] [PATCH v1 5/6] doc: update sample app with unknown speed

On 5/3/2020 2:57 PM, Andrew Rybchenko wrote: > On 5/2/20 10:35 PM, Ivan Dyukov wrote: >> 01.05.2020 16:28, Andrew Rybchenko пишет: >>> On 4/27/20 12:57 PM, Ivan Dyukov wrote: Signed-off-by: Ivan Dyukov ---   doc/guides/sample_app_ug/link_status_intr.rst | 3 ++-   1 file changed

Re: [dpdk-dev] [dpdk-stable] [PATCH v1 2/3] net/ring: fix eth_dev device pointer on allocation

On 06/05/20 14:43 +0100, Ferruh Yigit wrote: > On 5/6/2020 1:33 PM, Gaëtan Rivet wrote: > > On 06/05/20 12:48 +0100, Ferruh Yigit wrote: > >> On 5/5/2020 8:10 PM, Gaetan Rivet wrote: > >>> When a net_ring device is allocated, its device pointer is not set > >>> before calling rte_eth_dev_probing_fi

Re: [dpdk-dev] [PATCH 2/2] bus/pci: cleanup private symbols

On 06/05/20 14:43 +0200, David Marchand wrote: > Internal symbols do not need the rte_ prefix. > Some symbols do not need to be exposed in the private header and have > been made static. > > Fixes: c752998b5e2e ("pci: introduce library and driver") > > Signed-off-by: David Marchand For this pat

Re: [dpdk-dev] [PATCH v1 1/3] net/failsafe: avoid crash on malformed eth_dev

On 5/5/2020 8:10 PM, Gaetan Rivet wrote: > Some PMD do not respect the eth_dev API when allocating their > rte_eth_dev. As a result, on device add event resulting from > rte_eth_dev_probing_finish() call, the eth_dev processed is incomplete. > > The segfault is a good way to focus the developer on

Re: [dpdk-dev] [PATCH v1 3/3] net/failsafe: fix default service proxy state

On 5/5/2020 8:10 PM, Gaetan Rivet wrote: > The service proxy is initialized at 0. This is assuming that all of > its fields are invalid at 0. The issue is that a file descriptor at 0 is a > valid one. > > The value -1 is used as sentinel during cleanup. Initialize the RX proxy > file descriptor to

Re: [dpdk-dev] [PATCH v5 1/5] app/flow-perf: add flow performance skeleton

On 5/6/20 8:07 PM, Wisam Monther wrote: >> -Original Message- >> From: Andrew Rybchenko >> Sent: Wednesday, May 6, 2020 5:26 PM >> To: Wisam Monther ; dev@dpdk.org; Jack Min >> ; Thomas Monjalon ; >> jerinjac...@gmail.com; gerlitz...@gmail.com; l@epfl.ch; >> ajit.khapa...@broadcom.com

[dpdk-dev] [PATCH v2] test/service: add perf test for service on app lcore

This commit adds a basic test to check the cycle cost of related to calling into a service. Signed-off-by: Harry van Haaren --- v2: - Add space at start of output (Phil Yang) - Fix compile error on older GCCs (David Marchand) --- app/test/test_service_cores.c | 13 - 1 file change

[dpdk-dev] [PATCH] net/mlx5: support match on GTP flags

This patch adds to MLX5 PMD the support of matching on GTP header item v_pt_rsv_flags. This item is contained in 1 byte of the format: --- | bit | 0 - 2 | 3 | 4 | 5 | 6 | 7 | |-| | value | Version | PT | Res |

  1   2   3   >