Re: [dpdk-dev] Regarding rte_eth_rx_burst

2020-05-10 Thread Wang, Haiyue
> -Original Message- > From: Prashant Upadhyaya > Sent: Monday, May 11, 2020 13:58 > To: Wang, Haiyue > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] Regarding rte_eth_rx_burst > > Thanks Wang ! > ...which begs the proverbial question -- is this a bug or a feature ? > I would say it is a bu

[dpdk-dev] [PATCH] net/octeontx2: fix minimum length to SMQ config

2020-05-10 Thread Sunil Kumar Kori
NIX exposes NIX_AF_SMQ(0..511)_CFG to configure minimum length of the packet which is being used for zero padding if packet is less than configured value. Setting it to default minimum length i.e. 60 bytes. Fixes: ec8ddd4fb1be ("net/octeontx2: restructure TM helper functions") Signed-off-by: Sun

Re: [dpdk-dev] [PATCH v3 2/2] crypto/dpaa_sec: improve error handling

2020-05-10 Thread Hemant Agrawal (OSS)
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v3 1/2] crypto/dpaa2_sec: improve error handling

2020-05-10 Thread Hemant Agrawal (OSS)
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-10 Thread Ray Kinsella
Hi Akhil, I didn't see this - checking again. Ray K On 09/05/2020 22:11, Akhil Goyal wrote: > Hi Ray/Arek, > > I still see Incompatible cryptodev even after update in the abignore list. > I checked it with ./devtools/validate-abi.sh > NOTICE: ABI may be incompatible, check reports/logs for deta

Re: [dpdk-dev] Regarding rte_eth_rx_burst

2020-05-10 Thread Prashant Upadhyaya
Thanks Wang ! ...which begs the proverbial question -- is this a bug or a feature ? I would say it is a bug as the polling for 1 mbuf works for the other PMD's, worse still the setting to zero is done in a quiet manner leading to entire rx blockage if the caller keeps calling with polling for 1 mbu

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang

2020-05-10 Thread Xing, Beilei
> -Original Message- > From: Xu, Ting > Sent: Monday, May 11, 2020 6:25 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; sta...@dpdk.org > Subject: [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang > > When set DCB in testpmd by clang, the

[dpdk-dev] [PATCH v2] crypto/caam_jr: fix wrong check of fd

2020-05-10 Thread wangyunjian
From: Yunjian Wang Zero is a valid fd. It will fail to check the fd if the fd is zero. The "job_ring->uio_fd" is an fd, so define it as "int". Fixes: e7a45f3cc245 ("crypto/caam_jr: add UIO specific operations") Fixes: a5e1018d5e67 ("crypto/caam_jr: add routines to configure HW") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH] net/ice: fix uninitialized scalar variable

2020-05-10 Thread Ye Xiaolong
On 05/06, Qi Zhang wrote: >Fix coverity defect due to uninitialized scalar variable. > >Coverity issue: 357763 > >Fixes: 47d460d63233 ("net/ice: rework switch filter") >Cc: sta...@dpdk.org > >Signed-off-by: Qi Zhang >--- > drivers/net/ice/ice_switch_filter.c | 1 + > 1 file changed, 1 insertion(+)

Re: [dpdk-dev] [PATCH v2] net/igc: remove some useless log

2020-05-10 Thread Ye Xiaolong
On 05/07, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >Some log will always be printed when the device is initialized >and shut down, which will mislead users and should be removed. > >Fixes: 746664d546fb (net/igc: implement flow API) >Cc: sta...@dpdk.org > >Signed-off-by: Alvin Zhang >---

Re: [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error

2020-05-10 Thread Ye Xiaolong
On 05/07, Wei Zhao wrote: >The dummy packet for pppoe-ipv6 has an error, we should >use 0x3b for next header in ipv6 header in the dummy packet, >or some case can not be download, such as: > >"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / >end actions vf id 1 / end" > >Fixes: 55d61fb27a5e ("n

Re: [dpdk-dev] [PATCH] net/iavf: fix rte flow error log issue

2020-05-10 Thread Ye Xiaolong
On 05/09, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Guo, Jia >> Sent: Saturday, May 9, 2020 4:59 AM >> To: Xing, Beilei ; Ye, Xiaolong >> ; Yang, Qiming ; Wu, >> Jingjing >> Cc: Zhang, Qi Z ; dev@dpdk.org; Lu, Wenzhuo >> ; Guo, Jia >> Subject: [PATCH] net/iavf: fix rte flow e

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix link state timing issue on fiber ports

2020-05-10 Thread Ye Xiaolong
On 05/08, Phil Yang wrote: >In ixgbe_dev_link_update_share(), if the media type is fiber and the >link is down, a flag (IXGBE_FLAG_NEED_LINK_CONFIG) is set. A callback >to ixgbe_dev_setup_link_thread_handler() is scheduled which should >try to set up the link and clear the flag afterwards. This fla

Re: [dpdk-dev] [dpdk-dev v2] net/iavf: fix input set for rss hash

2020-05-10 Thread Ye Xiaolong
On 05/09, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Guo, Jia >> Sent: Sunday, May 10, 2020 3:30 AM >> To: Xing, Beilei ; Zhang, Qi Z ; >> Wu, Jingjing >> Cc: Iremonger, Bernard ; Ye, Xiaolong >> ; dev@dpdk.org; Guo, Jia >> Subject: [dpdk-dev v2] net/iavf: fix input set for rs

[dpdk-dev] [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang

2020-05-10 Thread Ting Xu
When set DCB in testpmd by clang, there is a segmentation fault. It is because the local variable rss_conf in get_eth_dcb_conf() is not cleared, so that the pointer member variable rss_key has a random address, which leads to an error in the following processing. This patch initialized the local va

Re: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd

2020-05-10 Thread wangyunjian
> -Original Message- > From: Gagandeep Singh [mailto:g.si...@nxp.com] > Sent: Sunday, May 10, 2020 1:54 PM > To: wangyunjian ; dev@dpdk.org; Akhil Goyal > > Cc: Hemant Agrawal ; Lilijun (Jerry) > ; xudingke ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong che

Re: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode

2020-05-10 Thread Zhao1, Wei
Hi, Guinan > -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Friday, May 8, 2020 4:30 PM > To: dev@dpdk.org > Cc: Sun, GuinanX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control > mode > > The register autoneg can't be update

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-05-10 Thread Pavan Nikhilesh Bhagavatula
Hi Vipin, >Hi Pavan, > >snipped >> > >> >Should we check & warn the user if >> >1. port speed mismatch >> >2. on different NUMA >> >3. port pairs are physical and vdev like tap, and KNI (performance). >> > >> >> Sure, it can be a separate patch as it will be applicable for multiple >examples. >I b

Re: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM

2020-05-10 Thread Pavan Nikhilesh Bhagavatula
>> From: Pavan Nikhilesh >> >> Merge crc32 hash calculation public API headers for x86 and ARM, >> split implementations of x86 and ARM into their respective private >> headers. >> This reduces the ifdef code clutter while keeping current ABI intact. >> >> Although we install `rte_crc_arm64.h` it

Re: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM

2020-05-10 Thread Pavan Nikhilesh Bhagavatula
>> Subject: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and >ARM >> >> From: Pavan Nikhilesh >> >> Merge crc32 hash calculation public API headers for x86 and ARM, split >> implementations of x86 and ARM into their respective private >headers. >> This reduces the ifdef code clutter while

Re: [dpdk-dev] [PATCH v5 00/18] update and simplify telemetry library.

2020-05-10 Thread Thomas Monjalon
30/04/2020 18:01, Ciara Power: > This patchset extensively reworks the telemetry library adding new > functionality and simplifying much of the existing code, while > maintaining backward compatibility. Applied, thanks for the nice work. Few notes: - I did few minor cleanups in documentation and

Re: [dpdk-dev] [EXT] Re: [PATCH v4] mempool/octeontx2: add devargs to lock ctx in cache

2020-05-10 Thread Pavan Nikhilesh Bhagavatula
>01/05/2020 12:21, Pavan Nikhilesh Bhagavatula: >> >Subject: [dpdk-dev] [PATCH v4] mempool/octeontx2: add devargs >to >> >lock ctx in cache >> > >> >From: Pavan Nikhilesh >> > >> >Add device arguments to lock NPA aura and pool contexts in NDC >cache. >> >The device args take hexadecimal bitmask wh

Re: [dpdk-dev] [PATCH v5 15/18] lib: add telemetry as eal dependency

2020-05-10 Thread Thomas Monjalon
30/04/2020 18:01, Ciara Power: > This patch moves telemetry further down the build, and adds it as a > dependency for EAL. Telemetry V2 is now configured to build by default, > and the legacy support is built when the telemetry config flag is set. > > Telemetry now has EAL flags, shown below: > "-

[dpdk-dev] [PATCH v2 2/2] doc: support IPsec Multi-buffer lib v0.54

2020-05-10 Thread Pablo de Lara
Updated SNOW3G and KASUMI PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/kasumi.rst | 6 +++--- doc/guides/cryptodevs/snow3g.rst | 6 +++--- doc/guides/rel_notes/release_20_

[dpdk-dev] [PATCH v2 1/2] crypto/zuc: support IPSec Multi-buffer lib v0.54

2020-05-10 Thread Pablo de Lara
The latest version of the Intel IPSec Multi-buffer library adds an API to authenticate multiple buffers in parallel. The PMD is modified to use this API, improving performance of the ZUC-EIA3 algorithm. Signed-off-by: Pablo de Lara --- v2: - Simplified logic in process_hash_op per Akhil's commen

Re: [dpdk-dev] [PATCH 1/2] crypto/zuc: support IPSec Multi-buffer lib v0.54

2020-05-10 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Saturday, May 9, 2020 8:05 PM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] crypto/zuc: support IPSec Multi-buffer lib > v0.54 > > Hi Pablo, > > > +#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)

Re: [dpdk-dev] Regarding rte_eth_rx_burst

2020-05-10 Thread Wang, Haiyue
> -Original Message- > From: dev On Behalf Of Prashant Upadhyaya > Sent: Sunday, May 10, 2020 22:06 > To: dev@dpdk.org > Subject: [dpdk-dev] Regarding rte_eth_rx_burst > > Hi, > > I recently started using X722 NIC which uses i40 PMD of DPDK. > I am on DPDK 20.02. > I am seeing that when

[dpdk-dev] Regarding rte_eth_rx_burst

2020-05-10 Thread Prashant Upadhyaya
Hi, I recently started using X722 NIC which uses i40 PMD of DPDK. I am on DPDK 20.02. I am seeing that when I call the rte_eth_rx_burst with last argument as 1 (polling for 1 mbuf), then I am not receiving data via repeated calls. When I go for calls to rte_eth_rx_burst with last argument as 32, t

Re: [dpdk-dev] [PATCH] net/tap: fix compilation issue with old kernels

2020-05-10 Thread Raslan Darawsheh
reference to glibc which is missing from commit log: https://github.com/bminor/glibc/commit/f9b437d5efce93800b51ad2a437c8b1c9616bf80 Kindest regards, Raslan Darawsheh > -Original Message- > From: Raslan Darawsheh > Sent: Thursday, May 7, 2020 12:46 PM > To: ferruh.yi...@intel.com > Cc: d

[dpdk-dev] [PATCH] net/tap: fix compilation issue glibc < 2.24

2020-05-10 Thread Raslan Darawsheh
When trying to compile with glibc < 2.24 that doesn't support SOL_NETLINK it will cause compilation failure: drivers/net/tap/tap_netlink.c:70:17: error: 'SOL_NETLINK' undeclared (first use in this function) setsockopt(fd, SOL_NETLINK, NETLINK_EXT_ACK, &one, sizeof(one)); Fixes: b9cf1a882820 ("

[dpdk-dev] [PATCH v6 3/3] timer: support EAL functions on Windows

2020-05-10 Thread Fady Bader
Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 86 + lib/librte_eal/windows/include/rte_o

[dpdk-dev] [PATCH v6 2/3] eal: proc type function for Windows

2020-05-10 Thread Fady Bader
Implementation of rte_proc_type_t for Windows as it is needed for Windows eal timer. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index d084606a6..feee91244 100644

[dpdk-dev] [PATCH v6 0/3] eal timer split and implementation for Windows

2020-05-10 Thread Fady Bader
This patchset splits OS dependent EAL timer functions and implements them for windows. v2: * fixing styles and correctness errors. v3: * fixing correctness, get_tsc_freq was reimplemented. v4: * rebasing to the new version of "Windows basic memory management" series. * fixing styl

[dpdk-dev] [PATCH v6 1/3] timer: move from common to Unix directory

2020-05-10 Thread Fady Bader
Eal common timer doesn't compile under Windows. Compilation log: error LNK2019: unresolved external symbol nanosleep referenced in function rte_delay_us_sleep error LNK2019: unresolved external symbol get_tsc_freq referenced in function set_tsc_freq error LNK2019: unresolved external symbol sleep

Re: [dpdk-dev] [PATCH v2 4/4] event/octeontx2: fix build for O1 optimization

2020-05-10 Thread Jerin Jacob
On Fri, May 8, 2020 at 10:52 PM Ananyev, Konstantin wrote: > > > > > Subject: [PATCH v2 4/4] event/octeontx2: fix build for O1 optimization > > > > Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using > > gcc 7.3.0 > > > > Build error > > In file included from .../drivers/event/octeontx2

Re: [dpdk-dev] [PATCH v2 2/4] mempool/octeontx2: fix build for gcc O1 optimization

2020-05-10 Thread Jerin Jacob
On Fri, May 8, 2020 at 10:16 PM Ferruh Yigit wrote: > > Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using > gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) > > Build error: > In file included from .../drivers/mempool/octeontx2/otx2_mempool.h:13, > from .../drivers/mempool/o

[dpdk-dev] [PATCH] net/mlx5: prefer DevX API to create Rx objects

2020-05-10 Thread Dekel Peled
Currently, DevX API is used to create Rx objects (RQ, RQT, TIR) only if LRO or hairpin features are enabled on this RQ. This patch uses DevX API by default, if DevX is supported and can be used. Otherwise, Verbs API is used. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/net/mlx5

Re: [dpdk-dev] [PATCH] net/mlx5: fix match on empty VLAN item in DV mode

2020-05-10 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Tuesday, May 5, 2020 3:58 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix match on empty VLAN item in DV mode > > In existing implementation, using wild

Re: [dpdk-dev] [PATCH] common/octeontx2: upgrade mbox definition to version 7

2020-05-10 Thread Jerin Jacob
On Thu, May 7, 2020 at 2:27 PM wrote: > > From: Jerin Jacob > > Upgrade mailbox definitions to version 0x0007 of kernel AF driver. > > Signed-off-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks

Re: [dpdk-dev] [PATCH v3 7/7] bus/pci: support Windows with bifurcated drivers

2020-05-10 Thread Thomas Monjalon
08/05/2020 00:50, Dmitry Kozlyuk: > On 2020-05-07 15:16 GMT+0300 tal...@mellanox.com wrote: > > +static > > +int get_device_pci_address(HDEVINFO hDevInfo, > > + PSP_DEVINFO_DATA pDeviceInfoData, struct rte_pci_addr *addr) > > Result type should be on a separate line (that is, "static int "). >

Re: [dpdk-dev] [PATCH] net/bnx2x: add Rx desc MTU segment limitation

2020-05-10 Thread Jerin Jacob
On Tue, May 5, 2020 at 8:38 AM Rasesh Mody wrote: > > Add Rx descriptor limit for number of segments per MTU. > PMD doesn't support Jumbo Rx scatter gather hence set 1 segment per > MTU. Some applciations can adjust mbuf_size based on this value. > For others PMD detects the condition where Rx pac

Re: [dpdk-dev] [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid comparison

2020-05-10 Thread Ophir Munk
Thanks for clarifying the INTERNAL/EXPERIMENTAL difference. > -Original Message- > From: Thomas Monjalon > Sent: Thursday, May 7, 2020 11:08 PM > To: Ophir Munk > Cc: dev@dpdk.org; David Marchand ; Ray > Kinsella ; Matan Azrad ; Raslan > Darawsheh > Subject: Re: [PATCH v3 1/2] common/ml

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup

2020-05-10 Thread Jerin Jacob
On Wed, May 6, 2020 at 8:13 AM Rasesh Mody wrote: > > Hi, > > >From: Thomas Monjalon > >Sent: Tuesday, May 05, 2020 2:15 AM > > > >05/05/2020 10:59, Ferruh Yigit: > >> On 5/5/2020 7:44 AM, Jerin Jacob wrote: > >> > On Tue, May 5, 2020 at 8:39 AM Rasesh Mody > >wrote: > >> >> > >> >> Some applica