Re: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item

2020-06-17 Thread Dekel Peled
Hi, Kind reminder, please respond on the recent correspondence so we can conclude this issue. Regards, Dekel > -Original Message- > From: Dekel Peled > Sent: Wednesday, June 3, 2020 3:11 PM > To: Ori Kam ; Adrien Mazarguil > > Cc: Andrew Rybchenko ; > ferruh.yi...@intel.com; john.mcna

Re: [dpdk-dev] [PATCH v1 2/2] vhost: introduce async enqueue for split ring

2020-06-17 Thread Liu, Yong
Thanks, Patrick. Some comments are inline. > -Original Message- > From: dev On Behalf Of patrick...@intel.com > Sent: Thursday, June 11, 2020 6:02 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > ; Wang, Zhihong ; Ye, > Xiaolong > Cc: Fu, Patrick ; Jiang, Cheng1 > ; Liang

[dpdk-dev] [PATCH v10 2/2] timer: support EAL functions on Windows

2020-06-17 Thread Fady Bader
Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 93 + lib/librte_eal/windows/include/rte_o

[dpdk-dev] [PATCH v10 0/2] eal timer split and implementation for Windows

2020-06-17 Thread Fady Bader
This patchset splits OS dependent EAL timer functions and implements them for windows. v2: * fixing styles and correctness errors. v3: * fixing correctness, get_tsc_freq was reimplemented. v4: * rebasing to the new version of "Windows basic memory management" series. * fixing styl

[dpdk-dev] [PATCH v10 1/2] timer: move from common to Unix directory

2020-06-17 Thread Fady Bader
Eal common timer doesn't compile under Windows. Compilation log: error LNK2019: unresolved external symbol nanosleep referenced in function rte_delay_us_sleep error LNK2019: unresolved external symbol get_tsc_freq referenced in function set_tsc_freq error LNK2019: unresolved external symbol sleep

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: move getter functions from net to common

2020-06-17 Thread Matan Azrad
From: Ori Kam: > From: Ophir Munk > > Getter functions such as: 'mlx5_os_get_ctx_device_name', > 'mlx5_os_get_ctx_device_path', 'mlx5_os_get_dev_device_name', > 'mlx5_os_get_umem_id' are implemented under net directory. To enable > additional devices (e.g. regex, vdpa) to access these getter f

Re: [dpdk-dev] [PATCH v3 05/12] net/ice: add stop flag for device start / stop

2020-06-17 Thread Yang, Qiming
> -Original Message- > From: Xu, Ting > Sent: Tuesday, June 16, 2020 20:41 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Wu, Jingjing ; Xing, Beilei > ; Kovacevic, Marko ; > Mcnamara, John ; Ye, Xiaolong > > Subject: [PATCH v3 05/12] net/ice: add stop flag for device start /

Re: [dpdk-dev] [PATCH v3 02/12] net/ice: complete device info get in DCF

2020-06-17 Thread Yang, Qiming
> -Original Message- > From: Xu, Ting > Sent: Tuesday, June 16, 2020 20:41 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Wu, Jingjing ; Xing, Beilei > ; Kovacevic, Marko ; > Mcnamara, John ; Ye, Xiaolong > > Subject: [PATCH v3 02/12] net/ice: complete device info get in DCF >

[dpdk-dev] [PATCH 1/2] net/mlx5: move getter functions from net to common

2020-06-17 Thread Ori Kam
From: Ophir Munk Getter functions such as: 'mlx5_os_get_ctx_device_name', 'mlx5_os_get_ctx_device_path', 'mlx5_os_get_dev_device_name', 'mlx5_os_get_umem_id' are implemented under net directory. To enable additional devices (e.g. regex, vdpa) to access these getter functions they are moved under

[dpdk-dev] [PATCH 2/2] common/mlx5: move doorbell record to common

2020-06-17 Thread Ori Kam
The creation of DBR can be used by a number of different Mellanox PMDs. for example RegEx / Net / VDPA. This commits moves the DBR creation and relase functions to common folder. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/linux/mlx5_common_os.c | 1 +

Re: [dpdk-dev] [PATCH v3 09/12] net/ice: add queue start and stop for DCF

2020-06-17 Thread Yang, Qiming
> -Original Message- > From: Xu, Ting > Sent: Tuesday, June 16, 2020 20:41 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Wu, Jingjing ; Xing, Beilei > ; Kovacevic, Marko ; > Mcnamara, John ; Ye, Xiaolong > > Subject: [PATCH v3 09/12] net/ice: add queue start and stop for DCF

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

2020-06-17 Thread Matan Azrad
HI Maxime From: Maxime Coquelin: > On 6/17/20 1:04 PM, Matan Azrad wrote: > > >>> Don’t you think that only enabled queues must be fully initialized > >>> when > >> their status is changed from disabled to enabled? > >>> So, you can assume that disabled queues can stay "not fully > >>> initializ

Re: [dpdk-dev] [PATCH v3 10/12] net/ice: enable stats for DCF

2020-06-17 Thread Yang, Qiming
> -Original Message- > From: Xu, Ting > Sent: Tuesday, June 16, 2020 20:41 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Wu, Jingjing ; Xing, Beilei > ; Kovacevic, Marko ; > Mcnamara, John ; Ye, Xiaolong > > Subject: [PATCH v3 10/12] net/ice: enable stats for DCF > > From: Q

Re: [dpdk-dev] [PATCH 00/10] net/ice: base code update for 20.08 batch 2

2020-06-17 Thread Yang, Qiming
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, June 11, 2020 16:43 > To: Yang, Qiming > Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > > Subject: [PATCH 00/10] net/ice: base code update for 20.08 batch 2 > > Main changes: > 1. support outer IP filter for GTPU (include IPv6)

Re: [dpdk-dev] [PATCH v1 1/2] vhost: introduce async data path registration API

2020-06-17 Thread Liu, Yong
Thanks, Patrick. So comments are inline. > -Original Message- > From: dev On Behalf Of patrick...@intel.com > Sent: Thursday, June 11, 2020 6:02 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > ; Wang, Zhihong ; Ye, > Xiaolong > Cc: Fu, Patrick ; Jiang, Cheng1 > ; Liang,

[dpdk-dev] [PATCH v4 2/2] net/iavf: add RSS support for ipv4 ipv6 mix of GTP

2020-06-17 Thread Junfeng Guo
RSS for GTP with outer & inner ipv4 & ipv6 combination are supported in this patch, so that we can process RSS based on inner 5 tuples or 3 tuples of all the cases below of GTP packets: 1. ipv4 (outer) + ipv4 (inner) 2. ipv4 (outer) + ipv6 (inner) 3. ipv6 (outer) + ipv4 (inn

[dpdk-dev] [PATCH v4 1/2] net/ice: add RSS support for ipv4 ipv6 mix of GTP

2020-06-17 Thread Junfeng Guo
RSS for GTP with outer & inner ipv4 & ipv6 combination are supported in this patch, so that we can process RSS based on inner 5 tuples or 3 tuples of all the cases below of GTP packets: 1. ipv4 (outer) + ipv4 (inner) 2. ipv4 (outer) + ipv6 (inner) 3. ipv6 (outer) + ipv4 (inn

[dpdk-dev] [PATCH v4 0/2] add RSS support for ipv4 ipv6 mix of GTP on VF and PF

2020-06-17 Thread Junfeng Guo
RSS for GTP with outer & inner ipv4 & ipv6 combination are supported in this patchset, so that we can process RSS based on inner 5 tuples or 3 tuples of all the cases below of GTP packets: 1. ipv4 (outer) + ipv4 (inner) 2. ipv4 (outer) + ipv6 (inner) 3. ipv6 (outer) + ipv4 (

Re: [dpdk-dev] [PATCH 2/4] doc: remove build instructions where unneeded

2020-06-17 Thread Ajit Khaparde
On Wed, Jun 17, 2020 at 5:42 PM Thomas Monjalon wrote: > The build should be described only in few places, > in order to maintain up-to-date, accurate and detailed instructions. > This change is removing some of the unneeded repetitions. > > Signed-off-by: Thomas Monjalon > For the Broadcom PMD

[dpdk-dev] [PATCH v3 0/2] add RSS support for ipv4 ipv6 mix of GTP on VF and PF

2020-06-17 Thread Junfeng Guo
RSS for GTP with outer & inner ipv4 & ipv6 combination are supported in this patchset, so that we can process RSS based on inner 5 tuples or 3 tuples of all the cases below of GTP packets: 1. ipv4 (outer) + ipv4 (inner) 2. ipv4 (outer) + ipv6 (inner) 3. ipv6 (outer) + ipv4 (

[dpdk-dev] [PATCH v3 2/2] net/iavf: add RSS support for ipv4 ipv6 mix of GTP

2020-06-17 Thread Junfeng Guo
RSS for GTP with outer & inner ipv4 & ipv6 combination are supported in this patch, so that we can process RSS based on inner 5 tuples or 3 tuples of all the cases below of GTP packets: 1. ipv4 (outer) + ipv4 (inner) 2. ipv4 (outer) + ipv6 (inner) 3. ipv6 (outer) + ipv4 (inn

[dpdk-dev] [PATCH v3 1/2] net/ice: add RSS support for ipv4 ipv6 mix of GTP

2020-06-17 Thread Junfeng Guo
RSS for GTP with outer & inner ipv4 & ipv6 combination are supported in this patch, so that we can process RSS based on inner 5 tuples or 3 tuples of all the cases below of GTP packets: 1. ipv4 (outer) + ipv4 (inner) 2. ipv4 (outer) + ipv6 (inner) 3. ipv6 (outer) + ipv4 (inn

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: clock gettime call in throughput calculation

2020-06-17 Thread Honnappa Nagarahalli
Thanks Jerin for the feedback > -Original Message- > From: Jerin Jacob > Sent: Wednesday, June 17, 2020 10:16 AM > To: Honnappa Nagarahalli > Cc: dpdk-dev ; Ali Alnubani ; > orgerl...@mellanox.com; Wenzhuo Lu ; Beilei Xing > ; Bernard Iremonger ; > hemant.agra...@nxp.com; jer...@marvell.

Re: [dpdk-dev] [PATCH 2/4] doc: remove build instructions where unneeded

2020-06-17 Thread Zhoujian (jay)
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, June 18, 2020 8:42 AM > To: dev@dpdk.org > Cc: david.march...@redhat.com; bruce.richard...@intel.com; Nicolas Chautru > ; John McNamara ; > Marko Kovacevic ; Zhoujian (jay) > ; Ajit Khaparde ; > S

Re: [dpdk-dev] [PATCH] doc: fix typing error

2020-06-17 Thread Chautru, Nicolas
From: Sarosh Arif : > fixed typing error in doc/guides/tools/testbbdev.rst > > Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") > Signed-off-by: Sarosh Arif > --- > doc/guides/tools/testbbdev.rst | 2 +- Thanks. Acked-by: Nic Chautru > 1 file changed, 1 insertion(+), 1 de

Re: [dpdk-dev] [PATCH 2/4] doc: remove build instructions where unneeded

2020-06-17 Thread Chautru, Nicolas
From: Thomas Monjalon > The build should be described only in few places, in order to maintain up-to- > date, accurate and detailed instructions. > This change is removing some of the unneeded repetitions. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/bbdevs/fpga_5gnr_fec.rst |

Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant newline

2020-06-17 Thread Xiaoyu Min
On Wed, 20-06-17, 15:53, David Marchand wrote: > The DRV_LOG macro already appends a newline. > > Fixes: 46287eacc1b1 ("net/mlx5: introduce hash list") > Fixes: 860897d2895a ("net/mlx5: reorganize flow tables with hash list") > Fixes: e484e4032332 ("net/mlx5: optimize tag traversal with hash list"

Re: [dpdk-dev] [PATCH 0/4] one more step in makefiles deprecation

2020-06-17 Thread Stephen Hemminger
On Thu, 18 Jun 2020 02:42:14 +0200 Thomas Monjalon wrote: > Some "make" usages are cleaned up in the documentation, > and an inevitable deprecation warning is printed when using "make". > > > * > NOTE: Lots of docs must be converted to meson > build,

Re: [dpdk-dev] [PATCH v3 5/7] net/ixgbe: return unknown speed in status

2020-06-17 Thread Zhao1, Wei
Hi, ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, June 18, 2020 12:51 AM > To: i.dyu...@samsung.com; dev@dpdk.org; v.kurams...@samsung.com; > tho...@monjalon.net; david.march...@redhat.com; > arybche...@solarflare.com; Zhao1, Wei ; Guo, Jia > ; Xing, Beilei ; Yang, Q

[dpdk-dev] [PATCH 4/4] mk: add a paused deprecation warning before each build

2020-06-17 Thread Thomas Monjalon
DPDK 20.05 had some deprecation notes after "make config" and after the build. For DPDK 20.08, the config note is replaced with a warning before the config and before the build. After the warning, there is a pause which can be skipped with the variable MAKE_PAUSE. This deprecation process was disc

[dpdk-dev] [PATCH 2/4] doc: remove build instructions where unneeded

2020-06-17 Thread Thomas Monjalon
The build should be described only in few places, in order to maintain up-to-date, accurate and detailed instructions. This change is removing some of the unneeded repetitions. Signed-off-by: Thomas Monjalon --- doc/guides/bbdevs/fpga_5gnr_fec.rst | 7 +-- doc/guides/bbdevs/fpga_lte_f

[dpdk-dev] [PATCH 3/4] doc: update build instructions in the Linux guide

2020-06-17 Thread Thomas Monjalon
Before removing the "make" build system completely, the Linux guide instructions are made more concise and accurate. Some detailed explanations are also available in doc/guides/prog_guide/dev_kit_root_make_help.rst This is the swan song for makefile system, in order to have accurate information ba

[dpdk-dev] [PATCH 0/4] one more step in makefiles deprecation

2020-06-17 Thread Thomas Monjalon
Some "make" usages are cleaned up in the documentation, and an inevitable deprecation warning is printed when using "make". * NOTE: Lots of docs must be converted to meson build, configuration and installation layout, as soon as possible. Please HELP!

[dpdk-dev] [PATCH 1/4] doc: remove outdated guidelines for library addition

2020-06-17 Thread Thomas Monjalon
There was a doc about how to extend DPDK by adding a library. It could have been useful but was never updated, so it is lacking a lot of explanations about doxygen, meson, versioning, maintainership, etc. Anyway such guidelines should fit in the contributors guide. Better to completely remove this

Re: [dpdk-dev] [PATCH v9 2/2] timer: support EAL functions on Windows

2020-06-17 Thread Ranjit Menon
On 6/17/2020 2:39 AM, Fady Bader wrote: Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 91

Re: [dpdk-dev] [PATCH v2 3/4] devtools: add ppc64 in meson build test

2020-06-17 Thread David Christensen
Add cross-compilation support of a PPC target in the build test matrix. The CPU is defined as Power8, running as little endian. Signed-off-by: Thomas Monjalon Reviewed-by: David Christensen

Re: [dpdk-dev] [PATCH v2 2/4] devtools: allow non-standard toolchain in meson test

2020-06-17 Thread David Christensen
On 6/15/20 3:22 PM, Thomas Monjalon wrote: If a compiler is not found in $PATH, the compilation test is skipped. In some cases, the compiler could be found after extending $PATH in an environment configuration script (called by load-devel-config). The decision to skip is deferred to a later s

Re: [dpdk-dev] [PATCH v2 1/4] devtools: shrink cross-compilation test definition

2020-06-17 Thread David Christensen
On 6/15/20 3:22 PM, Thomas Monjalon wrote: Each cross-compilation case needs to define the target compiler and the meson cross file. Given the compiler is already defined in the cross file, the latter is enough. The function "build" is changed to accept a cross file alternatively to the compiler

Re: [dpdk-dev] [PATCH 3/4] devtools: add ppc64 in meson build test

2020-06-17 Thread David Christensen
16/06/2020 22:35, David Christensen: Thomas Monjalon wrote: This script supports only builds from x86 Linux so far. This patch is adding cross-compilation of ppc from x86, and it works fine. Which distro and packages are used for testing? I tried it with Ubuntu 20.04 but the cross-compiler is

Re: [dpdk-dev] [PATCH v5 5/8] drivers: ignore pmdinfogen generation for Windows

2020-06-17 Thread Dmitry Kozlyuk
On Tue, 9 Jun 2020 13:31:36 +0300 tal...@mellanox.com wrote: > From: Tal Shnaiderman > > pmdinfogen generation is currently unsupported for Windows. > The relevant part in meson.build is skipped. > > Signed-off-by: Tal Shnaiderman > --- > drivers/meson.build | 3 ++- > 1 file changed, 2 inse

Re: [dpdk-dev] [PATCH v5 7/8] bus/pci: introduce Windows support with stubs

2020-06-17 Thread Dmitry Kozlyuk
[snip] > @@ -345,3 +352,21 @@ rte_eal_init(int argc, char **argv) > rte_eal_mp_wait_lcore(); > return fctret; > } > + > +int > +rte_vfio_container_dma_map(__rte_unused int container_fd, > + __rte_unused uint64_t vaddr, > + __rte_unused uint64_t i

Re: [dpdk-dev] [PATCH v5 8/8] bus/pci: support Windows with bifurcated drivers

2020-06-17 Thread Dmitry Kozlyuk
[snip] > +#ifdef RTE_TOOLCHAIN_GCC > +#include This breaks cross-compilation because devpropdef.h is all-lowercase on Linux. > +DEFINE_DEVPROPKEY(DEVPKEY_Device_Numa_Node, 0x540b947e, 0x8b40, 0x45bc, > + 0xa8, 0xa2, 0x6a, 0x0b, 0x89, 0x4c, 0xbd, 0xa2, 3); > +#endif [snip] > +static int > +

Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant newline

2020-06-17 Thread Slava Ovsiienko
> -Original Message- > From: David Marchand > Sent: Wednesday, June 17, 2020 16:53 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Bing Zhao ; Jack Min > Subject: [PATCH] net/mlx5: remove redundant newline > > The DRV_LOG macro already append

Re: [dpdk-dev] [PATCH v3 2/2] doc: include config options in testpmd user guide

2020-06-17 Thread Thomas Monjalon
17/06/2020 20:21, Ferruh Yigit: > On 5/20/2020 4:20 AM, Dharmik Thakkar wrote: > > Update testpmd documentation to include RECORD configuration options, > > CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and > > CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS. > > > > Signed-off-by: Dharmik Thakkar > > Reviewed-b

[dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes

2020-06-17 Thread Sergey Lvov
It seems to be a typo Signed-off-by: Sergey Lvov --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 612a64599..3ef0df84a 100644 --- a/drivers/net/bon

Re: [dpdk-dev] [PATCH v3 2/2] doc: include config options in testpmd user guide

2020-06-17 Thread Ferruh Yigit
On 5/20/2020 4:20 AM, Dharmik Thakkar wrote: > Update testpmd documentation to include RECORD configuration options, > CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and > CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS. > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Phil Y

Re: [dpdk-dev] [PATCH] net/cxgbe: always enable HASH filter support

2020-06-17 Thread Ferruh Yigit
On 6/12/2020 11:10 PM, Rahul Lakkireddy wrote: > From: Karra Satwik > > Disable all unused firmware resources during init time to give > more resources for HASH (exact-match) filter region and always > request firmware to enable HASH filter support when resources > are available. > > Signed-off-

Re: [dpdk-dev] [PATCH v2 4/9] usertools/dpdk-pmdinfo: support python3 only

2020-06-17 Thread Neil Horman
On Wed, Jun 17, 2020 at 04:10:46PM +0100, Louise Kilheeney wrote: > Changed script to explicitly use python3 only to avoid > maintaining python 2. > > Cc: Neil Horman > > Signed-off-by: Louise Kilheeney Acked-by: Neil Horman > --- > usertools/dpdk-pmdinfo.py | 4 +--- > 1 file changed, 1 inse

Re: [dpdk-dev] [PATCH v3 7/7] net/ice: return unknown speed in status

2020-06-17 Thread Ferruh Yigit
On 6/15/2020 10:01 AM, Ivan Dyukov wrote: > rte_ethdev has declared new NUM_UNKNOWN speed which > could be used in case when no speed information is available and > link is up. NUM_NONE should be returned, if link is down. > > Signed-off-by: Ivan Dyukov > --- > drivers/net/ice/ice_ethdev.c | 5 +

Re: [dpdk-dev] [PATCH v3 6/7] net/i40e: return unknown speed in status

2020-06-17 Thread Ferruh Yigit
On 6/15/2020 10:01 AM, Ivan Dyukov wrote: > rte_ethdev has declared new NUM_UNKNOWN speed which > could be used in case when no speed information is available and > link is up. NUM_NONE should be returned, if link is down. > > Signed-off-by: Ivan Dyukov > --- > drivers/net/i40e/i40e_ethdev.c

Re: [dpdk-dev] [PATCH v3 5/7] net/ixgbe: return unknown speed in status

2020-06-17 Thread Ferruh Yigit
On 6/15/2020 10:01 AM, Ivan Dyukov wrote: > rte_ethdev has declared new NUM_UNKNOWN speed which > could be used in case when no speed information is available > > Signed-off-by: Ivan Dyukov > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > >

Re: [dpdk-dev] [PATCH v3 4/7] doc: update sample app with unknown speed

2020-06-17 Thread Ferruh Yigit
On 6/15/2020 10:01 AM, Ivan Dyukov wrote: > Add usage of rte_eth_link_format function to example > applications > > Signed-off-by: Ivan Dyukov > --- > doc/guides/sample_app_ug/link_status_intr.rst | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/sam

Re: [dpdk-dev] [PATCH v3 3/7] app: UNKNOWN link speed print format

2020-06-17 Thread Ferruh Yigit
On 6/15/2020 10:01 AM, Ivan Dyukov wrote: > Add usage of rte_eth_link_format function to example > applications > > Signed-off-by: Ivan Dyukov <...> > @@ -155,7 +155,7 @@ static void > app_ports_check_link(void) > { > uint32_t all_ports_up, i; > - > + char status_text[50]; I think

Re: [dpdk-dev] [PATCH v3 1/7] ethdev: allow unknown link speed

2020-06-17 Thread Ferruh Yigit
On 6/15/2020 10:01 AM, Ivan Dyukov wrote: > From: Thomas Monjalon > > When querying the link information, the link status is > a mandatory major information. > Other boolean values are supposed to be accurate: > - duplex mode (half/full) > - negotiation (auto/fixed) > > This API upda

Re: [dpdk-dev] [PATCH v3 2/7] ethdev: add a link status text representation

2020-06-17 Thread Ferruh Yigit
On 6/15/2020 10:01 AM, Ivan Dyukov wrote: > This commit add function which treat link status structure > and format it to text representation. If I am following correctly, the initial need was to escape from speed checks everytime loging link information caused by this new 'unknown' speed. And la

Re: [dpdk-dev] [EXT] RE: [RFC] mbuf: accurate packet Tx scheduling

2020-06-17 Thread Harman Kalra
On Wed, Jun 10, 2020 at 03:16:12PM +, Slava Ovsiienko wrote: > External Email > > -- > Hi, Harman > > > -Original Message- > > From: Harman Kalra > > Sent: Wednesday, June 10, 2020 16:34 > > To: Slava Ovsiienko > >

[dpdk-dev] DPDK Release Status Meeting 11/06/2020

2020-06-17 Thread Mcnamara, John
Minutes 11 June 2020 Agenda: * Meeting * Release Dates * Subtrees * OvS Participants: * Arm * Debian/Microsoft * Intel * Mellanox * Red Hat Meeting --- * Call for maintainers to follow up on patches that have stalled. * There are several patchset hanging around but n

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: clock gettime call in throughput calculation

2020-06-17 Thread Jerin Jacob
On Wed, Jun 17, 2020 at 8:13 PM Honnappa Nagarahalli wrote: > > The throughput calculation requires a counter that measures > passing of time. The PMU cycle counter does not do that. This It is not clear from git commit on why PMU cycle counter does not do that? On dpdk bootup, we are figuring o

[dpdk-dev] [PATCH v2 8/9] devtools: support python3 only

2020-06-17 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2. Cc: Neil Horman Cc: Ray Kinsella Signed-off-by: Louise Kilheeney Acked-by: Ray Kinsella --- devtools/update_version_map_abi.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/devtools/update_ve

[dpdk-dev] [PATCH v2 9/9] config/arm: support python3 only

2020-06-17 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2. Cc: Thomas Monjalon Signed-off-by: Louise Kilheeney --- v2: fixed python3 path. --- config/arm/armv8_machine.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/arm/armv8_machine.py b/config

[dpdk-dev] [PATCH v2 7/9] app/test: support python3 only

2020-06-17 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2. Signed-off-by: Louise Kilheeney --- v2: removed use of iter function as not needed for python3. --- app/test/autotest.py| 3 +-- app/test/autotest_data.py | 1 + app/test/autotest_runner.py | 19

[dpdk-dev] [PATCH v2 6/9] app/test-cmdline: support python3 only

2020-06-17 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2. Cc: Olivier Matz Signed-off-by: Louise Kilheeney --- app/test-cmdline/cmdline_test.py | 3 +-- app/test-cmdline/cmdline_test_data.py | 1 + mk/rte.sdktest.mk | 2 +- 3 files changed, 3 inserti

[dpdk-dev] [PATCH v2 3/9] usertools/dpdk-telemetry-client: support python3 only

2020-06-17 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maaintaining python 2. Cc: Kevin Laatz Signed-off-by: Louise Kilheeney --- usertools/dpdk-telemetry-client.py | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/usertools/dpdk-telemetry-client.py b/usert

[dpdk-dev] [PATCH v2 2/9] usertools/dpdk-devbind: support python3 only

2020-06-17 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2. Signed-off-by: Louise Kilheeney --- v2: removed check_output function as not required for python3. --- usertools/dpdk-devbind.py | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/us

[dpdk-dev] [PATCH v2 4/9] usertools/dpdk-pmdinfo: support python3 only

2020-06-17 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2. Cc: Neil Horman Signed-off-by: Louise Kilheeney --- usertools/dpdk-pmdinfo.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py index 12f20735

[dpdk-dev] [PATCH v2 5/9] usertools/cpu_layout: support python3 only

2020-06-17 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2. Signed-off-by: Louise Kilheeney --- usertools/cpu_layout.py | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py index 6f129b1db..89a48cec4 10075

[dpdk-dev] [PATCH v2 1/9] app/test-bbdev: support python3 only

2020-06-17 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2. Cc: Nicolas Chautru Signed-off-by: Louise Kilheeney Acked-by: Nicolas Chautru --- app/test-bbdev/test-bbdev.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/app/test-bbdev/test-bbdev.py b

[dpdk-dev] [PATCH v2 0/9] adding support for python 3 only.

2020-06-17 Thread Louise Kilheeney
v2: fix comments on v1. This patch set converts all python scripts in the project to use python3 only. This is due to python2 being EOL in January 2020. One script not tested: ./config/arm/armv8_machine.py Louise Kilheeney (9): app/test-bbdev: support python3 only usertools/dpdk-devbind: su

[dpdk-dev] [PATCH] net/octeontx2: add cn98xx support

2020-06-17 Thread Harman Kalra
New cn98xx SOC comes up with two NIX blocks wrt cn96xx, cn93xx, to achieve higher performance. Adding support for cn98xx where need a logic to detect if the LF is attached to NIX0 or NIX1 and then accordingly use the respective NIX block. Signed-off-by: Harman Kalra --- doc/guides/platform/octe

[dpdk-dev] [PATCH 5/5] app/testpmd: enable empty polls in burst stats

2020-06-17 Thread Honnappa Nagarahalli
The number of empty polls provides information about available CPU head room in the presence of continuous polling. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang --- app/test-pmd/csumonly.c | 5 +-- app/test-pmd/icmpecho.c | 6 ++-- app/test-pmd/iofwd.c

[dpdk-dev] [PATCH 2/5] app/testpmd: enable burst stats for flowgen mode rx path

2020-06-17 Thread Honnappa Nagarahalli
Enable missing burst stats for rx path for flowgen mode. Fixes: e9e23a617eb8 ("app/testpmd: add flowgen forwarding engine") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang --- app/test-pmd/flowgen.c | 4 1 file changed, 4 insertion

[dpdk-dev] [PATCH 4/5] app/testpmd: fix burst percentage calculation

2020-06-17 Thread Honnappa Nagarahalli
The burst % calculation can over flow due to multiplication. Fix the multiplication and increase the size of variables to 64b. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang --- app/test-pmd

[dpdk-dev] [PATCH 3/5] app/testpmd: enable burst stats for noisy vnf mode

2020-06-17 Thread Honnappa Nagarahalli
From: Phil Yang Add burst stats for noisy vnf mode. Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode") Cc: sta...@dpdk.org Cc: jfreim...@redhat.com Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- app/test-pmd/noisy_vnf.c | 12 ++

[dpdk-dev] [PATCH 1/5] app/testpmd: clock gettime call in throughput calculation

2020-06-17 Thread Honnappa Nagarahalli
The throughput calculation requires a counter that measures passing of time. The PMU cycle counter does not do that. This results in incorrect throughput numbers when RTE_ARM_EAL_RDTSC_USE_PMU is enabled. Use clock_gettime system call to calculate the time passed since last call. Bugzilla ID: 450

Re: [dpdk-dev] [PATCH] build: check functionality rather than binutils version

2020-06-17 Thread Bruce Richardson
On Wed, Jun 17, 2020 at 01:45:57PM +0200, Thomas Monjalon wrote: > 17/06/2020 12:40, Bruce Richardson: > > Rather than checking the binutils version number, which can lead to > > unnecessary disabling of AVX512 if fixes have been backported to distro > > versions, we can instead check the output of

Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant newline

2020-06-17 Thread Bing Zhao
Yes, the newline should be removed. Many thanks. BR. Bing > -Original Message- > From: David Marchand > Sent: Wednesday, June 17, 2020 9:53 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Matan Azrad ; Shahaf > Shuler ; Slava Ovsiienko > ; Bing Zhao ; > Jack Min > Subject: [PATCH] net/mlx5

[dpdk-dev] [PATCH] net/mlx5: remove redundant newline

2020-06-17 Thread David Marchand
The DRV_LOG macro already appends a newline. Fixes: 46287eacc1b1 ("net/mlx5: introduce hash list") Fixes: 860897d2895a ("net/mlx5: reorganize flow tables with hash list") Fixes: e484e4032332 ("net/mlx5: optimize tag traversal with hash list") Fixes: 6801116688fe ("net/mlx5: fix multiple flow table

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/5] net/cxgbe: fix rte_flow related hardware resource leaks

2020-06-17 Thread Ferruh Yigit
On 6/12/2020 11:07 PM, Rahul Lakkireddy wrote: > This series of patches fix various hardware resource leaks in flow > create failure and flow destroy paths. > > Patch 1 fixes Compressed Local IP (CLIP) entry leaks. > > Patch 2 fixes Layer 2 Table (L2T) entry leaks. > > Patch 3 fixes double Multi

Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

2020-06-17 Thread Kevin Traynor
On 17/06/2020 12:43, Matan Azrad wrote: > > > From: Ferruh Yigit: >> On 6/16/2020 5:23 PM, Matan Azrad wrote: >>> >>> >>> From: Ferruh Yigit On 6/16/2020 5:06 PM, Matan Azrad wrote: > Hi > > Ferruh, Raslan > > This patch is not a fix, we don't need to backport it. >>

Re: [dpdk-dev] [PATCH 3/3] net/virtio: add Virtio status support to Virtio-user

2020-06-17 Thread Maxime Coquelin
On 6/17/20 2:07 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: dev On Behalf Of Maxime Coquelin >> Sent: Thursday, May 28, 2020 3:46 PM >> To: dev@dpdk.org; amore...@redhat.com; Ye, Xiaolong >> ; shah...@mellanox.com; ma...@mellanox.com >> Cc: Maxime Coquelin >>

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

2020-06-17 Thread Maxime Coquelin
On 6/17/20 1:04 PM, Matan Azrad wrote: >>> Don’t you think that only enabled queues must be fully initialized when >> their status is changed from disabled to enabled? >>> So, you can assume that disabled queues can stay "not fully initialized"... >> >> That may work but might not be following

[dpdk-dev] [PATCH v3] maintainers: update for interrupt subsystem

2020-06-17 Thread Harman Kalra
updating MAINTAINERS file for interrupt subsytem. Signed-off-by: Harman Kalra --- V2: simplified way for covering all interrupt related files. V3: in replying to original mail. MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [dpdk-dev] [PATCH 1/3] net/virtio: add vhost-user protocol features support

2020-06-17 Thread Maxime Coquelin
On 6/17/20 1:57 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: dev On Behalf Of Maxime Coquelin >> Sent: Thursday, May 28, 2020 3:46 PM >> To: dev@dpdk.org; amore...@redhat.com; Ye, Xiaolong >> ; shah...@mellanox.com; ma...@mellanox.com >> Cc: Maxime Coquelin >>

[dpdk-dev] [PATCH v2] maintainers: update for interrupt subsystem

2020-06-17 Thread Harman Kalra
updating MAINTAINERS file for interrupt subsytem. Signed-off-by: Harman Kalra --- V2: simplified way for covering all interrupt related files. MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 816696caf..45b6c3a99 100644 --- a/M

Re: [dpdk-dev] [EXT] Re: [PATCH] maintainers: update for interrupt subsystem

2020-06-17 Thread Harman Kalra
On Wed, Jun 17, 2020 at 12:10:40AM +0200, Thomas Monjalon wrote: > External Email > > -- > 03/06/2020 17:22, Harman Kalra: > > updating MAINTAINERS file for interrupt subsytem. > > > > Signed-off-by: Harman Kalra > > --- > > +In

Re: [dpdk-dev] [PATCH 3/3] net/virtio: add Virtio status support to Virtio-user

2020-06-17 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: dev On Behalf Of Maxime Coquelin > Sent: Thursday, May 28, 2020 3:46 PM > To: dev@dpdk.org; amore...@redhat.com; Ye, Xiaolong > ; shah...@mellanox.com; ma...@mellanox.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [PATCH 3/3] net/virtio: add Virti

Re: [dpdk-dev] [PATCH v3 00/10] rename blacklist/whitelist to block/allow

2020-06-17 Thread Mcnamara, John
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Saturday, June 13, 2020 1:01 AM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v3 00/10] rename blacklist/whitelist to > block/allow > > The terms blacklist and whitelist are often seen as

Re: [dpdk-dev] [PATCH 1/3] net/virtio: add vhost-user protocol features support

2020-06-17 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: dev On Behalf Of Maxime Coquelin > Sent: Thursday, May 28, 2020 3:46 PM > To: dev@dpdk.org; amore...@redhat.com; Ye, Xiaolong > ; shah...@mellanox.com; ma...@mellanox.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [PATCH 1/3] net/virtio: add vhost

Re: [dpdk-dev] [PATCH] build: check functionality rather than binutils version

2020-06-17 Thread Thomas Monjalon
17/06/2020 12:40, Bruce Richardson: > Rather than checking the binutils version number, which can lead to > unnecessary disabling of AVX512 if fixes have been backported to distro > versions, we can instead check the output of "as" from binutils to see if > it is correct. > > These checks use the

Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

2020-06-17 Thread Matan Azrad
From: Ferruh Yigit: > On 6/16/2020 5:23 PM, Matan Azrad wrote: > > > > > > From: Ferruh Yigit > >> On 6/16/2020 5:06 PM, Matan Azrad wrote: > >>> Hi > >>> > >>> Ferruh, Raslan > >>> > >>> This patch is not a fix, we don't need to backport it. > >> > >> Why not backport it? > > > > There is no a b

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

2020-06-17 Thread Matan Azrad
Hi Maxime From: Maxime Coquelin: > Hi Matan, > > On 6/14/20 8:08 AM, Matan Azrad wrote: > > Hi Maxime > > > > From: Maxime Coquelin: > >> On 6/9/20 1:09 PM, Matan Azrad wrote: > >>> Hi Maxime > >>> > >>> From: Maxime Coquelin > Hi Matan, > > On 6/8/20 11:19 AM, Matan Azrad wrote: >

[dpdk-dev] [PATCH] build: check functionality rather than binutils version

2020-06-17 Thread Bruce Richardson
Rather than checking the binutils version number, which can lead to unnecessary disabling of AVX512 if fixes have been backported to distro versions, we can instead check the output of "as" from binutils to see if it is correct. These checks use the minimal assembly reproduction code posted to the

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-17 Thread Andrew Rybchenko
On 6/17/20 1:00 PM, Thomas Monjalon wrote: > 17/06/2020 08:30, jer...@marvell.com: >> From: Jerin Jacob >> >> Introducing the RTE_LOG_REGISTER macro to avoid the code duplication >> in the log registration process. >> >> It is a wrapper macro for declaring the logtype, register the log and sets >>

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-17 Thread Andrew Rybchenko
On 6/17/20 1:02 PM, David Marchand wrote: > On Wed, Jun 17, 2020 at 8:30 AM wrote: >> >> From: Jerin Jacob >> >> Introducing the RTE_LOG_REGISTER macro to avoid the code duplication >> in the log registration process. >> >> It is a wrapper macro for declaring the logtype, register the log and set

Re: [dpdk-dev] [PATCH v4 2/2] test/cryptodev: add chacha poly test cases to cryptodev

2020-06-17 Thread Tejasree Kondoj
Acked-by: Tejasree Kondoj > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Thursday, June 11, 2020 8:37 PM > To: Arek Kusztal ; dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com > Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/cryptodev: add chacha poly test >

Re: [dpdk-dev] [PATCH v1 0/4] mlx5 MR refactor

2020-06-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ophir Munk > Sent: Tuesday, June 16, 2020 12:45 PM > To: dev@dpdk.org; Matan Azrad ; Raslan > Darawsheh > Cc: Ophir Munk > Subject: [PATCH v1 0/4] mlx5 MR refactor > > This patch series is part of preparing mlx5 PMD to compile and run under > multiple OS

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: re-implement commands by using private API

2020-06-17 Thread Di, ChenxuX
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, June 17, 2020 4:12 AM > To: Di, ChenxuX ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > Subject: Re: [dpdk-dev] [PATCH 3/5] app/testpmd: re-implement commands by > using private API > > On 11/0

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-17 Thread David Marchand
On Wed, Jun 17, 2020 at 8:30 AM wrote: > > From: Jerin Jacob > > Introducing the RTE_LOG_REGISTER macro to avoid the code duplication > in the log registration process. > > It is a wrapper macro for declaring the logtype, register the log and sets Having the logtype variable declared as part of

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-17 Thread Thomas Monjalon
17/06/2020 08:30, jer...@marvell.com: > From: Jerin Jacob > > Introducing the RTE_LOG_REGISTER macro to avoid the code duplication > in the log registration process. > > It is a wrapper macro for declaring the logtype, register the log and sets > it's level in the constructor context. > > Signe

Re: [dpdk-dev] [PATCH v3 3/3] doc/guides: updated script usage for checking patches

2020-06-17 Thread Thomas Monjalon
02/06/2020 15:53, Ciara Power: > The contributor's guide includes the usage of both the checkpatches and > check-git-log scripts, which needed to be updated to reflect the now > standardised format. I think the doc update should be merged in the first patch. In general, doc and code updates should

  1   2   >