Re: [dpdk-dev] [PATCH v1 2/4] vhost: skip access lock when vDPA is configured

2020-06-18 Thread Maxime Coquelin
On 6/18/20 6:28 PM, Matan Azrad wrote: > No need to take access lock in the vhost-user massage handler when s/massage/message/ > vDPA driver controls all the data-path of the vhost device. > > It allows the vDPA set_vring_state operation callback to configure > guest notifications. > > Signe

Re: [dpdk-dev] [PATCH v1 1/4] vhost: support host notifier queue configuration

2020-06-18 Thread Maxime Coquelin
On 6/18/20 6:28 PM, Matan Azrad wrote: > As an arrangement to per queue operations in the vDPA device it is > needed to change the next experimental API: > > The API ``rte_vhost_host_notifier_ctrl`` was changed to be per queue > instead of per device. > > A `qid` parameter was added to the API

Re: [dpdk-dev] [PATCH v2 0/2] vdpa/mlx5: support MTU feature

2020-06-18 Thread Maxime Coquelin
On 6/18/20 9:06 PM, Matan Azrad wrote: > v2: rebase. > > Matan Azrad (2): > common/mlx5: share kernel interface name getter > vdpa/mlx5: support MTU feature > > doc/guides/rel_notes/release_20_08.rst | 1 + > doc/guides/vdpadevs/features/mlx5.ini | 1 + > drivers/comm

Re: [dpdk-dev] [PATCH v4 0/4] vhost: support vDPA virtio queue statistics

2020-06-18 Thread Maxime Coquelin
On 6/18/20 8:59 PM, Matan Azrad wrote: > The vDPA device offloads all the datapath of the vhost device to the HW > device. > > In order to expose to the user traffic information this series introduces new > APIs to get traffic statistics and to reset them per virtio queue. > > Since there is

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: add virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/19/20 8:01 AM, Maxime Coquelin wrote: > Hi Ferruh, > > On 6/18/20 6:30 PM, Maxime Coquelin wrote: >> >> >> On 6/2/20 5:51 PM, Matan Azrad wrote: >>> Starting from FW version 22.27.4002, it is required to configure >>> protection domain (PD) for each virtq created by DevX. >>> >>> Add PD re

Re: [dpdk-dev] [PATCH v4 2/4] common/mlx5: support DevX virtq stats operations

2020-06-18 Thread Maxime Coquelin
On 6/18/20 8:59 PM, Matan Azrad wrote: > Add DevX API to create and query virtio queue statistics from the HW. > The next counters are supported by the HW per virtio queue: > received_desc. > completed_desc. > error_cqes. > bad_desc_errors. > exceed_max_chain. >

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: add virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
Hi Ferruh, On 6/18/20 6:30 PM, Maxime Coquelin wrote: > > > On 6/2/20 5:51 PM, Matan Azrad wrote: >> Starting from FW version 22.27.4002, it is required to configure >> protection domain (PD) for each virtq created by DevX. >> >> Add PD requirement in virtq DevX APIs. >> >> Cc: sta...@dpdk.org >

Re: [dpdk-dev] [PATCH v3 0/4] vhost: support vDPA virtio queue statistics

2020-06-18 Thread Maxime Coquelin
Hi Ferruh, On 6/18/20 6:29 PM, Maxime Coquelin wrote: > > > On 6/2/20 5:47 PM, Matan Azrad wrote: >> The vDPA device offloads all the datapath of the vhost device to the HW >> device. >> >> In order to expose to the user traffic information this series introduces >> new APIs to get traffic sta

Re: [dpdk-dev] [PATCH 00/10] net/ice: base code update for 20.08 batch 2

2020-06-18 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Thursday, June 18, 2020 2:04 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: RE: [PATCH 00/10] net/ice: base code update for 20.08 batch 2 > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Thursday, Ju

[dpdk-dev] [PATCH v2] app/testpmd: fix CPU cycles per pkt stats on transmit modes

2020-06-18 Thread Phil Yang
In txonly and flowgen forwarding mode, calculating CPU per packets with total received packets is not accurate. Use total transmitted packets for these cases. The error output under txonly mode: testpmd> show fwd stats all -- Forward statistics for port 0 ---

Re: [dpdk-dev] [PATCH] app/testpmd: fix CPU cycles per pkt stats on transmit modes

2020-06-18 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, June 19, 2020 3:29 AM > To: Phil Yang ; dev@dpdk.org > Cc: ferruh.yi...@intel.com; maxime.coque...@redhat.com; Ruifeng Wang > ; nd ; sta...@dpdk.org; > david.march...@redhat.com; Honnappa Nagarahalli > ; nd > Subject: RE: [

[dpdk-dev] [PATCH 0/2] ethdev: minor bugfixes

2020-06-18 Thread Wei Hu (Xavier)
This series are minor bugfixes for rte_ethdev.c. Chengchang Tang (2): ethdev: fix data room size verification in Rx queue setup ethdev: fix VLAN offloads set if no relative capabilities lib/librte_ethdev/rte_ethdev.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion

[dpdk-dev] [PATCH 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-18 Thread Wei Hu (Xavier)
From: Chengchang Tang Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start a vlan hardware offloads which the driver does not support. if the PMD driver does not support the relative hardware offloads and does not check for it, the hardware s

[dpdk-dev] [PATCH 1/2] ethdev: fix data room size verification in Rx queue setup

2020-06-18 Thread Wei Hu (Xavier)
From: Chengchang Tang In the rte_eth_rx_queue_setup API function, the local variable named mbp_buf_size, which is the data room size of the input parameter mp, is checked to guarantee that each memory chunck used for net device in the mbuf is bigger than the min_rx_bufsize. But if mbp_buf_size is

Re: [dpdk-dev] [PATCH v3 10/12] net/ice: enable stats for DCF

2020-06-18 Thread Xu, Ting
Hi, Qiming, > -Original Message- > From: Yang, Qiming > Sent: Thursday, June 18, 2020 2:32 PM > To: Xu, Ting ; dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei ; Kovacevic, Marko > ; Mcnamara, John ; > Ye, Xiaolong > Subject: RE: [PATCH v3 10/12] net/ice: enable stats for D

Re: [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes

2020-06-18 Thread Wei Hu (Xavier)
Hi, Chas Williams & Sergey Lvov There was a two-patch series about bonding those are still in reviewing state, and the one of them includes the identical modification. Thanks. http://patches.dpdk.org/patch/68742/ The series include two patches: http://patches.dpdk.org/patch/68742/ http://pa

Re: [dpdk-dev] [PATCH v1 1/2] vhost: introduce async data path registration API

2020-06-18 Thread Liu, Yong
> -Original Message- > From: Fu, Patrick > Sent: Thursday, June 18, 2020 5:09 PM > To: Liu, Yong > Cc: Jiang, Cheng1 ; Liang, Cunming > ; dev@dpdk.org; maxime.coque...@redhat.com; > Xia, Chenbo ; Wang, Zhihong > ; Ye, Xiaolong > Subject: RE: [dpdk-dev] [PATCH v1 1/2] vhost: introduce

Re: [dpdk-dev] [PATCH v6 9/9] build: generate version.map file for MingW on Windows

2020-06-18 Thread Dmitry Kozlyuk
On Fri, 19 Jun 2020 00:15:46 +0300 tal...@mellanox.com wrote: > From: Tal Shnaiderman > > The MingW build for Windows has special cases where exported > function contain additional prefix: > > __emutls_v.per_lcore__* > > To avoid adding those prefixed functions to the version.map file > the ma

Re: [dpdk-dev] [PATCH v1 7/8] common/mlx5: exclude OS dependency in devx commands

2020-06-18 Thread Thomas Monjalon
+Cc Ferruh for info 19/06/2020 00:47, Thomas Monjalon: > 10/06/2020 11:32, Ophir Munk: > > Shared function mlx5_devx_cmd_mkey_create() reads the OS pagesize by > > calling a Linux API: 'sysconf(_SC_PAGESIZE)'. Wrap this call with a > > shared API 'mlx5_os_get_page_size()' which contains the specif

Re: [dpdk-dev] [PATCH v1 7/8] common/mlx5: exclude OS dependency in devx commands

2020-06-18 Thread Thomas Monjalon
10/06/2020 11:32, Ophir Munk: > Shared function mlx5_devx_cmd_mkey_create() reads the OS pagesize by > calling a Linux API: 'sysconf(_SC_PAGESIZE)'. Wrap this call with a > shared API 'mlx5_os_get_page_size()' which contains the specific OS > implementation. > > Signed-off-by: Ophir Munk Sorry,

Re: [dpdk-dev] [PATCH v6 2/9] pci: use OS generic memory mapping functions

2020-06-18 Thread Dmitry Kozlyuk
[snip] > @@ -154,14 +154,15 @@ pci_map_resource(void *requested_addr, int fd, off_t > offset, size_t size, > void *mapaddr; > > /* Map the PCI memory resource of device */ > - mapaddr = mmap(requested_addr, size, PROT_READ | PROT_WRITE, > - MAP_SHARED | additi

Re: [dpdk-dev] [PATCH v6 8/9] bus/pci: support Windows with bifurcated drivers

2020-06-18 Thread Dmitry Kozlyuk
[snip] > +static void > +get_kernel_driver_type(struct rte_pci_device *dev __rte_unused) "dev" is used. > +{ > + /* > + * If another kernel driver is supported the relevant checking > + * functions should be here > + */ > + dev->kdrv = RTE_KDRV_NONE; > +} > + > +static int

[dpdk-dev] [PATCH v6 7/9] bus/pci: introduce Windows support with stubs

2020-06-18 Thread talshn
From: Tal Shnaiderman Addition of stub eal and bus/pci functions to compile bus/pci for Windows. Signed-off-by: Tal Shnaiderman --- drivers/baseband/meson.build | 4 + drivers/bus/ifpga/meson.build | 6 ++ drivers/bus/pci/meson.build| 14 ++- drivers/bus/pci/pci_common.

[dpdk-dev] [PATCH v6 9/9] build: generate version.map file for MingW on Windows

2020-06-18 Thread talshn
From: Tal Shnaiderman The MingW build for Windows has special cases where exported function contain additional prefix: __emutls_v.per_lcore__* To avoid adding those prefixed functions to the version.map file the map_to_def.py script was modified to create a map file for Mingw with the needed ch

[dpdk-dev] [PATCH v6 8/9] bus/pci: support Windows with bifurcated drivers

2020-06-18 Thread talshn
From: Tal Shnaiderman Uses SetupAPI.h functions to scan PCI tree. Uses DEVPKEY_Device_Numa_Node to get the PCI NUMA node. Uses SPDRP_BUSNUMBER and SPDRP_BUSNUMBER to get the BDF. scanning currently supports types RTE_KDRV_NONE. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/windows/pci.c

[dpdk-dev] [PATCH v6 6/9] drivers: fix incorrect meson import folder for Windows

2020-06-18 Thread talshn
From: Tal Shnaiderman import library (/IMPLIB) in meson.build should use the 'drivers' and not 'libs' folder. The error is: fatal error LNK1149: output filename matches input filename. The fix uses the correct folder. Fixes: 5ed3766981 ("drivers: process shared link dependencies as for libs")

[dpdk-dev] [PATCH v6 2/9] pci: use OS generic memory mapping functions

2020-06-18 Thread talshn
From: Tal Shnaiderman Changing all of PCIs Unix memory mapping to the new memory allocation API wrapper. Change all of PCI mapping function usage in bus/pci to support the new API. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/bsd/pci.c| 2 +- drivers/bus/pci/linux/pci_uio.c |

[dpdk-dev] [PATCH v6 0/9] Windows bus/pci support

2020-06-18 Thread talshn
From: Tal Shnaiderman This patchset implements the EAL and PCI functions needed for probing PMDs using RTE_KDRV_NONE on Windows. --- v6: * Fix duplication of exported functions for mingw by modifying the version.map in build (new commit) * Fix comments and move additional funct

[dpdk-dev] [PATCH v6 5/9] drivers: ignore pmdinfogen generation for Windows

2020-06-18 Thread talshn
From: Tal Shnaiderman pmdinfogen generation is currently unsupported for Windows. The relevant part in meson.build is skipped. Signed-off-by: Tal Shnaiderman --- drivers/meson.build | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/meson.

[dpdk-dev] [PATCH v6 3/9] pci: build on Windows

2020-06-18 Thread talshn
From: Tal Shnaiderman Added in rte_pci header file to include off_t type since it is missing for Windows. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_pci/rte_pci.h | 1 + lib/meson.build| 5 - 3 files changed, 6 ins

[dpdk-dev] [PATCH v6 4/9] pci: fix format warning on Windows

2020-06-18 Thread talshn
From: Tal Shnaiderman the struct rte_pci_addr defines domain as uint32_t variable however the PCI_PRI_FMT macro used for logging the struct sets the format of domain to uint16_t. The mismatch causes the following warning messages in Windows clang build: format specifies type 'unsigned short' bu

[dpdk-dev] [PATCH v6 1/9] eal: move OS common functions to single file

2020-06-18 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_config.c. Those functions are getter functions for IOVA, configuration, Multi-process. Move rte_config, internal_config, early_mem_config and runtime_dir to be defined in a common file. Signed-off-by: Tal Shnaid

Re: [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes

2020-06-18 Thread Chas Williams
Yes, this does look like a typo on someone's part. Please change use net/bonding: instead of pmd_bond: Please add a Fixes: line Please add a Cc: sta...@dpdk.org On 6/17/20 3:02 PM, Sergey Lvov wrote: > It seems to be a typo > > Signed-off-by: Sergey Lvov > --- > drivers/net/bonding/rte_eth_bo

Re: [dpdk-dev] [PATCH v10 0/2] eal timer split and implementation for Windows

2020-06-18 Thread Ranjit Menon
On 6/17/2020 11:55 PM, Fady Bader wrote: This patchset splits OS dependent EAL timer functions and implements them for windows. v2: * fixing styles and correctness errors. v3: * fixing correctness, get_tsc_freq was reimplemented. v4: * rebasing to the new version of "Windows ba

Re: [dpdk-dev] [PATCH] app/testpmd: fix CPU cycles per pkt stats on transmit modes

2020-06-18 Thread Honnappa Nagarahalli
> Subject: [PATCH] app/testpmd: fix CPU cycles per pkt stats on transmit modes > > In txonly and flowgen forwarding mode, calculating CPU per packets with total > received packets is not accurate. Use total transmitted packets for these > cases. > > The error output under txonly mode: > testpm

[dpdk-dev] [PATCH 2/3] vdpa/mlx5: optimize completion queue poll

2020-06-18 Thread Matan Azrad
The vDPA driver uses a CQ in order to know when traffic works were completed by the HW. Each traffic completion adds a CQE to the CQ. When the vDPA driver detects CQEs in the CQ, it triggers the guest notification for the corresponding queue and consumes all of them. There is collapse feature in

[dpdk-dev] [PATCH 3/3] vdpa/mlx5: add traffic control device arguments

2020-06-18 Thread Matan Azrad
Add 2 device arguments to conrol traffic modes: 1. Control the CQ polling timer frequency when traffic is on. 2. Control the non-traffic time which moves the timer to be off. Signed-off-by: Matan Azrad --- doc/guides/vdpadevs/mlx5.rst| 17 ++ drivers/vdpa/mlx5/mlx5_vdpa.c

[dpdk-dev] [PATCH 1/3] vdpa/mlx5: optimize notification events

2020-06-18 Thread Matan Azrad
When the virtio guest driver doesn't work with poll mode, the driver creates event mechanism in order to schedule completion notifications for each virtq burst traffic. When traffic comes to a virtq, a CQE will be added to the virtq CQ by the FW. The driver requests interrupt for the next CQE inde

[dpdk-dev] [PATCH 0/3] vdpa/mlx5: optimize cpu utilization

2020-06-18 Thread Matan Azrad
Use timer thread to schedule CQ polling instead of interrupts. Optimize CQ polling. Matan Azrad (3): vdpa/mlx5: optimize notification events vdpa/mlx5: optimize completion queue poll vdpa/mlx5: add traffic control device arguments doc/guides/vdpadevs/mlx5.rst| 17 +++ drivers/vdpa

[dpdk-dev] [PATCH] vhost: fix features definition location

2020-06-18 Thread Matan Azrad
The vhost library provide an infrastructure in order to help the DPDK users to manage vhost devices. One of the infrastructure parts is the features enablement APIs. Some features bits may be defined only in the internal file vhost.h in case the kernel version doesn't include them. Hence, user r

[dpdk-dev] [PATCH v2 2/2] vdpa/mlx5: support MTU feature

2020-06-18 Thread Matan Azrad
The guest virtio device may request MTU updating when the vhost backend device exposes a capability to support it. Exspose the MTU feature capability. At configuration time, check the requested MTU and update it in the HW device. Signed-off-by: Matan Azrad Reviewed-by: Maxime Coquelin --- doc

[dpdk-dev] [PATCH v2 0/2] vdpa/mlx5: support MTU feature

2020-06-18 Thread Matan Azrad
v2: rebase. Matan Azrad (2): common/mlx5: share kernel interface name getter vdpa/mlx5: support MTU feature doc/guides/rel_notes/release_20_08.rst | 1 + doc/guides/vdpadevs/features/mlx5.ini | 1 + drivers/common/mlx5/linux/mlx5_common_os.c | 89 +++

[dpdk-dev] [PATCH v2 1/2] common/mlx5: share kernel interface name getter

2020-06-18 Thread Matan Azrad
Some configuration of the mlx5 port are done by the kernel net device associated to the IB device represents the PCI device. The DPDK mlx5 driver uses linux system calls, for example ioctl, in order to configure per port configurations requested by the DPDK user. One of the basic knowledges requi

[dpdk-dev] [PATCH v4 4/4] examples/vdpa: add statistics show command

2020-06-18 Thread Matan Azrad
A new vDPA driver feature was added to query the virtq statistics from the HW. Use this feature to show the HW queues statistics for the virtqs. Command description: stats X Y. X is the device ID. Y is the queue ID, Y=0x to show all the virtio queues statistics of the device X. Signed-off-by

[dpdk-dev] [PATCH v4 3/4] vdpa/mlx5: support virtio queue statistics get

2020-06-18 Thread Matan Azrad
Add support for statistics operations. A DevX counter object is allocated per virtq in order to manage the virtq statistics. The counter object is allocated before the virtq creation and destroyed after it, so the statistics are valid only in the life time of the virtq. Signed-off-by: Matan Azra

[dpdk-dev] [PATCH v4 2/4] common/mlx5: support DevX virtq stats operations

2020-06-18 Thread Matan Azrad
Add DevX API to create and query virtio queue statistics from the HW. The next counters are supported by the HW per virtio queue: received_desc. completed_desc. error_cqes. bad_desc_errors. exceed_max_chain. invalid_buffer. Signed-off-by: Matan Azrad

[dpdk-dev] [PATCH v4 0/4] vhost: support vDPA virtio queue statistics

2020-06-18 Thread Matan Azrad
The vDPA device offloads all the datapath of the vhost device to the HW device. In order to expose to the user traffic information this series introduces new APIs to get traffic statistics and to reset them per virtio queue. Since there is no any formal statistics suggested by the virtio specs,

[dpdk-dev] [PATCH v4 1/4] vhost: inroduce operation to get vDPA queue stats

2020-06-18 Thread Matan Azrad
The vDPA device offloads all the datapath of the vhost device to the HW device. In order to expose to the user traffic information this patch introduces new 3 APIs to get traffic statistics, the device statistics name and to reset the statistics per virtio queue. The statistics are taken directly

[dpdk-dev] [PATCH 3/3] net/bnxt: add ARM64 vector support

2020-06-18 Thread Lance Richardson
Add bnxt vector PMD support using NEON SIMD instructions. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- v2: - Use rte_vect.h instead of including arm_neon.h directly in bnxt_rxtx_vec_neon.c. drivers/net/bnxt/Makefile | 3 + drivers/net/bnxt/bnxt_eth

[dpdk-dev] [PATCH 2/3] net/bnxt: support Rx/Tx burst mode info

2020-06-18 Thread Lance Richardson
Retrieve burst mode options according to the selected Rx/Tx burst function name. Signed-off-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde --- v2: no change doc/guides/nics/features/bnxt.ini | 1 + drivers/net/bnxt/bnxt_ethdev.c| 46 ++

[dpdk-dev] [PATCH v2 0/3] net/bnxt: vector mode enhancements

2020-06-18 Thread Lance Richardson
- Switch to non-vector receive function when "mark" action is requested. - Add support for rx_burst_mode_get()/tx_burst_mode_get() to return currently active receive/transmit mode. - Add vector mode support for ARM64. Lance Richardson (3): net/bnxt: disable vector receive for mark action n

[dpdk-dev] [PATCH 1/3] net/bnxt: disable vector receive for mark action

2020-06-18 Thread Lance Richardson
The bnxt vector mode receive handler does not support the rte_flow 'mark' action. Since we cannot know in advance whether this action will be required, add support for dynamically switching from vector to non-vector receive when the first flow create request with a mark action is processed. Fixes:

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: share kernel interface name getter

2020-06-18 Thread Matan Azrad
Yes, more conflict are exists with current master-net-mlx. I have newest version rebased on master-net-mlx. I will send new version, for all the old versions... > -Original Message- > From: Maxime Coquelin > Sent: Thursday, June 18, 2020 7:07 PM > To: Matan Azrad ; Slava Ovsiienko > > C

Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter

2020-06-18 Thread Honnappa Nagarahalli
> > Hi Phil, > > Good catch - thanks for the fix. I've commented in-line: > > > -Original Message- > > From: Phil Yang > > Sent: Friday, June 12, 2020 6:20 AM > > To: dev@dpdk.org; Carrillo, Erik G > > Cc: d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > > ruifeng.w...@arm.

Re: [dpdk-dev] [EXTERNAL] 19.11.3 patches review and test

2020-06-18 Thread Luca Boccassi
Thank you! On Thu, 2020-06-18 at 18:11 +, Abhishek Marathe wrote: > Hi Luca, > > All testcases pass for DPDK LTS 19.11.3. Failed testcases below were double > checked and No issues found. > > Test Report: > > DPDK > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpd

Re: [dpdk-dev] [PATCH] crypto/qat: add data-path APIs

2020-06-18 Thread Trahe, Fiona
> -Original Message- > From: Zhang, Roy Fan > Sent: Friday, June 12, 2020 3:40 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Zhang, Roy Fan > ; Bronowski, PiotrX > Subject: [PATCH] crypto/qat: add data-path APIs > > This patch adds data-path APIs to QAT symmetric dir

Re: [dpdk-dev] [PATCH v4 1/3] lib/lpm: integrate RCU QSBR

2020-06-18 Thread Medvedkin, Vladimir
Hi Honnappa, On 08/06/2020 19:46, Honnappa Nagarahalli wrote: Subject: [PATCH v4 1/3] lib/lpm: integrate RCU QSBR Currently, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. This results in incorrect looku

Re: [dpdk-dev] [PATCH v4 1/3] lib/lpm: integrate RCU QSBR

2020-06-18 Thread Medvedkin, Vladimir
Hi Ruifeng, Thanks for patches, see comments below On 08/06/2020 06:16, Ruifeng Wang wrote: Currently, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. This results in incorrect lookup results. RCU QSBR pro

[dpdk-dev] [PATCH v2 6/7] power: add API to probe support for a specific env

2020-06-18 Thread Anatoly Burakov
Currently, there is no way to know if the power management env is supported without trying to initialize it. The init API also does not distinguish between failure due to some error and failure due to power management not being available on the platform in the first place. Thus, add an API that pr

[dpdk-dev] [PATCH v2 4/7] l3fwd-power: add support for requesting legacy mode

2020-06-18 Thread Anatoly Burakov
Currently, legacy mode is the implicit default, but it is not possible to directly request using legacy mode. Add the argument to enable requesting legacy mode, and also make it the default. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 28 +++- 1 file

[dpdk-dev] [PATCH v2 5/7] l3fwd-power: add interrupt-only mode

2020-06-18 Thread Anatoly Burakov
In addition to existing modes, add a mode which is very similar to legacy mode, but does not do frequency scaling, and thus does not depend on the power library. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 188 +++- 1 file changed, 185 inserti

[dpdk-dev] [PATCH v2 7/7] l3fwd-power: add auto-selection of default mode

2020-06-18 Thread Anatoly Burakov
Currently, the application does support running without the power library being initialized, but it has to be specifically requested. On platforms without support for frequency scaling using the power library, we can just enable interrupt-only mode by default. Signed-off-by: Anatoly Burakov Sugge

[dpdk-dev] [PATCH v2 3/7] l3fwd-power: code style and flow fixes

2020-06-18 Thread Anatoly Burakov
Make the coding style more consistent, and the init logic control flow more explicit. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c i

[dpdk-dev] [PATCH v2 1/7] l3fwd-power: disable interrupts by default

2020-06-18 Thread Anatoly Burakov
Currently, interrupts are enabled in telemetry and empty poll modes, but they are not used. Switch to disabling interrupts by default, and only enable interrupts for modes that require them. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 12 +++- 1 file changed, 7 inser

[dpdk-dev] [PATCH v2 0/7] Add interrupt-only mode to l3fwd-power

2020-06-18 Thread Anatoly Burakov
Since 20.05, l3fwd-power has become much more stringent about whether it allows initialization without initializing the librte_power library with it. This means that while previously the app could have been used to test RX interrupts functionality even if the app itself was in a half-working state,

[dpdk-dev] [PATCH v2 2/7] l3fwd-power: only allow supported power library envs

2020-06-18 Thread Anatoly Burakov
Currently, l3fwd-power will attempt to run even if the power env is set to KVM, which is not supported. Fix this by preventing the app from initializing unless the env is set to one of the supported modes. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 9 + 1 file chang

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: adjust virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:51 PM, Matan Azrad wrote: > In other to fill the new requirement for virtq configuration, > set the single PD managed by the driver for all the virtqs. > > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad > Signed-off-by: Xueming Li > --- > drivers/vdpa/mlx5/mlx5_vdpa.c

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: add virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:51 PM, Matan Azrad wrote: > Starting from FW version 22.27.4002, it is required to configure > protection domain (PD) for each virtq created by DevX. > > Add PD requirement in virtq DevX APIs. > > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad > Signed-off-by: Xueming Li > -

Re: [dpdk-dev] [PATCH v3 0/4] vhost: support vDPA virtio queue statistics

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:47 PM, Matan Azrad wrote: > The vDPA device offloads all the datapath of the vhost device to the HW > device. > > In order to expose to the user traffic information this series introduces new > APIs to get traffic statistics and to reset them per virtio queue. > > Since there is

Re: [dpdk-dev] [PATCH v2] vhost: enable reply-ack systematically

2020-06-18 Thread Maxime Coquelin
On 5/28/20 11:03 AM, Maxime Coquelin wrote: > As announced during v20.05 release cycle, this > patch makes reply-ack protocol feature to be enabled > unconditionally. > > This protocol feature makes the communication between the > master and the slave more robust, avoiding for example > possibl

[dpdk-dev] [PATCH v1 1/4] vhost: support host notifier queue configuration

2020-06-18 Thread Matan Azrad
As an arrangement to per queue operations in the vDPA device it is needed to change the next experimental API: The API ``rte_vhost_host_notifier_ctrl`` was changed to be per queue instead of per device. A `qid` parameter was added to the API arguments list. Setting the parameter to the value VHO

[dpdk-dev] [PATCH v1 0/4] vhost: improve ready state

2020-06-18 Thread Matan Azrad
Dou to the issue described in "vhost: improve device ready definition" patch here, we need to change the ready state definition in vhost device. To support the suggestion improvment there is update for the host notifier control API. Also need to skip access lock when vDPA device is configured.

[dpdk-dev] [PATCH v1 2/4] vhost: skip access lock when vDPA is configured

2020-06-18 Thread Matan Azrad
No need to take access lock in the vhost-user massage handler when vDPA driver controls all the data-path of the vhost device. It allows the vDPA set_vring_state operation callback to configure guest notifications. Signed-off-by: Matan Azrad --- lib/librte_vhost/vhost_user.c | 6 -- 1 file

[dpdk-dev] [PATCH v1 4/4] vdpa/mlx5: support queue update

2020-06-18 Thread Matan Azrad
Last changes in vDPA device management by vhost library may cause queue ready state update after the device configuration. So, there is chance that some queue configuration information will be known only after the device was configured. Add support to reconfigure a queue after the device configur

[dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-18 Thread Matan Azrad
Some guest drivers may not configure disabled virtio queues. In this case, the vhost management never triggers the vDPA device configuration because it waits to the device to be ready. The current ready state means that all the virtio queues should be configured regardless the enablement status.

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: share kernel interface name getter

2020-06-18 Thread Maxime Coquelin
Your series does not apply, there are no common ancestor so I can't do 3-way merge. Could you please rebase it on top of next-virtio's master branch? Thanks, Maxime On 6/2/20 5:53 PM, Matan Azrad wrote: > Some configuration of the mlx5 port are done by the kernel net device > associated to the I

Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver

2020-06-18 Thread Parav Pandit
> From: Gaëtan Rivet > Sent: Thursday, June 18, 2020 8:05 PM > To: Parav Pandit > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Ori Kam ; > Matan Azrad > Subject: Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver > > On 18/06/20 10:03 +, Parav Pandit wrote: > > > > > From: Ga

Re: [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-06-18 Thread McDaniel, Timothy
Hello Mattias, Thank you for your review comments. I will incorporate the changes you have suggested in V2 of the patchset, which I am currently working on. Thanks, Tim -Original Message- From: Mattias Rönnblom Sent: Saturday, June 13, 2020 5:44 AM To: Jerin Jacob ; McDaniel, Timothy

Re: [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-06-18 Thread McDaniel, Timothy
Hello Jerin, I am working on V2 of the patchset, and the ABI breakage will be corrected in that version. Thanks, Tim -Original Message- From: Jerin Jacob Sent: Friday, June 12, 2020 10:59 PM To: McDaniel, Timothy Cc: Jerin Jacob ; dpdk-dev ; Eads, Gage ; Van Haaren, Harry ; Ray Kin

Re: [dpdk-dev] DPDK Release Status Meeting 18/06/2020

2020-06-18 Thread Thomas Monjalon
18/06/2020 17:26, Ferruh Yigit: > On 6/18/2020 3:09 PM, Trahe, Fiona wrote: > > Hi all, > > > > If there's a cryptodev API change planned for 20.11 (an ABI breakage), is > > it necessary > > to send a deprecation notice in 20.08? > > Or can this just be worked during the normal 20.11 patch review

Re: [dpdk-dev] DPDK Release Status Meeting 18/06/2020

2020-06-18 Thread Ferruh Yigit
On 6/18/2020 3:09 PM, Trahe, Fiona wrote: > Hi all, > > If there's a cryptodev API change planned for 20.11 (an ABI breakage), is it > necessary > to send a deprecation notice in 20.08? > Or can this just be worked during the normal 20.11 patch review cycle? As far as I got it, it needs to follo

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: support MTU feature

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:53 PM, Matan Azrad wrote: > The guest virtio device may request MTU updating when the vhost backend > device exposes a capability to support it. > > Exspose the MTU feature capability. s/Expose/Exspose/ > > In configuration time, check the requested MTU and update it in the HW s

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: share kernel interface name getter

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:53 PM, Matan Azrad wrote: > Some configuration of the mlx5 port are done by the kernel net device > associated to the IB device represents the PCI device. > > The DPDK mlx5 driver uses linux system calls, for example ioctl, in > order to configure per port configurations requested b

Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter

2020-06-18 Thread Carrillo, Erik G
Hi Phil, Good catch - thanks for the fix. I've commented in-line: > -Original Message- > From: Phil Yang > Sent: Friday, June 12, 2020 6:20 AM > To: dev@dpdk.org; Carrillo, Erik G > Cc: d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; dharmik.thak...@arm.

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: adjust virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:51 PM, Matan Azrad wrote: > In other to fill the new requirement for virtq configuration, > set the single PD managed by the driver for all the virtqs. > > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad > Signed-off-by: Xueming Li > --- > drivers/vdpa/mlx5/mlx5_vdpa.c

Re: [dpdk-dev] [RFC PATCH 6/6] bus/mlx5_pci: enable net and vDPA to use mlx5 PCI bus driver

2020-06-18 Thread Gaëtan Rivet
On 18/06/20 10:06 +, Parav Pandit wrote: > > > > From: Gaëtan Rivet > > Sent: Tuesday, June 16, 2020 3:26 AM > > > > On 10/06/20 17:17 +, Parav Pandit wrote: > > > Enable class driver to match with the mlx5 pci devices. > > > Migrate mlx5 net PMD and vdpa PMD to start using mlx5 common

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: clock gettime call in throughput calculation

2020-06-18 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 10:43 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; alia...@mellanox.com; > orgerl...@mellanox.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com;

Re: [dpdk-dev] [PATCH 3/3] net/bnxt: add ARM64 vector support

2020-06-18 Thread Lance Richardson
On Tue, Jun 16, 2020 at 1:18 AM Ruifeng Wang wrote: > > > +#if defined(RTE_ARCH_ARM64) > > +#include > > rte_vect.h includes compatibility improvement. It can replace arm_neon.h here. > > > +#else > > +#error "bnxt vector pmd: unsupported target." > > +#endif > > + Thanks, Ruifeng, I've address

Re: [dpdk-dev] [PATCH 5/5] app/testpmd: enable empty polls in burst stats

2020-06-18 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 10:43 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; alia...@mellanox.com; > orgerl...@mellanox.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com;

Re: [dpdk-dev] [PATCH 4/5] app/testpmd: fix burst percentage calculation

2020-06-18 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 10:43 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; alia...@mellanox.com; > orgerl...@mellanox.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com;

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: adjust virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:51 PM, Matan Azrad wrote: > In other to fill the new requirement for virtq configuration, > set the single PD managed by the driver for all the virtqs. > > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad > Signed-off-by: Xueming Li > --- > drivers/vdpa/mlx5/mlx5_vdpa.c

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: enable burst stats for flowgen mode rx path

2020-06-18 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 10:43 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; alia...@mellanox.com; > orgerl...@mellanox.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com;

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: add virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:51 PM, Matan Azrad wrote: > Starting from FW version 22.27.4002, it is required to configure > protection domain (PD) for each virtq created by DevX. > > Add PD requirement in virtq DevX APIs. > > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad > Signed-off-by: Xueming Li > -

[dpdk-dev] [PATCH] app/testpmd: fix CPU cycles per pkt stats on transmit modes

2020-06-18 Thread Phil Yang
In txonly and flowgen forwarding mode, calculating CPU per packets with total received packets is not accurate. Use total transmitted packets for these cases. The error output under txonly mode: testpmd> show fwd stats all -- Forward statistics for port 0 ---

Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver

2020-06-18 Thread Gaëtan Rivet
On 18/06/20 10:03 +, Parav Pandit wrote: > > > From: Gaëtan Rivet > > Sent: Tuesday, June 16, 2020 3:17 AM > > > > On 10/06/20 17:17 +, Parav Pandit wrote: > > > Create a mlx5 bus driver framework for invoking drivers of multiple > > > classes who have registered with the mlx5_pci bus dr

Re: [dpdk-dev] [PATCH] maintainers: update for netcope sze/nfb

2020-06-18 Thread Martin Špinler
Acked-by: Martin Spinler > Setting Martin Spinler as new and only maintainer for Netcope > libsze2/nfb drivers > > Signed-off-by: Jakub Neruda

[dpdk-dev] [PATCH] maintainers: resign from next-net-intel/virtio/vhost/af_xdp

2020-06-18 Thread Xiaolong Ye
I will leave Intel soon and likely won't have dedicated time for maintainership, so removing my name from all related maintainer roles. Signed-off-by: Xiaolong Ye --- MAINTAINERS | 5 - 1 file changed, 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 816696caf2..32da70fae9 100644

Re: [dpdk-dev] DPDK Release Status Meeting 18/06/2020

2020-06-18 Thread Trahe, Fiona
Hi all, If there's a cryptodev API change planned for 20.11 (an ABI breakage), is it necessary to send a deprecation notice in 20.08? Or can this just be worked during the normal 20.11 patch review cycle? Regards, Fiona > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sen

[dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-18 Thread Chengchang Tang
In common practice, PMD configure the rx_buf_size according to the data room size of the object in mempool. But in fact the final value is related to the specifications of hw, and its values will affect the number of fragments in recieving pkts. At present, we seem to have no way to espose relevan

[dpdk-dev] [PATCH 4/4] eal: cache last directory permissions checked

2020-06-18 Thread Bruce Richardson
When loading a directory of drivers, we check the same hierarchy multiple times. If we just cache the last directory checked, this avoids repeated checks of the same path, since all drivers in that path have been added to the list consecutively. Signed-off-by: Bruce Richardson --- lib/librte_eal

  1   2   >