[dpdk-dev] 18.11.9 (LTS) patches review and test

2020-06-20 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for LTS release 18.11.9. The planned date for the final release is 3rd July. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations wi

[dpdk-dev] [RFC v2 0/1] add flow action context API

2020-06-20 Thread Andrey Vesnovaty
Hi, and thanks a lot for your RFC v1 comments. RFC v2 emphasize the intent for sharing the flow action: * The term 'action context' was unclear and replaced with 'shared action'. * RFC v2 subject became 'add flow shared action API'. * all proposed APIs renamed according the above. The new sha

[dpdk-dev] [RFC v2 1/1] add flow shared action API

2020-06-20 Thread Andrey Vesnovaty
This commit introduces extension of DPDK flow action API enabling sharing of single rte_flow_action in multiple flows. The API intended for PMDs where multiple HW offloaded flows can reuse the same HW essence/object representing flow action and modification of such an essence/object effects all the

Re: [dpdk-dev] [PATCH v6 9/9] build: generate version.map file for MingW on Windows

2020-06-20 Thread Dmitry Kozlyuk
[snip] > diff --git a/drivers/meson.build b/drivers/meson.build > index 646a7d5eb5..b25a368531 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -152,16 +152,22 @@ foreach class:dpdk_driver_classes > implib = 'lib' + lib_name + '.dll.a' > >

Re: [dpdk-dev] [PATCH v6 1/9] eal: move OS common functions to single file

2020-06-20 Thread Dmitry Kozlyuk
[snip] > diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c > index f162124a37..473c7ac67c 100644 > --- a/lib/librte_eal/linux/eal.c > +++ b/lib/librte_eal/linux/eal.c [snip] > static int > eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) > { > @@ -630,6 +590,8

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-06-20 Thread Dmitry Kozlyuk
> diff --git a/lib/librte_eal/common/meson.build > b/lib/librte_eal/common/meson.build > index e1bdaf024..05e40a26b 100644 > --- a/lib/librte_eal/common/meson.build > +++ b/lib/librte_eal/common/meson.build > @@ -28,6 +28,7 @@ if is_windows > 'malloc_elem.c', > 'malloc_

[dpdk-dev] [PATCH 1/7] cmdline: make implementation opaque

2020-06-20 Thread Dmitry Kozlyuk
struct cmdline exposes platform-specific members it contains, most notably struct termios that is only available on Unix. Make the structure opaque. Remove tests checking struct cmdline content as meaningless. Add cmdline_get_rdline() to access history buffer. The new function is currently used o

[dpdk-dev] [PATCH 0/7] cmdline: support Windows

2020-06-20 Thread Dmitry Kozlyuk
This patchset enables librte_cmdline on Windows. To do that, it creates a number of wrappers for OS-dependent terminal handling and I/O. Considered alternative was to revive [1] and use libedit (Unix-only) for terminal handling. However, testing revealed that WinEditLine [2] is not a drop-in replac

[dpdk-dev] [PATCH 2/7] cmdline: add internal wrappers for terminal handling

2020-06-20 Thread Dmitry Kozlyuk
Extract struct terminal and associated functions that set up, save, and restore terminal parameters. Use existing code as Unix implementation. Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/Makefile | 4 lib/librte_cmdline/cmdline_os_unix.c | 27 +++

[dpdk-dev] [PATCH 3/7] cmdline: add internal wrappers for character input

2020-06-20 Thread Dmitry Kozlyuk
poll(3) is a purely Unix facility, so it cannot be directly used by common code. read(2) is limited in device support outside of Unix. Create wrapper functions and implement them for Unix. Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/cmdline.c | 12 +++- lib/librte_cmdlin

[dpdk-dev] [PATCH 5/7] eal/windows: improve compatibility networking headers

2020-06-20 Thread Dmitry Kozlyuk
Extend compatibility header system to support librte_cmdline. pthread.h has to include windows.h, which exposes struct in_addr, etc. conflicting with compatibility headers. WIN32_LEAN_AND_MEAN macro is required to disable this behavior. Use rte_windows.h to define WIN32_LEAN_AND_MEAN for pthread l

[dpdk-dev] [PATCH 7/7] examples/cmdline: build on Windows

2020-06-20 Thread Dmitry Kozlyuk
Enable cmdline sample application as all dependencies are met. Signed-off-by: Dmitry Kozlyuk --- examples/cmdline/commands.c | 1 - examples/cmdline/main.c | 1 - examples/meson.build| 6 +++--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/cmdline/commands.

[dpdk-dev] [PATCH 6/7] cmdline: support Windows

2020-06-20 Thread Dmitry Kozlyuk
Implement terminal handling, input polling, and vdprintf() for Windows. Because Windows I/O model differs fundamentally from Unix and there is no concept of character device, polling is simulated depending on the underlying inpue device. Supporting non-terminal input is useful for automated testin

[dpdk-dev] [PATCH 4/7] cmdline: add internal wrapper for vdprintf

2020-06-20 Thread Dmitry Kozlyuk
Add internal wrapper for vdprintf(3) that is only available on Unix. Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/cmdline.c | 2 +- lib/librte_cmdline/cmdline_os_unix.c | 6 ++ lib/librte_cmdline/cmdline_private.h | 8 3 files changed, 15 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH 1/3] config: never link with pthread on Windows

2020-06-20 Thread Dmitry Kozlyuk
Even if pthread is provided by the toolchain, it is not needed for DPDK on Windows, because internal shim is used. As a side-effect, this enables cross-build with MinGW configured with non-POSIX thread library, e.g. mcfgthread, which is the default on some distributions. Signed-off-by: Dmitry Kozl

[dpdk-dev] [PATCH 0/3] improve MinGW-w64 support

2020-06-20 Thread Dmitry Kozlyuk
Following the discussion on the mailing list [1], clarify MinGW-w64 installation process and stop linking with pthread on Windows. Make Meson cross-file more general along the way. [1]: https://mails.dpdk.org/archives/dev/2020-June/170252.html Dmitry Kozlyuk (3): config: never link with pthread

[dpdk-dev] [PATCH 3/3] doc/windows: clarify installation for MinGW-w64

2020-06-20 Thread Dmitry Kozlyuk
Provide a more direct link for installer download and clarify thread model choice during installation. As pthread is not a requirement, remove notice about its possible runtime dependency. Signed-off-by: Dmitry Kozlyuk --- doc/guides/windows_gsg/build_dpdk.rst | 12 +++- doc/guides/windo

[dpdk-dev] [PATCH 2/3] config/x86: don't use absolute paths for MinGW-w64 cross toolchain

2020-06-20 Thread Dmitry Kozlyuk
Absolute paths in Meson cross-file impose unnecessary limitation on build environment, remove them. Signed-off-by: Dmitry Kozlyuk --- config/x86/meson_mingw.txt | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/config/x86/meson_mingw.txt b/config/x86/meson_mingw.tx

Re: [dpdk-dev] [PATCH v6 9/9] build: generate version.map file for MingW on Windows

2020-06-20 Thread Tal Shnaiderman
Thanks Dmitry, Using libname is the correct way in drivers/meson.build. I'll modify lib/meson.build to use libname for consistency. > -Original Message- > From: Dmitry Kozlyuk > Sent: Saturday, June 20, 2020 9:55 PM > To: Tal Shnaiderman > Cc: dev@dpdk.org; Thomas Monjalon ; > pallavi.k

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-20 Thread Matan Azrad
Hi Maxime From: Maxime Coquelin: > Hi Matan, > > On 6/19/20 3:11 PM, Matan Azrad wrote: > > Hi Maxime > > > > Thanks for the fast review. > > This is first version, let's review it carefully to be sure it is correct. > > @Xiao Wang, it will be good to hear your idea too. > > We also need to under

Re: [dpdk-dev] [PATCH v1 1/4] vhost: support host notifier queue configuration

2020-06-20 Thread Matan Azrad
Hi Maxime From: Maxime Coquelin: > On 6/19/20 3:28 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> On 6/18/20 6:28 PM, Matan Azrad wrote: > >>> As an arrangement to per queue operations in the vDPA device it is > >>> needed to change the next experimental API: > >>> > >>> The API ``

Re: [dpdk-dev] [PATCH v6 9/9] build: generate version.map file for MingW on Windows

2020-06-20 Thread Tal Shnaiderman
> Subject: Re: [PATCH v6 9/9] build: generate version.map file for MingW on > Windows > > On Fri, 19 Jun 2020 00:15:46 +0300 > tal...@mellanox.com wrote: > > > From: Tal Shnaiderman > > > > The MingW build for Windows has special cases where exported function > > contain additional prefix: > > >