[dpdk-dev] [PATCH 26/27] event/dlb: add dequeue, dequeue_burst, and variants

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 814 +++ 1 file changed, 814 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index fdfe272..49265d9 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 25/27] event/dlb: add enqueue and its burst variants

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 4ba4719..fdfe272 100644 --- a/drivers/event/dlb/dlb.c +++ b/drivers/event/dl

[dpdk-dev] [PATCH 27/27] event/dlb: add eventdev_stop and eventdev_close

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 263 +++ 1 file changed, 263 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 49265d9..3b429a5 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 24/27] event/dlb: add timeout_ticks, dump, xstats, and selftest

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index d93b159..4ba4719 100644 --- a/drivers/event/dlb/dlb.c +++ b/drivers/event/dl

[dpdk-dev] [PATCH 19/27] event/dlb: add port_setup

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 1235 +++ 1 file changed, 1235 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index ded3b18..796b496 100644 --- a/drivers/event/dlb

[dpdk-dev] [PATCH 18/27] event/dlb: add queue setup

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 295 +++ 1 file changed, 295 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index b527f2c..ded3b18 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 22/27] event/dlb: add port_unlink and port_unlinks_in_progress

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 166 +++ 1 file changed, 166 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index fb96551..ac97f4d 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 20/27] event/dlb: add port_link

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 303 +++ 1 file changed, 303 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 796b496..786c252 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 23/27] event/dlb: add eventdev_start

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 142 +++ 1 file changed, 142 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index ac97f4d..d93b159 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 21/27] event/dlb: add queue_release and port_release

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 786c252..fb96551 100644 --- a/drivers/event/dlb/dlb.c +++ b/drivers/eve

[dpdk-dev] [PATCH 17/27] event/dlb: add queue_def_conf and port_def_conf

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index b864253..b527f2c 100644 --- a/drivers/event/dlb/dlb.c +++ b/drive

[dpdk-dev] [PATCH 15/27] event/dlb: add probe

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile|1 + drivers/event/dlb/dlb.c | 517 + drivers/event/dlb/meson.build |3 +- 3 files changed, 520 insertions(+), 1 deletion(-) create mode 100644 d

[dpdk-dev] [PATCH 13/27] event/dlb: add xstats support

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile |1 + drivers/event/dlb/dlb_xstats.c | 1249 drivers/event/dlb/meson.build |3 +- 3 files changed, 1252 insertions(+), 1 deletion(-) create mode 10064

[dpdk-dev] [PATCH 16/27] event/dlb: add infos_get and configure

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 401 +++ 1 file changed, 401 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index c635deb..b864253 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 14/27] event/dlb: add PMD self-tests

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile |1 + drivers/event/dlb/dlb_selftest.c | 1564 ++ drivers/event/dlb/meson.build|3 +- 3 files changed, 1567 insertions(+), 1 deletion(-) create mode 1

[dpdk-dev] [PATCH 09/27] event/dlb: add inline functions used in multiple files

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_inline_fns.h | 80 1 file changed, 80 insertions(+) create mode 100644 drivers/event/dlb/dlb_inline_fns.h diff --git a/drivers/event/dlb/dlb_inline_fns.h b/drivers/even

[dpdk-dev] [PATCH 12/27] event/dlb: add the PMD's public interfaces

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile |2 + drivers/event/dlb/meson.build |4 +- drivers/event/dlb/rte_pmd_dlb.c | 38 + drivers/event/dlb/rte_pmd_dlb.h

[dpdk-dev] [PATCH 10/27] event/dlb: add PFPMD-specific interface layer to shared code

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile |2 + drivers/event/dlb/meson.build |4 +- drivers/event/dlb/pf/dlb_main.c | 609 ++ drivers/event/dlb/pf/dlb_main.h | 54 +++ drivers/event/dlb/pf/dlb_pf.c

[dpdk-dev] [PATCH 08/27] event/dlb: add definitions shared with LKM or shared code

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_user.h | 1083 ++ 1 file changed, 1083 insertions(+) create mode 100644 drivers/event/dlb/dlb_user.h diff --git a/drivers/event/dlb/dlb_user.h b/drivers/event/dlb/dlb_u

[dpdk-dev] [PATCH 11/27] event/dlb: add flexible PMD to device interfaces

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" The PMD uses function pointers so that it can be executed as a bifurcated PMD accessing hardware via a linux kernel mode driver, or as a PF PMD where it has complete control of the hardware device. Note that this interface is not used in the data path. Signed-off-by: M

[dpdk-dev] [PATCH 07/27] event/dlb: add private data structures and constants

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_priv.h | 564 ++ 1 file changed, 564 insertions(+) create mode 100644 drivers/event/dlb/dlb_priv.h diff --git a/drivers/event/dlb/dlb_priv.h b/drivers/event/dlb/dlb_pr

[dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_log.h | 24 1 file changed, 24 insertions(+) create mode 100644 drivers/event/dlb/dlb_log.h diff --git a/drivers/event/dlb/dlb_log.h b/drivers/event/dlb/dlb_log.h new file mode 1006

[dpdk-dev] [PATCH 05/27] event/dlb: add DLB documentation

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- doc/guides/eventdevs/dlb.rst | 497 ++ 1 file changed, 497 insertions(+) create mode 100644 doc/guides/eventdevs/dlb.rst diff --git a/doc/guides/eventdevs/dlb.rst b/doc/guides/eventdevs/dlb

[dpdk-dev] [PATCH 04/27] event/dlb: add make and meson build infrastructure

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- config/common_base| 19 ++- config/rte_config.h |8 +++- drivers/event/Makefile|7 +++ drivers/event/dlb/Makefile| 27 +++ drivers/event/d

[dpdk-dev] [PATCH 00/27] event/dlb Intel DLB PMD

2020-06-26 Thread Tim McDaniel
Hello Jerin and the DPDK community. The following patchset adds support for a new eventdev PMD. The DLB PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. The DLB is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. T

[dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" Previous implementation traced u8 disable_impl_release, which is now a bit field contained in the new u32 event_port_cfg field. Signed-off-by: McDaniel, Timothy --- lib/librte_eventdev/rte_event_crypto_adapter.c |2 +- lib/librte_eventdev/rte_event_eth_tx_adapter.

[dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-06-26 Thread Tim McDaniel
From: "McDaniel, Timothy" The DLB hardware does not conform exactly to the eventdev interface. 1) It has a limit on the number of queues that may be linked to a port. 2) Some ports a further restricted to a maximum of 1 linked queue. 3) It does not (currently) have the ability to carry the flow_i

[dpdk-dev] [PATCH v1 4/5] net/hinic: add tcam filter switch for FDIR

2020-06-26 Thread Xiaoyun wang
When the filter rule needs to use the TCAM method, PMD driver enables the TCAM filter switch, otherwise disables it, which can improve the performance of microcode in FDIR scenarios that not use TCAM method. Fixes: 1fe89aa37f36 ("net/hinic: add flow director filter") Cc: sta...@dpdk.org Signed-of

[dpdk-dev] [PATCH v1 3/5] net/hinic: fix setting promiscuous mode problem

2020-06-26 Thread Xiaoyun wang
When setting promiscuous or allmulticast mode, increase multi-thread resource protection, because the patch "net/bonding: prefer allmulti to promiscuous for LACP" adds trying to use allmulti when adding a slave, and EVS bond driver also sets promisc with another thread, which may lead to thread ree

[dpdk-dev] [PATCH v1 5/5] net/hinic/base: modify return errors

2020-06-26 Thread Xiaoyun wang
Modify return errors with linux system errors when system requests fail. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cfg.c| 4 +- drivers/net/hinic/base/hinic_pmd_hwdev.c | 16 ++--- drivers/net/hinic/base/hinic_pmd_hwif.c | 4 +- drivers/net/hinic/base/hinic_pmd

[dpdk-dev] [PATCH v1 0/5] fix promisc and tcam problem

2020-06-26 Thread Xiaoyun wang
This patch adds multi-thread resource protection when setting promiscuous or allmulticast mode, adds bufout and out size parameter for mgmt sync channel and removes unused parameters for mgmt channel with no ack, adds TCAM filter switch for FDIR, and modifies return errors. -- v1: - add out par

[dpdk-dev] [PATCH v1 2/5] net/hinic/base: remove unused parameter

2020-06-26 Thread Xiaoyun wang
Remove unused parameters for mgmt channel with no ack. Fixes: a4957d87e05a ("net/hinic/base: add mgmt module") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_hwdev.c | 2 +- drivers/net/hinic/base/hinic_pmd_mgmt.c | 3 +-- drivers/net/hinic/base/hinic_pmd_

[dpdk-dev] [PATCH v1 1/5] net/hinic/base: add out parameter for mgmt sync channel

2020-06-26 Thread Xiaoyun wang
Add bufout and out size info for some cmds that use mgmt sync channel, which can improve dfx capability when send msg failed. Fixes: 7fcd6b05b923 ("net/hinic/base: support cmdq mechanism") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cmdq.c | 31 --

Re: [dpdk-dev] [PATCH v9 00/10] Windows bus/pci support

2020-06-26 Thread Narcisa Ana Maria Vasile
On Wed, Jun 24, 2020 at 11:28:37AM +0300, tal...@mellanox.com wrote: > From: Tal Shnaiderman > > This patchset implements the EAL and PCI functions needed for probing PMDs > using RTE_KDRV_NONE on Windows. > > --- > v9: > * Split the patch of common OS file to config and options patches

Re: [dpdk-dev] [PATCH v9 09/10] bus/pci: support Windows with bifurcated drivers

2020-06-26 Thread Narcisa Ana Maria Vasile
On Wed, Jun 24, 2020 at 11:28:46AM +0300, tal...@mellanox.com wrote: > From: Tal Shnaiderman > > Uses SetupAPI.h functions to scan PCI tree. > Uses DEVPKEY_Device_Numa_Node to get the PCI NUMA node. > Uses SPDRP_BUSNUMBER and SPDRP_BUSNUMBER to get the BDF. > scanning currently supports types RTE

[dpdk-dev] [20.11, PATCH] bbdev: remove experimental tag from API

2020-06-26 Thread Nicolas Chautru
This commit promotes the full bbdev interface to stable, starting with the 20.08 major version. Overdue for some time as bbdev interface has been stable. Signed-off-by: Nicolas Chautru --- doc/guides/rel_notes/release_20_08.rst | 2 ++ lib/librte_bbdev/rte_bbdev.h | 31 ---

[dpdk-dev] [20.11, PATCH] bbdev: remove experimental tag from API

2020-06-26 Thread Nicolas Chautru
Planning to move bbdev API to stable from 20.11 (ABI version 21) and remove experimental tag. Sending now to advertise and get any feedback. Some manual rebase will be required later on notably as the actual release note which is not there yet. Nicolas Chautru (1): bbdev: remove experimental

[dpdk-dev] [PATCH v2 4/5] app/testpmd: fix burst percentage calculation

2020-06-26 Thread Honnappa Nagarahalli
The burst % calculation can over flow due to multiplication. Fix the multiplication and increase the size of variables to 64b. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Tested-by: Phil Y

[dpdk-dev] [PATCH v2 5/5] app/testpmd: enable empty polls in burst stats

2020-06-26 Thread Honnappa Nagarahalli
The number of empty polls provides information about available CPU head room in the presence of continuous polling. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Tested-by: Phil Yang Tested-by: Ali Alnubani --- app/test-pmd/csumonly.c | 5 +-- app/test

[dpdk-dev] [PATCH v2 1/5] app/testpmd: clock gettime call in throughput calculation

2020-06-26 Thread Honnappa Nagarahalli
The throughput calculation requires a counter that measures passing of time. However, the kernel saves and restores the PMU state when a thread is unscheduled and scheduled. This ensures that the PMU cycles are not counted towards a thread that is not scheduled. Hence, when RTE_ARM_EAL_RDTSC_USE_PM

[dpdk-dev] [PATCH v2 3/5] app/testpmd: enable burst stats for noisy vnf mode

2020-06-26 Thread Honnappa Nagarahalli
From: Phil Yang Add burst stats for noisy vnf mode. Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode") Cc: sta...@dpdk.org Cc: jfreim...@redhat.com Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang Reviewed-by: Jens Freimann --- app/

[dpdk-dev] [PATCH v2 2/5] app/testpmd: enable burst stats for flowgen mode rx path

2020-06-26 Thread Honnappa Nagarahalli
Enable missing burst stats for rx path for flowgen mode. Fixes: e9e23a617eb8 ("app/testpmd: add flowgen forwarding engine") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Tested-by: Phil Yang --- app/test-pmd/flowgen.c | 4 1 fil

Re: [dpdk-dev] [PATCH] eal: generic counter based loop for CPU freq calculation

2020-06-26 Thread Honnappa Nagarahalli
Hi Jerin, Thanks for the comments. > -Original Message- > From: Jerin Jacob > Sent: Wednesday, June 24, 2020 7:51 AM > To: Honnappa Nagarahalli > Cc: dpdk-dev ; jer...@marvell.com; > hemant.agra...@nxp.com; akhil.go...@nxp.com; ogerl...@mellanox.com; > Ajit Khaparde (ajit.khapa..

[dpdk-dev] [PATCH v2 2/2] eal/arm: change inline functions to always inline

2020-06-26 Thread Honnappa Nagarahalli
Change the inline functions to use __rte_always_inline to be consistent with rest of the inline functions. Signed-off-by: Honnappa Nagarahalli --- lib/librte_eal/arm/include/rte_cycles_64.h | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/arm/inclu

[dpdk-dev] [PATCH v2 1/2] eal/arm: generic counter based loop for CPU freq calculation

2020-06-26 Thread Honnappa Nagarahalli
get_tsc_freq uses 'nanosleep' system call to calculate the CPU frequency. However, 'nanosleep' results in the process getting un-scheduled. The kernel saves and restores the PMU state. This ensures that the PMU cycles are not counted towards a sleeping process. When RTE_ARM_EAL_RDTSC_USE_PMU is def

Re: [dpdk-dev] rte_ether_addr_copy() strange comment

2020-06-26 Thread Stephen Hemminger
On Fri, 26 Jun 2020 17:28:49 + "Van Haaren, Harry" wrote: > > -Original Message- > > From: Yigit, Ferruh > > Sent: Friday, June 26, 2020 4:54 PM > > To: Van Haaren, Harry ; Morten Brørup > > ; dev@dpdk.org > > Cc: Olivier Matz ; Ananyev, Konstantin > > > > Subject: Re: [dpdk-dev] rt

Re: [dpdk-dev] rte_ether_addr_copy() strange comment

2020-06-26 Thread Van Haaren, Harry
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, June 26, 2020 4:54 PM > To: Van Haaren, Harry ; Morten Brørup > ; dev@dpdk.org > Cc: Olivier Matz ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] rte_ether_addr_copy() strange comment > > On 6/26/2020 1:41 PM, Van Haaren, Harry

Re: [dpdk-dev] [PATCH v2 3/4] doc: update build instructions in the Linux guide

2020-06-26 Thread Bruce Richardson
On Thu, Jun 25, 2020 at 11:43:37PM +0200, Thomas Monjalon wrote: > Before removing the "make" build system completely, > the Linux guide instructions are made more concise and accurate. > Some detailed explanations are also available in > doc/guides/prog_guide/dev_kit_root_make_help.rst > > This i

Re: [dpdk-dev] [PATCH] net/octeontx2: update release notes with cn98xx

2020-06-26 Thread Ferruh Yigit
On 6/26/2020 4:02 PM, Harman Kalra wrote: > Updating release notes with information about new > Marvell SOC i.e cn98xx support added to existing > octeontx2 driver. > > Signed-off-by: Harman Kalra > --- > doc/guides/rel_notes/release_20_08.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Re: [dpdk-dev] [PATCH] eal: don't use default library path for static binaries

2020-06-26 Thread Stephen Hemminger
On Fri, 26 Jun 2020 15:59:57 +0100 Bruce Richardson wrote: > When using statically linked DPDK binaries, the EAL checks the default PMD > path and tries to load any drivers there, despite the fact that all drivers > are normally linked into the binary. This behaviour can cause issues if > the PM

Re: [dpdk-dev] [PATCH v2 3/3] mbuf: standardize library debug flag

2020-06-26 Thread Bruce Richardson
On Wed, Apr 22, 2020 at 11:45:55PM +0200, Lukasz Wojciechowski wrote: > Use standardized debug macro RTE_DEBUG_MBUF instead of > RTE_LIBRTE_MBUF_DEBUG for wrapping sanity checks. > > Add runtime control of running sanity checks basing on > rte_log_can_log() function. > > To run mbuf sanity checks

Re: [dpdk-dev] [PATCH v2 1/3] config: introduce global rte debug flag

2020-06-26 Thread Bruce Richardson
On Wed, Apr 22, 2020 at 11:45:53PM +0200, Lukasz Wojciechowski wrote: > A new boolean meson build flag is introduced with this patch: rte_debug. > To enable this option add -Drte_debug=true to the meson configure command. > > By enabling this flag the globaly defined macro RTE_DEBUG becomes > defi

Re: [dpdk-dev] [PATCH v2 2/3] config: remove unused config flags

2020-06-26 Thread Bruce Richardson
On Wed, Apr 22, 2020 at 11:45:54PM +0200, Lukasz Wojciechowski wrote: > Following flags were still present in the common_base config, > but they were not used anywhere in the code: > * CONFIG_RTE_LIBRTE_ACL_DEBUG > * CONFIG_RTE_LIBRTE_NFP_DEBUG_TX > * CONFIG_RTE_LIBRTE_NFP_DEBUG_RX > * CONFIG_RTE_L

[dpdk-dev] [PATCH] net: rte_ether minor optimizations

2020-06-26 Thread Morten Brørup
* rte_is_broadcast_ether_addr(): Use binary logic instead of comparisons and boolean logic, thus reducing the number of branches. It now resembles rte_is_zero_ether_addr(). * rte_ether_addr_copy(): The source code modifications were discussed on the mailing list: http://mails.dpdk.org/archives/dev

[dpdk-dev] [dpdk-announce] [HELP REQUIRED] call for reviews

2020-06-26 Thread Thomas Monjalon
Hi all, Our next milestone is approaching, 20.08-rc1 should be in 12 days : http://core.dpdk.org/roadmap/#dates and the roadmap is very long: http://core.dpdk.org/roadmap/#2008 We all want to have our code reviewed and accepted. In order to have a small hope of reaching our goals,

[dpdk-dev] [PATCH 2/2] doc: update octeontx platform guide

2020-06-26 Thread Harman Kalra
Removing make build instructions from the platform guide as building DPDK sources using 'make' will be deprecated in future releases. Signed-off-by: Harman Kalra --- doc/guides/platform/octeontx.rst | 52 ++-- 1 file changed, 22 insertions(+), 30 deletions(-) diff --

[dpdk-dev] [PATCH 1/2] doc: update octeontx2 platform guide

2020-06-26 Thread Harman Kalra
Removing make build instructions from the platform guide as building DPDK sources using 'make' will be deprecated in future releases. Signed-off-by: Harman Kalra --- doc/guides/platform/octeontx2.rst | 29 + 1 file changed, 5 insertions(+), 24 deletions(-) diff --git

Re: [dpdk-dev] rte_ether_addr_copy() strange comment

2020-06-26 Thread Ferruh Yigit
On 6/26/2020 1:41 PM, Van Haaren, Harry wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, June 26, 2020 1:08 PM >> To: Morten Brørup ; dev@dpdk.org >> Cc: Olivier Matz ; Van Haaren, Harry >> ; Ananyev, Konstantin >> >> Subject: Re: [dpdk-dev] rte_ether_addr_copy() stran

Re: [dpdk-dev] [PATCH] common/octeontx2: retry intr callback unregister

2020-06-26 Thread Jerin Jacob
On Thu, Jun 11, 2020 at 1:06 PM Nithin Dabilpuram wrote: > > Interrupt callback unregister can fail with -EAGAIN > when interrupt handler is active in interrupt thread. > Hence retry before reporting a failure or proceeding further. > > Signed-off-by: Nithin Dabilpuram Acked-by: Jerin Jacob De

Re: [dpdk-dev] [PATCH v2 2/6] security: add support for DOCSIS protocol

2020-06-26 Thread Coyle, David
Hi Pablo > -Original Message- > From: De Lara Guarch, Pablo > > +/** > > + * DOCSIS security session configuration. > > + * > > + * This structure contains data required to create a DOCSIS security > session. > > + */ > > +struct rte_security_docsis_xform { > > + enum rte_security_docsi

Re: [dpdk-dev] [PATCH v2 5/6] test/crypto: add DOCSIS security test cases

2020-06-26 Thread Coyle, David
Hi Pablo > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, June 23, 2020 7:04 PM > > > +static int > > +test_docsis_proto_uplink(int i, struct docsis_test_data *d_td) { > > + struct rte_security_op *sec_op; > > + struct rte_security_docsis_op *doc_op; > > + struct

Re: [dpdk-dev] [PATCH v2 3/6] crypto/aesni_mb: add support for DOCSIS protocol

2020-06-26 Thread Coyle, David
Hi Pablo, thank you for the comments > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, June 23, 2020 6:57 PM > > > +static inline void > > +verify_docsis_sec_crc(JOB_AES_HMAC *job, uint16_t crc_len, uint8_t > > +*status) { > > + uint16_t crc_offset; > > + uint8_t *c

[dpdk-dev] [PATCH] net/octeontx2: update release notes with cn98xx

2020-06-26 Thread Harman Kalra
Updating release notes with information about new Marvell SOC i.e cn98xx support added to existing octeontx2 driver. Signed-off-by: Harman Kalra --- doc/guides/rel_notes/release_20_08.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/

Re: [dpdk-dev] [PATCH v4 4/9] eal: introduce thread uninit helper

2020-06-26 Thread Jerin Jacob
On Fri, Jun 26, 2020 at 8:18 PM David Marchand wrote: > > This is a preparation step for dynamically unregistering threads. > > Since we explicitly allocate a per thread trace buffer in > rte_thread_init, add an internal helper to free this buffer. > > Signed-off-by: David Marchand > --- > Note:

[dpdk-dev] [PATCH] eal: don't use default library path for static binaries

2020-06-26 Thread Bruce Richardson
When using statically linked DPDK binaries, the EAL checks the default PMD path and tries to load any drivers there, despite the fact that all drivers are normally linked into the binary. This behaviour can cause issues if the PMD path and lib dir is configured to a non-standard location which is

Re: [dpdk-dev] [PATCH v4 9/9] mempool/bucket: handle non-EAL lcores

2020-06-26 Thread Andrew Rybchenko
On 6/26/20 5:47 PM, David Marchand wrote: > Convert to new lcore API to support non-EAL lcores. > > Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko

[dpdk-dev] [PATCH v4 7/9] eal: add lcore init callbacks

2020-06-26 Thread David Marchand
DPDK components and applications can have their say when a new lcore is initialized. For this, they can register a callback for initializing and releasing their private data. Signed-off-by: David Marchand --- Changes since v2: - added missing test, - fixed rollback on lcore register, Changes sin

[dpdk-dev] [PATCH v4 8/9] eal: add lcore iterators

2020-06-26 Thread David Marchand
Add a helper to iterate all lcores. The iterator callback is read-only wrt the lcores list. Implement a dump function on top of this for debugging. Signed-off-by: David Marchand --- Changes since v2: - added rte_lcore_dump calls in unit test, for basic check, Changes since v1: - introduced lcor

[dpdk-dev] [PATCH v4 9/9] mempool/bucket: handle non-EAL lcores

2020-06-26 Thread David Marchand
Convert to new lcore API to support non-EAL lcores. Signed-off-by: David Marchand --- Changes since v3: - addressed Andrew comments, --- drivers/mempool/bucket/rte_mempool_bucket.c | 130 1 file changed, 81 insertions(+), 49 deletions(-) diff --git a/drivers/mempool/bucket

[dpdk-dev] [PATCH v4 6/9] eal: register non-EAL threads as lcores

2020-06-26 Thread David Marchand
DPDK allows calling some part of its API from a non-EAL thread but this has some limitations. OVS (and other applications) has its own thread management but still want to avoid such limitations by hacking RTE_PER_LCORE(_lcore_id) and faking EAL threads potentially unknown of some DPDK component. I

[dpdk-dev] [PATCH v4 3/9] eal: introduce thread init helper

2020-06-26 Thread David Marchand
Introduce a helper responsible for initialising the per thread context. We can then have a unified context for EAL and non-EAL threads and remove copy/paste'd OS-specific helpers. Per EAL thread CPU affinity setting is separated from the thread init. It is to accommodate with Windows EAL where CPU

[dpdk-dev] [PATCH v4 4/9] eal: introduce thread uninit helper

2020-06-26 Thread David Marchand
This is a preparation step for dynamically unregistering threads. Since we explicitly allocate a per thread trace buffer in rte_thread_init, add an internal helper to free this buffer. Signed-off-by: David Marchand --- Note: I preferred renaming the current internal function to free all threads

[dpdk-dev] [PATCH v4 5/9] eal: move lcore role code

2020-06-26 Thread David Marchand
For consistency sake, move all lcore role code in the dedicated compilation unit / header. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_lcore.c | 11 +++ lib/librte_eal/common/eal_common_thread.c | 11 --- lib/librte_eal/include/rte_eal.h | 9 -- lib/

[dpdk-dev] [PATCH v4 0/9] Register non-EAL threads as lcore

2020-06-26 Thread David Marchand
OVS and some other applications have been hacking into DPDK internals to fake EAL threads and avoid performance penalty of only having non-EAL threads. This series proposes to add a new type of lcores and maps those threads to such lcores. non-EAL threads won't run the DPDK eal mainloop. As a cons

[dpdk-dev] [PATCH v4 2/9] eal: fix multiple definition of per lcore thread id

2020-06-26 Thread David Marchand
Because of the inline accessor + static declaration in rte_gettid(), we end up with multiple symbols for RTE_PER_LCORE(_thread_id). Each compilation unit will pay a cost when accessing this information for the first time. $ nm build/app/dpdk-testpmd | grep per_lcore__thread_id 0054 d p

[dpdk-dev] [PATCH v4 1/9] eal: relocate per thread symbols to common

2020-06-26 Thread David Marchand
We have per lcore thread symbols scattered in OS implementations but common code relies on them. Move all of them in common. RTE_PER_LCORE(_socket_id) and RTE_PER_LCORE(_cpuset) have public accessors and are not exported through the library map, they can be made static. Signed-off-by: David March

Re: [dpdk-dev] [PATCH v3 00/14] vDPA API and framework rework

2020-06-26 Thread Adrian Moreno
On 6/26/20 4:04 PM, Maxime Coquelin wrote: > This series aims to rework the vDPA framework and > its API to better fit into the DPDK device model > and also be more easily consumable by applications. > > Main changes are creating a device class for vDPA, > which enables applications to iterate

Re: [dpdk-dev] [PATCH v3 09/14] vhost: use linked-list for vDPA devices

2020-06-26 Thread Adrian Moreno
On 6/26/20 4:04 PM, Maxime Coquelin wrote: > There is no more notion of device ID outside of vdpa.c. > We can now move from array to linked-list model for keeping > track of the vDPA devices. > > There is no point in using array here, as all vDPA API are > used from the control path, so no perf

Re: [dpdk-dev] [PATCH v1 2/2] vhost: introduce async enqueue for split ring

2020-06-26 Thread Maxime Coquelin
On 6/11/20 12:02 PM, patrick...@intel.com wrote: > From: Patrick > > This patch implement async enqueue data path for split ring. > > Signed-off-by: Patrick > --- > lib/librte_vhost/rte_vhost_async.h | 38 +++ > lib/librte_vhost/virtio_net.c | 538 > ++

Re: [dpdk-dev] [RFC PATCH] log: track log level changes

2020-06-26 Thread Andrew Rybchenko
On 6/26/20 2:47 PM, David Marchand wrote: > Add a log message when changing log levels to be sure of which logtype > is enabled. > > Suggested-by: Ilya Maximets > Signed-off-by: David Marchand Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v1 1/2] vhost: introduce async data path registration API

2020-06-26 Thread Maxime Coquelin
On 6/11/20 12:02 PM, patrick...@intel.com wrote: > From: Patrick > > This patch introduces registration/un-registration APIs > for async data path together with all required data > structures and DMA callback function proto-types. > > Signed-off-by: Patrick > --- > lib/librte_vhost/Makefile

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-26 Thread David Marchand
On Wed, Jun 24, 2020 at 1:59 PM Ananyev, Konstantin wrote: > > > Do you mean - make this new dynamic-lcore API return an error if callied > > > from secondary process? > > > > > > > Yes, and prohibiting from attaching a secondary process if dynamic > > lcore API has been used in primary. > > I int

Re: [dpdk-dev] [PATCH v1 0/2] introduce asynchronous data path for vhost

2020-06-26 Thread Maxime Coquelin
Hi Patrick, On 6/11/20 12:02 PM, patrick...@intel.com wrote: > From: Patrick Fu > > Performing large memory copies usually takes up a major part of CPU > cycles and becomes the hot spot in vhost-user enqueue operation. To > offload expensive memory operations from the CPU, this patch set > propo

Re: [dpdk-dev] [PATCH] net/octeontx2: fix seg fault on running procinfo

2020-06-26 Thread Jerin Jacob
On Mon, May 25, 2020 at 2:21 PM Harman Kalra wrote: > > Segmentation fault has been observed while running procinfo > with reset options i.e. --stats-reset and --xstats-reset. > Reason is procinfo runs as a secondary process and tries to > hold a lock which is part of struct mdev, which was not >

Re: [dpdk-dev] [PATCH v1 2/2] vhost: introduce async enqueue for split ring

2020-06-26 Thread Maxime Coquelin
On 6/11/20 12:02 PM, patrick...@intel.com wrote: > From: Patrick > > This patch implement async enqueue data path for split ring. A bit more verbose commit message would be helpful since the cover letter won't be in the git history. Duplicating relevant parts from the cover letter would be su

Re: [dpdk-dev] rte_ether_addr_copy() strange comment

2020-06-26 Thread Jerin Jacob
On Fri, Jun 26, 2020 at 6:05 PM Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > > Sent: Friday, June 26, 2020 2:08 PM > > > > On 6/25/2020 4:45 PM, Morten Brørup wrote: > > > The function rte_ether_addr_copy() checks for __INTEL_COMPILER and > > has

Re: [dpdk-dev] [PATCH v3 9/9] mempool/bucket: handle non-EAL lcores

2020-06-26 Thread Andrew Rybchenko
On 6/26/20 5:13 PM, David Marchand wrote: > On Tue, Jun 23, 2020 at 7:28 PM Andrew Rybchenko > wrote: >> >> On 6/22/20 4:25 PM, David Marchand wrote: >>> Convert to new lcore API to support non-EAL lcores. >>> >>> Signed-off-by: David Marchand >>> --- [snip] >>> + bd->adoption_buffer_rings[

Re: [dpdk-dev] [PATCH v1 1/2] vhost: introduce async data path registration API

2020-06-26 Thread Maxime Coquelin
On 6/11/20 12:02 PM, patrick...@intel.com wrote: > From: Patrick > > This patch introduces registration/un-registration APIs > for async data path together with all required data > structures and DMA callback function proto-types. > > Signed-off-by: Patrick > --- > lib/librte_vhost/Makefile

Re: [dpdk-dev] [PATCH v4] bus/pci: fix VF bus error for memory access

2020-06-26 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Friday, June 26, 2020 17:17 > To: Wang, Haiyue > Cc: Kevin Traynor ; Luca Boccassi ; > dev ; Burakov, > Anatoly ; dpdk stable ; Harman > Kalra > Subject: Re: [PATCH v4] bus/pci: fix VF bus error for memory access > > On Thu, Jun 25,

Re: [dpdk-dev] [PATCH v3 9/9] mempool/bucket: handle non-EAL lcores

2020-06-26 Thread David Marchand
On Tue, Jun 23, 2020 at 7:28 PM Andrew Rybchenko wrote: > > On 6/22/20 4:25 PM, David Marchand wrote: > > Convert to new lcore API to support non-EAL lcores. > > > > Signed-off-by: David Marchand > > --- > > drivers/mempool/bucket/rte_mempool_bucket.c | 131 > > 1 file chang

[dpdk-dev] [PATCH v3 11/14] examples/vdpa: use new wrappers instead of ops

2020-06-26 Thread Maxime Coquelin
Now that wrappers to query number of queues, Virtio features and Vhost-user protocol features are available, let's make the vDPA example to use them. Acked-by: Adrián Moreno Signed-off-by: Maxime Coquelin --- examples/vdpa/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v3 12/14] examples/vdpa: remove useless device count

2020-06-26 Thread Maxime Coquelin
The VDPA example now uses the vDPA class iterator, so knowing the number of available devices beforehand is no longer needed. Acked-by: Adrián Moreno Signed-off-by: Maxime Coquelin --- examples/vdpa/main.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/examples/vdp

[dpdk-dev] [PATCH v3 14/14] vhost: split vDPA header file

2020-06-26 Thread Maxime Coquelin
This patch split the vDPA header file in two, making rte_vdpa_device structure opaque to the application. Applications should only include rte_vdpa.h, while drivers should include both rte_vdpa.h and rte_vdpa_dev.h. Acked-by: Adrián Moreno Signed-off-by: Maxime Coquelin --- drivers/vdpa/ifc/if

[dpdk-dev] [PATCH v3 13/14] vhost: remove vDPA device count API

2020-06-26 Thread Maxime Coquelin
This API is no more useful, this patch removes it. Acked-by: Adrián Moreno Signed-off-by: Maxime Coquelin --- lib/librte_vhost/rte_vdpa.h| 13 - lib/librte_vhost/rte_vhost_version.map | 1 - lib/librte_vhost/vdpa.c| 9 - 3 files changed, 23 dele

[dpdk-dev] [PATCH v3 07/14] vhost: replace device ID in applications

2020-06-26 Thread Maxime Coquelin
This patch replaces the use of vDPA device ID with vDPA device pointer. The goals is to remove the vDPA device ID to avoid condusion with the Vhost ID. Acked-by: Adrián Moreno Signed-off-by: Maxime Coquelin --- examples/vdpa/main.c | 118 + lib/librte_v

[dpdk-dev] [PATCH v3 10/14] vhost: introduce wrappers for some vDPA ops

2020-06-26 Thread Maxime Coquelin
This patch is preliminary work to make the vDPA device structure opaque to the user application. Some callbacks of the vDPA devices are used to query capabilities before attaching to a Vhost port. This patch introduces wrappers for these ops. Acked-by: Adrián Moreno Signed-off-by: Maxime Coquelin

[dpdk-dev] [PATCH v3 08/14] vhost: remove useless vDPA API

2020-06-26 Thread Maxime Coquelin
vDPA is no more used outside of the vDPA internals, so remove rte_vdpa_get_device() API that is now useless. Acked-by: Adrián Moreno Signed-off-by: Maxime Coquelin --- lib/librte_vhost/rte_vdpa.h| 30 - lib/librte_vhost/rte_vhost_version.map | 1 - lib/librte_vhost/

[dpdk-dev] [PATCH v3 09/14] vhost: use linked-list for vDPA devices

2020-06-26 Thread Maxime Coquelin
There is no more notion of device ID outside of vdpa.c. We can now move from array to linked-list model for keeping track of the vDPA devices. There is no point in using array here, as all vDPA API are used from the control path, so no performance concerns. Signed-off-by: Maxime Coquelin --- li

[dpdk-dev] [PATCH v3 06/14] vhost: replace vDPA device ID in Vhost

2020-06-26 Thread Maxime Coquelin
This removes the notion of device ID in Vhost library as a preliminary step to get rid of the vDPA device ID. Acked-by: Adrián Moreno Signed-off-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 12 drivers/vdpa/mlx5/mlx5_vdpa.c | 18 --- examples/vdpa/m

[dpdk-dev] [PATCH v3 05/14] vhost: replace device ID in vDPA ops

2020-06-26 Thread Maxime Coquelin
This patch is a preliminary step to get rid of the vDPA device ID. It makes vDPA callbacks to use the vDPA device struct as a reference instead of the ID. Acked-by: Adrián Moreno Signed-off-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 79 ++-- drivers/vdpa/mlx5/mlx5_

  1   2   >