[dpdk-dev] [PATCH v5] net/i40e: fix qps configuration in VF

2020-07-15 Thread alvinx . zhang
From: Alvin Zhang If a VF request PF to allocate more number of queue pairs, the PF will free the queue pairs which have been allocated and reset the VF. So, VF should stop to work until all the process is done. This patch modify the process of the request queue pairs. To improve efficiency and e

[dpdk-dev] [PATCH v1] net/mlx5: return EAGAIN on premature disable interrupt calls

2020-07-15 Thread Ophir Munk
RXQ interrupts under Linux are based on the epoll mechanism. An expected order of operations is as follows: 1. Call rte_eth_dev_rx_intr_enable(), to arm the CQ for receiving events on data input. 2. Block on rte_epoll_wait() with an array of file descriptors representing the CQ events. Upon data ar

[dpdk-dev] [PATCH] lpm: fix unchecked return value

2020-07-15 Thread Ruifeng Wang
Coverity complains about unchecked return value of rte_rcu_qsbr_dq_enqueue. By default, defer queue size is big enough to hold all tbl8 groups. When enqueue fails, return error to the user to indicate system issue. Coverity issue: 360832 Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")

[dpdk-dev] [PATCH v5] net/i40e: fix modify the number of qps in VF

2020-07-15 Thread alvinx . zhang
From: Alvin Zhang If a VF request PF to allocate more number of queue pairs, the PF will free the queue pairs which have been allocated and reset the VF. So, VF should stop to work until all the process is done. This patch modify the process of the request queue pairs. To improve efficiency and e

Re: [dpdk-dev] [PATCH v5] net/i40e: fix modify the number of qps in VF

2020-07-15 Thread Zhang, AlvinX
Thanks Qiming, I have updated it and resubmitted the patch. > -Original Message- > From: Yang, Qiming > Sent: Thursday, July 16, 2020 12:58 PM > To: Zhang, AlvinX ; Guo, Jia > Cc: Xing, Beilei ; dev@dpdk.org; Zhang, AlvinX > ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5] net/i40e

Re: [dpdk-dev] [PATCH v2 9/9] crypto/octeontx2: add cryptodev sec dequeue routine

2020-07-15 Thread Tejasree Kondoj
Hi Akhil, Please see inline. Thanks Tejasree > -Original Message- > From: Akhil Goyal > Sent: Wednesday, July 15, 2020 10:40 PM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Vamsi Krishna Attunuru ; Narayana Prasad > Raju Athreya ; Anoob Joseph > ; dev@dpdk.org > Subject: [EXT] RE: [PAT

Re: [dpdk-dev] [PATCH v2 4/9] crypto/octeontx2: add cryptodev sec registration

2020-07-15 Thread Tejasree Kondoj
Hi Akhil, Please see inline. Thanks Tejasree > -Original Message- > From: Akhil Goyal > Sent: Wednesday, July 15, 2020 10:28 PM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Narayana Prasad Raju Athreya ; Anoob Joseph > ; Vamsi Krishna Attunuru ; > dev@dpdk.org > Subject: [EXT] RE: [PAT

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net/i40e: fixed misplaced arguments

2020-07-15 Thread Muhammad Bilal
Yes, This is the patch for the same bug, Which is already fixed. So this duplicate patch can be ignored. On Tue, Jul 14, 2020 at 9:54 PM Ferruh Yigit wrote: > > On 7/14/2020 4:58 PM, Muhammad Bilal wrote: > > Here I have corrected a misplaced argument of i40e_aq_get_phy_register() > > This was al

[dpdk-dev] [PATCH v8 3/3] eal/atomic: add wrapper for C11 atomic thread fence

2020-07-15 Thread Phil Yang
Provide a wrapper for __atomic_thread_fence built-in to support optimized code for __ATOMIC_SEQ_CST memory order for x86 platforms. Suggested-by: Honnappa Nagarahalli Signed-off-by: Phil Yang Reviewed-by: Ola Liljedahl Acked-by: Konstantin Ananyev --- lib/librte_eal/arm/include/rte_atomic_32.

[dpdk-dev] [PATCH v8 0/3] generic rte atomic APIs deprecate proposal

2020-07-15 Thread Phil Yang
DPDK provides generic rte_atomic APIs to do several atomic operations. These APIs are using the deprecated __sync built-ins and enforce full memory barriers on aarch64. However, full barriers are not necessary in many use cases. In order to address such use cases, C language offers C11 atomic APIs.

[dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-15 Thread Phil Yang
In order to deprecate the rte_atomic and rte_smp barrier APIs, prevent the patches from using these APIs in the converted modules and compilers __sync built-ins in all modules. The converted modules: lib/librte_distributor lib/librte_hash lib/librte_kni lib/librte_lpm lib/librte_rcu lib/librte_rin

Re: [dpdk-dev] [PATCH v5] net/i40e: fix modify the number of qps in VF

2020-07-15 Thread Yang, Qiming
> -Original Message- > From: dev On Behalf Of alvinx.zh...@intel.com > Sent: Thursday, July 16, 2020 12:24 > To: Guo, Jia > Cc: Xing, Beilei ; dev@dpdk.org; Zhang, AlvinX > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v5] net/i40e: fix modify the number of qps in VF Fix and modify a

[dpdk-dev] [PATCH v8 1/3] doc: add optimizations using C11 atomic built-ins

2020-07-15 Thread Phil Yang
Add information about possible optimizations using C11 atomic built-ins. Signed-off-by: Phil Yang Signed-off-by: Honnappa Nagarahalli --- doc/guides/prog_guide/writing_efficient_code.rst | 59 +++- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/doc/guides/prog

[dpdk-dev] [PATCH v5] net/i40e: fix modify the number of qps in VF

2020-07-15 Thread alvinx . zhang
From: Alvin Zhang If a VF request PF to allocate more number of queue pairs, the PF will free the queue pairs which have been allocated and reset the VF. So, VF should stop to work until all the process is done. This patch modify the process of the request queue pairs. To improve efficiency and e

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-15 Thread Phil Yang
David Marchand writes: > Subject: Re: [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt > operations > > On Thu, Jul 9, 2020 at 5:59 PM Phil Yang wrote: > > > > Use C11 atomic built-ins with explicit ordering instead of rte_atomic > > ops which enforce unnecessary barriers on aarch64. >

Re: [dpdk-dev] [PATCH v5] net/ice: fix invalid RSS type

2020-07-15 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Thursday, July 16, 2020 11:25 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > ; Xu, Ting ; Su, Simei > > Subject: [PATCH v5] net/ice: fix invalid RSS type > > When a RSS rule with only SRC/DST_ONLY or IPV6 prefix RSS t

Re: [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user

2020-07-15 Thread Xia, Chenbo
Hi Adrian, > -Original Message- > From: Adrian Moreno > Sent: Thursday, July 16, 2020 1:18 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Wang, Zhihong ; > amore...@redhat.com; Xia, Chenbo > Subject: [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user > > This patch a

Re: [dpdk-dev] [PATCH v2] net/ice: fix tunnel type get error

2020-07-15 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Thursday, July 16, 2020 9:42 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH v2] net/ice: fix tunnel type get error > > When function ice_get_tun_type_for_recipe() get tunnel type, for > ICE_NON_TUN we need to incl

[dpdk-dev] [PATCH v5] net/ice: fix invalid RSS type

2020-07-15 Thread Simei Su
When a RSS rule with only SRC/DST_ONLY or IPV6 prefix RSS type, it should return failure. Besides, when a RSS rule with symmetric hash function, the RSS type shouldn't carry with SRC/DST_ONLY. This patch adds invalid RSS type check for the two cases. Fixes: 0b952714e9c1 ("net/ice: refactor PF hash

Re: [dpdk-dev] [PATCH 3/5] net/virtio: add VIRTIO_SET_STATUS support to Virtio-user

2020-07-15 Thread Xia, Chenbo
Hi Adrian, > -Original Message- > From: Adrian Moreno > Sent: Thursday, July 16, 2020 1:18 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Wang, Zhihong ; > amore...@redhat.com; Xia, Chenbo > Subject: [PATCH 3/5] net/virtio: add VIRTIO_SET_STATUS support to Virtio-user > > From:

Re: [dpdk-dev] [PATCH v4] net/ice: fix invalid RSS type

2020-07-15 Thread Su, Simei
Hi, Qi > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, July 15, 2020 10:13 PM > To: Su, Simei > Cc: dev@dpdk.org; Guo, Junfeng ; Guo, Jia > ; Xu, Ting > Subject: RE: [PATCH v4] net/ice: fix invalid RSS type > > > > > -Original Message- > > From: Su, Simei > > Sen

Re: [dpdk-dev] [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit

2020-07-15 Thread Xia, Chenbo
Hi Adrian, > -Original Message- > From: Adrian Moreno > Sent: Thursday, July 16, 2020 1:18 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Wang, Zhihong ; > amore...@redhat.com; Xia, Chenbo > Subject: [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit > > For the sake of

[dpdk-dev] [PATCH v2] net/ice: fix tunnel type get error

2020-07-15 Thread Wei Zhao
When function ice_get_tun_type_for_recipe() get tunnel type, for ICE_NON_TUN we need to include gtp-c and some gtp-u ptype with no payload, as they do not have tunnel packet as paylod. Fixes: 418d2563d10b ("net/ice/base: get tunnel type for recipe") Signed-off-by: Wei Zhao Tested-by: Nannan Lu

[dpdk-dev] [PATCH v4] net/i40e: fix modify the number of qps in VF

2020-07-15 Thread alvinx . zhang
From: Alvin Zhang If a VF request PF to allocate more number of queue pairs, the PF will free the queue pairs which have been allocated and reset the VF. So, VF should stop to work until all the process is done. This patch modify the process of the request queue pairs. To improve efficiency and e

Re: [dpdk-dev] [PATCH] net/ice: fix tunnel type get error

2020-07-15 Thread Zhao1, Wei
H, qi > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, July 15, 2020 10:02 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Nannan > Subject: RE: [PATCH] net/ice: fix tunnel type get error > > > > > -Original Message- > > From: Zhao1, Wei > > Sent: Wednesday, July 15,

Re: [dpdk-dev] [PATCH v3] net/i40e: fix modify the number of qps in VF

2020-07-15 Thread Zhang, AlvinX
Hi Guojia, Thanks a lot. I'll update it. BR, Alvin > -Original Message- > From: Guo, Jia > Sent: Wednesday, July 15, 2020 6:17 PM > To: Zhang, AlvinX > Cc: dev@dpdk.org; Xing, Beilei > Subject: Re: [PATCH v3] net/i40e: fix modify the number of qps in VF > > hi, alvin > > The process

Re: [dpdk-dev] [PATCH v5 9/9] doc: replace references to blacklist/whitelist

2020-07-15 Thread Stephen Hemminger
On Wed, 15 Jul 2020 16:02:57 -0700 Stephen Hemminger wrote: > diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst > index 7f4036c3210e..38e5b0a96206 100644 > --- a/doc/guides/cryptodevs/qat.rst > +++ b/doc/guides/cryptodevs/qat.rst > @@ -126,7 +126,7 @@ Limitations >opt

[dpdk-dev] [PATCH v5 9/9] doc: replace references to blacklist/whitelist

2020-07-15 Thread Stephen Hemminger
The terms blacklist and whitelist are no longer used. Most of this was automatic replacement, but in a couple of places the language was awkward before and have tried to improve the readabilty. The blacklist/whitelist changes to API will not be a breaking change for applications in this release b

[dpdk-dev] [PATCH v5 6/9] eal: replace pci-whitelist/pci-blacklist options

2020-07-15 Thread Stephen Hemminger
Replace "pci-whitelist" with "include" and "pci-blacklist" with pci-exclude. Allow the old options for now, but print a nag warning since old options are deprecated. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_eal/common/eal_common_options.c | 71 ++--

[dpdk-dev] [PATCH v5 7/9] app/test: use new allowlist and blocklist

2020-07-15 Thread Stephen Hemminger
Test the renamed pci-blocklist and pci-allowlist arguments. Use new terms in test variable names as well. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- app/test/autotest.py| 16 ++-- app/test/autotest_runner.py | 18 ++--- app/test/test.c | 2

[dpdk-dev] [PATCH v5 8/9] eal: mark old macros for blacklist/whitelist as deprecated

2020-07-15 Thread Stephen Hemminger
Use of these macros in applications should cause a deprecation warning. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_eal/include/rte_bus.h | 9 +++-- lib/librte_eal/include/rte_dev.h | 10 +++--- lib/librte_eal/include/rte_devargs.h | 9 +++-- 3

[dpdk-dev] [PATCH v5 4/9] eal: replace usage of blacklist/whitelist in enum

2020-07-15 Thread Stephen Hemminger
The terms blacklist and whitelist are often seen as reminders of the divisions in society. Instead, use more exact terms for handling of which devices are used in DPDK. This patch renames the enum values in the EAL include files. As a backward compatible temporary migration tool, define a replacem

[dpdk-dev] [PATCH v5 5/9] drivers: replace references to blacklist

2020-07-15 Thread Stephen Hemminger
Use the new terminology blocked to describe when devices are excluded from being used. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- drivers/bus/dpaa/dpaa_bus.c| 7 +++ drivers/bus/fslmc/fslmc_bus.c | 9 - drivers/bus/fslmc/fslmc_vfio.c | 8 ---

[dpdk-dev] [PATCH v5 1/9] rte_ethdev: change comment to rte_dev_eth_mac_addr_add

2020-07-15 Thread Stephen Hemminger
The comment used the term whitelist and was awkardly written. Replace it with simpler direct description of adding a new address. No code or API changes for this. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_ethdev/rte_ethdev.h | 3 +-- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH v5 0/9] rename blacklist/whitelist to exclude/include

2020-07-15 Thread Stephen Hemminger
The terms blacklist and whitelist are often seen as reminders of the privilege in society. Instead, use more exact terms for handling of which devices are used in DPDK. This is a proposed change for DPDK 20.08 to replace the names blacklist and whitelist in API and command lines. The first three

[dpdk-dev] [PATCH v5 2/9] mk: replace reference to blacklist/whitelist

2020-07-15 Thread Stephen Hemminger
Use BLOCKLIST and ALLOWLIST in the make variable names. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- mk/rte.sdktest.mk | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk index 803018ba3a70..6777e0c0f603 100644

[dpdk-dev] [PATCH v5 3/9] check_maintainers: change variable names

2020-07-15 Thread Stephen Hemminger
Change variable names in python script: replace whitelist with include_files and blacklist with exclude_files. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- devtools/check-maintainers.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/devtools/check-ma

[dpdk-dev] [PATCH v3 7/7] app/proc-info: add crypto security context info

2020-07-15 Thread Stephen Hemminger
From: Hemant Agrawal If crypto context is not present, no point in displaying it. This patch adds the crypto based security context info. Also improve the flag printing to SECURITY OFFLOAD from INLINE. Use common code for displaying crypto context information when doing show_ports and show_cryp

[dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

2020-07-15 Thread Stephen Hemminger
There are cases where a port maybe owned by another (failsafe, netvsc, bond); but currently proc-info has no way to look at stats of those ports. This patch provides way for the user to explicitly ask for these ports. If no portmask is given the output is unchanged; it only shows the top level por

[dpdk-dev] [PATCH v3 1/7] app/proc-info: remove unused logtype #define

2020-07-15 Thread Stephen Hemminger
This logtype is defined but never used. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab438..69e3000616c0 100644 --- a/app/proc-info/main.c +++ b/ap

[dpdk-dev] [PATCH v3 5/7] app/proc-info: dump rx and tx descriptor info

2020-07-15 Thread Stephen Hemminger
Many drivers will report per queue info for both rx and tx as well as how many descriptors are in use. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 79 1 file changed, 66 insertions(+), 13 deletions(-) diff --

[dpdk-dev] [PATCH v3 2/7] app/proc-info: eliminate useless borders

2020-07-15 Thread Stephen Hemminger
Printing extra borders does not improve readability, and is just unnecessary. Putting TSC hz in header also makes no sense here. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 35 +++ 1 file changed, 7 insertions(+), 28 delet

[dpdk-dev] [PATCH v3 3/7] app/proc-info: hide EAL info messages

2020-07-15 Thread Stephen Hemminger
The DPDK EAL info messages at the start of a diagnostic application are not helpful to end user. Suppress them by setting log-level by default. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) di

[dpdk-dev] [PATCH v3 0/7] app/proc-info enhancments

2020-07-15 Thread Stephen Hemminger
The current proc-info command is useful for diagnosing issues with external DPDK applications, but the display is limited and somewhat ugly. This patchset adds some enhancements which show more info and suppress unnecessary stuff. v3 - consolidate chages for displaying crypto info v2 - fix checkpa

[dpdk-dev] [PATCH v3 4/7] app/proc-info: add more info to show_ports

2020-07-15 Thread Stephen Hemminger
Revise the display of port information to include more data and be more human friendly. * Display units for port speed, and decode link fields. * Show driver and device information * Show MAC address * Show flow control information * Combine lines if possible * Show all multicast mode

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-15 Thread Stephen Hemminger
On Wed, 15 Jul 2020 14:28:17 +0100 "Burakov, Anatoly" wrote: > > -#define SKIP_MASTERSKIP_INITIAL > > -#define CALL_MASTERCALL_INITIAL > > +#define SKIP_MASTER _Pragma("GCC warning \"'SKIP_MASTER' is deprecated\"") > > SKIP_INITIAL > > +#define CALL_MASTER _Pragma("GCC warning \"

Re: [dpdk-dev] Random failure in service_autotest

2020-07-15 Thread Honnappa Nagarahalli
> Subject: Re: Random failure in service_autotest > > David Marchand writes: > > > On Wed, Jul 15, 2020 at 3:09 PM Lukasz Wojciechowski > > wrote: > >> > >> > >> W dniu 15.07.2020 o 15:02, David Marchand pisze: > >> > On Wed, Jul 15, 2020 at 2:56 PM Aaron Conole > wrote: > >> >> I guess the

Re: [dpdk-dev] [PATCH v3 0/5] app: add multi process crypto application

2020-07-15 Thread Thomas Monjalon
15/07/2020 22:15, Akhil Goyal: > > > I see this application as a useful tool to test the readiness of a driver > > > to be > > used > > > in a multi process environment. If app is not a correct place to host it, > > > should it > > be > > > added in examples/multi_process/. I also suggested that

[dpdk-dev] [PATCH] eal: change the log level for test assert macro

2020-07-15 Thread Honnappa Nagarahalli
Change the log level for RTE_TEST_ASSERT macro to error to help log errors while running test cases. Signed-off-by: Honnappa Nagarahalli --- lib/librte_eal/include/rte_test.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/include/rte_test.h b/lib/librte_eal/i

Re: [dpdk-dev] [PATCH v3 0/5] app: add multi process crypto application

2020-07-15 Thread Akhil Goyal
> > I see this application as a useful tool to test the readiness of a driver > > to be > used > > in a multi process environment. If app is not a correct place to host it, > > should it > be > > added in examples/multi_process/. I also suggested that in v2 but it makes > more > > sense in app as

Re: [dpdk-dev] [PATCH v3 0/5] app: add multi process crypto application

2020-07-15 Thread Thomas Monjalon
15/07/2020 21:25, Akhil Goyal: > Hi Thomas, > > > > 15/07/2020 20:26, Akhil Goyal: > > > Hi Arek, > > > > > > > > Due to increasing interest in multi process support for crypto PMDs > > > > new test app can be added so in overview we can say that: > > > > > > > > The Multi-process Crypto applicati

Re: [dpdk-dev] [PATCH 1/3] examples/fips_validation: fix TDES interim callback

2020-07-15 Thread Akhil Goyal
> 02/07/2020 20:53, Akhil Goyal: > > Hi Marko/Fan, > > > > Could you please review this series? > > What happens? Nobody to review this? > > > > Subject: [PATCH 1/3] examples/fips_validation: fix TDES interim callback > > > > > > Fix missing callback registration and the incorrect > > > callback

Re: [dpdk-dev] [PATCH 20.08] crypto/scheduler: use ring peek API

2020-07-15 Thread Akhil Goyal
> > Subject: [PATCH 20.08] crypto/scheduler: use ring peek API > > > > scheduler PMD uses its own hand-made peek functions > > that directly access rte_ring internals. > > As now rte_ring has an API for that type of functionality - > > change scheduler PMD to use API provided by rte_ring. > > > > S

Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-07-15 Thread Akhil Goyal
> > > > > >> >Why do we need this change? > > > >> >The existing test case is to demonstrate a generic case where we > > > >> >can have an auth only trailer as well. It is similar to a case of > > > >> >IPSEC ESN but not exactly IPSec. Cipher offset can be anything as > > > >> >per the app > > > >r

Re: [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in compression pmd

2020-07-15 Thread Akhil Goyal
> Tested-by: Jiang, YuX > > > Because capability memzone of compression does not have lookup call, > > second and subsequent devices cannot be created. > > > > Fixes: 0e6fff16a7a2 ("drivers: add multi process handling of > > capabilities in > > QAT") > > > > Signed-off-by: Arek Kusztal > > Ack

Re: [dpdk-dev] [PATCH v2 1/1] compress/qat: revert change in GEN3 marketing name

2020-07-15 Thread Akhil Goyal
> This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70. > > Signed-off-by: Adam Dybkowski > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v3 0/5] app: add multi process crypto application

2020-07-15 Thread Akhil Goyal
Hi Thomas, > > 15/07/2020 20:26, Akhil Goyal: > > Hi Arek, > > > > > > Due to increasing interest in multi process support for crypto PMDs > > > new test app can be added so in overview we can say that: > > > > > > The Multi-process Crypto application is a simple application that > > > allows to r

Re: [dpdk-dev] [PATCH v3 0/5] app: add multi process crypto application

2020-07-15 Thread Thomas Monjalon
15/07/2020 20:26, Akhil Goyal: > Hi Arek, > > > > Due to increasing interest in multi process support for crypto PMDs > > new test app can be added so in overview we can say that: > > > > The Multi-process Crypto application is a simple application that > > allows to run crypto related operations

Re: [dpdk-dev] [PATCH v2 06/20] regex/mlx5: add probe function

2020-07-15 Thread Thomas Monjalon
12/07/2020 22:58, Ori Kam: > --- a/drivers/regex/mlx5/mlx5_regex.c > +++ b/drivers/regex/mlx5/mlx5_regex.c > +static const struct rte_regexdev_ops mlx5_regexdev_ops = {}; Another pedantic compilation failure: drivers/regex/mlx5/mlx5_regex.c:23:58: error: ISO C forbids empty initializer braces [-We

[dpdk-dev] [RFC PATCH 2/2] example/qos_sched: subport bandwidth profile config

2020-07-15 Thread Savinay Dharmappa
qos sched application uses the new apis introduced as part of dynamic configuration of subport bandwidth to configure the deafult subport bandwidth profile while buidling the hirerachical scheduler. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- examples/qos_sched/cfg_file.

[dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subport bandwidth profile

2020-07-15 Thread Savinay Dharmappa
This patch modifies the subport level data structures and add new API to allow dynamic configuration of the subport bandwidth profile. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 486 - lib/librte_s

[dpdk-dev] [RFC PATCH 0/2] Enable dyynamic configuration of subport bandwidth profile

2020-07-15 Thread Savinay Dharmappa
DPDK sched library allows runtime configuration of the pipe profiles to the pipes of the subport once scheduler hierarchy is constructed. However, to change the subport level bandwidth, existing hierarchy needs to be dismantled and whole process of building hierarchy under subport nodes needs to be

Re: [dpdk-dev] [PATCH v3 0/5] app: add multi process crypto application

2020-07-15 Thread Akhil Goyal
Hi Arek, > > Due to increasing interest in multi process support for crypto PMDs > new test app can be added so in overview we can say that: > > The Multi-process Crypto application is a simple application that > allows to run crypto related operations in a multiple process environment. It > buil

Re: [dpdk-dev] [PATCH v3 5/5] doc: add documentation for multi process crypto app

2020-07-15 Thread Akhil Goyal
Hi Arek, > Subject: [PATCH v3 5/5] doc: add documentation for multi process crypto app Please do not make separate patches for documentation. Your first patch description says more info can be found in mp_crypto.rst. But it is not there in that patch. You should add the relevant documentation in

[dpdk-dev] [PATCH 10/10] net/bnxt: add support for decrement TTL action

2020-07-15 Thread Somnath Kotur
From: Kishore Padmanabha Added support for decrement TTL action. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 30 +++ drivers/net/bnxt/tf_ulp/ulp_rte_parser.h | 5 +

[dpdk-dev] [PATCH 09/10] net/bnxt: increase the number of egress flow entries

2020-07-15 Thread Somnath Kotur
From: Kishore Padmanabha Increase the number of egress flow entries. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH 08/10] net/bnxt: consider VLAN fields for template match criteria

2020-07-15 Thread Somnath Kotur
From: Kishore Padmanabha The vlan mask fields were not setting the field bitmap causing the template match process to ignore vlan fields. This change fixes this bug. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_rte

[dpdk-dev] [PATCH 07/10] net/bnxt: add support for identifier search and ref count

2020-07-15 Thread Somnath Kotur
From: Kishore Padmanabha Add support to search for identifiers and increase the reference count for identifiers that are already allocated. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 117 ++

[dpdk-dev] [PATCH 04/10] net/bnxt: add changes to support 2 table scopes

2020-07-15 Thread Somnath Kotur
From: Farah Smith Need to remap the table scope ids allocated from HCAPI RM from high to low value because for legacy devices a table scope is a set of base addresses. The PCIe addresses must map to a PCIe PF which exists in the hardware. Signed-off-by: Farah Smith Reviewed-by: Somnath Kotur

[dpdk-dev] [PATCH 06/10] net/bnxt: ignore ipv4 TOS mask

2020-07-15 Thread Somnath Kotur
From: Kishore Padmanabha This is a work around for the OVS setting offload rules that are passing ipv4 tos mask as wild card and currently we do not support. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_rte_parser.c

[dpdk-dev] [PATCH 03/10] net/bnxt: check index range in bulk get

2020-07-15 Thread Somnath Kotur
From: Jay Ding In tf_tbl_bulk_get, check if the indexes are in the range of reserved tbl id instead of checking the allocation of each id. Signed-off-by: Jay Ding Reviewed-by: Somnath Kotur Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Somnath Kotur --- driver

[dpdk-dev] [PATCH 05/10] net/bnxt: add support to extract data from the ulp blob

2020-07-15 Thread Somnath Kotur
From: Kishore Padmanabha Extended the ulp blob to extract data from the blob for a given offset and length. The support is added only for little endian format. Signed-off-by: Kishore Padmanabha Reviewed-by: Randy Schacher Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_utils.c |

[dpdk-dev] [PATCH v4 00/10] bnxt patches

2020-07-15 Thread Somnath Kotur
Minor enhancments added to the TF-ULP/Core layers Farah Smith (1): net/bnxt: add changes to support 2 table scopes Jay Ding (2): net/bnxt: implement TF Identifier search net/bnxt: check index range in bulk get Kishore Padmanabha (6): net/bnxt: add support to extract data from the ulp blo

[dpdk-dev] [PATCH 02/10] net/bnxt: implement TF Identifier search

2020-07-15 Thread Somnath Kotur
From: Jay Ding Implement shadow copy DB to hold reference count for each ID in each identifier type. Implement identifier search functionality. Signed-off-by: Jay Ding Reviewed-by: Randy Schacher Signed-off-by: Somnath Kotur --- drivers/net/bnxt/meson.build| 3 +- drive

[dpdk-dev] [PATCH 01/10] net/bnxt: add option to delay EEM sysmem mapping

2020-07-15 Thread Somnath Kotur
From: Peter Spreadborough - The mapping of kernel pages for EEM sysmem operation takes a significant amount of time. This change give the build option to delay the sysmem mapping until the first write to EEM Signed-off-by: Peter Spreadborough Reviewed-by: Randy Schacher Signed-off-by: Somn

Re: [dpdk-dev] [PATCH v2 06/20] regex/mlx5: add probe function

2020-07-15 Thread Thomas Monjalon
12/07/2020 22:58, Ori Kam: > +/** > + * DPDK callback to register a PCI device. Is this intro useful? Why specifying "DPDK"? > + * > + * This function spawns RegEx device out of a given PCI device. > + * > + * @param[in] pci_drv > + * PCI driver structure (mlx5_regex_driver). > + * @param[in] p

Re: [dpdk-dev] [PATCH v2 09/20] common/mlx5: add write and read RXP registers

2020-07-15 Thread Thomas Monjalon
12/07/2020 22:58, Ori Kam: > This commits add the write and read RXP registers functionality. > > Signed-off-by: Ori Kam > Acked-by: Viacheslav Ovsiienko [...] > --- a/drivers/common/mlx5/rte_common_mlx5_version.map > +++ b/drivers/common/mlx5/rte_common_mlx5_version.map > @@ -38,6 +38,8 @@ INTE

Re: [dpdk-dev] [PATCH v2 02/20] regex/mlx5: add log utils

2020-07-15 Thread Thomas Monjalon
12/07/2020 22:58, Ori Kam: > From: Yuval Avnery > > Add the DRV_LOG macro which should be used for error prints. Should be MLX5_REGEX_LOG > +extern int mlx5_regex_logtype; > + > +#define MLX5_REGEX_LOG_PREFIX "regex_mlx5" > +/* Generic printf()-like logging macro with automatic line feed. */ >

Re: [dpdk-dev] [PATCH v2 01/20] regex/mlx5: add RegEx PMD layer and mlx5 driver

2020-07-15 Thread Thomas Monjalon
12/07/2020 22:58, Ori Kam: > From: Yuval Avnery [...] > +++ b/drivers/regex/mlx5/Makefile > +LDLIBS += -lrte_common_mlx5 > +LDLIBS += -lm > +LDLIBS += -lrte_eal -lrte_mbuf > +LDLIBS += -lrte_kvargs > +LDLIBS += -lrte_bus_pci [...] > +++ b/drivers/regex/mlx5/meson.build > +deps += ['common_mlx5', '

Re: [dpdk-dev] [PATCH v2 05/20] common/mlx5: add support for regex capability query

2020-07-15 Thread Thomas Monjalon
12/07/2020 22:58, Ori Kam: > From: Yuval Avnery > > Update hca cap struct and common query hca cap function. > > Signed-off-by: Yuval Avnery > Acked-by: Viacheslav Ovsiienko > > --- > drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ > drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ > drivers/commo

Re: [dpdk-dev] [PATCH v2 04/20] common/mlx5: add mlx5 regex command structs

2020-07-15 Thread Thomas Monjalon
12/07/2020 22:58, Ori Kam: > From: Yuval Avnery > > Add regex commands structs to support regex. Addind data stuctures without any use of it is meaningless. We can probably squash a lot of commits. > Signed-off-by: Yuval Avnery > Acked-by: Viacheslav Ovsiienko > > --- > --- a/drivers/common/

Re: [dpdk-dev] [PATCH v2 01/20] regex/mlx5: add RegEx PMD layer and mlx5 driver

2020-07-15 Thread Thomas Monjalon
12/07/2020 22:58, Ori Kam: > From: Yuval Avnery > > This commit introduce the RegEx poll mode drivers class, and > adds Mellanox RegEx PMD. > > Signed-off-by: Yuval Avnery > Signed-off-by: Ori Kam > --- > v2: > * Add documantion. First typo. Bad start for a doc update... > --- a/MAINTAINERS

[dpdk-dev] [PATCH 5/5] net/virtio: enable feature checking on virtio-user

2020-07-15 Thread Adrian Moreno
virtio 1.0 introduced a mechanism for the driver to verify that the feature bits it sets are accepted by the device. This mechanism consists in setting the VIRTIO_STATUS_FEATURE_OK status bit and re-reading it, whitch gives a chance for the device to clear it if the the features were not accepted.

[dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user

2020-07-15 Thread Adrian Moreno
This patch adds support for VHOST_USER_GET_STATUS request. Only vhost-user backed is supported for now Signed-off-by: Adrian Moreno --- drivers/net/virtio/virtio_user/vhost_user.c | 2 + .../net/virtio/virtio_user/virtio_user_dev.c | 39 +++ .../net/virtio/virtio_user/virtio

[dpdk-dev] [PATCH 3/5] net/virtio: add VIRTIO_SET_STATUS support to Virtio-user

2020-07-15 Thread Adrian Moreno
From: Maxime Coquelin This patch adds support for VHOST_USER_SET_STATUS request. It is used to make the backend aware of Virtio devices status update. It is useful for the backend to know when the Virtio driver is done with the Virtio device configuration. Signed-off-by: Maxime Coquelin Signed

[dpdk-dev] [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit

2020-07-15 Thread Adrian Moreno
For the sake of completeness, add the definition of the missing status bit in accordance with the virtio spec Signed-off-by: Adrian Moreno --- drivers/net/virtio/virtio_pci.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtio_pci.h b/drive

[dpdk-dev] [PATCH 0/5] Add support for GET/SET_STATUS on virtio-user pmd

2020-07-15 Thread Adrian Moreno
Recently, two new messages have been added to the vhost-user protocol that make the device initialization more robust. VHOST_VIRTIO_SET_STATUS allows the driver to set the device status VHOST_VIRTIO_GET_STATUS allows the driver to read the status back from the device This series implements these

[dpdk-dev] [PATCH 1/5] net/virtio: split virtio-net and virtio status

2020-07-15 Thread Adrian Moreno
Currently, the same field is being used to store both the generic virtio device status and the virtio-net-specific status. This can become problematic since they have different sets of status bits that may collide (e.g: VIRTIO_CONFIG_STATUS_ACK and VIRTIO_NET_S_LINK_UP). Split them in different f

Re: [dpdk-dev] [PATCH v2 9/9] crypto/octeontx2: add cryptodev sec dequeue routine

2020-07-15 Thread Akhil Goyal
> From: Vamsi Attunuru > > This patch adds lookaside IPsec dequeue routine. > > Signed-off-by: Vamsi Attunuru > Signed-off-by: Tejasree Kondoj > --- The patch can be squashed into the previous one. As enqueue will not work without dequeue operation. > doc/guides/cryptodevs/octeontx2.rst

Re: [dpdk-dev] [PATCH v2 4/9] crypto/octeontx2: add cryptodev sec registration

2020-07-15 Thread Akhil Goyal
>RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT | >RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO | >RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT | > - RTE_CRYPTODEV_FF_SYM_SESSIONLESS; > + RTE_CRY

Re: [dpdk-dev] [PATCH v2 00/20] add Mellanox RegEx PMD

2020-07-15 Thread Thomas Monjalon
Some typos to fix: WARNING:TYPO_SPELLING: 'IDENTIFER' may be misspelled - perhaps 'IDENTIFIER'? WARNING:TYPO_SPELLING: 'dissabling' may be misspelled - perhaps 'disabling'? WARNING:TYPO_SPELLING: 'thsi' may be misspelled - perhaps 'this'? WARNING:TYPO_SPELLING: 'interations' may be misspelled - per

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-15 Thread Phil Yang
> -Original Message- > From: David Marchand > Sent: Wednesday, July 15, 2020 8:29 PM > To: Phil Yang > Cc: Olivier Matz ; dev ; Stephen > Hemminger ; David Christensen > ; Honnappa Nagarahalli > ; Ruifeng Wang > ; nd ; Dodji Seketeli > ; Aaron Conole > Subject: Re: [PATCH v4 1/2] mbuf: u

Re: [dpdk-dev] Retrieving lcore worker thread id

2020-07-15 Thread Stephen Hemminger
On Wed, 15 Jul 2020 10:17:09 + Mattias Rönnblom wrote: > On 2020-07-14 22:51, Stephen Hemminger wrote: > > On Tue, 14 Jul 2020 18:59:59 + > > Honnappa Nagarahalli wrote: > > > >> > >> > Hi. > >>> Hey, > >>> > In DPDK 19.11, the lcore_config struct of is made > >>>

[dpdk-dev] ixgbe vector rx does not conform to rte_eth_rx_burst() API

2020-07-15 Thread Morten Brørup
Wei, Jeff, For the ixgbe driver using vector functions, i.e. ixgbe_recv_pkts_vec(), calling rte_eth_rx_burst() with nb_pkts > RTE_IXGBE_MAX_RX_BURST only returns RTE_IXGBE_MAX_RX_BURST packets. E.g. calling rte_eth_rx_burst() with nb_pkts=64 only returns 32 packets. The API description of rte

[dpdk-dev] [PATCH v4 1/2] Fix build of apps with external dependencies

2020-07-15 Thread Felix Moessbauer
This fix initializes the dependency object with the external dependency list. Previously, the external dependencies were just ignored. Signed-off-by: Felix Moessbauer --- app/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/meson.build b/app/meson.build index 5

[dpdk-dev] [PATCH v4 0/2] Add l2reflect measurement application

2020-07-15 Thread Felix Moessbauer
Changes since v3: - check for sys/io.h header - fix linking issues on gcc 10 Changes since v2: - add missing internal dependency - improve wording of commit message Changes since v1: - move to app folder, as suggested by maintainer - fix issues reported by checkpatch Felix Moessbauer (2): F

[dpdk-dev] [PATCH v4 2/2] Add l2reflect measurement application

2020-07-15 Thread Felix Moessbauer
The l2reflect application implements a ping-pong benchmark to measure the latency between two instances. For communication, we use raw ethernet and send one packet at a time. The timing data is collected locally and min/max/avg values are displayed in a TUI. Finally, a histogram of the latencies is

[dpdk-dev] [PATCH v3 4/5] app/mp_crypto: add enqueue-dequeue functions

2020-07-15 Thread Arek Kusztal
Add enqueue/dequeue functions and related dependency functions to multi process crypto app. Command line options to use are described in mp_crypto.rst file. Signed-off-by: Arek Kusztal --- app/test-mp-crypto/Makefile| 2 +- app/test-mp-crypto/main.c | 544 +

[dpdk-dev] [PATCH v3 0/5] app: add multi process crypto application

2020-07-15 Thread Arek Kusztal
Due to increasing interest in multi process support for crypto PMDs new test app can be added so in overview we can say that: The Multi-process Crypto application is a simple application that allows to run crypto related operations in a multiple process environment. It builds on the EAL primary/se

[dpdk-dev] [PATCH v3 2/5] app/mp_crypto: add device configuration functions

2020-07-15 Thread Arek Kusztal
Add functions to allow device configuration, command line used to configure device is described in mp_crypto.rst file. Signed-off-by: Arek Kusztal --- app/test-mp-crypto/main.c | 229 - app/test-mp-crypto/mp_crypto.h | 6 ++ 2 files changed, 232 ins

  1   2   3   >