[dpdk-dev] [DPDK v2] [DPDK] net/e1000: add the VLAN capabilities of NIC

2020-07-19 Thread zhihongx . peng
From: Peng Zhihong The rte_eth_dev_set_vlan_offload function will check whether the NIC has the set vlan feature. If it has not, it will return failure. So need to add all the vlan feature flags of the NIC. Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API") Cc: sta...@dpdk.org Si

Re: [dpdk-dev] [PATCH v8 2/4] net/i40e: use WC store to update queue tail registers

2020-07-19 Thread Ruifeng Wang
> -Original Message- > From: Radu Nicolau > Sent: Friday, July 17, 2020 6:50 PM > To: dev@dpdk.org > Cc: beilei.x...@intel.com; jia@intel.com; bruce.richard...@intel.com; > konstantin.anan...@intel.com; jerinjac...@gmail.com; > david.march...@redhat.com; fiona.tr...@intel.com; wei.zh

Re: [dpdk-dev] [PATCH v8 1/4] eal: add WC store functions

2020-07-19 Thread Ruifeng Wang
> -Original Message- > From: Radu Nicolau > Sent: Friday, July 17, 2020 6:50 PM > To: dev@dpdk.org > Cc: beilei.x...@intel.com; jia@intel.com; bruce.richard...@intel.com; > konstantin.anan...@intel.com; jerinjac...@gmail.com; > david.march...@redhat.com; fiona.tr...@intel.com; wei.zh

[dpdk-dev] [PATCH v6 13/13] regex/mlx5: add start stop functions

2020-07-19 Thread Ori Kam
Add the start, stop and close functions. In current implementation they are empty functions and are only exists in order that when called from rte level, the function will return with success code. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 21 + drivers/reg

[dpdk-dev] [PATCH v6 12/13] regex/mlx5: implement dequeue function

2020-07-19 Thread Ori Kam
From: Yuval Avnery Implement dequeue function for the regex API. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/common/mlx5/mlx5_prm.h | 10 +++ drivers/regex/mlx5/mlx5_regex.c | 1 + drivers/regex/mlx5/mlx5_regex.h | 4 ++ drivers/regex/mlx5/mlx5_

[dpdk-dev] [PATCH v6 10/13] regex/mlx5: fastpath setup

2020-07-19 Thread Ori Kam
From: Yuval Avnery Allocated and register input/output buffers and metadata. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/common/mlx5/mlx5_prm.h | 36 ++ drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/re

[dpdk-dev] [PATCH v6 07/13] regex/mlx5: add program rules support

2020-07-19 Thread Ori Kam
From: Francis Kelly This commit introduce the ability to program rules to the RegEx engine. Signed-off-by: Francis Kelly Acked-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 34 ++ drivers/regex/mlx5/mlx5_regex.h | 52 ++- drivers/regex/mlx5/mlx5_regex_devx.c | 67 +++ driver

[dpdk-dev] [PATCH v6 11/13] regex/mlx5: add enqueue implementation

2020-07-19 Thread Ori Kam
From: Yuval Avnery Will look for a free SQ to send the job on. doorbell will be given when sq is full, or no more jobs on the burst. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 1 + drivers/regex/mlx5/mlx5_regex.h | 6 ++ drivers/

[dpdk-dev] [PATCH v6 08/13] regex/mlx5: add completion queue creation

2020-07-19 Thread Ori Kam
This commit adds the creation of CQ Signed-off-by: Ori Kam --- drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/regex/mlx5/mlx5_regex.c | 1 + drivers/regex/mlx5/mlx5_regex.h | 4 +- drivers/regex/mlx5/mlx5_regex_contro

[dpdk-dev] [PATCH v6 09/13] regex/mlx5: add send queue support

2020-07-19 Thread Ori Kam
This commit introduce the SQ creation. The SQ is used for enqueuing a job. In order to support out of order matches, we create number os SQ per one application QP. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.h | 2 + drivers/regex/mlx5/mlx5_regex_control.c | 179 +

[dpdk-dev] [PATCH v6 04/13] regex/mlx5: add get info function

2020-07-19 Thread Ori Kam
This commit adds the get info function. Signed-off-by: Ori Kam --- drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/regex/mlx5/mlx5_regex.c | 4 +++- drivers/regex/mlx5/mlx5_regex.h | 5 + drivers/regex/mlx5/mlx5_rxp.c | 29 +

[dpdk-dev] [PATCH v6 03/13] regex/mlx5: add probe function

2020-07-19 Thread Ori Kam
This commit adds the probe function to the RegEx PMD. Signed-off-by: Parav Pandit Signed-off-by: Ori Kam --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 + drivers/common/mlx5/mlx5_devx_cmds.h | 2 + drivers/common/mlx5/mlx5_prm.h | 9 +- drivers/regex/mlx5/Makefile | 2 + d

[dpdk-dev] [PATCH v6 05/13] regex/mlx5: add engine status check

2020-07-19 Thread Ori Kam
This commit checks the engine status. Signed-off-by: Ori Kam --- drivers/common/mlx5/mlx5_prm.h | 91 ++ drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/regex/mlx5/mlx5_regex.c | 28 +++ drivers/regex/mlx5/mlx5_regex.h

[dpdk-dev] [PATCH v6 06/13] regex/mlx5: add configure function

2020-07-19 Thread Ori Kam
This commit implements the configure function. This function is responsible to configure the RegEx engine. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 2 + drivers/regex/mlx5/mlx5_regex.h | 15 +++ drivers/regex/mlx5/mlx5_rxp.c | 235 +++-

[dpdk-dev] [PATCH v6 02/13] regex/mlx5: add log utils

2020-07-19 Thread Ori Kam
From: Yuval Avnery Add the MLX5_REGEX_LOG macro which should be used for error prints. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/mlx5_regex.c | 5 + drivers/regex/mlx5/mlx5_regex_utils.h | 19

[dpdk-dev] [PATCH v6 00/13] add Mellanox RegEx PMD

2020-07-19 Thread Ori Kam
This patch series introduce the Mellanox BF2 RegEx PMD. Mellanox BF2 RegEx PMD implement the API defined in the regexdev lib [1]. This PMD allows a DPDK application to offload the RegEx functionality to Mellanox BF2 RegEx engine. [1] https://patches.dpdk.org/cover/72792/ v6: * Address ML comm

[dpdk-dev] [PATCH v6 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver

2020-07-19 Thread Ori Kam
From: Yuval Avnery This commit introduce the RegEx pull mode drivers class, and adds Mellanox RegEx PMD. Signed-off-by: Yuval Avnery Signed-off-by: Ori Kam --- v6: * Address ML comments. v5: * Move to mlx5 bus v3: * Address ML comments. v2: * Add docs. --- .gitignore

Re: [dpdk-dev] [PATCH v2] bus/fslmc: fix memory leak in secondary process

2020-07-19 Thread Hemant Agrawal (OSS)
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v5 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver

2020-07-19 Thread Ori Kam
Hi Thomas, Thanks for the review. > -Original Message- > From: Thomas Monjalon > > 19/07/2020 20:09, Ori Kam: > > From: Yuval Avnery > > > > This commit introduce the RegEx pull mode drivers class, and > > adds Mellanox RegEx PMD. > [...] > > --- /dev/null > > +++ b/doc/guides/regexdev

Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk

2020-07-19 Thread Hemant Agrawal
HI Thomas, -Original Message- From: Thomas Monjalon Sent: Monday, July 20, 2020 1:41 AM To: Hemant Agrawal ; Sachin Saxena Cc: dev@dpdk.org; Ferruh Yigit ; techbo...@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk Importance: High 17/07/2020 13

[dpdk-dev] [dpdk-dev v1] net/iavf: fix issue for GTPU l4 hash

2020-07-19 Thread Jeff Guo
When the configure pattern involve GTPU inner l3 and l4, even the configure input set only l3 but not l4, the different l4 protocol header should also be configured for the different l4 protocol. Fixes: 215a247b5f33 ("net/iavf: refactor hash flow") Fixes: 642f20195015 ("net/iavf: support RSS for I

[dpdk-dev] [PATCH v1] vhost: support cross page buf in async data path

2020-07-19 Thread patrick . fu
From: Patrick Fu Async copy fails when ring buffer cross two physical pages. This patch fix the failure by letting copies occur in sync mode if crossing page buffers are given. Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring") Signed-off-by: Patrick Fu --- lib/librte_vhost

[dpdk-dev] [DPDK] net/i40e: add the VLAN capabilities of NIC

2020-07-19 Thread zhihongx . peng
From: Peng Zhihong The rte_eth_dev_set_vlan_offload function will check whether the NIC has the set vlan feature. If it has not, it will return failure. So need to add all the vlan feature flags of the NIC. Fixes: e0cb96204b71 (net/i40e: add support for representor ports) Cc: declan.dohe...@inte

Re: [dpdk-dev] [PATCH 1/1] eal/linux: do not create user mem map repeatedly when it exists

2020-07-19 Thread wangyunjian
> -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Friday, July 17, 2020 10:24 PM > To: wangyunjian ; dev@dpdk.org; > david.march...@redhat.com > Cc: Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] eal/linux: do not

Re: [dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC

2020-07-19 Thread Zhao1, Wei
Hi, > -Original Message- > From: Peng, ZhihongX > Sent: Monday, July 20, 2020 9:47 AM > To: Zhao1, Wei ; Guo, Jia > Cc: dev@dpdk.org; Peng, ZhihongX ; > wei@intel.com > Subject: [DPDK] net/e1000: add the VLAN capabilities of NIC > > From: Peng Zhihong > > The rte_eth_dev_set_vlan

[dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC

2020-07-19 Thread zhihongx . peng
From: Peng Zhihong The rte_eth_dev_set_vlan_offload function will check whether the NIC has the set vlan feature. If it has not, it will return failure. So need to add all the vlan feature flags of the NIC. Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API") Cc: wei@intel.com

Re: [dpdk-dev] [PATCH v5 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver

2020-07-19 Thread Thomas Monjalon
19/07/2020 20:09, Ori Kam: > From: Yuval Avnery > > This commit introduce the RegEx pull mode drivers class, and > adds Mellanox RegEx PMD. [...] > --- /dev/null > +++ b/doc/guides/regexdevs/features_overview.rst > @@ -0,0 +1,100 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright 202

Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk

2020-07-19 Thread Thomas Monjalon
17/07/2020 13:36, Ferruh Yigit: > On 7/11/2020 9:17 AM, Hemant Agrawal wrote: > > DPAA platorm MAC interface is known as FMAN i.e. Frame Manager. > > There are two ways to control it. > > 1. Statically configure the queues and classification rules before the > > start of the application using FMC t

[dpdk-dev] [PATCH v5 13/13] regex/mlx5: add start stop functions

2020-07-19 Thread Ori Kam
Add the start, stop and close functions. In current implementation they are empty functions and are only exists in order that when called from rte level, the function will return with success code. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 21 + drivers/reg

[dpdk-dev] [PATCH v5 08/13] regex/mlx5: add completion queue creation

2020-07-19 Thread Ori Kam
This commit adds the creation of CQ Signed-off-by: Ori Kam --- drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/regex/mlx5/mlx5_regex.c | 1 + drivers/regex/mlx5/mlx5_regex.h | 4 +- drivers/regex/mlx5/mlx5_regex_contro

[dpdk-dev] [PATCH v5 10/13] regex/mlx5: fastpath setup

2020-07-19 Thread Ori Kam
From: Yuval Avnery Allocated and register input/output buffers and metadata. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/common/mlx5/mlx5_prm.h | 36 ++ drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/reg

[dpdk-dev] [PATCH v5 12/13] regex/mlx5: implement dequeue function

2020-07-19 Thread Ori Kam
From: Yuval Avnery Implement dequeue function for the regex API. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/common/mlx5/mlx5_prm.h | 10 +++ drivers/regex/mlx5/mlx5_regex.c | 1 + drivers/regex/mlx5/mlx5_regex.h | 4 ++ drivers/regex/mlx5/mlx5_r

[dpdk-dev] [PATCH v5 09/13] regex/mlx5: add send queue support

2020-07-19 Thread Ori Kam
This commit introduce the SQ creation. The SQ is used for enqueuing a job. In order to support out of order matches, we create number os SQ per one application QP. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.h | 2 + drivers/regex/mlx5/mlx5_regex_control.c | 179 +

[dpdk-dev] [PATCH v5 11/13] regex/mlx5: add enqueue implementation

2020-07-19 Thread Ori Kam
From: Yuval Avnery Will look for a free SQ to send the job on. doorbell will be given when sq is full, or no more jobs on the burst. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 1 + drivers/regex/mlx5/mlx5_regex.h | 6 ++ drivers/r

[dpdk-dev] [PATCH v5 06/13] regex/mlx5: add configure function

2020-07-19 Thread Ori Kam
This commit implements the configure function. This function is responsible to configure the RegEx engine. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 2 + drivers/regex/mlx5/mlx5_regex.h | 15 +++ drivers/regex/mlx5/mlx5_rxp.c | 235 +++-

[dpdk-dev] [PATCH v5 05/13] regex/mlx5: add engine status check

2020-07-19 Thread Ori Kam
This commit checks the engine status. Signed-off-by: Ori Kam --- drivers/common/mlx5/mlx5_prm.h | 91 ++ drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/regex/mlx5/mlx5_regex.c | 28 +++ drivers/regex/mlx5/mlx5_regex.h

[dpdk-dev] [PATCH v5 03/13] regex/mlx5: add probe function

2020-07-19 Thread Ori Kam
This commit adds the probe function to the RegEx PMD. Signed-off-by: Parav Pandit Signed-off-by: Ori Kam --- v5: * Use common mlx5 bus. --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 + drivers/common/mlx5/mlx5_devx_cmds.h | 2 + drivers/common/mlx5/mlx5_prm.h | 9 +- drivers/regex/ml

[dpdk-dev] [PATCH v5 04/13] regex/mlx5: add get info function

2020-07-19 Thread Ori Kam
This commit adds the get info function. Signed-off-by: Ori Kam --- drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/regex/mlx5/mlx5_regex.c | 4 +++- drivers/regex/mlx5/mlx5_regex.h | 5 + drivers/regex/mlx5/mlx5_rxp.c | 29 +

[dpdk-dev] [PATCH v5 07/13] regex/mlx5: add program rules support

2020-07-19 Thread Ori Kam
From: Francis Kelly This commit introduce the ability to program rules to the RegEx engine. Signed-off-by: Francis Kelly Acked-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 34 ++ drivers/regex/mlx5/mlx5_regex.h | 52 ++- drivers/regex/mlx5/mlx5_regex_devx.c | 67 +++ drivers

[dpdk-dev] [PATCH v5 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver

2020-07-19 Thread Ori Kam
From: Yuval Avnery This commit introduce the RegEx pull mode drivers class, and adds Mellanox RegEx PMD. Signed-off-by: Yuval Avnery Signed-off-by: Ori Kam --- v5: * Move to mlx5 bus v3: * Address ML comments. v2: * Add docs. --- .gitignore| 1 + M

[dpdk-dev] [PATCH v5 02/13] regex/mlx5: add log utils

2020-07-19 Thread Ori Kam
From: Yuval Avnery Add the MLX5_REGEX_LOG macro which should be used for error prints. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/mlx5_regex.c | 5 + drivers/regex/mlx5/mlx5_regex_utils.h | 19 +

[dpdk-dev] [PATCH v5 00/13] add Mellanox RegEx PMD

2020-07-19 Thread Ori Kam
This patch series introduce the Mellanox BF2 RegEx PMD. Mellanox BF2 RegEx PMD implement the API defined in the regexdev lib [1]. This PMD allows a DPDK application to offload the RegEx functionality to Mellanox BF2 RegEx engine. [1] https://patches.dpdk.org/cover/72792/ v5: * Fix compilation

[dpdk-dev] [PATCH v1] net/vhost: support queue update

2020-07-19 Thread Matan Azrad
The commit below changed the readiness condition of vhost device to fix multi-queues issues showed with QEMU versions. Now, the vhost device is ready when the first queue-pair is ready. When more queues are being ready, the queue state callback will be triggered to notify the vhost manager. In ca

[dpdk-dev] [PATCH v2] net/mlx5: add queue start and stop feature

2020-07-19 Thread Viacheslav Ovsiienko
The mlx5 PMD did not support queue_start and queue_stop eth_dev API routines, queue could not be suspended and resumed during device operation. There is the use case when this feature is crucial for applications: - there is the secondary process handling the queue - secondary process crashed/abor

Re: [dpdk-dev] [PATCH] common/mlx5: support more fields in DevX CQ create

2020-07-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Sunday, July 19, 2020 2:11 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] common/mlx5: support more fields in DevX CQ create > > Update CQ create operation using DevX API, support add

Re: [dpdk-dev] [PATCH] net/mlx5: implement CQ for RxQ using DevX API

2020-07-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Sunday, July 19, 2020 2:13 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: implement CQ for RxQ using DevX API > > This patch continues the work to use DevX API for different

Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build

2020-07-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ali Alnubani > Sent: Sunday, July 19, 2020 2:52 PM > To: dev@dpdk.org > Cc: Suanming Mou ; Raslan Darawsheh > > Subject: [PATCH] common/mlx5: fix mlx5 build > > This fixes the following build errors by adding 2 > missing header includes: > > ``` > drive

Re: [dpdk-dev] [PATCH] common/mlx5: support more fields in DevX CQ create

2020-07-19 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Sunday, July 19, 2020 14:11 > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] common/mlx5: support more fields in DevX CQ create > > Update CQ create operation using DevX API, support additional

Re: [dpdk-dev] [PATCH v3 0/8] mlx5 PMD multi OS support - part #3

2020-07-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ophir Munk > Sent: Sunday, July 19, 2020 1:18 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Ophir Munk > ; Matan Azrad > Subject: [PATCH v3 0/8] mlx5 PMD multi OS support - part #3 > > > This patch series is part of preparing mlx5 PMD to compile > and

Re: [dpdk-dev] [PATCH v2] telemetry: add upper limit on connections

2020-07-19 Thread Thomas Monjalon
15/07/2020 17:03, Ciara Power: > This patch limits the number of client connections to the new telemetry > socket. The limit is set to 10. > > Signed-off-by: Ciara Power Not sure I should wait for any review. Applied, thanks

[dpdk-dev] [PATCH] common/mlx5: fix receiving queue doorbell register size

2020-07-19 Thread Viacheslav Ovsiienko
When received queue is being created with DevX the allocated doorbell register size is only uint64_t. That is definitely less than size of CPU cacheline and it might happen the registers attached to different queues handled by different cores are allocated within same cacheline. It might cause cont

Re: [dpdk-dev] [RFC PATCH] ethdev: add a new flow action of queue range

2020-07-19 Thread Ori Kam
Hi Fengchen, Please make sure to include maintainers next time. Thanks, Ori > -Original Message- > From: dev On Behalf Of Ori Kam > > > > > -Original Message- > > From: dev On Behalf Of Andrew Rybchenko > > > > On 7/17/20 12:32 PM, Wei Hu (Xavier) wrote: > > > From: Chengwen

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Thomas Monjalon
19/07/2020 13:41, Matan Azrad: > > From: Thomas Monjalon: > > 19/07/2020 12:56, Matan Azrad: > > > > > > From: Thomas Monjalon > > > > The detection of the CPU was done in a constructor and shared in a > > > > global variable. > > > > > > > > This variable may not be visible in the net PMD because

Re: [dpdk-dev] [RFC PATCH] ethdev: add a new flow action of queue range

2020-07-19 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Andrew Rybchenko > > On 7/17/20 12:32 PM, Wei Hu (Xavier) wrote: > > From: Chengwen Feng > > > > This patch adds a new flow action of queue range, which was used to assign > > packets to a continuous queue range. > > > > Current FD (flow di

Re: [dpdk-dev] [PATCH] app/flow-perf: fix typo in usage

2020-07-19 Thread Thomas Monjalon
06/07/2020 09:58, Wisam Jaddo: > From hairping-rss into hairpin-rss > > Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") > Cc: wis...@mellanox.com > > Signed-off-by: Wisam Jaddo Applied, thanks

Re: [dpdk-dev] [PATCH v4] app/flow-perf: fix condition of hairpin queues setup

2020-07-19 Thread Thomas Monjalon
16/07/2020 16:16, Wisam Jaddo: > The hairpin queue is the one that start from normal rxq, > and will be less than nr_queues where nr_queues is the > sum of normal and hairpin > > Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") > Cc: wis...@mellanox.com > > Signed-off-by: Wis

Re: [dpdk-dev] [RFC PATCH] ethdev: add a new flow action of queue range

2020-07-19 Thread Andrew Rybchenko
On 7/17/20 12:32 PM, Wei Hu (Xavier) wrote: > From: Chengwen Feng > > This patch adds a new flow action of queue range, which was used to assign > packets to a continuous queue range. > > Current FD (flow director) provide a useful means to assign packets to > a target queue. But it has the foll

[dpdk-dev] [PATCH] doc: update release notes for mlx5 PMD

2020-07-19 Thread Suanming Mou
Update the release notes of mlx5 PMD for two new added devargs: 1. sys_mem_en 2. decap_en Signed-off-by: Suanming Mou --- doc/guides/rel_notes/release_20_08.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst

[dpdk-dev] [PATCH] common/mlx5: fix mlx5 build

2020-07-19 Thread Ali Alnubani
This fixes the following build errors by adding 2 missing header includes: ``` drivers/common/mlx5/linux/mlx5_glue.c: In function 'mlx5_glue_destroy_flow_action': drivers/common/mlx5/linux/mlx5_glue.c:187:2: error: implicit declaration of function 'mlx5_free' [-Werror=implicit-function-dec

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Matan Azrad
From: Thomas Monjalon: > 19/07/2020 12:56, Matan Azrad: > > > > From: Thomas Monjalon > > > The detection of the CPU was done in a constructor and shared in a > > > global variable. > > > > > > This variable may not be visible in the net PMD because it was not > > > exported as part of the .map

[dpdk-dev] [PATCH] net/mlx5: implement CQ for RxQ using DevX API

2020-07-19 Thread Dekel Peled
This patch continues the work to use DevX API for different objects creation and management. On Rx control path, the RQ, RQT, and TIR objects can already be created using DevX API. This patch adds the support to create CQ for RxQ using DevX API. The corresponding event channel is also created and u

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Thomas Monjalon
19/07/2020 12:56, Matan Azrad: > > From: Thomas Monjalon > > The detection of the CPU was done in a constructor and shared in a global > > variable. > > > > This variable may not be visible in the net PMD because it was not exported > > as part of the .map file. > > Can you explain exactly when

[dpdk-dev] [PATCH] common/mlx5: support more fields in DevX CQ create

2020-07-19 Thread Dekel Peled
Update CQ create operation using DevX API, support additional fields. Signed-off-by: Dekel Peled --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/ml

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Matan Azrad
From: Thomas Monjalon > The detection of the CPU was done in a constructor and shared in a global > variable. > > This variable may not be visible in the net PMD because it was not exported > as part of the .map file. Can you explain exactly when it is not visible? > It is fixed by exporting

[dpdk-dev] [PATCH v3 8/8] mlx5: remove inclusion of Verbs header files

2020-07-19 Thread Ophir Munk
Several source files include Verbs header files as in (1). These source files will not compile under non-Linux operating systems. This commit removes this inclusion in two cases: Case 1: There is no usage of ibv_* or mlx5dv_* symbols in the source file so the inclusion in (1) can be safely removed

[dpdk-dev] [PATCH v3 6/8] net/mlx5: header file cleanup

2020-07-19 Thread Ophir Munk
The cleanup refers to header file mlx5.h. 1. Remove unused prototypes. 2. Move prototypes under their correct title. 3. Change functions to static and remove their prototye from the header file. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 102 ++

[dpdk-dev] [PATCH v3 4/8] linux/mlx5: add setters for promiscuous and all-multi

2020-07-19 Thread Ophir Munk
This commit adds Linux implementation of routines mlx5_os_set_promisc() and mlx5_os_set_promisc(). The routines call netlink APIs. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 40 drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v3 7/8] net/mlx5: refactor multi process communication

2020-07-19 Thread Ophir Munk
1. The shared data communication between the primary and the secondary processes is implemented using Linux API. Move the Linux API code under linux directory (file linux/mlx5_os.c). 2. File net/mlx5/mlx5_mp.c handles requests to the primary and secondary processes (e.g. start_rxtx, stop_rxtx). It

[dpdk-dev] [PATCH v3 5/8] net/mlx5: eliminate dependency on Linux in shared header

2020-07-19 Thread Ophir Munk
This commit eliminates Linux dependencies in shared file mlx5.h. 1. All functions using 'struct ifreq' are moved to file linux/mlx5_ethdev_os.c such that this struct can be removed from mlx5.h. 2. Function mlx5_set_flags() that uses Linux flags (e.g. IFF_UP) is changed to static and its prototype

[dpdk-dev] [PATCH v3 3/8] net/mlx5: refactor Linux MAC operations

2020-07-19 Thread Ophir Munk
Move OS specific MAC operations add, remove, modify VF into file linux/mlx5_os.c. Remove unused function mlx5_get_mac(). Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 97 drivers/net/mlx5/mlx5.h | 7 ++-

[dpdk-dev] [PATCH v3 2/8] net/mlx5: replace Linux specific calls with rte API

2020-07-19 Thread Ophir Munk
The following Linux calls are replaced by their matching rte APIs. mmap ==> rte_mem_map() munmap == >rte_mem_unmap() sysconf(_SC_PAGESIZE) ==> rte_mem_page_size() Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 9 ++- drivers/common/mlx5/mlx5_prm

[dpdk-dev] [PATCH v3 1/8] net/mlx5: move flow prio discovery and adjust under Verbs

2020-07-19 Thread Ophir Munk
Function calls mlx5_flow_adjust_priority() and mlx5_flow_discover_priorities() are Verbs based. Move them from file mlx5_flow.c to file mlx5_flow_verbs.c Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h| 1 - drivers/net/mlx5/mlx5_flow.c | 112

[dpdk-dev] [PATCH v3 0/8] mlx5 PMD multi OS support - part #3

2020-07-19 Thread Ophir Munk
This patch series is part of preparing mlx5 PMD to compile and run under multiple OSs. Part #3 v1: Initial version v2: Version rebased v3: Fix coverity complain: BRANCH_PAST_INITIALIZATION Ophir Munk (8): net/mlx5: move flow prio discovery and adjust under Verbs net/mlx5: replace Linux spec

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, July 19, 2020 13:08 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Shiri Kuzin > ; sta...@dpdk.org; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko ; Ray Kinsella ; > Neil Horman > Subject: [PATCH] common/mlx5: fix CPU detection

[dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Thomas Monjalon
The detection of the CPU was done in a constructor and shared in a global variable. This variable may not be visible in the net PMD because it was not exported as part of the .map file. It is fixed by exporting a function, which is cleaner than a variable. By checking the CPU only at the first ca

Re: [dpdk-dev] [PATCH v6 0/8] fib: implement AVX512 vector lookup

2020-07-19 Thread Thomas Monjalon
17/07/2020 18:43, Richardson, Bruce: > From: Thomas Monjalon > > 15/07/2020 14:29, Medvedkin, Vladimir: > > > On 15/07/2020 12:59, Thomas Monjalon wrote: > > > > 15/07/2020 12:35, Medvedkin, Vladimir: > > > >> On 15/07/2020 10:47, Thomas Monjalon wrote: > > > >>> 14/07/2020 16:38, Stephen Hemminge

Re: [dpdk-dev] [PATCH 0/2] net/mlx5: scatter FCS with decapsulation

2020-07-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, July 15, 2020 4:10 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Ori Kam ; Raslan Darawsheh > ; dev@dpdk.org > Subject: [PATCH 0/2] net/mlx5: scatter FCS with decapsulation > > There are some limitations on the some NICs

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h

2020-07-19 Thread Jerin Jacob
On Sun, Jul 19, 2020 at 1:12 AM Manish Chopra wrote: > > > -Original Message- > > From: dev On Behalf Of Manish Chopra > > Sent: Friday, July 17, 2020 2:19 AM > > To: Gaƫtan Rivet ; Thomas Monjalon > > > > Cc: Jerin Jacob ; Ferruh Yigit > > ; Igor Russkikh ; dpdk-dev > > > > Subject: Re

Re: [dpdk-dev] [PATCH] net/mlx5: fix rte flow items size calculation

2020-07-19 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Thursday, July 16, 2020 15:15 > To: dev@dpdk.org > Cc: Dekel Peled ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix rte flow items size calculation > > flow_dv_get_item_len returns the actual header size o

Re: [dpdk-dev] [PATCH v7 0/9] Improve mlx5 PMD driver framework for multiple classes

2020-07-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Parav Pandit > Sent: Friday, July 17, 2020 4:49 PM > To: dev@dpdk.org; gr...@u256.net; ferruh.yi...@intel.com; Thomas > Monjalon > Cc: Raslan Darawsheh ; Ori Kam > ; Matan Azrad ; > joyce.k...@arm.com; Parav Pandit > Subject: [PATCH v7 0/9] Improve mlx5

[dpdk-dev] [PATCH v2 8/8] mlx5: remove inclusion of Verbs header files

2020-07-19 Thread Ophir Munk
Several source files include Verbs header files as in (1). These source files will not compile under non-Linux operating systems. This commit removes this inclusion in two cases: Case 1: There is no usage of ibv_* or mlx5dv_* symbols in the source file so the inclusion in (1) can be safely removed

[dpdk-dev] [PATCH v2 7/8] net/mlx5: refactor multi process communication

2020-07-19 Thread Ophir Munk
1. The shared data communication between the primary and the secondary processes is implemented using Linux API. Move the Linux API code under linux directory (file linux/mlx5_os.c). 2. File net/mlx5/mlx5_mp.c handles requests to the primary and secondary processes (e.g. start_rxtx, stop_rxtx). It

[dpdk-dev] [PATCH v2 5/8] net/mlx5: eliminate dependency on Linux in shared header

2020-07-19 Thread Ophir Munk
This commit eliminates Linux dependencies in shared file mlx5.h. 1. All functions using 'struct ifreq' are moved to file linux/mlx5_ethdev_os.c such that this struct can be removed from mlx5.h. 2. Function mlx5_set_flags() that uses Linux flags (e.g. IFF_UP) is changed to static and its prototype

[dpdk-dev] [PATCH v2 4/8] linux/mlx5: add setters for promiscuous and all-multi

2020-07-19 Thread Ophir Munk
This commit adds Linux implementation of routines mlx5_os_set_promisc() and mlx5_os_set_promisc(). The routines call netlink APIs. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 40 drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v2 6/8] net/mlx5: header file cleanup

2020-07-19 Thread Ophir Munk
The cleanup refers to header file mlx5.h. 1. Remove unused prototypes. 2. Move prototypes under their correct title. 3. Change functions to static and remove their prototye from the header file. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 102 ++

[dpdk-dev] [PATCH v2 3/8] net/mlx5: refactor Linux MAC operations

2020-07-19 Thread Ophir Munk
Move OS specific MAC operations add, remove, modify VF into file linux/mlx5_os.c. Remove unused function mlx5_get_mac(). Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 97 drivers/net/mlx5/mlx5.h | 7 ++-

[dpdk-dev] [PATCH v2 1/8] net/mlx5: move flow prio discovery and adjust under Verbs

2020-07-19 Thread Ophir Munk
Function calls mlx5_flow_adjust_priority() and mlx5_flow_discover_priorities() are Verbs based. Move them from file mlx5_flow.c to file mlx5_flow_verbs.c Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h| 1 - drivers/net/mlx5/mlx5_flow.c | 112

[dpdk-dev] [PATCH v2 2/8] net/mlx5: replace Linux specific calls with rte API

2020-07-19 Thread Ophir Munk
The following Linux calls are replaced by their matching rte APIs. mmap ==> rte_mem_map() munmap == >rte_mem_unmap() sysconf(_SC_PAGESIZE) ==> rte_mem_page_size() Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 9 +++- drivers/common/mlx5/mlx5_pr

[dpdk-dev] [PATCH v2 0/8] mlx5 PMD multi OS support - part #3

2020-07-19 Thread Ophir Munk
This patch series is part of preparing mlx5 PMD to compile and run under multiple OSs. Part #3 v1: Initial version v2: Version rebased Ophir Munk (8): net/mlx5: move flow prio discovery and adjust under Verbs net/mlx5: replace Linux specific calls with rte API net/mlx5: refactor Linux MAC