Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/6] drivers: add generic API to find PCI extended cap

On 27/07/20 05:10 +, Manish Chopra wrote: > > -Original Message- > > From: Gaëtan Rivet > > Sent: Monday, July 27, 2020 4:18 AM > > To: Manish Chopra > > Cc: jerinjac...@gmail.com; Jerin Jacob Kollanukkaran ; > > ferruh.yi...@intel.com; dev@dpdk.org; Igor Russkikh > > ; Rasesh Mody ;

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/6] drivers: add generic API to find PCI extended cap

Hi, > -Original Message- > From: Manish Chopra > Sent: Monday, July 27, 2020 13:11 > To: Gaëtan Rivet > Cc: jerinjac...@gmail.com; Jerin Jacob Kollanukkaran ; > Yigit, Ferruh ; dev@dpdk.org; Igor Russkikh > ; Rasesh Mody ; GR- > Everest-DPDK-Dev ; Xu, Rosen > ; Zhang, Tianfei ; > heinric

Re: [dpdk-dev] [PATCH] net: rte_ether minor optimizations

On Fri, Jun 26, 2020 at 06:51:35PM +0200, Morten Brørup wrote: > * rte_is_broadcast_ether_addr(): > Use binary logic instead of comparisons and boolean logic, thus reducing > the number of branches. > It now resembles rte_is_zero_ether_addr(). > > * rte_ether_addr_copy(): > The source code modific

Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO

Hi, On Tue, Jun 02, 2020 at 06:49:01AM +, Matan Azrad wrote: > Hi > > From: Thomas Monjalon > > 10/08/2019 23:31, Thomas Monjalon: > > > 06/08/2019 20:17, Andrew Rybchenko: > > > > On 8/6/19 5:56 PM, Matan Azrad wrote: > > > > > The API breakage is because the ``tso_segsz`` field was document

[dpdk-dev] [dpdk-dev v1] net/ice: fix invalid hash validation

An invalid rule should not be validated successfully. If the rule is not in the supporting list, just return failure to application. Signed-off-by: Jeff Guo --- drivers/net/ice/ice_hash.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ic

[dpdk-dev] [PATCH] vdpa/mlx5: fix steering update in virtq unset

When a virtq is destroyed by the driver, it must be removed from the steering RQT which holds its reference. The driver didn't remove the virtq from RQT before destroying it what caused HW syndrome in virtq unset. Remove the virtq from RQT before destroying it. Fixes: 9f09b1ca15c5 ("vdpa/mlx5: r

Re: [dpdk-dev] [PATCH v10 01/10] eal: introduce macro for bit definition

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa > Nagarahalli > Sent: Friday, July 24, 2020 8:31 PM > > > > > Subject: [dpdk-dev] [PATCH v10 01/10] eal: introduce macro for bit > definition > > > > There are several drivers which duplicate bit generation macro. > > Introduce a ge

Re: [dpdk-dev] [PATCH 0/2] Fix vhost performance regression

Hi Maxime I understand the direction... See below From: Maxime Coquelin > On 7/24/20 10:54 AM, Maxime Coquelin wrote: > > > > > > On 7/24/20 9:06 AM, Maxime Coquelin wrote: > >> Hi Yinan, > >> > >> On 7/24/20 6:55 AM, Wang, Yinan wrote: > >>> Hi Maxime, > >>> > >>> The performance drop issue ca

Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO

Hi Olivier From: Olivier Matz: > Hi, > > On Tue, Jun 02, 2020 at 06:49:01AM +, Matan Azrad wrote: > > Hi > > > > From: Thomas Monjalon > > > 10/08/2019 23:31, Thomas Monjalon: > > > > 06/08/2019 20:17, Andrew Rybchenko: > > > > > On 8/6/19 5:56 PM, Matan Azrad wrote: > > > > > > The API bre

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

> > On Mon, 20 Jul 2020 12:54:08 +, Fady Bader wrote: > > [snip] > > > > Getting the same error with a setup similar to Dmitry's. My setup: > > > > SDK 10.0.18362, > > > > > > I'm sending v4 patch that should resolve this. > > > > > > > clang 9.0.0. What version of clang are you using on you

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

> -Original Message- > From: Bruce Richardson > Sent: Wednesday, July 22, 2020 1:31 PM > To: Fady Bader > Cc: Dmitry Kozlyuk ; Narcisa Ana Maria Vasile > ; dev@dpdk.org; Thomas Monjalon > ; Tasnim Bashar ; Tal > Shnaiderman ; Yohad Tor ; > harini.ramakrish...@microsoft.com; ocard...@mi

[dpdk-dev] [PATCH] net/mlx5: fix CQ interrupt handling and cleanup

Recent patch added creation of Rx CQ using DevX API. The reading of events from DevX channel was not done correctly. This patch fixes the event reading, using the correct data structure. Cleanup after CQ creation, in case of error, is also updated. Fixes: 08d1838f645a ("net/mlx5: implement CQ for

[dpdk-dev] [PATCH] crypto/armv8: fix typos and compilation

Typo in debug log switch macro caused debug log cannot be enabled. Fixed the typo to match option defined in config file. Typo in crypto dev name macro caused unexpected device name in log. Fixed the typo to log with correct device name. Solved compilation error when debug log is enabled: rte_arm

Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO

On Mon, Jul 27, 2020 at 08:41:47AM +, Matan Azrad wrote: > > Hi Olivier > > From: Olivier Matz: > > Hi, > > > > On Tue, Jun 02, 2020 at 06:49:01AM +, Matan Azrad wrote: > > > Hi > > > > > > From: Thomas Monjalon > > > > 10/08/2019 23:31, Thomas Monjalon: > > > > > 06/08/2019 20:17, Andre

Re: [dpdk-dev] [dpdk-dev v1] net/ice: fix invalid hash validation

> -Original Message- > From: Guo, Jia > Sent: Monday, July 27, 2020 3:59 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; Su, Simei ; Guo, Jia > > Subject: [dpdk-dev v1] net/ice: fix invalid hash validation > > An invalid rule should not be validated successfully. If the rule

Re: [dpdk-dev] [PATCH v2] eal/linux: do not create user mem map repeatedly when it exists

On 25-Jul-20 10:59 AM, wangyunjian wrote: -Original Message- From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] Sent: Friday, July 24, 2020 9:25 PM To: wangyunjian ; dev@dpdk.org; david.march...@redhat.com Cc: Lilijun (Jerry) ; xudingke ; sta...@dpdk.org Subject: Re: [dpdk-dev] [PA

[dpdk-dev] [Bug 516] Multiple Intel Ethernet drivers do not conform to rte_eth_rx_burst() API

https://bugs.dpdk.org/show_bug.cgi?id=516 Bug ID: 516 Summary: Multiple Intel Ethernet drivers do not conform to rte_eth_rx_burst() API Product: DPDK Version: unspecified Hardware: All OS: All St

Re: [dpdk-dev] [PATCH] crypto/armv8: fix typos and compilation

Hello Ruifeng, On Mon, Jul 27, 2020 at 10:58 AM Ruifeng Wang wrote: > > Typo in debug log switch macro caused debug log cannot be enabled. > Fixed the typo to match option defined in config file. > > Typo in crypto dev name macro caused unexpected device name in log. > Fixed the typo to log with

[dpdk-dev] [PATCH v4] net/ice: fix GTPU down/uplink and extension conflict

When adding a RSS rule with GTPU_DWN/UP, it will write from top to bottom for profile due to firmware limitation. If a RSS rule with GTPU_EH already exists, then GTPU_DWN/UP packet will match GTPU_EH profile. This patch solves this issue by remembering a gtpu_eh RSS configure and removing it before

[dpdk-dev] [PATCH] doc: scheduler API deprecation notice

This patch adds a deprecation notice about upcoming changes in public API of the Scheduler PMD. Signed-off-by: Adam Dybkowski Acked-by: Fan Zhang --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guide

Re: [dpdk-dev] ixgbe vector rx does not conform to rte_eth_rx_burst() API

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Saturday, July 18, 2020 5:45 AM > > > From: dev On Behalf Of Zhao1, Wei > > Sent: Saturday, July 18, 2020 11:32 AM > > To: Morten Brørup ; Guo, Jia > > > > > > HI, > > > > > From: Morten Brørup > > > Sent: Thursday, July

Re: [dpdk-dev] [PATCH] crypto/armv8: fix typos and compilation

> -Original Message- > From: David Marchand > Sent: Monday, July 27, 2020 5:39 PM > To: Ruifeng Wang > Cc: akhil.go...@nxp.com; dev ; Honnappa Nagarahalli > ; nd ; dpdk stable > > Subject: Re: [dpdk-dev] [PATCH] crypto/armv8: fix typos and compilation > > Hello Ruifeng, > > On Mon, Ju

[dpdk-dev] [PATCH v5 2/2] doc: update QAT PMD release notes

This patch updates 20.08 release notes inside the part that describe changes in Intel QuickAssist PMD. Fixes: faa57df0b458 ("crypto/qat: support ChaCha20-Poly1305") Fixes: 9904ff684981 ("common/qat: improve multi-process handling") Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe --- doc/gu

[dpdk-dev] [PATCH v5 1/2] common/qat: support GEN2 QAT device 200xx

This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 7 +-- doc/guides/rel_notes/release_20_08.rst | 2 ++ drivers/common/qat/qat_dev

[dpdk-dev] [PATCH v2] test/cycles: restore original delay function

test_delay_us_sleep registers sleep based delay for testing. This changes the default delay function of testing environment. It is not expected. Restore defalut delay function after the test to fix the issue. Fixes: a51639cc720a ("eal: add nanosleep based delay function") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH v5 0/2] common/qat: support GEN2 QAT device 200xx

This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). v2: * rename the device v3: * improve release notes v4: * simplify release notes v5: * split actual implementation patch and additional release notes update Adam Dybkowski (2): comm

[dpdk-dev] [PATCH v2] test/cycles: restore original delay function

test_delay_us_sleep registers sleep based delay for testing. This changes the default delay function of testing environment. It is not expected. Restore default delay function after the test to fix the issue. Fixes: a51639cc720a ("eal: add nanosleep based delay function") Cc: sta...@dpdk.org Sig

Re: [dpdk-dev] [PATCH v3 09/22] net/bnxt: ignore VLAN priority mask

On 7/24/2020 6:32 AM, Ajit Khaparde wrote: > From: Kishore Padmanabha > > This is a work around for the OVS setting offload rules that > are passing vlan priority mask as wild card and currently we > do not support it. > > Signed-off-by: Kishore Padmanabha > Reviewed-by: Michael Baucom > --- >

Re: [dpdk-dev] [PATCH v3 05/22] net/bnxt: add tf hash API

On 7/24/2020 6:32 AM, Ajit Khaparde wrote: > From: Mike Baucom > > Added tf_hash API for common hash uses across tf_core functions > > Signed-off-by: Mike Baucom > Reviewed-by: Farah Smith > Reviewed-by: Kishore Padmanabha 'tf' is TruFlow, righ? I think 'tf' is hard to understand, can you pl

Re: [dpdk-dev] ixgbe vector rx does not conform to rte_eth_rx_burst() API

> -Original Message- > From: Morten Brørup > Sent: Monday, July 27, 2020 5:42 PM > To: Zhao1, Wei ; Guo, Jia ; Xing, > Beilei ; Zhang, Qi Z ; Wang, > Xiao W ; Wu, Jingjing ; Yang, > Qiming ; Xu, Rosen > Cc: dev@dpdk.org; Thomas Monjalon ; Yigit, Ferruh > ; Andrew Rybchenko > Subject: R

Re: [dpdk-dev] [PATCH v3 13/22] net/bnxt: modify ulp mapper to use tbl search

On 7/24/2020 6:32 AM, Ajit Khaparde wrote: > From: Mike Baucom > > modified ulp mappper to use the new tf_search_tbl_entry API. > When search before allocation is requested, mapper calls > tc_search_tbl_entry with the alloc flag. > > - On HIT, the result and table index is returned. > - On MISS,

Re: [dpdk-dev] [PATCH v3 00/22] bnxt patches

On 7/24/2020 5:48 PM, Ajit Khaparde wrote: > > > On Thu, Jul 23, 2020 at 10:32 PM Ajit Khaparde > wrote: > > Some fixes, cleanups and changes to augment pre-existing > support in infrastructure > > Please apply > > v1->v2: >  - Fixed some

Re: [dpdk-dev] [PATCH v3 13/22] net/bnxt: modify ulp mapper to use tbl search

On Mon, Jul 27, 2020 at 4:06 PM Ferruh Yigit wrote: > > On 7/24/2020 6:32 AM, Ajit Khaparde wrote: > > From: Mike Baucom > > > > modified ulp mappper to use the new tf_search_tbl_entry API. > > When search before allocation is requested, mapper calls > > tc_search_tbl_entry with the alloc flag. >

Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice for sched changes

-Original Message- From: dev On Behalf Of Savinay Dharmappa Sent: Thursday, July 16, 2020 6:56 PM To: Dharmappa, Savinay ; dev@dpdk.org Cc: Dumitrescu, Cristian ; Singh, Jasvinder Subject: [dpdk-dev] [PATCH v2] doc: add deprecation notice for sched changes Add deprecation note for ma

Re: [dpdk-dev] [PATCH v2] hash: fix return value of null not checked

On Wed, Jul 22, 2020 at 5:59 AM wangyunjian wrote: > The function rte_zmalloc_socket() could return NULL, the return > value need to be checked. > > Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") > Cc: sta...@dpdk.org > > Reported-by: Bin Huang > Signed-off-by: Yunjian Wang > R

Re: [dpdk-dev] [PATCH v2] test/cycles: restore original delay function

On Mon, Jul 27, 2020 at 12:22 PM Ruifeng Wang wrote: > > test_delay_us_sleep registers sleep based delay for testing. > This changes the default delay function of testing environment. > It is not expected. > > Restore default delay function after the test to fix the issue. > > Fixes: a51639cc720a

Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type define

> -Original Message- > From: Fu, Patrick > Sent: Thursday, July 23, 2020 1:39 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Cc: Fu, Patrick > Subject: [PATCH v1] vhost: fix async callback return type define > > From: Patrick Fu > > The async copy device callback

[dpdk-dev] [PATCH] ethdev: fix RSS flow expansion in case of mismatch

Function rte_flow_expand_rss() is used to expand a flow rule with partial pattern into several rules, to ensure all relevant packets are matched. It uses utility function rte_flow_expand_rss_item_complete(), to check if the last valid item in the flow rule pattern needs to be completed. For example

Re: [dpdk-dev] [PATCH v3] vhost: fix async copy fail on multi-page buffers

Hi Patrick, > -Original Message- > From: Fu, Patrick > Sent: Monday, July 27, 2020 2:33 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Cc: Fu, Patrick > Subject: [PATCH v3] vhost: fix async copy fail on multi-page buffers > > From: Patrick Fu > > Async copy fails

Re: [dpdk-dev] [PATCH] net/tap: avoid using SIGIO

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, July 15, 2020 1:58 AM > > SIGIO maybe used by application, instead choose another rt-signal. > Linux allows any signal to be used for signal based IO. > Search for an unused signal in the available rt-signa

Re: [dpdk-dev] [PATCH] ethdev: fix RSS flow expansion in case of mismatch

Resending To: maintaners. > -Original Message- > From: Dekel Peled > Sent: Monday, July 27, 2020 3:58 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] ethdev: fix RSS flow expansion in case of mismatch > > Function rte_fl

[dpdk-dev] [Bug 517] Traffic Class Assignment

https://bugs.dpdk.org/show_bug.cgi?id=517 Bug ID: 517 Summary: Traffic Class Assignment Product: DPDK Version: 18.08 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major Priority: Normal

Re: [dpdk-dev] [PATCH] net/mlx5: fix CQ interrupt handling and cleanup

Hi, > -Original Message- > From: Dekel Peled > Sent: Monday, July 27, 2020 11:51 AM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: fix CQ interrupt handling and cleanup > > Recent patch added creation of Rx CQ using DevX API. > T

[dpdk-dev] [PATCH 20.11] usertools/dpdk-devbind: hide "if" value for non-network devs

The "if", or interface, field in the status display of dpdk-devbind is only relevant for network interfaces, so don't display it for other device types. Signed-off-by: Bruce Richardson --- usertools/dpdk-devbind.py | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/user

Re: [dpdk-dev] [PATCH 1/2] vhost: fix guest notification setting

> -Original Message- > From: Maxime Coquelin > Sent: Thursday, July 23, 2020 9:09 PM > To: dev@dpdk.org; ma...@mellanox.com; Xia, Chenbo > ; Liu, Yong ; Wang, Yinan > > Cc: tho...@monjalon.net; Yigit, Ferruh ; > david.march...@redhat.com; Maxime Coquelin > > Subject: [PATCH 1/2] vhost:

Re: [dpdk-dev] [PATCH 2/2] net/vhost: fix queue update

Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, July 23, 2020 9:09 PM > To: dev@dpdk.org; ma...@mellanox.com; Xia, Chenbo > ; Liu, Yong ; Wang, Yinan > > Cc: tho...@monjalon.net; Yigit, Ferruh ; > david.march...@redhat.com; Maxime Coquelin > > Subject: [PATCH 2

[dpdk-dev] [PATCH] vdpa/mlx5: fix notification timing

The issue is relevant only for the timer event modes: 0 and 1. When the HW finishes to consume a burst of the guest Rx descriptors, it creates a CQE in the CQ. When traffic stops, the mlx5 driver arms the CQ to get a notification when a specific CQE index is created - the index to be armed is the

[dpdk-dev] [PATCH] eventdev: fix return value of null not checked

From: Yunjian Wang The function rte_zmalloc() could return NULL, the return value need to be checked. Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 ++ 1 file changed,

[dpdk-dev] [PATCH] net/qede: fix qede milliseconds sleep macro

The macro defined for milliseconds sleep was not putting the thread to sleep and was simply calling a delay routine. This fix redefines the macro to call the correct rte sleep API. Fixes: ec94dbc57362 ("qede: add base driver") Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by

[dpdk-dev] [PATCH] vdpa/mlx5: fix completion queue initialization

Vdpa device failed to initialize 2nd VQ during setup. From FW syndrome, unsupported CQE size was specified in CQ initialization attributes. The unsupported CQE size comes from uninitialized stack struct data, and the struct has new fields defined recently which are not initialized in vdpa code. T

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

Alexander Kozyrev writes: > > > > > > @@ -1790,9 +1792,9 @@ mlx5_rx_burst_mprq(void *dpdk_rxq, > > struct > > > > > > rte_mbuf **pkts, uint16_t pkts_n) void *buf_addr; > > > > > > > > > > > > /* Increment the refcnt of the whole chunk. */ > > > > > > -rte_atomic16_add_return(&buf->refcnt, 1);

[dpdk-dev] [PATCH] app/testpmd: fix txonly mode timestamp intitialization

The testpmd application forwards data in multiple threads. In the txonly mode the Tx timestamps must be initialized on per thread basis to provide phase shift for the packet burst being sent. This per thread initialization was performed on zero value of the variable in thread local storage and happ

Re: [dpdk-dev] DPDK hugepage memory fragmentation

Hi Anatoly, Since we do not have the driver support of SRIOv with VFIO, we are using IGB_UIO . Basically our application is crashing due to the buffer allocation failure. I believe because it didn't get a contiguous memory location and fails to allocate the memory. Is there any API, I can use to du

[dpdk-dev] [PATCH] doc/mlx5: add timestamp upper limitaion description

Add description about Tx scheduling timstamp upper limit. It timstamp exceed the value it is marked by PMD as being into "too-distant-future" and not sheduled at all (is being sent without any wait). Signed-off-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 7 +++ 1 file changed, 7

[dpdk-dev] [PATCH v2] doc/mlx5: add timestamp upper limitation description

Add description about Tx scheduling timstamp upper limit. It timstamp exceed the value it is marked by PMD as being into "too-distant-future" and not scheduled at all (is being sent without any wait). Signed-off-by: Viacheslav Ovsiienko --- v1->v2: typo fix doc/guides/nics/mlx5.rst | 7 +++

Re: [dpdk-dev] [PATCH] ethdev: fix RSS flow expansion in case of mismatch

Hi Dekel, > -Original Message- > From: Dekel Peled > > Resending To: maintaners. > > > -Original Message- > > From: Dekel Peled > > > > Function rte_flow_expand_rss() is used to expand a flow rule with partial > > pattern into several rules, to ensure all relevant packets are m

Re: [dpdk-dev] [PATCH v1] app/test-regex: add RegEx test application

27/07/2020 07:12, Ori Kam: > From: Jerin Jacob > > On Mon, Jul 27, 2020 at 1:28 AM Ori Kam wrote: > > > --- /dev/null > > > +++ b/app/test-regex/hello_world.rof2 > > > @@ -0,0 +1,45 @@ > > > +# > > > +# rof_version: 2 > > > +# > > > +# date:20200210_164643 > > > +# > > > +# rxp_compiler:5.7.18007

Re: [dpdk-dev] [PATCH v10 01/10] eal: introduce macro for bit definition

> From: Morten Brørup > Sent: Monday, July 27, 2020 1:52 PM > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa > > Nagarahalli > > Sent: Friday, July 24, 2020 8:31 PM > > > > > > > > > Subject: [dpdk-dev] [PATCH v10 01/10] eal: introduce macro for bit > > definition > > > > > > T

Re: [dpdk-dev] [PATCH v1] app/test-regex: add RegEx test application

26/07/2020 21:58, Ori Kam: > --- a/app/meson.build > +++ b/app/meson.build > @@ -12,6 +12,7 @@ apps = [ > 'test-bbdev', > 'test-cmdline', > 'test-compress-perf', > + 'test-regex', > 'test-crypto-perf', > 'test-eventdev', > 'test-fib', In this list, I think t

Re: [dpdk-dev] [PATCH] kni: fix kernel deadlock when using mlx devices

On 5/6/2020 1:14 AM, Stephen Hemminger wrote: > On Wed, 18 Mar 2020 16:17:57 +0100 > Thomas Monjalon wrote: > >> 17/01/2020 17:43, Ferruh Yigit: >>> On 12/22/2019 5:55 PM, Stephen Hemminger wrote: This fixes a deadlock when using KNI with bifurcated drivers. Bringing kni device up alw

[dpdk-dev] [PATCH v12 00/10] Improve mlx5 PMD driver framework for multiple classes

This series introduces mlx5 common driver layer to support multiple class of devices for a single PCI device. Motivation and example -- mlx5 PCI device supports multiple class of devices such as net, vdpa and regex devices. Currently only one pmd (either net or vdpa) can bind

[dpdk-dev] [PATCH v12 06/10] common/mlx5: avoid using class constructor priority

mlx5_common is shared library between mlx5 net, VDPA and regex PMD. It is better to use common initialization helper instead of using RTE_PRIORITY_CLASS priority. Reviewed-by: David Marchand Suggested-by: David Marchand Signed-off-by: Parav Pandit --- Changelog: v7->v8: - new patch --- driver

[dpdk-dev] [PATCH v12 05/10] regex/mlx5: fix segmentation fault during error unwinding

When fail to initialize the device, avoid segmentation fault while accessing uninitialized priv. Fixes: cfc672a90b74 ("regex/mlx5: support probing") Signed-off-by: Parav Pandit --- Changelog: v9->v10: - Corrected type in commit log v7->v8: - Rebased - new patch --- drivers/regex/mlx5/mlx5_re

[dpdk-dev] [PATCH v12 04/10] common/mlx5: fix void parameters in glue wrappers

Following two errors are reported when compiled with gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5). drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a

[dpdk-dev] [PATCH v12 01/10] eal: introduce macro for bit definition

There are several drivers which duplicate bit generation macro. Introduce a generic bit macros so that such drivers avoid redefining same in multiple drivers. Signed-off-by: Parav Pandit Acked-by: Matan Azrad Acked-by: Morten Brørup --- Changelog: v11->v12: - Define RTE_BIT32 macro as well -

[dpdk-dev] [PATCH v12 02/10] drivers: fix indent of directory list

From: Thomas Monjalon Define each sub-directory on its own line ended with a comma, and use a simple indent. Acked-by: Bruce Richardson Reviewed-by: David Marchand Signed-off-by: Thomas Monjalon --- Changelog: v7->8: - new patch --- drivers/meson.build | 24 +--- 1 file

[dpdk-dev] [PATCH v12 03/10] drivers: relax dependency order

From: Thomas Monjalon Drivers dependencies are evaluated in the order defined per their parent directory (also called class). This strict ordering prevents from having pairs of drivers from two classes with different dependency ordering. For example, if the mlx5 common code depends on the pci bus

[dpdk-dev] [PATCH v12 07/10] common/mlx5: change class values as bits

mlx5 PCI Device supports multiple classes of devices such as net, vdpa, and/or regex. To support these multiple classes, change mlx5_class to a bitmap values so that if users asks to enable multiple of them, all supported classes can be parsed. Signed-off-by: Parav Pandit Acked-by: Matan Azrad -

[dpdk-dev] [PATCH v12 08/10] common/mlx5: introduce layer to support multiple class drivers

Add generic mlx5 PCI PMD layer as part of existing common_mlx5 module. This enables multiple classes (net, regex, vdpa) PMDs to be supported at same time. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v11->v12: - Added releases note back v10->v11: - Moved class combination h

[dpdk-dev] [PATCH v12 09/10] common/mlx5: register class drivers through common layer

Migrate mlx5 net, vdpa and regex PMD to start using mlx5 common class driver. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v10->v11: - Moved new class combinations to previous patch v8->v9: - Removed leftover inclusion of mlx5_pci bus include directory --- drivers/net/mlx5

[dpdk-dev] [PATCH v12 10/10] common/mlx5: remove class check from class drivers

Now that mlx5_pci PMD checks for enabled classes and performs probe(), remove() of associated classes, individual class driver does not need to check if other driver is enabled. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 37

Re: [dpdk-dev] [PATCH] kni: fix kernel deadlock when using mlx devices

On Mon, 27 Jul 2020 18:33:08 +0100 Ferruh Yigit wrote: > On 5/6/2020 1:14 AM, Stephen Hemminger wrote: > > On Wed, 18 Mar 2020 16:17:57 +0100 > > Thomas Monjalon wrote: > > > >> 17/01/2020 17:43, Ferruh Yigit: > >>> On 12/22/2019 5:55 PM, Stephen Hemminger wrote: > This fixes a dea

Re: [dpdk-dev] [PATCH v2 0/5] compiling ethdev lib under windows

On Sun, Jul 26, 2020 at 09:24:26AM +, Fady Bader wrote: > Hi Narcisa, > I saw that the net patch was acked, can you also review this patch too to see > if more work should be done. > Hi Fady, Yes, I will look at it. > Thanks, > Fady > > > > -Original Message- > > From: Fady Bader

[dpdk-dev] [PATCH 20.08 3/6] doc: fix incorrect reference to master process

Correct terminolgy here is primary process. This is a bug in original doc. Fixes: fc1f2750a3ec ("doc: programmers guide") Cc: bernard.iremon...@intel.com Signed-off-by: Stephen Hemminger --- doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[dpdk-dev] [PATCH 20.08 0/6] Inclusive language fixes and deprecation notices

This set annonuces the upcoming changes for 20.11 around master/slave and blacklist/whitelist. It also fixes several places in the current code where the wrong and confusing terminolgy was used. Stephen Hemminger (6): doc: announce deprecation of master lcore kni: fix reference to master/slave

[dpdk-dev] [PATCH 20.08 5/6] rte_ethdev: change comment to rte_dev_eth_mac_addr_add

The comment used the term whitelist and was awkardly written. Replace it with simpler direct description of adding a new address. No code or API changes for this. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_ethdev/rte_ethdev.h | 3 +-- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH 20.08 4/6] doc: announce deprecation blacklist/whitelist

Announce upcoming changes for 20.11 around the terms blacklist and whitelist. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/deprecation.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.r

[dpdk-dev] [PATCH 20.08 6/6] check_maintainers: change variable names

Change variable names in python script: replace whitelist with include_files and blacklist with exclude_files. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- devtools/check-maintainers.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/devtools/check-ma

[dpdk-dev] [PATCH 20.08 1/6] doc: announce deprecation of master lcore

Announce upcoming changes related to master/slave in reference to lcore. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/deprecation.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst i

[dpdk-dev] [PATCH 20.08 2/6] kni: fix reference to master/slave process

In DPDK, the correct terms for process are primary/secondary. This is bugfix, not a change in terms for new release. Fixes: f2e7592c474c ("kni: fix multi-process support") Signed-off-by: Stephen Hemminger --- lib/librte_kni/rte_kni.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [dpdk-dev] [PATCH] net/tap: avoid using SIGIO

On Mon, 27 Jul 2020 15:19:32 +0200 Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Wednesday, July 15, 2020 1:58 AM > > > > SIGIO maybe used by application, instead choose another rt-signal. > > Linux allows any signal to be used for sign

[dpdk-dev] [PATCH v4 2/6] net/qede: define PCI config space specific osals

This patch defines various PCI config space access APIs in order to read and find IOV specific PCI capabilities. With these definitions implemented, it enables the base driver to do SR-IOV specific initialization and HW specific configuration required from PF-PMD driver instance. Signed-off-by: M

[dpdk-dev] [PATCH v4 1/6] drivers: add generic API to find PCI extended cap

By adding generic API, this patch removes individual functions/defines implemented by drivers to find extended PCI capabilities. Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh --- drivers/bus/pci/pci_common.c | 43 ++ drivers/bus/pci/rte_bus_pci.h

[dpdk-dev] [PATCH v4 0/6] qede: SR-IOV PF driver support

Hi, This series adds SR-IOV PF pmd driver support to have VF pmd driver work over PF pmd driver instances in order to run the adapter completely under DPDK environment for one of the use cases like ovs-dpdk. This is very initial bring-up with following testing covered - * Enable/Disable SR-IOV V

[dpdk-dev] [PATCH v4 4/6] net/qede: add infrastructure support for VF load

This patch adds necessary infrastructure support (required to handle messages from VF and sending ramrod on behalf of VF's configuration request from alarm handler context) to start/load the VF-PMD driver instance on top of PF-PMD driver instance. Signed-off-by: Manish Chopra Signed-off-by: Igor

[dpdk-dev] [PATCH v4 5/6] net/qede: initialize VF MAC and link

This patch configures VFs with random mac if no MAC is provided by the PF/bulletin. This also adds required bulletin APIs by PF-PMD driver to communicate LINK properties/changes to the VFs through bulletin update mechanism. With these changes, VF-PMD instance is able to run fastpath over PF-PMD dr

[dpdk-dev] [PATCH v4 3/6] net/qede: configure VFs on hardware

Based on number of VFs enabled at PCI, PF-PMD driver instance enables/configures those VFs from hardware perspective, such that in later patches they could get required HW access to communicate with PFs for slowpath configuration and run the fastpath themsleves. This patch also add two new qede IO

[dpdk-dev] [PATCH v4 6/6] net/qede: add VF FLR support

This patch adds required bit to handle VF FLR indication from Management FW (MFW) of the device With that VFs were able to load in VM (VF attached as PCI passthrough to the guest VM) followed by FLR successfully Updated the docs/guides with the feature support Signed-off-by: Manish Chopra Signe

Re: [dpdk-dev] [PATCH v4 1/6] drivers: add generic API to find PCI extended cap

On 27/07/20 15:03 -0700, Manish Chopra wrote: > By adding generic API, this patch removes individual > functions/defines implemented by drivers to find extended > PCI capabilities. > > Signed-off-by: Manish Chopra > Signed-off-by: Igor Russkikh LGTM, Reviewed-by: Gaetan Rivet -- Gaëtan

Re: [dpdk-dev] [PATCH v2 6/8] net/i40e/base: support unused ports disabling

Acked-by: Jeff Guo On 7/27/2020 1:34 PM, Guinan Sun wrote: This patch adds support for disabling unused ports. Signed-off-by: Damian Milosek Signed-off-by: Guinan Sun --- V2: * Modifiy title and message --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + drivers/net/i40e/base/i40e_common.c

Re: [dpdk-dev] [PATCH v2 0/8] update i40e base code

Acked-by: Jeff Guo On 7/27/2020 1:34 PM, Guinan Sun wrote: update i40e base code. source code of i40e driver: cid-i40e.2020.07.16.tar.gz dropped by the team which develop basic drivers for any i40e NIC. changelog in ND share repo: From fc99a1143d3f ("i40e-shared: FEC on/off support flag for

[dpdk-dev] [PATCH] doc: vhost multi-queue reconnection known issue

This patch added known issue for vhost multi-queue reconnection with virtio-net/virtio-pmd. Signed-off-by: Xuan Ding --- doc/guides/rel_notes/known_issues.rst | 21 + 1 file changed, 21 insertions(+) diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/

Re: [dpdk-dev] [PATCH v10 01/10] eal: introduce macro for bit definition

> > > > > Subject: [dpdk-dev] [PATCH v10 01/10] eal: introduce macro for bit > > definition > > > > > > There are several drivers which duplicate bit generation macro. > > > Introduce a generic bit macros so that such drivers avoid redefining > > same in > > > multiple drivers. > > > > > > Signed-

Re: [dpdk-dev] [PATCH v1] vdpa/ifc: fix vring update after device config

Hi Rosen, > -Original Message- > From: Xu, Rosen > Sent: Sunday, July 26, 2020 9:27 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Yigit, Ferruh ; > Wang, Xiao W > Subject: RE: [PATCH v1] vdpa/ifc: fix vring update after device config > > Hi, > > > -Original

Re: [dpdk-dev] [PATCH v1] vdpa/ifc: fix vring update after device config

Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, July 28, 2020 10:35 > To: Xu, Rosen ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Yigit, Ferruh ; > Wang, Xiao W > Subject: RE: [PATCH v1] vdpa/ifc: fix vring update after device config > > Hi Rosen, > > > -Ori

Re: [dpdk-dev] [PATCH v3] vhost: fix async copy fail on multi-page buffers

Hi, > -Original Message- > From: Xia, Chenbo > Sent: Monday, July 27, 2020 9:14 PM > To: Fu, Patrick ; dev@dpdk.org; > maxime.coque...@redhat.com > Subject: RE: [PATCH v3] vhost: fix async copy fail on multi-page buffers > > Hi Patrick, > > > -Original Message- > > From: Fu, Pat

[dpdk-dev] [PATCH v2] test/mcslock: move performance test to perf tests

Move the MCS lock performance test into perf tests. Signed-off-by: Phil Yang Reviewed-by: Gavin Hu --- v2: 1. Rebase code. 2. Split from the original patchset. MAINTAINERS | 1 + app/test/Makefile| 1 + app/test/autotest_data.py| 6 +++ app/test/meson.bui

[dpdk-dev] [PATCH v4] vhost: fix async copy fail on multi-page buffers

From: Patrick Fu Async copy fails when single ring buffer vector is splited on multiple physical pages. This happens because current hpa address translation function doesn't handle multi-page buffers. A new gpa to hpa address conversion function, which returns the hpa on the first hitting host pa

[dpdk-dev] [PATCH v2] test/atomic: reduce the number of loops to avoid timeouts

Reduce the number of loops to 10K to avoid the meson test timeout warning. For example: $ sudo meson test -C build --suite DPDK:fast-tests / atomic_autotest -t 50 [...] 1/1 DPDK:fast-tests / atomic_autotest OK 187.35s Signed-off-by: Phil Yang --- v2: Split from the original patchset.

[dpdk-dev] [PATCH] net/i40e: fix a wrong bitmap free call

From: Chenmin Sun This patch fixes the coverity warning #361024. rte_bitmap_free() is not a right way to free a bitmap, replacing it with rte_free(). Signed-off-by: Chenmin Sun --- drivers/net/i40e/i40e_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i4

  1   2   >