Re: [dpdk-dev] [PATCH v4] app/test-regex: add RegEx test application

2020-07-30 Thread Thomas Monjalon
29/07/2020 20:09, Ori Kam: > From: Yuval Avnery > > Following the new RegEx class. > There is a need to create a dedicated test application in order to > validate this class and PMD. > > Unlike net device this application loads data from a file. > > This commit introduces the new RegEx test app

[dpdk-dev] [PATCH] net/i40e: fix link status

2020-07-30 Thread Guinan Sun
The PF driver supports to use link_event_adv or link_event to get the link speed. However, when using link_event_adv to get link speed, there is a lack of logic to convert between link speed type (I40E_LINK_SPEED_XXX) and mbps type (SPEED_XXX). As a result, the mbps type is not recognized, so the l

Re: [dpdk-dev] [PATCH v2 20.08 1/6] doc: announce deprecation of master lcore

2020-07-30 Thread Bruce Richardson
On Wed, Jul 29, 2020 at 05:57:59PM -0700, Stephen Hemminger wrote: > Announce upcoming changes related to master/slave in reference > to lcore. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/deprecation.rst | 17 + > 1 file changed, 17 insertions(+) > > diff -

Re: [dpdk-dev] [PATCH v2 20.08 2/6] kni: fix reference to master/slave process

2020-07-30 Thread Bruce Richardson
On Wed, Jul 29, 2020 at 05:58:00PM -0700, Stephen Hemminger wrote: > In DPDK, the correct terms for process are primary/secondary. > This is bugfix, not a change in terms for new release. > > Fixes: f2e7592c474c ("kni: fix multi-process support") > Signed-off-by: Stephen Hemminger > --- Acked-by:

Re: [dpdk-dev] [PATCH v2 20.08 4/6] doc: announce deprecation blacklist/whitelist

2020-07-30 Thread Bruce Richardson
On Wed, Jul 29, 2020 at 05:58:02PM -0700, Stephen Hemminger wrote: > Announce upcoming changes for 20.11. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/deprecation.rst | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/doc/guides/rel_notes/deprec

[dpdk-dev] [PATCH] net/ice: fix FDIR GTPU rule create fail

2020-07-30 Thread Wei Zhao
For GTPU rule with extend header of DOWN and UP link PDU type, it should use different trainning packet, also for GTPU rule without extend header the trainning packet for FDIR is also different. This patch enable these case. Fixes: 934fd00c9389 ("net/ice/base: fix GTPU IP hash") Signed-off-by: We

[dpdk-dev] Detecting memory leaks in PMD /testpmd

2020-07-30 Thread P Smith
Hi All, Is there a simple tool to track / detect memory used by the PMD especially since it uses hugepages and rte_*alloc() and friends so traditional app memory checkers may not be applicable here ?I see some tracepoints being enabled, but could someone please point to how to use that f

Re: [dpdk-dev] [PATCH] net/i40e: fix link status

2020-07-30 Thread Jeff Guo
hi, guinan On 7/30/2020 4:25 PM, Guinan Sun wrote: The PF driver supports to use link_event_adv or link_event to get the link speed. However, when using link_event_adv to get link speed, there is a lack of logic to convert between link speed type (I40E_LINK_SPEED_XXX) and mbps type (SPEED_XXX).

Re: [dpdk-dev] [PATCH] net/i40e: fix link status

2020-07-30 Thread Sun, GuinanX
Hi Jeff > -Original Message- > From: Guo, Jia > Sent: Thursday, July 30, 2020 5:12 PM > To: Sun, GuinanX ; Xing, Beilei > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH] net/i40e: fix link status > > hi, guinan > > On 7/30/2020 4:25 PM, Guinan Sun wrote: > > The PF driver sup

Re: [dpdk-dev] [PATCH] net/ice: fix FDIR GTPU rule create fail

2020-07-30 Thread Huang, ZhiminX
Tested-by: Huang, ZhiminX Regards, HuangZhiMin -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao Sent: Thursday, July 30, 2020 4:31 PM To: dev@dpdk.org Cc: Zhang, Qi Z ; Zhao1, Wei Subject: [dpdk-dev] [PATCH] net/ice: fix FDIR GTPU rule create fail For G

[dpdk-dev] [PATCH v2] net/ice: fix FDIR GTPU rule create fail

2020-07-30 Thread Wei Zhao
For GTPU rule without extend header the trainning packet for FDIR is different. This patch enable these case. Fixes: 934fd00c9389 ("net/ice/base: fix GTPU IP hash") Signed-off-by: Wei Zhao --- drivers/net/ice/base/ice_fdir.c | 63 +++- drivers/net/ice/base/ice_type.h |

[dpdk-dev] [PATCH 0/3] Fix external mbuf free issue in GSO case

2020-07-30 Thread yang_y_yi
From: Yi Yang It is impossible to fix external mbuf free issue in GSO case, the issue is GSO case only can free buffer in external mbuf but can't free this external mbuf because this is done by free_cb, in order to fix it, free_cb interface has to been changed to adapt to GSO case, this patch ser

[dpdk-dev] [PATCH 1/3] gso: fix refcnt update issue for external mbuf

2020-07-30 Thread yang_y_yi
From: Yi Yang rte_gso_segment will segment original mbuf to multiple small size mbufs, every mbuf of them has two segments, the second segment will attach to original mbuf, if original mbuf is external, rte_gso_segment should update refcnt of mbuf->shinfo but not refcnt of mbuf. Otherwise, origin

[dpdk-dev] [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-07-30 Thread yang_y_yi
From: Yi Yang In GSO case, segmented mbufs are attached to original mbuf which can't be freed when it is external. The issue is free_cb doesn't know original mbuf and doesn't free it when refcnt of shinfo is 0. Original mbuf can be freed by rte_pktmbuf_free segmented mbufs or by rte_pktmbuf_free

[dpdk-dev] [PATCH 3/3] vhost: use new free_cb interface to fix mbuf free issue

2020-07-30 Thread yang_y_yi
From: Yi Yang New free_cb interface can help fix original external mbuf free issue in GSO case, it still can be compatible with normal non-GSO case. dpdkvhostuser port can work both in GSO case and in non-GSO case by this fix. Signed-off-by: Yi Yang --- lib/librte_vhost/virtio_net.c | 22 +

Re: [dpdk-dev] [PATCH v2] net/ice: fix FDIR GTPU rule create fail

2020-07-30 Thread Zhao1, Wei
Add Cc zhiminx.huang > -Original Message- > From: Zhao1, Wei > Sent: Thursday, July 30, 2020 5:28 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH v2] net/ice: fix FDIR GTPU rule create fail > > For GTPU rule without extend header the trainning packet for FDIR is

[dpdk-dev] 回复: [PATCH v1 1/2] ring: fix the misdescription of the param

2020-07-30 Thread Feifei Wang
Hi, David, Konstantin and Honnappa > -邮件原件- > 发件人: David Marchand > 发送时间: 2020年7月30日 0:00 > 收件人: Feifei Wang ; Ananyev, Konstantin > ; Honnappa Nagarahalli > ; Olivier Matz > 抄送: dev ; nd ; dpdk stable > ; tho...@monjalon.net > 主题: Re: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescripti

Re: [dpdk-dev] [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-07-30 Thread Thomas Monjalon
30/07/2020 11:56, yang_y...@163.com: > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -1193,7 +1193,7 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf > *mi, struct rte_mbuf *m) > RTE_ASSERT(m->shinfo != NULL); > > if (rte_mbuf_ext_refcnt_update(m->s

[dpdk-dev] 回复: [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-30 Thread Feifei Wang
> -邮件原件- > 发件人: Honnappa Nagarahalli > 发送时间: 2020年7月30日 5:24 > 收件人: Feifei Wang ; David Marchand > > 抄送: Konstantin Ananyev ; Gavin Hu > ; Olivier Matz ; dev > ; nd ; dpdk stable ; > Honnappa Nagarahalli ; nd > 主题: RE: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the

[dpdk-dev] [PATCH v2] net/i40e: fix link status

2020-07-30 Thread Guinan Sun
If the PF driver supports the new speed reporting capabilities then use link_event_adv instead of link_event to get the speed. Fixes: 2a73125b7041 ("i40evf: fix link info update") Cc: sta...@dpdk.org Signed-off-by: Guinan Sun --- v2: * Modify commit log. * Add code comments. * Delete useless cod

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] lib/table: fix cache alignment issue

2020-07-30 Thread Kevin Traynor
On 29/07/2020 14:28, David Marchand wrote: > On Wed, Jul 29, 2020 at 3:14 PM Dumitrescu, Cristian > wrote: >>> Please correct me if I am wrong, but it simply means this part of the >>> table library never worked for 32-bit. >>> It seems more adding 32-bit support rather than a fix and then I >>

[dpdk-dev] DPDK Release Status Meeting 30/07/2020

2020-07-30 Thread Ferruh Yigit
Minutes 30 July 2020 Agenda: * Release Dates * -rc2 status * Subtrees * LTS * Opens Participants: * Arm * Broadcom * Debian/Microsoft * Intel * Marvell * Nvidia * NXP * Red Hat Release Dates - * v20.08 dates: * -rc3 pushed to *Thursday, 30 July 2020* * -rc4

Re: [dpdk-dev] 答复: [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-07-30 Thread Thomas Monjalon
30/07/2020 12:39, Yi Yang (杨燚)-云服务集团: > Thomas, do you mean I need to change the below files to add deprecation > notice about free_cb? No it should be a separate patch for announing the deprecation in 20.08. Below patches cannot be applied in 20.08. > > doc/guides/rel_notes/deprecation.rst

Re: [dpdk-dev] 答复: [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-07-30 Thread yang_y_yi
Got it. Thanks a lot. 在 2020-07-30 18:42:38,"Thomas Monjalon" 写道: >30/07/2020 12:39, Yi Yang (杨燚)-云服务集团: >> Thomas, do you mean I need to change the below files to add deprecation >> notice about free_cb? > >No it should be a separate patch for announing the deprecation in 20.0

Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status

2020-07-30 Thread Wang, ShougangX
Tested-by: Shougang Wang > -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Thursday, July 30, 2020 6:25 PM > To: Xing, Beilei ; Guo, Jia ; > dev@dpdk.org > Cc: Sun, GuinanX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > If the PF driver s

Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status

2020-07-30 Thread Jeff Guo
Acked-by: Jeff Guo On 7/30/2020 6:51 PM, Wang, ShougangX wrote: Tested-by: Shougang Wang -Original Message- From: dev On Behalf Of Guinan Sun Sent: Thursday, July 30, 2020 6:25 PM To: Xing, Beilei ; Guo, Jia ; dev@dpdk.org Cc: Sun, GuinanX ; sta...@dpdk.org Subject: [dpdk-dev] [PATC

[dpdk-dev] [PATCH] test/crypto: fix device number

2020-07-30 Thread Ankur Dwivedi
In testsuite_setup(), ts_params is configured for first valid device. The same device should be used as valid device in test_device_configure_invalid_dev_id test case. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi ---

[dpdk-dev] [PATCH V1 1/3] gso: fix refcnt update issue for external mbuf

2020-07-30 Thread yang_y_yi
From: Yi Yang rte_gso_segment will segment original mbuf to multiple small size mbufs, every mbuf of them has two segments, the second segment will attach to original mbuf, if original mbuf is external, rte_gso_segment should update refcnt of mbuf->shinfo but not refcnt of mbuf. Otherwise, origin

[dpdk-dev] [PATCH V1 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-07-30 Thread yang_y_yi
From: Yi Yang In GSO case, segmented mbufs are attached to original mbuf which can't be freed when it is external. The issue is free_cb doesn't know original mbuf and doesn't free it when refcnt of shinfo is 0. Original mbuf can be freed by rte_pktmbuf_free segmented mbufs or by rte_pktmbuf_free

[dpdk-dev] [PATCH V1 3/3] vhost: use new free_cb interface to fix mbuf free issue

2020-07-30 Thread yang_y_yi
From: Yi Yang New free_cb interface can help fix original external mbuf free issue in GSO case, it still can be compatible with normal non-GSO case. dpdkvhostuser port can work both in GSO case and in non-GSO case by this fix. Signed-off-by: Yi Yang --- lib/librte_vhost/virtio_net.c | 22 +

[dpdk-dev] [PATCH V1 0/3] Fix external mbuf free issue in GSO case

2020-07-30 Thread yang_y_yi
From: Yi Yang It is impossible to fix external mbuf free issue in GSO case, the issue is GSO case only can free buffer in external mbuf but can't free this external mbuf because this is done by free_cb, in order to fix it, free_cb interface has to been changed to adapt to GSO case, this patch ser

Re: [dpdk-dev] 答复: [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-07-30 Thread yang_y_yi
Unfortunately, git send-email in windows can't work with -cc-cmd, I just tried it but maintainers weren't added to cc list. Here is my get-maintainer.sh. Anybody knows why it can't work. $ ./get-maintainer.sh dpdk-patches/-cover-letter.patch yangyi01@yangyi0100 MINGW64 ~ $ ./get-maintainer

[dpdk-dev] [PATCH] doc: announce deprecation of rte_mbuf_extbuf_free_callback_t

2020-07-30 Thread yang_y_yi
From: Yi Yang typedef rte_mbuf_extbuf_free_callback_t will be deprecated in 20.08 release. Signed-off-by: Yi Yang --- doc/guides/rel_notes/deprecation.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst in

Re: [dpdk-dev] [PATCH v2] eal/linux: do not create user mem map repeatedly when it exists

2020-07-30 Thread wangyunjian
> -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Monday, July 27, 2020 5:24 PM > To: wangyunjian ; dev@dpdk.org; > david.march...@redhat.com > Cc: Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] eal/linux: do not cr

[dpdk-dev] [PATCH] maintainers: add Chenbo for Vhost/Virtio/vDPA

2020-07-30 Thread Maxime Coquelin
Chenbo has done an excellent job in reviewing, contributing and testing patches. This patch adds him as co-maintainer for Vhost, Virtio and vDPA components. Signed-off-by: Maxime Coquelin --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 532

Re: [dpdk-dev] [PATCH] maintainers: add Chenbo for Vhost/Virtio/vDPA

2020-07-30 Thread Ferruh Yigit
On 7/30/2020 2:46 PM, Maxime Coquelin wrote: > Chenbo has done an excellent job in reviewing, > contributing and testing patches. > > This patch adds him as co-maintainer for Vhost, Virtio > and vDPA components. > > Signed-off-by: Maxime Coquelin Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v5 0/6] qede: SR-IOV PF driver support

2020-07-30 Thread Manish Chopra
Hi, This series adds SR-IOV PF pmd driver support to have VF pmd driver work over PF pmd driver instances in order to run the adapter completely under DPDK environment for one of the use cases like ovs-dpdk. This is very initial bring-up with following testing covered - * Enable/Disable SR-IOV V

[dpdk-dev] [PATCH v5 1/6] drivers: add generic API to find PCI extended cap

2020-07-30 Thread Manish Chopra
By adding generic API, this patch removes individual functions/defines implemented by drivers to find extended PCI capabilities. Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh --- drivers/bus/pci/pci_common.c | 43 ++ drivers/bus/pci/rte_bus_pci.h

[dpdk-dev] [PATCH v5 2/6] net/qede: define PCI config space specific osals

2020-07-30 Thread Manish Chopra
This patch defines various PCI config space access APIs in order to read and find IOV specific PCI capabilities. With these definitions implemented, it enables the base driver to do SR-IOV specific initialization and HW specific configuration required from PF-PMD driver instance. Signed-off-by: M

[dpdk-dev] [PATCH v5 3/6] net/qede: configure VFs on hardware

2020-07-30 Thread Manish Chopra
Based on number of VFs enabled at PCI, PF-PMD driver instance enables/configures those VFs from hardware perspective, such that in later patches they could get required HW access to communicate with PFs for slowpath configuration and run the fastpath themsleves. This patch also add two new qede IO

[dpdk-dev] [PATCH v5 5/6] net/qede: initialize VF MAC and link

2020-07-30 Thread Manish Chopra
This patch configures VFs with random mac if no MAC is provided by the PF/bulletin. This also adds required bulletin APIs by PF-PMD driver to communicate LINK properties/changes to the VFs through bulletin update mechanism. With these changes, VF-PMD instance is able to run fastpath over PF-PMD dr

[dpdk-dev] [PATCH v5 4/6] net/qede: add infrastructure support for VF load

2020-07-30 Thread Manish Chopra
This patch adds necessary infrastructure support (required to handle messages from VF and sending ramrod on behalf of VF's configuration request from alarm handler context) to start/load the VF-PMD driver instance on top of PF-PMD driver instance. Signed-off-by: Manish Chopra Signed-off-by: Igor

[dpdk-dev] [PATCH v5 6/6] net/qede: add VF FLR support

2020-07-30 Thread Manish Chopra
This patch adds required bit to handle VF FLR indication from Management FW (MFW) of the device With that VFs were able to load in VM (VF attached as PCI passthrough to the guest VM) followed by FLR successfully Updated the docs/guides with the feature support Signed-off-by: Manish Chopra Signe

Re: [dpdk-dev] [PATCH v2 20.08 4/6] doc: announce deprecation blacklist/whitelist

2020-07-30 Thread Stephen Hemminger
On Thu, 30 Jul 2020 09:45:19 +0100 Bruce Richardson wrote: > On Wed, Jul 29, 2020 at 05:58:02PM -0700, Stephen Hemminger wrote: > > Announce upcoming changes for 20.11. > > > > Signed-off-by: Stephen Hemminger > > --- > > doc/guides/rel_notes/deprecation.rst | 21 + > > 1 f

Re: [dpdk-dev] [RFC v2 2/2] app/testpmd: support malloc and free tracking log

2020-07-30 Thread Somnath Kotur
On Tue, Apr 21, 2020 at 7:11 PM Iremonger, Bernard wrote: > > > -Original Message- > > From: dev On Behalf Of Xueming Li > > Sent: Friday, April 17, 2020 9:04 AM > > To: Burakov, Anatoly ; Yigit, Ferruh > > ; Stephen Hemminger > > > > Cc: dev@dpdk.org; Asaf Penso > > Subject: [dpdk-dev]

Re: [dpdk-dev] [RFC v2 2/2] app/testpmd: support malloc and free tracking log

2020-07-30 Thread Xueming(Steven) Li
Hi Som, > -Original Message- > From: Somnath Kotur > Sent: Thursday, July 30, 2020 11:10 PM > To: Iremonger, Bernard > Cc: Xueming(Steven) Li ; Burakov, Anatoly > ; Yigit, Ferruh ; Stephen > Hemminger ; dev@dpdk.org; Asaf Penso > > Subject: Re: [dpdk-dev] [RFC v2 2/2] app/testpmd: suppo

Re: [dpdk-dev] [PATCH] net/netvsc: fix seg fault during transmit

2020-07-30 Thread Stephen Hemminger
On Wed, 29 Jul 2020 09:58:44 -0400 Chas Williams <3ch...@gmail.com> wrote: > Commit cc0251813277 ("net/netvsc: split send buffers from Tx > descriptors") changed the way that transmit descriptors are > allocated. They come from a single pool instead of being > individually attached to each mbuf. T

Re: [dpdk-dev] [RFC v2 2/2] app/testpmd: support malloc and free tracking log

2020-07-30 Thread Somnath Kotur
On Thu, Jul 30, 2020 at 8:43 PM Xueming(Steven) Li wrote: > > Hi Som, > > > -Original Message- > > From: Somnath Kotur > > Sent: Thursday, July 30, 2020 11:10 PM > > To: Iremonger, Bernard > > Cc: Xueming(Steven) Li ; Burakov, Anatoly > > ; Yigit, Ferruh ; Stephen > > Hemminger ; dev@dpd

Re: [dpdk-dev] [EXT] Re: [PATCH v1 1/3] eal: add API for bus close

2020-07-30 Thread Rohit Raj
Yes, I agree. I will rework and send this patch series again. Regards, Rohit Raj Software Engineer | NXP India Private Limited Email: rohit@nxp.com -Original Message- From: Stephen Hemminger Sent: Tuesday, July 28, 2020 10:54 PM To: Rohit Raj Cc: Ray Kinsella ; Neil Horman ; dev@

[dpdk-dev] [PATCH v1] net/ice: optimize TCP header size calculation

2020-07-30 Thread Haiyue Wang
The rte_pktmbuf_read function can handle the contiguous data buffer reading, so remove the redundant contiguous memory handling. Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Fixes: 2a0c9ae4f646 ("net/ice: fix TCP checksum offload") Fixes: 7365a3cee51f ("net/ice: calculate TCP header size f

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

2020-07-30 Thread McDaniel, Timothy
>-Original Message- >From: McDaniel, Timothy >Sent: Thursday, July 2, 2020 5:14 PM >To: dev@dpdk.org >Cc: jer...@marvell.com; Eads, Gage ; Van Haaren, Harry >; m...@ashroe.eu; nhor...@tuxdriver.com; Rao, >Nikhil ; Carrillo, Erik G ; >Gujjar, >Abhinandan S ; pbhagavat...@marvell.com; >he

Re: [dpdk-dev] Userspace testing

2020-07-30 Thread Owen Hilyard
Thanks for the advice. I was wondering about the state of the "Setup VFIO permissions" option in the setup script. It seems to just modify the character device's permissions and then check their memory limit. Should this option also handle the hugepages setup? Thanks On Wed, Jul 29, 2020 at 11:3

[dpdk-dev] [RFC] eal: mark rte_malloc with malloc attribute

2020-07-30 Thread Stephen Hemminger
Gcc (and recent versions of Clang) have a function attribute that hints to the optimizer that it doesn't need to worry about aliasing on a pointer returned from malloc. Signed-off-by: Stephen Hemminger --- lib/librte_eal/include/rte_common.h | 11 +++ lib/librte_eal/include/rte_malloc.h

[dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

2020-07-30 Thread Akhil Goyal
The API ``rte_security_session_create`` takes only single mempool for session and session private data. So the application need to create mempool for twice the number of sessions needed and will also lead to wastage of memory as session private data need more memory compared to session. Hence the A

Re: [dpdk-dev] [PATCH] doc: add tested platforms with Mellanox NICs

2020-07-30 Thread Thomas Monjalon
29/07/2020 14:22, Raslan Darawsheh: [...] > +* Mellanox\ |reg| ConnectX\ |reg|-6 Dx EN 100G MCX623106AN-CDAT (2x100G) > + > + * Host interface: PCI Express 4.0 x16 > + * Device ID: 15b3:101d > + * Firmware version: 22.28.1002 and above > + > +* Mellanox(R) BlueField SmartNIC > +

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

2020-07-30 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [EXT] [PATCH] doc: add deprecation notice for security session create API

2020-07-30 Thread Anoob Joseph
> The API ``rte_security_session_create`` takes only single mempool for session > and session private data. So the application need to create mempool for twice > the number of sessions needed and will also lead to wastage of memory as > session private data need more memory compared to session. >

Re: [dpdk-dev] [PATCH] net/netvsc: fix seg fault during transmit

2020-07-30 Thread Ferruh Yigit
On 7/30/2020 4:13 PM, Stephen Hemminger wrote: > On Wed, 29 Jul 2020 09:58:44 -0400 > Chas Williams <3ch...@gmail.com> wrote: > >> Commit cc0251813277 ("net/netvsc: split send buffers from Tx >> descriptors") changed the way that transmit descriptors are >> allocated. They come from a single pool

Re: [dpdk-dev] [PATCH 0/7] cmdline: support Windows

2020-07-30 Thread Kadam, Pallavi
Hi Dmitry, On 6/20/2020 2:05 PM, Dmitry Kozlyuk wrote: This patchset enables librte_cmdline on Windows. To do that, it creates a number of wrappers for OS-dependent terminal handling and I/O. Considered alternative was to revive [1] and use libedit (Unix-only) for terminal handling. However, t

Re: [dpdk-dev] [PATCH v3] doc: add more detail to telemetry guides

2020-07-30 Thread Thomas Monjalon
24/07/2020 13:20, Ciara Power: > +**Example Callback** > + > +This callback is an example of handling multiple commands in one callback, > +and also shows the use of params which holds a port ID. The params input > needs > +to be validated and converted to the required integer type for port ID. Th

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

2020-07-30 Thread Jerin Jacob
On Thu, Jul 30, 2020 at 10:03 PM McDaniel, Timothy wrote: > > > >-Original Message- > >From: McDaniel, Timothy > >Sent: Thursday, July 2, 2020 5:14 PM > >To: dev@dpdk.org > >Cc: jer...@marvell.com; Eads, Gage ; Van Haaren, Harry > >; m...@ashroe.eu; nhor...@tuxdriver.com; Rao, > >Nikhil ;

[dpdk-dev] [PATCH 00/27] Add Intel DLM PMD to 20.11

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" This patchset is targetted at DPDK 20.11 Changes since V2 - Fixed a memory corruption issue due to not allocating enough CQ memory for depths < 8. Hardware requires minimum allocation to be at least 8 entries. - Address review comments from Gage and Mat

[dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" The DLB hardware does not conform exactly to the eventdev interface. 1) It has a limit on the number of queues that may be linked to a port. 2) Some ports a further restricted to a maximum of 1 linked queue. 3) It does not (currently) have the ability to carry the flow_i

[dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Previous implementation traced u8 disable_impl_release, which is now a bit field contained in the new u32 event_port_cfg field. Signed-off-by: McDaniel, Timothy --- lib/librte_eventdev/rte_event_crypto_adapter.c |2 +- lib/librte_eventdev/rte_event_eth_tx_adapter.

[dpdk-dev] [PATCH 04/27] event/dlb: add make and meson build infrastructure

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- config/common_base| 19 ++- config/rte_config.h |8 +++- drivers/event/Makefile|7 +++ drivers/event/dlb/Makefile| 27 +++ drivers/event/d

[dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_log.h | 25 + 1 file changed, 25 insertions(+) create mode 100644 drivers/event/dlb/dlb_log.h diff --git a/drivers/event/dlb/dlb_log.h b/drivers/event/dlb/dlb_log.h new file mode 100

[dpdk-dev] [PATCH 07/27] event/dlb: add private data structures and constants

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_priv.h | 565 ++ 1 file changed, 565 insertions(+) create mode 100644 drivers/event/dlb/dlb_priv.h diff --git a/drivers/event/dlb/dlb_priv.h b/drivers/event/dlb/dlb_pr

[dpdk-dev] [PATCH 08/27] event/dlb: add definitions shared with LKM or shared code

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_user.h | 1083 ++ 1 file changed, 1083 insertions(+) create mode 100644 drivers/event/dlb/dlb_user.h diff --git a/drivers/event/dlb/dlb_user.h b/drivers/event/dlb/dlb_u

[dpdk-dev] [PATCH 10/27] event/dlb: add PFPMD-specific interface layer to shared code

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile |2 + drivers/event/dlb/meson.build |4 +- drivers/event/dlb/pf/dlb_main.c | 614 ++ drivers/event/dlb/pf/dlb_main.h | 54 +++ drivers/event/dlb/pf/dlb_pf.c

[dpdk-dev] [PATCH 05/27] event/dlb: add DLB documentation

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- doc/guides/eventdevs/dlb.rst | 343 ++ 1 file changed, 343 insertions(+) create mode 100644 doc/guides/eventdevs/dlb.rst diff --git a/doc/guides/eventdevs/dlb.rst b/doc/guides/eventdevs/dlb

[dpdk-dev] [PATCH 09/27] event/dlb: add inline functions used in multiple files

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_inline_fns.h | 80 1 file changed, 80 insertions(+) create mode 100644 drivers/event/dlb/dlb_inline_fns.h diff --git a/drivers/event/dlb/dlb_inline_fns.h b/drivers/even

[dpdk-dev] [PATCH 13/27] event/dlb: add xstats support

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile |1 + drivers/event/dlb/dlb_xstats.c | 1249 drivers/event/dlb/meson.build |3 +- 3 files changed, 1252 insertions(+), 1 deletion(-) create mode 10064

[dpdk-dev] [PATCH 14/27] event/dlb: add PMD self-tests

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- app/test/test_eventdev.c |8 + drivers/event/dlb/Makefile |1 + drivers/event/dlb/dlb_selftest.c | 1563 ++ drivers/event/dlb/meson.build|3 +- 4 files changed, 1574

[dpdk-dev] [PATCH 16/27] event/dlb: add infos_get and configure

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 401 +++ 1 file changed, 401 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index c1054d7..2da5cd1 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 11/27] event/dlb: add flexible PMD to device interfaces

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" The PMD uses function pointers so that it can be executed as a bifurcated PMD accessing hardware via a linux kernel mode driver, or as a PF PMD where it has complete control of the hardware device. Note that this interface is not used in the data path. Signed-off-by: M

[dpdk-dev] [PATCH 12/27] event/dlb: add the PMD's public interfaces

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile |2 + drivers/event/dlb/meson.build |4 +- drivers/event/dlb/rte_pmd_dlb.c | 38 + drivers/event/dlb/rte_pmd_dlb.h

[dpdk-dev] [PATCH 19/27] event/dlb: add port_setup

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 1241 +++ 1 file changed, 1241 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index ae1d19b..8bbcd03 100644 --- a/drivers/event/dlb

[dpdk-dev] [PATCH 15/27] event/dlb: add probe

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile|1 + drivers/event/dlb/dlb.c | 508 + drivers/event/dlb/meson.build |3 +- 3 files changed, 511 insertions(+), 1 deletion(-) create mode 100644 d

[dpdk-dev] [PATCH 18/27] event/dlb: add queue setup

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 295 +++ 1 file changed, 295 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index b1070c9..ae1d19b 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 17/27] event/dlb: add queue_def_conf and port_def_conf

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: Ifa154a041fa117776612efc027b128c1603b6396 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 2da5cd1..b10

[dpdk-dev] [PATCH 20/27] event/dlb: add port_link

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: Id86dbdd1070e8102bf602765654fe5afde0e0d6c Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 303 +++ 1 file changed, 303 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c i

[dpdk-dev] [PATCH 21/27] event/dlb: add queue_release and port_release

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: I7dc1b4c03a222b40d629705946d00f3800dbe63d Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index e601a0e..0eb0cf5 1

[dpdk-dev] [PATCH 22/27] event/dlb: add port_unlink and port_unlinks_in_progress

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: I06d4006786440a0454ce883dba0ce14640dfff92 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 166 +++ 1 file changed, 166 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c i

[dpdk-dev] [PATCH 23/27] event/dlb: add eventdev_start

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: I9dcf8cf95c1001e09ab3e44e3fbd2ccbf0ddec72 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 142 +++ 1 file changed, 142 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c i

[dpdk-dev] [PATCH 25/27] event/dlb: add enqueue and its burst variants

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: I58cb02dc040aa6dcf30992ea57ff3f332b4946f2 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 3ece86a..d5df855 100644

[dpdk-dev] [PATCH 24/27] event/dlb: add timeout_ticks, dump, xstats, and selftest

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: I763bff70a4da35b898c1f5abfdcc45a7c1dfac08 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 7a78d59..3ece86a 100644

[dpdk-dev] [PATCH 27/27] event/dlb: add eventdev_stop and eventdev_close

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: Iff64ba83ead496b3dedeaf323ee09bce1f631a6f Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 263 +++ 1 file changed, 263 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c i

[dpdk-dev] [PATCH 26/27] event/dlb: add dequeue, dequeue_burst, and variants

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 809 +++ 1 file changed, 809 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index d5df855..5adc95e 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque

2020-07-30 Thread Dmitry Kozlyuk
struct cmdline exposes platform-specific members it contains, most notably struct termios that is only available on Unix. Make the structure opaque. Remove tests checking struct cmdline content as meaningless. Add cmdline_get_rdline() to access history buffer. The new function is currently used o

[dpdk-dev] [PATCH v2 0/7] cmdline: support Windows

2020-07-30 Thread Dmitry Kozlyuk
This patchset enables librte_cmdline on Windows. To do that, it creates a number of wrappers for OS-dependent terminal handling and I/O. Considered alternative was to revive [1] and use libedit (Unix-only) for terminal handling. However, testing revealed that WinEditLine [2] is not a drop-in replac

[dpdk-dev] [PATCH v2 3/7] cmdline: add internal wrappers for character input

2020-07-30 Thread Dmitry Kozlyuk
poll(3) is a purely Unix facility, so it cannot be directly used by common code. read(2) is limited in device support outside of Unix. Create wrapper functions and implement them for Unix. Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/cmdline.c | 12 +++- lib/librte_cmdlin

[dpdk-dev] [PATCH v2 4/7] cmdline: add internal wrapper for vdprintf

2020-07-30 Thread Dmitry Kozlyuk
Add internal wrapper for vdprintf(3) that is only available on Unix. Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/cmdline.c | 2 +- lib/librte_cmdline/cmdline_os_unix.c | 6 ++ lib/librte_cmdline/cmdline_private.h | 8 3 files changed, 15 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v2 5/7] eal/windows: improve compatibility networking headers

2020-07-30 Thread Dmitry Kozlyuk
Extend compatibility header system to support librte_cmdline. pthread.h has to include windows.h, which exposes struct in_addr, etc. conflicting with compatibility headers. WIN32_LEAN_AND_MEAN macro is required to disable this behavior. Use rte_windows.h to define WIN32_LEAN_AND_MEAN for pthread l

[dpdk-dev] [PATCH v2 2/7] cmdline: add internal wrappers for terminal handling

2020-07-30 Thread Dmitry Kozlyuk
Extract struct terminal and associated functions that set up, save, and restore terminal parameters. Use existing code as Unix implementation. Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/Makefile | 4 lib/librte_cmdline/cmdline_os_unix.c | 27 +++

[dpdk-dev] [PATCH v2 7/7] examples/cmdline: build on Windows

2020-07-30 Thread Dmitry Kozlyuk
Enable cmdline sample application as all dependencies are met. Signed-off-by: Dmitry Kozlyuk --- examples/cmdline/commands.c | 1 - examples/cmdline/main.c | 1 - examples/meson.build| 6 +++--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/cmdline/commands.

[dpdk-dev] [PATCH v2 6/7] cmdline: support Windows

2020-07-30 Thread Dmitry Kozlyuk
Implement terminal handling, input polling, and vdprintf() for Windows. Because Windows I/O model differs fundamentally from Unix and there is no concept of character device, polling is simulated depending on the underlying inpue device. Supporting non-terminal input is useful for automated testin

Re: [dpdk-dev] [PATCH] examples: fix return value of function that parses portmask

2020-07-30 Thread Thomas Monjalon
21/07/2020 18:07, Bruce Richardson: > On Thu, Jun 11, 2020 at 05:36:24PM +0500, Sarosh Arif wrote: > > Giving invalid or zero portmask as command line option to > > these applications will have an unexpected response. > > The reason behind this is that the return value of function > > that parses

Re: [dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on exit

2020-07-30 Thread Thomas Monjalon
Declan is not reviewing patches anymore. Adding more maintainers in Cc. PS: Maybe we should update the file MAINTAINERS to avoid patches being stuck. 22/07/2020 14:50, Ibtisam Tariq: > When exiting the application, resources should be cleared. > > Signed-off-by: Ibtisam Tariq > --- > examples

Re: [dpdk-dev] [PATCH] examples/packet_ordering: fix return value of parse_portmask

2020-07-30 Thread Thomas Monjalon
05/06/2020 15:41, Sarosh Arif: > Giving invalid or zero portmask as command line option to > packet_ordering application will have an unexpected response. > The reason behind this is that parse_portmask's return value is > stored in a variable called portmask.The data type of portmask > is unsign

Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

2020-07-30 Thread Thomas Monjalon
13/07/2020 15:28, Sarosh Arif: > Did you get the time to review it? > > On Tue, Jun 23, 2020 at 2:22 PM Pattan, Reshma > wrote: > > *From:* Sarosh Arif > > > > > Hello, > > > > > > This patch has been sitting around for more than 3 weeks. Is there > > > something that needs to be done further f

  1   2   >