Re: [dpdk-dev] [PATCH v7 1/5] net/bnxt: add support for aarch32

2020-08-19 Thread Ruifeng Wang
From: Ajit Khaparde Sent: Thursday, August 20, 2020 1:46 AM To: Juraj Linkeš Cc: Bruce Richardson ; Aaron Conole ; maicolgabr...@hotmail.com; dpdk-dev ; Ruifeng Wang Subject: Re: [dpdk-dev] [PATCH v7 1/5] net/bnxt: add support for aarch32 On Fri, Aug 14, 2020 at 3:32 AM Juraj Linkeš mailto

[dpdk-dev] [PATCH v2 3/4] app/testpmd: fix packet header in txonly mode

2020-08-19 Thread Wei Hu (Xavier)
From: Chengchang Tang In txonly forward mode, the packet header is fixed by the initial setting, including the packet length and checksum. So when the packets varies, this may cause a packet header error. Currently, there are two methods in txonly mode to randomly change the packets. 1. Set txspl

[dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information

2020-08-19 Thread Wei Hu (Xavier)
From: Huisong Li Currently, the information of Rx/Tx queues from PMD driver is not displayed exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" and "ports[pid].tx_conf" maintained in testpmd application may be not the value actually used by PMD driver. For instance, user do

[dpdk-dev] [PATCH v2 2/4] app/testpmd: fix VLAN offload configuration when config fail

2020-08-19 Thread Wei Hu (Xavier)
From: Chengchang Tang When failing to configure VLAN offloads after the port was started, there is no need to update the port configuration. Currently, when user configure an unsupported VLAN offloads and fails, and then restart the port, it will fails since the configuration has been refreshed.

[dpdk-dev] [PATCH v2 1/4] app/testpmd: fix missing verification of port id

2020-08-19 Thread Wei Hu (Xavier)
From: Chengchang Tang To set Tx vlan offloads, it is required to stop port firstly. But before checking whether the port is stopped, the port id entered by the user is not checked for validity. When the port id is illegal, it would lead to a segmentation fault since it attempts to access a member

[dpdk-dev] [PATCH v2 0/4] minor fixes for testpmd

2020-08-19 Thread Wei Hu (Xavier)
This series are minor fixes for testpmd application. Chengchang Tang (3): app/testpmd: fix missing verification of port id app/testpmd: fix VLAN offload configuration when config fail app/testpmd: fix packet header in txonly mode Huisong Li (1): app/testpmd: fix displaying Rx Tx queues in

Re: [dpdk-dev] [PATCH v5 2/2] test/cpuflag: add new flags for ARM64 platform

2020-08-19 Thread Wei Hu (Xavier)
Hi, Ruifeng Wang On 2020/8/19 16:11, Ruifeng Wang wrote: -Original Message- From: Wei Hu (Xavier) Sent: Wednesday, August 19, 2020 3:04 PM To: dev@dpdk.org Cc: nd ; Honnappa Nagarahalli ; Ruifeng Wang ; jerinjac...@gmail.com; xavier.hu...@huawei.com Subject: [PATCH v5 2/2] test/cpufla

Re: [dpdk-dev] [PATCH v7 1/5] net/bnxt: add support for aarch32

2020-08-19 Thread Ajit Khaparde
On Fri, Aug 14, 2020 at 3:32 AM Juraj Linkeš wrote: > From: Ruifeng Wang > > Expand vector PMD support to aarch32. > > Signed-off-by: Ruifeng Wang > --- > drivers/net/bnxt/Makefile | 2 +- > drivers/net/bnxt/bnxt_rxq.h | 2 +- > drivers/net/bnxt/bnxt_rxr.h | 2 +- > drivers/net/bnxt/bnxt_txr

[dpdk-dev] [PATCH] net/ark: fix meson build

2020-08-19 Thread Ed Czeck
* Rename net/ark specific CONFIG_RTE macros to local macros. * Change condition of ARK_PAD_TX to match behavior of meson build to makefile build. * Install header file needed for dynamic library. * Update doc as required. Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 24 +

[dpdk-dev] [PATCH] net/vdev_netvsc: handle removal of associated pci device

2020-08-19 Thread Stephen Hemminger
The vdev_netvsc was not detecting when the associated PCI device (SRIOV) was removed. Because of that it would keep feeding the same (removed) device to failsafe PMD which would then unsuccessfully try and probe for it. Change to use a mark/sweep method to detect that PCI device was removed, and a

Re: [dpdk-dev] [PATCH 20.11 14/19] doc: remove references to make in NIC guides

2020-08-19 Thread Bruce Richardson
On Fri, Aug 07, 2020 at 01:30:04PM +0100, Ciara Power wrote: > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > > Signed-off-by: Ciara Power > --- Final comments for this review of the doc. /Bruce > diff --git a/doc/guides/nics/mlx4.rst b/do

Re: [dpdk-dev] [PATCH] net/ark: fix meson build

2020-08-19 Thread Ferruh Yigit
On 8/19/2020 4:35 PM, Ed Czeck wrote: > * Set RTE_LIBRTE_ARK_PAD_TX in local meson.build to match > the CONFIG_RTE_LIBRTE_ARK_PAD_TX setting used in make. > * Install header file needed for dynamic library. > > Signed-off-by: Ed Czeck > --- > drivers/net/ark/meson.build | 3 +++ > 1 file changed

Re: [dpdk-dev] [PATCH 20.11 14/19] doc: remove references to make in NIC guides

2020-08-19 Thread Bruce Richardson
On Fri, Aug 07, 2020 at 01:30:04PM +0100, Ciara Power wrote: > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > Scanned the first half of the NIC guide with this patch applied. Some comments below. The review of the second half of the doc will f

Re: [dpdk-dev] [PATCH V2] net/hns3: support getting Tx and Rx queue information

2020-08-19 Thread Ferruh Yigit
On 8/18/2020 4:07 AM, Wei Hu (Xavier) wrote: > From: Huisong Li > > This patch adds support for querying Rx/Tx queue information. > > Currently, if there are not available Rx buffer descriptors in receiving > direction based on hns3 network engine, incoming packets will always be > dropped by ha

Re: [dpdk-dev] [PATCH 20.11 16/19] doc: remove references to make in prog guides

2020-08-19 Thread Stephen Hemminger
On Mon, 17 Aug 2020 14:54:21 +0100 Bruce Richardson wrote: > > diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst > > b/doc/guides/prog_guide/dev_kit_build_system.rst > > index 74dba4dd16..91d2120e22 100644 > > --- a/doc/guides/prog_guide/dev_kit_build_system.rst > > +++ b/doc/guides/pr

Re: [dpdk-dev] [PATCH 1/4] net/netvsc: move rxbuf_info from per-device to per-queue

2020-08-19 Thread Ferruh Yigit
On 8/17/2020 12:11 AM, Stephen Hemminger wrote: > On Mon, 10 Aug 2020 19:33:11 -0700 > lon...@linuxonhyperv.com wrote: > >> From: Long Li >> >> netvsc uses rxbuf_info buffer to track received packets attached via >> rte_pktmbuf_attach_extbuf() and ack the host based on usage count. It uses >> the

[dpdk-dev] [PATCH] net/ark: fix meson build

2020-08-19 Thread Ed Czeck
* Set RTE_LIBRTE_ARK_PAD_TX in local meson.build to match the CONFIG_RTE_LIBRTE_ARK_PAD_TX setting used in make. * Install header file needed for dynamic library. Signed-off-by: Ed Czeck --- drivers/net/ark/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ark/meson.

Re: [dpdk-dev] [PATCH 20.11 16/19] doc: remove references to make in prog guides

2020-08-19 Thread Laatz, Kevin
On 07/08/2020 13:30, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/prog_guide/build_app.rst | 46 +--- .../prog_guide/dev_kit_build_system.rst | 218 +-

Re: [dpdk-dev] [PATCH 1/2] ethdev: allow negative values in flow rule types

2020-08-19 Thread Gregory Etelson
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, July 5, 2020 16:34 > To: Gregory Etelson ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: allow negative values in > flow rule types > > On 6/25/20 7:03 PM, Gregor

Re: [dpdk-dev] [PATCH 2/2] ethdev: tunnel offload model

2020-08-19 Thread Gregory Etelson
Hello Andrew, Thank you for detailed review. Sorry for the late response. Please see my answers inline. Regards, Gregory > -Original Message- > From: Andrew Rybchenko > Sent: Sunday, July 5, 2020 17:51 > To: Gregory Etelson ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Eli Br

Re: [dpdk-dev] [PATCH 20.11 12/19] doc: remove references to make in Linux gsg guides

2020-08-19 Thread Bruce Richardson
On Tue, Aug 18, 2020 at 12:40:53PM +0100, Bruce Richardson wrote: > On Fri, Aug 07, 2020 at 01:30:02PM +0100, Ciara Power wrote: > > Make is no longer supported for compiling DPDK, references are now > > removed in the documentation. > > > > Signed-off-by: Ciara Power > > --- > > doc/guides/linu

[dpdk-dev] [PATCH] examples/vm_power: fix resource leak on error path

2020-08-19 Thread wangyunjian
From: Yunjian Wang This patch fixes the resource leaks reported by coverity. Coverity issue: 337674 Fixes: 95f648ff9eed ("examples/vm_power: make branch ratio threshold per core") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- examples/vm_power_manager/main.c | 1 + 1 file changed, 1 ins

[dpdk-dev] [Bug 528] ixgbe: PTP not working when ixgbe_xmit_pkts_vec is used

2020-08-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=528 Bug ID: 528 Summary: ixgbe: PTP not working when ixgbe_xmit_pkts_vec is used Product: DPDK Version: 20.05 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] Ipsec-secgw packet processing

2020-08-19 Thread satyavalli rama
Hi Anoob We are using the following hardware details, HOST: x722 (i40e) intel. VM: e1000 (82540) intel. We have launched Virtual machine on host , and executing ipsec-secgw application on VM. Please find below the CLI and configuration for TRANSPORT MODE. CLI: ./build/ipsec-secgw -l 0 -n 4 --s

[dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform

2020-08-19 Thread Wei Hu (Xavier)
This series updates CPU flags for arm64 platform. Wei Hu (Xavier) (2): eal/arm64: update CPU flags test/cpuflag: add new flags for ARM64 platform app/test/test_cpuflags.c | 39 lib/librte_eal/arm/include/rte_cpuflags_64.h | 13 +++ lib/librte_eal/

[dpdk-dev] [PATCH v6 2/2] test/cpuflag: add new flags for ARM64 platform

2020-08-19 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds new flags into the test_cpuflags() functions for ARM64 platform, such as RTE_CPUFLAG_SVE, etc. Signed-off-by: Wei Hu (Xavier) Reviewed-by: Ruifeng Wang --- v5 -> v6: update '\t' for alignment. v4 -> v5: Use double '\t' for better alignment. v4: Initial p

[dpdk-dev] [PATCH v6 1/2] eal/arm64: update CPU flags

2020-08-19 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" ARM64 Linux kernel updated the CPU flags using the HWCAP scheme. The related marco definition can be found in linux kernel: arch/arm64/include/uapi/asm/hwcap.h This patch incorporates those changes to the eal library. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu

Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro

2020-08-19 Thread Vipul Ashri
Hi All This patch needs to get reviewed by all available reviewers as link came visible now. @Xia Chenbo, As you have already reviewed so here I request you to share your review vote again and Ack if possible. @Ferruh, Below link is correct patch, I appreciate and thank you very much for your

Re: [dpdk-dev] [PATCH v5 2/2] test/cpuflag: add new flags for ARM64 platform

2020-08-19 Thread Ruifeng Wang
> -Original Message- > From: Wei Hu (Xavier) > Sent: Wednesday, August 19, 2020 3:04 PM > To: dev@dpdk.org > Cc: nd ; Honnappa Nagarahalli > ; Ruifeng Wang > ; jerinjac...@gmail.com; > xavier.hu...@huawei.com > Subject: [PATCH v5 2/2] test/cpuflag: add new flags for ARM64 platform > > F

Re: [dpdk-dev] [RFC PATCH] config: remap flags used for Arm platforms

2020-08-19 Thread Ruifeng Wang
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, August 18, 2020 10:36 PM > To: Ruifeng Wang ; hemant.agra...@nxp.com; > jer...@marvell.com; vikto...@rehivetech.com > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; Phil Yang ; nd > > Subject: Re: [dpdk-dev] [RFC PATCH] config: remap

Re: [dpdk-dev] [PATCH v4 2/2] test/cpuflag: add new flags for ARM64 platform

2020-08-19 Thread Wei Hu (Xavier)
Hi, Ruifeng Wang On 2020/8/19 10:26, Ruifeng Wang wrote: -Original Message- From: Wei Hu (Xavier) Sent: Tuesday, August 18, 2020 4:09 PM To: dev@dpdk.org Cc: nd ; Honnappa Nagarahalli ; Ruifeng Wang ; jerinjac...@gmail.com; xavier.hu...@huawei.com Subject: [PATCH v4 2/2] test/cpuflag:

[dpdk-dev] [PATCH v5 2/2] test/cpuflag: add new flags for ARM64 platform

2020-08-19 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds new flags into the test_cpuflags() functions for ARM64 platform, such as RTE_CPUFLAG_SVE, etc. Signed-off-by: Wei Hu (Xavier) Reviewed-by: Ruifeng Wang --- v4 -> v5: Use double '\t' for better alignment. v4: Initial patch. --- app/test/test_cpuflags.c |

[dpdk-dev] [PATCH v5 1/2] eal/arm64: update CPU flags

2020-08-19 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" ARM64 Linux kernel updated the CPU flags using the HWCAP scheme. The related marco definition can be found in linux kernel: arch/arm64/include/uapi/asm/hwcap.h This patch incorporates those changes to the eal library. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu

[dpdk-dev] [PATCH v5 0/2] update CPU flags for arm64 platform

2020-08-19 Thread Wei Hu (Xavier)
This series updates CPU flags for arm64 platform. Wei Hu (Xavier) (2): eal/arm64: update CPU flags test/cpuflag: add new flags for ARM64 platform app/test/test_cpuflags.c | 39 lib/librte_eal/arm/include/rte_cpuflags_64.h | 13 +++ lib/librte_eal/