[dpdk-dev] [PATCH v1 2/4] example/vhost: add support for vhost async data path

2020-09-09 Thread Cheng Jiang
This patch is to implement vhost DMA operation callbacks for CBDMA PMD and add vhost async data-path in vhost sample. With providing callback implementation for CBDMA, vhost sample can leverage CBDMA to accelerate vhost async data-path. Signed-off-by: Cheng Jiang --- examples/vhost/main.c | 129

[dpdk-dev] [PATCH v1 3/4] doc: update vhost sample doc for vhost async data path

2020-09-09 Thread Cheng Jiang
Add vhost async driver arguments information for vhost async data path in vhost sample application. Signed-off-by: Cheng Jiang --- doc/guides/sample_app_ug/vhost.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vho

[dpdk-dev] [PATCH v1 1/4] example/vhost: add async vhost driver args parsing function

2020-09-09 Thread Cheng Jiang
This patch is to add async vhost driver arguments parsing function for CBDMA channel. With these arguments vhost sample can be set to use CBDMA or CPU for enqueue operation and bind vhost device with specific CBDMA channel to accelerate vhost data-path. Signed-off-by: Cheng Jiang --- examples/vh

[dpdk-dev] [PATCH v1 4/4] doc: update release notes for vhost sample

2020-09-09 Thread Cheng Jiang
Add release notes for vhost async data path support in vhost sample. Signed-off-by: Cheng Jiang --- doc/guides/rel_notes/release_20_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst index df227a177..6

[dpdk-dev] [PATCH v1 0/4] add async data path in vhost sample

2020-09-09 Thread Cheng Jiang
This patch set makes vhost-vswitch be able to use vhost async APIs for enqueue operations. Demonstrated how the application leverage IOAT DMA channel with vhost async APIs. We introduce two parameters to enable DMA acceleration for Tx operations of queues: -async_vhost_driver Async vhost-user net

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix incorrect byte counters

2020-09-09 Thread Jiang, JunyuX
HI guojia, > -Original Message- > From: Guo, Jia > Sent: Thursday, September 10, 2020 1:59 PM > To: Han, YingyaX ; Jiang, JunyuX > ; dev@dpdk.org > Cc: Xing, Beilei ; Jiang, JunyuX > ; sta...@dpdk.org > Subject: RE: [dpdk-stable] [PATCH] net/i40e: fix incorrect byte counters > > Hi, juny

[dpdk-dev] [PATCH V1] testpmd: add eeprom/module eeprom display

2020-09-09 Thread David Liu
Add module EEPROM/EEPROM dump command "show port (module_eeprom|eeprom)" Commands will dump the content of the EEPROM/module EEPROM for the selected port. Signed-off-by: David Liu --- app/test-pmd/cmdline.c | 50 app/test-pmd/config.c | 120

[dpdk-dev] [PATCH 3/3] net/iavf: enable AVX512 for TX

2020-09-09 Thread Wenzhuo Lu
To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the TX descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- doc/guides/rel_notes/release_20_11.rst | 3 + drivers/net/iavf/iavf_ethdev.c

[dpdk-dev] [PATCH 2/3] net/iavf: enable AVX512 for flexible RX

2020-09-09 Thread Wenzhuo Lu
To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to hande the flexible RX descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c| 10 + drivers/net/iavf/iavf_rxt

[dpdk-dev] [PATCH 0/3] enable AVX512 for iavf

2020-09-09 Thread Wenzhuo Lu
AVX512 instructions is supported by more and more platforms. These instructions can be used in the data path to enhance the per-core performance of packet processing. Comparing with the existing implementation, this path set introduces some AVX512 instructions into the iavf data path, and we get a

[dpdk-dev] [PATCH 1/3] net/iavf: enable AVX512 for legacy RX

2020-09-09 Thread Wenzhuo Lu
To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the legacy RX descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c| 27 +- drivers/net/iavf/iavf_rxt

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix incorrect byte counters

2020-09-09 Thread Guo, Jia
Hi, junyu > -Original Message- > From: Han, YingyaX > Sent: Thursday, September 10, 2020 10:18 AM > To: Jiang, JunyuX ; dev@dpdk.org > Cc: Guo, Jia ; Xing, Beilei ; Jiang, > JunyuX ; sta...@dpdk.org > Subject: RE: [dpdk-stable] [PATCH] net/i40e: fix incorrect byte counters > > Tested-by:

Re: [dpdk-dev] [PATCH v4] net/iavf: support outer IP hash for GTPU

2020-09-09 Thread Guo, Jia
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, September 10, 2020 11:26 AM > To: Guo, Jia ; Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v4] net/iavf: support outer IP hash for GTPU > > From: Alvin Zhang > > Add headers for GTPU, now outer IP hash ca

Re: [dpdk-dev] [PATCH v4 2/2] net/iavf: support outer IP hash for GTPC

2020-09-09 Thread Guo, Jia
Hi, Alvin > -Original Message- > From: Zhang, AlvinX > Sent: Thursday, September 10, 2020 11:37 AM > To: Guo, Jia ; Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v4 2/2] net/iavf: support outer IP hash for GTPC > > From: Alvin Zhang > > Add patterns and headers for

[dpdk-dev] [PATCH] net/mlx5: disable flow dump for Verbs flow

2020-09-09 Thread Xueming Li
There was a segment fault when dump flows with device argument of dv_flow_en=0. In such case, Verbs flow engine was enabled and fdb resources were not initialized. It's suggested to use mlx_fs_dump for Verbs flow dump. This patch adds verbs engine check, prints warning message and return gracefull

[dpdk-dev] [PATCH] net/mlx5: disable flow dump for Verbs flow

2020-09-09 Thread Xueming Li
There was a segment fault when dump flows with device argument of dv_flow_en=0. In such case, Verbs flow engine was enabled and fdb resources were not initialized. It's suggested to use mlx_fs_dump for Verbs flow dump. This patch adds verbs engine check, prints warning message and return gracefull

[dpdk-dev] [PATCH v4 2/2] net/iavf: support outer IP hash for GTPC

2020-09-09 Thread alvinx . zhang
From: Alvin Zhang Add patterns and headers for GTPC, now outer IP hash can be configured as input sets for GTPC packet. Signed-off-by: Alvin Zhang --- V2: Modify codes according to comments. V3: Refact all codes. V4: Fix compatibility issues. drivers/net/iavf/iavf_generic_flow.c | 18 +++

[dpdk-dev] [PATCH v4 1/2] common/iavf: add GTPC support

2020-09-09 Thread alvinx . zhang
From: Alvin Zhang Add GTPC header and its field selector. Signed-off-by: Alvin Zhang --- drivers/common/iavf/virtchnl.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 79515ee..0042cc0 100644 --- a/drivers/common/iav

[dpdk-dev] [PATCH v4] net/iavf: support outer IP hash for GTPU

2020-09-09 Thread alvinx . zhang
From: Alvin Zhang Add headers for GTPU, now outer IP hash can be configured as input sets for GTPU packet. Signed-off-by: Alvin Zhang --- V2: Modify codes according to comments. V3: Refact all codes. V4: Fix compatibility issues. drivers/net/iavf/iavf_hash.c | 13 + 1 file chang

Re: [dpdk-dev] [PATCH 00/40] ice base code update

2020-09-09 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Wednesday, September 9, 2020 3:17 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH 00/40] ice base code update > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Monday, September 7, 2020 19:28 > > To:

[dpdk-dev] Missing SPDK and redundant license info

2020-09-09 Thread Stephen Hemminger
These should be fixed before release! Makefiles will be dropped. The ethdev stuff is from Jan Blunck, let me see if I can find current email. $ ./devtools/check-spdx-tag.sh -v Files without SPDX License -- doc/guides/custom.css doc/guides/linux_gsg/nic_perf_intel_platform.

Re: [dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support

2020-09-09 Thread Hu, Jiayu
No more comments on this patch. Thanks, Jiayu From: yang_y_yi Sent: Wednesday, September 9, 2020 5:00 PM To: Hu, Jiayu Cc: tho...@monjalon.net; dev@dpdk.org; yangy...@inspur.com Subject: Re:Re: [dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support Importance: High This is incremental patch to fix

[dpdk-dev] [PATCH v1] app/test-pmd: fix meson build failed when used latency stats lib

2020-09-09 Thread SteveX Yang
meson build cannot find the header rte_latencystats.h when build DPDK first time or never installed DPDK lib after build via meson/ninja. Because the corresponding header directory isn't included after enabled RTE_LIBRTE_LATENCY_STATS flag. Add the header file location and link library to meson.b

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix incorrect byte counters

2020-09-09 Thread Han, YingyaX
Tested-by: Yingya Han -Original Message- From: stable On Behalf Of Junyu Jiang Sent: Thursday, September 10, 2020 9:54 AM To: dev@dpdk.org Cc: Guo, Jia ; Xing, Beilei ; Jiang, JunyuX ; sta...@dpdk.org Subject: [dpdk-stable] [PATCH] net/i40e: fix incorrect byte counters This patch fixed

[dpdk-dev] [PATCH v1] app/test-pmd: fix meson build failed when enabled pmd_bonded

2020-09-09 Thread SteveX Yang
meson build cannot find the header rte_eth_bond.h when build DPDK first time or never installed DPDK lib after build via meson/ninja. Because the corresponding header directory isn't included after enabled RTE_LIBRTE_PMD_BOND macro. Add the header file location and link library to meson.build of

Re: [dpdk-dev] [PATCH] net/netvsc: replace compiler builtin overflow check

2020-09-09 Thread Ajit Khaparde
On Tue, Sep 8, 2020 at 3:07 AM Ferruh Yigit wrote: > '__builtin_add_overflow' added to gcc in version 5, earlier versions > causing build error, like gcc 4.8.5 in RHEL7. > > Replaced compiler builtin check with arithmetic check. > > Fixes: cabb3c0f29f1 ("net/netvsc: check for overflow on packet i

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: remove underscore prefix from internal API

2020-09-09 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 09-Sep-20 6:31 PM, Ferruh Yigit wrote: '_rte_eth_dev_callback_process()' & '_rte_eth_dev_reset()' internal APIs has unconventional underscore ('_') prefix. Although this is not documented most probably this is to mark them as internal. Since we have '__rte_internal' f

[dpdk-dev] [PATCH] net/i40e: fix incorrect byte counters

2020-09-09 Thread Junyu Jiang
This patch fixed the issue that rx/tx bytes overflowed on 48 bit limitation by enlarging the limitation. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang --- drivers/net/i40e/i40e_ethdev.c | 47 ++ drivers/net/i40e

Re: [dpdk-dev] [PATCH v4 2/7] ethdev: move inline device operations

2020-09-09 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 09-Sep-20 6:31 PM, Ferruh Yigit wrote: This patch is a preparation to hide the 'struct eth_dev_ops' from applications by moving some device operations from 'struct eth_dev_ops' to 'struct rte_eth_dev'. Mentioned ethdev APIs are in the data path and implemented as in

[dpdk-dev] [PATCH v3] app/testpmd: fix the default RSS key configuration

2020-09-09 Thread Lijun Ou
When a user runs a flow create cmd to configure an RSS rule with specifying the empty rss actions in testpmd, this mean that the flow gets the default RSS functions from the valid NIC default RSS hash key. However, the testpmd is not set the default RSS key incorrectly when RSS key is not specified

Re: [dpdk-dev] [PATCH v4] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-09-09 Thread Alexander Kozyrev
> > > > > > Use c11 atomics with RELAXED ordering instead of the rte_atomic ops > > which enforce unnecessary barriers on aarch64. > > > > Signed-off-by: Phil Yang > Looks good. > > Reviewed-by: Honnappa Nagarahalli Acked-by: Alexander Kozyrev > > > --- > > v4: > > Remove the unnecessary A

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-09-09 Thread Honnappa Nagarahalli
> > > > > Phil, we are seeing much worse degradation on our ARM platform > > > > > unfortunately. > > > > > I don't think that discrepancy in memcpy can explain this behavior. > > > > > Your patch is not touching this area of code. Let me collect > > > > > some perf stat on our side. > > > > Are

Re: [dpdk-dev] [PATCH v4] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-09-09 Thread Honnappa Nagarahalli
> > Use c11 atomics with RELAXED ordering instead of the rte_atomic ops which > enforce unnecessary barriers on aarch64. > > Signed-off-by: Phil Yang Looks good. Reviewed-by: Honnappa Nagarahalli > --- > v4: > Remove the unnecessary ACQUIRE barrier in rx burst path. (Honnappa) > > v3: > Sp

Re: [dpdk-dev] [PATCH 1/1] timer: add limitation note for sync stop and reset

2020-09-09 Thread Honnappa Nagarahalli
> > If a timer's callback function calls rte_timer_reset_sync() or > rte_timer_stop_sync() on another timer that is in the RUNNING state and > owned by the current lcore, the *_sync() calls will loop indefinitely. > > Relatedly, if a timer's callback function calls *_sync() on another timer >

[dpdk-dev] [PATCH] EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h

2020-09-09 Thread Omkar Maslekar
rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr) enables software to hint to hardware that line is likely to be shared. Useful in core-to-core communications where cache-line is likely to be shared. ARM and PPC implementation is provided with NOP and can be added if any equiv

[dpdk-dev] [PATCH] EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h

2020-09-09 Thread Omkar Maslekar
We are including this in rte_prefetch.h since it is the most closely related code location.rte_cldemte is similar to a prefetch hint -in reverse Omkar Maslekar (1): EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h doc/guides/rel_notes/release_20_11.rst| 26 ---

Re: [dpdk-dev] [PATCH v6] usertools: add a huge page setup script

2020-09-09 Thread Ajit Khaparde
snip > > diff --git a/doc/guides/tools/hugepages.rst > b/doc/guides/tools/hugepages.rst > new file mode 100644 > index ..a82b71620011 > --- /dev/null > +++ b/doc/guides/tools/hugepages.rst > @@ -0,0 +1,79 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > +Copyright (c) 2020

Re: [dpdk-dev] [PATCH] bus/pci: support segment value as address domain on Windows

2020-09-09 Thread Narcisa Ana Maria Vasile
On Tue, Aug 25, 2020 at 02:43:16PM +0300, Tal Shnaiderman wrote: > Set the domain value for rte_pci_addr probing on Windows > to the value of the PCI segment returned by SPDRP_BUSNUMBER. > > Signed-off-by: Tal Shnaiderman > --- > drivers/bus/pci/windows/pci.c | 4 ++-- > 1 file changed, 2 insert

Re: [dpdk-dev] [PATCH] bus/pci: fix hardware ids parsing on Windows

2020-09-09 Thread Narcisa Ana Maria Vasile
On Sun, Aug 23, 2020 at 04:06:04PM +0300, Tal Shnaiderman wrote: > From: Tal Shnaiderman > > Swap subsystem vendor id and subsystem device id. > Parse the SPDRP_HARDWAREID string with correct type values. > > Fixes: b762221ac24 ("bus/pci: support Windows with bifurcated drivers") > Cc: sta...@dp

Re: [dpdk-dev] [v2 2/2] test: add testcase for crypto enqueue callback

2020-09-09 Thread Honnappa Nagarahalli
Hi Abhinandan, This test case looks good. I think you could add few negative test cases as well. For ex: removing the call back without registering the RCU. Thanks, Honnappa > > > > The purpose of this testcase is to showcase the cryptodev enqueue > > callback usage with RCU support. >

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-09-09 Thread Honnappa Nagarahalli
> > > > In an eventdev world, multiple workers (with ordered queue) will be > > working on IPsec ESP processing. The ESP header's sequence number is > > unique and has to be sequentially incremented in an orderly manner. > > This rises a need for incrementing sequence number in crypto stage > > e

[dpdk-dev] [PATCH] doc: removed typing mistake

2020-09-09 Thread Muhammad Bilal
Here I have removed 'that' from the sentence to make it grammatically correct, as it seems to be a typing mistake Fixes: d0dff9ba445e ("doc: sample application user guide") Cc: bernard.iremon...@intel.com Signed-off-by: Muhammad Bilal --- doc/guides/prog_guide/multi_proc_support.rst | 2 +- doc

[dpdk-dev] [PATCH v1] app/bbdev: fix test vector symlink

2020-09-09 Thread Nicolas Chautru
5G DL default symlink was pointing to a 4G vector. Fixes: d762705308c4 ("app/bbdev: add test vectors for 5GNR") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- app/test-bbdev/ldpc_enc_default.data | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-bbdev/ldpc_enc

[dpdk-dev] [PATCH] eventdev: support telemetry with xstats info

2020-09-09 Thread Chen, Mike Ximing
The telemetry library is connected with eventdev xstats and port link info. The following new telemetry commands are added: /eventdev/dev_list /eventdev/port_list,DevID /eventdev/queue_list,DevID /eventdev/dev_xstats,DevID /eventdev/port_xstats,DevID,PortID /eventdev/queue_xstats,DevID,PortID /eve

[dpdk-dev] [RFC 3/3] sft: introduce API

2020-09-09 Thread Andrey Vesnovaty
Defines RTE SFT APIs for Statefull Flow Table library. SFT General description: SFT library provides a framework for applications that need to maintain context across different packets of the connection. Examples for such applications: - Next-generation firewalls - Intrusion detection/prevention s

[dpdk-dev] [RFC 1/3] ethdev: add item/action for SFT

2020-09-09 Thread Andrey Vesnovaty
Attach SFT flow context to packet with SFT action. Match on SFT flow context (attached to packet), with SFT item. Signed-off-by: Andrey Vesnovaty --- lib/librte_ethdev/rte_flow.h | 84 1 file changed, 84 insertions(+) diff --git a/lib/librte_ethdev/rte_flow.

[dpdk-dev] [RFC 2/3] ethdev: support SFT APIs

2020-09-09 Thread Andrey Vesnovaty
ethdev updated to support SFT lookup offload to ethernet device. Signed-off-by: Andrey Vesnovaty --- lib/librte_ethdev/rte_ethdev.c | 7 +++ lib/librte_ethdev/rte_ethdev.h | 16 lib/librte_ethdev/rte_ethdev_core.h | 1 + 3 files changed, 24 insertions(+) diff --

[dpdk-dev] [RFC 0/3] introduce Stateful Flow Table

2020-09-09 Thread Andrey Vesnovaty
The RFC introduces Stateful Flow Table (SFT) API and changes needed in both ethdev an RTE flow to support SFT functionality. SFT library provides a framework for applications that need to maintain context across different packets of the connection. The goals of the SFT library: - Accelerate flow

[dpdk-dev] [PATCH 12/12] net/bnxt: transmit vector mode improvements

2020-09-09 Thread Lance Richardson
Improve performance of vector burst transmit function by processing multiple packets per inner loop iteration. Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 96 +++- 1 file changed, 66 insertions(+), 30 deletions(-) diff --git a/drivers/net/b

[dpdk-dev] [PATCH 10/12] net/bnxt: optimize vector mode mbuf allocation

2020-09-09 Thread Lance Richardson
Simplify and optimize receive mbuf allocation function used by the vector mode PMDs. Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_rxtx_vec_common.h | 40 ++ drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 70 - drivers/

[dpdk-dev] [PATCH 11/12] net/bnxt: handle multiple packets per loop in vector PMD

2020-09-09 Thread Lance Richardson
Process four receive descriptors per inner loop in vector mode burst receive functions. Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/bnxt/bnxt_rxq.c | 3 +- drivers/net/bnxt/bnxt_rxq.h

[dpdk-dev] [PATCH 07/12] net/bnxt: increase max burst size for vector mode

2020-09-09 Thread Lance Richardson
Increase the maximum supported burst size for the bnxt vector mode PMD from 32 to 64. Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH 09/12] net/bnxt: table-based handling for ol flags

2020-09-09 Thread Lance Richardson
Use table to translate receive descriptor status flags to rte_mbuf ol_flags values. Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_rxr.c | 166 -- drivers/net/bnxt/bnxt_rxr.h | 6 + drivers/net/bnxt/bnxt_r

[dpdk-dev] [PATCH 08/12] net/bnxt: use table-based packet type translation

2020-09-09 Thread Lance Richardson
Use table-based method for translating receive packet descriptor flags into rte_mbuf packet type values. Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_rxr.c | 127 -- drivers/net/bnxt/bnxt_rxr.h | 2 + dr

[dpdk-dev] [PATCH 06/12] net/bnxt: use smaller cq when agg ring not needed

2020-09-09 Thread Lance Richardson
Don't allocate extra completion queue entries for aggregation ring when aggregation ring will not be used. Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 11 +-- drivers/net/bnxt/bnxt_rxr.c| 21 +++-- 2 files cha

[dpdk-dev] [PATCH 04/12] net/bnxt: require async cq for vector mode

2020-09-09 Thread Lance Richardson
Disable support for vector mode when async completions can be placed in a receive completion ring and change the default for all platforms to use a dedicated async completion ring. Simplify completion handling in vector mode receive paths now that it no longer needs to handle async completions. R

[dpdk-dev] [PATCH 03/12] net/bnxt: use appropriate type for Rx mbuf ring

2020-09-09 Thread Lance Richardson
Change the type of the software receive mbuf ring from an array of structures containing an mbuf pointer to an array of pointers to struct rte_mbuf for consistency with how this ring is currently used by the vector mode receive function. Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Somnath Kotur

[dpdk-dev] [PATCH 05/12] net/bnxt: improve support for small ring sizes

2020-09-09 Thread Lance Richardson
Improve support for small ring sizes: - Ensure that transmit free threshold is no more than 1/4 ring size. - Ensure that receive free threshold is no more than 1/4 ring size. - Validate requested ring sizes against minimum supported size. - Use rxq receive free threshold instead of fixe

[dpdk-dev] [PATCH 01/12] net/bnxt: fix burst mode get for Arm

2020-09-09 Thread Lance Richardson
Transmit and receive burst mode get operations incorrectly return "Vector SSE" on ARM64 platforms, change to return "Vector Neon" instead. Fixes: 3983583414 ("net/bnxt: support NEON") Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Lance Richardson Cc: sta...@dpdk.org --- drivers/net/bnxt/bnxt_

[dpdk-dev] [PATCH 02/12] net/bnxt: fix rxq/txq get information

2020-09-09 Thread Lance Richardson
Return correct values for Rx/Tx offloads and for rx_drop_en. Fixes: 2fc201884be8 ("net/bnxt: support rxq/txq get information") Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Lance Richardson Cc: sta...@dpdk.org --- drivers/net/bnxt/bnxt_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 del

[dpdk-dev] [PATCH 00/12] net/bnxt: vector PMD improvements

2020-09-09 Thread Lance Richardson
Fixes and optimizations to improve bnxt vector mode performance and functionality. Lance Richardson (12): net/bnxt: fix burst mode get for Arm net/bnxt: fix rxq/txq get information net/bnxt: use appropriate type for Rx mbuf ring net/bnxt: require async cq for vector mode net/bnxt: improv

Re: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline type

2020-09-09 Thread Dumitrescu, Cristian
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, September 9, 2020 8:06 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline > type > > On Tue, 8 Sep 2020 21:17:50 +0100 > Cristian Dumitr

Re: [dpdk-dev] [PATCH v2 01/17] eal: add max SIMD bitwidth

2020-09-09 Thread Honnappa Nagarahalli
> > > > diff --git a/lib/librte_eal/include/rte_eal.h > b/lib/librte_eal/include/rte_eal.h > > > index ddcf6a2e7a..8148f650f2 100644 > > > --- a/lib/librte_eal/include/rte_eal.h > > > +++ b/lib/librte_eal/include/rte_eal.h > > > @@ -43,6 +43,13 @@ enum rte_proc_type_t { > > > RTE_PROC_INVALID

Re: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline type

2020-09-09 Thread Stephen Hemminger
On Tue, 8 Sep 2020 21:17:50 +0100 Cristian Dumitrescu wrote: > +/* > + * Pipeline. > + */ > +struct rte_swx_pipeline { > + int build_done; > + int numa_node; > +}; > + > + Is int the right type for these. build_done seems like a boolean and numa_node should be unsigned?

Re: [dpdk-dev] [PATCH v2] windows/netuio: add Windows NetUIO kernel driver

2020-09-09 Thread Narcisa Ana Maria Vasile
On Thu, Aug 20, 2020 at 06:32:02PM -0700, Ranjit Menon wrote: > Hi, Naty > > On 8/20/2020 3:23 PM, Narcisa Ana Maria Vasile wrote: > >From: Narcisa Vasile > > > >The Windows NetUIO kernel driver allows the DPDK userspace > >application to directly access the hardware. > > > >Cc: Harini Ramakrishn

Re: [dpdk-dev] [PATCH v2] windows/netuio: add Windows NetUIO kernel driver

2020-09-09 Thread Narcisa Ana Maria Vasile
On Mon, Aug 24, 2020 at 11:53:44PM +0300, Dmitry Kozlyuk wrote: > On Thu, 20 Aug 2020 15:23:55 -0700, Narcisa Ana Maria Vasile wrote: > > From: Narcisa Vasile > > > > The Windows NetUIO kernel driver allows the DPDK userspace > > application to directly access the hardware. > > > > Cc: Harini Ra

[dpdk-dev] [PATCH v7] usertools: add a huge page setup script

2020-09-09 Thread Stephen Hemminger
This is an improved version of the setup of huge pages bases on earlier DPDK setup. Differences are: * autodetects NUMA vs non NUMA * allows setting different page sizes recent kernels support multiple sizes. * accepts a parameter in bytes (not pages). * can display current hugepa

[dpdk-dev] [PATCH v3] windows/netuio: add Windows NetUIO kernel driver

2020-09-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile The Windows netuio kernel driver provides the DPDK userspace application with direct access to hardware, by mapping the HW registers in userspace and allowing read/write operations from/to the device configuration space. Two IOCTLs are defined by the netuio interface: * IO

Re: [dpdk-dev] [PATCH] ethdev: mark all traffic manager API as experimental

2020-09-09 Thread Ferruh Yigit
On 9/9/2020 6:22 PM, Nithin Dabilpuram wrote: > This patch marks all traffic manager API as experimental as > per deprecation notice[1] and discussion[2] mentioned in following > threads. Can you please remove mentioned deprecation notice in this patch? > > [1] https://mails.dpdk.org/archives/de

Re: [dpdk-dev] [PATCH 00/40] Pipeline alignment with the P4 language

2020-09-09 Thread Wang, Han2
Thanks Cristian, This looks great. We on the Barefoot P4 compiler side are already investigating adding support for this as a new P4C CPU target. Cheers, Han

Re: [dpdk-dev] [PATCH v1 34/42] net/txgbe: add remaining RX and TX queue operations

2020-09-09 Thread Ferruh Yigit
On 9/1/2020 12:51 PM, Jiawen Wu wrote: > Add remaining receive and transmit queue operaions. > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/txgbe_ethdev.c | 123 +++ > drivers/net/txgbe/txgbe_ethdev.h | 16 ++ > drivers/net/txgbe/txgbe_rxtx.c | 259

Re: [dpdk-dev] [PATCH] net: add a new network PMD named txgbe

2020-09-09 Thread Stephen Hemminger
On Thu, 20 Aug 2020 11:02:31 +0800 Jiawen Wu wrote: > +# CFLAGS for gcc > +# > +ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) > +CFLAGS += -Wno-deprecated > +endif Why is this flag on for the driver code?

Re: [dpdk-dev] [PATCH v1 30/42] net/txgbe: add device info get

2020-09-09 Thread Ferruh Yigit
On 9/1/2020 12:51 PM, Jiawen Wu wrote: > Add device information get operation. > > Signed-off-by: Jiawen Wu <...> > +uint64_t > +txgbe_get_rx_queue_offloads(struct rte_eth_dev *dev __rte_unused) > +{ > + uint64_t offloads = 0; > + > + offloads |= DEV_RX_OFFLOAD_VLAN_STRIP; > Instead of

Re: [dpdk-dev] [PATCH v1 29/42] net/txgbe: add queue stats mapping and enable RX DMA unit

2020-09-09 Thread Ferruh Yigit
On 9/1/2020 12:51 PM, Jiawen Wu wrote: > Add queue stats mapping set, complete receive and transmit unit with DMA and > sec path. > > Signed-off-by: Jiawen Wu <...> > +static int > +txgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev, > + uint16_t queue_

Re: [dpdk-dev] [PATCH v1 28/42] net/txgbe: add device xstats get

2020-09-09 Thread Ferruh Yigit
On 9/1/2020 12:50 PM, Jiawen Wu wrote: > Add device xstats get from reading hardware registers. > > Signed-off-by: Jiawen Wu <...> > + > +static int txgbe_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > + struct rte_eth_xstat_name *xstats_names, unsigned int limit) > +{ 'dev'

Re: [dpdk-dev] [PATCH v1 03/42] net/txgbe: add device init and uninit

2020-09-09 Thread Ferruh Yigit
On 9/1/2020 12:50 PM, Jiawen Wu wrote: > Add basic init and uninit function, registers and some macro definitions > prepare for hardware infrastructure. > > Signed-off-by: Jiawen Wu <...> > +static const struct eth_dev_ops txgbe_eth_dev_ops = { > + .dev_start = txgbe_dev_s

Re: [dpdk-dev] [PATCH v1 02/42] net/txgbe: add ethdev probe and remove

2020-09-09 Thread Ferruh Yigit
On 9/1/2020 12:50 PM, Jiawen Wu wrote: > add basic PCIe ethdev probe and remove. > > Signed-off-by: Jiawen Wu <...> > +++ b/drivers/net/txgbe/base/meson.build > @@ -0,0 +1,21 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2015-2020 > + > +sources = [ > + > +] > + > +error_cflag

Re: [dpdk-dev] [PATCH] ethdev: mark all traffic manager API as experimental

2020-09-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, September 9, 2020 6:22 PM > To: Yigit, Ferruh ; Richardson, Bruce > ; Dumitrescu, Cristian > ; tho...@monjalon.net; > bl...@debian.org; Singh, Jasvinder ; > arybche...@solarflare.com; Kinsella, Ray ; > nhor...@tuxdriver.c

Re: [dpdk-dev] [PATCH v1 01/42] net/txgbe: add build and doc infrastructure

2020-09-09 Thread Ferruh Yigit
On 9/1/2020 12:50 PM, Jiawen Wu wrote: > Adding bare minimum PMD library and doc build infrastructure and claim the > maintainership for txgbe PMD. > > Signed-off-by: Jiawen Wu <...> > > +Wangxun txgbe > +M: Jiawen Wu > +M: Jian Wang > +F: drivers/net/txgbe/ > +F: doc/guides/nics/txgbe.rst

Re: [dpdk-dev] [PATCH] net: add a new network PMD named txgbe

2020-09-09 Thread Ferruh Yigit
On 9/1/2020 12:52 PM, jiawe...@trustnetic.com wrote: > Hi Ferruh, > > Since this patch is too large, it needs to be split into so many small > patches, which takes a lot of time. Thanks Jiawen for the work, I am aware it is not easy to arrange the patches and it takes time. Mostly looks good, I

[dpdk-dev] [PATCH] ethdev: mark all traffic manager API as experimental

2020-09-09 Thread Nithin Dabilpuram
This patch marks all traffic manager API as experimental as per deprecation notice[1] and discussion[2] mentioned in following threads. [1] https://mails.dpdk.org/archives/dev/2020-May/166221.html [2] https://mails.dpdk.org/archives/dev/2020-April/165364.html Signed-off-by: Nithin Dabilpuram ---

[dpdk-dev] [PATCH v1] maintainers: remove documentation maintainers

2020-09-09 Thread John McNamara
Removed the documentation maintainers. The documentation is now, currently, unmaintained. Signed-off-by: John McNamara Signed-off-by: Marko Kovacevic --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3b16d7a..df5b756 100644 --- a/MAINTAINERS ++

Re: [dpdk-dev] [PATCH v1 12/18] net/mlx5: separate Rx indirection table object creation

2020-09-09 Thread Ferruh Yigit
On 9/9/2020 3:37 PM, Matan Azrad wrote: > > Hi Ferruh > > From: Ferruh Yigit >> On 9/3/2020 11:13 AM, Michael Baum wrote: >>> Separate Rx indirection table object creation into both Verbs and DevX >>> modules. >>> >>> Signed-off-by: Michael Baum >>> Acked-by: Matan Azrad >> >> <...> >> >>> +

[dpdk-dev] [PATCH] examples/fips_validation: fix req file version incompatibility

2020-09-09 Thread Archana Muniganti
Separate out CAVS request file version 21.4 code to support lower versions. Fixes: 32440cdf2af9 ("examples/fips_validation: fix parsing of TDES vectors") Fixes: 2b84d2bd47df ("examples/fips_validation: fix count overwrite for TDES") Signed-off-by: Archana Muniganti --- examples/fips_validation/

Re: [dpdk-dev] [v2 2/2] test: add testcase for crypto enqueue callback

2020-09-09 Thread Gujjar, Abhinandan S
+Konstantin & Honnappa > -Original Message- > From: Gujjar, Abhinandan S > Sent: Tuesday, September 8, 2020 12:41 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; jer...@marvell.com; > akhil.go...@nxp.com; Vangati, Narender ; > Gujjar, Abhinandan S > Subject: [v2 2/2] test: add testcase for

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-09-09 Thread Gujjar, Abhinandan S
+Konstantin & Honnappa > -Original Message- > From: Gujjar, Abhinandan S > Sent: Tuesday, September 8, 2020 12:40 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; jer...@marvell.com; > akhil.go...@nxp.com; Vangati, Narender ; > Gujjar, Abhinandan S > Subject: [v2 1/2] cryptodev: support enq

[dpdk-dev] [v2 2/2] test: add testcase for crypto enqueue callback

2020-09-09 Thread Abhinandan Gujjar
The purpose of this testcase is to showcase the cryptodev enqueue callback usage with RCU support. Signed-off-by: Abhinandan Gujjar --- app/test/test_cryptodev.c | 123 +- 1 file changed, 122 insertions(+), 1 deletion(-) diff --git a/app/test/test_cry

[dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-09-09 Thread Abhinandan Gujjar
In an eventdev world, multiple workers (with ordered queue) will be working on IPsec ESP processing. The ESP header's sequence number is unique and has to be sequentially incremented in an orderly manner. This rises a need for incrementing sequence number in crypto stage especially in event crypto

[dpdk-dev] [PATCH 1/1] timer: add limitation note for sync stop and reset

2020-09-09 Thread Erik Gabriel Carrillo
If a timer's callback function calls rte_timer_reset_sync() or rte_timer_stop_sync() on another timer that is in the RUNNING state and owned by the current lcore, the *_sync() calls will loop indefinitely. Relatedly, if a timer's callback function calls *_sync() on another timer that is in the RUN

[dpdk-dev] [PATCH 0/1] timer: add limitation note for sync stop and reset

2020-09-09 Thread Erik Gabriel Carrillo
Bugzilla ID 491 identifies a couple of scenarios in which calls to the rte_timer_reset_sync() and rte_timer_stop_sync() APIs could hang. Changing the function prototypes such that error codes are returned in these scenarios was considered, but rather than introducing another ABI change, it was pro

Re: [dpdk-dev] [PATCH v1 12/18] net/mlx5: separate Rx indirection table object creation

2020-09-09 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit > On 9/3/2020 11:13 AM, Michael Baum wrote: > > Separate Rx indirection table object creation into both Verbs and DevX > > modules. > > > > Signed-off-by: Michael Baum > > Acked-by: Matan Azrad > > <...> > > > + if (!ind_tbl->ind_table) { > > + rte

Re: [dpdk-dev] [PATCH 00/14] net/sfc: factor out common driver library

2020-09-09 Thread Ferruh Yigit
On 9/8/2020 10:14 AM, Andrew Rybchenko wrote: > Network and vDPA drivers share libefx. So, libefx should be moved > to common drivers. > > DPDK adaptation of the MCDI interface may be shared as well. > > The new common driver name is sfc_efx since it a new home of > libefx base driver. sfc_ prefi

[dpdk-dev] [PATCH 6/6] net/enic: support VXLAN decap action combined with VLAN pop

2020-09-09 Thread Hyong Youb Kim
Flow Manager (flowman) provides DECAP_STRIP operation which decapsulates VXLAN header and then removes VLAN header from the inner packet. Use this operation to support vxlan_decap followed by of_pop_vlan. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/rel_notes/release_20_

[dpdk-dev] [PATCH 4/6] net/enic: ignore vlan inner type when it is zero

2020-09-09 Thread Hyong Youb Kim
When a VLAN pattern is present, the flow handler always copies its inner_type to the match buffer regardless of its value (i.e. HW matches inner_type against packet's inner ethertype). When inner_type spec and mask are both 0, adding it to the match buffer is usually harmless but breaks the followi

[dpdk-dev] [PATCH 5/6] net/enic: generate VXLAN source port if it is zero in template

2020-09-09 Thread Hyong Youb Kim
When VXLAN source port in the template is zero, the adapter is expected to generate a value based on the inner packet flow, when it performs encapsulation. Flow Manager in the VIC adapter currently lacks such ability. So, generate a random port when creating a flow if the port is zero, to avoid tra

[dpdk-dev] [PATCH 3/6] net/enic: support priorities for TCAM flows

2020-09-09 Thread Hyong Youb Kim
Group 0 corresponds to TCAM which supports priorities. Accept non-zero priorities for group 0 flows. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/rel_notes/release_20_11.rst | 1 + drivers/net/enic/enic_fm_flow.c| 10 ++ 2 files changed, 7 insertions(+),

[dpdk-dev] [PATCH 2/6] net/enic: support egress PORT_ID action

2020-09-09 Thread Hyong Youb Kim
Use Flow Manager (flowman) to support egress PORT_ID action. It can steer egress packets from PFs and VFs to any uplink port as long as they are all on the same VIC adapter. It can also steer packets between ports on the same VIC adapter (i.e. loopback). Signed-off-by: Hyong Youb Kim Reviewed-by:

[dpdk-dev] [PATCH 1/6] net/enic: remove obsolete code

2020-09-09 Thread Hyong Youb Kim
The 'next' field in struct enic is unused. The comment in enic_cq_rq() is out-of-date. Remove them. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h index b

[dpdk-dev] [PATCH 0/6] net/enic: minor updates to flow implementation

2020-09-09 Thread Hyong Youb Kim
This series enables several flow features such as priorities and egress PORT_ID action. It depends on the ealier patch series that adds VF representors. The 1st patch (remove obsolete code) does not technically belong in the series, but is piggybacked here as it is a trivial cleanup. Thanks.. -Hy

[dpdk-dev] [PATCH 5/5] net/enic: enable flow API for VF representor

2020-09-09 Thread Hyong Youb Kim
Use Flow Manager (flowman) to support flow API for representors. Representor's flow handlers simply invoke PF handlers and pass the representor's flowman structure. The PF flowman handlers are aware of representors and perform appropriate devcmds to create flows on the NIC. Also use flowman to cre

  1   2   >